Re: [Qemu-devel] [PATCH v5 0/5] Simplify qobject refcount

2018-04-19 Thread Markus Armbruster
Marc-André Lureau writes: > Hi, > > This series aims to get rid of the distinction between QObject, that > must use qobject_incref/qobject_decref and its various derived types > that have to use QINCREF/QDECREF. Instead, replace it with > qobject_ref/qobject_unref

[Qemu-devel] [PATCH for-2.13] Clear mem_path if we fall back to anonymous RAM allocation

2018-04-19 Thread David Gibson
If the -mem-path option is set, we attempt to map the guest's RAM from a file in the given path; it's usually used to back guest RAM with hugepages. If we're unable to (e.g. not enough free hugepages) then we fall back to allocating normal anonymous pages. This behaviour can be surprising, but a

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-19 Thread Olaf Hering
Am Thu, 19 Apr 2018 09:19:28 +0200 schrieb Markus Armbruster : > > [1] https://libvirt.org/platforms.html > This policy looks sensible to me Unless I misinterpret that, noone cares about SLE11 anymore. So, just wipe that single one developer system with glib-2.22 and move

[Qemu-devel] [RFC 1/2] block/file-posix: implement bdrv_co_invalidate_cache() on Linux

2018-04-19 Thread Stefan Hajnoczi
On Linux posix_fadvise(POSIX_FADV_DONTNEED) invalidates pages*. Use this to drop page cache on the destination host during shared storage migration. This way the destination host will read the latest copy of the data and will not use stale data from the page cache. The flow is as follows: 1.

[Qemu-devel] [RFC 2/2] block/file-posix: verify page cache is not used

2018-04-19 Thread Stefan Hajnoczi
This commit is for debugging only. Do not merge it. mincore(2) checks whether pages are resident. Use it to verify that page cache has been dropped. You can trigger a verification failure by mmapping the image file from another process and loading a byte from a page so that it becomes

[Qemu-devel] [RFC 0/2] block/file-posix: allow -drive cache.direct=off live migration

2018-04-19 Thread Stefan Hajnoczi
file-posix.c only supports shared storage live migration with -drive cache.direct=off due to cache consistency issues. There are two main shared storage configurations: files on NFS and host block devices on SAN LUNs. The problem is that QEMU starts on the destination host before the source host

Re: [Qemu-devel] [PATCH v1 for-2.13 4/4] pc-bios/s390-ccw/net: Add support for .INS config files

2018-04-19 Thread Thomas Huth
On 19.04.2018 10:02, Viktor VM Mihajlovski wrote: > On 18.04.2018 14:31, Thomas Huth wrote: >> The .INS config files can normally be found on CD-ROM ISO images, >> so by supporting these files, it is now possible to boot directly >> when the TFTP server is set up with the contents of such an

Re: [Qemu-devel] [libvirt] [qemu RFC v2] qapi: add "firmware.json"

2018-04-19 Thread Laszlo Ersek
On 04/19/18 09:56, Daniel P. Berrangé wrote: > On Thu, Apr 19, 2018 at 09:48:36AM +0200, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >>> On 04/18/18 10:47, Markus Armbruster wrote: Laszlo Ersek writes: >>> > +## > +#

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1] configure: require glib-2.24

2018-04-19 Thread Kamil Rytarowski
On 19.04.2018 10:54, Peter Maydell wrote: > On 19 April 2018 at 08:59, Daniel P. Berrangé wrote: >> I wouldn't say people don't care about SLE11 (or other similarly old distros >> like RHEL-6). Rather the view in libvirt was that if a user is stuck on such >> an old distro,

[Qemu-devel] [PATCH 1/5] checkpatch: add a --strict check for utf-8 in commit logs

2018-04-19 Thread Stefan Hajnoczi
From: Joe Perches Some find using utf-8 in commit logs inappropriate. Some patch commit logs contain unintended utf-8 characters when doing things like copy/pasting compilation output. Look for the start of any commit log by skipping initial lines that look like email headers

Re: [Qemu-devel] [PATCH v5 5/5] qobject: modify qobject_ref() to assert on NULL

2018-04-19 Thread Markus Armbruster
Marc-André Lureau writes: > While it may be convenient to accept NULL value in > qobject_unref() (for similar reasons as free() accepts NULL), it is > not such a good idea for qobject_ref(), assert() on NULL. One place > relied on that behaviour (the monitor request

Re: [Qemu-devel] [PATCH v5 4/5] qobject: modify qobject_ref() to return obj

2018-04-19 Thread Markus Armbruster
Eric Blake writes: > On 04/17/2018 08:36 AM, Marc-André Lureau wrote: >> For convenience and clarity, make it possible to call qobject_ref() at >> the time when the reference is associated with a variable, or >> argument, by making qobject_ref() return the same pointer as

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-19 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Apr 18, 2018 at 02:45:38PM +0200, Cornelia Huck wrote: > >> Are we ready to give up support for whatever distro is still on 2.22? >> (If yes, can we bump to an even newer glib version?) Or should we >> rather solve this by adding a

Re: [Qemu-devel] [PATCH for-2.13 v2 2/5] ppc: e500: switch E500 based machines to full machine definition

2018-04-19 Thread Igor Mammedov
On Thu, 19 Apr 2018 14:15:20 +1000 David Gibson wrote: > On Wed, Apr 18, 2018 at 04:28:02PM +0200, Igor Mammedov wrote: > > Convert PPCE500Params to PCCE500MachineClass which it essentially is, > > and introduce PCCE500MachineState to keep track of E500 specific > >

Re: [Qemu-devel] [RFC 1/2] block/file-posix: implement bdrv_co_invalidate_cache() on Linux

2018-04-19 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Linux posix_fadvise(POSIX_FADV_DONTNEED) invalidates pages*. Use > this to drop page cache on the destination host during shared storage > migration. This way the destination host will read the latest copy of > the data and will not use stale

[Qemu-devel] [PATCH v3] xilinx_spips: Correct SNOOP_NONE state when flushing the txfifo

2018-04-19 Thread Sai Pavan Boddu
SNOOP_NONE state handle is moved above in the if ladder, as it's same as SNOOP_STRIPPING during data cycles. Signed-off-by: Sai Pavan Boddu --- Changes for V2: Fixed commit message Reordered to code, to avoid code duplication. Changes for V3: Dropped

Re: [Qemu-devel] [RFC 2/2] block/file-posix: verify page cache is not used

2018-04-19 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > This commit is for debugging only. Do not merge it. > > mincore(2) checks whether pages are resident. Use it to verify that > page cache has been dropped. > > You can trigger a verification failure by mmapping the image file from > another

[Qemu-devel] [PATCH 0/5] checkpatch: backport UTF-8 fixes and MAINTAINERS check

2018-04-19 Thread Stefan Hajnoczi
This series cherry picks checkpatch UTF-8 fixes and the MAINTAINERS file check from Linux. Thomas Huth original did the backport in January 2017 but the series was forgotten (<1485436265-12573-1-git-send-email-th...@redhat.com>). I did the cherry pick again from scratch. The MAINTAINERS file

Re: [Qemu-devel] [PATCH 0/5] checkpatch: backport UTF-8 fixes and MAINTAINERS check

2018-04-19 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180419091105.3943-1-stefa...@redhat.com Subject: [Qemu-devel] [PATCH 0/5] checkpatch: backport UTF-8 fixes and MAINTAINERS check === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH v5 3/5] qobject: replace qobject_incref/QINCREF qobject_decref/QDECREF

2018-04-19 Thread Markus Armbruster
Marc-André Lureau writes: > Now that we can safely call QOBJECT() on QObject * as well as its > subtypes, we can have macros qobject_ref() / qobject_unref() that work > everywhere instead of having to use QINCREF() / QDECREF() for QObject > and qobject_incref() /

[Qemu-devel] [RFC for-2.13 6/7] spapr: Don't rewrite mmu capabilities in KVM mode

2018-04-19 Thread David Gibson
Currently during KVM initialization on POWER, kvm_fixup_page_sizes() rewrites a bunch of information in the cpu state to reflect the capabilities of the host MMU and KVM. This overwrites the information that's already there reflecting how the TCG implementation of the MMU will operate. This

Re: [Qemu-devel] [RFC PATCH v4] spapr: Support ibm, dynamic-memory-v2 property

2018-04-19 Thread David Gibson
On Thu, Apr 19, 2018 at 12:17:35PM +0530, Bharata B Rao wrote: > The new property ibm,dynamic-memory-v2 allows memory to be represented > in a more compact manner in device tree. > > Signed-off-by: Bharata B Rao Applied to ppc-for-2.13. -- David Gibson

[Qemu-devel] [PATCH for-2.13 v3 4/5] platform-bus-device: use device plug callback instead of machine_done notifier

2018-04-19 Thread Igor Mammedov
platform-bus were using machine_done notifier to get and map (assign irq/mmio resources) dynamically added sysbus devices after all '-device' options had been processed. That however creates non obvious dependencies on ordering of machine_done notifiers and requires carefull line juggling to keep

Re: [Qemu-devel] [PATCH v2 2/3] nbd/server: implement dirty bitmap export

2018-04-19 Thread Vladimir Sementsov-Ogievskiy
18.04.2018 17:05, Eric Blake wrote: On 04/13/2018 01:14 PM, Vladimir Sementsov-Ogievskiy wrote: Handle new NBD meta namespace: "qemu", and corresponding queries: "qemu:dirty-bitmap:". With new metadata context negotiated, BLOCK_STATUS query will reply with dirty-bitmap data, converted to

Re: [Qemu-devel] [RFC 3/5] hw/arm: add scattered RAM memory region support

2018-04-19 Thread Shameerali Kolothum Thodi
Hi Andrew, > -Original Message- > From: Andrew Jones [mailto:drjo...@redhat.com] > Sent: Tuesday, November 14, 2017 2:50 PM > To: Zhuyijun > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; > eric.au...@redhat.com; peter.mayd...@linaro.org; Shameerali Kolothum > Thodi

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-19 Thread Gerd Hoffmann
Hi, > Well, it depends. You might be stuck with an old distro because > some software you want to run depends on it, but also want to run > newer versions of some programs like QEMU. If you're in that > boat you can probably live with having to also compile a newer > version of glib to go with

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-19 Thread Daniel P . Berrangé
On Thu, Apr 19, 2018 at 11:20:17AM +0200, Gerd Hoffmann wrote: > Hi, > > > Well, it depends. You might be stuck with an old distro because > > some software you want to run depends on it, but also want to run > > newer versions of some programs like QEMU. If you're in that > > boat you can

[Qemu-devel] [RFC for-2.13 1/7] spapr: Maximum (HPT) pagesize property

2018-04-19 Thread David Gibson
The way the POWER Hash Page Table (HPT) MMU is virtualized by KVM HV means that every page that the guest puts in the pagetables must be truly physically contiguous, not just GPA-contiguous. In effect this means that an HPT guest can't use any pagesizes greater than the host page size used to

Re: [Qemu-devel] [PATCH v4 0/9] enable numa configuration before machine_init() from QMP

2018-04-19 Thread Igor Mammedov
On Wed, 18 Apr 2018 09:08:30 +0200 Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Tue, Apr 17, 2018 at 05:41:10PM +0200, Igor Mammedov wrote: > >> On Tue, 17 Apr 2018 11:27:39 -0300 > >> Eduardo Habkost wrote: > >>

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-19 Thread Thomas Huth
On 18.04.2018 08:02, Gerd Hoffmann wrote: > On Wed, Apr 18, 2018 at 12:40:54AM +0200, Laszlo Ersek wrote: >> Add a schema that describes the different uses and properties of virtual >> machine firmware. > > Looks good to me overall. > >> +{ 'enum' : 'FirmwareType', >> + 'data' : [ 'bios',

Re: [Qemu-devel] [PATCH v5 2/5] qobject: use a QObjectBase_ struct

2018-04-19 Thread Markus Armbruster
In addition to Eric's comments... Marc-André Lureau writes: > By moving the base fields to a QObjectBase_, QObject can be a type > which also has a 'base' field. This allows to write a generic > QOBJECT() macro that will work with any QObject type, including >

[Qemu-devel] configure --help lacks explanation of xen-pci-passthrough

2018-04-19 Thread Markus Armbruster
$ ./configure --help | grep -C 3 xen-pci-passthrough virtfs VirtFS mpath Multipath persistent reservation passthrough xen xen backend driver support xen-pci-passthrough brlapi BrlAPI (Braile) curlcurl connectivity membarrier

Re: [Qemu-devel] [PATCH v1 for-2.13 3/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-04-19 Thread Viktor VM Mihajlovski
On 18.04.2018 14:31, Thomas Huth wrote: > Since it is quite cumbersome to manually create a combined kernel with > initrd image for network booting, we now support loading via pxelinux > configuration files, too. In these files, the kernel, initrd and command > line parameters can be specified

Re: [Qemu-devel] [libvirt] [qemu RFC v2] qapi: add "firmware.json"

2018-04-19 Thread Daniel P . Berrangé
On Thu, Apr 19, 2018 at 09:48:36AM +0200, Markus Armbruster wrote: > Laszlo Ersek writes: > > > On 04/18/18 10:47, Markus Armbruster wrote: > >> Laszlo Ersek writes: > > > >>> +## > >>> +# @FirmwareArchitecture: > >>> +# > >>> +# Defines the target

[Qemu-devel] [PATCH 4/5] checkpatch: emit a warning on file add/move/delete

2018-04-19 Thread Stefan Hajnoczi
From: Joe Perches Whenever files are added, moved, or deleted, the MAINTAINERS file patterns can be out of sync or outdated. To try to keep MAINTAINERS more up-to-date, add a one-time warning whenever a patch does any of those. Signed-off-by: Joe Perches

Re: [Qemu-devel] [PATCH for-2.13 v2 2/5] ppc: e500: switch E500 based machines to full machine definition

2018-04-19 Thread David Gibson
On Thu, Apr 19, 2018 at 10:30:19AM +0200, Igor Mammedov wrote: > On Thu, 19 Apr 2018 14:15:20 +1000 > David Gibson wrote: > > > On Wed, Apr 18, 2018 at 04:28:02PM +0200, Igor Mammedov wrote: > > > Convert PPCE500Params to PCCE500MachineClass which it essentially is,

[Qemu-devel] [RFC for-2.13 3/7] target/ppc: Add ppc_hash64_filter_pagesizes()

2018-04-19 Thread David Gibson
The paravirtualized PAPR platform sometimes needs to restrict the guest to using only some of the page sizes actually supported by the host's MMU. At the moment this is handled in KVM specific code, but for consistency we want to apply the same limitations to all accelerators. This makes a start

[Qemu-devel] [RFC for-2.13 2/7] spapr: Use maximum page size capability to simplify memory backend checking

2018-04-19 Thread David Gibson
The way we used to handle KVM allowable guest pagesizes for PAPR guests required some convoluted checking of memory attached to the guest. The allowable pagesizes advertised to the guest cpus depended on the memory which was attached at boot, but then we needed to ensure that any memory later

[Qemu-devel] [RFC for-2.13 7/7] spapr_pci: Remove unhelpful pagesize warning

2018-04-19 Thread David Gibson
By default, the IOMMU model built into the spapr virtual PCI host bridge supports 4kiB and 64kiB IOMMU page sizes. However this can be overridden which may be desirable to allow larger IOMMU page sizes when running a guest with hugepage backing and passthrough devices. For that reason a warning

[Qemu-devel] [RFC for-2.13 0/7] spapr: Clean up pagesize handling

2018-04-19 Thread David Gibson
Currently the "pseries" machine type will (usually) advertise different pagesizes to the guest when running under KVM and TCG, which is not how things are supposed to work. This comes from poor handling of hardware limitations which mean that under KVM HV the guest is unable to use pagesizes

[Qemu-devel] [RFC PATCH v4] spapr: Support ibm, dynamic-memory-v2 property

2018-04-19 Thread Bharata B Rao
The new property ibm,dynamic-memory-v2 allows memory to be represented in a more compact manner in device tree. Signed-off-by: Bharata B Rao --- v3: https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg02159.html Changes in v4: (Addresses all David Gibson's

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-19 Thread Markus Armbruster
Laszlo Ersek writes: > On 04/18/18 10:47, Markus Armbruster wrote: >> Laszlo Ersek writes: > >>> +## >>> +# @FirmwareArchitecture: >>> +# >>> +# Defines the target architectures (emulator binaries) that firmware may >>> +# execute on. >>> +# >>> +#

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-19 Thread Daniel P . Berrangé
On Thu, Apr 19, 2018 at 09:30:24AM +0200, Olaf Hering wrote: > Am Thu, 19 Apr 2018 09:19:28 +0200 > schrieb Markus Armbruster : > > > > [1] https://libvirt.org/platforms.html > > This policy looks sensible to me > > Unless I misinterpret that, noone cares about SLE11

Re: [Qemu-devel] [PATCH for-2.13 v2 3/5] pc: simplify MachineClass::get_hotplug_handler handling

2018-04-19 Thread Igor Mammedov
On Wed, 18 Apr 2018 11:56:03 -0300 Eduardo Habkost wrote: > On Wed, Apr 18, 2018 at 04:28:03PM +0200, Igor Mammedov wrote: > > By default MachineClass::get_hotplug_handler is NULL and concrete board > > should set it to it's own handler. > > Considering there isn't any

Re: [Qemu-devel] [RFC 1/2] block/file-posix: implement bdrv_co_invalidate_cache() on Linux

2018-04-19 Thread Fam Zheng
On Thu, 04/19 15:52, Stefan Hajnoczi wrote: > On Linux posix_fadvise(POSIX_FADV_DONTNEED) invalidates pages*. Use > this to drop page cache on the destination host during shared storage > migration. This way the destination host will read the latest copy of > the data and will not use stale data

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-19 Thread Thomas Huth
On 18.04.2018 00:40, Laszlo Ersek wrote: > Add a schema that describes the different uses and properties of virtual > machine firmware. > > Each firmware executable installed on a host system should come with at > least one JSON file that conforms to this schema. Each file informs the >

Re: [Qemu-devel] [libvirt] [qemu RFC v2] qapi: add "firmware.json"

2018-04-19 Thread Daniel P . Berrangé
On Thu, Apr 19, 2018 at 10:39:32AM +0200, Laszlo Ersek wrote: > On 04/19/18 09:56, Daniel P. Berrangé wrote: > > On Thu, Apr 19, 2018 at 09:48:36AM +0200, Markus Armbruster wrote: > >> Laszlo Ersek writes: > >> > >>> On 04/18/18 10:47, Markus Armbruster wrote: > Laszlo

Re: [Qemu-devel] [PATCH v5 1/5] qobject: ensure base is at offset 0

2018-04-19 Thread Markus Armbruster
Eric Blake writes: > On 04/18/2018 11:45 AM, Markus Armbruster wrote: > >>> Might also be worth mentioning that this explicitly guarantees that >>> existing casts work correctly (even though we'd prefer to get rid of >>> such casts in any location except the qobject.h macros);

[Qemu-devel] [RFC for-2.13 4/7] spapr: Add cpu_apply hook to capabilities

2018-04-19 Thread David Gibson
spapr capabilities have an apply hook to actually activate (or deactivate) the feature in the system at reset time. However, a number of capabilities affect the setup of cpus, and need to be applied to each of them - including hotplugged cpus for extra complication. To make this simpler, add an

[Qemu-devel] [RFC for-2.13 5/7] spapr: Limit available pagesizes to provide a consistent guest environment

2018-04-19 Thread David Gibson
KVM HV has some limitations (deriving from the hardware) that mean not all host-cpu supported pagesizes may be usable in the guest. At present this means that KVM guests and TCG guests may see different available page sizes even if they notionally have the same vcpu model. This is confusing and

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-19 Thread Laszlo Ersek
On 04/19/18 02:09, David Gibson wrote: > On Wed, 18 Apr 2018 10:32:06 +0200 > Laszlo Ersek wrote: > >> On 04/18/18 08:02, Gerd Hoffmann wrote: >> [...] >> [...] >>> >>> Looks good to me overall. >>> +{ 'enum' : 'FirmwareType', + 'data' : [ 'bios', 'slof',

Re: [Qemu-devel] [PATCH v1 for-2.13 3/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-04-19 Thread Thomas Huth
On 19.04.2018 09:41, Viktor VM Mihajlovski wrote: > On 18.04.2018 14:31, Thomas Huth wrote: >> Since it is quite cumbersome to manually create a combined kernel with >> initrd image for network booting, we now support loading via pxelinux >> configuration files, too. In these files, the kernel,

[Qemu-devel] [PATCH 3/5] checkpatch: ignore email headers better

2018-04-19 Thread Stefan Hajnoczi
From: Joe Perches There are some patches created by git format-patch that when scanned by checkpatch report errors on lines like To: address.tld This is a checkpatch false positive. Improve the logic a bit to ignore folded email headers to avoid emitting these messages.

[Qemu-devel] [PATCH v3 33/35] ppc: externalize ppc_get_vcpu_by_pir()

2018-04-19 Thread Cédric Le Goater
We will use it to get the CPU interrupt presenter in XIVE. Signed-off-by: Cédric Le Goater --- hw/ppc/pnv.c | 16 hw/ppc/ppc.c | 16 include/hw/ppc/ppc.h | 1 + 3 files changed, 17 insertions(+), 16 deletions(-) diff --git

[Qemu-devel] [PATCH 2/4] audio/hda: turn some dprintfs into trace points

2018-04-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/audio/hda-codec.c | 9 - hw/audio/trace-events | 4 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c index 9ee2f3d55f..13d4473f18 100644 --- a/hw/audio/hda-codec.c +++

[Qemu-devel] [PATCH 4/4] ui: document non-qapi parser cases.

2018-04-19 Thread Gerd Hoffmann
Add comments to the cases not (yet) switched over to parse_display_qapi(). Signed-off-by: Gerd Hoffmann --- vl.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/vl.c b/vl.c index 1123cd792e..d35c443b8c 100644 --- a/vl.c +++ b/vl.c @@ -2121,6 +2121,16 @@

[Qemu-devel] [PATCH 3/4] ui: switch gtk display to qapi parser

2018-04-19 Thread Gerd Hoffmann
Drop the gtk option parser from parse_display(), so parse_display_qapi() will handle it instead. Signed-off-by: Gerd Hoffmann --- vl.c | 32 1 file changed, 32 deletions(-) diff --git a/vl.c b/vl.c index 39303d6b55..1123cd792e 100644 ---

[Qemu-devel] [PATCH v2 09/43] docker: extend "cc" command to accept compiler

2018-04-19 Thread Alex Bennée
When calling our cross-compilation images we want to call something other than the default cc. Signed-off-by: Alex Bennée --- v2 - use arg.cc default to simplify logic --- tests/docker/docker.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 22/43] tests/tcg/x86_64: add Makefile.target

2018-04-19 Thread Alex Bennée
The sources for x86_64 are shared in the i386 directory which will be included thanks to TARGET_BASE_ARCH. However not all sources build so we need to filter out the ones we can't build in the 64 bit world. Signed-off-by: Alex Bennée --- tests/tcg/i386/Makefile.target

[Qemu-devel] [PATCH v2 42/43] tests/tcg: disable fp-test for 32 bit (HACK!)

2018-04-19 Thread Alex Bennée
This prevents us trying to build fp-test for 32 bit guests as they would fail due to pollution from config-host.h when including osdep.h. As keeping softfloat.o would be useful maybe we can conditionally disabled it? Signed-off-by: Alex Bennée ---

Re: [Qemu-devel] [qemu-s390x] [PATCH for-2.13] Clear mem_path if we fall back to anonymous RAM allocation

2018-04-19 Thread David Hildenbrand
On 19.04.2018 15:34, Christian Borntraeger wrote: > > > On 04/19/2018 02:58 PM, Cornelia Huck wrote: >> On Thu, 19 Apr 2018 14:33:18 +0200 >> Igor Mammedov wrote: >> >>> On Thu, 19 Apr 2018 17:21:23 +1000 >>> David Gibson wrote: >>> If the

[Qemu-devel] [PATCH v2 31/43] tests/tcg: enable building for MIPS

2018-04-19 Thread Alex Bennée
This doesn't add any additional tests but enables building the multiarch tests for MIPS using docker cross compilers. We don't have a cross compiler for mips64 big endian though. Signed-off-by: Alex Bennée --- tests/tcg/mips/Makefile.include | 17 + 1

[Qemu-devel] [PATCH] target/arm: Use v7m_stack_read() for reading the frame signature

2018-04-19 Thread Peter Maydell
In commit 95695effe8caa552b8f2 we changed the v7M/v8M stack pop code to use a new v7m_stack_read() function that checks whether the read should fail due to an MPU or bus abort. We missed one call though, the one which reads the signature word for the callee-saved register part of the frame.

[Qemu-devel] [PATCH v2 19/43] tests/tcg/i386: fix test-i386

2018-04-19 Thread Alex Bennée
The test-i386 test case is a little special as it includes assembler files. Add the additional compile magic to assemble these bits and link them to the final binary. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Philippe

[Qemu-devel] [PATCH v2 36/43] Makefile.target: add (clean-)guest-tests targets

2018-04-19 Thread Alex Bennée
Now all the build infrastructure is in place we can build tests for each guest that we support. That support mainly depends on having cross compilers installed or docker setup. To keep all the logic for that together we put the rules in tests/tcg/Makefile.include and include it from the main

[Qemu-devel] [PATCH v2 43/43] tests: fp-test add fcvt support (!INCOMPLETE WIP)

2018-04-19 Thread Alex Bennée
This adds support for the various FOO-to-BAR conversions to fp-test. It also defines PREC_HALF although currently that is not used and will need compile time detection for _Float16 support. I've added a small test file for testing against regressions. Signed-off-by: Alex Bennée

Re: [Qemu-devel] [PATCH 2/5] checkpatch: check utf-8 content from a commit log when it's missing from charset

2018-04-19 Thread Thomas Huth
On 19.04.2018 11:11, Stefan Hajnoczi wrote: > From: Pasi Savanainen > > Check that a commit log doesn't contain UTF-8 when a mail header > explicitly defines a different charset, like > > 'Content-Type: text/plain; charset="us-ascii"' > > Signed-off-by: Pasi

[Qemu-devel] [PATCH v1 4/5] target-microblaze: mmu: Make TLBSX write-only

2018-04-19 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Make TLBSX write-only and guest-error log reads from it. Signed-off-by: Edgar E. Iglesias --- target/microblaze/mmu.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target/microblaze/mmu.c

[Qemu-devel] [PATCH v1 0/5] target-microblaze: Misc bug fixes

2018-04-19 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Hi, This is a series of fixes for bugs I ran into when adding support for extended addressing. It would be nice to get these into 2.12 if it's not too late. Cheers, Edgar Edgar E. Iglesias (5): target-microblaze: Respect MSR.PVR as

[Qemu-devel] [PATCH v1 1/5] target-microblaze: Respect MSR.PVR as read-only

2018-04-19 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Respect MSR.PVR as read-only. We were wrongly overwriting the PVR bit. Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.h | 4 +++- target/microblaze/translate.c | 8 +--- 2 files changed, 4

Re: [Qemu-devel] [PATCH] riscv: requires libfdt

2018-04-19 Thread Paolo Bonzini
On 19/04/2018 12:51, KONRAD Frederic wrote: > When compiling on a machine without libfdt installed the configure script > should try to get libfdt from the git or should die because otherwise > CONFIG_LIBFDT is not set and the build process end in an error in the link > phase.. eg: > >

Re: [Qemu-devel] [PATCH v3 6/6] vhost-user: support registering external host notifiers

2018-04-19 Thread Liang, Cunming
> -Original Message- > From: Bie, Tiwei > Sent: Thursday, April 19, 2018 7:15 PM > To: Michael S. Tsirkin > Cc: jasow...@redhat.com; alex.william...@redhat.com; pbonz...@redhat.com; > stefa...@redhat.com; qemu-devel@nongnu.org; virtio-dev@lists.oasis- > open.org; Liang,

[Qemu-devel] [PATCH v3 13/35] spapr: add hcalls support for the XIVE exploitation interrupt mode

2018-04-19 Thread Cédric Le Goater
The different XIVE virtualization engines (sources and event queues) are configured with a set of Hypervisor calls : - H_INT_GET_SOURCE_INFO used to obtain the address of the MMIO page of the Event State Buffer (PQ bits) entry associated with the source. - H_INT_SET_SOURCE_CONFIG

[Qemu-devel] [PATCH v3 05/35] spapr/xive: add a single source block to the sPAPR XIVE model

2018-04-19 Thread Cédric Le Goater
Bare-metal systems (PowerNV) have multiples interrupt sources. The XIVE interrupt controller has an internal source for IPIs and generic IPIs, the PSIHB has one and also the PHBs. But, for simplicity on the sPAPR machine, we use a unique XiveSource object for all IPIs and virtual device interrupts

[Qemu-devel] [PATCH v3 27/35] migration: discard non-migratable RAMBlocks

2018-04-19 Thread Cédric Le Goater
On the POWER9 processor, the XIVE interrupt controller can control interrupt sources using MMIO to trigger events, to EOI or to turn off the sources. Priority management and interrupt acknowledgment is also controlled by MMIO in the presenter sub-engine. These MMIO regions are exposed to guests

[Qemu-devel] [PATCH v3 34/35] ppc/pnv: add XIVE support

2018-04-19 Thread Cédric Le Goater
This is simple model of the POWER9 XIVE interrupt controller for the PowerNV machine. XIVE for baremetal is a complex controller and the model only addresses the needs of the skiboot firmware. Support is provided for : * virtual structure descriptor tables describing the XIVE internal tables

[Qemu-devel] [PATCH v3 31/35] spapr/xive: raise migration priority of the machine

2018-04-19 Thread Cédric Le Goater
The XIVE MMIO regions should be set on the destination before the XIVE sources are restored. This is currently handled at the machine level because it depends on the KVM initialization to be done before anything else. But it has ugly consequences on MMU, which seems broken after migration :

[Qemu-devel] [PATCH 1/4] audio/hda: create millisecond timers that handle IO

2018-04-19 Thread Gerd Hoffmann
Currently, the HDA device tries to sync itself with the QEMU audio backend by waiting for the guest driver to handle buffer completion interrupts. This causes the backend to often read too much data from the device, as well as running out of data whenever the guest takes too long to handle the

Re: [Qemu-devel] [PATCH v5 5/5] qobject: modify qobject_ref() to assert on NULL

2018-04-19 Thread Marc-André Lureau
Hi On Thu, Apr 19, 2018 at 8:18 AM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> While it may be convenient to accept NULL value in >> qobject_unref() (for similar reasons as free() accepts NULL), it is >> not such a good idea for

[Qemu-devel] [PATCH 1/4] ui: add qapi parser for -display

2018-04-19 Thread Gerd Hoffmann
Add parse_display_qapi() function which parses the -display command line using a qapi visitor for DisplayOptions. Wire up as default catch in parse_display(). Improves the error message for unknown display types. Also enables json as -display argument, i.e. -display "{ 'type': 'gtk' }"

[Qemu-devel] [PATCH v2 03/43] configure: add support for --cross-cc-FOO

2018-04-19 Thread Alex Bennée
This allows us to specify cross compilers for our guests. This is useful for building test images/programs. Currently we re-run the compile test for each target. I couldn't think of a way to cache the value for a given arch without getting messier configure code. The cross compiler for the guest

[Qemu-devel] [PATCH v2 00/43] fix building of tests/tcg

2018-04-19 Thread Alex Bennée
Hi, This is the second revision of my attempt to revive the tests/tcg directory. You can find the first iteration here: https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg01361.html Changes: I've slightly re-jigged the Makefile inclusion to make tests/tcg/Makefile very simple. All the

[Qemu-devel] [PATCH v2 06/43] configure: set cross_cc_FOO for host compiler

2018-04-19 Thread Alex Bennée
We can build tests for the host system with the compiler that we have selected. Signed-off-by: Alex Bennée --- configure | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 29af33716d..44d310a692 100755 ---

[Qemu-devel] [PATCH v2 08/43] docker: Add "cc" subcommand

2018-04-19 Thread Alex Bennée
Signed-off-by: Fam Zheng [AJB: add if args.paths check] Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- v2 - add if args.paths check to avoid iterating null

[Qemu-devel] [PATCH v2 07/43] Makefile: Rename TARGET_DIRS to TARGET_LIST

2018-04-19 Thread Alex Bennée
From: Fam Zheng To be more accurate on its purpose and make code that looks for a certain target out of this variable more readable. Signed-off-by: Fam Zheng Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH v2 34/43] tests/tcg: enable building for ppc64

2018-04-19 Thread Alex Bennée
Currently this just enables building the multiarch tests. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/tcg/ppc64le/Makefile.include | 2 ++ 1 file changed, 2 insertions(+)

[Qemu-devel] [PATCH v2 12/43] tests/tcg: move architecture independent tests into subdir

2018-04-19 Thread Alex Bennée
We will want to build these for all supported guest architectures so lets move them all into one place. We also drop test_path at this point because it needs qemu utils and glib bits which is hard to support for cross compiling. Signed-off-by: Alex Bennée Reviewed-by:

[Qemu-devel] [PATCH v3 32/35] ppc/pnv: introduce a pnv_icp_create() helper

2018-04-19 Thread Cédric Le Goater
The type of the interrupt presenter depends on the processor family, POWER8 uses XICS and POWER9 uses XIVE. Provide a machine-level helper to isolate the process and hide the details to the pnv core realize function. Signed-off-by: Cédric Le Goater --- hw/ppc/pnv.c | 14

[Qemu-devel] [PATCH v2 05/43] configure: allow user to specify --cross-cc-cflags-foo=

2018-04-19 Thread Alex Bennée
As an individual compiler may be able to support several targets with the appropriate flags we need to expose this to the user as well. Signed-off-by: Alex Bennée --- configure | 8 1 file changed, 8 insertions(+) diff --git a/configure b/configure index

[Qemu-devel] [PATCH v2 02/43] configure: add test for docker availability

2018-04-19 Thread Alex Bennée
This tests for a working docker installation without sudo and sets up config-host.mak accordingly. This will be useful from cross compiling things in the future. Signed-off-by: Alex Bennée --- configure | 17 + 1 file changed, 17 insertions(+) diff --git

[Qemu-devel] [PATCH v2 04/43] configure: move i386_cc to cross_cc_i386

2018-04-19 Thread Alex Bennée
Also dont assume x86_64 compiler can build i386 binaries. Signed-off-by: Alex Bennée Tested-by: Philippe Mathieu-Daudé --- v2 - drop using system x86_64 compiler for i386 compiles --- configure | 24 1 file changed, 16

[Qemu-devel] [PATCH v2 13/43] tests/tcg/multiarch: Build fix for linux-test

2018-04-19 Thread Alex Bennée
From: Fam Zheng To keep the compiler happy, and to fit in our buildsys flags: - Make local functions "static" - #ifdef out unused functions - drop cutils/osdep dependencies Signed-off-by: Fam Zheng [AJB: drop cutils/osdep dependencies] Signed-off-by: Alex

[Qemu-devel] [PATCH v2 27/43] tests/tcg/aarch64: add Makefile.target

2018-04-19 Thread Alex Bennée
Nothing much here yet. Signed-off-by: Alex Bennée --- tests/tcg/aarch64/Makefile.target | 5 + 1 file changed, 5 insertions(+) create mode 100644 tests/tcg/aarch64/Makefile.target diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile.target

[Qemu-devel] [PATCH v2 40/43] tests: add fp-test, a floating point test suite

2018-04-19 Thread Alex Bennée
From: "Emilio G. Cota" This will allow us to run correctness tests against our FP implementation. The test can be run in two modes (called "testers"): host and soft. With the former we check the results and FP flags on the host machine against the model. With the latter we check

[Qemu-devel] [PATCH v2 37/43] tests/Makefile.include: add (clean-)check-tcg targets

2018-04-19 Thread Alex Bennée
This will ensure all linux-user targets build their guest test programs. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- v2 - use -include instead of complex macro stuff - also

[Qemu-devel] [PATCH v2 28/43] tests/tcg/aarch64: add fcvt test cases for AArch64

2018-04-19 Thread Alex Bennée
This runs through the usual float to float conversions and crucially also runs with ARM Alternative Half Precision Format. Signed-off-by: Alex Bennée --- tests/tcg/aarch64/Makefile.target |8 + tests/tcg/aarch64/fcvt.c | 260 ++

[Qemu-devel] [PATCH v2 23/43] tests/tcg/i386/test-i386: use modern vector_size attributes

2018-04-19 Thread Alex Bennée
The compiler complains about the old __mode__ style attributes. Signed-off-by: Alex Bennée --- tests/tcg/i386/test-i386.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/tcg/i386/test-i386.c b/tests/tcg/i386/test-i386.c index

[Qemu-devel] [PATCH 0/4] audio/hda: improve windows guest audio quality.

2018-04-19 Thread Gerd Hoffmann
Based on a patch by Martin Schrodt. Gerd Hoffmann (4): audio/hda: create millisecond timers that handle IO audio/hda: turn some dprintfs into trace points audio/hda: tweak timer adjust logic audio/hda: detect output buffer overruns and underruns include/hw/compat.h | 7 ++

[Qemu-devel] [PATCH v3 28/35] intc: introduce a CPUIntc interface

2018-04-19 Thread Cédric Le Goater
which we will use in the sPAPR machine to reset the interrupt controller of each CPU at the KVM level. Signed-off-by: Cédric Le Goater --- hw/intc/intc.c | 26 ++ include/hw/intc/intc.h | 21 + 2 files changed, 47 insertions(+)

[Qemu-devel] [PATCH 2/4] ui: switch trivial displays to qapi parser

2018-04-19 Thread Gerd Hoffmann
Drop the option-less display types (egl-headless, curses, none) from parse_display(), so they'll be handled by parse_display_qapi(). Signed-off-by: Gerd Hoffmann --- vl.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/vl.c b/vl.c index 784c3fb795..39303d6b55 100644

  1   2   3   4   5   >