Re: [Qemu-devel] [PATCH 5/5] linux-user: add sparc/sparc64 specific errno

Le 08/05/2018 à 22:22, Max Filippov a écrit : > On Tue, May 8, 2018 at 12:40 PM, Laurent Vivier wrote: >> Copied from linux/arch/sparc/include/uapi/asm/errno.h >> >> Signed-off-by: Laurent Vivier >> --- >> linux-user/sparc/target_syscall.h | 203 >>

[Qemu-devel] [PATCH] m68k: fix floatx80_mod() (Coverity CID1390568)

Update the variable checked by the loop condition (expDiff). Backport the update from Previous. Fixes: 591596b77a ("target/m68k: add fmod/frem") Signed-off-by: Laurent Vivier --- target/m68k/softfloat.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Qemu-devel] [PULL 0/3] RISC-V: QEMU 2.13 Minor Fixes

On Wed, May 9, 2018 at 8:49 AM, Peter Maydell wrote: > On 8 May 2018 at 21:07, Michael Clark wrote: > > The following changes since commit c8b7e627b4269a3bc3ae41d9f42054 > 7a47e6d9b9: > > > > Merge remote-tracking branch

[Qemu-devel] [PULL 03/30] cpus: tcg: fix never exiting loop on unplug

From: Cédric Le Goater Commit 9b0605f9837b ("cpus: tcg: unregister thread with RCU, fix exiting of loop on unplug") changed the exit condition of the loop in the vCPU thread function but forgot to remove the beginning 'while (1)' statement. The resulting code : while (1)

[Qemu-devel] [PULL 04/30] checkpatch.pl: add common glib defines to typelist

From: Peter Xu Otherwise it can warn this: ERROR: space prohibited between function name and open parenthesis '(' When with things like this: typedef gboolean (*it_tree_iterator)(ITValue start, ITValue end); CC: Paolo Bonzini CC: "Daniel P.

[Qemu-devel] [PULL 15/30] opts: don't silently truncate long option values

From: Daniel P. Berrangé The existing QemuOpts parsing code uses a fixed size 1024 byte buffer for storing the option values. If a value exceeded this size it was silently truncated and no error reported to the user. Long option values is not a common scenario, but it is

[Qemu-devel] [PULL 09/30] exec: extract address_space_translate_iommu, fix page_mask corner case

This will be used to process IOMMUs in a MemoryRegionCache. This includes a small bugfix, in that the returned page_mask is now correctly -1 if the IOMMU memory region maps the entire address space directly. Previously, address_space_get_iotlb_entry would return ~TARGET_PAGE_MASK. Reviewed-by:

[Qemu-devel] [PULL 26/30] configure: Display if libfdt is from system or git

From: Philippe Mathieu-Daudé The configure script outputs "yes" regardless which libfdt is used: ./configure [...] fdt support yes Sometimes you can have both system and local git version available, change the configure script to display which library got selected:

Re: [Qemu-devel] [PATCH] RISC-V: Remove unnecessary header include

On Tue, May 8, 2018 at 7:42 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/riscv/riscv_htif.c | 1 - > hw/riscv/sifive_e.c | 1 - > hw/riscv/sifive_u.c

[Qemu-devel] [PATCH 5/5] linux-user: add sparc/sparc64 specific errno

Copied from linux/arch/sparc/include/uapi/asm/errno.h Signed-off-by: Laurent Vivier --- linux-user/sparc/target_syscall.h | 203 linux-user/sparc64/target_syscall.h | 203 2 files changed, 406

[Qemu-devel] [PULL 1/3] riscv: spike: allow base == 0

From: KONRAD Frederic The sanity check on base doesn't allow htif to be mapped @0. Check if the symbol exists instead so we can map it where we want. Reviewed-by: Michael Clark Signed-off-by: KONRAD Frederic

[Qemu-devel] [PULL 22/30] qemu-doc: provide details of supported build platforms

From: Daniel P. Berrangé Describe the policy the project uses to decide which OS are supported as build platforms. This will: - Allow maintainers to determine when the minimum version of a 3rd party piece of software can be increased without negatively impacting

[Qemu-devel] [PULL 17/30] qemu-options: Mark -virtioconsole as deprecated

From: Thomas Huth The qemu-doc already states that this option is only maintained for backward compatibility and "-device virtconsole" should be used instead. So let's take the next step and mark this option officially as deprecated. Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 5/5] linux-user: add sparc/sparc64 specific errno

On Tue, May 8, 2018 at 12:40 PM, Laurent Vivier wrote: > Copied from linux/arch/sparc/include/uapi/asm/errno.h > > Signed-off-by: Laurent Vivier > --- > linux-user/sparc/target_syscall.h | 203 > >

Re: [Qemu-devel] [PATCH] target/m68k: Fix build Werror with gcc 8.0.1

Le 08/05/2018 à 20:55, Richard Henderson a écrit : > Fedora 28 ships with the released gcc 8. > > The Werror stems from the compiler finding a path through the second > switch via a missing default case in which src1 is uninitialized, and > not being able to prove that the missing default case is

[Qemu-devel] [PULL 02/30] cpus: Fix event order on resume of stopped guest

From: Markus Armbruster When resume of a stopped guest immediately runs into block device errors, the BLOCK_IO_ERROR event is sent before the RESUME event. Reproducer: 1. Create a scratch image $ dd if=/dev/zero of=scratch.img bs=1M count=100 Size doesn't actually

[Qemu-devel] [PULL 19/30] qemu-options: Bail out on unsupported options instead of silently ignoring them

From: Thomas Huth The dangling remainder of the -tdf option revealed a deficiency in our option parsing: Options that have been declared, but are not supported in the switch-case statement in vl.c and not handled in the OS-specifc os_parse_cmd_args() functions are currently

[Qemu-devel] [PULL 30/30] rename included C files to foo.inc.c, remove osdep.h

osdep.h is only needed for files that are compiled directly. Remove it from included C source files, and rename them to *.inc.c so that scripts/clean-includes knows to skip them. Cc: Eric Blake Cc: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 4/5] linux-user: fix convertion of flock/flock64 l_type field

As l_type values (F_RDLCK, F_WRLCK, F_UNLCK, F_EXLCK, F_SHLCK) are not bitmasks, we can't use target_to_host_bitmask() and host_to_target_bitmask() to convert them. Introduce target_to_host_flock() and host_to_target_flock() to convert values between host and target. Signed-off-by: Laurent

[Qemu-devel] [PATCH 2/5] linux-user: fix flock/flock64 padding

include/uapi/asm-generic/fcntl.h insert a padding macro at the end of the structures flock and flock64. This macro is defined to "short __unused;" on sparc, and "long pad[4]" on mips. Signed-off-by: Laurent Vivier --- linux-user/syscall_defs.h | 16 +--- 1 file

Re: [Qemu-devel] [PULL 0/3] RISC-V: QEMU 2.13 Minor Fixes

On Wed, May 9, 2018 at 4:05 AM, Peter Maydell wrote: > On 8 May 2018 at 00:14, Michael Clark wrote: > > The following changes since commit c8b7e627b4269a3bc3ae41d9f42054 > 7a47e6d9b9: > > > > Merge remote-tracking branch

[Qemu-devel] [PULL 08/30] exec: small changes to flatview_do_translate

Prepare for extracting the IOMMU part to a separate function. Mostly cosmetic; the only semantic change is that, if there is more than one cascaded IOMMU and the second one fails to translate, *plen_out is now adjusted according to the page mask of the first IOMMU. Reviewed-by: Peter Xu

[Qemu-devel] [PULL 01/30] configure: recognize more rpmbuild macros

From: Olaf Hering Extend the list of recognized, but ignored options from rpms %configure macro. This fixes build on hosts running SUSE Linux. Cc: qemu-sta...@nongnu.org Signed-off-by: Olaf Hering Message-Id: <20180418075045.27393-1-o...@aepfle.de>

Re: [Qemu-devel] [PATCH] tcg: Limit the number of ops in a TB

On 05/08/2018 04:36 PM, Richard Henderson wrote: > In 6001f7729e12 we partially attempt to address the branch > displacement overflow caused by 15fa08f845. > > However, gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vqtbX.c > is a testcase that contains a TB so large as to overflow anyway. >

Re: [Qemu-devel] [RFC PATCH 3/4] hw/ssi: Remove SSIBus from qemu/typedefs.h

On Tue, May 8, 2018 at 8:10 AM, Philippe Mathieu-Daudé wrote: > There are only two files requiring this typedef (strongarm.h > and hw/arm/pxa.h), let them include "hw/pcmcia.h" directly to > simplify qemu/typedefs.h. > > Signed-off-by: Philippe Mathieu-Daudé I

Re: [Qemu-devel] [PATCH v7 1/9] i386: Helpers to encode cache information consistently

On Tue, May 08, 2018 at 06:40:23PM +, Moger, Babu wrote: > Hi Eduardo, One more comment below. > > > -Original Message- > > From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] > > On Behalf Of Moger, Babu > > Sent: Monday, May 7, 2018 5:48 PM > > To: Eduardo Habkost

[Qemu-devel] [PATCH 0/5] linux-user: fix sparc32plus

This series fixes several problems with sparc and allows to debootstrap a chroot using qemu-sparc32plus and debian sparc/wheezy. For the moment, networking doesn't work. Laurent Vivier (5): linux-user: define correct fcntl() values for sparc linux-user: fix flock/flock64 padding

Re: [Qemu-devel] [PATCH] linux-user: fix convertion of flock/flock64 l_type field

Le 08/05/2018 à 20:55, Eric Blake a écrit : > On 05/08/2018 12:08 PM, Max Filippov wrote: >> On Tue, May 8, 2018 at 9:36 AM, Laurent Vivier wrote: > > In the subject, s/convertion/conversion/ > >>> As l_type values (F_RDLCK, F_WRLCK, F_UNLCK, F_EXLCK, F_SHLCK) >>> are not

Re: [Qemu-devel] [PATCH] tcg: Limit the number of ops in a TB

Le 08/05/2018 à 21:36, Richard Henderson a écrit : > In 6001f7729e12 we partially attempt to address the branch > displacement overflow caused by 15fa08f845. > > However, gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vqtbX.c > is a testcase that contains a TB so large as to overflow anyway.

[Qemu-devel] [PULL 07/30] exec: move memory access declarations to a common header, inline *_phys functions

For now, this reduces the text size very slightly due to the newly-added inlining: text size before: 9301965 text size after: 9300645 Later, however, the declarations in include/exec/memory_ldst.inc.h will be reused for the MemoryRegionCache slow path functions. Signed-off-by: Paolo

[Qemu-devel] [PULL 29/30] pc-dimm: fix error messages if no slots were defined

From: David Hildenbrand If no slots were defined we try to allocate an empty bitmap, which fails. Signed-off-by: David Hildenbrand Reviewed-by: Marcel Apfelbaum Reviewed-by: Thomas Huth Message-Id:

[Qemu-devel] [PATCH 3/5] linux-user: update sparc/syscall_nr.h to linux header 4.16

And kill sys_aplib, add sys_sync_file_range: on sparc, since linux 2.6.17, aplib syscall has been replaced by sync_file_range syscall. (289eee6fa78e ["SPARC]: Wire up sys_sync_file_range() into syscall tables.") The syscall has been removed in linux v2.5.71 (6196166fad "[SPARC64]: Kill

[Qemu-devel] [PATCH 1/5] linux-user: define correct fcntl() values for sparc

Signed-off-by: Laurent Vivier --- linux-user/syscall_defs.h | 9 + 1 file changed, 9 insertions(+) diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h index 361bb83a29..ec3f561685 100644 --- a/linux-user/syscall_defs.h +++ b/linux-user/syscall_defs.h @@

Re: [Qemu-devel] [PATCH] docker: Fix trivial typo

Le 08/05/2018 à 16:43, Philippe Mathieu-Daudé a écrit : > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include > index

Re: [Qemu-devel] [PATCH 1/5] linux-user: define correct fcntl() values for sparc

On Tue, May 8, 2018 at 12:40 PM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > linux-user/syscall_defs.h | 9 + > 1 file changed, 9 insertions(+) Reviewed-by: Max Filippov -- Thanks. -- Max

Re: [Qemu-devel] [PULL 0/3] RISC-V: QEMU 2.13 Minor Fixes

On 8 May 2018 at 21:07, Michael Clark wrote: > The following changes since commit c8b7e627b4269a3bc3ae41d9f420547a47e6d9b9: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-05-04' into > staging (2018-05-04 14:42:46 +0100) > > are available in the git

[Qemu-devel] [PULL 00/30] Misc patches for 2018-05-09

The following changes since commit cc8f8ba754bba17eea9791d67b572eb26e30b4ce: Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-05-08 15:25:17 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream

[Qemu-devel] [PULL 12/30] update-linux-headers: drop hyperv.h

From: Roman Kagan As of mainline linux commit 5a485803221777013944cbd1a7cd5c62efba3ffa "x86/hyper-v: move hyperv.h out of uapi" by Vitaly Kuznetsov, no linux uapi header includes it, so we no longer need to create a stub for it. Cc: Vitaly Kuznetsov

[Qemu-devel] [PULL 28/30] build: Silence dtc directory creation

From: Jan Kiszka Align with other mkdir calls. Signed-off-by: Jan Kiszka Reviewed-by: Philippe Mathieu-Daudé Message-Id: <0dd4c8f5-d60e-e564-652f-cd0101f6e...@web.de> Message-Id: <20180415230522.24404-5-f4...@amsat.org>

[Qemu-devel] [PULL 11/30] qemu-thread: always keep the posix wrapper layer

From: Peter Xu We will conditionally have a wrapper layer depending on whether the host has the PTHREAD_SETNAME capability. It complicates stuff. Let's keep the wrapper there; we opt out the pthread_setname_np() call only. Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH v1] configure: recognize more rpmbuild macros

On 18/04/2018 11:23, Paolo Bonzini wrote: > On 18/04/2018 09:50, Olaf Hering wrote: >> Extend the list of recognized, but ignored options from rpms %configure >> macro. This fixes build on hosts running SUSE Linux. >> >> Signed-off-by: Olaf Hering >> --- >> configure | 3 +++ >>

[Qemu-devel] [PULL 21/30] qemu-options: Remove deprecated -no-kvm-irqchip

From: Thomas Huth We've never documented this option in our qemu-doc, so apart from the users that already used the old qemu-kvm fork before, most users should not be aware of this option at all. It's been marked as deprecated in the source code for a long time already, and

[Qemu-devel] [PULL 25/30] configure: Really use local libfdt if the system one is too old

From: Philippe Mathieu-Daudé QEMU requires libfdt version >= 1.4.2. If the host has an older libfdt installed, the configure script will use a (git cloned) local version. Example with Debian 8: $ dpkg-query --showformat='${Version}\n' --show libfdt-dev 1.4.0+dfsg-1

Re: [Qemu-devel] [PATCH] linux-user: fix convertion of flock/flock64 l_type field

On 05/08/2018 12:08 PM, Max Filippov wrote: On Tue, May 8, 2018 at 9:36 AM, Laurent Vivier wrote: In the subject, s/convertion/conversion/ As l_type values (F_RDLCK, F_WRLCK, F_UNLCK, F_EXLCK, F_SHLCK) are not bitmasks, we can't use target_to_host_bitmask() and

[Qemu-devel] [PATCH] target/m68k: Fix build Werror with gcc 8.0.1

Fedora 28 ships with the released gcc 8. The Werror stems from the compiler finding a path through the second switch via a missing default case in which src1 is uninitialized, and not being able to prove that the missing default case is unreachable due to the first switch. Simplify the second

Re: [Qemu-devel] [PATCH v7 1/9] i386: Helpers to encode cache information consistently

> -Original Message- > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Tuesday, May 8, 2018 2:08 PM > To: Moger, Babu > Cc: ge...@hostfission.com; k...@vger.kernel.org; m...@redhat.com; > k...@tripleback.net; mtosa...@redhat.com; qemu-devel@nongnu.org; >

[Qemu-devel] [PULL 2/3] riscv: htif: increase the priority of the htif subregion

From: KONRAD Frederic The htif device is supposed to be mapped over an other subregion. So increase its priority to one to avoid any conflict. Here is the output of info mtree: Before: (qemu) info mtree address-space: memory -

[Qemu-devel] [PULL 05/30] qom: allow object_get_canonical_path_component without parent

Just return NULL; any callers that cause a change in behavior would have caused an assertion failure before, so this is safe. Signed-off-by: Paolo Bonzini --- include/qom/object.h | 1 + qom/object.c | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PULL 18/30] qemu-options: Remove remainders of the -tdf option

From: Thomas Huth The -tdf options has been removed with d07aa197c5a1556449361a0cbb5108e2, but apparently I forgot to remove the corresponding two lines from qemu-options.hx, so this option is still "available" and just silently ignored. Kill it now for good. Reviewed-by:

[Qemu-devel] [PULL 14/30] opts: don't silently truncate long parameter keys

From: Daniel P. Berrangé The existing QemuOpts parsing code uses a fixed size 128 byte buffer for storing the parameter keys. If a key exceeded this size it was silently truncate and no error reported to the user. This behaviour was reasonable & harmless because

[Qemu-devel] [PATCH] iscsi: Avoid potential for get_status overflow

Detected by Coverity: Multiplying two 32-bit int and assigning the result to a 64-bit number is a risk of overflow. Prior to the conversion to byte-based interfaces, the block layer took care of ensuring that a status request never exceeded 2G in the driver; but after that conversion, the block

Re: [Qemu-devel] [PATCH] RISC-V: Remove unnecessary header include

On Wed, May 9, 2018 at 2:42 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Michael Clark --- > hw/riscv/riscv_htif.c | 1 - > hw/riscv/sifive_e.c | 1 - > hw/riscv/sifive_u.c | 1 - >

[Qemu-devel] [PULL 23/30] glib: bump min required glib library version to 2.42

From: Daniel P. Berrangé Per supported platforms doc, the various min glib on relevant distros is: RHEL-7: 2.50.3 Debian (Stretch): 2.50.3 Debian (Jessie): 2.42.1 OpenBSD (Ports): 2.54.3 FreeBSD (Ports): 2.50.3 OpenSUSE Leap 15: 2.54.3 Ubuntu (Xenial): 2.48.0

[Qemu-devel] [PULL 06/30] memdev: remove "id" property

The "id" property is unnecessary and can be replaced simply with object_get_canonical_path_component. This patch mostly undoes commit e1ff3c67e8 ("monitor: fix qmp/hmp query-memdev not reporting IDs of memory backends", 2017-01-12). Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PULL 16/30] target/i386: sev: fix memory leaks

Reported by Coverity. Signed-off-by: Paolo Bonzini --- target/i386/sev.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/target/i386/sev.c b/target/i386/sev.c index c011671..2395171 100644 --- a/target/i386/sev.c +++

[Qemu-devel] [PULL 24/30] i386/kvm: add support for Hyper-V reenlightenment MSRs

From: Vitaly Kuznetsov KVM recently gained support for Hyper-V Reenlightenment MSRs which are required to make KVM-on-Hyper-V enable TSC page clocksource to its guests when INVTSC is not passed to it (and it is not passed by default in Qemu as it effectively blocks

Re: [Qemu-devel] [PATCH] hw/ide/ahci: Keep ALLWINNER_AHCI() macro internal

On 05/08/2018 10:49 AM, Philippe Mathieu-Daudé wrote: > The ALLWINNER_AHCI() macro is only used in ahci-allwinner.c. > extra internal! > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: John Snow Feel free to stage in trivial, thanks.

[Qemu-devel] [PULL 20/30] qemu-options: Remove deprecated -no-kvm-pit-reinjection

From: Thomas Huth Deprecated since the beginning when it was added for compatibility with the ancient qemu-kvm fork of QEMU, and it even printed out the deprecation warning since right from the start (i.e. QEMU v1.3.0), so it's really time to remove this now. Reviewed-by:

[Qemu-devel] [PATCH] tcg: Limit the number of ops in a TB

In 6001f7729e12 we partially attempt to address the branch displacement overflow caused by 15fa08f845. However, gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vqtbX.c is a testcase that contains a TB so large as to overflow anyway. The limit here of 8000 ops produces a maximum output TB size

[Qemu-devel] GSoC Intro: Vulkan-ize VirGL

Hi, I'm Nathan Gauër, a french student in computer science. For this year's Google Summer of Code, I've been selected to work on the Vulkan support for Virgl3D. The nature of this project makes the roadmap a bit blurry, but hopefully, we will get somewhere soon. My mentor will be Marc-André

[Qemu-devel] [PULL 3/3] riscv: requires libfdt

From: KONRAD Frederic When compiling on a machine without libfdt installed the configure script should try to get libfdt from the git or should die because otherwise CONFIG_LIBFDT is not set and the build process end in an error in the link phase.. eg:

[Qemu-devel] [PULL 0/3] RISC-V: QEMU 2.13 Minor Fixes

The following changes since commit c8b7e627b4269a3bc3ae41d9f420547a47e6d9b9: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-05-04' into staging (2018-05-04 14:42:46 +0100) are available in the git repository at: https://github.com/riscv/riscv-qemu.git

Re: [Qemu-devel] [PATCH 2/5] linux-user: fix flock/flock64 padding

On Tue, May 8, 2018 at 12:40 PM, Laurent Vivier wrote: > include/uapi/asm-generic/fcntl.h insert a padding macro at > the end of the structures flock and flock64. > > This macro is defined to "short __unused;" on sparc, > and "long pad[4]" on mips. > > Signed-off-by: Laurent

[Qemu-devel] [RFC PATCH 1/1] SPARC64: add icount support

This patch adds gen_io_start()/gen_io_end() to various instructions as required in order to boot my OpenBIOS test images on qemu-system-sparc64 with icount enabled. Signed-off-by: Mark Cave-Ayland --- target/sparc/translate.c | 97

[Qemu-devel] [RFC PATCH 0/1] SPARC64: add icount support

This is a patch I've had in an earlier form for a while but never really developed due to experiencing random hangs when writing to the SPARC64 CPU timers. Fortunately it seems the recent icount timer fixes have resolved the underlying issues and with this patch I am able to boot all my

[Qemu-devel] [PULL 10/30] exec: reintroduce MemoryRegion caching

MemoryRegionCache was reverted to "normal" address_space_* operations for 2.9, due to lack of support for IOMMUs. Reinstate the optimizations, caching only the IOMMU translation at address_cache_init but not the IOMMU lookup and target AddressSpace translation are not cached; now that

Re: [Qemu-devel] [RFC PATCH 4/4] hw/ide/ahci: Remove AllwinnerAHCIState from qemu/typedefs.h

On 05/08/2018 11:10 AM, Philippe Mathieu-Daudé wrote: > Files requiring AllwinnerAHCIState already include "hw/ide/ahci.h". > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/ide/ahci.h | 4 ++-- > include/qemu/typedefs.h | 1 - > 2 files changed, 2 insertions(+),

[Qemu-devel] [PULL 13/30] accel: use g_strsplit for parsing accelerator names

From: Daniel P. Berrangé Instead of re-using the get_opt_name() method from QemuOpts to split a string on ':', just use g_strsplit(). Signed-off-by: Daniel P. Berrangé Message-Id: <20180416111743.8473-2-berra...@redhat.com> Signed-off-by: Paolo

[Qemu-devel] [PULL 27/30] shippable: Remove Debian 8 libfdt kludge

From: Philippe Mathieu-Daudé This kludge was added in a825ca06137, but a cleaner and more generic fix is now available (see ##COMMIT_CONFIGURE_LIBFDT_LDFLAGS_SHA##). Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180415230522.24404-4-f4...@amsat.org>

Re: [Qemu-devel] [PULL 00/20] RISC-V: QEMU 2.13 Privileged ISA emulation updates

On Wed, May 9, 2018 at 1:22 AM, Peter Maydell wrote: > On 6 May 2018 at 00:35, Michael Clark wrote: > > The following changes since commit c8b7e627b4269a3bc3ae41d9f42054 > 7a47e6d9b9: > > > > Merge remote-tracking branch

Re: [Qemu-devel] [PATCH v4] loader: Fix misaligned member access

Hi Peter, Paolo, On 04/24/2018 07:21 PM, Philippe Mathieu-Daudé wrote: > The libfdt does not guarantee than fdt_getprop() returns a pointer > aligned to the property size. > > Assuming the base of the fdt is aligned, a 32-bit property returns > a 32-bit aligned pointer. This is however not

[Qemu-devel] [PATCH v2 13/14] sdcard: Add a "validate-crc" property

Since not all modelled controllers use the CRC verification (which is somehow expensive), let the controller have a configurable property to enable verification. So far only the Milkymist controller uses it. This silent the Coverity warning: "Code block is unreachable because of the syntactic

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add trace-events and qemu-option-trace.texi to tracing section

Hi Thomas, On 05/09/2018 01:38 AM, Thomas Huth wrote: > The "trace-events" and "qemu-option-trace.texi" files in the top directory > are currently "unmaintained" according to scripts/get_maintainer.pl. They > obviously belong to the Tracing section, so add an entry for them there. I agree

Re: [Qemu-devel] [PATCH v1] configure: recognize more rpmbuild macros

Am Wed, 9 May 2018 00:15:42 +0200 schrieb Paolo Bonzini : > Actually, --program-prefix= and --exec-prefix= have a meaning, they > cannot just be ignored. For now I've removed this line; what is the > exact incantation used by SUSE Linux? Like in every other rpm.rpm I guess:

[Qemu-devel] [PATCH] blockjob: expose error string via query

When we've reached the concluded state, we need to expose the error state if applicable. Add the new field. This should be sufficient for determining if a job completed successfully or not after concluding; if we want to discriminate based on how it failed more mechanically, we can always add an

Re: [Qemu-devel] [PATCH 00/10] Avoid integer overflow in next_page_start

On Thu, Apr 12, 2018 at 11:56 AM, Richard Henderson < richard.hender...@linaro.org> wrote: > On 04/12/2018 01:29 AM, Emilio G. Cota wrote: > > To ease an eventual merge I'll be updating the patches' R-b tags as > > they come in this branch: > >

[Qemu-devel] [PATCH v2 00/14] sdcard: Proper implementation of CRC7

Hi, This series emerged after last Coverity scan and Peter suggestion in: http://lists.nongnu.org/archive/html/qemu-devel/2018-04/msg05046.html (3) "proper" implementation of CRC, so that an sd controller can either (a) mark the SDRequest as "no CRC" and have sd_req_crc_validate()

Re: [Qemu-devel] [PATCH v5 6/6] MAINTAINERS: add entries for AP

On 8/5/18 10:46 pm, Cornelia Huck wrote: > On Tue, 8 May 2018 08:25:03 -0400 > Tony Krowiak wrote: > >> Added entries for the s390 adjunct processor (AP) support. >> >> Signed-off-by: Tony Krowiak >> --- >> MAINTAINERS | 14

[Qemu-devel] [PATCH v2 01/14] sdcard: Use the ldst API

The load/store API will ease further code movement. Per the Physical Layer Simplified Spec. "3.6 Bus Protocol": "In the CMD line the Most Significant Bit (MSB) is transmitted first, the Least Significant Bit (LSB) is the last." Signed-off-by: Philippe Mathieu-Daudé ---

[Qemu-devel] [PATCH v2 11/14] sdcard: Add sd_frame48_init(), replace SDRequest by a raw buffer

Using sd_frame48_init() we silent the Coverity warning: "Use of an uninitialized variable (CWE-457)" and fixes the following issues (all "Uninitialized scalar variable"): - CID1386072 (hw/sd/sdhci.c::sdhci_end_transfer) - CID1386074 (hw/sd/bcm2835_sdhost.c::bcm2835_sdhost_send_command) -

Re: [Qemu-devel] [PATCH 5/8] sdcard: Implement the UHS-I SWITCH_FUNCTION entries (Spec v3)

Hi Peter, On 03/09/2018 02:03 PM, Peter Maydell wrote: > On 9 March 2018 at 15:36, Philippe Mathieu-Daudé wrote: [...] >> static void sd_function_switch(SDState *sd, uint32_t arg) >> { >> -int i, mode, new_func; >> -mode = !!(arg & 0x8000); >> - >> -sd->data[0]

[Qemu-devel] [PATCH v2 10/14] sdcard: Remove the SDRequest argument from internal functions

Replace the SDRequest argument using directly {uint8_t cmd, uint32_t arg}, it will be easier to remove the SDRequest struct in the next commit. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 104 +++-- 1 file changed, 53

[Qemu-devel] [PATCH v2 07/14] sdcard: Invert the sd_req_crc_is_valid() logic

Let's return TRUE when the CRC is valid. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index d8dad94fc4..6fc8daa5b8 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -467,13

[Qemu-devel] [RFC PATCH v2 14/14] hw/sd/ssi-sd: Enable CRC validation

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/ssi-sd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c index 77e446bb94..0375f0b959 100644 --- a/hw/sd/ssi-sd.c +++ b/hw/sd/ssi-sd.c @@ -95,11 +95,11 @@ static uint32_t

[Qemu-devel] [PATCH v2 09/14] sdcard: Add sd_frame136_verify_checksum()

Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sd.h | 10 ++ hw/sd/sdmmc-internal.c | 6 ++ tests/sdcard-test.c| 12 3 files changed, 28 insertions(+) diff --git a/include/hw/sd/sd.h b/include/hw/sd/sd.h index 752d8edd6c..83399cd42d

[Qemu-devel] [PATCH v2 06/14] sdcard: Add test_sd_verify_cksum_frame136()

Per the Physical Layer Simplified Spec. "3.6 Bus Protocol": There are two types of Data packet format for the SD card. (1) Usual data (8-bit width): The usual data (8-bit width) are sent in LSB (Least Significant Byte) first, MSB (Most Significant Byte) last sequence. But in the

[Qemu-devel] [PATCH v5 4/4] monitor: add lock to protect mon_fdsets

Similar to previous patch, but introduce a new global big lock for mon_fdsets. Take it where needed. Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Xu --- monitor.c | 64 +-- 1 file changed, 53

[Qemu-devel] [PATCH] MAINTAINERS: Add trace-events and qemu-option-trace.texi to tracing section

The "trace-events" and "qemu-option-trace.texi" files in the top directory are currently "unmaintained" according to scripts/get_maintainer.pl. They obviously belong to the Tracing section, so add an entry for them there. Signed-off-by: Thomas Huth --- MAINTAINERS | 2 ++ 1

[Qemu-devel] [PATCH] MAINTAINERS: Add an entry for qemu-options* files in main directory

The file "qemu-options.h", "qemu-options.hx" and "qemu-options-wrapper.h" in the main directory are currently without maintainer according to our get_maintainers.pl script. Considering that the command line options are a public interface and thus quite important, this is quite a bad state. So I'd

[Qemu-devel] [PATCH v2 02/14] sdcard: Constify sd_crc*()'s message argument

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 235e0518d6..eb6dd5482e 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -236,11 +236,11 @@ static const int

[Qemu-devel] [PATCH v2 04/14] sdcard: Extract sd_frame48/136_calc_checksum()

It will help when moving this around for qtesting in the next commit. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 27a70896cd..06607115a7 100644 ---

[Qemu-devel] [PATCH v2 03/14] sdcard: Fix sd_crc*() style

Fix style to keep patchew/checkpatch happy when moving this code in the next patch. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sd.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 1/2] migration: implement io_set_aio_fd_handler function for RDMA QIOChannel

On Wed, May 9, 2018 at 1:10 AM, Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Lidong Chen wrote: >> > if qio_channel_rdma_readv return QIO_CHANNEL_ERR_BLOCK, the destination >> > qemu >> > crash. >> > >> > The

[Qemu-devel] [PATCH v2 05/14] sdcard: Move sd_crc7() and calc_checksum() out for qtesting

Move the calc_checksum() functions out so we will able to write qtests for them. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sd.h | 20 hw/sd/sd.c | 33 - hw/sd/sdmmc-internal.c | 35

[Qemu-devel] [PATCH v2 12/14] sdcard: Add tests to validate the 7-bit CRC checksum of 48-bit SD frame

Signed-off-by: Philippe Mathieu-Daudé --- tests/sdcard-test.c | 74 + 1 file changed, 74 insertions(+) diff --git a/tests/sdcard-test.c b/tests/sdcard-test.c index 81789d1f88..2288a05cdf 100644 --- a/tests/sdcard-test.c +++

[Qemu-devel] [PATCH v5 2/4] monitor: protect mon->fds with mon_lock

mon->fds were protected by BQL. Now protect it by mon_lock so that it can even be used in monitor iothread. Signed-off-by: Peter Xu --- monitor.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index

[Qemu-devel] [PATCH 3/5] vmdk: Implement .bdrv_co_create callback

This makes VMDK support x-blockdev-create. The implementation reuses the image creation code in vmdk_co_create_opts which now acceptes a callback pointer to "retrieve" BlockBackend pointers from the caller. This way we separate the logic between file/extent acquisition and initialization. The

[Qemu-devel] [PATCH 0/5] vmdk: Implement x-blockdev-create

This adds vmdk support to x-blockdev-create command. Unlike other formats, several VMDK subformats consists of multiple files (extents). In the QAPI interface we use an array of BlockdevRef to pass in. The management tool need to figure out how many extent files are needed but that is simple

Re: [Qemu-devel] [PATCH v1 1/1] tests/docker: Add a Avocado Docker test

On Mon, 05/07 13:09, Alistair Francis wrote: > Avocado is not trivial to setup on non-Fedora systems. To simplfying > future testing add a docker test image that runs Avocado tests. > > Signed-off-by: Alistair Francis > --- > tests/docker/dockerfiles/fedora.docker | 12

Re: [Qemu-devel] [PATCH] blockjob: expose error string via query

On 05/08/2018 06:36 PM, John Snow wrote: When we've reached the concluded state, we need to expose the error state if applicable. Add the new field. This should be sufficient for determining if a job completed successfully or not after concluding; if we want to discriminate based on how it

  1   2   3   4   >