Re: [Qemu-devel] [PATCH v3 12/12] intel-iommu: new sync_shadow_page_table

On Fri, May 18, 2018 at 12:06:14AM +0300, Michael S. Tsirkin wrote: > On Thu, May 17, 2018 at 04:59:27PM +0800, Peter Xu wrote: > > Firstly, introduce the sync_shadow_page_table() helper to resync the > > whole shadow page table of an IOMMU address space. Meanwhile, when we > > receive domain

[Qemu-devel] [PULL 1/3] console: Avoid segfault in screendump

From: Michal Privoznik After f771c5440e04626f1 it is possible to select device and head which to take screendump from. And even though we check if provided head number falls within range, it may still happen that the console has no surface yet leading to SIGSEGV: qemu.git

Re: [Qemu-devel] [PATCH 1/1] hw/usb/dev-smartcard-reader: Handle 64 B USB packets

On Wed, May 16, 2018 at 01:55:44PM +0200, jje...@redhat.com wrote: > From: Jakub Jelen > > The current code was not correctly handling 64 B (Max USB 1.1 payload size) > packets and therefore preventing some of the messages from smart card to > pass through to the guest. Added

Re: [Qemu-devel] [PATCH v2 09/10] intel-iommu: don't unmap all for shadow page table

On Thu, May 17, 2018 at 07:23:33PM +0200, Auger Eric wrote: > Hi Peter, > > On 05/04/2018 05:08 AM, Peter Xu wrote: > > IOMMU replay was carried out before in many use cases, e.g., context > > cache invalidations, domain flushes. We used this mechanism to sync the > > shadow page table by

Re: [Qemu-devel] [PATCH 1/2] qapi: allow flat unions with empty branches

Eric Blake writes: > On 05/17/2018 03:05 AM, Markus Armbruster wrote: QAPI language design alternatives: 1. Having unions cover all discriminator values explicitly is useful. > 2. Having unions repeat all the discriminator values

Re: [Qemu-devel] [PATCH] console: Avoid segfault in screendump

> > graphic_hw_update(con); > surface = qemu_console_surface(con); > +if (!surface) { > +error_setg(errp, "no surface"); > +return; > +} > + Added to ui queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v2 01/10] intel-iommu: send PSI always even if across PDEs

Hi, On 05/18/2018 05:41 AM, Peter Xu wrote: > On Thu, May 17, 2018 at 04:42:54PM +0200, Auger Eric wrote: >> Hi Peter, >> >> On 05/04/2018 05:08 AM, Peter Xu wrote: >>> During IOVA page table walking, there is a special case when the PSI >>> covers one whole PDE (Page Directory Entry, which

Re: [Qemu-devel] [PATCH] sdl: Move use of surface pointer below check for whether it is NULL

Please excuse me and thank you very much for the fix! 2018-05-18 10:04 GMT+03:00 Gerd Hoffmann : > On Tue, May 15, 2018 at 07:58:14PM +0100, Peter Maydell wrote: > > In commit 2ab858c6c38ee1 we added a use of the 'surf' variable > > in sdl2_2d_update() that was unfortunately

[Qemu-devel] [PATCH v4 4/9] intel-iommu: only do page walk for MAP notifiers

For UNMAP-only IOMMU notifiers, we don't need to walk the page tables. Fasten that procedure by skipping the page table walk. That should boost performance for UNMAP-only notifiers like vhost. CC: QEMU Stable Signed-off-by: Peter Xu ---

[Qemu-devel] [PATCH v4 7/9] intel-iommu: trace domain id during page walk

This patch only modifies the trace points. Previously we were tracing page walk levels. They are redundant since we have page mask (size) already. Now we trace something much more useful which is the domain ID of the page walking. That can be very useful when we trace more than one devices on

[Qemu-devel] [PULL 2/3] ui: add x_keymap.o to modules

From: Paolo Bonzini x_keymap.o is common to the SDL and GTK+ modules, and it causes the QEMU binary to link to the X11 libraries. Add it separately to the modules to keep the main QEMU binary smaller. Signed-off-by: Paolo Bonzini Message-id:

[Qemu-devel] [PULL 0/3] Ui 20180518 patches

The following changes since commit a4207e3b00e89f934adb231057dcf9a75ac2ae45: Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into staging (2018-05-17 11:59:50 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20180518-pull-request for you

Re: [Qemu-devel] [PATCH 1/4] vga: move bochs vbe defines to header file

On Thu, May 17, 2018 at 12:20:58PM -0300, Philippe Mathieu-Daudé wrote: > On 05/17/2018 06:25 AM, Gerd Hoffmann wrote: > > Create a new header file, move the bochs vbe dispi interface > > defines to it, so they can be used outside vga code. > > > > Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH v2 06/10] intel-iommu: pass in address space when page walk

On Thu, May 17, 2018 at 04:32:55PM +0200, Auger Eric wrote: > Hi Peter, > > On 05/04/2018 05:08 AM, Peter Xu wrote: > > We pass in the VTDAddressSpace to replace the aw bits when doing page > > walk. The VTDAddressSpace contains the aw bits information, meanwhile > > we'll need to do something

Re: [Qemu-devel] [PATCH v3 00/12] intel-iommu: nested vIOMMU, cleanups, bug fixes

On Thu, May 17, 2018 at 03:49:05PM -0400, Jintack Lim wrote: > On Thu, May 17, 2018 at 4:59 AM, Peter Xu wrote: > > (Hello, Jintack, Feel free to test this branch again against your scp > > error case when you got free time) > > Hi Peter, > > > > > I rewrote some of the

Re: [Qemu-devel] [PATCH v3 00/12] intel-iommu: nested vIOMMU, cleanups, bug fixes

On Fri, May 18, 2018 at 02:26:59PM +0800, Peter Xu wrote: [...] > I'll temporarily consider putting it at the last patch of series if no > one jumps out and tells me another more correct way. Also I'll > possibly make bold to append your suggested-by too to further claim

[Qemu-devel] [PPC64] P5020DS: Booting from img possible (-drive)?

|Hello, I was able to boot a Linux kernel (uImage) with an initrd in a virtual P5020DS PPC64 machine with an e5500 core (QEMU 2.12.0) with the following command. qemu-system-ppc64 -M ppce500 -cpu e5500 -m 2048 -initrd /home/christian/Downloads/slitaz25.gz -nographic -kernel

Re: [Qemu-devel] [PATCH v3 06/12] intel-iommu: pass in address space when page walk

Hi Peter, On 05/17/2018 10:59 AM, Peter Xu wrote: > We pass in the VTDAddressSpace too. It'll be used in the follow up > patches. So you evetually preferred to keep .aw. I don't have a strong opinion but maybe a small preference to v2 version. Nevertheless Reviewed-by: Eric Auger

Re: [Qemu-devel] [PATCH v3 01/12] intel-iommu: send PSI always even if across PDEs

Hi Peter, On 05/17/2018 10:59 AM, Peter Xu wrote: > During IOVA page table walking, there is a special case when the PSI > covers one whole PDE (Page Directory Entry, which contains 512 Page > Table Entries) or more. In the past, we skip that entry and we don't > notify the IOMMU notifiers.

[Qemu-devel] Ping? Re: [PATCH v6 2/2] iothread: let aio_epoll_disable fit to aio_context_destroy

Ping On 2018/5/17 14:48, WangJie (Pluto) wrote: > I enjoyed the great benefit of your suggestions, and I will improve next > time. :) > This time, I ask maintainers to touch up the commit message base on version 5 > and merge it, thanks very much. > > On 2018/5/17 14:22, Peter Xu wrote: >> On

[Qemu-devel] [PATCH v4 3/9] intel-iommu: add iommu lock

SECURITY IMPLICATION: this patch fixes a potential race when multiple threads access the IOMMU IOTLB cache. Add a per-iommu big lock to protect IOMMU status. Currently the only thing to be protected is the IOTLB/context cache, since that can be accessed even without BQL, e.g., in IO dataplane.

Re: [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

Cc'ing a few more people. Daniel Henrique Barboza writes: > When issuing the qmp/hmp 'system_wakeup' command, what happens in a > nutshell is: > > - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason > and notify the event > - in the main_loop, all

Re: [Qemu-devel] [PATCH v2 09/10] intel-iommu: don't unmap all for shadow page table

Hi Peter, On 05/18/2018 08:06 AM, Peter Xu wrote: > On Thu, May 17, 2018 at 07:23:33PM +0200, Auger Eric wrote: >> Hi Peter, >> >> On 05/04/2018 05:08 AM, Peter Xu wrote: >>> IOMMU replay was carried out before in many use cases, e.g., context >>> cache invalidations, domain flushes. We used

[Qemu-devel] [PATCH v4 6/9] intel-iommu: pass in address space when page walk

We pass in the VTDAddressSpace too. It'll be used in the follow up patches. CC: QEMU Stable Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index

Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

On Thu, May 17, 2018 at 02:41:09PM +0200, Eduardo Otubo wrote: On 15/05/2018 - 19:33:48, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger the guest startup fails. So this

[Qemu-devel] [PULL 1/2] ccid-card-passthru: fix regression in realize()

From: Marc-André Lureau Since cc847bfd16d894fd8c1a2ce25f31772f6cdbbc74, CCID card-passthru fails to intialize, because it changed a debug line to an error, probably by mistake. Change it back to a DPRINTF debug. (solves Boxes creating VM with smartcard passthru

Re: [Qemu-devel] [PATCH v3 05/12] intel-iommu: introduce vtd_page_walk_info

On 05/17/2018 10:59 AM, Peter Xu wrote: > During the recursive page walking of IOVA page tables, some stack > variables are constant variables and never changed during the whole page > walking procedure. Isolate them into a struct so that we don't need to > pass those contants down the stack

Re: [Qemu-devel] [PATCH 2/3] qemu-iotests: Filter NFS paths

Am 17.05.2018 um 18:52 hat Kevin Wolf geschrieben: > NFS paths were only partially filtered in _filter_img_create, _img_info > and _filter_img_info, resulting in "nfs://127.0.0.1TEST_DIR/t.IMGFMT". > This adds another replacement to the sed calls that matches $TEST_IMG as > a whole. > >

[Qemu-devel] [Bug 1771948] [NEW] aarch64 msr CNTFRQ_EL0

Public bug reported: Hello, I'm running qemu 2.12 on a raspberry pi 3 with the command: qemu-system-aarch64 -M raspi3 -serial stdio -kernel executable.bin On my start file (right in the beginning with the highest EL), the following instructions: ldr x0 , =1920 msr CNTFRQ_EL0, x0 and

[Qemu-devel] [PATCH v4 8/9] util: implement simple iova tree

Introduce a simplest iova tree implementation based on GTree. CC: QEMU Stable Signed-off-by: Peter Xu --- include/qemu/iova-tree.h | 134 +++ util/iova-tree.c | 114 +

Re: [Qemu-devel] [PATCH v2] riscv: remove define cpu_init()

On Fri, 18 May 2018 14:10:24 +1200 Michael Clark wrote: > On Wed, May 16, 2018 at 4:00 AM, Igor Mammedov wrote: > > > cpu_init() was removed since 2.12, so drop the define that is now unused. > > > > Signed-off-by: Igor Mammedov > >

Re: [Qemu-devel] [PATCH v3 00/12] intel-iommu: nested vIOMMU, cleanups, bug fixes

On Fri, May 18, 2018 at 12:08:01AM +0300, Michael S. Tsirkin wrote: > On Thu, May 17, 2018 at 04:59:15PM +0800, Peter Xu wrote: > > (Hello, Jintack, Feel free to test this branch again against your scp > > error case when you got free time) > > > > I rewrote some of the patches in V3. Major

Re: [Qemu-devel] [PATCH] sdl: Move use of surface pointer below check for whether it is NULL

On Tue, May 15, 2018 at 07:58:14PM +0100, Peter Maydell wrote: > In commit 2ab858c6c38ee1 we added a use of the 'surf' variable > in sdl2_2d_update() that was unfortunately placed above the > early-exit-if-NULL check. Move it to where it ought to be. Added to ui patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH] ui: add x_keymap.o to modules

On Thu, May 17, 2018 at 02:39:42PM +0200, Paolo Bonzini wrote: > x_keymap.o is common to the SDL and GTK+ modules, and it causes the > QEMU binary to link to the X11 libraries. Add it separately to the > modules to keep the main QEMU binary smaller. Added to ui patch queue. thanks, Gerd

[Qemu-devel] [PATCH v4 1/9] intel-iommu: send PSI always even if across PDEs

SECURITY IMPLICATION: without this patch, any guest with both assigned device and a vIOMMU might encounter stale IO page mappings even if guest has already unmapped the page. The stale mappings will only be limited to the guest's own memory range, so it should not affect the host memory or other

[Qemu-devel] [PATCH v4 2/9] intel-iommu: remove IntelIOMMUNotifierNode

That is not really necessary. Removing that node struct and put the list entry directly into VTDAddressSpace. It simplfies the code a lot. Since at it, rename the old notifiers_list into vtd_as_with_notifiers. CC: QEMU Stable Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH v2 05/10] intel-iommu: introduce vtd_page_walk_info

Hi Peter, On 05/18/2018 07:59 AM, Peter Xu wrote: > On Thu, May 17, 2018 at 04:32:58PM +0200, Auger Eric wrote: >> Hi Peter, >> >> On 05/04/2018 05:08 AM, Peter Xu wrote: >>> During the recursive page walking of IOVA page tables, some stack >>> variables are constant variables and never changed

[Qemu-devel] [PULL 2/2] hw/usb/dev-smartcard-reader: Handle 64 B USB packets

From: Jakub Jelen The current code was not correctly handling 64 B (Max USB 1.1 payload size) packets and therefore preventing some of the messages from smart card to pass through to the guest. If the smart card in host responded with 34 B of data in APDU layer, the CCID

[Qemu-devel] [PULL 0/2] Usb 20180518 patches

The following changes since commit a4207e3b00e89f934adb231057dcf9a75ac2ae45: Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into staging (2018-05-17 11:59:50 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/usb-20180518-pull-request

Re: [Qemu-devel] [PATCH v7 3/3] qmp.c: system_wakeup: runstate and wake-up support check

This affects both QMP and HMP. Let's rephrase the title to qmp hmp: Make system_wakeup check wake-up support and run state Can do that in my tree. Daniel Henrique Barboza writes: > The qmp/hmp command 'system_wakeup' is simply a direct call to >

Re: [Qemu-devel] [PATCH v2 05/10] intel-iommu: introduce vtd_page_walk_info

On Thu, May 17, 2018 at 04:32:58PM +0200, Auger Eric wrote: > Hi Peter, > > On 05/04/2018 05:08 AM, Peter Xu wrote: > > During the recursive page walking of IOVA page tables, some stack > > variables are constant variables and never changed during the whole page > > walking procedure. Isolate

Re: [Qemu-devel] [PATCH v3 00/12] intel-iommu: nested vIOMMU, cleanups, bug fixes

On Fri, May 18, 2018 at 12:04:04AM +0300, Michael S. Tsirkin wrote: > On Thu, May 17, 2018 at 04:59:15PM +0800, Peter Xu wrote: > > (Hello, Jintack, Feel free to test this branch again against your scp > > error case when you got free time) > > > > I rewrote some of the patches in V3. Major

[Qemu-devel] [PATCH v4 0/9] intel-iommu: nested vIOMMU, cleanups, bug fixes

Upstream repo: https://github.com/xzpeter/qemu/tree/fix-vtd-dma This version contains little functional changes, mostly comment-wise and patch squashings. I squashed the last 4 patches since they are solving the same problem, meanwhile the old patch 9 itself might brought some problem if without

[Qemu-devel] [PATCH v4 9/9] intel-iommu: rework the page walk logic

SECURITY IMPLICATION: this patch will fix a potential small window that the DMA page table might be incomplete or invalid when the guest sends domain/context invalidations to a device. It can cause random DMA errors for assigned devices. This is a major change to the VT-d shadow page walking

[Qemu-devel] [PATCH v4 5/9] intel-iommu: introduce vtd_page_walk_info

During the recursive page walking of IOVA page tables, some stack variables are constant variables and never changed during the whole page walking procedure. Isolate them into a struct so that we don't need to pass those contants down the stack every time and multiple times. CC: QEMU Stable

Re: [Qemu-devel] [PATCH v2 04/10] intel-iommu: only do page walk for MAP notifiers

Hi Peter, On 05/18/2018 07:53 AM, Peter Xu wrote: > On Thu, May 17, 2018 at 03:39:50PM +0200, Auger Eric wrote: >> Hi Peter, >> >> On 05/04/2018 05:08 AM, Peter Xu wrote: >>> For UNMAP-only IOMMU notifiers, we don't really need to walk the page >> s/really// ;-) > > Ok. > >>> tables. Fasten

Re: [Qemu-devel] [PATCH] ccid-card-passthru: fix regression in realize()

On Tue, May 15, 2018 at 05:30:39PM +0200, Marc-André Lureau wrote: > Since cc847bfd16d894fd8c1a2ce25f31772f6cdbbc74, CCID card-passthru > fails to intialize, because it changed a debug line to an error, > probably by mistake. Change it back to a DPRINTF debug. > > (solves Boxes creating VM with

[Qemu-devel] [PULL 3/3] sdl: Move use of surface pointer below check for whether it is NULL

From: Peter Maydell In commit 2ab858c6c38ee1 we added a use of the 'surf' variable in sdl2_2d_update() that was unfortunately placed above the early-exit-if-NULL check. Move it to where it ought to be. Fixes: Coverity CID 1390598 Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH v4 32/49] tests/tcg/arm: add fcvt test cases for AArch32/64

Philippe Mathieu-Daudé writes: > On 05/17/2018 05:30 PM, Richard Henderson wrote: >> On 05/17/2018 10:47 AM, Alex Bennée wrote: >>> This runs through the usual float to float conversions and crucially >>> also runs with ARM Alternative Half Precision Format. >>> >>>

Re: [Qemu-devel] [PATCH 1/2] qapi: allow flat unions with empty branches

On 18/5/2018 9:45 AM, Markus Armbruster wrote: Eric Blake writes: On 05/17/2018 03:05 AM, Markus Armbruster wrote: QAPI language design alternatives: 1. Having unions cover all discriminator values explicitly is useful. 2. Having unions repeat all the discriminator

Re: [Qemu-devel] [PULL 10/40] migration: Delay start of migration main routines

Am 16.05.2018 um 01:39 hat Juan Quintela geschrieben: > We need to make sure that we have started all the multifd threads. > > Signed-off-by: Juan Quintela > Reviewed-by: Daniel P. Berrangé This commit makes qemu-iotests 091 hang for me. Either it

[Qemu-devel] [PULL 0/2] Docker and block patches

The following changes since commit a4207e3b00e89f934adb231057dcf9a75ac2ae45: Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into staging (2018-05-17 11:59:50 +0100) are available in the Git repository at: git://github.com/famz/qemu.git

Re: [Qemu-devel] [PATCH v3 3/3] xen-hvm: try to use xenforeignmemory_map_resource() to map ioreq pages

On Tue, May 15, 2018 at 05:40:53PM +0100, Paul Durrant wrote: > Xen 4.11 has a new API to directly map guest resources. Among the resources > that can be mapped using this API are ioreq pages. > > This patch modifies QEMU to attempt to use the new API should it exist, > falling back to the

Re: [Qemu-devel] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEMU

On 15 May 2018 at 15:46, Richard Henderson wrote: > On 05/15/2018 06:25 AM, Peter Maydell wrote: >> That said, I think we're planning to deprecate vixl now we have the >> capstone support. Richard, what's the status here? Could we just remove >> the vixl code now? > > We could

Re: [Qemu-devel] [PATCH v3-a 00/27] target/arm: Scalable Vector Extension

On 16 May 2018 at 23:29, Richard Henderson wrote: > This is the first third, more or less, of my current patch set. > I'm sending only this portion now, rather than another monster > set all at once. > > The major change is to move the call to sve_access_check inside

Re: [Qemu-devel] [PATCH v5 4/4] monitor: add lock to protect mon_fdsets

Peter Xu writes: > On Thu, May 17, 2018 at 03:03:02PM +0200, Markus Armbruster wrote: > > [...] > >> > @@ -2502,7 +2525,9 @@ int monitor_fdset_get_fd(int64_t fdset_id, int flags) >> > MonFdset *mon_fdset; >> > MonFdsetFd *mon_fdset_fd; >> > int mon_fd_flags; >>

[Qemu-devel] [PATCH v3 4/4] OvmfPkg/PlatformBootManagerLib: process TPM PPI request

From: Marc-André Lureau Call Tcg2PhysicalPresenceLibProcessRequest() to process pending PPI requests from PlatformBootManagerAfterConsole(). Laszlo understanding of edk2 is that the PPI operation processing was meant to occur *entirely* before End-Of-Dxe, so that

Re: [Qemu-devel] Ping? Re: [PATCH v6 2/2] iothread: let aio_epoll_disable fit to aio_context_destroy

On Fri, 05/18 16:24, WangJie (Pluto) wrote: > Ping I'll send a pull request with v5. Fam

Re: [Qemu-devel] [PATCH] xen-hvm: stop faking I/O to access PCI config space

> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 17 May 2018 17:31 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org; Stefano > Stabellini ; Michael S. Tsirkin

Re: [Qemu-devel] [RFC PATCH 2/2] tests/Makefile: comment out flakey tests

On 18 May 2018 at 10:14, Alex Bennée wrote: > The following tests keep showing up in failed Travis runs: > > - test-aio > - rcutorture > - tpm-crb-test > - tpm-tis-test > > I suspect it is load that causes the problems but they really need to > be fixed properly.

Re: [Qemu-devel] [PULL 10/40] migration: Delay start of migration main routines

* Kevin Wolf (kw...@redhat.com) wrote: > Am 16.05.2018 um 01:39 hat Juan Quintela geschrieben: > > We need to make sure that we have started all the multifd threads. > > > > Signed-off-by: Juan Quintela > > Reviewed-by: Daniel P. Berrangé > > This

Re: [Qemu-devel] [RFC PATCH 2/2] tests/Makefile: comment out flakey tests

On Fri, May 18, 2018 at 10:14:40AM +0100, Alex Bennée wrote: > The following tests keep showing up in failed Travis runs: > > - test-aio What is the issue? signature.asc Description: PGP signature

[Qemu-devel] [PPC64] P5020DS: Booting from img possible (-drive)?

It works on my AmigaOne X5000 (P5020 board with 2x e5500 cores). Screenshots: https://plus.google.com/115515624056477014971 — Christian Sent from my iPhone > On 18. May 2018, at 10:54, Thomas Huth wrote: > >> On 18.05.2018 08:01, Christian Zigotzky wrote: >> Hello, >> >>

Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

On 18/05/2018 - 09:52:12, Ján Tomko wrote: > On Thu, May 17, 2018 at 02:41:09PM +0200, Eduardo Otubo wrote: > > On 15/05/2018 - 19:33:48, Yi Min Zhao wrote: > > > If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains > > > compiled. This would make libvirt set the corresponding

Re: [Qemu-devel] [PATCH v5 1/4] monitor: rename out_lock to mon_lock

On Thu, May 17, 2018 at 02:32:34PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > The out_lock was only protecting a few Monitor fields. In the future > > "was protecting"? When? Or do you mean "is protecting"? Yes - "is protecting". > > > the monitor code

Re: [Qemu-devel] [PATCH v4 1/9] xen: add a meaningful declaration of grant_copy_segment into xen_common.h

On Thu, May 17, 2018 at 04:35:50PM +0100, Paul Durrant wrote: > Currently the xen_disk source has to carry #ifdef exclusions to compile > against Xen older then 4.8. This is a bit messy so this patch lifts the > definition of struct xengnttab_grant_copy_segment and adds it into the > pre-4.8

Re: [Qemu-devel] [PATCH 0/5] NBD reconnect: preliminary refactoring

17.05.2018 16:48, Eric Blake wrote: On 05/17/2018 04:54 AM, Vladimir Sementsov-Ogievskiy wrote: What about patches 1-4? Still on my list to review (I'm first trying to post an updated proposal on the libvirt list for managing incremental backups); but on first glance, the idea of being able

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 36/49] tests/tcg: enable building for s390x

On 17.05.2018 19:47, Alex Bennée wrote: > This doesn't add any additional tests but enables building the > multiarch tests for s390x. > > Signed-off-by: Alex Bennée > Acked-by: Cornelia Huck > Reviewed-by: Philippe Mathieu-Daudé >

Re: [Qemu-devel] [PPC64] P5020DS: Booting from img possible (-drive)?

On Fri, 18 May 2018 13:50:42 +0200 Christian Zigotzky wrote: > On 18 May 2018 at 1:13PM, Greg Kurz wrote: > > And of course your kernel should be built with virtio support. > I think I have enabled virtio support. Please find attached my kernel > config. > Indeed, what

[Qemu-devel] [PATCH v3 3/4] OvmfPkg: add Tcg2PhysicalPresenceLibQemu

From: Marc-André Lureau Cloned "SecurityPkg/Library/DxeTcg2PhysicalPresenceLib" and: - removed all the functions that are unreachable from Tcg2PhysicalPresenceLibProcessRequest() [called from platform BDS], or SubmitRequestToPreOSFunction() and

[Qemu-devel] [RFC PATCH 2/2] tests/Makefile: comment out flakey tests

The following tests keep showing up in failed Travis runs: - test-aio - rcutorture - tpm-crb-test - tpm-tis-test I suspect it is load that causes the problems but they really need to be fixed properly. Signed-off-by: Alex Bennée --- tests/Makefile.include | 8

Re: [Qemu-devel] [PULL 00/41] Migration queue

On 18 May 2018 at 11:19, Peter Maydell wrote: > On 11 May 2018 at 14:41, Peter Maydell wrote: >> Hi. I get some test failures here: >> >> S390x host: >> TEST: tests/migration-test... (pid=57456) >> /ppc64/migration/deprecated:

[Qemu-devel] [PATCH v6 2/4] monitor: protect mon->fds with mon_lock

mon->fds were protected by BQL. Now protect it by mon_lock so that it can even be used in monitor iothread. Reviewed-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Peter Xu --- monitor.c | 22 ++

Re: [Qemu-devel] [PATCH v4 21/49] tests/tcg/i386: add runner for test-i386-fprem

On 17/05/2018 19:46, Alex Bennée wrote: > The runner needs to compare against a reference run. We also only run > this test when SPEED=slow as it takes a while. > > Signed-off-by: Alex Bennée > --- > tests/tcg/i386/Makefile.target | 11 +++ >

[Qemu-devel] [PATCH v2 1/2] target/arm: support reading of CNT[VCT|FRQ]_EL0 from user-space

Since kernel commit a86bd139f2 (arm64: arch_timer: Enable CNTVCT_EL0 trap..) user-space has been able to read these system registers. As we can't use QEMUTimer's in linux-user mode we just directly call cpu_get_clock(). Signed-off-by: Alex Bennée --- v2 - include

[Qemu-devel] [PATCH v3 1/4] OvmfPkg: add Tcg2PhysicalPresenceLibNull when !TPM2_ENABLE

From: Marc-André Lureau This NULL library will let us call Tcg2PhysicalPresenceLibProcessRequest() unconditionally from BdsPlatform when building without TPM2_ENABLE. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [qemu PATCH v2 0/4] support NFIT platform capabilities

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180517050024.20101-1-ross.zwis...@linux.intel.com Subject: [Qemu-devel] [qemu PATCH v2 0/4] support NFIT platform capabilities === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [RFC PATCH 0/2] Travis Stability Patches

Hi, The Sisyphean task of keeping our CI stable continues. The first patch is simple as it reduces the build to prevent us timing out. The second patch isn't meant for merging but as far as I can tell covers all the regular tests that fail on Travis. I would be grateful if the test authors could

Re: [Qemu-devel] [PPC64] P5020DS: Booting from img possible (-drive)?

On 18.05.2018 11:06, Christian Zigotzky wrote: > It works on my AmigaOne X5000 (P5020 board with 2x e5500 cores). > > Screenshots: https://plus.google.com/115515624056477014971 Interesting ... but you still use your own kernel, and not the stock Ubuntu kernel, right? That would explain how this

Re: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs

On Thu, May 17, 2018 at 02:46:36PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Add some explicit comment for both Readline and cpu_set/cpu_get helpers > > that they do not need the mon_lock protection. > > Appreciated! > > > Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH v4 2/9] xen_backend: add grant table helpers

On Thu, May 17, 2018 at 04:35:51PM +0100, Paul Durrant wrote: > This patch adds grant table helper functions to the xen_backend code to > localize error reporting and use of xen_domid. > > The patch also defers the call to xengnttab_open() until just before the > initialise method in XenDevOps is

Re: [Qemu-devel] [PATCH v4 5/9] xen_backend: add an emulation of grant copy

On Thu, May 17, 2018 at 04:35:54PM +0100, Paul Durrant wrote: > Not all Xen environments support the xengnttab_grant_copy() operation. > E.g. where the OS is FreeBSD or Xen is older than 4.8.0. > > This patch introduces an emulation of that operation using > xengnttab_map_domain_grant_refs() and

[Qemu-devel] [PATCH v2 2/2] tests/tcg/aarch64: userspace system register test

Signed-off-by: Alex Bennée --- tests/tcg/aarch64/Makefile.target | 2 +- tests/tcg/aarch64/sysregs.c | 14 ++ 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 tests/tcg/aarch64/sysregs.c diff --git

Re: [Qemu-devel] [PATCH] pnv: add a physical mapping array describing MMIO ranges in each chip

On Thu, 17 May 2018 15:18:14 +0200 Cédric Le Goater wrote: > Based on previous work done in skiboot, the physical mapping array > helps in calculating the MMIO ranges of each controller depending on > the chip id and the chip type. This is will be particularly useful for > the P9

Re: [Qemu-devel] [PULL v2 00/28] softfloat patch roundup

On 17 May 2018 at 23:49, Richard Henderson wrote: > V2 fixing the two erroneous uses of get_fpstatus_ptr > within the aa32 translator in patch 9. > > Only reposting 9/28 here. > > > r~ > > > > The following changes since commit

Re: [Qemu-devel] [PATCH v5 4/4] monitor: add lock to protect mon_fdsets

On Thu, May 17, 2018 at 03:03:02PM +0200, Markus Armbruster wrote: [...] > > @@ -2502,7 +2525,9 @@ int monitor_fdset_get_fd(int64_t fdset_id, int flags) > > MonFdset *mon_fdset; > > MonFdsetFd *mon_fdset_fd; > > int mon_fd_flags; > > +int ret = -1; > > Suggest not to

[Qemu-devel] [PATCH v6 1/4] monitor: rename out_lock to mon_lock

The out_lock is protecting a few Monitor fields. In the future the monitor code will start to run in multiple threads. We are going to turn it into a bigger lock to protect not only the out buffer but also all the rest. Since at it, rearrange the Monitor struct a bit. Reviewed-by: Stefan

[Qemu-devel] [PATCH v6 0/4] monitor: let Monitor be thread safe

v6: - add/drop some r-bs - address all the comments from Markus - rebase, and run some simple qtests to make sure nothing breaks v5: - collect r-bs and rebase - move two close()s outside critical section [Dave] - move comment to end of line [Stefan] v4: - fix a s/cur_mon/mon/ typo v3: - add

[Qemu-devel] [PATCH v6 3/4] monitor: more comments on lock-free fleids/funcs

Add some explicit comment for both Readline and cpu_set/cpu_get helpers that they do not need the mon_lock protection. Signed-off-by: Peter Xu --- monitor.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index

[Qemu-devel] [PATCH v6 4/4] monitor: add lock to protect mon_fdsets

Similar to previous patch, but introduce a new global big lock for mon_fdsets. Take it where needed. The monitor_fdset_get_fd() handling is a bit tricky: now we need to call qemu_mutex_unlock() which might pollute errno, so we need to make sure the correct errno be passed up to the callers.

Re: [Qemu-devel] [PATCH v4 18/49] tests/tcg: enable building for i386

On 17/05/2018 19:46, Alex Bennée wrote: > + > +# Specialist test runners > +.PHONY: pi_10.com > +pi_10.com: > + cp $(I386_SRC)/pi_10.com . > + > +run-runcom: runcom pi_10.com > + $(call quiet-command, $(QEMU) ./runcom ./pi_10.com > runcom.out, > "TEST", "$< on $(TARGET_NAME)") > + Why

[Qemu-devel] [PATCH v3 2/4] OvmfPkg/IndustryStandard: add QemuTpm.h header

From: Marc-André Lureau Add some common macros and type definitions corresponding to the QEMU TPM interface. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marc-André Lureau Acked-by: Laszlo Ersek

Re: [Qemu-devel] [PATCH v3 0/4] RFC: ovmf: Add support for TPM Physical Presence interface

On 05/18/2018 08:23 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Hi, The following series adds basic TPM PPI 1.3 support for OVMF-on-QEMU with TPM2 (I haven't looked at TPM1, for lack of interest). PPI test runs successfully with Windows 10

[Qemu-devel] [PULL 1/2] docker: Fix trivial typo

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180508144358.13530-1-f4...@amsat.org> Reviewed-by: Laurent Vivier Signed-off-by: Fam Zheng --- tests/docker/Makefile.include | 2 +- 1 file

[Qemu-devel] [PULL 2/2] iothread: fix epollfd leak in the process of delIOThread

From: Jie Wang When we call addIOThread, the epollfd created in aio_context_setup, but not close it in the process of delIOThread, so the epollfd will leak. Reorder the code in aio_epoll_disable and reuse it. Signed-off-by: Jie Wang Message-Id:

Re: [Qemu-devel] [PPC64] P5020DS: Booting from img possible (-drive)?

On 18 May 2018 at 11:24PM, Thomas Huth wrote: On 18.05.2018 11:06, Christian Zigotzky wrote: It works on my AmigaOne X5000 (P5020 board with 2x e5500 cores). Screenshots: https://plus.google.com/115515624056477014971 Interesting ... but you still use your own kernel, and not the stock Ubuntu

[Qemu-devel] [PATCH v2 0/2] support reading of CNT[VCT|FRQ]_EL0 from user-space

Hi, The second patch won't build on master until the tcg testing revival is merged but I've included it for reference. Alex. Alex Bennée (2): target/arm: support reading of CNT[VCT|FRQ]_EL0 from user-space tests/tcg/aarch64: userspace system register test target/arm/helper.c

Re: [Qemu-devel] [PULL 0/3] Ui 20180518 patches

are available in the git repository at: > > git://git.kraxel.org/qemu tags/ui-20180518-pull-request > > for you to fetch changes up to e8dcb8ae5121965ac8c89e6b277ac127e9d08452: > > sdl: Move use of surface pointer below check for whethe

Re: [Qemu-devel] [PULL 10/40] migration: Delay start of migration main routines

Am 18.05.2018 um 12:34 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kw...@redhat.com) wrote: > > Am 16.05.2018 um 01:39 hat Juan Quintela geschrieben: > > > We need to make sure that we have started all the multifd threads. > > > > > > Signed-off-by: Juan Quintela

[Qemu-devel] [PATCH v3 0/4] RFC: ovmf: Add support for TPM Physical Presence interface

From: Marc-André Lureau Hi, The following series adds basic TPM PPI 1.3 support for OVMF-on-QEMU with TPM2 (I haven't looked at TPM1, for lack of interest). PPI test runs successfully with Windows 10 WHLK, despite the limited number of supported funcions

  1   2   3   4   >