[Qemu-devel] [PATCH v3 6/7] hmp: add exit_preconfig

2018-06-08 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add the exit_preconfig command to return to normality. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Reviewed-by: Igor Mammedov --- hmp-commands.hx | 15 +++ hmp.c | 7 +++ hmp.h | 1 + 3 files changed, 23

Re: [Qemu-devel] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig

2018-06-08 Thread Eduardo Habkost
On Thu, Jun 07, 2018 at 02:00:09PM +0200, Igor Mammedov wrote: > When using --daemonize, the initial lead process will fork a child and > then wait to be notified that setup is complete via a pipe, before it > exits. When using --preconfig there is an extra call to main_loop() > before the

[Qemu-devel] [PATCH v3 0/3] glib: update the min required version

2018-06-08 Thread Daniel P . Berrangé
The previous patch to bump glib to 2.42 hit problems with Peter's build environment for testing merge: https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg02557.html This posting drops back to 2.40, which allows Ubuntu 14.04 from GLibC compile farm to be supported. It does NOT try to go

Re: [Qemu-devel] [PATCH v3 3/5] nbd/server: implement dirty bitmap export

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
23.05.2018 13:24, Vladimir Sementsov-Ogievskiy wrote: Handle new NBD meta namespace: "qemu", and corresponding queries: "qemu:dirty-bitmap:". With new metadata context negotiated, BLOCK_STATUS query will reply with dirty-bitmap data, converted to extents. New public function nbd_export_bitmap

[Qemu-devel] [PATCH] hw/pvrdma: Bugfix - provide the correct attr_mask to query_qp

2018-06-08 Thread Yuval Shaia
Calling rdma_rm_query_qp with attr_mask equals to -1 leads to error where backend query_qp fails to retrieve the needed QP attributes. Fix it by providing the attr_mask we got from driver. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_cmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Philippe Mathieu-Daudé
On 06/08/2018 11:40 AM, Daniel P. Berrangé wrote: > On Fri, Jun 08, 2018 at 11:37:36AM -0300, Philippe Mathieu-Daudé wrote: >> Cc'ing Eric >> >> On 06/08/2018 11:30 AM, Eduardo Habkost wrote: >>> All of the supported build platforms documented in qemu-doc.texi >>> should already support Python

Re: [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files

2018-06-08 Thread Eric Blake
On 06/07/2018 05:31 PM, Ross Zwisler wrote: With a fully built QEMU I currently see the following with "git status": Untracked files: (use "git add ..." to include in what will be committed) qapi/qapi-commands-job.c qapi/qapi-commands-job.h

Re: [Qemu-devel] [PATCH v4 04/14] pc: prepare for multi stage hotplug handlers

2018-06-08 Thread Michael S. Tsirkin
On Fri, Jun 08, 2018 at 03:07:53PM +0200, David Hildenbrand wrote: > On 08.06.2018 14:55, Michael S. Tsirkin wrote: > > On Fri, Jun 08, 2018 at 02:32:09PM +0200, David Hildenbrand wrote: > >> > > if (TYPE_PC_DIMM) { > > pc_dimm_plug() > > /* do here additional concrete machine

[Qemu-devel] [PATCH v4 1/6] nbd/server: fix trace

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
Return code = 1 doesn't mean that we parsed base:allocation. Use correct traces in both -parsed and -skipped cases. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index

[Qemu-devel] [PATCH v4 0/6] NBD export

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
Hi all. This is a proposal and realization of new NBD meta context: qemu. New possible queries will look like: qemu:dirty-bitmap: Mapping from export-bitmap-name to BdrvDirtyBitmap is done through qmp command nbd-server-add-bitmap. For now, only one bitmap export is allowed per NBD export,

[Qemu-devel] [PATCH v4 3/6] nbd/server: add nbd_meta_empty_or_pattern helper

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
Add nbd_meta_pattern() and nbd_meta_empty_or_pattern() helpers for metadata query parsing. nbd_meta_pattern() will be reused for "qemu" namespace in following patches. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 86 +---

Re: [Qemu-devel] [PATCH] chardev: Restore CR,LF on stdio

2018-06-08 Thread Peter Maydell
On 8 June 2018 at 06:47, Thomas Huth wrote: > On 07.06.2018 23:08, Philippe Mathieu-Daudé wrote: >> Remove the 'stair-step output' on stdio. >> >> This partially reverts commit 12fb0ac05, which was correct >> on the mailing list but got corrupted by the maintainer :p >> >> Introduced-by:

Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch

2018-06-08 Thread Michael S. Tsirkin
On Fri, Jun 08, 2018 at 07:17:51AM +0200, Thomas Huth wrote: > On 08.06.2018 01:09, Michael S. Tsirkin wrote: > > On Thu, Jun 07, 2018 at 04:31:08PM -0600, Ross Zwisler wrote: > >> Currently if "make check" detects a mismatch in the ASL generated during > >> testing, we print an error such as: >

Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig

2018-06-08 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > * Markus Armbruster (arm...@redhat.com) wrote: >> >> "Dr. David Alan Gilbert" writes: >> >> >> >> > * Markus Armbruster (arm...@redhat.com) wrote: >> >> >> Peter Xu

[Qemu-devel] [PATCH 4/8] authz: add QAuthZSimple object type for trivial auth checks

2018-06-08 Thread Daniel P . Berrangé
In many cases a single VM will just need to whilelist a single identity as the allowed user of network services. This is especially the case for TLS live migration (optionally with NBD storage) where we just need to whitelist the x509 certificate distinguished name of the source QEMU host.

[Qemu-devel] [PATCH 1/8] util: add helper APIs for dealing with inotify

2018-06-08 Thread Daniel P . Berrangé
The inotify userspace API for reading events is quite horrible, so it is useful to wrap it in a more friendly API to avoid duplicating code across many users in QEMU. Signed-off-by: Daniel P. Berrangé --- MAINTAINERS| 6 ++ include/qemu/inotify.h | 49 +++

Re: [Qemu-devel] [PATCH v2 3/6] spapr: move memory hotplug support check into spapr_memory_pre_plug()

2018-06-08 Thread Greg Kurz
On Fri, 8 Jun 2018 14:48:13 +0200 David Hildenbrand wrote: > Let's finish cleaning up the hotplug handler. This check can be > performed in the pre_plug code as the very first thing. > > Signed-off-by: David Hildenbrand > --- > hw/ppc/spapr.c | 13 ++--- > 1 file changed, 6

[Qemu-devel] [PATCH v3 1/3] util: remove redundant include of glib.h and add osdep.h

2018-06-08 Thread Daniel P . Berrangé
Code must only ever include glib.h indirectly via the glib-compat.h header file, because we will need some macros set before glib.h is pulled in. Adding extra includes of glib.h will (soon) cause compile failures such as: In file included from

[Qemu-devel] [Bug 1463909] Re: virtio: networking not working when guest's eth0 is not in promiscuous mode

2018-06-08 Thread Thomas Huth
** Project changed: qemu => qemu (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1463909 Title: virtio: networking not working when guest's eth0 is not in promiscuous mode Status in qemu

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 0/7] sdcard: cleanup the SD_SPEC version

2018-06-08 Thread Philippe Mathieu-Daudé
On 06/08/2018 09:14 AM, Peter Maydell wrote: > On 7 June 2018 at 19:06, Philippe Mathieu-Daudé wrote: >> Since v2: >> - heavy documentation improvements >> - squashed previous 3+4 "add spec_version property default to v2" for >> atomicity >> - SSI/SD patch downgraded to RFC >> - added Alistair

Re: [Qemu-devel] [RFC v2 03/12] vhost-user: wrap some read/write with retry handling

2018-06-08 Thread Philippe Mathieu-Daudé
On 06/01/2018 01:27 PM, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé > --- > hw/virtio/vhost-user.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c >

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Eduardo Habkost
On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote: > All of the supported build platforms documented in qemu-doc.texi > should already support Python 2.7. > > Removing support for Python 2.6 will allow us to remove some > compatibility modules we carry in the QEMU tree: > > *

Re: [Qemu-devel] [PATCH] block/qcow2: save dirty_bitmaps_loaded during reopen

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
08.06.2018 15:32, Vladimir Sementsov-Ogievskiy wrote: This variable was introduced to handle reopens. We need it on the following qcow2_do_open, to don't try load bitmaps again. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch

2018-06-08 Thread Michael S. Tsirkin
On Fri, Jun 08, 2018 at 09:34:02AM -0600, Ross Zwisler wrote: > On Fri, Jun 08, 2018 at 07:17:51AM +0200, Thomas Huth wrote: > > On 08.06.2018 01:09, Michael S. Tsirkin wrote: > > > On Thu, Jun 07, 2018 at 04:31:08PM -0600, Ross Zwisler wrote: > > >> Currently if "make check" detects a mismatch in

Re: [Qemu-devel] [PATCH] chardev: Restore CR,LF on stdio

2018-06-08 Thread Patryk Olszewski
W dniu 08.06.2018 o 17:25, Peter Maydell pisze: > On 8 June 2018 at 06:47, Thomas Huth wrote: >> On 07.06.2018 23:08, Philippe Mathieu-Daudé wrote: >>> Remove the 'stair-step output' on stdio. >>> >>> This partially reverts commit 12fb0ac05, which was correct >>> on the mailing list but got

Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch

2018-06-08 Thread Michael S. Tsirkin
On Fri, Jun 08, 2018 at 05:14:09PM +0100, Peter Maydell wrote: > On 8 June 2018 at 16:59, Michael S. Tsirkin wrote: > > The expected value tests are a debugging aid. They do not catch bugs and > > aren't designed to. In particular the comparisons do not even run if > > IASL isn't installed. > >

Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch

2018-06-08 Thread Michael S. Tsirkin
On Fri, Jun 08, 2018 at 05:16:30PM +0100, Peter Maydell wrote: > On 8 June 2018 at 17:03, Michael S. Tsirkin wrote: > > Pull requests are somewhat different, they are usually tested for lack > > of warnings. This change didn't arrive as a result of a pull request > > maybe that's why it slipped

Re: [Qemu-devel] [Qemu-block] Some question about savem/qcow2 incremental snapshot

2018-06-08 Thread Pankaj Gupta
> Hi Junyan, Just want to add in same email thread there is discussion by Stefan & Kevin describing ways of handling NVDIMM similar to block device with the pros & cons of the approach. In light of that we have to consider this as memory but support of qcow2 is required for snapshot,

[Qemu-devel] [PATCH 3/8] authz: add QAuthZ object as an authorization base class

2018-06-08 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The current qemu_acl module provides a simple access control list facility inside QEMU, which is used via a set of monitor commands acl_show, acl_policy, acl_add, acl_remove & acl_reset. Note there is no ability to create ACLs - the network services (eg VNC server)

Re: [Qemu-devel] [PATCH v2 3/4] hw/arm/sysbus-fdt: Replace error_setg(_fatal) by error_report() + exit()

2018-06-08 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Use error_report() + exit() instead of error_setg(_fatal), > as suggested by the "qapi/error.h" documentation: > >Please don't error_setg(_fatal, ...), use error_report() and >exit(), because that's more obvious. > > This fixes CID 1352173: > "Passing

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 2/8] spapr: no need to verify the node

2018-06-08 Thread Thomas Huth
On 08.06.2018 09:48, David Hildenbrand wrote: > On 08.06.2018 09:46, Greg Kurz wrote: >> On Fri, 8 Jun 2018 09:42:48 +0200 >> David Hildenbrand wrote: >> >>> On 08.06.2018 09:34, Greg Kurz wrote: On Thu, 7 Jun 2018 18:52:12 +0200 David Hildenbrand wrote: > The node

[Qemu-devel] [PATCH v8 1/6] bitmap: bitmap_count_one_with_offset

2018-06-08 Thread Wei Wang
Count the number of 1s in a bitmap starting from an offset. Signed-off-by: Wei Wang CC: Dr. David Alan Gilbert CC: Juan Quintela CC: Michael S. Tsirkin Reviewed-by: Dr. David Alan Gilbert --- include/qemu/bitmap.h | 13 + 1 file changed, 13 insertions(+) diff --git

[Qemu-devel] [PATCH v8 5/6] migration: move migrate_postcopy() to include/migration/misc.h

2018-06-08 Thread Wei Wang
The ram save state notifier callback, for example the free page optimization offerred by virtio-balloon, may need to check if postcopy is in use, so move migrate_postcopy() to the outside header. Signed-off-by: Wei Wang CC: Dr. David Alan Gilbert CC: Juan Quintela CC: Michael S. Tsirkin CC:

Re: [Qemu-devel] storing machine data in qcow images?

2018-06-08 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Fri, Jun 08, 2018 at 09:21:30AM +0100, Dr. David Alan Gilbert wrote: > > * Laszlo Ersek (ler...@redhat.com) wrote: > > > On 06/07/18 12:54, Andrea Bolognani wrote: > > > > On Thu, 2018-06-07 at 11:36 +0100, Daniel P. Berrangé wrote: > > > >>

Re: [Qemu-devel] [PATCH] typedefs: add QJSON

2018-06-08 Thread Dr. David Alan Gilbert
* Greg Kurz (gr...@kaod.org) wrote: > Since commit 83ee768d6247b, we now have two places that define the > QJSON type: > > $ git grep 'typedef struct QJSON QJSON' > include/migration/vmstate.h:typedef struct QJSON QJSON; > migration/qjson.h:typedef struct QJSON QJSON; > > This breaks

[Qemu-devel] [PATCH v3 6/6] bochs-display: enable vgabios

2018-06-08 Thread Gerd Hoffmann
--- hw/display/bochs-display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c index 1187d77576..12d8a66c6c 100644 --- a/hw/display/bochs-display.c +++ b/hw/display/bochs-display.c @@ -337,6 +337,7 @@ static void

[Qemu-devel] [PATCH v3 2/6] hw/display: add standalone ramfb device

2018-06-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/hw/display/ramfb.h| 3 +++ hw/arm/sysbus-fdt.c | 7 + hw/arm/virt.c | 2 ++ hw/display/ramfb-standalone.c | 62 +++ hw/i386/pc_piix.c | 2 ++ hw/i386/pc_q35.c

[Qemu-devel] [PATCH v3 4/6] hw/vfio/display: add ramfb support

2018-06-08 Thread Gerd Hoffmann
So we have a boot display when using a vgpu as primary display. Use vfio-pci-ramfb instead of vfio-pci to enable it. Signed-off-by: Gerd Hoffmann --- include/hw/vfio/vfio-common.h | 2 ++ hw/vfio/display.c | 10 ++ hw/vfio/pci.c | 15 +++ 3

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-08 Thread Cornelia Huck
On Fri, 8 Jun 2018 15:13:28 +0200 Halil Pasic wrote: > On 06/08/2018 02:20 PM, Cornelia Huck wrote: > >>> My proposal is to do the same > >>> copying to scsw(r) again, which would mean we get a request with both > >>> the halt and the start bit set. The vfio code now needs to do a hsch > >>>

[Qemu-devel] [Bug 1708462] Re: Support Python 3 to build

2018-06-08 Thread Eduardo Habkost
The series mentioned in comment #3 was merged in v2.12.0, see commit c21965a0c8b979c306e927f158257e5b0fa3a1f9. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [RFC v2 05/12] vhost-user: split vhost_user_read()

2018-06-08 Thread Philippe Mathieu-Daudé
On 06/01/2018 01:27 PM, Marc-André Lureau wrote: > Split vhost_user_read(), so only header can be read with > vhost_user_read_header(). > > Signed-off-by: Marc-André Lureau > --- > hw/virtio/vhost-user.c | 27 +++ > 1 file changed, 19 insertions(+), 8 deletions(-) > >

Re: [Qemu-devel] [PATCH 00/11] misc: Add trailing '\n' to qemu_log() calls

2018-06-08 Thread John Snow
On 06/08/2018 06:54 AM, Peter Maydell wrote: > On 6 June 2018 at 20:43, John Snow wrote: >> so error_setg must be used WITHOUT \n and logging must happen with \n? >> >> If we're sure that's the way we want to have things laid out, we really >> ought to augment checkpatch to catch this --

[Qemu-devel] [PATCH v4 6/6] docs/interop: add nbd.txt

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
Describe new metadata namespace: "qemu". Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/interop/nbd.txt | 37 + MAINTAINERS | 1 + 2 files changed, 38 insertions(+) create mode 100644 docs/interop/nbd.txt diff --git a/docs/interop/nbd.txt

[Qemu-devel] [PATCH v4 5/6] qapi: new qmp command nbd-server-add-bitmap

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block.json | 23 +++ blockdev-nbd.c | 23 +++ 2 files changed, 46 insertions(+) diff --git a/qapi/block.json b/qapi/block.json index c694524002..ddbca2e286 100644 --- a/qapi/block.json +++

Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch

2018-06-08 Thread Ross Zwisler
On Fri, Jun 08, 2018 at 07:17:51AM +0200, Thomas Huth wrote: > On 08.06.2018 01:09, Michael S. Tsirkin wrote: > > On Thu, Jun 07, 2018 at 04:31:08PM -0600, Ross Zwisler wrote: > >> Currently if "make check" detects a mismatch in the ASL generated during > >> testing, we print an error such as: >

Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch

2018-06-08 Thread Peter Maydell
On 8 June 2018 at 16:59, Michael S. Tsirkin wrote: > The expected value tests are a debugging aid. They do not catch bugs and > aren't designed to. In particular the comparisons do not even run if > IASL isn't installed. If they're not actually tests to catch bugs, maybe we shouldn't be running

[Qemu-devel] [RFC PATCH 0/3] Better docker dependency checking

2018-06-08 Thread Alex Bennée
Hi, These patches apply on top of my tcg/testing patch series and attempt to make the dependancy checking a bit smarter within the confines of what Make can achieve. The basic idea is although the debian-sid-image will always rebuild by making it a conditional dependancy we can only trigger this

Re: [Qemu-devel] [PATCH v2 0/3] glib: update the min required version

2018-06-08 Thread Peter Maydell
On 8 June 2018 at 13:00, Peter Maydell wrote: > Note that updating to MXE is still on my todo list; I'll let > you know when I get to it... ...and now I've updated my windows crossbuild environment. thanks -- PMM

[Qemu-devel] [PATCH] Purge uses of banned g_assert_FOO()

2018-06-08 Thread Markus Armbruster
We banned use of certain g_assert_FOO() functions outside tests, and made checkpatch.pl flag them (commit 6e9389563e5). We neglected to purge existing uses. Do that now. Signed-off-by: Markus Armbruster --- hw/ide/ahci.c | 2 +- hw/ppc/spapr_ovec.c | 12 ++--

[Qemu-devel] [PATCH 8/8] authz: delete existing ACL implementation

2018-06-08 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The 'qemu_acl' type was a previous non-QOM based attempt to provide an authorization facility in QEMU. Because it is non-QOM based it cannot be created via the command line and requires special monitor commands to manipulate it. The new QAuthZ subclasses provide a

Re: [Qemu-devel] [PATCH] Purge uses of banned g_assert_FOO()

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 07:02:31PM +0200, Markus Armbruster wrote: > We banned use of certain g_assert_FOO() functions outside tests, and > made checkpatch.pl flag them (commit 6e9389563e5). We neglected to > purge existing uses. Do that now. > > Signed-off-by: Markus Armbruster > --- >

[Qemu-devel] [PATCH v3 2/3] glib: bump min required glib library version to 2.40

2018-06-08 Thread Daniel P . Berrangé
Per supported platforms doc[1], the various min glib on relevant distros is: RHEL-7: 2.50.3 Debian (Stretch): 2.50.3 Debian (Jessie): 2.42.1 OpenBSD (Ports): 2.54.3 FreeBSD (Ports): 2.50.3 OpenSUSE Leap 15: 2.54.3 SLE12-SP2: 2.48.2 Ubuntu (Xenial): 2.48.0 macOS (Homebrew):

Re: [Qemu-devel] [qemu PATCH 3/5] hw/i386: Update SSDT table used by "make check"

2018-06-08 Thread Eric Blake
On 06/07/2018 06:14 PM, Michael S. Tsirkin wrote: On Thu, Jun 07, 2018 at 04:31:09PM -0600, Ross Zwisler wrote: This commit: commit aa78a16d8645 ("hw/i386: Rename 2.13 machine types to 3.0") updated the name used to create the q35 machine, which in turn changed the SSDT table which is

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote: > All of the supported build platforms documented in qemu-doc.texi > should already support Python 2.7. > > Removing support for Python 2.6 will allow us to remove some > compatibility modules we carry in the QEMU tree: > > *

[Qemu-devel] [Bug 1463172] Re: destination arm board hangs after migration from x86 source

2018-06-08 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH v3 1/3] util: remove redundant include of glib.h and add osdep.h

2018-06-08 Thread Eric Blake
On 06/08/2018 08:16 AM, Daniel P. Berrangé wrote: Code must only ever include glib.h indirectly via the glib-compat.h header file, because we will need some macros set before glib.h is pulled in. Adding extra includes of glib.h will (soon) cause compile failures such as: In file included from

Re: [Qemu-devel] [RFC v2 02/12] libvhost-user: exit by default on VHOST_USER_NONE

2018-06-08 Thread Philippe Mathieu-Daudé
On 06/01/2018 01:27 PM, Marc-André Lureau wrote: > Since commit 2566378d6d13bf4d28c7770bdbda5f7682594bbe, libvhost-user > no longer panics on disconnect (rc == 0), and instead silently ignores > an invalid VHOST_USER_NONE message. > > Without extra work from the API user, this will simply

[Qemu-devel] [PATCH v4 4/6] nbd/server: implement dirty bitmap export

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
Handle new NBD meta namespace: "qemu", and corresponding queries: "qemu:dirty-bitmap:". With new metadata context negotiated, BLOCK_STATUS query will reply with dirty-bitmap data, converted to extents. New public function nbd_export_bitmap selects bitmap to export. For now, only one bitmap may be

Re: [Qemu-devel] [qemu PATCH 3/5] hw/i386: Update SSDT table used by "make check"

2018-06-08 Thread Michael S. Tsirkin
On Fri, Jun 08, 2018 at 09:24:49AM -0500, Eric Blake wrote: > On 06/07/2018 06:14 PM, Michael S. Tsirkin wrote: > > On Thu, Jun 07, 2018 at 04:31:09PM -0600, Ross Zwisler wrote: > > > This commit: > > > > > > commit aa78a16d8645 ("hw/i386: Rename 2.13 machine types to 3.0") > > > > > > updated

[Qemu-devel] [RFC PATCH 3/3] docker: remove SUBMAKE_NOCACHE_HACK for debian-sid based images

2018-06-08 Thread Alex Bennée
Now we can conditionally make docker-image-debian-sid a dependency depending on if we actually need to re-build our image we can remove this hack and use that mechanism. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 25 ++--- tests/tcg/Makefile.include|

Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch

2018-06-08 Thread Peter Maydell
On 8 June 2018 at 17:03, Michael S. Tsirkin wrote: > Pull requests are somewhat different, they are usually tested for lack > of warnings. This change didn't arrive as a result of a pull request > maybe that's why it slipped through the cracks. Peter? > > Maybe we need a "pedantic" flag to fail

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 5/8] hw/timer: Add basic M41T80 emulation

2018-06-08 Thread BALATON Zoltan
On Fri, 8 Jun 2018, Cédric Le Goater wrote: On 06/06/2018 03:31 PM, BALATON Zoltan wrote: Basic emulation of the M41T80 serial (I2C) RTC chip. Only getting time of day is implemented. Setting time and RTC alarm are not supported. Signed-off-by: BALATON Zoltan --- MAINTAINERS

Re: [Qemu-devel] [Qemu-block] Some question about savem/qcow2 incremental snapshot

2018-06-08 Thread Junyan He
I think nvdimm kind memory can really save the content(no matter real or emulated). But I think it is still memory, as I understand, its data should be stored in the qcow2 image or some external snapshot data image, so that we can copy this qcow2 image to other place and restore the same

Re: [Qemu-devel] [Qemu-block] Some question about savem/qcow2 incremental snapshot

2018-06-08 Thread Pankaj Gupta
Hi Junyan, > I think nvdimm kind memory can really save the content(no matter real or > emulated). But I think it is still > memory, as I understand, its data should be stored in the qcow2 image or some > external snapshot data > image, so that we can copy this qcow2 image to other place and

[Qemu-devel] [PATCH 5/8] authz: add QAuthZList object type for an access control list

2018-06-08 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" Add a QAuthZList object type that implements the QAuthZ interface. This built-in implementation maintains a trivial access control list with a sequence of match rules and a final default policy. This replicates the functionality currently provided by the qemu_acl

[Qemu-devel] [PATCH 7/8] authz: add QAuthZPAM object type for authorizing using PAM

2018-06-08 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" Add an authorization backend that talks to PAM to check whether the user identity is allowed. This only uses the PAM account validation facility, which is essentially just a check to see if the provided username is permitted access. It doesn't use the authentication or

[Qemu-devel] [PATCH v3 3/7] hmp: Restrict auto-complete in preconfig

2018-06-08 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Don't show the commands that aren't available. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Reviewed-by: Igor Mammedov --- monitor.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index

[Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Eduardo Habkost
All of the supported build platforms documented in qemu-doc.texi should already support Python 2.7. Removing support for Python 2.6 will allow us to remove some compatibility modules we carry in the QEMU tree: * scripts/argparse.py * scripts/ordereddict.py Python 2.6 is also not receiving bug

Re: [Qemu-devel] [PATCH v2 02/10] python: futurize -f libfuturize.fixes.fix_absolute_import

2018-06-08 Thread Stefan Hajnoczi
On Fri, Jun 08, 2018 at 09:29:44AM -0300, Eduardo Habkost wrote: > Make implicit relative imports explicit and add "from __future__ import > absolute_import" at the top of each relevant module. > > This is necessary for Python 3 compatibility. > > Done using: > > $ py=$( (g grep -l -E

[Qemu-devel] [PATCH] fixup! python: futurize -f libfuturize.fixes.fix_print_with_import

2018-06-08 Thread Eduardo Habkost
On Fri, Jun 08, 2018 at 09:29:43AM -0300, Eduardo Habkost wrote: > Change all Python code to use print as a function. > > This is necessary for Python 3 compatibility. > > Done using: > > $ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \ > sort -u | grep -v

[Qemu-devel] [Bug 1463812] Re: qemu-system-ppc64 V2.30 cause RHEL5.9 disk corruption

2018-06-08 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Philippe Mathieu-Daudé
Cc'ing Eric On 06/08/2018 11:30 AM, Eduardo Habkost wrote: > All of the supported build platforms documented in qemu-doc.texi > should already support Python 2.7. https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg05173.html On 08/25/2017 11:40 AM, Peter Maydell wrote: > Our choices

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:37:36AM -0300, Philippe Mathieu-Daudé wrote: > Cc'ing Eric > > On 06/08/2018 11:30 AM, Eduardo Habkost wrote: > > All of the supported build platforms documented in qemu-doc.texi > > should already support Python 2.7. > >

Re: [Qemu-devel] [RFC v2 01/12] chardev: avoid crash if no associated address

2018-06-08 Thread Philippe Mathieu-Daudé
On 06/01/2018 01:27 PM, Marc-André Lureau wrote: > A socket chardev may not have associated address (when adding client > fd manually for example). But on disconnect, updating socket filename > expects an address and may lead to this crash: > > Thread 1 "qemu-system-x86" received signal

Re: [Qemu-devel] [PATCH v2 1/4] hw/block/fdc: Replace error_setg(_abort) by assert()

2018-06-08 Thread John Snow
On 06/08/2018 02:05 AM, Markus Armbruster wrote: > John Snow writes: > >> On 06/07/2018 10:46 AM, Philippe Mathieu-Daudé wrote: >>> Use assert() instead of error_setg(_abort), >>> as suggested by the "qapi/error.h" documentation: >>> >>> Please don't error_setg(_fatal, ...), use

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:55:59AM -0300, Eduardo Habkost wrote: > On Fri, Jun 08, 2018 at 03:37:47PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote: > > > All of the supported build platforms documented in qemu-doc.texi > > > should already

[Qemu-devel] [PATCH] throttle: Fix crash on reopen

2018-06-08 Thread Alberto Garcia
The throttle block filter can be reopened, and with this it is possible to change the throttle group that the filter belongs to. The way the code does that is the following: - On throttle_reopen_prepare(): create a new ThrottleGroupMember and attach it to the new throttle group. - On

[Qemu-devel] [PATCH v4 2/6] nbd/server: refactor NBDExportMetaContexts

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
Use NBDExport pointer instead of just export name: there no needs to store duplicated name in the struct, moreover, NBDExport will be used further. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff

Re: [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files

2018-06-08 Thread Ross Zwisler
On Fri, Jun 08, 2018 at 09:59:00AM -0500, Eric Blake wrote: > On 06/07/2018 05:31 PM, Ross Zwisler wrote: > > With a fully built QEMU I currently see the following with "git status": > > > >Untracked files: > > (use "git add ..." to include in what will be committed) > > > >

[Qemu-devel] [RFC PATCH 2/3] dcoker: docker.py add check sub-command

2018-06-08 Thread Alex Bennée
This command allows you to check if we need to re-build a docker image. If the image isn't in the repository or the checksums don't match then we return false and some text (for processing in makefiles). Signed-off-by: Alex Bennée --- tests/docker/docker.py | 22 ++ 1 file

Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list"

2018-06-08 Thread Andreas Färber
Am 08.06.2018 um 11:41 schrieb Dr. David Alan Gilbert: > * Andreas Färber (afaer...@suse.de) wrote: >> Am 01.06.2018 um 17:39 schrieb Ricardo Perez Blanco: >>> For debugging purposes it is very useful to: >>> - See the description of the field. This information is already filled >>>in but not

Re: [Qemu-devel] [Qemu-block] Some question about savem/qcow2 incremental snapshot

2018-06-08 Thread Stefan Hajnoczi
On Fri, Jun 08, 2018 at 05:02:58AM +, He, Junyan wrote: > I use the simple way to handle this, > 1. Separate the nvdimm region from ram when do snapshot. > 2. If the first time, we dump all the nvdimm data the same as ram, and enable > dirty log trace > for nvdimm kind region. > 3. If not the

Re: [Qemu-devel] [PULL 0/5] slirp updates

2018-06-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180608061316.4909-1-samuel.thiba...@ens-lyon.org Subject: [Qemu-devel] [PULL 0/5] slirp updates === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Eduardo Habkost
On Fri, Jun 08, 2018 at 03:37:47PM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote: > > All of the supported build platforms documented in qemu-doc.texi > > should already support Python 2.7. > > > > Removing support for Python 2.6 will allow us

Re: [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files

2018-06-08 Thread Eric Blake
On 06/08/2018 09:59 AM, Eric Blake wrote: On 06/07/2018 05:31 PM, Ross Zwisler wrote: With a fully built QEMU I currently see the following with "git status":    Untracked files: (use "git add ..." to include in what will be committed)    qapi/qapi-commands-job.c   

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote: > All of the supported build platforms documented in qemu-doc.texi > should already support Python 2.7. > > Removing support for Python 2.6 will allow us to remove some > compatibility modules we carry in the QEMU tree: > > *

Re: [Qemu-devel] Cortex M0 emulation tasks

2018-06-08 Thread Stefan Hajnoczi
On Mon, May 28, 2018 at 3:26 PM, Stefan Hajnoczi wrote: > Tasks: > > D3.3 Instruction Support > D3.5.1 Alignment support Julia and I have discussed these two tasks and she will work on them. I will implement an undefined instruction test case that verifies that all undefined instructions do

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-08 Thread Pierre Morel
On 08/06/2018 16:45, Cornelia Huck wrote: On Fri, 8 Jun 2018 15:13:28 +0200 Halil Pasic wrote: On 06/08/2018 02:20 PM, Cornelia Huck wrote: My proposal is to do the same copying to scsw(r) again, which would mean we get a request with both the halt and the start bit set. The vfio code now

[Qemu-devel] [RFC PATCH 1/3] docker: docker.py don't conflate checksums for extra_files

2018-06-08 Thread Alex Bennée
This just gets confusing especially as the helper function doesn't even take into account any extra files (or the executable). Currently the actual check just ignores them and also passes the result through _dockerfile_preprocess so we fix that too. Signed-off-by: Alex Bennée ---

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Cleber Rosa
On 06/08/2018 10:30 AM, Eduardo Habkost wrote: > All of the supported build platforms documented in qemu-doc.texi > should already support Python 2.7. > > Removing support for Python 2.6 will allow us to remove some > compatibility modules we carry in the QEMU tree: > > * scripts/argparse.py

[Qemu-devel] [PATCH 0/8] Add a standard authorization framework

2018-06-08 Thread Daniel P . Berrangé
The current network services now support encryption via TLS and in some cases support authentication via SASL. In cases where SASL is not available, x509 client certificates can be used as a crude authorization scheme, but using a sub-CA and controlling who you give certs to. In general this is

[Qemu-devel] [PATCH 2/8] hw/usb: switch MTP to use new inotify APIs

2018-06-08 Thread Daniel P . Berrangé
The internal inotify APIs allow alot of conditional statements to be cleared out, and provide a simpler callback for handling events. Signed-off-by: Daniel P. Berrangé --- hw/usb/dev-mtp.c | 238 +++ 1 file changed, 97 insertions(+), 141 deletions(-)

[Qemu-devel] [PATCH 6/8] authz: add QAuthZListFile object type for a file access control list

2018-06-08 Thread Daniel P . Berrangé
Add a QAuthZListFile object type that implements the QAuthZ interface. This built-in implementation is a proxy around the QAtuhZList object type, initializing it from an external file, and optionally, automatically reloading it whenever it changes. To create an instance of this object via the QMP

Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig

2018-06-08 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert" writes: > >> > >> > * Markus Armbruster (arm...@redhat.com) wrote: > >> >> "Dr. David Alan Gilbert" writes: > >> >> > >> >> > *

[Qemu-devel] [PULL 4/5] slirp: correct size computation while concatenating mbuf

2018-06-08 Thread Samuel Thibault
From: Prasad J Pandit While reassembling incoming fragmented datagrams, 'm_cat' routine extends the 'mbuf' buffer, if it has insufficient room. It computes a wrong buffer size, which leads to overwriting adjacent heap buffer area. Correct this size computation in m_cat. Reported-by: ZDI

[Qemu-devel] [PULL 1/5] slirp: Fix spurious error report when sending directly

2018-06-08 Thread Samuel Thibault
Move check to where it actually is useful, and reduce scope of 'len' variable along the way. Signed-off-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daudé --- slirp/socket.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/slirp/socket.c b/slirp/socket.c

Re: [Qemu-devel] [PATCH v7 4/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-08 Thread Wei Wang
On 06/07/2018 02:32 PM, Peter Xu wrote: Btw, the migration_state_notifiers is already there, but seems not really used (I only tracked spice-core.c called add_migration_state_change_notifier). I thought adding new migration states can reuse all that we have. What's your real concern about that?

Re: [Qemu-devel] [RFC v3] qapi: command category to stimulate high-level machine devices

2018-06-08 Thread Stefan Hajnoczi
On Thu, Jun 07, 2018 at 02:58:53PM +0200, Gerd Hoffmann wrote: > > Gerd: What is your preference? Do you want board-specific fake displays > > inside the QEMU process as the long-term direction for UIs? > > Well, it isn't the one or the other, we could actually do both. For the > deployments

Re: [Qemu-devel] storing machine data in qcow images?

2018-06-08 Thread Dr. David Alan Gilbert
* Laszlo Ersek (ler...@redhat.com) wrote: > On 06/07/18 12:54, Andrea Bolognani wrote: > > On Thu, 2018-06-07 at 11:36 +0100, Daniel P. Berrangé wrote: > >> On Thu, Jun 07, 2018 at 11:32:18AM +0100, Richard W.M. Jones wrote: > >>> Another problem which Laszlo mentioned is the varstore isn't

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 2/8] spapr: no need to verify the node

2018-06-08 Thread David Hildenbrand
On 08.06.2018 10:39, Igor Mammedov wrote: > On Fri, 8 Jun 2018 10:07:31 +0200 > Thomas Huth wrote: > >> On 08.06.2018 09:48, David Hildenbrand wrote: >>> On 08.06.2018 09:46, Greg Kurz wrote: On Fri, 8 Jun 2018 09:42:48 +0200 David Hildenbrand wrote: > On 08.06.2018

  1   2   3   4   5   >