[Qemu-devel] [PATCH 12/14] check: Only test virtio-gpu when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- tests/display-vga-test.c | 4 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index a9cb5e926b..c4d68061e5 100644 --- a/tests/Makefile.include +++

[Qemu-devel] [PATCH 07/14] check: Only test usb storage when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include| 2 +- tests/usb-hcd-uhci-test.c | 5 - tests/usb-hcd-xhci-test.c | 4 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 6565206a78..9193945c24 100644 ---

Re: [Qemu-devel] [PATCH 0/9] monitor: enable OOB by default

2018-07-17 Thread Peter Xu
On Mon, Jul 16, 2018 at 07:18:28PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Based-on: <20180703085358.13941-1-arm...@redhat.com> > > Now in master. > > > This work is based on Markus's latest out-of-band fixes: > > "[PATCH v2 00/32] ] qmp: Fixes and cleanups around OOB

Re: [Qemu-devel] [PATCH 01/25] configure: We don't want to clean configuration files

2018-07-17 Thread Daniel P . Berrangé
On Tue, Jul 17, 2018 at 01:33:38PM +0200, Juan Quintela wrote: > If you don't want to compile everything, you configure > config-devices.mak. And then make clean remove it, and make will > create a default one without your configuration. Fix it by not > removing it. > > Signed-off-by: Juan

[Qemu-devel] [PATCH 3/3] char-socket: delay setting fd-pass feature until connected

2018-07-17 Thread Marc-André Lureau
Wait for QIO channel connection completion, and check the feature set by QIO. This fixes setting fd-pass chardev feature on SOCKET_ADDRESS_FD where fd has AF_UNIX. Signed-off-by: Marc-André Lureau --- chardev/char-socket.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

Re: [Qemu-devel] [PATCH 3/3] char-socket: delay setting fd-pass feature until connected

2018-07-17 Thread Marc-André Lureau
Hi On Tue, Jul 17, 2018 at 3:01 PM, Daniel P. Berrangé wrote: > On Tue, Jul 17, 2018 at 02:52:39PM +0200, Marc-André Lureau wrote: >> Wait for QIO channel connection completion, and check the feature set >> by QIO. This fixes setting fd-pass chardev feature on >> SOCKET_ADDRESS_FD where fd has

Re: [Qemu-devel] [PATCH] arm: Add ARMv6-M programmer's model support

2018-07-17 Thread Peter Maydell
On 17 July 2018 at 14:42, Julia Suvorova wrote: > On 17.07.2018 16:09, Peter Maydell wrote: >> This should be outside the "if v8" if(), because you also want it for v6M >> (giving you the v6M CCR value of STKALIGN and UNALIGN_TRP set and all >> other bits clear). > > > This is the main problem.

Re: [Qemu-devel] [PATCH v4 16/20] intc/arm_gic: Implement gic_update_virt() function

2018-07-17 Thread Peter Maydell
On 14 July 2018 at 18:15, Luc Michel wrote: > Add the gic_update_virt() function to update the vCPU interface states > and raise vIRQ and vFIQ as needed. This commit renames gic_update() to > gic_update_internal() and generalizes it to handle both cases, with a > `virt' parameter to track whether

Re: [Qemu-devel] [PATCH v8 2/5] tpm: implement virtual memory device for TPM PPI

2018-07-17 Thread Igor Mammedov
On Tue, 17 Jul 2018 12:22:49 +0200 Marc-André Lureau wrote: > On Tue, Jul 17, 2018 at 9:59 AM, Igor Mammedov wrote: > > On Mon, 16 Jul 2018 16:56:36 +0200 > > Marc-André Lureau wrote: > > > >> Hi > >> > >> On Mon, Jul 16, 2018 at 4:44 PM, Igor Mammedov > >> wrote: > >> > On Mon, 16 Jul

Re: [Qemu-devel] [PATCH v8 2/5] tpm: implement virtual memory device for TPM PPI

2018-07-17 Thread Igor Mammedov
On Mon, 16 Jul 2018 14:59:45 +0200 Marc-André Lureau wrote: > From: Stefan Berger > > Implement a virtual memory device for the TPM Physical Presence interface. > The memory is located at 0xFED45000 and used by ACPI to send messages to the > firmware (BIOS) and by the firmware to provide

Re: [Qemu-devel] [PATCH v2 for 3.0 06/16] docker: move make check into check_qemu helper

2018-07-17 Thread Philippe Mathieu-Daudé
On 07/17/2018 06:59 AM, Alex Bennée wrote: > Philippe Mathieu-Daudé writes: >> On 07/13/2018 09:17 AM, Alex Bennée wrote: >>> Not all docker images can run the check step. Let's move everything >>> into a common helper so we don't need to replicate checks in the >>> future. >>> >>> Signed-off-by:

[Qemu-devel] [PULL 07/13] hw/char/serial: retry write if EAGAIN

2018-07-17 Thread Paolo Bonzini
From: Marc-André Lureau If the chardev returns -1 with EAGAIN errno on write(), it should try to send it again (EINTR is handled by the chardev itself). This fixes commit 019288bf137183bf3407c9824655b753bfafc99f "hw/char/serial: Only retry if qemu_chr_fe_write returns 0" Tested-by: Igor

[Qemu-devel] [PULL 12/13] opts: remove redundant check for NULL parameter

2018-07-17 Thread Paolo Bonzini
From: Daniel P. Berrangé No callers of get_opt_value() pass in a NULL for the "value" parameter, so the check is redundant. Signed-off-by: Daniel P. Berrangé Message-Id: <20180514171913.17664-4-berra...@redhat.com> Reviewed-by: Eduardo Habkost Tested-by: Roman Kagan Signed-off-by: Paolo

[Qemu-devel] [PULL 02/13] accel: Fix typo and grammar in comment

2018-07-17 Thread Paolo Bonzini
From: Stefan Weil The typo was found by codespell. Signed-off-by: Stefan Weil Message-Id: <20180712194454.26765-1...@weilnetz.de> Signed-off-by: Paolo Bonzini --- accel/tcg/translate-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/translate-all.c

[Qemu-devel] [PULL 08/13] qdev: add HotplugHandler->post_plug() callback

2018-07-17 Thread Paolo Bonzini
From: Stefan Hajnoczi The ->pre_plug() callback is invoked before the device is realized. The ->plug() callback is invoked when the device is being realized but before it is reset. This patch adds a ->post_plug() callback which is invoked after the device has been reset. This callback is

Re: [Qemu-devel] [PATCH 14/25] check: Only test ioh3420 when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index a56d423303..3b555660bd 100644 > ---

[Qemu-devel] [PATCH 10/14] check: Only test virtio-serial when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index bb30c56795..7feda20577 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -204,10 +204,10 @@

Re: [Qemu-devel] [PATCH] nvic: Change NVIC to support ARMv6-M

2018-07-17 Thread Peter Maydell
On 10 July 2018 at 16:33, Julia Suvorova wrote: > The differences from ARMv7-M NVIC are: > * ARMv6-M only supports up to 32 external interrupts >(configurable feature already). The ICTR is reserved. > * Active Bit Register is reserved. > * ARMv6-M supports 4 priority levels against 256

Re: [Qemu-devel] [PATCH] arm: Add ARMv6-M programmer's model support

2018-07-17 Thread Peter Maydell
On 13 July 2018 at 11:30, Julia Suvorova wrote: > Forbid stack alignment change. (CCR) > Reserve FAULTMASK, BASEPRI registers. > Report any fault as HardFault. Disable MemManage, BusFault and > UsageFault, so they always escalated to HardFault. (SHCSR) > > Signed-off-by: Julia Suvorova > --- >

Re: [Qemu-devel] [PATCH 3/3] char-socket: delay setting fd-pass feature until connected

2018-07-17 Thread Marc-André Lureau
Hi On Tue, Jul 17, 2018 at 3:11 PM, Daniel P. Berrangé wrote: > On Tue, Jul 17, 2018 at 03:07:01PM +0200, Marc-André Lureau wrote: >> Hi >> >> On Tue, Jul 17, 2018 at 3:01 PM, Daniel P. Berrangé >> wrote: >> > On Tue, Jul 17, 2018 at 02:52:39PM +0200, Marc-André Lureau wrote: >> >> Wait for

Re: [Qemu-devel] [PATCH] headers: fix linux/mod_devicetable.h inclusions

2018-07-17 Thread Lad, Prabhakar
On Mon, Jul 9, 2018 at 4:19 PM, Arnd Bergmann wrote: > A couple of drivers produced build errors after the mod_devicetable.h > header was split out from the platform_device one, e.g. > > drivers/media/platform/davinci/vpbe_osd.c:42:40: error: array type has > incomplete element type 'struct

Re: [Qemu-devel] [PATCH 2/3] i.MX6UL: Add i.MX6UL SOC

2018-07-17 Thread Peter Maydell
On 30 June 2018 at 22:58, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois > --- > default-configs/arm-softmmu.mak | 1 + > hw/arm/Makefile.objs| 1 + > hw/arm/fsl-imx6ul.c | 649 > include/hw/arm/fsl-imx6ul.h

[Qemu-devel] [PULL 00/13] Misc fixes for QEMU 3.0.0-rc1

2018-07-17 Thread Paolo Bonzini
The following changes since commit 9277d81f5c2c6f4d0b5e47c8476eb7ee7e5c0beb: docs: Grammar and spelling fixes (2018-07-13 10:16:04 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git for you to fetch changes up to dfaa7d50b0f72060764096ffcae4a0c06ce24f9b:

[Qemu-devel] [PULL 03/13] hyperv: rename vcpu_id to vp_index

2018-07-17 Thread Paolo Bonzini
From: Roman Kagan In Hyper-V-related code, vCPUs are identified by their VP (virtual processor) index. Since it's customary for "vcpu_id" in QEMU to mean APIC id, rename the respective variables to "vp_index" to make the distinction clear. Signed-off-by: Roman Kagan Message-Id:

Re: [Qemu-devel] [PATCH] hw/riscv/sifive_u: Fix introspection problem in the "riscv.sifive.u.soc" device

2018-07-17 Thread Philippe Mathieu-Daudé
On 07/17/2018 12:02 PM, Thomas Huth wrote: > Valgrind complains: > > echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \ > "'arguments':{'typename':'riscv.sifive.u.soc'}}" \ > "{'execute': 'human-monitor-command', " \ > "'arguments': {'command-line': 'info qtree'}}" |

Re: [Qemu-devel] [PATCH v8 5/5] PoC: tpm: add ACPI memory clear interface

2018-07-17 Thread Marc-André Lureau
Hi On Tue, Jul 17, 2018 at 9:57 AM, Igor Mammedov wrote: > On Mon, 16 Jul 2018 14:59:48 +0200 > Marc-André Lureau wrote: > >> This allows to pass the last failing test from the Windows HLK TPM 2.0 >> TCG PPI 1.3 tests. >> >> The interface is described in the "TCG Platform Reset Attack >>

Re: [Qemu-devel] [PATCH] hw/sd/bcm2835_sdhost: Fix PIO mode writes

2018-07-17 Thread Guenter Roeck
On Mon, Jul 16, 2018 at 10:20:37PM -0300, Philippe Mathieu-Daudé wrote: > Cc'ing ANTField folks who might have the specs. > > On 07/16/2018 07:23 PM, Guenter Roeck wrote: > > Writes in PIO mode have two requirements: > > > > - A data interrupt must be generated after a write command has been > >

Re: [Qemu-devel] [PATCH] arm: Add ARMv6-M programmer's model support

2018-07-17 Thread Julia Suvorova via Qemu-devel
On 17.07.2018 16:49, Peter Maydell wrote: On 17 July 2018 at 14:42, Julia Suvorova wrote: On 17.07.2018 16:09, Peter Maydell wrote: This should be outside the "if v8" if(), because you also want it for v6M (giving you the v6M CCR value of STKALIGN and UNALIGN_TRP set and all other bits

[Qemu-devel] [PATCH 08/14] check: Only test nvdim_acpi when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/bios-tables-test.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index fd59c7f9a2..1de6e3d58c 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -825,6 +825,7 @@ static void

[Qemu-devel] [PATCH 06/14] check: Only test usb smartcard when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/usb-hcd-xhci-test.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/usb-hcd-xhci-test.c b/tests/usb-hcd-xhci-test.c index 5b1b681bf2..be80c5f032 100644 --- a/tests/usb-hcd-xhci-test.c +++ b/tests/usb-hcd-xhci-test.c @@ -35,6

[Qemu-devel] [PATCH 13/14] check: Only test virtio-input when it is compiled in

2018-07-17 Thread Juan Quintela
The full of it. Introspection is able to search for drivers that you aren't there, so just disable it. Signed-off-by: Juan Quintela --- hw/virtio/virtio-pci.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 75c96990c0..987d7c0a5a

Re: [Qemu-devel] [RFC 00/14] More patches to disable stuff

2018-07-17 Thread Thomas Huth
On 17.07.2018 14:04, Juan Quintela wrote: > Hi > > Notice that this is an RFC because they don't work. As said on my > previous submmision, we need -softmmu/config-devices.h to make > this work. This series just allow us to disable the devices, but not > to enable it back O:-) > > Notice: > >

Re: [Qemu-devel] [PATCH] arm: Add ARMv6-M programmer's model support

2018-07-17 Thread Julia Suvorova via Qemu-devel
On 17.07.2018 16:09, Peter Maydell wrote: diff --git a/target/arm/cpu.c b/target/arm/cpu.c index a914ce4e8c..3788cb773d 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -220,6 +220,11 @@ static void arm_cpu_reset(CPUState *s) env->v7m.aircr = R_V7M_AIRCR_BFHFNMINS_MASK;

Re: [Qemu-devel] [PATCH 0/4] docker: Improve 'host-cross' image

2018-07-17 Thread Cornelia Huck
On Mon, 16 Jul 2018 23:29:20 -0300 Philippe Mathieu-Daudé wrote: > Sorry I don't have a better name for this image, > it is meant to cross-build for the same architecture > than the host. > > Due to the bad name, explicitely tagged the last 2 > patches as 'RFC'. > > Tested on x86_64 and

Re: [Qemu-devel] [PATCH v4 09/20] intc/arm_gic: Add virtualization enabled IRQ helper functions

2018-07-17 Thread Peter Maydell
On 14 July 2018 at 18:15, Luc Michel wrote: > Add some helper functions to gic_internal.h to get or change the state > of an IRQ. When the current CPU is not a vCPU, the call is forwarded to > the GIC distributor. Otherwise, it acts on the list register matching > the IRQ in the current CPU

Re: [Qemu-devel] [PATCH v4 20/20] arm/virt: Add support for GICv2 virtualization extensions

2018-07-17 Thread Peter Maydell
On 14 July 2018 at 18:16, Luc Michel wrote: > Add support for GICv2 virtualization extensions by mapping the necessary > I/O regions and connecting the maintenance IRQ lines. > > Declare those additions in the device tree and in the ACPI tables. > > Signed-off-by: Luc Michel Reviewed-by: Peter

Re: [Qemu-devel] [PATCH 1/3] i.MX6UL: Add i.MX6UL specific CCM device

2018-07-17 Thread Peter Maydell
On 30 June 2018 at 22:58, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois > --- > hw/misc/Makefile.objs| 1 + > hw/misc/imx6ul_ccm.c | 887 +++ > include/hw/misc/imx6ul_ccm.h | 228 + > 3 files changed, 1116

Re: [Qemu-devel] [PATCH 0/4] docker: Improve 'host-cross' image

2018-07-17 Thread Philippe Mathieu-Daudé
Hi Cornelia, On 07/17/2018 11:12 AM, Cornelia Huck wrote: > On Mon, 16 Jul 2018 23:29:20 -0300 > Philippe Mathieu-Daudé wrote: > >> Sorry I don't have a better name for this image, >> it is meant to cross-build for the same architecture >> than the host. >> >> Due to the bad name, explicitely

[Qemu-devel] [PULL 06/13] PC Chipset: Improve serial divisor calculation

2018-07-17 Thread Paolo Bonzini
From: Calvin Lee This fixes several problems I found in the UART serial implementation. Now all divisor values are allowed, while before divisor values of zero and below the base baud rate were rejected. All changes are in reference to http://www.sci.muni.cz/docs/pc/serport.txt Signed-off-by:

Re: [Qemu-devel] [PATCH v2 for 3.0 16/16] docker: ignore distro versioning of debootstrap

2018-07-17 Thread Philippe Mathieu-Daudé
On 07/13/2018 09:17 AM, Alex Bennée wrote: > We do a minimum version check for the debootstrap but if the distro > has added their own minor version tick it would fail and fall-back to > the SCM version. This is sub-optimal as the latest/greatest version > may be broken at any one particular time.

Re: [Qemu-devel] [PATCH v2 for 3.0 12/16] docker: drop QEMU_TARGET check, fallback in EXECUTABLE not set

2018-07-17 Thread Philippe Mathieu-Daudé
On 07/13/2018 09:17 AM, Alex Bennée wrote: > The addition of QEMU_TARGET was intended to ensure we fall back to > checking for the existence of an image if the build system was not > currently configured to build it. However this breaks the direct use > of the rule for building custom binfmt_misc

Re: [Qemu-devel] [PATCH v2 for 3.0 00/16] various docker fixes

2018-07-17 Thread Philippe Mathieu-Daudé
On 07/13/2018 09:17 AM, Alex Bennée wrote: > Hi, > > Unfortunately this series grew a little while I was re-basing as I > noticed a couple of bugs. An upstream change in debootstrap which I'd > been happily using for Ubuntu images caused a breakage which I've > hopefully now fixed: > >

Re: [Qemu-devel] [PATCH 13/25] check: Only test isa-testdev when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: [...] > @@ -319,15 +319,15 @@ check-qtest-m68k-y = tests/boot-serial-test$(EXESUF) > > check-qtest-microblaze-y = tests/boot-serial-test$(EXESUF) > > -check-qtest-mips-y = tests/endianness-test$(EXESUF) > +check-qtest-mips-$(CONFIG_ISA_TESTDEV) =

[Qemu-devel] [Bug 1782107] Re: Random errors when emulating armv7 and using dh

2018-07-17 Thread Nadav Ruskin
Thank you for the quick reply. Version: nadav@DESKTOP-4DUIS04:/mnt/c/Git/configsite$ dpkg -s qemu-user-static | grep Version Version: 1:2.11+dfsg-1ubuntu7.4 A log with verbose mode enabled is attached. ** Attachment added: "myerror3.txt"

Re: [Qemu-devel] [PATCH v8 2/5] tpm: implement virtual memory device for TPM PPI

2018-07-17 Thread Laszlo Ersek
On 07/17/18 12:39, Marc-André Lureau wrote: > Hi > > On Tue, Jul 17, 2018 at 12:03 PM, Igor Mammedov wrote: >> On Mon, 16 Jul 2018 14:59:45 +0200 >> Marc-André Lureau wrote: >> >>> From: Stefan Berger >>> >>> Implement a virtual memory device for the TPM Physical Presence interface. >>> The

Re: [Qemu-devel] [PATCH 1/3] char-socket: correctly set has_reconnect when parsing QemuOpts

2018-07-17 Thread Daniel P . Berrangé
On Tue, Jul 17, 2018 at 02:52:37PM +0200, Marc-André Lureau wrote: > qemu_chr_parse_socket() fills all ChardevSocket fields, but that > doesn't reflect correctly the arguments given with the options / on > the command line. "reconnect" takes a number as argument, and the > default value is 0,

Re: [Qemu-devel] [PATCH v4 07/20] intc/arm_gic: Add virtualization extensions helper macros and functions

2018-07-17 Thread Peter Maydell
On 14 July 2018 at 18:15, Luc Michel wrote: > Add some helper macros and functions related to the virtualization > extensions to gic_internal.h. > > The GICH_LR_* macros help extracting specific fields of a list register > value. The only tricky one is the priority field as only the MSB are >

Re: [Qemu-devel] [PATCH v8 2/5] tpm: implement virtual memory device for TPM PPI

2018-07-17 Thread Igor Mammedov
On Tue, 17 Jul 2018 15:04:25 +0200 Laszlo Ersek wrote: > On 07/17/18 12:39, Marc-André Lureau wrote: > > Hi > > > > On Tue, Jul 17, 2018 at 12:03 PM, Igor Mammedov > > wrote: > >> On Mon, 16 Jul 2018 14:59:45 +0200 > >> Marc-André Lureau wrote: > >> > >>> From: Stefan Berger > >>> > >>>

[Qemu-devel] [PATCH] hw/microblaze/xlnx-zynqmp-pmu: Fix introspection problem in 'xlnx, zynqmp-pmu-soc'

2018-07-17 Thread Thomas Huth
Valgrind complains: echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \ "'arguments':{'typename':'xlnx,zynqmp-pmu-soc'}}" \ "{'execute': 'human-monitor-command', " \ "'arguments': {'command-line': 'info qtree'}}" | \ valgrind -q

Re: [Qemu-devel] [PATCH v2 for 3.0 11/16] docker: add expansion for docker-test-FOO to Makefile.include

2018-07-17 Thread Philippe Mathieu-Daudé
On 07/16/2018 06:07 AM, Alex Bennée wrote: > Philippe Mathieu-Daudé writes: > >> Hi Alex, >> >> On 07/13/2018 09:17 AM, Alex Bennée wrote: >>> This allows us to run a particular test on all docker images. For >>> example: >>> >>> make docker-test-unit >>> >>> Will run the unit tests on every

Re: [Qemu-devel] [PATCH v2 for 3.0 15/16] docker: add commentary to debian-bootstrap.docker

2018-07-17 Thread Philippe Mathieu-Daudé
On 07/13/2018 09:17 AM, Alex Bennée wrote: > This is just a note that later versions of debootstrap don't > technically need this hack. > > Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé > --- > tests/docker/dockerfiles/debian-bootstrap.docker | 1 + > 1 file changed, 1

[Qemu-devel] [PULL 11/13] i386: only parse the initrd_filename once for multiboot modules

2018-07-17 Thread Paolo Bonzini
From: Daniel P. Berrangé The multiboot code parses the initrd_filename twice, first to count how many entries there are, and second to process each entry. This changes the first loop to store the parse module names in a list, and the second loop can now use these names. This avoids having to

Re: [Qemu-devel] [PATCH v2 for 3.0 13/16] docker: add --hint to docker.py check

2018-07-17 Thread Philippe Mathieu-Daudé
On 07/17/2018 12:24 AM, Philippe Mathieu-Daudé wrote: > On 07/13/2018 09:17 AM, Alex Bennée wrote: >> When a check fails we currently just report why we failed. This is not >> totally helpful to people who want to boot-strap a new image. Add a >> --hint option which we can pass down to give a bit

[Qemu-devel] [PULL RESEND] Misc fixes for QEMU 3.0.0-rc1

2018-07-17 Thread Paolo Bonzini
The following changes since commit 9277d81f5c2c6f4d0b5e47c8476eb7ee7e5c0beb: docs: Grammar and spelling fixes (2018-07-13 10:16:04 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to

Re: [Qemu-devel] [PATCH v8 1/8] i386: Helpers to encode cache information consistently

2018-07-17 Thread Philippe Mathieu-Daudé
Hi Eduardo, On 07/16/2018 04:52 PM, Eduardo Habkost wrote: > On Mon, Jul 16, 2018 at 10:20:09AM -0300, Philippe Mathieu-Daudé wrote: > [...] >>> +enum CacheType { >>> +DCACHE, >> >> I just noticed this clashes on mips host: > [...] >> In file included from

Re: [Qemu-devel] [PATCH 1/7 V10] memory, exec: Expose all memory block related flags.

2018-07-17 Thread Richard Henderson
On 07/16/2018 11:32 PM, junyan...@gmx.com wrote: > From: Junyan He > > We need to use these flags in other files rather than just in exec.c, > For example, RAM_SHARED should be used when create a ram block from file. > We expose them the exec/memory.h > > Signed-off-by: Junyan He >

Re: [Qemu-devel] [PATCH 3/3] char-socket: delay setting fd-pass feature until connected

2018-07-17 Thread Daniel P . Berrangé
On Tue, Jul 17, 2018 at 03:07:01PM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Jul 17, 2018 at 3:01 PM, Daniel P. Berrangé > wrote: > > On Tue, Jul 17, 2018 at 02:52:39PM +0200, Marc-André Lureau wrote: > >> Wait for QIO channel connection completion, and check the feature set > >> by QIO.

Re: [Qemu-devel] [PATCH 22/25] check: Only test usb-uhci devices when they are compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 3a78ada070..27f50e3231 100644 > ---

Re: [Qemu-devel] [PATCH 23/25] check: Only test usb-ehci when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:34, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 27f50e3231..731443387d 100644 > ---

Re: [Qemu-devel] [PATCH 21/25] check: Only test usb-ohci when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index ccf71bddcc..3a78ada070 100644 > ---

Re: [Qemu-devel] [PATCH v4 00/20] arm_gic: add virtualization extensions support

2018-07-17 Thread Peter Maydell
On 14 July 2018 at 18:15, Luc Michel wrote: > v4: I've now reviewed or commented on all the patches I think except the xilinx board one. You'll want to rebase on top of current master -- this version doesn't apply (probably as a result of the for-3.0 bugfix patches that are now in master).

Re: [Qemu-devel] [PATCH 1/4] docker: Use the host architecture

2018-07-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > This image is badly named and not amd64 specific. > > Use `dpkg --print-architecture` to get the host architecture. > > Signed-off-by: Philippe Mathieu-Daudé It's like you've been reading my mind ;-) Reviewed-by: Alex Bennée > --- >

Re: [Qemu-devel] [RFC PATCH 3/4] docker: Rename 'amd64' image as 'host-cross'

2018-07-17 Thread Philippe Mathieu-Daudé
On 07/17/2018 11:45 AM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> .shippable.yml | 4 ++-- >> tests/docker/Makefile.include| 2 +- >> .../{debian-amd64.docker

[Qemu-devel] [PULL 13/13] Document command line options with single dash

2018-07-17 Thread Paolo Bonzini
From: BALATON Zoltan QEMU options have a single dash (but also work as double dash for convenience and compatibility). Most options are listed with single dash in command line help but some were listed with two dashes. Normalize these to have the same format as the others. Left --preconfig as

[Qemu-devel] [PULL 10/13] i386: fix regression parsing multiboot initrd modules

2018-07-17 Thread Paolo Bonzini
From: Daniel P. Berrangé The logic for parsing the multiboot initrd modules was messed up in commit 950c4e6c94b15cd0d8b638917a8dbf458e6a Author: Daniel P. Berrangé Date: Mon Apr 16 12:17:43 2018 +0100 opts: don't silently truncate long option values Causing the length to be

[Qemu-devel] Profiling results (was: Re: [PATCH] Do not enable QOM debugging by default)

2018-07-17 Thread BALATON Zoltan
On Mon, 16 Jul 2018, Peter Maydell wrote: Is this coming up as significant in profiling? In the past we've This seems to depend on the workload. From the cases I'm interested in AROS and AmigaOS on qemu-system-ppc -M sam460ex does not seem to be effected much

[Qemu-devel] [PATCH 01/14] check: Only test ipmi when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- tests/bios-tables-test.c | 4 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 0ac4b960bc..bb1080ecb5 100644 --- a/tests/Makefile.include +++

[Qemu-devel] [PATCH 09/14] check: Only test virtio-balloon when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/virtio/virtio-pci.c | 5 - tests/Makefile.include | 6 +++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 3a01fe90f0..bdbc7ab78d 100644 --- a/hw/virtio/virtio-pci.c +++

Re: [Qemu-devel] [PATCH 15/25] check: Only test i82801b11 when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 3b555660bd..b0aa79909b 100644 > ---

Re: [Qemu-devel] [PATCH 09/14] check: Only test virtio-balloon when it is compiled in

2018-07-17 Thread Cornelia Huck
On Tue, 17 Jul 2018 14:04:09 +0200 Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hw/virtio/virtio-pci.c | 5 - > tests/Makefile.include | 6 +++--- > 2 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > index

Re: [Qemu-devel] [PATCH 3/3] char-socket: delay setting fd-pass feature until connected

2018-07-17 Thread Daniel P . Berrangé
On Tue, Jul 17, 2018 at 02:52:39PM +0200, Marc-André Lureau wrote: > Wait for QIO channel connection completion, and check the feature set > by QIO. This fixes setting fd-pass chardev feature on > SOCKET_ADDRESS_FD where fd has AF_UNIX. > > Signed-off-by: Marc-André Lureau > --- >

Re: [Qemu-devel] [PATCH 2/3] char-socket: make 'fd' incompatible with 'reconnect'

2018-07-17 Thread Daniel P . Berrangé
On Tue, Jul 17, 2018 at 02:52:38PM +0200, Marc-André Lureau wrote: > A chardev socket created with the 'fd=' argument is not going to > handle reconnection properly by recycling the same fd (or not in a > supported way). Let's forbid this case. > > Signed-off-by: Marc-André Lureau > --- >

Re: [Qemu-devel] [PATCH v4 12/20] intc/arm_gic: Implement virtualization extensions in gic_(deactivate|complete_irq)

2018-07-17 Thread Peter Maydell
On 14 July 2018 at 18:15, Luc Michel wrote: > Implement virtualization extensions in the gic_deactivate_irq() and > gic_complete_irq() functions. When a guest tries to deactivat or end an "deactivate" > IRQ that does not exist in the LRs, the EOICount field of the virtual > interface HCR

Re: [Qemu-devel] [PATCH v4 14/20] intc/arm_gic: Wire the vCPU interface

2018-07-17 Thread Peter Maydell
On 14 July 2018 at 18:15, Luc Michel wrote: > Add the read/write functions to handle accesses to the vCPU interface. > Those accesses are forwarded to the real CPU interface, with the CPU id > being converted to the corresponding vCPU id (vCPU id = CPU id + > GIC_NCPU). > > As for the CPU

Re: [Qemu-devel] [PATCH] migration: release MigrationIncomingState in migration_object_finalize

2018-07-17 Thread 858585 jemmy
On Thu, Jul 12, 2018 at 12:08 PM, 858585 jemmy wrote: > On Fri, Jul 6, 2018 at 6:41 PM, Dr. David Alan Gilbert > wrote: >> * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: >>> * Lidong Chen (jemmy858...@gmail.com) wrote: >>> > Qemu initialize the MigrationIncomingState structure in >>> >

Re: [Qemu-devel] [PATCH v2 for 3.0 07/16] docker: gracefully skip check_qemu

2018-07-17 Thread Philippe Mathieu-Daudé
On 07/17/2018 07:22 AM, Alex Bennée wrote: > Philippe Mathieu-Daudé writes: >> On 07/13/2018 09:17 AM, Alex Bennée wrote: >>> Not all our images are able to run the tests. Rather than use features >>> we can just check for the existence and run-ability of gtester. If the >>> image has been setup

Re: [Qemu-devel] [PATCH 11/12] qga: process_event() simplification

2018-07-17 Thread Markus Armbruster
Copying the maintainer Michael Roth. Marc-André Lureau writes: > Simplify the code around qmp_dispatch(): > - rely on qmp_dispatch/check_obj() for message checking > - have a single send_response() point > - constify send_response() argument > - rsp/req variable renaming for clarity > >

Re: [Qemu-devel] [PATCH v2 for 3.0 09/16] docker: disable debian-powerpc-user-cross

2018-07-17 Thread Philippe Mathieu-Daudé
On 07/13/2018 09:17 AM, Alex Bennée wrote: > While we can build we can't run the unit tests due to a missing system > call (249 - swapcontext). This could be a code generation issue as > other architectures don't seem to have this system call. > > Signed-off-by: Alex Bennée Tested-by: Philippe

[Qemu-devel] [PATCH 14/14] check: Only test virtio-scsi when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- tests/cdrom-test.c | 4 tests/drive_del-test.c | 6 ++ 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index c4d68061e5..74ee02348c 100644 ---

[Qemu-devel] [PATCH 0/3] chardev: fix setting FD_PASS for socket type=fd

2018-07-17 Thread Marc-André Lureau
Hi, This is an alternative series from Daniel "[PATCH] chardev: unconditionally set FD_PASS feature for socket type=fd". Instead of unconditionally set FD_PASS feature for any socket address which has type==fd, we can rely on QIO synchronized initialization and feature check, as long as

[Qemu-devel] [PATCH 2/3] char-socket: make 'fd' incompatible with 'reconnect'

2018-07-17 Thread Marc-André Lureau
A chardev socket created with the 'fd=' argument is not going to handle reconnection properly by recycling the same fd (or not in a supported way). Let's forbid this case. Signed-off-by: Marc-André Lureau --- chardev/char-socket.c | 4 1 file changed, 4 insertions(+) diff --git

[Qemu-devel] [PATCH 1/3] char-socket: correctly set has_reconnect when parsing QemuOpts

2018-07-17 Thread Marc-André Lureau
qemu_chr_parse_socket() fills all ChardevSocket fields, but that doesn't reflect correctly the arguments given with the options / on the command line. "reconnect" takes a number as argument, and the default value is 0, which doesn't help to identify the missing option. The other arguments have

Re: [Qemu-devel] [PATCH 3/3] i.MX6UL: Add Freescale i.MX6 UltraLite 14x14 EVK Board

2018-07-17 Thread Peter Maydell
On 30 June 2018 at 22:58, Jean-Christophe Dubois wrote: > Tested by booting linux 4.18 (built using imx_v6_v7_defconfig) on the > emulated board. > > Signed-off-by: Jean-Christophe Dubois > --- > hw/arm/Makefile.objs | 2 +- > hw/arm/mcimx6ul-evk.c | 86

[Qemu-devel] [PATCH] hw/riscv/sifive_u: Fix introspection problem in the "riscv.sifive.u.soc" device

2018-07-17 Thread Thomas Huth
Valgrind complains: echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \ "'arguments':{'typename':'riscv.sifive.u.soc'}}" \ "{'execute': 'human-monitor-command', " \ "'arguments': {'command-line': 'info qtree'}}" | \ valgrind -q riscv32-softmmu/qemu-system-riscv32 -M

[Qemu-devel] [PULL 04/13] hyperv: ensure VP index equal to QEMU cpu_index

2018-07-17 Thread Paolo Bonzini
From: Roman Kagan Hyper-V identifies vCPUs by Virtual Processor (VP) index which can be queried by the guest via HV_X64_MSR_VP_INDEX msr. It is defined by the spec as a sequential number which can't exceed the maximum number of vCPUs per VM. It has to be owned by QEMU in order to preserve it

Re: [Qemu-devel] [PATCH 14/14] tests: drop ds1338-test

2018-07-17 Thread Peter Maydell
On 5 July 2018 at 19:20, Michael Davidsaver wrote: > redundant to ds-rtc-*-test.c > > Signed-off-by: Michael Davidsaver > --- > tests/Makefile.include | 2 -- > tests/ds1338-test.c| 75 > -- > 2 files changed, 77 deletions(-) > delete mode

Re: [Qemu-devel] [PATCH 12/25] check: Only test ipack when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 691f853ab6..5a3943c81c 100644 > ---

Re: [Qemu-devel] [PATCH 18/25] check: Only test pvpanic when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > There was not possible to compile out pvpanic. Use the same trick > that applesmc. Either "It is not possible" or "There is no possibility" ? And that "that" in the second sentence also sounds wrong. Apart from that: Reviewed-by: Thomas Huth

Re: [Qemu-devel] [PATCH v3] trace/simple: fix hang in child after fork(2)

2018-07-17 Thread Cornelia Huck
On Tue, 17 Jul 2018 11:19:44 +0100 Stefan Hajnoczi wrote: > The simple trace backend spawns a write-out thread which is used to > asynchronously flush the in-memory ring buffer to disk. > > fork(2) does not clone all threads, only the thread that invoked > fork(2). As a result there is no

Re: [Qemu-devel] [RFC v3 2/2] virtio-pmem: Add virtio pmem driver

2018-07-17 Thread Stefan Hajnoczi
On Fri, Jul 13, 2018 at 01:22:31PM +0530, Pankaj Gupta wrote: > + /* The request submission function */ > +static int virtio_pmem_flush(struct device *dev) > +{ > + int err; > + unsigned long flags; > + struct scatterlist *sgs[2], sg, ret; > + struct virtio_device *vdev =

Re: [Qemu-devel] [PATCH 19/25] check: Only test nvme when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 31d124ee44..b3e707e8c3 100644 > ---

Re: [Qemu-devel] [PATCH v4 10/20] intc/arm_gic: Implement virtualization extensions in gic_(activate_irq|drop_prio)

2018-07-17 Thread Peter Maydell
On 14 July 2018 at 18:15, Luc Michel wrote: > Implement virtualization extensions in gic_activate_irq() and > gic_drop_prio() and in gic_get_prio_from_apr_bits() called by > gic_drop_prio(). > > When the current CPU is a vCPU: > - Use GIC_VIRT_MIN_BPR and GIC_VIRT_NR_APRS instead of their

Re: [Qemu-devel] [RFC PATCH 3/4] docker: Rename 'amd64' image as 'host-cross'

2018-07-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé > --- > .shippable.yml | 4 ++-- > tests/docker/Makefile.include| 2 +- > .../{debian-amd64.docker => debian-host-cross.docker}| 9 > ++--- I'd

Re: [Qemu-devel] [PATCH 10/12] tests: add a qmp success-response test

2018-07-17 Thread Markus Armbruster
Marc-André Lureau writes: > Verify the usage of this schema feature and the API behaviour. This > should be the only case where qmp_dispatch() returns NULL without > error. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PULL 00/13] Misc fixes for QEMU 3.0.0-rc1

2018-07-17 Thread Peter Maydell
On 17 July 2018 at 16:06, Paolo Bonzini wrote: > The following changes since commit 9277d81f5c2c6f4d0b5e47c8476eb7ee7e5c0beb: > > docs: Grammar and spelling fixes (2018-07-13 10:16:04 +0100) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git Hi -- your pullreq

Re: [Qemu-devel] [PATCH v5 02/13] target/arm: Filter cycle counter based on PMCCFILTR_EL0

2018-07-17 Thread Peter Maydell
On 22 June 2018 at 21:32, Aaron Lindsay wrote: > The pmu_counter_enabled and pmu_op_start/finish functions are generic > (as opposed to PMCCNTR-specific) to allow for the implementation of > other events. > > Signed-off-by: Aaron Lindsay Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v5 13/13] target/arm: Send interrupts on PMU counter overflow

2018-07-17 Thread Peter Maydell
On 22 June 2018 at 21:32, Aaron Lindsay wrote: > Setup a QEMUTimer to get a callback when we expect counters to next > overflow and trigger an interrupt at that time. > > Signed-off-by: Aaron Lindsay > --- > target/arm/cpu.c| 11 + > target/arm/cpu.h| 7 +++ > target/arm/helper.c

Re: [Qemu-devel] [PATCH v2 for-2.11.2] spapr: make pseries-2.11 the default machine type

2018-07-17 Thread Michael Roth
Quoting David Gibson (2018-07-17 05:50:06) > On Thu, Jun 21, 2018 at 03:23:21PM +0200, Greg Kurz wrote: > > On Thu, 21 Jun 2018 11:18:09 +1000 > > David Gibson wrote: > > > > > On Wed, Jun 20, 2018 at 02:54:15PM +0200, Greg Kurz wrote: > > > > The spapr capability framework was introduced in

Re: [Qemu-devel] [PATCH] qga-win: Handle fstrim for OSes lower than Win8

2018-07-17 Thread Michael Roth
Quoting Daniel P. Berrangé (2018-07-17 04:34:18) > On Mon, Jul 16, 2018 at 03:10:38PM -0500, Michael Roth wrote: > > Quoting Sameeh Jubran (2018-06-24 07:45:40) > > > From: Sameeh Jubran > > > > > > The defrag.exe tool which is used for executing the fstrim command > > > on Windows doesn't

Re: [Qemu-devel] [PATCH v5 09/13] target/arm: PMU: Add instruction and cycle events

2018-07-17 Thread Peter Maydell
On 22 June 2018 at 21:32, Aaron Lindsay wrote: > The instruction event is only enabled when icount is used, cycles are > always supported. Always defining get_cycle_count (but altering its > behavior depending on CONFIG_USER_ONLY) allows us to remove some > CONFIG_USER_ONLY #defines throughout

  1   2   3   >