Re: [Qemu-devel] [PATCH v3 21/22] virtio-pmem: hotplug support functions

2018-09-24 Thread David Hildenbrand
On 24/09/2018 08:44, David Gibson wrote: > On Thu, Sep 20, 2018 at 12:32:42PM +0200, David Hildenbrand wrote: >> virtio-pmem devices will have to be hotplugged using the machine hotplug >> handler just like other memory devices. Therefore, all machines that >> want to support virtio-pmem will have

Re: [Qemu-devel] [PATCH 0/2] RFC: object: recommend a few type check macros

2018-09-24 Thread Igor Mammedov
On Fri, 21 Sep 2018 15:13:30 +0400 Marc-André Lureau wrote: > Hi, > > This is a readability suggestion. See the first patch for the doc > change, and the second patch for an example of usage and readability > improvement. Looks like a nice improvement, but could you conversion tree wide so we

Re: [Qemu-devel] [PATCH 3/3] virtio-pmem: Add virtio pmem driver

2018-09-24 Thread Pankaj Gupta
Hi Dan, Thanks for the review. Please find my reply inline. > > This patch adds virtio-pmem driver for KVM guest. > > > > Guest reads the persistent memory range information from > > Qemu over VIRTIO and registers it on nvdimm_bus. It also > > creates a nd_region object with the persistent

Re: [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype

2018-09-24 Thread David Hildenbrand
On 24/09/2018 07:45, David Gibson wrote: > On Thu, Sep 20, 2018 at 12:32:38PM +0200, David Hildenbrand wrote: >> From: Pankaj Gupta >> >> This is the current protoype of virtio-pmem. Support will require >> machine changes for the architectures that will support it, so it will >> not yet be

Re: [Qemu-devel] [PATCH v3 07/22] memory-device: add and use memory_device_get_region_size()

2018-09-24 Thread David Hildenbrand
On 21/09/2018 10:38, David Gibson wrote: > On Fri, Sep 21, 2018 at 09:15:09AM +0200, David Hildenbrand wrote: >> -mr = ddc->get_memory_region(dimm, errp); -if (!mr) { +value = memory_device_get_region_size(MEMORY_DEVICE(obj), errp); >>> >>> Given the below, that

[Qemu-devel] [PATCH] hostmem-file: make available memory-backend-file on macOS hosts

2018-09-24 Thread hikarupsp
From: Hikaru Nishida Before this change, memory-backend-file object is invalid for macOS hosts because hostmem-file.c is compiled only on Linux hosts. However, macOS hosts can support memory-backend-file object in the same way as on Linux hosts. This patch makes hostmem-file.c and related

Re: [Qemu-devel] [PATCH] hostmem-file: make available memory-backend-file on macOS hosts

2018-09-24 Thread Paolo Bonzini
On 24/09/2018 10:13, hikaru...@gmail.com wrote: > From: Hikaru Nishida > > Before this change, memory-backend-file object is invalid for macOS > hosts because hostmem-file.c is compiled only on Linux hosts. > However, macOS hosts can support memory-backend-file object in the same > way as on

Re: [Qemu-devel] [RFC] Virtio RNG: Consider changing the default entropy source to /dev/urandom?

2018-09-24 Thread Kashyap Chamarthy
On Fri, Sep 21, 2018 at 08:06:24PM +0200, Laszlo Ersek wrote: > On 09/21/18 17:43, Kashyap Chamarthy wrote: [...] > > (b) When QEMU exposes a Virtio RNG device to the guest, that device > > needs a source of entropy, and IIUC, that source needs to be > > "non-blocking" (i.e.

[Qemu-devel] [Bug 1498144] Re: Failure booting hurd with qemu-system-i386 on ARM

2018-09-24 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] virtio-net sporadic error with QNX 7.0 guest: virtio-net ctrl missing headers

2018-09-24 Thread Claudio
Hello all, I am following this with QNX as a guest driver bug. Thank you, Claudio On 09/17/2018 08:57 AM, Claudio wrote: > Hello Michael, > > On 09/12/2018 07:26 PM, Michael S. Tsirkin wrote: >> On Wed, Sep 12, 2018 at 07:12:58PM +0200, Claudio wrote: >>> Hi Michael, >>> >>> On 09/12/2018

[Qemu-devel] [PATCH 1/3] Revert "check: Move wdt_ib700 test to common"

2018-09-24 Thread Thomas Huth
This reverts commit ee1f6c812b3240420dff07a3860060b7d4abfe09. The patch did not work as expected: The wdt_ib700 test is currently not run at all anymore. Signed-off-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] QEMU and Kconfig

2018-09-24 Thread Samuel Ortiz
Hi All, It seems that back in 2013, Paolo tried to start a GSoC project [1] aimed at integrating Kconfig into QEMU and use it as its main configuration framework. I personally think that the rationale described in this GSoC project is still valid today. However I'm not sure the project even

[Qemu-devel] [Bug 1502884] Re: Super important feature req: QEMU VNC server: Introduce a keyboard "norepeat" option!

2018-09-24 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1502884 Title: Super important feature req: QEMU VNC server: Introduce a keyboard

[Qemu-devel] [Bug 1332234] Re: qemu-system-ppc no longer able to read real cdrom

2018-09-24 Thread Thomas Huth
According to https://bugs.launchpad.net/qemu/+bug/588691 CD-ROM drives should be working again, so I assume we can close this bug nowadays? Or can you still reproduce it with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification

Re: [Qemu-devel] [PATCH v9 2/2] target: arm: Add support for VCPU event states

2018-09-24 Thread gengdongjiu
Hi Andrew, Thanks for the review and comments. [...] > > @@ -600,6 +605,60 @@ int kvm_arm_cpreg_level(uint64_t regidx) > > #define AARCH64_SIMD_CTRL_REG(x) (KVM_REG_ARM64 | KVM_REG_SIZE_U32 | \ > > KVM_REG_ARM_CORE | KVM_REG_ARM_CORE_REG(x)) > > > > +static int

Re: [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype

2018-09-24 Thread Pankaj Gupta
> On 24/09/2018 07:45, David Gibson wrote: > > On Thu, Sep 20, 2018 at 12:32:38PM +0200, David Hildenbrand wrote: > >> From: Pankaj Gupta > >> > >> This is the current protoype of virtio-pmem. Support will require > >> machine changes for the architectures that will support it, so it will > >>

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-24 Thread Pavel Dovgalyuk
> From: Markus Armbruster [mailto:arm...@redhat.com] > Pavel Dovgalyuk writes: > > > This patch introduces replay_break qmp and hmp commands. > > These commands allow stopping at the specified instruction. > > It may be useful for debugging when there are some known > > events that should be

Re: [Qemu-devel] [PATCH v3 18/22] virtio-pci: proxy for virtio-pmem

2018-09-24 Thread David Gibson
On Thu, Sep 20, 2018 at 12:32:39PM +0200, David Hildenbrand wrote: > From: Pankaj Gupta > > We need a proxy device for virtio-pmem. > > Signed-off-by: Pankaj Gupta > [ split up patches ] > Signed-off-by: David Hildenbrand Reviewed-by: David Gibson > --- > hw/virtio/virtio-pci.c | 41

Re: [Qemu-devel] [PATCH v3 21/22] virtio-pmem: hotplug support functions

2018-09-24 Thread David Gibson
On Thu, Sep 20, 2018 at 12:32:42PM +0200, David Hildenbrand wrote: > virtio-pmem devices will have to be hotplugged using the machine hotplug > handler just like other memory devices. Therefore, all machines that > want to support virtio-pmem will have to modify their machine hotplug > handler. >

[Qemu-devel] [PATCH 3/3] Revert "check: Move VMXNET3 test to common"

2018-09-24 Thread Thomas Huth
This reverts commit 7a066770f53c198014add869696427f81d67e9c2. The patch did not work as expected: The vmxnet3 test is currently not run at all anymore. Signed-off-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 2/3] Revert "check: Move endianess test to common"

2018-09-24 Thread Thomas Huth
This reverts commit 669cc7100065c690cb7b4f3da5cfc471d1ed4740. The patch did not work as expected: The endianess test is currently not run at all anymore. Signed-off-by: Thomas Huth --- tests/Makefile.include | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 0/3] Re-enable wdt_ib700, endianness and vmxnet3 tests

2018-09-24 Thread Thomas Huth
The recent clean-up in the tests/Makefile.include file disabled some tests accidentally: Adding tests directly to check-qtest-y does not work since the variable is overwritten at the end of the file again. Also the Makefile is only included once and not per target architecture, so adding the tests

Re: [Qemu-devel] [PULL 00/19] next batch of s390x changes

2018-09-24 Thread Peter Maydell
On 29 August 2018 at 10:41, Cornelia Huck wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the Git repository at:

Re: [Qemu-devel] [PATCH 04/11] hw/arm/aspeed: add a 'mmio-exec' property to boot from the FMC flash module

2018-09-24 Thread Peter Maydell
On 19 September 2018 at 11:19, Cédric Le Goater wrote: > These are the number of read operations done on the flash memory region : > > 922478 ~ 3.5 MBytes OpenBMC U-Boot > 20569977 ~ 80 MBytes Mainline U-Boot > > > So we are trashing the TBs I would say. Is there a way to increase the

Re: [Qemu-devel] [PATCH v3 06/22] memory-device: document MemoryDeviceClass

2018-09-24 Thread David Hildenbrand
On 24/09/2018 14:22, Igor Mammedov wrote: > On Thu, 20 Sep 2018 12:32:27 +0200 > David Hildenbrand wrote: > >> Document the functions and when to not expect errors. >> >> Signed-off-by: David Hildenbrand >> --- >> include/hw/mem/memory-device.h | 13 + >> 1 file changed, 13

[Qemu-devel] [PATCH] hw/timer/cmsdk-apb-dualtimer: Add missing 'break' statements

2018-09-24 Thread Peter Maydell
Add 'break' statements missing from a switch in the APB dual-timer write function. Spotted by Coverity as CID 1395626 and 1395633. Reported-by: Paolo Bonzini Signed-off-by: Peter Maydell --- hw/timer/cmsdk-apb-dualtimer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Qemu-devel] [PATCH v3 06/22] memory-device: document MemoryDeviceClass

2018-09-24 Thread Igor Mammedov
On Mon, 24 Sep 2018 14:26:23 +0200 David Hildenbrand wrote: > On 24/09/2018 14:22, Igor Mammedov wrote: > > On Thu, 20 Sep 2018 12:32:27 +0200 > > David Hildenbrand wrote: > > > >> Document the functions and when to not expect errors. > >> > >> Signed-off-by: David Hildenbrand > >> --- > >>

Re: [Qemu-devel] [PULL 0/9] Removal of deprecated options and improvements for qtests

2018-09-24 Thread Thomas Huth
On 2018-09-24 14:35, Peter Maydell wrote: > On 24 September 2018 at 13:29, Thomas Huth wrote: >> On 2018-09-24 14:24, Peter Maydell wrote: >>> Applied, thanks. >> >> Oops, I was just about to send a v2 for this (since Markus had some >> complaints about one of the patches)... I guess we should

Re: [Qemu-devel] [PATCH v1 0/8] MemoryDevice: introduce and use ResourceHandler

2018-09-24 Thread David Hildenbrand
On 10/05/2018 15:32, Igor Mammedov wrote: > On Thu, 10 May 2018 15:20:55 +0200 > David Hildenbrand wrote: > >> On 10.05.2018 15:02, Igor Mammedov wrote: >>> On Wed, 9 May 2018 16:13:14 +0200 >>> David Hildenbrand wrote: >>> On 03.05.2018 17:49, David Hildenbrand wrote: > Hotplug

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-24 Thread Markus Armbruster
"Pavel Dovgalyuk" writes: >> From: Markus Armbruster [mailto:arm...@redhat.com] >> Pavel Dovgalyuk writes: >> >> > This patch introduces replay_break qmp and hmp commands. >> > These commands allow stopping at the specified instruction. >> > It may be useful for debugging when there are some

Re: [Qemu-devel] [PULL 0/1] qemu-openbios.for-upstream queue 20180831

2018-09-24 Thread Peter Maydell
On 31 August 2018 at 12:32, Mark Cave-Ayland wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the git repository

Re: [Qemu-devel] [PATCH v3 08/22] memory-device: factor out get_memory_region() from pc-dimm

2018-09-24 Thread Igor Mammedov
On Thu, 20 Sep 2018 12:32:29 +0200 David Hildenbrand wrote: > The memory region is necessary for plugging/unplugging a memory device. > The region size (via get_region_size()) is no longer sufficient, as > besides the alignment, also the region itself is required in order to > add it to the

Re: [Qemu-devel] [PULL 0/6] QAPI patches for 2018-08-28

2018-09-24 Thread Peter Maydell
On 28 August 2018 at 20:10, Markus Armbruster wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the Git repository

Re: [Qemu-devel] [PULL 21/52] hw/timer/cmsdk-apb-dualtimer: Implement CMSDK dual timer module

2018-09-24 Thread Peter Maydell
On 9 September 2018 at 21:34, Paolo Bonzini wrote: > On 24/08/2018 11:33, Peter Maydell wrote: >> ze); >> + >> + if (offset >= A_TIMERITCR) { >> + switch (offset) { >> + case A_TIMERITCR: >> + s->timeritcr = value & R_TIMERITCR_VALID_MASK; >> + cmsdk_apb_dualtimer_update(s); >> + case

Re: [Qemu-devel] [PULL 0/9] Removal of deprecated options and improvements for qtests

2018-09-24 Thread Peter Maydell
On 24 September 2018 at 13:29, Thomas Huth wrote: > On 2018-09-24 14:24, Peter Maydell wrote: >> Applied, thanks. > > Oops, I was just about to send a v2 for this (since Markus had some > complaints about one of the patches)... I guess we should revert "tests: > add qmp/qom-set-without-value

Re: [Qemu-devel] [PATCH v3 05/22] memory-device: forward errors in get_region_size()/get_plugged_size()

2018-09-24 Thread Igor Mammedov
On Thu, 20 Sep 2018 12:32:26 +0200 David Hildenbrand wrote: > Let's properly forward the errors, so errors from get_region_size() / > get_plugged_size() can be handled. > > Users right now call both functions after the device has been realized, > which is will never fail, so it is fine to

[Qemu-devel] [PATCH v2] hostmem-file: make available memory-backend-file on POSIX-based hosts

2018-09-24 Thread hikarupsp
From: Hikaru Nishida Before this change, memory-backend-file object is valid for Linux hosts only because hostmem-file.c is compiled only on Linux hosts. However, other POSIX-based hosts (such as macOS) can support memory-backend-file object in the same way as on Linux hosts. This patch makes

Re: [Qemu-devel] [PATCH v3 06/22] memory-device: document MemoryDeviceClass

2018-09-24 Thread Igor Mammedov
On Mon, 24 Sep 2018 14:40:24 +0200 David Hildenbrand wrote: > On 24/09/2018 14:39, Igor Mammedov wrote: > > On Mon, 24 Sep 2018 14:26:23 +0200 > > David Hildenbrand wrote: > > > >> On 24/09/2018 14:22, Igor Mammedov wrote: > >>> On Thu, 20 Sep 2018 12:32:27 +0200 > >>> David Hildenbrand

Re: [Qemu-devel] [PATCH] hostmem-file: make available memory-backend-file on macOS hosts

2018-09-24 Thread Hikaru Nishida
Thank you for letting me know about CONFIG_POSIX. I'll fix my patch to utilize it and submit again. Hikaru Nishida 2018年9月24日(月) 17:51 Paolo Bonzini : > > On 24/09/2018 10:13, hikaru...@gmail.com wrote: > > From: Hikaru Nishida > > > > Before this change, memory-backend-file object is invalid

Re: [Qemu-devel] [PATCH v3 07/22] memory-device: add and use memory_device_get_region_size()

2018-09-24 Thread Igor Mammedov
On Mon, 24 Sep 2018 11:03:35 +0200 David Hildenbrand wrote: > On 21/09/2018 10:38, David Gibson wrote: > > On Fri, Sep 21, 2018 at 09:15:09AM +0200, David Hildenbrand wrote: > >> > > -mr = ddc->get_memory_region(dimm, errp); > -if (!mr) { > +value =

Re: [Qemu-devel] [PATCH 0/3] Re-enable wdt_ib700, endianness and vmxnet3 tests

2018-09-24 Thread Paolo Bonzini
On 24/09/2018 09:42, Thomas Huth wrote: > The recent clean-up in the tests/Makefile.include file disabled some > tests accidentally: Adding tests directly to check-qtest-y does not > work since the variable is overwritten at the end of the file again. > Also the Makefile is only included once and

Re: [Qemu-devel] [PATCH v3 06/22] memory-device: document MemoryDeviceClass

2018-09-24 Thread Igor Mammedov
On Thu, 20 Sep 2018 12:32:27 +0200 David Hildenbrand wrote: > Document the functions and when to not expect errors. > > Signed-off-by: David Hildenbrand > --- > include/hw/mem/memory-device.h | 13 + > 1 file changed, 13 insertions(+) > > diff --git

Re: [Qemu-devel] [PULL 0/9] Removal of deprecated options and improvements for qtests

2018-09-24 Thread Thomas Huth
On 2018-09-24 14:24, Peter Maydell wrote: > On 31 August 2018 at 09:38, Thomas Huth wrote: >> Hi Peter! >> >> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: >> >> Merge remote-tracking branch >> 'remotes/armbru/tags/pull-error-2018-08-27-v2' into staging

Re: [Qemu-devel] [PATCH v3 06/22] memory-device: document MemoryDeviceClass

2018-09-24 Thread David Hildenbrand
On 24/09/2018 14:39, Igor Mammedov wrote: > On Mon, 24 Sep 2018 14:26:23 +0200 > David Hildenbrand wrote: > >> On 24/09/2018 14:22, Igor Mammedov wrote: >>> On Thu, 20 Sep 2018 12:32:27 +0200 >>> David Hildenbrand wrote: >>> Document the functions and when to not expect errors.

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-24 Thread Peter Maydell
On 24 September 2018 at 14:02, Markus Armbruster wrote: > "Pavel Dovgalyuk" writes: >> This is a doxygen-style comment for automatic documentation generation. > > We don't generate documentation, yet. > > We do have many GTKDoc-style comments. Perhaps because we hope that if > we only add

Re: [Qemu-devel] [PATCH 2/3] libnvdimm: nd_region flush callback support

2018-09-24 Thread Pankaj Gupta
> > This patch adds functionality to perform flush from guest > > to host over VIRTIO. We are registering a callback based > > on 'nd_region' type. virtio_pmem driver requires this special > > flush function. For rest of the region types we are registering > > existing flush function. Report

Re: [Qemu-devel] [PATCH 1/3] nd: move nd_region to common header

2018-09-24 Thread Pankaj Gupta
> Subject: Re: [PATCH 1/3] nd: move nd_region to common header > > On Fri, Aug 31, 2018 at 6:31 AM Pankaj Gupta wrote: > > > > This patch moves nd_region definition to common header > > include/linux/nd.h file. This is required for flush callback > > support for both virtio-pmem & pmem driver.

Re: [Qemu-devel] [PULL 0/9] Removal of deprecated options and improvements for qtests

2018-09-24 Thread Peter Maydell
On 31 August 2018 at 09:38, Thomas Huth wrote: > Hi Peter! > > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the git

Re: [Qemu-devel] [PATCH v3 06/22] memory-device: document MemoryDeviceClass

2018-09-24 Thread David Hildenbrand
On 24/09/2018 15:19, Igor Mammedov wrote: > On Mon, 24 Sep 2018 14:40:24 +0200 > David Hildenbrand wrote: > >> On 24/09/2018 14:39, Igor Mammedov wrote: >>> On Mon, 24 Sep 2018 14:26:23 +0200 >>> David Hildenbrand wrote: >>> On 24/09/2018 14:22, Igor Mammedov wrote: > On Thu, 20

Re: [Qemu-devel] [PATCH v10 8/9] qcow2: Set the default cache-clean-interval to 10 minutes

2018-09-24 Thread Alberto Garcia
On Fri 21 Sep 2018 07:23:09 PM CEST, Leonid Bloch wrote: > The default cache-clean-interval is set to 10 minutes, in order to lower > the overhead of the qcow2 caches (before the default was 0, i.e. > disabled). > > * For non-Linux platforms the default is kept at 0, because >

Re: [Qemu-devel] [PATCH v3 12/22] memory-device: complete factoring out plug handling

2018-09-24 Thread Igor Mammedov
On Thu, 20 Sep 2018 12:32:33 +0200 David Hildenbrand wrote: > With the new memory device functions in place, we can factor out > plugging of memory devices completely. > > Signed-off-by: David Hildenbrand > --- > hw/mem/memory-device.c | 10 +++--- > hw/mem/pc-dimm.c

Re: [Qemu-devel] [PATCH v10 2/9] include: Add a lookup table of sizes

2018-09-24 Thread Alberto Garcia
On Fri 21 Sep 2018 07:23:03 PM CEST, Leonid Bloch wrote: > Adding a lookup table for the powers of two, with the appropriate size > prefixes. This is needed when a size has to be stringified, in which > case something like '(1 * KiB)' would become a literal '(1 * (1L << 10))' > string. Powers of

Re: [Qemu-devel] [PATCH v10 2/9] include: Add a lookup table of sizes

2018-09-24 Thread Eric Blake
On 9/21/18 12:23 PM, Leonid Bloch wrote: Adding a lookup table for the powers of two, with the appropriate size prefixes. This is needed when a size has to be stringified, in which case something like '(1 * KiB)' would become a literal '(1 * (1L << 10))' string. Powers of two are used very often

Re: [Qemu-devel] [PATCH v3 15/22] hw/acpi-build: only indicate nvdimm and pc-dimm

2018-09-24 Thread Igor Mammedov
On Thu, 20 Sep 2018 12:32:36 +0200 David Hildenbrand wrote: > Once we have other memory devices that are not ACPI devices (e.g. > virtio based), we cannot indicate them via ACPI. So let's skip these > devices. > > Signed-off-by: David Hildenbrand dimm specific entries in SRAT will be removed

Re: [Qemu-devel] [PATCH 04/11] hw/arm/aspeed: add a 'mmio-exec' property to boot from the FMC flash module

2018-09-24 Thread Cédric Le Goater
On 09/24/2018 01:41 PM, Peter Maydell wrote: > On 19 September 2018 at 11:19, Cédric Le Goater wrote: >> These are the number of read operations done on the flash memory region : >> >> 922478 ~ 3.5 MBytes OpenBMC U-Boot >> 20569977 ~ 80 MBytes Mainline U-Boot >> >> >> So we are

Re: [Qemu-devel] [PATCH v3 14/22] memory-device: trace when pre_assigning/assigning/unassigning addresses

2018-09-24 Thread Igor Mammedov
On Thu, 20 Sep 2018 12:32:35 +0200 David Hildenbrand wrote: > Let's trace the address when pre_pluggin/plugging/unplugging a memory device. > > Trace it when pre_plugging as well as when plugging, so we really know > when a specific address is actually used. > > Signed-off-by: David

Re: [Qemu-devel] [PULL 0/6] Monitor patches for 2018-09-01

2018-09-24 Thread Peter Maydell
On 1 September 2018 at 12:17, Markus Armbruster wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the Git

[Qemu-devel] [Bug 1794086] [NEW] readlink(2) returns invalid size for /proc/self/exe

2018-09-24 Thread Oleg Andriyanov
Public bug reported: readlink(2) seems to ignore the size of supplied buffer for the resolved name and always returns the actual size of the resolved name instead. Steps to reproduce: ```bash echo '#include #include #include int main(int argc, const char** argv) { if(argc < 2) exit(1);

Re: [Qemu-devel] [PATCH v3 09/22] memory-device: drop get_region_size()

2018-09-24 Thread Igor Mammedov
On Fri, 21 Sep 2018 09:19:17 +0200 David Hildenbrand wrote: > On 21/09/2018 07:19, David Gibson wrote: > > On Thu, Sep 20, 2018 at 12:32:30PM +0200, David Hildenbrand wrote: > >> We now have get_memory_region(), which can be used generically to detect > >> the region size. Use

Re: [Qemu-devel] [PATCH v3 10/22] memory-device: add device class function set_addr()

2018-09-24 Thread Igor Mammedov
On Thu, 20 Sep 2018 12:32:31 +0200 David Hildenbrand wrote: > To be able to factor out address asignment of memory devices, we will > have to read (get_addr()) and write (set_addr()) the address. > > We can't use properties for this purpose, as properties are device > specific. E.g. while the

Re: [Qemu-devel] [PATCH v3 08/10] block: Allow changing 'discard' on reopen

2018-09-24 Thread Alberto Garcia
On Mon 24 Sep 2018 03:43:10 PM CEST, Max Reitz wrote: > On 19.09.18 11:18, Alberto Garcia wrote: >> On Thu 06 Sep 2018 11:37:08 AM CEST, Alberto Garcia wrote: >>> 'discard' is one of the basic BlockdevOptions available for all >>> drivers, but it's not handled by bdrv_reopen_prepare() so any

Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/timer/cmsdk-apb-dualtimer: Add missing 'break' statements

2018-09-24 Thread Philippe Mathieu-Daudé
On 9/24/18 2:31 PM, Peter Maydell wrote: > Add 'break' statements missing from a switch in the APB dual-timer > write function. Spotted by Coverity as CID 1395626 and 1395633. > > Reported-by: Paolo Bonzini > Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > --- >

Re: [Qemu-devel] [PATCH 04/11] hw/arm/aspeed: add a 'mmio-exec' property to boot from the FMC flash module

2018-09-24 Thread Cédric Le Goater
On 09/24/2018 03:31 PM, Peter Maydell wrote: > On 24 September 2018 at 14:28, Cédric Le Goater wrote: >> On 09/24/2018 01:41 PM, Peter Maydell wrote: >>> On 19 September 2018 at 11:19, Cédric Le Goater wrote: These are the number of read operations done on the flash memory region :

Re: [Qemu-devel] [PULL v2 00/10] Block patches

2018-09-24 Thread Peter Maydell
On 31 August 2018 at 15:32, Max Reitz wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH v10 1/9] qcow2: Options' documentation fixes

2018-09-24 Thread Alberto Garcia
On Fri 21 Sep 2018 07:23:02 PM CEST, Leonid Bloch wrote: > Signed-off-by: Leonid Bloch > --- > docs/qcow2-cache.txt | 20 +--- > qemu-options.hx | 9 ++--- > 2 files changed, 19 insertions(+), 10 deletions(-) > > diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt

[Qemu-devel] [PULL 3/4] Drop "qemu:" prefix from error_report() arguments

2018-09-24 Thread Markus Armbruster
From: Mao Zhongyi error_report and friends already add a "qemu-system-xxx" prefix to the string, so a "qemu:" prefix is redundant in the string. Just drop it. Reported-by: Thomas Huth Signed-off-by: Mao Zhongyi Reviewed-by: Eduardo Habkost Message-Id:

[Qemu-devel] [PULL 0/4] Error reporting & miscellaneous patches for 2018-09-24

2018-09-24 Thread Markus Armbruster
The following changes since commit d6f71af65410d3e003ba331c5e57eddcf716cbcf: Merge remote-tracking branch 'remotes/xanclic/tags/pull-block-2018-08-31-v2' into staging (2018-09-24 14:35:58 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git

Re: [Qemu-devel] [PULL 0/9] Removal of deprecated options and improvements for qtests

2018-09-24 Thread Peter Maydell
On 24 September 2018 at 13:38, Thomas Huth wrote: > On 2018-09-24 14:35, Peter Maydell wrote: >> On 24 September 2018 at 13:29, Thomas Huth wrote: >>> On 2018-09-24 14:24, Peter Maydell wrote: Applied, thanks. >>> >>> Oops, I was just about to send a v2 for this (since Markus had some >>>

Re: [Qemu-devel] [Bug 1332234] Re: qemu-system-ppc no longer able to read real cdrom

2018-09-24 Thread John Arbuckle
> On Sep 24, 2018, at 5:14 AM, Thomas Huth <1332...@bugs.launchpad.net> wrote: > > According to https://bugs.launchpad.net/qemu/+bug/588691 CD-ROM drives > should be working again, so I assume we can close this bug nowadays? Or > can you still reproduce it with the latest version of QEMU? > > **

[Qemu-devel] [PULL 1/4] qemu-error: add {error, warn}_report_once_cond

2018-09-24 Thread Markus Armbruster
From: Cornelia Huck Add two functions to print an error/warning report once depending on a passed-in condition variable and flip it if printed. This is useful if you want to print a message not once-globally, but e.g. once-per-device. Inspired by warn_once() in hw/vfio/ccw.c, which has been

[Qemu-devel] [PULL 4/4] MAINTAINERS: Fix F: patterns that don't match anything

2018-09-24 Thread Markus Armbruster
Commit ba51ef25571 moved hw/dma/sun4m_iommu.c to hw/sparc/sun4m_iommu.c without updating MAINTAINERS. Commit f5980f757c0 deleted include/hw/sparc/sun4m.h without updating MAINTAINERS. Commit 0bcc8e5bd8d fat-fingered tests/check-block-qdict.c. Commit 33e9e9bd62d fat-fingered include/qemu/job.h.

[Qemu-devel] [PULL 2/4] qemu-error: make use of {error, warn}_report_once_cond

2018-09-24 Thread Markus Armbruster
From: Cornelia Huck {error,warn}_report_once() are a special case of the new functions and can simply switch to them. Signed-off-by: Cornelia Huck Message-Id: <20180830145902.27376-3-coh...@redhat.com> Reviewed-by: Markus Armbruster [Dispense with unlikely() to keep the macros as simple as

Re: [Qemu-devel] [PATCH v3 08/10] block: Allow changing 'discard' on reopen

2018-09-24 Thread Max Reitz
On 19.09.18 11:18, Alberto Garcia wrote: > On Thu 06 Sep 2018 11:37:08 AM CEST, Alberto Garcia wrote: >> 'discard' is one of the basic BlockdevOptions available for all >> drivers, but it's not handled by bdrv_reopen_prepare() so any attempt >> to change it results in an error: >> >>(qemu)

Re: [Qemu-devel] [PATCH 1/2] monitor: guard iothread access by mon->use_io_thread

2018-09-24 Thread Eric Blake
On 9/21/18 3:28 AM, Wolfgang Bumiller wrote: monitor_resume() and monitor_suspend() both want to "kick" the I/O thread if it is there, but in monitor_suspend() lacked the use_io_thread flag condition. This is required when we later only spawn the thread on first use. When sending a

Re: [Qemu-devel] [PATCH v5 0/8] target/mips: Support R5900 GCC programs in user mode

2018-09-24 Thread Fredrik Noring
Hi Philippe, > > That would be programs not compiled by GCC, as explained in the first > > sentence of the body text. The subject line is very brief by necessity > > since it is limited to 72 or so characters. It was an attempt to qualify > > the subject line "initial support for MIPS R5900",

Re: [Qemu-devel] [Qemu-arm] [PULL 0/5] Vga 20180903 patches

2018-09-24 Thread Peter Maydell
On 3 September 2018 at 07:57, Gerd Hoffmann wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the git repository

[Qemu-devel] [PULL 0/6] QObject patches for 2018-09-24

2018-09-24 Thread Markus Armbruster
The following changes since commit d5a515738ee2dec0cdf11d8a14a09abae6c20571: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20180903-pull-request' into staging (2018-09-24 16:15:26 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git

Re: [Qemu-devel] [PATCH v10 2/9] include: Add a lookup table of sizes

2018-09-24 Thread Leonid Bloch
On 9/24/18 5:09 PM, Eric Blake wrote: > On 9/21/18 12:23 PM, Leonid Bloch wrote: >> Adding a lookup table for the powers of two, with the appropriate size >> prefixes. This is needed when a size has to be stringified, in which >> case something like '(1 * KiB)' would become a literal '(1 * (1L <<

Re: [Qemu-devel] [PATCH v10 6/9] qcow2: Increase the default upper limit on the L2 cache size

2018-09-24 Thread Alberto Garcia
On Fri 21 Sep 2018 07:23:07 PM CEST, Leonid Bloch wrote: > The upper limit on the L2 cache size is increased from 1 MB to 32 MB > on Linux platforms, and to 8 MB on other platforms (this difference is > caused by the ability to set intervals for cache cleaning on Linux > platforms only). > > This

Re: [Qemu-devel] [PATCH v10 1/9] qcow2: Options' documentation fixes

2018-09-24 Thread Leonid Bloch
On 9/24/18 6:04 PM, Alberto Garcia wrote: > On Fri 21 Sep 2018 07:23:02 PM CEST, Leonid Bloch wrote: >> Signed-off-by: Leonid Bloch >> --- >> docs/qcow2-cache.txt | 20 +--- >> qemu-options.hx | 9 ++--- >> 2 files changed, 19 insertions(+), 10 deletions(-) >> >>

Re: [Qemu-devel] [PATCH 3/3] linux-user: implement special usbfs ioctls.

2018-09-24 Thread Laurent Vivier
Le 19/09/2018 à 10:04, Cortland Tölva a écrit : > Userspace submits a USB Request Buffer to the kernel, optionally > discards it, and finally reaps the URB. Thunk buffers from target > to host and back. > > Tested by running an i386 scanner driver on ARMv7. Neither the > discardurb ioctl nor

Re: [Qemu-devel] [PULL 00/14] ppc-for-3.1 queue 20180907

2018-09-24 Thread Peter Maydell
On 7 September 2018 at 08:31, David Gibson wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the Git repository

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-24 Thread Peter Maydell
On 24 September 2018 at 17:50, Paolo Bonzini wrote: > On 24/09/2018 15:12, Peter Maydell wrote: >> It got bumped by more important things >> and also because somebody else said they were going to look at it, >> and then it got bumped off *their* todo list by more important >> things :-)) > > I

Re: [Qemu-devel] [PATCH 1/3] Check for Linux USBFS in configure

2018-09-24 Thread Laurent Vivier
Le 23/09/2018 à 06:44, Blake Tölva a écrit : > Thanks Laurent, I have updated the patch. Should I resend the whole > series to the list? yes. > I believe the third patch may also need revision as the call to > thunk_convert at the end > of do_ioctl_usbdevfs_reapurb seems clunky. Would love

Re: [Qemu-devel] [RFC v5 0/6] pci_expander_brdige: support separate pci domain for pxb-pcie

2018-09-24 Thread Zihan Yang
Marcel Apfelbaum 于2018年9月20日周四 下午2:41写道: > > Hi Zihan, Gerd > > On 09/20/2018 09:09 AM, Gerd Hoffmann wrote: > As for the management, will some checks when adding mcfg be enough for > management? Or I can maintain a variable to indicate how many space > have been consumed and warn

[Qemu-devel] [PULL 1/6] json: Fix lexer for lookahead character beyond '\x7F'

2018-09-24 Thread Markus Armbruster
The lexer fails to end a valid token when the lookahead character is beyond '\x7F'. For instance, input true\xC2\xA2 produces the tokens JSON_ERROR true\xC2 JSON_ERROR \xA2 This should be JSON_KEYWORD true JSON_ERROR \xC2 JSON_ERROR \xA2 instead.

Re: [Qemu-devel] [PATCH v3 18/19] block: Use a single global AioWait

2018-09-24 Thread Max Reitz
On 20.09.18 18:19, Kevin Wolf wrote: > When draining a block node, we recurse to its parent and for subtree > drains also to its children. A single AIO_WAIT_WHILE() is then used to > wait for bdrv_drain_poll() to become true, which depends on all of the > nodes we recursed to. However, if the

[Qemu-devel] [Bug 1332234] Re: qemu-system-ppc no longer able to read real cdrom

2018-09-24 Thread Thomas Huth
** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1332234 Title: qemu-system-ppc no longer able to read real cdrom Status in QEMU: Fix

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-24 Thread Paolo Bonzini
On 24/09/2018 15:12, Peter Maydell wrote: > It got bumped by more important things > and also because somebody else said they were going to look at it, > and then it got bumped off *their* todo list by more important > things :-)) I sense the force calling me... Well, my plans were did not

Re: [Qemu-devel] [PATCH v10 3/9] qcow2: Make sizes more humanly readable

2018-09-24 Thread Eric Blake
On 9/21/18 12:23 PM, Leonid Bloch wrote: Signed-off-by: Leonid Bloch Reviewed-by: Alberto Garcia --- block/qcow2.c | 2 +- block/qcow2.h | 9 + 2 files changed, 6 insertions(+), 5 deletions(-) +++ b/block/qcow2.h @@ -27,6 +27,7 @@ #include "crypto/block.h" #include

Re: [Qemu-devel] [PATCH v3 19/19] test-bdrv-drain: Test draining job source child and parent

2018-09-24 Thread Max Reitz
On 20.09.18 18:19, Kevin Wolf wrote: > For the block job drain test, don't only test draining the source and > the target node, but create a backing chain for the source > (source_backing <- source <- source_overlay) and test draining each of > the nodes in it. > > When using iothreads, the

Re: [Qemu-devel] [RFC v5 0/6] pci_expander_brdige: support separate pci domain for pxb-pcie

2018-09-24 Thread Zihan Yang
Hi Marcel, Marcel Apfelbaum 于2018年9月20日周四 下午2:39写道: > > Hi Zihan, > > On 09/18/2018 04:41 PM, Michael S. Tsirkin wrote: > > Cc Laine, Eric for an opinion about the management interface. > > > > On Mon, Sep 17, 2018 at 10:57:31PM +0800, Zihan Yang wrote: > >> Hi all > >> > >> Here is a minimal

Re: [Qemu-devel] [PULL v2 00/10] riscv-pullreq queue

2018-09-24 Thread Peter Maydell
On 5 September 2018 at 23:09, Alistair Francis wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the Git

[Qemu-devel] [PULL 3/6] json: Make lexer's "character consumed" logic less confusing

2018-09-24 Thread Markus Armbruster
The lexer uses macro TERMINAL_NEEDED_LOOKAHEAD() to decide whether a state transition consumes the input character. It returns true when the state transition is defined with the TERMINAL() macro. To detect that, it checks whether input '\0' would have resulted in the same state transition, and

[Qemu-devel] [PULL 2/6] json: Clean up how lexer consumes "end of input"

2018-09-24 Thread Markus Armbruster
When the lexer isn't in its start state at the end of input, it's working on a token. To flush it out, it needs to transit to its start state on "end of input" lookahead. There are two ways to the start state, depending on the current state: * If the lexer is in a TERMINAL(JSON_FOO) state, it

[Qemu-devel] [PULL 6/6] json: Eliminate lexer state IN_WHITESPACE, pseudo-token JSON_SKIP

2018-09-24 Thread Markus Armbruster
The lexer ignores whitespace like this: on whitespace on non-ws spontaneously IN_START --> IN_WHITESPACE --> JSON_SKIP --> IN_START ^| \__/ on whitespace This accumulates a whitespace token in state IN_WHITESPACE, only to throw it

[Qemu-devel] [Bug 1794086] Re: readlink(2) returns incorrect size for /proc/self/exe

2018-09-24 Thread Oleg Andriyanov
** Summary changed: - readlink(2) returns invalid size for /proc/self/exe + readlink(2) returns incorrect size for /proc/self/exe -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1794086 Title:

Re: [Qemu-devel] [PATCH 2/3] Linux user mode usbfs types and defs.

2018-09-24 Thread Laurent Vivier
Le 19/09/2018 à 10:04, Cortland Tölva a écrit : > Provide ioctl definitions for the generic thunk mechanism to > convert most usbfs calls. > > Signed-off-by: Cortland Tölva > --- > linux-user/ioctls.h| 38 ++ > linux-user/syscall.c | 3 ++ >

[Qemu-devel] [PULL 5/6] json: Eliminate lexer state IN_ERROR

2018-09-24 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20180831075841.13363-6-arm...@redhat.com> --- qobject/json-lexer.c | 9 + qobject/json-parser-int.h | 8 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/qobject/json-lexer.c

[Qemu-devel] [PULL 4/6] json: Nicer recovery from lexical errors

2018-09-24 Thread Markus Armbruster
When the lexer chokes on an input character, it consumes the character, emits a JSON error token, and enters its start state. This can lead to suboptimal error recovery. For instance, input 0123 , produces the tokens JSON_ERROR01 JSON_INTEGER 23 JSON_COMMA, Make the

  1   2   >