Re: [Qemu-devel] [PATCH 3/3] ppc/pnv: check size before data buffer access

2018-10-25 Thread P J P
Hello Cedric, +-- On Wed, 24 Oct 2018, Cédric Le Goater wrote --+ | I think using a data[8] would be more appropriate. It would make the | pnv_lpc_do_eccb() routine a little more complex. I tried to rewrite it to | have a common one with the P9 LPC model but could not find a common pattern.

Re: [Qemu-devel] Call for patches for the qemu-trivial pull request

2018-10-25 Thread Thomas Huth
On 2018-10-23 11:04, Laurent Vivier wrote: > Hi, > > I'm going to collect patches for the next pull request for the > qemu-trivial I'd like to do before the softfreeze. > > As we didn't have any pull request for more than 3 months and some of > the patches have been pushed through another

[Qemu-devel] [PATCH] hw/pvrdma: Check the correct return value

2018-10-25 Thread Yuval Shaia
Return value of 0 means ok, we want to free the memory only in case of error. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c index 4faeb21631..57d6f41ae6 100644 ---

Re: [Qemu-devel] [PATCH 2/3] adlib: mark as insecure and deprecated.

2018-10-25 Thread Philippe Mathieu-Daudé
On 25/10/18 10:52, Gerd Hoffmann wrote: We have a lovely, guest-triggerable buffer overflow in opl2 emulation. Reproducer: outw(0xff60, 0x220); outw(0x1020, 0x220); outw(0xffb0, 0x220); Result: Will overflow FM_OPL->AR_TABLE[] (see hw/audio/fmopl.[ch]) The specs google

Re: [Qemu-devel] [PATCH 3/3] cirrus: mark as deprecated

2018-10-25 Thread Philippe Mathieu-Daudé
On 25/10/18 10:52, Gerd Hoffmann wrote: While being at it deprecate cirrus too. Reason (short version): use stdvga instead. Verbose version: https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful Signed-off-by: Gerd Hoffmann --- hw/display/cirrus_vga.c | 2 ++

Re: [Qemu-devel] Call for patches for the qemu-trivial pull request

2018-10-25 Thread Laurent Vivier
On 25/10/2018 07:56, Thomas Huth wrote: > On 2018-10-23 11:04, Laurent Vivier wrote: >> Hi, >> >> I'm going to collect patches for the next pull request for the >> qemu-trivial I'd like to do before the softfreeze. >> >> As we didn't have any pull request for more than 3 months and some of >> the

[Qemu-devel] [PULL v2 07/43] hw/ssi/xilinx_spi: Use DeviceState::realize rather than SysBusDevice::init

2018-10-25 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Move from the legacy SysBusDevice::init method to using DeviceState::realize. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Cédric Le Goater Message-Id: <20181002212522.23303-5-f4...@amsat.org> Signed-off-by: Eduardo Habkost ---

[Qemu-devel] [PULL v2 08/43] hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init

2018-10-25 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Move from the legacy SysBusDevice::init method to using DeviceState::realize. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20181002212522.23303-6-f4...@amsat.org> Reviewed-by: Peter Maydell Signed-off-by: Eduardo Habkost --- hw/sh4/sh_pci.c | 20

Re: [Qemu-devel] [PATCH 1/1] i386: Add PKU/OSPKE on Skylake-Server CPU model

2018-10-25 Thread Eduardo Habkost
On Wed, Oct 17, 2018 at 12:48:58PM +0200, Paolo Bonzini wrote: > On 17/10/2018 11:30, Tao Xu wrote: > > As the release document ref below link (page 13): > > https://software.intel.com/sites/default/files/managed/c5/15/\ > > architecture-instruction-set-extensions-programming-reference.pdf > > >

[Qemu-devel] [Bug 1793859] Re: GTK display and mouse input area scaling fails when using vfio-pci device

2018-10-25 Thread Chen Zhang
Hi, I have a hack for this issue. In general, the gvt-g is buggy in that the kernel driver i915 failed to provide the actual resolution for the vgpu and always report the largest available one. The following patch modified the gtk-egl implementation for DMA Buf mode, to convert mouse

[Qemu-devel] [RFC v4 69/71] cputlb: queue async flush jobs without the BQL

2018-10-25 Thread Emilio G. Cota
This yields sizable scalability improvements, as the below results show. Host: Two Intel E5-2683 v3 14-core CPUs at 2.00 GHz (Haswell) Workload: Ubuntu 18.04 ppc64 compiling the linux kernel with "make -j N", where N is the number of cores in the guest. Speedup vs a single

[Qemu-devel] [RFC v4 64/71] sparc: convert to cpu_has_work_with_iothread_lock

2018-10-25 Thread Emilio G. Cota
Soon we will call cpu_has_work without the BQL. Cc: Mark Cave-Ayland Cc: Artyom Tarasenko Signed-off-by: Emilio G. Cota --- target/sparc/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c index 88427283c1..54bffc1a6c 100644 ---

[Qemu-devel] [RFC v4 65/71] xtensa: convert to cpu_has_work_with_iothread_lock

2018-10-25 Thread Emilio G. Cota
Soon we will call cpu_has_work without the BQL. Cc: Max Filippov Signed-off-by: Emilio G. Cota --- target/xtensa/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/xtensa/cpu.c b/target/xtensa/cpu.c index d4ca35e6cc..5f3b4a70b0 100644 --- a/target/xtensa/cpu.c

Re: [Qemu-devel] [PATCH 1/3] qdev: add deprecation_reason to DeviceClass

2018-10-25 Thread Philippe Mathieu-Daudé
Hi Gerd, On 25/10/18 10:52, Gerd Hoffmann wrote: Simliar to deprecated machine types. "Similar" Print a warning when creating a deprecated device. Add deprecation notice to -device help. TODO: add to intospection. "introspection" Do we want the TODO in the git history? Signed-off-by:

[Qemu-devel] [PATCH V4 1/5] hw/misc/pvpanic: Build the pvpanic device in $(common-obj)

2018-10-25 Thread Peng Hao
From: Philippe Mathieu-Daudé The 'pvpanic' ISA device can be use by any machine with an ISA bus. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs index

[Qemu-devel] [PULL v2 13/43] hw/alpha/typhoon: Remove unuseful code

2018-10-25 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20181002212522.23303-11-f4...@amsat.org> Signed-off-by: Eduardo Habkost --- hw/alpha/typhoon.c | 13 - 1 file changed, 13 deletions(-) diff --git a/hw/alpha/typhoon.c

[Qemu-devel] [PULL v2 03/43] vl:c: make sure that sockets are calculated correctly in '-smp X' case

2018-10-25 Thread Eduardo Habkost
From: Igor Mammedov commit (5cdc9b76e3 vl.c: Remove dead assignment) removed sockets calculation when 'sockets' weren't provided on CLI since there wasn't any users for it back then. Exiting checks are neither reachable } else if (sockets * cores * threads < cpus) { or nor triggerable if

[Qemu-devel] [PULL v2 28/43] memory-device: add device class function set_addr()

2018-10-25 Thread Eduardo Habkost
From: David Hildenbrand To be able to factor out address assignment of memory devices, we will have to read (get_addr()) and write (set_addr()) the address. We can't use properties for this purpose, as properties are device specific. E.g. while the address property for a DIMM is called "addr",

[Qemu-devel] [PULL v2 15/43] hw/mips/malta: Remove unuseful code

2018-10-25 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20181002212522.23303-13-f4...@amsat.org> Signed-off-by: Eduardo Habkost --- hw/mips/mips_malta.c | 13 - 1 file changed, 13 deletions(-) diff --git a/hw/mips/mips_malta.c

[Qemu-devel] [PULL v2 21/43] memory-device: use memory device terminology in error messages

2018-10-25 Thread Eduardo Habkost
From: David Hildenbrand While we rephrased most error messages, we missed these. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Igor Mammedov Reviewed-by: David Gibson Signed-off-by: David Hildenbrand Message-Id: <20181005092024.14344-6-da...@redhat.com> Signed-off-by: Eduardo Habkost

[Qemu-devel] [RFC 1/2] qdev/qbus: Add hidden device support

2018-10-25 Thread Sameeh Jubran
From: Sameeh Jubran Signed-off-by: Sameeh Jubran --- hw/core/qdev.c | 48 +++--- hw/pci/pci.c | 1 + include/hw/pci/pci.h | 2 ++ include/hw/qdev-core.h | 11 +++- qdev-monitor.c | 58 +++--- 5

[Qemu-devel] [PULL v2 26/43] memory-device: factor out get_memory_region() from pc-dimm

2018-10-25 Thread Eduardo Habkost
From: David Hildenbrand The memory region is necessary for plugging/unplugging a memory device. The region size (via get_region_size()) is no longer sufficient, as besides the alignment, also the region itself is required in order to add it to the device memory region of the machine via -

Re: [Qemu-devel] [Qemu-trivial] [PATCH 10/10] scripts/qemu.py: remove trailing quotes on docstring

2018-10-25 Thread Laurent Vivier
On 04/10/2018 17:18, Cleber Rosa wrote: > Signed-off-by: Cleber Rosa > --- > scripts/qemu.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/qemu.py b/scripts/qemu.py > index 7abe26de69..676eb9709a 100644 > --- a/scripts/qemu.py > +++ b/scripts/qemu.py > @@

[Qemu-devel] [RFC v4 50/71] s390x: convert to cpu_interrupt_request

2018-10-25 Thread Emilio G. Cota
Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Alexander Graf Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- hw/intc/s390_flic.c | 2 +- target/s390x/cpu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

[Qemu-devel] [RFC v4 70/71] cpus-common: move exclusive_idle higher in the file

2018-10-25 Thread Emilio G. Cota
This will simplify the following commit's diff. Signed-off-by: Emilio G. Cota --- cpus-common.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/cpus-common.c b/cpus-common.c index 232cb12c46..ad8a8ef535 100644 --- a/cpus-common.c +++ b/cpus-common.c @@

[Qemu-devel] [RFC v4 42/71] ppc: convert to cpu_interrupt_request

2018-10-25 Thread Emilio G. Cota
Cc: David Gibson Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Emilio G. Cota --- hw/ppc/ppc.c| 2 +- target/ppc/excp_helper.c| 2 +- target/ppc/kvm.c| 4 ++-- target/ppc/translate_init.inc.c | 14 +++--- 4 files changed, 11

[Qemu-devel] [RFC v4 55/71] unicore32: convert to cpu_interrupt_request

2018-10-25 Thread Emilio G. Cota
Cc: Guan Xuetao Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/unicore32/cpu.c | 2 +- target/unicore32/softmmu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/unicore32/cpu.c b/target/unicore32/cpu.c index 2b49d1ca40..65c5334551

[Qemu-devel] [PULL v2 06/43] hw/timer/sun4v-rtc: Use DeviceState::realize rather than SysBusDevice::init

2018-10-25 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Move from the legacy SysBusDevice::init method to using DeviceState::realize. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Cédric Le Goater Message-Id: <20181002212522.23303-4-f4...@amsat.org> Signed-off-by: Eduardo Habkost ---

[Qemu-devel] [PULL v2 04/43] trace-events: Fix copy/paste typo

2018-10-25 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Missed while reviewing 5dd85b4b486. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Cédric Le Goater Message-Id: <20181002212522.23303-2-f4...@amsat.org> Signed-off-by: Eduardo Habkost --- hw/timer/trace-events | 2 +- 1 file

[Qemu-devel] [PULL v2 10/43] hw/mips/gt64xxx_pci: Convert gt64120_reset() function into Device reset method

2018-10-25 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Convert the gt64120_reset() function into a proper Device reset method. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Cédric Le Goater Message-Id: <20181002212522.23303-8-f4...@amsat.org> Signed-off-by: Eduardo Habkost ---

[Qemu-devel] [PULL v2 27/43] memory-device: drop get_region_size()

2018-10-25 Thread Eduardo Habkost
From: David Hildenbrand There are no remaining users of get_region_size() except memory_device_get_region_size() itself. We can make memory_device_get_region_size() work directly on get_memory_region() instead and drop get_region_size(). In addition, we can now use

Re: [Qemu-devel] [Qemu-trivial] [PATCH] piix: use TYPE_FOO constants than string constats

2018-10-25 Thread Laurent Vivier
On 11/10/2018 13:38, Li Qiang wrote: > Make them more QOMConventional. > Cc:qemu-triv...@nongnu.org > > Signed-off-by: Li Qiang > --- > hw/pci-host/piix.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) Applied, Thanks, Laurent

[Qemu-devel] [RFC v4 68/71] cpu: add async_run_on_cpu_no_bql

2018-10-25 Thread Emilio G. Cota
Some async jobs do not need the BQL. Signed-off-by: Emilio G. Cota --- include/qom/cpu.h | 14 ++ cpus-common.c | 39 ++- 2 files changed, 48 insertions(+), 5 deletions(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index

[Qemu-devel] [RFC v4 60/71] ppc: convert to cpu_has_work_with_iothread_lock

2018-10-25 Thread Emilio G. Cota
Soon we will call cpu_has_work without the BQL. Cc: David Gibson Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Emilio G. Cota --- target/ppc/translate_init.inc.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/target/ppc/translate_init.inc.c

[Qemu-devel] [RFC v4 62/71] s390x: convert to cpu_has_work_with_iothread_lock

2018-10-25 Thread Emilio G. Cota
Soon we will call cpu_has_work without the BQL. Cc: Cornelia Huck Cc: Alexander Graf Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Signed-off-by: Emilio G. Cota --- target/s390x/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/s390x/cpu.c

Re: [Qemu-devel] [PATCH V4 3/5] hw/misc/pvpanic: Add the MMIO interface

2018-10-25 Thread peng.hao2
>> Signed-off-by: Peng Hao >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/misc/pvpanic.c | 74 >> ++- >> include/hw/misc/pvpanic.h | 2 ++ >> 2 files changed, 62 insertions(+), 14 deletions(-) >> >> diff --git a/hw/misc/pvpanic.c

Re: [Qemu-devel] [PATCH RFC 0/2] Fix migration issues

2018-10-25 Thread Peter Xu
On Thu, Oct 25, 2018 at 05:04:00PM +0800, Fei Li wrote: [...] > @@ -1325,22 +1325,24 @@ bool multifd_recv_all_channels_created(void) >  /* Return true if multifd is ready for the migration, otherwise false */ >  bool multifd_recv_new_channel(QIOChannel *ioc) >  { > +    MigrationIncomingState

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vga_int: remove unused function protype

2018-10-25 Thread Laurent Vivier
On 23/10/2018 00:45, Philippe Mathieu-Daudé wrote: > On 22/10/18 10:00, yuchenlin--- via Qemu-devel wrote: >> From: yuchenlin >> >> Signed-off-by: yuchenlin > > Reviewed-by: Philippe Mathieu-Daudé > Applied, Thanks, Laurent

[Qemu-devel] [RFC v4 54/71] openrisc: convert to cpu_interrupt_request

2018-10-25 Thread Emilio G. Cota
Cc: Stafford Horne Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- hw/openrisc/cputimer.c | 2 +- target/openrisc/cpu.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/openrisc/cputimer.c b/hw/openrisc/cputimer.c index 850f88761c..739404e4f5 100644

[Qemu-devel] [RFC v4 31/71] ppc: use cpu_reset_interrupt

2018-10-25 Thread Emilio G. Cota
From: Paolo Bonzini Cc: David Gibson Cc: Alexander Graf Cc: qemu-...@nongnu.org Acked-by: David Gibson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota --- target/ppc/excp_helper.c | 2 +- 1 file changed, 1

[Qemu-devel] [RFC v4 57/71] accel/tcg: convert to cpu_interrupt_request

2018-10-25 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- accel/tcg/cpu-exec.c | 15 --- accel/tcg/tcg-all.c | 12 +--- accel/tcg/translate-all.c | 2 +- 3 files changed, 18 insertions(+), 11 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index

[Qemu-devel] [PATCH V4 0/5]

2018-10-25 Thread Peng Hao
The first patches are simple cleanups: - patch 1 move the pvpanic device with the 'ocmmon objects' so we compile it once for the x86/arm/aarch64 archs, - patch 2 simply renames ISA fields/definitions to generic ones. Then instead of add/use the MMIO pvpanic device in the virt machine in an

Re: [Qemu-devel] [PATCH V4 4/5] hw/arm/virt: Use the pvpanic device

2018-10-25 Thread Philippe Mathieu-Daudé
Hi, On 25/10/18 21:23, Peng Hao wrote: add pvpanic device in aarch64 virt machine. Signed-off-by: Peng Hao Signed-off-by: Philippe Mathieu-Daudé --- default-configs/aarch64-softmmu.mak | 1 + hw/arm/virt.c | 21 + include/hw/arm/virt.h

Re: [Qemu-devel] [PATCH RFC 0/2] Fix migration issues

2018-10-25 Thread Dr. David Alan Gilbert
* Fei Li (f...@suse.com) wrote: > Hi, > these two patches are to fix live migration issues. The first is > about multifd, and the second is to fix some error handling. > > But I have a question about using multifd migration. > In our current code, when multifd is used during migration, if there >

[Qemu-devel] [Bug 1759333] Re: Illegal Instruction with HVF when encountering SSE instructions in the emulator

2018-10-25 Thread Richard Henderson
** Tags removed: tcg ** Tags added: hvf -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1759333 Title: Illegal Instruction with HVF when encountering SSE instructions in the emulator Status in

[Qemu-devel] [PULL v2 02/43] vl.c deprecate incorrect CPUs topology

2018-10-25 Thread Eduardo Habkost
From: Igor Mammedov -smp [cpus],sockets/cores/threads[,maxcpus] should describe topology so that total number of logical CPUs [sockets * cores * threads] would be equal to [maxcpus], however historically we didn't have such check in QEMU and it is possible to start VM with an invalid topology.

[Qemu-devel] [PULL v2 01/43] hostmem-file: fixed the memory leak while get pmem path.

2018-10-25 Thread Eduardo Habkost
From: Zhang Yi object_get_canonical_path_component() returns a string which must be freed using g_free(). Reported-by: Peter Maydell Signed-off-by: Michael S. Tsirkin Signed-off-by: Zhang Yi Message-Id: <7328fb16c394eaf5d65437d11c2a9343647b6d3d.1535471899.git.yi.z.zh...@linux.intel.com>

[Qemu-devel] [PULL v2 18/43] memory-device: fix error message when hinted address is too small

2018-10-25 Thread Eduardo Habkost
From: David Hildenbrand The "at" should actually be a "before". if (new_addr < address_space_start) -> "can't add memory ... before... $address_space_start" So it looks similar to the other check } else if ((new_addr + size) > address_space_end) -> "can't add memory ...

Re: [Qemu-devel] [Qemu-trivial] [PATCH 02/10] tests/tcg/README: fix location for lm32 tests

2018-10-25 Thread Laurent Vivier
On 04/10/2018 17:18, Cleber Rosa wrote: > Point to the right and obvious location for lm32 tests. > > Signed-off-by: Cleber Rosa > --- > tests/tcg/README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/tcg/README b/tests/tcg/README > index a5643d33e7..2a58f9a058

[Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-10-25 Thread Sameeh Jubran
From: Sameeh Jubran Hi all, Background: There has been a few attempts to implement the standby feature for vfio assigned devices which aims to enable the migration of such devices. This is another attempt. The series implements an infrastructure for hiding devices from the bus upon boot. What

Re: [Qemu-devel] [PATCH v5 2/3] x86: Data structure changes to support MSR based features

2018-10-25 Thread Eduardo Habkost
On Thu, Oct 25, 2018 at 11:06:59AM +0800, Robert Hoo wrote: > On Wed, 2018-10-24 at 07:16 -0300, Eduardo Habkost wrote: [...] > > > +struct {   /*CPUID that enumerate this MSR*/ > > > +FeatureWord cpuid_class; > > > +uint32_tcpuid_flag; > > > +   

[Qemu-devel] [PULL v2 29/43] memory-device: complete factoring out pre_plug handling

2018-10-25 Thread Eduardo Habkost
From: David Hildenbrand With all required memory device class functions in place, we can factor out pre_plug handling of memory devices. Take proper care of errors. We still have to carry along legacy_align required for pc compatibility handling. We will factor out tracing of the address

[Qemu-devel] [RFC v4 36/71] arm: convert to cpu_interrupt_request

2018-10-25 Thread Emilio G. Cota
Cc: Peter Maydell Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/arm/cpu.c| 2 +- target/arm/helper.c | 12 +--- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index

[Qemu-devel] [RFC v4 61/71] mips: convert to cpu_has_work_with_iothread_lock

2018-10-25 Thread Emilio G. Cota
Soon we will call cpu_has_work without the BQL. Cc: Aurelien Jarno Cc: Aleksandar Markovic Signed-off-by: Emilio G. Cota --- target/mips/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/mips/cpu.c b/target/mips/cpu.c index 992d64e796..dcda1bce31 100644 ---

[Qemu-devel] [RFC v4 46/71] lm32: convert to cpu_interrupt_request

2018-10-25 Thread Emilio G. Cota
Cc: Michael Walle Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/lm32/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/lm32/cpu.c b/target/lm32/cpu.c index b7499cb627..1508bb6199 100644 --- a/target/lm32/cpu.c +++ b/target/lm32/cpu.c @@

[Qemu-devel] [RFC v4 47/71] m68k: convert to cpu_interrupt_request

2018-10-25 Thread Emilio G. Cota
Cc: Laurent Vivier Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/m68k/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c index 582e3a73b3..99a7eb4340 100644 --- a/target/m68k/cpu.c +++ b/target/m68k/cpu.c @@

[Qemu-devel] [PULL v2 12/43] hw/sparc64/niagara: Model the I/O Bridge with the 'unimplemented_device'

2018-10-25 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Since the I/O Bridge device is not implemented, Use the TYPE_UNIMPLEMENTED_DEVICE which suits better: if the user asks for 'unimp' warnings via the -d option then all accesses will generate logging. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Artyom

Re: [Qemu-devel] [Qemu-trivial] [PATCH] memory.h: fix types in comments

2018-10-25 Thread Laurent Vivier
On 09/10/2018 11:37, Li Qiang wrote: > > > Peter Maydell > 于2018年10月9日周二 下午6:26写道: > > On 9 October 2018 at 11:21, Li Qiang > wrote: > > Signed-off-by: Li Qiang mailto:liq...@gmail.com>> > > --- > > 

Re: [Qemu-devel] [Qemu-trivial] [PATCH 04/10] qemu-iotests: fix filename containing checks

2018-10-25 Thread Laurent Vivier
On 04/10/2018 17:18, Cleber Rosa wrote: > Commit cce293a2945 moved some functions from common.config to > common.rc, but the error messages still reference the old file > location. > > Signed-off-by: Cleber Rosa > --- > tests/qemu-iotests/common.rc | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [Qemu-devel] [Qemu-trivial] [PATCH 07/10] scripts/decodetree.py: remove unused imports

2018-10-25 Thread Laurent Vivier
On 04/10/2018 17:18, Cleber Rosa wrote: > Signed-off-by: Cleber Rosa > --- > scripts/decodetree.py | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/scripts/decodetree.py b/scripts/decodetree.py > index 277f9a9bba..457cffea90 100755 > --- a/scripts/decodetree.py > +++

Re: [Qemu-devel] [PATCH v1] arm: check bit index before usage

2018-10-25 Thread Peter Maydell
On 22 October 2018 at 19:10, P J P wrote: > From: Prasad J Pandit > > While performing gpio write via strongarm_gpio_handler_update > routine, the 'bit' index could access beyond s->handler[28] array. > Add check to avoid OOB access. > > Reported-by: Moguofang > Signed-off-by: Prasad J Pandit

[Qemu-devel] [RFC v4 59/71] cpu: introduce cpu_has_work_with_iothread_lock

2018-10-25 Thread Emilio G. Cota
It will gain some users soon. Suggested-by: Paolo Bonzini Signed-off-by: Emilio G. Cota --- include/qom/cpu.h | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index 9826cdfa4c..b5c3b2c734 100644 ---

[Qemu-devel] [RFC v4 53/71] sparc: convert to cpu_interrupt_request

2018-10-25 Thread Emilio G. Cota
Cc: Mark Cave-Ayland Cc: Artyom Tarasenko Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- hw/sparc64/sparc64.c | 4 ++-- target/sparc/cpu.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/sparc64/sparc64.c b/hw/sparc64/sparc64.c index

[Qemu-devel] [RFC v4 45/71] hppa: convert to cpu_interrupt_request

2018-10-25 Thread Emilio G. Cota
Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/hppa/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c index 00bf444620..1ab4e62850 100644 --- a/target/hppa/cpu.c +++ b/target/hppa/cpu.c @@ -60,7 +60,7 @@

[Qemu-devel] [RFC v4 43/71] sh4: convert to cpu_interrupt_request

2018-10-25 Thread Emilio G. Cota
Cc: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/sh4/cpu.c| 2 +- target/sh4/helper.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/sh4/cpu.c b/target/sh4/cpu.c index b9f393b7c7..58ea212f53 100644 ---

[Qemu-devel] [PATCH V4 5/5] hw/arm/virt: add pvpanic device in virt acpi table

2018-10-25 Thread Peng Hao
add pvpanic device in virt acpi table, so when kenrel command line uses acpi=force, kernel can get info from acpi table in aarch64. Signed-off-by: Peng Hao --- hw/arm/virt-acpi-build.c | 16 1 file changed, 16 insertions(+) diff --git a/hw/arm/virt-acpi-build.c

[Qemu-devel] [PULL v2 17/43] memory-device: fix alignment error message

2018-10-25 Thread Eduardo Habkost
From: David Hildenbrand We're missing "x" after the leading 0. Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand Message-Id: <20181005092024.14344-2-da...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/mem/memory-device.c | 2 +- 1 file changed, 1

[Qemu-devel] [PULL v2 05/43] hw/timer/sun4v-rtc: Convert from DPRINTF() macro to trace events

2018-10-25 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Artyom Tarasenko Reviewed-by: Cédric Le Goater Message-Id: <20181002212522.23303-3-f4...@amsat.org> Signed-off-by: Eduardo Habkost --- hw/timer/sun4v-rtc.c | 13 +++-- hw/timer/trace-events | 4 2

[Qemu-devel] [PULL v2 09/43] hw/pci-host/bonito: Use DeviceState::realize rather than SysBusDevice::init

2018-10-25 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Move from the legacy SysBusDevice::init method to using DeviceState::realize. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20181002212522.23303-7-f4...@amsat.org> Reviewed-by: Peter Maydell Signed-off-by: Eduardo Habkost --- hw/pci-host/bonito.c | 9

[Qemu-devel] [PULL v2 00/43] Machine queue, 2018-10-25

2018-10-25 Thread Eduardo Habkost
Changes v1 -> v2: * Fix 'make check' warnings (Igor) The following changes since commit 13399aad4fa87b2878c49d02a5d3bafa6c966ba3: Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-10-22' into staging (2018-10-23 17:20:23 +0100) are available in the Git repository at:

[Qemu-devel] [PULL v2 24/43] memory-device: document MemoryDeviceClass

2018-10-25 Thread Eduardo Habkost
From: David Hildenbrand Document the functions. Don't document get_region_size(), as we will be dropping/replacing that one soon. Use same documentation style as in include/exec/memory.h, but don't document the parameters, as they are self-explanatory. Reviewed-by: David Gibson Reviewed-by:

[Qemu-devel] [PULL v2 16/43] machine: fix a typo

2018-10-25 Thread Eduardo Habkost
From: Li Qiang Cc: qemu-triv...@nongnu.org Signed-off-by: Li Qiang Message-Id: <20181010161025.34796-1-liq...@163.com> Reviewed-by: Stefano Garzarella Signed-off-by: Eduardo Habkost --- hw/core/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/machine.c

[Qemu-devel] [PULL v2 19/43] memory-device: improve "range conflicts" error message

2018-10-25 Thread Eduardo Habkost
From: David Hildenbrand Handle id==NULL better and indicate that we are dealing with memory devices. Signed-off-by: David Hildenbrand Message-Id: <20181005092024.14344-4-da...@redhat.com> Reviewed-by: David Gibson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Eduardo Habkost ---

[Qemu-devel] [PULL v2 23/43] memory-device: forward errors in get_region_size()/get_plugged_size()

2018-10-25 Thread Eduardo Habkost
From: David Hildenbrand Let's properly forward the errors, so errors from get_region_size() / get_plugged_size() can be handled. Users right now call both functions after the device has been realized, which is will never fail, so it is fine to continue using error_abort. While at it, remove a

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configs/alpha: Remove unused CONFIG_PARALLEL_ISA switch

2018-10-25 Thread Laurent Vivier
On 24/10/2018 11:18, Thomas Huth wrote: > We don't use CONFIG_PARALLEL_ISA in any of our Makefiles, so this > is just a dead config option which can be removed. > > Fixes: a4cb773928e047b137c6998209cf2eec857fac6b > Signed-off-by: Thomas Huth > --- > default-configs/alpha-softmmu.mak | 1 - > 1

Re: [Qemu-devel] [Qemu-trivial] [PATCH 03/10] qemu-iotests: make 218 executable

2018-10-25 Thread Laurent Vivier
On 04/10/2018 17:18, Cleber Rosa wrote: > Commit 990dc39c made all tests executable at the time, but 218 came in > later, and missing those permissions. > > Signed-off-by: Cleber Rosa > --- > tests/qemu-iotests/218 | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > mode change 100644 =>

[Qemu-devel] [RFC v4 66/71] cpu: protect most CPU state with cpu->lock

2018-10-25 Thread Emilio G. Cota
Instead of taking the BQL every time we exit the exec loop, have a per-CPU lock to serialize accesses the the CPU's state. Differently from the BQL, this lock is uncontended so acquiring it is cheap. Signed-off-by: Emilio G. Cota --- include/qom/cpu.h | 20 ++-- cpus.c| 300

[Qemu-devel] [RFC v4 34/71] s390x: use cpu_reset_interrupt

2018-10-25 Thread Emilio G. Cota
From: Paolo Bonzini Cc: Cornelia Huck Cc: Alexander Graf Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: David Hildenbrand Reviewed-by: Richard Henderson Reviewed-by: Cornelia Huck Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota --- target/s390x/excp_helper.c | 2

[Qemu-devel] [RFC v4 49/71] nios: convert to cpu_interrupt_request

2018-10-25 Thread Emilio G. Cota
Cc: Chris Wulff Cc: Marek Vasut Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/nios2/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c index fbfaa2ce26..49a75414d3 100644 --- a/target/nios2/cpu.c +++

[Qemu-devel] [RFC v4 15/71] tcg-runtime: convert to cpu_halted_set

2018-10-25 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- accel/tcg/tcg-runtime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/tcg-runtime.c b/accel/tcg/tcg-runtime.c index 4aa038465f..70e3c9de71 100644 --- a/accel/tcg/tcg-runtime.c +++ b/accel/tcg/tcg-runtime.c @@ -172,5 +172,5 @@ void

[Qemu-devel] [RFC v4 28/71] openrisc: convert to cpu_halted

2018-10-25 Thread Emilio G. Cota
Cc: Stafford Horne Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/openrisc/sys_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/openrisc/sys_helper.c b/target/openrisc/sys_helper.c index b66a45c1e0..ab4d8fb520 100644 ---

Re: [Qemu-devel] [PATCH v3 2/7] qapi: correctly parse uint64_t values from strings

2018-10-25 Thread David Gibson
On Tue, Oct 23, 2018 at 05:23:01PM +0200, David Hildenbrand wrote: > Right now, we parse uint64_t values just like int64_t values, resulting > in negative values getting accepted and certain valid large numbers only > being representable as negative numbers. Also, reported errors indicate > that

[Qemu-devel] [RFC v4 25/71] sparc: convert to cpu_halted

2018-10-25 Thread Emilio G. Cota
Cc: Fabien Chouteau Cc: Mark Cave-Ayland Cc: Artyom Tarasenko Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- hw/sparc/leon3.c | 2 +- hw/sparc/sun4m.c | 8 hw/sparc64/sparc64.c | 4 ++-- target/sparc/helper.c | 2 +- 4 files changed, 8 insertions(+), 8

[Qemu-devel] [RFC v4 05/71] cpu: move run_on_cpu to cpus-common

2018-10-25 Thread Emilio G. Cota
We don't pass a pointer to qemu_global_mutex anymore. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- include/qom/cpu.h | 10 -- cpus-common.c | 2 +- cpus.c| 5 - 3 files changed, 1 insertion(+), 16 deletions(-) diff --git a/include/qom/cpu.h

[Qemu-devel] [RFC v4 17/71] ppc: convert to cpu_halted

2018-10-25 Thread Emilio G. Cota
In ppce500_spin.c, acquire the lock just once to update both cpu->halted and cpu->stopped. In hw/ppc/spapr_hcall.c, acquire the lock just once to update cpu->halted and call cpu_has_work, since later in the series we'll acquire the BQL (if not already held) from cpu_has_work. Cc: David Gibson

Re: [Qemu-devel] [PATCH v3 5/7] memory-device: use QEMU_IS_ALIGNED

2018-10-25 Thread David Gibson
On Tue, Oct 23, 2018 at 05:23:04PM +0200, David Hildenbrand wrote: > Shorter and easier to read. > > Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: David Hildenbrand Reviewed-by: David Gibson > --- > hw/mem/memory-device.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)

[Qemu-devel] [RFC v4 39/71] i386/hax-all: convert to cpu_interrupt_request

2018-10-25 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- target/i386/hax-all.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c index 8b53a9708f..70cea8b1a1 100644 --- a/target/i386/hax-all.c +++ b/target/i386/hax-all.c

Re: [Qemu-devel] [PATCH v2 01/29] target/riscv: Move CPURISCVState pointer to DisasContext

2018-10-25 Thread Peter Maydell
On 25 October 2018 at 17:38, Palmer Dabbelt wrote: > On Sat, 20 Oct 2018 00:14:23 PDT (-0700), kbast...@mail.uni-paderborn.de > wrote: >> >> CPURISCVState is rarely used, so there is no need to pass it to every >> translate function. This paves the way for decodetree which only passes >>

[Qemu-devel] [RFC 36/48] target/xtensa: prepare for 2-pass translation

2018-10-25 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- target/xtensa/translate.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index 14ab1c5ceb..83711f2a18 100644 --- a/target/xtensa/translate.c +++ b/target/xtensa/translate.c @@

[Qemu-devel] [RFC 37/48] target/openrisc: prepare for 2-pass translation

2018-10-25 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- target/openrisc/translate.c | 4 1 file changed, 4 insertions(+) diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c index 947330e10a..2f084668f9 100644 --- a/target/openrisc/translate.c +++ b/target/openrisc/translate.c @@ -1308,6

[Qemu-devel] [RFC 31/48] target/mips: prepare for 2-pass translation (WIP)

2018-10-25 Thread Emilio G. Cota
XXX: fill in plugin_insn Signed-off-by: Emilio G. Cota --- target/mips/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index efafc6e795..46ed40cf8f 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -25455,6

[Qemu-devel] [RFC 44/48] cpus: lockstep execution support

2018-10-25 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- include/qom/cpu.h | 27 +++ cpus.c| 113 +- 2 files changed, 139 insertions(+), 1 deletion(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index 1ac56fe84b..5841421a20 100644 ---

[Qemu-devel] [RFC 04/48] exec: introduce qemu_xxhash{2,4,5,6,7}

2018-10-25 Thread Emilio G. Cota
Before moving them all to include/qemu/xxhash.h. Signed-off-by: Emilio G. Cota --- include/exec/tb-hash-xx.h | 41 +-- include/exec/tb-hash.h| 2 +- tests/qht-bench.c | 2 +- util/qsp.c| 12 ++-- 4 files changed, 39

[Qemu-devel] [RFC 11/48] atomic_template: fix indentation in GEN_ATOMIC_HELPER

2018-10-25 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- accel/tcg/atomic_template.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/atomic_template.h b/accel/tcg/atomic_template.h index efde12fdb2..8d177fefef 100644 --- a/accel/tcg/atomic_template.h +++ b/accel/tcg/atomic_template.h @@

[Qemu-devel] [RFC 43/48] linux-user: support -plugin option

2018-10-25 Thread Emilio G. Cota
From: Lluís Vilanova Signed-off-by: Lluís Vilanova [ cota: s/instrument/plugin ] Signed-off-by: Emilio G. Cota --- linux-user/main.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/linux-user/main.c b/linux-user/main.c index 923cbb753a..0244ad736c 100644 ---

[Qemu-devel] [RFC 12/48] atomic_template: define pre/post macros

2018-10-25 Thread Emilio G. Cota
In preparation for plugin support. Signed-off-by: Emilio G. Cota --- accel/tcg/atomic_template.h | 92 +++-- 1 file changed, 57 insertions(+), 35 deletions(-) diff --git a/accel/tcg/atomic_template.h b/accel/tcg/atomic_template.h index 8d177fefef..b13318c1ce

[Qemu-devel] [PATCH 06/11] tests/tcg/mips: Test R5900 three-operand MADD1

2018-10-25 Thread Fredrik Noring
Signed-off-by: Fredrik Noring --- tests/tcg/mips/mipsr5900/madd.c | 43 + 1 file changed, 38 insertions(+), 5 deletions(-) diff --git a/tests/tcg/mips/mipsr5900/madd.c b/tests/tcg/mips/mipsr5900/madd.c index 9ad2ea6dbb..f6f215e1c3 100644 ---

[Qemu-devel] [PATCH 00/11] target/mips: Amend R5900 support

2018-10-25 Thread Fredrik Noring
This series amends the R5900 support with the following noncritical features: - The vendor-specific Application-Specific Extension (ASE) ASE_MMI is renamed to ASE_TOSHIBA_MMI, because several vendors have multimedia instruction (MMI) sets and other extensions of various kinds. ASE vendor

[Qemu-devel] [RFC v4 48/71] mips: convert to cpu_interrupt_request

2018-10-25 Thread Emilio G. Cota
Cc: Aurelien Jarno Cc: Aleksandar Markovic Cc: James Hogan Signed-off-by: Emilio G. Cota --- target/mips/cpu.c | 7 --- target/mips/kvm.c | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/target/mips/cpu.c b/target/mips/cpu.c index 497706b669..992d64e796 100644 ---

[Qemu-devel] [RFC v4 26/71] xtensa: convert to cpu_halted

2018-10-25 Thread Emilio G. Cota
Cc: Max Filippov Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/xtensa/cpu.c | 2 +- target/xtensa/helper.c| 2 +- target/xtensa/op_helper.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target/xtensa/cpu.c b/target/xtensa/cpu.c index

  1   2   3   >