Re: [Qemu-devel] [PATCH v3 02/19] hw: acpi: Export ACPI build alignment API

2018-10-29 Thread Philippe Mathieu-Daudé
On 29/10/18 18:01, Samuel Ortiz wrote: This is going to be needed by the Hardware-reduced ACPI routines. Signed-off-by: Samuel Ortiz --- hw/acpi/aml-build.c | 8 hw/i386/acpi-build.c| 8 include/hw/acpi/aml-build.h | 2 ++ 3 files changed, 10

Re: [Qemu-devel] [PATCH v3 09/19] hw: acpi: Export and generalize the PCI host AML API

2018-10-29 Thread Philippe Mathieu-Daudé
On 29/10/18 20:23, Philippe Mathieu-Daudé wrote: On 29/10/18 18:01, Samuel Ortiz wrote: From: Yang Zhong The AML build routines for the PCI host bridge and the corresponding DSDT addition are neither x86 nor PC machine type specific. We can move them to the architecture agnostic hw/acpi

Re: [Qemu-devel] [PATCH v3 01/19] hw: i386: Decouple the ACPI build from the PC machine type

2018-10-29 Thread Philippe Mathieu-Daudé
Hi Samuel, On 29/10/18 18:01, Samuel Ortiz wrote: ACPI tables are platform and machine type and even architecture agnostic, and as such we want to provide an internal ACPI API that only depends on platform agnostic information. For the x86 architecture, in order to build ACPI tables

[Qemu-devel] [PULL 3/3] hw: ccid-card-emulated: cleanup resource when realize in error path

2018-10-29 Thread Gerd Hoffmann
From: Li Qiang Signed-off-by: Li Qiang Message-id: 1539946236-18028-3-git-send-email-liq...@gmail.com Signed-off-by: Gerd Hoffmann --- hw/usb/ccid-card-emulated.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/hw/usb/ccid-card-emulated.c

[Qemu-devel] [PULL 1/3] usb: ohci: make num_ports to an unsinged integer

2018-10-29 Thread Gerd Hoffmann
From: Li Qiang This can avoid setting OCHIState.num_ports to a negative num. Signed-off-by: Li Qiang Message-id: 1540263618-18344-1-git-send-email-liq...@gmail.com Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ohci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PULL 0/3] Usb 20181029 patches

2018-10-29 Thread Gerd Hoffmann
The following changes since commit b312532fd03413d0e6ae6767ec793a3e30f487b8: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-10-19 19:01:07 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/usb-20181029-pull-request for you

Re: [Qemu-devel] [PATCH] microbit: do not rely on -kernel option

2018-10-29 Thread Stefan Hajnoczi
On Mon, Oct 29, 2018 at 7:46 PM Stefan Hajnoczi wrote: > @@ -39,8 +47,12 @@ static void microbit_init(MachineState *machine) > _fatal); > object_property_set_bool(soc, true, "realized", _fatal); > > -armv7m_load_kernel(ARM_CPU(first_cpu),

Re: [Qemu-devel] [PATCH v3 17/19] hw: acpi: Define ACPI tables builder interface

2018-10-29 Thread Philippe Mathieu-Daudé
Hi Samuel, On 29/10/18 18:01, Samuel Ortiz wrote: In order to decouple ACPI APIs from specific machine types, we are creating an ACPI builder interface that each ACPI platform can choose to implement. This way, a new machine type can re-use the high level ACPI APIs and define some custom table

Re: [Qemu-devel] [PATCH v3 19/19] hw: i386: Implement the ACPI builder interface for PC

2018-10-29 Thread Philippe Mathieu-Daudé
On 29/10/18 18:01, Samuel Ortiz wrote: All PC machine type derivatives will use the same ACPI table build methods. But with that change in place, any new x86 machine type will be able to re-use the acpi-build API and customize part of it by defining its own ACPI table build methods.

[Qemu-devel] [PULL 08/19] block/qcow2: improve error message in qcow2_inactivate

2018-10-29 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy [Maintainer edit -- touched up error message. --js] Reviewed-by: John Snow Signed-off-by: John Snow --- block/qcow2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/qcow2.c

[Qemu-devel] [PULL 14/19] block/backup: prohibit backup from using in use bitmaps

2018-10-29 Thread John Snow
If the bitmap is frozen, we shouldn't touch it. Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy Message-id: 20181002230218.13949-6-js...@redhat.com Signed-off-by: John Snow --- blockdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PULL 06/19] qapi: add transaction support for x-block-dirty-bitmap-merge

2018-10-29 Thread John Snow
From: Vladimir Sementsov-Ogievskiy New action is like clean action: do the whole thing in .prepare and undo in .abort. This behavior for bitmap-changing actions is needed because backup job actions use bitmap in .prepare. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow

Re: [Qemu-devel] [RFC v4 05/71] cpu: move run_on_cpu to cpus-common

2018-10-29 Thread Emilio G. Cota
On Mon, Oct 29, 2018 at 16:34:49 +, Alex Bennée wrote: > > Emilio G. Cota writes: > > > We don't pass a pointer to qemu_global_mutex anymore. > > > > Reviewed-by: Richard Henderson > > Signed-off-by: Emilio G. Cota > > As discussed on IRC I don't fundamentally object to this being in >

Re: [Qemu-devel] [PATCH v3 08/19] hw: i386: Refactor PCI host getter

2018-10-29 Thread Philippe Mathieu-Daudé
Hi Yang, Samuel. On 29/10/18 18:01, Samuel Ortiz wrote: From: Yang Zhong Make it more flexible by having it parsing a PCI host paths array instead of open coding those paths deep down into the code logic itself. This will be needed for PCI machine types that are neither emulatiing the ich9

Re: [Qemu-devel] [PATCH 1/4] MAINTAINERS: s390: more maintainers for vfio-ccw

2018-10-29 Thread Farhan Ali
On 10/29/2018 11:42 AM, Christian Borntraeger wrote: Eric and Farhan will help with maintaining vfio-ccw. Signed-off-by: Christian Borntraeger --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d794bd7..10045b6 100644 --- a/MAINTAINERS

Re: [Qemu-devel] [PATCH] target/riscv/pmp.c: pmpcfg_csr_read returns bogus value on RV64

2018-10-29 Thread Palmer Dabbelt
On Sat, 27 Oct 2018 01:42:02 PDT (-0700), alistai...@gmail.com wrote: On Fri, Oct 26, 2018 at 7:14 PM Dayeol Lee wrote: Hi, I submitted the patch, but just found this has been already fixed by Michael Clark and pushed to riscv/riscv-qemu https://github.com/riscv/riscv-qemu/pull/166 but not

[Qemu-devel] [PATCH] MAINTAINERS: Remove bouncing email in ARM ACPI

2018-10-29 Thread Philippe Mathieu-Daudé
Shannon Zhao's email at Huawei is bouncing: remove it. X-Failed-Recipients: zhaoshengl...@huawei.com ** Address not found ** Your message wasn't delivered to zhaoshengl...@huawei.com because the address couldn't be found, or is unable to receive mail. Note that the section still

Re: [Qemu-devel] [PATCH 0/2] Deprecate the "collie" machine and Strongarm devices

2018-10-29 Thread Guenter Roeck
On Mon, Oct 29, 2018 at 04:03:40PM +0100, Philippe Mathieu-Daudé wrote: > Hi Guenter, > > On 29/10/18 15:09, Guenter Roeck wrote: > >On 10/29/18 6:24 AM, Peter Maydell wrote: > >>On 27 October 2018 at 12:04, Guenter Roeck wrote: > >>>On 10/26/18 3:12 AM, Peter Maydell wrote: > Hi Guenter;

Re: [Qemu-devel] [PATCH 0/4] MAINTAINERS: s390: several updates

2018-10-29 Thread Alexander Graf
On 29.10.18 16:42, Christian Borntraeger wrote: > I discussed the following maintainer updates at the kvm forum with > Conny. This is the first set of changes. > Can the affected persons please Ack the relevant patches? > > PS: Alex, do you still want to be listed? No, I've been meaning to

Re: [Qemu-devel] [PATCH v3 06/19] hw: acpi: Generalize AML build routines

2018-10-29 Thread Philippe Mathieu-Daudé
On 29/10/18 18:01, Samuel Ortiz wrote: From: Yang Zhong Most of the AML build routines under acpi-build are not even architecture specific. They can be moved to the more generic hw/acpi folder where they could be shared across machine types and architectures. Signed-off-by: Yang Zhong ---

Re: [Qemu-devel] [PATCH v3 12/19] hw: i386: Make the hotpluggable memory size property more generic

2018-10-29 Thread Philippe Mathieu-Daudé
On 29/10/18 18:01, Samuel Ortiz wrote: This property is currently defined under i386/pc while it only describes a region size that's eventually fetched from the AML ACPI code. We can make it more generic and shareable across machine types by moving it to memory-device.h instead. It makes sens

Re: [Qemu-devel] [PATCH v3 15/19] hw: acpi: Export the PCI hotplug API

2018-10-29 Thread Philippe Mathieu-Daudé
On 29/10/18 18:01, Samuel Ortiz wrote: From: Sebastien Boeuf The ACPI hotplug support for PCI devices APIs are not x86 or even machine type specific. In order for future machine types to be able to re-use that code, we export it through the architecture agnostic hw/acpi folder. Signed-off-by:

[Qemu-devel] [PULL 13/19] block/dirty-bitmaps: prohibit enable/disable on locked/frozen bitmaps

2018-10-29 Thread John Snow
We're not being consistent about this. If it's in use by an operation, the user should not be able to change the behavior of that bitmap. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Message-id: 20181002230218.13949-5-js...@redhat.com

[Qemu-devel] [PULL 12/19] block/dirty-bitmaps: allow clear on disabled bitmaps

2018-10-29 Thread John Snow
Similarly to merge, it's OK to allow clear operations on disabled bitmaps, as this condition only means that they are not recording new writes. We are free to clear it if the user requests it. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [Bug 1776096] Re: qemu 2.12.0 qemu-system-ppc illegal instruction on ppc64le, crashes emulator

2018-10-29 Thread Murilo Opsfelder Araújo
Hi, Cameron. The step "Start QEMU and boot Mac OS X 10.4.11" is not clear to me. Is there a location where one could download such image and boot? I wonder how one without access to a Mac image can reproduce this issue. Cheers Murilo -- You received this bug notification because you are a

Re: [Qemu-devel] [PATCH v3 11/19] hw: acpi: Do not create hotplug method when handler is not defined

2018-10-29 Thread Philippe Mathieu-Daudé
On 29/10/18 18:01, Samuel Ortiz wrote: CPU and memory ACPI hotplug are not necessarily handled through SCI events. For example, with Hardware-reduced ACPI, the GED device will manage ACPI hotplug entirely. As a consequence, we make the CPU and memory specific events AML generation optional. The

Re: [Qemu-devel] [PATCH v3 18/19] hw: i386: Export the MADT build method

2018-10-29 Thread Philippe Mathieu-Daudé
Hi Samuel, On 29/10/18 18:01, Samuel Ortiz wrote: It is going to be used by the PC machine type as the MADT table builder method and thus needs to be exported outside of acpi-build.c Also, now that the generic build_madt() API is exported, we have to rename the ARM static one in order to avoid

[Qemu-devel] [PULL 00/19] Bitmaps patches

2018-10-29 Thread John Snow
The following changes since commit 62b658db1df7c6fa574caae038144f24bf6ca495: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2018-10-29 17:03:27 +) are available in the Git repository at: https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request

[Qemu-devel] [PULL 03/19] dirty-bitmap: rename bdrv_undo_clear_dirty_bitmap

2018-10-29 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Use more generic names to reuse the function for bitmap merge in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Signed-off-by: John Snow --- block/dirty-bitmap.c | 4 ++-- blockdev.c| 2 +-

[Qemu-devel] [PULL 01/19] blockdev-backup: add bitmap argument

2018-10-29 Thread John Snow
It is only an oversight that we don't allow incremental backup with blockdev-backup. Add the bitmap argument which enables this. Signed-off-by: John Snow Message-id: 20180830211605.13683-2-js...@redhat.com Signed-off-by: John Snow --- blockdev.c | 18 +-

[Qemu-devel] [PULL 02/19] dirty-bitmap: switch assert-fails to errors in bdrv_merge_dirty_bitmap

2018-10-29 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Move checks from qmp_x_block_dirty_bitmap_merge() to bdrv_merge_dirty_bitmap(), to share them with dirty bitmap merge transaction action in future commit. Note: for now, only qmp_x_block_dirty_bitmap_merge() calls bdrv_merge_dirty_bitmap(). Signed-off-by:

[Qemu-devel] [PATCH] microbit: do not rely on -kernel option

2018-10-29 Thread Stefan Hajnoczi
Microbit programs are typically in Intel HEX (.hex) format. The generic loader supports .hex files but it doesn't work as expected: $ qemu-system-arm -M microbit -device loader,file=microbit.hex Guest image must be specified (using -kernel) This error comes from armv7m_load_kernel(). Don't

[Qemu-devel] [PULL 2/3] hw: ccid-card-emulated: introduce clean_event_notifier

2018-10-29 Thread Gerd Hoffmann
From: Li Qiang Call it in device unrealize function. Signed-off-by: Li Qiang Message-id: 1539946236-18028-2-git-send-email-liq...@gmail.com Signed-off-by: Gerd Hoffmann --- hw/usb/ccid-card-emulated.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/usb/ccid-card-emulated.c

Re: [Qemu-devel] Minutes of KVM Forum BoF on deprecating stuff

2018-10-29 Thread John Snow
On 10/26/2018 10:22 AM, Daniel P. Berrangé wrote: > > On Fri, Oct 26, 2018 at 04:03:51PM +0200, Markus Armbruster wrote: >> This is from my (imperfect) notes, corrections welcome. >> >> Motivation: QEMU contains stuff of dubious value, which gets in the way >> in various (sometimes painful and

Re: [Qemu-devel] [PATCH v3 16/19] hw: acpi: Retrieve the PCI bus from AcpiPciHpState

2018-10-29 Thread Philippe Mathieu-Daudé
On 29/10/18 18:01, Samuel Ortiz wrote: From: Sebastien Boeuf Instead of using the machine type specific method find_i440fx() to retrieve the PCI bus, this commit aims to rely on the fact that the PCI bus is known by the structure AcpiPciHpState. When the structure is initialized through

[Qemu-devel] [PULL 10/19] block/dirty-bitmaps: add user_locked status checker

2018-10-29 Thread John Snow
Instead of both frozen and qmp_locked checks, wrap it into one check. frozen implies the bitmap is split in two (for backup), and shouldn't be modified. qmp_locked implies it's being used by another operation, like being exported over NBD. In both cases it means we shouldn't allow the user to

[Qemu-devel] [PULL 09/19] bloc/qcow2: drop dirty_bitmaps_loaded state variable

2018-10-29 Thread John Snow
From: Vladimir Sementsov-Ogievskiy This variable doesn't work as it should, because it is actually cleared in qcow2_co_invalidate_cache() by memset(). Drop it, as the following patch will introduce new behavior. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Signed-off-by:

[Qemu-devel] [PULL 16/19] bitmap: Update count after a merge

2018-10-29 Thread John Snow
From: Eric Blake We need an accurate count of the number of bits set in a bitmap after a merge. In particular, since the merge operation short-circuits a merge from an empty source, if you have bitmaps A, B, and C where B started empty, then merge C into B, and B into A, an inaccurate count

[Qemu-devel] [PULL 15/19] nbd: forbid use of frozen bitmaps

2018-10-29 Thread John Snow
Whether it's "locked" or "frozen", it's in use and should not be allowed for the purposes of this operation. Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy Message-id: 20181002230218.13949-7-js...@redhat.com Signed-off-by: John Snow --- nbd/server.c | 4 ++-- 1 file

[Qemu-devel] [PULL 11/19] block/dirty-bitmaps: fix merge permissions

2018-10-29 Thread John Snow
In prior commits that made merge transactionable, we removed the assertion that merge cannot operate on disabled bitmaps. In addition, we want to make sure that we are prohibiting merges to "locked" bitmaps. Use the new user_locked function to check. Reported-by: Eric Blake Signed-off-by: John

Re: [Qemu-devel] [PATCH v3 03/19] hw: acpi: Export the RSDP build API

2018-10-29 Thread Philippe Mathieu-Daudé
Hi Samuel, On 29/10/18 18:01, Samuel Ortiz wrote: The hardware-reduced API will need to build RSDP as well, so we should export this routine. While doing so, we also slightly change the function prototype. Since no caller needs it, and to make it more consistent with the rest of the AML build

Re: [Qemu-devel] [PATCH v3 09/19] hw: acpi: Export and generalize the PCI host AML API

2018-10-29 Thread Philippe Mathieu-Daudé
On 29/10/18 18:01, Samuel Ortiz wrote: From: Yang Zhong The AML build routines for the PCI host bridge and the corresponding DSDT addition are neither x86 nor PC machine type specific. We can move them to the architecture agnostic hw/acpi folder, and by carrying all the needed information

Re: [Qemu-devel] [PATCH v2 0/6] target/mips: Add support for prctl() PR_GET_FP_MODE and PR_SET_FP_MODE

2018-10-29 Thread Laurent Vivier
Le 29/10/2018 à 15:53, Aleksandar Markovic a écrit : >> From: Stefan Markovic >> Subject: [PATCH v2 0/6] target/mips: Add support for prctl() PR_GET_FP_MODE >> and PR_SET_FP_MODE >> >> From: Stefan Markovic >> >> This series includes support for prctl() PR_GET_FP_MODE and PR_SET_FP_MODE. >>

[Qemu-devel] [PULL 18/19] iotests: improve 169

2018-10-29 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Before previous patch, iotest 169 was actually broken for the case test_persistent__not_migbitmap__offline_shared, while formally passing. After migration log of vm_b had message: qemu-system-x86_64: Could not reopen qcow2 layer: Bitmap already

Re: [Qemu-devel] [PATCH v3 10/19] hw: acpi: Export the MCFG getter

2018-10-29 Thread Philippe Mathieu-Daudé
On 29/10/18 18:01, Samuel Ortiz wrote: From: Yang Zhong The ACPI MCFG getter is not x86 specific and could be called from anywhere within generic ACPI API, so let's export it. Signed-off-by: Yang Zhong Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé ---

Re: [Qemu-devel] [PATCH v3 13/19] hw: acpi: Export the SRAT AML build API

2018-10-29 Thread Philippe Mathieu-Daudé
On 29/10/18 18:01, Samuel Ortiz wrote: From: Yang Zhong The SRAT ACPI table is not x86 specific and will be needed for the Hardware-reduced ACPI implementation. So we should export it through the architecture independent hw/acpi folder. Also, now that the generic build_srat() API is exported,

[Qemu-devel] [PULL 07/19] iotests: 169: drop deprecated 'autoload' parameter

2018-10-29 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Signed-off-by: John Snow --- tests/qemu-iotests/169 | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qemu-iotests/169 b/tests/qemu-iotests/169 index f243db9955..df408f8367 100755 ---

[Qemu-devel] [PULL 04/19] dirty-bitmap: make it possible to restore bitmap after merge

2018-10-29 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Add backup parameter to bdrv_merge_dirty_bitmap() to be used then with bdrv_restore_dirty_bitmap() if it needed to restore the bitmap after merge operation. This is needed to implement bitmap merge transaction action in further commit. Signed-off-by: Vladimir

[Qemu-devel] [PULL 05/19] blockdev: rename block-dirty-bitmap-clear transaction handlers

2018-10-29 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Rename block-dirty-bitmap-clear transaction handlers to reuse them for x-block-dirty-bitmap-merge transaction in the following patch. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Signed-off-by: John Snow --- blockdev.c | 8 1

[Qemu-devel] [PULL 19/19] iotests: 169: add cases for source vm resuming

2018-10-29 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Test that we can resume source vm after [failed] migration, and bitmaps are ok. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: John Snow --- tests/qemu-iotests/169 | 60 +-

[Qemu-devel] [PULL 17/19] dirty-bitmaps: clean-up bitmaps loading and migration logic

2018-10-29 Thread John Snow
From: Vladimir Sementsov-Ogievskiy This patch aims to bring the following behavior: 1. We don't load bitmaps, when started in inactive mode. It's the case of incoming migration. In this case we wait for bitmaps migration through migration channel (if 'dirty-bitmaps' capability is enabled) or

Re: [Qemu-devel] [PATCH 1/3] hw/arm/xilinx_zynq: Use the ARRAY_SIZE macro

2018-10-29 Thread Alistair Francis
On Mon, Oct 29, 2018 at 4:22 PM Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/arm/xilinx_zynq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c >

Re: [Qemu-devel] [PATCH 3/3] arm: exynos4: Add dma support for smdkc210

2018-10-29 Thread Alistair Francis
On Mon, Oct 29, 2018 at 4:21 PM Philippe Mathieu-Daudé wrote: > > From: Guenter Roeck > > QEMU already supports pl330. Instantiate it for smdkc210. > > Signed-off-by: Guenter Roeck > Reviewed-by: Philippe Mathieu-Daudé > [PMD: Use pl330_init from "hw/dma/pl330.h"] > Signed-off-by: Philippe

Re: [Qemu-devel] [PATCH 0/2] Deprecate the "collie" machine and Strongarm devices

2018-10-29 Thread Philippe Mathieu-Daudé
On 29/10/18 21:24, Guenter Roeck wrote: On Mon, Oct 29, 2018 at 04:03:40PM +0100, Philippe Mathieu-Daudé wrote: On 29/10/18 15:09, Guenter Roeck wrote: On 10/29/18 6:24 AM, Peter Maydell wrote: On 27 October 2018 at 12:04, Guenter Roeck wrote: On 10/26/18 3:12 AM, Peter Maydell wrote: Hi

[Qemu-devel] [PATCH 1/3] arm: allwinner: Enable USB OHCI

2018-10-29 Thread Philippe Mathieu-Daudé
From: Guenter Roeck Signed-off-by: Guenter Roeck Reviewed-by: Philippe Mathieu-Daudé [PMD: Intented tabs -> space] Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/allwinner-a10.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c index

[Qemu-devel] [PATCH 2/3] usb: ehci: Add support for Allwinner A10

2018-10-29 Thread Philippe Mathieu-Daudé
From: Guenter Roeck Signed-off-by: Guenter Roeck Signed-off-by: Philippe Mathieu-Daudé --- Gerd: You already review this code here: https://lists.gnu.org/archive/html/qemu-arm/2017-01/msg00345.html Can we use your R-b again? hw/usb/hcd-ehci-sysbus.c | 17 + hw/usb/hcd-ehci.h

[Qemu-devel] [PATCH 3/3] arm: allwinner: Enable USB EHCI

2018-10-29 Thread Philippe Mathieu-Daudé
From: Guenter Roeck Signed-off-by: Guenter Roeck Reviewed-by: Philippe Mathieu-Daudé [PMD: Intented tabs -> space] Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/allwinner-a10.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c index

[Qemu-devel] [PATCH 1/3] hw/arm/xilinx_zynq: Use the ARRAY_SIZE macro

2018-10-29 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/xilinx_zynq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index f1496d2927..57497b0c4d 100644 --- a/hw/arm/xilinx_zynq.c +++ b/hw/arm/xilinx_zynq.c @@ -294,7 +294,7 @@ static void

[Qemu-devel] [PATCH 3/3] arm: exynos4: Add dma support for smdkc210

2018-10-29 Thread Philippe Mathieu-Daudé
From: Guenter Roeck QEMU already supports pl330. Instantiate it for smdkc210. Signed-off-by: Guenter Roeck Reviewed-by: Philippe Mathieu-Daudé [PMD: Use pl330_init from "hw/dma/pl330.h"] Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/exynos4_boards.c | 12 1 file changed, 12

[Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-29 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS| 1 + hw/arm/xilinx_zynq.c | 18 ++ hw/dma/pl330.c | 2 +- include/hw/dma/pl330.h | 41 + 4 files changed, 45 insertions(+), 17 deletions(-) create mode 100644

[Qemu-devel] [PATCH 0/3] hw/arm/exynos4: Add DMA support for SMDKC210 board

2018-10-29 Thread Philippe Mathieu-Daudé
Hi, this series is another intent to salvage previous work from Guenter Roeck: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg06302.html Instead of duplicate the pl330_init() from the xilinx_zynq, I factored it out. Regards, Phil. Guenter Roeck (1): arm: exynos4: Add dma support

Re: [Qemu-devel] [PATCH 1/2] tests: fw_cfg: add a function to get the fw_cfg file entry

2018-10-29 Thread Philippe Mathieu-Daudé
Hi Li, On 28/10/18 13:40, Li Qiang wrote: This is useful to write qtest abount fw_cfg file entry. Signed-off-by: Li Qiang --- tests/libqos/fw_cfg.c | 30 ++ tests/libqos/fw_cfg.h | 2 ++ 2 files changed, 32 insertions(+) diff --git a/tests/libqos/fw_cfg.c

[Qemu-devel] [PATCH] tests/bios-tables-test: Sanitize test verbose output

2018-10-29 Thread Philippe Mathieu-Daudé
Fix the extraneous extra blank lines in the test output when running with V=1. Before: TEST: tests/bios-tables-test... (pid=25678) /i386/acpi/piix4: Looking for expected file 'tests/acpi-test-data/pc/DSDT' Using expected file 'tests/acpi-test-data/pc/DSDT' Looking for

[Qemu-devel] [PATCH 0/3] hw/arm: Enable USB OHCI/EHCI on Allwinner A10

2018-10-29 Thread Philippe Mathieu-Daudé
Hi, this series intend to salvage previous work from Guenter Roeck [1]. A similar series from Icenowy Zheng was later reviewed by Gerd Hoffmann: https://lists.gnu.org/archive/html/qemu-arm/2017-01/msg00345.html [2]. I reviewed patches 1 and 3, Gerd already reviewed patch 2 ([2]), if he agrees to

Re: [Qemu-devel] [PATCH v5 03/11] escc: introduce a selector for the register bit

2018-10-29 Thread Philippe Mathieu-Daudé
Hi Marc, Laurent. On Mon, Oct 29, 2018 at 2:43 PM Mark Cave-Ayland wrote: > > From: Laurent Vivier > > On Sparc and PowerMac, the bit 0 of the address > selects the register type (control or data) and > bit 1 selects the channel (B or A). > > On m68k Macintosh, the bit 0 selects the channel and

Re: [Qemu-devel] [PATCH] fw_cfg_reboot: ensure reboot_time is nonegative

2018-10-29 Thread Philippe Mathieu-Daudé
On 25/10/18 3:45, Li Qiang wrote: Hello Laszlo and Philippe , Thanks for your review, Philippe Mathieu-Daudé mailto:phi...@redhat.com>> 于 2018年10月25日周四 上午6:56写道: Hi, On 24/10/18 13:35, Laszlo Ersek wrote: > On 10/24/18 09:11, Li Qiang wrote: >> This can avoid setting a

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-29 Thread Alistair Francis
On Mon, Oct 29, 2018 at 4:24 PM Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > MAINTAINERS| 1 + > hw/arm/xilinx_zynq.c | 18 ++ > hw/dma/pl330.c | 2 +- > include/hw/dma/pl330.h

Re: [Qemu-devel] [PATCH 2/2] tests: fw_cfg: add reboot_timeout test case

2018-10-29 Thread Philippe Mathieu-Daudé
On 28/10/18 13:40, Li Qiang wrote: Signed-off-by: Li Qiang --- tests/fw_cfg-test.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c index 1c5103fe1c..37765f15f8 100644 --- a/tests/fw_cfg-test.c +++

Re: [Qemu-devel] [PATCH 0/2] hw: ccid-card-emulated: fix some resources leak

2018-10-29 Thread Gerd Hoffmann
On Fri, Oct 19, 2018 at 03:50:34AM -0700, Li Qiang wrote: > > Li Qiang (2): > hw: ccid-card-emulated: introduce clean_event_notifier > hw: ccid-card-emulated: cleanup resource when realize in error path Added to usb queue. thanks, Gerd

Re: [Qemu-devel] bochs-display and the future of VGA support

2018-10-29 Thread Gerd Hoffmann
On Sun, Oct 28, 2018 at 01:40:29PM +0100, John Paul Adrian Glaubitz wrote: > Hi! > > I just happened to read Gerd Hoffmann's post on the bochs-display [1] driver > and was wondering what the future plans for VGA support are. > > Phoronix makes it sound like [2] that VGA support for guests is

Re: [Qemu-devel] [PATCH] vhost-user: fix qemu crash caused by failed backend

2018-10-29 Thread Liang Li
On Tue, Oct 02, 2018 at 01:54:25PM +0400, Marc-André Lureau wrote: > Hi > > On Thu, Sep 27, 2018 at 7:37 PM Liang Li wrote: > > > > During live migration, when stopping vhost-user device, 'vhost_dev_stop' > > will be called, 'vhost_dev_stop' will call a batch of 'vhost_user_read' > > and

[Qemu-devel] [PATCH v8 03/20] target/mips: Amend MXU instruction opcodes

2018-10-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Amend MXU instruction opcodes. Pool04 is actually only instruction OPC_MXU_S16MAD. Two cases within S16MAD are recognized by 1-bit subfield 'aptn1'. Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 160

[Qemu-devel] [PATCH v8 10/20] target/mips: Add bit encoding for MXU operand getting pattern 'optn3'

2018-10-29 Thread Aleksandar Markovic
From: Craig Janeczek Add bit encoding for MXU operand getting pattern 'optn3'. Reviewed-by: Stefan Markovic Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target/mips/translate.c

[Qemu-devel] [PATCH v8 07/20] target/mips: Add bit encoding for MXU accumulate add/sub 2-bit pattern 'aptn2'

2018-10-29 Thread Aleksandar Markovic
From: Craig Janeczek Add bit encoding for MXU accumulate add/subtract 2-bit pattern 'aptn2'. Reviewed-by: Stefan Markovic Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Qemu-devel] [PATCH v8 20/20] target/mips: Amend MXU ASE overview note

2018-10-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Add prefix, suffix, operation descriptions, and other corrections and amendments to the comment that describes MXU ASE. Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 84 +++--

[Qemu-devel] [PATCH v8 08/20] target/mips: Add bit encoding for MXU execute add/sub pattern 'eptn2'

2018-10-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Add bit encoding for MXU execute 2-bit add/subtract pattern 'eptn2'. Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/mips/translate.c

[Qemu-devel] [PATCH v8 17/20] target/mips: Add emulation of MXU instructions Q8MUL and Q8MULSU

2018-10-29 Thread Aleksandar Markovic
From: Craig Janeczek Adds support for emulating the Q8MUL and Q8MULSU MXU instructions. Reviewed-by: Aleksandar Markovic Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 101 1 file changed, 94

Re: [Qemu-devel] [PATCH] SDL: set a hint to not bypass the window compositor

2018-10-29 Thread Gerd Hoffmann
On Wed, Oct 24, 2018 at 04:37:48PM +0200, Sebastian Krzyszkowiak wrote: > Without that, window effects in KWin get suspended as soon as any > qemu-sdl window becomes visible. While the SDL default makes sense > for games, it's not really suitable for QEMU. > > Signed-off-by: Sebastian

Re: [Qemu-devel] [RFC 00/48] Plugin support

2018-10-29 Thread Pavel Dovgalyuk
> From: Emilio G. Cota [mailto:c...@braap.org] > - 2-pass translation. Once a "TB translation" callback is called, > the plugin must know the span of the TB. We should not > force plugins to guess where the TB will end; that is strictly > QEMU's job, and can change any time. A TB is thus a

[Qemu-devel] [PATCH] migration: fix concurrent call of multifd_save_cleanup

2018-10-29 Thread Liang Li
Concurrent call of multifd_save_cleanup() is unsafe, it will lead to null pointer dereference. 'multifd_save_cleanup()' should not be called in multifd_new_send_channel_async(), move it to ram_save_cleanup() like other features do. Signed-off-by: Liang Li --- migration/migration.c | 5 -

[Qemu-devel] could somebody who understands the block refcounting look at CID 1395870, CID 1395871?

2018-10-29 Thread Peter Maydell
Hi; could somebody who understands the block layer refcounting have a look at Coverity issues CID 1395870 and 1395871, please? In both cases, Coverity reports a use-after-free because it thinks that a sequence where a code path might (conditionally) end up calling blk_deref() twice could be

Re: [Qemu-devel] [PULL V2 01/26] filter-rewriter: Add TCP state machine and fix memory leak in connection_track_table

2018-10-29 Thread Peter Maydell
On 19 October 2018 at 04:22, Jason Wang wrote: > From: Zhang Chen > > We add almost full TCP state machine in filter-rewriter, except > TCPS_LISTEN and some simplify in VM active close FIN states. > The reason for this simplify job is because guest kernel will track > the TCP status and wait

Re: [Qemu-devel] [PULL 2/3] target/mips: Implement emulation of nanoMIPS EVA instructions

2018-10-29 Thread Aleksandar Markovic
> From: Peter Maydell > Sent: Monday, October 29, 2018 11:57 AM > Subject: Re: [PULL 2/3] target/mips: Implement emulation of nanoMIPS EVA > instructions > > On 25 October 2018 at 21:19, Aleksandar Markovic > wrote: > > From: Dimitrije Nikolic > > > > Implement emulation of nanoMIPS EVA

[Qemu-devel] [PATCH v8 02/20] target/mips: Define a bit for MXU in insn_flags

2018-10-29 Thread Aleksandar Markovic
From: Craig Janeczek Define a bit for MXU in insn_flags. This is the first non-MIPS (third party) ASE supported in QEMU for MIPS, so it is placed in the section "bits 56-63: vendor-specific ASEs". Reviewed-by: Aleksandar Markovic Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar

[Qemu-devel] [PATCH v8 06/20] target/mips: Add bit encoding for MXU accumulate add/sub 1-bit pattern 'aptn1'

2018-10-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Add bit encoding for MXU accumulate add/subtract 1-bit pattern 'aptn1'. Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/mips/translate.c

[Qemu-devel] [PATCH v8 09/20] target/mips: Add bit encoding for MXU operand getting pattern 'optn2'

2018-10-29 Thread Aleksandar Markovic
From: Craig Janeczek Add bit encoding for MXU operand getting pattern 'optn2'. Reviewed-by: Stefan Markovic Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/mips/translate.c

[Qemu-devel] [PATCH v8 15/20] target/mips: Add emulation of MXU instruction D16MUL

2018-10-29 Thread Aleksandar Markovic
From: Craig Janeczek Add support for emulating the D16MUL MXU instruction. Reviewed-by: Aleksandar Markovic Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 66 ++--- 1 file changed, 63 insertions(+),

[Qemu-devel] [PATCH v8 19/20] target/mips: Move MXU_EN check one level higher

2018-10-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Move MXU_EN check to the main MXU decoding function, to avoid code repetition. Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 509 ++-- 1 file changed, 238 insertions(+), 271

[Qemu-devel] [PATCH v8 18/20] target/mips: Add emulation of MXU instructions S32LDD and S32LDDR

2018-10-29 Thread Aleksandar Markovic
From: Craig Janeczek Add support for emulating the S32LDD and S32LDDR MXU instructions. Reviewed-by: Aleksandar Markovic Signed-off-by: Craig Janeczek Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 54 ++--- 1 file changed, 47

Re: [Qemu-devel] [PATCH 3/6] char: add a QEMU_CHAR_FEATURE_GCONTEXT flag

2018-10-29 Thread Marc-André Lureau
Hi On Wed, Oct 10, 2018 at 7:54 AM Peter Xu wrote: > > On Tue, Oct 09, 2018 at 05:12:48PM +0400, Marc-André Lureau wrote: > > The feature should be set if the chardev is able to switch > > GMainContext. Callers that want to put a chardev in a different thread > > context can/should check this

[Qemu-devel] [PATCH 1/2] nvme: don't unref ctrl_mem when device unrealized

2018-10-29 Thread Li Qiang
Currently, when hotplug/unhotplug nvme device, it will cause an assert in object.c. Following is the backtrack: ERROR:qom/object.c:981:object_unref: assertion failed: (obj->ref > 0) Thread 2 "qemu-system-x86" received signal SIGABRT, Aborted. [Switching to Thread 0x7fffcbd32700 (LWP 18844)]

[Qemu-devel] [PATCH 0/2] nvme: fix two issues in nvme unhotplug

2018-10-29 Thread Li Qiang
The first corrent the refcount and second fix a memory leak. Li Qiang (2): nvme: don't unref ctrl_mem when device unrealized nvme: free cmbuf in nvme_exit hw/block/nvme.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.11.0

[Qemu-devel] [PATCH 2/2] nvme: free cmbuf in nvme_exit

2018-10-29 Thread Li Qiang
This avoid a memory leak in unhotplug nvme device. Signed-off-by: Li Qiang --- hw/block/nvme.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 359a06d0ad..09d7c90259 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -1332,6 +1332,9 @@ static

Re: [Qemu-devel] [RFC PATCH 00/21] Trace updates and plugin RFC

2018-10-29 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Pavel Dovgalyuk writes: > > >> From: Alex Bennée [mailto:alex.ben...@linaro.org] > >> Pavel Dovgalyuk writes: > >> > >> >> From: Alex Bennée [mailto:alex.ben...@linaro.org] > >> >> Any serious analysis tool should allow for us to track all

Re: [Qemu-devel] [PATCH] hw/pvrdma: Check the correct return value

2018-10-29 Thread Marcel Apfelbaum
On 10/25/18 9:17 AM, Yuval Shaia wrote: Return value of 0 means ok, we want to free the memory only in case of error. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_cmd.c

[Qemu-devel] [PATCH v2 0/1] Add PKU on Skylake-Server CPU model

2018-10-29 Thread Tao Xu
This patch adds PKU on Skylake-Server CPU model. Changelog: v2 Remove OSPKE which is not needed. Add Skylake-Server-*-cpu.pku=off entries on PC_COMPAT_3_0 to keep PKU disabled on pc-*-3.0 and older. Tao Xu (1): i386: Add PKU on Skylake-Server CPU model

[Qemu-devel] [PATCH v2 1/1] i386: Add PKU on Skylake-Server CPU model

2018-10-29 Thread Tao Xu
As the release document ref below link (page 13): https://software.intel.com/sites/default/files/managed/c5/15/\ architecture-instruction-set-extensions-programming-reference.pdf PKU is supported in Skylake Server (Only Server) and later, and on Intel(R) Xeon(R) Processor Scalable Family. So PKU

Re: [Qemu-devel] [PATCH 2/3] adlib: mark as insecure and deprecated.

2018-10-29 Thread Gerd Hoffmann
On Fri, Oct 26, 2018 at 05:23:37PM +0530, P J P wrote: > +-- On Fri, 26 Oct 2018, Paolo Bonzini wrote --+ > | Oh, thanks! I said I was dumb. :) So the fix is just this: > | > | diff --git a/hw/audio/fmopl.h b/hw/audio/fmopl.h > | index e7e578a48e..7199afaa3c 100644 > | --- a/hw/audio/fmopl.h >

Re: [Qemu-devel] [PATCH 3/3] cirrus: mark as deprecated

2018-10-29 Thread Gerd Hoffmann
On Thu, Oct 25, 2018 at 09:37:58PM +0100, Daniel P. Berrangé wrote: > On Thu, Oct 25, 2018 at 10:52:56AM +0200, Gerd Hoffmann wrote: > > While being at it deprecate cirrus too. > > > > Reason (short version): use stdvga instead. > > Verbose version: > >

Re: [Qemu-devel] [PULL 0/9] Testing patches

2018-10-29 Thread Peter Maydell
On 26 October 2018 at 15:15, Fam Zheng wrote: > The following changes since commit 808ebd66e467f77c0d1f8c6346235f81e9c99cf2: > > Merge remote-tracking branch 'remotes/riscv/tags/riscv-for-master-3.1-sf0' > into staging (2018-10-25 17:41:03 +0100) > > are available in the Git repository at: > >

  1   2   3   4   >