[Qemu-devel] [PATCH v2] target/xtensa: drop num_[core_]regs from dc232b/dc233c configs

2018-11-02 Thread Max Filippov
gdb_regmap::num_core_regs field is initialized incorrectly in the dc232b and dc233c configurations. As a result the following message is displayed when attaching to an xtensa linux-user process: "Register 105 is not available", and gdb is unable to control the inferior. Now that

[Qemu-devel] [PATCH] vdi: Use a literal number of bytes for DEFAULT_CLUSTER_SIZE

2018-11-02 Thread Leonid Bloch
If an expression is used to define DEFAULT_CLUSTER_SIZE, when compiled, it will be embedded as a literal expression in the binary (as the default value) because it is stringified to mark the size of the default value. Now this is fixed by using a defined number to define this value.

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-02 Thread Liran Alon
> On 2 Nov 2018, at 18:39, Jim Mattson wrote: > > On Thu, Nov 1, 2018 at 8:46 PM, Liran Alon wrote: > >> Hmm this makes sense. >> >> This means though that the patch I have submitted here isn't good enough. >> My patch currently assumes that when it attempts to get nested state from >>

Re: [Qemu-devel] [PATCH] chardev: fix mess in OPENED/CLOSED events when muxed

2018-11-02 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 0084f7223c080cdbdfc2c5a2d132f8d6c0eff866.1541083966.git.artem.k.pisare...@gmail.com

[Qemu-devel] [Bug 588693] Re: CD-ROM devices always return a one session, one track TOC

2018-11-02 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/588693 Title: CD-ROM

[Qemu-devel] [Bug 588688] Re: Hard disk images are supporting ATAPI commands. They should fail.

2018-11-02 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/588688 Title: Hard disk

Re: [Qemu-devel] [PATCH v3 00/13] arm: nRF51 Devices and Microbit Support

2018-11-02 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181031002526.14262-1-cont...@steffen-goertz.de Subject: [Qemu-devel] [PATCH v3 00/13]

Re: [Qemu-devel] [PATCH] tests/bios-tables-test: Sanitize test verbose output

2018-11-02 Thread Thomas Huth
On 2018-10-30 00:18, Philippe Mathieu-Daudé wrote: > Fix the extraneous extra blank lines in the test output when running with V=1. > > Before: > > TEST: tests/bios-tables-test... (pid=25678) > /i386/acpi/piix4: > Looking for expected file 'tests/acpi-test-data/pc/DSDT' > >

Re: [Qemu-devel] [PATCH v2 00/10] hostmem: use object "id" for memory region name with >= 3.1

2018-11-02 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181030150453.9344-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/10]

Re: [Qemu-devel] [PATCH] qemu/units: Move out QCow2 specific definitions

2018-11-02 Thread Leonid Bloch
Hi, On 11/2/18 5:28 PM, Kevin Wolf wrote: > Am 02.11.2018 um 15:52 hat Eric Blake geschrieben: >> On 11/2/18 9:10 AM, Kevin Wolf wrote: >>> Am 02.11.2018 um 13:37 hat Philippe Mathieu-Daudé geschrieben: Hi Kevin, On 2/11/18 12:07, Kevin Wolf wrote: > Am 02.11.2018 um 09:58 hat

[Qemu-devel] [PATCH] include: Add a comment to explain the origin of sizes' lookup table

2018-11-02 Thread Leonid Bloch
The lookup table for power-of-two sizes was added in commit 540b8492618eb for the purpose of having convenient shortcuts for these sizes in cases when the literal number has to be present at compile time, and expressions as '(1 * KiB)' can not be used. One such case is the stringification of

Re: [Qemu-devel] [PATCH v2 00/10] hostmem: use object "id" for memory region name with >= 3.1

2018-11-02 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181030150453.9344-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/10]

Re: [Qemu-devel] [PATCH v3 00/13] arm: nRF51 Devices and Microbit Support

2018-11-02 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181031002526.14262-1-cont...@steffen-goertz.de Subject: [Qemu-devel] [PATCH v3 00/13]

Re: [Qemu-devel] [PATCH] target/arm: Conditionalize arm_div assert on aarch32 support

2018-11-02 Thread Alex Bennée
Richard Henderson writes: > When populating id registers from kvm, on a host that doesn't support > aarch32 mode at all, aa32_arm_div will not be supported either. > > Signed-off-by: Richard Henderson > --- > > "Tested" on an APM Mustang, which does support AArch32. I'm not > sure, off hand,

Re: [Qemu-devel] [PULL 1/2] qxl: store channel id in qxl->id

2018-11-02 Thread Frediano Ziglio
> > See qemu_spice_add_display_interface(), the console index is also used > as channel id. So put that into the qxl->id field too. > > In typical use cases (one primary qxl-vga device, optionally one or more > secondary qxl devices, no non-qxl display devices) this doesn't change > anything. >

Re: [Qemu-devel] [PATCH v4 03/23] hw: acpi: Export the RSDP build API

2018-11-02 Thread Shannon Zhao
Hi, On 2018/11/1 18:22, Samuel Ortiz wrote: diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index f28a2faa53..0ed132b79b 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -367,7 +367,7 @@ static void acpi_dsdt_add_power_button(Aml *scope) } /* RSDP

[Qemu-devel] [PATCH 1/1] virtio: pass argument by value for virtqueue_map_iovec()

2018-11-02 Thread Dongli Zhang
Pass num_sg by value instead of by pointer, as num_sg is never modified in virtqueue_map_iovec(). Signed-off-by: Dongli Zhang --- hw/virtio/virtio.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 4136d23..a5cb4e6 100644

Re: [Qemu-devel] [PATCH] docker: Use a stable snapshot for Debian Sid

2018-11-02 Thread Fam Zheng
On Thu, 11/01 19:37, Philippe Mathieu-Daudé wrote: > The Debian Sid repository is not garanteed to be stable, as his > 'unstable' name suggest :) > To allow quick testing, packages are pushed various time a day, > which my be annoying when trying to use it for stable development > (which is not

Re: [Qemu-devel] [PATCH] block/nvme: optimize the performance of nvme driver based on vfio-pci

2018-11-02 Thread Fam Zheng
On Thu, 11/01 18:38, Li Feng wrote: > When the IO size is larger than 2 pages, we move the the pointer one by > one in the pagelist, this is inefficient. > > This is a simple benchmark result: > > Before: > $ qemu-io -c 'write 0 1G' nvme://:00:04.0/1 > > wrote 1073741824/1073741824 bytes at

Re: [Qemu-devel] [PATCH RFC v7 5/9] migration: fix the multifd code when sending less channels

2018-11-02 Thread Fei Li
On 11/02/2018 11:32 AM, Peter Xu wrote: On Fri, Nov 02, 2018 at 11:00:24AM +0800, Fei Li wrote: On 11/02/2018 10:37 AM, Peter Xu wrote: On Thu, Nov 01, 2018 at 06:17:11PM +0800, Fei Li wrote: Set the migration state to "failed" instead of "setup" when failing to send packet via some

Re: [Qemu-devel] [PATCH for 3.2 v2 0/7] hw/arm/bcm2835: Add basic support for cprman (clock subsystem)

2018-11-02 Thread Philippe Mathieu-Daudé
On Fri, Nov 2, 2018 at 8:32 AM Philippe Mathieu-Daudé wrote: > > Hi Guenter, > > On Fri, Nov 2, 2018 at 3:52 AM Guenter Roeck wrote: > > > > On 11/1/18 5:12 PM, Philippe Mathieu-Daudé wrote: > > > Hi, > > > > > > This series is a mix of a previous work I had for the raspi, and a patch > > >

[Qemu-devel] How to emulate block I/O timeout on qemu side?

2018-11-02 Thread Dongli Zhang
Hi, Is there any way to emulate I/O timeout on qemu side (not fault injection in VM kernel) without modifying qemu source code? For instance, I would like to observe/study/debug the I/O timeout handling of nvme, scsi, virtio-blk (not supported) of VM kernel. Is there a way to trigger this on

Re: [Qemu-devel] [PATCH] docker: Use a stable snapshot for Debian Sid

2018-11-02 Thread Philippe Mathieu-Daudé
Hi Fam, Thanks for picking this. On Fri, Nov 2, 2018 at 7:48 AM Fam Zheng wrote: > On Thu, 11/01 19:37, Philippe Mathieu-Daudé wrote: > > The Debian Sid repository is not garanteed to be stable, as his > > 'unstable' name suggest :) There is an error in "my be" -> "might be"... Do you mind to

Re: [Qemu-devel] [PATCH RFC v7 5/9] migration: fix the multifd code when sending less channels

2018-11-02 Thread Peter Xu
On Fri, Nov 02, 2018 at 03:13:05PM +0800, Fei Li wrote: > > > On 11/02/2018 11:32 AM, Peter Xu wrote: > > On Fri, Nov 02, 2018 at 11:00:24AM +0800, Fei Li wrote: > > > > > > On 11/02/2018 10:37 AM, Peter Xu wrote: > > > > On Thu, Nov 01, 2018 at 06:17:11PM +0800, Fei Li wrote: > > > > > Set the

Re: [Qemu-devel] [PATCH for 3.2 v2 0/7] hw/arm/bcm2835: Add basic support for cprman (clock subsystem)

2018-11-02 Thread Philippe Mathieu-Daudé
Hi Guenter, On Fri, Nov 2, 2018 at 3:52 AM Guenter Roeck wrote: > > On 11/1/18 5:12 PM, Philippe Mathieu-Daudé wrote: > > Hi, > > > > This series is a mix of a previous work I had for the raspi, and a patch > > from > > Guenter:

[Qemu-devel] [PATCH] qemu/units: Move out QCow2 specific definitions

2018-11-02 Thread Philippe Mathieu-Daudé
This definitions are QCow2 specific, there is no need to expose them in the global namespace. This partially reverts commit 540b8492618eb. Signed-off-by: Philippe Mathieu-Daudé --- block/qcow2.h| 56 +++- include/qemu/units.h | 55

[Qemu-devel] [PATCH 1/3] Improve xen_disk batching behaviour

2018-11-02 Thread Tim Smith
When I/O consists of many small requests, performance is improved by batching them together in a single io_submit() call. When there are relatively few requests, the extra overhead is not worth it. This introduces a check to start batching I/O requests via blk_io_plug()/ blk_io_unplug() in an

[Qemu-devel] [PATCH 2/3] Improve xen_disk response latency

2018-11-02 Thread Tim Smith
If the I/O ring is full, the guest cannot send any more requests until some responses are sent. Only sending all available responses just before checking for new work does not leave much time for the guest to supply new work, so this will cause stalls if the ring gets full. Also, not completing

Re: [Qemu-devel] [PULL 0/3] decodetree improvements

2018-11-02 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181031165321.4422-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PULL 0/3] decodetree improvements === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] strange situation, guest cpu thread spinning at ~100%, but display not yet initialized

2018-11-02 Thread Alex Bennée
Chris Friesen writes: > Hi all, > > I have an odd situation which occurs very infrequently and I'm hoping > to get some advice on how to debug. Apologies for the length of this > message, I tried to include as much potentially useful information as > possible. > > In the context of an

Re: [Qemu-devel] [PATCH] nvme: fix oob access issue(CVE-2018-16847)

2018-11-02 Thread Philippe Mathieu-Daudé
On 2/11/18 2:22, Li Qiang wrote: Currently, the nvme_cmb_ops mr doesn't check the addr and size. This can lead an oob access issue. This is triggerable in the guest. Add check to avoid this issue. Fixes CVE-2018-16847. Reported-by: Li Qiang Reviewed-by: Paolo Bonzini Signed-off-by: Li Qiang

Re: [Qemu-devel] [PATCH v3 00/35] target/riscv: Convert to decodetree

2018-11-02 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181031132029.4887-1-kbast...@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v3 00/35] target/riscv: Convert to decodetree === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH v1] bt: use size_t type for length parameters instead of int

2018-11-02 Thread P J P
+-- On Sat, 27 Oct 2018, P J P wrote --+ |+-- On Sun, 21 Oct 2018, P J P wrote --+ || The length parameter values are not negative, thus use an unsigned || type 'size_t' for them. Many routines pass 'len' values to memcpy(3) || calls. If it was negative, it could lead to memory corruption issues.

[Qemu-devel] [PATCH 3/3] Avoid repeated memory allocation in xen_disk

2018-11-02 Thread Tim Smith
xen_disk currently allocates memory to hold the data for each ioreq as that ioreq is used, and frees it afterwards. Because it requires page-aligned blocks, this interacts poorly with non-page-aligned allocations and balloons the heap. Instead, allocate the maximum possible requirement, which is

Re: [Qemu-devel] [PATCH v4 05/23] hw: arm: Switch to the AML build RSDP building routine

2018-11-02 Thread Shannon Zhao
On 2018/11/2 17:35, Shannon Zhao wrote: On 2018/11/1 18:22, Samuel Ortiz wrote: We make the ARM virt ACPI code use the now shared build_rsdp() API from aml-build.c. By doing so we fix a bug where the ARM implementation was missing adding both the legacy and extended checksums, which was

[Qemu-devel] [PATCH v2] target/arm: Conditionalize some asserts on aarch32 support

2018-11-02 Thread Richard Henderson
When populating id registers from kvm, on a host that doesn't support aarch32 mode at all, neither arm_div nor jazelle will be supported either. Signed-off-by: Richard Henderson --- v2: Test aa64pfr.el0 >= 2; rename to isar_feature_aa64_aa32. Pull out realizefn test to no_aa32 bool; use it

[Qemu-devel] [PATCH v1 0/5] s390x/vfio: VFIO-AP interrupt control interception

2018-11-02 Thread Pierre Morel
The S390 APQP/AQIC instruction can be intercepted by the host to configure the AP queues interruption handling for and handle the ISC used by the host and the guest and the indicator address. This patch series define the AQIC feature in the cpumodel, extend the APDevice type for per queue

[Qemu-devel] [PATCH v1 1/5] s390x/vfio: ap: Linux uapi VFIO place holder

2018-11-02 Thread Pierre Morel
This file would be copied from Linux, I put it here for the review. Signed-off-by: Pierre Morel --- linux-headers/linux/vfio.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h index ceb6453394..32b1fec362 100644

Re: [Qemu-devel] [PATCH] qemu/units: Move out QCow2 specific definitions

2018-11-02 Thread Kevin Wolf
Am 02.11.2018 um 09:58 hat Philippe Mathieu-Daudé geschrieben: > This definitions are QCow2 specific, there is no need to expose them > in the global namespace. > > This partially reverts commit 540b8492618eb. > > Signed-off-by: Philippe Mathieu-Daudé If we don't want this globally, I think we

[Qemu-devel] [PATCH v2 for-3.1 3/4] configure: Rename FILES variable to LINKS

2018-11-02 Thread Peter Maydell
The FILES variable is used to accumulate a list of things to symlink from the source tree into the build tree. These don't have to be individual files; symlinking an entire directory of data files is also fine. Rename it to something less confusing before we add a few directories to it. Improve

Re: [Qemu-devel] [PATCH] target/arm: Conditionalize arm_div assert on aarch32 support

2018-11-02 Thread Peter Maydell
On 1 November 2018 at 21:57, Richard Henderson wrote: > When populating id registers from kvm, on a host that doesn't support > aarch32 mode at all, aa32_arm_div will not be supported either. > > Signed-off-by: Richard Henderson > --- > > "Tested" on an APM Mustang, which does support AArch32.

Re: [Qemu-devel] [PULL 0/3] decodetree improvements

2018-11-02 Thread Peter Maydell
On 31 October 2018 at 16:53, Richard Henderson wrote: > The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd: > > Merge remote-tracking branch > 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging > (2018-10-30 15:49:55 +) > > are available in the

[Qemu-devel] [PATCH 2/3] Improve xen_disk response latency

2018-11-02 Thread Tim Smith
If the I/O ring is full, the guest cannot send any more requests until some responses are sent. Only sending all available responses just before checking for new work does not leave much time for the guest to supply new work, so this will cause stalls if the ring gets full. Also, not completing

[Qemu-devel] [PATCH 3/3] Avoid repeated memory allocation in xen_disk

2018-11-02 Thread Tim Smith
xen_disk currently allocates memory to hold the data for each ioreq as that ioreq is used, and frees it afterwards. Because it requires page-aligned blocks, this interacts poorly with non-page-aligned allocations and balloons the heap. Instead, allocate the maximum possible requirement, which is

[Qemu-devel] [PATCH 0/3] Performance improvements for xen_disk v2

2018-11-02 Thread Tim Smith
A series of performance improvements for disks using the Xen PV ring. These have had fairly extensive testing. The batching and latency improvements together boost the throughput of small reads and writes by two to six percent (measured using fio in the guest) Avoiding repeated calls to

[Qemu-devel] [PATCH v1 3/5] s390x/vfio: ap: Definition for AP Adapter type

2018-11-02 Thread Pierre Morel
From: Pierre Morel Let's define the AP adapter type to use it with standard adapter interface. Signed-off-by: Pierre Morel --- include/hw/s390x/css.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/s390x/css.h b/include/hw/s390x/css.h index aae19c4272..9946492214 100644 ---

Re: [Qemu-devel] [PATCH v4 4/4] hw/arm: versal: Add a virtual Xilinx Versal board

2018-11-02 Thread Edgar E. Iglesias
On Tue, Oct 30, 2018 at 01:31:44PM +, Peter Maydell wrote: > On 22 October 2018 at 18:35, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > > > Add a virtual Xilinx Versal board. > > > > This board is based on the Xilinx Versal SoC. The exact > > details of what peripherals are

[Qemu-devel] [PATCH v2 for-3.1 2/4] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/

2018-11-02 Thread Peter Maydell
Currently tests/hex-loader-check-data contains data files used by the hexloader-test, and configure individually symlinks those data files into the build directory using a wildcard. Using a wildcard like this is a bad idea, because if a new data file is added, nothing causes configure to be

[Qemu-devel] [PATCH v2 for-3.1 0/4] configure: symlink directories, not wildcarded files

2018-11-02 Thread Peter Maydell
This patchset fixes a problem with our build infrastructure that meant that MST's recent 'pci, pc, virtio' pullreq failed tests. Currently our configure script has a wildcard loop that creates symlinks for every data file in tests/acpi-test-data from the source tree to the build tree. However, if

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-02 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 02/11/2018 04:46, Liran Alon wrote: > >> On Thu, Nov1, 2018 at 09:45 AM, Jim Mattson wrote: > > > >>> On Thu, Nov 1, 2018 at 8:56 AM, Dr. David Alan Gilbert > >>> wrote: > > > >>> So if I have matching host kernels it should always work? > >>>

Re: [Qemu-devel] [PATCH 00/12] file-posix: Simplify delegation to worker thread

2018-11-02 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181031215622.27690-1-kw...@redhat.com Subject: [Qemu-devel] [PATCH 00/12] file-posix: Simplify delegation to worker thread === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH v2 3/5] MAINTAINERS: use 'https://' instead of 'git://' for GitHub

2018-11-02 Thread Stefan Hajnoczi
When you clone the repository without previous commit history, 'git://' doesn't protect from man-in-the-middle attacks. HTTPS is more secure since the client verifies the server certificate. Reported-by: Jann Horn Reviewed-by: Daniel P. Berrangé Acked-by: Cornelia Huck Signed-off-by: Stefan

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-02 Thread Liran Alon
> On 2 Nov 2018, at 11:40, Paolo Bonzini wrote: > > On 02/11/2018 04:46, Liran Alon wrote: >>> On Thu, Nov1, 2018 at 09:45 AM, Jim Mattson wrote: >> On Thu, Nov 1, 2018 at 8:56 AM, Dr. David Alan Gilbert wrote: >> So if I have matching host kernels it should always work?

Re: [Qemu-devel] xen_disk qdevification (was: [PATCH 0/3] Performance improvements for xen_disk v2)

2018-11-02 Thread Paul Durrant
> -Original Message- > From: Kevin Wolf [mailto:kw...@redhat.com] > Sent: 02 November 2018 11:04 > To: Tim Smith > Cc: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org; qemu- > bl...@nongnu.org; Anthony Perard ; Paul Durrant > ; Stefano Stabellini ; > Max Reitz ; arm...@redhat.com >

Re: [Qemu-devel] [PATCH for-3.1] hw/ppc/mac_newworld: Free openpic_irqs array after use

2018-11-02 Thread Mark Cave-Ayland
On 01/11/2018 16:17, Peter Maydell wrote: > In ppc_core99_init(), we allocate an openpic_irqs array, which > we then use to collect up the various qemu_irqs which we're > going to connect to the interrupt controller. Once we've > called sysbus_connect_irq() to connect them all up, the > array is

Re: [Qemu-devel] [PATCH 1/3] Improve xen_disk batching behaviour

2018-11-02 Thread Paul Durrant
> -Original Message- > From: Tim Smith [mailto:tim.sm...@citrix.com] > Sent: 02 November 2018 10:01 > To: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org; qemu- > bl...@nongnu.org > Cc: Anthony Perard ; Kevin Wolf > ; Paul Durrant ; Stefano > Stabellini ; Max Reitz > Subject: [PATCH

Re: [Qemu-devel] [PATCH 3/3] Avoid repeated memory allocation in xen_disk

2018-11-02 Thread Paul Durrant
> -Original Message- > From: Tim Smith [mailto:tim.sm...@citrix.com] > Sent: 02 November 2018 10:01 > To: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org; qemu- > bl...@nongnu.org > Cc: Anthony Perard ; Kevin Wolf > ; Paul Durrant ; Stefano > Stabellini ; Max Reitz > Subject: [PATCH

Re: [Qemu-devel] [PATCH 2/3] Improve xen_disk response latency

2018-11-02 Thread Paul Durrant
> -Original Message- > From: Tim Smith [mailto:tim.sm...@citrix.com] > Sent: 02 November 2018 10:01 > To: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org; qemu- > bl...@nongnu.org > Cc: Anthony Perard ; Kevin Wolf > ; Paul Durrant ; Stefano > Stabellini ; Max Reitz > Subject:

Re: [Qemu-devel] [PATCH for-3.1] hw/ppc/mac_newworld: Free openpic_irqs array after use

2018-11-02 Thread Peter Maydell
On 2 November 2018 at 11:14, Mark Cave-Ayland wrote: > On 01/11/2018 16:17, Peter Maydell wrote: > >> In ppc_core99_init(), we allocate an openpic_irqs array, which >> we then use to collect up the various qemu_irqs which we're >> going to connect to the interrupt controller. Once we've >> called

Re: [Qemu-devel] [PATCH v5 00/11] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-11-02 Thread Laurent Vivier
On 02/11/2018 01:32, Thomas Huth wrote: > On 2018-10-30 13:39, Laurent Vivier wrote: >> Le 30/10/2018 à 14:12, Mark Cave-Ayland a écrit : >>> On 30/10/2018 12:49, Laurent Vivier wrote: >>> Le 30/10/2018 à 12:48, Mark Cave-Ayland a écrit : > On 30/10/2018 08:15, Richard Henderson wrote:

Re: [Qemu-devel] [PULL v2 0/7] Chardev patches

2018-11-02 Thread Peter Maydell
On 1 November 2018 at 08:24, Marc-André Lureau wrote: > The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd: > > Merge remote-tracking branch > 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging > (2018-10-30 15:49:55 +) > > are available in the

Re: [Qemu-devel] [PATCH v4 00/23] ACPI reorganization for hardware-reduced support

2018-11-02 Thread Igor Mammedov
On Thu, 1 Nov 2018 11:22:40 +0100 Samuel Ortiz wrote: Thanks for looking at ACPI mess we have in QEMU and trying to make it better, this series look a bit hackish probably because it was written to suit new virt board, so it needs some more clean up to be done. > This patch set provides an

Re: [Qemu-devel] [PATCH] target/arm: Conditionalize arm_div assert on aarch32 support

2018-11-02 Thread Richard Henderson
On 11/2/18 9:48 AM, Peter Maydell wrote: >> +static inline bool isar_feature_aa64_a32(const ARMISARegisters *id) >> +{ >> +return FIELD_EX64(id->id_aa64pfr0, ID_AA64PFR0, EL0) == 2; >> +} >> + > > Doesn't the stuff in the Arm ARM's "Principles of the ID > scheme for fields in ID registers"

Re: [Qemu-devel] [PATCH v4 05/23] hw: arm: Switch to the AML build RSDP building routine

2018-11-02 Thread Igor Mammedov
On Fri, 2 Nov 2018 17:35:06 +0800 Shannon Zhao wrote: > On 2018/11/1 18:22, Samuel Ortiz wrote: > > We make the ARM virt ACPI code use the now shared build_rsdp() API from > > aml-build.c. By doing so we fix a bug where the ARM implementation was > > missing adding both the legacy and extended

[Qemu-devel] [PATCH v1 2/5] s390x/cpumodel: Set up CPU model for AQIC interception

2018-11-02 Thread Pierre Morel
A new CPU model facilities is introduced to support AP devices interruption interception for a KVM guest. CPU model facility: The S390_FEAT_AP_QUEUE_INTERRUPT_CONTROL, CPU facility indicates whether AP interruption interception is available to the guest. This feature will be enabled only if the

[Qemu-devel] [PATCH v1 5/5] s390x/vfio: ap: Implementing AP Queue Interrupt Control

2018-11-02 Thread Pierre Morel
We intercept the PQAP(AQIC) instruction and transform the guest's AQIC command parameters for the host AQIC parameters. Doing this we use the standard adapter interface to provide the adapter NIB, indicator and ISC. We define a new structure, APQueue to keep track of the route and indicator

[Qemu-devel] [PATCH v1 4/5] s390x/vfio: ap: Intercepting AP Queue Interrupt Control

2018-11-02 Thread Pierre Morel
From: Pierre Morel We intercept the PQAP(AQIC) instruction. Until we implement AQIC we return a PGM_OPERATION. Signed-off-by: Pierre Morel --- hw/vfio/ap.c | 10 ++ include/hw/s390x/ap-device.h | 9 + target/s390x/kvm.c | 20 3

Re: [Qemu-devel] [PATCH v2 5/5] git: use HTTPS git URLs for repo.or.cz

2018-11-02 Thread Eric Blake
On 11/2/18 7:42 AM, Stefan Hajnoczi wrote: repo.or.cz supports git smart HTTPS. Use it in preference to git:// or http:// since it's more secure. Not sure why you didn't copy-paste the commit messages from the other patches, but it doesn't really matter. Suggested-by: Eric Blake

Re: [Qemu-devel] [PATCH 3/4] MAINTAINERS: use 'https://' instead of 'git://' for GitHub

2018-11-02 Thread Stefan Hajnoczi
On Wed, Oct 31, 2018 at 08:31:09AM -0500, Eric Blake wrote: > On 10/31/18 3:43 AM, Stefan Hajnoczi wrote: > > When you clone the repository without previous commit history, 'git://' > > doesn't protect from man-in-the-middle attacks. HTTPS is more secure > > since the client verifies the server

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-02 Thread Paolo Bonzini
On 02/11/2018 04:46, Liran Alon wrote: >> On Thu, Nov1, 2018 at 09:45 AM, Jim Mattson wrote: > >>> On Thu, Nov 1, 2018 at 8:56 AM, Dr. David Alan Gilbert >>> wrote: > >>> So if I have matching host kernels it should always work? >>> What happens if I upgrade the source kernel to increase it's

Re: [Qemu-devel] [PATCH] docs/block-replication.txt: Add more detail about replication_do_checkpoint_all

2018-11-02 Thread Zhang Chen
Hi All, Maybe we have forgot this patch? Ping again. Related discussion: https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03352.html Thanks Zhang Chen On Fri, Sep 14, 2018 at 2:32 PM Zhang Chen wrote: > Hi All, > > No news update? > Ping... > > Thanks > Zhang Chen > > On Thu, Sep 6,

Re: [Qemu-devel] [PATCH v4 03/23] hw: acpi: Export the RSDP build API

2018-11-02 Thread Philippe Mathieu-Daudé
Hi, On 2/11/18 10:20, Shannon Zhao wrote: Hi, On 2018/11/1 18:22, Samuel Ortiz wrote: diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index f28a2faa53..0ed132b79b 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -367,7 +367,7 @@ static void

[Qemu-devel] xen_disk qdevification (was: [PATCH 0/3] Performance improvements for xen_disk v2)

2018-11-02 Thread Kevin Wolf
Am 02.11.2018 um 11:00 hat Tim Smith geschrieben: > A series of performance improvements for disks using the Xen PV ring. > > These have had fairly extensive testing. > > The batching and latency improvements together boost the throughput > of small reads and writes by two to six percent

[Qemu-devel] [PATCH v2 for-3.1 1/4] tests: Move tests/acpi-test-data/ to tests/data/acpi/

2018-11-02 Thread Peter Maydell
Currently tests/acpi-test-data contains data files used by the bios-tables-test, and configure individually symlinks those data files into the build directory using a wildcard. Using a wildcard like this is a bad idea, because if a new data file is added, nothing causes configure to be rerun, and

[Qemu-devel] [PATCH v2 for-3.1 4/4] configure: Use LINKS loop for all build tree symlinks

2018-11-02 Thread Peter Maydell
A few places in configure were doing ad-hoc calls to the symlink function to set up symlinks from the build tree back to the source tree. We have a loop that does this already for all files and directories listed in the LINKS environment variable; use that instead. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH v2 4/5] gitmodules: use 'https://' instead of 'git://'

2018-11-02 Thread Stefan Hajnoczi
When you clone the repository without previous commit history, 'git://' doesn't protect from man-in-the-middle attacks. HTTPS is more secure since the client verifies the server certificate. Also change git.qemu-project.org to git.qemu.org (we control both domain names but qemu.org is used more

Re: [Qemu-devel] [PATCH v4 09/10] block/nbd-client: nbd reconnect

2018-11-02 Thread Vladimir Sementsov-Ogievskiy
31.07.2018 20:30, Vladimir Sementsov-Ogievskiy wrote: > Implement reconnect. To achieve this: > > 1. add new modes: > connecting-wait: means, that reconnecting is in progress, and there > were small number of reconnect attempts, so all requests are > waiting for the connection. >

[Qemu-devel] [PATCH v2 1/5] README: use 'https://' instead of 'git://'

2018-11-02 Thread Stefan Hajnoczi
When you clone the repository without previous commit history, 'git://' doesn't protect from man-in-the-middle attacks. HTTPS is more secure since the client verifies the server certificate. Reported-by: Jann Horn Reviewed-by: Daniel P. Berrangé Signed-off-by: Stefan Hajnoczi --- README

Re: [Qemu-devel] [PATCH v4 05/23] hw: arm: Switch to the AML build RSDP building routine

2018-11-02 Thread Shannon Zhao
On 2018/11/1 18:22, Samuel Ortiz wrote: We make the ARM virt ACPI code use the now shared build_rsdp() API from aml-build.c. By doing so we fix a bug where the ARM implementation was missing adding both the legacy and extended checksums, which was building an invalid RSDP table.

Re: [Qemu-devel] [Qemu-arm] [PATCH v4 06/23] hw: acpi: Generalize AML build routines

2018-11-02 Thread Shannon Zhao
On 2018/11/1 18:22, Samuel Ortiz wrote: diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 0a6a88380a..6822ee4eaa 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -546,7 +546,7 @@ build_srat(GArray *table_data, BIOSLinker *linker, VirtMachineState

[Qemu-devel] [PATCH 1/3] Improve xen_disk batching behaviour

2018-11-02 Thread Tim Smith
When I/O consists of many small requests, performance is improved by batching them together in a single io_submit() call. When there are relatively few requests, the extra overhead is not worth it. This introduces a check to start batching I/O requests via blk_io_plug()/ blk_io_unplug() in an

Re: [Qemu-devel] [PATCH] nvme: fix oob access issue(CVE-2018-16847)

2018-11-02 Thread Kevin Wolf
Am 02.11.2018 um 02:22 hat Li Qiang geschrieben: > Currently, the nvme_cmb_ops mr doesn't check the addr and size. > This can lead an oob access issue. This is triggerable in the guest. > Add check to avoid this issue. > > Fixes CVE-2018-16847. > > Reported-by: Li Qiang > Reviewed-by: Paolo

Re: [Qemu-devel] [PULL 0/3] migration queue

2018-11-02 Thread Peter Maydell
On 31 October 2018 at 16:57, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd: > > Merge remote-tracking branch > 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging >

[Qemu-devel] [PATCH] qapi: misc: change the 'pc' to unsinged 64 in CpuInfo

2018-11-02 Thread Li Qiang
When trigger a 'query-cpus' qmp, the pc is an signed value like following: {"arch": "x86", ... "pc": -1732653994, "halted": true,...} It is strange. Change it to uint64_t. Signed-off-by: Li Qiang --- qapi/misc.json | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v1 2/7] pcihp: overwrite hotplug handler recursively from the start

2018-11-02 Thread David Hildenbrand
On 01.11.18 15:10, Igor Mammedov wrote: > On Wed, 24 Oct 2018 12:19:25 +0200 > David Hildenbrand wrote: > >> For now, the hotplug handler is not called for devices that are >> being cold plugged. The hotplug handler is setup when the machine >> initialization is fully done. Only bridges that

Re: [Qemu-devel] xen_disk qdevification (was: [PATCH 0/3] Performance improvements for xen_disk v2)

2018-11-02 Thread Kevin Wolf
Am 02.11.2018 um 12:13 hat Paul Durrant geschrieben: > > -Original Message- > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Sent: 02 November 2018 11:04 > > To: Tim Smith > > Cc: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org; qemu- > > bl...@nongnu.org; Anthony Perard ; Paul

Re: [Qemu-devel] [PATCH v2] target/arm: Conditionalize some asserts on aarch32 support

2018-11-02 Thread Alex Bennée
Richard Henderson writes: > When populating id registers from kvm, on a host that doesn't support > aarch32 mode at all, neither arm_div nor jazelle will be supported either. > > Signed-off-by: Richard Henderson > --- > > v2: Test aa64pfr.el0 >= 2; rename to isar_feature_aa64_aa32. > Pull

[Qemu-devel] [PATCH v2 2/5] get_maintainer: use 'https://' instead of 'git://'

2018-11-02 Thread Stefan Hajnoczi
When you clone the repository without previous commit history, 'git://' doesn't protect from man-in-the-middle attacks. HTTPS is more secure since the client verifies the server certificate. Reported-by: Jann Horn Reviewed-by: Daniel P. Berrangé Signed-off-by: Stefan Hajnoczi ---

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-02 Thread Daniel P . Berrangé
On Fri, Nov 02, 2018 at 12:35:05PM +, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: > > On 02/11/2018 04:46, Liran Alon wrote: > > >> On Thu, Nov1, 2018 at 09:45 AM, Jim Mattson wrote: > > > > > >>> On Thu, Nov 1, 2018 at 8:56 AM, Dr. David Alan Gilbert > >

[Qemu-devel] [PATCH v2 5/5] git: use HTTPS git URLs for repo.or.cz

2018-11-02 Thread Stefan Hajnoczi
repo.or.cz supports git smart HTTPS. Use it in preference to git:// or http:// since it's more secure. Suggested-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- MAINTAINERS| 14 +++--- pc-bios/README | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git

[Qemu-devel] [PATCH v2 0/5] Use 'https://' instead of 'git://'

2018-11-02 Thread Stefan Hajnoczi
v2: * Use HTTPS for repo.or.cz [Eric] Jeff Cody has enabled git smart HTTP support on qemu.org. From now on HTTPS is the preferred protocol because it adds some protection against man-in-the-middle when cloning a repo. This patch series updates git:// URLs and changes them to https://. The

Re: [Qemu-devel] [PATCH v1 0/5] s390x/vfio: VFIO-AP interrupt control interception

2018-11-02 Thread David Hildenbrand
On 02.11.18 11:30, Pierre Morel wrote: > The S390 APQP/AQIC instruction can be intercepted by the host > to configure the AP queues interruption handling for and handle > the ISC used by the host and the guest and the indicator address. > > This patch series define the AQIC feature in the

[Qemu-devel] [PATCH v5 2/2] hw/arm: versal: Add a virtual Xilinx Versal board

2018-11-02 Thread Edgar E. Iglesias
Add a virtual Xilinx Versal board. This board is based on the Xilinx Versal SoC. The exact details of what peripherals are attached to this board will remain in control of QEMU. QEMU will generate an FDT on the fly for Linux and other software to auto-discover peripherals. Signed-off-by: Edgar

[Qemu-devel] [PATCH v5 0/2] arm: Add first models of Xilinx Versal SoC

2018-11-02 Thread Edgar E. Iglesias
This patch series adds initial support for Xilinx's Versal SoC. Xilinx is introducing Versal, an adaptive compute acceleration platform (ACAP), built on 7nm FinFET process technology. Versal ACAPs combine Scalar Processing Engines, Adaptable Hardware Engines, and Intelligent Engines with

[Qemu-devel] [PATCH v5 1/2] hw/arm: versal: Add a model of Xilinx Versal SoC

2018-11-02 Thread Edgar E. Iglesias
Add a model of Xilinx Versal SoC. Signed-off-by: Edgar E. Iglesias --- default-configs/aarch64-softmmu.mak | 1 + hw/arm/Makefile.objs| 1 + hw/arm/xlnx-versal.c| 323 include/hw/arm/xlnx-versal.h| 122 +++ 4 files

[Qemu-devel] [PATCH for-4.0 1/4] target/arm: Move id_aa64mmfr* to ARMISARegisters

2018-11-02 Thread Richard Henderson
At the same time, define the fields for these registers, and use those defines in arm_pamax(). Signed-off-by: Richard Henderson --- target/arm/cpu.h | 22 -- target/arm/internals.h | 3 ++- target/arm/cpu64.c | 6 +++--- target/arm/helper.c| 4 ++-- 4 files

Re: [Qemu-devel] [PATCH v2] target/arm: Conditionalize some asserts on aarch32 support

2018-11-02 Thread Peter Maydell
On 2 November 2018 at 12:32, Alex Bennée wrote: > > Richard Henderson writes: > >> When populating id registers from kvm, on a host that doesn't support >> aarch32 mode at all, neither arm_div nor jazelle will be supported either. >> >> Signed-off-by: Richard Henderson >> --- >> >> v2: Test

Re: [Qemu-devel] [PATCH] qemu/units: Move out QCow2 specific definitions

2018-11-02 Thread Kevin Wolf
Am 02.11.2018 um 13:37 hat Philippe Mathieu-Daudé geschrieben: > Hi Kevin, > > On 2/11/18 12:07, Kevin Wolf wrote: > > Am 02.11.2018 um 09:58 hat Philippe Mathieu-Daudé geschrieben: > > > This definitions are QCow2 specific, there is no need to expose them > > > in the global namespace. > > > >

Re: [Qemu-devel] [PATCH] nvme: fix oob access issue(CVE-2018-16847)

2018-11-02 Thread Keith Busch
On Fri, Nov 02, 2018 at 11:54:21AM +0100, Kevin Wolf wrote: > Am 02.11.2018 um 02:22 hat Li Qiang geschrieben: > > Currently, the nvme_cmb_ops mr doesn't check the addr and size. > > This can lead an oob access issue. This is triggerable in the guest. > > Add check to avoid this issue. > > > >

Re: [Qemu-devel] [PATCH v3 08/13] hw/gpio/nrf51_gpio: Add nRF51 GPIO peripheral

2018-11-02 Thread Peter Maydell
On 31 October 2018 at 00:25, Steffen Görtz wrote: > This adds a model of the nRF51 GPIO peripheral. > > Reference Manual: http://infocenter.nordicsemi.com/pdf/nRF51_RM_v3.0.pdf > > The nRF51 series microcontrollers support up to 32 GPIO pins in various > configurations. > The pins can be used as

  1   2   3   >