Re: [Qemu-devel] [PATCH 1/4] configure: keep track of Python version

2018-11-09 Thread Eduardo Habkost
On Fri, Nov 09, 2018 at 10:07:07AM -0500, Cleber Rosa wrote: > Some functionality is dependent on the Python version > detected/configured on configure. While it's possible to run the > Python version later and check for the version, doing it once is > preferable. Also, it's a relevant

Re: [Qemu-devel] [RFC QEMU 1/2] arm/virt: Initialize generic timer scale factor dynamically

2018-11-09 Thread Bijan Mottahedeh
On 11/8/2018 6:21 AM, Richard Henderson wrote: On 11/7/18 7:48 PM, Bijan Mottahedeh wrote: +static void set_system_clock_scale(void) +{ +unsigned long cntfrq_el0; + +asm volatile("mrs %0, cntfrq_el0" : "=r"(cntfrq_el0)); + +if (cntfrq_el0 == 0) { +cntfrq_el0 =

[Qemu-devel] [PATCH 0/2] refactor fw_cfg_bootsplash() and fw_cfg_reboot()

2018-11-09 Thread Li Qiang
This patchset comes out as the result of the following review as per Markus's and Gerd's advice: -->https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg06975.html -->http://lists.gnu.org/archive/html/qemu-devel/2018-11/msg00701.html The second patch also fix that the user can set a negative

[Qemu-devel] [PATCH 2/2] hw: fw_cfg: refactor fw_cfg_reboot()

2018-11-09 Thread Li Qiang
Currently the user can set a negative reboot_timeout. Also it is wrong to parse 'reboot-timeout' with qemu_opt_get() and then convert it to number. This patch refactor this function by following: 1. ensure reboot_timeout is in 0~0x 2. use qemu_opt_get_number() to parse reboot_timeout 3.

[Qemu-devel] [PATCH 1/2] hw: fw_cfg: refactor fw_cfg_bootsplash()

2018-11-09 Thread Li Qiang
Currently when the splash-time value is bigger than 0x we report and correct it, when it is less than 0 we just ingore it. Also we use qemu_opt_get() to get 'splash-time', then convert it to a number ourselves. This is wrong. This patch does following: 1. use qemu_opt_get_number() to parse

Re: [Qemu-devel] [RFC/PoC PATCH 1/3] i386: set initrd_max to 4G - 1 to allow up to 4G initrd

2018-11-09 Thread H. Peter Anvin
On 11/9/18 5:40 AM, Li Zhijian wrote: > Just noticed that there is a field xloadflags at recent protocol >   60 Protocol 2.12:  (Kernel 3.8) Added the xloadflags field and > extension fields >   61 to struct boot_params for loading bzImage and ramdisk >   62 above

Re: [Qemu-devel] [PATCH 4/4] check-help: visual and content improvements

2018-11-09 Thread Eduardo Habkost
On Fri, Nov 09, 2018 at 10:07:10AM -0500, Cleber Rosa wrote: > The "check" target is not a target that will run all other tests > listed, so in order to be accurate it's necessary to list those that > will run. The same is true for "check-clean". > > Then, to give a better visual impression of

Re: [Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

2018-11-09 Thread Paolo Bonzini
On 09/11/2018 15:14, Gerd Hoffmann wrote: > Broken (segfaultson first keypress) and appearently unused. > > Signed-off-by: Gerd Hoffmann No objection, but can we make some effort of, at least, putting the stack backtrace in the commit log? Paolo > --- > include/hw/bt.h | 3 - >

Re: [Qemu-devel] [PATCH v1 0/3] intel-iommu: add support for 5-level virtual IOMMU.

2018-11-09 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1541764187-10732-1-git-send-email-yu.c.zh...@linux.intel.com Subject: [Qemu-devel] [PATCH v1 0/3] intel-iommu: add support for 5-level virtual IOMMU. === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PATCH for 3.1] RISC-V: Respect fences for user-only emulators

2018-11-09 Thread Alistair Francis
On Fri, Nov 9, 2018 at 11:21 AM Palmer Dabbelt wrote: > > Our current fence implementation ignores fences for the user-only > configurations. This is incorrect but unlikely to manifest: it requires > multi-threaded user-only code that takes advantage of the weakness in > the host's memory model

Re: [Qemu-devel] [PATCH] bitmap: Update count after a merge

2018-11-09 Thread John Snow
On 11/09/2018 12:57 PM, Eric Blake wrote: > On 9/27/18 12:23 PM, John Snow wrote: >> >> >> On 09/26/2018 11:11 PM, Eric Blake wrote: >>> We need an accurate count of the number of bits set in a bitmap >>> after a merge. In particular, since the merge operation short-circuits >>> a merge from an

Re: [Qemu-devel] [PATCH v2 00/11] block: Deal with filters

2018-11-09 Thread Eric Blake
On 8/9/18 5:31 PM, Max Reitz wrote: Note 1: This series depends on v10 of my “block: Fix some filename generation issues” series. Based-on: <20180809213528.14738-1-mre...@redhat.com> Note 2: This is technically the first part of my active mirror followup. But just very technically. I noticed

Re: [Qemu-devel] [PATCH v2 02/11] blockdev: Check @replaces in blockdev_mirror_common

2018-11-09 Thread Eric Blake
On 8/9/18 5:31 PM, Max Reitz wrote: There is no reason why the constraints we put on @replaces should be limited to drive-mirror. Therefore, move the sanity checks from qmp_drive_mirror() to blockdev_mirror_common() so they apply to blockdev-mirror as well. Signed-off-by: Max Reitz ---

Re: [Qemu-devel] [PATCH 1/4] configure: keep track of Python version

2018-11-09 Thread Cleber Rosa
On 11/9/18 1:25 PM, Eduardo Habkost wrote: >> >> "Python -V" is quite different from "sys.version". Indeed it includes >> the "Python " prefix, but that's all, everything else is the version number. > > Is this a guarantee documented somewhere? > Oops, looks like I missed that comment, and

Re: [Qemu-devel] [PATCH 2/4] check-venv: use recorded Python version

2018-11-09 Thread Eduardo Habkost
On Fri, Nov 09, 2018 at 10:07:08AM -0500, Cleber Rosa wrote: > The current approach works fine, but it runs Python on every make > command (even if it's not related to the venv usage). > > This is just an optimization, and not a change of behavior. > > Signed-off-by: Cleber Rosa Reviewed-by:

[Qemu-devel] [RFC PATCH 1/2] Acceptance Tests: add QemuImgTest base class

2018-11-09 Thread Cleber Rosa
Testing other utilities such as qemu-img do not require the same infrastructure that testing QEMU itself does. Let's add a base class that just sets the suitable qemu-img binary to be used during test. Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 20

[Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-09 Thread Cleber Rosa
The initial goal of this RFC is to get feedback on tests not specific to the QEMU main binary, but specific to other components such as qemu-img. For this experiment, a small issue with the zero and negative number of I/O operations given to the bench command was chosen. Cleber Rosa (2):

[Qemu-devel] [RFC PATCH 2/2] qemu-img: consider a zero number of I/O requests an invalid count

2018-11-09 Thread Cleber Rosa
It's debatable whether it makes sense to consider the bench command successful when no I/O requests will be performed. This changes the behavior to consider a zero count of I/O requests an invalid value. While at it, avoid using signed types for number of I/O requests. The image file used, is a

[Qemu-devel] [PATCH] Acceptance test: add coverage tests for -smp option

2018-11-09 Thread Wainer dos Santos Moschetta
This adds tests for SMP option, by passing -smp with various combinations of cpus, cores, threads, and sockets values it checks that invalid topologies are not accepted as well as missing values are correctly calculated. Signed-off-by: Wainer dos Santos Moschetta ---

[Qemu-devel] [PATCH] RFC: net/socket: learn to talk with a unix dgram socket

2018-11-09 Thread Marc-André Lureau
-net socket has a fd argument, and may be passed pre-opened sockets. TCP sockets use framing. UDP sockets have datagram boundaries. When given a unix dgram socket, it will be able to read from it, but will attempt to send on the dgram_dst, which is unset. The other end will not receive the data.

[Qemu-devel] [PATCH] net: refactor net_socket_send()

2018-11-09 Thread Marc-André Lureau
Simplify net_socket_send(), avoid extra buf/buf1 variable, and backwards goto. Signed-off-by: Marc-André Lureau --- net/socket.c | 24 +--- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/net/socket.c b/net/socket.c index c92354049b..8a9c30892d 100644 ---

Re: [Qemu-devel] [RFC PATCH spice v3 1/3] QXL interface: add a function to identify monitors in the guest

2018-11-09 Thread Gerd Hoffmann
On Thu, Nov 08, 2018 at 11:05:10AM +0100, Lukáš Hrázký wrote: > Hello, > > On Thu, 2018-11-08 at 07:49 +0100, Gerd Hoffmann wrote: > > Hi, > > > > > + * The device_display_id_{start,count} denotes the sequence of device > > > display > > > + * IDs that map to the zero-based sequence of

Re: [Qemu-devel] [RFC PATCH spice v3 1/3] QXL interface: add a function to identify monitors in the guest

2018-11-09 Thread Frediano Ziglio
> On Thu, Nov 08, 2018 at 11:05:10AM +0100, Lukáš Hrázký wrote: > > Hello, > > > > On Thu, 2018-11-08 at 07:49 +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > + * The device_display_id_{start,count} denotes the sequence of device > > > > display > > > > + * IDs that map to the zero-based

Re: [Qemu-devel] xen_disk qdevification

2018-11-09 Thread Kevin Wolf
Am 09.11.2018 um 11:27 hat Paul Durrant geschrieben: > > -Original Message- > > From: Paul Durrant > > Sent: 08 November 2018 16:44 > > To: Paul Durrant ; 'Kevin Wolf' > > > > Cc: Stefano Stabellini ; qemu-bl...@nongnu.org; > > Tim Smith ; qemu-devel@nongnu.org; 'Markus > > Armbruster' ;

Re: [Qemu-devel] [RFC PATCH spice v3 1/3] QXL interface: add a function to identify monitors in the guest

2018-11-09 Thread Gerd Hoffmann
Hi, > first output/display: > spice_qxl_set_device_info(instance1, path1, 0, 1); > second: > spice_qxl_set_device_info(instance2, path1, 1, 1); > third: > spice_qxl_set_device_info(instance3, path1, 2, 1); That is a much better example IMHO. cheers, Gerd

Re: [Qemu-devel] [PULL] A Single RISC-V Patch for 3.1-rc1

2018-11-09 Thread Peter Maydell
On 8 November 2018 at 18:52, Palmer Dabbelt wrote: > On Thu, 08 Nov 2018 10:38:51 PST (-0800), alistai...@gmail.com wrote: >> >> On Thu, Nov 8, 2018 at 10:35 AM Palmer Dabbelt wrote: >>> >>> >>> The following changes since commit >>> a7ce790a029bd94eb320d8c69f38900f5233997e: >>> >>>

Re: [Qemu-devel] [PATCH] hw: set_netdev: remove useless code

2018-11-09 Thread Laurent Vivier
On 09/11/2018 11:00, Paolo Bonzini wrote: > On 09/11/2018 09:29, Laurent Vivier wrote: >> On 09/11/2018 09:26, Thomas Huth wrote: >>> On 2018-11-09 09:21, Laurent Vivier wrote: On 09/11/2018 09:13, Li Qiang wrote: > In set_netdev(), the peers[i] is initialized >

[Qemu-devel] [PATCH RFC 5/6] test-string-input-visitor: split off uint64 list tests

2018-11-09 Thread David Hildenbrand
Basically copy all int64 list tests but adapt them to work on uint64 instead. Signed-off-by: David Hildenbrand --- tests/test-string-input-visitor.c | 71 +-- 1 file changed, 67 insertions(+), 4 deletions(-) diff --git a/tests/test-string-input-visitor.c

[Qemu-devel] [PATCH RFC 6/6] test-string-input-visitor: add range overflow tests

2018-11-09 Thread David Hildenbrand
Let's make sure that the range handling code can properly deal with ranges that end at the biggest possible number. Signed-off-by: David Hildenbrand --- tests/test-string-input-visitor.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/test-string-input-visitor.c

[Qemu-devel] [PATCH RFC 0/6] qapi: rewrite string-input-visitor

2018-11-09 Thread David Hildenbrand
Rewrite string-input-visitor to be (hopefully) less ugly. Support int and uint lists (including ranges, but not implemented via type "Range"). Virtual walks are now supported and more errors are cought (and some bugs fixed). Fix and extend the tests. Parsing of uint64_t is now properly supported.

[Qemu-devel] [PATCH RFC 2/6] qapi: use qemu_strtod() in string-input-visitor

2018-11-09 Thread David Hildenbrand
Let's use the new function. Signed-off-by: David Hildenbrand --- qapi/string-input-visitor.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c index b3fdd0827d..dee708d384 100644 --- a/qapi/string-input-visitor.c

[Qemu-devel] [RFC v8 05/18] virtio-iommu: Add the iommu regions

2018-11-09 Thread Eric Auger
This patch initializes the iommu memory regions so that PCIe end point transactions get translated. The translation function is not yet implemented though. Signed-off-by: Eric Auger --- v6 -> v7: - use primary_bus - rebase on new translate proto featuring iommu_idx v5 -> v6: - include

[Qemu-devel] [RFC v8 07/18] virtio-iommu: Implement attach/detach command

2018-11-09 Thread Eric Auger
This patch implements the endpoint attach/detach to/from a domain. Signed-off-by: Eric Auger --- --- hw/virtio/virtio-iommu.c | 40 ++-- 1 file changed, 34 insertions(+), 6 deletions(-) diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c index

Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes

2018-11-09 Thread Aleksandar Markovic
> From: Fredrik Noring > Subject: Re: [PATCH v2 4/6] target/mips: Fix decoding mechanism of special > R5900 opcodes > > Hi Aleksandar, > > > Fredrik, do you know by any chance if a document exists that would justify > > inclusion of non-R5900 DMULT, DMULTU, DDIV, DDIVU in R5900 executables by

Re: [Qemu-devel] [RFC/PoC PATCH 1/3] i386: set initrd_max to 4G - 1 to allow up to 4G initrd

2018-11-09 Thread Juergen Gross
On 09/11/2018 10:57, Li Zhijian wrote: > On 11/9/2018 3:20 PM, Ingo Molnar wrote: >> * Li Zhijian wrote: >> If the kernel initrd creation process creates an initrd which is larger than 2GB and also claims that it can't be placed with any part of it above 2GB, then that sounds like

Re: [Qemu-devel] QEMU and Kconfig

2018-11-09 Thread Paolo Bonzini
On 08/11/2018 22:00, Eduardo Habkost wrote: > Understood. My interpretation of "target" was just "a QEMU > binary". In other words, I thought we were talking about > anything that could be compiled in/out from a specific QEMU > binary. The idea is "target" as opposed to "host". > Do you have a

Re: [Qemu-devel] xen_disk qdevification

2018-11-09 Thread Paul Durrant
> -Original Message- > From: Paul Durrant > Sent: 08 November 2018 16:44 > To: Paul Durrant ; 'Kevin Wolf' > > Cc: Stefano Stabellini ; qemu-bl...@nongnu.org; > Tim Smith ; qemu-devel@nongnu.org; 'Markus > Armbruster' ; Anthony Perard > ; xen-de...@lists.xenproject.org; Max Reitz > >

[Qemu-devel] [PATCH RFC 4/6] test-string-input-visitor: use virtual walk

2018-11-09 Thread David Hildenbrand
We now support virtual walks, so use that instead. Signed-off-by: David Hildenbrand --- tests/test-string-input-visitor.c | 36 +++ 1 file changed, 12 insertions(+), 24 deletions(-) diff --git a/tests/test-string-input-visitor.c b/tests/test-string-input-visitor.c

[Qemu-devel] [PATCH RFC 1/6] cutils: add qemu_strtod()

2018-11-09 Thread David Hildenbrand
Let's provide a wrapper for strtod(). Signed-off-by: David Hildenbrand --- include/qemu/cutils.h | 1 + util/cutils.c | 22 ++ 2 files changed, 23 insertions(+) diff --git a/include/qemu/cutils.h b/include/qemu/cutils.h index 7071bfe2d4..84fb9e53c6 100644 ---

Re: [Qemu-devel] List of files containing devices which have not been QOMified

2018-11-09 Thread Gerd Hoffmann
Hi, > I am also suspicious about hw/bt/ but don't know enough > about that subsystem to say if it could benefit from > using QOM objects more. I'm wondering whenever anyone would even notice if we just rm -rf hw/bt Looking through the changelog for the last five years (after hw/ split) the

[Qemu-devel] [RFC v8 08/18] virtio-iommu: Implement map/unmap

2018-11-09 Thread Eric Auger
This patch implements virtio_iommu_map/unmap. Signed-off-by: Eric Auger --- v5 -> v6: - use new v0.6 fields - replace error_report by qemu_log_mask v3 -> v4: - implement unmap semantics as specified in v0.4 --- hw/virtio/trace-events | 3 ++ hw/virtio/virtio-iommu.c | 94

[Qemu-devel] [RFC v8 00/18] VIRTIO-IOMMU device

2018-11-09 Thread Eric Auger
This series rebases the virtio-iommu device on qemu 3.1.0-rc0 and implements the v0.8 virtio-iommu spec [1]. Most importantly the pci proxy for the virtio-iommu device is now available and gets instantiated by the ARM virt machine when the ",iommu=virtio" virt machine option is added. The

[Qemu-devel] [RFC v8 02/18] linux-headers: Partial update for virtio-iommu v0.8

2018-11-09 Thread Eric Auger
Partial sync against Jean-Philippe's branch: git://linux-arm.org/linux-jpb.git virtio-iommu/v0.8 Signed-off-by: Eric Auger --- include/standard-headers/linux/virtio_ids.h | 1 + include/standard-headers/linux/virtio_iommu.h | 159 ++ linux-headers/linux/virtio_iommu.h

[Qemu-devel] [RFC v8 03/18] virtio-iommu: Add skeleton

2018-11-09 Thread Eric Auger
This patchs adds the skeleton for the virtio-iommu device. Signed-off-by: Eric Auger --- v7 -> v8: - expose VIRTIO_IOMMU_F_BYPASS and VIRTIO_F_VERSION_1 features - set_config dummy implementation + tracing - add trace in get_features - set the features on realize() and store the acked ones -

[Qemu-devel] [RFC v8 11/18] virtio-iommu: Add an msi_bypass property

2018-11-09 Thread Eric Auger
In case the msi_bypass property is set, it means we need to register the IOAPIC MSI window as a reserved region: 0xFEE0 - 0xFEEF. Signed-off-by: Eric Auger --- --- hw/virtio/virtio-iommu.c | 52 include/hw/virtio/virtio-iommu.h | 1 + 2 files

[Qemu-devel] [RFC v8 15/18] hw/arm/virt: Add virtio-iommu to the virt board

2018-11-09 Thread Eric Auger
Both the virtio-iommu device and its dedicated mmio transport get instantiated when requested. Signed-off-by: Eric Auger --- v6 -> v7: - align to the smmu instantiation code v4 -> v5: - VirtMachineClass no_iommu added in this patch - Use object_resolve_path_type --- hw/arm/virt.c | 48

Re: [Qemu-devel] [PATCH 0/2] linux-user/mips: Support the n32 ABI for the R5900

2018-11-09 Thread Laurent Vivier
On 08/11/2018 19:42, Fredrik Noring wrote: > Recognise the R5900, which reports itself as MIPS III, as a 64-bit CPU > supporting the n32 ABI. Test that DMULT is emulated in user mode. if you have time, o32 & n32 support needs to be reworked. We have two binaries qemu-mips and qemu-mipsn32

[Qemu-devel] [PATCH RFC 3/6] qapi: rewrite string-input-visitor

2018-11-09 Thread David Hildenbrand
The input visitor has some problems right now, especially - unsigned type "Range" is used to process signed ranges, resulting in inconsistent behavior and ugly/magical code - uint64_t are parsed like int64_t, so big uint64_t values are not supported and error messages are misleading -

Re: [Qemu-devel] List of files containing devices which have not been QOMified

2018-11-09 Thread Gerd Hoffmann
On Fri, Nov 09, 2018 at 12:17:31PM +0100, Gerd Hoffmann wrote: > Hi, > > > I am also suspicious about hw/bt/ but don't know enough > > about that subsystem to say if it could benefit from > > using QOM objects more. > > I'm wondering whenever anyone would even notice if we just rm -rf hw/bt >

[Qemu-devel] [RFC v8 06/18] virtio-iommu: Endpoint and domains structs and helpers

2018-11-09 Thread Eric Auger
This patch introduce domain and endpoint internal datatypes. Both are stored in RB trees. The domain owns a list of endpoints attached to it. Helpers to get/put end points and domains are introduced. get() helpers will become static in subsequent patches. Signed-off-by: Eric Auger --- v6 ->

Re: [Qemu-devel] [PATCH v5 13/24] hw: acpi: Do not create hotplug method when handler is not defined

2018-11-09 Thread Igor Mammedov
On Mon, 5 Nov 2018 02:40:36 +0100 Samuel Ortiz wrote: > CPU and memory ACPI hotplug are not necessarily handled through SCI > events. For example, with Hardware-reduced ACPI, the GED device will > manage ACPI hotplug entirely. > As a consequence, we make the CPU and memory specific events AML >

Re: [Qemu-devel] [PATCH] hw: set_netdev: remove useless code

2018-11-09 Thread Laurent Vivier
On 09/11/2018 09:13, Li Qiang wrote: > In set_netdev(), the peers[i] is initialized > qemu_find_net_clients_except() when i is in > 0 between 'queues' it can't be NULL. > > Signed-off-by: Li Qiang > --- > hw/core/qdev-properties-system.c | 4 > 1 file changed, 4 deletions(-) > > diff

Re: [Qemu-devel] [PATCH 1/1 V2] Add vhost-pci-blk driver

2018-11-09 Thread Kevin Wolf
Am 09.11.2018 um 02:48 hat Dongli Zhang geschrieben: > > > On 11/09/2018 12:47 AM, Michael S. Tsirkin wrote: > > On Thu, Nov 08, 2018 at 10:09:00PM +0800, Dongli Zhang wrote: > >> It looks the kernel space vhost-blk can only process raw image. > >> > >> How about to verify that only raw image is

Re: [Qemu-devel] [PATCH] hw: set_netdev: remove useless code

2018-11-09 Thread Paolo Bonzini
On 09/11/2018 09:29, Laurent Vivier wrote: > On 09/11/2018 09:26, Thomas Huth wrote: >> On 2018-11-09 09:21, Laurent Vivier wrote: >>> On 09/11/2018 09:13, Li Qiang wrote: In set_netdev(), the peers[i] is initialized qemu_find_net_clients_except() when i is in 0 between 'queues' it

Re: [Qemu-devel] List of files containing devices which have not been QOMified

2018-11-09 Thread Mark Cave-Ayland
On 06/11/2018 18:43, Peter Maydell wrote: > I had an idea for how to get a rough list of source files > containing devices that haven't been QOMified. The theory > is that a pre-QOM device generally has an "init" function > which allocates memory for the device struct. So looking in > hw/ for

Re: [Qemu-devel] List of files containing devices which have not been QOMified

2018-11-09 Thread Peter Maydell
On 9 November 2018 at 10:17, Mark Cave-Ayland wrote: > On 06/11/2018 18:43, Peter Maydell wrote: > >> I had an idea for how to get a rough list of source files >> containing devices that haven't been QOMified. The theory >> is that a pre-QOM device generally has an "init" function >> which

Re: [Qemu-devel] [PATCH 1/2] linux-user/mips: Support the n32 ABI for the R5900

2018-11-09 Thread Laurent Vivier
On 08/11/2018 19:43, Fredrik Noring wrote: > Recognise the R5900, which reports itself as MIPS III, as a 64-bit CPU > supporting the n32 ABI. > > Signed-off-by: Fredrik Noring > --- > linux-user/mips64/target_elf.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

[Qemu-devel] [RFC v8 01/18] update-linux-headers: Import virtio_iommu.h

2018-11-09 Thread Eric Auger
Update the script to update the virtio_iommu.h header. Signed-off-by: Eric Auger --- scripts/update-linux-headers.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index 0a964fe240..55fd271a32 100755 ---

[Qemu-devel] [RFC v8 10/18] virtio-iommu: Implement probe request

2018-11-09 Thread Eric Auger
This patch implements the PROBE request. At the moment, no reserved regions are returned as none are registered per device. Only a NONE property is returned. Signed-off-by: Eric Auger --- v7 -> v8: - adapt to removal of value filed in virtio_iommu_probe_property v6 -> v7: - adapt to the change

[Qemu-devel] deprecating/removing bluetooth (was: Re: List of files containing devices which have not been QOMified)

2018-11-09 Thread Gerd Hoffmann
On Fri, Nov 09, 2018 at 02:16:53PM +0100, Paolo Bonzini wrote: > On 09/11/2018 13:39, Thomas Huth wrote: > > On 2018-11-09 12:29, Gerd Hoffmann wrote: > >> > >> Tried this after studying docs: > >> > >> qemu -usb -device usb-bt-dongle -bt hci,vlan=0 -bt device:keyboard > >> > >> Segfaults right

Re: [Qemu-devel] [RFC v4 50/71] s390x: convert to cpu_interrupt_request

2018-11-09 Thread Cornelia Huck
On Thu, 25 Oct 2018 10:46:23 -0400 "Emilio G. Cota" wrote: > Cc: Cornelia Huck > Cc: Christian Borntraeger > Cc: Alexander Graf > Cc: David Hildenbrand > Cc: qemu-s3...@nongnu.org > Reviewed-by: Richard Henderson > Signed-off-by: Emilio G. Cota > --- > hw/intc/s390_flic.c | 2 +- >

Re: [Qemu-devel] [PATCH v4 00/16] gdbstub: support for the multiprocess extension

2018-11-09 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181106110548.4209-1-luc.mic...@greensocs.com Subject: [Qemu-devel] [PATCH v4 00/16] gdbstub: support for the multiprocess extension === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

2018-11-09 Thread Gerd Hoffmann
Broken (segfaultson first keypress) and appearently unused. Signed-off-by: Gerd Hoffmann --- include/hw/bt.h | 3 - hw/bt/hid.c | 554 vl.c| 34 +--- hw/bt/Makefile.objs | 3 +- qemu-options.hx | 9 - 5

[Qemu-devel] [PATCH v2] pulseaudio: process audio data in smaller chunks

2018-11-09 Thread Gerd Hoffmann
The rate of pulseaudio absorbing the audio stream is used to control the the rate of the guests audio stream. When the emulated hardware uses small chunks (like intel-hda does) we need small chunks on the audio backend side too, otherwise that feedback loop doesn't work very well. Cc: Max

Re: [Qemu-devel] [PATCH v5 02/24] hw: acpi: Export ACPI build alignment API

2018-11-09 Thread Igor Mammedov
On Mon, 5 Nov 2018 02:40:25 +0100 Samuel Ortiz wrote: > This is going to be needed by the Hardware-reduced ACPI routines. > > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Philippe Mathieu-Daudé > Signed-off-by: Samuel Ortiz the patch is probably misplaced withing series, if there is an

Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes

2018-11-09 Thread Fredrik Noring
Hi Aleksandar, > Tx79 mentions the opposite: that DDIV, DDIVU, DMULT, DMULTU are not > included in R5900 set. > > I think that the best solution that you exclude DDIV, DDIVU, DMULT, DMULTU > in a separate patch - there is no document to support their inclusion. As Maciej noted, the 64-bit MIPS

Re: [Qemu-devel] [PATCH] qga-win: fix leaks of build_guest_disk_info()

2018-11-09 Thread Michael Roth
Quoting Marc-André Lureau (2018-11-03 08:01:43) > Introduced in commit b1ba8890e63ce9432c41c5c3fc229f54c87c9c99, vol_h > handle should be closed, and "out" cleanup should be done after > DeviceIoControl() fails. > > Signed-off-by: Marc-André Lureau Thanks, applied to qga tree:

Re: [Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

2018-11-09 Thread Liam Merwick
On 09/11/2018 14:14, Gerd Hoffmann wrote: Broken (segfaultson first keypress) and appearently unused. s/segfaultson/segfaults on/ s/appearently/apparently/ Signed-off-by: Gerd Hoffmann one question at the end, otherwise Reviewed-by: Liam Merwick --- include/hw/bt.h | 3 -

[Qemu-devel] [PATCH 3/4] Travis CI: make specified Python versions usable on jobs

2018-11-09 Thread Cleber Rosa
For the two Python jobs, which seem to have the goal of making sure QEMU builds successfully on the 3.0-3.6 spectrum of Python 3 versions, the specified version is only applicable if a Python virtual environment is used. To do that, it's necessary to define the (primary?) language of the job to

[Qemu-devel] [PATCH v3 2/7] target/arm64: hold BQL when calling do_interrupt()

2018-11-09 Thread Alex Bennée
Fix the assertion failure when running interrupts. Signed-off-by: Alex Bennée Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/kvm64.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index 6351a54b28..c39150e5e1 100644 ---

[Qemu-devel] [PATCH v3 4/7] tests/guest-debug: fix scoping of failcount

2018-11-09 Thread Alex Bennée
You should declare you are using a global version of a variable before you attempt to modify it in a function. Signed-off-by: Alex Bennée Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson --- tests/guest-debug/test-gdbstub.py | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PATCH v3 1/7] target/arm64: properly handle DBGVR RESS bits

2018-11-09 Thread Alex Bennée
This only fails with some (broken) versions of gdb but we should treat the top bits of DBGBVR as RESS. Properly sign extend QEMU's reference copy of dbgbvr and also update the register descriptions in the comment. Signed-off-by: Alex Bennée --- v2 - sanitise register on insertion - update

[Qemu-devel] [PATCH v3 0/7] KVM Guest Debug fixes (plus TCG EL2 debug tweaks)

2018-11-09 Thread Alex Bennée
Hi, I missed a fix I'd applied locally from v2 so this is a resend with some additional tags, some changes suggested by rth and one more fix for the test case. So these are fixes for guest debug when running under KVM. While re-spinning these I came across an anomaly which pointed to a kernel

[Qemu-devel] [PATCH v3 3/7] target/arm64: kvm debug set target_el when passing exception to guest

2018-11-09 Thread Alex Bennée
When we are debugging the guest all exceptions come our way but might be for the guest's own debug exceptions. We use the ->do_interrupt() infrastructure to inject the exception into the guest. However, we are missing a full setup of the exception structure, causing an assert later down the line.

[Qemu-devel] [PATCH v3 7/7] arm: fix aa64_generate_debug_exceptions to work with EL2

2018-11-09 Thread Alex Bennée
The test was incomplete and incorrectly caused debug exceptions to be generated when returning to EL2 after a failed attempt to single-step an EL1 instruction. Fix this while cleaning up the function a little. Signed-off-by: Alex Bennée --- v3 - further re-arrangement as suggested by rth ---

[Qemu-devel] [PATCH v3 6/7] arm: use symbolic MDCR_TDE in arm_debug_target_el

2018-11-09 Thread Alex Bennée
We already have this symbol defined so lets use it. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index b5eff79f73..1efff21a18 100644 --- a/target/arm/cpu.h

[Qemu-devel] [PATCH v3 5/7] tests/guest-debug: don't use symbol resolution for PC checks

2018-11-09 Thread Alex Bennée
It turns out symbol resolution isn't enough as modern kernels are often padded with check code at the start of functions. GDB seems to put the breakpoint at the first non-check instruction which causes comparisons with the symbol resolution to fail. For normal breakpoints we can detect the hit

[Qemu-devel] [PATCH v7] lsi: Reselection needed to remove pending commands from queue

2018-11-09 Thread George Kennedy
Under heavy IO (e.g. fio) the queue is not checked frequently enough for pending commands. As a result some pending commands are timed out by the linux sym53c8xx driver, which sends SCSI Abort messages for the timed out commands. The SCSI Abort messages result in linux errors, which show up on the

[Qemu-devel] [RFC PATCH 1/2] tests/test-qht-par: test gets stuck intermittently on OSX

2018-11-09 Thread Cleber Rosa
To be fully honest, this may not be a OSX (alone) condition, but may be a situation that only happens with OSX on Travis-CI, were resources are quite limited. I have personal experience with tests that exercise parallelism or depend on timing to fail on Travis. Because I'm not 100% certain that

[Qemu-devel] [RFC PATCH 0/2] Address OS X Travis failures

2018-11-09 Thread Cleber Rosa
The OS X jobs on Travis fail for a number of reasons. This is an attempt to decide its faith, either as something that will be kept on the configuration (and properly maintained), removed, or maybe active but with failures waived (Travis allows for that). The result of this can be seen in these

Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes

2018-11-09 Thread Aleksandar Markovic
> From: Fredrik Noring > Subject: Re: [PATCH v2 4/6] target/mips: Fix decoding mechanism of special > R5900 opcodes > > Hi Aleksandar, > > > Tx79 mentions the opposite: that DDIV, DDIVU, DMULT, DMULTU are not > > included in R5900 set. > > > > I think that the best solution that you exclude

[Qemu-devel] [RFC PATCH 2/2] Travis CI: break down OSX+clang jobs

2018-11-09 Thread Cleber Rosa
The OSX jobs were timing out on Travis, due to the long time they need to run tests with all targets. Let's break them down to avoid hitting the time limit, and at the same time, give faster results. Additionally the qtest based tests were hanging intermittently. The first debugging attempt

Re: [Qemu-devel] [RFC PATCH 1/2] tests/test-qht-par: test gets stuck intermittently on OSX

2018-11-09 Thread Peter Maydell
On 9 November 2018 at 15:30, Cleber Rosa wrote: > To be fully honest, this may not be a OSX (alone) condition, but may > be a situation that only happens with OSX on Travis-CI, were resources > are quite limited. > > I have personal experience with tests that exercise parallelism or > depend on

Re: [Qemu-devel] [PATCH v3 0/7] KVM Guest Debug fixes (plus TCG EL2 debug tweaks)

2018-11-09 Thread Alex Bennée
Alex Bennée writes: > Hi, > > I missed a fix I'd applied locally from v2 so this is a resend with > some additional tags, some changes suggested by rth and one more fix > for the test case. > > So these are fixes for guest debug when running under KVM. While > re-spinning these I came across

Re: [Qemu-devel] [PATCH] hw: set_netdev: remove useless code

2018-11-09 Thread Thomas Huth
On 2018-11-09 09:21, Laurent Vivier wrote: > On 09/11/2018 09:13, Li Qiang wrote: >> In set_netdev(), the peers[i] is initialized >> qemu_find_net_clients_except() when i is in >> 0 between 'queues' it can't be NULL. >> >> Signed-off-by: Li Qiang >> --- >> hw/core/qdev-properties-system.c | 4

Re: [Qemu-devel] [PATCH] hw: set_netdev: remove useless code

2018-11-09 Thread Laurent Vivier
On 09/11/2018 09:26, Thomas Huth wrote: > On 2018-11-09 09:21, Laurent Vivier wrote: >> On 09/11/2018 09:13, Li Qiang wrote: >>> In set_netdev(), the peers[i] is initialized >>> qemu_find_net_clients_except() when i is in >>> 0 between 'queues' it can't be NULL. >>> >>> Signed-off-by: Li Qiang

Re: [Qemu-devel] [PATCH v4 00/16] gdbstub: support for the multiprocess extension

2018-11-09 Thread Luc Michel
On 11/8/18 5:09 PM, Philippe Mathieu-Daudé wrote: > On 6/11/18 12:05, Luc Michel wrote: >> changes since v3: >>    - patch 1    cpu_cluster.h: remove QEMU_ from the multiple includes >>     guard #ifdef/#define [Alistair] >> >>    - patch 1    cpu_cluster.c: include osdep.h first

[Qemu-devel] [PATCH 0/2] virtio-9p: qmp interface for set/query io throttle for fsdev devices

2018-11-09 Thread xiezhide
These patches provide the qmp interface, to set/query the io throttle status of the all fsdev devices that are present in a vm. Some of the patches also remove the duplicate code that was present in block and fsdev files. Zhide Xie (2): fsdev-qmp: qmp interface for set/query io throttle for

[Qemu-devel] [Bug 1802465] [NEW] typing string via VNC is unreliable

2018-11-09 Thread Zhaocong
Public bug reported: QEMU version is 3.0.0 # Description The problem is that, when typing string through VNC, it can be unreliable -- sometimes some key strokes get skipped, sometimes get swapped, sometimes get repeated. There's no problem when typing through VNC on physical hardware. # Steps

[Qemu-devel] [PATCH] hw: set_netdev: remove useless code

2018-11-09 Thread Li Qiang
In set_netdev(), the peers[i] is initialized qemu_find_net_clients_except() when i is in 0 between 'queues' it can't be NULL. Signed-off-by: Li Qiang --- hw/core/qdev-properties-system.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/core/qdev-properties-system.c

Re: [Qemu-devel] [PATCH] hw: set_netdev: remove useless code

2018-11-09 Thread Laurent Vivier
On 09/11/2018 09:13, Li Qiang wrote: > In set_netdev(), the peers[i] is initialized > qemu_find_net_clients_except() when i is in > 0 between 'queues' it can't be NULL. > > Signed-off-by: Li Qiang > --- > hw/core/qdev-properties-system.c | 4 > 1 file changed, 4 deletions(-) > > diff

Re: [Qemu-devel] [PATCH] hw: set_netdev: remove useless code

2018-11-09 Thread Thomas Huth
On 2018-11-09 09:13, Li Qiang wrote: > In set_netdev(), the peers[i] is initialized > qemu_find_net_clients_except() when i is in > 0 between 'queues' it can't be NULL. > > Signed-off-by: Li Qiang > --- > hw/core/qdev-properties-system.c | 4 > 1 file changed, 4 deletions(-) > > diff

[Qemu-devel] [RFC v8 09/18] virtio-iommu: Implement translate

2018-11-09 Thread Eric Auger
This patch implements the translate callback Signed-off-by: Eric Auger --- v6 -> v7: - implemented bypass-mode v5 -> v6: - replace error_report by qemu_log_mask v4 -> v5: - check the device domain is not NULL - s/printf/error_report - set flags to IOMMU_NONE in case of all translation faults

[Qemu-devel] [RFC v8 18/18] hw/arm/virt: Allow virtio-iommu instantiation

2018-11-09 Thread Eric Auger
The virtio-iommu now can be instantiated by adding the virt machine option "-M virt,iommu=virtio" Signed-off-by: Eric Auger --- hw/arm/virt.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index f2994c4359..d2080a1ba9 100644 ---

[Qemu-devel] [RFC v8 16/18] hw/arm/virt-acpi-build: Introduce fill_iort_idmap helper

2018-11-09 Thread Eric Auger
To avoid code duplication, let's introduce an helper that fills one IORT ID mappings array index. Signed-off-by: Eric Auger --- v8: new --- hw/arm/virt-acpi-build.c | 43 1 file changed, 26 insertions(+), 17 deletions(-) diff --git

Re: [Qemu-devel] List of files containing devices which have not been QOMified

2018-11-09 Thread Peter Maydell
On 9 November 2018 at 12:39, Thomas Huth wrote: > On 2018-11-09 12:29, Gerd Hoffmann wrote: >> On Fri, Nov 09, 2018 at 12:17:31PM +0100, Gerd Hoffmann wrote: >>> Hi, >>> I am also suspicious about hw/bt/ but don't know enough about that subsystem to say if it could benefit from

Re: [Qemu-devel] [PATCH 0/2] ipmi: Allow UUID to be set for a BMC

2018-11-09 Thread Corey Minyard
On 11/8/18 5:22 PM, David Gibson wrote: On Thu, Nov 08, 2018 at 08:19:42AM -0600, miny...@acm.org wrote: The code was using the qemu UUID for the BMC. But that's really not a good method. In general, you don't want the GUID to change when you migrate, and you want the GUID to be the same

Re: [Qemu-devel] [RFC v4 24/71] s390x: convert to cpu_halted

2018-11-09 Thread Cornelia Huck
On Wed, 31 Oct 2018 16:56:54 + Alex Bennée wrote: > Emilio G. Cota writes: > > > On Wed, Oct 31, 2018 at 16:13:05 +, Alex Bennée wrote: > >> > @@ -353,10 +355,12 @@ void s390_cpu_unhalt(S390CPU *cpu) > >> > CPUState *cs = CPU(cpu); > >> > trace_cpu_unhalt(cs->cpu_index); >

Re: [Qemu-devel] [RFC/PoC PATCH 1/3] i386: set initrd_max to 4G - 1 to allow up to 4G initrd

2018-11-09 Thread Ingo Molnar
* Li Zhijian wrote: > > If the kernel initrd creation process creates an initrd which > > is larger than 2GB and also claims that it can't be placed > > with any part of it above 2GB, then that sounds like a bug > > in the initrd creation process... > > Exactly, it's a real problem. > > Add

Re: [Qemu-devel] [RFC/PoC PATCH 1/3] i386: set initrd_max to 4G - 1 to allow up to 4G initrd

2018-11-09 Thread Li Zhijian
On 11/9/2018 3:20 PM, Ingo Molnar wrote: * Li Zhijian wrote: If the kernel initrd creation process creates an initrd which is larger than 2GB and also claims that it can't be placed with any part of it above 2GB, then that sounds like a bug in the initrd creation process... Exactly, it's a

  1   2   >