[Qemu-devel] [PATCH v5 09/16] gdbstub: add multiprocess support to gdb_vm_state_change()

2018-11-10 Thread Luc Michel
Add support for multiprocess extension in gdb_vm_state_change() function. Signed-off-by: Luc Michel Reviewed-by: Philippe Mathieu-Daudé --- gdbstub.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index aae3cce01a..decf56c610 100644

[Qemu-devel] [PATCH v5 11/16] gdbstub: add support for extended mode packet

2018-11-10 Thread Luc Michel
Add support for the '!' extended mode packet. This is required for the multiprocess extension. Signed-off-by: Luc Michel --- gdbstub.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index bd4895ac0a..4132227092 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1294,10

[Qemu-devel] [PATCH v5 10/16] gdbstub: add multiprocess support to 'D' packets

2018-11-10 Thread Luc Michel
'D' packets are used by GDB to detach from a process. In multiprocess mode, the PID to detach from is sent in the request. Signed-off-by: Luc Michel Reviewed-by: Philippe Mathieu-Daudé --- gdbstub.c | 60 --- 1 file changed, 53 insertions(+),

[Qemu-devel] [PATCH v5 15/16] gdbstub: add multiprocess extension support

2018-11-10 Thread Luc Michel
Add multiprocess extension support by enabling multiprocess mode when the peer requests it, and by replying that we actually support it in the qSupported reply packet. Signed-off-by: Luc Michel Reviewed-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis --- gdbstub.c | 6 ++ 1 file

[Qemu-devel] [PATCH v5 07/16] gdbstub: add multiprocess support to (f|s)ThreadInfo and ThreadExtraInfo

2018-11-10 Thread Luc Michel
Change the thread info related packets handling to support multiprocess extension. Add the CPUs class name in the extra info to help differentiate them in multiprocess mode. Signed-off-by: Luc Michel Reviewed-by: Philippe Mathieu-Daudé --- gdbstub.c | 35 +-- 1

[Qemu-devel] [PATCH v5 05/16] gdbstub: add multiprocess support to vCont packets

2018-11-10 Thread Luc Michel
Add the gdb_first_cpu() and gdb_next_cpu() to iterate over all the CPUs in currently attached processes. Add the gdb_first_cpu_in_process() and gdb_next_cpu_in_process() to iterate over CPUs of a given process. Use them to add multiprocess extension support to vCont packets. Signed-off-by: Luc

[Qemu-devel] [PATCH v5 14/16] gdbstub: gdb_set_stop_cpu: ignore request when process is not attached

2018-11-10 Thread Luc Michel
When gdb_set_stop_cpu() is called with a CPU associated to a process currently not attached by the GDB client, return without modifying the stop CPU. Otherwise, GDB gets confused if it receives packets with a thread-id it does not know about. Signed-off-by: Luc Michel Acked-by: Alistair Francis

Re: [Qemu-devel] [PATCH for 3.1] RISC-V: Respect fences for user-only emulators

2018-11-10 Thread Richard Henderson
On 11/9/18 8:19 PM, Palmer Dabbelt wrote: > Our current fence implementation ignores fences for the user-only > configurations. This is incorrect but unlikely to manifest: it requires > multi-threaded user-only code that takes advantage of the weakness in > the host's memory model and can be

[Qemu-devel] [PATCH v5 01/16] hw/cpu: introduce CPU clusters

2018-11-10 Thread Luc Michel
This commit adds the cpu-cluster type. It aims at gathering CPUs from the same cluster in a machine. For now it only has a `cluster-id` property. Signed-off-by: Luc Michel Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé ---

[Qemu-devel] [PATCH v5 04/16] gdbstub: add multiprocess support to 'H' and 'T' packets

2018-11-10 Thread Luc Michel
Add a couple of helper functions to cope with GDB threads and processes. The gdb_get_process() function looks for a process given a pid. The gdb_get_cpu() function returns the CPU corresponding to the (pid, tid) pair given as parameters. The read_thread_id() function parses the thread-id sent

[Qemu-devel] [PATCH v5 13/16] gdbstub: processes initialization on new peer connection

2018-11-10 Thread Luc Michel
When a new connection is established, we set the first process to be attached, and the others detached. The first CPU of the first process is selected as the current CPU. Signed-off-by: Luc Michel Reviewed-by: Alistair Francis --- gdbstub.c | 20 +++- 1 file changed, 15

[Qemu-devel] [PATCH v5 02/16] gdbstub: introduce GDB processes

2018-11-10 Thread Luc Michel
Add a structure GDBProcess that represent processes from the GDB semantic point of view. CPUs can be split into different processes, by grouping them under different cpu-cluster objects. Each occurrence of a cpu-cluster object implies the existence of the corresponding process in the GDB stub.

[Qemu-devel] [PATCH v5 06/16] gdbstub: add multiprocess support to 'sC' packets

2018-11-10 Thread Luc Michel
Change the sC packet handling to support the multiprocess extension. Instead of returning the first thread, we return the first thread of the current process. Signed-off-by: Luc Michel Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- gdbstub.c | 11 --- 1 file

[Qemu-devel] [PATCH v5 00/16] gdbstub: support for the multiprocess extension

2018-11-10 Thread Luc Michel
changes since v4: - patch 1add cpu_cluster.[ch] files into MAINTAINERS Machine core section (thanks Eduardo!) [Philippe, Eduardo] - patch 1revert to uint32_t for cluster IDs [Philippe] - patch 1fixed a coding style issue [patchew] changes since v3: - patch 1

[Qemu-devel] [PATCH v5 12/16] gdbstub: add support for vAttach packets

2018-11-10 Thread Luc Michel
Add support for the vAttach packets. In multiprocess mode, GDB sends them to attach to additional processes. Signed-off-by: Luc Michel --- gdbstub.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 4132227092..ba365808db 100644

[Qemu-devel] [PATCH v5 03/16] gdbstub: add multiprocess support to '?' packets

2018-11-10 Thread Luc Michel
The gdb_get_cpu_pid() function does the PID lookup for the given CPU. It checks if the CPU is a direct child of a CPU cluster. If it is, the returned PID is the cluster ID plus one (cluster IDs start at 0, GDB PIDs at 1). When the CPU is not a child of such a container, the PID of the first

[Qemu-devel] [PATCH v5 16/16] arm/xlnx-zynqmp: put APUs and RPUs in separate CPU clusters

2018-11-10 Thread Luc Michel
Create two separate CPU clusters for APUs and RPUs. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-zynqmp.h | 3 +++ hw/arm/xlnx-zynqmp.c | 21 + 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/include/hw/arm/xlnx-zynqmp.h

[Qemu-devel] [PATCH v5 08/16] gdbstub: add multiprocess support to Xfer:features:read:

2018-11-10 Thread Luc Michel
Change the Xfer:features:read: packet handling to support the multiprocess extension. This packet is used to request the XML description of the CPU. In multiprocess mode, different descriptions can be sent for different processes. This function now takes the process to send the description for as

[Qemu-devel] [PATCH for-3.1] target/arm: Fix typo in tlbi_aa64_vmalle1_write

2018-11-10 Thread Richard Henderson
This would cause an infinite recursion or loop. Signed-off-by: Richard Henderson --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 96301930cc..a327988c66 100644 --- a/target/arm/helper.c +++

[Qemu-devel] [PATCH for-3.2 11/13] slirp: replace the poor-man string split with g_strsplit()

2018-11-10 Thread Marc-André Lureau
Use the glib function for the work, fix a potential crash on >256 words. Signed-off-by: Marc-André Lureau --- slirp/misc.c | 21 +++-- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/slirp/misc.c b/slirp/misc.c index d9804f2a6d..dedc9bf6c3 100644 ---

Re: [Qemu-devel] [PATCH for-3.2 02/13] slirp: remove do_pty from fork_exec()

2018-11-10 Thread Samuel Thibault
Marc-André Lureau, le sam. 10 nov. 2018 17:45:37 +0400, a ecrit: > QEMU uses fork_exec() with do_pty values 0 or 3. > Let's clean up some unused code. Applied to my tree, thanks! > Signed-off-by: Marc-André Lureau > --- > slirp/misc.h | 2 +- > slirp/misc.c | 55

[Qemu-devel] [PULL 2/4] slirp: Use g_new() to allocate sockets in socreate()

2018-11-10 Thread Samuel Thibault
From: Peter Maydell The slirp socreate() function can only fail if the attempt to malloc() the struct socket fails. Switch to using g_new() instead, which will allow us to remove the error-handling code from its callers. Signed-off-by: Peter Maydell Signed-off-by: Samuel Thibault ---

Re: [Qemu-devel] [PATCH for-3.2 07/13] slirp: move internal function declarations

2018-11-10 Thread Samuel Thibault
Marc-André Lureau, le sam. 10 nov. 2018 17:45:42 +0400, a ecrit: > Clarify that those functions are internal to slirp. Applied to my tree, thanks! Samuel

Re: [Qemu-devel] [PATCH for-3.2 10/13] slirp: improve subprocess socket creation

2018-11-10 Thread Samuel Thibault
Marc-André Lureau, le sam. 10 nov. 2018 17:45:45 +0400, a ecrit: > @@ -163,23 +183,14 @@ fork_exec(struct socket *so, const char *ex) > exit(1); > >default: > - qemu_add_child_watch(pid); > -/* > - * XXX this could block us... > -

Re: [Qemu-devel] [PATCH for-3.2 13/13] slirp: simplify fork_exec()

2018-11-10 Thread Samuel Thibault
Marc-André Lureau, le sam. 10 nov. 2018 17:45:48 +0400, a ecrit: > Use g_spawn_async_with_fds() to setup the child. > > GSpawn handles reaping the child, and closing parent file descriptors. Similarly :) Samuel

[Qemu-devel] [PULL 0/4] slirp updates

2018-11-10 Thread Samuel Thibault
The following changes since commit 160e5c22e55b3f775c2003dfc626fa872ee4a7a1: Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging (2018-11-09 10:54:10 +) are available in the Git repository at: https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault

Re: [Qemu-devel] [PATCH for-3.2 10/13] slirp: improve subprocess socket creation

2018-11-10 Thread Samuel Thibault
Peter Maydell, le sam. 10 nov. 2018 14:04:10 +, a ecrit: > On 10 November 2018 at 13:53, Samuel Thibault wrote: > > Marc-André Lureau, le sam. 10 nov. 2018 17:45:45 +0400, a ecrit: > >> @@ -163,23 +183,14 @@ fork_exec(struct socket *so, const char *ex) > >> exit(1); > >> > >>

[Qemu-devel] [PULL 1/4] slirp: Don't pass possibly -1 fd to send()

2018-11-10 Thread Samuel Thibault
From: Peter Maydell Coverity complains (CID 1005726) that we might pass -1 as the fd argument to send() in slirp_send(), because we previously checked for "so->s == -1 && so->extra". The case of "so->s == -1 but so->extra NULL" should not in theory happen, but it is hard to guarantee because

Re: [Qemu-devel] [PATCH for-3.2 08/13] slirp: remove Monitor dependency, return a string for info

2018-11-10 Thread Samuel Thibault
Marc-André Lureau, le sam. 10 nov. 2018 17:45:43 +0400, a ecrit: > There is nothing performance-sensitive in returning an allocated > string for info, and handling the monitor_printf() on the caller side. Applied to my tree, thanks! Samuel

[Qemu-devel] [PATCH for-3.2 09/13] slirp: fix slirp_add_exec() leaks

2018-11-10 Thread Marc-André Lureau
Free the list elements allocated in add_exec(). Signed-off-by: Marc-André Lureau --- slirp/misc.h | 2 +- slirp/slirp.c | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/slirp/misc.h b/slirp/misc.h index 94829722cd..0bc5e74bc5 100644 --- a/slirp/misc.h +++

[Qemu-devel] [PATCH for-3.2 13/13] slirp: simplify fork_exec()

2018-11-10 Thread Marc-André Lureau
Use g_spawn_async_with_fds() to setup the child. GSpawn handles reaping the child, and closing parent file descriptors. Signed-off-by: Marc-André Lureau --- slirp/misc.c | 77 +--- 1 file changed, 37 insertions(+), 40 deletions(-) diff --git

Re: [Qemu-devel] [PATCH for-3.2 01/13] slirp: associate slirp_output callback with the Slirp context

2018-11-10 Thread Samuel Thibault
Marc-André Lureau, le sam. 10 nov. 2018 17:45:36 +0400, a ecrit: > Let's make the slirp interface a bit more library-like. > Associate the slirp_output() with a Slirp context. > > Signed-off-by: Marc-André Lureau Applied to my tree, thanks! Samuel

[Qemu-devel] [PULL 3/4] slirp: Remove code that handles socreate() failure

2018-11-10 Thread Samuel Thibault
From: Peter Maydell Now that socreate() can never fail, we can remove the code that was trying to handle that situation. In particular this removes code in tcp_connect() that provoked Coverity to complain (CID 1005724): in closesocket(accept(inso->s, (struct sockaddr *), )); if the accept()

[Qemu-devel] [PULL 4/4] slirp: fork_exec(): create and connect child socket before fork()

2018-11-10 Thread Samuel Thibault
From: Peter Maydell Currently fork_exec() fork()s, and then creates and connects the child socket which it uses for communication with the parent in the child process. This is awkward because the child has no mechanism to report failure back to the parent, which might end up blocked forever in

Re: [Qemu-devel] [PATCH for-3.2 03/13] slirp: replace ex_pty with ex_chardev

2018-11-10 Thread Samuel Thibault
Marc-André Lureau, le sam. 10 nov. 2018 17:45:38 +0400, a ecrit: > do_pty == 3 means to talk to a chardev. Applied to my tree, thanks!

Re: [Qemu-devel] [PATCH for-3.2 11/13] slirp: replace the poor-man string split with g_strsplit()

2018-11-10 Thread Samuel Thibault
Marc-André Lureau, le sam. 10 nov. 2018 17:45:46 +0400, a ecrit: > Use the glib function for the work, fix a potential crash on >256 words. Applied to my tree, thanks! Samuel

[Qemu-devel] [PATCH for-3.2 02/13] slirp: remove do_pty from fork_exec()

2018-11-10 Thread Marc-André Lureau
QEMU uses fork_exec() with do_pty values 0 or 3. Let's clean up some unused code. Signed-off-by: Marc-André Lureau --- slirp/misc.h | 2 +- slirp/misc.c | 55 ++-- slirp/tcp_subr.c | 2 +- 3 files changed, 18 insertions(+), 41 deletions(-)

[Qemu-devel] [PATCH for-3.2 05/13] slirp: remove unused EMU_RSH

2018-11-10 Thread Marc-André Lureau
EMU_RSH handling was dropped in commit 0d62c4cfe21752df4c1d6e2c2398f15d5eaa794a. The assignment, and subsequent free() of ex_ptr->ex_exec to so->extra looks unsafe (double free is likely to occur). Signed-off-by: Marc-André Lureau --- slirp/misc.h | 1 - slirp/slirp.c| 2 --

[Qemu-devel] [PATCH for-3.2 00/13] slirp: cleanups

2018-11-10 Thread Marc-André Lureau
Hi, Here is a bunch of slirp cleanups for 3.2. Marc-André Lureau (13): slirp: associate slirp_output callback with the Slirp context slirp: remove do_pty from fork_exec() slirp: replace ex_pty with ex_chardev slirp: use a dedicated field for chardev pointer slirp: remove unused EMU_RSH

[Qemu-devel] [PATCH for-3.2 01/13] slirp: associate slirp_output callback with the Slirp context

2018-11-10 Thread Marc-André Lureau
Let's make the slirp interface a bit more library-like. Associate the slirp_output() with a Slirp context. Signed-off-by: Marc-André Lureau --- slirp/libslirp.h | 9 + slirp/slirp.h| 1 + net/slirp.c | 5 +++-- slirp/ncsi.c | 2 +- slirp/slirp.c| 11 +++ 5

[Qemu-devel] [PATCH for-3.2 07/13] slirp: move internal function declarations

2018-11-10 Thread Marc-André Lureau
Clarify that those functions are internal to slirp. Signed-off-by: Marc-André Lureau --- slirp/libslirp.h | 3 --- slirp/slirp.h| 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/slirp/libslirp.h b/slirp/libslirp.h index 3e88dbaa01..a4f390ee89 100644 ---

Re: [Qemu-devel] [PATCH for-3.2 10/13] slirp: improve subprocess socket creation

2018-11-10 Thread Peter Maydell
On 10 November 2018 at 13:53, Samuel Thibault wrote: > Marc-André Lureau, le sam. 10 nov. 2018 17:45:45 +0400, a ecrit: >> @@ -163,23 +183,14 @@ fork_exec(struct socket *so, const char *ex) >> exit(1); >> >>default: >> - qemu_add_child_watch(pid); >> -

Re: [Qemu-devel] [PATCH for-3.2 04/13] slirp: use a dedicated field for chardev pointer

2018-11-10 Thread Samuel Thibault
Marc-André Lureau, le sam. 10 nov. 2018 17:45:39 +0400, a ecrit: > Let's not mix command line and chardev pointers. Applied to my tree, thanks! Samuel

Re: [Qemu-devel] List of files containing devices which have not been QOMified

2018-11-10 Thread Mark Cave-Ayland
On 09/11/2018 10:31, Peter Maydell wrote: > On 9 November 2018 at 10:17, Mark Cave-Ayland > wrote: >> On 06/11/2018 18:43, Peter Maydell wrote: >> >>> I had an idea for how to get a rough list of source files >>> containing devices that haven't been QOMified. The theory >>> is that a pre-QOM

[Qemu-devel] [PATCH] edid: silence a stringop-overflow warning

2018-11-10 Thread Marc-André Lureau
Simplify the code that doesn't need strncpy() since length of string is already computed. /home/elmarco/src/qemu/hw/display/edid-generate.c: In function 'edid_desc_text': /home/elmarco/src/qemu/hw/display/edid-generate.c:168:5: error: 'strncpy' specified bound depends on the length of the source

[Qemu-devel] [PATCH for-3.2 10/13] slirp: improve subprocess socket creation

2018-11-10 Thread Marc-André Lureau
Fix a bunch of error handling issues by creating the "TCP socketpair" from the parent process. (the code is currently disabled on Windows: at first I thought a socketpair() could be used, but I realized that slirp calls MSG_OOB on the socket, which isn't implemented on Linux) Signed-off-by:

[Qemu-devel] [PATCH for-3.2 12/13] glib-compat: add g_spawn_async_with_fds() fallback

2018-11-10 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- include/glib-compat.h | 56 +++ 1 file changed, 56 insertions(+) diff --git a/include/glib-compat.h b/include/glib-compat.h index fdf95a255d..4a10c9691f 100644 --- a/include/glib-compat.h +++ b/include/glib-compat.h @@

[Qemu-devel] [PATCH for-3.2 06/13] slirp: rename /extra/chardev

2018-11-10 Thread Marc-André Lureau
Now it's only used for the chardev pointer. Signed-off-by: Marc-André Lureau --- slirp/socket.h | 2 +- slirp/slirp.c| 4 ++-- slirp/tcp_subr.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/slirp/socket.h b/slirp/socket.h index 2f224bc34f..930ed95972 100644 ---

Re: [Qemu-devel] [PATCH for-3.2 06/13] slirp: rename /extra/chardev

2018-11-10 Thread Samuel Thibault
Marc-André Lureau, le sam. 10 nov. 2018 17:45:41 +0400, a ecrit: > Now it's only used for the chardev pointer. Applied to my tree, thanks! Samuel

Re: [Qemu-devel] [PATCH for-3.2 05/13] slirp: remove unused EMU_RSH

2018-11-10 Thread Samuel Thibault
Marc-André Lureau, le sam. 10 nov. 2018 17:45:40 +0400, a ecrit: > EMU_RSH handling was dropped in commit > 0d62c4cfe21752df4c1d6e2c2398f15d5eaa794a. > > The assignment, and subsequent free() of ex_ptr->ex_exec to so->extra > looks unsafe (double free is likely to occur). Applied to my tree,

[Qemu-devel] [PATCH for-3.2 03/13] slirp: replace ex_pty with ex_chardev

2018-11-10 Thread Marc-André Lureau
do_pty == 3 means to talk to a chardev. Signed-off-by: Marc-André Lureau --- slirp/misc.h | 2 +- slirp/misc.c | 2 +- slirp/slirp.c| 4 ++-- slirp/tcp_subr.c | 4 +--- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/slirp/misc.h b/slirp/misc.h index

[Qemu-devel] [PATCH for-3.2 08/13] slirp: remove Monitor dependency, return a string for info

2018-11-10 Thread Marc-André Lureau
There is nothing performance-sensitive in returning an allocated string for info, and handling the monitor_printf() on the caller side. Signed-off-by: Marc-André Lureau --- slirp/libslirp.h | 2 +- net/slirp.c | 7 --- slirp/misc.c | 23 +-- 3 files changed,

[Qemu-devel] [PATCH for-3.2 04/13] slirp: use a dedicated field for chardev pointer

2018-11-10 Thread Marc-André Lureau
Let's not mix command line and chardev pointers. Signed-off-by: Marc-André Lureau --- slirp/libslirp.h | 2 +- slirp/misc.h | 4 ++-- net/slirp.c | 8 slirp/misc.c | 11 +++ slirp/slirp.c| 5 +++-- slirp/tcp_subr.c | 2 +- 6 files changed, 18

Re: [Qemu-devel] [PATCH for-3.2 09/13] slirp: fix slirp_add_exec() leaks

2018-11-10 Thread Samuel Thibault
Marc-André Lureau, le sam. 10 nov. 2018 17:45:44 +0400, a ecrit: > Free the list elements allocated in add_exec(). Applied to my tree, thanks! Samuel

Re: [Qemu-devel] [PATCH v2 10/22] json: Define new QMP message for pvrdma

2018-11-10 Thread Marcel Apfelbaum
On 11/8/18 6:08 PM, Yuval Shaia wrote: pvrdma requires that the same GID attached to it will be attached to the backend device in the host. A new QMP messages is defined so pvrdma device can broadcast any change made to its GID table. This event is captured by libvirt which in turn will

Re: [Qemu-devel] [PATCH v2] pulseaudio: process audio data in smaller chunks

2018-11-10 Thread Philippe Mathieu-Daudé
Hi Gerd, On 11/9/18 3:20 PM, Gerd Hoffmann wrote: > The rate of pulseaudio absorbing the audio stream is used to control the > the rate of the guests audio stream. When the emulated hardware uses > small chunks (like intel-hda does) we need small chunks on the audio > backend side too, otherwise

Re: [Qemu-devel] [PATCH] build: qga: add macro to force use of native mingw32 assert()

2018-11-10 Thread Philippe Mathieu-Daudé
Hi Michael, On 11/9/18 5:00 PM, Michael Roth wrote: > When building qemu-ga for w32 with VSS support, some parts of qemu-ga > are not linked against glib, specifically the C++ bits used to > create the VSS provider DLL. With 3ebee3b191e, we now define assert() > as g_assert() for all mingw32

Re: [Qemu-devel] [PATCH for-3.2 00/13] slirp: cleanups

2018-11-10 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181110134548.14741-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH for-3.2 00/13] slirp: cleanups === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH] ps2kbd: default to scan enabled after reset

2018-11-10 Thread Hervé Poussineau
Ping. Le 21/10/2018 à 21:07, Hervé Poussineau a écrit : A check for scan_enabled has been added to ps2_keyboard_event in commit 143c04c7e0639e53086519592ead15d2556bfbf2 to prevent stream corruption. This works well as long as operating system is resetting keyboard, or enabling it. This fixes

Re: [Qemu-devel] [RFC] [PATCH] kvm: arm: Introduce error code KVM_EINVARIANT

2018-11-10 Thread Manish Jaggi
CCing a larger audience. Please review. On 10/23/2018 03:51 PM, Jaggi, Manish wrote: > From: Manish Jaggi > > This patch introduces an error code KVM_EINVARIANT which is returned > by KVM when userland tries to set an invariant register. > > The need for this error code is in VM Migration for

Re: [Qemu-devel] [PATCH v2 02/22] hw/rdma: Add ability to force notification without re-arm

2018-11-10 Thread Marcel Apfelbaum
On 11/8/18 6:07 PM, Yuval Shaia wrote: Upon completion of incoming packet the device pushes CQE to driver's RX ring and notify the driver (msix). While for data-path incoming packets the driver needs the ability to control whether it wished to receive interrupts or not, for control-path

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/2] target/arm: Hyp mode R14 is shared with User and System

2018-11-10 Thread Philippe Mathieu-Daudé
On 11/9/18 7:15 PM, Peter Maydell wrote: > On 9 November 2018 at 17:35, Peter Maydell wrote: >> Hyp mode is an exception to the general rule that each AArch32 >> mode has its own r13, r14 and SPSR -- it has a banked r13 and >> SPSR but shares its r14 with User and System mode. We were >>

Re: [Qemu-devel] [PATCH v2 01/22] contrib/rdmacm-mux: Add implementation of RDMA User MAD multiplexer

2018-11-10 Thread Shamir Rabinovitch
On Thu, Nov 08, 2018 at 06:07:57PM +0200, Yuval Shaia wrote: > RDMA MAD kernel module (ibcm) disallow more than one MAD-agent for a > given MAD class. > This does not go hand-by-hand with qemu pvrdma device's requirements > where each VM is MAD agent. > Fix it by adding implementation of RDMA MAD

Re: [Qemu-devel] [Qemu-arm] [PATCH for-3.1] target/arm: Fix typo in tlbi_aa64_vmalle1_write

2018-11-10 Thread Philippe Mathieu-Daudé
On 11/10/18 1:17 PM, Richard Henderson wrote: > This would cause an infinite recursion or loop. Hehe :) > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH v2 05/22] hw/rdma: Add support for MAD packets

2018-11-10 Thread Marcel Apfelbaum
Hi Yuval On 11/8/18 6:08 PM, Yuval Shaia wrote: MAD (Management Datagram) packets are widely used by various modules both in kernel and in user space for example the rdma_* API which is used to create and maintain "connection" layer on top of RDMA uses several types of MAD packets. Can you

Re: [Qemu-devel] [PATCH v2 09/22] hw/pvrdma: Set the correct opcode for send completion

2018-11-10 Thread Marcel Apfelbaum
On 11/8/18 6:08 PM, Yuval Shaia wrote: opcode for WC should be set by the device and not taken from work element. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_qp_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c

Re: [Qemu-devel] [PATCH v2 03/22] hw/rdma: Return qpn 1 if ibqp is NULL

2018-11-10 Thread Marcel Apfelbaum
Hi Yuval, On 11/8/18 6:07 PM, Yuval Shaia wrote: Device is not supporting QP0, only QP1. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/rdma_backend.h b/hw/rdma/rdma_backend.h index 86e8fe8ab6..3ccc9a2494

Re: [Qemu-devel] [PATCH for-3.2 00/13] slirp: cleanups

2018-11-10 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181110134548.14741-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH for-3.2

[Qemu-devel] [Bug 1802684] [NEW] QEMU gui crashes on macOS Mojave

2018-11-10 Thread inactive
Public bug reported: QEMU release 3.0.0 as well as a recent head build /usr/local/Cellar/qemu/HEAD-03c1ca1 (147 files, 257.2MB) Built from source on 2018-11-06 at 13:41:32 with: --with-gtk+3 --with-sdl2 --with-libusb /usr/local/Cellar/qemu/3.0.0 (137 files, 261.6MB) * Poured from bottle on

Re: [Qemu-devel] [PATCH v2 07/22] hw/pvrdma: Make default pkey 0xFFFF

2018-11-10 Thread Marcel Apfelbaum
On 11/8/18 6:08 PM, Yuval Shaia wrote: Commit 6e7dba23af ("hw/pvrdma: Make default pkey 0x") exports default pkey as external definition but omit the change from 0x7FFF to 0x. Fixes: 6e7dba23af ("hw/pvrdma: Make default pkey 0x") Signed-off-by: Yuval Shaia ---

Re: [Qemu-devel] [PATCH v2 08/22] hw/pvrdma: Set the correct opcode for recv completion

2018-11-10 Thread Marcel Apfelbaum
On 11/8/18 6:08 PM, Yuval Shaia wrote: The function pvrdma_post_cqe populates CQE entry with opcode from the given completion element. For receive operation value was not set. Fix it by setting it to IBV_WC_RECV. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_qp_ops.c | 3 ++- 1 file

Re: [Qemu-devel] [PATCH v2 06/22] hw/pvrdma: Make function reset_device return void

2018-11-10 Thread Marcel Apfelbaum
On 11/8/18 6:08 PM, Yuval Shaia wrote: This function cannot fail - fix it to return void Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index

Re: [Qemu-devel] [PATCH v2 13/22] hw/pvrdma: Make sure PCI function 0 is vmxnet3

2018-11-10 Thread Marcel Apfelbaum
On 11/8/18 6:08 PM, Yuval Shaia wrote: Guest driver enforces it, we should also. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma.h | 2 ++ hw/rdma/vmw/pvrdma_main.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/hw/rdma/vmw/pvrdma.h b/hw/rdma/vmw/pvrdma.h index

Re: [Qemu-devel] [PATCH v2 04/22] hw/rdma: Abort send-op if fail to create addr handler

2018-11-10 Thread Marcel Apfelbaum
On 11/8/18 6:08 PM, Yuval Shaia wrote: Function create_ah might return NULL, let's exit with an error. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index

[Qemu-devel] [PATCH 1/2] MAINTAINERS: Add scripts/decodetree.py to the TCG section

2018-11-10 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 126fe0be7e..45e4bfcd87 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -112,6 +112,7 @@ S: Maintained F: cpus.c F: exec.c F: accel/tcg/ +F:

[Qemu-devel] [PATCH for-4 0/2] decodetree: Support multiple inclusion

2018-11-10 Thread Philippe Mathieu-Daudé
Hi Richard, I noticed this issue when using decodetree with multiple ISAs. Regards, Phil. Philippe Mathieu-Daudé (2): MAINTAINERS: Add scripts/decodetree.py to the TCG section decodetree: Add multiple include guard MAINTAINERS | 1 + scripts/decodetree.py | 5 + 2 files

[Qemu-devel] [PATCH 2/2] decodetree: Add multiple include guard

2018-11-10 Thread Philippe Mathieu-Daudé
It is necessary when splitting an ISA, or when using multiple ISAs. Signed-off-by: Philippe Mathieu-Daudé --- scripts/decodetree.py | 5 + 1 file changed, 5 insertions(+) diff --git a/scripts/decodetree.py b/scripts/decodetree.py index 0bc73b5990..5dea15e7a5 100755 ---

Re: [Qemu-devel] [PATCH] ps2kbd: default to scan enabled after reset

2018-11-10 Thread Philippe Mathieu-Daudé
Hi Hervé, On Sun, Oct 21, 2018 at 9:12 PM Hervé Poussineau wrote: > A check for scan_enabled has been added to ps2_keyboard_event in commit > 143c04c7e0639e53086519592ead15d2556bfbf2 to prevent stream corruption. > This works well as long as operating system is resetting keyboard, or > enabling

Re: [Qemu-devel] [PATCH v2 01/22] contrib/rdmacm-mux: Add implementation of RDMA User MAD multiplexer

2018-11-10 Thread Yuval Shaia
On Sat, Nov 10, 2018 at 10:10:04PM +0200, Shamir Rabinovitch wrote: > On Thu, Nov 08, 2018 at 06:07:57PM +0200, Yuval Shaia wrote: > > RDMA MAD kernel module (ibcm) disallow more than one MAD-agent for a > > given MAD class. > > This does not go hand-by-hand with qemu pvrdma device's requirements

Re: [Qemu-devel] [PATCH v2 10/22] json: Define new QMP message for pvrdma

2018-11-10 Thread Yuval Shaia
On Sat, Nov 10, 2018 at 08:25:46PM +0200, Marcel Apfelbaum wrote: > > > +# > > +## > > +{ 'event': 'RDMA_GID_STATUS_CHANGED', > > + 'data': { 'netdev': 'str', > > +'gid-status': 'bool', > > 'git-status' naming as of indication if we add or remove a gid > is a little odd,

Re: [Qemu-devel] [PATCH] build: qga: add macro to force use of native mingw32 assert()

2018-11-10 Thread Michael Roth
Quoting Philippe Mathieu-Daudé (2018-11-10 13:34:25) > Hi Michael, > > On 11/9/18 5:00 PM, Michael Roth wrote: > > When building qemu-ga for w32 with VSS support, some parts of qemu-ga > > are not linked against glib, specifically the C++ bits used to > > create the VSS provider DLL. With

[Qemu-devel] [Bug 1802684] Re: QEMU gui crashes on macOS Mojave

2018-11-10 Thread Peter Maydell
Thanks for the bug report. It looks like Mojave is pickier about apps not calling various GUI update functions from the "wrong" thread. We probably need to figure out how to dispatch those to the main thread instead of whatever thread we were on. Unfortunately we don't really have anybody in QEMU

[Qemu-devel] [Bug 1802684] Re: QEMU gui crashes on macOS Mojave

2018-11-10 Thread inactive
I'll see if I have some time this weekend to dig into qemu Cocoa layer. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1802684 Title: QEMU gui crashes on macOS Mojave Status in QEMU: New Bug

[Qemu-devel] [PATCH] decodetree: Force Python to print unsigned values

2018-11-10 Thread Philippe Mathieu-Daudé
Python internal representation is signed, so unsigned values bigger than 31-bit are interpreted as signed (and printed with a '-' signed). Mask out to force unsigned values. Signed-off-by: Philippe Mathieu-Daudé --- scripts/decodetree.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH v2 13/22] hw/pvrdma: Make sure PCI function 0 is vmxnet3

2018-11-10 Thread Yuval Shaia
On Sat, Nov 10, 2018 at 08:27:44PM +0200, Marcel Apfelbaum wrote: > > > On 11/8/18 6:08 PM, Yuval Shaia wrote: > > Guest driver enforces it, we should also. > > > > Signed-off-by: Yuval Shaia > > --- > > hw/rdma/vmw/pvrdma.h | 2 ++ > > hw/rdma/vmw/pvrdma_main.c | 3 +++ > > 2 files