Re: [Qemu-devel] [PATCH v1 0/3] Improvements to the netmap backend

2018-12-14 Thread Jason Wang
On 2018/12/7 上午12:59, Vincenzo Maffione wrote: Improvements to the netmap backend, mostly to fix the handling of incomplete multi-slot packets. This has been tested with and without jumbo frames, using pkt-gen to send 60, 1500, 5000 or 9000 bytes packets between two VMs connected through a

Re: [Qemu-devel] [PATCH v3 01/16] virtio: split vhost vsock bits from virtio-pci

2018-12-14 Thread Thomas Huth
On 2018-12-13 22:00, Juan Quintela wrote: > Reviewed-by: Laurent Vivier > Signed-off-by: Juan Quintela > > --- > > Updated copyright info > Also split virtio-pci.h bits > --- > hw/virtio/Makefile.objs | 3 ++ > hw/virtio/vhost-vsock-pci.c | 82 + >

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Replace qdict_put() by qdict_put_obj() where appropriate

2018-12-14 Thread Alberto Garcia
On Thu 13 Dec 2018 06:51:54 PM CET, Markus Armbruster wrote: > Patch created mechanically by rerunning: > > $ spatch --sp-file scripts/coccinelle/qobject.cocci \ > --macro-file scripts/cocci-macro-file.h \ > --dir block --in-place > > Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v3 02/16] virtio: split virtio input host bits from virtio-pci

2018-12-14 Thread Thomas Huth
On 2018-12-13 22:00, Juan Quintela wrote: > For consistency with other devices, rename > virtio_host_{initfn,pci_info} to virtio_input_host_{initfn,info}. > > Reviewed-by: Laurent Vivier > Signed-off-by: Juan Quintela > --- > default-configs/virtio.mak| 1 + > hw/virtio/Makefile.objs

[Qemu-devel] [PATCH] build: Remake config-host.mak when VERSION changes

2018-12-14 Thread Markus Armbruster
configure gets the version number from VERSION, and writes it to config-host.mak. The make dependency for that is missing. Because of that, a rebuild after a VERSION change may not pick up the change. Fix that. Signed-off-by: Markus Armbruster --- Makefile | 2 +- 1 file changed, 1

Re: [Qemu-devel] [PULL v2 00/32] QAPI patches for 2018-12-13

2018-12-14 Thread Markus Armbruster
Resent by accident, please ignore this copy, and use the original instead.

Re: [Qemu-devel] [PATCH v3 0/2] intel-iommu: add support for 5-level virtual IOMMU.

2018-12-14 Thread Yu Zhang
Sorry, any comments for this series? Thanks. :) B.R. Yu On 12/12/2018 9:05 PM, Yu Zhang wrote: Intel's upcoming processors will extend maximum linear address width to 57 bits, and introduce 5-level paging for CPU. Meanwhile, the platform will also extend the maximum guest address width for

Re: [Qemu-devel] [PATCH qemu v2] spapr-iommu: Always advertise the maximum possible DMA window size

2018-12-14 Thread David Gibson
On Fri, Dec 14, 2018 at 03:21:22PM +1100, Alexey Kardashevskiy wrote: > When deciding about the huge DMA window, the typical Linux pseries guest > uses the maximum allowed RAM size as the upper limit. We did the same > on QEMU side to match that logic. Now we are going to support a GPU RAM > pass

Re: [Qemu-devel] [PATCH v2] qcow2: Assert that refcount block offsets fit in the refcount table

2018-12-14 Thread Alberto Garcia
ping I suppose this one can go in now. On Wed 14 Nov 2018 03:58:57 PM CET, Alberto Garcia wrote: > Refcount table entries have a field to store the offset of the > refcount block. The rest of the bits of the entry are currently > reserved. > > The offset is always taken from the entry using

[Qemu-devel] patchew.org using expired https certificate

2018-12-14 Thread Peter Maydell
Connecting to https://patchew.org/ makes my browser complain: # patchew.org uses an invalid security certificate. # The certificate expired on 19 November 2017, 00:27:00 GMT. # The current time is 14 December 2018, 09:52. # Error code: SEC_ERROR_EXPIRED_CERTIFICATE which is a bit odd, given I

Re: [Qemu-devel] [PATCH 0/2] Minor fixes for the mirror block job

2018-12-14 Thread Alberto Garcia
ping On Thu 22 Nov 2018 04:00:25 PM CET, Alberto Garcia wrote: > Hi, > > a couple of minor fixes for the mirror block job. I don't think these > bugs can be reproduced at the moment so this shouldn't be 3.1 > material. > > Berto > > Alberto Garcia (2): > mirror: Release the dirty bitmap if

Re: [Qemu-devel] [PATCH qemu v3] ppc/spapr: Receive and store device tree blob from SLOF

2018-12-14 Thread Greg Kurz
On Fri, 14 Dec 2018 12:55:20 +1100 Alexey Kardashevskiy wrote: > SLOF receives a device tree and updates it with various properties > before switching to the guest kernel and QEMU is not aware of any changes > made by SLOF. Since there is no real RTAS (QEMU implements it), it makes > sense to

[Qemu-devel] [PULL 5/5] usb-mtp: Limit filename to object information size

2018-12-14 Thread Gerd Hoffmann
From: Michael Hanselmann The filename length in MTP metadata is specified by the guest. By trusting it directly it'd theoretically be possible to get the host to write memory parts outside the filename buffer into a filename. In practice though there are usually NUL bytes stopping the string

[Qemu-devel] [PULL 2/5] usb-host: reset and close libusb_device_handle before qemu exit

2018-12-14 Thread Gerd Hoffmann
From: linzhecheng we should perform these things as same as usb_host_close. Signed-off-by: linzhecheng Message-id: 20181130064700.5984-1-linzhech...@huawei.com [ kraxel: whitespace fixup ] Signed-off-by: Gerd Hoffmann --- hw/usb/host-libusb.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [Qemu-devel] [PATCH 2/3] i386: Atomically update PTEs with mttcg

2018-12-14 Thread Philippe Mathieu-Daudé
On 12/14/18 1:05 AM, Benjamin Herrenschmidt wrote: > Note to RiscV folks: You may want to adapt your code to do the same as > this, esp. afaik, what you do today is endian-broken if host and guest > endian are different. Cc'ing the RISC-V list. > Cheers, > Ben. > > On Fri, 2018-12-14 at 10:58

Re: [Qemu-devel] [PATCH v3 16/16] virtio: virtio 9p really requires CONFIG_VIRTFS to work

2018-12-14 Thread Thomas Huth
On 2018-12-13 22:00, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > default-configs/virtio.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/default-configs/virtio.mak b/default-configs/virtio.mak > index 5ae4a61018..ecb4420e74 100644 > ---

Re: [Qemu-devel] [PATCH v2] qdev/core: Can not replug device on bus that allows one device

2018-12-14 Thread Pierre Morel
On 13/12/2018 17:26, Tony Krowiak wrote: If the maximum number of devices allowed on a bus is 1 and a device which is plugged into the bus is subsequently unplugged, attempting to replug the device fails with error "Bus 'xxx' does not support hotplugging". The "error" is detected in the

Re: [Qemu-devel] [PATCH v3 14/16] virtio: split virtio gpu bits rom virtio-pci.h

2018-12-14 Thread Thomas Huth
On 2018-12-13 22:00, Juan Quintela wrote: > Reviewed-by: Laurent Vivier > Signed-off-by: Juan Quintela > --- > hw/display/virtio-gpu-pci.c | 14 ++ > hw/display/virtio-vga.c | 1 + > hw/virtio/virtio-pci.h | 14 -- > 3 files changed, 15 insertions(+), 14

Re: [Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block

2018-12-14 Thread Paolo Bonzini
On 14/12/18 07:29, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 13/12/18 19:21, Peter Maydell wrote: >>> On Thu, 13 Dec 2018 at 18:07, Paolo Bonzini wrote: On 13/12/18 19:01, Peter Maydell wrote: > I sent a patch to do this a little while back: >

Re: [Qemu-devel] [PATCH v3 15/16] virtio: split virtio crypto bits rom virtio-pci.h

2018-12-14 Thread Thomas Huth
On 2018-12-13 22:00, Juan Quintela wrote: > Reviewed-by: Laurent Vivier > Signed-off-by: Juan Quintela > --- > hw/virtio/virtio-crypto-pci.c | 14 ++ > hw/virtio/virtio-pci.h| 14 -- > 2 files changed, 14 insertions(+), 14 deletions(-) > Reviewed-by: Thomas

Re: [Qemu-devel] [PULL 0/6] Qcrypto next patches

2018-12-14 Thread Peter Maydell
On Wed, 12 Dec 2018 at 11:24, Daniel P. Berrangé wrote: > > The following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11 > 19:18:58 +) > > are available in the Git

Re: [Qemu-devel] patchew.org using expired https certificate

2018-12-14 Thread Stefan Hajnoczi
On Fri, Dec 14, 2018 at 09:54:06AM +, Peter Maydell wrote: > Connecting to https://patchew.org/ makes my browser complain: > > # patchew.org uses an invalid security certificate. > # The certificate expired on 19 November 2017, 00:27:00 GMT. > # The current time is 14 December 2018, 09:52. >

Re: [Qemu-devel] patchew.org using expired https certificate

2018-12-14 Thread Fam Zheng
> On Dec 14, 2018, at 18:13, Stefan Hajnoczi wrote: > > On Fri, Dec 14, 2018 at 09:54:06AM +, Peter Maydell wrote: >> Connecting to https://patchew.org/ makes my browser complain: >> >> # patchew.org uses an invalid security certificate. >> # The certificate expired on 19 November 2017,

Re: [Qemu-devel] [PATCH 2/2] avoid TABs in files that only contain a few

2018-12-14 Thread Daniel P . Berrangé
On Thu, Dec 13, 2018 at 11:37:37PM +0100, Paolo Bonzini wrote: > Most files that have TABs only contain a handful of them. Change > them to spaces so that we don't confuse people. > > disas, standard-headers, linux-headers and libdecnumber are imported > from other projects and probably should

[Qemu-devel] [PULL v2 00/42] Block layer patches

2018-12-14 Thread Kevin Wolf
The following changes since commit d8d5fefd8657d4f7b380b3a1533340434b5b9def: Merge remote-tracking branch 'remotes/berrange/tags/qcrypto-next-pull-request' into staging (2018-12-13 18:45:18 +) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream

[Qemu-devel] [PATCH v4] log: Make glib logging go through QEMU

2018-12-14 Thread Christophe Fergeau
This commit adds a qemu_init_logging() helper which calls g_log_set_default_handler() so that glib logs (g_log, g_warning, ...) are handled similarly to other QEMU logs. This means they will get a timestamp if timestamps are enabled, and they will go through the monitor if one is configured. This

Re: [Qemu-devel] [PATCH qemu v2] hmp: Print if memory section is registered with an accelerator

2018-12-14 Thread Philippe Mathieu-Daudé
Hi Alexey, On 12/14/18 3:58 AM, Alexey Kardashevskiy wrote: > This adds an accelerator name to the "into mtree -f" to tell the user if > a particular memory section is registered with the accelerator; > the primary user for this is KVM and such information is useful > for debugging purposes. > >

Re: [Qemu-devel] [RFC PATCH v2] contrib: add a basic gitdm config

2018-12-14 Thread Laurent Vivier
On 14/12/2018 11:51, Philippe Mathieu-Daudé wrote: > On 12/12/18 11:25 AM, Alex Bennée wrote: >> This is a QEMU specific version of a gitdm config for generating >> reports on the contributor base of the project. I've added enough >> group maps and domain aliases to ensure the current top ten is

Re: [Qemu-devel] [PATCH 00/10] Remove deprecated load_image() function

2018-12-14 Thread Peter Maydell
On Fri, 30 Nov 2018 at 15:20, Peter Maydell wrote: > > This patchset removes the load_image() function, which we noted > in a comment as being deprecated in 2008 but were still using > in a handful of places. All the use cases are bugs of some > kind or another, either straightforward "no length

Re: [Qemu-devel] [PATCH v2 for-4.0 0/3] Avoid cpu_physical_memory_read() in generic code

2018-12-14 Thread Peter Maydell
On Thu, 22 Nov 2018 at 17:28, Peter Maydell wrote: > > This patchset takes three places in generic code which > use cpu_physical_memory_read(), and changes them to use > address_space_read() instead. > > Changes v1->v2: > * patches 1, 2 unchanged (and reviewed) > * patch 3: handle as being NULL

Re: [Qemu-devel] [Qemu-arm] [PATCH for-4.0 0/2] Rename cpu_physical_memory_write_rom() to address_space_write_rom()

2018-12-14 Thread Peter Maydell
On Thu, 22 Nov 2018 at 13:35, Peter Maydell wrote: > > The API of cpu_physical_memory_write_rom() is odd, because it > takes an AddressSpace, unlike all the other cpu_physical_memory_* > access functions. We note this oddity as a TODO in the > docs/devel/loads-stores.rst documentation. > > Rename

Re: [Qemu-devel] [PATCH v3 03/16] virtio: split virtio input bits from virtio-pci

2018-12-14 Thread Thomas Huth
On 2018-12-13 22:00, Juan Quintela wrote: > Reviewed-by: Laurent Vivier > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs | 1 + > hw/virtio/virtio-input-pci.c | 154 +++ > hw/virtio/virtio-pci.c | 113 - >

Re: [Qemu-devel] [PATCH v3 08/16] virtio: split vhost user scsi bits from virtio-pci

2018-12-14 Thread Thomas Huth
On 2018-12-13 22:00, Juan Quintela wrote: > Reviewed-by: Laurent Vivier > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs | 1 + > hw/virtio/vhost-user-scsi-pci.c | 101 > hw/virtio/virtio-pci.c | 58 -- >

Re: [Qemu-devel] [PATCH] vhost-vsock: support parse mergeable feature

2018-12-14 Thread jiangyiwen
On 2018/12/13 22:54, Michael S. Tsirkin wrote: > On Thu, Dec 13, 2018 at 11:27:24AM +0800, jiangyiwen wrote: >> On 2018/12/12 21:19, Michael S. Tsirkin wrote: >>> On Wed, Dec 12, 2018 at 05:54:49PM +0800, jiangyiwen wrote: Currently vhost-vsock doesn't have any feature bits, so it don't

Re: [Qemu-devel] [PATCH] vhost-vsock: support parse mergeable feature

2018-12-14 Thread jiangyiwen
On 2018/12/13 23:34, Stefan Hajnoczi wrote: > On Thu, Dec 13, 2018 at 11:27:24AM +0800, jiangyiwen wrote: >> On 2018/12/12 21:19, Michael S. Tsirkin wrote: >>> On Wed, Dec 12, 2018 at 05:54:49PM +0800, jiangyiwen wrote: Currently vhost-vsock doesn't have any feature bits, so it don't

Re: [Qemu-devel] [Qemu-trivial] [PATCH] error: Remove NULL checks on error_propagate() calls

2018-12-14 Thread Laurent Vivier
On 13/12/2018 18:31, Markus Armbruster wrote: > Patch created mechanically by rerunning: > > $ spatch --sp-file scripts/coccinelle/error_propagate_null.cocci \ > --macro-file scripts/cocci-macro-file.h \ > --dir . --in-place > > Whitespace tidied up manually. > >

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: Use error_fatal to simplify obvious fatal errors (again)

2018-12-14 Thread Laurent Vivier
On 13/12/2018 18:58, Markus Armbruster wrote: > Patch created mechanically by rerunning: > > $ spatch --in-place --sp-file scripts/coccinelle/use-error_fatal.cocci \ > --macro-file scripts/cocci-macro-file.h vl.c > > Signed-off-by: Markus Armbruster > --- > vl.c | 7 ++- >

Re: [Qemu-devel] [SPAM] [Qemu-ppc] [PATCH 2/2] avoid TABs in files that only contain a few

2018-12-14 Thread Greg Kurz
On Thu, 13 Dec 2018 23:37:37 +0100 Paolo Bonzini wrote: > Most files that have TABs only contain a handful of them. Change > them to spaces so that we don't confuse people. > > disas, standard-headers, linux-headers and libdecnumber are imported > from other projects and probably should be

[Qemu-devel] [PATCH v3] contrib: add a basic gitdm config

2018-12-14 Thread Alex Bennée
This is a QEMU specific version of a gitdm config for generating reports on the contributor base of the project. I've added enough group maps and domain aliases to ensure the current top ten is as reflective as it can be. As of this commit running: git log --numstat --since "Last Year" | gitdm

Re: [Qemu-devel] [PATCH v11 7/7] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-12-14 Thread Dr. David Alan Gilbert
* Wei Wang (wei.w.w...@intel.com) wrote: > On 12/14/2018 05:56 PM, Dr. David Alan Gilbert wrote: > > * Wei Wang (wei.w.w...@intel.com) wrote: > > > On 12/13/2018 11:45 PM, Dr. David Alan Gilbert wrote: > > > > * Wei Wang (wei.w.w...@intel.com) wrote: > > > > > The new feature enables the

Re: [Qemu-devel] [PATCH 2/2] avoid TABs in files that only contain a few

2018-12-14 Thread Paolo Bonzini
On 14/12/18 11:22, Daniel P. Berrangé wrote: >> crypto/aes.c >> crypto/desrfb.c > > I'd rather like this to be cleaned to finish the job for > crypto/. Ok, will do. Paolo

Re: [Qemu-devel] [PATCH v2 4/8] qcow2-threads: split out generic path

2018-12-14 Thread Vladimir Sementsov-Ogievskiy
14.12.2018 2:28, Paolo Bonzini wrote: > On 11/12/18 17:43, Vladimir Sementsov-Ogievskiy wrote: >> +ThreadPool *pool = aio_get_thread_pool(bdrv_get_aio_context(bs)); >> + >> +while (s->nb_threads >= QCOW2_MAX_THREADS) { >> +qemu_co_queue_wait(>thread_task_queue, NULL); >> +} >>

Re: [Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_set_{block, nonblock}

2018-12-14 Thread Li Qiang
Li Qiang 于2018年12月14日周五 上午9:46写道: > Hi all, > > Here is the error. > > GTESTER check-qtest-x86_64 > Unable to get file status flag on fd 21860: Bad file descriptor(errno=9) > GTESTER check-qtest-aarch64 > Broken pipe > GTester: last random seed: R02S3f0d6981dd97231d06e0b2966baf94b9 > Unable

Re: [Qemu-devel] [PATCH v1 1/2] target/arm: kvm64 make guest debug AA32 break point aware

2018-12-14 Thread Omair Javaid
On Thu, 13 Dec 2018 at 16:55, Alex Bennée wrote: > > When supported by the hardware we can run AA32 guests or even AA64 EL1 > code with AA32 EL0 mode code. Inserting a AA64 break point into AA32 > code tends to break things. This is especially acute with gdb as it > inserts temporary breakpoints

[Qemu-devel] [PATCH] scripts: add script to convert multiline comments into 4-line format

2018-12-14 Thread Paolo Bonzini
Since we're adding checkpatch rules to enforce 4-line multiline comment format, i.e. with lone /* and */, this script can be run on existing code so that the comment style does not become inconsistent within a file. The alternative to awk-in-a-shell-script could be Perl, which also supports -i

Re: [Qemu-devel] [PATCH v1] pc: Use hotplug_handler_(plug|unplug|unplug_request)

2018-12-14 Thread Paolo Bonzini
On 12/12/18 10:57, David Hildenbrand wrote: > Let's avoid manually looking up the hotplug handler class. Use the > existing wrappers instead. > > Signed-off-by: David Hildenbrand > --- > hw/i386/pc.c | 30 -- > 1 file changed, 8 insertions(+), 22 deletions(-) > >

Re: [Qemu-devel] [PULL 00/41] Block layer patches

2018-12-14 Thread Peter Maydell
On Wed, 12 Dec 2018 at 13:27, Kevin Wolf wrote: > > The following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11 > 19:18:58 +) > > are available in the Git

Re: [Qemu-devel] [PATCH v11 7/7] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-12-14 Thread Wei Wang
On 12/14/2018 05:56 PM, Dr. David Alan Gilbert wrote: * Wei Wang (wei.w.w...@intel.com) wrote: On 12/13/2018 11:45 PM, Dr. David Alan Gilbert wrote: * Wei Wang (wei.w.w...@intel.com) wrote: The new feature enables the virtio-balloon device to receive hints of guest free pages from the free

Re: [Qemu-devel] [PATCH] vl: Use error_fatal to simplify obvious fatal errors (again)

2018-12-14 Thread Philippe Mathieu-Daudé
On 12/13/18 6:58 PM, Markus Armbruster wrote: > Patch created mechanically by rerunning: > > $ spatch --in-place --sp-file scripts/coccinelle/use-error_fatal.cocci \ > --macro-file scripts/cocci-macro-file.h vl.c > > Signed-off-by: Markus Armbruster Reviewed-by: Philippe

[Qemu-devel] [PULL 0/5] Usb 20181214 patches

2018-12-14 Thread Gerd Hoffmann
The following changes since commit 4f818e7b7f8ecb5c166d093b8859fec2ddeca2ef: Update version for v3.1.0-rc5 release (2018-12-06 17:07:12 +) are available in the git repository at: git://git.kraxel.org/qemu tags/usb-20181214-pull-request for you to fetch changes up

Re: [Qemu-devel] [PATCH] input: avoid malloc for mouse events

2018-12-14 Thread Philippe Mathieu-Daudé
On 12/10/18 3:08 PM, Gerd Hoffmann wrote: > There is no reason to allocate mouse events using malloc, we can > allcoate them from stack instead, save a few cpu cycles and make the > code more readable with c99 initializers. Good idea. > > Suggested-by: FelixYao > Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] patchew.org using expired https certificate

2018-12-14 Thread Peter Maydell
On Fri, 14 Dec 2018 at 10:22, Fam Zheng wrote: > I tried to solve a coming expiration but some misconfiguration and mistakes > by me stoped it from working today, and I’m unfortunately hitting a rate > limit of certbot operations. I’ll fix it when the limit is cleared (next > week, hopefully).

Re: [Qemu-devel] [Qemu-block] Request for clarification on qemu-img convert behavior zeroing target host_device

2018-12-14 Thread De Backer, Fred (Nokia - BE/Antwerp)
>>> Indeed, performance traces are important for issues like this. >>See strace of both FC27 and FC29 attached >Looks like you traced only the main thread. All the I/O is done in other >threads. >These flags would be useful: > >    strace -o log -f -T -tt New straces attached with mentioned

Re: [Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block

2018-12-14 Thread Peter Maydell
On Fri, 14 Dec 2018 at 06:29, Markus Armbruster wrote: > > Paolo Bonzini writes: > > > On 13/12/18 19:21, Peter Maydell wrote: > >> On Thu, 13 Dec 2018 at 18:07, Paolo Bonzini wrote: > >>> On 13/12/18 19:01, Peter Maydell wrote: > I sent a patch to do this a little while back: >

Re: [Qemu-devel] [Qemu-arm] [PATCH for-4.0 0/2] Rename cpu_physical_memory_write_rom() to address_space_write_rom()

2018-12-14 Thread Paolo Bonzini
On 14/12/18 12:32, Peter Maydell wrote: > On Thu, 22 Nov 2018 at 13:35, Peter Maydell wrote: >> >> The API of cpu_physical_memory_write_rom() is odd, because it >> takes an AddressSpace, unlike all the other cpu_physical_memory_* >> access functions. We note this oddity as a TODO in the >>

[Qemu-devel] [PULL v2 27/32] qapi: Add #if conditions to generated code members

2018-12-14 Thread Markus Armbruster
From: Marc-André Lureau Wrap generated enum and struct members and their supporting code with #if/#endif, using the .ifcond members added in the previous patches. We do enum and struct in a single patch because union tag enum and the associated variants tie them together, and dealing with that

[Qemu-devel] [PATCH] build: Remake config-host.mak when VERSION changes

2018-12-14 Thread Markus Armbruster
configure gets the version number from VERSION, and writes it to config-host.mak. The make dependency for that is missing. Because of that, a rebuild after a VERSION change may not pick up the change. Fix that. Signed-off-by: Markus Armbruster --- Makefile | 2 +- 1 file changed, 1

[Qemu-devel] [PULL v2 00/32] QAPI patches for 2018-12-13

2018-12-14 Thread Markus Armbruster
git-request-pull master public pull-qapi-2018-12-13-v2 The following changes since commit c3ec0fa1a8e815ecfec9eabb9c20ee206c313e07: Merge remote-tracking branch 'remotes/armbru/tags/pull-monitor-2018-12-12' into staging (2018-12-13 13:41:44 +) are available in the Git repository at:

Re: [Qemu-devel] [PATCH v3 04/16] virtio: split virtio rng bits from virtio-pci

2018-12-14 Thread Thomas Huth
On 2018-12-13 22:00, Juan Quintela wrote: > Reviewed-by: Laurent Vivier > Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth

Re: [Qemu-devel] [PATCH v3 06/16] virtio: split virtio 9p bits from virtio-pci

2018-12-14 Thread Thomas Huth
On 2018-12-13 22:00, Juan Quintela wrote: > Reviewed-by: Laurent Vivier > Signed-off-by: Juan Quintela > > --- > > Also disable virtio9p test (lvivier) [...] > diff --git a/tests/Makefile.include b/tests/Makefile.include > index dd7c882cc5..90d33bb058 100644 > --- a/tests/Makefile.include >

Re: [Qemu-devel] [PATCH v2] qdev/core: Can not replug device on bus that allows one device

2018-12-14 Thread Pierre Morel
On 13/12/2018 17:26, Tony Krowiak wrote: If the maximum number of devices allowed on a bus is 1 and a device which is plugged into the bus is subsequently unplugged, attempting to replug the device fails with error "Bus 'xxx' does not support hotplugging". The "error" is detected in the

Re: [Qemu-devel] [PATCH v3 09/16] virtio: split vhost scsi bits from virtio-pci

2018-12-14 Thread Thomas Huth
On 2018-12-13 22:00, Juan Quintela wrote: > Reviewed-by: Laurent Vivier > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs| 1 + > hw/virtio/vhost-scsi-pci.c | 95 ++ > hw/virtio/virtio-pci.c | 59 --- >

[Qemu-devel] [PATCH v2] scripts: add script to convert multiline comments into 4-line format

2018-12-14 Thread Paolo Bonzini
Since we're adding checkpatch rules to enforce 4-line multiline comment format, i.e. with lone /* and */, this script can be run on existing code so that the comment style does not become inconsistent within a file. The alternative to awk-in-a-shell-script could be Perl, which also supports -i

Re: [Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_set_{block, nonblock}

2018-12-14 Thread Peter Maydell
On Fri, 14 Dec 2018 at 09:16, Li Qiang wrote: > First of all I want to know does the following error means? > doesn't it mean "the x86 qtest is ok and aarch64 is not ok"? > > > GTESTER check-qtest-x86_64 > GTESTER check-qtest-aarch64 > vhost-user-test:

Re: [Qemu-devel] [PATCH v11 7/7] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-12-14 Thread Dr. David Alan Gilbert
* Wei Wang (wei.w.w...@intel.com) wrote: > On 12/13/2018 11:45 PM, Dr. David Alan Gilbert wrote: > > * Wei Wang (wei.w.w...@intel.com) wrote: > > > The new feature enables the virtio-balloon device to receive hints of > > > guest free pages from the free page vq. > > > > > > A notifier is

[Qemu-devel] [PULL 3/5] ehci: fix fetch qtd race

2018-12-14 Thread Gerd Hoffmann
The token field contains the (guest-filled) state of the qtd, which indicates whenever the other fields are valid or not. So make sure we read the token first, otherwise we may end up with an stale next pointer: (1) ehci reads next (2) guest writes next (3) guest writes token (4) ehci

[Qemu-devel] [PULL 1/5] pvusb: set max grants only in initialise

2018-12-14 Thread Gerd Hoffmann
From: Juergen Gross Don't call xen_be_set_max_grant_refs() in usbback_alloc(), as the gnttabdev pointer won't be initialised yet. The call can easily be moved to usbback_connect(). Signed-off-by: Juergen Gross Message-id: 20181206133923.30105-1-jgr...@suse.com Signed-off-by: Gerd Hoffmann ---

[Qemu-devel] [PULL 4/5] usb-mtp: use O_NOFOLLOW and O_CLOEXEC.

2018-12-14 Thread Gerd Hoffmann
Open files and directories with O_NOFOLLOW to avoid symlinks attacks. While being at it also add O_CLOEXEC. usb-mtp only handles regular files and directories and ignores everything else, so users should not see a difference. Because qemu ignores symlinks, carrying out a successful symlink

Re: [Qemu-devel] [PATCH] error: Remove NULL checks on error_propagate() calls

2018-12-14 Thread Philippe Mathieu-Daudé
On 12/13/18 6:31 PM, Markus Armbruster wrote: > Patch created mechanically by rerunning: > > $ spatch --sp-file scripts/coccinelle/error_propagate_null.cocci \ > --macro-file scripts/cocci-macro-file.h \ > --dir . --in-place > > Whitespace tidied up manually. > >

Re: [Qemu-devel] [RFC PATCH v2] contrib: add a basic gitdm config

2018-12-14 Thread Philippe Mathieu-Daudé
On 12/12/18 11:25 AM, Alex Bennée wrote: > This is a QEMU specific version of a gitdm config for generating > reports on the contributor base of the project. I've added enough > group maps and domain aliases to ensure the current top ten is as > reflective as it can be. As of this commit running:

Re: [Qemu-devel] [PATCH for-4.0 0/6] vhost-user-blk: Add support for backend reconnecting

2018-12-14 Thread Michael S. Tsirkin
On Fri, Dec 14, 2018 at 10:33:54AM +0800, Yongji Xie wrote: > On Fri, 14 Dec 2018 at 10:20, Michael S. Tsirkin wrote: > > > > On Fri, Dec 14, 2018 at 09:56:41AM +0800, Yongji Xie wrote: > > > On Thu, 13 Dec 2018 at 22:45, Michael S. Tsirkin wrote: > > > > > > > > On Thu, Dec 06, 2018 at

Re: [Qemu-devel] [PATCH] qemu: avoid memory leak while remove disk

2018-12-14 Thread Michael S. Tsirkin
On Fri, Dec 07, 2018 at 09:53:06AM +0800, wangjian wrote: > Memset vhost_dev to zero in the vhost_dev_cleanup function. > This causes dev.vqs to be NULL, so that > vqs does not free up space when calling the g_free function. > This will result in a memory leak. But you can't release vqs > directly

Re: [Qemu-devel] [PATCH] hw/pci-bridge: check invalid slot number for root and downstream port

2018-12-14 Thread Michael S. Tsirkin
On Wed, Dec 05, 2018 at 05:41:26PM +0800, Huan Xiong wrote: > Since root and downstream port have only one slot, device should be > connected to them using slot 0. QEMU doesn't have a check for that > and starts up when a non-zero slot is specified, though the device > is not seen in guest OS. >

Re: [Qemu-devel] [RFC v2 05/38] plugin: add user-facing API

2018-12-14 Thread Emilio G. Cota
On Fri, Dec 14, 2018 at 18:47:42 +, Aaron Lindsay wrote: > On Dec 14 12:50, Emilio G. Cota wrote: > > On Fri, Dec 14, 2018 at 12:08:22 -0500, Emilio G. Cota wrote: > > > On Fri, Dec 14, 2018 at 15:57:32 +, Aaron Lindsay wrote: > > (snip) > > > > I added a function to the user-facing plugin

Re: [Qemu-devel] Loading snapshot with readonly qcow2 image

2018-12-14 Thread Eric Blake
On 12/14/18 10:03 AM, Michael Spradling wrote: Can you combine -s (create a writable temp file) with -l to get what you want? /me tries: I can confirm that 'qemu-nbd -s a' lets me write data that is discarded on disconnect (lsof says a temp file in /var/tmp/vl.XX was created); and that

Re: [Qemu-devel] [PATCH v2 6/7] iotests: allow pretty-print for qmp_log

2018-12-14 Thread John Snow
On 12/13/18 8:09 AM, Vladimir Sementsov-Ogievskiy wrote: > 13.12.2018 4:50, John Snow wrote: >> If iotests have lines exceeding >998 characters long, git doesn't >> want to send it plaintext to the list. We can solve this by allowing >> the iotests to use pretty printed QMP output that we can

Re: [Qemu-devel] [PATCH v11 0/7] virtio-balloon: free page hint support

2018-12-14 Thread Michael S. Tsirkin
On Tue, Dec 11, 2018 at 04:24:46PM +0800, Wei Wang wrote: > This is the deivce part implementation to add a new feature, > VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device > receives the guest free page hints from the driver and clears the > corresponding bits in the dirty

[Qemu-devel] [PATCH] target/arm: Convert ARM_TBFLAG_* to FIELDs

2018-12-14 Thread Richard Henderson
Use "register" TBFLAG_ANY to indicate shared state between A32 and A64, and "registers" TBFLAG_A32 & TBFLAG_A64 for fields that are specific to the given cpu state. Move ARM_TBFLAG_BE to shared state, instead of its current placement within "Bit usage when in AArch32 state". Signed-off-by:

Re: [Qemu-devel] [PATCH 2/2] avoid TABs in files that only contain a few

2018-12-14 Thread Eric Blake
On 12/13/18 4:37 PM, Paolo Bonzini wrote: Most files that have TABs only contain a handful of them. Change them to spaces so that we don't confuse people. disas, standard-headers, linux-headers and libdecnumber are imported from other projects and probably should be exempted from the check.

Re: [Qemu-devel] [PATCH v2] qdev/core: Can not replug device on bus that allows one device

2018-12-14 Thread Halil Pasic
On Thu, 13 Dec 2018 11:26:42 -0500 Tony Krowiak wrote: > If the maximum number of devices allowed on a bus is 1 and a device > which is plugged into the bus is subsequently unplugged, attempting to replug > the device fails with error "Bus 'xxx' does not support hotplugging". > The "error" is

Re: [Qemu-devel] [PATCH 2/3] Update that HMP 'cpu_add' is deprecated in 4.0

2018-12-14 Thread Kashyap Chamarthy
On Thu, Dec 13, 2018 at 09:03:23PM +0100, Thomas Huth wrote: > On 2018-12-13 13:42, Kashyap Chamarthy wrote: > > Also fix the wrong spelling of it: s/cpu-add/cpu_add/ > > > > Signed-off-by: Kashyap Chamarthy > > --- > > qemu-deprecated.texi | 4 ++-- > > 1 file changed, 2 insertions(+), 2

Re: [Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block

2018-12-14 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 14 Dec 2018 at 06:29, Markus Armbruster wrote: >> >> Paolo Bonzini writes: >> >> > On 13/12/18 19:21, Peter Maydell wrote: >> >> On Thu, 13 Dec 2018 at 18:07, Paolo Bonzini wrote: >> >>> On 13/12/18 19:01, Peter Maydell wrote: >> I sent a patch to do this

Re: [Qemu-devel] [PULL 0/8] Set minimum compiler versions to GCC 4.8 and Clang 3.4

2018-12-14 Thread Peter Maydell
On Wed, 12 Dec 2018 at 09:13, Thomas Huth wrote: > > Hi Peter, > > the following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11 > 19:18:58 +) > > are available in

Re: [Qemu-devel] [PATCH] hw/s390x: Fix bad mask in time2tod()

2018-12-14 Thread Thomas Huth
On 2018-12-14 14:26, Christian Borntraeger wrote: > > > On 14.12.2018 14:23, Thomas Huth wrote: >> On 2018-12-14 14:15, Christian Borntraeger wrote: >>> >>> >>> On 14.12.2018 14:08, Thomas Huth wrote: The time2tod() function tries to deal with the 9 uppermost bits in the time value,

Re: [Qemu-devel] [PATCH for-4.0 0/6] vhost-user-blk: Add support for backend reconnecting

2018-12-14 Thread Michael S. Tsirkin
On Fri, Dec 14, 2018 at 12:36:01PM +0800, Jason Wang wrote: > > On 2018/12/13 下午10:56, Michael S. Tsirkin wrote: > > On Thu, Dec 13, 2018 at 11:41:06AM +0800, Yongji Xie wrote: > > > On Thu, 13 Dec 2018 at 10:58, Jason Wang wrote: > > > > > > > > On 2018/12/12 下午5:18, Yongji Xie wrote: > > > >

Re: [Qemu-devel] [PATCH 2/2] avoid TABs in files that only contain a few

2018-12-14 Thread Peter Maydell
On Thu, 13 Dec 2018 at 22:38, Paolo Bonzini wrote: > > Most files that have TABs only contain a handful of them. Change > them to spaces so that we don't confuse people. > > disas, standard-headers, linux-headers and libdecnumber are imported > from other projects and probably should be exempted

[Qemu-devel] [PULL 00/15] Hardfloat + softfloat maintainers update and gitdm

2018-12-14 Thread Alex Bennée
The following changes since commit d8d5fefd8657d4f7b380b3a1533340434b5b9def: Merge remote-tracking branch 'remotes/berrange/tags/qcrypto-next-pull-request' into staging (2018-12-13 18:45:18 +) are available in the Git repository at: https://github.com/stsquad/qemu.git

[Qemu-devel] [PULL 06/15] softfloat: rename canonicalize to sf_canonicalize

2018-12-14 Thread Alex Bennée
From: "Emilio G. Cota" glibc >= 2.25 defines canonicalize in commit eaf5ad0 (Add canonicalize, canonicalizef, canonicalizel., 2016-10-26). Given that we'll be including soon, prepare for this by prefixing our canonicalize() with sf_ to avoid clashing with the libc's canonicalize().

[Qemu-devel] [PULL 13/15] hardfloat: implement float32/64 fused multiply-add

2018-12-14 Thread Alex Bennée
From: "Emilio G. Cota" Performance results for fp-bench: 1. Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz - before: fma-single: 74.73 MFlops fma-double: 74.54 MFlops - after: fma-single: 203.37 MFlops fma-double: 169.37 MFlops 2. ARM Aarch64 A57 @ 2.4GHz - before: fma-single: 23.24 MFlops

Re: [Qemu-devel] [PATCH for-3.2 v3 1/3] block/snapshot.c: eliminate use of ID input in snapshot operations

2018-12-14 Thread Dr. David Alan Gilbert
* Daniel Henrique Barboza (danielhb...@gmail.com) wrote: > At this moment, QEMU attempts to create/load/delete snapshots > by using either an ID (id_str) or a name. The problem is that the code > isn't consistent of whether the entered argument is an ID or a name, > causing unexpected behaviors. >

[Qemu-devel] [PATCH] Remove deprecated -enable-hax option

2018-12-14 Thread Thomas Huth
Our command line interface is really quite overcrowded, we should avoid duplicated options that do the same thing in just a slightly different way. "-accel hax" is shorter and more generic that "-enable-hax", so there is really no real usage for the latter option. "-enable-hax" has been deprecated

Re: [Qemu-devel] [PATCH] Remove deprecated -enable-hax option

2018-12-14 Thread Philippe Mathieu-Daudé
On 12/14/18 1:21 PM, Thomas Huth wrote: > Our command line interface is really quite overcrowded, we should avoid > duplicated options that do the same thing in just a slightly different > way. "-accel hax" is shorter and more generic that "-enable-hax", so > there is really no real usage for the

[Qemu-devel] [Bug 1735384] Re: OpenJDK JVM segfaults on qemu-sh4 (regression)

2018-12-14 Thread John Paul Adrian Glaubitz
This has been fixed now and Java works fine again on qemu-sh4 on git master: (sid-sh4-sbuild)root@nofan:/# java --version openjdk 10 2018-03-20 OpenJDK Runtime Environment (build 10+46-Debian-5) OpenJDK Zero VM (build 10+46-Debian-5, interpreted mode) (sid-sh4-sbuild)root@nofan:/# ** Changed in:

Re: [Qemu-devel] [Qemu-block] Request for clarification on qemu-img convert behavior zeroing target host_device

2018-12-14 Thread De Backer, Fred (Nokia - BE/Antwerp)
>Of course, we should also think about the other problem you mentioned, related >to copying a smaller image to a larger block device. Does this require zeroing >the parts after the image or should we leave them alone? > >I'd tend to say that since you're passing the whole block device as a

Re: [Qemu-devel] [PATCH v3 00/16] Virtio devices split from virtio-pci

2018-12-14 Thread Michael S. Tsirkin
On Fri, Dec 14, 2018 at 07:07:44AM +, Gonglei (Arei) wrote: > > > -Original Message- > > From: Juan Quintela [mailto:quint...@redhat.com] > > Sent: Friday, December 14, 2018 5:01 AM > > To: qemu-devel@nongnu.org > > Cc: Michael S. Tsirkin ; Thomas Huth ; > > Gerd Hoffmann ; Gonglei

Re: [Qemu-devel] [PATCH 12/15] s390-bios: Refactor virtio to run channel programs via cio

2018-12-14 Thread Cornelia Huck
On Wed, 12 Dec 2018 09:11:15 -0500 "Jason J. Herne" wrote: > Now that we have a Channel I/O library let's modify virtio boot code to > make use of it for running channel programs. > > Signed-off-by: Jason J. Herne > --- > pc-bios/s390-ccw/virtio.c | 21 ++--- > 1 file changed,

[Qemu-devel] [PATCH] hw/s390x: Fix bad mask in time2tod()

2018-12-14 Thread Thomas Huth
The time2tod() function tries to deal with the 9 uppermost bits in the time value, but uses the wrong mask for this: 0xff80 should be used instead of 0xff10 here. Fixes: 14055ce53c2d901d826ffad7fb7d6bb8ab46bdfd Signed-off-by: Thomas Huth --- include/hw/s390x/tod.h | 2 +-

[Qemu-devel] [PATCH v5 2/2] memory-device: rewrite address assignment using ranges

2018-12-14 Thread David Hildenbrand
Let's rewrite it properly using ranges. This fixes certain overflows that are right now possible. E.g. qemu-system-x86_64 -m 4G,slots=20,maxmem=40G -M pc \ -object memory-backend-file,id=mem1,share,mem-path=/dev/zero,size=2G -device pc-dimm,memdev=mem1,id=dimm1,addr=-0x4000 Now

Re: [Qemu-devel] [PATCH] hw/s390x: Fix bad mask in time2tod()

2018-12-14 Thread Thomas Huth
On 2018-12-14 14:15, Christian Borntraeger wrote: > > > On 14.12.2018 14:08, Thomas Huth wrote: >> The time2tod() function tries to deal with the 9 uppermost bits in the >> time value, but uses the wrong mask for this: 0xff80 should >> be used instead of 0xff10 here. >>

Re: [Qemu-devel] [PATCH 0/2] Fix TABs in many files

2018-12-14 Thread Wainer dos Santos Moschetta
On 12/13/2018 08:37 PM, Paolo Bonzini wrote: Space-tab sequences at the beginning of the line are always a mistake, so patch 1 fixes them. I am not touching space-tab in the middle of the line, many of which are in #define lines. In addition, about a third of the files with TABs have only a

  1   2   3   >