Re: [Qemu-devel] [PULL 00/24] target/hppa patch queue

2019-02-12 Thread Peter Maydell
On Tue, 12 Feb 2019 at 04:57, Richard Henderson wrote: > > The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into > staging (2019-02-11 17:04:57 +) > > are available in the Git repository at: >

Re: [Qemu-devel] [PATCH v2] virtio-blk: set correct config size for the host driver

2019-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 02:01:44PM +0800, Changpeng Liu wrote: > Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features support" > introduced extra fields to existing struct virtio_blk_config, when > migration was executed from older QEMU version to current head, it > will break the

[Qemu-devel] [RFC PULL 2/6] virtio-blk: add host_features field in VirtIOBlock

2019-02-12 Thread Stefan Hajnoczi
From: Stefano Garzarella Since configurable features for virtio-blk are growing, this patch adds host_features field in the struct VirtIOBlock. (as in virtio-net) In this way, we can avoid to add new fields for new properties and we can directly set VIRTIO_BLK_F* flags in the host_features. We

[Qemu-devel] [RFC PULL 0/6] Block pull request for testing

2019-02-12 Thread Stefan Hajnoczi
Peter hit a virtio-blk-test failure caused by the new DISCARD/WRITE_ZEROES patches that Stefano and I have been unable to reproduce. Here are the patches so they can be tested again in Peter's environment. Stefano Garzarella (6): virtio-blk: add acct_failed param to

Re: [Qemu-devel] [PATCH 0/4] a few trivials

2019-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 01:47:54PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Just cleaning out my trivial pile; a few more traces and > a couple of error reporting tweaks. > > Dave Looks sane Reviewed-by: Michael S. Tsirkin > > Dr. David Alan Gilbert

[Qemu-devel] [PATCH 2/3] contrib/vhost-user-blk: fix the compilation issue

2019-02-12 Thread Philippe Mathieu-Daudé
From: Changpeng Liu Signed-off-by: Changpeng Liu Reviewed-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella Reviewed-by: Michael S. Tsirkin Message-Id: <1547615970-23545-2-git-send-email-changpeng@intel.com> [PMD: this patch was first (incorrectly) introduced as a56de056c91f8]

Re: [Qemu-devel] [PATCH 3/4] kvm: Add kvm_set_ioeventfd* traces

2019-02-12 Thread Philippe Mathieu-Daudé
On 2/12/19 2:47 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add a couple of traces around the kvm_set_ioeventfd* calls. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé > --- > accel/kvm/kvm-all.c| 3 +++ >

[Qemu-devel] [RFC PULL 1/6] virtio-blk: add acct_failed param to virtio_blk_handle_rw_error()

2019-02-12 Thread Stefan Hajnoczi
From: Stefano Garzarella We add acct_failed param in order to use virtio_blk_handle_rw_error() also when is not required to call block_acct_failed(). (eg. a discard operation is failed) Reviewed-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefano Garzarella Acked-by:

[Qemu-devel] [PATCH v3] virtio-blk: set correct config size for the host driver

2019-02-12 Thread Changpeng Liu
Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features support" added fields to struct virtio_blk_config. This changes the size of the config space and breaks migration from QEMU 3.1 and older: qemu-system-ppc64: get_pci_config_device: Bad config data: i=0x10 read: 41 device: 1

Re: [Qemu-devel] [PATCH] s390x/kvm: add tracepoint to ioeventfd interface

2019-02-12 Thread Philippe Mathieu-Daudé
Hi Cornelia, On 2/12/19 4:30 PM, Cornelia Huck wrote: > Trace when assigning/unassigning. > > Signed-off-by: Cornelia Huck > --- > target/s390x/kvm.c| 2 ++ > target/s390x/trace-events | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c >

Re: [Qemu-devel] [PATCH 23/25] hw/arm: Express dependencies of the ZynqMP zcu102 machine with Kconfig

2019-02-12 Thread Thomas Huth
On 2019-02-11 15:45, Paolo Bonzini wrote: > On 09/02/19 07:39, Thomas Huth wrote: >> +select PCI # TODO: Currently required for SDHCI and AHCI, remove >> later > > I think SDHCI and AHCI should select it instead, similar to how FDC > selects ISA_BUS (see patch 25 of the Kconfig series).

Re: [Qemu-devel] [PATCH v3 1/2] pcie: Add a simple PCIe ACS (Access Control Services) helper function

2019-02-12 Thread Knut Omang
On Tue, 2019-02-12 at 08:59 -0700, Alex Williamson wrote: > On Tue, 12 Feb 2019 09:07:43 +0100 > Knut Omang wrote: > > > On Mon, 2019-02-11 at 16:09 -0700, Alex Williamson wrote: > > > On Sun, 10 Feb 2019 07:52:59 +0100 > > > Knut Omang wrote: > > > > > > > Add a helper function to add PCIe

Re: [Qemu-devel] [PULL 00/25] pci, pc, virtio: fixes, cleanups, features

2019-02-12 Thread Philippe Mathieu-Daudé
On 2/12/19 2:04 PM, Michael S. Tsirkin wrote: > On Tue, Feb 12, 2019 at 11:39:21AM +0100, Philippe Mathieu-Daudé wrote: >> On 2/12/19 8:11 AM, Peter Xu wrote: >>> On Tue, Feb 05, 2019 at 11:06:42AM -0500, Michael S. Tsirkin wrote: OK I reverted the whole part dealing with vhost-user and

[Qemu-devel] [PATCH 1/3] Revert "contrib/vhost-user-blk: fix the compilation issue"

2019-02-12 Thread Philippe Mathieu-Daudé
Commit a56de056c91f8 squashed the following two unrelated commits at once: - "contrib/vhost-user-blk: fix the compilation issue" (Message-Id: 1547615970-23545-2-git-send-email-changpeng@intel.com) - "i386/kvm: ignore masked irqs when update msi routes" (Message-Id:

[Qemu-devel] [RFC PULL 5/6] tests/virtio-blk: change assert on data_size in virtio_blk_request()

2019-02-12 Thread Stefan Hajnoczi
From: Stefano Garzarella The size of data in the virtio_blk_request must be a multiple of 512 bytes for IN and OUT requests, or a multiple of the size of struct virtio_blk_discard_write_zeroes for DISCARD and WRITE_ZEROES requests. Reviewed-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 3/4] kvm: Add kvm_set_ioeventfd* traces

2019-02-12 Thread Cornelia Huck
On Tue, 12 Feb 2019 13:47:57 + "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Add a couple of traces around the kvm_set_ioeventfd* calls. > > Signed-off-by: Dr. David Alan Gilbert > --- > accel/kvm/kvm-all.c| 3 +++ > accel/kvm/trace-events | 2 ++ > 2

Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer()

2019-02-12 Thread Philippe Mathieu-Daudé
On 2/12/19 2:43 PM, Liam Merwick wrote: > On 12/02/2019 13:27, Stefan Berger wrote: >> On 2/12/19 7:31 AM, Philippe Mathieu-Daudé wrote: >>> On 2/11/19 10:13 PM, Stefan Berger wrote: On 2/11/19 3:09 PM, Liam Merwick wrote: > On 11/02/2019 19:56, Stefan Berger wrote: >> On 2/11/19

Re: [Qemu-devel] [v3 PATCH] hw/arm/bcm2835_peripherals: add bcm283x sp804-alike timer

2019-02-12 Thread Mark
Hi Andrew, Thanks for reviewing the patch I've submitted. I've already messed up two and this is my first time contributing to any open-source software. ☺ I've checked the implementation you suggested and I think it would be a great example for me to implement free-running counters, too. Best

[Qemu-devel] [PATCH] s390x/kvm: add tracepoint to ioeventfd interface

2019-02-12 Thread Cornelia Huck
Trace when assigning/unassigning. Signed-off-by: Cornelia Huck --- target/s390x/kvm.c| 2 ++ target/s390x/trace-events | 1 + 2 files changed, 3 insertions(+) diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c index 15fdc168e1c5..7d61bd109092 100644 --- a/target/s390x/kvm.c +++

[Qemu-devel] [PATCH 1/2] slirp: remove slirp_ prefix for socket wrappers

2019-02-12 Thread Marc-André Lureau
QEMU wraps the socket functions in os-win32.h, but in commit a9d8b3ec4385793815d71217857304, the header inclusion was dropped, breaking libslirp on Windows. There are already a few socket functions that are wrapped in libslirp, with "slirp_" prefix, but many of them are missing, and we are going

[Qemu-devel] [PATCH 0/2] Fix slirp regression on win32

2019-02-12 Thread Marc-André Lureau
Hi, QEMU wraps the socket functions in os-win32.h, but in commit a9d8b3ec4385793815d71217857304, the header inclusion was dropped, breaking slirp on Windows. Fix the regression by wrapping all the socket functions. thanks Marc-André Lureau (2): slirp: remove slirp_ prefix for socket wrappers

[Qemu-devel] [PATCH 3/7] slirp: use "slirp_" prefix for inet_aton() win32 implementation

2019-02-12 Thread Marc-André Lureau
To avoid conflict with QEMU inet_aton() implementation, let's use the "slirp_" prefix. This allows to drop the WITH_QEMU, thus the source won't make a distinction when building with QEMU or not. Signed-off-by: Marc-André Lureau --- slirp/util.h| 4 ++-- slirp/util.c| 4 ++--

[Qemu-devel] [PATCH 7/7] slirp: remove QEMU Makefile.objs

2019-02-12 Thread Marc-André Lureau
QEMU no longer includes it, and treats slirp/ as a separate project. Signed-off-by: Marc-André Lureau --- slirp/Makefile.objs | 36 1 file changed, 36 deletions(-) delete mode 100644 slirp/Makefile.objs diff --git a/slirp/Makefile.objs

Re: [Qemu-devel] [RFC PULL 0/6] Block sgarzare test patches

2019-02-12 Thread Peter Maydell
On Tue, 12 Feb 2019 at 14:12, Stefan Hajnoczi wrote: > > Block pull request for testing > > Peter hit a virtio-blk-test failure caused by the new DISCARD/WRITE_ZEROES > patches that Stefano and I have been unable to reproduce. Here

Re: [Qemu-devel] [PULL 00/25] pci, pc, virtio: fixes, cleanups, features

2019-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 11:39:21AM +0100, Philippe Mathieu-Daudé wrote: > On 2/12/19 8:11 AM, Peter Xu wrote: > > On Tue, Feb 05, 2019 at 11:06:42AM -0500, Michael S. Tsirkin wrote: > >> > >> OK I reverted the whole part dealing with vhost-user and reposted. > > > > I noticed that the merged pull

Re: [Qemu-devel] [PATCH 10/15] s390-bios: Support for running format-0/1 channel programs

2019-02-12 Thread Halil Pasic
On Tue, 5 Feb 2019 11:18:38 +0100 Cornelia Huck wrote: > On Mon, 4 Feb 2019 14:29:18 -0500 > Farhan Ali wrote: > > > On 02/04/2019 06:13 AM, Cornelia Huck wrote: > > > On Thu, 31 Jan 2019 12:31:00 -0500 > > > Farhan Ali wrote: > > > > > >> On 01/29/2019 08:29 AM, Jason J. Herne wrote: >

Re: [Qemu-devel] Key repeat is no longer working on TTY and grub menu

2019-02-12 Thread Daniel P . Berrangé
On Tue, Feb 12, 2019 at 01:02:42PM +, Leonardo Soares Müller wrote: > I noticed that the key inputs are no longer repeating when using default > setting on QEMU. For example, if I press "a" and keep it pressed it will > print only one "a" instead of repeating them. Another example is when >

Re: [Qemu-devel] [PATCH v2] s390x: add zPCI feature to "qemu" CPU model

2019-02-12 Thread Cornelia Huck
On Tue, 12 Feb 2019 12:23:23 +0100 David Hildenbrand wrote: > As we now always have PCI support, let's add it to the "qemu" CPU model, > taking care of backwards compatibility. > > Signed-off-by: David Hildenbrand > --- > > v1 -> v2: > - Use correct model identifiction of the z12 we emulate >

Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer()

2019-02-12 Thread Liam Merwick
On 12/02/2019 13:27, Stefan Berger wrote: On 2/12/19 7:31 AM, Philippe Mathieu-Daudé wrote: On 2/11/19 10:13 PM, Stefan Berger wrote: On 2/11/19 3:09 PM, Liam Merwick wrote: On 11/02/2019 19:56, Stefan Berger wrote: On 2/11/19 11:02 AM, Philippe Mathieu-Daudé wrote: On 2/11/19 4:03 PM, Liam

[Qemu-devel] [PATCH 3/3] i386/kvm: ignore masked irqs when update msi routes

2019-02-12 Thread Philippe Mathieu-Daudé
From: Peter Xu When we are with intel-iommu device and with IR on, KVM will register an IEC notifier to detect interrupt updates from the guest and we'll kick off kvm_update_msi_routes_all() when it happens to make sure kernel IRQ cache is matching the latest. Though,

[Qemu-devel] [PATCH] chardev/wctablet: Fix a typo

2019-02-12 Thread Philippe Mathieu-Daudé
The correct name is Wacom. Fix the typo present this the origin of this file (378af96155d). Signed-off-by: Philippe Mathieu-Daudé --- chardev/wctablet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chardev/wctablet.c b/chardev/wctablet.c index 969d014574..35dbd29a33

[Qemu-devel] [PATCH] hw/dma/i8257: Use qemu_log_mask(UNIMP) instead of fprintf

2019-02-12 Thread Philippe Mathieu-Daudé
Avoid to clutter stdout until explicitly requested (with -d unimp): $ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin dma: command df not supported dma: command df not supported dma: command df not supported dma: command df not supported Signed-off-by: Philippe Mathieu-Daudé ---

[Qemu-devel] [PATCH 4/7] slirp: move sources to src/ subdirectory

2019-02-12 Thread Marc-André Lureau
Prepare for making slirp/ a standalone project. Remove some useless includes while at it. Signed-off-by: Marc-André Lureau --- slirp/{ => src}/bootp.h | 0 slirp/{ => src}/debug.h | 0 slirp/{ => src}/dhcpv6.h | 0 slirp/{ => src}/if.h | 0 slirp/{ => src}/ip.h

Re: [Qemu-devel] [PATCH 07/13] block: Allow omitting the 'backing' option in certain cases

2019-02-12 Thread Kevin Wolf
Am 17.01.2019 um 16:33 hat Alberto Garcia geschrieben: > Of all options of type BlockdevRef used to specify children in > BlockdevOptions, 'backing' is the only one that is optional. > > For "x-blockdev-reopen" we want that if an option is omitted then it > must be reset to its default value. The

Re: [Qemu-devel] [PATCH v1 4/9] {monitor, hw/pvrdma}: Expose device internals via monitor interface

2019-02-12 Thread Yuval Shaia
On Sun, Feb 10, 2019 at 12:45:32PM +0200, Yuval Shaia wrote: > Allow interrogating device internals through HMP interface. > The exposed indicators can be used for troubleshooting by developers or > sysadmin. > There is no need to expose these attributes to a management system (e.x. > libvirt)

Re: [Qemu-devel] [PATCH 0/2] Fix slirp regression on win32

2019-02-12 Thread Howard Spoelstra
On Tue, Feb 12, 2019 at 5:09 PM Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > Hi, > > QEMU wraps the socket functions in os-win32.h, but in commit > a9d8b3ec4385793815d71217857304, the header inclusion was dropped, > breaking slirp on Windows. Fix the regression by wrapping all the >

Re: [Qemu-devel] [PATCH] hw/arm/armsse: Fix miswiring of expansion IRQs

2019-02-12 Thread Philippe Mathieu-Daudé
On 2/12/19 12:06 PM, Peter Maydell wrote: > On Tue, 12 Feb 2019 at 11:05, Philippe Mathieu-Daudé > wrote: >> On 2/12/19 11:52 AM, Peter Maydell wrote: >>> In commit 91c1e9fcbd7548db368 where we added dual-CPU support to >>> the ARMSSE, we set up the wiring of the expansion IRQs via nested >>>

Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer()

2019-02-12 Thread Stefan Berger
On 2/12/19 7:31 AM, Philippe Mathieu-Daudé wrote: On 2/11/19 10:13 PM, Stefan Berger wrote: On 2/11/19 3:09 PM, Liam Merwick wrote: On 11/02/2019 19:56, Stefan Berger wrote: On 2/11/19 11:02 AM, Philippe Mathieu-Daudé wrote: On 2/11/19 4:03 PM, Liam Merwick wrote: [...] -

Re: [Qemu-devel] [PULL 00/25] pci, pc, virtio: fixes, cleanups, features

2019-02-12 Thread Philippe Mathieu-Daudé
On 2/12/19 2:24 PM, Michael S. Tsirkin wrote: > On Tue, Feb 12, 2019 at 02:15:36PM +0100, Philippe Mathieu-Daudé wrote: >> On 2/12/19 2:04 PM, Michael S. Tsirkin wrote: >>> On Tue, Feb 12, 2019 at 11:39:21AM +0100, Philippe Mathieu-Daudé wrote: On 2/12/19 8:11 AM, Peter Xu wrote: > On

[Qemu-devel] [RFC PULL 4/6] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-12 Thread Stefan Hajnoczi
From: Stefano Garzarella This patch adds the support of DISCARD and WRITE_ZEROES commands, that have been introduced in the virtio-blk protocol to have better performance when using SSD backend. We support only one segment per request since multiple segments are not widely used and there are no

[Qemu-devel] [RFC PULL 6/6] tests/virtio-blk: add test for WRITE_ZEROES command

2019-02-12 Thread Stefan Hajnoczi
From: Stefano Garzarella If the WRITE_ZEROES feature is enabled, we check this command in the test_basic(). Reviewed-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Acked-by: Thomas Huth Signed-off-by: Stefano Garzarella Acked-by: Pankaj Gupta Message-id:

[Qemu-devel] [RFC PULL 1/6] virtio-blk: add acct_failed param to virtio_blk_handle_rw_error()

2019-02-12 Thread Stefan Hajnoczi
From: Stefano Garzarella We add acct_failed param in order to use virtio_blk_handle_rw_error() also when is not required to call block_acct_failed(). (eg. a discard operation is failed) Reviewed-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefano Garzarella Acked-by:

[Qemu-devel] [RFC PULL 3/6] virtio-blk: add "discard" and "write-zeroes" properties

2019-02-12 Thread Stefan Hajnoczi
From: Stefano Garzarella In order to avoid migration issues, we enable DISCARD and WRITE_ZEROES features only for machine type >= 4.0 As discussed with Michael S. Tsirkin and Stefan Hajnoczi on the list [1], DISCARD operation should not have security implications (eg. page cache attacks), so we

Re: [Qemu-devel] [PATCH v3 1/2] pcie: Add a simple PCIe ACS (Access Control Services) helper function

2019-02-12 Thread Alex Williamson
On Tue, 12 Feb 2019 09:07:43 +0100 Knut Omang wrote: > On Mon, 2019-02-11 at 16:09 -0700, Alex Williamson wrote: > > On Sun, 10 Feb 2019 07:52:59 +0100 > > Knut Omang wrote: > > > > > Add a helper function to add PCIe capability for Access Control Services > > > (ACS) > > > ACS support in

Re: [Qemu-devel] [PATCH 22/25] hw/arm: Express dependencies of nrf51 Kconfig

2019-02-12 Thread Thomas Huth
On 2019-02-11 18:37, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 2/9/19 7:39 AM, Thomas Huth wrote: >> Add Kconfig dependencies for the NRF51 / microbit machine. >> >> Signed-off-by: Thomas Huth >> --- >> hw/arm/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git

[Qemu-devel] [PATCH 0/7] slirp: make it a standalone project

2019-02-12 Thread Marc-André Lureau
Hi, As discussed earlier in "[PATCH for-3.2 00/41] RFC: slirp: make it again a standalone project" and other threads, it would be useful to make slirp a separate project. In the previous thread "[PATCH slirp 0/5] Make it a standalone project", it was recommended by Peter that we keep the

Re: [Qemu-devel] [Qemu-ppc] [PATCH] cuda: decrease time delay before raising VIA SR interrupt

2019-02-12 Thread Mark Cave-Ayland
On 12/02/2019 11:03, BALATON Zoltan wrote: > On Tue, 12 Feb 2019, Mark Cave-Ayland wrote: >> On 11/02/2019 23:35, Philippe Mathieu-Daudé wrote: >> >>> Hi Mark, >>> >>> On 2/10/19 6:44 PM, Mark Cave-Ayland wrote: In order to handle a race condition in MacOS 9, a delay was introduced when

Re: [Qemu-devel] [qemu-s390x] [PATCH 06/15] s390-bios: Clean up cio.h

2019-02-12 Thread Thomas Huth
On 2019-02-04 11:48, Cornelia Huck wrote: > On Tue, 29 Jan 2019 08:29:13 -0500 > "Jason J. Herne" wrote: > >> Add proper typedefs to all structs and modify all bit fields to use >> consistent >> formatting. >> >> Signed-off-by: Jason J. Herne >> Reviewed-by: Collin Walling >> --- >>

Re: [Qemu-devel] [PULL 1/7] audio: fix pc speaker init

2019-02-12 Thread David Hildenbrand
On 12.02.19 13:20, David Hildenbrand wrote: > On 12.02.19 13:08, Philippe Mathieu-Daudé wrote: >> Hi David, >> >> On 2/12/19 12:47 PM, David Hildenbrand wrote: >>> On 24.01.19 14:20, Gerd Hoffmann wrote: Get rid of the pcspk_state global, allow pc speaker be added using "-device

Re: [Qemu-devel] [PULL 0/3] Block patches

2019-02-12 Thread Peter Maydell
On Tue, 12 Feb 2019 at 04:01, Stefan Hajnoczi wrote: > > The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into > staging (2019-02-11 17:04:57 +) > > are available in the Git repository at: > >

[Qemu-devel] [Bug 1808928] Re: Bitmap Extra data is not supported

2019-02-12 Thread Ali Sag
as far as i know nothing happened. it had worked normally while instance was running. For a reason, instance is shutdown, then it never open again. i have some backups, i tried to return previous backups. But they also gave same error. Thanks to replication i could get it back. i copied image from

Re: [Qemu-devel] [PULL 00/25] pci, pc, virtio: fixes, cleanups, features

2019-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 02:15:36PM +0100, Philippe Mathieu-Daudé wrote: > On 2/12/19 2:04 PM, Michael S. Tsirkin wrote: > > On Tue, Feb 12, 2019 at 11:39:21AM +0100, Philippe Mathieu-Daudé wrote: > >> On 2/12/19 8:11 AM, Peter Xu wrote: > >>> On Tue, Feb 05, 2019 at 11:06:42AM -0500, Michael S.

Re: [Qemu-devel] [PATCH v2 4/4] migration: Add capabilities validation

2019-02-12 Thread Yury Kotov
11.02.2019, 16:30, "Dr. David Alan Gilbert" : > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: >>  Currently we don't check which capabilities set in the source QEMU. >>  We just expect that the target QEMU has the same enabled capabilities. >> >>  Add explicit validation for capabilities to make

[Qemu-devel] [RFC PULL 3/6] virtio-blk: add "discard" and "write-zeroes" properties

2019-02-12 Thread Stefan Hajnoczi
From: Stefano Garzarella In order to avoid migration issues, we enable DISCARD and WRITE_ZEROES features only for machine type >= 4.0 As discussed with Michael S. Tsirkin and Stefan Hajnoczi on the list [1], DISCARD operation should not have security implications (eg. page cache attacks), so we

[Qemu-devel] [RFC PULL 0/6] Block sgarzare test patches

2019-02-12 Thread Stefan Hajnoczi
The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into staging (2019-02-11 17:04:57 +) are available in the Git repository at: git://github.com/stefanha/qemu.git

[Qemu-devel] [RFC PULL 5/6] tests/virtio-blk: change assert on data_size in virtio_blk_request()

2019-02-12 Thread Stefan Hajnoczi
From: Stefano Garzarella The size of data in the virtio_blk_request must be a multiple of 512 bytes for IN and OUT requests, or a multiple of the size of struct virtio_blk_discard_write_zeroes for DISCARD and WRITE_ZEROES requests. Reviewed-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 01/13] block: Allow freezing BdrvChild links

2019-02-12 Thread Kevin Wolf
Am 17.01.2019 um 16:33 hat Alberto Garcia geschrieben: > Our permission system is useful to define what operations are allowed > on a certain block node and includes things like BLK_PERM_WRITE or > BLK_PERM_RESIZE among others. > > One of the permissions is BLK_PERM_GRAPH_MOD which allows

Re: [Qemu-devel] [PATCH v3] virtio-blk: set correct config size for the host driver

2019-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 11:19:49PM +0800, Changpeng Liu wrote: > Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features > support" added fields to struct virtio_blk_config. This changes > the size of the config space and breaks migration from QEMU 3.1 > and older: > >

[Qemu-devel] [PATCH 2/2] slirp: wrap the remaining socket functions

2019-02-12 Thread Marc-André Lureau
QEMU wraps the socket functions in os-win32.h, but in commit a9d8b3ec4385793815d71217857304, the header inclusion was dropped, breaking libslirp on Windows. Wrap the missing functions. Rename the wrapped function with "slirp_" prefix and "_wrap" suffix, for consistency and to avoid a clash with

[Qemu-devel] [PATCH 2/7] slirp: use libslirp migration code

2019-02-12 Thread Marc-André Lureau
slirp migration code uses QEMU vmstate so far, when building WITH_QEMU. Introduce slirp_state_{load,save,version}() functions to move the state saving handling to libslirp side. So far, the bitstream compatibility should remain equal with current QEMU, as this is effectively using the same code,

Re: [Qemu-devel] [PATCH v2] virtio-blk: set correct config size for the host driver

2019-02-12 Thread Greg Kurz
On Tue, 12 Feb 2019 14:01:44 +0800 Changpeng Liu wrote: > Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features support" > introduced extra fields to existing struct virtio_blk_config, when > migration was executed from older QEMU version to current head, it A hint about the

[Qemu-devel] [PATCH 4/4] wavcapture: Convert to error_report

2019-02-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Kill off a pile of monitor_printf's and cur_mon usage. The only one left in wavcapture.c is the info case. Signed-off-by: Dr. David Alan Gilbert --- audio/wavcapture.c | 39 +-- 1 file changed, 17 insertions(+), 22

Re: [Qemu-devel] [PATCH] hostmem-file: reject invalid pmem file sizes

2019-02-12 Thread Igor Mammedov
On Tue, 12 Feb 2019 10:52:41 +0800 Stefan Hajnoczi wrote: > Guests started with NVDIMMs larger than the underlying host file produce > confusing errors inside the guest. This happens because the guest > accesses pages beyond the end of the file. > > Check the pmem file size on startup and

Re: [Qemu-devel] [PATCH] s390x/kvm: add tracepoint to ioeventfd interface

2019-02-12 Thread David Hildenbrand
On 12.02.19 16:58, Cornelia Huck wrote: > On Tue, 12 Feb 2019 16:52:09 +0100 > Philippe Mathieu-Daudé wrote: > >> Hi Cornelia, >> >> On 2/12/19 4:30 PM, Cornelia Huck wrote: >>> Trace when assigning/unassigning. >>> >>> Signed-off-by: Cornelia Huck >>> --- >>> target/s390x/kvm.c| 2 ++

[Qemu-devel] [PATCH 1/7] slirp: adapt a subset of QEMU vmstate code

2019-02-12 Thread Marc-André Lureau
Add vmstate serialization code adapted from QEMU. Keep only the bits that are required for libslirp. Introduce a IStream/OStream interface to replace QEMU QFile abstraction. Signed-off-by: Marc-André Lureau --- slirp/libslirp.h| 1 + slirp/stream.h | 34 slirp/vmstate.h |

[Qemu-devel] [PATCH] linux-user: fix recvmsg emulation

2019-02-12 Thread Andreas Schwab
Set msg_flags in the returned struct msghdr. Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 90bfda3563..b6b566a6fa 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@

[Qemu-devel] Key repeat is no longer working on TTY and grub menu

2019-02-12 Thread Leonardo Soares Müller
I noticed that the key inputs are no longer repeating when using default setting on QEMU. For example, if I press "a" and keep it pressed it will print only one "a" instead of repeating them. Another example is when deleting text: instead of holding backspace pressed and the text is deleted, it's

[Qemu-devel] [PATCH 1/4] pckbd: Convert DPRINTF->trace

2019-02-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert --- hw/input/pckbd.c | 19 ++- hw/input/trace-events | 7 +++ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c index 72e7d5f6cc..47a606f5e3 100644

[Qemu-devel] [PATCH 3/4] kvm: Add kvm_set_ioeventfd* traces

2019-02-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add a couple of traces around the kvm_set_ioeventfd* calls. Signed-off-by: Dr. David Alan Gilbert --- accel/kvm/kvm-all.c| 3 +++ accel/kvm/trace-events | 2 ++ 2 files changed, 5 insertions(+) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index

[Qemu-devel] [PATCH 0/4] a few trivials

2019-02-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Just cleaning out my trivial pile; a few more traces and a couple of error reporting tweaks. Dave Dr. David Alan Gilbert (4): pckbd: Convert DPRINTF->trace HMP: Prepend errors with 'Error:' kvm: Add kvm_set_ioeventfd* traces wavcapture: Convert to

Re: [Qemu-devel] [PATCH 2/4] HMP: Prepend errors with 'Error:'

2019-02-12 Thread Philippe Mathieu-Daudé
On 2/12/19 2:47 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Always make error messages start with 'Error:' as a fallback > to make sure that anything parsing them can tell it failed. > > Note: Some places don't use hmp_handle_error > > Signed-off-by: Dr. David

[Qemu-devel] [RFC PULL 2/6] virtio-blk: add host_features field in VirtIOBlock

2019-02-12 Thread Stefan Hajnoczi
From: Stefano Garzarella Since configurable features for virtio-blk are growing, this patch adds host_features field in the struct VirtIOBlock. (as in virtio-net) In this way, we can avoid to add new fields for new properties and we can directly set VIRTIO_BLK_F* flags in the host_features. We

Re: [Qemu-devel] [PATCH 1/4] pckbd: Convert DPRINTF->trace

2019-02-12 Thread Philippe Mathieu-Daudé
On 2/12/19 2:47 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Signed-off-by: Dr. David Alan Gilbert Per https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg03186.html this one already has: Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH] target/i386: Generate #UD when applying LOCK to a register

2019-02-12 Thread Paolo Bonzini
On 07/12/18 18:09, Richard Henderson wrote: > This covers inc, dec, and the bit test instructions. > > I believe we've finally covered all of the cases for > which we have an atomic path that would use the cpu_A0 > temp, which is only initialized for address sources. > > Fixes:

Re: [Qemu-devel] [PATCH v4 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-12 Thread Michael S. Tsirkin
On Fri, Feb 08, 2019 at 02:49:44PM +0100, Stefano Garzarella wrote: > This series adds the support of DISCARD and WRITE_ZEROES commands > and extends the virtio-blk-test to test WRITE_ZEROES command when > the feature is enabled. Looking at how this wasn't merged yet, maybe it's not too late.

Re: [Qemu-devel] [PATCH 02/13] block: Freeze the backing chain for the duration of the commit job

2019-02-12 Thread Kevin Wolf
Am 17.01.2019 um 16:33 hat Alberto Garcia geschrieben: > Signed-off-by: Alberto Garcia > --- > block/commit.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/block/commit.c b/block/commit.c > index 53148e610b..8824d135e0 100644 > --- a/block/commit.c > +++ b/block/commit.c > @@

Re: [Qemu-devel] [PATCH v2] virtio-blk: set correct config size for the host driver

2019-02-12 Thread Liu, Changpeng
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, February 12, 2019 9:49 PM > To: Liu, Changpeng > Cc: qemu-devel@nongnu.org; stefa...@redhat.com; sgarz...@redhat.com; > dgilb...@redhat.com; ldok...@redhat.com > Subject: Re: [PATCH v2]

Re: [Qemu-devel] [Qemu-block] [PATCH 06/13] block: Handle child references in bdrv_reopen_queue()

2019-02-12 Thread Kevin Wolf
Am 12.02.2019 um 17:28 hat Kevin Wolf geschrieben: > > -child_key_dot = g_strdup_printf("%s.", child->name); > > -qdict_extract_subqdict(explicit_options, NULL, child_key_dot); > > -qdict_extract_subqdict(options, _child_options, child_key_dot); > > -

Re: [Qemu-devel] [PULL 1/7] audio: fix pc speaker init

2019-02-12 Thread David Hildenbrand
On 12.02.19 13:08, Philippe Mathieu-Daudé wrote: > Hi David, > > On 2/12/19 12:47 PM, David Hildenbrand wrote: >> On 24.01.19 14:20, Gerd Hoffmann wrote: >>> Get rid of the pcspk_state global, allow pc speaker >>> be added using "-device isa-pcspk". >>> >>> Signed-off-by: Gerd Hoffmann >>>

Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer()

2019-02-12 Thread Philippe Mathieu-Daudé
On 2/11/19 10:13 PM, Stefan Berger wrote: > On 2/11/19 3:09 PM, Liam Merwick wrote: >> On 11/02/2019 19:56, Stefan Berger wrote: >>> On 2/11/19 11:02 AM, Philippe Mathieu-Daudé wrote: On 2/11/19 4:03 PM, Liam Merwick wrote: [...] > -printf("tpm_tis: %s length = %d\n", string, len);

[Qemu-devel] [RFC PULL 4/6] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-12 Thread Stefan Hajnoczi
From: Stefano Garzarella This patch adds the support of DISCARD and WRITE_ZEROES commands, that have been introduced in the virtio-blk protocol to have better performance when using SSD backend. We support only one segment per request since multiple segments are not widely used and there are no

Re: [Qemu-devel] [PATCH] chardev/wctablet: Fix a typo

2019-02-12 Thread Marc-André Lureau
On Tue, Feb 12, 2019 at 4:12 PM Philippe Mathieu-Daudé wrote: > > The correct name is Wacom. > Fix the typo present this the origin of this file (378af96155d). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau > --- > chardev/wctablet.c | 2 +- > 1 file changed, 1

Re: [Qemu-devel] [PATCH] s390x/kvm: add tracepoint to ioeventfd interface

2019-02-12 Thread Cornelia Huck
On Tue, 12 Feb 2019 16:52:09 +0100 Philippe Mathieu-Daudé wrote: > Hi Cornelia, > > On 2/12/19 4:30 PM, Cornelia Huck wrote: > > Trace when assigning/unassigning. > > > > Signed-off-by: Cornelia Huck > > --- > > target/s390x/kvm.c| 2 ++ > > target/s390x/trace-events | 1 + > > 2

Re: [Qemu-devel] [PATCH 06/13] block: Handle child references in bdrv_reopen_queue()

2019-02-12 Thread Kevin Wolf
Am 17.01.2019 um 16:33 hat Alberto Garcia geschrieben: > Children in QMP are specified with BlockdevRef / BlockdevRefOrNull, > which can contain a set of child options, a child reference, or > NULL. In optional attributes like "backing" it can also be missing. > > Only the first case (set of

[Qemu-devel] [PATCH] Discard old bitmap directories in QCOW2 image

2019-02-12 Thread Andrey Shinkevich
Clean QCOW2 image from bitmap obsolete directory when a new one is allocated and stored. It slows down the image growth a little bit. The flag QCOW2_DISCARD_ALWAYS allows a call to raw_co_pdiscard() that does the actual cleaning of the image on disk. With the flag QCOW2_DISCARD_OTHER, a reference

Re: [Qemu-devel] [qemu-s390x] [PATCH 09/15] s390-bios: ptr2u32 and u32toptr

2019-02-12 Thread Thomas Huth
On 2019-01-29 14:29, Jason J. Herne wrote: > Introduce inline functions to convert between pointers and unsigned 32-bit > ints. These are used to hide the ugliness required to avoid compiler > warnings. > > Signed-off-by: Jason J. Herne > --- > pc-bios/s390-ccw/libc.h | 12 > 1

Re: [Qemu-devel] [qemu-s390x] [PATCH 08/15] s390-bios: Map low core memory

2019-02-12 Thread Thomas Huth
On 2019-01-29 14:29, Jason J. Herne wrote: > Create a new header for basic architecture specific definitions and add a > mapping of low core memory. This mapping will be used by the real dasd boot > process. > > Signed-off-by: Jason J. Herne > --- > pc-bios/s390-ccw/main.c | 2 + >

Re: [Qemu-devel] [PATCH v2 3/4] tests/migration-test: Add a test for ignore-shared capability

2019-02-12 Thread Yury Kotov
11.02.2019, 16:17, "Dr. David Alan Gilbert" : > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: >>  Signed-off-by: Yury Kotov >>  --- >>   tests/migration-test.c | 109 + >>   1 file changed, 89 insertions(+), 20 deletions(-) >> >>  diff --git

[Qemu-devel] [PATCH 2/4] HMP: Prepend errors with 'Error:'

2019-02-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Always make error messages start with 'Error:' as a fallback to make sure that anything parsing them can tell it failed. Note: Some places don't use hmp_handle_error Signed-off-by: Dr. David Alan Gilbert --- hmp.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PULL 00/25] pci, pc, virtio: fixes, cleanups, features

2019-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 02:53:16PM +0100, Philippe Mathieu-Daudé wrote: > On 2/12/19 2:24 PM, Michael S. Tsirkin wrote: > > On Tue, Feb 12, 2019 at 02:15:36PM +0100, Philippe Mathieu-Daudé wrote: > >> On 2/12/19 2:04 PM, Michael S. Tsirkin wrote: > >>> On Tue, Feb 12, 2019 at 11:39:21AM +0100,

[Qemu-devel] [PATCH 0/3] pci, vhost-user: Fix two incorrectly applied patches

2019-02-12 Thread Philippe Mathieu-Daudé
Commit a56de056c91f8 squashed two unrelated commits at once. Revert it and reapply the two commits to avoid confusion. See: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg02966.html Changpeng Liu (1): contrib/vhost-user-blk: fix the compilation issue Peter Xu (1): i386/kvm: ignore

[Qemu-devel] [RFC PULL 6/6] tests/virtio-blk: add test for WRITE_ZEROES command

2019-02-12 Thread Stefan Hajnoczi
From: Stefano Garzarella If the WRITE_ZEROES feature is enabled, we check this command in the test_basic(). Reviewed-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Acked-by: Thomas Huth Signed-off-by: Stefano Garzarella Acked-by: Pankaj Gupta Message-id:

Re: [Qemu-devel] [PATCH 04/13] block: Freeze the backing chain for the duration of the stream job

2019-02-12 Thread Kevin Wolf
Am 17.01.2019 um 16:33 hat Alberto Garcia geschrieben: > Signed-off-by: Alberto Garcia > --- > block/stream.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/block/stream.c b/block/stream.c > index 7a49ac0992..39a2e10892 100644 > --- a/block/stream.c > +++

Re: [Qemu-devel] [PATCH 04/13] block: Freeze the backing chain for the duration of the stream job

2019-02-12 Thread Alberto Garcia
On Tue 12 Feb 2019 04:15:58 PM CET, Kevin Wolf wrote: > Am 17.01.2019 um 16:33 hat Alberto Garcia geschrieben: >> Signed-off-by: Alberto Garcia >> --- >> block/stream.c | 16 >> 1 file changed, 16 insertions(+) >> >> diff --git a/block/stream.c b/block/stream.c >> index

Re: [Qemu-devel] [PATCH] hw/dma/i8257: Use qemu_log_mask(UNIMP) instead of fprintf

2019-02-12 Thread Thomas Huth
On 2019-02-12 15:53, Philippe Mathieu-Daudé wrote: > Avoid to clutter stdout until explicitly requested (with -d unimp): > > $ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin > dma: command df not supported > dma: command df not supported > dma: command df not supported > dma:

[Qemu-devel] [PATCH 6/7] build-sys: link with slirp as an external project

2019-02-12 Thread Marc-André Lureau
Use the "system" libslirp if its present or requested. Else build with a static libslirp.a if slirp/ is checked out ("internal") or a submodule ("git"). Signed-off-by: Marc-André Lureau --- net/slirp.c| 2 +- Makefile | 8 +++--- Makefile.objs | 1 - Makefile.target

[Qemu-devel] [PATCH 5/7] slirp: add a standalone Makefile

2019-02-12 Thread Marc-André Lureau
Add a simple Makefile to build libslirp.a, a static library version of libslirp, to be used by QEMU during a transition period, until a shared library is available. Signed-off-by: Marc-André Lureau --- slirp/Makefile | 47 +++ 1 file changed, 47

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 1/3] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init

2019-02-12 Thread Collin Walling
On 2/12/19 5:04 AM, Cornelia Huck wrote: > On Mon, 11 Feb 2019 20:16:55 -0500 > Collin Walling wrote: > >> The extended PTFF features (qsie, qtoue, stoe, stoue) are dependent >> on the multiple-epoch facility (mepoch). Let's print a warning if these >> features are enabled without mepoch. >> >>

Re: [Qemu-devel] [PATCH v3 00/17] block: local qiov helper

2019-02-12 Thread Vladimir Sementsov-Ogievskiy
On 11.02.2019 6:04, Stefan Hajnoczi wrote: > On Thu, Feb 07, 2019 at 01:24:28PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> v3: > > Will you send a v4 based on Eric's comments or do you want to keep the > series as it is? > I don't really want to resend, and I don't think that open-coding

Re: [Qemu-devel] [PATCH 09/13] block: Add 'runtime_opts' and 'mutable_opts' fields to BlockDriver

2019-02-12 Thread Kevin Wolf
Am 17.01.2019 um 16:34 hat Alberto Garcia geschrieben: > This patch adds two new fields to BlockDriver: > >- runtime_opts: list of runtime options for a particular block > driver. We'll use this list later to detect what options are > missing when we try to reopen a block device. >

  1   2   3   4   >