Re: [Qemu-devel] [PATCH 2/2] lsi: use ldn_le_p()/stn_le_p()

2019-02-18 Thread Philippe Mathieu-Daudé
Hi Sven, On 2/18/19 6:55 PM, Sven Schnelle wrote: > Signed-off-by: Sven Schnelle > --- > hw/scsi/lsi53c895a.c | 19 ++- > 1 file changed, 2 insertions(+), 17 deletions(-) > > diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c > index c493e3c4c7..93c4434bfb 100644 > ---

Re: [Qemu-devel] [PATCH 03/14] hw/timer/pl031: Allow use as an embedded-struct device

2019-02-18 Thread Philippe Mathieu-Daudé
On 2/14/19 1:50 PM, Peter Maydell wrote: > Create a new include file for the pl031's device struct, > type macros, etc, so that it can be instantiated using > the "embedded struct" coding style. > > Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > --- >

Re: [Qemu-devel] [PATCH] hw/rdma: another clang compilation fix

2019-02-18 Thread Philippe Mathieu-Daudé
On 2/17/19 8:51 AM, Marcel Apfelbaum wrote: > > Cc:qemu-sta...@nongnu.org I doubt this is a security issue worth Cc'ing qemu-stable :) > Thanks, > Marcel > > On 2/14/19 5:40 PM, Marcel Apfelbaum wrote: >> Configuring QEMU with: >>     configure --target-list="x86_64-softmmu" --cc=clang

Re: [Qemu-devel] [PATCH 09/14] hw/arm/armsse: Allow boards to specify init-svtor

2019-02-18 Thread Philippe Mathieu-Daudé
On 2/14/19 1:51 PM, Peter Maydell wrote: > The Musca boards have DAPLink firmware that sets the initial > secure VTOR value (the location of the vector table) differently > depending on the boot mode (from flash, from RAM, etc). Export > the init-svtor as a QOM property of the ARMSSE object so

Re: [Qemu-devel] [PATCH v2 2/6] block/dirty-bitmaps: rename frozen predicate helper

2019-02-18 Thread John Snow
On 2/18/19 8:57 AM, Vladimir Sementsov-Ogievskiy wrote: > 14.02.2019 2:23, John Snow wrote: >> "Frozen" was a good description a long time ago, but it isn't adequate now. >> Rename the frozen predicate to has_successor to make the semantics of the >> predicate more clear to outside callers. >>

Re: [Qemu-devel] [PATCH] Acceptance tests: drop usage of ":avocado: enable"

2019-02-18 Thread Philippe Mathieu-Daudé
On 2/18/19 6:37 PM, Cleber Rosa wrote: > The Avocado test runner attemps to find its INSTRUMENTED (that is, > Python based tests) in a manner that is as safe as possible to the > user. Different from plain Python unittest, it won't load or > execute test code on an operation such as: > > $

Re: [Qemu-devel] [PATCH 2/2] lsi: use ldn_le_p()/stn_le_p()

2019-02-18 Thread Peter Maydell
On Mon, 18 Feb 2019 at 21:41, Philippe Mathieu-Daudé wrote: > > Hi Sven, > > On 2/18/19 6:55 PM, Sven Schnelle wrote: > > Signed-off-by: Sven Schnelle > > --- > > hw/scsi/lsi53c895a.c | 19 ++- > > 1 file changed, 2 insertions(+), 17 deletions(-) > > > > diff --git

Re: [Qemu-devel] [PATCH v2] mips_fulong2e: Add on-board graphics chip

2019-02-18 Thread Philippe Mathieu-Daudé
On 2/18/19 1:09 PM, BALATON Zoltan wrote: > Add (partial) emulation of the on-board GPU of the machine. This > allows the PMON2000 firmware to run and should also work with Linux > console but probably not with X yet. > > Signed-off-by: BALATON Zoltan > Reviewed-by: Philippe Mathieu-Daudé >

Re: [Qemu-devel] [PATCH v2 6/6] block/dirty-bitmaps: move comment block

2019-02-18 Thread John Snow
On 2/18/19 12:39 PM, Vladimir Sementsov-Ogievskiy wrote: > 14.02.2019 2:23, John Snow wrote: >> Simply move the big status enum comment block to above the status >> function, and document it as being deprecated. The whole confusing >> block can get deleted in three releases time. >> >>

Re: [Qemu-devel] [RFC PATCH 1/2] block/dirty-bitmaps: add inconsistent bit

2019-02-18 Thread John Snow
On 2/18/19 12:46 PM, Vladimir Sementsov-Ogievskiy wrote: > 14.02.2019 2:36, John Snow wrote: >> Add an inconsistent bit to dirty-bitmaps that allows us to report a bitmap as >> persistent but potentially inconsistent, i.e. if we find bitmaps on a qcow2 >> that have been marked as "in use". >>

Re: [Qemu-devel] [PATCH v2] i386, acpi: check acpi_memory_hotplug capacity in pre_plug

2019-02-18 Thread Wei Yang
On Mon, Feb 18, 2019 at 02:53:36PM +0100, Igor Mammedov wrote: >On Mon, 18 Feb 2019 13:21:29 + >Wei Yang wrote: > >> On Mon, Feb 18, 2019 at 01:56:02PM +0100, Igor Mammedov wrote: >> >On Mon, 18 Feb 2019 12:13:24 + >> >Wei Yang wrote: >> > >> >> On Mon, Feb 18, 2019 at 10:50:34AM +0100,

Re: [Qemu-devel] [RFC PATCH 00/11] qcow2: External data files

2019-02-18 Thread Max Reitz
On 31.01.19 18:55, Kevin Wolf wrote: > There are use cases where raw images are given (e.g. existing physical > disks), but advanced features like dirty bitmaps or backing files are > wanted that require use of a proper image format like qcow2. > > This series adds an incompatible feature bit to

Re: [Qemu-devel] [PATCH 10/12] test-bdrv-drain: AioContext switch in drained section

2019-02-18 Thread Eric Blake
On 2/18/19 10:18 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > tests/test-bdrv-drain.c | 32 > 1 file changed, 32 insertions(+) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226

Re: [Qemu-devel] [PATCH 09/12] block: Fix AioContext switch for drained node

2019-02-18 Thread Eric Blake
On 2/18/19 10:18 AM, Kevin Wolf wrote: > When a drained node changes its AioContext, we need to move its > aio_disable_external() to the new context, too. > > Without this fix, drain_end will try to reenable the new context, which > has never been disabled, so an assertion failure is triggered. >

[Qemu-devel] [PATCH v4 0/1] blockdev: acquire aio_context for bitmap add/remove

2019-02-18 Thread John Snow
See patch for details. V4: Embarrassingly, fix a missing semicolon; V3: Add signed-off-by. My script went a bit haywire, so this one's for posterity. John Snow (1): blockdev: acquire aio_context for bitmap add/remove blockdev.c | 26 -- 1 file changed, 20

Re: [Qemu-devel] [PATCH v2 5/6] block/dirty-bitmaps: unify qmp_locked and user_locked calls

2019-02-18 Thread John Snow
On 2/18/19 12:27 PM, Vladimir Sementsov-Ogievskiy wrote: > 14.02.2019 2:23, John Snow wrote: >> These mean the same thing now. Unify them and rename the merged call >> bdrv_dirty_bitmap_busy to indicate semantically what we are describing, >> as well as help disambiguate from the various

Re: [Qemu-devel] [PATCH v2 3/6] block/dirty-bitmap: change semantics of enabled predicate

2019-02-18 Thread John Snow
On 2/18/19 11:39 AM, Vladimir Sementsov-Ogievskiy wrote: > 14.02.2019 2:23, John Snow wrote: >> Currently, enabled means something like "the status of the bitmap >> is ACTIVE." After this patch, it should mean exclusively: "This >> bitmap is recording guest writes, and is allowed to do so." >>

[Qemu-devel] [PATCH v3] i386, acpi: check acpi_memory_hotplug capacity in pre_plug

2019-02-18 Thread Wei Yang
Currently we do device realization like below: hotplug_handler_pre_plug() dc->realize() hotplug_handler_plug() Before we do device realization and plug, we should allocate necessary resources and check if memory-hotplug-support property is enabled. At the piix4 and ich9, the

Re: [Qemu-devel] [PATCH 00/10] ppc: Add Hypervisor Virtualization Interrupt on POWER9

2019-02-18 Thread David Gibson
On Fri, Feb 15, 2019 at 05:16:38PM +0100, Cédric Le Goater wrote: > Hello, > > Here is a series of fixes and extensions provided by Ben which modify > the POWER9 interrupt model to prepare ground for the support of the > XIVE interrupt controller as found on POWER9 PowerNV machines. Applied to

Re: [Qemu-devel] [PATCH v2 2/9] ccid-card-passthru: Replace never trigger if statement by an assertion

2019-02-18 Thread Philippe Mathieu-Daudé
On 2/15/19 11:59 AM, Marc-André Lureau wrote: > Hi > > On Thu, Feb 14, 2019 at 9:20 PM Philippe Mathieu-Daudé > wrote: >> >> The right side of the comparison is the return value of can_read(): >> VSCARD_IN_SIZE - card->vscard_in_pos. >> Since the 'size' argument of chardev::read() is bound to >>

Re: [Qemu-devel] [PATCH 04/14] hw/timer/pl031: Convert to using trace events

2019-02-18 Thread Philippe Mathieu-Daudé
On 2/14/19 1:50 PM, Peter Maydell wrote: > Convert the debug printing in the PL031 device to use trace events, > and augment it to cover the interesting parts of device operation. > > Signed-off-by: Peter Maydell > --- > hw/timer/pl031.c | 55 +++ >

Re: [Qemu-devel] [PATCH v4 1/1] blockdev: acquire aio_context for bitmap add/remove

2019-02-18 Thread John Snow
On 2/18/19 4:55 PM, Eric Blake wrote: > On 2/18/19 3:42 PM, John Snow wrote: >> When bitmaps are persistent, they may incur a disk read or write when bitmaps >> are added or removed. For configurations like virtio-dataplane, failing to >> acquire this lock will abort QEMU when disk IO occurs.

[Qemu-devel] [Bug 1685242] Re: ovmf hangs at efi with virtio-net memory hotplug

2019-02-18 Thread Laszlo Ersek (Red Hat)
OVMF places the 64-bit PCI MMIO aperture after the memory hotplug area. If you specify `-m maxmem=1024G`, then accessing 64-bit MMIO BARs of PCI(e) devices, allocated from the aperture, will require at least 41 address bits. If you use KVM, and nested paging (EPT on Intel, NPT on AMD) is enabled,

Re: [Qemu-devel] [RFC PATCH 07/11] qcow2: External file I/O

2019-02-18 Thread Max Reitz
On 31.01.19 18:55, Kevin Wolf wrote: > This changes the qcow2 implementation to direct all guest data I/O to > s->data_file rather than bs->file, while metadata I/O still uses > bs->file. At the moment, this is still always the same, but soon we'll > add options to set s->data_file to an external

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-02-18 Thread Michael S. Tsirkin
On Mon, Feb 18, 2019 at 10:49:08PM +0200, Yuri Benditovich wrote: > On Mon, Feb 18, 2019 at 6:39 PM Michael S. Tsirkin wrote: > > > > On Mon, Feb 18, 2019 at 11:58:51AM +0200, Yuri Benditovich wrote: > > > On Mon, Feb 18, 2019 at 5:49 AM Jason Wang wrote: > > > > > > > > > > > > On 2019/2/13

Re: [Qemu-devel] Please help corrupt filesystem image

2019-02-18 Thread John Snow
On 2/16/19 10:54 PM, Alexander Marx wrote: > Dear List! > > I have a big problem and hope you can help me. > I built a new windows 2016 domain with virtual servers. 2 dc and 9 rds > hosts. > I was nearly finished with the setup and ready to migrate the users from > old to new domain. > > Then

Re: [Qemu-devel] [PATCH] iotests: Skip 211 on insufficient memory

2019-02-18 Thread Philippe Mathieu-Daudé
On 2/18/19 7:06 PM, Max Reitz wrote: > VDI keeps the whole bitmap in memory, and the maximum size (which is > tested here) is 2 GB. This may not be available on all machines, and it > rarely is available when running a 32 bit build. > > Fix this by making VM.run_job() return the error string if

Re: [Qemu-devel] [PATCH 3/7] tests/tcg: target/mips: Change directory name 'bit-counting' to 'bit-count'

2019-02-18 Thread Philippe Mathieu-Daudé
On 2/18/19 4:31 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Change directory name 'bit-counting' to 'bit-count'. This is just for > cosmetic and consistency sake. This was the only subdirectory in MSA > test directory that uses ending 'ing'. > > Signed-off-by: Aleksandar

Re: [Qemu-devel] [PATCH v2 4/6] block/dirty-bitmap: explicitly lock bitmaps with successors

2019-02-18 Thread John Snow
On 2/18/19 11:52 AM, Vladimir Sementsov-Ogievskiy wrote: > 14.02.2019 2:23, John Snow wrote: >> Instead of implying a locked status, make it explicit. > > locked interferes with bitmap mutex, so may be better "qmp_locked state", but > not sure. > I agree that "locked" has too many meanings,

[Qemu-devel] [PATCH v5] blockdev: acquire aio_context for bitmap add/remove

2019-02-18 Thread John Snow
When bitmaps are persistent, they may incur a disk read or write when bitmaps are added or removed. For configurations like virtio-dataplane, failing to acquire this lock will abort QEMU when disk IO occurs. We used to acquire aio_context as part of the bitmap lookup, so re-introduce the lock for

Re: [Qemu-devel] [PATCH qemu v2 4/4] spapr: Support NVIDIA V100 GPU with NVLink2

2019-02-18 Thread Alexey Kardashevskiy
On 15/02/2019 16:30, David Gibson wrote: > On Fri, Feb 15, 2019 at 03:42:56PM +1100, Alexey Kardashevskiy wrote: >> >> >> On 15/02/2019 14:22, David Gibson wrote: >>> On Thu, Feb 14, 2019 at 04:21:44PM +1100, Alexey Kardashevskiy wrote: NVIDIA V100 GPUs have on-board RAM which is mapped

Re: [Qemu-devel] [Qemu-ppc] [PATCH 04/10] sam460ex: Don't size flash memory to match backing image

2019-02-18 Thread BALATON Zoltan
On Mon, 18 Feb 2019, Markus Armbruster wrote: BALATON Zoltan writes: On Mon, 18 Feb 2019, Markus Armbruster wrote: Machine "sam460ex" maps its flash memory at address 0xFFF0. When no image is supplied, its size is 1MiB (0x10). Else, it's the size of the image rounded up to the next

Re: [Qemu-devel] [PATCH] iotests: handle TypeError for Python3 in test 242

2019-02-18 Thread Philippe Mathieu-Daudé
On 2/18/19 9:05 PM, Eric Blake wrote: > [adding Eduardo for some python 2-vs-3 advice] And Cleber. > > On 2/18/19 1:59 PM, Andrey Shinkevich wrote: >> To write one byte to disk, Python2 may use 'chr' type. >> In Python3, conversion to 'byte' type is required. >> >> Signed-off-by: Andrey

Re: [Qemu-devel] [PATCH 1/7] hw/misc: mips_itu: Fix 32/64 bit issue in a line involving shift operator

2019-02-18 Thread Philippe Mathieu-Daudé
On 2/18/19 4:31 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Fix 32/64 bit issue in a line involving shift operator. "1 << ..." > calculation of size is done as a 32-bit signed integer which may > then be unintentionally sign-extended into the 64-bit result. The > problem was

[Qemu-devel] [PATCH v4 1/1] blockdev: acquire aio_context for bitmap add/remove

2019-02-18 Thread John Snow
When bitmaps are persistent, they may incur a disk read or write when bitmaps are added or removed. For configurations like virtio-dataplane, failing to acquire this lock will abort QEMU when disk IO occurs. We used to acquire aio_context as part of the bitmap lookup, so re-introduce the lock for

Re: [Qemu-devel] [PATCH v2 0/3] Misc MIPS fulong2e improvements

2019-02-18 Thread Philippe Mathieu-Daudé
On 2/18/19 1:01 PM, BALATON Zoltan wrote: > v2 of > http://lists.nongnu.org/archive/html/qemu-devel/2019-02/msg02477.html > Addressed review comments and removed last patch (sending it > separately) to make this series not depend on my ati-vga patch so it > can be applied independently. > >

Re: [Qemu-devel] [RFC PATCH 08/11] qcow2: Add basic data-file infrastructure

2019-02-18 Thread Max Reitz
On 31.01.19 18:55, Kevin Wolf wrote: > This adds a .bdrv_open option to specify the external data file node. > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 3 ++- > block/qcow2.h| 4 +++- > block/qcow2.c| 25 +++-- > 3 files changed, 28

Re: [Qemu-devel] [RFC PATCH 11/11] qcow2: Add data file to ImageInfoSpecificQCow2

2019-02-18 Thread Max Reitz
On 31.01.19 18:55, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 1 + > block/qcow2.c| 6 +- > 2 files changed, 6 insertions(+), 1 deletion(-) [...] > diff --git a/block/qcow2.c b/block/qcow2.c > index 4959bf16a4..e3427f9fcd 100644 > ---

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3] ppc: add host-serial and host-model machine attributes

2019-02-18 Thread David Gibson
On Mon, Feb 18, 2019 at 11:52:18AM +, Daniel P. Berrangé wrote: > On Mon, Feb 18, 2019 at 12:38:11PM +0100, Greg Kurz wrote: > > On Mon, 18 Feb 2019 15:42:18 +0530 > > P J P wrote: > > > > > From: Prasad J Pandit > > > > > > On ppc hosts, hypervisor shares following system attributes > > >

Re: [Qemu-devel] [PATCH 06/12] nbd: Use low-level QIOChannel API in nbd_read_eof()

2019-02-18 Thread Eric Blake
On 2/18/19 10:18 AM, Kevin Wolf wrote: > Instead of using the convenience wrapper qio_channel_read_all_eof(), use > the lower level QIOChannel API. This means duplicating some code, but > we'll need this because this coroutine yield is special: We want it to > be interruptible so that

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-02-18 Thread Yuri Benditovich
On Mon, Feb 18, 2019 at 6:39 PM Michael S. Tsirkin wrote: > > On Mon, Feb 18, 2019 at 11:58:51AM +0200, Yuri Benditovich wrote: > > On Mon, Feb 18, 2019 at 5:49 AM Jason Wang wrote: > > > > > > > > > On 2019/2/13 下午10:51, Yuri Benditovich wrote: > > > >

Re: [Qemu-devel] [PATCH 05/14] hw/char/pl011: Allow use as an embedded-struct device

2019-02-18 Thread Philippe Mathieu-Daudé
On 2/14/19 1:50 PM, Peter Maydell wrote: > Create a new include file for the pl011's device struct, > type macros, etc, so that it can be instantiated using > the "embedded struct" coding style. > > Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > --- >

Re: [Qemu-devel] [RFC PATCH 10/11] qcow2: Store data file name in the image

2019-02-18 Thread Max Reitz
On 31.01.19 18:55, Kevin Wolf wrote: > Rather than requiring that the external data file node is passed > explicitly when creating the qcow2 node, store the filename in the > designated header extension during .bdrv_create and read it from there > as a default during .bdrv_open. > >

Re: [Qemu-devel] [PATCH 03/12] target/ppc: Re-enable RMLS on POWER9 for virtual hypervisors

2019-02-18 Thread David Gibson
On Fri, Feb 15, 2019 at 06:00:20PM +0100, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > Historically the 64-bit server MMU supports two way of configuring the > guest "real mode" mapping: > > - The "RMA" with is a single chunk of physically contiguous > memory remapped as guest

Re: [Qemu-devel] [PATCH 05/10] ppc405_boards: Don't size flash memory to match backing image

2019-02-18 Thread David Gibson
On Mon, Feb 18, 2019 at 01:56:10PM +0100, Markus Armbruster wrote: > Machine "ref405ep" maps its flash memory at address 2^32 - image size. > Image size is rounded up to the next multiple of 64KiB. Useless, > because pflash_cfi02_realize() fails with "failed to read the initial > flash content"

Re: [Qemu-devel] [PATCH 04/12] target/ppc: Fix #include guard in mmu-book3s-v3.h

2019-02-18 Thread David Gibson
On Fri, Feb 15, 2019 at 06:00:21PM +0100, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Cédric Le Goater Applied, thanks. > --- > target/ppc/mmu-book3s-v3.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >

Re: [Qemu-devel] [PATCH 05/12] target/ppc: Cleanup 64-bit MMU includes

2019-02-18 Thread David Gibson
On Fri, Feb 15, 2019 at 06:00:22PM +0100, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > To enable inlining more things, move #include of mmu-hash64.h and > mmu-radix64.h to mmu-book3s-v3.h > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Cédric Le Goater I don't really

Re: [Qemu-devel] [PATCH 02/12] target/ppci/mmu: Use LPCR:HR to chose radix vs. hash translation

2019-02-18 Thread David Gibson
On Mon, Feb 18, 2019 at 10:20:43PM +0100, Philippe Mathieu-Daudé wrote: > On 2/18/19 7:47 AM, David Gibson wrote: > > On Fri, Feb 15, 2019 at 06:00:19PM +0100, Cédric Le Goater wrote: > >> From: Benjamin Herrenschmidt > >> > >> Now that LPCR:HR is set properly for SPAPR, use it for deciding > >>

Re: [Qemu-devel] [PATCH 06/12] target/ppc: Fix ordering of hash MMU accesses

2019-02-18 Thread David Gibson
On Fri, Feb 15, 2019 at 06:00:23PM +0100, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > With mttcg, we can have MMU lookups happening at the same time > as the guest modifying the page tables. > > Since the HPTEs of the hash table MMU contains two words (or > double worlds on

Re: [Qemu-devel] Please help corrupt filesystem image

2019-02-18 Thread Alexander Marx
Thank you for replying. Well i am using latest PROXMOX in a cluster of 4 physical servers. during the weekend i had to stop all hosts because electricians had to work on the fuse box. i shutted down all vm's then powered off all physical hosts. One of them took very long. this host had a raid5 of

[Qemu-devel] [Bug 1737883] Re: Cannot boot FreeBSD on versatilepb machine

2019-02-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1737883 Title: Cannot

Re: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups

2019-02-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190218125615.18970-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190218125615.18970-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups

Re: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups

2019-02-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190218125615.18970-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190218125615.18970-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups

Re: [Qemu-devel] [PATCH 07/12] target/ppc: Add basic support for "new format" HPTE as found on POWER9

2019-02-18 Thread David Gibson
On Fri, Feb 15, 2019 at 06:00:24PM +0100, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > POWER9 (arch v3) slightly changes the HPTE format. The B bits move > from the first to the second half of the HPTE, and the AVPN/ARPN > are slightly shorter. > > However, under SPAPR, the

Re: [Qemu-devel] [PATCH 07/12] target/ppc: Add basic support for "new format" HPTE as found on POWER9

2019-02-18 Thread David Gibson
On Tue, Feb 19, 2019 at 03:05:29PM +1100, David Gibson wrote: > On Fri, Feb 15, 2019 at 06:00:24PM +0100, Cédric Le Goater wrote: > > From: Benjamin Herrenschmidt > > > > POWER9 (arch v3) slightly changes the HPTE format. The B bits move > > from the first to the second half of the HPTE, and the

[Qemu-devel] [PATCH] target/xtensa: fixup test_mmuhifi_c3 overlay

2019-02-18 Thread Max Filippov
xtensa-modules part of the test_mmuhifi_c3 core is missing fixes that returns XTENSA_UNDEFINED for undefined opcodes and marks all data structures static. Run sed script from target/xtensa/import_core.sh on it. This fixes test_sr tests for missing special registers. Signed-off-by: Max Filippov

Re: [Qemu-devel] [Qemu-ppc] [PATCH 04/10] sam460ex: Don't size flash memory to match backing image

2019-02-18 Thread Markus Armbruster
BALATON Zoltan writes: > On Mon, 18 Feb 2019, Markus Armbruster wrote: >> BALATON Zoltan writes: >>> On Mon, 18 Feb 2019, Markus Armbruster wrote: Machine "sam460ex" maps its flash memory at address 0xFFF0. When no image is supplied, its size is 1MiB (0x10). Else, it's the

Re: [Qemu-devel] [PATCH 09/10] pflash: Clean up after commit 368a354f02b part 2

2019-02-18 Thread Markus Armbruster
Laszlo Ersek writes: > On 02/18/19 18:01, Laszlo Ersek wrote: >> On 02/18/19 13:56, Markus Armbruster wrote: >>> QOMification left parameter @size unused in pflash_cfi01_register() >>> and pflash_cfi02_register(). register(). Obviously, @size should > > I meant to point out the typo above, but

[Qemu-devel] [Bug 1816052] Re: qemu system emulator fails to start if no sound card is present on host

2019-02-18 Thread Kris M
I agree. Thanks. :) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1816052 Title: qemu system emulator fails to start if no sound card is present on host Status in QEMU: New Bug description:

[Qemu-devel] [PATCH 0/2] PCDIMM cleanup

2019-02-18 Thread Wei Yang
Two trivial cleanup for pc-dimm. Patch [1] remove the check on class->hotpluggable since pc-dimm is always hotpluggable. Patch [2] remove realized callback since the task is done in pre_plug stage. Wei Yang (2): pc-dimm: remove check on pc-dimm hotpluggable pc-dimm: remove realize callback

[Qemu-devel] [PATCH 2/2] pc-dimm: remove realize callback

2019-02-18 Thread Wei Yang
PCDIMM's realize callback is introduced to do proper setup for NVDIMM. Currently the NVDIMM setup task is nvdimm_prepare_memory_region(), which is done in pre_plug stage. This means related task has already been done at realize point. This patch remove PCDIMM realize callback. Signed-off-by:

[Qemu-devel] [PATCH 1/2] pc-dimm: remove check on pc-dimm hotpluggable

2019-02-18 Thread Wei Yang
Function acpi_memory_plug_cb() is only invoked when dev is a PCDIMM, which is hotpluggable. This means it is not necessary to check this property again. This patch removes this check. Signed-off-by: Wei Yang --- hw/acpi/memory_hotplug.c | 4 1 file changed, 4 deletions(-) diff --git

Re: [Qemu-devel] Testing sysbus devices

2019-02-18 Thread Markus Armbruster
Stephen Checkoway writes: > On Feb 18, 2019, at 13:08, Markus Armbruster wrote: > >> Stephen Checkoway writes: >> >>> On Feb 18, 2019, at 08:43, Thomas Huth wrote: >>> On 18/02/2019 07.07, Stephen Checkoway wrote: > Hi all, > > I've been working on some improvements to the

[Qemu-devel] [PATCH 00/23] tests/tcg/xtensa: conditionalize xtensa tests

2019-02-18 Thread Max Filippov
Hello, this series reorganizes xtensa tests so that they can be run on various xtensa core configurations. It adds new tests for FPU2000 opcodes and for FLIX. It also adds support for printing test execution trace when preprocessor macro DEBUG is defined. Max Filippov (23): target/xtensa:

[Qemu-devel] [PATCH 01/23] target/xtensa: implement PREFCTL SR

2019-02-18 Thread Max Filippov
Cache prefetch option adds an unprivileged SR PREFCTL. Add trivial implementation for this SR. Signed-off-by: Max Filippov --- target/xtensa/cpu.h | 1 + target/xtensa/translate.c | 16 2 files changed, 17 insertions(+) diff --git a/target/xtensa/cpu.h

[Qemu-devel] [PATCH 08/23] tests/tcg/xtensa: conditionalize debug option tests

2019-02-18 Thread Max Filippov
Make debug tests conditional on the presence of the debug option in the config and tests that depend on the presence/number of instruction or data breakpoint registers on the corresponding definitions. Use configured debug interrupt level instead of the hardcoded value to set up IRQ handler and

[Qemu-devel] [PATCH 19/23] tests/tcg/xtensa: add LSCI/LSCX group tests

2019-02-18 Thread Max Filippov
Signed-off-by: Max Filippov --- tests/tcg/xtensa/Makefile | 1 + tests/tcg/xtensa/test_lsc.S | 122 2 files changed, 123 insertions(+) create mode 100644 tests/tcg/xtensa/test_lsc.S diff --git a/tests/tcg/xtensa/Makefile

[Qemu-devel] [PATCH 16/23] tests/tcg/xtensa: conditionalize windowed register tests

2019-02-18 Thread Max Filippov
Make windowed register tests conditional on the presence of this option. Fix tests to work correctly for both 32 and 64 physical registers. Signed-off-by: Max Filippov --- tests/tcg/xtensa/test_windowed.S | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-)

[Qemu-devel] [PATCH 04/23] tests/tcg/xtensa: support configs with LITBASE

2019-02-18 Thread Max Filippov
Configurations with LITBASE register may use absolute literals by default. Pass --no-absolute-literals option to assembler to use PC-relative literals instead. Signed-off-by: Max Filippov --- tests/tcg/xtensa/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/tcg/xtensa/Makefile

[Qemu-devel] [PATCH 03/23] tests/tcg/xtensa: support configurations w/o vecbase

2019-02-18 Thread Max Filippov
Configurations w/o vecbase may have vectors not grouped together and not in fixed order. They may not always be grouped into single output sections by assigning next offset to dot, as it may sometimes move dot backwards and sometimes they may even belong to different memory region. Don't group

[Qemu-devel] [PATCH 21/23] tests/tcg/xtensa: add FP0 group conversion tests

2019-02-18 Thread Max Filippov
Test conversions for normal, NaN and Inf arguments. Signed-off-by: Max Filippov --- tests/tcg/xtensa/Makefile| 1 + tests/tcg/xtensa/test_fp0_conv.S | 304 +++ 2 files changed, 305 insertions(+) create mode 100644 tests/tcg/xtensa/test_fp0_conv.S

[Qemu-devel] [PATCH 02/23] tests/tcg/xtensa: indicate failed tests

2019-02-18 Thread Max Filippov
When test suite with multiple tests fails it's not obvious which test failed. Pring "failed" in every invocation of test_fail. Do printing when DEBUG preprocessor macro is defined. Signed-off-by: Max Filippov --- tests/tcg/xtensa/macros.inc | 7 ++- 1 file changed, 6 insertions(+), 1

[Qemu-devel] [PATCH 07/23] tests/tcg/xtensa: enable boolean tests

2019-02-18 Thread Max Filippov
Uncomment test_boolean in the test makefile. Make actual tests code conditional on the presence of boolean option in the config. Signed-off-by: Max Filippov --- tests/tcg/xtensa/Makefile | 2 +- tests/tcg/xtensa/test_boolean.S | 4 2 files changed, 5 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH 18/23] tests/tcg/xtensa: add test for FLIX

2019-02-18 Thread Max Filippov
Signed-off-by: Max Filippov --- tests/tcg/xtensa/Makefile| 1 + tests/tcg/xtensa/test_flix.S | 60 2 files changed, 61 insertions(+) create mode 100644 tests/tcg/xtensa/test_flix.S diff --git a/tests/tcg/xtensa/Makefile

[Qemu-devel] [PATCH 10/23] tests/tcg/xtensa: add straightforward conditionals

2019-02-18 Thread Max Filippov
Make tests for optional instruction groups conditional on the presence of corresponding options in the config. Signed-off-by: Max Filippov --- tests/tcg/xtensa/test_clamps.S | 4 tests/tcg/xtensa/test_loop.S | 4 tests/tcg/xtensa/test_mac16.S | 4 tests/tcg/xtensa/test_max.S

[Qemu-devel] [PATCH 06/23] tests/tcg/xtensa: fix endianness issues in test_b

2019-02-18 Thread Max Filippov
Use bbci.l/bbsi.l instead of bbci/bbsi, as they are assembly macros that accept little-endian bit number and produce correct immediate for both little and big endian configurations. Choose value loaded into register for bbc/bbs opcodes based on configuration endianness. Signed-off-by: Max

[Qemu-devel] [PATCH 14/23] tests/tcg/xtensa: fix SR tests for big endian configs

2019-02-18 Thread Max Filippov
SR tests generate instructions that the assembler does not recognize and thus must take care about configuration endianness. Signed-off-by: Max Filippov --- tests/tcg/xtensa/test_sr.S | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH 12/23] tests/tcg/xtensa: conditionalize timer/CCOUNT tests

2019-02-18 Thread Max Filippov
Make timer/CCOUNT tests conditional on the presence of timer option and number of configured timers. Don't use hard coded interrupt levels for timers, use configured values. Signed-off-by: Max Filippov --- tests/tcg/xtensa/test_timer.S | 48 +++ 1 file

[Qemu-devel] [PATCH 11/23] tests/tcg/xtensa: conditionalize interrupt tests

2019-02-18 Thread Max Filippov
Make interrupt tests conditional on the presence of interrupt option and on the presence of level-1 and high level software interrupts. Don't use hard-coded interrupt level for the high level interrupt tests, choose high level software IRQ and use its configured level. Signed-off-by: Max Filippov

[Qemu-devel] [PATCH 05/23] tests/tcg/xtensa: don't use optional opcodes in generic code

2019-02-18 Thread Max Filippov
Don't use 'loop' opcode in generic testsuite completion code, only use core opcodes to make it work with any configuration. Signed-off-by: Max Filippov --- tests/tcg/xtensa/macros.inc | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tests/tcg/xtensa/macros.inc

[Qemu-devel] [PATCH 15/23] tests/tcg/xtensa: conditionalize and fix s32c1i tests

2019-02-18 Thread Max Filippov
Make s32c1i tests conditional on the presence of this option. Initialize ATOMCTL SR when it's present to allow RCW transactions on uncached memory. Signed-off-by: Max Filippov --- tests/tcg/xtensa/test_s32c1i.S | 12 1 file changed, 12 insertions(+) diff --git

[Qemu-devel] [PATCH 09/23] tests/tcg/xtensa: conditionalize cache option tests

2019-02-18 Thread Max Filippov
Make data/instruction tests conditional on the presence of data/instruction cache, whether they're lockable and whether data cache is writeback. Signed-off-by: Max Filippov --- tests/tcg/xtensa/test_cache.S | 62 ++- 1 file changed, 50 insertions(+), 12

[Qemu-devel] [PATCH 22/23] tests/tcg/xtensa: add FP1 group tests

2019-02-18 Thread Max Filippov
Test comparisons and conditional move operations. Signed-off-by: Max Filippov --- tests/tcg/xtensa/Makefile | 1 + tests/tcg/xtensa/test_fp1.S | 141 2 files changed, 142 insertions(+) create mode 100644 tests/tcg/xtensa/test_fp1.S diff --git

[Qemu-devel] [PATCH 13/23] tests/tcg/xtensa: conditionalize and expand SR tests

2019-02-18 Thread Max Filippov
Make tests for specific special registers conditional on the presence of the options that add these registers and test that the registers are not accessible otherwise. Signed-off-by: Max Filippov --- tests/tcg/xtensa/test_sr.S | 133 + 1 file changed,

[Qemu-devel] [PATCH 23/23] tests/tcg/xtensa: add FPU2000 coprocessor tests

2019-02-18 Thread Max Filippov
Signed-off-by: Max Filippov --- tests/tcg/xtensa/Makefile | 1 + tests/tcg/xtensa/test_fp_cpenable.S | 27 +++ 2 files changed, 28 insertions(+) create mode 100644 tests/tcg/xtensa/test_fp_cpenable.S diff --git a/tests/tcg/xtensa/Makefile

[Qemu-devel] [PATCH 20/23] tests/tcg/xtensa: add FP0 group arithmetic tests

2019-02-18 Thread Max Filippov
Test arithmetic operations for normal, NaN and Inf arguments. Signed-off-by: Max Filippov --- tests/tcg/xtensa/Makefile | 1 + tests/tcg/xtensa/macros.inc | 17 tests/tcg/xtensa/test_fp0_arith.S | 173 ++ 3 files changed, 191

[Qemu-devel] [PATCH 17/23] tests/tcg/xtensa: conditionalize MMU-related tests

2019-02-18 Thread Max Filippov
Make MMU-related tests conditional on the presence of MMUv2 option. Signed-off-by: Max Filippov --- tests/tcg/xtensa/test_mmu.S | 4 tests/tcg/xtensa/test_phys_mem.S | 4 2 files changed, 8 insertions(+) diff --git a/tests/tcg/xtensa/test_mmu.S b/tests/tcg/xtensa/test_mmu.S

Re: [Qemu-devel] [PATCH v4 06/11] virtio: get avail bytes check for packed ring

2019-02-18 Thread Jason Wang
On 2019/2/19 上午1:07, Wei Xu wrote: On Mon, Feb 18, 2019 at 03:27:21PM +0800, Jason Wang wrote: On 2019/2/14 下午12:26, w...@redhat.com wrote: From: Wei Xu Add packed ring headcount check. Common part of split/packed ring are kept. Signed-off-by: Wei Xu --- hw/virtio/virtio.c | 197

[Qemu-devel] Failing qemu-iotest 233

2019-02-18 Thread Thomas Huth
Hi Eric, hi Daniel, QEMU iotest 233 is failing for me on RHEL7: 233[07:29:30] [07:29:30] [failed, exit status 1] - output mismatch (see 233.out.bad) --- /home/thuth/devel/qemu/tests/qemu-iotests/233.out 2019-02-19 07:14:45.0 +0100 +++

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-02-18 Thread Jason Wang
On 2019/2/19 上午7:34, Michael S. Tsirkin wrote: On Mon, Feb 18, 2019 at 10:49:08PM +0200, Yuri Benditovich wrote: On Mon, Feb 18, 2019 at 6:39 PM Michael S. Tsirkin wrote: On Mon, Feb 18, 2019 at 11:58:51AM +0200, Yuri Benditovich wrote: On Mon, Feb 18, 2019 at 5:49 AM Jason Wang wrote:

Re: [Qemu-devel] [PATCH v2] Add a gitlab-ci file for Continuous Integration testing on Gitlab

2019-02-18 Thread Thomas Huth
On 18/02/2019 19.22, Cleber Rosa wrote: > > > On 2/13/19 6:54 AM, Thomas Huth wrote: >> This is very convenient for people like me who store their QEMU git trees >> on gitlab.com: Automatic CI pipelines are now run for each branch that is >> pushed to the server - useful for some extra-testing

Re: [Qemu-devel] [PATCH v1 0/1] Allow TAP to unnegotiate virtio-net header

2019-02-18 Thread Jason Wang
On 2019/2/18 下午7:53, Vincenzo Maffione wrote: Hi Jason, Thanks for the quick reply. My PV device (to be open sourced soon) uses the QEMU net backend interface, in a way similar to virtio-net. For example it uses qemu_set_offload(), qemu_has_vnet_hdr_len(), qemu_using_vnet_hdr(),

Re: [Qemu-devel] [PATCH v4 07/11] virtio: fill/flush/pop for packed ring

2019-02-18 Thread Jason Wang
On 2019/2/18 下午10:46, Wei Xu wrote: Do we allow chain more descriptors than vq size in the case of indirect? According to the spec: " The device limits the number of descriptors in a list through a transport-specific and/or device-specific value. If not limited, the maximum number of

Re: [Qemu-devel] [PATCH 12/12] aio-posix: Assert that aio_poll() is always called in home thread

2019-02-18 Thread Eric Blake
On 2/18/19 10:18 AM, Kevin Wolf wrote: > aio_poll() has an existing assertion that the function is only called > from the AioContext's home thread if blocking is allowed. > > This is not enough, some handlers make assumptions about the thread they > run in. Extend the assertion to non-blocking

Re: [Qemu-devel] [PATCH 11/12] block: Use normal drain for bdrv_set_aio_context()

2019-02-18 Thread Eric Blake
On 2/18/19 10:18 AM, Kevin Wolf wrote: > Now that bdrv_set_aio_context() works inside drained sections, it can > also use the real drain function instead of open coding something > similar. > > Signed-off-by: Kevin Wolf > --- > block.c | 14 +- > 1 file changed, 5 insertions(+), 9

Re: [Qemu-devel] [PATCH 07/14] hw/char/pl011: Use '0x' prefix when logging hex numbers

2019-02-18 Thread Philippe Mathieu-Daudé
On 2/14/19 1:51 PM, Peter Maydell wrote: > The pl011 logs when the guest makes a bad access. It prints > the address offset in hex but confusingly omits the '0x' > prefix; add it. > > Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > --- > hw/char/pl011.c | 4 ++-- > 1 file

Re: [Qemu-devel] [RFC PATCH 06/11] qcow2: Don't assume 0 is an invalid cluster offset

2019-02-18 Thread Max Reitz
On 31.01.19 18:55, Kevin Wolf wrote: > The cluster allocation code uses 0 as an invalid offset that is used in > case of errors or as "offset not yet determined". With external data > files, a host cluster offset of 0 becomes valid, though. > > Define a constant INV_OFFSET (which is not cluster

[Qemu-devel] [PATCH 1/2] CODING_STYLE: specify the indent rule for multiline code

2019-02-18 Thread Wei Yang
We didn't specify the indent rule for multiline code here, which may misleading users. And in current code, the code use different rules. Add this rule in CODING_STYLE to make sure this is clear to every one. Signed-off-by: Wei Yang Suggested-by: Igor Mammedov --- CODING_STYLE | 26

[Qemu-devel] [PATCH 0/2] CODING_STYLE: trivial update

2019-02-18 Thread Wei Yang
The first one is suggested by Igor Mammedov to provide rule for multiline code. The second is a trivial fix to make example code all indented with 4 spaces. Wei Yang (2): CODING_STYLE: specify the indent rule for multiline code CODING_STYLE: indent example code as all others CODING_STYLE |

[Qemu-devel] [PATCH 2/2] CODING_STYLE: indent example code as all others

2019-02-18 Thread Wei Yang
All the example code are indented with four spaces except this one. Fix this by adding four spaces here. Signed-off-by: Wei Yang --- CODING_STYLE | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CODING_STYLE b/CODING_STYLE index 73f66ca185..27581d80c1 100644 ---

  1   2   3   4   5   >