Re: [Qemu-devel] [PATCH for-4.1 v2] q35: Revert to kernel irqchip

2019-05-15 Thread Peter Xu
On Tue, May 14, 2019 at 02:14:41PM -0600, Alex Williamson wrote: > Commit b2fc91db8447 ("q35: set split kernel irqchip as default") changed > the default for the pc-q35-4.0 machine type to use split irqchip, which > turned out to have disasterous effects on vfio-pci INTx support. KVM > resampling

Re: [Qemu-devel] [PATCH v6] hw/acpi: extract acpi_add_rom_blob()

2019-05-15 Thread Wei Yang
On Tue, Mar 26, 2019 at 10:43:20AM +0800, Wei Yang wrote: >arm and i386 has almost the same function acpi_add_rom_blob(), except >giving different FWCfgCallback function. > >This patch moves acpi_add_rom_blob() to utils.c by passing >FWCfgCallback to it. > >Signed-off-by: Wei Yang >Reviewed-by:

Re: [Qemu-devel] [PATCH v2 1/1] target/arm: Fix vector operation segfault

2019-05-15 Thread Philippe Mathieu-Daudé
On 5/15/19 2:21 AM, Alistair Francis wrote: > Commit 89e68b575 "target/arm: Use vector operations for saturation" > causes this abort() when booting QEMU ARM with a Cortex-A15: > > 0 0x74c2382f in raise () at /usr/lib/libc.so.6 > 1 0x74c0e672 in abort () at /usr/lib/libc.so.6 >

Re: [Qemu-devel] [PATCH 7/9] target/xtensa: implement block prefetch option opcodes

2019-05-15 Thread Philippe Mathieu-Daudé
On 5/14/19 10:44 PM, Max Filippov wrote: > Block prefetch option adds a bunch of non-privileged opcodes that may be > implemented as nops since QEMU doesn't model caches. > > Signed-off-by: Max Filippov > --- > target/xtensa/translate.c | 42 ++ > 1 file

Re: [Qemu-devel] [PATCH v7 00/24] Add qemu_getrandom and ARMv8.5-RNG etc

2019-05-15 Thread Markus Armbruster
This version fixes the check-unit failure for me.

[Qemu-devel] [PATCH] docs/devel/build-system: Update an example

2019-05-15 Thread Philippe Mathieu-Daudé
The default-configs/ example added in 717171bd2025 is no more accurate since fa212a2b8b60 (and various further other commits). The Kconfig build system is now in place. Use the aarch64-softmmu config as example. Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/build-system.txt | 15

Re: [Qemu-devel] [PATCH 2/4] migration/savevm: use migration_is_blocked to validate

2019-05-15 Thread Wei Yang
On Wed, May 15, 2019 at 02:38:27PM +0800, Wei Yang wrote: >On Tue, May 14, 2019 at 04:18:14PM +0100, Dr. David Alan Gilbert wrote: >>* Wei Yang (richardw.y...@linux.intel.com) wrote: >>> >>> Well, when you look into the source side of migration: >>> >>> qmp_migrate >>> migrate_prepare >>>

Re: [Qemu-devel] [PATCH] docs/devel/build-system: Update an example

2019-05-15 Thread Thomas Huth
On 15/05/2019 09.03, Philippe Mathieu-Daudé wrote: > The default-configs/ example added in 717171bd2025 is no > more accurate since fa212a2b8b60 (and various further other > commits). > > The Kconfig build system is now in place. > Use the aarch64-softmmu config as example. > > Signed-off-by:

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Andrew Jones
On Tue, May 14, 2019 at 03:32:13PM +0200, Markus Armbruster wrote: > Syntax that can support such growth would be nice. > > To grow a single unsigned number, we can make it wider (but we don't > have infrastructure for numbers wider than 64 bits), or we can add more > numbers (but under what

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Andrew Jones
On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > On Tue, 14 May 2019 11:02:25 +0200 > Andrew Jones wrote: > > My thought is primarily machines. If a human wants to use the command > > line and SVE, then I'm assuming they'll be happy with sve-max-vq or > > figuring out a map they

Re: [Qemu-devel] [PATCH v9 03/27] gdbstub: Implement thread_alive (T pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Signed-off-by: Jon Doron Reviewed-by: Alex Bennée > --- > gdbstub.c | 43 --- > 1 file changed, 32 insertions(+), 11 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 621d689868..c47ef7dd9c 100644 > --- a/gdbstub.c >

Re: [Qemu-devel] [PATCH 1/3] migration/ram.c: start of migration_bitmap_sync_range is always 0

2019-05-15 Thread Wei Yang
On Wed, May 15, 2019 at 09:04:51AM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> On Tue, May 14, 2019 at 03:27:02PM +0100, Dr. David Alan Gilbert wrote: >> >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> >> We can eliminate to pass 0. >> >> >> >>

[Qemu-devel] ping Re: [PATCH v6 0/7] NBD reconnect

2019-05-15 Thread Vladimir Sementsov-Ogievskiy
ping 11.04.2019 20:27, Vladimir Sementsov-Ogievskiy wrote: > Here is NBD reconnect. Previously, if connection failed all current > and future requests will fail. After the series, nbd-client driver > will try to reconnect unlimited times. During first @reconnect-delay > seconds of reconnecting

Re: [Qemu-devel] [PATCH 1/3] migration/ram.c: start of migration_bitmap_sync_range is always 0

2019-05-15 Thread Wei Yang
On Tue, May 14, 2019 at 03:27:02PM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> We can eliminate to pass 0. >> >> Signed-off-by: Wei Yang > >I'm going to queue just 1/3for the current pull. In the pull request, I didn't see Patch[3]. Do I

Re: [Qemu-devel] [PATCH 2/4] migration/savevm: use migration_is_blocked to validate

2019-05-15 Thread Wei Yang
On Tue, May 14, 2019 at 04:18:14PM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> >> Well, when you look into the source side of migration: >> >> qmp_migrate >> migrate_prepare >> migration_is_blocked >> >> This means if migration_is_blocked

Re: [Qemu-devel] [PATCH for-4.1 v2] q35: Revert to kernel irqchip

2019-05-15 Thread Daniel P . Berrangé
On Wed, May 15, 2019 at 02:15:03PM +0800, Peter Xu wrote: > On Tue, May 14, 2019 at 02:14:41PM -0600, Alex Williamson wrote: > > Commit b2fc91db8447 ("q35: set split kernel irqchip as default") changed > > the default for the pc-q35-4.0 machine type to use split irqchip, which > > turned out to

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

2019-05-15 Thread Andrew Jones
On Tue, May 14, 2019 at 06:03:09PM +0200, Andrea Bolognani wrote: > I thought about it a bit more and perhaps the simplified design is > better after all. > > Whatever the interface looks like on the QEMU side, we're going to > want to offer libvirt users two options for configuring vector >

[Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefix length error message

2019-05-15 Thread Stefano Garzarella
Reword and add a missing parentheses at the end of the error message. Signed-off-by: Stefano Garzarella Reviewed-by: Marc-André Lureau --- v2: - Reworded the error message (Markus) - Added Marc-André's R-b I made a little change to the error message, let me now if I should remove

Re: [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace()

2019-05-15 Thread Markus Armbruster
Jason Wang writes: > On 2019/5/14 下午8:18, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On Mon, 13 May 2019 at 14:21, Markus Armbruster wrote: Perhaps I should do it just for this file while I touch it anyway. The question to ask: should parse_acl_file() obey the locale

Re: [Qemu-devel] [RFC v2 PATCH 2/3] spapr: Add NVDIMM device support

2019-05-15 Thread Shivaprasad G Bhat
Hi David, Thanks for the comments. Replies inline.. On 05/14/2019 07:52 AM, David Gibson wrote: On Mon, May 13, 2019 at 04:28:02AM -0500, Shivaprasad G Bhat wrote: Add support for NVDIMM devices for sPAPR. Piggyback on existing nvdimm device interface in QEMU to support virtual NVDIMM devices

[Qemu-devel] [Bug 1829079] Re: Can't build static on ARM (Raspbian)

2019-05-15 Thread Philippe Mathieu-Daudé
This looks Debian specific. Not sure why you have to install the p11-kit/libp11-dev/libp11-2 packages although. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1829079 Title: Can't build static on

[Qemu-devel] [PATCH 2/2] qemu-img.texi: Describe human-readable info output

2019-05-15 Thread Max Reitz
Ideally, it should be self-explanatory. However, keys like "disk size" arguably really are not self-explanatory. In any case, there is no harm in going into a some more detail here. Signed-off-by: Max Reitz --- qemu-img.texi | 41 + 1 file changed, 41

[Qemu-devel] [PATCH 1/2] qemu-img.texi: Be specific about JSON object types

2019-05-15 Thread Max Reitz
Just writing that --output=json outputs JSON information does not really help; we should also make a note of what QAPI type the result object has. (The map subcommand does not emit a QAPI-typed object, but its section already describes the object structure well enough.) Signed-off-by: Max Reitz

[Qemu-devel] [PATCH 0/2] qemu-img.texi: Provide more info on some commands’ output

2019-05-15 Thread Max Reitz
Most qemu-img subcommands that have (optional) JSON output don’t describe the structure of their JSON output -- but having a fixed, well-known output structure kind of is the point of having JSON output at all. Therefore, patch 1 in this series makes every such command note which QAPI type their

Re: [Qemu-devel] [PATCH 0/2] fix qmp-cont vs migration-finish race-crash

2019-05-15 Thread Kevin Wolf
Am 24.01.2019 um 13:25 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi. > > It's a simple fix for problems reported in "Aborts in iotest 169" > by Max: > https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg05907.html > > In thread Kevin described that a problem itself is bigger and needs

Re: [Qemu-devel] [PATCH v9 04/27] gdbstub: Implement continue (c pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Signed-off-by: Jon Doron Reviewed-by: Alex Bennée > --- > gdbstub.c | 25 +++-- > 1 file changed, 19 insertions(+), 6 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index c47ef7dd9c..89f1ab6524 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@

Re: [Qemu-devel] [PATCH v9 03/27] gdbstub: Implement thread_alive (T pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Signed-off-by: Jon Doron Reviewed-by: Alex Bennée > --- > gdbstub.c | 43 --- > 1 file changed, 32 insertions(+), 11 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 621d689868..c47ef7dd9c 100644 > --- a/gdbstub.c >

Re: [Qemu-devel] [PATCH v4 6/6] acpi: pci: use build_append_foo() API to construct MCFG

2019-05-15 Thread Wei Yang
On Wed, May 15, 2019 at 07:29:17AM +0200, Philippe Mathieu-Daudé wrote: >On 5/15/19 3:10 AM, Michael S. Tsirkin wrote: >> On Fri, Apr 19, 2019 at 08:30:53AM +0800, Wei Yang wrote: >>> build_append_foo() API doesn't need explicit endianness conversions >>> which eliminates a source of errors and it

Re: [Qemu-devel] [PATCH] docs/devel/build-system: Update an example

2019-05-15 Thread Philippe Mathieu-Daudé
On 5/15/19 9:16 AM, Thomas Huth wrote: > On 15/05/2019 09.03, Philippe Mathieu-Daudé wrote: >> The default-configs/ example added in 717171bd2025 is no >> more accurate since fa212a2b8b60 (and various further other >> commits). >> >> The Kconfig build system is now in place. >> Use the

[Qemu-devel] [Bug 1829079] Re: Can't build static on ARM (Raspbian)

2019-05-15 Thread Thomas Huth
I agree with Philippe - if you have to symlink your libraries like this, it is certainly not a bug in QEMU, but a problem of your distro. So please report this issue in your distro bugtracker instead. ** Changed in: qemu Status: New => Invalid -- You received this bug notification

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

2019-05-15 Thread Andrea Bolognani
On Tue, 2019-05-14 at 13:14 -0700, Richard Henderson wrote: > On 5/14/19 9:03 AM, Andrea Bolognani wrote: > > On Tue, 2019-05-14 at 14:53 +0200, Andrew Jones wrote: > > > We already have sve-max-vq, so I'm not sure we want to rename it. > > > > Oh, I didn't realize that was the case. And of

Re: [Qemu-devel] [PATCH 1/3] migration/ram.c: start of migration_bitmap_sync_range is always 0

2019-05-15 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > On Tue, May 14, 2019 at 03:27:02PM +0100, Dr. David Alan Gilbert wrote: > >* Wei Yang (richardw.y...@linux.intel.com) wrote: > >> We can eliminate to pass 0. > >> > >> Signed-off-by: Wei Yang > > > >I'm going to queue just 1/3for the current

Re: [Qemu-devel] [PATCH v4 6/6] acpi: pci: use build_append_foo() API to construct MCFG

2019-05-15 Thread Wei Yang
On Tue, May 14, 2019 at 09:10:34PM -0400, Michael S. Tsirkin wrote: >On Fri, Apr 19, 2019 at 08:30:53AM +0800, Wei Yang wrote: >> build_append_foo() API doesn't need explicit endianness conversions >> which eliminates a source of errors and it makes build_mcfg() look like >> declarative definition

Re: [Qemu-devel] [Qemu-block] [PATCH 0/9] Assembly coroutine backend and x86 CET support

2019-05-15 Thread Stefan Hajnoczi
On Thu, May 09, 2019 at 02:44:39PM +0100, Peter Maydell wrote: > On Sun, 5 May 2019 at 16:41, Alex Bennée wrote: > > > > > > Paolo Bonzini writes: > > > > > *** BLURB HERE *** > > > > I assume there was going to be a bit more background here? > > Mmm, could we have the rationale, please ?

[Qemu-devel] Question about the vfio device interrupt

2019-05-15 Thread Li Qiang
Hello Paolo, Alex and all, In vfio_intx_enable_kvm(qemu) I see we associate a resamplefd with the umask function(vfio_pci_intx_unmask_handler in linux). irq_set = g_malloc0(argsz); irq_set->argsz = argsz; irq_set->flags = VFIO_IRQ_SET_DATA_EVENTFD | VFIO_IRQ_SET_ACTION_UNMASK;

Re: [Qemu-devel] [PATCH v9 06/27] gdbstub: Implement set_thread (H pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Signed-off-by: Jon Doron > --- > gdbstub.c | 79 ++- > 1 file changed, 49 insertions(+), 30 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 469aaeb875..21cdaf4678 100644 > --- a/gdbstub.c > +++ b/gdbstub.c >

Re: [Qemu-devel] Question about the vfio device interrupt

2019-05-15 Thread Auger Eric
Hi, On 5/15/19 12:01 PM, Li Qiang wrote: > Hello Paolo, Alex and all, > > In vfio_intx_enable_kvm(qemu) I see we associate a resamplefd with the > umask function(vfio_pci_intx_unmask_handler in linux). > > irq_set = g_malloc0(argsz); > irq_set->argsz = argsz; > irq_set->flags =

Re: [Qemu-devel] [Bug 1828508] [NEW] qemu-img created VMDK files lead to "Unsupported or invalid disk type 7"

2019-05-15 Thread Stefan Hajnoczi
On Fri, May 10, 2019 at 06:06:32AM -, Jake Mikelson wrote: > Public bug reported: > > Using qemu-img version 3.1.50 (v3.1.0-13607-geb2db0f7ba-dirty) on a > Windows 10 machine. > > Converting a VHD to VMDK. > qemu-img.exe convert "c:\test\AppD-VM01.vhd" -O vmdk -o adapter_type=buslogic > -p

Re: [Qemu-devel] [PATCH v9 07/27] gdbstub: Implement insert breakpoint (Z pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Signed-off-by: Jon Doron > --- > gdbstub.c | 33 + > 1 file changed, 33 insertions(+) > > diff --git a/gdbstub.c b/gdbstub.c > index 21cdaf4678..36c7353a22 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -1588,6 +1588,29 @@ static void

Re: [Qemu-devel] [PATCH] tests/libqtest: Remove unused global_qtest-related wrapper functions

2019-05-15 Thread Stefan Hajnoczi
On Fri, May 10, 2019 at 07:22:39AM +0200, Thomas Huth wrote: > A bunch of the wrapper functions that use global_qtest are not used > anymore. Remove them to avoid that they are used in new code again. > > Signed-off-by: Thomas Huth > --- > tests/libqtest.c | 11 + > tests/libqtest.h | 108

Re: [Qemu-devel] [PATCH 1/3] migration: Add multifd-compress parameter

2019-05-15 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela >> +case MIGRATION_PARAMETER_MULTIFD_COMPRESS: >> +p->has_multifd_compress = true; >> +visit_type_enum(v, param, _type, >> +_lookup, ); >> +

Re: [Qemu-devel] [PATCH v2 6/8] migration: Add multifd-compress parameter

2019-05-15 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> Signed-off-by: Juan Quintela >> >> --- >> Rename it to NONE >> @@ -1822,6 +1826,19 @@ void hmp_migrate_set_parameter(Monitor *mon, const >> QDict *qdict) >> p->has_multifd_channels = true; >> visit_type_int(v, param,

Re: [Qemu-devel] [PATCH v17 00/10] Add ARMv8 RAS virtualization support in QEMU

2019-05-15 Thread gengdongjiu
Hi All, for this series patch, we can use below simple method to test: 1). Apply below hard code change after applying this series patch: diff --git a/cpus.c b/cpus.c index e58e7ab..7149f54 100644 --- a/cpus.c +++ b/cpus.c @@ -1131,6 +1131,8 @@ static void sigbus_reraise(void) static void

Re: [Qemu-devel] [PATCH 2/4] migration/savevm: use migration_is_blocked to validate

2019-05-15 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > On Wed, May 15, 2019 at 02:38:27PM +0800, Wei Yang wrote: > >On Tue, May 14, 2019 at 04:18:14PM +0100, Dr. David Alan Gilbert wrote: > >>* Wei Yang (richardw.y...@linux.intel.com) wrote: > >>> > >>> Well, when you look into the source side of

Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

2019-05-15 Thread Peter Maydell
On Tue, 14 May 2019 at 20:16, Aleksandar Markovic wrote: > > On May 13, 2019 11:14 PM, "Richard Henderson" > wrote: > > > > On 5/11/19 5:47 AM, Aleksandar Markovic wrote: > > > If no, the patch shoud be amended. If yes, the commit message should be > > > extended. > > > > Like what? I think

Re: [Qemu-devel] Question about the vfio device interrupt

2019-05-15 Thread Li Qiang
Auger Eric 于2019年5月15日周三 下午6:16写道: > Hi, > > On 5/15/19 12:01 PM, Li Qiang wrote: > > Hello Paolo, Alex and all, > > > > In vfio_intx_enable_kvm(qemu) I see we associate a resamplefd with the > > umask function(vfio_pci_intx_unmask_handler in linux). > > > > irq_set = g_malloc0(argsz); > >

Re: [Qemu-devel] [PATCH v9 08/27] gdbstub: Implement remove breakpoint (z pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Signed-off-by: Jon Doron Merge with previous patch as per comments there. > --- > gdbstub.c | 49 - > 1 file changed, 32 insertions(+), 17 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 36c7353a22..b42425b24c

[Qemu-devel] [Bug 1829079] Re: Can't build static on ARM (Raspbian)

2019-05-15 Thread Peter Maydell
You might find that adding --disable-tools to your configure line also helps in not trying to statically link random binaries you don't really want. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH] monitor: Fix gva2gpa coverityism

2019-05-15 Thread Stefan Hajnoczi
On Fri, May 10, 2019 at 08:01:40PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Coverity is complaining that while I'm checking the return > value of mon_get_cpu(), I'm not actually using the checked value, > I'm calling it again and thus it's worried I might

Re: [Qemu-devel] [PATCH V1] Introducing virtio-example.

2019-05-15 Thread Stefan Hajnoczi
On Sun, Apr 28, 2019 at 04:26:31PM +0300, Yoni Bettan wrote: > The main goal is to create an example to be used as template or > guideline for contributors when they wish to create a new virtio > device and to document "the right way" to do so. > > It consists of several parts: > > 1. The

Re: [Qemu-devel] [PATCH v9 05/27] gdbstub: Implement continue with signal (C pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Signed-off-by: Jon Doron > --- > gdbstub.c | 30 +- > 1 file changed, 25 insertions(+), 5 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 89f1ab6524..469aaeb875 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -1532,6 +1532,21 @@

Re: [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace()

2019-05-15 Thread Peter Maydell
On Wed, 15 May 2019 at 07:34, Markus Armbruster wrote: > > Jason Wang writes: > > > On 2019/5/14 下午8:18, Markus Armbruster wrote: > >> -netdev's helper parameter is seriously underdocumented. Document or > >> deprecate? > > > > > > I believe management should only use fd parameter of TAP. If we

Re: [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace()

2019-05-15 Thread Daniel P . Berrangé
On Wed, May 15, 2019 at 08:34:17AM +0200, Markus Armbruster wrote: > Jason Wang writes: > > > On 2019/5/14 下午8:18, Markus Armbruster wrote: > >> Peter Maydell writes: > >> > >>> On Mon, 13 May 2019 at 14:21, Markus Armbruster wrote: > Perhaps I should do it just for this file while I

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Dave Martin
On Wed, May 15, 2019 at 09:15:20AM +0100, Andrew Jones wrote: > On Tue, May 14, 2019 at 03:32:13PM +0200, Markus Armbruster wrote: > > Syntax that can support such growth would be nice. > > > > To grow a single unsigned number, we can make it wider (but we don't > > have infrastructure for

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Igor Mammedov
On Wed, 15 May 2019 10:18:54 +0200 Andrew Jones wrote: > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > On Tue, 14 May 2019 11:02:25 +0200 > > Andrew Jones wrote: > > > My thought is primarily machines. If a human wants to use the command > > > line and SVE, then I'm

Re: [Qemu-devel] [PATCH for-4.1 v2] q35: Revert to kernel irqchipQEM

2019-05-15 Thread Alex Williamson
On Wed, 15 May 2019 14:15:03 +0800 Peter Xu wrote: > On Tue, May 14, 2019 at 02:14:41PM -0600, Alex Williamson wrote: > > Commit b2fc91db8447 ("q35: set split kernel irqchip as default") changed > > the default for the pc-q35-4.0 machine type to use split irqchip, which > > turned out to have

Re: [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace()

2019-05-15 Thread Paolo Bonzini
On 15/05/19 08:34, Markus Armbruster wrote: >>> qemu-bridge-helper should have a manual page, and its handling of errors >>> in ACL include files needs work. There's probably more; I just glanced >>> at it. I'm not volunteering, though. It lacks a maintainer. Should we >>> add it to Jason's

Re: [Qemu-devel] Question about the vfio device interrupt

2019-05-15 Thread Alex Williamson
On Wed, 15 May 2019 18:22:54 +0800 Li Qiang wrote: > Auger Eric 于2019年5月15日周三 下午6:16写道: > > > Hi, > > > > On 5/15/19 12:01 PM, Li Qiang wrote: > > > Hello Paolo, Alex and all, > > > > > > In vfio_intx_enable_kvm(qemu) I see we associate a resamplefd with the > > > umask

Re: [Qemu-devel] [PATCH 1/4] qapi: Support features for structs

2019-05-15 Thread Markus Armbruster
Kevin Wolf writes: > Am 18.04.2019 um 22:03 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Sometimes, the behaviour of QEMU changes compatibly, but without a >> > change in the QMP syntax (usually by allowing values or operations that >> > previously resulted in an error).

[Qemu-devel] [Bug 1829242] [NEW] qemu on windows host exits after savevm command

2019-05-15 Thread Alex
Public bug reported: I'm running qemu-system-i386.exe 3.1.0 with this command line: "C:\Program Files\qemu\qemu-system-i386.exe" -L C:\user\qemu\pc-bios\ -name win7 -m 4G -uuid 564db62e-e031-b5cf-5f34-a75f8cefa98e -rtc base=localtime -accel hax -hdd

[Qemu-devel] [PATCH v3 0/7] Leon3 patches

2019-05-15 Thread KONRAD Frederic
Hi all, Those are some little fixes for the leon3 machine: * The first patch makes an error message more friendly when no kernel / bios are provided. * The three next one remove the old-style create function as suggested by Mark. * The fifth part initializes the uart and the timer

[Qemu-devel] [PATCH v3 1/7] leon3: fix the error message when no bios are provided

2019-05-15 Thread KONRAD Frederic
The leon3 board is looking for u-boot.bin by default (LEON3_PROM_FILENAME).. But in the case this file is not found and no other file are given on the command line we get the following error: $ ./qemu-system-sparc -M leon3_generic qemu-system-sparc: Can't read bios image (null) So use

[Qemu-devel] [PATCH v3 4/7] grlib, apbuart: get rid of the old-style create function

2019-05-15 Thread KONRAD Frederic
Suggested-by: Mark Cave-Ayland Signed-off-by: KONRAD Frederic --- hw/char/grlib_apbuart.c | 4 ++-- hw/sparc/leon3.c | 9 - include/hw/sparc/grlib.h | 20 +--- 3 files changed, 11 insertions(+), 22 deletions(-) diff --git a/hw/char/grlib_apbuart.c

[Qemu-devel] [PATCH v3 5/7] leon3: add a little bootloader

2019-05-15 Thread KONRAD Frederic
This adds a little bootloader to the leon3_machine when a ram image is given through the kernel parameter and no bios are provided: * The UART transmiter is enabled. * The TIMER is initialized. Reviewed-by: Fabien Chouteau Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: KONRAD Frederic

[Qemu-devel] [PATCH v3 7/7] MAINTAINERS: add myself for leon3

2019-05-15 Thread KONRAD Frederic
Reviewed-by: Fabien Chouteau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland Signed-off-by: KONRAD Frederic --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index bc54c6d..9424a49 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[Qemu-devel] [PATCH v3 2/7] grlib, irqmp: get rid of the old-style create function

2019-05-15 Thread KONRAD Frederic
Suggested-by: Mark Cave-Ayland Signed-off-by: KONRAD Frederic --- hw/intc/grlib_irqmp.c| 3 +-- hw/sparc/leon3.c | 12 ++-- include/hw/sparc/grlib.h | 31 ++- 3 files changed, 13 insertions(+), 33 deletions(-) diff --git a/hw/intc/grlib_irqmp.c

[Qemu-devel] [PATCH v3 6/7] leon3: introduce the plug and play mechanism

2019-05-15 Thread KONRAD Frederic
This adds the AHB and APB plug and play devices. They are scanned during the linux boot to discover the various peripheral. Reviewed-by: Fabien Chouteau Signed-off-by: KONRAD Frederic --- MAINTAINERS | 2 +- hw/misc/Makefile.objs | 2 +

Re: [Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefix length error message

2019-05-15 Thread Markus Armbruster
Stefano Garzarella writes: > Reword and add a missing parentheses at the end of the > error message. > > Signed-off-by: Stefano Garzarella > Reviewed-by: Marc-André Lureau > --- > v2: > - Reworded the error message (Markus) > - Added Marc-André's R-b > I made a little change to the

[Qemu-devel] [PATCH v3 3/7] grlib, gptimer: get rid of the old-style create function

2019-05-15 Thread KONRAD Frederic
Suggested-by: Mark Cave-Ayland Signed-off-by: KONRAD Frederic --- hw/sparc/leon3.c | 17 - hw/timer/grlib_gptimer.c | 4 ++-- include/hw/sparc/grlib.h | 27 +-- 3 files changed, 19 insertions(+), 29 deletions(-) diff --git a/hw/sparc/leon3.c

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

2019-05-15 Thread Dave Martin
On Wed, May 15, 2019 at 12:28:20PM +0100, Andrea Bolognani wrote: > On Wed, 2019-05-15 at 12:14 +0100, Dave Martin wrote: > > On Wed, May 15, 2019 at 09:03:58AM +0100, Andrea Bolognani wrote: > > > On Tue, 2019-05-14 at 13:14 -0700, Richard Henderson wrote: > > > > Why is =4 less user-friendly

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Dave Martin
On Wed, May 15, 2019 at 12:42:44PM +0100, Andrew Jones wrote: > On Wed, May 15, 2019 at 12:00:45PM +0100, Dave Martin wrote: > > On Wed, May 15, 2019 at 09:18:54AM +0100, Andrew Jones wrote: > > > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > > > On Tue, 14 May 2019 11:02:25

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Dave Martin
On Wed, May 15, 2019 at 12:09:04PM +0100, Dr. David Alan Gilbert wrote: > * Dave Martin (dave.mar...@arm.com) wrote: > > On Wed, May 15, 2019 at 09:18:54AM +0100, Andrew Jones wrote: > > > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > > > On Tue, 14 May 2019 11:02:25 +0200 > >

Re: [Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefix length error message

2019-05-15 Thread Stefano Garzarella
On Wed, May 15, 2019 at 02:33:03PM +0200, Markus Armbruster wrote: > Stefano Garzarella writes: > > > Reword and add a missing parentheses at the end of the > > error message. > > > > Signed-off-by: Stefano Garzarella > > Reviewed-by: Marc-André Lureau > > --- > > v2: > > - Reworded the

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 1/1] target/arm: Fix vector operation segfault

2019-05-15 Thread Alex Bennée
Alistair Francis writes: > Commit 89e68b575 "target/arm: Use vector operations for saturation" > causes this abort() when booting QEMU ARM with a Cortex-A15: You may want to check your email settings because when I tried to apply this patch it failed because the message is base64 encoded

Re: [Qemu-devel] [PATCH v9 00/27] gdbstub: Refactor command packets handler

2019-05-15 Thread Alex Bennée
Jon Doron writes: > This patch series refactors the old gdbstub command packets handler > with a new infrastructure which should ease extending and adding new > and missing gdb command packets. There seems to be some compiler errors and variants that this breaks the CI on:

Re: [Qemu-devel] [PATCH v7 01/24] build: Link user-only with crypto-rng-obj-y

2019-05-15 Thread Laurent Vivier
On 15/05/2019 19:49, Daniel P. Berrangé wrote: > On Wed, May 15, 2019 at 10:22:08AM -0700, Richard Henderson wrote: >> On 5/15/19 9:53 AM, Daniel P. Berrangé wrote: >>> On Tue, May 14, 2019 at 12:16:30PM -0700, Richard Henderson wrote: For user-only, we require only the random number bits of

[Qemu-devel] [PATCH 2/4] iotests.py: Let assert_qmp() accept an array

2019-05-15 Thread Max Reitz
Sometimes we cannot tell which error message qemu will emit, and we do not care. With this change, we can then just pass an array of all possible messages to assert_qmp() and it will choose the right one. Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 18 -- 1

[Qemu-devel] [PATCH 3/4] iotests.py: Fix VM.run_job

2019-05-15 Thread Max Reitz
log() is in the current module, there is no need to prefix it. In fact, doing so may make VM.run_job() unusable in tests that never use iotests.log() themselves. Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL 05/21] megasas: fix mapped frame size

2019-05-15 Thread Paolo Bonzini
From: Peter Lieven the current value of 1024 bytes (16 * MFI_FRAME_SIZE) we map is not enough to hold the maximum number of scatter gather elements we advertise. We actually need a maximum of 2048 bytes. This is 128 max sg elements * 16 bytes (sizeof (union mfi_sgl)). Cc:

[Qemu-devel] [PULL 03/21] Declare -realtime as deprecated

2019-05-15 Thread Paolo Bonzini
From: Thomas Huth The old -realtime mlock=on|off parameter does exactly the same as the new -overcommit mem-lock=on|off parameter. Additionally, "-realtime" does not activate any additional "realtime" capabilities as the name might indicate. We should avoid to confuse the users this way, so

[Qemu-devel] [PULL 00/21] Misc patches for 2019-05-15

2019-05-15 Thread Paolo Bonzini
The following changes since commit e329ad2ab72c43b56df88b34954c2c7d839bb373: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190513' into staging (2019-05-14 10:08:47 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to

[Qemu-devel] [PULL 02/21] roms: assert if max rom size is less than the used size

2019-05-15 Thread Paolo Bonzini
From: Igor Mammedov It would ensure that we would notice attempt to write beyond the allocated buffer. In case of MemoryRegion backed ROM it's the host buffer and the guest RAM otherwise. assert can be triggered with: dd if=/dev/zero of=/tmp/blob bs=63k count=1 qemu-system-x86_64 `for i in

[Qemu-devel] [PULL 19/21] ioapic: allow buggy guests mishandling level-triggered interrupts to make progress

2019-05-15 Thread Paolo Bonzini
From: Vitaly Kuznetsov It was found that Hyper-V 2016 on KVM in some configurations (q35 machine + piix4-usb-uhci) hangs on boot. Root-cause was that one of Hyper-V level-triggered interrupt handler performs EOI before fixing the cause of the interrupt. This results in IOAPIC keep re-raising the

[Qemu-devel] [PULL 18/21] build: don't build hardware objects with linux-user

2019-05-15 Thread Paolo Bonzini
From: Laurent Vivier Some objects are only needed for system emulation and tools. We can ignore them for the user mode case Update tests to run accordingly: conditionally build some tests on CONFIG_BLOCK. Some tests use components that are only built when softmmu or block tools are enabled,

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Dr. David Alan Gilbert
* Dave Martin (dave.mar...@arm.com) wrote: > On Wed, May 15, 2019 at 09:15:20AM +0100, Andrew Jones wrote: > > On Tue, May 14, 2019 at 03:32:13PM +0200, Markus Armbruster wrote: > > > Syntax that can support such growth would be nice. > > > > > > To grow a single unsigned number, we can make it

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Dr. David Alan Gilbert
* Dave Martin (dave.mar...@arm.com) wrote: > On Wed, May 15, 2019 at 09:18:54AM +0100, Andrew Jones wrote: > > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > > On Tue, 14 May 2019 11:02:25 +0200 > > > Andrew Jones wrote: > > > > My thought is primarily machines. If a human

Re: [Qemu-devel] [PATCH 1/4] qapi: Support features for structs

2019-05-15 Thread Peter Krempa
On Wed, May 15, 2019 at 12:58:46 +0200, Kevin Wolf wrote: > Am 18.04.2019 um 22:03 hat Markus Armbruster geschrieben: > > Kevin Wolf writes: > > > > > Sometimes, the behaviour of QEMU changes compatibly, but without a > > > change in the QMP syntax (usually by allowing values or operations that

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

2019-05-15 Thread Andrea Bolognani
On Wed, 2019-05-15 at 12:14 +0100, Dave Martin wrote: > On Wed, May 15, 2019 at 09:03:58AM +0100, Andrea Bolognani wrote: > > On Tue, 2019-05-14 at 13:14 -0700, Richard Henderson wrote: > > > Why is =4 less user-friendly than =512? > > > > > > I don't actually see "total bits in vector" as more

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Andrew Jones
On Wed, May 15, 2019 at 12:00:45PM +0100, Dave Martin wrote: > On Wed, May 15, 2019 at 09:18:54AM +0100, Andrew Jones wrote: > > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > > On Tue, 14 May 2019 11:02:25 +0200 > > > Andrew Jones wrote: > > > > My thought is primarily

Re: [Qemu-devel] [PATCH v9 09/27] gdbstub: Implement set register (P pkt) with new infra

2019-05-15 Thread Alex Bennée
Jon Doron writes: > Signed-off-by: Jon Doron > --- > gdbstub.c | 39 ++- > 1 file changed, 30 insertions(+), 9 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index b42425b24c..10e3f12a68 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -1634,6

[Qemu-devel] [PATCH v3 0/8] WIP: Multifd compression support

2019-05-15 Thread Juan Quintela
v3: - improve the code - address David and Markus comments - make compression code into methods so we can add any other method ading just three functions Please review, as far as I know everything is ok now. Todo: Add zstd support v2: - improve the code left and right - Split better the zlib

[Qemu-devel] [PATCH v3 1/8] migration: fix multifd_recv event typo

2019-05-15 Thread Juan Quintela
It uses num in multifd_send(). Make it coherent. Signed-off-by: Juan Quintela --- migration/trace-events | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/trace-events b/migration/trace-events index de2e136e57..cd50a1e659 100644 --- a/migration/trace-events +++

[Qemu-devel] [PATCH v3 2/8] migration-test: rename parameter to parameter_int

2019-05-15 Thread Juan Quintela
We would need _str ones on the next patch. Signed-off-by: Juan Quintela --- tests/migration-test.c | 49 +- 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index bd3f5c3125..0b25aa3d6c 100644

[Qemu-devel] [PATCH v3 3/8] tests: Add migration multifd test

2019-05-15 Thread Juan Quintela
We set multifd-channels. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Signed-off-by: Juan Quintela --- tests/migration-test.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index

[Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter

2019-05-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- Rename it to NONE Fix typos (dave) --- hmp.c| 17 + hw/core/qdev-properties.c| 13 + include/hw/qdev-properties.h | 1 + migration/migration.c| 16 qapi/migration.json |

[Qemu-devel] [PATCH v3 4/8] migration-test: introduce functions to handle string parameters

2019-05-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/migration-test.c | 37 + 1 file changed, 37 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index ff480e0682..65d5e256a7 100644 --- a/tests/migration-test.c +++ b/tests/migration-test.c @@

[Qemu-devel] [PATCH v3 7/8] multifd: Add zlib compression support

2019-05-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/core/qdev-properties.c | 2 +- migration/migration.c | 9 migration/migration.h | 1 + migration/ram.c | 47 +++ qapi/migration.json | 2 +- tests/migration-test.c| 6 + 6 files

[Qemu-devel] [PATCH v3 6/8] migration: Make none operations into its own structure

2019-05-15 Thread Juan Quintela
It will be used later. Signed-off-by: Juan Quintela --- migration/ram.c | 54 - 1 file changed, 49 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 1ca9ba77b6..6679e4f213 100644 --- a/migration/ram.c +++

Re: [Qemu-devel] [PATCH 1/4] qapi: Support features for structs

2019-05-15 Thread Kevin Wolf
Am 18.04.2019 um 22:03 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Sometimes, the behaviour of QEMU changes compatibly, but without a > > change in the QMP syntax (usually by allowing values or operations that > > previously resulted in an error). QMP clients may still need to

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Dave Martin
On Wed, May 15, 2019 at 09:18:54AM +0100, Andrew Jones wrote: > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > On Tue, 14 May 2019 11:02:25 +0200 > > Andrew Jones wrote: > > > My thought is primarily machines. If a human wants to use the command > > > line and SVE, then I'm

  1   2   3   >