[Qemu-devel] [PATCH] spapr: Print out extra hints when CAS negotiation of interrupt mode fails

2019-05-16 Thread Greg Kurz
Let's suggest to the user how the machine should be configured to allow the guest to boot successfully. Suggested-by: Satheesh Rajendran Signed-off-by: Greg Kurz --- hw/ppc/spapr_hcall.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spa

Re: [Qemu-devel] [PATCH v4 6/6] acpi: pci: use build_append_foo() API to construct MCFG

2019-05-16 Thread Wei Yang
On Wed, May 15, 2019 at 07:29:17AM +0200, Philippe Mathieu-Daudé wrote: > >Thanks Michael for testing... > >Wei, can you add a MCFG test in tests/bios-tables-test.c? > I took a look into the test, current q35 has already has a reference MCFG in tests/data/acpi/q35/MCFG. And there would be a warn

Re: [Qemu-devel] [PATCH] spapr: Print out extra hints when CAS negotiation of interrupt mode fails

2019-05-16 Thread Satheesh Rajendran
On Thu, May 16, 2019 at 09:36:57AM +0200, Greg Kurz wrote: > Let's suggest to the user how the machine should be configured to allow > the guest to boot successfully. > > Suggested-by: Satheesh Rajendran > Signed-off-by: Greg Kurz > --- > hw/ppc/spapr_hcall.c |4 ++-- > 1 file changed, 2 in

Re: [Qemu-devel] [PATCH v9 2/7] virtio-pmem: Add virtio pmem driver

2019-05-16 Thread Pankaj Gupta
> > > + vpmem->vdev = vdev; > > + vdev->priv = vpmem; > > + err = init_vq(vpmem); > > + if (err) { > > + dev_err(&vdev->dev, "failed to initialize virtio pmem vq's\n"); > > + goto out_err; > > + } > > + > > + virtio_cread(vpmem->vdev, struct virtio_pmem_config, >

Re: [Qemu-devel] [PATCH] [RFC] qcow2: add compression type feature

2019-05-16 Thread Denis Plotnikov
On 29.04.2019 1:32, Max Reitz wrote: > On 05.02.19 10:08, Denis Plotnikov wrote: >> The patch adds some preparation parts for incompatible compression type >> feature into QCOW2 header that indicates that *all* compressed clusters >> must be (de)compressed using a certain compression type. >> >>

Re: [Qemu-devel] [PATCH v9 2/7] virtio-pmem: Add virtio pmem driver

2019-05-16 Thread Pankaj Gupta
> >> + vpmem->vdev = vdev; > >> + vdev->priv = vpmem; > >> + err = init_vq(vpmem); > >> + if (err) { > >> + dev_err(&vdev->dev, "failed to initialize virtio pmem vq's\n"); > >> + goto out_err; > >> + } > >> + > >> + virtio_cread(vpmem->vdev, struct virtio_pmem_config, > >>

Re: [Qemu-devel] [PATCH] spapr: Print out extra hints when CAS negotiation of interrupt mode fails

2019-05-16 Thread Cédric Le Goater
On 5/16/19 9:45 AM, Satheesh Rajendran wrote: > On Thu, May 16, 2019 at 09:36:57AM +0200, Greg Kurz wrote: >> Let's suggest to the user how the machine should be configured to allow >> the guest to boot successfully. >> >> Suggested-by: Satheesh Rajendran >> Signed-off-by: Greg Kurz >> --- >> hw

Re: [Qemu-devel] [PATCH v2 1/4] net: fix assertion failure when ipv6-prefixlen is not a number

2019-05-16 Thread Markus Armbruster
Stefano Garzarella writes: > If 'ipv6-prefixlen' is not a number, the current behaviour > produces an assertion failure: > $ qemu-system-x86_64 -net user,ipv6-net=feca::0/a > qemu-system-x86_64: qemu/util/qemu-option.c:1175: qemu_opts_foreach: > Assertion `!errp || !*errp' failed. >

Re: [Qemu-devel] [PULL 22/27] vl: Create block backends before setting machine properties

2019-05-16 Thread Michal Privoznik
On 3/11/19 11:08 PM, Markus Armbruster wrote: qemu-system-FOO's main() acts on command line arguments in its own idiosyncratic order. There's not much method to its madness. Whenever we find a case where one kind of command line argument needs to refer to something created for another kind later

Re: [Qemu-devel] [PATCH v2 2/4] net: avoid using variable length array in net_client_init()

2019-05-16 Thread Markus Armbruster
Stefano Garzarella writes: > net_client_init() uses a variable length array to store the prefix > of 'ipv6-net' parameter (e.g. if ipv6-net=fec0::0/64, the prefix > is 'fec0::0'). > This patch introduces g_strsplit() to split the 'ipv6-net' parameter, > so we can remove the variable length array.

Re: [Qemu-devel] [PATCH] spapr: Print out extra hints when CAS negotiation of interrupt mode fails

2019-05-16 Thread Satheesh Rajendran
On Thu, May 16, 2019 at 10:32:15AM +0200, Greg Kurz wrote: > On Thu, 16 May 2019 10:22:26 +0200 > Cédric Le Goater wrote: > > > On 5/16/19 9:45 AM, Satheesh Rajendran wrote: > > > On Thu, May 16, 2019 at 09:36:57AM +0200, Greg Kurz wrote: > > >> Let's suggest to the user how the machine should

Re: [Qemu-devel] [PATCH] spapr: Print out extra hints when CAS negotiation of interrupt mode fails

2019-05-16 Thread Greg Kurz
On Thu, 16 May 2019 10:22:26 +0200 Cédric Le Goater wrote: > On 5/16/19 9:45 AM, Satheesh Rajendran wrote: > > On Thu, May 16, 2019 at 09:36:57AM +0200, Greg Kurz wrote: > >> Let's suggest to the user how the machine should be configured to allow > >> the guest to boot successfully. > >> > >> S

Re: [Qemu-devel] [PATCH v2 3/4] net: use g_strsplit() for parsing host address and port

2019-05-16 Thread Markus Armbruster
Stefano Garzarella writes: > Use the glib function to split host address and port in > the parse_host_port() function. > > Suggested-by: Markus Armbruster > Signed-off-by: Stefano Garzarella Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 4/4] net: remove unused get_str_sep() function

2019-05-16 Thread Markus Armbruster
Stefano Garzarella writes: > Since the get_str_sep() function is no longer used in > net/net.c, we can remove it. > > Signed-off-by: Stefano Garzarella Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 1/5] vfio: vfio_iommu_type1: linux header place holder

2019-05-16 Thread Pierre Morel
On 12/05/2019 20:22, Michael S. Tsirkin wrote: On Fri, May 10, 2019 at 04:38:49PM +0200, Pierre Morel wrote: This should be copied from Linux kernel UAPI includes. Signed-off-by: Pierre Morel pls add a note which linux version did you sync with. I will, thanks. Pierre --- linux-heade

Re: [Qemu-devel] [PATCH 3/5] s390: vfio_pci: Use a PCI Group structure

2019-05-16 Thread Pierre Morel
On 14/05/2019 13:49, Cornelia Huck wrote: On Fri, 10 May 2019 16:38:51 +0200 Pierre Morel wrote: We use a S390PCIGroup structure to hold the information related to zPCI Function group. This allows us to be ready to support multiple groups and to retrieve the group information from the host.

Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent

2019-05-16 Thread Peter Maydell
On Thu, 16 May 2019 at 06:37, Markus Armbruster wrote: > > Peter Maydell writes: > > > In commit 80376c3fc2c38fdd453 in 2010 we added a workaround for > > some qbus buses not being connected to qdev devices -- if the > > bus has no parent object then we register a reset function which > > resets

Re: [Qemu-devel] [PATCH 00/11] kvm/migration: support KVM_CLEAR_DIRTY_LOG

2019-05-16 Thread Peter Xu
On Thu, May 09, 2019 at 10:33:19AM +0800, Peter Xu wrote: > On Wed, May 08, 2019 at 01:55:07PM +0200, Paolo Bonzini wrote: > > On 08/05/19 06:39, Peter Xu wrote: > > >> The disadvantage of this is that you won't clear in the kernel those > > >> dirty bits that come from other sources (e.g. vhost or

Re: [Qemu-devel] [PATCH v2] migration/dirty-bitmaps: change bitmap enumeration method

2019-05-16 Thread Vladimir Sementsov-Ogievskiy
14.05.2019 23:19, John Snow wrote: > Shift from looking at every root BDS to *every* BDS. This will migrate > bitmaps that are attached to blockdev created nodes instead of just ones > attached to emulated storage devices. > > Note that this will not migrate anonymous or internal-use bitmaps, as >

Re: [Qemu-devel] [PATCH v13 09/12] Add rx-softmmu

2019-05-16 Thread Philippe Mathieu-Daudé
On 5/16/19 7:52 AM, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > Tested-by: Philippe Mathieu-Daudé > > Using only CONFIG_RX=y: Richard: Can you drop the previous "Using only CONFIG_RX=y" line? It was related to an older series. Thanks! > Reviewed-by: Philippe Mathieu-Daudé > > Sig

Re: [Qemu-devel] [PATCH v12 00/12] Add RX archtecture support

2019-05-16 Thread Philippe Mathieu-Daudé
Hi Yoshinori, On 5/16/19 6:13 AM, Yoshinori Sato wrote: > On Thu, 16 May 2019 01:48:29 +0900, > Richard Henderson wrote: [...]>> Rather than having you send out a v13 with only changes to the tags, I will >> apply them myself while preparing an initial pull request for this. >> >> Thanks for your

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 6/6] migration: Block migration while handling machine check

2019-05-16 Thread Greg Kurz
On Mon, 22 Apr 2019 12:33:45 +0530 Aravinda Prasad wrote: > Block VM migration requests until the machine check > error handling is complete as (i) these errors are > specific to the source hardware and is irrelevant on > the target hardware, (ii) these errors cause data > corruption and should b

Re: [Qemu-devel] [PATCH] [RFC] qcow2: add compression type feature

2019-05-16 Thread Max Reitz
On 16.05.19 09:50, Denis Plotnikov wrote: > > > On 29.04.2019 1:32, Max Reitz wrote: >> On 05.02.19 10:08, Denis Plotnikov wrote: >>> The patch adds some preparation parts for incompatible compression type >>> feature into QCOW2 header that indicates that *all* compressed clusters >>> must be (de

Re: [Qemu-devel] [PATCH] [RFC] qcow2: add compression type feature

2019-05-16 Thread Denis Plotnikov
On 16.05.2019 13:40, Max Reitz wrote: > On 16.05.19 09:50, Denis Plotnikov wrote: >> >> >> On 29.04.2019 1:32, Max Reitz wrote: >>> On 05.02.19 10:08, Denis Plotnikov wrote: The patch adds some preparation parts for incompatible compression type feature into QCOW2 header that indicates

[Qemu-devel] [PATCH] migration: Fix typo in migrate_add_blocker() error message

2019-05-16 Thread Greg Kurz
Signed-off-by: Greg Kurz --- migration/migration.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 609e0df5d0c0..c15e75e0eebe 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1714,7 +1714,7 @@ int migrate

Re: [Qemu-devel] [PATCH v4 6/6] acpi: pci: use build_append_foo() API to construct MCFG

2019-05-16 Thread Philippe Mathieu-Daudé
On Thu, May 16, 2019 at 9:41 AM Wei Yang wrote: > > On Wed, May 15, 2019 at 07:29:17AM +0200, Philippe Mathieu-Daudé wrote: > > > >Thanks Michael for testing... > > > >Wei, can you add a MCFG test in tests/bios-tables-test.c? > > > > I took a look into the test, current q35 has already has a refer

Re: [Qemu-devel] [PATCH v2] iotests: Filter 175's allocation information

2019-05-16 Thread Max Reitz
On 13.05.19 17:52, Max Reitz wrote: > It is possible for an empty file to take up blocks on a filesystem. > Make iotest 175 take this into account. > > Reported-by: Thomas Huth > Signed-off-by: Max Reitz > --- > v2: [Nir] > - Use a function for filtering > - s/empty_blocks/extra_blocks/ > --- >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 6/6] migration: Block migration while handling machine check

2019-05-16 Thread Aravinda Prasad
On Thursday 16 May 2019 04:24 PM, Greg Kurz wrote: > On Mon, 22 Apr 2019 12:33:45 +0530 > Aravinda Prasad wrote: > >> Block VM migration requests until the machine check >> error handling is complete as (i) these errors are >> specific to the source hardware and is irrelevant on >> the target

[Qemu-devel] [PATCH] configure: only link capstone to emulation targets

2019-05-16 Thread Daniel P . Berrangé
Only the emulators link to code that uses capstone, so adding it to the global LIBs places undesirable dependancies on other binaries, in particular the tools. There is no variable that covers both user emulation and machine emulation, so add a new "$libs_cpu" for this purpose. In particular this

Re: [Qemu-devel] [PATCH v2 2/4] net: avoid using variable length array in net_client_init()

2019-05-16 Thread Stefano Garzarella
On Thu, May 16, 2019 at 10:44:20AM +0200, Markus Armbruster wrote: > Stefano Garzarella writes: > > > net_client_init() uses a variable length array to store the prefix > > of 'ipv6-net' parameter (e.g. if ipv6-net=fec0::0/64, the prefix > > is 'fec0::0'). > > This patch introduces g_strsplit() t

Re: [Qemu-devel] [Qemu-block] [PATCH v3 1/3] block: introducing 'bdrv_co_delete_file' interface

2019-05-16 Thread Daniel Henrique Barboza
Hi John, On 5/13/19 4:47 PM, John Snow wrote: It looks like this one has gone un-noticed for a little while. On 3/26/19 5:17 PM, Daniel Henrique Barboza wrote: Adding to Block Drivers the capability of being able to clean up its created files can be useful in certain situations. For the LUKS d

Re: [Qemu-devel] [PULL 22/27] vl: Create block backends before setting machine properties

2019-05-16 Thread Markus Armbruster
Michal Privoznik writes: > On 3/11/19 11:08 PM, Markus Armbruster wrote: >> qemu-system-FOO's main() acts on command line arguments in its own >> idiosyncratic order. There's not much method to its madness. >> Whenever we find a case where one kind of command line argument needs >> to refer to s

Re: [Qemu-devel] [PATCH] spapr/xive: Sanity checks of OV5 during CAS

2019-05-16 Thread David Gibson
On Thu, May 16, 2019 at 08:58:14AM +0200, Greg Kurz wrote: > On Thu, 16 May 2019 12:09:57 +0530 > Satheesh Rajendran wrote: > > > On Wed, May 15, 2019 at 07:04:24PM +0200, Greg Kurz wrote: > > > If a machine is started with ic-mode=xive but the guest only knows > > > about XICS, eg. an RHEL 7.6 g

Re: [Qemu-devel] [PULL 00/21] Misc patches for 2019-05-15

2019-05-16 Thread Peter Maydell
On Wed, 15 May 2019 at 21:52, Paolo Bonzini wrote: > > The following changes since commit e329ad2ab72c43b56df88b34954c2c7d839bb373: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190513' into > staging (2019-05-14 10:08:47 +0100) > > are available in the git repository at: > > >

[Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes

2019-05-16 Thread Michael S. Tsirkin
The following changes since commit efb4f3b62c69383a7308d7b739a3193e7c0ccae8: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-05-10 14:49:36 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_u

[Qemu-devel] [PULL 02/37] Revert "globals: Allow global properties to be optional"

2019-05-16 Thread Michael S. Tsirkin
From: Daniel P. Berrangé This reverts commit d7741743f4f3d2683d1bb6938f88dc0167c21afa. Relying on setting properties on parents types which may not be relevant to certain sub-classes had unexpected side-effects causing bugs in device config defaults. It is preferrable to be explicit about which

[Qemu-devel] [PULL 06/37] vhost-user-blk: Use started flag in vhost_user_blk_set_status()

2019-05-16 Thread Michael S. Tsirkin
From: Xie Yongji Use started flag in vhost_user_blk_set_status() to decide if starting vhost-user backend or not. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu Message-Id: <20190320112646.3712-4-xieyon...@baidu.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- h

[Qemu-devel] [PULL 15/37] do not call vhost_net_cleanup() on running net from char user event

2019-05-16 Thread Michael S. Tsirkin
From: Dan Streetman Buglink: https://launchpad.net/bugs/1823458 Currently, a user CHR_EVENT_CLOSED event will cause net_vhost_user_event() to call vhost_user_cleanup(), which calls vhost_net_cleanup() for all its queues. However, vhost_net_cleanup() must never be called like this for fully-init

[Qemu-devel] [PULL 01/37] hw: report invalid disable-legacy|modern usage for virtio-1-only devs

2019-05-16 Thread Michael S. Tsirkin
From: Daniel P. Berrangé A number of virtio devices (gpu, crypto, mouse, keyboard, tablet) only support the virtio-1 (aka modern) mode. Currently if the user launches QEMU, setting those devices to enable legacy mode, QEMU will silently create them in modern mode, ignoring the user's (mistaken) r

[Qemu-devel] [PULL 03/37] docs: reST-ify vhost-user documentation

2019-05-16 Thread Michael S. Tsirkin
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20190315180735.13096-1-marcandre.lur...@redhat.com> Reviewed-by: Jens Freimann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- docs/interop/vhost-user.txt | 1219 --- MAINT

[Qemu-devel] [PULL 08/37] vhost-user-blk: Add return value for vhost_user_blk_start()

2019-05-16 Thread Michael S. Tsirkin
From: Xie Yongji Add a return value for vhost_user_blk_start() to check whether we start vhost-user backend successfully or not. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu Message-Id: <20190320112646.3712-6-xieyon...@baidu.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[Qemu-devel] [PULL 23/37] tests: acpi: rename acpi_parse_rsdp_table() into acpi_fetch_rsdp_table()

2019-05-16 Thread Michael S. Tsirkin
From: Igor Mammedov so name would reflect what the function does Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Wei Yang Message-Id: <1556808723-226478-2-git-send-email-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[Qemu-devel] [PULL 05/37] virtio: Use started flag in virtio_vmstate_change()

2019-05-16 Thread Michael S. Tsirkin
From: Xie Yongji Currently, we use DRIVER_OK status bit to check whether guest driver has started the device in virtio_vmstate_change(). But it's not the case for virtio 1.0 transitional devices. If migration completes between kicking virtqueue and setting VIRTIO_CONFIG_S_DRIVER_OK, guest may be

[Qemu-devel] [PULL 09/37] vhost-user-blk: Add support to reconnect backend

2019-05-16 Thread Michael S. Tsirkin
From: Xie Yongji Since we now support the message VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD. The backend is able to restart safely because it can track inflight I/O in shared memory. This patch allows qemu to reconnect the backend after connection closed. Signed-off-by: Xie Yongj

[Qemu-devel] [PULL 04/37] virtio: Introduce started flag to VirtioDevice

2019-05-16 Thread Michael S. Tsirkin
From: Xie Yongji The virtio 1.0 transitional devices support driver uses the device before setting the DRIVER_OK status bit. So we introduce a started flag to indicate whether driver has started the device or not. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu Message-Id: <20190320112646.37

[Qemu-devel] [PULL 27/37] tests: acpi: fetch X_DSDT if pointer to DSDT is 0

2019-05-16 Thread Michael S. Tsirkin
From: Igor Mammedov that way it would be possible to test a DSDT pointed by 64bit X_DSDT field in FADT. PS: it will allow to enable testing arm/virt board, which sets only newer X_DSDT field. Signed-off-by: Igor Mammedov Message-Id: <1556808723-226478-6-git-send-email-imamm...@redhat.com> Revi

[Qemu-devel] [PULL 10/37] contrib/vhost-user-blk: enable inflight I/O tracking

2019-05-16 Thread Michael S. Tsirkin
From: Xie Yongji This patch enables inflight I/O tracking for vhost-user-blk backend so that we could restart it safely. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu Message-Id: <20190320112646.3712-8-xieyon...@baidu.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL 31/37] tests: acpi: add a way to start tests with UEFI firmware

2019-05-16 Thread Michael S. Tsirkin
From: Igor Mammedov For testcase to use UEFI firmware, one needs to provide and specify firmware and varstore blob names in test_data { uefi_fl1, uefi_fl2 } fields respectively and RAM start address plus size where to look for test structure signature. Additionally testcase should specify bootabl

[Qemu-devel] [PULL 14/37] q35: acpi: do not create dummy MCFG table

2019-05-16 Thread Michael S. Tsirkin
From: Igor Mammedov Dummy table (with signature "QEMU") creation came from original SeaBIOS codebase. And QEMU would have to keep it around if there were Q35 machine that depended on keeping ACPI tables blob constant size. Luckily there were no versioned Q35 machine types before commit: (since

[Qemu-devel] [PULL 07/37] vhost-user-blk: Only start vhost-user backend with the first kick

2019-05-16 Thread Michael S. Tsirkin
From: Xie Yongji We should only start vhost-user backend at the first kick for virtio 1.0 transitional devices. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu Message-Id: <20190320112646.3712-5-xieyon...@baidu.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/

[Qemu-devel] [PULL 11/37] acpi/piix4: Convert debug printf()s to trace events

2019-05-16 Thread Michael S. Tsirkin
From: Markus Armbruster Signed-off-by: Markus Armbruster Message-Id: <20190402161900.7374-2-arm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- hw/acpi/piix4.c | 14 +++--- hw/ac

[Qemu-devel] [PULL 16/37] hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start

2019-05-16 Thread Michael S. Tsirkin
From: Wei Yang mcfg_start points to the start of MCFG table and is used in build_header. While this information could be derived from mcfg. This patch removes the unnecessary variable mcfg_start. Signed-off-by: Wei Yang Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-I

[Qemu-devel] [PULL 21/37] pcie: Remove redundant test in pcie_mmcfg_data_{read, write}()

2019-05-16 Thread Michael S. Tsirkin
From: David Gibson These functions have an explicit test for accesses above the device's config size. But pci_host_config_{read,write}_common() which they're about to call already have checks against the config space limit and do the right thing. So, remove the redundant tests. Signed-off-by:

[Qemu-devel] [PULL 35/37] tests: acpi: add simple arm/virt testcase

2019-05-16 Thread Michael S. Tsirkin
From: Igor Mammedov adds simple arm/virt test case that starts guest with bios-tables-test.aarch64.iso.qcow2 boot image which initializes UefiTestSupport* structure in RAM once guest is booted. * see commit: tests: acpi: add acpi_find_rsdp_address_uefi() helper Signed-off-by: Igor Mammedov Re

[Qemu-devel] [PULL 22/37] pci: Simplify pci_bus_is_root()

2019-05-16 Thread Michael S. Tsirkin
From: David Gibson pci_bus_is_root() currently relies on a method in the PCIBusClass. But it's always known if a PCI bus is a root bus when we create it, so using a dynamic method is overkill. This replaces it with an IS_ROOT bit in a new flags field, which is set on root buses and otherwise cle

[Qemu-devel] [PULL 12/37] acpi/pcihp: Convert debug printf()s to trace events

2019-05-16 Thread Michael S. Tsirkin
From: Markus Armbruster Signed-off-by: Markus Armbruster Message-Id: <20190402161900.7374-3-arm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- hw/acpi/pcihp.c | 25 -

[Qemu-devel] [PULL 26/37] tests: acpi: make pointer to RSDP 64bit

2019-05-16 Thread Michael S. Tsirkin
From: Igor Mammedov In case of UEFI, RSDP doesn't have to be located in lowmem, it could be placed at any address. Make sure that test won't break if it is placed above the first 4Gb of address space. PS: While at it cleanup some local variables as we don't really need them. Signed-off-by: Igor

[Qemu-devel] [PULL 13/37] acpi/pcihp: Add a few more trace points related to unplug

2019-05-16 Thread Michael S. Tsirkin
From: Markus Armbruster Signed-off-by: Markus Armbruster Message-Id: <20190402161900.7374-4-arm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Markus Armbruster Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- hw/acpi/pcihp.c

[Qemu-devel] [PULL 32/37] tests: acpi: ignore SMBIOS tests when UEFI firmware is used

2019-05-16 Thread Michael S. Tsirkin
From: Igor Mammedov once FW provides a pointer to SMBIOS entry point like it does for RSDP it should be possible to enable this one the same way. Signed-off-by: Igor Mammedov Reviewed-by: Laszlo Ersek Message-Id: <1556808723-226478-11-git-send-email-imamm...@redhat.com> Tested-by: Philippe Mat

[Qemu-devel] [PULL 28/37] tests: acpi: skip FACS table if board uses hw reduced ACPI profile

2019-05-16 Thread Michael S. Tsirkin
From: Igor Mammedov If FADT has HW_REDUCED_ACPI flag set, do not attempt to fetch FACS as it's not provided by the board. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Wei Yang Message-Id: <1556808723-226478-7-git-send-email-imamm...@redhat.com> Reviewed-by: Mi

[Qemu-devel] [PULL 17/37] i386, acpi: remove mcfg_ prefix in AcpiMcfgInfo members

2019-05-16 Thread Michael S. Tsirkin
From: Wei Yang This is obvious the member in AcpiMcfgInfo describe MCFG's property. Remove the mcfg_ prefix. Signed-off-by: Wei Yang Suggested-by: Igor Mammedov Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190419003053.8260-4-richardw.y...@linux.intel.com> R

[Qemu-devel] [PULL 30/37] tests: acpi: add acpi_find_rsdp_address_uefi() helper

2019-05-16 Thread Michael S. Tsirkin
From: Igor Mammedov introduce UEFI specific counterpart to acpi_find_rsdp_address() that will help to find RSDP address when [OA]VMF is used as firmware. It requires guest firmware or other guest app to place 1Mb aligned UefiTestSupport structure (defined in this patch) in RAM with UefiTestSuppor

[Qemu-devel] [PULL 33/37] tests: acpi: allow to override default accelerator

2019-05-16 Thread Michael S. Tsirkin
From: Igor Mammedov By default test cases were run with 'kvm:tcg' accelerators to speed up tests execution. While it works for x86, were change of accelerator doesn't affect ACPI tables, the approach doesn't works for ARM usecase though. In arm/virt case, KVM mode requires using 'host' cpu model

[Qemu-devel] [PULL 34/37] tests: add expected ACPI tables for arm/virt board

2019-05-16 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Tested-by: Philippe Mathieu-Daudé Message-Id: <1556808723-226478-13-git-send-email-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/data/acpi/virt/APIC | Bin 0 -> 168 bytes tests/data/acpi/virt/

Re: [Qemu-devel] [PATCH] spapr/xive: Sanity checks of OV5 during CAS

2019-05-16 Thread Greg Kurz
On Thu, 16 May 2019 21:46:01 +1000 David Gibson wrote: [...] > > I won't be sending a pull request for a little while yet, so if you > want to send a followup improving the messages I can fold it into the > original patch in my tree. > Done. https://patchwork.ozlabs.org/patch/1100396/ pgpfY

[Qemu-devel] [PULL 18/37] hw/arm/virt-acpi-build: pass AcpiMcfgInfo to build_mcfg()

2019-05-16 Thread Michael S. Tsirkin
From: Wei Yang To build MCFG, two information is necessary: * bus number * base address Abstract these two information to AcpiMcfgInfo so that build_mcfg and build_mcfg_q35 will have the same declaration. Signed-off-by: Wei Yang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor M

[Qemu-devel] [PULL 19/37] hw/acpi: Consolidate build_mcfg to pci.c

2019-05-16 Thread Michael S. Tsirkin
From: Wei Yang Now we have two identical build_mcfg functions. Consolidate them in acpi/pci.c. Signed-off-by: Wei Yang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov Message-Id: <20190419003053.8260-6-richardw.y...@linux.intel.com> Reviewed-by: Michael S. Tsirkin Signed-off

[Qemu-devel] [PULL 37/37] tests: acpi: print error unable to dump ACPI table during rebuild

2019-05-16 Thread Michael S. Tsirkin
From: Igor Mammedov Instead of just asserting print the error that lead to assert first. While at it move assert into rebuild branch, which removes redundant check done in case of !rebuild branch is taken (the later is taken care of by g_assert_no_error). Signed-off-by: Igor Mammedov Reviewed-b

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-16 Thread Collin Walling
On 5/14/19 5:04 AM, Christian Borntraeger wrote: On 14.05.19 11:00, David Hildenbrand wrote: On 14.05.19 10:56, Christian Borntraeger wrote: On 14.05.19 10:50, David Hildenbrand wrote: On 14.05.19 10:37, Christian Borntraeger wrote: On 14.05.19 09:28, David Hildenbrand wrote: But that

[Qemu-devel] [PULL 20/37] libvhost-user: fix bad vu_log_write

2019-05-16 Thread Michael S. Tsirkin
From: Li Feng Mark dirty as page, the step of each call is 1. Signed-off-by: Li Feng Message-Id: <20190420091016.213160-1-fen...@smartx.com> Reviewed-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- contrib/libvhost-user/libvhost-user.c | 2 +- 1 f

[Qemu-devel] [PATCH 2/2] iotests: test external snapshot with bitmap copying

2019-05-16 Thread Vladimir Sementsov-Ogievskiy
This test shows that external snapshots and incremental backups are friends. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/254 | 52 + tests/qemu-iotests/254.out | 53 ++ tests/qemu-iotests/group |

Re: [Qemu-devel] [PATCH v13 10/12] hw/registerfields.h: Add 8bit and 16bit register macros.

2019-05-16 Thread Philippe Mathieu-Daudé
Hi Yoshinori, On 5/16/19 7:52 AM, Yoshinori Sato wrote: > Some RX peripheral using 8bit and 16bit registers. > Added 8bit and 16bit APIs. > > Signed-off-by: Yoshinori Sato > Reviewed-by: Richard Henderson > --- > include/hw/registerfields.h | 32 +++- > 1 file chang

Re: [Qemu-devel] [PATCH v13 11/12] qemu/bitops.h: Add extract8 and extract16

2019-05-16 Thread Philippe Mathieu-Daudé
On 5/16/19 7:52 AM, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > Reviewed-by: Richard Henderson > --- > include/qemu/bitops.h | 38 ++ > 1 file changed, 38 insertions(+) > > diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h > index 3f0926c

Re: [Qemu-devel] [PULL 02/21] roms: assert if max rom size is less than the used size

2019-05-16 Thread Thomas Huth
On 15/05/2019 22.50, Paolo Bonzini wrote: > From: Igor Mammedov > > It would ensure that we would notice attempt to write beyond > the allocated buffer. In case of MemoryRegion backed ROM it's > the host buffer and the guest RAM otherwise. > > assert can be triggered with: > dd if=/dev/zero of

[Qemu-devel] [PULL 24/37] tests: acpi: make acpi_fetch_table() take size of fetched table pointer

2019-05-16 Thread Michael S. Tsirkin
From: Igor Mammedov Currently acpi_fetch_table() assumes 32 bit size of table pointer in ACPI tables. However X_foo variants are 64 bit, prepare acpi_fetch_table() to handle both by adding an argument for addr_ptr pointed entry size. Follow up commits will use that to read XSDT and X_foo entries

Re: [Qemu-devel] [PATCH 1/4] block: Improve "Block node is read-only" message

2019-05-16 Thread Alberto Garcia
On Wed 15 May 2019 10:15:00 PM CEST, Max Reitz wrote: > This message does not make any sense when it appears as the response to > making an R/W node read-only. We should detect that case and emit a > different message, then. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PULL 00/16] migration queue

2019-05-16 Thread Peter Maydell
On Tue, 14 May 2019 at 19:36, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > The following changes since commit e329ad2ab72c43b56df88b34954c2c7d839bb373: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190513' into > staging (2019-05-14 10:08:47 +0100)

[Qemu-devel] [PULL 25/37] tests: acpi: make RSDT test routine handle XSDT

2019-05-16 Thread Michael S. Tsirkin
From: Igor Mammedov If RSDP revision is more than 0 fetch table pointed by XSDT and fallback to legacy RSDT table otherwise. While at it drop unused acpi_get_xsdt_address(). Signed-off-by: Igor Mammedov Message-Id: <1556808723-226478-4-git-send-email-imamm...@redhat.com> Reviewed-by: Wei Yang

Re: [Qemu-devel] [PATCH 2/4] iotests.py: Let assert_qmp() accept an array

2019-05-16 Thread Alberto Garcia
On Wed 15 May 2019 10:15:01 PM CEST, Max Reitz wrote: > Sometimes we cannot tell which error message qemu will emit, and we do > not care. With this change, we can then just pass an array of all > possible messages to assert_qmp() and it will choose the right one. > > Signed-off-by: Max Reitz Re

Re: [Qemu-devel] [RFC 00/17] multi-phase reset mechanism

2019-05-16 Thread Peter Maydell
On Mon, 25 Mar 2019 at 11:02, Damien Hedde wrote: > > Hi all, > > This series is a proposal to implement the multi-phase reset we've discussed > here (https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00310.html) and > more recently there > (https://lists.gnu.org/archive/html/qemu-devel/201

[Qemu-devel] [PULL 29/37] tests: acpi: move boot_sector_init() into x86 tests branch

2019-05-16 Thread Michael S. Tsirkin
From: Igor Mammedov boot_sector_init() won't be used by arm/virt board, so move it from global scope to x86 branch that uses it. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1556808723-226478-8-git-send-email-imamm...@redhat.com> Tested-by: Philippe Mathieu-Dau

Re: [Qemu-devel] [PULL 22/27] vl: Create block backends before setting machine properties

2019-05-16 Thread Michal Privoznik
On 5/16/19 1:43 PM, Markus Armbruster wrote: Actually, there is more problems with this. Trying to run a guest with persistent reservations fails after this patch is applied (git bisect points me to this commit). My command line is: qemu.git $ ./x86_64-softmmu/qemu-system-x86_64 \ -monitor std

[Qemu-devel] [PULL 36/37] tests: acpi: refactor rebuild-expected-aml.sh to dump ACPI tables for a specified list of targets

2019-05-16 Thread Michael S. Tsirkin
From: Igor Mammedov Make initial list contain aarch64 and x86_64 targets. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1556808723-226478-15-git-send-email-imamm...@redhat.com> Reviewed-by: Wei Yang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsi

Re: [Qemu-devel] [PATCH v13 12/12] MAINTAINERS: Add RX

2019-05-16 Thread Philippe Mathieu-Daudé
On 5/16/19 7:52 AM, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > Reviewed-by: Richard Henderson > --- > MAINTAINERS | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index a73a61a546..ef6a02702e 100644 > --- a/MAINTAINERS > +++

[Qemu-devel] [PATCH 0/2] bitmaps: merge bitmaps from different nodes

2019-05-16 Thread Vladimir Sementsov-Ogievskiy
Hi all! We need to copy bitmaps to new top node on external snapshot, to not break incremental backup chain. The only thing to do is to allow block-dirty-bitmap-merge to work with different nodes, here it is. Vladimir Sementsov-Ogievskiy (2): qapi: support external bitmaps in block-dirty-bitma

[Qemu-devel] [PATCH 1/2] qapi: support external bitmaps in block-dirty-bitmap-merge

2019-05-16 Thread Vladimir Sementsov-Ogievskiy
Add new optional parameter making possible to merge bitmaps from different nodes. It is needed to maintain external snapshots during incremental backup chain history. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 13 ++--- block/dirty-bitmap.c | 9 ++--- blo

Re: [Qemu-devel] [PATCH 3/4] iotests.py: Fix VM.run_job

2019-05-16 Thread Alberto Garcia
On Wed 15 May 2019 10:15:02 PM CEST, Max Reitz wrote: > log() is in the current module, there is no need to prefix it. In fact, > doing so may make VM.run_job() unusable in tests that never use > iotests.log() themselves. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto

[Qemu-devel] [Bug 1823458] Re: race condition between vhost_net_stop and CHR_EVENT_CLOSED on shutdown crashes qemu

2019-05-16 Thread Dan Streetman
see bug 1829245 for regression introduced by this patch; these patches will be reverted from xenial, and then re-uploaded along with a patch for the regression in bug 1829380 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bug

Re: [Qemu-devel] [PATCH v13 07/12] hw/char: RX62N serial communication interface (SCI)

2019-05-16 Thread Philippe Mathieu-Daudé
On 5/16/19 7:52 AM, Yoshinori Sato wrote: > This module supported only non FIFO type. > Hardware manual. > https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf > > Signed-off-by: Yoshinori Sato > Reviewed-by: Alex Bennée > --- > include/hw/char/renesas_sci.h

Re: [Qemu-devel] [PATCH v9 00/27] gdbstub: Refactor command packets handler

2019-05-16 Thread Alex Bennée
Alex Bennée writes: > Jon Doron writes: > >> This patch series refactors the old gdbstub command packets handler >> with a new infrastructure which should ease extending and adding new >> and missing gdb command packets. > > Jon, > > > Finally it would be nice if we could modernise the membuf

Re: [Qemu-devel] [PATCH v13 06/12] hw/timer: RX62N internal timer modules

2019-05-16 Thread Philippe Mathieu-Daudé
Hi Yoshinori, On 5/16/19 7:52 AM, Yoshinori Sato wrote: > renesas_tmr: 8bit timer modules. > renesas_cmt: 16bit compare match timer modules. > This part use many renesas's CPU. > Hardware manual. > https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf > > Signe

Re: [Qemu-devel] [PATCH v2] iotests: Filter 175's allocation information

2019-05-16 Thread Nir Soffer
On Thu, May 16, 2019 at 2:03 PM Max Reitz wrote: > On 13.05.19 17:52, Max Reitz wrote: > > It is possible for an empty file to take up blocks on a filesystem. > > Make iotest 175 take this into account. > > > > Reported-by: Thomas Huth > > Signed-off-by: Max Reitz > > --- > > v2: [Nir] > > - Us

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-16 Thread Jakub Jermar
Hi, On 5/3/19 12:02 PM, Jakub Jermar wrote: > Hi, > > On 4/23/19 4:58 PM, Jakub Jermar wrote: >> Hi Philippe! >> >> On 4/23/19 3:48 PM, Philippe Mathieu-Daudé wrote: >>> Hi Jakub, >>> >>> On 4/23/19 1:00 PM, Jakub Jermář wrote: This commit addresses QEMU Bug #1825311: mips_cpu_ha

Re: [Qemu-devel] [Qemu-block] [PATCH 0/9] Assembly coroutine backend and x86 CET support

2019-05-16 Thread Peter Maydell
On Wed, 15 May 2019 at 10:48, Stefan Hajnoczi wrote: > > On Thu, May 09, 2019 at 02:44:39PM +0100, Peter Maydell wrote: > > On Sun, 5 May 2019 at 16:41, Alex Bennée wrote: > > > > > > > > > Paolo Bonzini writes: > > > > > > > *** BLURB HERE *** > > > > > > I assume there was going to be a bit mo

Re: [Qemu-devel] [PATCH v13 05/12] hw/intc: RX62N interrupt controller (ICUa)

2019-05-16 Thread Philippe Mathieu-Daudé
On 5/16/19 7:52 AM, Yoshinori Sato wrote: > This implementation supported only ICUa. > Hardware manual. > https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf > > Signed-off-by: Yoshinori Sato > Reviewed-by: Alex Bennée > --- > include/hw/intc/rx_icu.h |

Re: [Qemu-devel] [PATCH 0/2] target/arm: Minor bit field improvements

2019-05-16 Thread Peter Maydell
On Tue, 14 May 2019 at 02:11, Richard Henderson wrote: > > The tcg extract2 patch on which this depended is now in master. > > > r~ > > > Richard Henderson (2): > target/arm: Use extract2 for EXTR > target/arm: Simplify BFXIL expansion Applied to target-arm.next, thanks. -- PMM

Re: [Qemu-devel] [PATCH v13 00/12] Add RX archtecture support

2019-05-16 Thread Philippe Mathieu-Daudé
On 5/16/19 7:52 AM, Yoshinori Sato wrote: > Hello. > This patch series is added Renesas RX target emulation. > > Add "Reviewed-by" for all changes. > > My git repository is bellow. > git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20190514 > > Testing binaries bellow. > u-boot > Downlo

Re: [Qemu-devel] [PATCH v13 02/12] target/rx: TCG helper

2019-05-16 Thread Philippe Mathieu-Daudé
On 5/16/19 7:52 AM, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > Reviewed-by: Richard Henderson > --- > target/rx/helper.h| 31 > target/rx/helper.c| 148 > target/rx/op_helper.c | 481 > ++ > 3 files chan

Re: [Qemu-devel] [RFC 0/3] target/m68k: convert to transaction_failed hook

2019-05-16 Thread Peter Maydell
On Fri, 3 May 2019 at 18:12, Laurent Vivier wrote: > > On 10/12/2018 17:56, Peter Maydell wrote: > > This patchset converts the m68k target from the deprecated > > unassigned_access hook to the new transaction_failed hook. > > It's RFC for a couple of reasons: > > * it's untested, since I don't

Re: [Qemu-devel] [PATCH v2] iotests: Filter 175's allocation information

2019-05-16 Thread Max Reitz
On 16.05.19 15:06, Nir Soffer wrote: > On Thu, May 16, 2019 at 2:03 PM Max Reitz > wrote: > > On 13.05.19 17:52, Max Reitz wrote: > > It is possible for an empty file to take up blocks on a filesystem. > > Make iotest 175 take this into account. > > >

  1   2   3   >