Re: [Qemu-devel] [PATCH] spapr/xive: Add proper rollback to kvmppc_xive_connect()

2019-06-18 Thread Cédric Le Goater
On 16/06/2019 19:22, Greg Kurz wrote: > Make kvmppc_xive_disconnect() able to undo the changes of a partial > execution of kvmppc_xive_connect() and use it to perform rollback. > > Based-on: <20190614165920.12670-2-...@kaod.org> > Signed-off-by: Greg Kurz Reviewed-by: Cédric Le Goater Thanks,

Re: [Qemu-devel] [PATCH] xics/spapr: Only emulated XICS should use RTAS/hypercalls emulation

2019-06-18 Thread Cédric Le Goater
On 17/06/2019 13:55, Greg Kurz wrote: > Checking that we're not using the in-kernel XICS is ok with the "xics" > interrupt controller mode, but it is definitely not enough with the > other modes since the guest could be using XIVE. > > Ensure XIVE is not in use when emulated XICS RTAS/hypercalls a

Re: [Qemu-devel] [RFC PATCH v2 06/35] multi-process: build system for remote device process

2019-06-18 Thread Kevin Wolf
Am 18.06.2019 um 08:24 hat Gerd Hoffmann geschrieben: > Hi, > > > +# > > +# remote-pci-obj-y is common code used by remote devices > > + > > +remote-pci-obj-$(CONFIG_MPQEMU) += hw/ > > +remote-pci-obj-$(CONFIG_MPQEMU) += qom/ > > +remote-pc

Re: [Qemu-devel] [PATCH 5/6] xics/kvm: Add error propagation to ic*_set_kvm_state() functions

2019-06-18 Thread Cédric Le Goater
On 17/06/2019 15:46, Greg Kurz wrote: > This allows errors happening there to be propagated up to spapr_irq, > just like XIVE already does. > > Signed-off-by: Greg Kurz Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/intc/xics.c| 39 ++- >

Re: [Qemu-devel] [PATCH 6/6] xics/kvm: Add proper rollback to xics_kvm_init()

2019-06-18 Thread Cédric Le Goater
On 17/06/2019 15:47, Greg Kurz wrote: > Make xics_kvm_disconnect() able to undo the changes of a partial execution > of xics_kvm_connect() and use it to perform rollback. > > Note that kvmppc_define_rtas_kernel_token(0) never fails, no matter the > RTAS call has been defined or not. > > Signed-of

Re: [Qemu-devel] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
17.06.2019 19:25, Kevin Wolf wrote: > Am 17.06.2019 um 18:01 hat Max Reitz geschrieben: > Should new implicit/explicit > filters be created above or under them? That was always the most difficult question we had when we introduced filters. The problem is that we nev

Re: [Qemu-devel] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
17.06.2019 17:56, Max Reitz wrote: > On 17.06.19 12:36, Vladimir Sementsov-Ogievskiy wrote: >> 14.06.2019 23:03, Max Reitz wrote: >>> On 14.06.19 18:22, Vladimir Sementsov-Ogievskiy wrote: 14.06.2019 15:57, Max Reitz wrote: > On 14.06.19 11:04, Vladimir Sementsov-Ogievskiy wrote: >> 13

Re: [Qemu-devel] [PATCH 0/4] qapi: block-dirty-bitmap-remove transaction action

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
17.06.2019 19:03, Kevin Wolf wrote: > Am 17.06.2019 um 13:37 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 08.06.2019 1:26, John Snow wrote: >>> >>> >>> On 6/3/19 8:00 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all! Here is block-dirty-bitmap-remove transaction action. I

Re: [Qemu-devel] [PATCH 0/4] qapi: block-dirty-bitmap-remove transaction action

2019-06-18 Thread Kevin Wolf
Am 18.06.2019 um 09:31 hat Vladimir Sementsov-Ogievskiy geschrieben: > 17.06.2019 19:03, Kevin Wolf wrote: > > Am 17.06.2019 um 13:37 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> 08.06.2019 1:26, John Snow wrote: > >>> > >>> > >>> On 6/3/19 8:00 AM, Vladimir Sementsov-Ogievskiy wrote: >

Re: [Qemu-devel] [PATCH 0/3] block: blk_co_pcache

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
17.06.2019 16:20, Kevin Wolf wrote: > Am 17.06.2019 um 15:09 hat Eric Blake geschrieben: >> On 6/17/19 7:09 AM, Kevin Wolf wrote: >> > > Hmm, don't you think that blk_co_pcache sends NBD_CMD_CACHE if called on > nbd driver? > I didn't implement it. But may be I should.. > >

Re: [Qemu-devel] [PATCH 4/4] xen: Avoid VLA

2019-06-18 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 17 June 2019 18:37 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Stefano Stabellini > > Subject: Re: [PATCH 4/4] xen: Avoid VLA > > On Mon, Jun 17, 2019 at 05:39:09PM

Re: [Qemu-devel] [Xen-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c

2019-06-18 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 17 June 2019 18:19 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; Stefano Stabellini > ; qemu-devel@nongnu.org > Subject: Re: [Xen-devel] [PATCH 3/4] xen: Import Xen public headers used by >

Re: [Qemu-devel] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-18 Thread Kevin Wolf
Am 18.06.2019 um 09:19 hat Vladimir Sementsov-Ogievskiy geschrieben: > 17.06.2019 19:25, Kevin Wolf wrote: > > The first step would be making the block drivers full replacements of > > the old things, which unfortunately isn't true today. > > > > After your "deal with filters" series, we should be

Re: [Qemu-devel] [PATCH 0/3] block: blk_co_pcache

2019-06-18 Thread Kevin Wolf
Am 18.06.2019 um 09:38 hat Vladimir Sementsov-Ogievskiy geschrieben: > 17.06.2019 16:20, Kevin Wolf wrote: > > Am 17.06.2019 um 15:09 hat Eric Blake geschrieben: > >> On 6/17/19 7:09 AM, Kevin Wolf wrote: > >> > > > > Hmm, don't you think that blk_co_pcache sends NBD_CMD_CACHE if called >

Re: [Qemu-devel] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
18.06.2019 11:20, Kevin Wolf wrote: > Am 18.06.2019 um 09:19 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 17.06.2019 19:25, Kevin Wolf wrote: >>> The first step would be making the block drivers full replacements of >>> the old things, which unfortunately isn't true today. >>> >>> After your "d

[Qemu-devel] [PATCH] hw/arm/boot: fix direct kernel boot setup

2019-06-18 Thread Andrew Jones
We need to check ram_end, not ram_size. Fixes: 852dc64d665f ("hw/arm/boot: Diagnose layouts that put initrd or DTB off the end of RAM") Signed-off-by: Andrew Jones --- hw/arm/boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index b2f93f6bef

Re: [Qemu-devel] [PATCH] target/ppc: fix compile error in kvmppc_define_rtas_kernel_token()

2019-06-18 Thread David Gibson
On Sat, Jun 15, 2019 at 10:12:52AM +0200, Cédric Le Goater wrote: > gcc9 reports : > > In file included from /usr/include/string.h:494, > from ./include/qemu/osdep.h:101, > from ./target/ppc/kvm.c:17: > In function ‘strncpy’, > inlined from ‘kvmppc_define_rtas

Re: [Qemu-devel] [PATCH] xics: Add comment about CPU hotplug

2019-06-18 Thread David Gibson
On Mon, Jun 17, 2019 at 04:10:33PM +0200, Greg Kurz wrote: > So that no one is tempted to drop that code, which is never called > for cold plugged CPUs. > > Signed-off-by: Greg Kurz Applied, thanks. > --- > hw/intc/xics.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/intc/xic

Re: [Qemu-devel] [PATCH v3 00/15] target/ppc: remove getVSR()/putVSR() and further tidy-up

2019-06-18 Thread David Gibson
On Sun, Jun 16, 2019 at 01:37:36PM +0100, Mark Cave-Ayland wrote: > With the conversion of PPC VSX registers to host endian during the 4.0 > development > cycle, the VSX helpers getVSR() and putVSR() which were used to convert > between big > endian and host endian (and are currently just a no-op

[Qemu-devel] [PATCH] spapr_pci: Fix DRC owner in spapr_dt_pci_bus()

2019-06-18 Thread Greg Kurz
spapr_dt_drc() scans the aliases of all DRConnector objects and filters the ones that it will use to generate OF properties according to their owner and type. Passing bus->parent_dev _works_ if bus belongs to a PCI bridge, but it is NULL if it is the PHB's root bus. This causes all allocated PCI D

Re: [Qemu-devel] [QEMU PATCH v3 4/9] KVM: i386: Block migration for vCPUs exposed with nested virtualization

2019-06-18 Thread Dr. David Alan Gilbert
* Liran Alon (liran.a...@oracle.com) wrote: > Commit d98f26073beb ("target/i386: kvm: add VMX migration blocker") > added a migration blocker for vCPU exposed with Intel VMX. > However, migration should also be blocked for vCPU exposed with > AMD SVM. > > Both cases should be blocked because QEMU

[Qemu-devel] [PATCH 2/2] aspeed: add a GPIO controller to the SoC

2019-06-18 Thread Rashmica Gupta
Signed-off-by: Rashmica Gupta --- hw/arm/aspeed_soc.c | 17 + include/hw/arm/aspeed_soc.h | 3 +++ 2 files changed, 20 insertions(+) diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c index 1cc98b9f40..8583869acf 100644 --- a/hw/arm/aspeed_soc.c +++ b/hw/arm/aspeed_s

[Qemu-devel] [PATCH 0/2] Add Aspeed GPIO controller model

2019-06-18 Thread Rashmica Gupta
Hi, These two patches add a bunch of the functionality of the ast2400 and ast2500 gpio controllers. This is based off upstream/master with two of Cédric's patches: - aspeed: add a per SoC mapping for the interrupt space - aspeed: add a per SoC mapping for the memory space Any feedback would be

[Qemu-devel] [PATCH 1/2] hw/gpio: Add basic Aspeed GPIO model

2019-06-18 Thread Rashmica Gupta
Add in details for GPIO controller for AST 2400 and 2500 Signed-off-by: Rashmica Gupta --- hw/gpio/Makefile.objs | 1 + hw/gpio/aspeed_gpio.c | 869 ++ include/hw/gpio/aspeed_gpio.h | 76 +++ 3 files changed, 946 insertions(+) create mode 10064

Re: [Qemu-devel] [RFC PATCH v2 00/35] Initial support of multi-process qemu

2019-06-18 Thread Daniel P . Berrangé
On Mon, Jun 17, 2019 at 11:14:50AM -0700, elena.ufimts...@oracle.com wrote: > From: Elena Ufimtseva > > Initial support of multi-process qemu > > Started with the presentation in October 2017 made by > Marc-Andre (Red Hat) and Konrad Wilk (Oracle) > (http://events17.linuxfoundation.org/sites/eve

Re: [Qemu-devel] [QEMU PATCH v3 6/9] vmstate: Add support for kernel integer types

2019-06-18 Thread Dr. David Alan Gilbert
* Liran Alon (liran.a...@oracle.com) wrote: > Reviewed-by: Nikita Leshenko > Reviewed-by: Maran Wilson > Signed-off-by: Liran Alon > --- > include/migration/vmstate.h | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/include/migration/vmstate.h b/include/migration/vm

Re: [Qemu-devel] [PULL 16/16] vl: Deprecate -mon pretty=... for HMP monitors

2019-06-18 Thread Daniel P . Berrangé
On Mon, Jun 17, 2019 at 08:49:03PM +0200, Markus Armbruster wrote: > From: Kevin Wolf > > The -mon pretty=on|off switch of the -mon option applies only to QMP > monitors. It's silently ignored for HMP. Deprecate this combination so > that we can make it an error in future versions. No objection

Re: [Qemu-devel] [QEMU PATCH v3 7/9] KVM: i386: Add support for save and restore nested state

2019-06-18 Thread Dr. David Alan Gilbert
* Liran Alon (liran.a...@oracle.com) wrote: > Kernel commit 8fcc4b5923af ("kvm: nVMX: Introduce KVM_CAP_NESTED_STATE") > introduced new IOCTLs to extract and restore vCPU state related to > Intel VMX & AMD SVM. > > Utilize these IOCTLs to add support for migration of VMs which are > running nested

Re: [Qemu-devel] [QEMU PATCH v3 8/9] KVM: i386: Add support for KVM_CAP_EXCEPTION_PAYLOAD

2019-06-18 Thread Dr. David Alan Gilbert
* Liran Alon (liran.a...@oracle.com) wrote: > Kernel commit c4f55198c7c2 ("kvm: x86: Introduce KVM_CAP_EXCEPTION_PAYLOAD") > introduced a new KVM capability which allows userspace to correctly > distinguish between pending and injected exceptions. > > This distinguish is important in case of neste

Re: [Qemu-devel] [PATCH 1/2] hw/gpio: Add basic Aspeed GPIO model

2019-06-18 Thread Cédric Le Goater
On 18/06/2019 10:51, Rashmica Gupta wrote: > Add in details for GPIO controller for AST 2400 and 2500 I agree. C. > > Signed-off-by: Rashmica Gupta > --- > hw/gpio/Makefile.objs | 1 + > hw/gpio/aspeed_gpio.c | 869 ++ > include/hw/gpio/aspe

Re: [Qemu-devel] [RFC PATCH v2 20/35] multi-process: Add QMP & extend HMP commands to list remote info

2019-06-18 Thread Stefan Hajnoczi
On Mon, Jun 17, 2019 at 7:28 PM wrote: > > From: Jagannathan Raman > > Add query-remote QMP command and extend "info" HMP command, to list > the remote objects used by QEMU. > > Signed-off-by: Jagannathan Raman > Signed-off-by: John G Johnson > Signed-off-by: Elena Ufimtseva > --- > hmp-comma

Re: [Qemu-devel] [PATCH 2/2] aspeed: add a GPIO controller to the SoC

2019-06-18 Thread Cédric Le Goater
On 18/06/2019 10:51, Rashmica Gupta wrote: > Signed-off-by: Rashmica Gupta > --- > hw/arm/aspeed_soc.c | 17 + > include/hw/arm/aspeed_soc.h | 3 +++ > 2 files changed, 20 insertions(+) > > diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c > index 1cc98b9f40..858386

[Qemu-devel] [PATCH v10] ssh: switch from libssh2 to libssh

2019-06-18 Thread Pino Toscano
Rewrite the implementation of the ssh block driver to use libssh instead of libssh2. The libssh library has various advantages over libssh2: - easier API for authentication (for example for using ssh-agent) - easier API for known_hosts handling - supports newer types of keys in known_hosts Use AP

Re: [Qemu-devel] [PATCH 0/2] Add Aspeed GPIO controller model

2019-06-18 Thread Cédric Le Goater
On 18/06/2019 10:51, Rashmica Gupta wrote: > Hi, > > These two patches add a bunch of the functionality of the ast2400 and > ast2500 gpio controllers. > > This is based off upstream/master with two of Cédric's patches: > - aspeed: add a per SoC mapping for the interrupt space > - aspeed: add a p

Re: [Qemu-devel] [PATCH v4 1/5] net/announce: Allow optional list of interfaces

2019-06-18 Thread Dr. David Alan Gilbert
* Jason Wang (jasow...@redhat.com) wrote: > > On 2019/6/13 下午5:59, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Allow the caller to restrict the set of interfaces that announces are > > sent on. The default is still to send on all interfaces. > > > > e.g. > >

Re: [Qemu-devel] [PATCH] spapr_pci: Fix DRC owner in spapr_dt_pci_bus()

2019-06-18 Thread David Gibson
On Tue, Jun 18, 2019 at 10:42:53AM +0200, Greg Kurz wrote: > spapr_dt_drc() scans the aliases of all DRConnector objects and filters > the ones that it will use to generate OF properties according to their > owner and type. > > Passing bus->parent_dev _works_ if bus belongs to a PCI bridge, but it

[Qemu-devel] [Bug 1833204] [NEW] VM failed to start in nested virtualization with error "KVM: entry failed, hardware error 0x0"

2019-06-18 Thread Wei, Yu
Public bug reported: Hi, I have 3 ubuntu nodes provisioned by IaaS. Then I tried to launch VM again in my ubuntu nodes. It's a little strange that VM could be started successfully in two nodes. And always failed in one nodes with error "KVM: entry failed, hardware error 0x0". When using virs

Re: [Qemu-devel] [PATCH 1/6] target/arm: NS BusFault on vector table fetch escalates to NS HardFault

2019-06-18 Thread Peter Maydell
On Mon, 17 Jun 2019 at 20:28, Richard Henderson wrote: > > On 6/17/19 10:53 AM, Peter Maydell wrote: > > + * The HardFault is Secure if BFHFNMINS is 0 (meaning that all HFs are > > + * secure); otherwise it targets the same security state as the > > + * underlying exception. > >

Re: [Qemu-devel] [PULL 16/16] vl: Deprecate -mon pretty=... for HMP monitors

2019-06-18 Thread Kevin Wolf
Am 18.06.2019 um 11:01 hat Daniel P. Berrangé geschrieben: > On Mon, Jun 17, 2019 at 08:49:03PM +0200, Markus Armbruster wrote: > > From: Kevin Wolf > > > > The -mon pretty=on|off switch of the -mon option applies only to QMP > > monitors. It's silently ignored for HMP. Deprecate this combination

Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-18 Thread Roman Kagan
On Tue, Jun 18, 2019 at 11:24:57AM +1000, Vadim Rozenfeld wrote: > On Mon, 2019-06-17 at 14:49 -0300, Eduardo Habkost wrote: > > On Mon, Jun 17, 2019 at 05:32:13PM +, Roman Kagan wrote: > > > On Mon, Jun 17, 2019 at 11:23:01AM -0300, Eduardo Habkost wrote: > > > > On Mon, Jun 17, 2019 at 01:48:

[Qemu-devel] [PATCH v2] qemu-ga: Convert invocation documentation to rST

2019-06-18 Thread Peter Maydell
The qemu-ga documentation is currently in qemu-ga.texi in Texinfo format, which we present to the user as: * a qemu-ga manpage * a section of the main qemu-doc HTML documentation Convert the documentation to rST format, and present it to the user as: * a qemu-ga manpage * part of the interop/

Re: [Qemu-devel] [PULL v2 00/16] Monitor patches for 2019-06-17

2019-06-18 Thread Peter Maydell
On Tue, 18 Jun 2019 at 07:29, Markus Armbruster wrote: > > The following changes since commit 076243ffe6c1b687e9e6d98348c3bf3398df78f3: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-docs-20190617' > into staging (2019-06-17 16:41:25 +0100) > > are available in the Git repository

Re: [Qemu-devel] [PATCH] hw/arm/boot: fix direct kernel boot setup

2019-06-18 Thread Peter Maydell
On Tue, 18 Jun 2019 at 09:34, Andrew Jones wrote: > > We need to check ram_end, not ram_size. > > Fixes: 852dc64d665f ("hw/arm/boot: Diagnose layouts that put initrd or > DTB off the end of RAM") > Signed-off-by: Andrew Jones > --- > hw/arm/boot.c | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [Qemu-devel] [Xen-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c

2019-06-18 Thread Anthony PERARD
On Tue, Jun 18, 2019 at 08:55:53AM +0100, Paul Durrant wrote: > > -Original Message- > > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > > > > On Mon, Jun 17, 2019 at 05:45:44PM +0100, Anthony PERARD wrote: > > > On Mon, Jun 17, 2019 at 05:15:51PM +0100, Paul Durrant wrote: > > >

[Qemu-devel] [PATCH] i386: make 'hv-spinlocks' a regular uint32 property

2019-06-18 Thread Roman Kagan
X86CPU.hv-spinlocks is a uint32 property that has a special setter validating the value to be no less than 0xFFF and no bigger than UINT_MAX. The latter check is redundant; as for the former, there appears to be no reason to prohibit the user from setting it to a lower value. So nuke the dedicate

Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-18 Thread Roman Kagan
On Tue, Jun 18, 2019 at 10:35:05AM +, Roman Kagan wrote: > On Tue, Jun 18, 2019 at 11:24:57AM +1000, Vadim Rozenfeld wrote: > > On Mon, 2019-06-17 at 14:49 -0300, Eduardo Habkost wrote: > > > On Mon, Jun 17, 2019 at 05:32:13PM +, Roman Kagan wrote: > > > > On Mon, Jun 17, 2019 at 11:23:01AM

Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-18 Thread Vadim Rozenfeld
On Tue, 2019-06-18 at 10:35 +, Roman Kagan wrote: > On Tue, Jun 18, 2019 at 11:24:57AM +1000, Vadim Rozenfeld wrote: > > On Mon, 2019-06-17 at 14:49 -0300, Eduardo Habkost wrote: > > > On Mon, Jun 17, 2019 at 05:32:13PM +, Roman Kagan wrote: > > > > On Mon, Jun 17, 2019 at 11:23:01AM -0300,

[Qemu-devel] [PATCH v2 4/4] xen: Avoid VLA

2019-06-18 Thread Anthony PERARD
Avoid using a variable length array. We allocate the `dirty_bitmap' buffer only once when we start tracking for dirty bits. Signed-off-by: Anthony PERARD --- Notes: v2: - Allocate the bitmap buffer only once when we start tracking dirty bits. (instead of at every function call)

[Qemu-devel] [PATCH v2 1/4] xen: Fix build with public headers

2019-06-18 Thread Anthony PERARD
Following 37677d7db3 "Clean up a few header guard symbols", QEMU start to fail to build: In file included from ~/xen/tools/../tools/include/xen/io/blkif.h:31:0, from ~/xen/tools/qemu-xen-dir/hw/block/xen_blkif.h:5, from ~/xen/tools/qemu-xen-dir/hw/block/xen-block.

[Qemu-devel] [PATCH v2 2/4] xen: Import other xen/io/*.h

2019-06-18 Thread Anthony PERARD
Following "xen: Fix build with public headers", import other Xen public headers that are describing interfaces. Import fbif.h, kbdif.h, netif.h, console.h, xenbus.h, protocols.h. While editing xenfb.c, remove the include of event_channel.h as it isn't needed. The headers are cleaned up a bit whi

[Qemu-devel] [PATCH v2 0/4] Fix build of Xen support + cleanup

2019-06-18 Thread Anthony PERARD
Hi, Fix the build in osstest and some cleanup For reference: Recent flight failure: https://lists.xenproject.org/archives/html/xen-devel/2019-06/msg01022.html Bisect result: https://lists.xenproject.org/archives/html/xen-devel/2019-06/msg01029.html Thanks. Anthony PERARD (4): xen: Fix build

[Qemu-devel] [PATCH v2 3/4] xen: Drop includes of xen/hvm/params.h

2019-06-18 Thread Anthony PERARD
xen-mapcache.c doesn't needs params.h. xen-hvm.c uses defines available in params.h but so is xen_common.h which is included before. HVM_PARAM_* flags are only needed to make xc_hvm_param_{get,set} calls so including only xenctrl.h, which is where the definition the function is, should be enough.

Re: [Qemu-devel] [PATCH] hw/arm/boot: fix direct kernel boot setup

2019-06-18 Thread Philippe Mathieu-Daudé
On 6/18/19 1:02 PM, Peter Maydell wrote: > On Tue, 18 Jun 2019 at 09:34, Andrew Jones wrote: >> >> We need to check ram_end, not ram_size. >> >> Fixes: 852dc64d665f ("hw/arm/boot: Diagnose layouts that put initrd or >> DTB off the end of RAM") >> Signed-off-by: Andrew Jones Reviewed-by: Philippe

Re: [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model

2019-06-18 Thread Igor Mammedov
On Mon, 17 Jun 2019 13:27:00 -0300 Eduardo Habkost wrote: > On Mon, Jun 17, 2019 at 05:33:43PM +0200, Igor Mammedov wrote: > > On Mon, 17 Jun 2019 17:15:21 +0200 > > Philippe Mathieu-Daudé wrote: > [...] > > > Yes. Eduardo and you should write some lines to explain this, and then > > > we will

Re: [Qemu-devel] [PATCH v2 4/4] xen: Avoid VLA

2019-06-18 Thread Philippe Mathieu-Daudé
On 6/18/19 1:23 PM, Anthony PERARD wrote: > Avoid using a variable length array. > > We allocate the `dirty_bitmap' buffer only once when we start tracking > for dirty bits. > Suggested-by: Paul Durrant Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Anthony PERARD > --- > > Notes: >

[Qemu-devel] [PATCH v7 7/9] qemu/units: add SI decimal units

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/units.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/qemu/units.h b/include/qemu/units.h index 692db3fbb2..52ccc7445c 100644 --- a/include/qemu/units.h +++ b/include/qemu/units.h @@ -17,4 +17,11 @@ #define PiB

[Qemu-devel] [PATCH v7 1/9] block/nbd: split connection_co start out of nbd_client_connect

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
nbd_client_connect is going to be used from connection_co, so, let's refactor nbd_client_connect in advance, leaving io channel configuration all in nbd_client_connect. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/nbd.c | 22 +- 1 file change

[Qemu-devel] [PATCH v7 6/9] qemu-coroutine-sleep: introduce qemu_co_sleep_wake

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
Introduce a function to gracefully wake a coroutine sleeping in qemu_co_sleep_ns(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/coroutine.h| 17 -- block/null.c| 2 +- block/sheepdog.c| 2 +- tests/test-bdrv-drain.c | 6 ++--- t

[Qemu-devel] [PATCH v7 8/9] block/nbd: nbd reconnect

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
Implement reconnect. To achieve this: 1. add new modes: connecting-wait: means, that reconnecting is in progress, and there were small number of reconnect attempts, so all requests are waiting for the connection. connecting-nowait: reconnecting is in progress, there were a lot of

[Qemu-devel] [PATCH v7 2/9] block/nbd: use non-blocking io channel for nbd negotiation

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
No reason to use blocking channel for negotiation and we'll benefit in further reconnect feature, as qio_channel reads and writes will do qemu_coroutine_yield while waiting for io completion. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- include/block/nbd.h | 3 ++- b

[Qemu-devel] [PATCH v7 5/9] block/nbd: refactor nbd connection parameters

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
We'll need some connection parameters to be available all the time to implement nbd reconnect. So, let's refactor them: define additional parameters in BDRVNBDState, drop them from function parameters, drop nbd_client_init and separate options parsing instead from nbd_open. Signed-off-by: Vladimir

[Qemu-devel] [PATCH v7 3/9] block/nbd: move from quit to state

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
To implement reconnect we need several states for the client: CONNECTED, QUIT and two different CONNECTING states. CONNECTING states will be added in the following patches. This patch implements CONNECTED and QUIT. QUIT means, that we should close the connection and fail all current and further re

Re: [Qemu-devel] [PATCH v2 3/4] xen: Drop includes of xen/hvm/params.h

2019-06-18 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 18 June 2019 12:24 > To: qemu-devel@nongnu.org > Cc: Anthony Perard ; Paul Durrant > ; Stefano > Stabellini ; xen-de...@lists.xenproject.org > Subject: [PATCH v2 3/4] xen: Drop includes of xen/hvm/params

[Qemu-devel] [PATCH v7 4/9] block/nbd: add cmdline and qapi parameter reconnect-delay

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
Reconnect will be implemented in the following commit, so for now, in semantics below, disconnect itself is a "serious error". Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- qapi/block-core.json | 11 ++- block/nbd.c | 16 +++- 2 files chang

[Qemu-devel] [PATCH v7 0/9] NBD reconnect

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is NBD reconnect. Previously, if connection failed all current and future requests will fail. After the series, nbd-client driver will try to reconnect unlimited times. During first @reconnect-delay seconds of reconnecting all requests will wait for the connection, and if it is establi

[Qemu-devel] [PATCH v7 9/9] iotests: test nbd reconnect

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
Add test, which starts backup to nbd target and restarts nbd server during backup. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/257| 63 +++ tests/qemu-iotests/257.out| 10 ++ tests/qemu-iotests/group | 1 + tests/qemu-i

Re: [Qemu-devel] [PATCH v2 4/4] xen: Avoid VLA

2019-06-18 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 18 June 2019 12:24 > To: qemu-devel@nongnu.org > Cc: Anthony Perard ; Paul Durrant > ; Stefano > Stabellini ; xen-de...@lists.xenproject.org > Subject: [PATCH v2 4/4] xen: Avoid VLA > > Avoid using a va

Re: [Qemu-devel] [PATCH] hw/arm/boot: fix direct kernel boot setup

2019-06-18 Thread Andrew Jones
On Tue, Jun 18, 2019 at 12:02:37PM +0100, Peter Maydell wrote: > On Tue, 18 Jun 2019 at 09:34, Andrew Jones wrote: > > > > We need to check ram_end, not ram_size. > > > > Fixes: 852dc64d665f ("hw/arm/boot: Diagnose layouts that put initrd or > > DTB off the end of RAM") > > Signed-off-by: Andrew J

Re: [Qemu-devel] [PATCH] hw/arm/boot: fix direct kernel boot setup

2019-06-18 Thread Peter Maydell
On Tue, 18 Jun 2019 at 12:56, Andrew Jones wrote: > > On Tue, Jun 18, 2019 at 12:02:37PM +0100, Peter Maydell wrote: > > On Tue, 18 Jun 2019 at 09:34, Andrew Jones wrote: > > > > > > We need to check ram_end, not ram_size. > > > > > > Fixes: 852dc64d665f ("hw/arm/boot: Diagnose layouts that put i

Re: [Qemu-devel] [Xen-devel] [PATCH v2 0/4] Fix build of Xen support + cleanup

2019-06-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190618112341.513-1-anthony.per...@citrix.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Xen-devel] [PATCH v2 0/4] Fix build of Xen support + cleanup Type: series Message-id: 20190618112341

Re: [Qemu-devel] [RFC PATCH 1/2] target/arm: Add stubs to build with CONFIG_SEMIHOSTING disabled

2019-06-18 Thread Philippe Mathieu-Daudé
On 6/17/19 5:33 PM, Philippe Mathieu-Daudé wrote: > On 6/17/19 5:19 PM, Alex Bennée wrote: >> Philippe Mathieu-Daudé writes: >> >>> If a distribution wants to build QEMU without semihosting support, >>> it currently gets this build failure: >>> >>> $ ./configure --target-list=aarch64-softmmu --w

Re: [Qemu-devel] [PATCH 3/3] target/tricore: Use translate_loop

2019-06-18 Thread Bastian Koppelmann
On 6/17/19 6:45 PM, Richard Henderson wrote: On 6/17/19 7:35 AM, Bastian Koppelmann wrote: +static void tricore_tr_init_disas_context(DisasContextBase *dcbase, + CPUState *cs) { +DisasContext *ctx = container_of(dcbase, DisasContext, base);

Re: [Qemu-devel] [PATCH] hw/arm/boot: fix direct kernel boot setup

2019-06-18 Thread Philippe Mathieu-Daudé
On 6/18/19 1:55 PM, Andrew Jones wrote: > On Tue, Jun 18, 2019 at 12:02:37PM +0100, Peter Maydell wrote: >> On Tue, 18 Jun 2019 at 09:34, Andrew Jones wrote: >>> >>> We need to check ram_end, not ram_size. >>> >>> Fixes: 852dc64d665f ("hw/arm/boot: Diagnose layouts that put initrd or >>> DTB off t

Re: [Qemu-devel] [PATCH v5 24/42] block: Use child access functions for QAPI queries

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
13.06.2019 1:09, Max Reitz wrote: > query-block and query-named-block-nodes now return any filtered child > under "backing", not just bs->backing or COW children. This is so that > filters do not interrupt the reported backing chain. This changes the > output for iotest 184, as the throttled node

Re: [Qemu-devel] [PATCH v2 1/4] xen: Fix build with public headers

2019-06-18 Thread Daniel P . Berrangé
On Tue, Jun 18, 2019 at 12:23:38PM +0100, Anthony PERARD wrote: > Following 37677d7db3 "Clean up a few header guard symbols", QEMU start > to fail to build: > > In file included from ~/xen/tools/../tools/include/xen/io/blkif.h:31:0, > from ~/xen/tools/qemu-xen-dir/hw/block/xen_blk

Re: [Qemu-devel] [PATCH v5 3/8] hw/acpi: Add ACPI Generic Event Device Support

2019-06-18 Thread Auger Eric
Hi Shameer, On 5/22/19 6:22 PM, Shameer Kolothum wrote: > From: Samuel Ortiz > > The ACPI Generic Event Device (GED) is a hardware-reduced specific > device[ACPI v6.1 Section 5.6.9] that handles all platform events, > including the hotplug ones.This patch generates the AML code that . This patch

Re: [Qemu-devel] [PATCH v5 4/8] hw/arm/virt: Add memory hotplug framework

2019-06-18 Thread Auger Eric
Hi Shameer, On 5/22/19 6:22 PM, Shameer Kolothum wrote: > From: Eric Auger > > This patch adds the memory hot-plug/hot-unplug infrastructure > in machvirt. The device memory is not yet exposed to the Guest > either through DT or ACPI and hence both cold/hot plug of memory > is explicitly disable

Re: [Qemu-devel] [PATCH v5 7/8] hw/acpi: Add system power down support to GED

2019-06-18 Thread Auger Eric
Hi Shameer, On 5/22/19 6:22 PM, Shameer Kolothum wrote: > This adds support to use GED for system power down event. > > Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger Thanks Eric > --- > hw/acpi/generic_event_device.c | 16 > include/hw/acpi/generic_event_d

Re: [Qemu-devel] [PATCH v5 5/8] hw/arm/virt: Enable device memory cold/hot plug with ACPI boot

2019-06-18 Thread Auger Eric
Hi Shameer, On 5/22/19 6:22 PM, Shameer Kolothum wrote: > This initializes the GED device with base memory and irq, configures > ged memory hotplug event and builds the corresponding aml code. With > this, both hot and cold plug of device memory is enabled now for Guest > with ACPI boot. > > Memo

Re: [Qemu-devel] [PATCH v5 8/8] hw/arm: Use GED for system_powerdown event

2019-06-18 Thread Auger Eric
Hi Shameer, On 5/22/19 6:22 PM, Shameer Kolothum wrote: > Use GED for system_powerdown event instead of GPIO for ACPI. > Guest boot with DT still uses GPIO.> > Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger Thanks Eric > --- > hw/arm/virt-acpi-build.c | 37 +--

Re: [Qemu-devel] [PATCH] hw/arm/boot: fix direct kernel boot setup

2019-06-18 Thread Andrew Jones
On Tue, Jun 18, 2019 at 12:58:30PM +0100, Peter Maydell wrote: > On Tue, 18 Jun 2019 at 12:56, Andrew Jones wrote: > > > > On Tue, Jun 18, 2019 at 12:02:37PM +0100, Peter Maydell wrote: > > > On Tue, 18 Jun 2019 at 09:34, Andrew Jones wrote: > > > > > > > > We need to check ram_end, not ram_size.

[Qemu-devel] [Bug 1833101] Re: vexpress-a9 (but not -a15) creates two pl111 LCDs due to duplicate sysbus_create_simple("pl111", ...) calls

2019-06-18 Thread David Lindsay
Ah. :) As is probably somewhat evident at this point, I'm using vexpress-a9 because it's such a convenient QEMU target, rather than because I have real hardware anywhere. Hm, I didn't once stop and think that maybe there actually were two LCD controllers. (And this is where software is great; I

Re: [Qemu-devel] [PATCH v5 0/8] ARM virt: ACPI memory hotplug support

2019-06-18 Thread Auger Eric
Hi Shameer, On 5/22/19 6:22 PM, Shameer Kolothum wrote: > This series is an attempt to provide device memory hotplug support > on ARM virt platform. This is based on Eric's recent works here[1] > and carries some of the pc-dimm related patches dropped from his > series. > > The kernel support fo

Re: [Qemu-devel] [PATCH v5 0/8] ARM virt: ACPI memory hotplug support

2019-06-18 Thread Peter Maydell
On Tue, 18 Jun 2019 at 13:52, Auger Eric wrote: > Feel free to add my T-b on next version: > Tested-by: Eric Auger I'm not sure we should carry across Tested-by tags like that: any respin might accidentally introduce bugs that make it stop working... thanks -- PMM

[Qemu-devel] [PATCH] hw/arm/boot: fix direct kernel boot with initrd

2019-06-18 Thread Andrew Jones
Fix the condition used to check whether the initrd fits into RAM; in some cases if an initrd was also passed on the command line we would get an error stating that it was too big to fit into RAM after the kernel. Despite the error the loader continued anyway, though, so also add an exit(1) when the

Re: [Qemu-devel] [PATCH] hw/arm/boot: fix direct kernel boot setup

2019-06-18 Thread Andrew Jones
On Tue, Jun 18, 2019 at 02:50:15PM +0200, Andrew Jones wrote: > On Tue, Jun 18, 2019 at 12:58:30PM +0100, Peter Maydell wrote: > > On Tue, 18 Jun 2019 at 12:56, Andrew Jones wrote: > > > > > > On Tue, Jun 18, 2019 at 12:02:37PM +0100, Peter Maydell wrote: > > > > On Tue, 18 Jun 2019 at 09:34, Andr

[Qemu-devel] [Bug 1833101] Re: vexpress-a9 (but not -a15) creates two pl111 LCDs due to duplicate sysbus_create_simple("pl111", ...) calls

2019-06-18 Thread Peter Maydell
You might want to check our advice on how to pick a machine type for Arm: https://wiki.qemu.org/Documentation/Platforms/ARM#Guidelines_for_choosing_a_QEMU_machine Basically we suggest 'virt' unless you have a strong reason for wanting to emulate something else. NB that we don't support PCI in ou

Re: [Qemu-devel] [PATCH v5 25/42] mirror: Deal with filters

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
13.06.2019 1:09, Max Reitz wrote: > This includes some permission limiting (for example, we only need to > take the RESIZE permission for active commits where the base is smaller > than the top). > > Signed-off-by: Max Reitz ohm, unfortunately I'm far from knowing block/mirror mechanics and inte

Re: [Qemu-devel] [PATCH v10] ssh: switch from libssh2 to libssh

2019-06-18 Thread Max Reitz
On 18.06.19 11:24, Pino Toscano wrote: > Rewrite the implementation of the ssh block driver to use libssh instead > of libssh2. The libssh library has various advantages over libssh2: > - easier API for authentication (for example for using ssh-agent) > - easier API for known_hosts handling > - su

Re: [Qemu-devel] [PULL 0/6] Python queue, 2019-06-11

2019-06-18 Thread Peter Maydell
On Tue, 11 Jun 2019 at 18:15, Eduardo Habkost wrote: > > Changes from 2019-06-07: Python 2 deprecation and Python 3 check > for 3.5+ were removed. > > The following changes since commit 219dca61ebf41625831d4f96a720852baf44b762: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pul

Re: [Qemu-devel] [PATCH] migration: Improve accuracy of vCPU throttling with per-vCPU timers

2019-06-18 Thread Cosmin Marin
On 17/06/2019, 04:46, "Peter Xu" wrote: On Fri, Jun 14, 2019 at 09:11:06AM -0700, Cosmin Marin wrote: > During auto-convergence live migration, the configured throttling rate > is not matched in practice. Experimental measurements of throughput for > a memory-write intensive wor

Re: [Qemu-devel] [PATCH v5 0/8] ARM virt: ACPI memory hotplug support

2019-06-18 Thread Auger Eric
Hi Peter, On 6/18/19 2:57 PM, Peter Maydell wrote: > I'm not sure we should carry across Tested-by tags like that: any > respin might accidentally introduce bugs that make it stop working... OK. No problem. I will test the next version then. Thanks Eric

Re: [Qemu-devel] [PATCH v5 26/42] backup: Deal with filters

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
13.06.2019 1:09, Max Reitz wrote: > Signed-off-by: Max Reitz not sure in completeness (hmm, I'm afraid neither assurance nor completeness is possible for filters yet).. Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model

2019-06-18 Thread Eduardo Habkost
On Tue, Jun 18, 2019 at 01:34:10PM +0200, Igor Mammedov wrote: > On Mon, 17 Jun 2019 13:27:00 -0300 > Eduardo Habkost wrote: > > > On Mon, Jun 17, 2019 at 05:33:43PM +0200, Igor Mammedov wrote: > > > On Mon, 17 Jun 2019 17:15:21 +0200 > > > Philippe Mathieu-Daudé wrote: > > [...] > > > > Yes.

Re: [Qemu-devel] [PATCH v5 29/42] nbd: Use CAF when looking for dirty bitmap

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
13.06.2019 1:09, Max Reitz wrote: > When looking for a dirty bitmap to share, we should handle filters by > just including them in the search (so they do not break backing chains). > > Signed-off-by: Max Reitz > --- > nbd/server.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >

Re: [Qemu-devel] [PULL 0/6] Python queue, 2019-06-11

2019-06-18 Thread Cleber Rosa
On Tue, Jun 18, 2019 at 02:27:29PM +0100, Peter Maydell wrote: > On Tue, 11 Jun 2019 at 18:15, Eduardo Habkost wrote: > > > > Changes from 2019-06-07: Python 2 deprecation and Python 3 check > > for 3.5+ were removed. > > > > The following changes since commit 219dca61ebf41625831d4f96a720852baf44b

[Qemu-devel] [PATCH] blockdev: enable non-root nodes for transaction drive-backup source

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
We forget to enable it for transaction .prepare, while it is already enabled in do_drive_backup since commit a2d665c1bc362 "blockdev: loosen restrictions on drive-backup source node" Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hmm, I've to add John by hand, get_maintainer.pl don't report

[Qemu-devel] [PATCH v21 03/21] hw/registerfields.h: Add 8bit and 16bit register macros

2019-06-18 Thread Yoshinori Sato
From: Philippe Mathieu-Daudé Some RX peripheral using 8bit and 16bit registers. Added 8bit and 16bit APIs. Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-11-ys...@users.sourceforge.jp> Tested-by: Philippe Math

[Qemu-devel] [PATCH v21 08/21] target/rx: Disassemble rx_index_addr into a string

2019-06-18 Thread Yoshinori Sato
From: Richard Henderson We were eliding all zero indexes. It is only ld==0 that does not have an index in the instruction. This also allows us to avoid breaking the final print into multiple pieces. Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-1

[Qemu-devel] [PATCH v21 11/21] target/rx: Dump bytes for each insn during disassembly

2019-06-18 Thread Yoshinori Sato
From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <201906070

  1   2   3   4   >