On 7/26/19 9:09 AM, Pino Toscano wrote:
> Add a 'private-key' option which represents the path of a private key
> to use for authentication, and 'private-key-secret' as the name of an
> object with its passphrase.
>
> Signed-off-by: Pino Toscano
> +++ b/qapi/block-core.json
> @@ -3226,6
On 7/25/19 11:47 PM, tony.ngu...@bt.com wrote:
> To convert interfaces of MemoryRegion access, MEMOP_SIZE and
> SIZE_MEMOP no-op stubs were introduced to change syntax while keeping
> the existing semantics.
>
> Now with interfaces converted, we fill the stubs and use MemOp
> semantics.
>
>
Eric Blake writes:
> On 7/26/19 7:05 AM, Markus Armbruster wrote:
>> In my "build everything" tree, changing a type in qapi/common.json
>> triggers a recompile of some 3600 out of 6600 objects (not counting
>> tests and objects that don't depend on qemu/osdep.h).
>>
>> One common dependency is
On Tue, 2019-07-23 at 11:38 +0800, Jason Wang wrote:
> On 2019/7/20 上午2:52, Oleinik, Alexander wrote:
> > Virtual devices should not try to send zero-sized packets. The
> > caller
> > should check the size prior to calling qemu_sendv_packet_async.
> >
> > Signed-off-by: Alexander Oleinik
> > ---
Hi Michael and Pavel,
The USART was based on the ATMega2560.
It was designed for testing so its functionality is somewhat limited.
Peripherals seem to vary between AVR chips so the configuration in the 2560 may
not match other chips, especially the older ones.
>From memory, the only shared
Handful of bug fixes to sneak in before rc3.
thanks
-- PMM
The following changes since commit c985266ea5b50e46e07b3568c1346e10064205c9:
Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190726' into
staging (2019-07-26 13:52:06 +0100)
are available in the Git repository at:
https
gamepad_state::buttons is a pointer to an array of structs,
not an array of structs, so should be declared in the vmstate
with VMSTATE_STRUCT_VARRAY_POINTER_INT32; otherwise we
corrupt memory on incoming migration.
We bump the vmstate version field as the easiest way to
deal with the migration
From: Damien Hedde
Fix the pl330 main and queue vmstate description.
There were missing POINTER flags causing crashes during
incoming migration because:
+ PL330State chan field is a pointer to an array
+ PL330Queue queue field is a pointer to an array
Also bump corresponding vmsd version
The VMSTATE_STRUCT_VARRAY_UINT32 macro is intended to handle
migrating a field which is an array of structs, but where instead of
migrating the entire array we only migrate a variable number of
elements of it.
The VMSTATE_STRUCT_VARRAY_POINTER_UINT32 macro is intended to handle
migrating a field
On 7/26/19 4:39 AM, Alex Bennée wrote:
> While most features are now detected by probing the ID_* registers
> kernels can (and do) use MIDR_EL1 for working out of they have to
> apply errata. This can trip up warnings in the kernel as it tries to
> work out if it should apply workarounds to
24.07.2019 15:52, John Snow wrote:
>
>
> On 7/24/19 7:12 AM, Vladimir Sementsov-Ogievskiy wrote:
>> 15.07.2019 22:48, John Snow wrote:
>>>
>>>
>>> On 7/8/19 6:04 PM, John Snow wrote:
Hi, this is a proposal based off of Vladimir's patchset:
[Qemu-devel] [PATCH 0/4] qapi:
On Fri, Jul 26, 2019 at 2:55 AM Alistair Francis
wrote:
> Update the Hypervisor CSR addresses to match the v0.4 spec.
>
> Signed-off-by: Alistair Francis
> ---
> target/riscv/cpu_bits.h | 35 ++-
> 1 file changed, 18 insertions(+), 17 deletions(-)
>
> diff --git
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 554 +
target/arm/a32.decode | 32 +++
target/arm/t32.decode | 37 ++-
3 files changed, 302 insertions(+), 321 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 560 ++---
target/arm/a32.decode | 48
target/arm/t32.decode | 46
3 files changed, 396 insertions(+), 258 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index e316eeb312..53c46fcdc4 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -9161,11 +9161,7
Signed-off-by: Richard Henderson
---
target/arm/helper.h| 1 -
target/arm/op_helper.c | 15 -
target/arm/translate.c | 74 +++---
target/arm/a32.decode | 10 ++
target/arm/t32.decode | 9 +
5 files changed, 66 insertions(+), 43
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 94 +++---
target/arm/t16.decode | 33 +++
2 files changed, 38 insertions(+), 89 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index 7b87621315..28f274ca7c
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 152 ++---
target/arm/t16.decode | 36 ++
2 files changed, 43 insertions(+), 145 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index db93b12608..17a0eea425
On Fri, 26 Jul 2019 at 18:51, Richard Henderson
wrote:
>
> We miss quite a number of single-step events by having
> the check in the wrong place.
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/translate.c | 16 ++--
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
>
From: Alistair Francis
Fix a typo in the warning message displayed to users, don't print the
message when running inside qtest and don't mention a specific QEMU
version for the deprecation.
Signed-off-by: Alistair Francis
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Palmer Dabbelt
---
The following changes since commit bf8b024372bf8abf5a9f40bfa65eeefad23ff988:
Update version for v4.1.0-rc2 release (2019-07-23 18:28:08 +0100)
are available in the Git repository at:
git://github.com/palmer-dabbelt/qemu.git tags/riscv-for-master-4.1-rc3
for you to fetch changes up to
John, please see inline...
Regards,
Dmitry
On Thu, 2019-07-25 at 13:58 -0400, John Snow wrote:
>
> On 7/23/19 6:19 PM, Dmitry Fomichev wrote:
> > Currently, attaching zoned block devices (i.e., storage devices
> > compliant to ZAC/ZBC standards) using several virtio methods doesn't
> > work
We can turn logging on/off globally instead of per-function.
Remove use_log from run_job, and use python logging to turn on
diffable output when we run through a script entry point.
(No, I have no idea why output on 245 changed. I really don't.)
Signed-off-by: John Snow
---
Hello
I am working with qemu tracing support and combined with tcg.
I read that if tcg property is used for trace-event, it generates a
trace-event once during translation and another trace-event after the
execution.
I made the following change in target/i386/translate.c
-static inline void
On Fri, Jul 26, 2019 at 10:10:59AM +0100, Stefan Hajnoczi wrote:
> When debug output is disabled there is no need to calculate the number
> of in/out bytes available.
>
> There is also no need to skip a request if there are 0 out bytes. The
> request parsing code already handles invalid
On Fri, Jul 26, 2019 at 10:11:00AM +0100, Stefan Hajnoczi wrote:
> Most lo_do_lookup() have already checked that the parent inode exists.
> lo_lookup() hasn't and can therefore hit a NULL pointer dereference when
> lo_inode(req, parent) returns NULL.
>
Sigh...this one has been fixed by 3
On Fri, Jul 26, 2019 at 2:00 PM Jonathan Behrens wrote:
>
> The remaining checks are not sufficient. If you look at the bottom of csr.c,
> you'll see that for most of the M-mode CSRs the predicate is set to "any"
> which unconditionally allows access regardless of privilege mode. The S-mode
>
Like script_main, but doesn't require a single point of entry.
Replace all existing initialization sections with this drop-in replacement.
This brings debug support to all existing script-style iotests.
Note: supported_oses=['linux'] was omitted, as it is a default argument.
Signed-off-by: John
Based-on: https://github.com/jnsnow/qemu/tree/bitmaps
This is a quick hack-em-up of what it might look like to use python
logging to enable output conditionally on iotests.log(). We unify an
initialization call (which also enables debugging output for those tests
with -d) and then make the switch
Please see patch 1/ for the motivation and utility of this series.
This v1 submission improves on the previous RFC with revised commit
logs, comments, and more testing, and the missing IVRS support for DMA
alias ranges is now included. Testing has been done with Linux guests
with both SeaBIOS and
PCIe requester IDs are used by modern IOMMUs to differentiate devices
in order to provide a unique IOVA address space per device. These
requester IDs are composed of the bus/device/function (BDF) of the
requesting device. Conventional PCI pre-dates this concept and is
simply a shared parallel
When we account for DMA aliases in the PCI address space, we can no
longer use a single IVHD entry in the IVRS covering all devices. We
instead need to walk the PCI bus and create alias ranges when we find
a conventional bus. These alias ranges cannot overlap with a "Select
All" range (as
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1585533
Title:
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1590322
Title:
On 7/25/19 7:59 PM, Peter Maydell wrote:
> On Thu, 25 Jul 2019 at 18:02, Dr. David Alan Gilbert
> wrote:
>>
>> * Peter Maydell (peter.mayd...@linaro.org) wrote:
>>> gamepad_state::buttons is a pointer to an array of structs,
>>> not an array of structs, so should be declared in the vmstate
>>>
On 7/23/2019 10:59 PM, Igor Mammedov wrote:
On Tue, 16 Jul 2019 22:51:11 +0800
Tao Xu wrote:
In struct arm_boot_info, kernel_filename, initrd_filename and
kernel_cmdline are copied from from MachineState. This patch add
MachineState as a parameter into arm_load_dtb() and move the copy chunk
On Fri, Jul 26, 2019 at 06:43:27AM +, tony.ngu...@bt.com wrote:
> Preparation for collapsing the two byte swaps, adjust_endianness and
> handle_bswap, along the I/O path.
>
> Target dependant attributes are conditionalize upon NEED_CPU_H.
>
> Signed-off-by: Tony Nguyen
ppc parts
Acked-by:
On Thu, Jul 25, 2019 at 01:36:38PM +0200, David Hildenbrand wrote:
> As ramblocks cannot get removed/readded while we are processing a bulk
> of inflation requests, there is no more need to track the page size
> in form of the number of subpages.
>
> Suggested-by: David Gibson
> Signed-off-by:
On Thu, Jul 25, 2019 at 09:15:08AM -0500, Shivaprasad G Bhat wrote:
> The logic is broken for multiple vcpu guests, also causing memory leak.
> The logic is in place to handle kvm not having KVM_CAP_PPC_IRQ_LEVEL,
> which is part of the kernel now since 2.6.37. Instead of fixing the
> leak, drop
On Thu, Jul 25, 2019 at 01:36:36PM +0200, David Hildenbrand wrote:
> Using the address of a RAMBlock to test for a matching pbp is not really
> safe. Instead, let's use the guest physical address of the base page
> along with the page size (via the number of subpages).
>
> Also, let's allocate
Signed-off-by: Stefan Hajnoczi
---
contrib/virtiofsd/fuse_kernel.h | 51 ++---
1 file changed, 34 insertions(+), 17 deletions(-)
diff --git a/contrib/virtiofsd/fuse_kernel.h b/contrib/virtiofsd/fuse_kernel.h
index 3186efbed6..7722e0ac23 100644
---
This new FUSE_INIT field communicates the alignment constraint for
FUSE_SETUPMAPPING/FUSE_REMOVEMAPPING.
This feature will be implemented in the next commit.
Signed-off-by: Stefan Hajnoczi
---
contrib/virtiofsd/fuse_kernel.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff
Communicate the host page size to the FUSE client so that
FUSE_SETUPMAPPING/FUSE_REMOVEMAPPING requests are aware of our alignment
constraints.
Signed-off-by: Stefan Hajnoczi
---
contrib/virtiofsd/fuse_lowlevel.c | 8
1 file changed, 8 insertions(+)
diff --git
The client must know the server's alignment constraints for FUSE_SETUPMAPPING
and FUSE_REMOVEMAPPING. This is necessary because mmap(2)/munmap(2) have
alignment constraints and the guest may have a different page size from the
host. The new FUSE_INIT map_alignment field communicates this
On 26/07/2019 09:18, sathn...@linux.vnet.ibm.com wrote:
> From: Satheesh Rajendran
>
> Current acceptance test will not run in powerpc Little endian
> environment due the arch name does not match the qemu binary path,
> let's handle it.
>
> Signed-off-by: Satheesh Rajendran
Reviewed-by:
On 26/07/2019 09:17, sathn...@linux.vnet.ibm.com wrote:
> From: Satheesh Rajendran
>
> This series attempt to add support for avocado acceptance
> test for powerpc and adds linux console boot test.
>
> avocado run boot_linux_console.py:BootLinuxConsole.test_ppc64le_pseries
> version.py vnc.py
On 26/07/2019 09:18, sathn...@linux.vnet.ibm.com wrote:
> From: Satheesh Rajendran
>
> Add pseries linux boot console test
>
> $avocado --show=console run -t arch:ppc64le boot_linux_console.py
> console: SLOF
> **
> console:
On Fri, 26 Jul 2019 at 08:37, Laurent Desnogues
wrote:
> On Fri, Jul 26, 2019 at 9:24 AM Alex Bennée wrote:
> > Peter Maydell writes:
> > > I wonder if we should put 0x51 (ascii 'Q') in the PARTNUM field;
> > > then if somebody really needs to distinguish QEMU from random
> > > other
On Fri, Jul 26, 2019 at 10:37:35AM +0200, Cédric Le Goater wrote:
> On 26/07/2019 09:17, sathn...@linux.vnet.ibm.com wrote:
> > From: Satheesh Rajendran
> >
> > This series attempt to add support for avocado acceptance
> > test for powerpc and adds linux console boot test.
> >
> > avocado run
On Fri, Jul 26, 2019 at 10:40:44AM +0200, Cédric Le Goater wrote:
> On 26/07/2019 09:18, sathn...@linux.vnet.ibm.com wrote:
> > From: Satheesh Rajendran
> >
> > Add pseries linux boot console test
> >
> > $avocado --show=console run -t arch:ppc64le boot_linux_console.py
> > console: SLOF
> >
On Thu, Jul 25, 2019 at 09:30:30AM -0400, Jason Dillaman wrote:
> On Thu, Jul 25, 2019 at 4:13 AM Stefano Garzarella
> wrote:
> >
> > On Wed, Jul 24, 2019 at 01:48:42PM -0400, Jason Dillaman wrote:
> > > On Tue, Jul 23, 2019 at 3:13 AM Stefano Garzarella
> > > wrote:
> > > >
> > > > This patch
On Fri, 26 Jul 2019 at 09:25, Damien Hedde wrote:
> On 7/25/19 7:59 PM, Peter Maydell wrote:
> > As an aside, I'm surprised also the macro doesn't complain
> > that we said the num_buttons field is int32 but it's really "int"...
> > arguably a different kind of missing type check.
>
> We would
This patchset implements the IE (Invert Endian) bit in SPARCv9 MMU TTE.
It is an attempt of the instructions outlined by Richard Henderson to Mark
Cave-Ayland.
Tested with OpenBSD on sun4u. Solaris 10 is my actual goal, but unfortunately a
separate keyboard issue remains in the way.
On 01/11/17
No-op SIZE_MEMOP macro allows us to later easily convert
memory_region_dispatch_{read|write} paramter "unsigned size" into a
size+sign+endianness encoded "MemOp op".
Being a no-op macro, this patch does not introduce any logical change.
Signed-off-by: Tony Nguyen
Reviewed-by: Philippe
To convert interfaces of MemoryRegion access, MEMOP_SIZE and
SIZE_MEMOP no-op stubs were introduced to change syntax while keeping
the existing semantics.
Now with interfaces converted, we fill the stubs and use MemOp
semantics.
Signed-off-by: Tony Nguyen
---
include/exec/memop.h | 5 ++---
No-op MEMOP_SIZE and SIZE_MEMOP macros allows us to later easily
convert memory_region_dispatch_{read|write} paramter "unsigned size"
into a size+sign+endianness encoded "MemOp op".
Being a no-op macro, this patch does not introduce any logical change.
Signed-off-by: Tony Nguyen
---
Now that MemOp has been pushed down into the memory API, we can
collapse the two byte swaps adjust_endianness and handle_bswap into
the former.
Collapsing byte swaps along the I/O path enables additional endian
inversion logic, e.g. SPARC64 Invert Endian TTE bit, with redundant
byte swaps
No-op SIZE_MEMOP macro allows us to later easily convert
memory_region_dispatch_{read|write} paramter "unsigned size" into a
size+sign+endianness encoded "MemOp op".
Being a no-op macro, this patch does not introduce any logical change.
Signed-off-by: Tony Nguyen
---
hw/vfio/pci-quirks.c | 5
The fast path is taken when TLB_FLAGS_MASK is all zero.
TLB_FORCE_SLOW is simply a TLB_FLAGS_MASK bit to force the slow path,
there are no other side effects.
Signed-off-by: Tony Nguyen
---
include/exec/cpu-all.h | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git
Append MemTxAttrs to interfaces so we can pass along up coming Invert
Endian TTE bit on SPARC64.
Signed-off-by: Tony Nguyen
---
target/sparc/mmu_helper.c | 32 ++--
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/target/sparc/mmu_helper.c
Notice new attribute, byte swap, and force the transaction through the
memory slow path.
Required by architectures that can invert endianness of memory
transaction, e.g. SPARC64 has the Invert Endian TTE bit.
Signed-off-by: Tony Nguyen
---
accel/tcg/cputlb.c | 11 +++
This bit configures endianness of PCI MMIO devices. It is used by
Solaris and OpenBSD sunhme drivers.
Tested working on OpenBSD.
Unfortunately Solaris 10 had a unrelated keyboard issue blocking
testing... another inch towards Solaris 10 on SPARC64 =)
Signed-off-by: Tony Nguyen
---
From: Satheesh Rajendran
Add pseries linux boot console test
$avocado --show=console run -t arch:ppc64le boot_linux_console.py
console: SLOF
**
console: QEMU Starting
console: Build Date = Jul 3 2019 12:26:14
console: FW
From: Satheesh Rajendran
Current acceptance test will not run in powerpc Little endian
environment due the arch name does not match the qemu binary path,
let's handle it.
Signed-off-by: Satheesh Rajendran
---
tests/acceptance/avocado_qemu/__init__.py | 4
1 file changed, 4 insertions(+)
From: Satheesh Rajendran
This series attempt to add support for avocado acceptance
test for powerpc and adds linux console boot test.
avocado run boot_linux_console.py:BootLinuxConsole.test_ppc64le_pseries
version.py vnc.py
JOB ID : 918ed65e5e8bc1370c84c166a2c41936a700571e
JOB LOG:
On Wed, Jul 24, 2019 at 07:47:45AM -0500, Shivaprasad G Bhat wrote:
> The KVM_CAP_PPC_IRQ_LEVEL is part of the kernel now since 2.6.37.
> Drop the redundant logic which is not excercised on new the kernels anymore.
> Exit with error on older kernels.
>
> Signed-off-by: Shivaprasad G Bhat
On Wed, Jul 24, 2019 at 11:32:00AM +0200, Cédric Le Goater wrote:
> On 23/07/2019 08:37, David Gibson wrote:
> > On Tue, Jul 23, 2019 at 08:00:27AM +0200, Cédric Le Goater wrote:
> >> On 23/07/2019 03:38, David Gibson wrote:
> >>> On Mon, Jul 22, 2019 at 08:23:47PM +0200, Cédric Le Goater wrote:
>
On Fri, Jul 26, 2019 at 9:24 AM Alex Bennée wrote:
>
>
> Peter Maydell writes:
>
> > On Tue, 23 Jul 2019 at 12:33, Alex Bennée wrote:
[...]
> > /*
> > * Reset MIDR so the guest doesn't mistake our 'max' CPU type for a real
> > * one and try to apply errata workarounds or use impdef
On 25.07.19 19:00, Eric Blake wrote:
> On 7/25/19 10:57 AM, Max Reitz wrote:
>> Several vmdk subformats do not work with iotest 126, so disable them.
>>
>> (twoGbMaxExtentSparse actually should work, but fixing that is a bit
>> difficult. The problem is that the vmdk descriptor file will contain
Change memory_region_dispatch_{read|write} parameter "unsigned size"
to "MemOp op".
The endianness encoded in MemOp will enable the collapse of two byte
swaps, adjust_endianness and handle_bswap, along the I/O path.
Interfaces will be converted in two steps: first syntactically then
Preparation for collapsing the two byte swaps, adjust_endianness and
handle_bswap, along the I/O path.
Target dependant attributes are conditionalize upon NEED_CPU_H.
Signed-off-by: Tony Nguyen
---
MAINTAINERS | 1 +
accel/tcg/cputlb.c | 2
No-op SIZE_MEMOP macro allows us to later easily convert
memory_region_dispatch_{read|write} paramter "unsigned size" into a
size+sign+endianness encoded "MemOp op".
Being a no-op macro, this patch does not introduce any logical change.
Signed-off-by: Tony Nguyen
---
hw/virtio/virtio-pci.c | 7
No-op SIZE_MEMOP macro allows us to later easily convert
memory_region_dispatch_{read|write} paramter "unsigned size" into a
size+sign+endianness encoded "MemOp op".
Being a no-op macro, this patch does not introduce any logical change.
Signed-off-by: Tony Nguyen
Reviewed-by: Philippe
No-op SIZE_MEMOP macro allows us to later easily convert
memory_region_dispatch_{read|write} paramter "unsigned size" into a
size+sign+endianness encoded "MemOp op".
Being a no-op macro, this patch does not introduce any logical change.
Signed-off-by: Tony Nguyen
Reviewed-by: Philippe
No-op SIZE_MEMOP macro allows us to later easily convert
memory_region_dispatch_{read|write} paramter "unsigned size" into a
size+sign+endianness encoded "MemOp op".
Being a no-op macro, this patch does not introduce any logical change.
Signed-off-by: Tony Nguyen
---
hw/s390x/s390-pci-inst.c |
Peter Maydell writes:
> On Tue, 23 Jul 2019 at 12:33, Alex Bennée wrote:
>>
>> While most features are now detected by probing the ID_* registers
>> kernels can (and do) use MIDR_EL1 for working out of they have to
>> apply errata. This can trip up warnings in the kernel as it tries to
>>
On Wed, Jul 24, 2019 at 08:25:04PM +0530, Amol Surati wrote:
> On Wed, Jul 24, 2019 at 06:57:30PM +1000, David Gibson wrote:
> > On Wed, Jul 24, 2019 at 09:11:54AM +0200, Cédric Le Goater wrote:
> > > On 24/07/2019 05:23, David Gibson wrote:
> > > > On Tue, Jul 23, 2019 at 11:01:38AM +0200, Cédric
On Wed, Jul 24, 2019 at 11:33:06AM +0200, Auger Eric wrote:
> Hi Yi, David,
>
> On 7/24/19 6:57 AM, Liu, Yi L wrote:
> >> From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On
> >> Behalf
> >> Of David Gibson
> >> Sent: Tuesday, July 23, 2019 11:58 AM
> >> To: Liu, Yi L
> >>
On Wed, Jul 24, 2019 at 06:57:09PM +0200, Greg Kurz wrote:
> KVM on POWER9 doesn't use the XIVE VP space optimally. This currently
> limits the number of VMs we can start to 127. Starting with the 128th
> one, KVM fails to create the XIVE or the XICS-on-XIVE device and we
> go through the fallback
On Wed, Jul 24, 2019 at 10:50:17AM -0300, Eduardo Habkost wrote:
> On Wed, Jul 24, 2019 at 12:35:24PM +0200, Cornelia Huck wrote:
> > Add 4.2 machine types for arm/i440fx/q35/s390x/spapr.
> >
> > For i440fx and q35, unversioned cpu models are still translated
> > to -v1, as 0788a56bd1ae ("i386:
On 25/07/19 22:30, Michael S. Tsirkin wrote:
> On Thu, Jul 25, 2019 at 05:35:01PM +0200, Paolo Bonzini wrote:
>> On 25/07/19 16:46, Michael S. Tsirkin wrote:
>>> Actually, I think I have a better idea.
>>> At the moment we just get an exit on these reads and return all-ones.
>>> Yes, in theory
On Wed, Jul 24, 2019 at 07:12:31PM +0200, Max Reitz wrote:
> No .bdrv_has_zero_init() implementation returns 1 if growing the file
> would add non-zero areas (at least with PREALLOC_MODE_OFF), so using it
> in lieu of this new function was always safe.
>
> But on the other hand, it is possible
When debug output is disabled there is no need to calculate the number
of in/out bytes available.
There is also no need to skip a request if there are 0 out bytes. The
request parsing code already handles invalid requests.
Signed-off-by: Stefan Hajnoczi
---
contrib/virtiofsd/fuse_virtio.c |
Hold the lock across both lo_map_get() and lo_map_remove() to prevent
races between two FUSE_RELEASE requests. In this case I don't see a
serious bug but it's safer to do things atomically.
Signed-off-by: Stefan Hajnoczi
---
contrib/virtiofsd/passthrough_ll.c | 12
1 file changed,
virtiofsd is not ready for multithreading yet. This patch series starts to
make the code capable of processing multiple FUSE requests simultaneously. I'm
sending these fixes split into several patch series as I make progress auditing
the code for thread-safety issues. The final patch series
Most lo_do_lookup() have already checked that the parent inode exists.
lo_lookup() hasn't and can therefore hit a NULL pointer dereference when
lo_inode(req, parent) returns NULL.
Signed-off-by: Stefan Hajnoczi
---
contrib/virtiofsd/passthrough_ll.c | 4
1 file changed, 4 insertions(+)
fdopendir(3) takes ownership of the file descriptor. The presence of
the lo_dirp->fd field could lead to someone incorrectly adding a
close(d->fd) cleanup call in the future.
Do not store the file descriptor in struct lo_dirp since it is unused.
Signed-off-by: Stefan Hajnoczi
---
Introduce lo_dirp_put() so that FUSE_RELEASEDIR does not cause
use-after-free races with other threads that are accessing lo_dirp.
Also make lo_releasedir() atomic to prevent FUSE_RELEASEDIR racing with
itself. This prevents double-frees.
Signed-off-by: Stefan Hajnoczi
---
On 7/25/19 7:27 PM, Dr. David Alan Gilbert wrote:
> * Peter Maydell (peter.mayd...@linaro.org) wrote:
>> The VMSTATE_STRUCT_VARRAY_UINT32 macro is intended to handle
>> migrating a field which is an array of structs, but where instead of
>> migrating the entire array we only migrate a variable
On 25.07.19 18:27, Kevin Wolf wrote:
> The functionality offered by blk_pread_unthrottled() goes back to commit
> 498e386c584. Then, we couldn't perform I/O throttling with synchronous
> requests because timers wouldn't be executed in polling loops. So the
> commit automatically disabled I/O
On Thu, 25 Jul 2019 at 19:00, Dr. David Alan Gilbert
wrote:
>
> * Peter Maydell (peter.mayd...@linaro.org) wrote:
> > On Thu, 25 Jul 2019 at 18:27, Dr. David Alan Gilbert
> > wrote:
> > >
> > > * Peter Maydell (peter.mayd...@linaro.org) wrote:
> > > > #define type_check_2darray(t1,t2,n,m)
On 26/07/19 08:47, tony.ngu...@bt.com wrote:
> + op = SIZE_MEMOP(size);
> + if (need_bswap(big_endian)) {
> + op ^= MO_BSWAP;
> + }
And this has the same issue as the first version. It should be
op = SIZE_MEMOP(size) | (big_endian ? MO_BE : MO_LE);
and
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> On Thu, 25 Jul 2019 at 19:00, Dr. David Alan Gilbert
> wrote:
> >
> > * Peter Maydell (peter.mayd...@linaro.org) wrote:
> > > On Thu, 25 Jul 2019 at 18:27, Dr. David Alan Gilbert
> > > wrote:
> > > >
> > > > * Peter Maydell
On Fri, 26 Jul 2019 at 10:32, Dr. David Alan Gilbert
wrote:
>
> * Peter Maydell (peter.mayd...@linaro.org) wrote:
> > Would
> >
> > /*
> > * Check that type t2 is an array of type t1 of size n,
> > * eg if t1 is 'foo' and n is 32 then t2 must be 'foo[32]'
> > */
> >
> > be clearer ?
>
> Yep.
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> On Fri, 26 Jul 2019 at 10:32, Dr. David Alan Gilbert
> wrote:
> >
> > * Peter Maydell (peter.mayd...@linaro.org) wrote:
> > > Would
> > >
> > > /*
> > > * Check that type t2 is an array of type t1 of size n,
> > > * eg if t1 is 'foo' and n is
On Wed, Jul 24, 2019 at 07:12:29PM +0200, Max Reitz wrote:
> bdrv_has_zero_init() only has meaning for newly created images or image
> areas. If qemu-img convert did not create the image itself, it cannot
> rely on bdrv_has_zero_init()'s result to carry any meaning.
>
> Signed-off-by: Max Reitz
On 26/07/19 08:47, tony.ngu...@bt.com wrote:
> +static bool memory_region_endianness_inverted(MemoryRegion *mr)
> {
> #ifdef TARGET_WORDS_BIGENDIAN
> return mr->ops->endianness == DEVICE_LITTLE_ENDIAN;
> @@ -361,23 +361,27 @@ static bool
> memory_region_wrong_endianness(MemoryRegion *mr)
>
On Wed, Jul 24, 2019 at 07:12:32PM +0200, Max Reitz wrote:
> We need to implement .bdrv_has_zero_init_truncate() for every block
> driver that supports truncation and has a .bdrv_has_zero_init()
> implementation.
>
> Implement it the same way each driver implements .bdrv_has_zero_init().
> This
On Wed, Jul 24, 2019 at 07:12:33PM +0200, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> block/parallels.c | 2 +-
> block/vhdx.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/parallels.c b/block/parallels.c
> index 00fae125d1..7cd2714b69 100644
>
While most features are now detected by probing the ID_* registers
kernels can (and do) use MIDR_EL1 for working out of they have to
apply errata. This can trip up warnings in the kernel as it tries to
work out if it should apply workarounds to features that don't
actually exist in the reported
1 - 100 of 348 matches
Mail list logo
