[Qemu-devel] [Bug 1839428] [NEW] qemu core dumped when repeat "system_reset" multiple times during guest boot

2019-08-08 Thread Xujun Ma
Public bug reported: commit 864ab314f1d924129d06ac7b571f105a2b76a4b2 (HEAD, tag: v4.1.0-rc4, origin/master, origin/HEAD, master) Test arch:x86 and power Steps: 1.Boot up guest with command power cmdline: /usr/libexec/backup/qemu-kvm \ -smp 8 \ -m 4096 \ -nodefaults \ -device

Re: [Qemu-devel] [PATCH v2] hw: net: cadence_gem: Fix build errors in DB_PRINT()

2019-08-08 Thread Bin Meng
On Thu, Aug 8, 2019 at 3:01 PM Philippe Mathieu-Daudé wrote: > > On 8/8/19 8:36 AM, Bin Meng wrote: > > On Thu, Aug 8, 2019 at 1:21 PM Philippe Mathieu-Daudé > > wrote: > >> > >> Hi, > >> > >> On 8/8/19 6:44 AM, Bin Meng wrote: > >>> When CADENCE_GEM_ERR_DEBUG is turned on, there are several >

[Qemu-devel] [Bug 1839428] Re: qemu core dumped when repeat "system_reset" multiple times during guest boot

2019-08-08 Thread Xujun Ma
Upstream qemu-v3.1.0 pass Upstream qemu-v3.1.1 pass Upstream qemu-v4.0.0 fail Upstream qemu-v4.0.0-rc0 fail So the problem occurs due to patch between qemu-v3.1.1 to qemu-v4.0.0-rc0. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] Quick nbdkit question

2019-08-08 Thread Richard W.M. Jones
On Wed, Aug 07, 2019 at 02:30:18PM -0700, ivo welch wrote: > hi richard---please forgive us. another quickie. we created an nbd > device. just a block device...no partitions, etc. in the guest vm, we > wrote a short C program that writes one sector (open file, fseek, fwrite, > close file) and

[Qemu-devel] [Bug 1838946] Re: qemu 3.10 golang crash

2019-08-08 Thread Antony Rheneus
Thanks @pmaydell, I missed to check binfmt qemu version. I checked in qemu 4.0.93 and I don't issue any issue. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [Fail] tests/test-util-filemonitor fails

2019-08-08 Thread Daniel P . Berrangé
On Thu, Aug 08, 2019 at 10:07:23AM +0800, Wei Yang wrote: > Current qemu fails tests/test-util-filemonitor. You'll need to provide more info. The test works for me and passes in all the QEMU CI environments. Regards, Daniel -- |: https://berrange.com -o-

[Qemu-devel] [Bug 1811533] Re: Unstable Win10 guest with qemu 3.1 + huge pages + hv_stimer

2019-08-08 Thread Žilvinas Žaltiena
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1811533 Title: Unstable Win10 guest with qemu 3.1 + huge pages + hv_stimer Status in QEMU:

Re: [Qemu-devel] [PATCH v2] numa: numa nodeid need not be sequential

2019-08-08 Thread David Gibson
On Tue, Aug 06, 2019 at 09:29:45PM +1000, Daniel Black wrote: > Replace all node_id assumptions with lookups from > machinestate->numa_state->nodes[] > and remove aspects that assume a sequential numbering of nodes. This enables > non-sequential NUMA node number topoligies to be created. > >

[Qemu-devel] [PATCH] scsi: lsi: exit infinite loop while executing script (CVE-2019-12068)

2019-08-08 Thread P J P
From: Prasad J Pandit When executing script in lsi_execute_script(), the LSI scsi adapter emulator advances 's->dsp' index to read next opcode. This can lead to an infinite loop if the next opcode is empty. Exit such loop after reading 10k empty opcodes. Reported-by: Bugs SysSec Signed-off-by:

Re: [Qemu-devel] [PATCH v2] hw: net: cadence_gem: Fix build errors in DB_PRINT()

2019-08-08 Thread Bin Meng
On Thu, Aug 8, 2019 at 1:21 PM Philippe Mathieu-Daudé wrote: > > Hi, > > On 8/8/19 6:44 AM, Bin Meng wrote: > > When CADENCE_GEM_ERR_DEBUG is turned on, there are several > > compilation errors in DB_PRINT(). Fix them. > > > > Signed-off-by: Bin Meng > > > > --- > > > > Changes in v2: > > Please

[Qemu-devel] [PATCH] ide: ahci: add check to avoid null dereference (CVE-2019-12067)

2019-08-08 Thread P J P
From: Prasad J Pandit AHCI emulator while committing DMA buffer in ahci_commit_buf() may do a NULL dereference if the command header 'ad->cur_cmd' is null. Add check to avoid it. Reported-by: Bugs SysSec Signed-off-by: Prasad J Pandit --- hw/ide/ahci.c | 6 -- 1 file changed, 4

Re: [Qemu-devel] [PATCH v2] hw: net: cadence_gem: Fix build errors in DB_PRINT()

2019-08-08 Thread Philippe Mathieu-Daudé
On 8/8/19 8:36 AM, Bin Meng wrote: > On Thu, Aug 8, 2019 at 1:21 PM Philippe Mathieu-Daudé > wrote: >> >> Hi, >> >> On 8/8/19 6:44 AM, Bin Meng wrote: >>> When CADENCE_GEM_ERR_DEBUG is turned on, there are several >>> compilation errors in DB_PRINT(). Fix them. >>> >>> Signed-off-by: Bin Meng

Re: [Qemu-devel] [PATCH v2 1/2] memory-device: not necessary to use goto for the last check

2019-08-08 Thread David Hildenbrand
On 08.08.19 04:38, Wei Yang wrote: > On Thu, Aug 08, 2019 at 02:30:02AM +, Zeng, Star wrote: >>> -Original Message- >>> From: Wei Yang [mailto:richardw.y...@linux.intel.com] >>> Sent: Thursday, August 8, 2019 10:13 AM >>> To: Zeng, Star >>> Cc: Wei Yang ; qemu-devel@nongnu.org; >>>

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-08 Thread piaojun
Hi Stefan, >From my test, your patch set of multithreading improves iops greatly as below: Guest configuration: 8 vCPU 8GB RAM Linux 5.1 (vivek-aug-06-2019) Host configuration: Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz (8 cores x 4 threads) 32GB RAM Linux 3.10.0 EXT4 + LVM + local HDD ---

Re: [Qemu-devel] Is network backend netmap worth keeping? (was: [PATCH v2 27/29] Include sysemu/sysemu.h a lot less)

2019-08-08 Thread Stefano Garzarella
On Thu, Aug 08, 2019 at 06:48:25AM +0200, Markus Armbruster wrote: > Please excuse the attention-grabbing subject. > > Philippe Mathieu-Daudé writes: > > > On 8/7/19 10:16 PM, Markus Armbruster wrote: > [...] > >> Can you tell me offhand what I have to install so configure enables > >>

Re: [Qemu-devel] [PATCH] numa: Introduce MachineClass::auto_enable_numa for implicit NUMA node

2019-08-08 Thread Tao Xu
On 8/8/2019 1:52 AM, Eduardo Habkost wrote: On Tue, Aug 06, 2019 at 02:50:55PM +0200, Igor Mammedov wrote: On Mon, 5 Aug 2019 15:13:02 +0800 Tao Xu wrote: Add MachineClass::auto_enable_numa field. When it is true, a NUMA node is expected to be created implicitly. Acked-by: David Gibson

Re: [Qemu-devel] [PATCH] scsi: lsi: exit infinite loop while executing script (CVE-2019-12068)

2019-08-08 Thread Stefano Garzarella
On Thu, Aug 08, 2019 at 12:03:40PM +0530, P J P wrote: > From: Prasad J Pandit > > When executing script in lsi_execute_script(), the LSI scsi > adapter emulator advances 's->dsp' index to read next opcode. > This can lead to an infinite loop if the next opcode is empty. > Exit such loop after

[Qemu-devel] [Bug 1839294] Re: Latest Installer (qemu-w64-setup-20190807.exe) for windows immediately deletes installed files at the very end of the installation

2019-08-08 Thread Philipp Oppermann
I hit the same error in my azure pipelines script that uses `choco install qemu`. While it worked with qemu-w64-setup-20190731.exe, the `C:\Program Files\qemu` directory is empty with qemu-w64-setup-20190807.exe. -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [Qemu-devel] [RFC PATCH 3/6] hw/ppc/pnv_homer: add homer/occ common area emulation for PowerNV

2019-08-08 Thread Cédric Le Goater
On 07/08/2019 12:07, Balamuruhan S wrote: > On Wed, Aug 07, 2019 at 09:54:55AM +0200, Cédric Le Goater wrote: >> On 07/08/2019 09:14, Balamuruhan S wrote: >>> Add mmio callback functions to enable homer/occ common area >>> to emulate pstate table, occ-sensors, slw, occ static and >>> dynamic

Re: [Qemu-devel] [Fail] tests/test-util-filemonitor fails

2019-08-08 Thread Wei Yang
On Thu, Aug 08, 2019 at 09:02:29AM +0100, Daniel P. Berrangé wrote: >On Thu, Aug 08, 2019 at 10:07:23AM +0800, Wei Yang wrote: >> Current qemu fails tests/test-util-filemonitor. > >You'll need to provide more info. The test works for me and passes in all >the QEMU CI environments. > The error

Re: [Qemu-devel] [RFC PATCH 4/6] hw/ppc/pnv: initialize and realize homer/occ common area

2019-08-08 Thread Cédric Le Goater
On 07/08/2019 12:12, Balamuruhan S wrote: > On Wed, Aug 07, 2019 at 09:59:26AM +0200, Cédric Le Goater wrote: >> On 07/08/2019 09:14, Balamuruhan S wrote: >>> homer and occ common area region base address are initialized >>> to create device tree and realized to map the address with >>> mmio

Re: [Qemu-devel] [PATCH v3 03/15] target/arm/monitor: Introduce qmp_query_cpu_model_expansion

2019-08-08 Thread Andrew Jones
On Wed, Aug 07, 2019 at 08:22:07AM -0700, Richard Henderson wrote: > On 8/6/19 5:21 AM, Andrew Jones wrote: > > That's a reasonable suggestion. I do like having self-contained > > validation, self-contained, but when cross-dependencies arise, then > > it does make sense to have a master validation

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-08 Thread Stefan Hajnoczi
On Wed, Aug 07, 2019 at 04:57:15PM -0400, Vivek Goyal wrote: > Kernel also serializes MAP/UNMAP on one inode. So you will need to run > multiple jobs operating on different inodes to see parallel MAP/UNMAP > (atleast from kernel's point of view). Okay, there is still room to experiment with how

Re: [Qemu-devel] [RFC PATCH 2/6] hw/ppc/pnv_xscom: extend xscom to use python interface

2019-08-08 Thread Cédric Le Goater
On 07/08/2019 09:14, Balamuruhan S wrote: > Existing xscom access emulation for read/write can be > extended with the python interface to support feeding > data externally. You should take a look at Rashmica's patch : hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500

Re: [Qemu-devel] [Qemu-arm] [PATCH v2] hw: net: cadence_gem: Fix build errors in DB_PRINT()

2019-08-08 Thread Alex Bennée
Bin Meng writes: > When CADENCE_GEM_ERR_DEBUG is turned on, there are several > compilation errors in DB_PRINT(). Fix them. The first fix should be to ensure the format strings are validated in normal compilation. This can be achieved by allowing the compiler to optimise away debug strings

[Qemu-devel] [PATCH v2] scsi: lsi: exit infinite loop while executing script (CVE-2019-12068)

2019-08-08 Thread P J P
From: Prasad J Pandit When executing script in lsi_execute_script(), the LSI scsi adapter emulator advances 's->dsp' index to read next opcode. This can lead to an infinite loop if the next opcode is empty. Exit such loop after reading 10k empty opcodes. Reported-by: Bugs SysSec Signed-off-by:

Re: [Qemu-devel] [PATCH] scsi: lsi: exit infinite loop while executing script (CVE-2019-12068)

2019-08-08 Thread Paolo Bonzini
On 08/08/19 08:33, P J P wrote: > From: Prasad J Pandit > > When executing script in lsi_execute_script(), the LSI scsi > adapter emulator advances 's->dsp' index to read next opcode. > This can lead to an infinite loop if the next opcode is empty. > Exit such loop after reading 10k empty

Re: [Qemu-devel] [PATCH] ide: ahci: add check to avoid null dereference (CVE-2019-12067)

2019-08-08 Thread Philippe Mathieu-Daudé
Hi Prasad, On 8/8/19 8:56 AM, P J P wrote: > From: Prasad J Pandit > > AHCI emulator while committing DMA buffer in ahci_commit_buf() > may do a NULL dereference if the command header 'ad->cur_cmd' > is null. Add check to avoid it. > > Reported-by: Bugs SysSec > Signed-off-by: Prasad J Pandit

Re: [Qemu-devel] [Fail] tests/test-util-filemonitor fails

2019-08-08 Thread Daniel P . Berrangé
On Thu, Aug 08, 2019 at 04:46:53PM +0800, Wei Yang wrote: > On Thu, Aug 08, 2019 at 09:02:29AM +0100, Daniel P. Berrangé wrote: > >On Thu, Aug 08, 2019 at 10:07:23AM +0800, Wei Yang wrote: > >> Current qemu fails tests/test-util-filemonitor. > > > >You'll need to provide more info. The test works

Re: [Qemu-devel] [PATCH untested for-4.2] memory: fix race between TCG and accesses to dirty bitmap

2019-08-08 Thread Alex Bennée
Paolo Bonzini writes: > The race is as follows: > > vCPU thread reader thread > --- --- > TLB check -> slow path > notdirty_mem_write > write to RAM > set dirty flag >

Re: [Qemu-devel] RISC-V: Vector && DSP Extension

2019-08-08 Thread Aleksandar Markovic
On Thu, Aug 8, 2019 at 3:48 PM Chih-Min Chao wrote: > > > On Thu, Aug 8, 2019 at 7:29 PM Aleksandar Markovic < > aleksandar.m.m...@gmail.com> wrote: > >> On Thu, Aug 8, 2019 at 11:52 AM liuzhiwei wrote: >> >> > Hi all, >> > >> > My workmate and I have been working on Vector & Dsp

Re: [Qemu-devel] [PATCH v2 2/2] Add dbus-vmstate object

2019-08-08 Thread Marc-André Lureau
Hi On Thu, Aug 8, 2019 at 7:03 PM Marc-André Lureau wrote: > > When instanciated, this object will connect to the given D-Bus > bus. During migration, it will take the data from org.qemu.VMState1 > instances. I forgot to update the commit message. When instantiated, this object will connect to

[Qemu-devel] Does i386-linux-user build on an i686 host?

2019-08-08 Thread Markus Armbruster
Fails for me, but perhaps I'm doing it wrong: $ uname -a Linux gcc45 3.16.0-7-686-pae #1 SMP Debian 3.16.59-1 (2018-10-03) i686 GNU/Linux $ ../configure --target-list=i386-linux-user Install prefix/usr/local BIOS directory/usr/local/share/qemu firmware path

Re: [Qemu-devel] [PATCH] qtest: Rename qtest.c:qtest_init()

2019-08-08 Thread Stefan Hajnoczi
On Mon, Aug 05, 2019 at 03:13:01AM +, Oleinik, Alexander wrote: > Both the qtest client, libqtest.c, and server, qtest.c, used the same > name for initialization functions which can cause confusion. > > Signed-off-by: Alexander Oleinik > --- > Thank you, Thomas Huth for the suggestion. > >

Re: [Qemu-devel] [PATCH 11/67] target/arm: Add stubs for aa32 decodetree

2019-08-08 Thread Richard Henderson
On 8/8/19 4:41 AM, Aleksandar Markovic wrote: > +/* > + * Include the generated decoders. > + * Note that the T32 decoder reuses some of the trans_* functions > + * initially declared by the A32 decoder, which results in duplicate > + * declaration warnings.  Suppress them. >

Re: [Qemu-devel] [PATCH v2] migration: rename migration_bitmap_sync_range to ramblock_sync_dirty_bitmap

2019-08-08 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > Rename for better understanding of the code. > > Suggested-by: Paolo Bonzini > Signed-off-by: Wei Yang Reviewed-by: Dr. David Alan Gilbert and queued. > > --- > v2: > * rebase on top of "just pass RAMBlock is enough" > > --- >

Re: [Qemu-devel] [PATCH v1 4/7] fpu: rename softfloat-specialize.h -> .inc.c

2019-08-08 Thread Richard Henderson
On 8/8/19 9:41 AM, Alex Bennée wrote: > This is not a normal header and should only be included in the main > softfloat.c file to bring in the various target specific > specialisations. Indeed as it contains non-inlined C functions it is > not even a legal header. Rename it to match our included C

Re: [Qemu-devel] [PATCH v6 05/26] hw/s390x: Access MemoryRegion with MemOp

2019-08-08 Thread Cornelia Huck
On Wed, 7 Aug 2019 08:27:35 + wrote: > The memory_region_dispatch_{read|write} operand "unsigned size" is > being converted into a "MemOp op". > > Convert interfaces by using no-op size_memop. > > After all interfaces are converted, size_memop will be implemented > and the

Re: [Qemu-devel] [PATCH v2 2/3] qcow2: rework the cluster compression routine

2019-08-08 Thread Max Reitz
On 04.07.19 15:09, Denis Plotnikov wrote: > The patch allow to process image compression type defined > in the image header and choose an appropriate method for > image clusters (de)compression. > > Signed-off-by: Denis Plotnikov > --- > block/qcow2.c | 93

Re: [Qemu-devel] [PATCH v1 1/7] fpu: move LIT64 helper to softfloat-types

2019-08-08 Thread Richard Henderson
On 8/8/19 9:41 AM, Alex Bennée wrote: > This simple pasting helper can be used by those who don't need the > entire softfloat api. Move it to the smaller types header. > > Signed-off-by: Alex Bennée > --- > include/fpu/softfloat-types.h | 2 ++ > include/fpu/softfloat.h | 2 -- > 2 files

[Qemu-devel] [PATCH v1 3/7] fpu: make softfloat-macros "self-contained"

2019-08-08 Thread Alex Bennée
The macros use the "flags" type and to be consistent if anyone just needs the macros we should bring in the header we need. There is an outstanding TODO to audit the use of "flags" and replace with bool at which point this include could be dropped. Signed-off-by: Alex Bennée ---

[Qemu-devel] [PATCH v1 1/7] fpu: move LIT64 helper to softfloat-types

2019-08-08 Thread Alex Bennée
This simple pasting helper can be used by those who don't need the entire softfloat api. Move it to the smaller types header. Signed-off-by: Alex Bennée --- include/fpu/softfloat-types.h | 2 ++ include/fpu/softfloat.h | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2 26/29] Clean up inclusion of sysemu/sysemu.h

2019-08-08 Thread Alex Bennée
Markus Armbruster writes: > Alex Bennée writes: > >> Markus Armbruster writes: >> >>> In my "build everything" tree, changing sysemu/sysemu.h triggers a >>> recompile of some 5400 out of 6600 objects (not counting tests and >>> objects that don't depend on qemu/osdep.h). >>> >>> 119 of 380

Re: [Qemu-devel] [PATCH v6 07/26] hw/virtio: Access MemoryRegion with MemOp

2019-08-08 Thread Cornelia Huck
On Wed, 7 Aug 2019 08:28:16 + wrote: > The memory_region_dispatch_{read|write} operand "unsigned size" is > being converted into a "MemOp op". > > Convert interfaces by using no-op size_memop. > > After all interfaces are converted, size_memop will be implemented > and the

[Qemu-devel] [RFC PATCH 2/6] net/colo-compare: Use the tcp_header structure

2019-08-08 Thread Philippe Mathieu-Daudé
The tcp_header structure comes convenient macros to avoid manipulating the TCP header flags/offset bits manually. Replace the tcp_hdr structure by the tcp_header equivalent, and use the macros. Signed-off-by: Philippe Mathieu-Daudé --- RFC: Verify th_off endianess net/colo-compare.c | 14

[Qemu-devel] [RFC PATCH 4/6] hw/net/vmxnet3: Use the tcp_header structure

2019-08-08 Thread Philippe Mathieu-Daudé
The tcp_header structure comes convenient macros to avoid manipulating the TCP header flags/offset bits manually. Replace the tcp_hdr structure by the tcp_header equivalent, and use the macros. Since we will remove the duplicated TCP_FLAG_ACK definition in the next commit, replace its use now.

Re: [Qemu-devel] [PATCH v6 08/26] hw/vfio: Access MemoryRegion with MemOp

2019-08-08 Thread Cornelia Huck
On Wed, 7 Aug 2019 08:28:40 + wrote: > The memory_region_dispatch_{read|write} operand "unsigned size" is > being converted into a "MemOp op". > > Convert interfaces by using no-op size_memop. > > After all interfaces are converted, size_memop will be implemented > and the

Re: [Qemu-devel] [PATCH v6 12/26] hw/s390x: Hard code size with MO_{8|16|32|64}

2019-08-08 Thread Cornelia Huck
On Wed, 7 Aug 2019 08:30:04 + wrote: > Temporarily no-op size_memop was introduced to aid the conversion of > memory_region_dispatch_{read|write} operand "unsigned size" into > "MemOp op". > > Now size_memop is implemented, again hard coded size but with "Now that size_memop has been

[Qemu-devel] [PATCH v2 2/2] Add dbus-vmstate object

2019-08-08 Thread Marc-André Lureau
When instanciated, this object will connect to the given D-Bus bus. During migration, it will take the data from org.qemu.VMState1 instances. See documentation for further details. Signed-off-by: Marc-André Lureau --- MAINTAINERS | 6 + backends/Makefile.objs| 4 +

[Qemu-devel] [PATCH v2 1/2] qemu-file: move qemu_{get, put}_counted_string() declarations

2019-08-08 Thread Marc-André Lureau
Move migration helpers for strings under include/, so they can be used outside of migration/ Signed-off-by: Marc-André Lureau Reviewed-by: Juan Quintela --- include/migration/qemu-file-types.h | 4 migration/qemu-file.h | 4 2 files changed, 4 insertions(+), 4

[Qemu-devel] [PATCH v1 5/7] target/mips: rationalise softfloat includes

2019-08-08 Thread Alex Bennée
We should avoid including the whole of softfloat headers in cpu.h and explicitly include it only where we will be calling softfloat functions. We can use the -types.h and -helpers.h in cpu.h for the few bits that are global. Signed-off-by: Alex Bennée --- target/mips/cpu.h| 3 ++-

[Qemu-devel] [PATCH v1 7/7] targets (various): use softfloat-helpers.h where we can

2019-08-08 Thread Alex Bennée
Generally the cpu and non-FP helper files just want to manipulate the softfloat flags. For this they can just use the -helpers.h include which brings in a minimal number of inline helpers. Signed-off-by: Alex Bennée --- target/alpha/helper.c | 2 +- target/microblaze/cpu.c | 2 +-

Re: [Qemu-devel] [PATCH v1 0/7] softfloat header cleanups

2019-08-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190808164117.23348-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v1 0/7] softfloat header cleanups Message-id:

[Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr structures

2019-08-08 Thread Philippe Mathieu-Daudé
This is a preparatory cleanup series. Commit 75020a70215 introduced 4 very equivalent structures: - tcp_header and tcp_hdr, - udp_header and udp_hdr. Choose the most widely use in the codebase, which happens to provide convenient bitfields manipulation macros and is not endian-specific.

[Qemu-devel] [RFC PATCH 1/6] hw/net/virtio-net: Use TCP_HEADER_FLAGS/TCP_HEADER_DATA_OFFSET macros

2019-08-08 Thread Philippe Mathieu-Daudé
"net/eth.h" provides convenient macros to avoid manipulating the TCP header flags/offset bits manually, let's use them. Signed-off-by: Philippe Mathieu-Daudé --- RFC: Check the macro uses the correct bits hw/net/virtio-net.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff

[Qemu-devel] [PATCH 3/6] net/filter-rewriter: Use the tcp_header structure

2019-08-08 Thread Philippe Mathieu-Daudé
The tcp_header structure comes convenient macros to avoid manipulating the TCP header flags/offset bits manually. Replace the tcp_hdr structure by the tcp_header equivalent, and use the TCP_HEADER_FLAGS macro. Signed-off-by: Philippe Mathieu-Daudé --- net/filter-rewriter.c | 37

Re: [Qemu-devel] [PATCH v2 3/3] qcow2: add zstd cluster compression

2019-08-08 Thread Max Reitz
On 04.07.19 15:09, Denis Plotnikov wrote: > zstd significantly reduces cluster compression time. > It provides better compression performance maintaining > the same level of compression ratio in comparison with > zlib, which, by the moment, has been the only compression > method available. > >

Re: [Qemu-devel] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-08 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Mon, 29 Jul 2019 at 15:59, Damien Hedde wrote: > > > > This add the reset related sections for every QOM > > device. > > A bit more detail in the commit message would help, I think -- > this is adding extra machinery which has to copy and

[Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

2019-08-08 Thread Marc-André Lureau
Hi, With external processes or helpers participating to the VM support, it becomes necessary to handle their migration. Various options exist to transfer their state: 1) as the VM memory, RAM or devices (we could say that's how vhost-user devices can be handled today, they are expected to

[Qemu-devel] [PATCH v1 0/7] softfloat header cleanups

2019-08-08 Thread Alex Bennée
Hi Markus, As promised here is a softfloat specific follow-up to your headers clean-up series: From: Markus Armbruster Date: Tue, 6 Aug 2019 17:14:06 +0200 Message-Id: <20190806151435.10740-1-arm...@redhat.com> Subject: [Qemu-devel] [PATCH v2 00/29] Tame a few "touch this, recompile

[Qemu-devel] [PATCH v1 2/7] fpu: move inline helpers into a separate header

2019-08-08 Thread Alex Bennée
There are a bunch of users of the inline helpers who do not need access to the entire softfloat API. Move those inline helpers into a new header file which can be included without bringing in the rest of the world. Signed-off-by: Alex Bennée --- include/fpu/softfloat-helpers.h | 118

[Qemu-devel] [PATCH 5/6] net/eth: Remove the unused tcp_hdr structure

2019-08-08 Thread Philippe Mathieu-Daudé
Commit 75020a70215 introduced 2 very similar structures: tcp_header and tcp_hdr. We replaced the uses of struct tcp_hdr with the equivalent struct tcp_header. Remove the unused one. Signed-off-by: Philippe Mathieu-Daudé --- I prefer the TCP_FLAG_XXX name, but there is only one single use of

[Qemu-devel] [PATCH 6/6] net/eth: Remove the single use of udp_hdr structure

2019-08-08 Thread Philippe Mathieu-Daudé
Commit 75020a70215 introduced 2 very equivalent structures: udp_header and udp_hdr. Replace the single use of udp_hdr by udp_header (which has few more uses in the codebase) and remove the now unused structure. Signed-off-by: Philippe Mathieu-Daudé --- hw/net/net_tx_pkt.c | 2 +-

[Qemu-devel] [PATCH v1 6/7] target/riscv: rationalise softfloat includes

2019-08-08 Thread Alex Bennée
We should avoid including the whole of softfloat headers in cpu.h and explicitly include it only where we will be calling softfloat functions. We can use the -types.h and -helpers.h in cpu.h for the few bits that are global. Signed-off-by: Alex Bennée --- target/riscv/cpu.c| 1 +

[Qemu-devel] [PATCH v1 4/7] fpu: rename softfloat-specialize.h -> .inc.c

2019-08-08 Thread Alex Bennée
This is not a normal header and should only be included in the main softfloat.c file to bring in the various target specific specialisations. Indeed as it contains non-inlined C functions it is not even a legal header. Rename it to match our included C convention. Signed-off-by: Alex Bennée ---

Re: [Qemu-devel] [PATCH v1 0/7] softfloat header cleanups

2019-08-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190808164117.23348-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v1 0/7] softfloat header cleanups Message-id:

Re: [Qemu-devel] [PATCH v1 3/7] fpu: make softfloat-macros "self-contained"

2019-08-08 Thread Richard Henderson
On 8/8/19 9:41 AM, Alex Bennée wrote: > The macros use the "flags" type and to be consistent if anyone just > needs the macros we should bring in the header we need. There is an > outstanding TODO to audit the use of "flags" and replace with bool at > which point this include could be dropped.

Re: [Qemu-devel] Is network backend netmap worth keeping?

2019-08-08 Thread Vincenzo Maffione
Yes, indeed. Netmap is actively maintained on FreeBSD, and QEMU is packaged on FreeBSD with netmap support enabled. Also keep in mind that, differently from Linux, the (current) tap driver on FreeBSD does not support offloads (e.g. IFF_VNET_HDR, TUNSETVNETHDRSIZE and so on). On the contrary,

[Qemu-devel] [PATCH 6/7] target/arm: Simplify SMMLA, SMMLAR, SMMLS, SMMLSR

2019-08-08 Thread Richard Henderson
All of the inputs to these instructions are 32-bits. Rather than extend each input to 64-bits and then extract the high 32-bits of the output, use tcg_gen_muls2_i32 and other 32-bit generator functions. Signed-off-by: Richard Henderson --- target/arm/translate.c | 72

[Qemu-devel] [PATCH 7/7] target/arm: Use tcg_gen_extrh_i64_i32 to extract the high word

2019-08-08 Thread Richard Henderson
Separate shift + extract low will result in one extra insn for hosts like RISC-V, MIPS, and Sparc. Signed-off-by: Richard Henderson --- target/arm/translate.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c

[Qemu-devel] [PATCH 1/7] target/arm: Use tcg_gen_extract_i32 for shifter_out_im

2019-08-08 Thread Richard Henderson
Extract is a compact combination of shift + and. Signed-off-by: Richard Henderson --- target/arm/translate.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 846052acea..43e005d191 100644 ---

[Qemu-devel] [PATCH 3/7] target/arm: Remove redundant shift tests

2019-08-08 Thread Richard Henderson
The immediate shift generator functions already test for, and eliminate, the case of a shift by zero. Signed-off-by: Richard Henderson --- target/arm/translate.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/target/arm/translate.c

Re: [Qemu-devel] [PATCH v1 0/7] softfloat header cleanups

2019-08-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190808164117.23348-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v1 0/7] softfloat header cleanups Message-id:

Re: [Qemu-devel] [PATCH v1 5/7] target/mips: rationalise softfloat includes

2019-08-08 Thread Richard Henderson
On 8/8/19 9:41 AM, Alex Bennée wrote: > index 21c0615e020..f146924623c 100644 > --- a/target/mips/cpu.h > +++ b/target/mips/cpu.h > @@ -5,7 +5,8 @@ > > #include "cpu-qom.h" > #include "exec/cpu-defs.h" > -#include "fpu/softfloat.h" > +#include "fpu/softfloat-types.h" > +#include

Re: [Qemu-devel] [PATCH v1 6/7] target/riscv: rationalise softfloat includes

2019-08-08 Thread Richard Henderson
On 8/8/19 9:41 AM, Alex Bennée wrote: > We should avoid including the whole of softfloat headers in cpu.h and > explicitly include it only where we will be calling softfloat > functions. We can use the -types.h and -helpers.h in cpu.h for the few > bits that are global. > > Signed-off-by: Alex

Re: [Qemu-devel] [PATCH v1 7/7] targets (various): use softfloat-helpers.h where we can

2019-08-08 Thread Richard Henderson
On 8/8/19 9:41 AM, Alex Bennée wrote: > Generally the cpu and non-FP helper files just want to manipulate the > softfloat flags. For this they can just use the -helpers.h include > which brings in a minimal number of inline helpers. > > Signed-off-by: Alex Bennée > --- > target/alpha/helper.c

[Qemu-devel] [PATCH 4/7] target/arm: Use ror32 instead of open-coding the operation

2019-08-08 Thread Richard Henderson
The helper function is more documentary, and also already handles the case of rotate by zero. Signed-off-by: Richard Henderson --- target/arm/translate.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index

[Qemu-devel] [PATCH 5/7] target/arm: Use tcg_gen_rotri_i32 for gen_swap_half

2019-08-08 Thread Richard Henderson
Rotate is the more compact and obvious way to swap 16-bit elements of a 32-bit word. Signed-off-by: Richard Henderson --- target/arm/translate.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index b40f163bab..ddc54e77e4

[Qemu-devel] [PATCH 2/7] target/arm: Use tcg_gen_deposit_i32 for PKHBT, PKHTB

2019-08-08 Thread Richard Henderson
Use deposit as the composit operation to merge the bits from the two inputs. Signed-off-by: Richard Henderson --- target/arm/translate.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index

[Qemu-devel] [PATCH 0/7] target/arm: Misc cleanups

2019-08-08 Thread Richard Henderson
Some of these were cleanups that I was making simultaneous with the decodetree split. Let's do those beforehand to make the split easier to read. Some of these are new, noticed while I was in the area. r~ Richard Henderson (7): target/arm: Use tcg_gen_extract_i32 for shifter_out_im

Re: [Qemu-devel] [PATCH v1 0/7] softfloat header cleanups

2019-08-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190808164117.23348-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v1 0/7] softfloat header cleanups Message-id:

Re: [Qemu-devel] [PATCH v3 03/15] target/arm/monitor: Introduce qmp_query_cpu_model_expansion

2019-08-08 Thread Richard Henderson
On 8/8/19 1:50 AM, Andrew Jones wrote: > I'm not sure. Of course I'd need to experiment with it to be sure, but > I'm reluctant to go through that exercise, because I believe that a > deferred validation will result in less specific errors messages. For > example, how would the validator know in

[Qemu-devel] configure and submodules capstone, slirp, dtc

2019-08-08 Thread Markus Armbruster
configure --help documents capstone like any other generic optional feature. This leaves --enable-capstone=git and =system undocumented there. Anyone care to improve this? It documents slirp unlike other generic optional features, and shows only --disable-slirp. Anyone care to improve this?

Re: [Qemu-devel] [PATCH v1 2/7] fpu: move inline helpers into a separate header

2019-08-08 Thread Richard Henderson
On 8/8/19 9:41 AM, Alex Bennée wrote: > +static inline void set_float_detect_tininess(int val, float_status *status) > +{ > +status->float_detect_tininess = val; > +} > +static inline void set_float_rounding_mode(int val, float_status *status) > +{ > +status->float_rounding_mode = val; >

Re: [Qemu-devel] [PATCH v3] migration/postcopy: use mis->bh instead of allocating a QEMUBH

2019-08-08 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > On Wed, Aug 07, 2019 at 07:35:34PM +0100, Dr. David Alan Gilbert wrote: > >* Wei Yang (richardw.y...@linux.intel.com) wrote: > >> For migration incoming side, it either quit in precopy or postcopy. It > >> is safe to use the mis->bh for both

Re: [Qemu-devel] [RFC PATCH 6/6] hw/ppc/pnv_homer: add python interface support for homer/occ common area

2019-08-08 Thread David Gibson
On Wed, Aug 07, 2019 at 12:44:45PM +0530, Balamuruhan S wrote: > use python interface APIs in homer/occ common area emulation to > interact with scripts if provided else fallback to normal flow, > it shows how simple to use the interface to call python methods > with any number of arguments in any

Re: [Qemu-devel] [RFC PATCH 0/6] Enhancing Qemu MMIO emulation with scripting interface

2019-08-08 Thread David Gibson
On Wed, Aug 07, 2019 at 10:15:48AM +0200, Cédric Le Goater wrote: > On 07/08/2019 09:14, Balamuruhan S wrote: > > Hi All, > > > > This is a proposal to extend mmio callbacks in Qemu with scripting interface > > that is prototyped with python in this implementation. It gives ability to > > feed

Re: [Qemu-devel] [RFC PATCH 5/6] hw/ppc/pnv_xscom: retrieve homer/occ base address from PBA BARs

2019-08-08 Thread David Gibson
On Wed, Aug 07, 2019 at 12:44:44PM +0530, Balamuruhan S wrote: > During PowerNV boot skiboot populates the device tree by retrieving > base address of homer/occ common area from PBA BARs and prd ipoll > mask by accessing xscom read/write accesses. > > Signed-off-by: Balamuruhan S Again seems

Re: [Qemu-devel] [RFC PATCH 4/6] hw/ppc/pnv: initialize and realize homer/occ common area

2019-08-08 Thread David Gibson
On Wed, Aug 07, 2019 at 12:44:43PM +0530, Balamuruhan S wrote: > homer and occ common area region base address are initialized > to create device tree and realized to map the address with > mmio callbacks during `pnv_chip_realize()`. > > `SysBusNum` enum is introduced to set sysbus for XSCOM,

Re: [Qemu-devel] [RFC PATCH 1/6] utils/python_api: add scripting interface for Qemu with python lib

2019-08-08 Thread David Gibson
On Thu, Aug 08, 2019 at 02:45:02PM +0200, Philippe Mathieu-Daudé wrote: > On 8/8/19 12:49 PM, Daniel P. Berrangé wrote: > > On Wed, Aug 07, 2019 at 12:44:40PM +0530, Balamuruhan S wrote: > >> Adds scripting interface with python library to call functions in > >> python modules from Qemu that can

Re: [Qemu-devel] [PATCH] ide: ahci: add check to avoid null dereference (CVE-2019-12067)

2019-08-08 Thread John Snow
On 8/8/19 5:11 AM, Philippe Mathieu-Daudé wrote: > Hi Prasad, > > On 8/8/19 8:56 AM, P J P wrote: >> From: Prasad J Pandit >> >> AHCI emulator while committing DMA buffer in ahci_commit_buf() >> may do a NULL dereference if the command header 'ad->cur_cmd' >> is null. Add check to avoid it.

Re: [Qemu-devel] [PATCH v3 05/33] Switch to new api in qdev/bus

2019-08-08 Thread David Gibson
On Wed, Jul 31, 2019 at 01:31:28PM +0200, Philippe Mathieu-Daudé wrote: > On 7/31/19 11:29 AM, Damien Hedde wrote: > > On 7/31/19 8:05 AM, David Gibson wrote: > >> On Mon, Jul 29, 2019 at 04:56:26PM +0200, Damien Hedde wrote: > >>> Deprecate old reset apis and make them use the new one while they

Re: [Qemu-devel] [PATCH] numa: Introduce MachineClass::auto_enable_numa for implicit NUMA node

2019-08-08 Thread David Gibson
On Wed, Aug 07, 2019 at 02:52:56PM -0300, Eduardo Habkost wrote: > On Tue, Aug 06, 2019 at 02:50:55PM +0200, Igor Mammedov wrote: > > On Mon, 5 Aug 2019 15:13:02 +0800 > > Tao Xu wrote: > > > > > Add MachineClass::auto_enable_numa field. When it is true, a NUMA node > > > is expected to be

Re: [Qemu-devel] [PATCH] numa: Introduce MachineClass::auto_enable_numa for implicit NUMA node

2019-08-08 Thread David Gibson
On Thu, Aug 08, 2019 at 04:35:00PM +1000, David Gibson wrote: > On Wed, Aug 07, 2019 at 02:52:56PM -0300, Eduardo Habkost wrote: > > On Tue, Aug 06, 2019 at 02:50:55PM +0200, Igor Mammedov wrote: > > > On Mon, 5 Aug 2019 15:13:02 +0800 > > > Tao Xu wrote: > > > > > > > Add

Re: [Qemu-devel] [PATCH v3 09/33] add doc about Resettable interface

2019-08-08 Thread David Gibson
On Wed, Aug 07, 2019 at 11:34:41AM +0100, Peter Maydell wrote: > On Wed, 31 Jul 2019 at 07:33, David Gibson > wrote: > > > > On Mon, Jul 29, 2019 at 04:56:30PM +0200, Damien Hedde wrote: > > > +The function *resettable_reset* is used to trigger a reset on a given > > > +object. > > > +void

Re: [Qemu-devel] [PATCH v3 05/33] Switch to new api in qdev/bus

2019-08-08 Thread David Gibson
On Wed, Jul 31, 2019 at 11:29:36AM +0200, Damien Hedde wrote: > > > On 7/31/19 8:05 AM, David Gibson wrote: > > On Mon, Jul 29, 2019 at 04:56:26PM +0200, Damien Hedde wrote: > >> Deprecate old reset apis and make them use the new one while they > >> are still used somewhere. > >> > >>

Re: [Qemu-devel] [PATCH] target-arm: Make the counter tick relative to cntfrq

2019-08-08 Thread Andrew Jeffery
On Fri, 9 Aug 2019, at 13:36, no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20190809031321.14760-1-and...@aj.id.au/ > > > > Hi, > > This series failed build test on s390x host. Please find the details below. > > === TEST SCRIPT BEGIN === > #!/bin/bash > # Testing

Re: [Qemu-devel] [PATCH v2] Update the avx2 configure test to be compatible with clang

2019-08-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190809042909.74988-1-rebe...@bsdio.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make

Re: [Qemu-devel] [Fail] tests/test-util-filemonitor fails

2019-08-08 Thread Wei Yang
On Thu, Aug 08, 2019 at 10:22:13AM +0100, Daniel P. Berrangé wrote: >On Thu, Aug 08, 2019 at 04:46:53PM +0800, Wei Yang wrote: >> On Thu, Aug 08, 2019 at 09:02:29AM +0100, Daniel P. Berrangé wrote: >> >On Thu, Aug 08, 2019 at 10:07:23AM +0800, Wei Yang wrote: >> >> Current qemu fails

Re: [Qemu-devel] [PATCH v3] spapr: quantify error messages regarding capability settings

2019-08-08 Thread David Gibson
On Mon, Aug 05, 2019 at 03:09:58PM +1000, Daniel Black wrote: > Its not immediately obvious how cap-X=Y setting need to be applied > to the command line so, for spapr capability hints, this has been clarified > to: > > ..try appending -machine cap-X=Y > > The wrong value messages have been

  1   2   >