[Qemu-devel] [Bug 1840249] [NEW] Cancelling 'make docker-test-build' does not cancel running containers

2019-08-15 Thread Philippe Mathieu-Daudé
Public bug reported: version: v4.1.0-rc5 Run 'make -k docker-test-build', wait a few, cancel with ^C: $ make -k docker-test-build 2>&1 > /dev/null ^C $ docker ps CONTAINER IDIMAGECOMMAND CREATED STATUS 62264a2d777a

[Qemu-devel] Running docker cross-tests with SELinux (was: Re: [PATCH v3 20/29] Include qemu/main-loop.h less)

2019-08-15 Thread Philippe Mathieu-Daudé
Hi Alex, On 8/10/19 9:34 PM, Markus Armbruster wrote: > > There are a few SELinux gripes in my logs, like this one: > > type=AVC msg=audit(1565418107.93:125036): avc: denied { module_request } > for pid=19599 comm="configure" kmod="binfmt-464c" >

Re: [Qemu-devel] [PATCH v3 0/4] qcow2: async handling of fragmented io

2019-08-15 Thread Max Reitz
On 15.08.19 14:10, Vladimir Sementsov-Ogievskiy wrote: > 01: - use coroutine_fn where appropriate !!! :-) signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v3 1/4] block: introduce aio task pool

2019-08-15 Thread Max Reitz
On 15.08.19 14:10, Vladimir Sementsov-Ogievskiy wrote: > Common interface for aio task loops. To be used for improving > performance of synchronous io loops in qcow2, block-stream, > copy-on-read, and may be other places. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

Re: [Qemu-devel] Question about libvhost-user and vhost-user-bridge.c

2019-08-15 Thread Stefan Hajnoczi
On Wed, Aug 14, 2019 at 10:54:34AM -0700, William Tu wrote: > Hi, > > I'm using libvhost-user.a to write a vhost backend, in order to receive and > send packets from/to VMs from OVS. I started by reading the > vhost-user-bridge.c. > I can now pass the initialization stage, seeing

Re: [Qemu-devel] [PATCH] usb: reword -usb command-line option and mention xHCI

2019-08-15 Thread Stefan Hajnoczi
On Thu, Aug 15, 2019 at 08:13:40AM +0200, Gerd Hoffmann wrote: > Hi, > > > > > -Enable the USB driver (if it is not used by default yet). > > > > +Enable USB emulation on machine types with an on-board USB host > > > > controller (if > > > > +not enabled by default). Note that on-board USB

Re: [Qemu-devel] [PATCH v3 4/4] block/qcow2: introduce parallel subrequest handling in read and write

2019-08-15 Thread Max Reitz
On 15.08.19 14:10, Vladimir Sementsov-Ogievskiy wrote: > It improves performance for fragmented qcow2 images. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.h | 3 ++ > block/qcow2.c | 125 - > block/trace-events | 1

Re: [Qemu-devel] [PATCH 00/13] RFC: luks/encrypted qcow2 key management

2019-08-15 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.08.2019 um 23:08 hat Eric Blake geschrieben: >> On 8/14/19 3:22 PM, Maxim Levitsky wrote: >> >> > This is an issue that was raised today on IRC with Kevin Wolf. Really >> > thanks >> > for the idea! >> > >> > We agreed that this new qmp interface should take the

Re: [Qemu-devel] [PATCH v0] Implement new cache mode "target"

2019-08-15 Thread Kevin Wolf
Am 15.08.2019 um 15:53 hat Stefan Hajnoczi geschrieben: > On Wed, Aug 07, 2019 at 04:09:54PM +0300, Artemy Kapitula wrote: > > Hi, > Please use "scripts/get_maintainer.pl -f block.c" to find out which > maintainers to email. qemu-devel@nongnu.org is a high-traffic list and > patches not CCed to

Re: [Qemu-devel] [PATCH v1 1/2] accel/tcg: adding integration with linux perf

2019-08-15 Thread Stefan Hajnoczi
On Wed, Aug 14, 2019 at 11:37:24PM -0300, vandersonmr wrote: > This commit adds support to Linux Perf in order > to be able to analyze qemu jitted code and > also to able to see the TBs PC in it. Is there any reference to the file format? Please include it in a code comment, if such a thing

[Qemu-devel] [PATCH v3 3/4] block/qcow2: refactor qcow2_co_pwritev_part

2019-08-15 Thread Vladimir Sementsov-Ogievskiy
Similarly to previous commit, prepare for parallelizing write-loop iterations. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 153 +- 1 file changed, 89 insertions(+), 64 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c

[Qemu-devel] [PATCH v3 2/4] block/qcow2: refactor qcow2_co_preadv_part

2019-08-15 Thread Vladimir Sementsov-Ogievskiy
Further patch will run partial requests of iterations of qcow2_co_preadv in parallel for performance reasons. To prepare for this, separate part which may be parallelized into separate function (qcow2_co_preadv_task). While being here, also separate encrypted clusters reading to own function,

[Qemu-devel] [PATCH v3 1/4] block: introduce aio task pool

2019-08-15 Thread Vladimir Sementsov-Ogievskiy
Common interface for aio task loops. To be used for improving performance of synchronous io loops in qcow2, block-stream, copy-on-read, and may be other places. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/aio_task.h | 54 + block/aio_task.c | 124

[Qemu-devel] [Bug 1840252] Re: Infinite loop over ERANGE from getsockopt

2019-08-15 Thread Fritz Katze
*** This bug is a duplicate of bug 1823790 *** https://bugs.launchpad.net/bugs/1823790 ** Description changed: Host system: Ubuntu 18.04.3 AMD64 Qemu Version: qemu-arm-static --version qemu-arm version 2.11.1(Debian 1:2.11+dfsg-1ubuntu7.17) - Emulated System: + Emulated System:

Re: [Qemu-devel] [PATCH] vhost-vsock: report QMP event when set running

2019-08-15 Thread Stefan Hajnoczi
On Tue, Jul 30, 2019 at 04:29:35PM -0400, Michael S. Tsirkin wrote: > On Tue, Jul 30, 2019 at 12:24:27PM +, N. B. wrote: > > From: Ning Bo > > > > Report vsock running event so that the upper application can > > control boot sequence. > > see

[Qemu-devel] [PATCH] MAINTAINERS: add Stefan Hajnoczi as vhost-vsock maintainer

2019-08-15 Thread Stefan Hajnoczi
A MAINTAINERS entry wasn't added when this code was merged. Add it now so that scripts/get_maintainer.pl works for vhost-vsock. Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d6de200453..b8fc408bf3

Re: [Qemu-devel] [PATCH v3 0/4] qcow2: async handling of fragmented io

2019-08-15 Thread Max Reitz
On 15.08.19 14:10, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is an asynchronous scheme for handling fragmented qcow2 > reads and writes. Both qcow2 read and write functions loops through > sequential portions of data. The series aim it to parallelize these > loops iterations. > It

[Qemu-devel] [PATCH v2] usb: reword -usb command-line option and mention xHCI

2019-08-15 Thread Stefan Hajnoczi
The -usb section of the man page is not very clear on what exactly -usb does and fails to mention xHCI as a modern alternative (-device nec-usb-xhci). Signed-off-by: Stefan Hajnoczi --- v2: * Use @option{-device ...} [Thomas] * Suggest qemu-xhci instead of nec-usb-xhci [Thomas and David] ---

Re: [Qemu-devel] [PATCH v3 04/13] fpu: use min/max values from stdint.h for integral overflow

2019-08-15 Thread Aleksandar Markovic
13.08.2019. 14.52, "Alex Bennée" је написао/ла: > > Remove some more use of LIT64 while making the meaning more clear. We > also avoid the need of casts as the results by definition fit into the > return type. > > Signed-off-by: Alex Bennée > --- > fpu/softfloat.c | 30

[Qemu-devel] [PATCH] trace: Clarify DTrace/SystemTap help message

2019-08-15 Thread Philippe Mathieu-Daudé
Most tracing backends are implemented within QEMU, except the DTrace/SystemTap backends. One side effect is when running 'qemu -trace help', an incomplete list of trace events is displayed when using the DTrace/SystemTap backends. This is partly due to trace events registered as modules with

Re: [Qemu-devel] [PATCH 7/7] target/arm: Use tcg_gen_extrh_i64_i32 to extract the high word

2019-08-15 Thread Peter Maydell
On Thu, 15 Aug 2019 at 12:56, Richard Henderson wrote: > > > > > > > >This patch is fine, but I noticed while reviewing it that tcg/README > >labels both the extrl_i64_i32 and extrh_i64_i32 operations as > >"for 64-bit hosts only". Presumably that's a documentation error, > >since we're not

Re: [Qemu-devel] [PATCH] Fix hw/rdma/vmw/pvrdma_cmd.c build

2019-08-15 Thread Stephen Kitt
On Thu, 15 Aug 2019 13:57:05 +0300, Yuval Shaia wrote: > On Sun, Aug 11, 2019 at 09:42:47PM +0200, Stephen Kitt wrote: > > This was broken by the cherry-pick in 41dd30f. Fix by handling errors > > as in the rest of the function: "goto out" instead of "return rc". > > > > Signed-off-by: Stephen

[Qemu-devel] [PATCH v3 0/4] qcow2: async handling of fragmented io

2019-08-15 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is an asynchronous scheme for handling fragmented qcow2 reads and writes. Both qcow2 read and write functions loops through sequential portions of data. The series aim it to parallelize these loops iterations. It improves performance for fragmented qcow2 images, I've tested it as

[Qemu-devel] [PATCH v3 4/4] block/qcow2: introduce parallel subrequest handling in read and write

2019-08-15 Thread Vladimir Sementsov-Ogievskiy
It improves performance for fragmented qcow2 images. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h | 3 ++ block/qcow2.c | 125 - block/trace-events | 1 + 3 files changed, 117 insertions(+), 12 deletions(-) diff --git

[Qemu-devel] [Bug 1840250] [NEW] 'make -j1 docker-test-build' uses more than one job

2019-08-15 Thread Philippe Mathieu-Daudé
Public bug reported: version: v4.1.0-rc5 Run 'make -j1 docker-test-build', wait a few, various containers get instantiated. $ make -j1 docker-test-build 2>&1 > /dev/null On another terminal: $ docker ps CONTAINER IDIMAGECOMMAND CREATED

Re: [Qemu-devel] [RFC PATCH v2 01/17] fuzz: Move initialization from main to qemu_init

2019-08-15 Thread Darren Kenny
On Mon, Aug 05, 2019 at 09:43:06AM +0200, Paolo Bonzini wrote: On 05/08/19 09:11, Oleinik, Alexander wrote: Using this, we avoid needing a special case to break out of main(), early, when initializing the fuzzer, as we can just call qemu_init. There is still a #define around main(), since it

[Qemu-devel] [Bug 1840252] Re: Infinite loop over ERANGE from getsockopt

2019-08-15 Thread Peter Maydell
*** This bug is a duplicate of bug 1823790 *** https://bugs.launchpad.net/bugs/1823790 Hi; thanks for this bug report. It looks like it's the same as LP:1823790. The underlying cause is that we don't implement the SO_PEERSEC getsockopt option properly. Unfortunately this option appears to be

Re: [Qemu-devel] [PATCH v4] blockjob: drain all job nodes in block_job_drain

2019-08-15 Thread Max Reitz
On 02.08.19 11:52, Vladimir Sementsov-Ogievskiy wrote: > Instead of draining additional nodes in each job code, let's do it in > common block_job_drain, draining just all job's children. > BlockJobDriver.drain becomes unused, so, drop it at all. > > It's also a first step to finally get rid of

Re: [Qemu-devel] [PATCH v3 2/4] block/qcow2: refactor qcow2_co_preadv_part

2019-08-15 Thread Max Reitz
On 15.08.19 14:10, Vladimir Sementsov-Ogievskiy wrote: > Further patch will run partial requests of iterations of > qcow2_co_preadv in parallel for performance reasons. To prepare for > this, separate part which may be parallelized into separate function > (qcow2_co_preadv_task). > > While being

Re: [Qemu-devel] [PATCH v2] Add git-publish profile for security bugs

2019-08-15 Thread Stefan Hajnoczi
On Tue, Aug 13, 2019 at 11:07:27AM +0200, Gerd Hoffmann wrote: > Simplifies sending security patches to all people listed in > https://wiki.qemu.org/SecurityProcess. Should also make it > harder to send a copy to the mailing list by accident. > > Signed-off-by: Gerd Hoffmann > --- >

Re: [Qemu-devel] [PATCH] trace: Clarify DTrace/SystemTap help message

2019-08-15 Thread Stefan Hajnoczi
On Thu, Aug 15, 2019 at 02:02:47PM +0200, Philippe Mathieu-Daudé wrote: > Most tracing backends are implemented within QEMU, except the > DTrace/SystemTap backends. > > One side effect is when running 'qemu -trace help', an incomplete > list of trace events is displayed when using the

Re: [Qemu-devel] [PATCH v3 3/4] block/qcow2: refactor qcow2_co_pwritev_part

2019-08-15 Thread Max Reitz
On 15.08.19 14:10, Vladimir Sementsov-Ogievskiy wrote: > Similarly to previous commit, prepare for parallelizing write-loop > iterations. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.c | 153 +- > 1 file changed, 89

[Qemu-devel] Exposing feature deprecation to machine clients (was: [PATCH 2/2] qapi: deprecate implicit filters)

2019-08-15 Thread Markus Armbruster
John Snow writes: > On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote: >> To get rid of implicit filters related workarounds in future let's >> deprecate them now. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- [...] >> diff --git a/blockdev.c b/blockdev.c >> index

Re: [Qemu-devel] [PATCH v5 10/10] linux-user: dumping hot TBs at the end of the execution

2019-08-15 Thread Aleksandar Markovic
15.08.2019. 04.37, "vandersonmr" је написао/ла: > > dumps, in linux-user mode, the hottest TBs if -d tb_stats is used. > > Signed-off-by: Vanderson M. do Rosario > -- Hi, Vanderson, Can you please provide an illustrative example of the dump output, within the commit message? Thanks,

Re: [Qemu-devel] [PATCH 00/13] RFC: luks/encrypted qcow2 key management

2019-08-15 Thread Maxim Levitsky
On Thu, 2019-08-15 at 16:18 +0200, Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 14.08.2019 um 23:08 hat Eric Blake geschrieben: > > > On 8/14/19 3:22 PM, Maxim Levitsky wrote: > > > > > > > This is an issue that was raised today on IRC with Kevin Wolf. Really > > > > thanks > > > >

Re: [Qemu-devel] [PATCH v2] qemu-img convert: Deprecate using -n and -o together

2019-08-15 Thread Eric Blake
On 8/15/19 6:06 AM, Kevin Wolf wrote: > bdrv_create options specified with -o have no effect when skipping image > creation with -n, so this doesn't make sense. Warn against the misuse > and deprecate the combination so we can make it a hard error later. > > Signed-off-by: Kevin Wolf > ---

Re: [Qemu-devel] [PATCH v2] qemu-img convert: Deprecate using -n and -o together

2019-08-15 Thread Max Reitz
On 15.08.19 13:06, Kevin Wolf wrote: > bdrv_create options specified with -o have no effect when skipping image > creation with -n, so this doesn't make sense. Warn against the misuse > and deprecate the combination so we can make it a hard error later. > > Signed-off-by: Kevin Wolf > --- > > -

[Qemu-devel] [Bug 1840252] [NEW] Infinite loop over ERANGE from getsockopt

2019-08-15 Thread Fritz Katze
Public bug reported: Host system: Ubuntu 18.04.3 AMD64 Qemu Version: qemu-arm-static --version qemu-arm version 2.11.1(Debian 1:2.11+dfsg-1ubuntu7.17) Emulated System: Root file system taken from RaspberryPi 3 image ubuntu-18.04.3-preinstalled-server-armhf+raspi3.img from

Re: [Qemu-devel] [PATCH v5 01/10] accel: introducing TBStatistics structure

2019-08-15 Thread Alex Bennée
vandersonmr writes: > To store statistics for each TB, we created a TBStatistics structure > which is linked with the TBs. TBStatistics can stay alive after > tb_flush and be relinked to a regenerated TB. So the statistics can > be accumulated even through flushes. > > The goal is to have all

Re: [Qemu-devel] [PATCH v5 02/10] accel: collecting TB execution count

2019-08-15 Thread Alex Bennée
vandersonmr writes: > If a TB has a TBS (TBStatistics) with the TB_EXEC_STATS > enabled, then we instrument the start code of this TB > to atomically count the number of times it is executed. > We count both the number of "normal" executions and atomic > executions of a TB. > > The execution

Re: [Qemu-devel] [PATCH for-4.2 v10 03/15] virtio-iommu: Add skeleton

2019-08-15 Thread Peter Xu
On Tue, Jul 30, 2019 at 07:21:25PM +0200, Eric Auger wrote: > +static void virtio_iommu_handle_command(VirtIODevice *vdev, VirtQueue *vq) > +{ > +VirtIOIOMMU *s = VIRTIO_IOMMU(vdev); > +struct virtio_iommu_req_head head; > +struct virtio_iommu_req_tail tail; [1] > +

Re: [Qemu-devel] [PATCH v5 03/10] accel: collecting JIT statistics

2019-08-15 Thread Alex Bennée
vandersonmr writes: > If a TB has a TBS (TBStatistics) with the TB_JIT_STATS > enabled then we collect statistics of its translation > processes and code translation. > > Collecting the number of host instructions seems to be > not simple as it would imply in having to modify several > target

Re: [Qemu-devel] [PATCH v5 04/10] accel: replacing part of CONFIG_PROFILER with TBStats

2019-08-15 Thread Alex Bennée
vandersonmr writes: > We add some of the statistics collected in the TCGProfiler > into the TBStats, having the statistics not only for the whole > emulation but for each TB. Then, we removed these stats > from TCGProfiler and reconstruct the information for the > "info jit" using the sum of

Re: [Qemu-devel] [PATCH 00/13] RFC: luks/encrypted qcow2 key management

2019-08-15 Thread Eric Blake
On 8/15/19 9:44 AM, Maxim Levitsky wrote: Does the idea of a union type with a default value for the discriminator help? Maybe we have a discriminator which defaults to 'auto', and add a union branch 'auto':'any'. During creation, if the "driver":"auto" branch is selected

Re: [Qemu-devel] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-15 Thread Laszlo Ersek
On 08/14/19 16:04, Paolo Bonzini wrote: > On 14/08/19 15:20, Yao, Jiewen wrote: >>> - Does this part require a new branch somewhere in the OVMF SEC code? >>> How do we determine whether the CPU executing SEC is BSP or >>> hot-plugged AP? >> [Jiewen] I think this is blocked from hardware

Re: [Qemu-devel] [RFC PATCH v3 15/46] target/i386: introduce function ck_cpuid

2019-08-15 Thread Aleksandar Markovic
15.08.2019. 04.23, "Jan Bobek" је написао/ла: > > Introduce a helper function to take care of instruction CPUID checks. > > Signed-off-by: Jan Bobek > --- Jan, what is the origin of "CK"? If it is a QEMU internal thing, perhaps use "CHECK". The function should be called check_cpuid(), imho. I

Re: [Qemu-devel] [RFC PATCH] ati-vga: Implement dummy VBlank IRQ

2019-08-15 Thread BALATON Zoltan
On Thu, 15 Aug 2019, Gerd Hoffmann wrote: +static void ati_vga_update_irq(ATIVGAState *s) +{ +pci_set_irq(>dev, s->regs.gen_int_status & 1); This should be "s->regs.gen_int_status & s->regs.gen_int_cntl" I guess? Probably, but we only try to emulate VBlank yet so to avoid any problems

Re: [Qemu-devel] [libvirt] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-15 Thread Peter Krempa
On Thu, Aug 15, 2019 at 12:49:28 +0200, Kevin Wolf wrote: > Am 14.08.2019 um 21:27 hat John Snow geschrieben: [...] > > example: > > > > { "return": {}, > > "deprecated": True, > > "warning": "Omitting filter-node-name parameter is deprecated, it will > > be required in the future" > > } >

Re: [Qemu-devel] [PATCH 7/7] target/arm: Use tcg_gen_extrh_i64_i32 to extract the high word

2019-08-15 Thread Richard Henderson
> >This patch is fine, but I noticed while reviewing it that tcg/README >labels both the extrl_i64_i32 and extrh_i64_i32 operations as >"for 64-bit hosts only". Presumably that's a documentation error, >since we're not guarding the existing uses of the extrl_i64_i32 >here with any kind of

Re: [Qemu-devel] [PATCH v0] Implement new cache mode "target"

2019-08-15 Thread Stefan Hajnoczi
On Wed, Aug 07, 2019 at 04:09:54PM +0300, Artemy Kapitula wrote: Hi, Please use "scripts/get_maintainer.pl -f block.c" to find out which maintainers to email. qemu-devel@nongnu.org is a high-traffic list and patches not CCed to the right maintainer may not get quick review. > There is an issue

Re: [Qemu-devel] [libvirt] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-15 Thread Markus Armbruster
Peter Krempa writes: > On Thu, Aug 15, 2019 at 12:49:28 +0200, Kevin Wolf wrote: >> Am 14.08.2019 um 21:27 hat John Snow geschrieben: > > [...] > >> > example: >> > >> > { "return": {}, >> > "deprecated": True, >> > "warning": "Omitting filter-node-name parameter is deprecated, it will >> >

Re: [Qemu-devel] [PATCH v2] usb: reword -usb command-line option and mention xHCI

2019-08-15 Thread Thomas Huth
On 8/15/19 4:14 PM, Stefan Hajnoczi wrote: > The -usb section of the man page is not very clear on what exactly -usb > does and fails to mention xHCI as a modern alternative (-device > nec-usb-xhci). > > Signed-off-by: Stefan Hajnoczi > --- > v2: > * Use @option{-device ...} [Thomas] > *

Re: [Qemu-devel] [PATCH] trace: Clarify DTrace/SystemTap help message

2019-08-15 Thread Philippe Mathieu-Daudé
On 8/15/19 4:45 PM, Stefan Hajnoczi wrote: > On Thu, Aug 15, 2019 at 02:02:47PM +0200, Philippe Mathieu-Daudé wrote: >> Most tracing backends are implemented within QEMU, except the >> DTrace/SystemTap backends. >> >> One side effect is when running 'qemu -trace help', an incomplete >> list of

Re: [Qemu-devel] [PATCH] usb: reword -usb command-line option and mention xHCI

2019-08-15 Thread Gerd Hoffmann
Hi, > > > -Enable the USB driver (if it is not used by default yet). > > > +Enable USB emulation on machine types with an on-board USB host > > > controller (if > > > +not enabled by default). Note that on-board USB host controllers may not > > > +support USB 3.0. In this case -device

Re: [Qemu-devel] [RFC v2] hw/sd/aspeed_sdhci: New device

2019-08-15 Thread Cédric Le Goater
Hello Eddie, On 14/08/2019 22:27, Eddie James wrote: > The Aspeed SOCs have two SD/MMC controllers. Add a device that > encapsulates both of these controllers and models the Aspeed-specific > registers and behavior. > > Tested by reading from mmcblk0 in Linux: > qemu-system-arm -machine

Re: [Qemu-devel] [PULL 5/7] file-posix: Support BDRV_REQ_NO_FALLBACK for zero writes

2019-08-15 Thread Kevin Wolf
Am 15.08.2019 um 04:44 hat Eric Blake geschrieben: > On 3/26/19 10:51 AM, Kevin Wolf wrote: > > We know that the kernel implements a slow fallback code path for > > BLKZEROOUT, so if BDRV_REQ_NO_FALLBACK is given, we shouldn't call it. > > The other operations we call in the context of

Re: [Qemu-devel] [PATCH v2 00/12] block: qiov_offset parameter for io

2019-08-15 Thread Vladimir Sementsov-Ogievskiy
29.07.2019 18:24, Stefan Hajnoczi wrote: > On Tue, Jun 04, 2019 at 07:15:02PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> Here is new parameter qiov_offset for io path, to avoid >> a lot of places with same pattern of creating local_qiov or hd_qiov >> variables. >> >> These series

Re: [Qemu-devel] [PATCH v5 07/10] monitor: adding tb_stats hmp command

2019-08-15 Thread Dr. David Alan Gilbert
* vandersonmr (vanderson...@gmail.com) wrote: > Adding tb_stats [start|pause|stop|filter] command to hmp. > This allows controlling the collection of statistics. > It is also possible to set the level of collection: > all, jit, or exec. > > tb_stats filter allow to only collect statistics for the

Re: [Qemu-devel] [PATCH 2/4] configure: Avoid using libssh deprecated API

2019-08-15 Thread Andrea Bolognani
On Wed, 2019-08-14 at 17:14 +0200, Philippe Mathieu-Daudé wrote: > On 8/14/19 4:51 PM, Andrea Bolognani wrote: > > On Wed, 2019-08-14 at 16:15 +0200, Philippe Mathieu-Daudé wrote: > > > On 8/14/19 3:27 PM, Andrea Bolognani wrote: > > > > On Wed, 2019-08-14 at 14:15 +0200, Philippe Mathieu-Daudé

Re: [Qemu-devel] RISC-V: Vector && DSP Extension

2019-08-15 Thread Aleksandar Markovic
> We can accept draft > extensions in QEMU as long as they are disabled by default. > > Alistair > Hi, Alistair, Palmer, Is this an official stance of QEMU community, or perhaps Alistair's personal judgement, or maybe a rule within risv subcomunity? Yours, Aleksandar

Re: [Qemu-devel] [PATCH 00/13] RFC: luks/encrypted qcow2 key management

2019-08-15 Thread Kevin Wolf
Am 14.08.2019 um 23:08 hat Eric Blake geschrieben: > On 8/14/19 3:22 PM, Maxim Levitsky wrote: > > > This is an issue that was raised today on IRC with Kevin Wolf. Really thanks > > for the idea! > > > > We agreed that this new qmp interface should take the same options as > > blockdev-create

Re: [Qemu-devel] [RFC PATCH v3 46/46] target/i386: introduce SSE3 instructions to sse-opcode.inc.h

2019-08-15 Thread Aleksandar Markovic
15.08.2019. 11.55, "Richard Henderson" је написао/ла: > > On 8/15/19 8:02 AM, Aleksandar Markovic wrote: > > A question for you: What about FISTTP, MONITOR, MWAIT, that belong to SSE3, but > > are not mentioned in this patch? > > > > They are also not vector instructions, which is the subject of

Re: [Qemu-devel] [RFC PATCH] ati-vga: Implement dummy VBlank IRQ

2019-08-15 Thread Gerd Hoffmann
On Thu, Aug 15, 2019 at 02:25:07AM +0200, BALATON Zoltan wrote: > The MacOS driver exits if the card does not have an interrupt. If we > set PCI_INTERRUPT_PIN to 1 then it enables VBlank interrupts and it > boots but the mouse poniter can not be moved. This patch implements a > dummy VBlank

Re: [Qemu-devel] [libvirt] [PATCH 1/2] qapi: deprecate drive-mirror and drive-backup

2019-08-15 Thread Peter Krempa
On Wed, Aug 14, 2019 at 15:22:15 -0400, John Snow wrote: > > > On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote: > > It's hard and not necessary to maintain outdated versions of these > > commands. > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy > > --- > > qemu-deprecated.texi |

Re: [Qemu-devel] [PATCH v3 00/15] target/arm/kvm: enable SVE in guests

2019-08-15 Thread Peter Maydell
On Fri, 2 Aug 2019 at 13:25, Andrew Jones wrote: > > Since Linux kernel v5.2-rc1 KVM has support for enabling SVE in guests. > This series provides the QEMU bits for that enablement. First, we > select existing CPU properties representing features we want to > advertise in addition to the SVE

Re: [Qemu-devel] [PATCH-for-4.2 v9 01/12] hw/acpi: Make ACPI IO address space configurable

2019-08-15 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Linuxarm [mailto:linuxarm-boun...@huawei.com] On Behalf Of Shameer > Kolothum > Sent: 13 August 2019 22:05 > To: qemu-devel@nongnu.org; qemu-...@nongnu.org; > eric.au...@redhat.com; imamm...@redhat.com > Cc: peter.mayd...@linaro.org; sa...@linux.intel.com; >

Re: [Qemu-devel] [RFC PATCH] ati-vga: Implement dummy VBlank IRQ

2019-08-15 Thread BALATON Zoltan
On Thu, 15 Aug 2019, Gerd Hoffmann wrote: On Thu, Aug 15, 2019 at 02:25:07AM +0200, BALATON Zoltan wrote: The MacOS driver exits if the card does not have an interrupt. If we set PCI_INTERRUPT_PIN to 1 then it enables VBlank interrupts and it boots but the mouse poniter can not be moved. This

Re: [Qemu-devel] [RFC PATCH] ati-vga: Implement dummy VBlank IRQ

2019-08-15 Thread Gerd Hoffmann
Hi, > > > +static void ati_vga_update_irq(ATIVGAState *s) > > > +{ > > > +pci_set_irq(>dev, s->regs.gen_int_status & 1); > > > > This should be "s->regs.gen_int_status & s->regs.gen_int_cntl" I guess? > > Probably, but we only try to emulate VBlank yet so to avoid any problems due > to

Re: [Qemu-devel] [PATCH] Fix hw/rdma/vmw/pvrdma_cmd.c build

2019-08-15 Thread Yuval Shaia
On Sun, Aug 11, 2019 at 09:42:47PM +0200, Stephen Kitt wrote: > This was broken by the cherry-pick in 41dd30f. Fix by handling errors > as in the rest of the function: "goto out" instead of "return rc". > > Signed-off-by: Stephen Kitt > --- > hw/rdma/vmw/pvrdma_cmd.c | 2 +- > 1 file changed, 1

Re: [Qemu-devel] [RFC PATCH v3 02/46] target/i386: Push rex_w into DisasContext

2019-08-15 Thread Aleksandar Markovic
15.08.2019. 04.13, "Jan Bobek" је написао/ла: > > From: Richard Henderson > > Treat this the same as we already do for other rex bits. > > Signed-off-by: Richard Henderson > --- > target/i386/translate.c | 19 +++ > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff

Re: [Qemu-devel] [PATCH 00/13] RFC: luks/encrypted qcow2 key management

2019-08-15 Thread Maxim Levitsky
On Wed, 2019-08-14 at 16:08 -0500, Eric Blake wrote: > On 8/14/19 3:22 PM, Maxim Levitsky wrote: > > > This is an issue that was raised today on IRC with Kevin Wolf. Really thanks > > for the idea! > > > > We agreed that this new qmp interface should take the same options as > > blockdev-create

Re: [Qemu-devel] [PATCH v1] s390x/tcg: Fix VERIM with 32/64 bit elements

2019-08-15 Thread Cornelia Huck
On Wed, 14 Aug 2019 17:12:42 +0200 David Hildenbrand wrote: > Wrong order of operands. The constant always comes last. Makes QEMU crash > reliably on specific git fetch invocations. > > Reported-by: Stefano Brivio > Signed-off-by: David Hildenbrand > --- > > I guess it is too late for 4.1 :(

Re: [Qemu-devel] [RFC PATCH v2 16/39] target/i386: introduce instruction operand infrastructure

2019-08-15 Thread Richard Henderson
On 8/15/19 1:00 AM, Jan Bobek wrote: > On 8/13/19 2:07 AM, Richard Henderson wrote: >> On 8/10/19 5:12 AM, Jan Bobek wrote: >>> +#define INSNOP_INIT(opT, init_stmt)\ >>> +static int insnop_init(opT)(CPUX86State *env, DisasContext *s, \ >>> +

Re: [Qemu-devel] [RFC PATCH v3 02/46] target/i386: Push rex_w into DisasContext

2019-08-15 Thread Richard Henderson
On 8/15/19 8:30 AM, Aleksandar Markovic wrote: > > 15.08.2019. 04.13, "Jan Bobek" > је написао/ла: >> >> From: Richard Henderson mailto:r...@twiddle.net>> >> >> Treat this the same as we already do for other rex bits. >> >> Signed-off-by: Richard Henderson

Re: [Qemu-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-15 Thread Yao, Jiewen
Hi Paolo I am not sure what do you mean - "You do not need a reset vector ...". If so, where is the first instruction of the new CPU in the virtualization environment? Please help me understand that at first. Then we can continue the discussion. Thank you Yao Jiewen > -Original Message-

Re: [Qemu-devel] [RFC PATCH v3 46/46] target/i386: introduce SSE3 instructions to sse-opcode.inc.h

2019-08-15 Thread Richard Henderson
On 8/15/19 8:02 AM, Aleksandar Markovic wrote: > A question for you: What about FISTTP, MONITOR, MWAIT, that belong to SSE3, > but > are not mentioned in this patch? > They are also not vector instructions, which is the subject of this patch set. r~

Re: [Qemu-devel] RISC-V: Vector && DSP Extension

2019-08-15 Thread Aleksandar Markovic
15.08.2019. 11.07, "Peter Maydell" је написао/ла: > > On Thu, 15 Aug 2019 at 09:53, Aleksandar Markovic > wrote: > > > > > We can accept draft > > > extensions in QEMU as long as they are disabled by default. > > > Hi, Alistair, Palmer, > > > > Is this an official stance of QEMU community, or

Re: [Qemu-devel] [PATCH 0/7] target/arm: Misc cleanups

2019-08-15 Thread Peter Maydell
On Thu, 8 Aug 2019 at 21:26, Richard Henderson wrote: > > Some of these were cleanups that I was making simultaneous > with the decodetree split. Let's do those beforehand to > make the split easier to read. > > Some of these are new, noticed while I was in the area. > > > r~ > > > Richard

Re: [Qemu-devel] [RFC PATCH v3 03/46] target/i386: reduce scope of variable aflag

2019-08-15 Thread Aleksandar Markovic
15.08.2019. 04.10, "Jan Bobek" је написао/ла: > > The variable aflag is not used in most of disas_insn; make this clear > by explicitly reducing its scope to the block where it is used. > > Suggested-by: Richard Henderson > Reviewed-by: Richard Henderson > Signed-off-by: Jan Bobek > --- Jan,

Re: [Qemu-devel] RISC-V: Vector && DSP Extension

2019-08-15 Thread Peter Maydell
On Thu, 15 Aug 2019 at 09:53, Aleksandar Markovic wrote: > > > We can accept draft > > extensions in QEMU as long as they are disabled by default. > Hi, Alistair, Palmer, > > Is this an official stance of QEMU community, or perhaps Alistair's > personal judgement, or maybe a rule within risv

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-15 Thread Kevin Wolf
Am 14.08.2019 um 21:27 hat John Snow geschrieben: > > > On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote: > > To get rid of implicit filters related workarounds in future let's > > deprecate them now. > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy > > --- > > qemu-deprecated.texi

Re: [Qemu-devel] [RFC PATCH v3 43/46] target/i386: introduce SSE2 instructions to sse-opcode.inc.h

2019-08-15 Thread Aleksandar Markovic
15.08.2019. 04.51, "Jan Bobek" је написао/ла: > > Add all the SSE2 instruction entries to sse-opcode.inc.h. > > Signed-off-by: Jan Bobek > --- I gather the order of items in this file is based on instruction functionality. This means, however, that, for example, SSE2 items will be scattered all

Re: [Qemu-devel] [PATCH v3 00/15] target/arm/kvm: enable SVE in guests

2019-08-15 Thread Andrew Jones
On Thu, Aug 15, 2019 at 09:31:35AM +0100, Peter Maydell wrote: > On Fri, 2 Aug 2019 at 13:25, Andrew Jones wrote: > > > > Since Linux kernel v5.2-rc1 KVM has support for enabling SVE in guests. > > This series provides the QEMU bits for that enablement. First, we > > select existing CPU

Re: [Qemu-devel] [RFC PATCH v3 02/46] target/i386: Push rex_w into DisasContext

2019-08-15 Thread Aleksandar Markovic
15.08.2019. 11.55, "Richard Henderson" је написао/ла: > > On 8/15/19 8:30 AM, Aleksandar Markovic wrote: > > > > 15.08.2019. 04.13, "Jan Bobek" > > је написао/ла: > >> > >> From: Richard Henderson mailto:r...@twiddle.net>> > >> > >> Treat this the same as we already

Re: [Qemu-devel] [RFC v3 0/2] Add live migration support in the PVRDMA device

2019-08-15 Thread Yuval Shaia
On Sun, Jul 21, 2019 at 05:18:01AM +0530, Sukrit Bhatnagar wrote: > In v2, we had successful migration of PCI and MSIX states as well as > various DMA addresses and ring page information. > This series enables the migration of various GIDs used by the device. > > We have switched to a setup

Re: [Qemu-devel] [PATCH 0/3] colo: Add support for continious replication

2019-08-15 Thread Zhang, Chen
Hi Lukas, Please fix this issue and add more comments in the commit log. Thanks Zhang Chen > -Original Message- > From: no-re...@patchew.org [mailto:no-re...@patchew.org] > Sent: Thursday, August 15, 2019 11:20 AM > To: lukasstra...@web.de > Cc: Zhang, Chen ; qemu-devel@nongnu.org >

Re: [Qemu-devel] [PATCH v5 08/10] Adding info [tbs|tb|coverset] commands to HMP. These commands allow the exploration of TBs generated by the TCG. Understand which one hotter, with more guest/host ins

2019-08-15 Thread Dr. David Alan Gilbert
* vandersonmr (vanderson...@gmail.com) wrote: > The goal of this command is to allow the dynamic exploration > of TCG behavior and code quality. Therefore, for now, a > corresponding QMP command is not worthwhile. > > Signed-off-by: Vanderson M. do Rosario > --- > accel/tcg/tb-stats.c |

Re: [Qemu-devel] [PATCH v1 0/2] Integrating qemu to Linux Perf

2019-08-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190815023725.2659-1-vanderson...@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH v5 09/10] monitor: adding new info cfg command

2019-08-15 Thread Dr. David Alan Gilbert
* vandersonmr (vanderson...@gmail.com) wrote: > Adding "info cfg id depth" commands to HMP. > This command allow the exploration a TB > neighbors by dumping [and opening] a .dot > file with the TB CFG neighbors colorized > by their hotness. > > The goal of this command is to allow the dynamic

Re: [Qemu-devel] [PATCH v4 0/3] High downtime with 95+ throttle pct

2019-08-15 Thread Yury Kotov
Ping ping 07.08.2019, 10:42, "Yury Kotov" : > Ping > > 23.07.2019, 16:42, "Yury Kotov" : >>  Hi, >> >>  V4: >>  * The test was simplified to prevent false fails. >> >>  V3: >>  * Rebase fixes (migrate_set_parameter -> migrate_set_parameter_int) >> >>  V2: >>  * Added a test >>  * Fixed

Re: [Qemu-devel] [PATCH 7/7] target/arm: Use tcg_gen_extrh_i64_i32 to extract the high word

2019-08-15 Thread Peter Maydell
On Thu, 8 Aug 2019 at 21:26, Richard Henderson wrote: > > Separate shift + extract low will result in one extra insn > for hosts like RISC-V, MIPS, and Sparc. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 18 ++ > 1 file changed, 6 insertions(+), 12

[Qemu-devel] [PATCH v2] qemu-img convert: Deprecate using -n and -o together

2019-08-15 Thread Kevin Wolf
bdrv_create options specified with -o have no effect when skipping image creation with -n, so this doesn't make sense. Warn against the misuse and deprecate the combination so we can make it a hard error later. Signed-off-by: Kevin Wolf --- - Hopefully removed the "finger-wagging" that John

[Qemu-devel] [PATCH v2 3/7] iotests: Keep testing broken relative extent paths

2019-08-15 Thread Max Reitz
We had a test for a case where relative extent paths did not work, but unfortunately we just fixed the underlying problem, so it works now. This patch adds a new test case that still fails. Signed-off-by: Max Reitz Reviewed-by: John Snow --- tests/qemu-iotests/059 | 27

[Qemu-devel] [PATCH v2 0/7] vmdk: Misc fixes

2019-08-15 Thread Max Reitz
I made the mistake of trying to run the iotests with all non-default subformats our vmdk driver has to offer: - monolithicFlat - twoGbMaxExtentSparse - twoGbMaxExtentFlat - streamOptimized Many things broke, so this series fixes what I found. It’s mostly just iotest fixes, but there are actually

Re: [Qemu-devel] [PATCH-for-4.2 v2 2/6] s390x/tcg: Rework MMU selection for instruction fetches

2019-08-15 Thread Cornelia Huck
On Wed, 14 Aug 2019 09:23:51 +0200 David Hildenbrand wrote: > Instructions are always fetched from primary address space, except when > in home address mode. Perform the selection directly in cpu_mmu_index(). > > get_mem_index() is only used to perform data access, instructions are > fetched

[Qemu-devel] ANNOUNCE: libnbd 0.9.8 - prerelease of high performance NBD client library

2019-08-15 Thread Richard W.M. Jones
I'm pleased to announce a new high performance Network Block Device (NBD) client library called libnbd. It's written in C and there are also bindings available for Python, OCaml and (soon) Rust. 0.9.8 is the third pre-release before the stable 1.0 version where we freeze the API, so feedback on

Re: [Qemu-devel] [PATCH v1 1/2] accel/tcg: adding integration with linux perf

2019-08-15 Thread Alex Bennée
Stefan Hajnoczi writes: > On Wed, Aug 14, 2019 at 11:37:24PM -0300, vandersonmr wrote: >> This commit adds support to Linux Perf in order >> to be able to analyze qemu jitted code and >> also to able to see the TBs PC in it. > > Is there any reference to the file format? Please include it in

Re: [Qemu-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-15 Thread Paolo Bonzini
On 15/08/19 18:07, Igor Mammedov wrote: > Looking at Q35 code and Seabios SMM relocation as example, if I see it > right QEMU has: > - SMRAM is aliased from DRAM at 0xa > - and TSEG steals from the top of low RAM when configured > > Now problem is that default SMBASE at 0x3 isn't

[Qemu-devel] [PULL 01/33] migration: Add error_desc for file channel errors

2019-08-15 Thread Dr. David Alan Gilbert (git)
From: Yury Kotov Currently, there is no information about error if outgoing migration was failed because of file channel errors. Example (QMP session): -> { "execute": "migrate", "arguments": { "uri": "exec:head -c 1" }} <- { "return": {} } ... -> { "execute": "query-migrate" } <- { "return": {

[Qemu-devel] [PULL 03/33] migration: consolidate time info into populate_time_info

2019-08-15 Thread Dr. David Alan Gilbert (git)
From: Wei Yang Consolidate time information fill up into its function for better readability. Signed-off-by: Wei Yang Message-Id: <20190716005411.4156-1-richardw.y...@linux.intel.com> Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert --- migration/migration.c | 40

  1   2   3   >