Re: [Qemu-devel] [RFC 2/3] intc/arm_gic: Support PPI injection for more than 256 vpus

2019-08-29 Thread Auger Eric
Hi, On 8/29/19 9:58 AM, Auger Eric wrote: > Hi Zenghui, > > On 8/29/19 4:53 AM, Zenghui Yu wrote: >> Hi Eric, >> >> On 2019/8/28 0:05, Eric Auger wrote: >>> Host kernels that expose the KVM_CAP_ARM_IRQ_LINE_LAYOUT_2 capability >>> allow injection of PPIs along with vcpu ids larger than 255. Let's

Re: [Qemu-devel] [PATCH] configure: Add pkg-config handling for libgcrypt

2019-08-29 Thread Daniel P . Berrangé
On Thu, Aug 29, 2019 at 05:26:49PM +0800, He Zhe wrote: > > > On 8/29/19 5:15 PM, Daniel P. Berrangé wrote: > > On Thu, Aug 29, 2019 at 04:53:02PM +0800, zhe...@windriver.com wrote: > >> From: He Zhe > >> > >> libgcrypt may also be controlled by pkg-config, this patch adds pkg-config > >>

Re: [Qemu-devel] [patch-for-4.2 PATCH v11 0/6] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2019-08-29 Thread Greg Kurz
On Wed, 14 Aug 2019 11:40:50 +0530 Aravinda Prasad wrote: > This patch set adds support for FWNMI in PowerKVM guests. > > System errors such as SLB multihit and memory errors > that cannot be corrected by hardware is passed on to > the kernel for handling by raising machine check > exception

Re: [Qemu-devel] [RFC Patch] xen/pt: Emulate FLR capability

2019-08-29 Thread Roger Pau Monné
On Thu, Aug 29, 2019 at 05:02:27PM +0800, Chao Gao wrote: > Currently, for a HVM on Xen, no reset method is virtualized. So in a VM's > perspective, assigned devices cannot be reset. But some devices rely on PCI > reset to recover from hardware hangs. When being assigned to a VM, those > devices

[Qemu-devel] [PULL 05/31] target/mips: Clean up handling of CP0 register 4

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 4. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-6-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.h | 2 ++ target/mips/translate.c | 36

[Qemu-devel] [PULL 13/31] target/mips: Clean up handling of CP0 register 12

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 12. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-14-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.h | 3 +++ target/mips/translate.c | 32

[Qemu-devel] [PULL 19/31] target/mips: Clean up handling of CP0 register 18

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 18. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-20-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.h | 20 +--- target/mips/translate.c | 64

[Qemu-devel] [PULL 25/31] target/mips: Clean up handling of CP0 register 26

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 26. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-26-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.h | 2 +- target/mips/translate.c | 8 2 files

[Qemu-devel] [PULL 22/31] target/mips: Clean up handling of CP0 register 23

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 23. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-23-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.h | 6 +++ target/mips/translate.c | 126

[Qemu-devel] [PULL 12/31] target/mips: Clean up handling of CP0 register 11

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 11. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-13-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/translate.c | 8 1 file changed, 4 insertions(+), 4

Re: [Qemu-devel] [PATCH v9 03/13] block/backup: introduce BlockCopyState

2019-08-29 Thread Vladimir Sementsov-Ogievskiy
Thanks for reviewing! 28.08.2019 18:59, Max Reitz wrote: > On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote: >> Split copying code part from backup to "block-copy", including separate >> state structure and function renaming. This is needed to share it with >> backup-top filter driver in

Re: [Qemu-devel] [PATCH v9 04/13] block/backup: adjust block-copy functions style

2019-08-29 Thread Vladimir Sementsov-Ogievskiy
28.08.2019 19:06, Max Reitz wrote: > On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote: >> Fix comment style and reflow arguments in same manner like >> block_copy_state_new. > > I like the current function header style better. > OK, not critical at all for me, let's keep current. I'll

Re: [Qemu-devel] [PATCH RFC 0/4] intel_iommu: Do sanity check of vfio-pci earlier

2019-08-29 Thread Peter Xu
On Thu, Aug 29, 2019 at 10:46:42AM +0200, Auger Eric wrote: > If I understand correctly PT mode is a bypass mode. With the ARM SMMUv3 > the IOMMU MR translate() function gets called but implements a direct > mapping. I understand that on your side, you destroy the IOMMU MR, right? > > At the

[Qemu-devel] [PATCH v5 1/2] memory: Add IOMMU_ATTR_NEED_HW_NESTED_PAGING IOMMU memory region attribute

2019-08-29 Thread Eric Auger
We introduce a new IOMMU Memory Region attribute, IOMMU_ATTR_NEED_HW_NESTED_PAGING that tells whether the virtual IOMMU relies on physical IOMMU HW nested paging capability when protecting host assigned devices. Current Intel virtual IOMMU device supports "Caching Mode" and does not require 2

[Qemu-devel] [PATCH v5 0/2] VFIO/SMMUv3: Fail on VFIO/HW nested paging detection

2019-08-29 Thread Eric Auger
As of today when a guest is assigned with a host PCI device and an SMMUv3, VFIO calls memory_region_iommu_replay() default implementation. This translates the whole address range and completely stalls the execution. As VFIO/SMMUv3 integration is not supported yet (it requires SMMUv3 HW nested

Re: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type

2019-08-29 Thread Jing Liu
Hi Sergio, The idea is interesting and I tried to launch a guest by your guide but seems failed to me. I tried both legacy and normal modes, but the vncviewer connected and told me that: The vm has no graphic display device. All the screen in vnc is just black. kernel config: CONFIG_KVM_MMIO=y

[Qemu-devel] [PATCH v5 2/2] hw/vfio/common: Fail on VFIO/HW nested paging detection

2019-08-29 Thread Eric Auger
As of today, VFIO only works along with vIOMMU supporting caching mode. The SMMUv3 does not support this mode and requires HW nested paging to work properly with VFIO. So any attempt to run a VFIO device protected by such IOMMU would prevent the assigned device from working and at the moment the

[Qemu-devel] [PATCH 1/2] scripts/git.orderfile: Order Python files before unordered ones

2019-08-29 Thread Philippe Mathieu-Daudé
Order Python source files before the rest of unordered files. This helps in particular while reviewing iotests. Signed-off-by: Philippe Mathieu-Daudé --- scripts/git.orderfile | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/git.orderfile b/scripts/git.orderfile index

[Qemu-devel] [PATCH 0/2] git.orderfile: Order Python/shell scripts before unordered files

2019-08-29 Thread Philippe Mathieu-Daudé
This series update the git.orderfile to order Python and shell scripts before unordered files. This is particularly useful for changes in tests/qemu-iotests. Regards, Phil. Philippe Mathieu-Daudé (2): scripts/git.orderfile: Order Python files before unordered ones scripts/git.orderfile:

[Qemu-devel] [PULL 06/31] target/mips: Clean up handling of CP0 register 5

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 5. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-7-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.h | 6 + target/mips/translate.c | 64

[Qemu-devel] [PULL 14/31] target/mips: Clean up handling of CP0 register 13

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 13. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-15-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.h | 2 ++ target/mips/translate.c | 8 2 files

[Qemu-devel] [PULL 26/31] target/mips: Clean up handling of CP0 register 27

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 27. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-27-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/translate.c | 20 1 file changed, 4

[Qemu-devel] [PULL 21/31] target/mips: Clean up handling of CP0 register 20

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 20. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-22-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/translate.c | 8 1 file changed, 4 insertions(+), 4

[Qemu-devel] [PULL 31/31] target/mips: Fix emulation of ST.W in system mode

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Order of arguments in helper_ret_stl_mmu() invocations was wrong, apparently caused by a misplaced multiline copy-and-paste. Fixes: 6decc57 ("target/mips: Fix MSA instructions ST. on big endian host") Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo

[Qemu-devel] [PULL 18/31] target/mips: Clean up handling of CP0 register 17

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 17. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-19-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/translate.c | 32 1 file changed,

Re: [Qemu-devel] [PATCH 0/2] git.orderfile: Order Python/shell scripts before unordered files

2019-08-29 Thread Eric Blake
On 8/29/19 5:05 AM, Philippe Mathieu-Daudé wrote: > This series update the git.orderfile to order Python and shell > scripts before unordered files. > This is particularly useful for changes in tests/qemu-iotests. > > Regards, > > Phil. > > Philippe Mathieu-Daudé (2): > scripts/git.orderfile:

[Qemu-devel] [PATCH] configure: Add pkg-config handling for libgcrypt

2019-08-29 Thread zhe.he
From: He Zhe libgcrypt may also be controlled by pkg-config, this patch adds pkg-config handling for libgcrypt. Signed-off-by: He Zhe --- configure | 48 1 file changed, 40 insertions(+), 8 deletions(-) diff --git a/configure b/configure index

Re: [Qemu-devel] [PATCH RFC 0/4] intel_iommu: Do sanity check of vfio-pci earlier

2019-08-29 Thread Peter Xu
On Thu, Aug 29, 2019 at 10:05:27AM +0200, Auger Eric wrote: > Hi Peter, Hi, Eric, > On 8/29/19 3:18 AM, Peter Xu wrote: > > On Wed, Aug 28, 2019 at 02:59:45PM +0200, Auger Eric wrote: > >> Hi Peter, > > > > Hi, Eric, > > > > [...] > > > >> In > >> [PATCH v4 2/5] memory: Add

Re: [Qemu-devel] [PATCH-for-4.2 v9 01/12] hw/acpi: Make ACPI IO address space configurable

2019-08-29 Thread Igor Mammedov
On Thu, 15 Aug 2019 08:42:48 + Shameerali Kolothum Thodi wrote: > > -Original Message- > > From: Linuxarm [mailto:linuxarm-boun...@huawei.com] On Behalf Of Shameer > > Kolothum > > Sent: 13 August 2019 22:05 > > To: qemu-devel@nongnu.org; qemu-...@nongnu.org; > >

Re: [Qemu-devel] [PATCH v9 11/13] block: add lock/unlock range functions

2019-08-29 Thread Vladimir Sementsov-Ogievskiy
28.08.2019 20:02, Max Reitz wrote: > On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote: >> From: Vladimir Sementsov-Ogievskiy > > Hm. :-) > > Do you want to fix that? Yes.. Hmm seems like I was working from home at some moment > >> Introduce lock/unlock range functionality, based on

[Qemu-devel] [PATCH 2/2] scripts/git.orderfile: Order shell scripts before unordered files

2019-08-29 Thread Philippe Mathieu-Daudé
Order shell scripts before the rest of unordered files. This helps in particular while reviewing iotests. Signed-off-by: Philippe Mathieu-Daudé --- scripts/git.orderfile | 4 1 file changed, 4 insertions(+) diff --git a/scripts/git.orderfile b/scripts/git.orderfile index

Re: [Qemu-devel] [patch-for-4.2 PATCH v11 3/6] target/ppc: Handle NMI guest exit

2019-08-29 Thread Greg Kurz
On Wed, 14 Aug 2019 11:41:16 +0530 Aravinda Prasad wrote: > Memory error such as bit flips that cannot be corrected > by hardware are passed on to the kernel for handling. > If the memory address in error belongs to guest then > the guest kernel is responsible for taking suitable action. > Patch

[Qemu-devel] [PULL 15/31] target/mips: Clean up handling of CP0 register 14

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 14. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-16-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.h | 1 + target/mips/translate.c | 8 2 files

[Qemu-devel] [PULL 03/31] target/mips: Clean up handling of CP0 register 2

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 2. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-4-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.h | 7 ++ target/mips/translate.c | 64

[Qemu-devel] [PULL 01/31] target/mips: Clean up handling of CP0 register 0

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 0. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-2-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.h | 3 +++ target/mips/translate.c | 40

[Qemu-devel] [PATCH] virtiofsd: add man page

2019-08-29 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- Makefile | 7 +++ contrib/virtiofsd/virtiofsd.texi | 85 2 files changed, 92 insertions(+) create mode 100644 contrib/virtiofsd/virtiofsd.texi diff --git a/Makefile b/Makefile index

Re: [Qemu-devel] [PATCH] configure: Add pkg-config handling for libgcrypt

2019-08-29 Thread He Zhe
On 8/29/19 5:15 PM, Daniel P. Berrangé wrote: > On Thu, Aug 29, 2019 at 04:53:02PM +0800, zhe...@windriver.com wrote: >> From: He Zhe >> >> libgcrypt may also be controlled by pkg-config, this patch adds pkg-config >> handling for libgcrypt. > Where are you seeing pkg-config files for

[Qemu-devel] [PULL 3/3] usb-mtp: add sanity checks on rootdir

2019-08-29 Thread Gerd Hoffmann
From: Bandan Das Currently, we don't check if rootdir exists and is accessible. Furthermore, a trailing slash results in a null "desc" string which ends up in the share not visible in the guest. Add some simple sanity checks for appropriate permissions. Also, bail out if the user does not supply

[Qemu-devel] [PULL 1/3] xhci: Fix memory leak in xhci_address_slot

2019-08-29 Thread Gerd Hoffmann
From: Ying Fang Address Sanitizer shows memory leak in xhci_address_slot hw/usb/hcd-xhci.c:2156 and the stack is as bellow: Direct leak of 64 byte(s) in 4 object(s) allocated from: #0 0x91c6f5ab in realloc (/lib64/libasan.so.4+0xd35ab) #1 0x91987243 in g_realloc

Re: [Qemu-devel] [PATCH] target/arm: Fix SMMLS argument order

2019-08-29 Thread Laurent Desnogues
Hi, On Thu, Aug 29, 2019 at 3:33 AM Richard Henderson wrote: > > The previous simplification got the order of operands to the > subtraction wrong. Since the 64-bit product is the subtrahend, > we must use a 64-bit subtract to properly compute the borrow > from the low-part of the product. > >

Re: [Qemu-devel] [RFC 2/3] intc/arm_gic: Support PPI injection for more than 256 vpus

2019-08-29 Thread Auger Eric
Hi Zenghui, On 8/29/19 4:53 AM, Zenghui Yu wrote: > Hi Eric, > > On 2019/8/28 0:05, Eric Auger wrote: >> Host kernels that expose the KVM_CAP_ARM_IRQ_LINE_LAYOUT_2 capability >> allow injection of PPIs along with vcpu ids larger than 255. Let's >> encode the vpcu id on 12 bits according to the

[Qemu-devel] [PULL 11/31] target/mips: Clean up handling of CP0 register 10

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 10. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-12-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.h | 1 + target/mips/translate.c | 8 2 files

[Qemu-devel] [PULL 08/31] target/mips: Clean up handling of CP0 register 7

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 7. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-9-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/translate.c | 8 1 file changed, 4 insertions(+), 4

[Qemu-devel] [PULL 09/31] target/mips: Clean up handling of CP0 register 8

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 8. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-10-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.h | 1 + target/mips/translate.c | 32

[Qemu-devel] [PULL 00/31] MIPS queue for August 29th, 2019

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic The following changes since commit 1b142da5f82a8fcdc7783a418592de654d5c6052: target/mips: Clean up handling of CP0 register 0 (2019-08-29 11:50:18 +0200) are available in the git repository at: https://github.com/AMarkovic/qemu tags/mips-queue-aug-29-2019 for

[Qemu-devel] [PULL 27/31] target/mips: Clean up handling of CP0 register 28

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 28. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-28-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.h | 24 +++ target/mips/translate.c | 64

[Qemu-devel] [PULL 24/31] target/mips: Clean up handling of CP0 register 25

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 25. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-25-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/translate.c | 64 -

Re: [Qemu-devel] [Qemu-ppc] [patch-for-4.2 PATCH v11 0/6] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2019-08-29 Thread Aravinda Prasad
On Thursday 29 August 2019 03:51 PM, Greg Kurz wrote: > On Wed, 14 Aug 2019 11:40:50 +0530 > Aravinda Prasad wrote: > >> This patch set adds support for FWNMI in PowerKVM guests. >> >> System errors such as SLB multihit and memory errors >> that cannot be corrected by hardware is passed on to

Re: [Qemu-devel] [PATCH-for-4.2 v9 01/12] hw/acpi: Make ACPI IO address space configurable

2019-08-29 Thread Shameerali Kolothum Thodi
Hi Igor, > -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: 29 August 2019 09:45 > To: Shameerali Kolothum Thodi > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; > eric.au...@redhat.com; peter.mayd...@linaro.org; sa...@linux.intel.com; >

Re: [Qemu-devel] [PATCH v9 05/13] block: move block_copy from block/backup.c to separate file

2019-08-29 Thread Vladimir Sementsov-Ogievskiy
28.08.2019 19:16, Max Reitz wrote: > On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote: >> Split block_copy to separate file, to be cleanly shared with backup-top >> filter driver in further commits. >> >> It's a clean movement, the only change is drop "static" from interface >> functions. >>

Re: [Qemu-devel] [PATCH v2 5/7] mips/tcg: Call probe_write() for CONFIG_USER_ONLY as well

2019-08-29 Thread Aleksandar Markovic
26.08.2019. 09.52, "David Hildenbrand" је написао/ла: > > Let's call it also for CONFIG_USER_ONLY. While at it, add a FIXME and get > rid of one local variable. > > MIPS code probably needs a bigger refactoring in regards of > ensure_writable_pages(), similar to s390x, so for example, watchpoints

[Qemu-devel] [PATCH] qapi: Reintroduce CommandDisabled error class

2019-08-29 Thread Michal Privoznik
If there was a disabled command, then qemu-ga used to report CommandDisabled error class (among with human readable description). This changed in v1.2.0-rc0~28^2~16 in favor of GenericError class. While the change might work for other classes, this one should not have been dropped because it helps

Re: [Qemu-devel] [PATCH] configure: Add pkg-config handling for libgcrypt

2019-08-29 Thread Daniel P . Berrangé
On Thu, Aug 29, 2019 at 04:53:02PM +0800, zhe...@windriver.com wrote: > From: He Zhe > > libgcrypt may also be controlled by pkg-config, this patch adds pkg-config > handling for libgcrypt. Where are you seeing pkg-config files for libgcrypt ? The upstream project has (frustratingly) been

[Qemu-devel] [PULL 17/31] target/mips: Clean up handling of CP0 register 16

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 16. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-18-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.h | 3 ++- target/mips/translate.c | 60

[Qemu-devel] [PULL 20/31] target/mips: Clean up handling of CP0 register 19

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 19. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-21-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.h | 4 target/mips/translate.c | 64

[Qemu-devel] [PULL 28/31] target/mips: Clean up handling of CP0 register 29

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 29. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-29-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.h | 22 ++--- target/mips/translate.c | 64

[Qemu-devel] [PULL 0/3] Usb 20190829 patches

2019-08-29 Thread Gerd Hoffmann
The following changes since commit 23919ddfd56135cad3cb468a8f54d5a595f024f4: Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190827' into staging (2019-08-27 15:52:36 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-20190829-pull-request

[Qemu-devel] [PULL 2/3] xhci: Fix memory leak in xhci_kick_epctx

2019-08-29 Thread Gerd Hoffmann
From: fangying Address Sanitizer shows memory leak in xhci_kick_epctx hw/usb/hcd-xhci.c:1912. A sglist is leaked when a packet is retired and returns USB_RET_NAK status. The leak stack is as bellow: Direct leak of 2688 byte(s) in 168 object(s) allocated from: #0 0xae8b11db in

Re: [Qemu-devel] [PATCH v1 8/9] accel/stubs: reduce headers from tcg-stub

2019-08-29 Thread Alex Bennée
Alex Bennée writes: > We don't need much for these. However I do wonder why these aren't > just null inlines in exec-all.h > > Signed-off-by: Alex Bennée > Reviewed-by: Richard Henderson > --- > accel/stubs/tcg-stub.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git

Re: [Qemu-devel] Cryptic errors from PIP install if missing openssl-devel

2019-08-29 Thread Philippe Mathieu-Daudé
Hi Cleber, Lukáš, On 8/29/19 11:24 AM, Philippe Mathieu-Daudé wrote: > On 8/29/19 5:27 AM, Cleber Rosa wrote: >> On Thu, Aug 29, 2019 at 11:51:17AM +1000, David Gibson wrote: [...] >>> Fwiw, I also get an equally cryptic error that I haven't figured out >>> the cause for on my 32-bit Fedora

Re: [Qemu-devel] [RFC Patch] xen/pt: Emulate FLR capability

2019-08-29 Thread Jan Beulich
On 29.08.2019 11:02, Chao Gao wrote: > Currently, for a HVM on Xen, no reset method is virtualized. So in a VM's > perspective, assigned devices cannot be reset. But some devices rely on PCI > reset to recover from hardware hangs. When being assigned to a VM, those > devices cannot be reset and

[Qemu-devel] [PULL 23/31] target/mips: Clean up handling of CP0 register 24

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 24. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-24-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/translate.c | 8 1 file changed, 4 insertions(+), 4

[Qemu-devel] [PATCH] configure: Add pkg-config handling for libgcrypt

2019-08-29 Thread zhe.he
From: He Zhe libgcrypt may also be controlled by pkg-config, this patch adds pkg-config handling for libgcrypt. Signed-off-by: He Zhe --- configure | 48 1 file changed, 40 insertions(+), 8 deletions(-) diff --git a/configure b/configure index

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] git.orderfile: Order Python/shell scripts before unordered files

2019-08-29 Thread Stefano Garzarella
On Thu, Aug 29, 2019 at 12:05:19PM +0200, Philippe Mathieu-Daudé wrote: > This series update the git.orderfile to order Python and shell > scripts before unordered files. > This is particularly useful for changes in tests/qemu-iotests. > > Regards, > > Phil. > > Philippe Mathieu-Daudé (2): >

Re: [Qemu-devel] [Slirp] [PATCH 1/2] Do not reassemble fragments pointing outside of the original payload

2019-08-29 Thread P J P
+-- On Mon, 26 Aug 2019, Samuel Thibault wrote --+ | Philippe Mathieu-Daudé, le ven. 23 août 2019 17:15:32 +0200, a ecrit: | > > Did you make your test with commit 126c04acbabd ("Fix heap overflow in | > > ip_reass on big packet input") applied? | > | > Yes, unfortunately it doesn't fix the

Re: [Qemu-devel] [PATCH RFC 0/4] intel_iommu: Do sanity check of vfio-pci earlier

2019-08-29 Thread Auger Eric
Hi Peter, On 8/29/19 3:18 AM, Peter Xu wrote: > On Wed, Aug 28, 2019 at 02:59:45PM +0200, Auger Eric wrote: >> Hi Peter, > > Hi, Eric, > > [...] > >> In >> [PATCH v4 2/5] memory: Add IOMMU_ATTR_HW_NESTED_PAGING IOMMU memory >> region attribute (https://patchwork.kernel.org/patch/11109701/) > >

[Qemu-devel] [RFC Patch] xen/pt: Emulate FLR capability

2019-08-29 Thread Chao Gao
Currently, for a HVM on Xen, no reset method is virtualized. So in a VM's perspective, assigned devices cannot be reset. But some devices rely on PCI reset to recover from hardware hangs. When being assigned to a VM, those devices cannot be reset and won't work any longer if a hardware hang

[Qemu-devel] [PATCH v3] job: drop job_drain

2019-08-29 Thread Vladimir Sementsov-Ogievskiy
In job_finish_sync job_enter should be enough for a job to make some progress and draining is a wrong tool for it. So use job_enter directly here and drop job_drain with all related staff not used more. Suggested-by: Kevin Wolf Signed-off-by: Vladimir Sementsov-Ogievskiy Tested-by: John Snow

[Qemu-devel] [PULL 16/31] target/mips: Clean up handling of CP0 register 15

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 15. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-17-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.h | 1 + target/mips/translate.c | 20

Re: [Qemu-devel] [PATCH v6 1/6] iotests: allow Valgrind checking all QEMU processes

2019-08-29 Thread Andrey Shinkevich
On 29/08/2019 03:30, Eric Blake wrote: > On 8/28/19 5:58 PM, John Snow wrote: > >>> +++ b/tests/qemu-iotests/common.rc >>> @@ -60,61 +60,132 @@ if ! . ./common.config >>> exit 1 >>> fi >>> >>> +# Unset the variables to turn Valgrind off for specific processes, e.g. > > That's not

[Qemu-devel] [PULL 30/31] target/mips: Clean up handling of CP0 register 31

2019-08-29 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 31. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <1567009614-12438-31-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.h | 2 +- target/mips/translate.c | 56

Re: [Qemu-devel] [PATCH v8 01/37] target/mips: Add support for DSPRAM

2019-08-29 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 8/19/19 2:07 PM, Aleksandar Markovic wrote: > From: Yongbok Kim > > The optional Data Scratch Pad RAM (DSPRAM) block provides a general scratch > pad RAM > used for temporary storage of data. The DSPRAM provides a connection to > on-chip > memory or memory-mapped registers,

Re: [Qemu-devel] [PATCH] qapi: Reintroduce CommandDisabled error class

2019-08-29 Thread Markus Armbruster
Michal Privoznik writes: > If there was a disabled command, then qemu-ga used to report > CommandDisabled error class (among with human readable > description). This changed in v1.2.0-rc0~28^2~16 in favor of > GenericError class. Really? I believe it was slightly earlier in the same series:

Re: [Qemu-devel] [PATCH v1 0/2] Add live migration support in the PVRDMA device

2019-08-29 Thread Yuval Shaia
On Wed, Aug 28, 2019 at 07:53:26PM +0530, Sukrit Bhatnagar wrote: > This series enables the migration of various GIDs used by the device. > This is in addition to the successful migration of PCI and MSIX states > as well as various DMA addresses and ring page information. > > We have a

Re: [Qemu-devel] [PATCH for-4.2 v10 05/15] virtio-iommu: Add the iommu regions

2019-08-29 Thread Auger Eric
Hi Peter, On 8/16/19 6:00 AM, Peter Xu wrote: > On Tue, Jul 30, 2019 at 07:21:27PM +0200, Eric Auger wrote: > > [...] > >> static void virtio_iommu_get_config(VirtIODevice *vdev, uint8_t >> *config_data) >> { >> VirtIOIOMMU *dev = VIRTIO_IOMMU(vdev); >> @@ -266,6 +333,15 @@ static void

Re: [Qemu-devel] [PATCH] RISCV: support riscv vector extension 0.7.1

2019-08-29 Thread liuzhiwei
On 2019/8/29 上午4:43, Richard Henderson wrote: On 8/28/19 11:54 AM, Richard Henderson wrote: But it might be reasonable to include (VSTART == 0 && VL == VLMAX) as a single bit. BTW, it is reasonable to check VSTART == 0 always. Quoting the spec: # Implementations are permitted to raise

Re: [Qemu-devel] [PATCH v6 1/3] target/ppc: Optimize emulation of vpkpx instruction

2019-08-29 Thread Stefan Brankovic
On 27.8.19. 20:52, Richard Henderson wrote: On 8/27/19 2:37 AM, Stefan Brankovic wrote: +for (i = 0; i < 4; i++) { +switch (i) { +case 0: +/* + * Get high doubleword of vA to perfrom 6-5-5 pack of pixels + * 1 and 2. + */ +

[Qemu-devel] [PATCH] tests/docker: upgrade docker.py to python3

2019-08-29 Thread Alex Bennée
The recent podman changes (9459f754134bb) imported enum which is part of the python3 standard library but only available as an external library for python2. This causes problems on the fairly restricted environment such as shippable. Lets bite the bullet and make the script a fully python3 one. To

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-29 Thread Peter Krempa
On Wed, Aug 28, 2019 at 13:48:10 -0400, John Snow wrote: > (Peter: search for "pkrempa" down below.) > > On 8/28/19 5:20 AM, Vladimir Sementsov-Ogievskiy wrote: [] > So that's a bit of a change, but only visually. The "reality" is still > the same, we just report it more "accurately."

Re: [Qemu-devel] [PATCH v9 13/13] block/backup: use backup-top instead of write notifiers

2019-08-29 Thread Vladimir Sementsov-Ogievskiy
28.08.2019 22:50, Max Reitz wrote: > On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote: >> Drop write notifiers and use filter node instead. >> >> = Changes = >> >> 1. add filter-node-name argument for backup qmp api. We have to do it >> in this commit, as 257 needs to be fixed. > > I feel a

Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.2 v5 1/2] kvm: s390: split too big memory section on several memslots

2019-08-29 Thread Christian Borntraeger
On 29.08.19 14:04, Igor Mammedov wrote: > On Thu, 29 Aug 2019 08:47:49 +0200 > Christian Borntraeger wrote: > >> On 27.08.19 14:56, Igor Mammedov wrote: >>> On Tue, 20 Aug 2019 18:07:27 +0200 >>> Cornelia Huck wrote: >>> On Wed, 7 Aug 2019 11:32:41 -0400 Igor Mammedov wrote:

Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.2 v5 1/2] kvm: s390: split too big memory section on several memslots

2019-08-29 Thread Igor Mammedov
On Thu, 29 Aug 2019 14:07:44 +0200 Christian Borntraeger wrote: > On 29.08.19 14:04, Igor Mammedov wrote: > > On Thu, 29 Aug 2019 08:47:49 +0200 > > Christian Borntraeger wrote: > > > >> On 27.08.19 14:56, Igor Mammedov wrote: > >>> On Tue, 20 Aug 2019 18:07:27 +0200 > >>> Cornelia Huck

Re: [Qemu-devel] [PATCH v1 2/2] hw/pvrdma: add live migration support

2019-08-29 Thread Yuval Shaia
On Wed, Aug 28, 2019 at 07:53:28PM +0530, Sukrit Bhatnagar wrote: > vmstate_pvrdma describes the PCI and MSIX states as well as the dma > address for dsr and the gid table of device. > vmstate_pvrdma_gids describes each gid in the gid table. > > pvrdma_post_save() does the job of unregistering

Re: [Qemu-devel] [PATCH v2] pc: Don't make die-id mandatory unless necessary

2019-08-29 Thread Peter Krempa
On Wed, Aug 28, 2019 at 18:57:18 +0200, Igor Mammedov wrote: > On Wed, 28 Aug 2019 11:35:24 -0300 > Eduardo Habkost wrote: > > > On Wed, Aug 28, 2019 at 08:52:28AM +0200, Markus Armbruster wrote: > > > Eduardo Habkost writes: > > > > > > > We have this issue reported when using libvirt to

Re: [Qemu-devel] [PATCH] qapi: Reintroduce CommandDisabled error class

2019-08-29 Thread Eric Blake
On 8/29/19 8:04 AM, Michal Privoznik wrote: >>> A bit of background: up until very recently libvirt used qemu-ga >>> in all or nothing way. It didn't care why a qemu-ga command >>> failed. But very recently a new API was introduced which >>> implements 'best effort' approach (in some cases) and

Re: [Qemu-devel] [PATCH v9 07/13] iotests: prepare 124 and 257 bitmap querying for backup-top filter

2019-08-29 Thread Vladimir Sementsov-Ogievskiy
28.08.2019 19:40, Max Reitz wrote: > On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote: >> After backup-top filter appearing it's not possible to see dirty >> bitmaps in top node, so use node-name instead. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> tests/qemu-iotests/124

Re: [Qemu-devel] [PATCH for-4.2 v5 1/2] kvm: s390: split too big memory section on several memslots

2019-08-29 Thread Igor Mammedov
On Thu, 29 Aug 2019 08:47:49 +0200 Christian Borntraeger wrote: > On 27.08.19 14:56, Igor Mammedov wrote: > > On Tue, 20 Aug 2019 18:07:27 +0200 > > Cornelia Huck wrote: > > > >> On Wed, 7 Aug 2019 11:32:41 -0400 > >> Igor Mammedov wrote: > >> > >>> Max memslot size supported by kvm on

Re: [Qemu-devel] [PATCH] RISCV: support riscv vector extension 0.7.1

2019-08-29 Thread liuzhiwei
On 2019/8/29 上午5:34, Alistair Francis wrote: On Wed, Aug 28, 2019 at 12:04 AM liuzhiwei wrote: Change-Id: I3cf891bc400713b95f47ecca82b1bf773f3dcb25 Signed-off-by: liuzhiwei --- fpu/softfloat.c | 119 + include/fpu/softfloat.h | 4 +

Re: [Qemu-devel] [PATCH-for-4.2 v9 01/12] hw/acpi: Make ACPI IO address space configurable

2019-08-29 Thread Igor Mammedov
On Thu, 29 Aug 2019 11:04:27 + Shameerali Kolothum Thodi wrote: > Hi Igor, > > > -Original Message- > > From: Igor Mammedov [mailto:imamm...@redhat.com] > > Sent: 29 August 2019 09:45 > > To: Shameerali Kolothum Thodi > > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; > >

Re: [Qemu-devel] [PATCH v1 2/2] hw/pvrdma: add live migration support

2019-08-29 Thread Yuval Shaia
On Wed, Aug 28, 2019 at 07:53:28PM +0530, Sukrit Bhatnagar wrote: > vmstate_pvrdma describes the PCI and MSIX states as well as the dma > address for dsr and the gid table of device. > vmstate_pvrdma_gids describes each gid in the gid table. > > pvrdma_post_save() does the job of unregistering

[Qemu-devel] [PATCH] block/vhdx: add check for truncated image files

2019-08-29 Thread Peter Lieven
qemu is currently not able to detect truncated vhdx image files. Add a basic check if all allocated blocks are reachable to vhdx_co_check. Signed-off-by: Jan-Hendrik Frintrop Signed-off-by: Peter Lieven --- block/vhdx.c | 19 +++ 1 file changed, 19 insertions(+) diff --git

Re: [Qemu-devel] [PATCH for-4.2 v10 07/15] virtio-iommu: Implement attach/detach command

2019-08-29 Thread Auger Eric
Hi Peter, On 8/16/19 6:27 AM, Peter Xu wrote: > On Tue, Jul 30, 2019 at 07:21:29PM +0200, Eric Auger wrote: >> This patch implements the endpoint attach/detach to/from >> a domain. >> >> Signed-off-by: Eric Auger >> >> --- >> --- >> hw/virtio/virtio-iommu.c | 40

Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.2 v5 1/2] kvm: s390: split too big memory section on several memslots

2019-08-29 Thread Christian Borntraeger
On 29.08.19 14:31, Igor Mammedov wrote: > On Thu, 29 Aug 2019 14:07:44 +0200 > Christian Borntraeger wrote: > >> On 29.08.19 14:04, Igor Mammedov wrote: >>> On Thu, 29 Aug 2019 08:47:49 +0200 >>> Christian Borntraeger wrote: >>> On 27.08.19 14:56, Igor Mammedov wrote: > On Tue,

Re: [Qemu-devel] [PATCH v2] pc: Don't make die-id mandatory unless necessary

2019-08-29 Thread Peter Krempa
On Thu, Aug 29, 2019 at 15:12:33 +0200, Peter Krempa wrote: > On Wed, Aug 28, 2019 at 18:57:18 +0200, Igor Mammedov wrote: > > On Wed, 28 Aug 2019 11:35:24 -0300 [...] > > Also if we would need to change implicit values logic down the road > > it would be a pain like with any default parameters

Re: [Qemu-devel] [PATCH] tests/docker: upgrade docker.py to python3

2019-08-29 Thread Daniel P . Berrangé
On Thu, Aug 29, 2019 at 03:41:20PM +0100, Alex Bennée wrote: > The recent podman changes (9459f754134bb) imported enum which is part > of the python3 standard library but only available as an external > library for python2. This causes problems on the fairly restricted > environment such as

Re: [Qemu-devel] [PATCH v1 1/2] hw/pvrdma: make DSR mapping idempotent in load_dsr()

2019-08-29 Thread Yuval Shaia
On Wed, Aug 28, 2019 at 07:53:27PM +0530, Sukrit Bhatnagar wrote: > Map to DSR only when there is no mapping done already i.e., when > dev->dsr_info.dsr is NULL. This allows the rest of mappings and > ring inits to be done by calling load_dsr() when DSR has already > been mapped to, somewhere

Re: [Qemu-devel] [PATCH] qapi: Reintroduce CommandDisabled error class

2019-08-29 Thread Michal Privoznik
On 8/29/19 2:10 PM, Markus Armbruster wrote: > Michal Privoznik writes: > >> If there was a disabled command, then qemu-ga used to report >> CommandDisabled error class (among with human readable >> description). This changed in v1.2.0-rc0~28^2~16 in favor of >> GenericError class. > > Really?

Re: [Qemu-devel] [PATCH] RISCV: support riscv vector extension 0.7.1

2019-08-29 Thread liuzhiwei
Hi,  Alex On 2019/8/28 下午5:08, Alex Bennée wrote: liuzhiwei writes: Change-Id: I3cf891bc400713b95f47ecca82b1bf773f3dcb25 Signed-off-by: liuzhiwei --- fpu/softfloat.c | 119 + include/fpu/softfloat.h | 4 + Changes to softfloat should be in a

Re: [Qemu-devel] [PATCH for-4.2 v10 03/15] virtio-iommu: Add skeleton

2019-08-29 Thread Auger Eric
Hi Peter, First of all, please forgive me for the delay. On 8/15/19 3:54 PM, Peter Xu wrote: > On Tue, Jul 30, 2019 at 07:21:25PM +0200, Eric Auger wrote: >> +static void virtio_iommu_handle_command(VirtIODevice *vdev, VirtQueue *vq) >> +{ >> +VirtIOIOMMU *s = VIRTIO_IOMMU(vdev); >> +

Re: [Qemu-devel] [PATCH] qapi: Reintroduce CommandDisabled error class

2019-08-29 Thread Michal Privoznik
On 8/29/19 3:12 PM, Eric Blake wrote: On 8/29/19 8:04 AM, Michal Privoznik wrote: A bit of background: up until very recently libvirt used qemu-ga in all or nothing way. It didn't care why a qemu-ga command failed. But very recently a new API was introduced which implements 'best effort'

  1   2   3   >