Re: [Qemu-devel] [PATCH v4 3/3] qcow2: add zstd cluster compression

2019-09-04 Thread Denis Plotnikov
Kevin, thanks for commenting. I'll resend the series shortly. Denis On 03.09.2019 17:12, Kevin Wolf wrote: > Am 28.08.2019 um 14:56 hat Denis Plotnikov geschrieben: >> zstd significantly reduces cluster compression time. >> It provides better compression performance maintaining >> the same level

Re: [Qemu-devel] [PATCH] memory: Set notdirty_mem_ops validator

2019-09-04 Thread Tony Nguyen
On Tue, Sep 03, 2019 at 05:50:56PM +0100, Peter Maydell wrote: > Do you have a backtrace of QEMU from the segfault? I'm having trouble > thinking of what the situation is when we'd try to invoke the > read handler on io_mem_notdirty... Using tcg-next

Re: [Qemu-devel] [PATCH] numa: Introduce MachineClass::auto_enable_numa for implicit NUMA node

2019-09-04 Thread Tao Xu
On 9/4/2019 1:52 AM, Eduardo Habkost wrote: On Mon, Aug 05, 2019 at 03:13:02PM +0800, Tao Xu wrote: Add MachineClass::auto_enable_numa field. When it is true, a NUMA node is expected to be created implicitly. Acked-by: David Gibson Suggested-by: Igor Mammedov Suggested-by: Eduardo Habkost

[Qemu-devel] [PULL 0/5] Fail patches

2019-09-04 Thread Juan Quintela
The following changes since commit 3483534ec314f6057e66966bfceaa9df02c28fbf: Merge remote-tracking branch 'remotes/cleber/tags/python-next-pull-request' into staging (2019-09-03 16:48:37 +0100) are available in the Git repository at: https://github.com/juanquintela/qemu.git

[Qemu-devel] [PULL 1/5] socket: Add backlog parameter to socket_listen

2019-09-04 Thread Juan Quintela
Current parameter was always one. We continue with that value for now in all callers. Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrangé --- Moved trace to socket_listen --- include/qemu/sockets.h| 2 +- io/channel-socket.c | 2 +- qga/channel-posix.c | 2 +-

[Qemu-devel] [PULL 3/5] socket: Add num connections to qio_channel_socket_async()

2019-09-04 Thread Juan Quintela
Reviewed-by: Daniel P. Berrangé Signed-off-by: Juan Quintela --- include/io/channel-socket.h| 2 ++ io/channel-socket.c| 30 +++--- io/trace-events| 2 +- tests/test-io-channel-socket.c | 2 +- 4 files changed, 27 insertions(+), 9

[Qemu-devel] [PULL 4/5] socket: Add num connections to qio_net_listener_open_sync()

2019-09-04 Thread Juan Quintela
Reviewed-by: Daniel P. Berrangé Signed-off-by: Juan Quintela --- blockdev-nbd.c| 2 +- chardev/char-socket.c | 2 +- include/io/net-listener.h | 2 ++ io/net-listener.c | 3 ++- migration/socket.c| 2 +- qemu-nbd.c| 2 +- ui/vnc.c

[Qemu-devel] [PULL 2/5] socket: Add num connections to qio_channel_socket_sync()

2019-09-04 Thread Juan Quintela
Reviewed-by: Daniel P. Berrangé Signed-off-by: Juan Quintela --- include/io/channel-socket.h| 2 ++ io/channel-socket.c| 7 --- io/net-listener.c | 2 +- io/trace-events| 2 +- scsi/qemu-pr-helper.c | 3 ++- tests/test-char.c

[Qemu-devel] [PULL 5/5] multifd: Use number of channels as listen backlog

2019-09-04 Thread Juan Quintela
Reviewed-by: Daniel P. Berrangé Signed-off-by: Juan Quintela --- migration/socket.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/migration/socket.c b/migration/socket.c index e63f5e1612..97c9efde59 100644 --- a/migration/socket.c +++ b/migration/socket.c @@ -178,10

Re: [Qemu-devel] [PATCH 0/7] target/sparc: Convert to do_transaction_failed hook

2019-09-04 Thread Peter Maydell
On Tue, 3 Sep 2019 at 18:00, Mark Cave-Ayland wrote: > > On 03/09/2019 14:15, Peter Maydell wrote: > > > Mark -- ping? Richard has reviewed this series; do you want > > more time to test it, or should I just apply it to master > > if you don't have any other pending sparc patches? > > Yes, sorry

Re: [Qemu-devel] [PATCH 00/36] tcg patch queue

2019-09-04 Thread Peter Maydell
On Tue, 3 Sep 2019 at 18:00, Mark Cave-Ayland wrote: > > On 03/09/2019 17:08, Richard Henderson wrote: > > > The following changes since commit fec105c2abda8567ec15230429c41429b5ee307c: > > > > Merge remote-tracking branch > > 'remotes/kraxel/tags/audio-20190828-pull-request' into staging

Re: [Qemu-devel] [PATCH v8 01/13] vfio: KABI for migration interface

2019-09-04 Thread Yan Zhao
On Tue, Sep 03, 2019 at 02:05:46PM +0800, Tian, Kevin wrote: > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Saturday, August 31, 2019 12:15 AM > > > > On Fri, 30 Aug 2019 07:25:59 + > > "Tian, Kevin" wrote: > > > > > > From: Alex Williamson

[Qemu-devel] [PATCH-for-4.2 v10 06/11] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT

2019-09-04 Thread Shameer Kolothum
Generate Memory Affinity Structures for PC-DIMM ranges. Also, Linux and Windows need ACPI SRAT table to make memory hotplug work properly, however currently QEMU doesn't create SRAT table if numa options aren't present on CLI. Hence add support(>=4.2) to create numa node automatically

[Qemu-devel] [PATCH v8 4/6] iotests: Valgrind fails with nonexistent directory

2019-09-04 Thread Andrey Shinkevich
The Valgrind uses the exported variable TMPDIR and fails if the directory does not exist. Let us exclude such a test case from being run under the Valgrind and notify the user of it. Suggested-by: Kevin Wolf Signed-off-by: Andrey Shinkevich Reviewed-by: John Snow --- tests/qemu-iotests/051 |

Re: [Qemu-devel] [PATCH v8 0/3] rng-builtin: add an RNG backend that uses qemu_guest_getrandom()

2019-09-04 Thread Michael S. Tsirkin
On Tue, Aug 20, 2019 at 06:06:12PM +0200, Laurent Vivier wrote: > Add a new RNG backend using QEMU builtin getrandom function. > > v8: rebase on v4.1 > > v7: rebase on master > Make rng-builtin asynchronous with QEMUBH (removed existing R-b) > > v6: remove "sysemu/rng-random.h" from

[Qemu-devel] [PATCH 08/10] aspeed/smc: Calculate checksum on normal DMA

2019-09-04 Thread Cédric Le Goater
From: Christian Svensson This patch adds the missing checksum calculation on normal DMA transfer. According to the datasheet this is how the SMC should behave. Verified on AST1250 that the hardware matches the behaviour. Signed-off-by: Christian Svensson Reviewed-by: Joel Stanley

Re: [Qemu-devel] [PATCH] libvhost-user: introduce and use vu_has_protocol_feature()

2019-09-04 Thread Tiwei Bie
On Wed, Sep 04, 2019 at 09:50:21AM +0300, Johannes Berg wrote: > From: Johannes Berg > > This simplifies the various has_feature() checks, we already > have vu_has_feature() but it checks features, not protocol > features. > > Signed-off-by: Johannes Berg > --- >

Re: [Qemu-devel] [PATCH-for-4.2 v10 01/11] hw/acpi: Make ACPI IO address space configurable

2019-09-04 Thread Igor Mammedov
On Wed, 4 Sep 2019 09:56:19 +0100 Shameer Kolothum wrote: > This is in preparation for adding support for ARM64 platforms > where it doesn't use port mapped IO for ACPI IO space. We are > making changes so that MMIO region can be accommodated > and board can pass the base address into the aml

Re: [Qemu-devel] [PULL 00/12] fixes for gdbstub, gitdm and testing

2019-09-04 Thread Peter Maydell
On Mon, 2 Sep 2019 at 11:21, Alex Bennée wrote: > > The following changes since commit 23919ddfd56135cad3cb468a8f54d5a595f024f4: > > Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190827' into > staging (2019-08-27 15:52:36 +0100) > > are available in the Git repository at: > >

[Qemu-devel] [PATCH 05/10] aspeed/smc: Add support for DMAs

2019-09-04 Thread Cédric Le Goater
The FMC controller on the Aspeed SoCs support DMA to access the flash modules. It can operate in a normal mode, to copy to or from the flash module mapping window, or in a checksum calculation mode, to evaluate the best clock settings for reads. The model introduces two custom address spaces for

Re: [Qemu-devel] [RFC v3 PATCH 40/45] multi-process/mon: Refactor monitor/chardev functions out of vl.c

2019-09-04 Thread Dr. David Alan Gilbert
* Jagannathan Raman (jag.ra...@oracle.com) wrote: > Some of the initialization helper functions w.r.t monitor & chardev > in vl.c are also used by the remote process. Therefore, these functions > are refactored into a shared file that both QEMU & remote process > could use. > > Signed-off-by:

[Qemu-devel] [PATCH-for-4.2 v10 03/11] hw/acpi: Add ACPI Generic Event Device Support

2019-09-04 Thread Shameer Kolothum
From: Samuel Ortiz The ACPI Generic Event Device (GED) is a hardware-reduced specific device[ACPI v6.1 Section 5.6.9] that handles all platform events, including the hotplug ones. This patch generates the AML code that defines GEDs. Platforms need to specify their own GED Event bitmap to

[Qemu-devel] [PATCH-for-4.2 v10 01/11] hw/acpi: Make ACPI IO address space configurable

2019-09-04 Thread Shameer Kolothum
This is in preparation for adding support for ARM64 platforms where it doesn't use port mapped IO for ACPI IO space. We are making changes so that MMIO region can be accommodated and board can pass the base address into the aml build function. Also move few MEMORY_* definitions to header so that

[Qemu-devel] [PATCH v8 1/6] iotests: allow Valgrind checking all QEMU processes

2019-09-04 Thread Andrey Shinkevich
With the '-valgrind' option, let all the QEMU processes be run under the Valgrind tool. The Valgrind own parameters may be set with its environment variable VALGRIND_OPTS, e.g. $ VALGRIND_OPTS="--leak-check=yes" ./check -valgrind or they may be listed in the Valgrind checked file ./.valgrindrc or

Re: [Qemu-devel] [PATCH v2] libvhost-user: fix SLAVE_SEND_FD handling

2019-09-04 Thread Tiwei Bie
On Wed, Sep 04, 2019 at 10:06:55AM +0800, Tiwei Bie wrote: > On Tue, Sep 03, 2019 at 11:04:22PM +0300, Johannes Berg wrote: > > From: Johannes Berg > > > > It doesn't look like this could possibly work properly since > > VHOST_USER_PROTOCOL_F_SLAVE_SEND_FD is defined to 10, but the > >

[Qemu-devel] [PATCH v8 5/6] iotests: extended timeout under Valgrind

2019-09-04 Thread Andrey Shinkevich
As the iotests run longer under the Valgrind, the QEMU_COMM_TIMEOUT is to be increased in the test cases 028, 183 and 192 when running under the Valgrind. Suggested-by: Roman Kagan Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow ---

Re: [Qemu-devel] [PATCH] block/nfs: add support for nfs_umount

2019-09-04 Thread Kevin Wolf
Am 03.09.2019 um 21:52 hat Peter Lieven geschrieben: > > > > Am 03.09.2019 um 16:56 schrieb Kevin Wolf : > > > > Am 03.09.2019 um 15:44 hat Peter Lieven geschrieben: > >> libnfs recently added support for unmounting. Add support > >> in Qemu too. > >> > >> Signed-off-by: Peter Lieven > > > >

[Qemu-devel] [PATCH 10/10] aspeed/scu: Introduce a aspeed_scu_get_apb_freq() routine

2019-09-04 Thread Cédric Le Goater
The APB frequency can be calculated directly when needed from the HPLL_PARAM and CLK_SEL register values. This removes useless state in the model. Signed-off-by: Cédric Le Goater --- include/hw/misc/aspeed_scu.h | 8 +++- hw/misc/aspeed_scu.c | 25 +

Re: [Qemu-devel] [PATCH for-4.2 v10 08/15] virtio-iommu: Implement map/unmap

2019-09-04 Thread Auger Eric
Hi, On 9/4/19 7:46 AM, Tian, Kevin wrote: >> From: Peter Xu [mailto:pet...@redhat.com] >> Sent: Wednesday, September 4, 2019 1:37 PM >> >> On Wed, Sep 04, 2019 at 04:23:50AM +, Tian, Kevin wrote: From: Peter Xu [mailto:pet...@redhat.com] Sent: Wednesday, September 4, 2019 9:44 AM

[Qemu-devel] [PATCH-for-4.2 v10 08/11] hw/arm: Use GED for system_powerdown event

2019-09-04 Thread Shameer Kolothum
For machines 4.2 or higher with ACPI boot use GED for system_powerdown event instead of GPIO. Guest boot with DT still uses GPIO. Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger --- v9 --> v10 -Eric's R-by v8 --> v9 -Re-arranged patches 8 & 9 from v8 based on Igor's comments. v7 -->

[Qemu-devel] [PATCH-for-4.2 v10 02/11] hw/acpi: Do not create memory hotplug method when handler is not defined

2019-09-04 Thread Shameer Kolothum
From: Samuel Ortiz With Hardware-reduced ACPI, the GED device will manage ACPI hotplug entirely. As a consequence, make the memory specific events AML generation optional. The code will only be added when the method name is not NULL. Signed-off-by: Samuel Ortiz Signed-off-by: Shameer Kolothum

Re: [Qemu-devel] [RFC v3 PATCH 00/45] Initial support of multi-process qemu

2019-09-04 Thread Daniel P . Berrangé
On Tue, Sep 03, 2019 at 04:37:26PM -0400, Jagannathan Raman wrote: > Started with the presentation in October 2017 made by Marc-Andre (Red Hat) > and Konrad Wilk (Oracle) [1], and continued by Jag's BoF at KVM Forum 2018, > the multi-process project is now a prototype and presented in this

[Qemu-devel] [PATCH v8 2/6] iotests: exclude killed processes from running under Valgrind

2019-09-04 Thread Andrey Shinkevich
The Valgrind tool fails to manage its termination in multi-threaded processes when they raise the signal SIGKILL. The bug has been reported to the Valgrind maintainers and was registered as the bug #409141: https://bugs.kde.org/show_bug.cgi?id=409141 Let's exclude such test cases from running

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-09-04 Thread Igor Mammedov
On Tue, 3 Sep 2019 19:20:25 +0200 Laszlo Ersek wrote: > On 09/03/19 16:53, Igor Mammedov wrote: > > On Mon, 2 Sep 2019 21:09:58 +0200 > > Laszlo Ersek wrote: > > > >> On 09/02/19 10:45, Igor Mammedov wrote: > >>> On Fri, 30 Aug 2019 20:46:14 +0200 > >>> Laszlo Ersek wrote: > >>> >

Re: [Qemu-devel] [PATCH v5 00/17] target/arm: Reduce overhead of cpu_get_tb_cpu_state

2019-09-04 Thread Peter Maydell
On Wed, 21 Aug 2019 at 00:54, Richard Henderson wrote: > However, while working on this patch set, I noticed that we have a lot of > unnecessary overlap between A- and M- profile in the TBFLAGs. Thus point 4 > above and the completely separate rebuild_hflags_m32(). > > If we rearrange things

[Qemu-devel] [PATCH 04/10] aspeed: Use consistent typenames

2019-09-04 Thread Cédric Le Goater
Improve the naming of the different controller models to ease their generation when initializing the SoC. The rename of the SMC types is breaking migration compatibility. Signed-off-by: Cédric Le Goater --- include/hw/arm/aspeed_soc.h | 3 --- hw/arm/aspeed_soc.c | 25

[Qemu-devel] [PATCH 07/10] aspeed/smc: Inject errors in DMA checksum

2019-09-04 Thread Cédric Le Goater
Emulate read errors in the DMA Checksum Register for high frequencies and optimistic settings of the Read Timing Compensation Register. This will help in tuning the SPI timing calibration algorithm. Errors are only injected when the property "inject_failure" is set to true as suggested by

[Qemu-devel] [PATCH-for-4.2 v10 09/11] docs/specs: Add ACPI GED documentation

2019-09-04 Thread Shameer Kolothum
Documents basic concepts of ACPI Generic Event device(GED) and interface between QEMU and the ACPI BIOS. Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger --- docs/specs/acpi_hw_reduced_hotplug.txt | 60 ++ 1 file changed, 60 insertions(+) create mode 100644

[Qemu-devel] [PATCH-for-4.2 v10 10/11] tests: add dummy ACPI tables for arm/virt board

2019-09-04 Thread Shameer Kolothum
This patch is in preparation for adding numamem and memhp tests to arm/virt board so that 'make check' is happy. This may not be required once the scripts are run and new tables are generated with ".numamem" and ".memhp" extensions. Signed-off-by: Shameer Kolothum --- I am not sure this is the

Re: [Qemu-devel] [PULL 0/3] Usb 20190829 patches

2019-09-04 Thread Peter Maydell
On Thu, 29 Aug 2019 at 08:12, Gerd Hoffmann wrote: > > The following changes since commit 23919ddfd56135cad3cb468a8f54d5a595f024f4: > > Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190827' into > staging (2019-08-27 15:52:36 +0100) > > are available in the Git repository at: >

Re: [Qemu-devel] [PULL 00/31] MIPS queue for August 29th, 2019

2019-09-04 Thread Peter Maydell
On Thu, 29 Aug 2019 at 11:25, Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > The following changes since commit 1b142da5f82a8fcdc7783a418592de654d5c6052: > > target/mips: Clean up handling of CP0 register 0 (2019-08-29 11:50:18 +0200) > > are available in the git repository at: >

[Qemu-devel] [PATCH v2 1/5] target/arm: handle M-profile semihosting at translate time

2019-09-04 Thread Alex Bennée
We do this for other semihosting calls so we might as well do it for M-profile as well. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - update for change to gen_exception_internal_insn API --- target/arm/m_helper.c | 18 ++ target/arm/translate.c | 20

[Qemu-devel] [PATCH v2 0/5] fixed up semihosting fixups

2019-09-04 Thread Alex Bennée
Hi Peter, Here is version 2 of the ARM semi-hosting cleanup patches. The re-base had failed due to a change in the gen_exception_internal_insn API which now takes the PC instead of offset from pc_next. There is also the a minor indentation fix. Alex Bennée (4): target/arm: handle M-profile

[Qemu-devel] [PATCH 00/10] Aspeed: machine extensions and fixes

2019-09-04 Thread Cédric Le Goater
Hello, This series improves the current models of the Aspeed machines in QEMU and adds new ones. It also prepares ground for the models of the Aspeed AST2600 SoC by calculating the model typenames using the SoC name. You will find patches for : - DMA support for the SMC controller, now using

[Qemu-devel] [PATCH 02/10] aspeed: add a GPIO controller to the SoC

2019-09-04 Thread Cédric Le Goater
From: Rashmica Gupta Signed-off-by: Rashmica Gupta Reviewed-by: Cédric Le Goater Signed-off-by: Cédric Le Goater --- include/hw/arm/aspeed_soc.h | 3 +++ hw/arm/aspeed_soc.c | 17 + 2 files changed, 20 insertions(+) diff --git a/include/hw/arm/aspeed_soc.h

[Qemu-devel] [PATCH 01/10] hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500

2019-09-04 Thread Cédric Le Goater
From: Rashmica Gupta GPIO pins are arranged in groups of 8 pins labeled A,B,..,Y,Z,AA,AB,AC. (Note that the ast2400 controller only goes up to group AB). A set has four groups (except set AC which only has one) and is referred to by the groups it is composed of (eg ABCD,EFGH,...,YZAAAB). Each

Re: [Qemu-devel] [PATCH] qmp: Fix memory leak in migrate_params_test_apply

2019-09-04 Thread fangying
On 2019/9/4 0:46, Dr. David Alan Gilbert wrote: * Ying Fang (fangyi...@huawei.com) wrote: Address Sanitizer shows memory leak in migrate_params_test_apply migration/migration.c:1253 and the stack is as bellow: Direct leak of 45 byte(s) in 9 object(s) allocated from: #0 0xbd7fc1db

Re: [Qemu-devel] [Qemu-block] [PATCH] docs: Update preferred NBD device syntax

2019-09-04 Thread Daniel P . Berrangé
On Tue, Sep 03, 2019 at 03:06:24PM -0400, John Snow wrote: > > > On 9/3/19 3:02 PM, Eric Blake wrote: > > [adding libvirt list] > > > > On 9/3/19 1:50 PM, John Snow wrote: > >> > >> > >> On 9/3/19 10:56 AM, Eric Blake wrote: > >>> Mention the preferred URI form, especially since NBD is trying

Re: [Qemu-devel] [PULL 00/19] ppc-for-4.2 queue 20190829

2019-09-04 Thread Peter Maydell
On Thu, 29 Aug 2019 at 07:08, David Gibson wrote: > > The following changes since commit 23919ddfd56135cad3cb468a8f54d5a595f024f4: > > Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190827' into > staging (2019-08-27 15:52:36 +0100) > > are available in the Git repository at: >

[Qemu-devel] [PATCH-for-4.2 v10 07/11] hw/arm: Factor out powerdown notifier from GPIO

2019-09-04 Thread Shameer Kolothum
This is in preparation of using GED device for system_powerdown event. Make the powerdown notifier registration independent of create_gpio() fn. Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger --- hw/arm/virt.c | 12 include/hw/arm/virt.h | 1 + 2 files changed, 5

Re: [Qemu-devel] [RFC v3 PATCH 41/45] multi-process/mon: trim HMP command set for remote storage processes

2019-09-04 Thread Dr. David Alan Gilbert
* Jagannathan Raman (jag.ra...@oracle.com) wrote: > Trim down the list of HMP commands available for storage class of > remote processes. > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > New patch in v3 > > Makefile.objs

[Qemu-devel] [PATCH-for-4.2 v10 00/11] ARM virt: ACPI memory hotplug support

2019-09-04 Thread Shameer Kolothum
This series is an attempt to provide device memory hotplug support on ARM virt platform. This is based on Eric's recent works here[1] and carries some of the pc-dimm related patches dropped from his series. The kernel support for arm64 memory hot add was added recently by Robin and hence the

[Qemu-devel] [PATCH-for-4.2 v10 04/11] hw/arm/virt: Add memory hotplug framework

2019-09-04 Thread Shameer Kolothum
From: Eric Auger This patch adds the memory hot-plug/hot-unplug infrastructure in machvirt. The device memory is not yet exposed to the Guest either through DT or ACPI and hence both cold/hot plug of memory is explicitly disabled for now. Signed-off-by: Eric Auger Signed-off-by: Kwangwoo Lee

Re: [Qemu-devel] [RFC v3 PATCH 02/45] multi-process: util: Add qemu_thread_cancel() to cancel running thread

2019-09-04 Thread Daniel P . Berrangé
On Tue, Sep 03, 2019 at 04:37:28PM -0400, Jagannathan Raman wrote: > qemu_thread_cancel() added to destroy a given running thread. > This will be needed in the following patches. I don't see anything in the following patches that actually uses this new function. That is good though, because it

[Qemu-devel] [PATCH v2 5/5] atomic_template: fix indentation in GEN_ATOMIC_HELPER

2019-09-04 Thread Alex Bennée
From: "Emilio G. Cota" Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- accel/tcg/atomic_template.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/atomic_template.h

[Qemu-devel] [PATCH 06/10] aspeed/smc: Add DMA calibration settings

2019-09-04 Thread Cédric Le Goater
When doing calibration, the SPI clock rate in the CE0 Control Register and the read delay cycles in the Read Timing Compensation Register are set using bit[11:4] of the DMA Control Register. Signed-off-by: Cédric Le Goater Acked-by: Joel Stanley Reviewed-by: Peter Maydell ---

[Qemu-devel] [PATCH 09/10] aspeed/scu: Introduce per-SoC SCU types

2019-09-04 Thread Cédric Le Goater
and use a class AspeedSCUClass to define each SoC characteristics. Signed-off-by: Cédric Le Goater --- include/hw/misc/aspeed_scu.h | 15 +++ hw/arm/aspeed_soc.c | 3 +- hw/misc/aspeed_scu.c | 83 3 files changed, 64 insertions(+), 37

Re: [Qemu-devel] [RFC v3 PATCH 01/45] multi-process: memory: alloc RAM from file at offset

2019-09-04 Thread Dr. David Alan Gilbert
* Jagannathan Raman (jag.ra...@oracle.com) wrote: > Allow RAM MemoryRegion to be created from an offset in a file, instead > of allocating at offset of 0 by default. This is needed to synchronize > RAM between QEMU & remote process. > This will be needed for the following patches. > >

Re: [Qemu-devel] [RFC v3 PATCH 07/45] multi-process: define proxy-link object

2019-09-04 Thread Daniel P . Berrangé
On Tue, Sep 03, 2019 at 04:37:33PM -0400, Jagannathan Raman wrote: > Defines proxy-link object which forms the communication link between > QEMU & emulation program. > Adds functions to configure members of proxy-link object instance. > Adds functions to send and receive messages over the

Re: [Qemu-devel] [PATCH] HACK: Centralize sve property checks

2019-09-04 Thread Andrew Jones
On Fri, Aug 09, 2019 at 06:31:12PM -0700, Richard Henderson wrote: > As promised, an experiment in unifying the checks. > > I believe that I've tested for all of the same conditions, modulo the > timing at which they are emitted. As before, only one error is reported, > so if multiple errors

[Qemu-devel] [PATCH v8 6/6] iotests: extend sleeping time under Valgrind

2019-09-04 Thread Andrey Shinkevich
To synchronize the time when QEMU is running longer under the Valgrind, increase the sleeping time in the test 247. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- tests/qemu-iotests/247 | 6 +- 1 file changed, 5 insertions(+), 1

[Qemu-devel] [PATCH v8 0/6] Allow Valgrind checking all QEMU processes

2019-09-04 Thread Andrey Shinkevich
In the current implementation of the QEMU bash iotests, only qemu-io processes may be run under the Valgrind with the switch '-valgrind'. Let's allow the common.rc bash script running all other QEMU processes, such as qemu-kvm, qemu-img, qemu-ndb and qemu-vxhs, under the Valgrind. v8: 01: Fix

[Qemu-devel] [PATCH v8 3/6] iotests: Add casenotrun report to bash tests

2019-09-04 Thread Andrey Shinkevich
The new function _casenotrun() is to be invoked if a test case cannot be run for some reason. The user will be notified by a message passed to the function. It is the caller's responsibility to make skipped a particular test. Suggested-by: Kevin Wolf Signed-off-by: Andrey Shinkevich

[Qemu-devel] [PATCH-for-4.2 v10 11/11] tests: Add bios tests to arm/virt

2019-09-04 Thread Shameer Kolothum
This adds numamem and memhp tests for arm/virt platform Signed-off-by: Shameer Kolothum --- tests/bios-tables-test-allowed-diff.h | 1 + tests/bios-tables-test.c | 49 +++ 2 files changed, 50 insertions(+) diff --git a/tests/bios-tables-test-allowed-diff.h

[Qemu-devel] [PATCH v2 3/5] target/arm: handle A-profile A32 semihosting at translate time

2019-09-04 Thread Alex Bennée
As for the other semihosting calls we can resolve this at translate time. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - update for change to gen_exception_internal_insn API --- target/arm/translate.c | 20 +--- 1 file changed, 17 insertions(+), 3

[Qemu-devel] [PATCH v2 2/5] target/arm: handle A-profile T32 semihosting at translate time

2019-09-04 Thread Alex Bennée
As for the other semihosting calls we can resolve this at translate time. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - update for change to gen_exception_internal_insn API --- target/arm/translate.c | 24 1 file changed, 20 insertions(+), 4

[Qemu-devel] [PATCH] libvhost-user: introduce and use vu_has_protocol_feature()

2019-09-04 Thread Johannes Berg
From: Johannes Berg This simplifies the various has_feature() checks, we already have vu_has_feature() but it checks features, not protocol features. Signed-off-by: Johannes Berg --- contrib/libvhost-user/libvhost-user.c | 20 ++-- 1 file changed, 10 insertions(+), 10

[Qemu-devel] [PATCH 03/10] aspeed: Remove unused SoC definitions

2019-09-04 Thread Cédric Le Goater
There are no QEMU Aspeed machines using the SoCs "ast2400-a0" or "ast2400". Signed-off-by: Cédric Le Goater --- hw/arm/aspeed_soc.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c index 04480875d0d8..3aa73d2438ef 100644

Re: [Qemu-devel] DMARC/DKIM and qemu-devel list settings

2019-09-04 Thread Daniel P . Berrangé
On Tue, Sep 03, 2019 at 03:11:08PM -0400, Ian Kelling wrote: > At FSF, we've been working on this issue recently. I was planning to > send a general message to qemu-devel, but someone brought it up in a > thread below, so I'm doing it now. > > Currently, a message sent to qemu-devel from a domain

Re: [Qemu-devel] [PATCH for-4.2 v10 08/15] virtio-iommu: Implement map/unmap

2019-09-04 Thread Peter Xu
On Wed, Sep 04, 2019 at 09:54:12AM +0200, Auger Eric wrote: > Hi, > > On 9/4/19 7:46 AM, Tian, Kevin wrote: > >> From: Peter Xu [mailto:pet...@redhat.com] > >> Sent: Wednesday, September 4, 2019 1:37 PM > >> > >> On Wed, Sep 04, 2019 at 04:23:50AM +, Tian, Kevin wrote: > From: Peter Xu

[Qemu-devel] [PATCH-for-4.2 v10 05/11] hw/arm/virt: Enable device memory cold/hot plug with ACPI boot

2019-09-04 Thread Shameer Kolothum
This initializes the GED device with base memory and irq, configures ged memory hotplug event and builds the corresponding aml code. With this, both hot and cold plug of device memory is enabled now for Guest with ACPI boot. Memory cold plug support with Guest DT boot is not yet supported. As

Re: [Qemu-devel] [PATCH] tests: make filemonitor test more robust to event ordering

2019-09-04 Thread Thomas Huth
On 21/08/2019 17.53, Daniel P. Berrangé wrote: > The ordering of events that are emitted during the rmdir > test have changed with kernel >= 5.3. Semantically both > new & old orderings are correct, so we must be able to > cope with either. > > To cope with this, when we see an unexpected event,

Re: [Qemu-devel] [PATCH 00/10] travis: Use caching when possible

2019-09-04 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > This series tries to reduce Travis CI failures due to network > issues, and tries to speed builds a bit, reducing failures due > to job timeouting. Looking good. Queued to testing/next, thanks. > > Travis feature: https://docs.travis-ci.com/user/caching/ > >

[Qemu-devel] [PATCH v2 4/5] target/arm: remove run time semihosting checks

2019-09-04 Thread Alex Bennée
Now we do all our checking and use a common EXCP_SEMIHOST for semihosting operations we can make helper code a lot simpler. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - fix re-base conflicts - hoist EXCP_SEMIHOST check - comment cleanups v5 - move CONFIG_TCG ifdefs

Re: [Qemu-devel] [PATCH 2/4] virtiofsd: add --print-capabilities option

2019-09-04 Thread Stefan Hajnoczi
On Tue, Sep 03, 2019 at 06:26:44PM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > Add the --print-capabilities option as per vhost-user.rst "Backend > > programs conventions". Currently there are no advertised features. > > > > Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH 00/36] tcg patch queue

2019-09-04 Thread Peter Maydell
On Tue, 3 Sep 2019 at 17:09, Richard Henderson wrote: > > The following changes since commit fec105c2abda8567ec15230429c41429b5ee307c: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20190828-pull-request' into staging (2019-09-03 > 14:03:15 +0100) > > are available in the Git

[Qemu-devel] [PATCH 06/14] hw/arm/bcm2835: Rename some definitions

2019-09-04 Thread Philippe Mathieu-Daudé
The UART1 is part of the AUX peripheral, the PCM_CLOCK (yet unimplemented) is part of the CPRMAN. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/bcm2835_peripherals.c| 4 ++-- include/hw/arm/raspi_platform.h | 8 2 files changed, 6 insertions(+), 6

[Qemu-devel] [RFC PATCH 03/14] hw/misc/bcm2835_property: Handle the 'domain state' property

2019-09-04 Thread Philippe Mathieu-Daudé
The kernel is happy with this change, so we don't need to do anything more sophisticated. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/bcm2835_property.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/misc/bcm2835_property.c

[Qemu-devel] [RFC PATCH 12/14] hw/arm/bcm2836: Add the BCM2838 which uses a GICv2

2019-09-04 Thread Philippe Mathieu-Daudé
The BCM2838 is improvement of the BCM2837: - Cortex-A72 instead of the A53 - peripheral block and local soc controller are mapped differently, - GICv2 - PCIe block - exhanced MMU to address over 4GiB of SDRAM See https://www.raspberrypi.org/forums/viewtopic.php?t=244479=25 and

Re: [Qemu-devel] [PATCH v2 5/6] tests/libqtest: Move global_test wrapper function into a separate header

2019-09-04 Thread Stefan Hajnoczi
On Wed, Sep 04, 2019 at 03:00:46PM +0200, Thomas Huth wrote: > diff --git a/tests/libqtest-single.h b/tests/libqtest-single.h > new file mode 100644 > index 00..49259558a5 > --- /dev/null > +++ b/tests/libqtest-single.h > @@ -0,0 +1,311 @@ > +/* > + * QTest - wrappers for test with single

[Qemu-devel] [PATCH v6 0/9] Clock framework API

2019-09-04 Thread Damien Hedde
This series aims to add a way to model clock distribution in qemu. This allows to model the clock tree of a platform allowing us to inspect clock configuration and detect problems such as disabled clock or bad configured pll. The added clock api is very similar the the gpio api for devices. We

[Qemu-devel] [PATCH v6 8/9] hw/char/cadence_uart: add clock support

2019-09-04 Thread damien . hedde
From: Damien Hedde Switch the cadence uart to multi-phase reset and add the reference clock input. The input clock frequency is added to the migration structure. The reference clock controls the baudrate generation. If it disabled, any input characters and events are ignored. If this clock

[Qemu-devel] [PATCH v6 4/9] qdev-monitor: print the device's clock with info qtree

2019-09-04 Thread Damien Hedde
This prints the clocks attached to a DeviceState when using "info qtree" monitor command. For every clock, it displays the direction, the name and if the clock is forwarded. For input clock, it displays also the frequency. This is based on the original work of Frederic Konrad. Signed-off-by:

[Qemu-devel] [PATCH v6 7/9] hw/misc/zynq_slcr: add clock generation for uarts

2019-09-04 Thread damien . hedde
From: Damien Hedde Switch the slcr to multi-phase reset and add some clocks: + the main input clock (ps_clk) + the reference clock outputs for each uart (uart0 & 1) The clock frequencies are computed using the internal pll & uart configuration registers and the ps_clk frequency. Signed-off-by:

[Qemu-devel] [PATCH v6 1/9] hw/core/clock: introduce clock objects

2019-09-04 Thread Damien Hedde
Introduce clock objects: ClockIn and ClockOut. These objects may be used to distribute clocks from an object to several other objects. Each ClockIn object contains the current state of the clock: the frequency; it allows an object to migrate its input clock state independently of other objects.

[Qemu-devel] [PATCH v6 8/9] hw/char/cadence_uart: add clock support

2019-09-04 Thread Damien Hedde
Switch the cadence uart to multi-phase reset and add the reference clock input. The input clock frequency is added to the migration structure. The reference clock controls the baudrate generation. If it disabled, any input characters and events are ignored. If this clock remains unconnected,

[Qemu-devel] [PATCH v6 6/9] docs/clocks: add device's clock documentation

2019-09-04 Thread Damien Hedde
Add the documentation about the clock inputs and outputs in devices. This is based on the original work of Frederic Konrad. Signed-off-by: Damien Hedde --- docs/devel/clock.txt | 246 +++ 1 file changed, 246 insertions(+) create mode 100644

[Qemu-devel] [PATCH v6 4/8] linux user: Add support for FDFLUSH ioctl

2019-09-04 Thread Aleksandar Markovic
From: Yunqiang Su FDFLUSH is used for flushing buffers of floppy drives. Support in QEMU is needed because some of Debian packages use this ioctl while running post-build tests. One such example is 'tar' package. Signed-off-by: Yunqiang Su Signed-off-by: Aleksandar Markovic Reviewed-by:

Re: [Qemu-devel] [PATCH v2 0/3] tests/tcg: disentangle makefiles

2019-09-04 Thread Paolo Bonzini
Ping? Paolo Il mer 7 ago 2019, 16:35 Paolo Bonzini ha scritto: > The tests/tcg rely a lot on per-target informations from > the QEMU makefiles, but most of the definitions in there > aren't really relevant to TCG tests. > > This series is just a cleanup, but it could also be > a useful start

[Qemu-devel] [PATCH v2 1/6] tests/migration: Do not use functions anymore that rely on global_qtest

2019-09-04 Thread Thomas Huth
The migration tests deal with multiple test states, so we really should not use functions here that rely on the single global_qtest variable. Switch from qtest_start() to qtest_init() to make sure that global_qtest is not set anymore. This also revealed a regression in the migrate() function: It

Re: [Qemu-devel] [PULL 00/21] target-arm queue

2019-09-04 Thread Peter Maydell
On Tue, 3 Sep 2019 at 16:36, Peter Maydell wrote: > > target-arm queue: this time around is all small fixes > and changes. > > thanks > -- PMM > > The following changes since commit fec105c2abda8567ec15230429c41429b5ee307c: > > Merge remote-tracking branch >

Re: [Qemu-devel] [PATCH v8 0/6] Allow Valgrind checking all QEMU processes

2019-09-04 Thread Kevin Wolf
Am 04.09.2019 um 11:11 hat Andrey Shinkevich geschrieben: > In the current implementation of the QEMU bash iotests, only qemu-io > processes may be run under the Valgrind with the switch '-valgrind'. > Let's allow the common.rc bash script running all other QEMU processes, > such as qemu-kvm,

Re: [Qemu-devel] [PATCH v3 4/5] socket: Add num connections to qio_net_listener_open_sync()

2019-09-04 Thread Daniel P . Berrangé
On Wed, Sep 04, 2019 at 03:19:21PM +0200, Juan Quintela wrote: > Eric Blake wrote: > > On 8/20/19 5:48 AM, Juan Quintela wrote: > >> Reviewed-by: Daniel P. Berrangé > >> Signed-off-by: Juan Quintela > >> --- > >> blockdev-nbd.c| 2 +- > >> chardev/char-socket.c | 2 +- > >>

Re: [Qemu-devel] [PATCH v2 3/6] tests/libqos: Replace clock_step with qtest_clock_step in virtio code

2019-09-04 Thread Eric Blake
On 9/4/19 8:00 AM, Thomas Huth wrote: > Library functions should not rely on functions that require global_qtest > (since they might get used in tests that deal with multiple states). > Commit 1999a70a05ad603d ("Make generic virtio code independent from > global_qtest") already tried to clean the

Re: [Qemu-devel] [PATCH v2 4/6] tests: Remove unnecessary global_qtest references

2019-09-04 Thread Eric Blake
On 9/4/19 8:00 AM, Thomas Huth wrote: > We are going to remove global_qtest from the main libqtest library > soon, so tests that do not urgently need global_qtest anymore > should be cleaned from the unnecessary references. > > Signed-off-by: Thomas Huth > --- > tests/ahci-test.c| 1 - >

Re: [Qemu-devel] [PATCH for-4.2 v10 14/15] virtio-iommu-pci: Add virtio iommu pci support

2019-09-04 Thread Auger Eric
Hi Michael, On 9/1/19 8:40 AM, Michael S. Tsirkin wrote: > On Thu, Aug 01, 2019 at 03:49:37PM +0200, Auger Eric wrote: >> Hi Michael, >> >> On 8/1/19 3:06 PM, Michael S. Tsirkin wrote: >>> On Thu, Aug 01, 2019 at 02:15:03PM +0200, Auger Eric wrote: Hi Michael, On 7/30/19 9:35 PM,

Re: [Qemu-devel] DMARC/DKIM and qemu-devel list settings

2019-09-04 Thread Ian Kelling
Daniel P. Berrangé writes: > > I think we should change mailman settings to *NOT* convert HTML to > plain text. It is pretty easy to setup mail clients to do this > conversion when viewing instead, which will avoid the DMARC problems. > > eg with mutt you can add > > auto_view text/html >

Re: [Qemu-devel] [PATCH v5 3/3] qcow2: add zstd cluster compression

2019-09-04 Thread Eric Blake
On 9/4/19 10:29 AM, Denis Plotnikov wrote: > zstd significantly reduces cluster compression time. > It provides better compression performance maintaining > the same level of compression ratio in comparison with > zlib, which, at the moment, has been the only compression > method available. > >

Re: [Qemu-devel] [RFC v3 PATCH 00/45] Initial support of multi-process qemu

2019-09-04 Thread Jag Raman
On 9/4/2019 5:18 AM, Daniel P. Berrangé wrote: On Tue, Sep 03, 2019 at 04:37:26PM -0400, Jagannathan Raman wrote: Started with the presentation in October 2017 made by Marc-Andre (Red Hat) and Konrad Wilk (Oracle) [1], and continued by Jag's BoF at KVM Forum 2018, the multi-process project

Re: [Qemu-devel] [PATCH v7 26/30] riscv: sifive: Implement a model for SiFive FU540 OTP

2019-09-04 Thread Alistair Francis
On Sat, Aug 31, 2019 at 8:15 PM Bin Meng wrote: > > This implements a simple model for SiFive FU540 OTP (One-Time > Programmable) Memory interface, primarily for reading out the > stored serial number from the first 1 KiB of the 16 KiB OTP > memory reserved by SiFive for internal use. > >

  1   2   3   4   >