Re: [Qemu-devel] [PATCH v6 00/16] tcg/ppc: Add vector opcodes

2019-09-05 Thread Aleksandar Markovic
ping for Richard 03.09.2019. 20.34, "Mark Cave-Ayland" је написао/ла: > > On 03/09/2019 18:37, Aleksandar Markovic wrote: > > > On Tue, Sep 3, 2019 at 7:05 PM Mark Cave-Ayland < > > mark.cave-ayl...@ilande.co.uk> wrote: > > > >> On 01/07/2019 19:34, Howard Spoelstra wrote: > >> > >>> On Mon, Jul

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

2019-09-05 Thread Libo Zhou
Do you know where in the source file I should look into to add my custom logging functionality? Or, would you suggest using gdb to look at my target register and memory contents? The answer in this link below looks really promising. I'm gonna give it a try first.

[Qemu-devel] [PULL 3/4] docs: document use of automatic cleanup functions in glib

2019-09-05 Thread Daniel P . Berrangé
Document the use of g_autofree and g_autoptr in glib for automatic freeing of memory. Reviewed-by: Alex Bennée Signed-off-by: Daniel P. Berrangé --- CODING_STYLE.rst | 85 1 file changed, 85 insertions(+) diff --git a/CODING_STYLE.rst

[Qemu-devel] [PULL 0/4] Docs patches

2019-09-05 Thread Daniel P . Berrangé
The following changes since commit 500efcfcf0fe2e0dae1d25637a13435ce7b6e421: Merge remote-tracking branch 'remotes/rth/tags/pull-or1k-20190904' into staging (2019-09-05 09:33:01 +0100) are available in the Git repository at: https://github.com/berrange/qemu tags/docs-pull-request for you

Re: [Qemu-devel] [RFC v3 PATCH 07/45] multi-process: define proxy-link object

2019-09-05 Thread Eric Blake
On 9/4/19 3:22 AM, Daniel P. Berrangé wrote: > On Tue, Sep 03, 2019 at 04:37:33PM -0400, Jagannathan Raman wrote: >> Defines proxy-link object which forms the communication link between >> QEMU & emulation program. >> Adds functions to configure members of proxy-link object instance. >> Adds

Re: [Qemu-devel] [RFC v3 PATCH 01/45] multi-process: memory: alloc RAM from file at offset

2019-09-05 Thread Jag Raman
On 9/4/2019 4:11 AM, Dr. David Alan Gilbert wrote: * Jagannathan Raman (jag.ra...@oracle.com) wrote: Allow RAM MemoryRegion to be created from an offset in a file, instead of allocating at offset of 0 by default. This is needed to synchronize RAM between QEMU & remote process. This will be

Re: [Qemu-devel] [RFC v3 PATCH 02/45] multi-process: util: Add qemu_thread_cancel() to cancel running thread

2019-09-05 Thread Jag Raman
On 9/4/2019 5:11 AM, Daniel P. Berrangé wrote: On Tue, Sep 03, 2019 at 04:37:28PM -0400, Jagannathan Raman wrote: qemu_thread_cancel() added to destroy a given running thread. This will be needed in the following patches. I don't see anything in the following patches that actually uses

[Qemu-devel] [Bug 1805256] Re: qemu-img hangs on high core count ARM system

2019-09-05 Thread Rafael David Tinoco
** Changed in: qemu (Ubuntu) Status: Confirmed => In Progress ** Changed in: qemu (Ubuntu) Assignee: (unassigned) => Rafael David Tinoco (rafaeldtinoco) ** Changed in: qemu (Ubuntu) Importance: Undecided => Medium -- You received this bug notification because you are a member of

Re: [Qemu-devel] [RFC v3 PATCH 19/45] multi-process: Add LSI device proxy object

2019-09-05 Thread Jag Raman
On 9/5/2019 6:22 AM, Gerd Hoffmann wrote: Hi, +static uint64_t proxy_lsi_io_read(void *opaque, hwaddr addr, unsigned size) +{ +ProxyLSIState *s = opaque; + +return proxy_default_bar_read(PCI_PROXY_DEV(s), >io_io, addr, size, + false); +} + +static

Re: [Qemu-devel] [RFC v3 PATCH 40/45] multi-process/mon: Refactor monitor/chardev functions out of vl.c

2019-09-05 Thread Jag Raman
On 9/4/2019 4:37 AM, Dr. David Alan Gilbert wrote: * Jagannathan Raman (jag.ra...@oracle.com) wrote: Some of the initialization helper functions w.r.t monitor & chardev in vl.c are also used by the remote process. Therefore, these functions are refactored into a shared file that both QEMU &

Re: [Qemu-devel] [PATCH v6 09/42] block: Include filters when freezing backing chain

2019-09-05 Thread Kevin Wolf
Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > In order to make filters work in backing chains, the associated > functions must be able to deal with them and freeze all filter links, be > they COW or R/W filter links. > > In the process, rename these functions to reflect that they now act on

Re: [Qemu-devel] [Qemu-block] [PATCH 0/7] block: Generic file creation fallback

2019-09-05 Thread Maxim Levitsky
On Fri, 2019-07-12 at 19:35 +0200, Max Reitz wrote: > Hi, > > Kevin commented on my RFC, so I got what an RFC wants, and he didn’t > object to the creation fallback part. So I suppose I can go down that > route at least. (Which was actually the more important part of the > series.) > > So as

Re: [Qemu-devel] Cryptic errors from PIP install if missing openssl-devel

2019-09-05 Thread Cleber Rosa
On Thu, Sep 05, 2019 at 12:09:24PM +1000, David Gibson wrote: > On Wed, Sep 04, 2019 at 03:57:17PM -0400, Cleber Rosa wrote: > > > > Hi David, > > > > I've pushed a branch here (most of the commits have already been sent > > separately): > > > >https://github.com/clebergnu/qemu/tree/ppc64 >

[Qemu-devel] [PULL 1/4] docs: convert README, CODING_STYLE and HACKING to RST syntax

2019-09-05 Thread Daniel P . Berrangé
Reviewed-by: Alex Bennée Signed-off-by: Daniel P. Berrangé --- CODING_STYLE => CODING_STYLE.rst | 121 +++--- HACKING => HACKING.rst | 123 +-- README => README.rst | 47 +++- scripts/checkpatch.pl|

Re: [Qemu-devel] [PATCH v3 3/4] docs: document use of automatic cleanup functions in glib

2019-09-05 Thread Eric Blake
On 8/29/19 11:50 AM, Daniel P. Berrangé wrote: > Document the use of g_autofree and g_autoptr in glib for automatic > freeing of memory. > > Signed-off-by: Daniel P. Berrangé > --- > CODING_STYLE.rst | 85 > 1 file changed, 85 insertions(+) > >

Re: [Qemu-devel] [PATCH v2 1/2] virtio: add vhost-user-fs base device

2019-09-05 Thread Dr. David Alan Gilbert
* Cornelia Huck (coh...@redhat.com) wrote: > On Fri, 23 Aug 2019 18:56:56 +0100 > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > The virtio-fs virtio device provides shared file system access using > > the FUSE protocol carried ovew virtio. > > The actual

[Qemu-devel] [RFC 1/3] virtiofsd: add org.qemu.Virtiofsd interface

2019-09-05 Thread Stefan Hajnoczi
Define a DBus interface for virtiofsd management. It only allows querying and changing the log level at the moment. In the future more methods and properties could be added. Signed-off-by: Stefan Hajnoczi --- configure| 7 +++ Makefile

Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p

2019-09-05 Thread Philippe Mathieu-Daudé
"virito-9p" -> "virtio-9p" in subject On 9/5/19 1:33 PM, Thomas Huth wrote: > So far we were not testing virtio-9p in Travis yet, since we forgot to > install libcap-devel. Do it now to get some more test coverage. > > Signed-off-by: Thomas Huth > --- > .travis.yml | 1 + > 1 file changed, 1

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-05 Thread Christian Schoenebeck via Qemu-devel
On Mittwoch, 4. September 2019 15:02:30 CEST Christian Schoenebeck wrote: > > > Well, mailman is handling this correctly. It replaces the "From:" field > > > with a placeholder and instead adds my actual email address as > > > "Reply-To:" field. That's the common way to handle this on mailing > >

Re: [Qemu-devel] test-aio-multithread assertion

2019-09-05 Thread Peter Maydell
On Wed, 4 Sep 2019 at 12:50, Peter Maydell wrote: > > Hi; I've been seeing intermittently on the BSDs this assertion > running test-aio-multithread as part of 'make check': > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} > tests/test-aio-multithread -m=quick -k --tap <

Re: [Qemu-devel] [PATCH 2/2] block/nvme: add support for discard

2019-09-05 Thread Maxim Levitsky
On Wed, 2019-08-28 at 12:03 +0300, Maxim Levitsky wrote: > On Tue, 2019-08-27 at 18:29 -0400, John Snow wrote: > > > > On 8/25/19 3:15 AM, Maxim Levitsky wrote: > > > Signed-off-by: Maxim Levitsky > > > --- > > > block/nvme.c | 83 ++ > > >

[Qemu-devel] [PULL 2/4] docs: merge HACKING.rst contents into CODING_STYLE.rst

2019-09-05 Thread Daniel P . Berrangé
The split of information between the two docs is rather arbitary and unclear. It is simpler for contributors if all the information is in one file. Reviewed-by: Alex Bennée Signed-off-by: Daniel P. Berrangé --- CODING_STYLE.rst | 296 ++ HACKING.rst

Re: [Qemu-devel] [PATCH v5 16/17] target/arm: Rebuild hflags at EL changes and MSR writes

2019-09-05 Thread Alex Bennée
Richard Henderson writes: > Now setting, but not relying upon, env->hflags. > > Signed-off-by: Richard Henderson > --- > linux-user/syscall.c | 1 + > target/arm/cpu.c | 1 + > target/arm/helper-a64.c| 3 +++ > target/arm/helper.c| 2 ++ > target/arm/machine.c

Re: [Qemu-devel] Cryptic errors from PIP install if missing openssl-devel

2019-09-05 Thread Eduardo Habkost
On Thu, Sep 05, 2019 at 09:38:24AM -0400, Cleber Rosa wrote: > On Thu, Sep 05, 2019 at 12:09:24PM +1000, David Gibson wrote: > > On Wed, Sep 04, 2019 at 03:57:17PM -0400, Cleber Rosa wrote: > > > > > > Hi David, > > > > > > I've pushed a branch here (most of the commits have already been sent >

Re: [Qemu-devel] [PATCH v6 14/42] block: Use CAFs when working with backing chains

2019-09-05 Thread Kevin Wolf
Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > Use child access functions when iterating through backing chains so > filters do not break the chain. > > Signed-off-by: Max Reitz > --- > block.c | 40 > 1 file changed, 28 insertions(+), 12

Re: [Qemu-devel] [PATCH v5 3/3] qcow2: add zstd cluster compression

2019-09-05 Thread Eric Blake
On 9/5/19 2:44 AM, Denis Plotnikov wrote: >>> + >>> +s_size = be32_to_cpu(*(const uint32_t *) src); >> As written, this looks like you may be dereferencing an unaligned >> pointer. It so happens that be32_to_cpu() applies & to your * to get >> back at the raw pointer, and then is careful to

[Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p

2019-09-05 Thread Thomas Huth
So far we were not testing virtio-9p in Travis yet, since we forgot to install libcap-devel. Do it now to get some more test coverage. Signed-off-by: Thomas Huth --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 92b00927d4..1d46442020 100644 ---

[Qemu-devel] [PATCH v7 1/3] 9p: Added virtfs option 'multidevs=remap|forbid|warn'

2019-09-05 Thread Christian Schoenebeck via Qemu-devel
From: Christian Schoenebeck 'warn' (default): Only log an error message (once) on host if more than one device is shared by same export, except of that just ignore this config error though. This is the default behaviour for not breaking existing installations implying that they really know what

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

2019-09-05 Thread Alex Bennée
Libo Zhou writes: > Do you know where in the source file I should look into to add my custom > logging functionality? > > > Or, would you suggest using gdb to look at my target register and memory > contents? The answer in this link below looks really promising. I'm gonna > give it a try

[Qemu-devel] [PATCH v3] qemu-ga: Convert invocation documentation to rST

2019-09-05 Thread Peter Maydell
The qemu-ga documentation is currently in qemu-ga.texi in Texinfo format, which we present to the user as: * a qemu-ga manpage * a section of the main qemu-doc HTML documentation Convert the documentation to rST format, and present it to the user as: * a qemu-ga manpage * part of the interop/

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 02/17] target/arm: Split out rebuild_hflags_a64

2019-09-05 Thread Alex Bennée
Richard Henderson writes: > Create a function to compute the values of the TBFLAG_A64 bits > that will be cached. For now, the env->hflags variable is not > used, and the results are fed back to cpu_get_tb_cpu_state. > > Signed-off-by: Richard Henderson > --- > target/arm/helper.c | 131

Re: [Qemu-devel] [PATCH v4 00/69] target/arm: Convert aa32 base isa to decodetree

2019-09-05 Thread Peter Maydell
On Wed, 4 Sep 2019 at 20:31, Richard Henderson wrote: > > This unifies the implementation of the actual instructions for > a32, t32, and t16. > > The changes from v3 are minimal, mostly rebase conflicts. There > is one change for checkpatch warnings, in patch 34 in trans_RFE. > > There is one

[Qemu-devel] [PATCH v7 0/3] 9p: Fix file ID collisions

2019-09-05 Thread Christian Schoenebeck via Qemu-devel
This is v7 of a proposed patch set for fixing file ID collisions with 9pfs. v6->v7: * Rebased to https://github.com/gkurz/qemu/commits/9p-next (SHA1 7fc4c49e91). * Be pedantic and abort with error on wrong value for new command line argument 'multidevs'. * Adjusted patches to

Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p

2019-09-05 Thread Greg Kurz
On Thu, 5 Sep 2019 14:07:01 +0200 Greg Kurz wrote: > On Thu, 5 Sep 2019 13:33:46 +0200 > Thomas Huth wrote: > > > So far we were not testing virtio-9p in Travis yet, since we forgot to > > install libcap-devel. Do it now to get some more test coverage. > > > > Signed-off-by: Thomas Huth > >

Re: [Qemu-devel] [PATCH v3 4/4] docs: split the CODING_STYLE doc into distinct groups

2019-09-05 Thread Peter Maydell
On Thu, 29 Aug 2019 at 17:59, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > --- > CODING_STYLE.rst | 9 + > 1 file changed, 9 insertions(+) Reviewed-by: Peter Maydell thanks -- PMM

[Qemu-devel] [PULL 4/4] docs: split the CODING_STYLE doc into distinct groups

2019-09-05 Thread Daniel P . Berrangé
Reviewed-by: Peter Maydell Signed-off-by: Daniel P. Berrangé --- CODING_STYLE.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/CODING_STYLE.rst b/CODING_STYLE.rst index 39397f0f6f..427699e0e4 100644 --- a/CODING_STYLE.rst +++ b/CODING_STYLE.rst @@ -7,6 +7,9 @@ QEMU Coding Style

[Qemu-devel] [RFC 2/3] virtiofsd: add DBus server to handle log level changes

2019-09-05 Thread Stefan Hajnoczi
Introduce a DBus server thread that runs alongside the other virtiofsd threads. It processes changes to the /org/qemu/virtiofsd object which can be accessed at the org.qemu.virtiofsd location on the bus. This code does not use locking because we are the only writer to the int current_log_level

[Qemu-devel] [RFC 0/3] virtiofsd: get/set log level via DBus

2019-09-05 Thread Stefan Hajnoczi
It is likely that virtiofsd will need to support "management commands" for reconfiguring it at runtime. The first use case was proposed by Eryu Guan for getting/setting the current log level. I promised to try out DBus as the management interface because it has a rich feature set and is

Re: [Qemu-devel] [RFC v3 PATCH 07/45] multi-process: define proxy-link object

2019-09-05 Thread Jag Raman
On 9/5/2019 10:37 AM, Eric Blake wrote: On 9/4/19 3:22 AM, Daniel P. Berrangé wrote: On Tue, Sep 03, 2019 at 04:37:33PM -0400, Jagannathan Raman wrote: Defines proxy-link object which forms the communication link between QEMU & emulation program. Adds functions to configure members of

[Qemu-devel] [RFC 3/3] virtiofsd: add virtiofsctl command-line management tool

2019-09-05 Thread Stefan Hajnoczi
virtiofsctl can control a running virtiofsd process: usage: ./virtiofsctl COMMAND [args...] Commands: get-log-level - show current log level set-log-level LEVEL - set current log level to one of "err", "warning", "info", "debug" Make sure it is

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-05 Thread Greg Kurz
On Thu, 05 Sep 2019 14:25:13 +0200 Christian Schoenebeck wrote: > On Mittwoch, 4. September 2019 15:02:30 CEST Christian Schoenebeck wrote: > > > > Well, mailman is handling this correctly. It replaces the "From:" field > > > > with a placeholder and instead adds my actual email address as > > >

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-09-05 Thread Laszlo Ersek
On 09/04/19 11:52, Igor Mammedov wrote: > it could be stolen RAM + black hole like TSEG, assuming fw can live without > RAM(0x3+128K) range > (in this case fwcfg interface would only work for locking down the range) > > or > > we can actually have a dedicated SMRAM (like in my earlier

Re: [Qemu-devel] [PATCH v6 11/42] block: Add bdrv_supports_compressed_writes()

2019-09-05 Thread Kevin Wolf
Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > Filters cannot compress data themselves but they have to implement > .bdrv_co_pwritev_compressed() still (or they cannot forward compressed > writes). Therefore, checking whether > bs->drv->bdrv_co_pwritev_compressed is non-NULL is not

Re: [Qemu-devel] [PATCH v6 1/3] qcow2: introduce compression type feature

2019-09-05 Thread Vladimir Sementsov-Ogievskiy
05.09.2019 12:31, Denis Plotnikov wrote: > The patch adds some preparation parts for incompatible compression type > feature to QCOW2 header that indicates that *all* compressed clusters > must be (de)compressed using a certain compression type. > > It is implied that the compression type is set

Re: [Qemu-devel] [PATCH v5 3/3] qcow2: add zstd cluster compression

2019-09-05 Thread Denis Plotnikov
On 05.09.2019 17:31, Eric Blake wrote: > On 9/5/19 2:44 AM, Denis Plotnikov wrote: > > + +s_size = be32_to_cpu(*(const uint32_t *) src); >>> As written, this looks like you may be dereferencing an unaligned >>> pointer. It so happens that be32_to_cpu() applies & to your * to get >>>

Re: [Qemu-devel] [RFC v3 PATCH 01/45] multi-process: memory: alloc RAM from file at offset

2019-09-05 Thread Dr. David Alan Gilbert
* Jag Raman (jag.ra...@oracle.com) wrote: > > > On 9/4/2019 4:11 AM, Dr. David Alan Gilbert wrote: > > * Jagannathan Raman (jag.ra...@oracle.com) wrote: > > > Allow RAM MemoryRegion to be created from an offset in a file, instead > > > of allocating at offset of 0 by default. This is needed to

Re: [Qemu-devel] Cryptic errors from PIP install if missing openssl-devel

2019-09-05 Thread Cleber Rosa
On Thu, Sep 05, 2019 at 11:06:18AM -0300, Eduardo Habkost wrote: > On Thu, Sep 05, 2019 at 09:38:24AM -0400, Cleber Rosa wrote: > > On Thu, Sep 05, 2019 at 12:09:24PM +1000, David Gibson wrote: > > > On Wed, Sep 04, 2019 at 03:57:17PM -0400, Cleber Rosa wrote: > > > > > > > > Hi David, > > > > >

[Qemu-devel] [Bug 1842925] [NEW] no batmap on convertion from qcow2 to vhd

2019-09-05 Thread Marat Salakhutdinov
Public bug reported: we run following version of qemu-img: $ qemu-img --version qemu-img version 2.5.0 (Debian 1:2.5+dfsg-5ubuntu10.41), Copyright (c) 2004-2008 Fabrice Bellard $ Here is os version: $ cat /etc/os-release NAME="Ubuntu" VERSION="16.04.6 LTS (Xenial Xerus)" ID=ubuntu

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 01/17] target/arm: Split out rebuild_hflags_common

2019-09-05 Thread Alex Bennée
Richard Henderson writes: > Create a function to compute the values of the TBFLAG_ANY bits > that will be cached. For now, the env->hflags variable is not > used, and the results are fed back to cpu_get_tb_cpu_state. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- >

Re: [Qemu-devel] [PATCH] gitlab-ci.yml: Install libattr1-dev and libcap-dev to test virtio-9p

2019-09-05 Thread Thomas Huth
On 05/09/2019 14.21, Greg Kurz wrote: > On Thu, 5 Sep 2019 13:17:29 +0200 > Thomas Huth wrote: > >> So far the gitlab-ci was not testing virtio-9p yet, since we did not >> install libattr1-dev and libcap-dev in any of the pipelines. Do it >> now to get some more test coverage. >> >>

[Qemu-devel] [Bug 1842925] Re: no batmap on convertion from qcow2 to vhd

2019-09-05 Thread Marat Salakhutdinov
we use vhd-util from link http://download.cloud.com.s3.amazonaws.com/tools/vhd-util -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1842925 Title: no batmap on convertion from qcow2 to vhd Status

[Qemu-devel] [PATCH v7 3/3] 9p: Use variable length suffixes for inode remapping

2019-09-05 Thread Christian Schoenebeck via Qemu-devel
From: Christian Schoenebeck Use variable length suffixes for inode remapping instead of the fixed 16 bit size prefixes before. With this change the inode numbers on guest will typically be much smaller (e.g. around >2^1 .. >2^7 instead of >2^48 with the previous fixed size inode remapping.

Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p

2019-09-05 Thread Greg Kurz
On Thu, 5 Sep 2019 13:33:46 +0200 Thomas Huth wrote: > So far we were not testing virtio-9p in Travis yet, since we forgot to > install libcap-devel. Do it now to get some more test coverage. > > Signed-off-by: Thomas Huth > --- Acked-by: Greg Kurz and Tested-by: Greg Kurz Whose tree is

Re: [Qemu-devel] [PATCH] gitlab-ci.yml: Install libattr1-dev and libcap-dev to test virtio-9p

2019-09-05 Thread Greg Kurz
On Thu, 5 Sep 2019 13:17:29 +0200 Thomas Huth wrote: > So far the gitlab-ci was not testing virtio-9p yet, since we did not > install libattr1-dev and libcap-dev in any of the pipelines. Do it > now to get some more test coverage. > > Signed-off-by: Thomas Huth > --- > .gitlab-ci.yml | 2 +-

[Qemu-devel] [PATCH v7 2/3] 9p: stat_to_qid: implement slow path

2019-09-05 Thread Christian Schoenebeck via Qemu-devel
From: Christian Schoenebeck stat_to_qid attempts via qid_path_prefixmap to map unique files (which are identified by 64 bit inode nr and 32 bit device id) to a 64 QID path value. However this implementation makes some assumptions about inode number generation on the host. If qid_path_prefixmap

Re: [Qemu-devel] [PATCH v3 2/4] docs: merge HACKING.rst contents into CODING_STYLE.rst

2019-09-05 Thread Eric Blake
On 8/29/19 11:50 AM, Daniel P. Berrangé wrote: > The split of information between the two docs is rather arbitary and > unclear. It is simpler for contributors if all the information is in > one file. > > Signed-off-by: Daniel P. Berrangé > --- > CODING_STYLE.rst | 296

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 17/17] target/arm: Rely on hflags correct in cpu_get_tb_cpu_state

2019-09-05 Thread Alex Bennée
Richard Henderson writes: > This is the payoff. > > From perf record -g data of ubuntu 18 boot and shutdown: > > BEFORE: > > - 23.02% 2.82% qemu-system-aar [.] helper_lookup_tb_ptr >- 20.22% helper_lookup_tb_ptr > + 10.05% tb_htable_lookup > - 9.13% cpu_get_tb_cpu_state

Re: [Qemu-devel] [PATCH v7 00/30] riscv: sifive_u: Improve the emulation fidelity of sifive_u machine

2019-09-05 Thread Bin Meng
Hi Alistair, On Thu, Sep 5, 2019 at 3:50 AM Alistair Francis wrote: > > On Sat, Aug 31, 2019 at 7:54 PM Bin Meng wrote: > > > > As of today, the QEMU 'sifive_u' machine is a special target that does > > not boot the upstream OpenSBI/U-Boot firmware images built for the real > > SiFive HiFive

[Qemu-devel] [PATCH] q35: lpc: allow to lock down 128K RAM at default SMBASE address

2019-09-05 Thread Igor Mammedov
lpc already has SMI negotiation feature, extend it by adding optin ICH9_LPC_SMI_F_LOCKED_SMBASE_BIT to supported features. Writing this bit into "etc/smi/requested-features" fw_cfg file, tells QEMU to alias 0x3,128K RAM range into SMRAM address space and mask this region from normal RAM

[Qemu-devel] [PATCH v2] riscv: sifive_test: Add reset functionality

2019-09-05 Thread Bin Meng
This adds a reset opcode for sifive_test device to trigger a system reset for testing purpose. Signed-off-by: Bin Meng Reviewed-by: Palmer Dabbelt --- Changes in v2: - fix build error in the "for-master" branch of Palmer's RISC-V repo that was rebased on QEMU master hw/riscv/sifive_test.c

Re: [Qemu-devel] [PATCH v1 02/42] configure: clean-up container cross compile detect

2019-09-05 Thread David Hildenbrand
On 04.09.19 22:29, Alex Bennée wrote: > The introduction of podman support inadvertently broke configure's > detect of the container support as the configure probe didn't specify > an engine type. To fix this in docker.py: > > - only (re)set USE_ENGINE if --engine is specified > - enhance the

Re: [Qemu-devel] [PATCH v3 0/6] tests/docker: add podman support

2019-09-05 Thread David Hildenbrand
On 05.09.19 18:15, David Hildenbrand wrote: > On 13.07.19 16:33, Marc-André Lureau wrote: >> Hi, >> >> podman allows to run containers in a similar fashion as docker, but >> without daemon or root privileges. Thank you podman! >> >> There is a weird issue with getaddrinfo(), that I reported

[Qemu-devel] [PULL 4/9] block: workaround for unaligned byte range in fallocate()

2019-09-05 Thread Eric Blake
From: Andrey Shinkevich Revert the commit 118f99442d 'block/io.c: fix for the allocation failure' and use better error handling for file systems that do not support fallocate() for an unaligned byte range. Allow falling back to pwrite in case fallocate() returns EINVAL. Suggested-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v2] riscv: sifive_test: Add reset functionality

2019-09-05 Thread Palmer Dabbelt
On Thu, 05 Sep 2019 08:57:44 PDT (-0700), bmeng...@gmail.com wrote: Hi Palmer, On Thu, Sep 5, 2019 at 11:55 PM Bin Meng wrote: This adds a reset opcode for sifive_test device to trigger a system reset for testing purpose. Signed-off-by: Bin Meng Reviewed-by: Palmer Dabbelt --- Changes

Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages

2019-09-05 Thread Johannes Berg
> +``VHOST_USER_VQ_CALL`` > + :id: 34 > + :equivalent ioctl: N/A > + :slave payload: vring state description > + :master payload: N/A Oops. This message should be called VHOST_USER_VRING_KICK. This file doesn't take about virtqueues, just vrings, and I inverted the call/kick. [...] >

Re: [Qemu-devel] [PATCH v6 0/4] virtio/block: handle zoned backing devices

2019-09-05 Thread Stefan Hajnoczi
On Wed, Sep 04, 2019 at 05:00:56PM -0400, Dmitry Fomichev wrote: > Currently, attaching zoned block devices (i.e., storage devices > compliant to ZAC/ZBC standards) using several virtio methods doesn't > work properly as zoned devices appear as regular block devices at the > guest. This may cause

Re: [Qemu-devel] [PATCH v3 0/6] tests/docker: add podman support

2019-09-05 Thread David Hildenbrand
On 13.07.19 16:33, Marc-André Lureau wrote: > Hi, > > podman allows to run containers in a similar fashion as docker, but > without daemon or root privileges. Thank you podman! > > There is a weird issue with getaddrinfo(), that I reported upstream >

Re: [Qemu-devel] [PATCH v6 16/42] block: Flush all children in generic code

2019-09-05 Thread Kevin Wolf
Am 12.08.2019 um 14:58 hat Max Reitz geschrieben: > On 10.08.19 17:36, Vladimir Sementsov-Ogievskiy wrote: > > 09.08.2019 19:13, Max Reitz wrote: > >> If the driver does not support .bdrv_co_flush() so bdrv_co_flush() > >> itself has to flush the children of the given node, it should not flush >

Re: [Qemu-devel] [PATCH v1 03/42] tests/docker: fix "cc" command to work with podman

2019-09-05 Thread John Snow
On 9/5/19 5:51 AM, Alex Bennée wrote: > > John Snow writes: > >> On 9/4/19 4:29 PM, Alex Bennée wrote: >>> Podman requires a little bit of additional magic to the uid mapping >>> which was already done for the normal RunCommand. We simplify the >>> logic by pushing it directly into the

Re: [Qemu-devel] [PATCH 2/2] block/nvme: add support for discard

2019-09-05 Thread John Snow
On 9/5/19 9:24 AM, Maxim Levitsky wrote: > On Wed, 2019-08-28 at 12:03 +0300, Maxim Levitsky wrote: >> On Tue, 2019-08-27 at 18:29 -0400, John Snow wrote: >>> >>> On 8/25/19 3:15 AM, Maxim Levitsky wrote: Signed-off-by: Maxim Levitsky --- block/nvme.c | 83

Re: [Qemu-devel] [RFC 3/3] virtiofsd: add virtiofsctl command-line management tool

2019-09-05 Thread Marc-André Lureau
Hi On Thu, Sep 5, 2019 at 9:13 PM Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > virtiofsctl can control a running virtiofsd process: > > > > usage: ./virtiofsctl COMMAND [args...] > > > > Commands: > > get-log-level - show current log level >

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-09-05 Thread Igor Mammedov
On Thu, 5 Sep 2019 15:08:31 +0200 Laszlo Ersek wrote: > On 09/04/19 11:52, Igor Mammedov wrote: > > > it could be stolen RAM + black hole like TSEG, assuming fw can live > > without RAM(0x3+128K) range > > (in this case fwcfg interface would only work for locking down the range) > > >

Re: [Qemu-devel] [RFC v3 PATCH 41/45] multi-process/mon: trim HMP command set for remote storage processes

2019-09-05 Thread Jag Raman
On 9/4/2019 4:56 AM, Dr. David Alan Gilbert wrote: * Jagannathan Raman (jag.ra...@oracle.com) wrote: Trim down the list of HMP commands available for storage class of remote processes. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- New

Re: [Qemu-devel] [RFC 0/3] virtiofsd: get/set log level via DBus

2019-09-05 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > It is likely that virtiofsd will need to support "management commands" for > reconfiguring it at runtime. The first use case was proposed by Eryu Guan for > getting/setting the current log level. > > I promised to try out DBus as the management

[Qemu-devel] [PULL 3/9] nbd: Tolerate more errors to structured reply request

2019-09-05 Thread Eric Blake
A server may have a reason to reject a request for structured replies, beyond just not recognizing them as a valid request; similarly, it may have a reason for rejecting a request for a meta context. It doesn't hurt us to continue talking to such a server; otherwise 'qemu-nbd --list' of such a

[Qemu-devel] [PULL 0/9] NBD patches through 2019-09-05

2019-09-05 Thread Eric Blake
The following changes since commit eac2f39602e0423adf56be410c9a22c31fec9a81: target/arm: Inline gen_bx_im into callers (2019-09-05 13:23:04 +0100) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2019-09-05 for you to fetch changes up to

[Qemu-devel] [PULL 1/9] nbd: Advertise multi-conn for shared read-only connections

2019-09-05 Thread Eric Blake
The NBD specification defines NBD_FLAG_CAN_MULTI_CONN, which can be advertised when the server promises cache consistency between simultaneous clients (basically, rules that determine what FUA and flush from one client are able to guarantee for reads from another client). When we don't permit

Re: [Qemu-devel] [PATCH v1 02/42] configure: clean-up container cross compile detect

2019-09-05 Thread Alex Bennée
David Hildenbrand writes: > On 04.09.19 22:29, Alex Bennée wrote: >> The introduction of podman support inadvertently broke configure's >> detect of the container support as the configure probe didn't specify >> an engine type. To fix this in docker.py: >> >> - only (re)set USE_ENGINE if

Re: [Qemu-devel] [RFC 3/3] virtiofsd: add virtiofsctl command-line management tool

2019-09-05 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > virtiofsctl can control a running virtiofsd process: > > usage: ./virtiofsctl COMMAND [args...] > > Commands: > get-log-level - show current log level > set-log-level LEVEL - set current log level to one of >

Re: [Qemu-devel] [PATCH 2/2] block/nvme: add support for discard

2019-09-05 Thread Maxim Levitsky
On Thu, 2019-09-05 at 13:27 -0400, John Snow wrote: > > On 9/5/19 9:24 AM, Maxim Levitsky wrote: > > On Wed, 2019-08-28 at 12:03 +0300, Maxim Levitsky wrote: > > > On Tue, 2019-08-27 at 18:29 -0400, John Snow wrote: > > > > > > > > On 8/25/19 3:15 AM, Maxim Levitsky wrote: > > > > >

Re: [Qemu-devel] [PATCH v1 02/42] configure: clean-up container cross compile detect

2019-09-05 Thread David Hildenbrand
On 05.09.19 20:35, Alex Bennée wrote: > > David Hildenbrand writes: > >> On 04.09.19 22:29, Alex Bennée wrote: >>> The introduction of podman support inadvertently broke configure's >>> detect of the container support as the configure probe didn't specify >>> an engine type. To fix this in

Re: [Qemu-devel] [PATCH v7 00/30] riscv: sifive_u: Improve the emulation fidelity of sifive_u machine

2019-09-05 Thread Palmer Dabbelt
On Thu, 05 Sep 2019 08:25:46 PDT (-0700), bmeng...@gmail.com wrote: Hi Alistair, On Thu, Sep 5, 2019 at 3:50 AM Alistair Francis wrote: On Sat, Aug 31, 2019 at 7:54 PM Bin Meng wrote: > > As of today, the QEMU 'sifive_u' machine is a special target that does > not boot the upstream

Re: [Qemu-devel] [PATCH v5 2/3] cpus: Fix throttling during vm_stop

2019-09-05 Thread Eric Blake
On 8/26/19 5:37 AM, Yury Kotov wrote: > Throttling thread sleeps in VCPU thread. For high throttle percentage > this sleep is more than 10ms. E.g. for 60% - 15ms, for 99% - 990ms. > vm_stop() kicks all VCPUs and waits for them. It's called at the end of > migration and because of the long sleep

[Qemu-devel] [PULL v2 0/9] qtests and misc patches

2019-09-05 Thread Thomas Huth
Hi Peter, the following changes since commit 500efcfcf0fe2e0dae1d25637a13435ce7b6e421: Merge remote-tracking branch 'remotes/rth/tags/pull-or1k-20190904' into staging (2019-09-05 09:33:01 +0100) are available in the Git repository at: https://gitlab.com/huth/qemu.git

Re: [Qemu-devel] [PULL 0/4] Docs patches

2019-09-05 Thread Peter Maydell
On Thu, 5 Sep 2019 at 14:45, Daniel P. Berrangé wrote: > > The following changes since commit 500efcfcf0fe2e0dae1d25637a13435ce7b6e421: > > Merge remote-tracking branch 'remotes/rth/tags/pull-or1k-20190904' into > staging (2019-09-05 09:33:01 +0100) > > are available in the Git repository at:

Re: [Qemu-devel] [PATCH v3 0/6] tests/docker: add podman support

2019-09-05 Thread Alex Bennée
David Hildenbrand writes: > On 13.07.19 16:33, Marc-André Lureau wrote: >> Hi, >> >> podman allows to run containers in a similar fashion as docker, but >> without daemon or root privileges. Thank you podman! >> >> There is a weird issue with getaddrinfo(), that I reported upstream >>

Re: [Qemu-devel] [RFC 2/3] virtiofsd: add DBus server to handle log level changes

2019-09-05 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > Introduce a DBus server thread that runs alongside the other virtiofsd > threads. It processes changes to the /org/qemu/virtiofsd object which > can be accessed at the org.qemu.virtiofsd location on the bus. > > This code does not use locking

[Qemu-devel] [PULL 2/9] nbd: Use g_autofree in a few places

2019-09-05 Thread Eric Blake
Thanks to our recent move to use glib's g_autofree, I can join the bandwagon. Getting rid of gotos is fun ;) There are probably more places where we could register cleanup functions and get rid of more gotos; this patch just focuses on the labels that existed merely to call g_free.

[Qemu-devel] [PULL 8/9] nbd: Implement client use of NBD FAST_ZERO

2019-09-05 Thread Eric Blake
The client side is fairly straightforward: if the server advertised fast zero support, then we can map that to BDRV_REQ_NO_FALLBACK support. A server that advertises FAST_ZERO but not WRITE_ZEROES is technically broken, but we can ignore that situation as it does not change our behavior.

[Qemu-devel] [PULL 5/9] docs: Update preferred NBD device syntax

2019-09-05 Thread Eric Blake
Mention the preferred URI form, especially since NBD is trying to standardize that form: https://lists.debian.org/nbd/2019/06/msg00012.html Signed-off-by: Eric Blake Message-Id: <20190903145634.20237-1-ebl...@redhat.com> Reviewed-by: John Snow --- qemu-doc.texi | 11 +-- 1 file

Re: [Qemu-devel] [PATCH v5 1/3] qemu-thread: Add qemu_cond_timedwait

2019-09-05 Thread Eric Blake
On 8/26/19 5:37 AM, Yury Kotov wrote: > Signed-off-by: Yury Kotov > --- Rather sparse on the commit message details. > include/qemu/thread.h| 18 ++ > util/qemu-thread-posix.c | 40 > util/qemu-thread-win32.c | 16 >

Re: [Qemu-devel] [PULL 0/4] Docs patches

2019-09-05 Thread Peter Maydell
On Thu, 5 Sep 2019 at 14:45, Daniel P. Berrangé wrote: > > The following changes since commit 500efcfcf0fe2e0dae1d25637a13435ce7b6e421: > > Merge remote-tracking branch 'remotes/rth/tags/pull-or1k-20190904' into > staging (2019-09-05 09:33:01 +0100) > > are available in the Git repository at:

[Qemu-devel] [PULL v2 9/9] gitlab-ci.yml: Install libattr-devel and libcap-devel to test virtio-9p

2019-09-05 Thread Thomas Huth
So far the gitlab-ci was not testing virtio-9p yet, since we did not install libattr-devel and libcap-devel in any of the pipelines. Do it now to get some more test coverage. Message-Id: <20190905111729.1197-1-th...@redhat.com> Acked-by: Greg Kurz Signed-off-by: Thomas Huth --- .gitlab-ci.yml

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 17/17] target/arm: Rely on hflags correct in cpu_get_tb_cpu_state

2019-09-05 Thread Laurent Desnogues
On Thu, Sep 5, 2019 at 5:24 PM Alex Bennée wrote: > > > Richard Henderson writes: > > > This is the payoff. > > > > From perf record -g data of ubuntu 18 boot and shutdown: > > > > BEFORE: > > > > - 23.02% 2.82% qemu-system-aar [.] helper_lookup_tb_ptr > >- 20.22%

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 17/17] target/arm: Rely on hflags correct in cpu_get_tb_cpu_state

2019-09-05 Thread Alex Bennée
Laurent Desnogues writes: > On Thu, Sep 5, 2019 at 5:24 PM Alex Bennée wrote: >> >> >> Richard Henderson writes: >> >> > This is the payoff. >> > >> > From perf record -g data of ubuntu 18 boot and shutdown: >> > >> > BEFORE: >> > >> > - 23.02% 2.82% qemu-system-aar [.]

Re: [Qemu-devel] [RFC v3 PATCH 41/45] multi-process/mon: trim HMP command set for remote storage processes

2019-09-05 Thread Dr. David Alan Gilbert
* Jag Raman (jag.ra...@oracle.com) wrote: > > > On 9/4/2019 4:56 AM, Dr. David Alan Gilbert wrote: > > * Jagannathan Raman (jag.ra...@oracle.com) wrote: > > > Trim down the list of HMP commands available for storage class of > > > remote processes. > > > > > > Signed-off-by: Elena Ufimtseva >

Re: [Qemu-devel] [PATCH v2] riscv: sifive_test: Add reset functionality

2019-09-05 Thread Bin Meng
Hi Palmer, On Thu, Sep 5, 2019 at 11:55 PM Bin Meng wrote: > > This adds a reset opcode for sifive_test device to trigger a system > reset for testing purpose. > > Signed-off-by: Bin Meng > Reviewed-by: Palmer Dabbelt > > --- > > Changes in v2: > - fix build error in the "for-master" branch of

[Qemu-devel] [PULL 9/9] nbd: Implement server use of NBD FAST_ZERO

2019-09-05 Thread Eric Blake
The server side is fairly straightforward: we can always advertise support for detection of fast zero, and implement it by mapping the request to the block layer BDRV_REQ_NO_FALLBACK. Signed-off-by: Eric Blake Message-Id: <20190823143726.27062-5-ebl...@redhat.com> Reviewed-by: Vladimir

[Qemu-devel] [PULL 7/9] nbd: Prepare for NBD_CMD_FLAG_FAST_ZERO

2019-09-05 Thread Eric Blake
Commit fe0480d6 and friends added BDRV_REQ_NO_FALLBACK as a way to avoid wasting time on a preliminary write-zero request that will later be rewritten by actual data, if it is known that the write-zero request will use a slow fallback; but in doing so, could not optimize for NBD. The NBD

[Qemu-devel] [PULL v2 6/9] tests/libqtest: Use libqtest-single.h in tests that require global_qtest

2019-09-05 Thread Thomas Huth
Tests that require global_qtest or the related wrapper functions now use the libqtest-single.h header that is dedicated for everything related to global_qtest. The core libqtest.c and libqtest.h files are now completely indepedent from global_qtest, so that the core library is now not depending on

  1   2   >