** Tags removed: fmod
** Tags added: float libm
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1843205
Title:
Inaccurate Fmod on i386
Status in QEMU:
New
Bug description:
# Qemu Version
On 07/09/2019 02.16, Matthew Rosato wrote:
> From: Pierre Morel
>
> We use a S390PCIGroup structure to hold the information
> related to zPCI Function group.
>
> This allows us to be ready to support multiple groups and to retrieve
> the group information from the host.
>
> Signed-off-by:
Public bug reported:
# Qemu Version
```bash
$ qemu-i386 --version
qemu-i386 version 3.0.1 (qemu-3.0.1-4.fc29)
Copyright (c) 2003-2017 Fabrice Bellard and the QEMU Project developers
```
# Failing Source Code (C)
```c
#include
#include
int main()
{
double x = 29860476080414620.0;
Signed-off-by: Mao Zhongyi
---
hw/pci/pci_bridge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c
index 715b9a4fe6..97967d12eb 100644
--- a/hw/pci/pci_bridge.c
+++ b/hw/pci/pci_bridge.c
@@ -311,7 +311,7 @@ void
Extract common print_sockfd() from various socket related syscalls.
Signed-off-by: Philippe Mathieu-Daudé
---
v6: use another ifdef TARGET_NR_socketcall
---
linux-user/strace.c | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/linux-user/strace.c
If the format is not the syscall last argument, a comma is append.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Laurent Vivier
---
checkpatch error:
ERROR: storage class should be at the beginning of the declaration
---
linux-user/strace.c | 10 +-
1 file changed, 5
Patchew URL: https://patchew.org/QEMU/20190908061543.25136-1-f4...@amsat.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190908061543.25136-1-f4...@amsat.org
Subject: [Qemu-devel] [PATCH v6 0/8] linux-user: strace
Suggested-by: Laurent Vivier
Signed-off-by: Philippe Mathieu-Daudé
---
linux-user/strace.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/linux-user/strace.c b/linux-user/strace.c
index c80e93b5db..f326c357a2 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@
Signed-off-by: Philippe Mathieu-Daudé
Tested-By: Guido Günther
Reviewed-by: Laurent Vivier
---
linux-user/strace.c| 13 +
linux-user/strace.list | 2 +-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/linux-user/strace.c b/linux-user/strace.c
index
Suggested-by: Laurent Vivier
Signed-off-by: Philippe Mathieu-Daudé
---
checkpatch error:
ERROR: storage class should be at the beginning of the declaration
---
linux-user/strace.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/linux-user/strace.c
Signed-off-by: Philippe Mathieu-Daudé
Tested-By: Guido Günther
---
linux-user/syscall.c | 6 --
linux-user/syscall_defs.h | 7 +++
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 8b41a03901..5128312db5 100644
---
Signed-off-by: Philippe Mathieu-Daudé
Tested-By: Guido Günther
---
v6: use TARGET_NR_socketcall || TARGET_NR_bind (lvivier)
---
linux-user/strace.c| 15 ++-
linux-user/strace.list | 2 +-
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/linux-user/strace.c
Hi Laurent,
Few patches I'v been writting while trying to figure out this issue:
http://lists.nongnu.org/archive/html/qemu-arm/2018-01/msg00514.html
As usual with linux-user files, this series will trigger some checkpatch
benign warnings.
Regards,
Phil.
Since v5:
- dropped 'Verify
Signed-off-by: Philippe Mathieu-Daudé
Tested-By: Guido Günther
---
linux-user/strace.c | 37 +
1 file changed, 37 insertions(+)
diff --git a/linux-user/strace.c b/linux-user/strace.c
index dcf843b360..77d7f6a97a 100644
--- a/linux-user/strace.c
+++
On Fri, Sep 06, 2019 at 08:16:25PM -0400, Matthew Rosato wrote:
> From: Pierre Morel
>
> This should be copied from Linux kernel UAPI includes.
> The version used here is Linux 5.3.0
>
> We define a new device region in vfio.h to be able to
> get the ZPCI CLP information by reading this region
On Fri, Sep 06, 2019 at 05:32:02PM +0200, Johannes Berg wrote:
> Hi,
>
> > Oh. Apparently qemu mailman chose this time to kick me out
> > of list subscription (too many bounces or something?)
> > so I didn't see it.
>
> D'oh. Well, it's really my mistake, I should've CC'ed you.
>
> > What
Add --preserve-arg0 in qemu-binfmt-conf.sh to configure the preserve-arg0
flag.
Now, if QEMU is started with -0 or QEMU_ARGV0 and an empty parameter
argv[0] (the full pathname provided by binfmt-misc) is removed and
replaced by argv[1] (the original argv[0] provided by binfmt-misc when
filename is only used to open the file if AT_EXECFD is not provided.
But exec_path already contains the path of the file to open.
Remove filename as it is only used in main.c whereas exec_path is
also used in syscall.c.
Fixes: d088d664f201 ("linux-user: identify running binary in /proc/self/exe")
If a hart writes -1 to mtimecmp it should not receive a timer interrupt
for (2^64 - 1)/(10 MHz) = 58455 years assuming a 10 MHz realtime clock.
But in practice I get a timer interrupt immediately because of an
integer overflow bug when QEMU converts realtime clock ticks into
nanoseconds.
My
Am Tue, 13 Aug 2019 15:49:21 +0200
schrieb Philippe Mathieu-Daudé :
> Proof of concept to interract with a framebuffer via VNC.
>
> This test send 'mem' and 'help' to the firmware prompt
> within the single X terminal opened.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> This test is
Hi,
This is the v2 of my patch series that makes mixeng optional and enables
more than two audio channels.
Changes from v1:
* renamed "mixeng" option to "mixing-engine"
* dropped patch "audio: remove hw->samples, buffer_size_in/out pcm_ops"
Regards,
Zoltan
Kővágó, Zoltán (24):
audio: api
Signed-off-by: Kővágó, Zoltán
---
audio/dsound_template.h | 47 +++---
audio/dsoundaudio.c | 307 +---
2 files changed, 92 insertions(+), 262 deletions(-)
diff --git a/audio/dsound_template.h b/audio/dsound_template.h
index 8ece870c9e..9f10b688df 100644
Signed-off-by: Kővágó, Zoltán
---
audio/coreaudio.c | 130 --
1 file changed, 69 insertions(+), 61 deletions(-)
diff --git a/audio/coreaudio.c b/audio/coreaudio.c
index d1be58b40a..5cde42f982 100644
--- a/audio/coreaudio.c
+++ b/audio/coreaudio.c
@@
Signed-off-by: Kővágó, Zoltán
---
audio/noaudio.c | 43 +--
1 file changed, 17 insertions(+), 26 deletions(-)
diff --git a/audio/noaudio.c b/audio/noaudio.c
index 0fb2629cf2..b054fd225b 100644
--- a/audio/noaudio.c
+++ b/audio/noaudio.c
@@ -41,10 +41,9 @@
Signed-off-by: Kővágó, Zoltán
---
audio/sdlaudio.c | 87 +++-
1 file changed, 42 insertions(+), 45 deletions(-)
diff --git a/audio/sdlaudio.c b/audio/sdlaudio.c
index 14b11f0335..f7ac8cd101 100644
--- a/audio/sdlaudio.c
+++ b/audio/sdlaudio.c
@@ -41,8
Signed-off-by: Kővágó, Zoltán
---
audio/Makefile.objs | 1 -
audio/audio_pt_int.c | 173
audio/audio_pt_int.h | 22 ---
audio/paaudio.c | 372 ++-
configure| 5 -
5 files changed, 45 insertions(+), 528
Signed-off-by: Kővágó, Zoltán
---
audio/audio.c | 42 ++
audio/audio_int.h | 7 ---
2 files changed, 6 insertions(+), 43 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index f5a5942da9..c945f23724 100644
--- a/audio/audio.c
+++
Signed-off-by: Kővágó, Zoltán
---
audio/alsaaudio.c | 302 --
1 file changed, 80 insertions(+), 222 deletions(-)
diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c
index 591344dccd..19124d09d8 100644
--- a/audio/alsaaudio.c
+++ b/audio/alsaaudio.c
@@
This way we no longer need vararg functions, improving compile time
error detection. Also now it's possible to check actually what commands
are supported, without needing to manually update ctl_caps.
Signed-off-by: Kővágó, Zoltán
---
audio/alsaaudio.c | 62 --
Usage notes: hw->samples became hw->{mix,conv}_buf->size, except before
initialization (audio_pcm_hw_alloc_resources_*), hw->samples gives the
initial size of the STSampleBuffer. The next commit tries to fix this
inconsistency.
Signed-off-by: Kővágó, Zoltán
---
audio/audio.c | 120
This will make it possible to skip mixeng with audio playback and
recording, allowing us to free ourselves from the limitations of the
current mixeng (stereo, int64 samples only). In this case, HW and SW
voices will be essentially the same, for every SW voice we will create
a HW voice, since we
Add an option to change the channel map used by pulseaudio. If not
specified, falls back to an OSS compatible channel map.
Signed-off-by: Kővágó, Zoltán
---
audio/paaudio.c | 18 ++
qapi/audio.json | 7 +--
qemu-options.hx | 9 +
3 files changed, 28 insertions(+),
Signed-off-by: Kővágó, Zoltán
---
audio/wavaudio.c | 54
1 file changed, 9 insertions(+), 45 deletions(-)
diff --git a/audio/wavaudio.c b/audio/wavaudio.c
index b6eeeb4e26..7816097db8 100644
--- a/audio/wavaudio.c
+++ b/audio/wavaudio.c
@@ -36,52
The bit shifting trick worked because the number of bytes per frame was
always a power-of-two (since QEMU only supports mono, stereo and 8, 16
and 32 bit samples). But if we want to add support for surround sound,
this no longer holds true.
Signed-off-by: Kővágó, Zoltán
---
audio/alsaaudio.c
This assumption is no longer true when mixeng is turned off.
Signed-off-by: Kővágó, Zoltán
---
hw/usb/dev-audio.c | 28 +---
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c
index ae42e5a2f1..74c99b1f12 100644
---
With stereo playback, they need about 375 minutes of continuous audio
playback to overflow, which is usually not a problem (as stopping and
later resuming playback resets the counters). But with 7.1 audio, they
only need about 95 minutes to overflow.
After the overflow, the buf->prod %
This will allow us to disable mixeng when we use a decent backend.
Disabling mixeng have a few advantages:
* we no longer convert the audio output from one format to another, when
the underlying audio system would just convert it to a third format.
We no longer convert, only the underlying
Signed-off-by: Kővágó, Zoltán
---
audio/ossaudio.c | 272 +--
1 file changed, 96 insertions(+), 176 deletions(-)
diff --git a/audio/ossaudio.c b/audio/ossaudio.c
index 1696933688..2782512706 100644
--- a/audio/ossaudio.c
+++ b/audio/ossaudio.c
@@
This commit removes the ad-hoc rate-limiting code from noaudio and
wavaudio, and replaces them with a (slightly modified) code from
spiceaudio. This way multiple write calls (for example when the
circular buffer wraps around) do not cause problems.
Signed-off-by: Kővágó, Zoltán
---
Implementation of the previously added mixing-engine option.
Signed-off-by: Kővágó, Zoltán
---
audio/audio.c | 70 ++
audio/audio_template.h | 20
2 files changed, 78 insertions(+), 12 deletions(-)
diff --git a/audio/audio.c
Signed-off-by: Kővágó, Zoltán
---
audio/audio.c | 30 ++
audio/audio.h | 10 ++
audio/audio_int.h | 4 ++--
audio/paaudio.c| 20
audio/spiceaudio.c | 14 --
5 files changed, 54 insertions(+), 24 deletions(-)
Which currently only means removing some checks. Old code won't require
more than two channels, but new code will need it.
Signed-off-by: Kővágó, Zoltán
---
audio/alsaaudio.c | 7 ---
audio/audio.c | 2 +-
2 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/audio/alsaaudio.c
42 matches
Mail list logo
