El mié, 04-09-2019 a las 19:13 +0200, Philippe Mathieu-Daudé escribió:
> IEC binary prefixes ease code review: the unit is explicit.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/arm/raspi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/raspi.c
El mié, 04-09-2019 a las 19:13 +0200, Philippe Mathieu-Daudé escribió:
> Various address spaces from the BCM2835 are reported as
> 'anonymous' in memory tree:
>
> (qemu) info mtree
>
> address-space: anonymous
> -008f (prio 0, i/o): bcm2835-mbox
>
I'm copying and pasting all my diff below, just in case something else caused
the segfault. Any help would be really appreciated guys.
diff --git a/target/mips/mips-defs.h b/target/mips/mips-defs.h
index bbf056a5..8a4acff3 100644
--- a/target/mips/mips-defs.h
+++ b/target/mips/mips-defs.h
@@
Paolo Bonzini 于2019年9月26日周四 下午5:18写道：
> On 26/09/19 10:59, Maxim Levitsky wrote:
> > If you mean to ask if there is a way to let guest access use no
> > paging at all, that is access host physical addresses directly, then
> > indeed there is no way, since regular non 'unrestricted guest' mode
>
El mié, 04-09-2019 a las 19:13 +0200, Philippe Mathieu-Daudé escribió:
> The UART1 is part of the AUX peripheral,
> the PCM_CLOCK (yet unimplemented) is part of the CPRMAN.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/arm/bcm2835_peripherals.c| 4 ++--
>
El vie, 06-09-2019 a las 12:07 +0200, Philippe Mathieu-Daudé escribió:
> On 9/4/19 7:13 PM, Philippe Mathieu-Daudé wrote:
> > The Raspberry firmware is closed-source. While running it, it
> > accesses various I/O registers. Logging these accesses as UNIMP
> > (unimplemented) help to understand
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> The image end offset as reported by qemu-img check is different when
> using an external data file; we do not care about its value here, so we
> can just filter it.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/091 | 3 ++-
>
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> Use _make_test_img whenever possible. This way, we will not ignore
> user-specified image options.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/094 | 2 +-
> tests/qemu-iotests/111 | 3 +--
> tests/qemu-iotests/123 | 2 +-
>
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> When using an external data file, there are no refcounts for data
> clusters. We thus have to adjust the corruption test in this patch to
> not be based around a data cluster allocation, but the L2 table
> allocation (L2 tables are still
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> The only difference is that the json:{} filename of the image looks
> different. We actually do not care about that filename in this test, we
> are only interested in (1) that there is a json:{} filename, and (2)
> whether the backing filename
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/007 | 5 +++--
> tests/qemu-iotests/014 | 2 ++
> tests/qemu-iotests/015 | 5 +++--
> tests/qemu-iotests/026 | 5 -
> tests/qemu-iotests/029 | 5 +++--
> tests/qemu-iotests/031 | 6
This can be used to set a DNS server to be used by the guest which is
different from the one configured on the host.
This fixes LP 1010484.
Signed-off-by: Samuel Thibault
---
net/slirp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/slirp.c b/net/slirp.c
index
On 2019-09-25 16:13, Gerd Hoffmann wrote:
Hi,
Oh now that I looked again at the pulseaudio docs, channel-map doesn't
have to be a list, it can be also a "well-known mapping name".
Unambiguous because the well-known mapping names are not valid channel
position list members.
Do we have
On Sun, Sep 29, 2019 at 10:13 PM Samuel Thibault
wrote:
>
> This can be used to set a DNS server to be used by the guest which is
> different from the one configured on the host.
>
> This fixes LP 1010484.
>
> Signed-off-by: Samuel Thibault
Reviewed-by: Marc-André Lureau
> ---
> net/slirp.c
On Fri, 2019-09-27 at 17:51 +0100, Daniel P. Berrangé wrote:
> On Fri, Sep 27, 2019 at 10:26:27AM -0500, Eric Blake wrote:
> > On 9/27/19 5:11 AM, Daniel P. Berrangé wrote:
> > > Some distros are now defaulting to LUKS version 2 which QEMU cannot
> > > process. For our I/O test that validates
On Fri, 2019-09-27 at 23:13 -0500, Eric Blake wrote:
> Qemu as server currently won't accept export names larger than 256
> bytes, so most uses of qemu as client have no reason to get anywhere
> near the NBD spec maximum of a 4k limit per string. However, we
> didn't actually have any code that
On 2019-09-25 11:49, Markus Armbruster wrote:
"Zoltán Kővágó" writes:
On 2019-09-23 15:08, Markus Armbruster wrote:
"Kővágó, Zoltán" writes:
This will allow us to disable mixeng when we use a decent backend.
Disabling mixeng have a few advantages:
* we no longer convert the audio output
El mié, 04-09-2019 a las 19:13 +0200, Philippe Mathieu-Daudé escribió:
> Base addresses and sizes taken from the "BCM2835 ARM Peripherals"
> datasheet from February 06 2012:
> https://www.raspberrypi.org/app/uploads/2012/02/BCM2835-ARM-Peripherals.pdf
>
> Reviewed-by: Peter Maydell
>
El mié, 04-09-2019 a las 19:13 +0200, Philippe Mathieu-Daudé escribió:
> The Raspberry Pi 4 uses a BCM2711 SoC (based on a BCM2838).
> The SoC can handle up to 8GiB of SDRAM, but we limit it to 4GiB
> (no 8GiB models in the market yet).
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
>
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/071 | 4 ++--
> tests/qemu-iotests/174 | 2 +-
> tests/qemu-iotests/178 | 4 ++--
> tests/qemu-iotests/197 | 4 ++--
> tests/qemu-iotests/215 | 4 ++--
> 5 files changed, 9 insertions(+), 9
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> IMGOPTS can never be empty for qcow2, because the check scripts adds
> compat=1.1 unless the user specified any compat option themselves.
> Thus, this block does not do anything and can be dropped.
>
> Signed-off-by: Max Reitz
> ---
>
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> Just rm will not delete external data files. Use _rm_test_img every
> time we delete a test image.
>
> (In the process, clean up the indentation of every _cleanup() this patch
> touches.)
>
> ((Also, use quotes consistently. I am happy to
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> The problem with allowing the data_file option is that you want to use a
> different data file per image used in the test. Therefore, we need to
> allow patterns like -o data_file='$TEST_IMG.data_file'.
>
> Then, we need to filter it out from
On Fri, Sep 27, 2019 at 04:12:40PM +0200, Greg Kurz wrote:
> On Thu, 26 Sep 2019 17:39:37 +0200
> Greg Kurz wrote:
>
> > On Wed, 25 Sep 2019 16:45:34 +1000
> > David Gibson wrote:
> >
> > > This method is used to set up the interrupt backends for the current
> > > configuration. However, this
On Thu, Sep 26, 2019 at 09:44:53PM +0100, Mark Cave-Ayland wrote:
> This allows us to remove more endian-specific defines from int_helper.c.
>
> Signed-off-by: Mark Cave-Ayland
Applied, thanks.
> ---
> target/ppc/int_helper.c | 72 ++---
> 1 file changed,
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> Overwriting IMGOPTS means ignoring all user-supplied options, which is
> not what we want. Replace the current IMGOPTS use by a new BACKING_FILE
> variable.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/267 | 12
> 1
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> It did not matter before, but now that _make_test_img understands -o, we
> should use it properly here.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/051 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> Blindly overriding IMGOPTS is suboptimal as this discards user-specified
> options. Whatever options the test needs should simply be appended.
>
> Some tests do this (with IMGOPTS=$(_optstr_add "$IMGOPTS" "...")), but
> that is cumbersome.
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> We do not care about the json:{} filenames here, so we can just filter
> them out and thus make the test work both with and without external data
> files.
Same comment as for iotest 110, this is more justification to move this
outside to reduce
Philippe, thanks for the fast review,
John, thanks for picking up this hot potato :-)
Sam
On Thu, Sep 26, 2019 at 10:16 PM Philippe Mathieu-Daudé
wrote:
> On 9/26/19 9:09 PM, Philippe Mathieu-Daudé wrote:
> > On 9/26/19 8:26 PM, John Snow wrote:
> >> On 9/26/19 5:57 AM, Philippe Mathieu-Daudé
El mié, 04-09-2019 a las 19:13 +0200, Philippe Mathieu-Daudé escribió:
> This file creates the BCM2836/BCM2837 blocks.
> The biggest differences with the BCM2838 we are going to add, are
> the base addresses of the interrupt controller and the peripherals.
> Add these addresses in the BCM283XInfo
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> This test can run just fine with other values for refcount_bits, so we
> should filter the value from qcow2.py's dump-header.
>
> (036 currently ignores user-specified image options, but that will be
> fixed in the next patch.)
>
>
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> Some tests require compat=1.1 and thus set IMGOPTS='compat=1.1'
> globally. That is not how it should be done; instead, they should
> simply set _unsupported_imgopts to compat=0.10 (compat=1.1 is the
> default anyway).
>
> This makes the
El mié, 04-09-2019 a las 19:13 +0200, Philippe Mathieu-Daudé escribió:
> The BCM2838 provides more peripherals.
> Add them as 'unimplemented' so we can track when/how firmware
> and kernel access them.
>
> Based on various sources:
>
> * U-boot:
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> Tests should not overwrite all user-supplied image options, but only add
> to it (which will effectively overwrite conflicting values). Accomplish
> this by passing options to _make_test_img via -o instead of $IMGOPTS.
>
> For some tests,
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> This will not work with external data files, so try to get tests working
> without it as far as possible.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/063 | 12
> tests/qemu-iotests/063.out | 3 ++-
>
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> This will allow us to add more options than just -b.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/common.rc | 28
> 1 file changed, 20 insertions(+), 8 deletions(-)
>
> diff --git
On Fri, Sep 27, 2019 at 12:16:49PM +0200, Greg Kurz wrote:
> On Fri, 27 Sep 2019 15:50:16 +1000
> David Gibson wrote:
>
> > This method essentially represents code which belongs to the interrupt
> > controller, but needs to be called on all possible intcs, rather than
> > just the currently
On Fri, Sep 27, 2019 at 10:40:14AM +0200, Greg Kurz wrote:
> On Fri, 27 Sep 2019 15:50:12 +1000
> David Gibson wrote:
>
> > spapr_xive_irq_claim() returns a bool to indicate if it succeeded.
> > But most of the callers and one callee use int return values and/or an
> > Error * with more
From: "Zhang, Qi"
Signed-off-by: Zhang, Qi
---
hw/i386/intel_iommu.c | 31 +--
1 file changed, 17 insertions(+), 14 deletions(-)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index f1de8fdb75..a118efaeaf 100644
--- a/hw/i386/intel_iommu.c
+++
On 27/09/2019 07:50, David Gibson wrote:
> This method essentially represents code which belongs to the interrupt
> controller, but needs to be called on all possible intcs, rather than
> just the currently active one. The "dual" version therefore calls
> into the xics and xive versions
On 30/09/2019 03:49, David Gibson wrote:
> On Fri, Sep 27, 2019 at 12:16:49PM +0200, Greg Kurz wrote:
>> On Fri, 27 Sep 2019 15:50:16 +1000
>> David Gibson wrote:
>>
>>> This method essentially represents code which belongs to the interrupt
>>> controller, but needs to be called on all possible
On Fri, Sep 27, 2019 at 12:16:49PM +0200, Greg Kurz wrote:
> On Fri, 27 Sep 2019 15:50:16 +1000
> David Gibson wrote:
>
> > This method essentially represents code which belongs to the interrupt
> > controller, but needs to be called on all possible intcs, rather than
> > just the currently
On Fri, Sep 27, 2019 at 04:27:12PM +0200, Greg Kurz wrote:
> On Fri, 27 Sep 2019 15:50:19 +1000
> David Gibson wrote:
>
> > This method depends only on the active irq controller. Now that we've
> > formalized the notion of active controller we can dispatch directly through
> > that, rather than
From: "Zhang, Qi"
When dt is supported, TM field should not be Reserved(0).
Refer to VT-d Spec 9.8
Signed-off-by: Zhang, Qi
Signed-off-by: Qi, Yadong
---
hw/i386/intel_iommu.c | 8
hw/i386/intel_iommu_internal.h | 17 +
2 files changed, 17 insertions(+), 8
From: "Zhang, Qi"
When dt is supported, TM field should not be Reserved(0).
Refer to VT-d Spec 9.8
Signed-off-by: Zhang, Qi
Signed-off-by: Qi, Yadong
---
hw/i386/intel_iommu.c | 12
hw/i386/intel_iommu_internal.h | 17 +
2 files changed, 21
On 27/09/2019 07:50, David Gibson wrote:
> These methods, like cpu_intc_create, really belong to the interrupt
> controller, but need to be called on all possible intcs.
>
> Like cpu_intc_create, therefore, make them methods on the intc and
> always call it for all existing intcs.
>
>
On Fri, Sep 27, 2019 at 05:22:16PM +0200, Greg Kurz wrote:
> On Fri, 27 Sep 2019 15:50:27 +1000
> David Gibson wrote:
>
> > For the benefit of peripheral device allocation, the number of available
> > irqs really wants to be the same on a given machine type version,
> > regardless of what irq
On Fri, Sep 27, 2019 at 02:16:12PM +0200, Greg Kurz wrote:
> On Fri, 27 Sep 2019 15:50:17 +1000
> David Gibson wrote:
>
> > These methods, like cpu_intc_create, really belong to the interrupt
> > controller, but need to be called on all possible intcs.
> >
> > Like cpu_intc_create, therefore,
On 27/09/2019 07:50, David Gibson wrote:
> The SpaprIrq structure is used to represent ths spapr machine's irq
> backend. Except that it kind of conflates two concepts: one is the
> backend proper - a specific interrupt controller that we might or
> might not be using, the other is the irq
On 30/09/2019 04:39, David Gibson wrote:
> On Fri, Sep 27, 2019 at 02:16:12PM +0200, Greg Kurz wrote:
>> On Fri, 27 Sep 2019 15:50:17 +1000
>> David Gibson wrote:
>>
>>> These methods, like cpu_intc_create, really belong to the interrupt
>>> controller, but need to be called on all possible
On 27/09/2019 07:50, David Gibson wrote:
> spapr now has the mechanism of constructing both XICS and XIVE instances of
> the SpaprInterruptController interface. However, only one of the interrupt
> controllers will actually be active at any given time, depending on feature
> negotiation with the
On 27/09/2019 07:50, David Gibson wrote:
> This method depends only on the active irq controller. Now that we've
> formalized the notion of active controller we can dispatch directly through
> that, rather than dispatching via SpaprIrq with the dual version having
> to do a second conditional
On 27/09/2019 07:50, David Gibson wrote:
> This method depends only on the active irq controller. Now that we've
> formalized the notion of active controller we can dispatch directly
> through that, rather than dispatching via SpaprIrq with the dual
> version having to do a second conditional
On 27/09/2019 07:50, David Gibson wrote:
> Both XICS and XIVE have routines to connect and disconnect KVM with similar
> but not identical signatures. This adjusts them to match exactly, which
> will be useful for further cleanups later.
>
> While we're at it, remove error reporting from the
On 27/09/2019 07:50, David Gibson wrote:
> This hook is a bit odd. The only caller is spapr_irq_init_kvm(), but
> it explicitly takes an SpaprIrq *, so it's never really called through the
> current SpaprIrq. Essentially this is just a way of passing through a
> function pointer so that
El mié, 04-09-2019 a las 19:13 +0200, Philippe Mathieu-Daudé escribió:
> The kernel is happy with this change, so we don't need
> to do anything more sophisticated.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/misc/bcm2835_property.c | 8
> 1 file
57 matches
Mail list logo
