[PATCH v8 4/9] target/arm/cpu64: max cpu: Introduce sve properties

2019-10-31 Thread Andrew Jones
Introduce cpu properties to give fine control over SVE vector lengths. We introduce a property for each valid length up to the current maximum supported, which is 2048-bits. The properties are named, e.g. sve128, sve256, sve384, sve512, ..., where the number is the number of bits. See the updates

[PATCH v8 7/9] target/arm/kvm: scratch vcpu: Preserve input kvm_vcpu_init features

2019-10-31 Thread Andrew Jones
kvm_arm_create_scratch_host_vcpu() takes a struct kvm_vcpu_init parameter. Rather than just using it as an output parameter to pass back the preferred target, use it also as an input parameter, allowing a caller to pass a selected target if they wish and to also pass cpu features. If the caller

Re: [PULL 0/9] Ide patches

2019-10-31 Thread Peter Maydell
On Thu, 31 Oct 2019 at 10:59, John Snow wrote: > > The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 > 14:10:32 +) > > are available in the Git

Re: [PULL 0/9] Ide patches

2019-10-31 Thread John Snow
On 10/31/19 11:02 AM, Peter Maydell wrote: > On Thu, 31 Oct 2019 at 10:59, John Snow wrote: >> >> The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: >> >> Merge remote-tracking branch >> 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 >>

Re: [PATCH v2] smb daemon get additional command line parameters from env variable

2019-10-31 Thread Samuel Thibault
Hello, Jordi Pujol, le jeu. 31 oct. 2019 14:33:00 +0100, a ecrit: > The smbd daemon takes additional command line options > from environment variable SMBDOPTIONS. > Set the environment variable SMBDOPTIONS before executing qemu. > > Example: > > export SMBDOPTIONS="--option='server min

[PULL v2 9/9] hd-geo-test: Add tests for lchs override

2019-10-31 Thread John Snow
From: Sam Eiderman Add QTest tests to check the logical geometry override option. The tests in hd-geo-test are out of date - they only test IDE and do not test interesting MBRs. Creating qcow2 disks with specific size and MBR layout is currently unused - we only use a default empty MBR.

Re: [PATCH v1 1/1] hw/arm/boot: Rebuild hflags when modifying CPUState at boot

2019-10-31 Thread Alex Bennée
Edgar E. Iglesias writes: > Rebuild hflags when modifying CPUState at boot. > > Fixes: e979972a6a > Signed-off-by: Edgar E. Iglesias > --- > hw/arm/boot.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/boot.c b/hw/arm/boot.c > index c264864c11..ef6724960c 100644 > ---

[PULL v2 4/9] bootdevice: Add interface to gather LCHS

2019-10-31 Thread John Snow
From: Sam Eiderman Add an interface to provide direct logical CHS values for boot devices. We will use this interface in the next commits. Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Signed-off-by: Sam Eiderman Signed-off-by: Sam Eiderman Reviewed-by: Philippe Mathieu-Daudé

[Bug 1847793] Re: qemu 4.1.0 - Corrupt guest filesystem after new vm install

2019-10-31 Thread Claus Paetow
Sorry for the delay,I was busy doing my job the last two weeks. I use XFS V5 on both main host (5.3.7-arch1-2-ARCH) and backup host (5.3.5-arch1-1-ARCH). It seems I ran in the first bug that has been fixed upstream. With git master (git clone at 18.10.) I could not reproduce the failure on my

Re: [PATCH v1 1/1] hw/arm/boot: Rebuild hflags when modifying CPUState at boot

2019-10-31 Thread Philippe Mathieu-Daudé
On 10/31/19 5:08 AM, Edgar E. Iglesias wrote: Rebuild hflags when modifying CPUState at boot. Fixes: e979972a6a Signed-off-by: Edgar E. Iglesias --- hw/arm/boot.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index c264864c11..ef6724960c 100644 ---

Re: RFC: New device for zero-copy VM memory access

2019-10-31 Thread geoff
On 2019-11-01 01:52, Peter Maydell wrote: On Thu, 31 Oct 2019 at 14:26, wrote: As the author of Looking Glass, I also have to consider the maintenance and the complexity of implementing the vhost protocol into the project. At this time a complete Porthole client can be implemented in 150

Re: [Virtio-fs] [PATCH] virtiofsd: Fix data corruption with O_APPEND wirte in writeback mode

2019-10-31 Thread Vivek Goyal
On Wed, Oct 23, 2019 at 09:25:23PM +0900, Misono Tomohiro wrote: > When writeback mode is enabled (-o writeback), O_APPEND handling is > done in kernel. Therefore virtiofsd clears O_APPEND flag when open. > Otherwise O_APPEND flag takes precedence over pwrite() and write > data may corrupt. > >

[PULL v2 6/9] bootdevice: Gather LCHS from all relevant devices

2019-10-31 Thread John Snow
From: Sam Eiderman Relevant devices are: * ide-hd (and ide-cd, ide-drive) * scsi-hd (and scsi-cd, scsi-disk, scsi-block) * virtio-blk-pci We do not call del_boot_device_lchs() for ide-* since we don't need to - IDE block devices do not support unplugging. Reviewed-by: Karl Heubaum

[PULL v2 0/9] Ide patches

2019-10-31 Thread John Snow
The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: Merge remote-tracking branch 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 14:10:32 +) are available in the Git repository at: https://github.com/jnsnow/qemu.git

Re: [libvirt] [PULL 0/9] Ide patches

2019-10-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191031105904.12194-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [libvirt] [PULL 0/9] Ide patches Type: series Message-id: 20191031105904.12194-1-js...@redhat.com === TEST

Re: [PATCH v6 2/4] tests/vm: add console_consume helper

2019-10-31 Thread Philippe Mathieu-Daudé
On 10/31/19 9:53 AM, Gerd Hoffmann wrote: Helper function to read all console output. Signed-off-by: Gerd Hoffmann --- tests/vm/basevm.py | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 2929de23aa..086bfb2c66 100755 ---

[PATCH] tests/boot_linux_console: Fetch assets from Debian snapshot archives

2019-10-31 Thread Philippe Mathieu-Daudé
The kernel packaged was fetched from an unstable repository. Use the stable snapshot archive instead. Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/boot_linux_console.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/acceptance/boot_linux_console.py

[PATCH v8 0/9] target/arm/kvm: enable SVE in guests

2019-10-31 Thread Andrew Jones
Since Linux kernel v5.2-rc1 KVM has support for enabling SVE in guests. This series provides the QEMU bits for that enablement. First, we select existing CPU properties representing features we want to advertise in addition to the SVE vector lengths and prepare them for a qmp query. Then we

[PATCH v8 9/9] target/arm/kvm: host cpu: Add support for sve properties

2019-10-31 Thread Andrew Jones
Allow cpu 'host' to enable SVE when it's available, unless the user chooses to disable it with the added 'sve=off' cpu property. Also give the user the ability to select vector lengths with the sve properties. We don't adopt 'max' cpu's other sve property, sve-max-vq, because that property is

Re: [PATCH v8 0/9] target/arm/kvm: enable SVE in guests

2019-10-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191031142734.8590-1-drjo...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Virtio-fs] [PATCH] virtiofsd: Fix data corruption with O_APPEND wirte in writeback mode

2019-10-31 Thread Vivek Goyal
On Thu, Oct 31, 2019 at 09:39:23AM +, misono.tomoh...@fujitsu.com wrote: [..] > > > > Hi Misono, > > > > > > > > Have you tried running pjdfstests. Looks like with the patch applied > > > > I see following tests failing which were passing without the patch. > > > > Can you please have a look.

[PULL v2 3/9] block: Support providing LCHS from user

2019-10-31 Thread John Snow
From: Sam Eiderman Add logical geometry variables to BlockConf. A user can now supply "lcyls", "lheads" & "lsecs" for any HD device that supports CHS ("cyls", "heads", "secs"). These devices include: * ide-hd * scsi-hd * virtio-blk-pci In future commits we will use the provided

Re: [libvirt] [PULL v2 0/9] Ide patches

2019-10-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191031155636.18589-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [libvirt] [PULL v2 0/9] Ide patches Type: series Message-id: 20191031155636.18589-1-js...@redhat.com ===

[PATCH v8 2/9] tests: arm: Introduce cpu feature tests

2019-10-31 Thread Andrew Jones
Now that Arm CPUs have advertised features lets add tests to ensure we maintain their expected availability with and without KVM. Signed-off-by: Andrew Jones Reviewed-by: Eric Auger --- tests/Makefile.include | 5 +- tests/arm-cpu-features.c | 253 +++ 2

Re: RFC: New device for zero-copy VM memory access

2019-10-31 Thread Peter Maydell
On Thu, 31 Oct 2019 at 14:26, wrote: > As the author of Looking Glass, I also have to consider the maintenance > and the complexity of implementing the vhost protocol into the project. > At this time a complete Porthole client can be implemented in 150 lines > of C without external dependencies,

[PULL v2 7/9] bootdevice: Refactor get_boot_devices_list

2019-10-31 Thread John Snow
From: Sam Eiderman Move device name construction to a separate function. We will reuse this function in the following commit to pass logical CHS parameters through fw_cfg much like we currently pass bootindex. Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Reviewed-by: Philippe

Re: [PATCH 0/1] BZ#1751431:guest-get-memory-block-info is not supported

2019-10-31 Thread Basil Salman
PING On Thu, Oct 17, 2019 at 3:34 PM Basil Salman wrote: > From: Basil Salman > > "guest-get-memory-block-info" is enabled according to "get-info" output, > while the command is only supported for linux with sysfs. > > "guest-get-memory-block-info" command was added to blacklist. > > Basil

Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again

2019-10-31 Thread Dr. David Alan Gilbert
* Han Han (h...@redhat.com) wrote: > However, another important question is: how can we avoid such undocumented > incompatibility appears again? The reboot-timeout one was accidental - it was a documented qemu feature; just no one noticed it when the input check was added. Officially if we

RE: [RFC v2 00/22] intel_iommu: expose Shared Virtual Addressing to VM

2019-10-31 Thread Liu, Yi L
> From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Thursday, October 31, 2019 5:33 AM > Subject: Re: [RFC v2 00/22] intel_iommu: expose Shared Virtual Addressing to > VM > > > On 2019/10/25 下午6:12, Tian, Kevin wrote: > >> From: Jason Wang [mailto:jasow...@redhat.com] > >> Sent: Friday,

Re: RFC: New device for zero-copy VM memory access

2019-10-31 Thread Dr. David Alan Gilbert
* ge...@hostfission.com (ge...@hostfission.com) wrote: > > > On 2019-11-01 01:52, Peter Maydell wrote: > > On Thu, 31 Oct 2019 at 14:26, wrote: > > > As the author of Looking Glass, I also have to consider the > > > maintenance > > > and the complexity of implementing the vhost protocol into

Re: [Bug 1850570] [NEW] Cannot use usb-host on Mac OS

2019-10-31 Thread G 3
> > Message: 9 > Date: Wed, 30 Oct 2019 01:46:54 - > From: John Canada <1850...@bugs.launchpad.net> > To: qemu-devel@nongnu.org > Subject: [Bug 1850570] [NEW] Cannot use usb-host on Mac OS > Message-ID: > < > 157240001496.28481.10507378472210680134.malone...@chaenomeles.canonical.com >

Re: [PATCH v6 4/4] tests/vm: update netbsd to version 8.1

2019-10-31 Thread Philippe Mathieu-Daudé
On 10/31/19 9:53 AM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- tests/vm/netbsd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vm/netbsd b/tests/vm/netbsd index d1bfd0..33779402dd 100755 --- a/tests/vm/netbsd +++ b/tests/vm/netbsd @@ -22,7 +22,7 @@

Re: [PATCH v2] smb daemon get additional command line parameters from env variable

2019-10-31 Thread Jordi Pujol
Hello, Many thanks Laurent, This is the version 2 of this patch, has been modified according to the qemu guidelines. ** From: Jordi Pujol Palomer Date: Thu, 31 Oct 2019 14:31:14 +0200 Subject: [PATCH v2] QEMU samba daemon: additional command line

[PATCH v8 5/9] target/arm/kvm64: Add kvm_arch_get/put_sve

2019-10-31 Thread Andrew Jones
These are the SVE equivalents to kvm_arch_get/put_fpsimd. Note, the swabbing is different than it is for fpsmid because the vector format is a little-endian stream of words. Signed-off-by: Andrew Jones Reviewed-by: Richard Henderson Reviewed-by: Eric Auger Tested-by: Masayoshi Mizuma ---

git-publish, --pull-request and --signoff (was: Re: [PULL 0/9] Ide patches)

2019-10-31 Thread John Snow
On 10/31/19 11:02 AM, Peter Maydell wrote: > On Thu, 31 Oct 2019 at 10:59, John Snow wrote: >> >> The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: >> >> Merge remote-tracking branch >> 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 >>

Re: RFC: New device for zero-copy VM memory access

2019-10-31 Thread Dr. David Alan Gilbert
* ge...@hostfission.com (ge...@hostfission.com) wrote: > Hi Dave, > > On 2019-10-31 05:52, Dr. David Alan Gilbert wrote: > > * ge...@hostfission.com (ge...@hostfission.com) wrote: > > > Hi All, > > > > > > Over the past week, I have been working to come up with a solution > > > to the > > >

Re: [PATCH v6 3/4] tests/vm: use console_consume for netbsd

2019-10-31 Thread Philippe Mathieu-Daudé
On 10/31/19 9:53 AM, Gerd Hoffmann wrote: Use new helper to read all pending console output, not just a single char. Unblocks installer boot. Signed-off-by: Gerd Hoffmann --- tests/vm/netbsd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vm/netbsd

[PATCH v8 8/9] target/arm/cpu64: max cpu: Support sve properties with KVM

2019-10-31 Thread Andrew Jones
Extend the SVE vq map initialization and validation with KVM's supported vector lengths when KVM is enabled. In order to determine and select supported lengths we add two new KVM functions for getting and setting the KVM_REG_ARM64_SVE_VLS pseudo-register. This patch has been co-authored with

Re: [PATCH] tests/boot_linux_console: Fetch assets from Debian snapshot archives

2019-10-31 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > The kernel packaged was fetched from an unstable repository. > Use the stable snapshot archive instead. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Tested-by: Alex Bennée > --- > tests/acceptance/boot_linux_console.py | 3 ++- > 1

[PULL v2 5/9] scsi: Propagate unrealize() callback to scsi-hd

2019-10-31 Thread John Snow
From: Sam Eiderman We will need to add LCHS removal logic to scsi-hd's unrealize() in the next commit. Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Sam Eiderman Signed-off-by: Sam Eiderman Tested-by: Philippe Mathieu-Daudé

[PULL v2 1/9] IDE: deprecate ide-drive

2019-10-31 Thread John Snow
It's an old compatibility shim that just delegates to ide-cd or ide-hd. I'd like to refactor these some day, and getting rid of the super-object will make that easier. Either way, we don't need this. Signed-off-by: John Snow Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster ACKed-by:

Re: [PATCH 1/1] qga: Add "guest-get-memory-block-info" to blacklist

2019-10-31 Thread Marc-André Lureau
On Thu, Oct 17, 2019 at 2:35 PM Basil Salman wrote: > > From: Basil Salman > > Memory block commands are only supported for linux with sysfs, > "guest-get-memory-block-info" was not in blacklist for other > cases. > > Reported on: > https://bugzilla.redhat.com/show_bug.cgi?id=1751431 > >

Re: [PULL v2 0/9] Ide patches

2019-10-31 Thread Peter Maydell
On Thu, 31 Oct 2019 at 15:57, John Snow wrote: > > The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 > 14:10:32 +) > > are available in the Git

Re: Missing PVR setting capability

2019-10-31 Thread Wayne Li
So it's been a little while and I've been trying some different approaches. I think the problem I am having is because I don't have the required kernel modules loaded. When I run lsmod I only see the following two modules loaded: Module Size Used by nfsd

[KVM Forum] Upstreaming device fuzzing discussion Fri 1 Nov 2019

2019-10-31 Thread Stefan Hajnoczi
Hi, Following Dima's presentation on virtio device fuzzing[1] and Alexander's "[PATCH v4 00/20] Add virtual device fuzzing support"[2] series on the mailing list, it's time discuss the roadmap for QEMU device fuzzing in qemu.git. We will meet at 13:45 CET on Fri 1st of November in the Forum 1/2/3

logfile issue

2019-10-31 Thread Robert Foley
We hit an issue when trying to change the log file from the monitor console. The root of the issue here is that the qemu_logfile handle is not thread safe. So when we try to close the file, we end up with a seg fault. The full analysis is below along with some possible solutions. Will plan to

Re: [PATCH v1 1/1] hw/arm/boot: Rebuild hflags when modifying CPUState at boot

2019-10-31 Thread Luc Michel
On 10/31/19 5:08 AM, Edgar E. Iglesias wrote: > Rebuild hflags when modifying CPUState at boot. > > Fixes: e979972a6a > Signed-off-by: Edgar E. Iglesias Reviewed-by: Luc Michel > --- > hw/arm/boot.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/boot.c b/hw/arm/boot.c >

[Bug 1850570] Re: Cannot use usb-host on Mac OS

2019-10-31 Thread John Canada
Yes, I tried running as root. I also tried it on a different computer that is running Mac OS 10.13, and it gave the same errors. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1850570 Title:

Re: [PATCH 00/30] virtiofs daemon (base)

2019-10-31 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Wed, Oct 30, 2019 at 10:47:00AM +, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Mon, Oct 21, 2019 at 11:58:02AM +0100, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David Alan

Re: RFC: New device for zero-copy VM memory access

2019-10-31 Thread geoff
On 2019-11-01 00:24, Dr. David Alan Gilbert wrote: * ge...@hostfission.com (ge...@hostfission.com) wrote: Hi Dave, On 2019-10-31 05:52, Dr. David Alan Gilbert wrote: > * ge...@hostfission.com (ge...@hostfission.com) wrote: > > Hi All, > > > > Over the past week, I have been working to come

[PATCH v8 1/9] target/arm/monitor: Introduce qmp_query_cpu_model_expansion

2019-10-31 Thread Andrew Jones
Add support for the query-cpu-model-expansion QMP command to Arm. We do this selectively, only exposing CPU properties which represent optional CPU features which the user may want to enable/disable. Additionally we restrict the list of queryable cpu models to 'max', 'host', or the current type

[PATCH v8 6/9] target/arm/kvm64: max cpu: Enable SVE when available

2019-10-31 Thread Andrew Jones
Enable SVE in the KVM guest when the 'max' cpu type is configured and KVM supports it. KVM SVE requires use of the new finalize vcpu ioctl, so we add that now too. For starters SVE can only be turned on or off, getting all vector lengths the host CPU supports when on. We'll add the other SVE CPU

[PATCH v8 3/9] target/arm: Allow SVE to be disabled via a CPU property

2019-10-31 Thread Andrew Jones
Since 97a28b0eeac14 ("target/arm: Allow VFP and Neon to be disabled via a CPU property") we can disable the 'max' cpu model's VFP and neon features, but there's no way to disable SVE. Add the 'sve=on|off' property to give it that flexibility. We also rename cpu_max_get/set_sve_vq to

[PULL v2 2/9] block: Refactor macros - fix tabbing

2019-10-31 Thread John Snow
From: Sam Eiderman Fixing tabbing in block related macros. Signed-off-by: Sam Eiderman Signed-off-by: Sam Eiderman Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: John Snow --- include/hw/block/block.h | 16

[PULL v2 8/9] bootdevice: FW_CFG interface for LCHS values

2019-10-31 Thread John Snow
From: Sam Eiderman Using fw_cfg, supply logical CHS values directly from QEMU to the BIOS. Non-standard logical geometries break under QEMU. A virtual disk which contains an operating system which depends on logical geometries (consistent values being reported from BIOS INT13 AH=08) will most

Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again

2019-10-31 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Han Han (h...@redhat.com) wrote: >> However, another important question is: how can we avoid such undocumented >> incompatibility appears again? > > The reboot-timeout one was accidental - it was a documented qemu > feature; just no one noticed it when the

[PATCH V2 1/4] net/awd.c: Introduce Advanced Watch Dog module framework

2019-10-31 Thread Zhang Chen
From: Zhang Chen This patch introduce a new module named Advanced Watch Dog, and defined the input and output parameter. AWD use standard chardev as the way of communicationg with the outside world. If you want to use it, please add "--enable-awd" when configure qemu. Demo command: -object

[PATCH V2 4/4] vl.c: Make Advanced Watch Dog delayed initialization

2019-10-31 Thread Zhang Chen
From: Zhang Chen Because Advanced Watch Dog module needs chardev socket to initialize properly before. Signed-off-by: Zhang Chen --- vl.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/vl.c b/vl.c index 6a65a64bfd..048fe458b9 100644 --- a/vl.c +++ b/vl.c @@ -2689,6 +2689,13 @@

Re: [PULL 1/9] IDE: deprecate ide-drive

2019-10-31 Thread Markus Armbruster
Paolo Bonzini writes: > On 31/10/19 11:58, John Snow wrote: >> It's an old compatibility shim that just delegates to ide-cd or ide-hd. >> I'd like to refactor these some day, and getting rid of the super-object >> will make that easier. >> >> Either way, we don't need this. > > Good idea. I

[PATCH V2 2/4] net/awd.c: Initailize input/output chardev

2019-10-31 Thread Zhang Chen
From: Zhang Chen Find and check the chardev awd_node and notification_node, The awd_node used for keep connect with outside(like VM client/other host/Remote server), and the notification_node used for do some operation when disconnect event occur. Signed-off-by: Zhang Chen --- net/awd.c | 37

[PATCH V2 0/4] Introduce Advanced Watch Dog module

2019-10-31 Thread Zhang Chen
From: Zhang Chen Advanced Watch Dog is an universal monitoring module on VMM side, it can be used to detect network down(VMM to guest, VMM to VMM, VMM to another remote server) and do previously set operation. Current AWD patch just accept any input as the signal to refresh the watchdog

[PATCH V2 3/4] net/awd.c: Load advanced watch dog worker thread job

2019-10-31 Thread Zhang Chen
From: Zhang Chen This patch load pulse_timer and timeout_timer in the new iothread. The pulse timer will send pulse info to awd_node, and the timeout timer will check the reply pulse from awd_node. If timeout occur, it will send opt_script's data to the notification_node. Signed-off-by: Zhang

Re: presentation at kvm forum and pagefaults

2019-10-31 Thread Michael S. Tsirkin
Regarding the presentation I gave at the kvm forum on pagefaults. Two points: 1. pagefaults are important not just for migration. They are important for performance features such as autonuma and huge pages, since this relies on moving pages around. Migration can maybe be solved by switch to

Sparc Solaris 10

2019-10-31 Thread Zainuddin AR
Hi, I like to find to find out if you have a working qemu on solaris 10 or 11. I have tried the qemu-sun4vniagara but without networking. Is the networking support for niagara version available? Regards Zai

Re: [RFC] q800: fix I/O memory map

2019-10-31 Thread Philippe Mathieu-Daudé
On 10/31/19 11:03 AM, Laurent Vivier wrote: Linux kernel 5.4 will introduce a new memory map for SWIM device. (aee6bff1c325 ("m68k: mac: Revisit floppy disc controller base addresses")) Until this release all MMIO are mapped between 0x50f0 and 0x50f4, but it appears that for real

Re: [PATCH] target/i386: return directly from hyperv_init_vcpu() if hyperv not enabled

2019-10-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191101014528.14505-1-richardw.y...@linux.intel.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] target/i386: return directly from hyperv_init_vcpu() if hyperv not enabled Type:

Re: [PATCH v5 02/13] hw/core/qdev: add trace events to help with resettable transition

2019-10-31 Thread Philippe Mathieu-Daudé
On 10/18/19 5:06 PM, Damien Hedde wrote: Adds trace events to reset procedure and when updating the parent bus of a device. Signed-off-by: Damien Hedde --- hw/core/qdev.c | 27 --- hw/core/trace-events | 9 + 2 files changed, 33 insertions(+), 3

Re: [PATCH v5 08/13] hw/core: deprecate old reset functions and introduce new ones

2019-10-31 Thread Philippe Mathieu-Daudé
On 10/18/19 5:06 PM, Damien Hedde wrote: Deprecate device_legacy_reset(), qdev_reset_all() and qbus_reset_all() to be replaced by new functions device_cold_reset() and bus_cold_reset() which uses resettable API. Also introduce resettable_cold_reset_fn() which may be used as a replacement for

[PATCH 1/2] vhost-user: add VHOST_USER_RESET_DEVICE to reset devices

2019-10-31 Thread Raphael Norwitz
Add a VHOST_USER_RESET_DEVICE message which will reset the vhost user backend. Disabling all rings, and resetting all internal state, ready for the backend to be reinitialized. A backend has to report it supports this features with the VHOST_USER_PROTOCOL_F_RESET_DEVICE protocol feature bit. If

[PATCH 0/2] vhost-user: add message for device reset

2019-10-31 Thread Raphael Norwitz
I have updated patches [1] sent by David Vrabel last year: [1] https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg05077.html This change adds a new ???reset device??? feature to the vhost-user protocol and a corresponding VHOST_USER_RESET_DEVICE message to notify vhost-user backends when a

[Bug 1799792] Re: Broken scaling with gtk,gl=on on a hidpi display

2019-10-31 Thread Ernst Sjöstrand
Also happens on Ubuntu 19.10 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1799792 Title: Broken scaling with gtk,gl=on on a hidpi display Status in QEMU: New Bug description: Tested on QEMU

[PATCH v7 0/9] target/arm/kvm: enable SVE in guests

2019-10-31 Thread Zhang, Lei
Hi Jones, Thanks for your patch. I have tested the v7 patch. All the test is passed. Please add Tested-by: Zhang Lei My test environment is below. *QEMU base + v7 pathc base is 58560ad254 (origin/master, origin/HEAD, master) Merge remote-tracking branch

Re: [PULL 1/9] IDE: deprecate ide-drive

2019-10-31 Thread Paolo Bonzini
On 31/10/19 11:58, John Snow wrote: > It's an old compatibility shim that just delegates to ide-cd or ide-hd. > I'd like to refactor these some day, and getting rid of the super-object > will make that easier. > > Either way, we don't need this. Good idea. I will prepare a similar patch for

Re: [PATCH v5 11/13] hw/s390x/ipl: replace deprecated qdev_reset_all registration

2019-10-31 Thread Philippe Mathieu-Daudé
On 10/18/19 5:06 PM, Damien Hedde wrote: Replace deprecated qdev_reset_all by resettable_cold_reset_fn for the ipl registration in the main reset handlers. This does not impact the behavior for the following reasons: + at this point resettable just call the old reset methods of devices and

[PATCH 2/2] vhost-user-scsi: reset the device if supported

2019-10-31 Thread Raphael Norwitz
If the vhost-user-scsi backend supports the VHOST_USER_F_RESET_DEVICE protocol feature, then the device can be reset when requested. If this feature is not supported, do not try a reset as this will send a VHOST_USER_RESET_OWNER that the backend is not expecting, potentially putting into an

[PATCH] target/i386: return directly from hyperv_init_vcpu() if hyperv not enabled

2019-10-31 Thread Wei Yang
If hyperv is not enabled, related features are not set or enabled. No extra work to do, return directly. --- First time touch hyperv, hope my understanding is correct. Signed-off-by: Wei Yang --- target/i386/kvm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/i386/kvm.c

Re: [RFC PATCH 0/6] docs: integrate doc comments with Sphinx build

2019-10-31 Thread Paolo Bonzini
On 29/10/19 19:21, Peter Maydell wrote: > On Tue, 29 Oct 2019 at 16:22, Paolo Bonzini wrote: >> >> Hello, >> >> this is an attempt at including kernel-doc, with small tweaks (see patch >> 2) to support QEMU's doc comment format, in the Sphinx documentation >> pipeline. >> >> The ugly part is

Re: [PATCH 2/2] Acceptance test: update kernel for m68k/q800 test

2019-10-31 Thread Alex Bennée
Cleber Rosa writes: > There's an updated version of the Debian package containing the m68k > Kernel. > > Now, if the package gets updated again, the test won't fail, but will > be canceled. A more permanent solution is certainly needed. At least for open source blobs can't we do something

Re: [PATCH] tests: fix conditional for disabling XTS test

2019-10-31 Thread Alex Bennée
Daniel P. Berrangé writes: > The intent is to only enable the XTS test if both CONFIG_BLOCK > and CONFIG_QEMU_PRIVATE_XTS are set to 'y'. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Alex Bennée Tested-by: Alex Bennée > --- > tests/Makefile.include | 2 +- > 1 file changed, 1

[Bug 1850751] [NEW] kvm flag is not exposed by default

2019-10-31 Thread Leoyzen Liu
Public bug reported: Hi I found that the kvm flags is not exposed by default, but according to the source code, it should be exposed by default when the CPU Model is a X86CPU. we have to specifically add "kvm=on" in QEMU custom cpu args like this to make VMWare Timing and KVM-Clock work: Also

[PULL 1/9] IDE: deprecate ide-drive

2019-10-31 Thread John Snow
It's an old compatibility shim that just delegates to ide-cd or ide-hd. I'd like to refactor these some day, and getting rid of the super-object will make that easier. Either way, we don't need this. Signed-off-by: John Snow Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster ACKed-by:

[PULL 0/9] Ide patches

2019-10-31 Thread John Snow
The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: Merge remote-tracking branch 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 14:10:32 +) are available in the Git repository at: https://github.com/jnsnow/qemu.git

[PULL 3/9] block: Support providing LCHS from user

2019-10-31 Thread John Snow
From: Sam Eiderman Add logical geometry variables to BlockConf. A user can now supply "lcyls", "lheads" & "lsecs" for any HD device that supports CHS ("cyls", "heads", "secs"). These devices include: * ide-hd * scsi-hd * virtio-blk-pci In future commits we will use the provided

[PULL 6/9] bootdevice: Gather LCHS from all relevant devices

2019-10-31 Thread John Snow
From: Sam Eiderman Relevant devices are: * ide-hd (and ide-cd, ide-drive) * scsi-hd (and scsi-cd, scsi-disk, scsi-block) * virtio-blk-pci We do not call del_boot_device_lchs() for ide-* since we don't need to - IDE block devices do not support unplugging. Reviewed-by: Karl Heubaum

[PULL 2/9] block: Refactor macros - fix tabbing

2019-10-31 Thread John Snow
From: Sam Eiderman Fixing tabbing in block related macros. Signed-off-by: Sam Eiderman Signed-off-by: Sam Eiderman Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: John Snow --- include/hw/block/block.h | 16

[PULL 4/9] bootdevice: Add interface to gather LCHS

2019-10-31 Thread John Snow
From: Sam Eiderman Add an interface to provide direct logical CHS values for boot devices. We will use this interface in the next commits. Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Signed-off-by: Sam Eiderman Signed-off-by: Sam Eiderman Reviewed-by: Philippe Mathieu-Daudé

[PULL 7/9] bootdevice: Refactor get_boot_devices_list

2019-10-31 Thread John Snow
From: Sam Eiderman Move device name construction to a separate function. We will reuse this function in the following commit to pass logical CHS parameters through fw_cfg much like we currently pass bootindex. Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Reviewed-by: Philippe

[PULL 5/9] scsi: Propagate unrealize() callback to scsi-hd

2019-10-31 Thread John Snow
From: Sam Eiderman We will need to add LCHS removal logic to scsi-hd's unrealize() in the next commit. Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Sam Eiderman Signed-off-by: Sam Eiderman Tested-by: Philippe Mathieu-Daudé

[PULL 8/9] bootdevice: FW_CFG interface for LCHS values

2019-10-31 Thread John Snow
From: Sam Eiderman Using fw_cfg, supply logical CHS values directly from QEMU to the BIOS. Non-standard logical geometries break under QEMU. A virtual disk which contains an operating system which depends on logical geometries (consistent values being reported from BIOS INT13 AH=08) will most

[PULL 9/9] hd-geo-test: Add tests for lchs override

2019-10-31 Thread John Snow
From: Sam Eiderman Add QTest tests to check the logical geometry override option. The tests in hd-geo-test are out of date - they only test IDE and do not test interesting MBRs. Creating qcow2 disks with specific size and MBR layout is currently unused - we only use a default empty MBR.

Re: [PULL 0/3] a couple of CI fixes

2019-10-31 Thread Peter Maydell
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2 for any user-visible changes. -- PMM On Thu, 31 Oct 2019 at 10:02, Alex Bennée wrote: > > The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: > > Merge remote-tracking branch >

Re: RFC: New device for zero-copy VM memory access

2019-10-31 Thread geoff
Another update to this that adds support for unmap notification. The device has also been renamed to `porthole` and now resides here: https://github.com/gnif/qemu/blob/master/hw/misc/porthole.c And here is the updated Linux test client.

Re: [PATCH 1/2] Acceptance test: cancel test if m68k kernel packages goes missing

2019-10-31 Thread Alex Bennée
Cleber Rosa writes: > The Linux kernel that is extracted from a Debian package for the q800 > machine test is hosted on a "pool" location. AFAICT, it gets updated > without too much ceremony, and I don't see any archival location that > is stable enough. > > For now, to avoid test errors,

Re: [PATCH 2/2] Acceptance test: update kernel for m68k/q800 test

2019-10-31 Thread Alex Bennée
Cleber Rosa writes: > There's an updated version of the Debian package containing the m68k > Kernel. > > Now, if the package gets updated again, the test won't fail, but will > be canceled. A more permanent solution is certainly needed. > > Signed-off-by: Cleber Rosa Reviewed-by: Alex

Re: [PULL 0/1] Require Python >= 3.5 to build QEMU

2019-10-31 Thread Peter Maydell
On Fri, 25 Oct 2019 at 21:34, Eduardo Habkost wrote: > > The following changes since commit 03bf012e523ecdf047ac56b2057950247256064d: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2019-10-25 14:59:53 +0100) > > are available in the Git repository at: > >

Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-10-31 Thread Greg Kurz
On Wed, 30 Oct 2019 17:32:43 +0100 David Gibson wrote: > We have to set the default model of all machine classes, not just for the > active one. Otherwise, "query-machines" will indicate the wrong CPU model > ("qemu-s390x-cpu" instead of "host-s390x-cpu") as "default-cpu-type". > A PPC cpu

[PATCH v6 4/4] tests/vm: update netbsd to version 8.1

2019-10-31 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/vm/netbsd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vm/netbsd b/tests/vm/netbsd index d1bfd0..33779402dd 100755 --- a/tests/vm/netbsd +++ b/tests/vm/netbsd @@ -22,7 +22,7 @@ class NetBSDVM(basevm.BaseVM): name =

The problems about COLO

2019-10-31 Thread Daniel Cho
Hello all, I have some questions about the COLO. 1) Could we dynamic set fault tolerance feature on running VM? In your document, the primary VM could not start first (if you start primary VM, the secondary VM will need to start), it means to if I want this VM with fault-tolerance feature, it

Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-10-31 Thread Peter Maydell
On Wed, 30 Oct 2019 at 16:34, David Gibson wrote: > > We have to set the default model of all machine classes, not just for the > active one. Otherwise, "query-machines" will indicate the wrong CPU model > ("qemu-s390x-cpu" instead of "host-s390x-cpu") as "default-cpu-type". > > s390x already

Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-10-31 Thread Peter Maydell
On Thu, 31 Oct 2019 at 08:28, Peter Maydell wrote: > Isn't this a bug in libvirt ? The default CPU for one machine type > tells you nothing at all about the default machine for another CPU > type. Libvirt needs to ask about the default CPU for the machine > it's actually interested in, which is

  1   2   >