Re: [PATCH v1 0/2] TCG plugin doc updates

Patchew URL: https://patchew.org/QEMU/20191112164051.16404-1-alex.ben...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH v2 19/20] nvme: make lba data size configurable

On Tue, Nov 12, 2019 at 03:24:00PM +, Beata Michalska wrote: > Hi Klaus, > > On Tue, 15 Oct 2019 at 11:50, Klaus Jensen wrote: > > #define DEFINE_NVME_NS_PROPERTIES(_state, _props) \ > > -DEFINE_PROP_UINT32("nsid", _state, _props.nsid, 0) > > +DEFINE_PROP_UINT32("nsid", _state,

Re: [PATCH] enable translating statx syscalls on more arches

Le 12/11/2019 à 09:27, Aleksandar Markovic a écrit : > > > On Tuesday, November 12, 2019, Aleksandar Markovic > mailto:aleksandar.m.m...@gmail.com>> wrote: > > > > On Tuesday, November 12, 2019, Andrew Kelley > wrote: > > ping > > On

[PULL 1/5] Makefile: install bios-microvm like other binary blobs

From: Bruce Rogers Commit 0d5fae3e52e introduced bios-microvm.bin but forgot to add it to the list of blobs being installed. Add it to the list of BLOBS that get installed. Fixes: 0d5fae3e52e "roms: add microvm-bios (qboot) as binary" Signed-off-by: Bruce Rogers [PMD: Reworded description]

[PULL 2/5] qom: Fix error message in object_class_property_add()

From: Greg Kurz The error message in object_class_property_add() was copied from object_property_add() in commit 16bf7f522a2ff. Clarify that it is about a class, not an object. While here, have the format string in both functions to fit in a single line for better grep-ability, despite the

Re: [PULL v2 01/13] linux-user: Support for NETLINK socket options

Le 12/11/2019 à 11:11, Peter Maydell a écrit : > On Wed, 6 Nov 2019 at 13:07, Laurent Vivier wrote: >> >> From: Josh Kunz >> >> This change includes support for all AF_NETLINK socket options up to about >> kernel version 5.4 (5.4 is not formally released at the time of writing). >> Socket

Re: [PATCH] qemu-coroutine-sleep: Silence Coverity warning

On Tue, 12 Nov 2019 at 10:08, Vladimir Sementsov-Ogievskiy wrote: > > 11.11.2019 23:35, Eric Blake wrote: > > Coverity warns that we store the address of a stack variable through a > > pointer passed in by the caller, which would let the caller trivially > > trigger use-after-free if that stored

[PATCH] linux-user: fix missing break

Reported by Coverity (CID 1407221) Fixes: a2d866827bd8 ("linux-user: Support for NETLINK socket options") cc: Josh Kunz Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index

Re: API definition for LUKS key management

On Tue, Nov 12, 2019 at 10:12:45AM +0100, Kevin Wolf wrote: > Am 11.11.2019 um 19:34 hat Daniel P. Berrangé geschrieben: > > On Mon, Nov 11, 2019 at 05:58:20PM +0200, Maxim Levitsky wrote: > > > One of the concerns that was raised during the review was that amend > > > interface for luks that I

Re: [PATCH v2 00/11] RFC crypto/luks: encryption key managment using amend interface

On 08.11.19 16:07, Maxim Levitsky wrote: > On Fri, 2019-10-04 at 21:10 +0200, Max Reitz wrote: >> On 13.09.19 00:30, Maxim Levitsky wrote: >>> This patch series is continuation of my work to add encryption >>> key managment to luks/qcow2 with luks. >>> >>> This is second version of this patch set.

Re: [PATCH] Makefile: install bios-microvm like other binary blobs

Le 02/11/2019 à 12:43, Philippe Mathieu-Daudé a écrit : > From: Bruce Rogers > > Commit 0d5fae3e52e introduced bios-microvm.bin but forgot to add > it to the list of blobs being installed. > Add it to the list of BLOBS that get installed. > > Fixes: 0d5fae3e52e "roms: add microvm-bios (qboot)

Re: [PATCH] i386: define the 'flush_l1d' CPUID feature bit (CVE-2018-3646)

On Tue, Nov 12, 2019 at 03:50:43AM +, Kyle Copperfield via wrote: > New microcode introduces the "Flush L1D Cache" CPUID feature bit. > This needs to be exposed to guest OS to allow them to protect against > CVE-2018-3646. My understanding was that this is only required in the L0 hypervisor,

Re: [PATCH] qemu-coroutine-sleep: Silence Coverity warning

11.11.2019 23:35, Eric Blake wrote: > Coverity warns that we store the address of a stack variable through a > pointer passed in by the caller, which would let the caller trivially > trigger use-after-free if that stored value is still present when we > finish execution. However, the way

Re: [PULL 10/14] net/virtio: add failover support

On Tue, 29 Oct 2019 at 23:01, Michael S. Tsirkin wrote: > > From: Jens Freimann > > This patch adds support to handle failover device pairs of a virtio-net > device and a (vfio-)pci device, where the virtio-net acts as the standby > device and the (vfio-)pci device as the primary. Hi; Coverity

[PULL 5/5] ivshmem-server: Terminate also on SIGINT

From: Jan Kiszka Allows to shutdown a foreground session via ctrl-c. Signed-off-by: Jan Kiszka Reviewed-by: Claudio Fontana Reviewed-by: Stefano Garzarella Message-Id: <99c1a7bd-1876-66a2-4b8e-d5bc86116...@web.de> Signed-off-by: Laurent Vivier --- contrib/ivshmem-server/main.c | 5 +++-- 1

[Bug 1852196] [NEW] update edk2 submodule & binaries to edk2-stable201911

Public bug reported: edk2-stable201911 will be tagged soon: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release- Planning https://github.com/tianocore/edk2/releases/tag/edk2-stable201911 [upcoming link] It should be picked up by QEMU, after the v4.2.0 release. Relevant

Re: [PATCH qemu-web] Add a blog post on "Micro-Optimizing KVM VM-Exits"

On Fri, Nov 08, 2019 at 10:22:47AM +0100, Kashyap Chamarthy wrote: > +The proposal: "KVM Monolithic" > +-- > + > +Based on his investigation, Andrea proposed a patch series, ["KVM > +monolithc"](https://lwn.net/Articles/800870/), to get rid of the KVM

Re: [RFC v5 056/126] virtio-ccw: introduce ERRP_AUTO_PROPAGATE

On Fri, 11 Oct 2019 19:04:42 +0300 Vladimir Sementsov-Ogievskiy wrote: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == _err > (the program will exit prior to the

Re: API definition for LUKS key management

Am 11.11.2019 um 19:34 hat Daniel P. Berrangé geschrieben: > On Mon, Nov 11, 2019 at 05:58:20PM +0200, Maxim Levitsky wrote: > > One of the concerns that was raised during the review was that amend > > interface for luks that I propose is > > different from the amend inteface used currently for

Re: [PATCH v2] ivshmem-server: Terminate also on SIGINT

Le 08/11/2019 à 16:15, Markus Armbruster a écrit : > Jan Kiszka writes: > >> On 03.08.19 15:22, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> Allows to shutdown a foreground session via ctrl-c. >>> >>> Signed-off-by: Jan Kiszka >>> --- >>> >>> Changes in v2: >>> - adjust error message >>>

Re: [PATCH v2] ivshmem-server: Clean up shmem on shutdown

Le 08/11/2019 à 16:14, Markus Armbruster a écrit : > Jan Kiszka writes: > >> On 06.08.19 15:01, Claudio Fontana wrote: >>> On 8/5/19 7:54 AM, Jan Kiszka wrote: From: Jan Kiszka So far, the server leaves the posix shared memory object behind when terminating, requiring the

Re: API definition for LUKS key management

On Mon, Nov 11, 2019 at 05:58:20PM +0200, Maxim Levitsky wrote: > I will try to explain the interface with bunch of examples: I want to fill in equiv examples from cryptsetup for sake of comparison > # adds a new password, defined by qemu secret 'sec0' to first unused slot > # give user a error

Re: [PULL 04/11] target/arm/cpu64: max cpu: Introduce sve properties

On Fri, 1 Nov 2019 at 08:51, Peter Maydell wrote: > > From: Andrew Jones > > Introduce cpu properties to give fine control over SVE vector lengths. > We introduce a property for each valid length up to the current > maximum supported, which is 2048-bits. The properties are named, e.g. > sve128,

Re: API definition for LUKS key management

On 12.11.19 10:12, Kevin Wolf wrote: > Am 11.11.2019 um 19:34 hat Daniel P. Berrangé geschrieben: >> On Mon, Nov 11, 2019 at 05:58:20PM +0200, Maxim Levitsky wrote: >>> One of the concerns that was raised during the review was that amend >>> interface for luks that I propose is >>> different from

Re: [PATCH] i386: define the 'flush_l1d' CPUID feature bit (CVE-2018-3646)

Patchew URL: https://patchew.org/QEMU/20191112035043.54600-1-kmcop...@danwin1210.me/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [qemu-web PATCH v3] documentation: link to nightly documentation

On 08/11/2019 11.54, Stefan Hajnoczi wrote: > Link to the documentation built from qemu.git/master once a day. > > Signed-off-by: Stefan Hajnoczi > --- > v3: > * Use a qemu.org URL, not a wiki.qemu.org URL [danpb] > v2: > * This revision was broken - please ignore! :) > --- > documentation.md

Re: [PULL 0/6] qtest and misc patches

On Tue, 12 Nov 2019 at 06:43, Thomas Huth wrote: > > Hi Peter, > > the following changes since commit 654efcb511d394c1d3f5292c28503d1d19e5b1d3: > > Merge remote-tracking branch 'remotes/vivier/tags/q800-branch-pull-request' > into staging (2019-11-11 09:23:46 +) > > are available in the

Re: [RFC v5 015/126] hw/s390x: rename Error ** parameter to more common errp

On Fri, 11 Oct 2019 19:04:01 +0300 Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > hw/s390x/event-facility.c | 2 +- > hw/s390x/s390-stattrib.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) Does not hurt, I guess. Reviewed-by: Cornelia

Re: [PATCH 5/5] hw/arm/virt: Add nvdimm hotplug support

On Fri, 4 Oct 2019 16:53:02 +0100 Shameer Kolothum wrote: > This adds support for nvdimm hotplug events through GED > and enables nvdimm for the arm/virt. Now Guests with DT boot > can have nvdimm cold plug and with ACPI both cold/hot plug. > > Hot removal functionality is not yet supported. >

Re: virtio,iommu_platform=on

On 11/12/19 04:53, Alexey Kardashevskiy wrote: > Hi! > > I am enabling IOMMU for virtio in the pseries firmware (SLOF) and seeing > problems, one of them is SLOF does SCSI bus scan, then it stops the > virtio-scsi by clearing MMIO|IO|BUSMASTER from PCI_COMMAND (as SLOF > stopped using the

Re: [PATCH] numa: Add missing \n to error message

Le 06/11/2019 à 13:46, Greg Kurz a écrit : > If memory allocation fails when using -mem-path, QEMU is supposed to print > out a message to indicate that fallback to anonymous RAM is deprecated. This > is done with error_printf() which does output buffering. As a consequence, > the message is only

Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

On Wed, Oct 23, 2019 at 05:28:17PM -0400, Michael S. Tsirkin wrote: > On Fri, Oct 18, 2019 at 02:55:47PM +0300, Denis Plotnikov wrote: > > From: "Denis V. Lunev" > > > > Linux guests submit IO requests no longer than PAGE_SIZE * max_seg > > field reported by SCSI controler. Thus typical

[PATCH v3 1/2] virtio: make seg_max virtqueue size dependent

Before the patch, seg_max parameter was immutable and hardcoded to 126 (128 - 2) without respect to queue size. This has two negative effects: 1. when queue size is < 128, we have Virtio 1.1 specfication violation: (2.6.5.3.1 Driver Requirements) seq_max must be <= queue_size. This

[PATCH v3 0/2] virtio: make seg_max virtqueue size dependent

v3: * add property to set in machine type [MST] * add min queue size check [Stefan] * add avocado based test [Max, Stefan, Eduardo, Cleber] v2: * the standalone patch to make seg_max virtqueue size dependent * other patches are postponed v1: the initial series Denis Plotnikov (2):

[PATCH v3 2/2] tests: add virtio-scsi and virtio-blk seg_max_adjust test

It tests proper seg_max_adjust settings for all machine types except 'none', 'isapc', 'microvm' Signed-off-by: Denis Plotnikov --- tests/acceptance/virtio_seg_max_adjust.py | 135 ++ 1 file changed, 135 insertions(+) create mode 100755

[PATCH v3 3/8] blockdev: place drive_backup_prepare with the other related transaction functions

Move drive_backup_prepare() to be side by side with the other related transaction helper functions. Signed-off-by: Sergio Lopez --- blockdev.c | 247 +++-- 1 file changed, 125 insertions(+), 122 deletions(-) diff --git a/blockdev.c b/blockdev.c

Re: [qemu-web PATCH] Add device fuzzing blog post

On 07/11/2019 16.48, Stefan Hajnoczi wrote: > On Thu, Nov 7, 2019 at 10:43 AM Thomas Huth wrote: >> >> - Original Message - >>> From: "Stefan Hajnoczi" >>> Sent: Thursday, November 7, 2019 10:11:36 AM >>> >>> This blog post covers the device fuzzing GSoC project that Alexander >>> Olenik

[Bug 1852115] Re: qemu --static user build fails with fedora rawhide glibc-2.30.9000

We use stime() to implement the target stime syscall. We should probably switch to using clock_settime(CLOCK_REALTIME, ...) instead, as that's what glibc uses internally now to implement its stime():

Re: [PATCH qemu-web] Add a blog post on "Micro-Optimizing KVM VM-Exits"

[Cc: Rich Jones, addressing his feedback on IRC, below.] On Fri, Nov 08, 2019 at 10:22:47AM +0100, Kashyap Chamarthy wrote: > This blog post summarizes the talk "Micro-Optimizing KVM VM-Exits"[1], > given by Andrea Arcangeli at the recently concluded KVM Forum 2019. > > [1] >

[PULL 3/5] numa: Add missing \n to error message

From: Greg Kurz If memory allocation fails when using -mem-path, QEMU is supposed to print out a message to indicate that fallback to anonymous RAM is deprecated. This is done with error_printf() which does output buffering. As a consequence, the message is only printed at the next flush, eg.

[PULL 0/5] Trivial branch patches

for you to fetch changes up to 5c62979ed5f75976ae215098566ebd93dfe4e22a: ivshmem-server: Terminate also on SIGINT (2019-11-12 10:37:20 +0100) Trivial fixes (20191112) ivshmem-server, error messages (numa, qom) and Makefile (bios

Re: [PATCH v6 1/3] block: introduce compress filter driver

12.11.2019 13:07, Andrey Shinkevich wrote: > On 12/11/2019 12:39, Kevin Wolf wrote: >> Am 11.11.2019 um 17:04 hat Andrey Shinkevich geschrieben: >>> Allow writing all the data compressed through the filter driver. >>> The written data will be aligned by the cluster size. >>> Based on the QEMU

[PATCH v3 1/8] blockdev: merge drive_backup_prepare with do_drive_backup

Consolidate drive_backup_prepare() with do_drive_backup() as a first step towards streamlining all functionality through transactions. Signed-off-by: Sergio Lopez --- blockdev.c | 58 +++--- 1 file changed, 16 insertions(+), 42 deletions(-) diff

[PATCH v3 6/8] blockdev: place blockdev_backup_prepare with the other related transaction helpers

Move blockdev_backup_prepare() to be side by side with the other related transaction helper functions. Signed-off-by: Sergio Lopez --- blockdev.c | 70 +++--- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/blockdev.c b/blockdev.c

[PATCH v3 0/8] blockdev: avoid acquiring AioContext lock twice at do_drive_backup and do_blockdev_backup

do_drive_backup() acquires the AioContext lock of the corresponding BlockDriverState. This is not a problem when it's called from qmp_drive_backup(), but drive_backup_prepare() also acquires the lock before calling it. The same things happens with do_blockdev_backup() and

Re: [PATCH v2 00/11] RFC crypto/luks: encryption key managment using amend interface

On Tue, 2019-11-12 at 12:58 +0100, Max Reitz wrote: > On 08.11.19 16:07, Maxim Levitsky wrote: > > On Fri, 2019-10-04 at 21:10 +0200, Max Reitz wrote: > > > On 13.09.19 00:30, Maxim Levitsky wrote: > > > > This patch series is continuation of my work to add encryption > > > > key managment to

Re: [RFC v5 023/126] hw/vfio/ap: drop local_err from vfio_ap_realize

On Fri, 11 Oct 2019 19:04:09 +0300 Vladimir Sementsov-Ogievskiy wrote: > No reason for local_err here, use errp directly instead. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > hw/vfio/ap.c | 16 +++- > 1 file changed, 3 insertions(+), 13 deletions(-) > > diff --git

Re: [RFC v5 037/126] S390 Machines: introduce ERRP_AUTO_PROPAGATE

On Fri, 11 Oct 2019 19:04:23 +0300 Vladimir Sementsov-Ogievskiy wrote: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == _err > (the program will exit prior to the

Re: [PATCH v6 1/3] block: introduce compress filter driver

11.11.2019 19:04, Andrey Shinkevich wrote: > Allow writing all the data compressed through the filter driver. > The written data will be aligned by the cluster size. > Based on the QEMU current implementation, that data can be written to > unallocated clusters only. May be used for a backup job. >

Re: [PATCH v3 0/2] virtio: make seg_max virtqueue size dependent

On Tue, Nov 12, 2019 at 02:13:52PM +0300, Denis Plotnikov wrote: > v3: > * add property to set in machine type [MST] > * add min queue size check [Stefan] > * add avocado based test [Max, Stefan, Eduardo, Cleber] > > v2: > * the standalone patch to make seg_max virtqueue size dependent >

Re: [RFC PATCH 16/18] qapi: Create 'pragma' module

Kevin Wolf writes: > We want to share the whitelists between the system emulator schema and > the storage daemon schema, so move all the pragmas from the main schema > file into a separate file that can be included from both. Confusing because the storage daemon schema doesn't exist at this

Re: [PULL 11/14] vfio: unplug failover primary device before migration

On Tue, 29 Oct 2019 at 23:01, Michael S. Tsirkin wrote: > > From: Jens Freimann > > As usual block all vfio-pci devices from being migrated, but make an > exception for failover primary devices. This is achieved by setting > unmigratable to 0 but also add a migration blocker for all vfio-pci >

Re: [PULL 20/39] hw/i386: Introduce the microvm machine type

On Thu, 24 Oct 2019 at 16:19, Paolo Bonzini wrote: > > From: Sergio Lopez > > microvm is a machine type inspired by Firecracker and constructed > after its machine model. > > It's a minimalist machine type without PCI nor ACPI support, designed > for short-lived guests. microvm also establishes

Re: [PULL 20/39] hw/i386: Introduce the microvm machine type

Peter Maydell writes: > On Thu, 24 Oct 2019 at 16:19, Paolo Bonzini wrote: >> >> From: Sergio Lopez >> >> microvm is a machine type inspired by Firecracker and constructed >> after its machine model. >> >> It's a minimalist machine type without PCI nor ACPI support, designed >> for

Re: [PATCH] pl031: Expose RTCICR as proper WC register

On Tue, 12 Nov 2019 at 07:28, Alexander Graf wrote: > > Hey Peter, > > On 08.11.19 17:58, Peter Maydell wrote: > > Did you find this because you had a guest that assumed the > > other behaviour? This bug has been in QEMU for a very long time, > > and it seems odd for a guest to deliberately

Re: [RFC v5 028/126] s390x: introduce ERRP_AUTO_PROPAGATE

On Fri, 11 Oct 2019 19:04:14 +0300 Vladimir Sementsov-Ogievskiy wrote: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == _err > (the program will exit prior to the

Re: [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git

On 12/11/19 04:45, Alexey Kardashevskiy wrote: > Recent git versions support worktrees where .git is not a directory but > a file with a path to the .git repository; however the get_maintainer.pl > script only recognises the .git directory, let's fix it. > > Signed-off-by: Alexey Kardashevskiy >

Re: [PATCH v6 1/3] block: introduce compress filter driver

Am 11.11.2019 um 17:04 hat Andrey Shinkevich geschrieben: > Allow writing all the data compressed through the filter driver. > The written data will be aligned by the cluster size. > Based on the QEMU current implementation, that data can be written to > unallocated clusters only. May be used for

Re: [PATCH] qemu-coroutine-sleep: Silence Coverity warning

On Mon, 11 Nov 2019 at 20:35, Eric Blake wrote: > > Coverity warns that we store the address of a stack variable through a > pointer passed in by the caller, which would let the caller trivially > trigger use-after-free if that stored value is still present when we > finish execution. However,

[PULL 4/5] ivshmem-server: Clean up shmem on shutdown

From: Jan Kiszka So far, the server leaves the posix shared memory object behind when terminating, requiring the user to explicitly remove it in order to start a new instance. Signed-off-by: Jan Kiszka Reviewed-by: Claudio Fontana Message-Id: Signed-off-by: Laurent Vivier ---

Re: [PATCH v6 1/3] block: introduce compress filter driver

On 12/11/2019 12:39, Kevin Wolf wrote: > Am 11.11.2019 um 17:04 hat Andrey Shinkevich geschrieben: >> Allow writing all the data compressed through the filter driver. >> The written data will be aligned by the cluster size. >> Based on the QEMU current implementation, that data can be written to

Re: [PULL v2 01/13] linux-user: Support for NETLINK socket options

On Wed, 6 Nov 2019 at 13:07, Laurent Vivier wrote: > > From: Josh Kunz > > This change includes support for all AF_NETLINK socket options up to about > kernel version 5.4 (5.4 is not formally released at the time of writing). > Socket options that were introduced in kernel versions before the

Re: [PATCH] i386: define the 'flush_l1d' CPUID feature bit (CVE-2018-3646)

On 12/11/19 10:51, Daniel P. Berrangé wrote: > On Tue, Nov 12, 2019 at 03:50:43AM +, Kyle Copperfield via wrote: >> New microcode introduces the "Flush L1D Cache" CPUID feature bit. >> This needs to be exposed to guest OS to allow them to protect against >> CVE-2018-3646. > > My understanding

[PATCH] hw: add compat machines for 5.0

Add 5.0 machine types for arm/i440fx/q35/s390x/spapr. For i440fx and q35, unversioned cpu models are still translated to -v1; I'll leave changing this (if desired) to the respective maintainers. Signed-off-by: Cornelia Huck --- also pushed out to https://github.com/cohuck/qemu machine-5.0 x86

[PATCH v3 4/8] blockdev: change qmp_drive_backup to make use of transactions

Change qmp_drive_backup() to create and start a transaction instead of calling do_drive_backup directly. Signed-off-by: Sergio Lopez --- blockdev.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/blockdev.c b/blockdev.c index b32855f702..5e85fc042e 100644 ---

[PATCH v3 2/8] blockdev: fix coding style issues in drive_backup_prepare

Fix a couple of minor coding style issues in drive_backup_prepare. Signed-off-by: Sergio Lopez --- blockdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 5d30aff1e5..e8b673c5f3 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3592,7

[PATCH v3 7/8] blockdev: change qmp_blockdev_backup to make use of transactions

Change qmp_blockdev_backup() to create and start a transaction instead of calling do_blockdev_backup() directly. Signed-off-by: Sergio Lopez --- blockdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/blockdev.c b/blockdev.c index f94aaa98f0..152a0f7454

Re: [RFC v5 030/126] kvm: introduce ERRP_AUTO_PROPAGATE

On Fri, 11 Oct 2019 19:04:16 +0300 Vladimir Sementsov-Ogievskiy wrote: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == _err > (the program will exit prior to the

Re: [PATCH 1/5] MAINTAINERS: Add a section on git infrastructure

On Tuesday, November 12, 2019, Alex Bennée wrote: > > Aleksandar Markovic writes: > > > From: Aleksandar Markovic > > > > There should be a patient person maintaining gory details of > > git-related files, and there is no better person for that role > > than Philippe. Alex should be the

Re: [PATCH] WHPX: refactor load library

On Tue, Nov 12, 2019 at 06:42:00PM +, Sunil Muthuswamy wrote: > > > > -Original Message- > > From: Sunil Muthuswamy > > Sent: Friday, November 8, 2019 12:32 PM > > To: 'Paolo Bonzini' ; 'Richard Henderson' > > ; 'Eduardo Habkost' ; 'Stefan > > Weil' > > Cc: 'qemu-devel@nongnu.org'

Re: [PATCH for 4.2 v1 1/1] riscv/virt: Increase flash size

On Mon, Nov 11, 2019 at 7:30 AM Bin Meng wrote: > > On Thu, Nov 7, 2019 at 8:54 AM Alistair Francis > wrote: > > > > Coreboot developers have requested that they have at least 32MB of flash > > to load binaries. We currently have 32MB of flash, but it is split in > > two to allow loading two

Re: [PATCH v4 15/20] fuzz: add fuzzer skeleton

On 11/7/19 7:55 AM, Stefan Hajnoczi wrote: On Wed, Oct 30, 2019 at 02:50:00PM +, Oleinik, Alexander wrote: diff --git a/tests/fuzz/fuzz.c b/tests/fuzz/fuzz.c new file mode 100644 index 00..0e38f81c48 --- /dev/null +++ b/tests/fuzz/fuzz.c @@ -0,0 +1,177 @@ +/* + * fuzzing driver + *

Re: [PATCH v1 3/5] Add use of RCU for qemu_logfile.

On Tue, 12 Nov 2019 at 12:36, Alex Bennée wrote: > > > > } > > +atomic_rcu_set(_logfile, logfile); > > } > > -qemu_mutex_unlock(_logfile_mutex); > > +logfile = qemu_logfile; > > Isn't this read outside of the protection of both rcu_read_lock() and > the mutex? Could

Re: [PATCH v14 03/11] tests: Add test for QAPI builtin type time

On Fri, Nov 08, 2019 at 09:05:52AM +0100, Markus Armbruster wrote: > Tao Xu writes: > > > On 11/7/2019 9:31 PM, Eduardo Habkost wrote: > >> On Thu, Nov 07, 2019 at 02:24:52PM +0800, Tao Xu wrote: > >>> On 11/7/2019 4:53 AM, Eduardo Habkost wrote: > On Mon, Oct 28, 2019 at 03:52:12PM +0800,

Re: [PATCH] qom: Fix error message in object_class_property_add()

Le 05/11/2019 à 15:05, Laurent Vivier a écrit : > Le 04/11/2019 à 14:23, Greg Kurz a écrit : >> The error message in object_class_property_add() was copied from >> object_property_add() in commit 16bf7f522a2ff. Clarify that it is >> about a class, not an object. >> >> While here, have the format

Re: [PATCH] qemu-coroutine-sleep: Silence Coverity warning

Eric Blake writes: > Coverity warns that we store the address of a stack variable through a > pointer passed in by the caller, which would let the caller trivially > trigger use-after-free if that stored value is still present when we > finish execution. However, the way coroutines work is

[PATCH v3 8/8] blockdev: honor bdrv_try_set_aio_context() context requirements

bdrv_try_set_aio_context() requires that the old context is held, and the new context is not held. Fix all the occurrences where it's not done this way. Suggested-by: Max Reitz Signed-off-by: Sergio Lopez --- blockdev.c | 67 ++ 1 file

[PATCH v3 5/8] blockdev: merge blockdev_backup_prepare with do_blockdev_backup

Consolidate blockdev_backup_prepare() with do_blockdev_backup() as a first step towards streamlining all functionality through transactions. Signed-off-by: Sergio Lopez --- blockdev.c | 64 +- 1 file changed, 15 insertions(+), 49 deletions(-)

Re: [RFC v5 026/126] python: add commit-per-subsystem.py

On Fri, 11 Oct 2019 19:04:12 +0300 Vladimir Sementsov-Ogievskiy wrote: > Add script to automatically commit tree-wide changes per-subsystem. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- I think this still needs some notes as to the supposed usage.

Re: [RFC v5 051/126] vfio-ccw: introduce ERRP_AUTO_PROPAGATE

On Fri, 11 Oct 2019 19:04:37 +0300 Vladimir Sementsov-Ogievskiy wrote: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == _err > (the program will exit prior to the

Re: [PATCH v4 01/20] softmmu: split off vl.c:main() into main.c

On 11/5/19 11:41 AM, Darren Kenny wrote: On Wed, Oct 30, 2019 at 02:49:48PM +, Oleinik, Alexander wrote: From: Alexander Oleinik A program might rely on functions implemented in vl.c, but implement its own main(). By placing main into a separate source file, there are no complaints about

Re: [PATCH v1 1/2] docs/devel: rename plugins.rst to tcg-plugins.rst

On Tue, 12 Nov 2019 at 16:42, Alex Bennée wrote: > > This makes it a bit clearer what this is about. > > Signed-off-by: Alex Bennée > --- > MAINTAINERS | 1 + > docs/devel/{plugins.rst => tcg-plugins.rst} | 0 > 2 files changed, 1 insertion(+) > rename

Re: [PATCH v1 2/5] qemu_log_lock/unlock now preserves the qemu_logfile handle.

Robert Foley writes: > qemu_log_lock() now returns a handle and qemu_log_unlock() receives a > handle to unlock. This allows for changing the handle during logging > and ensures the lock() and unlock() are for the same file. > > Signed-off-by: Robert Foley > --- > v1 > - Moved this up in

[PATCH v9 Kernel 1/5] vfio: KABI for migration interface for device state

- Defined MIGRATION region type and sub-type. - Used 3 bits to define VFIO device states. Bit 0 => _RUNNING Bit 1 => _SAVING Bit 2 => _RESUMING Combination of these bits defines VFIO device's state during migration _RUNNING => Normal VFIO device running state. When its reset,

[PATCH v9 Kernel 2/5] vfio iommu: Add ioctl defination to get dirty pages bitmap.

All pages pinned by vendor driver through vfio_pin_pages API should be considered as dirty during migration. IOMMU container maintains a list of all such pinned pages. Added an ioctl defination to get bitmap of such pinned pages for requested IO virtual address range. Signed-off-by: Kirti

[PATCH v9 QEMU 08/15] vfio: Add VM state change handler to know state of VM

VM state change handler gets called on change in VM's state. This is used to set VFIO device state to _RUNNING. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia --- hw/vfio/migration.c | 69 +++ hw/vfio/trace-events | 2 ++

[PATCH v9 QEMU 04/15] vfio: Add function to unmap VFIO region

This function will be used for migration region. Migration region is mmaped when migration starts and will be unmapped when migration is complete. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia Reviewed-by: Cornelia Huck --- hw/vfio/common.c | 20

[PATCH v9 QEMU 14/15] vfio: Add ioctl to get dirty pages bitmap during dma unmap.

With vIOMMU, IO virtual address range can get unmapped while in pre-copy phase of migration. In that case, unmap ioctl should return pages pinned in that range and QEMU should find its correcponding guest physical addresses and report those dirty. Note: This patch is not yet tested. I'm trying to

[PATCH v9 QEMU 09/15] vfio: Add migration state change notifier

Added migration state change notifier to get notification on migration state change. These states are translated to VFIO device state and conveyed to vendor driver. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia --- hw/vfio/migration.c | 28

Re: [PATCH v7 3/8] Acceptance tests: use avocado tags for machine type

On 11/11/19 10:49 PM, Cleber Rosa wrote: On Fri, Nov 08, 2019 at 02:20:45PM +0100, Philippe Mathieu-Daudé wrote: @@ -310,7 +302,7 @@ class BootLinuxConsole(Test): def test_arm_emcraft_sf2(self): """ :avocado: tags=arch:arm -:avocado: tags=machine:emcraft_sf2

RE: [PATCH] WHPX: refactor load library

> -Original Message- > From: Sunil Muthuswamy > Sent: Friday, November 8, 2019 12:32 PM > To: 'Paolo Bonzini' ; 'Richard Henderson' > ; 'Eduardo Habkost' ; 'Stefan > Weil' > Cc: 'qemu-devel@nongnu.org' ; Justin Terry (VM) > > Subject: [PATCH] WHPX: refactor load library > > This

[PATCH v1 1/2] docs/devel: rename plugins.rst to tcg-plugins.rst

This makes it a bit clearer what this is about. Signed-off-by: Alex Bennée --- MAINTAINERS | 1 + docs/devel/{plugins.rst => tcg-plugins.rst} | 0 2 files changed, 1 insertion(+) rename docs/devel/{plugins.rst => tcg-plugins.rst} (100%) diff --git a/MAINTAINERS

[PATCH v1 2/2] docs/devel: update tcg-plugins.rst with API versioning details

Signed-off-by: Alex Bennée --- docs/devel/tcg-plugins.rst | 16 1 file changed, 16 insertions(+) diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst index b18fb6729e3..8d619fd44ef 100644 --- a/docs/devel/tcg-plugins.rst +++ b/docs/devel/tcg-plugins.rst @@ -25,6

[PATCH v1 0/2] TCG plugin doc updates

Hi, A few minor tweaks to the TCG plugin documentation. Alex Bennée (2): docs/devel: rename plugins.rst to tcg-plugins.rst docs/devel: update tcg-plugins.rst with API versioning details MAINTAINERS | 1 + docs/devel/{plugins.rst => tcg-plugins.rst} | 16

Re: [PATCH v2] s390x: Properly fetch the short psw on diag308 subc 0/1

> Am 12.11.2019 um 17:58 schrieb Cornelia Huck : > > On Mon, 11 Nov 2019 10:28:08 -0500 > Janosch Frank wrote: > >> We need to actually fetch the cpu mask and set it. As we invert the >> short psw indication in the mask, SIE will report a specification >> exception, if it wasn't present in

Re: [PATCH v1 1/5] Add a mutex to guarantee single writer to qemu_logfile handle.

Robert Foley writes: > Also added qemu_logfile_init() for initializing the logfile mutex. > > Signed-off-by: Robert Foley Reviewed-by: Alex Bennée > --- > v1 > - changed qemu_logfile_init() to use __constructor__. > --- > util/log.c | 14 ++ > 1 file changed, 14

[PATCH v9 Kernel 5/5] vfio iommu: Implementation of ioctl to get dirty bitmap before unmap

If pages are pinned by external interface for requested IO virtual address range, bitmap of such pages is created and then that range is unmapped. To get bitmap during unmap, user should set flag VFIO_DMA_UNMAP_FLAG_GET_DIRTY_BITMAP, bitmap memory should be allocated and bitmap_size should be set.

[PATCH v9 Kernel 4/5] vfio iommu: Implementation of ioctl to get dirty pages bitmap.

IOMMU container maintains list of external pinned pages. Bitmap of pinned pages for input IO virtual address range is created and returned. IO virtual address range should be from a single mapping created by map request. Input bitmap_size is validated by calculating the size of requested range.

[PATCH v9 QEMU 03/15] vfio iommu: Add ioctl defination to unmap IOVA and return dirty bitmap

With vIOMMU, during pre-copy phase of migration, while CPUs are still running, IO virtual address unmap can happen while device still keeping reference of guest pfns. Those pages should be reported as dirty before unmap, so that VFIO user space application can copy content of those pages from

[PATCH v9 QEMU 15/15] vfio: Make vfio-pci device migration capable.

If device is not failover primary device call vfio_migration_probe() and vfio_migration_finalize() functions for vfio-pci device to enable migration for vfio PCI device which support migration. Removed vfio_pci_vmstate structure. Removed migration blocker from VFIO PCI device specific structure

  1   2   3   >