Re: [PATCH v2] linux-user/strace: Improve output of various syscalls

2019-11-21 Thread Helge Deller
On 20.11.19 23:20, Aleksandar Markovic wrote: > On Wed, Nov 20, 2019 at 10:13 PM Aleksandar Markovic > wrote: >> >> On Wed, Nov 20, 2019 at 3:58 PM Helge Deller wrote: >>> >>> Improve strace output of various syscalls which either have none >>> or only int-type parameters. >> >> It would be nice

Re: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project

2019-11-21 Thread Richard Henderson
On 11/21/19 7:01 AM, Aleksandar Markovic wrote: > On Wed, Nov 20, 2019 at 8:49 AM Richard Henderson > wrote: >> > >> How's that? He has been asked to split the linux-user stuff from the target >> skeleton stuff. > > ... > >> This argument would make more sense if there were more present here

[Bug 1853429] [NEW] qemu-kvm on aarch64 attach volume failed when vm is booting

2019-11-21 Thread Spencer Yu
Public bug reported: I use libvirt and qemu-kvm on aarch64 platform to attach volume to a booting vm,when the system of vm has not boot up, attach volume will be failed, after vm system booting up, attach volume can be successful. libvirt: 4.5.0 qemu : 2.12.0 console log and qemu command of vm

[Bug 1853429] Re: qemu-kvm on aarch64 attach volume failed when vm is booting

2019-11-21 Thread Spencer Yu
** Attachment added: "aarch64虚机系统未启动挂载盘console log.txt" https://bugs.launchpad.net/qemu/+bug/1853429/+attachment/5306839/+files/aarch64%E8%99%9A%E6%9C%BA%E7%B3%BB%E7%BB%9F%E6%9C%AA%E5%90%AF%E5%8A%A8%E6%8C%82%E8%BD%BD%E7%9B%98console%20log.txt -- You received this bug notification because you

Re: [PATCH for-5.0 v5 11/23] ppc/pnv: Introduce a pnv_xive_is_cpu_enabled() helper

2019-11-21 Thread Greg Kurz
On Thu, 21 Nov 2019 10:16:14 +0100 Cédric Le Goater wrote: > On 21/11/2019 08:58, Greg Kurz wrote: > > On Wed, 20 Nov 2019 22:40:31 +0100 > > Cédric Le Goater wrote: > > > >> On 20/11/2019 18:26, Greg Kurz wrote: > >>> On Fri, 15 Nov 2019 17:24:24 +0100 > >>> Cédric Le Goater wrote: > >>> >

[PULL 3/3] ui/gtk: fix gettext message's charset.

2019-11-21 Thread Gerd Hoffmann
From: yanminhui Signed-off-by: yanminhui Message-Id: <20191116031037.1207-1-yanminhui...@163.com> Signed-off-by: Gerd Hoffmann --- ui/gtk.c| 1 + po/zh_CN.po | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index 2f23922afc6a..692ccc7bbb90 100644

[PULL 2/3] display: xlnx_dp: Provide sufficient bytes for silent audio channel

2019-11-21 Thread Gerd Hoffmann
From: Sai Pavan Boddu Fill the audio channel with required number of bytes to cover the elapsed time. This prevents rate control reset, and avoids debug prints like below log: Resetting rate control (65692 samples) ... Resetting rate control (65721 samples) ...

Re: [PATCH 2/5] hw/ppc/pnv_xscom: PBA bar mask values are incorrect with homer/occ sizes

2019-11-21 Thread Balamuruhan S
On Wed, Nov 20, 2019 at 08:18:38AM +0100, Cédric Le Goater wrote: > On 19/11/2019 18:50, Balamuruhan S wrote: > > homer/occ sizes are calculated in skiboot with `(mask | 0xf) + 1`, > > and from xscom access should return correct mask values instead of actual > > sizes. > > > > Signed-off-by:

Re: [PATCH v2 2/6] block: truncate: Don't make backing file data visible

2019-11-21 Thread Vladimir Sementsov-Ogievskiy
21.11.2019 11:59, Max Reitz wrote: > On 20.11.19 19:44, Kevin Wolf wrote: >> When extending the size of an image that has a backing file larger than >> its old size, make sure that the backing file data doesn't become >> visible in the guest, but the added area is properly zeroed out. >> >>

Re: [PATCH v2 6/6] iotests: Test committing to short backing file

2019-11-21 Thread Vladimir Sementsov-Ogievskiy
20.11.2019 21:45, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf Hmm, allocating 7G will break tests on small disks, for example, on my 2G tmpfs. So, we probably should detect "+qemu-img: Failed to resize underlying file: Could not write zeros for preallocation: No space left on device" errors

Re: [PATCH v2 6/6] iotests: Test committing to short backing file

2019-11-21 Thread Vladimir Sementsov-Ogievskiy
21.11.2019 0:27, Eric Blake wrote: > On 11/20/19 12:45 PM, Kevin Wolf wrote: >> Signed-off-by: Kevin Wolf >> --- >>   tests/qemu-iotests/274    | 141 + >>   tests/qemu-iotests/274.out    | 227 ++ >>   tests/qemu-iotests/group  |   1 + >>

Re: [PATCH for-5.0 v5 15/23] ppc/xive: Use the XiveFabric and XivePresenter interfaces

2019-11-21 Thread Greg Kurz
On Thu, 21 Nov 2019 10:22:38 +0100 Cédric Le Goater wrote: > On 21/11/2019 09:08, Greg Kurz wrote: > > On Thu, 21 Nov 2019 08:40:32 +0100 > > Cédric Le Goater wrote: > > > >> On 21/11/2019 08:30, Greg Kurz wrote: > >>> On Thu, 21 Nov 2019 08:01:44 +0100 > >>> Cédric Le Goater wrote: > >>> >

Re: [PATCH] ui/gtk: fix gettext message's charset.

2019-11-21 Thread Gerd Hoffmann
On Thu, Nov 21, 2019 at 10:30:38AM +0800, yanminhui163 wrote: > I had compiled on NeoKylin (i18n LANG=zh_CN.UTF-8), but gtk menu's text is > wrong. Please keep the qemu-devel mailing list Cc'ed (reply-to-all should do this). So qemu doesn't do a full locate setup, to avoid confusing non-gtk

[PULL 1/3] audio: fix audio recording

2019-11-21 Thread Gerd Hoffmann
From: Volker Rümelin With current code audio recording with all audio backends except PulseAudio and DirectSound is broken. The generic audio recording buffer management forgot to update the current read position after a read. Fixes: ff095e5231 "audio: api for mixeng code free backends"

Re: [PATCH 1/5] hw/ppc/pnv: incorrect homer and occ common area size

2019-11-21 Thread Balamuruhan S
On Wed, Nov 20, 2019 at 08:13:50AM +0100, Cédric Le Goater wrote: > On 19/11/2019 18:50, Balamuruhan S wrote: > > Homer size is 4MB and OCC common area size is 8MB, but currently > > it is assigned with bar mask value. Also pass on the occ sram > > size 3 bits right shifted to initialize the size

Re: [PATCH 4/5] hw/ppc/pnv_xscom: occ common area to be mapped only once

2019-11-21 Thread Balamuruhan S
On Wed, Nov 20, 2019 at 08:30:03AM +0100, Cédric Le Goater wrote: > On 19/11/2019 18:50, Balamuruhan S wrote: > > occ common area should be mapped once > > It's the same address on each chip. > > the question is how the HW knows from which chip the OCC access is > being done ? How does it

Re: [PATCH 3/5] hw/ppc/pnv_xscom: Power8 occ common area is in PBA BAR 3

2019-11-21 Thread Balamuruhan S
On Wed, Nov 20, 2019 at 08:20:35AM +0100, Cédric Le Goater wrote: > On 19/11/2019 18:50, Balamuruhan S wrote: > > Fix incorrect PBA BAR and BARMASK value for Power8 occ common area > > region where skiboot enum declaration have it in BAR 3 and BARMASK > > is calculated BARMASK0 + BAR, > > > >

Re: [PATCH for-4.2 1/2] i386: Add new versions of Skylake/Cascadelake/Icelake without TSX

2019-11-21 Thread Paolo Bonzini
On 20/11/19 19:42, Eduardo Habkost wrote: > The plan is to set default_cpu_version=CPU_VERSION_LATEST on > pc-*-5.0 (or, more likely, 5.1). But this will happen only after > libvirt starts resolving CPU model versions. See the > "Runnability guarantee of CPU models" section at >

Re: [PATCH for-5.0 v5 11/23] ppc/pnv: Introduce a pnv_xive_is_cpu_enabled() helper

2019-11-21 Thread Cédric Le Goater
On 21/11/2019 08:58, Greg Kurz wrote: > On Wed, 20 Nov 2019 22:40:31 +0100 > Cédric Le Goater wrote: > >> On 20/11/2019 18:26, Greg Kurz wrote: >>> On Fri, 15 Nov 2019 17:24:24 +0100 >>> Cédric Le Goater wrote: >>> and use this helper to exclude CPUs which are not enabled in the XIVE

Re: [PATCH 0/5] ppc/pnv: fix Homer/Occ mappings on multichip systems

2019-11-21 Thread Cédric Le Goater
On 21/11/2019 10:11, Balamuruhan S wrote: > On Wed, Nov 20, 2019 at 08:46:30AM +0100, Cédric Le Goater wrote: >> Hello, >> >> On 19/11/2019 18:50, Balamuruhan S wrote: >>> Hi All, >>> >>> PowerNV fails to boot in multichip systems due to some misinterpretation >>> and mapping in Homer/Occ device

Re: [PATCH] pseries: disable migration-test if /dev/kvm cannot be used

2019-11-21 Thread David Gibson
On Thu, Nov 21, 2019 at 09:30:27AM +0100, Juan Quintela wrote: > Laurent Vivier wrote: > > On 21/11/2019 08:18, Juan Quintela wrote: > >> Laurent Vivier wrote: > >>> On ppc64, migration-test only works with kvm_hv, and we already > >>> have a check to verify the module is loaded. > >>> > >>>

Re: [RFC PATCH 00/18] Add qemu-storage-daemon

2019-11-21 Thread Stefan Hajnoczi
On Wed, Nov 06, 2019 at 03:58:00PM +0100, Kevin Wolf wrote: > Am 06.11.2019 um 15:37 hat Max Reitz geschrieben: > > On 17.10.19 15:01, Kevin Wolf wrote: > > The only thing I don’t like is the name, but that’s what is for. > > :-) > > I'm open for suggestions, but I thought 'qsd' was a bit too

Re: [PATCH 5/5] hw/ppc/pnv_xscom: add PBA BARs for Power8 slw image

2019-11-21 Thread Balamuruhan S
On Wed, Nov 20, 2019 at 08:31:50AM +0100, Cédric Le Goater wrote: > On 19/11/2019 18:50, Balamuruhan S wrote: > > slw base and size mask are accessed during boot in homer_init_chip(), > > so include BAR2 and BARMASK2 for Power8. > > > > Signed-off-by: Balamuruhan S > > --- > >

Re: [PATCH 00/15] s390x: Protected Virtualization support

2019-11-21 Thread Cornelia Huck
On Thu, 21 Nov 2019 10:13:29 +0100 Janosch Frank wrote: > On 11/20/19 2:26 PM, Cornelia Huck wrote: > > On Wed, 20 Nov 2019 06:43:19 -0500 > > Janosch Frank wrote: > > > > Do you have a branch with this somewhere? > > Just for you: > https://github.com/frankjaa/qemu/tree/protvirt >

[PATCH v2] virtio-input: fix memory leak on unrealize

2019-11-21 Thread Marc-André Lureau
Spotted by ASAN + minor stylistic change. Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin --- Michael: can you peek this in your next pullreq? thanks hw/input/virtio-input.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/input/virtio-input.c

Re: [PATCH v2 6/6] iotests: Test committing to short backing file

2019-11-21 Thread Vladimir Sementsov-Ogievskiy
20.11.2019 21:45, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH] pseries: disable migration-test if /dev/kvm cannot be used

2019-11-21 Thread Juan Quintela
Laurent Vivier wrote: > On 21/11/2019 08:18, Juan Quintela wrote: >> Laurent Vivier wrote: >>> On ppc64, migration-test only works with kvm_hv, and we already >>> have a check to verify the module is loaded. >>> >>> kvm_hv module can be loaded in memory and /sys/module/kvm_hv exists, >>> but on

Re: [PATCH v2 2/6] block: truncate: Don't make backing file data visible

2019-11-21 Thread Max Reitz
On 20.11.19 19:44, Kevin Wolf wrote: > When extending the size of an image that has a backing file larger than > its old size, make sure that the backing file data doesn't become > visible in the guest, but the added area is properly zeroed out. > > Consider the following scenario where the

Re: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project

2019-11-21 Thread Richard Henderson
On 11/20/19 4:17 PM, Taylor Simpson wrote: > Are you saying there's a way to tell qemu to put the stack at a certain > location? Or are you suggesting we do something on the hardware side? There's obviously nothing to be done on the hardware side. Presumably this is all about the kernel,

Re: [PATCH 0/5] ppc/pnv: fix Homer/Occ mappings on multichip systems

2019-11-21 Thread Balamuruhan S
On Wed, Nov 20, 2019 at 08:46:30AM +0100, Cédric Le Goater wrote: > Hello, > > On 19/11/2019 18:50, Balamuruhan S wrote: > > Hi All, > > > > PowerNV fails to boot in multichip systems due to some misinterpretation > > and mapping in Homer/Occ device models, this patchset fixes the > > following,

Re: [RFC v4 PATCH 09/49] multi-process: setup PCI host bridge for remote device

2019-11-21 Thread Stefan Hajnoczi
On Mon, Nov 18, 2019 at 10:25:59AM -0500, Jag Raman wrote: > On 11/13/2019 11:07 AM, Stefan Hajnoczi wrote: > > On Thu, Oct 24, 2019 at 05:08:50AM -0400, Jagannathan Raman wrote: > > > +static void remote_host_realize(DeviceState *dev, Error **errp) > > > +{ > > > +PCIHostState *pci =

Re: [PATCH for-5.0 v5 15/23] ppc/xive: Use the XiveFabric and XivePresenter interfaces

2019-11-21 Thread Greg Kurz
On Thu, 21 Nov 2019 08:40:32 +0100 Cédric Le Goater wrote: > On 21/11/2019 08:30, Greg Kurz wrote: > > On Thu, 21 Nov 2019 08:01:44 +0100 > > Cédric Le Goater wrote: > > > >> On 20/11/2019 19:30, Greg Kurz wrote: > >>> On Fri, 15 Nov 2019 17:24:28 +0100 > >>> Cédric Le Goater wrote: > >>> >

Re: [PATCH] pseries: disable migration-test if /dev/kvm cannot be used

2019-11-21 Thread Laurent Vivier
On 21/11/2019 08:18, Juan Quintela wrote: > Laurent Vivier wrote: >> On ppc64, migration-test only works with kvm_hv, and we already >> have a check to verify the module is loaded. >> >> kvm_hv module can be loaded in memory and /sys/module/kvm_hv exists, >> but on some systems (like build

Re: [PATCH 2/5] hw/ppc/pnv_xscom: PBA bar mask values are incorrect with homer/occ sizes

2019-11-21 Thread Balamuruhan S
On Wed, Nov 20, 2019 at 08:59:40AM +0100, Greg Kurz wrote: > On Wed, 20 Nov 2019 08:46:51 +0530 > Balamuruhan S wrote: > > > On Wed, Nov 20, 2019 at 08:31:03AM +0530, Balamuruhan S wrote: > > > On Wed, Nov 20, 2019 at 09:02:26AM +1100, David Gibson wrote: > > > > On Wed, Nov 20, 2019 at

Re: [PATCH 00/15] s390x: Protected Virtualization support

2019-11-21 Thread Janosch Frank
On 11/20/19 2:26 PM, Cornelia Huck wrote: > On Wed, 20 Nov 2019 06:43:19 -0500 > Janosch Frank wrote: > > Do you have a branch with this somewhere? Just for you: https://github.com/frankjaa/qemu/tree/protvirt

Re: [PATCH for-5.0 v5 15/23] ppc/xive: Use the XiveFabric and XivePresenter interfaces

2019-11-21 Thread Cédric Le Goater
On 21/11/2019 09:08, Greg Kurz wrote: > On Thu, 21 Nov 2019 08:40:32 +0100 > Cédric Le Goater wrote: > >> On 21/11/2019 08:30, Greg Kurz wrote: >>> On Thu, 21 Nov 2019 08:01:44 +0100 >>> Cédric Le Goater wrote: >>> On 20/11/2019 19:30, Greg Kurz wrote: > On Fri, 15 Nov 2019 17:24:28

[PULL 0/3] Fixes 20191121 patches

2019-11-21 Thread Gerd Hoffmann
The following changes since commit 39e2821077e6dcf788b7c2a9ef50970ec7995437: Update version for v4.2.0-rc2 release (2019-11-19 19:34:10 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/fixes-20191121-pull-request for you to fetch changes up

Re: [RFC 0/4] POC: Generating realistic block errors

2019-11-21 Thread Stefan Hajnoczi
On Thu, Nov 14, 2019 at 09:47:48AM -0600, Tony Asleson wrote: > On 9/20/19 12:28 PM, Tony Asleson wrote: > > On 9/20/19 4:22 AM, Stefan Hajnoczi wrote: > >> blkdebug is purely at the QEMU block layer level. It is not aware of > >> storage controller-specific error information or features. If you

Re: [PATCH v2 6/6] iotests: Test committing to short backing file

2019-11-21 Thread Vladimir Sementsov-Ogievskiy
21.11.2019 13:28, Vladimir Sementsov-Ogievskiy wrote: > 20.11.2019 21:45, Kevin Wolf wrote: >> Signed-off-by: Kevin Wolf > > Hmm, allocating 7G will break tests on small disks, for example, > on my 2G tmpfs. > > So, we probably should > detect "+qemu-img: Failed to resize underlying file: Could

Re: qcow2 preallocation and backing files

2019-11-21 Thread Max Reitz
On 20.11.19 16:58, Vladimir Sementsov-Ogievskiy wrote: > 20.11.2019 18:18, Alberto Garcia wrote: >> On Wed 20 Nov 2019 01:27:53 PM CET, Vladimir Semeeausntsov-Ogievskiy wrote: >> >>> 3. Also, the latter way is inconsistent with discard. Discarded >>> regions returns zeroes, not clusters from

Re: [RFC PATCH 00/18] Add qemu-storage-daemon

2019-11-21 Thread Kevin Wolf
Am 21.11.2019 um 11:32 hat Stefan Hajnoczi geschrieben: > On Wed, Nov 06, 2019 at 03:58:00PM +0100, Kevin Wolf wrote: > > Am 06.11.2019 um 15:37 hat Max Reitz geschrieben: > > > On 17.10.19 15:01, Kevin Wolf wrote: > > > The only thing I don’t like is the name, but that’s what is for. > > > :-) >

Re: [PATCH 06/15] s390x: protvirt: Support unpack facility

2019-11-21 Thread David Hildenbrand
On 20.11.19 12:43, Janosch Frank wrote: When a guest has saved a ipib of type 5 and call diagnose308 with subcode 10, we have to setup the protected processing environment via Ultravisor calls. The calls are done by KVM and are exposed via an API. The following steps are necessary: 1. Create a

Re: [PULL 0/3] virtio, acpi: fixes

2019-11-21 Thread Peter Maydell
On Wed, 20 Nov 2019 at 09:59, Michael S. Tsirkin wrote: > > The following changes since commit 39e2821077e6dcf788b7c2a9ef50970ec7995437: > > Update version for v4.2.0-rc2 release (2019-11-19 19:34:10 +) > > are available in the Git repository at: > >

Re: [PATCH 02/15] s390x: Beautify diag308 handling

2019-11-21 Thread Janosch Frank
On 11/21/19 12:17 PM, Cornelia Huck wrote: > On Wed, 20 Nov 2019 06:43:21 -0500 > Janosch Frank wrote: > >> Let's improve readability by: >> * Using constants for the subcodes >> * Moving parameter checking into a function >> * Removing subcode > 6 check as the default case catches that >> >>

[qemu-web PATCH] Add a blog post about the QEMU-related presentation of KVM Forum 2019

2019-11-21 Thread Thomas Huth
There have been quite a lot of QEMU-related talks at KVM Forum this year - let's provide a summary for the people who could not attend. Signed-off-by: Thomas Huth --- Note: For some talks it's hard to decide whether they really fit the QEMU blog or not. I've assembled the list below by quickly

Re: [PATCH v2] linux-user/strace: Add missing signal strings

2019-11-21 Thread Richard Henderson
On 11/20/19 3:55 PM, Helge Deller wrote: > Add the textual representations of some missing target signals. > > Signed-off-by: Helge Deller Reviewed-by: Richard Henderson r~

Re: [PATCH 03/15] s390x: protvirt: Add diag308 subcodes 8 - 10

2019-11-21 Thread Cornelia Huck
On Wed, 20 Nov 2019 06:43:22 -0500 Janosch Frank wrote: > For diag308 subcodes 8 - 10 we have a new ipib of type 5. The ipib > holds the address and length of the secure execution header, as well > as a list of guest components. > > Each component is a block of memory, for example kernel or

Re: [RFC v4 PATCH 00/49] Initial support of multi-process qemu

2019-11-21 Thread Stefan Hajnoczi
On Thu, Oct 24, 2019 at 05:08:41AM -0400, Jagannathan Raman wrote: > Started with the presentation in October 2017 made by Marc-Andre (Red Hat) > and Konrad Wilk (Oracle) [1], and continued by Jag's BoF at KVM Forum 2018, > the multi-process project is now a prototype and presented in this

Re: [PULL for rc3 0/5] a few doc and testing tweaks

2019-11-21 Thread Peter Maydell
On Wed, 20 Nov 2019 at 10:58, Alex Bennée wrote: > > The following changes since commit 39e2821077e6dcf788b7c2a9ef50970ec7995437: > > Update version for v4.2.0-rc2 release (2019-11-19 19:34:10 +) > > are available in the Git repository at: > > https://github.com/stsquad/qemu.git

Re: [PATCH 01/15] s390x: Cleanup cpu resets

2019-11-21 Thread Thomas Huth
On 21/11/2019 14.11, Janosch Frank wrote: > On 11/21/19 1:53 PM, Thomas Huth wrote: >> On 20/11/2019 12.43, Janosch Frank wrote: >>> Let's move the resets into one function and switch by type, so we can >>> use fallthroughs for shared reset actions. [...] >>> +memset(env, 0,

Re: [PATCH 04/15] Header sync protvirt

2019-11-21 Thread Cornelia Huck
On Thu, 21 Nov 2019 14:12:21 +0100 Janosch Frank wrote: > On 11/21/19 1:59 PM, Cornelia Huck wrote: > > On Wed, 20 Nov 2019 06:43:23 -0500 > > Janosch Frank wrote: > > > >> Let's sync all the protvirt header changes > >> > >> Signed-off-by: Janosch Frank > >> --- > >>

Re: [PATCH v4 21/37] sm501: make SerialMM a child, export chardev property

2019-11-21 Thread Peter Maydell
On Wed, 20 Nov 2019 at 15:31, Marc-André Lureau wrote: > > Embed the SerialMM sybus device, and re-export its "chardev" property. > That way, we can get rid of PROP_PTR "chr-state" and better track > devices relationship. > > Signed-off-by: Marc-André Lureau > --- > hw/display/sm501.c | 33

Re: [PATCH v2 1/1] ide: check DMA transfer size in ide_dma_cb() to prevent qemu DoS from quests

2019-11-21 Thread Kevin Wolf
Am 14.11.2019 um 18:25 hat Alexander Popov geschrieben: > The commit a718978ed58a from July 2015 introduced the assertion which > implies that the size of successful DMA transfers handled in ide_dma_cb() > should be multiple of 512 (the size of a sector). But guest systems can > initiate DMA

Re: [RFC v4 PATCH 16/49] multi-process: Add LSI device proxy object

2019-11-21 Thread Stefan Hajnoczi
On Thu, Oct 24, 2019 at 05:08:57AM -0400, Jagannathan Raman wrote: > Adds proxy-lsi53c895a object, as a derivative of the pci-proxy-dev > object. This object is the proxy for the lsi53c895a object > instantiated by the remote process. The same information could be fetched from the remote process.

Re: [PATCH v2 6/6] iotests: Test committing to short backing file

2019-11-21 Thread Kevin Wolf
Am 21.11.2019 um 11:30 hat Vladimir Sementsov-Ogievskiy geschrieben: > 21.11.2019 13:28, Vladimir Sementsov-Ogievskiy wrote: > > 20.11.2019 21:45, Kevin Wolf wrote: > >> Signed-off-by: Kevin Wolf > > > > Hmm, allocating 7G will break tests on small disks, for example, > > on my 2G tmpfs. > > > >

Re: [RFC v4 PATCH 32/49] multi-process: Use separate MMIO communication channel

2019-11-21 Thread Stefan Hajnoczi
On Wed, Nov 13, 2019 at 11:14:50AM -0500, Jag Raman wrote: > On 11/11/2019 11:21 AM, Stefan Hajnoczi wrote: > > On Thu, Oct 24, 2019 at 05:09:13AM -0400, Jagannathan Raman wrote: > > > Using a separate communication channel for MMIO helps > > > with improving Performance > > > > Why? > > Typical

Re: QEMU HTML documentation now on qemu.org

2019-11-21 Thread Stefan Hajnoczi
On Fri, Nov 15, 2019 at 09:05:32AM -0500, G 3 wrote: > > You can now access the latest QEMU HTML documentation built from > > https://wiki.qemu.org/docs/qemu-doc.html > > > This is a welcome start. Could we add version support to the URL? > > What I mean is add the version number to the path

Re: [qemu-web PATCH] Add device fuzzing blog post

2019-11-21 Thread Stefan Hajnoczi
On Tue, Nov 12, 2019 at 12:39:49PM +0100, Thomas Huth wrote: > On 07/11/2019 16.48, Stefan Hajnoczi wrote: > > On Thu, Nov 7, 2019 at 10:43 AM Thomas Huth wrote: > >> > >> - Original Message - > >>> From: "Stefan Hajnoczi" > >>> Sent: Thursday, November 7, 2019 10:11:36 AM > >>> > >>>

Re: [PATCH 02/15] s390x: Beautify diag308 handling

2019-11-21 Thread Thomas Huth
On 21/11/2019 12.21, David Hildenbrand wrote: > On 20.11.19 12:43, Janosch Frank wrote: >> Let's improve readability by: >> * Using constants for the subcodes >> * Moving parameter checking into a function >> * Removing subcode > 6 check as the default case catches that >> >> Signed-off-by:

Re: [PATCH 01/15] s390x: Cleanup cpu resets

2019-11-21 Thread Janosch Frank
On 11/21/19 1:53 PM, Thomas Huth wrote: > On 20/11/2019 12.43, Janosch Frank wrote: >> Let's move the resets into one function and switch by type, so we can >> use fallthroughs for shared reset actions. >> >> Signed-off-by: Janosch Frank >> --- >> hw/s390x/s390-virtio-ccw.c | 3 + >>

Re: [PATCH] target/arm: Fix handling of cortex-m FTYPE flag in EXCRET

2019-11-21 Thread Peter Maydell
On Thu, 21 Nov 2019 at 01:44, Jean-Hugues Deschênes wrote: > > According to the PushStack() pseudocode in the armv7m RM, > bit 4 of the LR should be set to NOT(CONTROL.PFCA) when > an FPU is present. Current implementation is doing it for > armv8, but not for armv7. This patch makes the existing

Re: [PATCH v4 19/37] mips: use sysbus_add_io()

2019-11-21 Thread Peter Maydell
On Wed, 20 Nov 2019 at 15:28, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > --- > hw/mips/mips_mipssim.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/mips/mips_mipssim.c b/hw/mips/mips_mipssim.c > index 3cd0e6eb33..2c2c7f25b2 100644 > ---

Re: [PATCH 05/15] s390x: protvirt: Sync PV state

2019-11-21 Thread Janosch Frank
On 11/21/19 2:25 PM, Cornelia Huck wrote: > On Wed, 20 Nov 2019 06:43:24 -0500 > Janosch Frank wrote: > >> We do not always have the SIE intercept code handy at each place where >> we do emulation. Unfortunately emulation for secure guests often >> differ slightly from normal emulation and we

[PATCH v4 3/5] blockdev: unify qmp_blockdev_backup and blockdev-backup transaction paths

2019-11-21 Thread Sergio Lopez
Issuing a blockdev-backup from qmp_blockdev_backup takes a slightly different path than when it's issued from a transaction. In the code, this is manifested as some redundancy between do_blockdev_backup() and blockdev_backup_prepare(). This change unifies both paths, merging do_blockdev_backup()

[PATCH v4 5/5] iotests: fix 141 after qmp_drive_backup with transactions

2019-11-21 Thread Sergio Lopez
qmp_drive_backup now creates and starts a transactions, which implies that the job will transition to pause and running twice. Fix test 141 to be aware of this change. Signed-off-by: Sergio Lopez --- tests/qemu-iotests/141.out | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [qemu-web PATCH] Add a blog post about the QEMU-related presentation of KVM Forum 2019

2019-11-21 Thread Eric Blake
On 11/21/19 5:52 AM, Thomas Huth wrote: There have been quite a lot of QEMU-related talks at KVM Forum this year - let's provide a summary for the people who could not attend. Signed-off-by: Thomas Huth --- Note: For some talks it's hard to decide whether they really fit the QEMU blog or

Re: [PATCH 06/15] s390x: protvirt: Support unpack facility

2019-11-21 Thread Janosch Frank
On 11/21/19 3:31 PM, Christian Borntraeger wrote: > > > On 21.11.19 15:28, David Hildenbrand wrote: >>> And please trim your emails. >>> >> >> If you use Thunderbird I suggest QuoteCollapse ... because nobody got time >> for that ;) > > neat. > Yeah, seems like I'm already too old-school for

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-21 Thread Eric Blake
On 11/21/19 9:07 AM, Markus Armbruster wrote: Max Reitz writes: With this change, it is possible to give default values for struct members, as follows: What you had to do so far: # @member: Some description, defaults to 42. { 'struct': 'Foo', 'data': { '*member': 'int' }

Re: [PATCH 01/15] s390x: Cleanup cpu resets

2019-11-21 Thread Cornelia Huck
On Wed, 20 Nov 2019 06:43:20 -0500 Janosch Frank wrote: > Let's move the resets into one function and switch by type, so we can > use fallthroughs for shared reset actions. Doing that makes sense. > > Signed-off-by: Janosch Frank > --- > hw/s390x/s390-virtio-ccw.c | 3 + >

Re: [PATCH 01/15] s390x: Cleanup cpu resets

2019-11-21 Thread Janosch Frank
On 11/21/19 12:10 PM, Cornelia Huck wrote: > On Wed, 20 Nov 2019 06:43:20 -0500 > Janosch Frank wrote: > >> Let's move the resets into one function and switch by type, so we can >> use fallthroughs for shared reset actions. > > Doing that makes sense. > >> >> Signed-off-by: Janosch Frank >>

Re: [PATCH 15/15] s390x: protvirt: Handle SIGP store status correctly

2019-11-21 Thread Janosch Frank
On 11/21/19 12:24 PM, David Hildenbrand wrote: > On 20.11.19 12:43, Janosch Frank wrote: >> Status storing is obviously not done by qemu anymore. >> >> Signed-off-by: Janosch Frank >> --- >> target/s390x/sigp.c | 7 +-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git

Re: [PATCH for-4.2 1/2] i386: Add new versions of Skylake/Cascadelake/Icelake without TSX

2019-11-21 Thread Kashyap Chamarthy
On Wed, Nov 20, 2019 at 01:49:11PM -0300, Eduardo Habkost wrote: > One of the mitigation methods for TAA[1] is to disable TSX > support on the host system. Linux added a mechanism to disable > TSX globally through the kernel command line, and many Linux > distributions now default to tsx=off.

Re: [PATCH v2 14/20] nvme: allow multiple aios per command

2019-11-21 Thread Klaus Birkelund
On Tue, Nov 12, 2019 at 03:25:06PM +, Beata Michalska wrote: > Hi Klaus, > > On Tue, 15 Oct 2019 at 11:55, Klaus Jensen wrote: > > @@ -341,19 +344,18 @@ static uint16_t nvme_dma_write_prp(NvmeCtrl *n, > > uint8_t *ptr, uint32_t len, > Any reason why the nvme_dma_write_prp is missing the

Re: [PATCH 04/15] Header sync protvirt

2019-11-21 Thread Cornelia Huck
On Wed, 20 Nov 2019 06:43:23 -0500 Janosch Frank wrote: > Let's sync all the protvirt header changes > > Signed-off-by: Janosch Frank > --- > linux-headers/asm-s390/kvm.h | 3 ++- > linux-headers/linux/kvm.h| 42 > 2 files changed, 44 insertions(+), 1

Re: [PATCH v3 0/2] virtio: make seg_max virtqueue size dependent

2019-11-21 Thread Stefan Hajnoczi
On Tue, Nov 12, 2019 at 02:13:52PM +0300, Denis Plotnikov wrote: > v3: > * add property to set in machine type [MST] > * add min queue size check [Stefan] > * add avocado based test [Max, Stefan, Eduardo, Cleber] > > v2: > * the standalone patch to make seg_max virtqueue size dependent >

Re: [PATCH v4 27/37] leon3: use qdev gpio facilities for the PIL

2019-11-21 Thread Peter Maydell
On Wed, 20 Nov 2019 at 15:30, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > --- > hw/sparc/leon3.c | 6 -- > target/sparc/cpu.h | 1 - > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c > index cac987373e..1a89d44e57

Re: [PATCH 02/15] s390x: Beautify diag308 handling

2019-11-21 Thread Janosch Frank
On 11/21/19 2:20 PM, Thomas Huth wrote: > On 20/11/2019 12.43, Janosch Frank wrote: >> Let's improve readability by: >> * Using constants for the subcodes >> * Moving parameter checking into a function >> * Removing subcode > 6 check as the default case catches that >> >> Signed-off-by: Janosch

Re: [PATCH 07/15] s390x: protvirt: Handle diag 308 subcodes 0,1,3,4

2019-11-21 Thread Janosch Frank
On 11/21/19 2:50 PM, Cornelia Huck wrote: > On Wed, 20 Nov 2019 06:43:26 -0500 > Janosch Frank wrote: > >> run_on_cpu(cs, s390_do_cpu_load_normal, RUN_ON_CPU_NULL); >> break; >> case S390_RESET_LOAD_NORMAL: /* Subcode 1*/ > > missing blank before */ (introduced in a

Re: [PATCH for-4.2? v2 0/6] block: Fix resize (extending) of short overlays

2019-11-21 Thread Stefan Hajnoczi
On Wed, Nov 20, 2019 at 07:44:55PM +0100, Kevin Wolf wrote: > See patch 2 for the description of the bug fixed. > > v2: > - Switched order of bs->total_sectors update and zero write [Vladimir] > - Fixed coding style [Vladimir] > - Changed the commit message to contain what was in the cover letter

Re: [PATCH] RISC-V: virt: This is a "sifive,test1" test finisher

2019-11-21 Thread Palmer Dabbelt
On Sun, 10 Nov 2019 13:10:33 PST (-0800), da...@gibson.dropbear.id.au wrote: On Fri, Nov 08, 2019 at 10:13:16AM -0800, Palmer Dabbelt wrote: On Fri, 08 Nov 2019 10:04:47 PST (-0800), Peter Maydell wrote: > On Fri, 8 Nov 2019 at 17:15, Alistair Francis wrote: > > > > On Fri, Nov 8, 2019 at

Re: [PATCH 08/15] s390x: protvirt: KVM intercept changes

2019-11-21 Thread Thomas Huth
On 20/11/2019 12.43, Janosch Frank wrote: > Secure guests no longer intercept with code 4 for an instruction > interception. Instead they have codes 104 and 108 for secure > instruction interception and secure instruction notification > respectively. > > The 104 mirrors the 4, but the 108 is a

Re: [PATCH v2] exynos4210_gic: Suppress gcc9 format-truncation warnings

2019-11-21 Thread Philippe Mathieu-Daudé
On 11/21/19 2:38 AM, David Gibson wrote: exynos4210_gic_realize() prints the number of cpus into some temporary buffers, but it only allows 3 bytes space for it. That's plenty: existing machines will only ever set this value to EXYNOS4210_NCPUS (2). But the compiler can't always figure that

Re: [RFC v4 PATCH 14/49] mutli-process: build remote command line args

2019-11-21 Thread Stefan Hajnoczi
On Thu, Oct 24, 2019 at 05:08:55AM -0400, Jagannathan Raman wrote: > From: Elena Ufimtseva > > Signed-off-by: Elena Ufimtseva > Signed-off-by: Jagannathan Raman > Signed-off-by: John G Johnson > --- > New patch in v3 > > hw/proxy/qemu-proxy.c | 80 >

Re: [RFC v4 PATCH 17/49] multi-process: Synchronize remote memory

2019-11-21 Thread Stefan Hajnoczi
On Thu, Oct 24, 2019 at 05:08:58AM -0400, Jagannathan Raman wrote: > +static const TypeInfo remote_mem_sync_type_info = { > +.name = TYPE_MEMORY_LISTENER, > +.parent= TYPE_OBJECT, > +.instance_size = sizeof(RemoteMemSync), > +}; > + > +static void

Re: [RFC v4 PATCH 19/49] multi-process: configure remote side devices

2019-11-21 Thread Stefan Hajnoczi
On Thu, Oct 24, 2019 at 05:09:00AM -0400, Jagannathan Raman wrote: > +static void set_remote_opts(PCIDevice *dev, QDict *qdict, unsigned int cmd) > +{ > +QString *qstr; > +MPQemuMsg msg; > +const char *str; > +PCIProxyDev *pdev; > + > +pdev = PCI_PROXY_DEV(dev); > + > +qstr

Re: [PATCH v2 6/6] iotests: Test committing to short backing file

2019-11-21 Thread Vladimir Sementsov-Ogievskiy
21.11.2019 14:39, Kevin Wolf wrote: > Am 21.11.2019 um 11:30 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 21.11.2019 13:28, Vladimir Sementsov-Ogievskiy wrote: >>> 20.11.2019 21:45, Kevin Wolf wrote: Signed-off-by: Kevin Wolf >>> >>> Hmm, allocating 7G will break tests on small disks, for

Re: [PATCH 02/15] s390x: Beautify diag308 handling

2019-11-21 Thread Thomas Huth
On 20/11/2019 12.43, Janosch Frank wrote: > Let's improve readability by: > * Using constants for the subcodes > * Moving parameter checking into a function > * Removing subcode > 6 check as the default case catches that > > Signed-off-by: Janosch Frank > --- > target/s390x/diag.c | 54

Re: [PATCH v4 18/37] mips: baudbase is 115200 by default

2019-11-21 Thread Peter Maydell
On Wed, 20 Nov 2019 at 15:28, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > --- > hw/mips/mips_mipssim.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/mips/mips_mipssim.c b/hw/mips/mips_mipssim.c > index bfafa4d7e9..3cd0e6eb33 100644 > --- a/hw/mips/mips_mipssim.c

[PATCH v4 2/5] blockdev: unify qmp_drive_backup and drive-backup transaction paths

2019-11-21 Thread Sergio Lopez
Issuing a drive-backup from qmp_drive_backup takes a slightly different path than when it's issued from a transaction. In the code, this is manifested as some redundancy between do_drive_backup() and drive_backup_prepare(). This change unifies both paths, merging do_drive_backup() and

[PATCH v4 0/5] blockdev: avoid acquiring AioContext lock twice at do_drive_backup and do_blockdev_backup

2019-11-21 Thread Sergio Lopez
do_drive_backup() acquires the AioContext lock of the corresponding BlockDriverState. This is not a problem when it's called from qmp_drive_backup(), but drive_backup_prepare() also acquires the lock before calling it. The same things happens with do_blockdev_backup() and

[PATCH v4 1/5] blockdev: fix coding style issues in drive_backup_prepare

2019-11-21 Thread Sergio Lopez
Fix a couple of minor coding style issues in drive_backup_prepare. Signed-off-by: Sergio Lopez --- blockdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 8e029e9c01..553e315972 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3620,7

Re: PCI memory sync question (kvm,dpdk,e1000,packet stalled)

2019-11-21 Thread Stefan Hajnoczi
On Wed, Nov 20, 2019 at 08:36:32PM +0300, ASM wrote: > I trying solve the problem, with packets stopping (e1000,tap,kvm). > My studies led to the following: > 1. From flatview_write_continue() I see, what e1000 writes the number > "7" to the STAT register. > 2. The driver from target OS reads STAT

Re: [PATCH 07/15] s390x: protvirt: Handle diag 308 subcodes 0,1,3,4

2019-11-21 Thread Janosch Frank
On 11/21/19 3:17 PM, Cornelia Huck wrote: > On Thu, 21 Nov 2019 15:04:31 +0100 > Janosch Frank wrote: > >> On 11/21/19 2:50 PM, Cornelia Huck wrote: >>> On Wed, 20 Nov 2019 06:43:26 -0500 >>> Janosch Frank wrote: >> >>> run_on_cpu(cs, s390_do_cpu_load_normal,

Re: [PATCH 06/15] s390x: protvirt: Support unpack facility

2019-11-21 Thread Christian Borntraeger
On 21.11.19 15:28, David Hildenbrand wrote: >> And please trim your emails. >> > > If you use Thunderbird I suggest QuoteCollapse ... because nobody got time > for that ;) neat.

Re: [PATCH 06/15] s390x: protvirt: Support unpack facility

2019-11-21 Thread Janosch Frank
On 11/20/19 2:43 PM, Cornelia Huck wrote: > On Wed, 20 Nov 2019 06:43:25 -0500 > Janosch Frank wrote: > >> When a guest has saved a ipib of type 5 and call diagnose308 with >> subcode 10, we have to setup the protected processing environment via >> Ultravisor calls. The calls are done by KVM and

Re: [RFC v4 PATCH 15/49] multi-process: PCI BAR read/write handling for proxy & remote endpoints

2019-11-21 Thread Stefan Hajnoczi
On Thu, Oct 24, 2019 at 05:08:56AM -0400, Jagannathan Raman wrote: > +const MemoryRegionOps proxy_default_ops = { Unused. Please structure patch series so that each patch is a self-contained logical change. It should be possible to review the series in order from start to finish. If there is

Re: [PATCH v2 2/6] block: truncate: Don't make backing file data visible

2019-11-21 Thread Kevin Wolf
Am 21.11.2019 um 09:59 hat Max Reitz geschrieben: > On 20.11.19 19:44, Kevin Wolf wrote: > > When extending the size of an image that has a backing file larger than > > its old size, make sure that the backing file data doesn't become > > visible in the guest, but the added area is properly zeroed

Re: [RFC v4 PATCH 18/49] multi-process: create IOHUB object to handle irq

2019-11-21 Thread Stefan Hajnoczi
On Thu, Oct 24, 2019 at 05:08:59AM -0400, Jagannathan Raman wrote: I don't know the interrupt code well enough to decide whether it's necessary to do so much work and tie the protocol to the KVM API. The main QEMU process already has the KVM API code and the ability to deal with these things. I

Re: [PATCH 01/15] s390x: Cleanup cpu resets

2019-11-21 Thread Cornelia Huck
On Thu, 21 Nov 2019 12:32:38 +0100 Janosch Frank wrote: > On 11/21/19 12:10 PM, Cornelia Huck wrote: > > On Wed, 20 Nov 2019 06:43:20 -0500 > > Janosch Frank wrote: > > > >> Let's move the resets into one function and switch by type, so we can > >> use fallthroughs for shared reset actions.

Re: [RFC v4 PATCH 30/49] multi-process: send heartbeat messages to remote

2019-11-21 Thread Stefan Hajnoczi
On Wed, Nov 13, 2019 at 11:01:07AM -0500, Jag Raman wrote: > > > On 11/11/2019 11:27 AM, Stefan Hajnoczi wrote: > > On Thu, Oct 24, 2019 at 05:09:11AM -0400, Jagannathan Raman wrote: > > > +static void broadcast_msg(MPQemuMsg *msg, bool need_reply) > > > +{ > > > +PCIProxyDev *entry; > > > +

  1   2   3   >