Re: [Qemu-devel] [PATCH v8 15/37] target/mips: Style improvements in mips_malta.c

2019-12-06 Thread Aleksandar Markovic
On Friday, December 6, 2019, Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Friday, December 6, 2019, Philippe Mathieu-Daudé > wrote: > >> Hi Aleksandar, >> >> On 8/19/19 4:47 PM, Aleksandar Rikalo wrote: >> >>> From: Aleksandar Markovic >>> > Sent: Monday, August 19, 2019

Re: [PATCH v2] migration/dirty-bitmaps: change bitmap enumeration method

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
14.05.2019 23:19, John Snow wrote: > Shift from looking at every root BDS to *every* BDS. This will migrate > bitmaps that are attached to blockdev created nodes instead of just ones > attached to emulated storage devices. > > Note that this will not migrate anonymous or internal-use bitmaps, as

[Bug 1623998] Re: pulseaudio Invalid argument error

2019-12-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1623998 Title: pulseaudio

Re: [RFC PATCH 1/9] vfio/pci: introduce mediate ops to intercept vfio-pci ops

2019-12-06 Thread Eric Blake
On 12/4/19 9:25 PM, Yan Zhao wrote: when vfio-pci is bound to a physical device, almost all the hardware resources are passthroughed. The intent is obvious, but it sounds awkward to a native speaker. s/passthroughed/passed through/ Sometimes, vendor driver of this physcial device may want to

Re: [PATCH] target/i386: skip kvm_msr_entry_add when kvm_vmx_basic is 0

2019-12-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1575627817-24625-1-git-send-email-catherine.h...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] target/i386: skip kvm_msr_entry_add when kvm_vmx_basic is 0 Type: series

RE: Error compiling Qemu-4.1 on Linux

2019-12-06 Thread Aijaz . Baig
That file IS present and its contents are: prefix=/usr exec_prefix=${prefix} libdir=${prefix}/lib/x86_64-linux-gnu includedir=${prefix}/include Name: GThread Description: Thread support for GLib Requires: glib-2.0 Version: 2.50.3 Libs: -L${libdir} -lgthread-2.0 -pthread Cflags: -pthread Let me

[PATCH] Fix some comment spelling errors.

2019-12-06 Thread Cameron Esfahani via
Signed-off-by: Cameron Esfahani --- target/i386/machine.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/i386/machine.c b/target/i386/machine.c index 2699eed94e..f21823f179 100644 --- a/target/i386/machine.c +++ b/target/i386/machine.c @@ -261,7 +261,7 @@ static

Re: [PATCH] Fix some comment spelling errors.

2019-12-06 Thread Stefan Weil
Am 07.12.19 um 03:33 schrieb Cameron Esfahani via: > Signed-off-by: Cameron Esfahani > --- > target/i386/machine.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/target/i386/machine.c b/target/i386/machine.c > index 2699eed94e..f21823f179 100644 > ---

[PATCH 2/2] .travis.yml: Add kernel build deps for acceptance tests

2019-12-06 Thread Wainer dos Santos Moschetta
The tests/acceptance/pvh.py test builds the Linux kernel at runtime so it needs dependencies installed in the container. Current used container image misses only libelf-dev, which is then added with this change. Signed-off-by: Wainer dos Santos Moschetta --- .travis.yml | 2 ++ 1 file changed,

[PATCH v2] socket: websocket refresh of max_size outside of poll

2019-12-06 Thread Anisse Astier
Because serial backend readiness isn't checked, the socket frontend (in websocket mode) would send new characters before previous characters were consumed. This lead to skipped characters, or worse, SysRq keys being triggered. This patch ensures the readable size is refreshed before consuming any

Re: [PATCH 10/21] hw/core: Fix latent fit_load_fdt() error handling bug

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
06.12.2019 10:46, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 30.11.2019 22:42, Markus Armbruster wrote: >>> fit_load_fdt() recovers from fit_image_addr() failing with ENOENT. >>> Except it doesn't when its @errp argument is _fatal or >>> _abort, because it blindly

Re: [PATCH v2 3/5] target/arm: Handle trapping to EL2 of AArch32 VMRS instructions

2019-12-06 Thread Peter Maydell
On Sun, 1 Dec 2019 at 12:20, Marc Zyngier wrote: > > HCR_EL2.TID3 requires that AArch32 reads of MVFR[012] are trapped to > EL2, and HCR_EL2.TID0 does the same for reads of FPSID. > In order to handle this, introduce a new TCG helper function that > checks for these control bits before executing

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-06 Thread Amit Shah
On Fri, 2019-12-06 at 10:17 +0800, Pan Nengyuan wrote: > On 2019/12/6 0:45, Amit Shah wrote: > > On Wed, 2019-12-04 at 15:31 +0800, pannengy...@huawei.com wrote: > > > From: Pan Nengyuan > > > > Shouldn't this be From: mst? > > > > I didn't find a ref to the original patch to confirm if you had

[PATCH] mailmap: Add entry about me

2019-12-06 Thread Yu-Chen Lin
I have two mail address, add entries for showing author and email correctly. Signed-off-by: Yu-Chen Lin --- .mailmap | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index 3816e4effe..3fbf3902a3 100644 --- a/.mailmap +++ b/.mailmap @@ -151,7 +151,8 @@

Re: [PATCH v2 06/13] s390x: protvirt: KVM intercept changes

2019-12-06 Thread Cornelia Huck
On Fri, 6 Dec 2019 09:45:41 +0100 Janosch Frank wrote: > On 12/6/19 9:29 AM, Cornelia Huck wrote: > > On Fri, 6 Dec 2019 08:44:52 +0100 > > Janosch Frank wrote: > > > >> On 12/5/19 6:46 PM, Cornelia Huck wrote: > >>> On Thu, 5 Dec 2019 18:34:32 +0100 > >>> Janosch Frank wrote: > >>>

[PATCH v2] s390x/tcg: clear local interrupts on reset normal

2019-12-06 Thread Cornelia Huck
We neglected to clean up pending interrupts and emergency signals; fix that. Signed-off-by: Cornelia Huck --- v1->v2: - rebased on top of my s390-next branch; we can now move the fields to be reset instead of clearing them manually Further cleanup possible in a follow-up patch. ---

Re: [PATCH for-5.0 4/8] acpi: cpuhp: spec: fix 'Command data' description

2019-12-06 Thread Igor Mammedov
On Thu, 5 Dec 2019 13:17:22 +0100 Laszlo Ersek wrote: > On 12/04/19 18:05, Igor Mammedov wrote: > > Correct returned value description in case 'Command field' == 0x0, > > it's in not PXM but CPU selector value with pending event > > (1) s/in not/not/ > > > > > In addition describe 0 blanket

Re: [PATCH v2 06/13] s390x: protvirt: KVM intercept changes

2019-12-06 Thread Janosch Frank
On 12/6/19 10:08 AM, Cornelia Huck wrote: > On Fri, 6 Dec 2019 09:45:41 +0100 > Janosch Frank wrote: > >> On 12/6/19 9:29 AM, Cornelia Huck wrote: >>> On Fri, 6 Dec 2019 08:44:52 +0100 >>> Janosch Frank wrote: >>> On 12/5/19 6:46 PM, Cornelia Huck wrote: > On Thu, 5 Dec 2019

Re: [PATCH v5 21/22] target/arm: Add mmu indexes for tag memory

2019-12-06 Thread Richard Henderson
On 12/6/19 3:46 AM, Peter Maydell wrote: >> +case ARMMMUIdx_TagS: >> +case ARMMMUIdx_TagNS: >> +/* Indicate tag memory to arm_asidx_from_attrs. */ >> +attrs->target_tlb_bit2 = true; >> +break; > > So here we fall through to the "handle a stage 1 lookup" code,

Re: [PATCH v6] hw/core/qdev: cleanup Error ** variables

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
06.12.2019 11:26, Markus Armbruster wrote: > Eric Blake writes: > >> On 12/5/19 8:48 AM, Vladimir Sementsov-Ogievskiy wrote: >> > @@ -918,27 +917,26 @@ static void device_set_realized(Object *obj, bool > value, Error **errp) >} >} else if (!value &&

Re: [PATCH v7 21/21] nbd: assert that Error** is not NULL in nbd_iter_channel_error

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
06.12.2019 11:54, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 05.12.2019 20:14, Eric Blake wrote: >>> On 12/5/19 9:20 AM, Vladimir Sementsov-Ogievskiy wrote: The local_err parameter is not here to return information about nbd_iter_channel_error failure. Instead

Re: [RFC][PATCH 2/3] docs/specs: Add specification of ivshmem device revision 2

2019-12-06 Thread Markus Armbruster
Jan Kiszka writes: > On 05.12.19 12:14, Markus Armbruster wrote: >> This has been on the list for more than three weeks already. I >> apologize for the delay. > > No problem! Your feedback is highly appreciated. > >> >> Jan Kiszka writes: >> >>> From: Jan Kiszka >>> >>> This imports the

Re: [PATCH v2 06/13] s390x: protvirt: KVM intercept changes

2019-12-06 Thread Janosch Frank
On 12/5/19 6:46 PM, Cornelia Huck wrote: > On Thu, 5 Dec 2019 18:34:32 +0100 > Janosch Frank wrote: > >> On 12/5/19 6:15 PM, Cornelia Huck wrote: >>> On Fri, 29 Nov 2019 04:48:02 -0500 >>> Janosch Frank wrote: >>> Secure guests no longer intercept with code 4 for an instruction

[PULL 1/1] target/i386: disable VMX features if nested=0

2019-12-06 Thread Paolo Bonzini
From: Yang Zhong If kvm does not support VMX feature by nested=0, the kvm_vmx_basic can't get the right value from MSR_IA32_VMX_BASIC register, which make qemu coredump when qemu do KVM_SET_MSRS. The coredump info: error: failed to set MSR 0x480 to 0x0 kvm_put_msrs: Assertion `ret ==

Re: [PATCH for-4.2?] block/qcow2-bitmap: fix crash bug in qcow2_co_remove_persistent_dirty_bitmap

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
05.12.2019 23:16, John Snow wrote: > > > On 12/5/19 3:09 PM, Eric Blake wrote: >> On 12/5/19 1:30 PM, Vladimir Sementsov-Ogievskiy wrote: >>> Here is double bug: >>> >>> First, return error but not set errp. This may lead to: >>> qmp block-dirty-bitmap-remove may report success when actually

Re: Offline manipulation of Dirty Bitmaps by qemu-img

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
06.12.2019 1:37, John Snow wrote: > This has come up in the past, and I believe we discussed this at KVM > Forum, too: > > There have been requests from oVirt (via Nir Soffer) to add some offline > bitmap manipulation functionality. In the past, our stance has generally > been "Use QEMU without

Re: [PULL 0/1] ppc-for-4.2 queue 20191206

2019-12-06 Thread Peter Maydell
b822e06fb2b13666fd9278e: > > > > > > Update version for v4.2.0-rc4 release (2019-12-03 17:56:30 +) > > > > > > are available in the Git repository at: > > > > > > git://github.com/dgibson/qemu.git tags/ppc-for-4.2-20191206 > > > >

[PATCH 3/5] mips: mipssim: Renovate coding style

2019-12-06 Thread Filip Bozuta
The script checkpatch.pl located in scripts folder was used to detect all errors and warrnings in files: hw/mips/mips_mipssim.c hw/net/mipsnet.c All these mips mipssim machine files were edited and all the errors and warrings generated by the checkpatch.pl script were corrected and then

Re: [PATCH v7 07/21] ppc: well form kvmppc_hint_smt_possible error hint helper

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
06.12.2019 3:02, David Gibson wrote: > On Thu, Dec 05, 2019 at 06:20:05PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Make kvmppc_hint_smt_possible hint append helper well formed: >> rename errp to errp_in, as it is IN-parameter here (which is unusual >> for errp), rename function to be

Re: [PATCH v2 0/5] target/arm: More EL2 trapping fixes

2019-12-06 Thread Peter Maydell
On Sun, 1 Dec 2019 at 12:20, Marc Zyngier wrote: > > Hi all, > > This series is a follow-up on [1], which tried to address the > remaining missing HCR_EL2.TIDx traps. I've hopefully now adressed the > comments that Peter and Edgar raised. > > I've also tried to tackle missing traps generated by

Re: [PATCH v5 22/22] target/arm: Add allocation tag storage for system mode

2019-12-06 Thread Richard Henderson
On 12/6/19 5:02 AM, Peter Maydell wrote: >> +/* >> + * Find the physical address for the virtual access. >> + * >> + * TODO: It should be possible to have the tag mmu_idx map >> + * from main memory ram_addr to tag memory host address. >> + * that would allow this lookup

Re: [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2019-12-06 Thread Peter Maydell
On Fri, 6 Dec 2019 at 01:26, Alexey Kardashevskiy wrote: > *** Note: this is not for master, this is for pseries The way to say this in a way that works with my filters for handling pullrequests is to say "not for master" and have the subject tag be "[PULL SUBSYSTEM name-of-subsystem]" (see

Re: [PATCH v3] qga: fence guest-set-time if hwclock not available

2019-12-06 Thread Markus Armbruster
Laszlo Ersek writes: > On 12/05/19 14:05, Philippe Mathieu-Daudé wrote: >> Hi Cornelia, >> >> On 12/5/19 12:53 PM, Cornelia Huck wrote: >>> The Posix implementation of guest-set-time invokes hwclock to >>> set/retrieve the time to/from the hardware clock. If hwclock >>> is not available, the

[PATCH 0/2] tests/acceptance: Add boot vmlinux test

2019-12-06 Thread Wainer dos Santos Moschetta
This series add a new acceptance test: boot an uncompressed Linux kernel built with CONFIG_PVH, so checking the PVH capability introduced in QEMU 4.0 works. The test implementation depends on [1] which is likely released on next Avocado. So that will need a version 2 of this series to bump

[PATCH 4/5] mips: r4000: Renovate coding style

2019-12-06 Thread Filip Bozuta
The script checkpatch.pl located in scripts folder was used to detect all errors and warrnings in file: hw/mips/mips_r4k.c This mips r4000 machine file was edited and all the errors and warrings generated by the checkpatch.pl script were corrected and then the script was ran again to make

Re: [PATCH v2 3/5] target/arm: Handle trapping to EL2 of AArch32 VMRS instructions

2019-12-06 Thread Marc Zyngier
On 2019-12-06 14:08, Peter Maydell wrote: On Sun, 1 Dec 2019 at 12:20, Marc Zyngier wrote: HCR_EL2.TID3 requires that AArch32 reads of MVFR[012] are trapped to EL2, and HCR_EL2.TID0 does the same for reads of FPSID. In order to handle this, introduce a new TCG helper function that checks for

Re: [PATCH v5 20/22] target/arm: Create tagged ram when MTE is enabled

2019-12-06 Thread Peter Maydell
On Thu, 5 Dec 2019 at 19:24, Richard Henderson wrote: > > On 12/5/19 10:40 AM, Peter Maydell wrote: > > Are there really separate S and NS tag RAMs? > > Implementation defined, I believe. As with everything about tag storage, it > would seem. But since there are separate S and NS normal RAMS, I

Re: [RFC v5 024/126] error: auto propagated local_err

2019-12-06 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 05.12.2019 17:58, Vladimir Sementsov-Ogievskiy wrote: >> 05.12.2019 15:36, Markus Armbruster wrote: >>> Vladimir Sementsov-Ogievskiy writes: >>> 04.12.2019 17:59, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> Here

[PATCH 0/5] mips: machines: Renovate coding style

2019-12-06 Thread Filip Bozuta
The scripts checkpatch.pl located in scripts folder was used to check for errors and warnings in fllowing mips machines: Jazz Malta Mipssim R4000 Fulong 2E Boston All generated errors and warnings were corrected and the script was ran again to make sure there are no more

Re: [PATCH] mailmap: Add entry about me

2019-12-06 Thread Philippe Mathieu-Daudé
Cc'ing qemu-trivial@ On 12/6/19 3:09 PM, Yu-Chen Lin wrote: I have two mail address, add entries for showing author and email correctly. Signed-off-by: Yu-Chen Lin --- .mailmap | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index

Re: [PATCH v3] qga: fence guest-set-time if hwclock not available

2019-12-06 Thread Markus Armbruster
Cornelia Huck writes: > On Thu, 5 Dec 2019 14:05:19 +0100 > Philippe Mathieu-Daudé wrote: > >> Hi Cornelia, >> >> On 12/5/19 12:53 PM, Cornelia Huck wrote: >> > The Posix implementation of guest-set-time invokes hwclock to >> > set/retrieve the time to/from the hardware clock. If hwclock >> >

[PATCH 1/5] mips: jazz: Renovate coding style

2019-12-06 Thread Filip Bozuta
The script checkpatch.pl located in scripts folder was used to detect all errors and warrnings in files: hw/mips/mips_jazz.c hw/display/jazz_led.c hw/dma/rc4030.c All these mips jazz machine files were edited and all the errors and warrings generated by the checkpatch.pl script were

[PATCH 1/2] tests/acceptance: Add PVH boot test

2019-12-06 Thread Wainer dos Santos Moschetta
QEMU 4.0 onward is able to boot an uncompressed kernel image by using the x86/HVM direct boot ABI. It needs Linux >= 4.21 built with CONFIG_PVH=y. This introduces an acceptance test which checks an uncompressed Linux kernel image boots properly. Signed-off-by: Wainer dos Santos Moschetta ---

Re: [PATCH v8 17/21] hw/usb: rename Error ** parameter to more common errp

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
06.12.2019 10:38, Philippe Mathieu-Daudé wrote: > On 12/5/19 6:46 PM, Vladimir Sementsov-Ogievskiy wrote: >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >>   hw/usb/dev-network.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/usb/dev-network.c

Re: [PATCH 00/10] Add Allwinner H3 SoC and Orange Pi PC Machine

2019-12-06 Thread Peter Maydell
On Tue, 3 Dec 2019 at 19:32, Niek Linnenbank wrote: > Indeed that sounds like an interesting combination. Are there plans to build > a multi-arch/single-binary QEMU? This is in the category of "it would be nice in theory to support multi-arch guest machines, and we've made some small steps in

[PATCH 2/5] mips: malta: Renovate coding style

2019-12-06 Thread Filip Bozuta
The script checkpatch.pl located in scripts folder was used to detect all errors and warrnings in files: hw/mips/mips_malta.c hw/mips/gt64xxx_pci.c tests/acceptance/linux_ssh_mips_malta.py All these mips malta machine files were edited and all the errors and warrings generated by the

[PATCH] gdbstub: change GDBState.last_packet to GByteArray

2019-12-06 Thread Damien Hedde
Remove the packet size upper limit by using a GByteArray instead of a statically allocated array for last_packet. Thus we can now send big packets. Also remove the last_packet_len field and use last_packet->len instead. Signed-off-by: Damien Hedde --- This patch is a follow-up of Alex's series

[PATCH 5/5] mips: fulong 2e: Renovate coding style

2019-12-06 Thread Filip Bozuta
The script checkpatch.pl located in scripts folder was used to detect all errors and warrnings in files: hw/mips/mips_fulong2e.c hw/isa/vt82c686.c hw/pci-host/bonito.c include/hw/isa/vt82c686.h These mips Fulong 2E machine files were edited and all the errors and warrings

Re: [PATCH 0/3] target/arm: Implement ARMv8.5-MemTag, user mode

2019-12-06 Thread Peter Maydell
On Tue, 15 Oct 2019 at 17:47, Richard Henderson wrote: > > This is a refresh of the user-only patch set from March. > > I do not attempt to implement any part of a kernel abi wrt mmap > and/or mprotect. Instead, it uses a x-tagged-pages property to > assume that all anonymous pages have tags. >

Re: [PATCH for-5.0 8/8] acpi: cpuhp: spec: document procedure for enabling modern CPU hotplug

2019-12-06 Thread Igor Mammedov
On Thu, 5 Dec 2019 15:07:53 +0100 Laszlo Ersek wrote: > On 12/04/19 18:05, Igor Mammedov wrote: > > Describe how to enable and detect modern CPU hotplug interface. > > Detection part is based on new CPHP_GET_CPU_ID_CMD command, > > introduced by "acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command"

Re: [RFC PATCH 0/9] Introduce mediate ops in vfio-pci

2019-12-06 Thread Yan Zhao
On Fri, Dec 06, 2019 at 05:40:02PM +0800, Jason Wang wrote: > > On 2019/12/6 下午4:22, Yan Zhao wrote: > > On Thu, Dec 05, 2019 at 09:05:54PM +0800, Jason Wang wrote: > >> On 2019/12/5 下午4:51, Yan Zhao wrote: > >>> On Thu, Dec 05, 2019 at 02:33:19PM +0800, Jason Wang wrote: > Hi: > >

Re: [PATCH v6 0/9] Clock framework API

2019-12-06 Thread Dr. David Alan Gilbert
* Cleber Rosa (cr...@redhat.com) wrote: > On Thu, Dec 05, 2019 at 12:01:56PM +0100, Philippe Mathieu-Daudé wrote: > > > > Understood, thanks for clearing this out! > > > > Side note, we don't do cross-arch migration testing, but we talked about > > having a 'different QEMU version' migration

Re: [PATCH v8 14/21] hw/s390x: rename Error ** parameter to more common errp

2019-12-06 Thread David Hildenbrand
On 05.12.19 18:46, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Cornelia Huck > --- > hw/s390x/event-facility.c | 2 +- > hw/s390x/s390-stattrib.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH 3/3] hw/pci: Remove the "command_serr_enable" property

2019-12-06 Thread Paolo Bonzini
On 05/12/19 17:06, Thomas Huth wrote: > diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h > index db75c6dfd0..5b6ebd15c6 100644 > --- a/include/hw/pci/pci.h > +++ b/include/hw/pci/pci.h > @@ -174,9 +174,6 @@ enum { > #define QEMU_PCI_CAP_MULTIFUNCTION_BITNR3 >

Re: [RFC PATCH 3/9] vfio/pci: register a default migration region

2019-12-06 Thread Yan Zhao
On Fri, Dec 06, 2019 at 07:55:15AM +0800, Alex Williamson wrote: > On Wed, 4 Dec 2019 22:26:38 -0500 > Yan Zhao wrote: > > > Vendor driver specifies when to support a migration region through cap > > VFIO_PCI_DEVICE_CAP_MIGRATION in vfio_pci_mediate_ops->open(). > > > > If vfio-pci detects

Re: [PATCH] gdbstub: change GDBState.last_packet to GByteArray

2019-12-06 Thread Philippe Mathieu-Daudé
On 12/6/19 2:42 PM, Damien Hedde wrote: Remove the packet size upper limit by using a GByteArray instead of a statically allocated array for last_packet. Thus we can now send big packets. Also remove the last_packet_len field and use last_packet->len instead. Signed-off-by: Damien Hedde ---

Re: [PATCH v17 6/7] migration: Include migration support for machine check handling

2019-12-06 Thread Ganesh
On 12/6/19 6:52 AM, David Gibson wrote: On Thu, Dec 05, 2019 at 10:39:29AM +0530, Ganesh wrote: On 11/19/19 8:15 AM, David Gibson wrote: On Thu, Oct 24, 2019 at 01:13:06PM +0530, Ganesh Goudar wrote: From: Aravinda Prasad This patch includes migration support for machine check handling.

Re: [PATCH v2 05/13] s390x: protvirt: Add pv state to cpu env

2019-12-06 Thread Janosch Frank
On 11/29/19 11:30 AM, David Hildenbrand wrote: > On 29.11.19 10:48, Janosch Frank wrote: >> We need to know if we run in pv state or not when emulating >> instructions. >> >> Signed-off-by: Janosch Frank >> --- >> hw/s390x/s390-virtio-ccw.c | 2 ++ >> target/s390x/cpu.h | 1 + >> 2 files

Re: [PATCH] target/i386: skip kvm_msr_entry_add when kvm_vmx_basic is 0

2019-12-06 Thread Catherine Ho
Hi Paolo and Eduardo I digged into the put msr assertion bug a little more, and seems I found the root cause. Please have a review. Best regards. Catherine On Fri, 6 Dec 2019 at 18:25, Catherine Ho wrote: > > Commit 1389309c811b ("KVM: nVMX: expose VMX capabilities for nested > hypervisors to

[PULL 0/1] KVM fix for QEMU 4.2-rc

2019-12-06 Thread Paolo Bonzini
The following changes since commit 1bdc319ab5d289ce6b822e06fb2b13666fd9278e: Update version for v4.2.0-rc4 release (2019-12-03 17:56:30 +) are available in the Git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to

Re: [PATCH v2 0/5] target/arm: More EL2 trapping fixes

2019-12-06 Thread Marc Zyngier
On 2019-12-06 14:13, Peter Maydell wrote: On Sun, 1 Dec 2019 at 12:20, Marc Zyngier wrote: Hi all, This series is a follow-up on [1], which tried to address the remaining missing HCR_EL2.TIDx traps. I've hopefully now adressed the comments that Peter and Edgar raised. I've also tried to

Re: [PATCH 06/10] arm/arm-powerctl: set NSACR.{CP11, CP10} bits in arm_set_cpu_on()

2019-12-06 Thread Peter Maydell
On Mon, 2 Dec 2019 at 21:10, Niek Linnenbank wrote: > > This change ensures that the FPU can be accessed in Non-Secure mode > when the CPU core is reset using the arm_set_cpu_on() function call. > The NSACR.{CP11,CP10} bits define the exception level required to > access the FPU in Non-Secure

Re: [RFC PATCH 1/9] vfio/pci: introduce mediate ops to intercept vfio-pci ops

2019-12-06 Thread Yan Zhao
On Fri, Dec 06, 2019 at 07:55:19AM +0800, Alex Williamson wrote: > On Wed, 4 Dec 2019 22:25:36 -0500 > Yan Zhao wrote: > > > when vfio-pci is bound to a physical device, almost all the hardware > > resources are passthroughed. > > Sometimes, vendor driver of this physcial device may want to

Re: [PATCH v2 5/5] target/arm: Add support for missing Jazelle system registers

2019-12-06 Thread Peter Maydell
On Mon, 2 Dec 2019 at 15:58, Richard Henderson wrote: > > On 12/1/19 12:20 PM, Marc Zyngier wrote: > > +if (cpu_isar_feature(jazelle, cpu)) { > > +ARMCPRegInfo jazelle_regs[] = { > > static const. If this can be static const we should just declare it at file scope. The only arrays we

Re: [PATCH v2 06/13] s390x: protvirt: KVM intercept changes

2019-12-06 Thread Janosch Frank
On 12/6/19 9:29 AM, Cornelia Huck wrote: > On Fri, 6 Dec 2019 08:44:52 +0100 > Janosch Frank wrote: > >> On 12/5/19 6:46 PM, Cornelia Huck wrote: >>> On Thu, 5 Dec 2019 18:34:32 +0100 >>> Janosch Frank wrote: >>> On 12/5/19 6:15 PM, Cornelia Huck wrote: > On Fri, 29 Nov 2019

Re: [Qemu-devel] [PATCH v5 0/2] arm/acpi: simplify aml code and enable SHPC

2019-12-06 Thread Peter Maydell
On Sat, 30 Nov 2019 at 03:47, Guoheyi wrote: > > Hi Peter, Igor, > > I couldn't find these 2 patches in the latest tree. Could you help to > merge them? In future I recommend pinging unapplied patches with a shorter delay than nine months :-) In QEMU's process, unless somebody has specifically

Re: [PULL 0/1] ppc-for-4.2 queue 20191206

2019-12-06 Thread Peter Maydell
> > > > > The following changes since commit > > > > 1bdc319ab5d289ce6b822e06fb2b13666fd9278e: > > > > > > > > Update version for v4.2.0-rc4 release (2019-12-03 17:56:30 +) > > > > > > > > are available in the Git repos

Re: [PATCH v2] s390x/tcg: clear local interrupts on reset normal

2019-12-06 Thread Philippe Mathieu-Daudé
On 12/6/19 2:54 PM, Cornelia Huck wrote: We neglected to clean up pending interrupts and emergency signals; fix that. Signed-off-by: Cornelia Huck --- v1->v2: - rebased on top of my s390-next branch; we can now move the fields to be reset instead of clearing them manually Yep, much

Re: [PATCH 08/10] arm: allwinner-h3: add Security Identifier device

2019-12-06 Thread Peter Maydell
On Mon, 2 Dec 2019 at 21:10, Niek Linnenbank wrote: > > The Security Identifier device in Allwinner H3 System on Chip > gives applications a per-board unique identifier. This commit > adds support for the Allwinner H3 Security Identifier using > randomized data as input. If this is a fixed value

Re: [PATCH v8 04/21] hmp: drop Error pointer indirection in hmp_handle_error

2019-12-06 Thread Philippe Mathieu-Daudé
On 12/5/19 6:46 PM, Vladimir Sementsov-Ogievskiy wrote: We don't need Error **, as all callers pass local Error object, which isn't used after the call. Use Error * instead. Good idea. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Dr. David Alan

Re: [PATCH 2/2] analyze-migration.py: replace numpy with python 3.2

2019-12-06 Thread Cleber Rosa
On Wed, Nov 27, 2019 at 02:10:38PM +0400, Marc-André Lureau wrote: > Use int.from_bytes() from python 3.2 instead. > > Signed-off-by: Marc-André Lureau > --- > scripts/analyze-migration.py | 35 +++ > 1 file changed, 19 insertions(+), 16 deletions(-) > > diff

Re: [PULL 0/1] ppc-for-4.2 queue 20191206

2019-12-06 Thread David Gibson
) > > > > are available in the Git repository at: > > > > git://github.com/dgibson/qemu.git tags/ppc-for-4.2-20191206 > > > > for you to fetch changes up to d887a8cfc083bcf3856f9f42352989f3624e0cae: > >

Re: [PATCH v2 06/13] s390x: protvirt: KVM intercept changes

2019-12-06 Thread Cornelia Huck
On Fri, 6 Dec 2019 08:44:52 +0100 Janosch Frank wrote: > On 12/5/19 6:46 PM, Cornelia Huck wrote: > > On Thu, 5 Dec 2019 18:34:32 +0100 > > Janosch Frank wrote: > > > >> On 12/5/19 6:15 PM, Cornelia Huck wrote: > >>> On Fri, 29 Nov 2019 04:48:02 -0500 > >>> Janosch Frank wrote: > >>>

Re: [PATCH v2] s390x/tcg: clear local interrupts on reset normal

2019-12-06 Thread David Hildenbrand
On 06.12.19 14:54, Cornelia Huck wrote: > We neglected to clean up pending interrupts and emergency signals; > fix that. > > Signed-off-by: Cornelia Huck > --- > > v1->v2: > - rebased on top of my s390-next branch; we can now move the fields > to be reset instead of clearing them manually >

[PATCH] target/i386: disable VMX features if nested=0

2019-12-06 Thread Yang Zhong
If kvm does not support VMX feature by nested=0, the kvm_vmx_basic can't get the right value from MSR_IA32_VMX_BASIC register, which make qemu coredump when qemu do KVM_SET_MSRS. The coredump info: error: failed to set MSR 0x480 to 0x0 kvm_put_msrs: Assertion `ret == cpu->kvm_msr_buf->nmsrs'

Re: [PATCH 06/21] io: Fix Error usage in a comment

2019-12-06 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 30.11.2019 22:42, Markus Armbruster wrote: >> Cc: "Daniel P. Berrangé" >> Signed-off-by: Markus Armbruster >> --- >> include/io/task.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/io/task.h b/include/io/task.h >>

Re: [PATCH 3/5] mips: mipssim: Renovate coding style

2019-12-06 Thread Aleksandar Markovic
On Monday, November 25, 2019, Filip Bozuta wrote: > The script checkpatch.pl located in scripts folder was > used to detect all errors and warrnings in files: > hw/mips/mips_mipssim.c > hw/net/mipsnet.c > > All these mips mipssim machine files were edited and > all the errors and

Re: [PATCH for-4.2?] block/qcow2-bitmap: fix crash bug in qcow2_co_remove_persistent_dirty_bitmap

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
05.12.2019 23:09, Eric Blake wrote: > On 12/5/19 1:30 PM, Vladimir Sementsov-Ogievskiy wrote: >> Here is double bug: >> >> First, return error but not set errp. This may lead to: >> qmp block-dirty-bitmap-remove may report success when actually failed >> >> block-dirty-bitmap-remove used in a

Re: [PATCH v8 11/21] hw/i386/amd_iommu: rename Error ** parameter to more common errp

2019-12-06 Thread Philippe Mathieu-Daudé
On 12/5/19 6:46 PM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/amd_iommu.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c

[PATCH] qapi: better document NVMe blockdev @device parameter

2019-12-06 Thread Daniel P . Berrangé
Mention that this is a PCI device address & give the format it is expected it. Also mention that it must be first unbound from any host kernel driver. Signed-off-by: Daniel P. Berrangé --- qapi/block-core.json | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH-for-5.0] hw/arm/sbsa-ref: Call qdev_get_gpio_in in place

2019-12-06 Thread Philippe Mathieu-Daudé
Instead of filling an array of qemu_irq and passing it around, directly call qdev_get_gpio_in() on the GIC. Signed-off-by: Philippe Mathieu-Daudé --- I accept better patch subject suggestions :) --- hw/arm/sbsa-ref.c | 58 +++ 1 file changed, 29

Re: [PATCH v8 03/21] error: make Error **errp const where it is appropriate

2019-12-06 Thread Philippe Mathieu-Daudé
On 12/5/19 6:46 PM, Vladimir Sementsov-Ogievskiy wrote: Mostly, Error ** is for returning error from the function, so the callee sets it. However these three functions get already filled errp parameter. They dont change the pointer itself, only change the internal state of referenced Error

Re: [PATCH v8 16/21] hw/tpm: rename Error ** parameter to more common errp

2019-12-06 Thread Philippe Mathieu-Daudé
On 12/5/19 6:46 PM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Berger Reviewed-by: Philippe Mathieu-Daudé --- hw/tpm/tpm_emulator.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/tpm/tpm_emulator.c

Re: [PATCH v6] hw/core/qdev: cleanup Error ** variables

2019-12-06 Thread Markus Armbruster
Eric Blake writes: > On 12/5/19 8:48 AM, Vladimir Sementsov-Ogievskiy wrote: > @@ -918,27 +917,26 @@ static void device_set_realized(Object *obj, bool value, Error **errp) } } else if (!value && dev->realized) { -Error **local_errp = NULL;

Re: [PATCH v8 13/21] monitor/qmp-cmds: rename Error ** parameter to more common errp

2019-12-06 Thread Philippe Mathieu-Daudé
On 12/5/19 6:46 PM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Philippe Mathieu-Daudé --- monitor/qmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor/qmp-cmds.c b/monitor/qmp-cmds.c index

Re: [PATCH] qapi: better document NVMe blockdev @device parameter

2019-12-06 Thread Stefan Hajnoczi
On Fri, Dec 06, 2019 at 02:38:11PM +, Daniel P. Berrangé wrote: > Mention that this is a PCI device address & give the format it is > expected it. Also mention that it must be first unbound from any > host kernel driver. > > Signed-off-by: Daniel P. Berrangé > --- > qapi/block-core.json | 6

Re: [PATCH] s390x/tcg: clear local interrupts on reset normal

2019-12-06 Thread Cornelia Huck
On Fri, 6 Dec 2019 10:36:40 +0100 David Hildenbrand wrote: > On 05.12.19 11:38, Cornelia Huck wrote: > > We neglected to clean up pending interrupts and emergency signals; > > fix that. > > > > Signed-off-by: Cornelia Huck > > --- > > > > Noted while looking at the fixes for the kvm reset

Re: [PATCH 2/5] mips: malta: Renovate coding style

2019-12-06 Thread Aleksandar Markovic
On Thursday, December 5, 2019, Cleber Rosa wrote: > On Mon, Dec 02, 2019 at 05:49:58PM -0300, Eduardo Habkost wrote: > > On Sun, Dec 01, 2019 at 12:46:12AM +0100, Aleksandar Markovic wrote: > > > On Monday, November 25, 2019, Filip Bozuta > wrote: > > > > > > > The script checkpatch.pl located

Re: [PATCH 0/3] Remove deprecated pc-0.x machine types and related hacks

2019-12-06 Thread Thomas Huth
On 06/12/2019 07.49, Markus Armbruster wrote: > Thomas Huth writes: > >> These have been on the deprecation list since a year now, so it's >> time to finally remove the pc-0.x machine types. >> >> We then can also remove some compatibility hacks in the devices, i.e. >> the "use_broken_id" in

Re: [PATCH v5 21/22] target/arm: Add mmu indexes for tag memory

2019-12-06 Thread Peter Maydell
On Fri, 11 Oct 2019 at 14:50, Richard Henderson wrote: > > The process by which one goes from an address space plus physical > address to a host pointer is complex. It is easiest to reuse the > mechanism already present within cputlb, and letting that cache > the results. > > Signed-off-by:

Re: [RFC PATCH 4/9] vfio-pci: register default dynamic-trap-bar-info region

2019-12-06 Thread Yan Zhao
On Fri, Dec 06, 2019 at 07:55:30AM +0800, Alex Williamson wrote: > On Wed, 4 Dec 2019 22:26:50 -0500 > Yan Zhao wrote: > > > Dynamic trap bar info region is a channel for QEMU and vendor driver to > > communicate dynamic trap info. It is of type > > VFIO_REGION_TYPE_DYNAMIC_TRAP_BAR_INFO and

[PATCH] hw/core: Fix data type in do_nmi()

2019-12-06 Thread Gavin Shan
object_dynamic_cast() should return machine (or GPIO) state instad of NMI state in do_nmi(). So it's wrong to convert it to NMI state unconditionally. This changes the prototype of NMIClass::nmi_monitor_handler() to accept the parent object of NMI state instead of itself. With this, he parent

Re: [PATCH-for-4.2? v2 1/2] tests/boot_linux_console: Fetch assets from Debian snapshot archives

2019-12-06 Thread Cleber Rosa
On Tue, Nov 26, 2019 at 11:38:09PM +0100, Philippe Mathieu-Daudé wrote: > The kernel packaged was fetched from an unstable repository. > Use the stable snapshot archive instead. > > Reviewed-by: Alex Bennée > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: > - Rebased > - Dropped Alex's

Re: [PATCH] target/i386: skip kvm_msr_entry_add when kvm_vmx_basic is 0

2019-12-06 Thread Paolo Bonzini
On 06/12/19 11:23, Catherine Ho wrote: > Commit 1389309c811b ("KVM: nVMX: expose VMX capabilities for nested > hypervisors to userspace") expands the msr_based_features with > MSR_IA32_VMX_BASIC and others. Then together with an old kernel before > 1389309c811b, the qemu call

Re: [PATCH] s390x/tcg: clear local interrupts on reset normal

2019-12-06 Thread David Hildenbrand
On 05.12.19 11:38, Cornelia Huck wrote: > We neglected to clean up pending interrupts and emergency signals; > fix that. > > Signed-off-by: Cornelia Huck > --- > > Noted while looking at the fixes for the kvm reset handling. > > We now clear some fields twice in the paths for clear or initial

Re: [RFC PATCH 0/9] Introduce mediate ops in vfio-pci

2019-12-06 Thread Jason Wang
On 2019/12/6 下午4:22, Yan Zhao wrote: On Thu, Dec 05, 2019 at 09:05:54PM +0800, Jason Wang wrote: On 2019/12/5 下午4:51, Yan Zhao wrote: On Thu, Dec 05, 2019 at 02:33:19PM +0800, Jason Wang wrote: Hi: On 2019/12/5 上午11:24, Yan Zhao wrote: For SRIOV devices, VFs are passthroughed into guest

Re: [PATCH v8 06/21] qdev-monitor: well form error hint helpers

2019-12-06 Thread Philippe Mathieu-Daudé
On 12/5/19 6:46 PM, Vladimir Sementsov-Ogievskiy wrote: Make qbus_list_bus and qbus_list_dev hint append helpers well formed: switch errp paramter to Error *const * type, as it has uncommon "parameter" behavior: not change the pointer to return error, but operate on already existent error

Re: [PATCH 10/21] hw/core: Fix latent fit_load_fdt() error handling bug

2019-12-06 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 30.11.2019 22:42, Markus Armbruster wrote: >> fit_load_fdt() recovers from fit_image_addr() failing with ENOENT. >> Except it doesn't when its @errp argument is _fatal or >> _abort, because it blindly passes @errp to fit_image_addr(). >> Messed up in commit

Re: [PATCH v5 03/22] target/arm: Add MTE system registers

2019-12-06 Thread Richard Henderson
On 12/3/19 3:48 AM, Peter Maydell wrote: >> +{ .name = "GMID_EL1", .state = ARM_CP_STATE_AA64, >> + .opc0 = 3, .opc1 = 1, .crn = 0, .crm = 0, .opc2 = 4, >> + .access = PL1_R, .type = ARM_CP_CONST, .resetvalue = GMID_EL1_BS }, > > This should trap if HCR_EL2.TID5 is 1 (since we're

Re: [PATCH v8 14/21] hw/s390x: rename Error ** parameter to more common errp

2019-12-06 Thread Philippe Mathieu-Daudé
On 12/5/19 6:46 PM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Cornelia Huck Reviewed-by: Philippe Mathieu-Daudé --- hw/s390x/event-facility.c | 2 +- hw/s390x/s390-stattrib.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)

  1   2   3   >