Re: [kvm-unit-tests PATCH v2 13/16] arm/arm64: ITS: INT functional tests

2020-01-16 Thread Andrew Jones
On Wed, Jan 15, 2020 at 06:11:23PM +0100, Auger Eric wrote: > >> +static int its_prerequisites(int nb_cpus) > >> +{ > >> + int cpu; > >> + > >> + if (!gicv3_its_base()) { > >> + report_skip("No ITS, skip ..."); > >> + return -1; > >> + } > >> + > >> + if (nr_cpus < 4) { > >>

Re: [PATCH v2 63/86] ppc:pnv: use memdev for RAM

2020-01-16 Thread Cédric Le Goater
On 1/15/20 4:07 PM, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing > MachineClass::default_ram_id > and

Re: [PATCH v2 38/86] s390x:s390-virtio-ccw: use memdev for RAM

2020-01-16 Thread David Hildenbrand
On 15.01.20 16:06, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing > MachineClass::default_ram_id > and

Re: [PATCH] ui/gtk: Get display refresh rate with GDK version 3.22 or later

2020-01-16 Thread Gerd Hoffmann
Hi, > Fixes: c4c00922cc (display/gtk: get proper refreshrate) > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Gerd Hoffmann > --- > Sorry I missed that, I only tested Nikola's patch on my workstation > which runs Fedora 30: > > $ pkg-config --modversion gtk+-3.0 > 3.24.11 Even

Re: [PATCH v2 08/86] arm:aspeed: actually check RAM size

2020-01-16 Thread Cédric Le Goater
On 1/15/20 4:06 PM, Igor Mammedov wrote: > It's supposed that SOC will check if "-m" provided > RAM size is valid by setting "ram-size" property and > then board would read back valid (possibly corrected > value) to map RAM MemoryReging with valid size. > Well it isn't doing so, since check is

Re: [PATCH v7 03/11] hw/core: create Resettable QOM interface

2020-01-16 Thread Damien Hedde
On 1/16/20 2:59 AM, Philippe Mathieu-Daudé wrote: > On 1/15/20 1:36 PM, Damien Hedde wrote: >> This commit defines an interface allowing multi-phase reset. This aims >> to solve a problem of the actual single-phase reset (built in >> DeviceClass and BusClass): reset behavior is dependent on the

[PATCH] block: fix memleaks in bdrv_refresh_filename

2020-01-16 Thread pannengyuan
From: Pan Nengyuan If we call the qmp 'query-block' while qemu is working on 'block-commit', it will cause memleaks, the memory leak stack is as follow: Indirect leak of 12360 byte(s) in 3 object(s) allocated from: #0 0x7f80f0b6d970 in __interceptor_calloc (/lib64/libasan.so.5+0xef970)

[PATCH] Makefile: Keep trace-events-subdirs ordered

2020-01-16 Thread Philippe Mathieu-Daudé
To ease review and reduce likelihood of merge failures (see [*]), keep trace-events-subdirs ordered when possible, following eb7ccb3c0. [*] https://www.mail-archive.com/qemu-devel@nongnu.org/msg671007.html Duplicate trace-events-subdirs entries generates duplicated symbols when using the

Re: [PATCH v2 10/86] arm:aspeed: use memdev for RAM

2020-01-16 Thread Cédric Le Goater
On 1/15/20 4:06 PM, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing > MachineClass::default_ram_id > and

[Bug 1859916] Re: coreaudio not working on MacOS

2020-01-16 Thread Mark Cave-Ayland
First thing to check is whether you have any other audio applications installed, since there seems to be a long running issue whereby other applications can prevent QEMU from being able to output audio. See

Re: [PATCH v3 4/4] block: Mark 'block_resize' as coroutine

2020-01-16 Thread Markus Armbruster
Kevin Wolf writes: > block_resize is safe to run in a coroutine, so use it as an example for > the new 'coroutine': true annotation in the QAPI schema. > > Signed-off-by: Kevin Wolf > Reviewed-by: Marc-André Lureau > --- > qapi/block-core.json | 3 ++- > blockdev.c | 6 +++--- > 2

Re: [PATCH 1/4] qemu-file: Don't do IO after shutdown

2020-01-16 Thread Juan Quintela
Juan Quintela wrote: > "Dr. David Alan Gilbert" wrote: >> * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: >>> * Juan Quintela (quint...@redhat.com) wrote: >> >> diff --git a/migration/qemu-file.c b/migration/qemu-file.c >> index 1e5543a279..bbb2b63927 100644 >> --- a/migration/qemu-file.c

Re: [PATCH] Makefile: Keep trace-events-subdirs ordered

2020-01-16 Thread Philippe Mathieu-Daudé
On 1/16/20 10:13 AM, Philippe Mathieu-Daudé wrote: To ease review and reduce likelihood of merge failures (see [*]), keep trace-events-subdirs ordered when possible, following eb7ccb3c0. [*] https://www.mail-archive.com/qemu-devel@nongnu.org/msg671007.html Duplicate trace-events-subdirs

Re: [PATCH] ui/gtk: Get display refresh rate with GDK version 3.22 or later

2020-01-16 Thread Philippe Mathieu-Daudé
On 1/16/20 11:16 AM, Daniel P. Berrangé wrote: On Thu, Jan 16, 2020 at 02:12:17AM +0100, Philippe Mathieu-Daudé wrote: The GdkMonitor was introduced in GTK+ 3.22: https://developer.gnome.org/gdk3/stable/api-index-3-22.html#api-index-3.22 If we build with older GTK+, the build fails:

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-16 Thread Greg Kurz
On Wed, 15 Jan 2020 19:10:37 +0100 Laurent Vivier wrote: > Hi, > > On 15/01/2020 18:48, Greg Kurz wrote: > > Migration can potentially race with CAS reboot. If the migration thread > > completes migration after CAS has set spapr->cas_reboot but before the > > mainloop could pick up the reset

Re: [PATCH v2 68/86] ppc:prep: use memdev for RAM

2020-01-16 Thread Mark Cave-Ayland
On 15/01/2020 15:07, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing > MachineClass::default_ram_id >

Re: [PATCH v7 10/11] vl: replace deprecated qbus_reset_all registration

2020-01-16 Thread Damien Hedde
On 1/16/20 12:44 AM, Philippe Mathieu-Daudé wrote: > On 1/15/20 1:36 PM, Damien Hedde wrote: >> Replace deprecated qbus_reset_all by resettable_cold_reset_fn for >> the sysbus reset registration. >> >> Apart for the raspi machines, this does not impact the behavior >> because: >> + at this

Re: [PATCH v7 03/11] hw/core: create Resettable QOM interface

2020-01-16 Thread Philippe Mathieu-Daudé
On 1/16/20 9:53 AM, Damien Hedde wrote: On 1/16/20 2:59 AM, Philippe Mathieu-Daudé wrote: On 1/15/20 1:36 PM, Damien Hedde wrote: This commit defines an interface allowing multi-phase reset. This aims to solve a problem of the actual single-phase reset (built in DeviceClass and BusClass):

[PATCH] hw/arm: Adjust some coding styles about memory hotplug

2020-01-16 Thread Keqian Zhu
From: zhukeqian There is extra indent in ACPI GED plug cb. And we can use existing helper function to trigger hotplug handler plug. Signed-off-by: Keqian Zhu Cc: Shameer Kolothum Cc: "Michael S. Tsirkin" Cc: Igor Mammedov --- hw/acpi/generic_event_device.c | 2 +- hw/arm/virt.c

Re: [PATCH] block: fix memleaks in bdrv_refresh_filename

2020-01-16 Thread Max Reitz
On 16.01.20 09:56, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > If we call the qmp 'query-block' while qemu is working on > 'block-commit', it will cause memleaks, the memory leak stack is as > follow: > > Indirect leak of 12360 byte(s) in 3 object(s) allocated from: > #0

Re: [PATCH] Makefile: Keep trace-events-subdirs ordered

2020-01-16 Thread Damien Hedde
On 1/16/20 10:13 AM, Philippe Mathieu-Daudé wrote: > To ease review and reduce likelihood of merge failures (see [*]), > keep trace-events-subdirs ordered when possible, following eb7ccb3c0. > > [*] https://www.mail-archive.com/qemu-devel@nongnu.org/msg671007.html > Duplicate

Re: [PATCH] ui/gtk: Get display refresh rate with GDK version 3.22 or later

2020-01-16 Thread Daniel P . Berrangé
On Thu, Jan 16, 2020 at 02:12:17AM +0100, Philippe Mathieu-Daudé wrote: > The GdkMonitor was introduced in GTK+ 3.22: > https://developer.gnome.org/gdk3/stable/api-index-3-22.html#api-index-3.22 > > If we build with older GTK+, the build fails: Presumably the problem here is Ubuntu Xenial 16.04

RE: [PATCH] tests: acpi: update path in rebuild-expected-aml

2020-01-16 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: 15 January 2020 13:46 > To: Shameerali Kolothum Thodi > Cc: Thomas Huth ; qemu-devel@nongnu.org; > imamm...@redhat.com; xuwei (O) ; Linuxarm > > Subject: Re: [PATCH] tests: acpi: update path in

Re: [PATCH v2] qcow2: Use a GString in report_unsupported_feature()

2020-01-16 Thread Stefano Garzarella
On Wed, Jan 15, 2020 at 02:56:26PM +0100, Alberto Garcia wrote: > This is a bit more efficient than having to allocate and free memory > for each item. > > The default size (60) is enough for all the existing incompatible > features or the "Unknown incompatible feature" message. > >

Re: [PATCH v2 62/86] ppc:mac_oldworld: use memdev for RAM

2020-01-16 Thread Mark Cave-Ayland
On 15/01/2020 15:07, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing > MachineClass::default_ram_id >

Re: [PATCH v2 61/86] ppc:mac_newworld: use memdev for RAM

2020-01-16 Thread Mark Cave-Ayland
On 15/01/2020 15:07, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing > MachineClass::default_ram_id >

Re: [PATCH v2 73/86] sparc:sun4m: use memdev for RAM

2020-01-16 Thread Mark Cave-Ayland
On 15/01/2020 15:07, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing > MachineClass::default_ram_id >

Re: [PATCH v5 08/22] gdbstub: extend GByteArray to read register helpers

2020-01-16 Thread Damien Hedde
On 1/14/20 4:09 PM, Alex Bennée wrote: > Instead of passing a pointer to memory now just extend the GByteArray > to all the read register helpers. They can then safely append their > data through the normal way. We don't bother with this abstraction for > write registers as we have already

Re: [PATCH v5 02/22] gdbstub: stop passing GDBState * around and use global

2020-01-16 Thread Damien Hedde
On 1/14/20 4:09 PM, Alex Bennée wrote: > We only have one GDBState which should be allocated at the time we > process any commands. This will make further clean-up a bit easier. > > Signed-off-by: Alex Bennée > Reviewed-by: Richard Henderson > > --- > v3 > - remove final *s paramters from

Re: [PATCH v3 4/4] block: Mark 'block_resize' as coroutine

2020-01-16 Thread Kevin Wolf
Am 16.01.2020 um 10:45 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > block_resize is safe to run in a coroutine, so use it as an example for > > the new 'coroutine': true annotation in the QAPI schema. > > > > Signed-off-by: Kevin Wolf > > Reviewed-by: Marc-André Lureau > > diff

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-16 Thread Laurent Vivier
On 16/01/2020 09:48, Greg Kurz wrote: > On Wed, 15 Jan 2020 19:10:37 +0100 > Laurent Vivier wrote: > >> Hi, >> >> On 15/01/2020 18:48, Greg Kurz wrote: >>> Migration can potentially race with CAS reboot. If the migration thread >>> completes migration after CAS has set spapr->cas_reboot but

Re: [PATCH] target/s390x/kvm: Enable adapter interruption suppression again

2020-01-16 Thread Thomas Huth
On 16/01/2020 13.50, Cornelia Huck wrote: > On Thu, 16 Jan 2020 13:20:26 +0100 > Thomas Huth wrote: > >> The AIS feature has been disabled late in the v2.10 development >> cycle since there were some issues with migration (see commit >> 3f2d07b3b01ea61126b - "s390x/ais: for 2.10 stable: disable

Re: [PATCH] target/s390x/kvm: Enable adapter interruption suppression again

2020-01-16 Thread Christian Borntraeger
On 16.01.20 13:55, Thomas Huth wrote: > On 16/01/2020 13.50, Cornelia Huck wrote: >> On Thu, 16 Jan 2020 13:20:26 +0100 >> Thomas Huth wrote: >> >>> The AIS feature has been disabled late in the v2.10 development >>> cycle since there were some issues with migration (see commit >>>

Re: [libvirt] [PATCH v2 82/86] numa: forbid '-numa node, mem' for 5.0 and newer machine types

2020-01-16 Thread Igor Mammedov
On Thu, 16 Jan 2020 13:06:28 + Daniel P. Berrangé wrote: > On Thu, Jan 16, 2020 at 01:37:03PM +0100, Igor Mammedov wrote: > > On Thu, 16 Jan 2020 11:42:09 +0100 > > Michal Privoznik wrote: > > > > > On 1/15/20 5:52 PM, Igor Mammedov wrote: > > > > On Wed, 15 Jan 2020 16:34:53 +0100 > >

Re: Bug? qemu-img convert to preallocated image makes it sparse

2020-01-16 Thread Max Reitz
On 16.01.20 15:57, Eric Blake wrote: > On 1/16/20 8:47 AM, Max Reitz wrote: > >> So when you convert to the target image, you have to make sure all areas >> that are zero in the source are zero in the target, too.  The way we do >> that is to write zeroes to the target.  The problem is that this

[PATCH v3 4/5] qemu-file: Don't do IO after shutdown

2020-01-16 Thread Juan Quintela
Be sure that we are not doing neither read/write after shutdown of the QEMUFile. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- Set error in case that there is none (dave) --- migration/qemu-file.c | 22 +- 1 file

Re: [PATCH] tests/qtest/vhost-user-test: Fix memory leaks

2020-01-16 Thread Philippe Mathieu-Daudé
On 1/16/20 3:07 PM, Thomas Huth wrote: Do not allocate resources in case we return early, and make sure to free dest_cmdline at the end. Reported-by: Euler Robot Reported-by: Pan Nengyuan Signed-off-by: Thomas Huth --- Based on a similar patch by Pan Nengyuan:

Re: [PATCH 095/104] virtiofsd: convert more fprintf and perror to use fuse log infra

2020-01-16 Thread Dr. David Alan Gilbert
* Misono Tomohiro (misono.tomoh...@jp.fujitsu.com) wrote: > > From: Eryu Guan > > > > Signed-off-by: Eryu Guan > > --- > > tools/virtiofsd/fuse_signals.c | 6 +- > > tools/virtiofsd/helper.c | 9 ++--- > > 2 files changed, 11 insertions(+), 4 deletions(-) > > > > diff --git

Re: [PATCH 072/104] virtiofsd: passthrough_ll: fix refcounting on remove/rename

2020-01-16 Thread Dr. David Alan Gilbert
* Misono Tomohiro (misono.tomoh...@jp.fujitsu.com) wrote: > > From: Miklos Szeredi > > > > Signed-off-by: Miklos Szeredi > > I'm not familiar with qemu convention but shouldn't we put > at least one line of description like linux kernel? Miklos: would you like to suggest a better commit

Re: [PATCH v2 85/86] numa: make exit() usage consistent

2020-01-16 Thread Thomas Huth
On 15/01/2020 16.07, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > CC: ehabk...@redhat.com > --- > hw/core/numa.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/core/numa.c b/hw/core/numa.c > index 3177066..47d5ea1 100644 > --- a/hw/core/numa.c >

Re: [libvirt] [PATCH v2 82/86] numa: forbid '-numa node, mem' for 5.0 and newer machine types

2020-01-16 Thread Michal Privoznik
On 1/16/20 1:37 PM, Igor Mammedov wrote: On Thu, 16 Jan 2020 11:42:09 +0100 Michal Privoznik wrote: On 1/15/20 5:52 PM, Igor Mammedov wrote: On Wed, 15 Jan 2020 16:34:53 +0100 Peter Krempa wrote: On Wed, Jan 15, 2020 at 16:07:37 +0100, Igor Mammedov wrote: Deprecation period is ran

[PATCH] tests/qtest/vhost-user-test: Fix memory leaks

2020-01-16 Thread Thomas Huth
Do not allocate resources in case we return early, and make sure to free dest_cmdline at the end. Reported-by: Euler Robot Reported-by: Pan Nengyuan Signed-off-by: Thomas Huth --- Based on a similar patch by Pan Nengyuan: https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg02183.html

[PATCH 2/3] docs: Create stub system manual

2020-01-16 Thread Peter Maydell
We want a user-facing manual which contains system emulation documentation. Create an empty one which we can populate. Signed-off-by: Peter Maydell --- Makefile | 10 +- docs/system/conf.py | 15 +++ docs/system/index.rst | 16 3 files

Re: [PULL 20/87] vl: warn for unavailable accelerators, clarify messages

2020-01-16 Thread Laurent Vivier
On 18/12/2019 13:01, Paolo Bonzini wrote: > So far, specifying an accelerator that was not compiled in did not result > in an error; fix that. > > While at it, clarify the mysterious "Back to TCG" message. Every time I run a non native VM I have this message: $ uname -m x86_64 $

Re: Bug? qemu-img convert to preallocated image makes it sparse

2020-01-16 Thread Eric Blake
On 1/16/20 8:47 AM, Max Reitz wrote: So when you convert to the target image, you have to make sure all areas that are zero in the source are zero in the target, too. The way we do that is to write zeroes to the target. The problem is that this operation disregards the previous preallocation

Re: [PATCH v3 4/4] block: Mark 'block_resize' as coroutine

2020-01-16 Thread Markus Armbruster
Kevin Wolf writes: > Am 16.01.2020 um 10:45 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> > block_resize is safe to run in a coroutine, so use it as an example for >> > the new 'coroutine': true annotation in the QAPI schema. >> > >> > Signed-off-by: Kevin Wolf >> > Reviewed-by:

Re: [PATCH v2] ui/gtk: Get display refresh rate with GDK version 3.22 or later

2020-01-16 Thread Peter Maydell
On Thu, 16 Jan 2020 at 11:54, Philippe Mathieu-Daudé wrote: > > Commit c4c00922cc introduced the use of the GdkMonitor API, which > was introduced in GTK+ 3.22: > https://developer.gnome.org/gdk3/stable/api-index-3-22.html#api-index-3.22 > > Unfortunately this break building with older versions,

[PATCH v3 2/5] migration: Create MigrationState active field

2020-01-16 Thread Juan Quintela
Right now, there is no easy way to dectect if we have already cancelled/finished/failed a migration. This field is setup to true when we start a migration, and it is set to false as soon as we stop it. It fixes a real bug, in ram_save_iterate() we call functions that wrote to the channel even if

[PATCH v3 3/5] migration: Don't wait in semaphore for thread we know has finished

2020-01-16 Thread Juan Quintela
If p->quit is true for any channel, we know that it has finished for any reason. So don't wait for it, just continue. Signed-off-by: Juan Quintela --- I could be convinced that the right thing to do in that case is to just do a break instead of a continue. Each option has its own

Re: [PATCH v3 5/5] migration-test: Make sure that multifd and cancel works

2020-01-16 Thread Thomas Huth
On 16/01/2020 16.46, Juan Quintela wrote: > Test that this sequerce works: > > - launch source > - launch target > - start migration > - cancel migration > - relaunch target > - do migration again > > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert [...] > +static void

Re: Bug? qemu-img convert to preallocated image makes it sparse

2020-01-16 Thread Max Reitz
On 16.01.20 17:00, Richard W.M. Jones wrote: > On Thu, Jan 16, 2020 at 05:38:03PM +0200, Maxim Levitsky wrote: >> How about doing write zeros without discard only in this particular case >> (convert to existing image) >> Basically omitting the BDRV_REQ_MAY_UNMAP flag to blk_co_pwrite_zeroes. >>

[PATCH v19 3/7] target/ppc: Handle NMI guest exit

2020-01-16 Thread Ganesh Goudar
From: Aravinda Prasad Memory error such as bit flips that cannot be corrected by hardware are passed on to the kernel for handling. If the memory address in error belongs to guest then the guest kernel is responsible for taking suitable action. Patch [1] enhances KVM to exit guest with exit

[PATCH v19 1/7] Wrapper function to wait on condition for the main loop mutex

2020-01-16 Thread Ganesh Goudar
From: Aravinda Prasad Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the condition. This wrapper is required because qemu_global_mutex is a static variable. Signed-off-by:

Re: [PATCH v2 83/86] tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups

2020-01-16 Thread Igor Mammedov
On Thu, 16 Jan 2020 17:35:32 +0100 Thomas Huth wrote: > On 15/01/2020 16.07, Igor Mammedov wrote: > > Use GString to pass argument to make_cli() so that it would be easy > > to dynamically change test case arguments from main(). The follow up > > patch will use it to change RAM size options

[Bug 1859916] Re: coreaudio not working on MacOS

2020-01-16 Thread JS
I am not using any audio enhancing software. I start trying qemu + Ubuntu Desktop a few weeks ago and put all configurations together last week, so I never try coreaudio on 4.1. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PULL 0/6] QAPI patches for 2020-01-14

2020-01-16 Thread Peter Maydell
On Tue, 14 Jan 2020 at 10:22, Markus Armbruster wrote: > > My previous pull request failed tests with Python 2, which is now > gone. Try again. > > The following changes since commit dc65a5bdc9fa543690a775b50d4ffbeb22c56d6d: > > Merge remote-tracking branch

[PATCH 3/3] qemu-block-drivers: Convert to rST

2020-01-16 Thread Peter Maydell
The qemu-block-drivers documentation is currently in docs/qemu-block-drivers.texi in Texinfo format, which we present to the user as: * a qemu-block-drivers manpage * a section of the main qemu-doc HTML documentation Convert the documentation to rST format, and present it to the user as: * a

Re: [PATCH 041/104] virtiofsd: add fuse_mbuf_iter API

2020-01-16 Thread Sergio Lopez
Dr. David Alan Gilbert (git) writes: > From: Stefan Hajnoczi > > Introduce an API for consuming bytes from a buffer with size checks. > All FUSE operations will be converted to use this safe API instead of > void *inarg. > > Signed-off-by: Stefan Hajnoczi > --- > tools/virtiofsd/buffer.c

Re: [PATCH 00/13] LUKS: encryption slot management using amend interface

2020-01-16 Thread Maxim Levitsky
On Tue, 2020-01-14 at 13:17 -0800, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200114193350.10830-1-mlevi...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [PATCH 00/13] LUKS:

[Bug 1859989] [NEW] qemu-img has broken output with large snapshot names

2020-01-16 Thread pevogam
Public bug reported: On Qemu 4.1.1 the output of snalshots breaks if the chosen state name is too long: ``` # qemu-img snapshot -l /mnt/local/some_image.qcow2 Snapshot list: IDTAG VM SIZEDATE VM CLOCK 1 online_provider_with_dhcp747 MiB

Re: Bug? qemu-img convert to preallocated image makes it sparse

2020-01-16 Thread Richard W.M. Jones
On Thu, Jan 16, 2020 at 03:47:30PM +0100, Max Reitz wrote: > On 16.01.20 15:13, Richard W.M. Jones wrote: > > I'm not necessarily saying this is a bug, but a change in behaviour in > > qemu has caused virt-v2v to fail. The reproducer is quite simple. > > > > Create sparse and preallocated qcow2

Re: [PATCH v6 0/3] target/ppc: single step for KVM HV

2020-01-16 Thread Leonardo Bras
On Fri, 2020-01-10 at 12:13 -0300, Fabiano Rosas wrote: > Hi, > > This version contains two major changes. A fix for stepping an > AIL-changing instruction and a fix for when other breakpoints happen > mid-step. > I have being using this patchset for almost an year now. It really makes

Re: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend

2020-01-16 Thread Philippe Mathieu-Daudé
On 1/15/20 10:01 PM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imamm...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed,

Re: [PATCH v2] m68k: Fix regression causing Single-Step via GDB/RSP to not single step

2020-01-16 Thread Laurent Vivier
Le 16/01/2020 à 17:54, Laurent Vivier a écrit : > A regression that was introduced, with the refactor to TranslatorOps, > drops two lines that update the PC when single-stepping is being performed. > > Fixes: 11ab74b01e0a ("target/m68k: Convert to TranslatorOps") > Reported-by: Lucien

Re: [PATCH v2 85/86] numa: make exit() usage consistent

2020-01-16 Thread Igor Mammedov
On Thu, 16 Jan 2020 17:43:30 +0100 Thomas Huth wrote: > On 15/01/2020 16.07, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > CC: ehabk...@redhat.com > > --- > > hw/core/numa.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/hw/core/numa.c

Re: [PATCH RFC 01/12] migration: Add multiRDMA capability support

2020-01-16 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Zhimin Feng (fengzhim...@huawei.com) wrote: >> From: fengzhimin >> >> Signed-off-by: fengzhimin > > Instead of creating x-multirdma as a capability and the corresponding > parameter for the number of channels; it would be better just > to use the multifd

Re: [PATCH v3 03/11] 9pfs: validate count sent by client with T_readdir

2020-01-16 Thread Greg Kurz
On Mon, 13 Jan 2020 23:22:08 +0100 Christian Schoenebeck wrote: > A good 9p client sends T_readdir with "count" parameter that's > sufficiently smaller than client's initially negotiated msize > (maximum message size). We perform a check for that though to > avoid the server to be interrupted

Re: [libvirt] [PATCH v2 82/86] numa: forbid '-numa node, mem' for 5.0 and newer machine types

2020-01-16 Thread Igor Mammedov
On Thu, 16 Jan 2020 14:03:12 +0100 Michal Privoznik wrote: > On 1/16/20 1:37 PM, Igor Mammedov wrote: > > On Thu, 16 Jan 2020 11:42:09 +0100 > > Michal Privoznik wrote: > > > >> On 1/15/20 5:52 PM, Igor Mammedov wrote: > >>> On Wed, 15 Jan 2020 16:34:53 +0100 > >>> Peter Krempa wrote: >

Re: [PATCH v2] Makefile: Keep trace-events-subdirs ordered

2020-01-16 Thread Stefan Hajnoczi
On Thu, Jan 16, 2020 at 12:43:39PM +0100, Philippe Mathieu-Daudé wrote: > Adding the same directory multiple times to trace-events-subdirs > might trigger build failures, in particular when using the LTTng > Userspace Tracer library as backend. > > For example when using two times the hw/core/

Re: [PATCH v2 1/4] qcow2: Require that the virtual size is a multiple of the sector size

2020-01-16 Thread Alberto Garcia
On Tue 14 Jan 2020 03:03:31 PM CET, Max Reitz wrote: >> 3. QEMU can open them but it gets the size wrong. > > Yes, but in a safe way. The user simply doesn’t get access to those > 13 bytes. Ok, I think I'll withdraw the patch then :-) Berto

Re: [PATCH 0/3] linux-user: Implement x86_64 vsyscalls

2020-01-16 Thread Alex Bennée
Richard Henderson writes: > The x86_64 abi has a legacy vsyscall page. The kernel folk > have been trying to deprecate this since at least v3.1, but > > (1) We don't implement the vdso that replaces vsyscalls, > (2) As of v5.5, the vsyscall page is still enabled by default. > > This lack is

Re: [PATCH 051/104] virtiofsd: Parse flag FUSE_WRITE_KILL_PRIV

2020-01-16 Thread Sergio Lopez
Dr. David Alan Gilbert (git) writes: > From: Vivek Goyal > > Caller can set FUSE_WRITE_KILL_PRIV in write_flags. Parse it and pass it > to the filesystem. > > Signed-off-by: Vivek Goyal > --- > tools/virtiofsd/fuse_common.h | 6 +- > tools/virtiofsd/fuse_lowlevel.c | 4 +++- > 2 files

Re: Bug? qemu-img convert to preallocated image makes it sparse

2020-01-16 Thread Kevin Wolf
Am 16.01.2020 um 15:37 hat Max Reitz geschrieben: > On 16.01.20 15:13, Richard W.M. Jones wrote: > > I'm not necessarily saying this is a bug, but a change in behaviour in > > qemu has caused virt-v2v to fail. The reproducer is quite simple. > > > > Create sparse and preallocated qcow2 files of

Re: [PATCH 3/5] virtio-scsi: default num_queues to -smp N

2020-01-16 Thread Cornelia Huck
On Thu, 16 Jan 2020 14:16:54 + Stefan Hajnoczi wrote: > On Thu, Jan 16, 2020 at 12:53:49PM +0100, Cornelia Huck wrote: > > On Thu, 16 Jan 2020 10:58:40 + > > Stefan Hajnoczi wrote: > > > > > Automatically size the number of request virtqueues to match the number > > > of vCPUs. This

[PATCH] spapr: Fail CAS if option vector table cannot be parsed

2020-01-16 Thread Greg Kurz
Most of the option vector helpers have assertions to check their arguments aren't null. The guest can provide an arbitrary address for the CAS structure that would result in such null arguments. Fail CAS with H_PARAMETER instead of aborting QEMU. Signed-off-by: Greg Kurz ---

Re: [PATCH 053/104] virtiofsd: Drop CAP_FSETID if client asked for it

2020-01-16 Thread Sergio Lopez
Dr. David Alan Gilbert (git) writes: > From: Vivek Goyal > > If client requested killing setuid/setgid bits on file being written, drop > CAP_FSETID capability so that setuid/setgid bits are cleared upon write > automatically. > > pjdfstest chown/12.t needs this. > > Signed-off-by: Vivek Goyal

Re: Bug? qemu-img convert to preallocated image makes it sparse

2020-01-16 Thread Richard W.M. Jones
On Thu, Jan 16, 2020 at 05:38:03PM +0200, Maxim Levitsky wrote: > How about doing write zeros without discard only in this particular case > (convert to existing image) > Basically omitting the BDRV_REQ_MAY_UNMAP flag to blk_co_pwrite_zeroes. > It will be slow, but maybe for this particular case,

Re: [PATCH v22 8/9] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

2020-01-16 Thread Peter Maydell
On Wed, 8 Jan 2020 at 11:33, Dongjiu Geng wrote: > +void kvm_arch_on_sigbus_vcpu(CPUState *c, int code, void *addr) > +{ > +ram_addr_t ram_addr; > +hwaddr paddr; > + > +assert(code == BUS_MCEERR_AR || code == BUS_MCEERR_AO); > + > +if (acpi_enabled && addr && > +

[PATCH v19 4/7] target/ppc: Build rtas error log upon an MCE

2020-01-16 Thread Ganesh Goudar
From: Aravinda Prasad Upon a machine check exception (MCE) in a guest address space, KVM causes a guest exit to enable QEMU to build and pass the error to the guest in the PAPR defined rtas error log format. This patch builds the rtas error log, copies it to the rtas_addr and then invokes the

[PATCH v19 0/7]target-ppc/spapr: Add FWNMI support in QEMU for PowerKM guests

2020-01-16 Thread Ganesh Goudar
This patch set adds support for FWNMI in PowerKVM guests. System errors such as SLB multihit and memory errors that cannot be corrected by hardware is passed on to the kernel for handling by raising machine check exception (an NMI). Upon such machine check exceptions, if the address in error

[PATCH v19 2/7] ppc: spapr: Introduce FWNMI capability

2020-01-16 Thread Ganesh Goudar
From: Aravinda Prasad Introduce fwnmi an spapr capability and add a helper function which tries to enable it, which would be used by following patch of the series. This patch by itself does not change the existing behavior. Signed-off-by: Aravinda Prasad [eliminate cap_ppc_fwnmi, add fwnmi cap

Re: [PATCH v2 28/86] arm:raspi: use memdev for RAM

2020-01-16 Thread Igor Mammedov
On Wed, 15 Jan 2020 20:07:34 +0100 Philippe Mathieu-Daudé wrote: > On 1/15/20 4:06 PM, Igor Mammedov wrote: > > memory_region_allocate_system_memory() API is going away, so > > replace it with memdev allocated MemoryRegion. The later is > > initialized by generic code, so board only needs to opt

[PATCH v3] m68k: Fix regression causing Single-Step via GDB/RSP to not single step

2020-01-16 Thread Laurent Vivier
A regression that was introduced, with the refactor to TranslatorOps, drops two lines that update the PC when single-stepping is being performed. Fixes: 11ab74b01e0a ("target/m68k: Convert to TranslatorOps") Reported-by: Lucien Murray-Pitts Suggested-by: Lucien Murray-Pitts Suggested-by:

[PATCH v2] m68k: Fix regression causing Single-Step via GDB/RSP to not single step

2020-01-16 Thread Laurent Vivier
A regression that was introduced, with the refactor to TranslatorOps, drops two lines that update the PC when single-stepping is being performed. Fixes: 11ab74b01e0a ("target/m68k: Convert to TranslatorOps") Reported-by: Lucien Murray-Pitts Suggested-by: Lucien Murray-Pitts Suggested-by:

Re: [PATCH v3 02/11] 9pfs: require msize >= 4096

2020-01-16 Thread Greg Kurz
On Mon, 13 Jan 2020 23:21:04 +0100 Christian Schoenebeck wrote: > A client establishes a session by sending a Tversion request along with > a 'msize' parameter which client uses to suggest server a maximum > message size ever to be used for communication (for both requests and > replies) between

Re: [PATCH v2 1/5] vhost-user block device backend

2020-01-16 Thread Stefan Hajnoczi
On Tue, Jan 14, 2020 at 10:06:16PM +0800, Coiby Xu wrote: > By making use of libvhost, multiple block device drives can be exported and > each drive can serve multiple clients simultaneously. Since vhost-user-server > needs a block drive to be created first, delay the creation of this object. >

Re: [PATCH v2 85/86] numa: make exit() usage consistent

2020-01-16 Thread Philippe Mathieu-Daudé
On 1/15/20 4:07 PM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- CC: ehabk...@redhat.com --- hw/core/numa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/core/numa.c b/hw/core/numa.c index 3177066..47d5ea1 100644 --- a/hw/core/numa.c +++ b/hw/core/numa.c

Re: [PATCH 071/104] virtiofsd: extract root inode init into setup_root()

2020-01-16 Thread Dr. David Alan Gilbert
* Misono Tomohiro (misono.tomoh...@jp.fujitsu.com) wrote: > > From: Miklos Szeredi > > > > Inititialize the root inode in a single place. > > > > Signed-off-by: Miklos Szeredi > > Signed-off-by: Stefan Hajnoczi > > --- > > tools/virtiofsd/passthrough_ll.c | 26 -- > >

Re: [PATCH v2 41/86] hw/hppa/machine: Correctly check the firmware is in PDC range

2020-01-16 Thread Igor Mammedov
On Thu, 16 Jan 2020 16:14:45 +0100 Philippe Mathieu-Daudé wrote: > On 1/15/20 10:59 PM, BALATON Zoltan wrote: > > On Wed, 15 Jan 2020, Philippe Mathieu-Daudé wrote: > >> On 1/15/20 7:15 PM, BALATON Zoltan wrote: > >>> On Wed, 15 Jan 2020, Igor Mammedov wrote: > From: Philippe

Re: [PATCH v2 83/86] tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups

2020-01-16 Thread Thomas Huth
On 15/01/2020 16.07, Igor Mammedov wrote: > Use GString to pass argument to make_cli() so that it would be easy > to dynamically change test case arguments from main(). The follow up > patch will use it to change RAM size options depending on target. > > While at it cleanup 'cli' freeing, using

Re: qemu-4.0.1: vhost_region_add_section:Section rounded to 0 prior to previous a0000

2020-01-16 Thread Peter Lieven
Am 16.01.20 um 13:47 schrieb Peter Lieven: Am 13.01.20 um 17:25 schrieb Peter Lieven: Am 09.01.20 um 19:44 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Am 08.01.20 um 16:04 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Hi, I have a Qemu 4.0.1

Re: [PATCH v22 9/9] MAINTAINERS: Add ACPI/HEST/GHES entries

2020-01-16 Thread Peter Maydell
On Wed, 8 Jan 2020 at 11:32, Dongjiu Geng wrote: > > I and Xiang are willing to review the APEI-related patches and > volunteer as the reviewers for the HEST/GHES part. > > Signed-off-by: Dongjiu Geng > Signed-off-by: Xiang Zheng > --- > MAINTAINERS | 9 + > 1 file changed, 9

[PATCH v19 7/7] ppc: spapr: Activate the FWNMI functionality

2020-01-16 Thread Ganesh Goudar
From: Aravinda Prasad This patch sets the default value of SPAPR_CAP_FWNMI_MCE to SPAPR_CAP_ON for machine type 4.2. Signed-off-by: Aravinda Prasad Signed-off-by: Ganesh Goudar --- hw/ppc/spapr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-16 Thread Igor Mammedov
On Thu, 16 Jan 2020 19:56:19 +0800 Guoheyi wrote: > 在 2020/1/5 20:53, Michael S. Tsirkin 写道: > > On Sun, Jan 05, 2020 at 07:34:01AM -0500, Michael S. Tsirkin wrote: > >> On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: > >>> According to ACPI spec, _ADR should be used for device

Re: [PATCH v2 1/5] vhost-user block device backend

2020-01-16 Thread Kevin Wolf
Hi, I'm only doing a quick first review pointing out the more obvious things while I familiarise myself with your code. I intend to review it in more detail later (either in a second pass for this series, or when you post v3). Am 14.01.2020 um 15:06 hat Coiby Xu geschrieben: > By making use of

Re: [PATCH 0/3] linux-user: Implement x86_64 vsyscalls

2020-01-16 Thread Alex Bennée
Richard Henderson writes: > The x86_64 abi has a legacy vsyscall page. The kernel folk > have been trying to deprecate this since at least v3.1, but > > (1) We don't implement the vdso that replaces vsyscalls, > (2) As of v5.5, the vsyscall page is still enabled by default. > > This lack is

Re: [PATCH v2 3/5] a standone-alone tool to directly share disk image file via vhost-user protocol

2020-01-16 Thread Stefan Hajnoczi
On Tue, Jan 14, 2020 at 10:06:18PM +0800, Coiby Xu wrote: > vhost-user-blk can have played as vhost-user backend but it only supports raw > file and don't support VIRTIO_BLK_T_DISCARD and VIRTIO_BLK_T_WRITE_ZEROES > operations on raw file (ioctl(fd, BLKDISCARD) is only valid for real block >

[PATCH 1/3] qemu-nbd: Convert invocation documentation to rST

2020-01-16 Thread Peter Maydell
The qemu-nbd documentation is currently in qemu-nbd.texi in Texinfo format, which we present to the user as: * a qemu-nbd manpage * a section of the main qemu-doc HTML documentation Convert the documentation to rST format, and present it to the user as: * a qemu-nbd manpage * part of the

Re: [PATCH 045/104] virtiofsd: prevent ".." escape in lo_do_readdir()

2020-01-16 Thread Sergio Lopez
Dr. David Alan Gilbert (git) writes: > From: Stefan Hajnoczi > > Construct a fake dirent for the root directory's ".." entry. This hides > the parent directory from the FUSE client. > > Signed-off-by: Stefan Hajnoczi > --- > tools/virtiofsd/passthrough_ll.c | 36

Re: Bug? qemu-img convert to preallocated image makes it sparse

2020-01-16 Thread Max Reitz
On 16.01.20 15:13, Richard W.M. Jones wrote: > I'm not necessarily saying this is a bug, but a change in behaviour in > qemu has caused virt-v2v to fail. The reproducer is quite simple. > > Create sparse and preallocated qcow2 files of the same size: > > $ qemu-img create -f qcow2

  1   2   3   4   >