Performance hit in qemu-system-ppc

Hi, I noticed a considerable (~20%) slowdown in the cpu performance of qemu-system-ppc. Bisecting led me to this commit: d03f140804b345a85973976506492027f703d82d is the first bad commit commit d03f140804b345a85973976506492027f703d82d Author: Richard Henderson Date: Mon Dec 9 13:49:58 2019

Re: Integrating QOM into QAPI

On Sat, 25 Jan 2020 at 09:28, Paolo Bonzini wrote: > > On 25/01/20 05:44, Marc-André Lureau wrote: > > I try to find a good reason qom was chosen over gobject, and I can't > > find it. > > The main reasons were integration with QAPI, and the object tree. > Though everything I say here is a kind

Re: [PATCH] .travis.yml: Add description to each job

On 25/01/2020 19.31, Philippe Mathieu-Daudé wrote: > The NAME variable can be used to describe nicely a job (see [*]). > As we currently have 32 jobs, use it. This helps for quickly > finding a particular job. > > before: https://travis-ci.org/qemu/qemu/builds/639887646 > after:

Re: Making QEMU easier for management tools and applications

> On 23 Jan 2020, at 18:58, John Snow wrote: > > > > On 1/23/20 2:19 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 12/24/19 8:41 AM, Daniel P. Berrangé wrote: > * scripts/qmp/qmp-shell > > Half-hearted attempt at a human-friendly wrapper around the JSON >

Re: [PATCH] bsd-user: improve support for sparc syscall flags

On 25/1/20 16:52, Laurent Vivier wrote: Le 25/01/2020 à 12:55, no-re...@patchew.org a écrit : Patchew URL: https://patchew.org/QEMU/20200125114753.61820-1-salva...@qindel.com/ Hi, This series seems to have some coding style problems. See output below for more information: Salvador, you

Re: [RFC] migration: Remove old compression code

Cc'ing like David did, plus Eric and Mike for additional QAPI expertise. Juan Quintela writes: > Hi > > There are several problems with the old compression code: > * it compress one page at a time (i.e. 4KB) > > * it has to copy all the page to the compression thread, the > compression thread

Re: [PATCH rc2 21/25] hw/avr: Add some Arduino boards

On 1/24/20 1:51 AM, Philippe Mathieu-Daudé wrote: > Arduino boards are build with AVR chipsets. > Add some of the popular boards: > > - Arduino Duemilanove > - Arduino Uno > - Arduino Mega > > For more information: > https://www.arduino.cc/en/Main/Products >

Re: [PATCH v4 6/7] disas: mips: Add micromips R6 disassembler - infrastructure and 16-bit instructions

On Saturday, January 25, 2020, Richard Henderson < richard.hender...@linaro.org> wrote: > On 1/24/20 1:38 PM, Aleksandar Markovic wrote: > > On Friday, January 24, 2020, Richard Henderson < > richard.hender...@linaro.org > > > wrote: > > The thing I'm

Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic

On Friday, January 24, 2020, Philippe Mathieu-Daudé wrote: > From: Michael Rolnik > > This includes: > - CPU data structures > - object model classes and functions > - migration functions > - GDB hooks > > I have an objection over this patch. It contains many diverse logical units squashed

Re: Integrating QOM into QAPI

On 25/01/20 05:44, Marc-André Lureau wrote: > On 22/01/20 13:42, Marc-André Lureau wrote: > > From the top of my mind, this is the pain point when trying to use > GObject: > > - static/inlined object, not supported by GObject, unlikely to ever be > > - few users in qemu,

Re: Making QEMU easier for management tools and applications

Kevin Wolf writes: > Am 24.01.2020 um 11:27 hat Daniel P. Berrangé geschrieben: >> On Fri, Jan 24, 2020 at 08:59:41AM +0100, Markus Armbruster wrote: >> > John Snow writes: >> > >> > > On 1/23/20 2:01 PM, Daniel P. Berrangé wrote: >> > >> So when configuring objects you'll always provide a

[PATCH] bsd-user: improve support for sparc syscall flags

From: Salvador Fandino Under sparc and sparc64, both NetBSD and OpenSSH use two bits of the syscall number as flags. Until now, those bits where only supported for sparc64 when emulating OpenBSD. This patch extends support for syscall flags to the sparc architecture and NetBSD emulation. It had

Re: Making QEMU easier for management tools and applications

On 20/01/20 10:55, Stefan Hajnoczi wrote: >> >> [1] https://qemu.readthedocs.io/en/latest/interop/live-block-operations.html > John and I discussed async events in the past. qmp-shell currently uses > the input() built-in function. If we modify it with a > select(2)/poll(2)-style function that

Re: Making QEMU easier for management tools and applications

On 24/01/20 10:50, Daniel P. Berrangé wrote: > * qemu-launcher-$TARGET > > A binary that is able to launch qemu-runtime-$TARGET > with jailers active. > > This has no command line arguments except for a pair > of UNIX socket paths. One is a QMP server, the other > is the

Re: Making QEMU easier for management tools and applications

On 24/12/19 14:41, Daniel P. Berrangé wrote: > I'm wondering if we need to think about a temporary *throwaway* fork of > QEMU. I wasn't involved in the work, but as an outside observer I think > it is interesting to see how the NEMU project fork ultimately led to QEMU > moving forward with a new

Re: [PATCH] bsd-user: improve support for sparc syscall flags

Patchew URL: https://patchew.org/QEMU/20200125114753.61820-1-salva...@qindel.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200125114753.61820-1-salva...@qindel.com Subject: [PATCH] bsd-user: improve support

Re: [PATCH] tests/acceptance: Add boot tests for some of the QEMU advent calendar images

On 24/01/2020 22.28, Wainer dos Santos Moschetta wrote: > > On 1/24/20 3:03 PM, Thomas Huth wrote: >> The 2018 edition of the QEMU advent calendar 2018 featured Linux images >> for various non-x86 machines. We can use them for a boot tests in our >> acceptance test suite. >> >> Let's also make

Re: [PATCH] bsd-user: improve support for sparc syscall flags

Le 25/01/2020 à 12:55, no-re...@patchew.org a écrit : > Patchew URL: > https://patchew.org/QEMU/20200125114753.61820-1-salva...@qindel.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > Salvador, you can use

[PATCH v13 01/10] virtio-iommu: Add skeleton

This patchs adds the skeleton for the virtio-iommu device. Signed-off-by: Eric Auger Reviewed-by: Peter Xu --- v12 -> v13 - removed IOMMU_PCI_BUS_MAX and IOMMU_PCI_DEVFN_MAX v11 -> v12: - remove s_by_bus_num - drop set_features (rely on default implementation) and acked_features v9 ->

[PATCH v13 00/10] VIRTIO-IOMMU device

This series implements the QEMU virtio-iommu device. This matches the v0.12 spec (voted) and the corresponding virtio-iommu driver upstreamed in 5.3. All kernel dependencies are resolved for DT integration. The virtio-iommu can be instantiated in ARM virt using "-device virtio-iommu-pci". Non DT

[PATCH v13 03/10] virtio-iommu: Implement attach/detach command

This patch implements the endpoint attach/detach to/from a domain. Domain and endpoint internal datatypes are introduced. Both are stored in RB trees. The domain owns a list of endpoints attached to it. Also helpers to get/put end points and domains are introduced. As for the IOMMU memory

Re: Making QEMU easier for management tools and applications

Il mer 15 gen 2020, 10:21 Markus Armbruster ha scritto: > > We don’t want the QAPI to let arbitrary fields of a QOM object > > be modified, do we? > > We already do: QMP command qom-set. If it breaks your guest, you get to > keep the pieces. > That's not true. We chose not to make that a

[PATCH v13 08/10] hw/arm/virt: Add the virtio-iommu device tree mappings

Adds the "virtio,pci-iommu" node in the host bridge node and the RID mapping, excluding the IOMMU RID. Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker --- v11 -> v12: - Added Jean's R-b v10 -> v11: - remove msi_bypass v8 -> v9: - disable msi-bypass property - addition of the

[PATCH v13 04/10] virtio-iommu: Implement map/unmap

This patch implements virtio_iommu_map/unmap. Signed-off-by: Eric Auger Reviewed-by: Peter Xu --- v11 -> v12: - check unmanaged managed flags on map - removed 2 qemu_log_mask in unmap() - fix leak v10 -> v11: - revisit the implementation of unmap according to Peter's suggestion - removed

[PATCH v13 06/10] virtio-iommu: Implement fault reporting

The event queue allows to report asynchronous errors. The translate function now injects faults when relevant. Signed-off-by: Eric Auger --- v12 -> v13: - return on virtio_error() v11 -> v12: - reporting the addr associated with the fault and set the VIRTIO_IOMMU_FAULT_F_ADDRESS flag. -

[PATCH v13 10/10] tests: Add virtio-iommu test

This adds the framework to test the virtio-iommu-pci device and tests exercising the attach/detach, map/unmap API. To run the tests: make tests/qtest/qos-test QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 tests/qtest/qos-test V=1 Signed-off-by: Eric Auger --- v12 -> v13 - remove

Re: [PATCH v4 6/7] disas: mips: Add micromips R6 disassembler - infrastructure and 16-bit instructions

On 1/25/20 12:22 AM, Aleksandar Markovic wrote: > > > On Saturday, January 25, 2020, Richard Henderson > wrote: > > On 1/24/20 1:38 PM, Aleksandar Markovic wrote: > > On Friday, January 24, 2020, Richard Henderson >

[PATCH] .travis.yml: Add description to each job

The NAME variable can be used to describe nicely a job (see [*]). As we currently have 32 jobs, use it. This helps for quickly finding a particular job. before: https://travis-ci.org/qemu/qemu/builds/639887646 after: https://travis-ci.org/philmd/qemu/builds/641795043 [*]

[PATCH] .travis.yml: Drop superfluous use of --python=python3 parameter

As we require Python3 since commit ddf9069963, we don't need to explicit it with the --python=/usr/bin/python3 configure option. Reported-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- Cc: Wainer dos Santos Moschetta Cc: Eduardo Habkost Cc: Cleber Rosa --- .travis.yml | 2 +- 1

Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic

On 25/01/2020 11.48, Aleksandar Markovic wrote: > > On Friday, January 24, 2020, Philippe Mathieu-Daudé > wrote: > > From: Michael Rolnik mailto:mrol...@gmail.com>> > > This includes: > - CPU data structures > - object model classes and functions > -

[PATCH v13 02/10] virtio-iommu: Decode the command payload

This patch adds the command payload decoding and introduces the functions that will do the actual command handling. Those functions are not yet implemented. Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker Reviewed-by: Peter Xu --- v11 -> v12: - ADded Jean and Peter's R-b v10 ->

[PATCH v13 05/10] virtio-iommu: Implement translate

This patch implements the translate callback Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker --- v11 -> v12: - Added Jean's R-b - s/qemu_log_mask/error_report_once v10 -> v11: - take into account the new value struct and use g_tree_lookup_extended - switched to

[PATCH v13 07/10] virtio-iommu-pci: Add virtio iommu pci support

This patch adds virtio-iommu-pci, which is the pci proxy for the virtio-iommu device. Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker --- v11 -> v12: - added Jean's R-b - remove the array of intervals. Will be introduced later? v10 -> v11: - add the reserved_regions array

[PATCH v13 09/10] virtio-iommu: Support migration

Add Migration support. We rely on recently added gtree and qlist migration. We only migrate the domain gtree. The endpoint gtree is re-constructed in a post-load operation. Signed-off-by: Eric Auger Acked-by: Peter Xu --- v11 -> v12: - do not migrate the endpoint gtree but reconstruct it from

[PATCH] migration: Simplify get_qlist

Instead of inserting read elements at the head and then reversing the list, it is simpler to add each element after the previous one. Introduce QLIST_RAW_INSERT_AFTER helper and use it in get_qlist(). Signed-off-by: Eric Auger Suggested-by: Juan Quintela --- --- include/qemu/queue.h | 19

Re: [PATCH] tests/acceptance: Add boot tests for some of the QEMU advent calendar images

On 1/25/20 5:43 PM, Thomas Huth wrote: > On 24/01/2020 22.28, Wainer dos Santos Moschetta wrote: >> >> On 1/24/20 3:03 PM, Thomas Huth wrote: >>> The 2018 edition of the QEMU advent calendar 2018 featured Linux images >>> for various non-x86 machines. We can use them for a boot tests in our >>>