RE: [PATCH V4 0/5] Introduce Advanced Watch Dog module

2020-03-04 Thread Zhang, Chen
> >>> Subject: Re: [PATCH V4 0/5] Introduce Advanced Watch Dog module > >>> > >>> > >>> On 2020/1/19 下午5:10, Zhang, Chen wrote: > Hi~ > > Anyone have comments about this module? > >>> Hi Chen: > >>> > >>> I will take a look at this series. > >> Sorry for slow reply due to CNY and

Re: [PATCH RFC 2/4] intc/s390_flic_kvm.c: Use kvm_device_ioctl() instead of ioctl()

2020-03-04 Thread Christian Borntraeger
On 03.03.20 15:19, David Hildenbrand wrote: > Let's use the official variant, which will e.g., trace the call. > > Cc: Cornelia Huck > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: qemu-s3...@nongnu.org > Signed-off-by: David Hildenbrand > --- > hw/intc/s390_flic_kvm.c | 22

Re: [PATCH v4 2/3] linux-user/syscall: Add support for clock_gettime64/clock_settime64

2020-03-04 Thread Aleksandar Markovic
1:53 AM Sre, 04.03.2020. Alistair Francis је написао/ла: > > Add support for the clock_gettime64/clock_settime64 syscalls. Currently > we only support these syscalls when running on 64-bit hosts. > For clarity, "Currently we only support" should be replaced with "This patch supports only". >

Re: [PATCH v4 07/11] monitor/hmp: move hmp_snapshot_* to block-hmp-cmds.c hmp_snapshot_blkdev is from GPLv2 version of the hmp-cmds.c thus have to change the licence to GPLv2

2020-03-04 Thread Maxim Levitsky
On Tue, 2020-03-03 at 18:15 +0100, Kevin Wolf wrote: > Am 30.01.2020 um 13:34 hat Maxim Levitsky geschrieben: > > Signed-off-by: Maxim Levitsky > > Reviewed-by: Dr. David Alan Gilbert > > Very long subject line. I suppose the license notice should be in the > body instead. > > >

Re: [PATCH] vhost-vsock: fix error message output

2020-03-04 Thread Stefano Garzarella
On Sun, Mar 01, 2020 at 01:03:06PM +0100, Nick Erdmann wrote: > error_setg_errno takes a positive error number, so we should not invert > errno's sign. > > Signed-off-by: Nick Erdmann > --- > hw/virtio/vhost-vsock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v4 02/11] monitor/hmp: uninline add_init_drive

2020-03-04 Thread Maxim Levitsky
On Tue, 2020-03-03 at 18:10 +0100, Kevin Wolf wrote: > Am 30.01.2020 um 13:34 hat Maxim Levitsky geschrieben: > > This is only used by hmp_drive_add. > > The code is just a bit shorter this way. > > > > No functional changes > > > > Signed-off-by: Maxim Levitsky > > Reviewed-by: Markus

Re: Wiki user request

2020-03-04 Thread Philippe Mathieu-Daudé
Ping? Le jeu. 27 févr. 2020 10:29, Joaquin de Andres a écrit : > Hi! > > I wonder if I can get write access to the wiki page. I'm working with > Philippe Mathieu-Daudé in the GSoC Arduino Visualization project ([1]) > and I need to modify and add pages. > > Thanks! > --joa > > [1]

Re: [PATCH v2 00/30] Configurable policy for handling deprecated interfaces

2020-03-04 Thread Peter Krempa
On Tue, Mar 03, 2020 at 17:34:35 +0100, Markus Armbruster wrote: > Based-on: <20200227144531.24309-1-arm...@redhat.com> > > This series extends QMP introspection to cover deprecation. > Additionally, new option -compat lets you configure what to do when > deprecated interfaces get used. This is

Re: [PATCH] optionrom/pvh: scan entire RSDP Area

2020-03-04 Thread Paolo Bonzini
On 04/03/20 09:55, Stefano Garzarella wrote: > CCing Paolo > > On Tue, Mar 03, 2020 at 02:52:47AM -0800, Joe Richey wrote: >> From: Joe Richey >> >> Right now the PVH option rom scans for the RSDP from 0xE to >> 0xE1FFF. This is probobly a typo, it should scan from 0xE to >> 0xF. >>

Re: [PATCH v6 18/18] pc-bios: s390x: Save iplb location in lowcore

2020-03-04 Thread David Hildenbrand
On 04.03.20 12:42, Janosch Frank wrote: > The POP states that for a list directed IPL the IPLB is stored into > memory by the machine loader and its address is stored at offset 0x14 > of the lowcore. > > ZIPL currently uses the address in offset 0x14 to access the IPLB and > acquire flags about

[PULL v1 03/10] tpm: Separate tpm_tis common functions from isa code

2020-03-04 Thread Stefan Berger
From: Eric Auger Move the device agnostic code into tpm_tis_common.c and put the ISA device specific code into tpm_tis_isa.c Signed-off-by: Eric Auger Reviewed-by: Stefan Berger Tested-by: Ard Biesheuvel Acked-by: Ard Biesheuvel Message-id: 20200226205942.11424-4-eric.au...@redhat.com

[PULL v1 08/10] test: tpm: pass optional machine options to swtpm test functions

2020-03-04 Thread Stefan Berger
From: Eric Auger We plan to use swtpm test functions on ARM for testing the sysbus TPM-TIS device. However on ARM there is no default machine type. So we need to explictly pass some machine options on startup. Let's allow this by adding a new parameter to both swtpm test functions and update all

[PULL v1 07/10] docs/specs/tpm: Document TPM_TIS sysbus device for ARM

2020-03-04 Thread Stefan Berger
From: Eric Auger Update the documentation with recent changes related to the sysbus TPM_TIS device addition and add the command line to be used with arm VIRT. Signed-off-by: Eric Auger Reviewed-by: Stefan Berger Message-id: 20200226205942.11424-8-eric.au...@redhat.com Signed-off-by: Stefan

[PULL v1 10/10] test: tpm-tis: Add Sysbus TPM-TIS device test

2020-03-04 Thread Stefan Berger
From: Eric Auger The tests themselves are the same as the ISA device ones. Only the main() changes as the "tpm-tis-device" device gets instantiated. Also the base address of the device is not 0xFED4 anymore but matches the base address of the ARM virt platform bus. Signed-off-by: Eric Auger

Re: [PATCH] block/qcow2-threads: fix qcow2_decompress

2020-03-04 Thread Ján Tomko
On a Monday in 2020, Vladimir Sementsov-Ogievskiy wrote: On success path we return what inflate() returns instead of 0. And it most probably works for Z_STREAM_END as it is positive, but is definitely broken for Z_BUF_ERROR. While being here, switch to errno return code, to be closer to

Re: [PATCH] audio: Add sndio backend

2020-03-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200304145003.gb15...@humpty.home.comstyle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] audio: Add sndio backend Message-id: 20200304145003.gb15...@humpty.home.comstyle.com Type:

[PATCH 1/5] hw/scsi/viosrp: Add missing 'hw/scsi/srp.h' include

2020-03-04 Thread Philippe Mathieu-Daudé
This header use the srp_* structures declared in "hw/scsi/srp.h". Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/viosrp.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/scsi/viosrp.h b/hw/scsi/viosrp.h index d8e365db1e..25676c2383 100644 --- a/hw/scsi/viosrp.h +++

[PATCH 4/5] hw/scsi/spapr_vscsi: Introduce req_ui() helper

2020-03-04 Thread Philippe Mathieu-Daudé
Introduce the req_ui() helper which returns a pointer to the viosrp_iu union held in the vscsi_req structure. This simplifies the next patch. Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/spapr_vscsi.c | 40 1 file changed, 24 insertions(+), 16

[PATCH 2/5] hw/scsi/spapr_vscsi: Use SRP_MAX_IU_LEN instead of sizeof flexible array

2020-03-04 Thread Philippe Mathieu-Daudé
Replace sizeof() flexible arrays union srp_iu/viosrp_iu by the SRP_MAX_IU_LEN definition, which is what this code actually meant to use. Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/spapr_vscsi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v6 03/18] s390x: protvirt: Support unpack facility

2020-03-04 Thread Janosch Frank
When a guest has saved a ipib of type 5 and calls diagnose308 with subcode 10, we have to setup the protected processing environment via Ultravisor calls. The calls are done by KVM and are exposed via an API. The following steps are necessary: 1. Enable protected mode for the VM (register it and

Re: [PATCH v5 16/50] multi-process: Synchronize remote memory

2020-03-04 Thread Dr. David Alan Gilbert
* Jagannathan Raman (jag.ra...@oracle.com) wrote: > Add memory-listener object which is used to keep the view of the RAM > in sync between QEMU and remote process. > A MemoryListener is registered for system-memory AddressSpace. The > listener sends SYNC_SYSMEM message to the remote process when

[PATCH v6 13/18] s390x: protvirt: Disable address checks for PV guest IO emulation

2020-03-04 Thread Janosch Frank
IO instruction data is routed through SIDAD for protected guests, so adresses do not need to be checked, as this is kernel memory. Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth --- target/s390x/ioinst.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-)

[PATCH v6 15/18] s390x: protvirt: Handle SIGP store status correctly

2020-03-04 Thread Janosch Frank
Status storing is not done by QEMU anymore, but is handled by SIE. Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth --- target/s390x/helper.c | 4 target/s390x/sigp.c | 1 + 2 files changed, 5 insertions(+) diff --git a/target/s390x/helper.c b/target/s390x/helper.c index

Re: [PATCH v4 4/5] qcow2: add zstd cluster compression

2020-03-04 Thread Denis Plotnikov
On 04.03.2020 10:49, Vladimir Sementsov-Ogievskiy wrote: 03.03.2020 16:34, Denis Plotnikov wrote: zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment,

[PULL v1 09/10] test: tpm-tis: Get prepared to share tests between ISA and sysbus devices

2020-03-04 Thread Stefan Berger
From: Eric Auger ISA and sysbus TPM-TIS devices will share their tests. Only the main() will change (instantiation option is different). Also the base address of the TPM-TIS device is going to be different. on x86 it is located at 0xFED4 while on ARM it can be located at any location,

[PULL v1 00/10] Merge TPM 2020/03/04

2020-03-04 Thread Stefan Berger
This series of patches adds support for TPM on ARM. Regards, Stefan The following changes since commit 2ac031d171ccd18c973014d9978b4a63f0ad5fb0: Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-5.0-sf3' into staging (2020-03-03 11:06:39 +) are available in the Git

[PULL v1 05/10] tpm: Add the SysBus TPM TIS device

2020-03-04 Thread Stefan Berger
From: Eric Auger Introduce the tpm-tis-device which is a sysbus device and is bound to be used on ARM. Signed-off-by: Eric Auger Reviewed-by: Stefan Berger Tested-by: Ard Biesheuvel Acked-by: Ard Biesheuvel Message-id: 20200226205942.11424-6-eric.au...@redhat.com Signed-off-by: Stefan

[PULL v1 06/10] hw/arm/virt: vTPM support

2020-03-04 Thread Stefan Berger
From: Eric Auger Let the TPM TIS SYSBUS device be dynamically instantiable in ARM virt. A device tree node is dynamically created (TPM via MMIO). The TPM Physical Presence interface (PPI) is not supported. To run with the swtmp TPM emulator, the qemu command line must be augmented with:

Re: [PATCH 1/2] misc: Replace zero-length arrays with flexible array member (automatic)

2020-03-04 Thread Paolo Bonzini
On 04/03/20 14:12, Philippe Mathieu-Daudé wrote: > > hw/scsi/spapr_vscsi.c:69:29: error: field 'iu' with variable sized type > 'union viosrp_iu' not at the end of a struct or class is a GNU extension > [-Werror,-Wgnu-variable-sized-type-not-at-end] >     union viosrp_iu iu; >  

Re: [PATCH 1/2] misc: Replace zero-length arrays with flexible array member (automatic)

2020-03-04 Thread Philippe Mathieu-Daudé
On 3/4/20 2:44 PM, Paolo Bonzini wrote: On 04/03/20 14:12, Philippe Mathieu-Daudé wrote: hw/scsi/spapr_vscsi.c:69:29: error: field 'iu' with variable sized type 'union viosrp_iu' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]     union

Re: [PATCH v1 2/3] riscv/sifive_u: Add a serial property to the sifive_u SoC

2020-03-04 Thread Bin Meng
Hi Alistair, On Wed, Mar 4, 2020 at 9:37 AM Alistair Francis wrote: > > At present the board serial number is hard-coded to 1, and passed > to OTP model during initialization. Firmware (FSBL, U-Boot) uses > the serial number to generate a unique MAC address for the on-chip > ethernet controller.

[PATCH 3/5] hw/scsi/spapr_vscsi: Simplify a bit

2020-03-04 Thread Philippe Mathieu-Daudé
We already have a ui pointer, use it (to simplify the next commit). Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/spapr_vscsi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c index 7e397ed797..3cb5a38181 100644 ---

[PATCH 0/5] hw/scsi/spapr_vscsi: Fix time bomb zero-length array use

2020-03-04 Thread Philippe Mathieu-Daudé
This series fixes a dangerous zero-length array use. Simples patches first to clean the issue in the last patch: dissociate the buffer holding DMA requests with pointer to SRP Information Unit packets. Philippe Mathieu-Daudé (5): hw/scsi/viosrp: Add missing 'hw/scsi/srp.h' include

Re: [PATCH] kvm: support to get/set dirty log initial-all-set capability

2020-03-04 Thread Peter Xu
On Wed, Mar 04, 2020 at 10:55:54AM +0800, Jay Zhou wrote: > Since the new capability KVM_DIRTY_LOG_INITIALLY_SET of > KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 has been introduced in the > kernel, tweak the userspace side to detect and enable this > capability. > > Signed-off-by: Jay Zhou > --- >

Re: [PATCH v2 1/4] qapi: net: Add query-netdevs command

2020-03-04 Thread Laurent Vivier
On 04/03/2020 14:06, Alexey Kirillov wrote: > Add a qmp command that provides information about currently attached > network devices and their configuration. > > Signed-off-by: Alexey Kirillov > --- > include/net/net.h | 1 + > net/hub.c | 8 +++ > net/l2tpv3.c | 19 +++ >

[PATCH v6 07/18] s390x: protvirt: KVM intercept changes

2020-03-04 Thread Janosch Frank
Secure guests no longer intercept with code 4 for an instruction interception. Instead they have codes 104 and 108 for secure instruction interception and secure instruction notification respectively. The 104 mirrors the 4 interception. The 108 is a notification interception to let KVM and QEMU

[PATCH v6 05/18] s390x: protvirt: Handle diag 308 subcodes 0,1,3,4

2020-03-04 Thread Janosch Frank
As we now have access to the protection state of the cpus, we can implement special handling of diag 308 subcodes for cpus in the protected state. For subcodes 0 and 1 we need to unshare all pages before continuing, so the guest doesn't accidentally expose data when dumping. For subcode 3/4 we

[PATCH v6 14/18] s390x: protvirt: Move IO control structures over SIDA

2020-03-04 Thread Janosch Frank
For protected guests, we need to put the IO emulation results into the SIDA, so SIE will write them into the guest at the next entry. Signed-off-by: Janosch Frank --- target/s390x/ioinst.c | 87 ++- 1 file changed, 61 insertions(+), 26 deletions(-) diff

[PATCH v6 17/18] docs: Add protvirt docs

2020-03-04 Thread Janosch Frank
Lets add some documentation for the Protected VM functionality. Signed-off-by: Janosch Frank --- docs/system/index.rst| 1 + docs/system/protvirt.rst | 57 2 files changed, 58 insertions(+) create mode 100644 docs/system/protvirt.rst diff --git

[PATCH v6 10/18] s390x: protvirt: SCLP interpretation

2020-03-04 Thread Janosch Frank
SCLP for a protected guest is done over the SIDAD, so we need to use the s390_cpu_virt_mem_* functions to access the SIDAD instead of guest memory when reading/writing SCBs. To not confuse the sclp emulation, we set 0x4000 as the SCCB address, since the function that injects the sclp external

[PATCH v2 4/4] net: Remove field info_str of NetClientState

2020-03-04 Thread Alexey Kirillov
Completely remove the info_str field of struct NetClientState because it is no longer required due to the addition of the QMP query-netdevs command. Signed-off-by: Alexey Kirillov --- hw/net/allwinner_emac.c | 2 +- hw/net/dp8393x.c| 2 +- hw/net/e1000.c | 4 ++--

Re: [PATCH v2 00/30] Configurable policy for handling deprecated interfaces

2020-03-04 Thread Markus Armbruster
Markus Armbruster writes: > Based-on: <20200227144531.24309-1-arm...@redhat.com> > > This series extends QMP introspection to cover deprecation. > Additionally, new option -compat lets you configure what to do when > deprecated interfaces get used. This is intended for testing users of > the

Re: [PATCH v1 1/3] riscv/sifive_u: Fix up file ordering

2020-03-04 Thread Bin Meng
On Wed, Mar 4, 2020 at 9:37 AM Alistair Francis wrote: > > Split the file into clear machine and SoC sections. > Yep, I found functions in this file are a little bit confusing as well .. > Signed-off-by: Alistair Francis > --- > hw/riscv/sifive_u.c | 107

Re: [PATCH 1/2] misc: Replace zero-length arrays with flexible array member (automatic)

2020-03-04 Thread Paolo Bonzini
On 04/03/20 15:12, Philippe Mathieu-Daudé wrote: > I'll send a fix for the dangerous code. > Do you want to drop this series, or only the change in 'struct srp_rsp' > (or in all hw/scsi/srp.h). Actually I guess it makes sense I move the > 'hw/scsi/srp.h' changes with the series cleaning dangerous

[PATCH 5/5] hw/scsi/spapr_vscsi: Do not mix SRP IU size with DMA buffer size

2020-03-04 Thread Philippe Mathieu-Daudé
The 'union srp_iu' is meant as a pointer to any SRP Information Unit type, it is not related to the size of a VIO DMA buffer. Use a plain buffer for the VIO DMA read/write calls. We can remove the reserved buffer from the 'union srp_iu'. This issue was noticed when replacing the zero-length

Re: [PATCH 0/2] misc: Replace zero-length arrays with flexible array member

2020-03-04 Thread Philippe Mathieu-Daudé
On 3/4/20 4:35 PM, Philippe Mathieu-Daudé wrote: v2: - do not modify qed.h (structure with single member) - based on hw/scsi/spapr_vscsi fix series This is a tree-wide cleanup inspired by a Linux kernel commit (from Gustavo A. R. Silva). Please ignore, for some reason the 'v2' tag is missing.

Re: New Hardware model emulation

2020-03-04 Thread Stefan Hajnoczi
On Wed, Mar 4, 2020, 13:04 Priyamvad Acharya wrote: > Hello, > > I tried to boot linux on qemu for RISCV(32 bit) with busybear-linux image. > When I run script containing qemu command line configuration it just hangs > with following message shown by attached image. > > How to fix it? > > I am

[PATCH 1/2] misc: Replace zero-length arrays with flexible array member (automatic)

2020-03-04 Thread Philippe Mathieu-Daudé
Description copied from Linux kernel commit from Gustavo A. R. Silva (see [3]): --v-- description start --v-- The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a

[PATCH 0/2] misc: Replace zero-length arrays with flexible array member

2020-03-04 Thread Philippe Mathieu-Daudé
v2: - do not modify qed.h (structure with single member) - based on hw/scsi/spapr_vscsi fix series This is a tree-wide cleanup inspired by a Linux kernel commit (from Gustavo A. R. Silva). --v-- description start --v-- The current codebase makes use of the zero-length array language

[PATCH v6 00/18] s390x: Protected Virtualization support

2020-03-04 Thread Janosch Frank
Most of the QEMU changes for PV are related to the new IPL type with subcodes 8 - 10 and the execution of the necessary Ultravisor calls to IPL secure guests. Note that we can only boot into secure mode from normal mode, i.e. stfle 161 is not active in secure mode. The other changes related to

[PATCH v6 06/18] s390x: protvirt: Inhibit balloon when switching to protected mode

2020-03-04 Thread Janosch Frank
Ballooning in protected VMs can only be done when the guest shares the pages it gives to the host. If pages are not shared, the integrity checks will fail once those pages have been altered and are given back to the guest. Hence, until we have a solution for this in the guest kernel, we inhibit

[PATCH v6 01/18] Sync pv

2020-03-04 Thread Janosch Frank
Signed-off-by: Janosch Frank --- linux-headers/linux/kvm.h | 43 +-- 1 file changed, 41 insertions(+), 2 deletions(-) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index 265099100e..e36f761194 100644 --- a/linux-headers/linux/kvm.h +++

[PATCH v6 11/18] s390x: protvirt: Set guest IPL PSW

2020-03-04 Thread Janosch Frank
Handling of CPU reset and setting of the IPL psw from guest storage at offset 0 is done by a Ultravisor call. Let's only fetch it if necessary. Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth --- target/s390x/cpu.c | 23 ++- 1 file changed, 14 insertions(+), 9

[PULL v1 04/10] tpm: Separate TPM_TIS and TPM_TIS_ISA configs

2020-03-04 Thread Stefan Berger
From: Eric Auger Let's separate the compilation of tpm_tis_common.c from the compilation of tpm_tis_isa.c The common part will be also compiled along with the tpm_tis_sysbus device. Signed-off-by: Eric Auger Reviewed-by: Philippe Mathieu-Daudé Tested-by: Ard Biesheuvel Acked-by: Ard

[PULL v1 01/10] tpm: rename TPM_TIS into TPM_TIS_ISA

2020-03-04 Thread Stefan Berger
From: Eric Auger As we plan to introduce a sysbus TPM_TIS, let's rename TPM_TIS into TPM_TIS_ISA. Signed-off-by: Eric Auger Reviewed-by: Stefan Berger Reviewed-by: Philippe Mathieu-Daudé Tested-by: Ard Biesheuvel Acked-by: Ard Biesheuvel Message-id:

Re: [PATCH 1/2] misc: Replace zero-length arrays with flexible array member (automatic)

2020-03-04 Thread Philippe Mathieu-Daudé
On 3/4/20 1:51 AM, Philippe Mathieu-Daudé wrote: Description copied from Linux kernel commit from Gustavo A. R. Silva (see [3]): --v-- description start --v-- The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to

Re: [PATCH v2] Fixed integer overflow in e1000e

2020-03-04 Thread Philippe Mathieu-Daudé
On 3/4/20 3:20 PM, and...@daynix.com wrote: From: Andrew Melnychenko Fixes: 6f3fbe4ed06 Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1737400 Fixed setting max_queue_num if there are no peers in NICConf. qemu_new_nic() creates NICState with 1 NetClientState(index 0) without peers, set

[PATCH v6 09/18] s390x: protvirt: Move STSI data over SIDAD

2020-03-04 Thread Janosch Frank
For protected guests, we need to put the STSI emulation results into the SIDA, so SIE will write them into the guest at the next entry. Signed-off-by: Janosch Frank Acked-by: David Hildenbrand --- target/s390x/kvm.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff

Re: [PATCH v9 0/4] delete created files when block_crypto_co_create_opts_luks fails

2020-03-04 Thread Daniel Henrique Barboza
Ping On 1/30/20 6:39 PM, Daniel Henrique Barboza wrote: The version 8 of this patch series got buried and it's now conflicting with master. Rebase and re-sending it. Also, I contemplated the idea of moving/copying the password verification in qcrypto_block_luks_create() all the way back to the

[PATCH v2 0/2] misc: Replace zero-length arrays with flexible array member

2020-03-04 Thread Philippe Mathieu-Daudé
v2: - do not modify qed.h (structure with single member) - based on hw/scsi/spapr_vscsi fix series: 20200304153311.22959-1-philmd@redhat.com">https://mid.mail-archive.com/20200304153311.22959-1-philmd@redhat.com This is a tree-wide cleanup inspired by a Linux kernel commit (from Gustavo A. R.

Re: [PATCH v4 5/5] iotests: 287: add qcow2 compression type test

2020-03-04 Thread Denis Plotnikov
On 04.03.2020 14:27, Vladimir Sementsov-Ogievskiy wrote: 03.03.2020 16:34, Denis Plotnikov wrote: The test checks fulfilling qcow2 requiriements for the compression type feature and zstd compression type operability. Signed-off-by: Denis Plotnikov ---   tests/qemu-iotests/287 | 127

[PATCH v5 2/5] qcow2: introduce compression type feature

2020-03-04 Thread Denis Plotnikov
The patch adds some preparation parts for incompatible compression type feature to qcow2 allowing the use different compression methods for image clusters (de)compressing. It is implied that the compression type is set on the image creation and can be changed only later by image conversion, thus

Re: [PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp

2020-03-04 Thread Vladimir Sementsov-Ogievskiy
23.02.2020 11:55, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and does corresponding changes in code (look for details in include/qapi/error.h) Usage example: spatch --sp-file

Re: [kvm-unit-tests PATCH v3 05/14] arm/arm64: ITS: Introspection tests

2020-03-04 Thread Auger Eric
Hi Drew, On 2/7/20 11:19 AM, Andrew Jones wrote: > On Tue, Jan 28, 2020 at 11:34:50AM +0100, Eric Auger wrote: >> Detect the presence of an ITS as part of the GICv3 init >> routine, initialize its base address and read few registers >> the IIDR, the TYPER to store its dimensioning parameters. >>

[PATCH] audio: Add sndio backend

2020-03-04 Thread Brad Smith
Add a sndio backend. sndio is the native API used by OpenBSD, although it has been ported to other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.). The C code is from Alexandre Ratchov and the rest of the bits are from me. Signed-off-by: Alexandre Ratchov Signed-off-by: Brad

[PATCH v2 2/2] misc: Replace zero-length arrays with flexible array member (manual)

2020-03-04 Thread Philippe Mathieu-Daudé
Description copied from Linux kernel commit from Gustavo A. R. Silva (see [3]): --v-- description start --v-- The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a

Re: [PATCH v2 4/4] net: Remove field info_str of NetClientState

2020-03-04 Thread Laurent Vivier
On 04/03/2020 14:06, Alexey Kirillov wrote: > Completely remove the info_str field of struct NetClientState because > it is no longer required due to the addition of the QMP query-netdevs command. > > Signed-off-by: Alexey Kirillov > --- > hw/net/allwinner_emac.c | 2 +- > hw/net/dp8393x.c

[PATCH v2 0/4] Introducing QMP query-netdevs command

2020-03-04 Thread Alexey Kirillov
This patch series introduces a new QMP command "query-netdevs" to get information about currently attached network devices. Also, since the "info_str" field of "NetClientState" is now deprecated, it has been completely removed. The HMP command "info network" now also uses the new QMP command

[PATCH v2 1/4] qapi: net: Add query-netdevs command

2020-03-04 Thread Alexey Kirillov
Add a qmp command that provides information about currently attached network devices and their configuration. Signed-off-by: Alexey Kirillov --- include/net/net.h | 1 + net/hub.c | 8 +++ net/l2tpv3.c | 19 +++ net/net.c | 91 +

[PATCH v2 3/4] hmp: Use QMP query-netdevs in hmp_info_network

2020-03-04 Thread Alexey Kirillov
Replace legacy field info_str of NetClientState with result of QMP command query-netdevs. Signed-off-by: Alexey Kirillov --- include/net/net.h | 3 +- net/clients.h | 1 + net/hub.c | 4 +- net/hub.h | 2 +- net/net.c | 175

[PATCH v2 2/4] tests: Add tests for query-netdevs command

2020-03-04 Thread Alexey Kirillov
Signed-off-by: Alexey Kirillov --- tests/qtest/Makefile.include | 2 + tests/qtest/test-query-netdevs.c | 120 +++ 2 files changed, 122 insertions(+) create mode 100644 tests/qtest/test-query-netdevs.c diff --git a/tests/qtest/Makefile.include

[PATCH v5 4/5] qcow2: add zstd cluster compression

2020-03-04 Thread Denis Plotnikov
zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compression method available. The performance test results: Test compresses and

Re: [PATCH v6 18/18] pc-bios: s390x: Save iplb location in lowcore

2020-03-04 Thread David Hildenbrand
On 04.03.20 14:25, Christian Borntraeger wrote: > On 04.03.20 12:42, Janosch Frank wrote: >> The POP states that for a list directed IPL the IPLB is stored into >> memory by the machine loader and its address is stored at offset 0x14 >> of the lowcore. >> >> ZIPL currently uses the address in

Re: [PATCH V4 0/5] Introduce Advanced Watch Dog module

2020-03-04 Thread Paolo Bonzini
On 04/03/20 09:06, Zhang, Chen wrote: >> Hi Eric and Paolo, Can you give some comments about this series? >> >> > No news for a while... > We already have some users(Cloud Service Provider) try to use is module in > their product. > But they also need to follow the Qemu upstream code. My main

[PATCH v5 5/5] iotests: 287: add qcow2 compression type test

2020-03-04 Thread Denis Plotnikov
The test checks fulfilling qcow2 requiriements for the compression type feature and zstd compression type operability. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/287 | 128 + tests/qemu-iotests/287.out

Re: [PATCH v5 2/5] qcow2: introduce compression type feature

2020-03-04 Thread Markus Armbruster
Denis Plotnikov writes: > The patch adds some preparation parts for incompatible compression type > feature to qcow2 allowing the use different compression methods for > image clusters (de)compressing. > > It is implied that the compression type is set on the image creation and > can be changed

[PATCH v2 2/4] qapi: Drop conditionals for Python 2

2020-03-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé --- scripts/qapi/common.py | 6 +- scripts/qapi/gen.py| 6 +- scripts/qapi/parser.py | 6 +- tests/qapi-schema/test-qapi.py | 6 +- 4 files changed, 4 insertions(+), 20 deletions(-)

[PATCH v2 3/4] qapi: Use super() now we have Python 3

2020-03-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- scripts/qapi/commands.py | 4 +-- scripts/qapi/error.py | 4 +-- scripts/qapi/events.py | 4 +-- scripts/qapi/gen.py| 10 scripts/qapi/introspect.py | 4 +-- scripts/qapi/parser.py | 2 +- scripts/qapi/schema.py | 51

[PATCH v2 0/4] qapi: Bye-bye Python 2

2020-03-04 Thread Markus Armbruster
v2: * PATCH 3: Don't mess up indentation * PATCH 4: Additionally clean up a pycodestyle-3 "E713 test for membership should be 'not in'" Markus Armbruster (4): qapi: Inheriting from object is pointless with Python 3, drop qapi: Drop conditionals for Python 2 qapi: Use super() now we have

[PATCH v6 04/18] s390x: protvirt: Add migration blocker

2020-03-04 Thread Janosch Frank
Migration is not yet supported. Signed-off-by: Janosch Frank --- hw/s390x/s390-virtio-ccw.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index dd39890f89..272531a9ee 100644 ---

[PATCH v6 08/18] s390x: Add SIDA memory ops

2020-03-04 Thread Janosch Frank
Protected guests save the instruction control blocks in the SIDA instead of QEMU/KVM directly accessing the guest's memory. Let's introduce new functions to access the SIDA. Signed-off-by: Janosch Frank --- linux-headers/linux/kvm.h | 2 ++ target/s390x/cpu.h| 7 ++-

[PATCH v6 02/18] s390x: protvirt: Add diag308 subcodes 8 - 10

2020-03-04 Thread Janosch Frank
For diag308 subcodes 8 - 10 we have a new ipib of type 5. The ipib holds the address and length of the secure execution header, as well as a list of guest components. Each component is a block of memory, for example kernel or initrd, which needs to be decrypted by the Ultravisor in order to run a

[PULL v1 02/10] tpm: Use TPMState as a common struct

2020-03-04 Thread Stefan Berger
From: Eric Auger As we plan to introduce a SysBus TPM TIS device, let's make the TPMState a common struct usable by both the ISADevice and the SysBusDevice. TPMStateISA embeds the struct and inherits from the ISADevice. The prototype of functions bound to be used by both the ISA and SysBus

[PATCH v5 3/5] qcow2: rework the cluster compression routine

2020-03-04 Thread Denis Plotnikov
The patch enables processing the image compression type defined for the image and chooses an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-threads.c | 71

[PATCH v5 0/5] qcow2: Implement zstd cluster compression method

2020-03-04 Thread Denis Plotnikov
v5: * replace -ENOTSUP with abort in qcow2_co_decompress [Vladimir] * set cluster size for all test cases in the beginning of the 287 test v4: * the series is rebased on top of 01 "block/qcow2-threads: fix qcow2_decompress" * 01 is just a no-change resend to avoid extra dependencies.

[PATCH v5 1/5] block/qcow2-threads: fix qcow2_decompress

2020-03-04 Thread Denis Plotnikov
From: Vladimir Sementsov-Ogievskiy On success path we return what inflate() returns instead of 0. And it most probably works for Z_STREAM_END as it is positive, but is definitely broken for Z_BUF_ERROR. While being here, switch to errno return code, to be closer to qcow2_compress API (and usual

Re: [PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp

2020-03-04 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 23.02.2020 11:55, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and >>> does corresponding changes in code (look for details in >>> include/qapi/error.h) >>> >>>

[PATCH v2 1/2] misc: Replace zero-length arrays with flexible array member (automatic)

2020-03-04 Thread Philippe Mathieu-Daudé
Description copied from Linux kernel commit from Gustavo A. R. Silva (see [3]): --v-- description start --v-- The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a

Re: [PATCH v5 40/50] multi-process/mig: build migration module in the remote process

2020-03-04 Thread Dr. David Alan Gilbert
* Jagannathan Raman (jag.ra...@oracle.com) wrote: > Add Makefile support to enable migration in remote process > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > Makefile.objs | 4 +++- > Makefile.target | 1 + >

[PATCH v2 1/4] qapi: Inheriting from object is pointless with Python 3, drop

2020-03-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé --- scripts/qapi/gen.py| 2 +- scripts/qapi/parser.py | 6 +++--- scripts/qapi/schema.py | 12 ++-- scripts/qapi/source.py | 4 ++-- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git

[PATCH v6 12/18] s390x: protvirt: Move diag 308 data over SIDAD

2020-03-04 Thread Janosch Frank
For protected guests the IPIB is written/read to/from the satellite block, so we need those accesses to go through s390_cpu_pv_mem_read/write(). Signed-off-by: Janosch Frank --- target/s390x/diag.c | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git

[PATCH v6 16/18] s390x: Add unpack facility feature to GA1

2020-03-04 Thread Janosch Frank
From: Christian Borntraeger The unpack facility is an indication that diagnose 308 subcodes 8-10 are available to the guest. That means, that the guest can put itself into protected mode. Once it is in protected mode, the hardware stops any attempt of VM introspection by the hypervisor. Some

[PATCH v6 18/18] pc-bios: s390x: Save iplb location in lowcore

2020-03-04 Thread Janosch Frank
The POP states that for a list directed IPL the IPLB is stored into memory by the machine loader and its address is stored at offset 0x14 of the lowcore. ZIPL currently uses the address in offset 0x14 to access the IPLB and acquire flags about secure boot. If the IPLB address points into memory

Re: [PATCH v6 18/18] pc-bios: s390x: Save iplb location in lowcore

2020-03-04 Thread Christian Borntraeger
On 04.03.20 12:42, Janosch Frank wrote: > The POP states that for a list directed IPL the IPLB is stored into > memory by the machine loader and its address is stored at offset 0x14 > of the lowcore. > > ZIPL currently uses the address in offset 0x14 to access the IPLB and > acquire flags about

Re: [PATCH] dp8393x: Mask EOL bit from descriptor addresses, take 2

2020-03-04 Thread Philippe Mathieu-Daudé
On 3/4/20 4:23 AM, Finn Thain wrote: A portion of a recent patch got lost due to a merge snafu. That patch is now commit 88f632fbb1 ("dp8393x: Mask EOL bit from descriptor addresses"). This patch restores the portion that got lost. Signed-off-by: Finn Thain --- hw/net/dp8393x.c | 4 ++-- 1

[PATCH v2] Fixed integer overflow in e1000e

2020-03-04 Thread andrew
From: Andrew Melnychenko Fixes: 6f3fbe4ed06 Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1737400 Fixed setting max_queue_num if there are no peers in NICConf. qemu_new_nic() creates NICState with 1 NetClientState(index 0) without peers, set max_queue_num to 0 - It prevents undefined

Re: [kvm-unit-tests PATCH v3 08/14] arm/arm64: ITS: its_enable_defaults

2020-03-04 Thread Auger Eric
Hi Zenghui, On 2/7/20 4:20 AM, Zenghui Yu wrote: > Hi Eric, > > On 2020/1/28 18:34, Eric Auger wrote: >> its_enable_defaults() is the top init function that allocates the >> command queue and all the requested tables (device, collection, >> lpi config and pending tables), enable LPIs at

[PATCH v2 4/4] qapi: Brush off some (py)lint

2020-03-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- scripts/qapi/commands.py | 2 +- scripts/qapi/expr.py | 3 +-- scripts/qapi/gen.py| 9 ++--- scripts/qapi/introspect.py | 2 -- scripts/qapi/parser.py | 6 ++ scripts/qapi/schema.py | 11 +-- 6 files changed, 15

Re: [PATCH v6 02/18] s390x: protvirt: Add diag308 subcodes 8 - 10

2020-03-04 Thread David Hildenbrand
On 04.03.20 12:42, Janosch Frank wrote: > For diag308 subcodes 8 - 10 we have a new ipib of type 5. The ipib > holds the address and length of the secure execution header, as well > as a list of guest components. > > Each component is a block of memory, for example kernel or initrd, > which needs

Re: [PATCH v6 02/18] s390x: protvirt: Add diag308 subcodes 8 - 10

2020-03-04 Thread David Hildenbrand
On 04.03.20 12:42, Janosch Frank wrote: > For diag308 subcodes 8 - 10 we have a new ipib of type 5. The ipib > holds the address and length of the secure execution header, as well > as a list of guest components. > > Each component is a block of memory, for example kernel or initrd, > which needs

  1   2   3   >