[Bug 1873032] Re: After upgrade qemu to 5.0.0-0.3.rc2.fc33 the virtual machine with Windows 10 after a while starts to work very slowly

2020-05-13 Thread Mikhail Gavrilov
I confirm that with patches https://lists.gnu.org/archive/html/qemu- devel/2020-05/msg02728.html Win 10 in QEMU working already more than 24 hours without issue. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[PATCH v2] i386/kvm: fix a use-after-free when vcpu plug/unplug

2020-05-13 Thread Pan Nengyuan
When we hotplug vcpus, cpu_update_state is added to vm_change_state_head in kvm_arch_init_vcpu(). But it forgot to delete in kvm_arch_destroy_vcpu() after unplug. Then it will cause a use-after-free access. This patch delete it in kvm_arch_destroy_vcpu() to fix that. Reproducer: virsh

Re: Qemu, VNC and non-US keymaps

2020-05-13 Thread B3r3n
Hello Daniel, Ok, TigerVNC, added -shared=1 to behave the same as TightVNC, works greatly, Thanks ! But funny thing, I saw you were part of exchanges on that topic, noVNC totally fails now. Despite my keyboard isnt changed, debian VM is just in QWERTY as if noVNC only send keysyms. If you

Re: [PATCH v1 3/8] s390/sclp: rework sclp boundary and length checks

2020-05-13 Thread Cornelia Huck
On Tue, 12 May 2020 10:55:56 -0400 Collin Walling wrote: > On 5/12/20 3:21 AM, David Hildenbrand wrote: > > On 09.05.20 01:08, Collin Walling wrote: > >> +static bool check_sufficient_sccb_len(SCCB *sccb, int size) > > > > "has_sufficient_sccb_len" ? > > > >> +{ > >> +MachineState

Re: [PATCH] qemu-nbd: Close inherited stderr

2020-05-13 Thread Raphael Pour
On 5/12/20 3:57 PM, Eric Blake wrote: > Wouldn't it just be simpler to not dup in the first place? > > diff --git i/qemu-nbd.c w/qemu-nbd.c > index 4aa005004ebd..6ba2544feb3a 100644 > --- i/qemu-nbd.c > +++ w/qemu-nbd.c > @@ -916,7 +916,9 @@ int main(int argc, char **argv) > } else if

Re: [PATCH v1 2/8] s390/sclp: check sccb len before filling in data

2020-05-13 Thread Cornelia Huck
On Wed, 13 May 2020 09:43:37 +0200 Janosch Frank wrote: > On 5/12/20 6:01 PM, Cornelia Huck wrote: > > On Mon, 11 May 2020 17:02:06 +0200 > > David Hildenbrand wrote: > > > >> On 11.05.20 16:50, Janosch Frank wrote: > >>> On 5/11/20 4:44 PM, David Hildenbrand wrote: > On 11.05.20

Re: [PATCH v1 2/8] s390/sclp: check sccb len before filling in data

2020-05-13 Thread Janosch Frank
On 5/12/20 6:01 PM, Cornelia Huck wrote: > On Mon, 11 May 2020 17:02:06 +0200 > David Hildenbrand wrote: > >> On 11.05.20 16:50, Janosch Frank wrote: >>> On 5/11/20 4:44 PM, David Hildenbrand wrote: On 11.05.20 16:36, Janosch Frank wrote: > On 5/9/20 1:08 AM, Collin Walling wrote:

Re: [PATCH v1 1/1] target/microblaze: Add MFS Rd,EDR translation

2020-05-13 Thread Luc Michel
On 5/12/20 4:36 PM, Edgar E. Iglesias wrote: > From: Tong Ho > > This is to fix cpu-abort with 'qemu: fatal: unknown mfs reg d' > (in the default case) when microblaze guest issues 'MFS Rd,EDR' > instruction. > > Since embeddedsw release 2019.2, XPlm_ExceptionHandler() issues > the instruction

Re: [PATCH 2/3] mips/mips_fulong2e: Set preferred page size to 16KB

2020-05-13 Thread Huacai Chen
Hi, Aleksandar, On Wed, May 13, 2020 at 3:56 PM Aleksandar Markovic wrote: > > сре, 8. апр 2020. у 11:08 Huacai Chen је написао/ла: > > > > Loongson processor prefers 16KB page size in system emulator, so let's > > define mc->minimum_page_bits to 14. > > > > Cc: Jiaxun Yang > > Signed-off-by:

Re: [PATCH v1 7/8] s390/kvm: header sync for diag318

2020-05-13 Thread Cornelia Huck
On Fri, 8 May 2020 19:08:22 -0400 Collin Walling wrote: > Signed-off-by: Collin Walling > --- > linux-headers/asm-s390/kvm.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h > index 0138ccb0d8..b661feafdc 100644 > ---

Re: [PATCH 1/3] target/mips: Support variable page size

2020-05-13 Thread Aleksandar Markovic
сре, 8. апр 2020. у 11:07 Huacai Chen је написао/ла: > > Traditionally, MIPS use 4KB page size, but Loongson prefer 16KB page > size in system emulator. So, let's define TARGET_PAGE_BITS_VARY and > TARGET_PAGE_BITS_MIN to support variable page size. > > Cc: Jiaxun Yang > Signed-off-by: Huacai

Re: [PATCH 2/3] mips/mips_fulong2e: Set preferred page size to 16KB

2020-05-13 Thread Aleksandar Markovic
сре, 8. апр 2020. у 11:08 Huacai Chen је написао/ла: > > Loongson processor prefers 16KB page size in system emulator, so let's > define mc->minimum_page_bits to 14. > > Cc: Jiaxun Yang > Signed-off-by: Huacai Chen > --- Huacai, thanks for the efforts regarding this series! I will very likely

[Bug 1878348] [NEW] --static build fails in v5.0 (since 5010cec2bc87dafab39b3913c8ca91f88df9c540)

2020-05-13 Thread Christophe Lyon
Public bug reported: Hi, Since commit 5010cec2bc87dafab39b3913c8ca91f88df9c540, building qemu fails when configured with --static (eg ../configure --target- list=x86_64-softmmu,x86_64-linux-user --enable-debug --static). On ubuntu 16.04, it fails to find -lffi and -lselinux. After I apt-get

Re: [PATCH v2 4/5] vhost: check vring address before calling unmap

2020-05-13 Thread Dima Stepanov
On Wed, May 13, 2020 at 11:00:38AM +0800, Jason Wang wrote: > > On 2020/5/12 下午5:08, Dima Stepanov wrote: > >On Tue, May 12, 2020 at 11:26:11AM +0800, Jason Wang wrote: > >>On 2020/5/11 下午5:11, Dima Stepanov wrote: > >>>On Mon, May 11, 2020 at 11:05:58AM +0800, Jason Wang wrote: > On

[PATCH v5 11/15] copy-on-read: Support preadv/pwritev_part functions

2020-05-13 Thread Andrey Shinkevich
Add support for the recently introduced functions bdrv_co_preadv_part() and bdrv_co_pwritev_part() to the COR-filter driver. Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git

[PATCH v5 10/15] copy-on-read: Support change filename functions

2020-05-13 Thread Andrey Shinkevich
The COR-filter driver should support a redirecting function to refresh filenames. Otherwise, a file name of the filter will be copied instead of the one of a data node. It is also true for the function bdrv_change_backing_file(). Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 18

Re: [PATCH 0/5] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-05-13 Thread Kevin Wolf
Am 12.05.2020 um 11:43 hat Daniel P. Berrangé geschrieben: > On Tue, May 12, 2020 at 11:32:06AM +0200, Lukas Straub wrote: > > On Mon, 11 May 2020 16:46:45 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > ... > > > > That way if

Re: [PATCH v2 3/4] mirror: Make sure that source and target size match

2020-05-13 Thread Vladimir Sementsov-Ogievskiy
12.05.2020 21:48, Kevin Wolf wrote: Am 12.05.2020 um 19:15 hat Vladimir Sementsov-Ogievskiy geschrieben: 11.05.2020 16:58, Kevin Wolf wrote: If the target is shorter than the source, mirror would copy data until it reaches the end of the target and then fail with an I/O error when trying to

[PATCH 10/12] target/mips: fpu: Remove now unused UNFUSED_FMA and FLOAT_FMA macros

2020-05-13 Thread Aleksandar Markovic
After demacroing ., these macros are not needed anymore. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 50 1 file changed, 50 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c index 927bac24ac..e8e50e4bc0

[PATCH 12/12] hw/mips: Convert Malta "ifdef 0"-ed code to comments

2020-05-13 Thread Aleksandar Markovic
The checkpatch complain about "#ifdef 0". Convert corresponding dead code to comments. In future, these cases could be converted to some no-nonsense logging/tracing. Signed-off-by: Aleksandar Markovic CC: Philippe Mathieu-Daudé --- hw/mips/mips_malta.c | 20 1 file

[PATCH 04/12] target/mips: fpu: Demacro DIV.

2020-05-13 Thread Aleksandar Markovic
This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) diff --git

[PATCH 09/12] target/mips: fpu: Demacro NMSUB.

2020-05-13 Thread Aleksandar Markovic
This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 0/5] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-05-13 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 12.05.2020 um 11:43 hat Daniel P. Berrangé geschrieben: > > On Tue, May 12, 2020 at 11:32:06AM +0200, Lukas Straub wrote: > > > On Mon, 11 May 2020 16:46:45 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Daniel P. Berrangé

[PATCH v4 24/34] block: Drop child_backing

2020-05-13 Thread Max Reitz
Signed-off-by: Max Reitz --- include/block/block_int.h | 1 - block.c | 60 ++- 2 files changed, 3 insertions(+), 58 deletions(-) diff --git a/include/block/block_int.h b/include/block/block_int.h index 4b09fa1124..0781d43af5 100644 ---

[PATCH v4 30/34] block: Make bdrv_filter_default_perms() static

2020-05-13 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- include/block/block_int.h | 10 -- block.c | 17 +++-- 2 files changed, 11 insertions(+), 16 deletions(-) diff --git a/include/block/block_int.h b/include/block/block_int.h index 0781d43af5..6fc5f0d333

Re: [PATCH v2 4/4] iotests: Mirror with different source/target size

2020-05-13 Thread Vladimir Sementsov-Ogievskiy
11.05.2020 16:58, Kevin Wolf wrote: This tests that the mirror job catches situations where the target node has a different size than the source node. It must also forbid resize operations when the job is already running. Signed-off-by: Kevin Wolf Message-Id:

Re: [PATCH] iotests/030: Reduce run time by unthrottling job earlier

2020-05-13 Thread Alberto Garcia
On Wed 13 May 2020 12:00:25 PM CEST, Kevin Wolf wrote: > test_overlapping_3() throttles its active commit job so it can be sure > the job is still busy when it checks that you can't start a conflicting > streaming job. > > However, it only sets the commit job back to full speed when it is > ready,

Re: [PATCH v1 0/1] target/microblaze: Fix FPU2 instruction check

2020-05-13 Thread Edgar E. Iglesias
On Mon, May 11, 2020 at 10:49:05AM -0700, Joe Komlodi wrote: > Hi all, > > This fixes a backwards if statement that caused Microblaze FPU2 instructions > to not be executed, even if use-fpu=2 in the DTS. > > Thanks! > Joe Reviewed-by: Edgar E. Iglesias > > Joe Komlodi (1): >

Re: [PATCH v2 2/2] net: Drop the NetLegacy structure, always use Netdev instead

2020-05-13 Thread Thomas Huth
On 12/05/2020 17.51, Eric Blake wrote: > On 5/12/20 10:13 AM, Thomas Huth wrote: > +++ b/qapi/net.json @@ -453,7 +453,7 @@    #    'l2tpv3' - since 2.1    ##    { 'union': 'Netdev', -  'base': { 'id': 'str', 'type': 'NetClientDriver' }, +  'base': { '*id':

Re: [PATCH RESEND v6 01/36] memory: alloc RAM from file at offset

2020-05-13 Thread Stefan Hajnoczi
On Tue, May 12, 2020 at 07:56:33AM -0400, Jag Raman wrote: > > > > On May 12, 2020, at 4:48 AM, Daniel P. Berrangé wrote: > > > > On Wed, Apr 22, 2020 at 09:13:36PM -0700, elena.ufimts...@oracle.com wrote: > >> From: Jagannathan Raman > >> > >> Allow RAM MemoryRegion to be created from an

[PATCH v5 07/15] commit: Deal with filters when blocking intermediate nodes

2020-05-13 Thread Andrey Shinkevich
From: Max Reitz This includes some permission limiting (for example, we only need to take the RESIZE permission if the base is smaller than the top). Signed-off-by: Max Reitz Signed-off-by: Andrey Shinkevich --- block/commit.c | 75 ++

[PATCH v5 06/15] block: Use CAFs in block status functions

2020-05-13 Thread Andrey Shinkevich
From: Max Reitz Use the child access functions in the block status inquiry functions as appropriate. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/block/io.c

[PATCH v5 15/15] block: apply COR-filter to block-stream jobs

2020-05-13 Thread Andrey Shinkevich
The patch completes the series with the COR-filter insertion to any block-stream operation. It also makes changes to the iotests 030 and 141.out. Signed-off-by: Andrey Shinkevich --- block/stream.c | 83 -- tests/qemu-iotests/030 | 8

Re: [PATCH] ppc/pnv: Add definitions for interrupts occurring in power-saving mode

2020-05-13 Thread David Gibson
On Mon, May 11, 2020 at 10:58:22AM +0200, Cédric Le Goater wrote: > If an interrupt occurred when the thread was in power-saving mode, > bits [42:45] of SRR1 indicate the exception that caused exit from > power-saving mode. > > bits [46:47] of SRR1 indicate the power-saving mode in which the >

Re: [PATCH] block/replication.c: Avoid cancelling the job twice

2020-05-13 Thread Kevin Wolf
Am 11.05.2020 um 09:08 hat Lukas Straub geschrieben: > If qemu in colo secondary mode is stopped, it crashes because > s->backup_job is canceled twice: First with job_cancel_sync_all() > in qemu_cleanup() and then in replication_stop(). > > Fix this by assigning NULL to s->backup_job when the job

Re: [PATCH v2] i386/kvm: fix a use-after-free when vcpu plug/unplug

2020-05-13 Thread Igor Mammedov
On Wed, 13 May 2020 09:26:30 -0400 Pan Nengyuan wrote: > When we hotplug vcpus, cpu_update_state is added to vm_change_state_head > in kvm_arch_init_vcpu(). But it forgot to delete in kvm_arch_destroy_vcpu() > after > unplug. Then it will cause a use-after-free access. This patch delete it in >

Re: [RFC v4 6/6] hmp: add x-debug-virtio commands

2020-05-13 Thread Dr. David Alan Gilbert
* Laurent Vivier (lviv...@redhat.com) wrote: > This patch implements HMP version of the virtio QMP commands > > Signed-off-by: Laurent Vivier Reviewed-by: Dr. David Alan Gilbert With a thought below > --- > Makefile| 2 +- > Makefile.target | 7 +- >

[PATCH v4 00/34] block: Introduce real BdrvChildRole

2020-05-13 Thread Max Reitz
Based-on: <20200429141126.85159-1-mre...@redhat.com> (“block: Do not call BlockDriver.bdrv_make_empty() directly”) Branch: https://github.com/XanClic/qemu.git child-role-v4 Branch: https://git.xanclic.moe/XanClic/qemu.git child-role-v4 v1:

[PATCH v4 03/34] block: Rename BdrvChildRole to BdrvChildClass

2020-05-13 Thread Max Reitz
This structure nearly only contains parent callbacks for child state changes. It cannot really reflect a child's role, because different roles may overlap (as we will see when real roles are introduced), and because parents can have custom callbacks even when the child fulfills a standard role.

[PATCH v4 04/34] block: Add BdrvChildRole and BdrvChildRoleBits

2020-05-13 Thread Max Reitz
This mask will supplement BdrvChildClass when it comes to what role (or combination of roles) a child takes for its parent. It consists of BdrvChildRoleBits values (which is an enum). Because empty enums are not allowed, let us just start with it filled. Signed-off-by: Max Reitz ---

[PATCH v4 12/34] block: Unify bdrv_child_cb_attach()

2020-05-13 Thread Max Reitz
Make bdrv_child_cb_attach() call bdrv_backing_attach() for children with a COW role (and drop the reverse call from bdrv_backing_attach()), so it can be used for any child (with a proper role set). Because so far no child has a proper role set, we need a temporary new callback for

[PATCH v4 28/34] tests: Use child_of_bds instead of child_file

2020-05-13 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/test-bdrv-drain.c | 29 + tests/test-bdrv-graph-mod.c | 6 -- 2 files changed, 21 insertions(+), 14 deletions(-) diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c index

[PATCH v4 18/34] block: Relax *perms_for_storage for data children

2020-05-13 Thread Max Reitz
We can be less restrictive about pure data children than those with metadata on them, so let bdrv_default_perms_for_storage() handle metadata children differently from pure data children. As explained in the code, the restrictions on metadata children are strictly stricter than those for pure

[PATCH v4 11/34] block: Use bdrv_inherited_options()

2020-05-13 Thread Max Reitz
Let child_file's, child_format's, and child_backing's .inherit_options() implementations fall back to bdrv_inherited_options() to show that it would really work for all of these cases, if only the parents passed the appropriate BdrvChildRole and parent_is_format values. (Also, make

[PATCH v4 34/34] block: Drop @child_class from bdrv_child_perm()

2020-05-13 Thread Max Reitz
Implementations should decide the necessary permissions based on @role. Signed-off-by: Max Reitz --- include/block/block_int.h | 4 +--- block.c | 39 +++-- block/backup-top.c | 3 +-- block/blkdebug.c| 3 +--

Re: 回复: [PATCH 0/2] use unsigned type for MegasasState fields

2020-05-13 Thread P J P
+-- On Tue, 12 May 2020, Philippe Mathieu-Daudé wrote --+ | The cover describes the bug as OOB, so I suppose this is a security issue. | Now a 6 months embargo surprises me. I was expecting some period in a | 30-90days range to be the default. However reading the 'Publication embargo' | chapter

Re: [PATCH 0/5] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-05-13 Thread Kevin Wolf
Am 13.05.2020 um 12:53 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kw...@redhat.com) wrote: > > Am 12.05.2020 um 11:43 hat Daniel P. Berrangé geschrieben: > > > On Tue, May 12, 2020 at 11:32:06AM +0200, Lukas Straub wrote: > > > > On Mon, 11 May 2020 16:46:45 +0100 > > > > "Dr. David

Re: [PATCH 0/5] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-05-13 Thread Paolo Bonzini
On 13/05/20 13:26, Daniel P. Berrangé wrote: > Are you referring to the in-kernel NFS client hangs here ? AFAIK, it is > impossible to do anything to get out of those hangs from userspace, because > the thread is stuck in an uninterruptable sleep in kernel space. > > If using the in-QEMU NFS

Re: [PATCH 0/5] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-05-13 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 13/05/20 13:26, Daniel P. Berrangé wrote: > > Are you referring to the in-kernel NFS client hangs here ? AFAIK, it is > > impossible to do anything to get out of those hangs from userspace, because > > the thread is stuck in an uninterruptable

Re: [PATCH 1/2] iotests: Fix incomplete type declarations

2020-05-13 Thread Max Reitz
On 11.05.20 18:35, Kevin Wolf wrote: > We need to fix only a few places so that iotests.py can pass > mypy --disallow-incomplete-defs, which seems to be a desirable option to > have enabled in the long run. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/iotests.py | 8 > 1

Re: [PATCH v1 0/4] target/microblaze: Add dynamic GDB XML and correct SReg reporting

2020-05-13 Thread Edgar E. Iglesias
On Mon, May 11, 2020 at 10:05:47AM -0700, Joe Komlodi wrote: > Hi all, > > This series adds dynamic GDB XML support for Micraoblaze CPUs, and fixes > an issue when reporting Microblaze SRegs through GDB. > > The SRegs used to be printed out by iterating over the SReg array, but the > SReg array

[PATCH] tests/docker: Kludge breakage by pinning linux-libc-dev

2020-05-13 Thread Philippe Mathieu-Daudé
Linux kernel commit d5767057c9a [1] aimed to fix an issue with the swab() declaration, but doing so it introduced the BITS_PER_LONG definition, without using the kernel __ prefix, leading to odd failures in userland code using kernel uapi headers, such: CC block/file-posix.o In

Re: [PATCH 2/2] iotests: Run pylint and mypy in a testcase

2020-05-13 Thread Max Reitz
On 11.05.20 18:35, Kevin Wolf wrote: > We made sure that iotests.py passes pylint. It would be a shame if we > allowed new patches in that break this again, so let's just add a > meta-test case that runs pylint on it. > > While we don't pass mypy --strict yet, we can already run it with a few >

Re: [PATCH 0/5] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-05-13 Thread Kevin Wolf
Am 13.05.2020 um 13:26 hat Daniel P. Berrangé geschrieben: > On Wed, May 13, 2020 at 01:13:20PM +0200, Kevin Wolf wrote: > > Am 13.05.2020 um 12:53 hat Dr. David Alan Gilbert geschrieben: > > > * Kevin Wolf (kw...@redhat.com) wrote: > > > > Am 12.05.2020 um 11:43 hat Daniel P. Berrangé

Re: [PATCH 0/5] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-05-13 Thread Kevin Wolf
Am 13.05.2020 um 13:58 hat Paolo Bonzini geschrieben: > On 13/05/20 13:26, Daniel P. Berrangé wrote: > > Are you referring to the in-kernel NFS client hangs here ? AFAIK, it is > > impossible to do anything to get out of those hangs from userspace, because > > the thread is stuck in an

Re: [PATCH 0/5] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-05-13 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 13.05.2020 um 12:53 hat Dr. David Alan Gilbert geschrieben: > > * Kevin Wolf (kw...@redhat.com) wrote: > > > Am 12.05.2020 um 11:43 hat Daniel P. Berrangé geschrieben: > > > > On Tue, May 12, 2020 at 11:32:06AM +0200, Lukas Straub wrote: > > > > > On

[Bug 1878413] [NEW] /proc/sys/fs/binfmt_misc/ empty even though binfmt_misc is loaded

2020-05-13 Thread Hans-Christoph Steiner
Public bug reported: _apksigner_ uses binfmt to execute via _jarwrapper_, since it is a JAR. We have a test suite that relies on _apksigner_ working. It was running fine in Ubuntu/bionic. Since it was pegged to LTS, it got upgraded to Ubuntu/focal and it stopped working. This is likely because

[PATCH v4 00/16] target/arm: partial vector cleanup

2020-05-13 Thread Richard Henderson
Version 4 fixes the VRSRA bug, and updates for other review comments. For patch 13 "target/arm: Pass pointer to qc to qrdmla/qrdmls", I added a note about the type change on the inline functions. r~ Richard Henderson (16): target/arm: Create gen_gvec_[us]sra target/arm: Create

[PATCH v4 01/16] target/arm: Create gen_gvec_[us]sra

2020-05-13 Thread Richard Henderson
The functions eliminate duplication of the special cases for this operation. They match up with the GVecGen2iFn typedef. Add out-of-line helpers. We got away with only having inline expanders because the neon vector size is only 16 bytes, and we know that the inline expansion will always

[PATCH v4 08/16] target/arm: Swap argument order for VSHL during decode

2020-05-13 Thread Richard Henderson
Rather than perform the argument swap during code generation, perform it during decode. This means it doesn't have to be special cased later, and we can share code with aarch64 code generation. Hopefully the decode comment addresses any confusion that might arise in between. Reviewed-by: Peter

Re: [PATCH v2 04/17] target/arm: Convert Neon VHADD 3-reg-same insns

2020-05-13 Thread Richard Henderson
On 5/12/20 9:38 AM, Peter Maydell wrote: > Convert the Neon VHADD insns in the 3-reg-same group to decodetree. > > Signed-off-by: Peter Maydell > --- > target/arm/neon-dp.decode | 2 ++ > target/arm/translate-neon.inc.c | 24 > target/arm/translate.c |

Re: [PATCH v3 2/4] qemu-img: validate image length in img_map

2020-05-13 Thread Eric Blake
On 5/13/20 8:36 AM, Eyal Moscovici wrote: The code handles this case correctly we merely skip the loop. However it Grammar suggestion: s/correctly we/correctly: we/ is probably best to return an explicit error. Reviewed-by: Eric Blake R-b still stands. Acked-by: Mark Kanda

Re: [PATCH for QEMU v2] hw/vfio: Add VMD Passthrough Quirk

2020-05-13 Thread Alex Williamson
On Wed, 13 May 2020 00:35:47 + "Derrick, Jonathan" wrote: > Hi Alex, > > I'm probably not getting the translation technical details correct. > > On Mon, 2020-05-11 at 16:59 -0600, Alex Williamson wrote: > > On Mon, 11 May 2020 15:01:27 -0400 > > Jon Derrick wrote: > > > > > The VMD

[PATCH v1 10/10] translate-all: include guest address in out_asm output

2020-05-13 Thread Alex Bennée
We already have information about where each guest instructions representation starts stored in the tcg_ctx->gen_insn_data so we can rectify the PC for faults. We can re-use this information to annotate the out_asm output with guest instruction address which makes it a bit easier to work out where

Re: [PATCH] tests/docker: Kludge breakage by pinning linux-libc-dev

2020-05-13 Thread Alex Bennée
Salvatore Bonaccorso writes: > Hi, > > On Wed, May 13, 2020 at 04:15:48PM +0100, Alex Bennée wrote: >> >> Philippe Mathieu-Daudé writes: >> >> > Linux kernel commit d5767057c9a [1] aimed to fix an issue with the >> > swab() declaration, but doing so it introduced the BITS_PER_LONG >> >

[PATCH v1 08/10] disas: include an optional note for the start of disassembly

2020-05-13 Thread Alex Bennée
This will become useful shortly for providing more information about output assembly inline. While there fix up the indenting and code formatting in disas(). Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- v2 - minor tweak to if(note){} fprintf(out,"\n") logig ---

[PATCH V2 1/4] target/microblaze: gdb: Add dynamic GDB XML register support

2020-05-13 Thread Joe Komlodi
Add dynamic GDB register XML for Microblaze, and modify the config file to use XML when building for Microblaze. For the dynamic XML to be read, there still needs to be a core XML file. Signed-off-by: Joe Komlodi --- configure | 1 + gdb-xml/microblaze-core.xml | 64

[RISU 2/9] Unify master_fd and apprentice_fd to comm_fd

2020-05-13 Thread Richard Henderson
Any one invocation cannot be both master and apprentice. Let's use only one variable for the file descriptor. Signed-off-by: Richard Henderson --- risu.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/risu.c b/risu.c index

[RISU 3/9] Hoist trace file opening

2020-05-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- risu.c | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/risu.c b/risu.c index 059348f..1c66885 100644 --- a/risu.c +++ b/risu.c @@ -363,6 +363,21 @@ int main(int argc, char **argv) } }

[RISU 1/9] Use bool for tracing variables

2020-05-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- risu.h| 3 ++- reginfo.c | 2 +- risu.c| 8 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/risu.h b/risu.h index 8d2d646..e2b4508 100644 --- a/risu.h +++ b/risu.h @@ -17,6 +17,7 @@ #include #include #include +#include

Re: [PATCH v2 0/9] RISC-V Add the OpenTitan Machine

2020-05-13 Thread Alistair Francis
On Thu, May 7, 2020 at 12:21 PM Alistair Francis wrote: > > OpenTitan is an open source silicon Root of Trust (RoT) project. This > series adds initial support for the OpenTitan machine to QEMU. > > This series add the Ibex CPU to the QEMU RISC-V target. It then adds the > OpenTitan machine, the

Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-05-13 Thread Igor Mammedov
On Tue, 12 May 2020 05:26:47 + Ani Sinha wrote: > > On May 12, 2020, at 12:23 AM, Igor Mammedov wrote: > > > >> > >> static void build_append_pci_bus_devices(Aml *parent_scope, PCIBus *bus, > >> - bool pcihp_bridge_en) > >> +

Re: [PATCH v2 11/17] target/arm: Convert Neon VADD, VSUB, VABD 3-reg-same insns to decodetree

2020-05-13 Thread Richard Henderson
On 5/12/20 9:38 AM, Peter Maydell wrote: > Convert the Neon VADD, VSUB, VABD 3-reg-same insns to decodetree. > We already have gvec helpers for addition and subtraction, but must > add one for fabd. > > Signed-off-by: Peter Maydell > --- > target/arm/helper.h | 3 ++- >

Re: [PATCH v2 2/3] megasas: avoid NULL pointer dereference

2020-05-13 Thread Alexander Bulekov
On 200514 0055, P J P wrote: > From: Prasad J Pandit > > While in megasas_handle_frame(), megasas_enqueue_frame() may > set a NULL frame into MegasasCmd object for a given 'frame_addr' > address. Add check to avoid a NULL pointer dereference issue. > > Reported-by: Alexander Bulekov > Fixes:

Re: [PATCH v2 16/17] target/arm: Convert Neon fp VMAX/VMIN/VMAXNM/VMINNM/VRECPS/VRSQRTS to decodetree

2020-05-13 Thread Richard Henderson
On 5/12/20 9:39 AM, Peter Maydell wrote: > Convert the Neon fp VMAX/VMIN/VMAXNM/VMINNM/VRECPS/VRSQRTS 3-reg-same > insns to decodetree. (These are all the remaining non-accumulation > instructions in this group.) > > Signed-off-by: Peter Maydell > --- > target/arm/neon-dp.decode | 6 +++

Re: [PATCH v4 14/34] block: Add child_of_bds

2020-05-13 Thread Eric Blake
On 5/13/20 6:05 AM, Max Reitz wrote: Any current user of child_file, child_format, and child_backing can and should use this generic BdrvChildClass instead, as it can handle all of these cases. However, to be able to do so, the users must pass the appropriate BdrvChildRole when the child is

Re: [PATCH v4 16/34] block: Pull out bdrv_default_perms_for_cow()

2020-05-13 Thread Eric Blake
On 5/13/20 6:05 AM, Max Reitz wrote: Right now, bdrv_format_default_perms() is used by format parents (generally). We want to switch to a model where most parents use a single BdrvChildClass, which then decides the permissions based on the child role. To do so, we have to split

[PATCH v4 14/16] target/arm: Clear tail in gvec_fmul_idx_*, gvec_fmla_idx_*

2020-05-13 Thread Richard Henderson
Must clear the tail for AdvSIMD when SVE is enabled. Fixes: ca40a6e6e39 Cc: qemu-sta...@nongnu.org Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/vec_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/arm/vec_helper.c b/target/arm/vec_helper.c

Re: [PATCH v2 06/17] target/arm: Convert Neon VRHADD, VHSUB 3-reg-same insns to decodetree

2020-05-13 Thread Richard Henderson
On 5/12/20 9:38 AM, Peter Maydell wrote: > Convert the Neon VRHADD and VHSUB 3-reg-same insns to decodetree. > (These are all the other insns in 3-reg-same which were using > GEN_NEON_INTEGER_OP() and which are not pairwise or > reversed-operands.) > > Signed-off-by: Peter Maydell > --- >

Re: [PATCH v4 00/34] block: Introduce real BdrvChildRole

2020-05-13 Thread Kevin Wolf
Am 13.05.2020 um 13:05 hat Max Reitz geschrieben: > Based-on: <20200429141126.85159-1-mre...@redhat.com> > (“block: Do not call BlockDriver.bdrv_make_empty() directly”) I was just ready to apply the series, but alas, then I saw this notice... So for now, you'll have to make do with:

Re: [PATCH v2 05/17] target/arm: Convert Neon VABA/VABD 3-reg-same to decodetree

2020-05-13 Thread Richard Henderson
On 5/12/20 9:38 AM, Peter Maydell wrote: > Convert the Neon VABA and VABD insns in the 3-reg-same group to > decodetree. > > Signed-off-by: Peter Maydell > --- > target/arm/neon-dp.decode | 6 ++ > target/arm/translate-neon.inc.c | 4 > target/arm/translate.c | 22

[RISU 9/9] Add --dump option to inspect trace files

2020-05-13 Thread Richard Henderson
Adjust some of the aarch64 code to look at the reginfo struct instead of looking at test_sve, so that we do not need to pass the --test-sve option in order to dump sve trace files. Signed-off-by: Richard Henderson --- risu.h | 1 + risu.c | 111

Re: [RFC] migration: Add migrate-set-bitmap-node-mapping

2020-05-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200513144941.1469447-1-mre...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH v4 11/34] block: Use bdrv_inherited_options()

2020-05-13 Thread Eric Blake
On 5/13/20 6:05 AM, Max Reitz wrote: Let child_file's, child_format's, and child_backing's .inherit_options() implementations fall back to bdrv_inherited_options() to show that it would really work for all of these cases, if only the parents passed the appropriate BdrvChildRole and

[PATCH v4 16/16] target/arm: Vectorize SABA/UABA

2020-05-13 Thread Richard Henderson
Include 64-bit element size in preparation for SVE2. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper.h| 17 +++-- target/arm/translate.h | 5 ++ target/arm/neon_helper.c | 10 --- target/arm/translate-a64.c | 17 ++--- target/arm/translate.c

[PATCH v4 04/16] target/arm: Remove unnecessary range check for VSHL

2020-05-13 Thread Richard Henderson
In 1dc8425e551, while converting to gvec, I added an extra range check against the shift count. This was unnecessary because the encoding of the shift count produces 0 to the element size - 1. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate.c | 12

[PATCH v4 09/16] target/arm: Create gen_gvec_{cmtst,ushl,sshl}

2020-05-13 Thread Richard Henderson
Provide a functional interface for the vector expansion. This fits better with the existing set of helpers that we provide for other operations. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate.h | 10 ++- target/arm/translate-a64.c | 18 ++--

[PATCH v1 8/8] plugins: new lockstep plugin for debugging TCG changes

2020-05-13 Thread Alex Bennée
When we make changes to the TCG we sometimes cause regressions that are deep into the execution cycle of the guest. Debugging this often requires comparing large volumes of trace information to figure out where behaviour has diverged. The lockstep plugin utilises a shared socket so two QEMU's

[PATCH v1 6/8] linux-user: properly "unrealize" vCPU object

2020-05-13 Thread Alex Bennée
We shouldn't be messing around with the CPU list in linux-user save for the very special case of do_fork(). When threads end we need to properly follow QOM object lifetime handling and allow the eventual cpu_common_unrealizefn to both remove the CPU and ensure any clean-up actions are taken place,

[PATCH v1 06/10] accel/tcg: Relax va restrictions on 64-bit guests

2020-05-13 Thread Alex Bennée
From: Richard Henderson We cannot at present limit a 64-bit guest to a virtual address space smaller than the host. It will mostly work to ignore this limitation, except if the guest uses high bits of the address space for tags. But it will certainly work better, as presently we can wind up

Re: [PATCH v4 13/34] block: Unify bdrv_child_cb_detach()

2020-05-13 Thread Eric Blake
On 5/13/20 6:05 AM, Max Reitz wrote: Make bdrv_child_cb_detach() call bdrv_backing_detach() for children with a COW role (and drop the reverse call from bdrv_backing_detach()), so it can be used for any child (with a proper role set). Because so far no child has a proper role set, we need a

Re: [PATCH] scripts/tracetool: Update maintainer email address

2020-05-13 Thread John Snow
On 5/11/20 4:28 AM, Philippe Mathieu-Daudé wrote: > There is an effort in progress to generate a QEMU Python > package. As I'm not sure this old email is still valid, > update it to not produce package with broken maintainer > email. > > Patch created mechanically by running: > > $ sed -i

Re: [PATCH v2 03/17] target/arm: Convert Neon 64-bit element 3-reg-same insns

2020-05-13 Thread Richard Henderson
On 5/12/20 9:38 AM, Peter Maydell wrote: > Convert the 64-bit element insns in the 3-reg-same group > to decodetree. This covers VQSHL, VRSHL and VQRSHL where > size==0b11. > > Signed-off-by: Peter Maydell > --- > target/arm/neon-dp.decode | 21 ++ >

Re: [PATCH v2 13/17] target/arm: Convert Neon fp VMUL, VMLA, VMLS 3-reg-same insns to decodetree

2020-05-13 Thread Richard Henderson
On 5/12/20 9:39 AM, Peter Maydell wrote: > Convert the Neon integer VMUL, VMLA, and VMLS 3-reg-same inssn to > decodetree. > > We don't have a gvec helper for multiply-accumulate, so VMLA and VMLS > need a loop function do_3same_fp(). This takes a reads_vd parameter > to do_3same_fp() which

Re: [PATCH v4 18/34] block: Relax *perms_for_storage for data children

2020-05-13 Thread Eric Blake
On 5/13/20 6:05 AM, Max Reitz wrote: We can be less restrictive about pure data children than those with metadata on them, so let bdrv_default_perms_for_storage() handle metadata children differently from pure data children. As explained in the code, the restrictions on metadata children are

Re: [PATCH v4 19/34] block: Add bdrv_default_perms()

2020-05-13 Thread Eric Blake
On 5/13/20 6:05 AM, Max Reitz wrote: This callback can be used by BDSs that use child_of_bds with the appropriate BdrvChildRole for their children. Also, make bdrv_format_default_perms() use it for child_of_bds children (just a temporary solution until we can drop bdrv_format_default_perms()

[PATCH Kernel v19 8/8] vfio: Selective dirty page tracking if IOMMU backed device pins pages

2020-05-13 Thread Kirti Wankhede
Added a check such that only singleton IOMMU groups can pin pages. >From the point when vendor driver pins any pages, consider IOMMU group dirty page scope to be limited to pinned pages. To optimize to avoid walking list often, added flag pinned_page_dirty_scope to indicate if all of the

[PATCH v4 07/16] target/arm: Create gen_gvec_{mla,mls}

2020-05-13 Thread Richard Henderson
Provide a functional interface for the vector expansion. This fits better with the existing set of helpers that we provide for other operations. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate.h | 7 +- target/arm/translate-a64.c | 4 +-

Re: [PATCH v3 0/4] Additional parameters for qemu_img map

2020-05-13 Thread Eric Blake
On 5/13/20 8:36 AM, Eyal Moscovici wrote: Hi, The following series adds two parameters to qemu-img map: 1. start-offset: mapping starting offset. 2. max-length: the length of the mapping. These parameters proved useful when mapping large disk spread across long store file chains. It allows us

[RISU 0/9] risu cleanups and improvements

2020-05-13 Thread Richard Henderson
This patch set does alter the format of the trace files, and thus means we'll have to re-generate these. However, the space saved for sve trace files is significant, so I consider it worthwhile. In addition, the new --dump option allows one to inspect the contents of the trace file. r~

  1   2   3   4   5   >