Re: [PATCH v2 06/11] ui/sdl2: fix handling of AltGr key on Windows

On Sat, May 16, 2020 at 09:20:09AM +0200, Volker Rümelin wrote: > Wire up the keyboard hooking code on Windows to fix the AltGr > key and improve keyboard grabbing. Ah, I see, you've kept any gtk dependency out of win32-kbd-hook for sharing with sdl. Hmm. I guess there is no easy way around

Re: [PATCH v3] block: make BlockConf.*_size properties 32-bit

On Wed, Apr 29, 2020 at 12:18:13PM +0300, Roman Kagan wrote: > Devices (virtio-blk, scsi, etc.) and the block layer are happy to use > 32-bit for logical_block_size, physical_block_size, and min_io_size. > However, the properties in BlockConf are defined as uint16_t limiting > the values to 32768.

Re: [PATCH 15/24] macio: Fix macio-bus to be a subtype of System bus

Mark Cave-Ayland writes: > On 18/05/2020 06:03, Markus Armbruster wrote: > >> The devices we plug into the macio-bus are all sysbus devices >> (DeviceClass member bus_type is TYPE_SYSTEM_BUS), but macio-bus does >> not derive from TYPE_SYSTEM_BUS. Fix that. >> >> "info qtree" now shows the

Re: [PATCH 13/24] ppc4xx: Drop redundant device realization

BALATON Zoltan writes: > On Mon, 18 May 2020, Markus Armbruster wrote: >> object_property_set_bool(OBJECT(dev), true, "realized", ...) right >> after qdev_init_nofail(dev) does nothing, because qdev_init_nofail() >> already realizes. Drop. >> >> Cc: BALATON Zoltan > > Shouldn't this Cc line

Re: [PATCH 18/24] display/sm501 display/ati: Fix to realize "i2c-ddc"

BALATON Zoltan writes: > On Mon, 18 May 2020, Markus Armbruster wrote: >> sm501_init() and ati_vga_realize() create an "i2c-ddc" device, but >> neglect to realize it. Affects machines sam460ex, shix, r2d, and >> fulong2e. >> >> I wonder how this ever worked. If the "device becomes real only on

Re: [PATCH 17/24] pnv/psi: Correct the pnv-psi* devices not to be sysbus devices

Cédric Le Goater writes: > On 5/18/20 7:04 AM, Markus Armbruster wrote: >> pnv_chip_power8_instance_init() creates a "pnv-psi-POWER8" sysbus >> device in a way that leaves it unplugged. >> pnv_chip_power9_instance_init() and pnv_chip_power10_instance_init() >> do the same for "pnv-psi-POWER9"

Re: [PATCH 10/24] macio: Bury unwanted "macio-gpio" devices

Mark Cave-Ayland writes: > On 18/05/2020 06:03, Markus Armbruster wrote: > >> These devices go with the "via-pmu" device, which is controlled by >> property "has-pmu". macio_newworld_init() creates it unconditionally, >> because the property has not been set then. macio_newworld_realize() >>

Re: [PATCH 16/24] ppc/pnv: Put "*-pnv-chip" and "pnv-xive" on the main system bus

Cédric Le Goater writes: > On 5/18/20 7:04 AM, Markus Armbruster wrote: >> pnv_init() creates "power10_v1.0-pnv-chip", "power8_v2.0-pnv-chip", >> "power8e_v2.1-pnv-chip", "power8nvl_v1.0-pnv-chip", or >> "power9_v2.0-pnv-chip" sysbus devices in a way that leaves them >> unplugged. >> >>

Re: [PATCH 18/24] display/sm501 display/ati: Fix to realize "i2c-ddc"

Philippe Mathieu-Daudé writes: > On 5/18/20 12:39 PM, BALATON Zoltan wrote: >> On Mon, 18 May 2020, Markus Armbruster wrote: >>> sm501_init() and ati_vga_realize() create an "i2c-ddc" device, but >>> neglect to realize it.  Affects machines sam460ex, shix, r2d, and >>> fulong2e. >>> >>> I wonder

Re: [PATCH not-for-merge 2/5] qom: Make "info qom-tree" show children sorted

Eric Blake writes: > On 5/18/20 12:19 AM, Markus Armbruster wrote: >> "info qom-tree" prints children in unstable order. This is a pain >> when diffing output for different versions to find change. Print it >> sorted. > > Yes, this does seem reasonable to include even without the rest of the >

Re: [PATCH v2 02/11] ui/gtk: fix handling of AltGr key on Windows

> +static void *gd_win32_get_hwnd(VirtualConsole *vc) > +{ > +#ifdef G_OS_WIN32 > +return gdk_win32_window_get_impl_hwnd( > +gtk_widget_get_window(vc->window ? vc->window : vc->s->window)); Can we move the gdk_win32_window_get_impl_hwnd() call to win32_kbd_set_window()? That should

Re: [PATCH Kernel v22 5/8] vfio iommu: Implementation of ioctl for dirty pages tracking

On 5/19/2020 3:23 AM, Alex Williamson wrote: On Mon, 18 May 2020 11:26:34 +0530 Kirti Wankhede wrote: VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: - Start dirty pages tracking while migration is active - Stop dirty pages tracking. - Get dirty pages bitmap. Its user space

[PATCH Kernel v22 5/8] vfio iommu: Implementation of ioctl for dirty pages tracking

VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: - Start dirty pages tracking while migration is active - Stop dirty pages tracking. - Get dirty pages bitmap. Its user space application's responsibility to copy content of dirty pages from source to destination during migration. To

Re: [PATCH not-for-merge 0/5] Instrumentation for "Fixes around device realization"

Mark Cave-Ayland writes: > On 18/05/2020 06:19, Markus Armbruster wrote: > >> This is the instrumentation mentioned in "[PATCH 00/24] Fixes around >> device realization". >> >> PATCH 2/5 might have value on its own. You tell me. >> >> Shell script to smoke-test all machines: >> >> #!/bin/sh

[PATCH Kernel v22 6/8] vfio iommu: Update UNMAP_DMA ioctl to get dirty bitmap before unmap

DMA mapped pages, including those pinned by mdev vendor drivers, might get unpinned and unmapped while migration is active and device is still running. For example, in pre-copy phase while guest driver could access those pages, host device or vendor driver can dirty these mapped pages. Such pages

[PATCH Kernel v22 8/8] vfio: Selective dirty page tracking if IOMMU backed device pins pages

Added a check such that only singleton IOMMU groups can pin pages. >From the point when vendor driver pins any pages, consider IOMMU group dirty page scope to be limited to pinned pages. To optimize to avoid walking list often, added flag pinned_page_dirty_scope to indicate if all of the

[PULL 4/8] tests/fuzz: Remove unuseful/unused typedefs

From: Philippe Mathieu-Daudé These typedefs are not used. Use a simple structure, remote the typedefs. Signed-off-by: Philippe Mathieu-Daudé Message-id: 20200514143433.18569-5-phi...@redhat.com Signed-off-by: Stefan Hajnoczi --- tests/qtest/fuzz/i440fx_fuzz.c | 10 -- 1 file changed,

[PULL 6/8] tests/fuzz: Extract ioport_fuzz_qtest() method

From: Philippe Mathieu-Daudé Extract generic ioport_fuzz_qtest() method from i440fx_fuzz_qtest(). This will help to write tests not specific to the i440FX controller. Signed-off-by: Philippe Mathieu-Daudé Message-id: 20200514143433.18569-7-phi...@redhat.com Signed-off-by: Stefan Hajnoczi ---

Re: [PATCH] linux-user/mmap.c: fix integer underflow in target_mremap

Hi Jonathan, thanks for the patch! CCing Riku and Laurent. On Mon, May 18, 2020 at 12:13:41PM -0600, Jonathan Marler wrote: > Been a few more days. Not sure how often I should be pinging. If this is > too much to ping every few days let me know. Is not too much, but next time is better to CC

Re: [PATCH 02/10] softfloat: Replace flag with bool

Richard Henderson writes: > We have had this on the to-do list for quite some time. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v2 5/5] vhost: add device started check in migration set log

On Mon, May 18, 2020 at 10:53:59AM +0100, Dr. David Alan Gilbert wrote: > * Dima Stepanov (dimas...@yandex-team.ru) wrote: > > On Mon, May 18, 2020 at 10:50:39AM +0800, Jason Wang wrote: > > > > > > On 2020/5/16 上午12:54, Dima Stepanov wrote: > > > >On Thu, May 14, 2020 at 03:34:24PM +0800, Jason

[PATCH] arm/aspeed: Compute the number of CPUs from the SoC definition

Commit ece09beec457 ("aspeed: introduce a configurable number of CPU per machine") was a convient change during bringup but the Aspeed SoCs have a fixed number of CPUs : one for the AST2400 and AST2500, and two for the AST2600. Remove the "num-cpu" property from the SoC state and use the fixed

Re: [PATCH 06/10] softfloat: Inline float32 compare specializations

Richard Henderson writes: > Replace the float32 compare specializations with inline functions > that call the standard float32_compare{,_quiet} functions. > Use bool as the return type. > > Signed-off-by: Richard Henderson > --- > include/fpu/softfloat.h | 49 +++-- > fpu/softfloat.c

[PULL 0/8] Block patches

The following changes since commit 013a18edbbc59cdad019100c7d03c0494642b74c: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-2020051= 4' into staging (2020-05-14 16:17:55 +0100) are available in the Git repository at: https://github.com/stefanha/qemu.git

[PULL 5/8] tests/fuzz: Extract pciconfig_fuzz_qos() method

From: Philippe Mathieu-Daudé Extract the generic pciconfig_fuzz_qos() method from i440fx_fuzz_qos(). This will help to write tests not specific to the i440FX controller. Signed-off-by: Philippe Mathieu-Daudé Message-id: 20200514143433.18569-6-phi...@redhat.com Signed-off-by: Stefan Hajnoczi

Re: [PATCH RFC v2 1/5] block: add bitmap-populate job

On Mon, May 18, 2020 at 15:49:02 -0500, Eric Blake wrote: > On 5/13/20 10:49 PM, John Snow wrote: [...] > > + > > +/* NB: new bitmap is anonymous and enabled */ > > +cluster_size = bdrv_dirty_bitmap_granularity(target_bitmap); > > +new_bitmap = bdrv_create_dirty_bitmap(bs,

Re: [PATCH 01/10] softfloat: Use post test for floatN_mul

Richard Henderson writes: > The existing f{32,64}_addsub_post test, which checks for zero > inputs, is identical to f{32,64}_mul_fast_test. Which means > we can eliminate the fast_test/fast_op hooks in favor of > reusing the same post hook. > > This means we have one fewer test along the fast

Re: [PATCH 03/10] softfloat: Change tininess_before_rounding to bool

Richard Henderson writes: > Slightly tidies the usage within softfloat.c and the > representation in float_status. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v4 9/9] iotests: rename and move 169 and 199 tests

Am 18.05.2020 um 18:12 hat Thomas Huth geschrieben: > On 15/05/2020 23.15, Vladimir Sementsov-Ogievskiy wrote: > > Rename bitmaps migration tests and move them to tests subdirectory to > > demonstrate new human-friendly test naming. > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy > > --- > >

Re: [PATCH 04/10] softfloat: Name rounding mode enum

Richard Henderson writes: > Give the previously unnamed enum a typedef name. Use the packed > attribute so that we do not affect the layout of the float_status > struct. Use it in the prototypes of relevant functions. > > Adjust switch statements as necessary to avoid compiler warnings. > >

Re: [PATCH 05/10] softfloat: Name compare relation enum

Richard Henderson writes: > Give the previously unnamed enum a typedef name. Use it in the > prototypes of compare functions. Use it to hold the results > of the compare functions. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: Migration with ``drive-mirror`` + NBD will let quorum qcow2 image become larger

Am 19.05.2020 um 10:32 hat Tao Xu geschrieben: > Hi, > > I am using ``drive-mirror`` + NBD for live storage migration. But I find > that if I use a qcow2 image(virtual size: 10 GiB, disk size: 1.8 GiB) as a > child of quorum, then the destination image become larger(virtual size: 10 > GiB, disk

Re: sharing intention for developing per-target, dynamically loadable accelerator modules

On 5/18/20 8:18 PM, Alex Bennée wrote: > > Claudio Fontana writes: > >> Hello all, >> >> my intention would be to develop per-target, dynamically loadable >> accelerator modules. >> >> This would allow to distribute a single QEMU base binary, and then provide >> accelerators as optional

Re: [PATCH v2 4/7] hw/elf_ops: Do not ignore write failures when loading ELF

On Mon, May 18, 2020 at 05:53:05PM +0200, Philippe Mathieu-Daudé wrote: > Do not ignore the MemTxResult error type returned by > address_space_write(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/elf_ops.h | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-)

[PULL 8/8] aio-posix: disable fdmon-io_uring when GSource is used

The glib event loop does not call fdmon_io_uring_wait() so fd handlers waiting to be submitted build up in the list. There is no benefit is using io_uring when the glib GSource is being used, so disable it instead of implementing a more complex fix. This fixes a memory leak where AioHandlers

[PULL 7/8] aio-posix: don't duplicate fd handler deletion in fdmon_io_uring_destroy()

The io_uring file descriptor monitoring implementation has an internal list of fd handlers that are pending submission to io_uring. fdmon_io_uring_destroy() deletes all fd handlers on the list. Don't delete fd handlers directly in fdmon_io_uring_destroy() for two reasons: 1. This duplicates the

Re: [PATCH] replay: synchronize on every virtual timer callback

Pavel Dovgalyuk writes: > On 18.05.2020 18:56, Alex Bennée wrote: >> Philippe Mathieu-Daudé writes: >> >>> + Alex >>> >>> On 5/6/20 10:17 AM, Pavel Dovgalyuk wrote: Sometimes virtual timer callbacks depend on order of virtual timer processing and warping of virtual clock.

Re: [PATCH 11/24] pnv/phb4: Bury unwanted "pnv-phb4-pec-stack" devices

On 5/18/20 7:03 AM, Markus Armbruster wrote: > The number of stacks is controlled by property "num-stacks". > pnv_pec_instance_init() creates the maximum supported number, because > the property has not been set then. pnv_pec_realize() realizes only > the wanted number. Works, although it can

Migration with ``drive-mirror`` + NBD will let quorum qcow2 image become larger

Hi, I am using ``drive-mirror`` + NBD for live storage migration. But I find that if I use a qcow2 image(virtual size: 10 GiB, disk size: 1.8 GiB) as a child of quorum, then the destination image become larger(virtual size: 10 GiB, disk size: 10 GiB). However if I use a qcow2 image directly,

Re: [PATCH] hw/ide: Make IDEDMAOps handlers take a const IDEDMA pointer

Am 18.05.2020 um 20:26 hat John Snow geschrieben: > > > On 5/15/20 4:48 AM, Kevin Wolf wrote: > > Am 14.05.2020 um 22:21 hat John Snow geschrieben: > >> > >> > >> On 5/12/20 3:49 PM, Philippe Mathieu-Daudé wrote: > >>> Handlers don't need to modify the IDEDMA structure. > >>> Make it const. >

Re: [PATCH v5 1/4] hw/net/can: Introduce Xilinx ZynqMP CAN controller

On Sun, May 17, 2020 at 12:24:01AM -0700, Vikram Garhwal wrote: > The Xilinx ZynqMP CAN controller is developed based on SocketCAN, QEMU CAN bus > implementation. Bus connection and socketCAN connection for each CAN module > can be set through command lines. Hi Vikram, Have a look at

[PATCH] ARM: PL061: Introduce N_GPIOS

Add a definition for the number of GPIO lines controlled by a PL061 instance, and use it instead of the hardcoded magic value 8. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Geert Uytterhoeven --- hw/gpio/pl061.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff

Re: QEMU 5.1: Can we require each new device/machine to provided a test?

On Mon, May 18, 2020 at 03:56:36PM -0400, John Snow wrote: > > > On 5/15/20 6:23 AM, Daniel P. Berrangé wrote: > > On Fri, May 15, 2020 at 12:11:17PM +0200, Thomas Huth wrote: > >> On 07/04/2020 12.59, Philippe Mathieu-Daudé wrote: > >>> Hello, > >>> > >>> Following Markus thread on deprecating

Re: [PATCH 2/9] ppc/xive: Export xive_presenter_notify()

On Wed, 13 May 2020 17:11:02 +0200 Cédric Le Goater wrote: > It's generic enough to be used from the XIVE2 router and avoid more > duplication. > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > include/hw/ppc/xive.h | 4 > hw/intc/xive.c| 8 > 2 files

Re: [PATCH 05/24] aspeed: Don't create unwanted "cortex-a7-arm-cpu" devices

On 5/19/20 7:46 AM, Markus Armbruster wrote: > Joel Stanley writes: > >> On Mon, 18 May 2020 at 12:24, Cédric Le Goater wrote: >>> >>> On 5/18/20 7:03 AM, Markus Armbruster wrote: The number of CPUs is controlled by property "num-cpus". aspeed_soc_ast2600_init() creates the maximum

[PULL 2/8] Makefile: List fuzz targets in 'make help'

From: Philippe Mathieu-Daudé List softmmu fuzz targets in 'make help' output: $ make help ... Architecture specific targets: aarch64-softmmu/all- Build for aarch64-softmmu aarch64-softmmu/fuzz - Build fuzzer for aarch64-softmmu alpha-softmmu/all -

[PULL 1/8] tests/fuzz/Makefile: Do not link code using unavailable devices

From: Philippe Mathieu-Daudé Some devices availability depends on CONFIG options. Use these options to only link tests when requested device is available. Signed-off-by: Philippe Mathieu-Daudé Message-id: 20200514143433.18569-2-phi...@redhat.com Signed-off-by: Stefan Hajnoczi ---

[PULL 3/8] tests/fuzz: Add missing space in test description

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-id: 20200514143433.18569-4-phi...@redhat.com Signed-off-by: Stefan Hajnoczi --- tests/qtest/fuzz/i440fx_fuzz.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/qtest/fuzz/i440fx_fuzz.c

Re: [virtio-dev] Re: Fwd: Qemu Support for Virtio Video V4L2 driver

Hi Nicolas, On Fri, May 15, 2020 at 8:38 AM Nicolas Dufresne wrote: > > Le lundi 11 mai 2020 à 20:49 +0900, Keiichi Watanabe a écrit : > > Hi, > > > > Thanks Saket for your feedback. As Dmitry mentioned, we're focusing on > > video encoding and decoding, not camera. So, my reply was about how to

[PATCH] hw/arm/virt: Fix PL061 node name and properties

Make the created node comply with the PL061 Device Tree bindings: - Use generic node name "gpio" instead of "pl061", - Add missing "#interrupt-cells" and "interrupt-controller" properties. Signed-off-by: Geert Uytterhoeven --- Split off from "[PATCH QEMU v2 2/5] ARM: PL061: Extract

Re: [PATCH v2 5/5] vhost: add device started check in migration set log

On Wed, May 13, 2020 at 01:56:18PM +0800, Jason Wang wrote: > > On 2020/5/13 下午12:15, Michael S. Tsirkin wrote: > >On Tue, May 12, 2020 at 12:35:30PM +0300, Dima Stepanov wrote: > >>On Tue, May 12, 2020 at 11:32:50AM +0800, Jason Wang wrote: > >>>On 2020/5/11 下午5:25, Dima Stepanov wrote: > On

Re: [PATCH 07/10] softfloat: Inline float64 compare specializations

Richard Henderson writes: > Replace the float64 compare specializations with inline functions > that call the standard float64_compare{,_quiet} functions. > Use bool as the return type. > > Signed-off-by: Richard Henderson > --- > include/fpu/softfloat.h | 49 ++-- >

Re: [PATCH 0/9] ppc/pnv: Introduce the XIVE2 and PHB5 controllers for the POWER10 chip

On Wed, 13 May 2020 17:11:00 +0200 Cédric Le Goater wrote: > Hello, > > This series completes the PowerNV POWER10 machine with the XIVE2 > interrupt controller and the PHB5 PCI host bridge controller. > > The XIVE2 interrupt controller of the POWER10 processor follows the > same logic than on

Re: [PATCH v2 5/9] block/io: expand in_flight inc/dec section: simple cases

Am 06.05.2020 um 09:02 hat Vladimir Sementsov-Ogievskiy geschrieben: > 27.04.2020 17:39, Vladimir Sementsov-Ogievskiy wrote: > > It's safer to expand in_flight request to start before enter to > > coroutine in synchronous wrappers, due to the following (theoretical) > > problem: > > > > Consider

Re: [PATCH v3 4/7] migration/block-dirty-bitmap: fix bitmaps pre-blockdev migration during mirror job

18.05.2020 23:36, Eric Blake wrote: On 5/15/20 7:40 AM, Vladimir Sementsov-Ogievskiy wrote: Important thing for bitmap migration is to select destination block node to obtain the migrated bitmap. Prepatch, on source we use bdrv_get_device_or_node_name() to identify the node, and on target we

Re: [PATCH v2 6/9] block/io: expand in_flight inc/dec section: block-status

Am 02.05.2020 um 00:00 hat Eric Blake geschrieben: > On 4/27/20 9:39 AM, Vladimir Sementsov-Ogievskiy wrote: > > It's safer to expand in_flight request to start before enter to > > coroutine in synchronous wrappers and end after BDRV_POLL_WHILE loop. > > Note that qemu_coroutine_enter may only

Re: [PATCH v2 5/9] block/io: expand in_flight inc/dec section: simple cases

Am 27.04.2020 um 16:39 hat Vladimir Sementsov-Ogievskiy geschrieben: > It's safer to expand in_flight request to start before enter to > coroutine in synchronous wrappers, due to the following (theoretical) > problem: > > Consider write. > It's possible, that qemu_coroutine_enter only schedules

Re: [PATCH v2 0/9] block/io: safer inc/dec in_flight sections

27.04.2020 17:38, Vladimir Sementsov-Ogievskiy wrote: Hi all! This is inspired by Kevin's "block: Fix blk->in_flight during blk_wait_while_drained()" series. So, like it's now done for block-backends, let's expand in_flight-protected sections for bdrv_ interfaces, including coroutine_enter and

Re: [PATCH] xen: fix build without pci passthrough

On Mon, May 11, 2020 at 02:40:43PM +0100, Anthony PERARD wrote: > On Mon, May 04, 2020 at 12:14:43PM +0200, Roger Pau Monne wrote: > > diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h > > index 179775db7b..660dd8a008 100644 > > --- a/hw/xen/xen_pt.h > > +++ b/hw/xen/xen_pt.h > > @@ -1,6 +1,7 @@ > >

Re: [RFC PATCH 0/8] RISCV risu porting

On 2020/5/12 0:30, Richard Henderson wrote: On 4/30/20 12:21 AM, LIU Zhiwei wrote: It's some difficult when I try to support RV32, because it's very similiar to RV64, so I can't make two .risu files like arm.risu and aarch64.risu. You could a command-line parameter, like --be or --sve for

[Bug 1856335] Re: Cache Layout wrong on many Zen Arch CPUs

adds "host-cache-info=on,l3-cache=off" to the qemu -cpu args I believe l3-cache=off is useless with host-cache-info=on So should do what you want. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH v2 5/5] vhost: add device started check in migration set log

On Fri, May 15, 2020 at 07:54:57PM +0300, Dima Stepanov wrote: > On Thu, May 14, 2020 at 03:34:24PM +0800, Jason Wang wrote: > > > > On 2020/5/13 下午5:47, Dima Stepanov wrote: > > >>> case CHR_EVENT_CLOSED: > > >>> /* a close event may happen during a read/write, but vhost > > >>>

Re: [PATCH 10/10] softfloat: Return bool from all classification predicates

Richard Henderson writes: > This includes *_is_any_nan, *_is_neg, *_is_inf, etc. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée As an aside do you think we'll see any benefit from rolling up the classifications with the decomposed versions? I would hope the compiler could

Re: [PATCH] replay: synchronize on every virtual timer callback

On 19.05.2020 11:11, Alex Bennée wrote: Pavel Dovgalyuk writes: On 18.05.2020 18:56, Alex Bennée wrote: Philippe Mathieu-Daudé writes: + Alex On 5/6/20 10:17 AM, Pavel Dovgalyuk wrote: Sometimes virtual timer callbacks depend on order of virtual timer processing and warping of virtual

Re: [PATCH v2 5/9] block/io: expand in_flight inc/dec section: simple cases

19.05.2020 13:52, Kevin Wolf wrote: Am 06.05.2020 um 09:02 hat Vladimir Sementsov-Ogievskiy geschrieben: 27.04.2020 17:39, Vladimir Sementsov-Ogievskiy wrote: It's safer to expand in_flight request to start before enter to coroutine in synchronous wrappers, due to the following (theoretical)

Re: [PATCH v2 5/9] block/io: expand in_flight inc/dec section: simple cases

Am 19.05.2020 um 13:06 hat Vladimir Sementsov-Ogievskiy geschrieben: > 19.05.2020 13:52, Kevin Wolf wrote: > > Am 06.05.2020 um 09:02 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 27.04.2020 17:39, Vladimir Sementsov-Ogievskiy wrote: > > > > It's safer to expand in_flight request to start

Re: [PATCH 08/10] softfloat: Inline float128 compare specializations

Richard Henderson writes: > Replace the float128 compare specializations with inline functions > that call the standard float128_compare{,_quiet} functions. > Use bool as the return type. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > include/fpu/softfloat.h | 49

Re: [PATCH 09/10] softfloat: Inline floatx80 compare specializations

Richard Henderson writes: > Replace the floatx80 compare specializations with inline functions > that call the standard floatx80_compare{,_quiet} functions. > Use bool as the return type. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > include/fpu/softfloat.h | 49

Re: [PATCH 5/9] ppc/pnv: Add a XIVE2 controller to the POWER10 chip.

On Wed, 13 May 2020 17:11:05 +0200 Cédric Le Goater wrote: > The XIVE2 interrupt controller of the POWER10 processor follows the > same logic than on POWER9 but the HW interface has been largely > reviewed. It has a new register interface, different BARs, extra > VSDs, new layout for the XIVE2

Re: [PATCH 02/24] display/xlnx_dp: Fix to realize "i2c-ddc" and "aux-to-i2c-bridge"

On Tue, 19 May 2020 at 06:09, Markus Armbruster wrote: > I figure the "device becomes real only on realize" thing is actually > more myth than thing. It's not a myth, it's an API guarantee thing. If you don't realize the device you create before you use it then you're in the world of unspecified

Re: [PATCH v2 5/5] vhost: add device started check in migration set log

* Dima Stepanov (dimas...@yandex-team.ru) wrote: > On Mon, May 18, 2020 at 10:53:59AM +0100, Dr. David Alan Gilbert wrote: > > * Dima Stepanov (dimas...@yandex-team.ru) wrote: > > > On Mon, May 18, 2020 at 10:50:39AM +0800, Jason Wang wrote: > > > > > > > > On 2020/5/16 上午12:54, Dima Stepanov

Re: [PATCH] replay: synchronize on every virtual timer callback

Pavel Dovgalyuk writes: > On 19.05.2020 11:11, Alex Bennée wrote: >> Pavel Dovgalyuk writes: >> >>> On 18.05.2020 18:56, Alex Bennée wrote: Philippe Mathieu-Daudé writes: > + Alex > > On 5/6/20 10:17 AM, Pavel Dovgalyuk wrote: >> Sometimes virtual timer callbacks

Re: [PATCH] replay: synchronize on every virtual timer callback

On 19.05.2020 13:32, Alex Bennée wrote: Pavel Dovgalyuk writes: On 19.05.2020 11:11, Alex Bennée wrote: Pavel Dovgalyuk writes: On 18.05.2020 18:56, Alex Bennée wrote: Philippe Mathieu-Daudé writes: + Alex On 5/6/20 10:17 AM, Pavel Dovgalyuk wrote: Sometimes virtual timer

[PATCH] icount: fix shift=auto for record/replay

This patch fixes shift=auto when record/replay is enabled. Now user does not need to guess the best shift value. Signed-off-by: Pavel Dovgalyuk -- v2: moved icount_time_shift to vmstate subsection --- cpus.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff

Re: [PATCH RFC 01/32] python/qemu: create qemu.lib module

19.05.2020 03:27, John Snow wrote: On 5/18/20 3:33 PM, Vladimir Sementsov-Ogievskiy wrote: 18.05.2020 21:23, John Snow wrote: On 5/18/20 2:14 PM, Vladimir Sementsov-Ogievskiy wrote: 14.05.2020 08:53, John Snow wrote: move python/qemu/*.py to python/qemu/lib/*.py. To create a namespace

Re: [PULL 0/6] NBD patches for 2020-05-18

On Mon, 18 May 2020 at 17:38, Eric Blake wrote: > > The following changes since commit debe78ce14bf8f8940c2bdf3ef387505e9e035a9: > > Merge remote-tracking branch 'remotes/rth/tags/pull-fpu-20200515' into > staging (2020-05-15 19:51:16 +0100) > > are available in the Git repository at: > >

Re: [PATCH v2 5/9] block/io: expand in_flight inc/dec section: simple cases

19.05.2020 14:16, Kevin Wolf wrote: Am 19.05.2020 um 13:06 hat Vladimir Sementsov-Ogievskiy geschrieben: 19.05.2020 13:52, Kevin Wolf wrote: Am 06.05.2020 um 09:02 hat Vladimir Sementsov-Ogievskiy geschrieben: 27.04.2020 17:39, Vladimir Sementsov-Ogievskiy wrote: It's safer to expand

Re: [PATCH v4 9/9] iotests: rename and move 169 and 199 tests

Am 19.05.2020 um 13:32 hat Vladimir Sementsov-Ogievskiy geschrieben: > 19.05.2020 12:07, Kevin Wolf wrote: > > Am 18.05.2020 um 18:12 hat Thomas Huth geschrieben: > > > On 15/05/2020 23.15, Vladimir Sementsov-Ogievskiy wrote: > > > > Rename bitmaps migration tests and move them to tests

Re: [PATCH] ARM: PL061: Introduce N_GPIOS

On 5/19/20 10:51 AM, Geert Uytterhoeven wrote: Add a definition for the number of GPIO lines controlled by a PL061 instance, and use it instead of the hardcoded magic value 8. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Geert Uytterhoeven Thanks for following up. Reviewed-by:

Re: [PATCH] xen: fix build without pci passthrough

On Tue, 19 May 2020 at 12:28, Roger Pau Monné wrote: > > On Mon, May 11, 2020 at 02:40:43PM +0100, Anthony PERARD wrote: > > On Mon, May 04, 2020 at 12:14:43PM +0200, Roger Pau Monne wrote: > > > diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h > > > index 179775db7b..660dd8a008 100644 > > > ---

[PATCH v3 03/10] Add VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS

This change introduces a new feature to the vhost-user protocol allowing a backend device to specify the maximum number of ram slots it supports. At this point, the value returned by the backend will be capped at the maximum number of ram slots which can be supported by vhost-user, which is

[PATCH v3 04/10] Transmit vhost-user memory regions individually

With this change, when the VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS protocol feature has been negotiated, Qemu no longer sends the backend all the memory regions in a single message. Rather, when the memory tables are set or updated, a series of VHOST_USER_ADD_MEM_REG and VHOST_USER_REM_MEM_REG

[PATCH v3 02/10] Add vhost-user helper to get MemoryRegion data

When setting the memory tables, qemu uses a memory region's userspace address to look up the region's MemoryRegion struct. Among other things, the MemoryRegion contains the region's offset and associated file descriptor, all of which need to be sent to the backend. With

[PATCH v3 06/10] Refactor out libvhost-user fault generation logic

In libvhost-user, the incoming postcopy migration path for setting the backend's memory tables has become convolued. In particular, moving the logic which starts generating faults, having received the final ACK from qemu can be moved to a separate function. This simplifies the code substantially.

[PATCH v3 08/10] Support adding individual regions in libvhost-user

When the VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS is enabled, qemu will transmit memory regions to a backend individually using the new message VHOST_USER_ADD_MEM_REG. With this change vhost-user backends built with libvhost-user can now map in new memory regions when VHOST_USER_ADD_MEM_REG

Re: [RFC PATCH 0/3] block: Synchronous bdrv_*() from coroutine in different AioContext

14.05.2020 17:26, Kevin Wolf wrote: Am 14.05.2020 um 15:21 hat Thomas Lamprecht geschrieben: On 5/12/20 4:43 PM, Kevin Wolf wrote: Stefan (Reiter), after looking a bit closer at this, I think there is no bug in QEMU, but the bug is in your coroutine code that calls block layer functions

Re: [PATCH v4 9/9] iotests: rename and move 169 and 199 tests

19.05.2020 12:07, Kevin Wolf wrote: Am 18.05.2020 um 18:12 hat Thomas Huth geschrieben: On 15/05/2020 23.15, Vladimir Sementsov-Ogievskiy wrote: Rename bitmaps migration tests and move them to tests subdirectory to demonstrate new human-friendly test naming. Signed-off-by: Vladimir

Re: [PATCH 04/24] aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" devices

On 5/19/20 7:45 AM, Markus Armbruster wrote: "Andrew Jeffery" writes: On Mon, 18 May 2020, at 21:49, Cédric Le Goater wrote: On 5/18/20 7:03 AM, Markus Armbruster wrote: These devices are optional, and controlled by @nb_nics. aspeed_soc_ast2600_init() and aspeed_soc_init() create the

Re: [PATCH 11/24] pnv/phb4: Bury unwanted "pnv-phb4-pec-stack" devices

Cédric Le Goater writes: > On 5/18/20 7:03 AM, Markus Armbruster wrote: >> The number of stacks is controlled by property "num-stacks". >> pnv_pec_instance_init() creates the maximum supported number, because >> the property has not been set then. pnv_pec_realize() realizes only >> the wanted

Re: [PATCH 02/24] display/xlnx_dp: Fix to realize "i2c-ddc" and "aux-to-i2c-bridge"

Peter Maydell writes: > On Tue, 19 May 2020 at 06:09, Markus Armbruster wrote: >> I figure the "device becomes real only on realize" thing is actually >> more myth than thing. > > It's not a myth, it's an API guarantee thing. If you don't realize > the device you create before you use it then

Re: [PULL v2 00/52] Block layer patches

On Mon, 18 May 2020 at 18:07, Kevin Wolf wrote: > > The following changes since commit debe78ce14bf8f8940c2bdf3ef387505e9e035a9: > > Merge remote-tracking branch 'remotes/rth/tags/pull-fpu-20200515' into > staging (2020-05-15 19:51:16 +0100) > > are available in the Git repository at: > >

Re: [PATCH] linux-user/mmap.c: fix integer underflow in target_mremap

Hi Jonathan. On 5/19/20 10:11 AM, Stefano Garzarella wrote: Hi Jonathan, thanks for the patch! CCing Riku and Laurent. On Mon, May 18, 2020 at 12:13:41PM -0600, Jonathan Marler wrote: Been a few more days. Not sure how often I should be pinging. If this is too much to ping every few days

Re: [PATCH] target/i386: Fix OUTL debug output

On 5/19/20 5:39 AM, Richard Henderson wrote: On 5/17/20 4:01 AM, Philippe Mathieu-Daudé wrote: Fix OUTL instructions incorrectly displayed as OUTW. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/misc_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by:

[PATCH v3 01/10] Add helper to populate vhost-user message regions

When setting vhost-user memory tables, memory region descriptors must be copied from the vhost_dev struct to the vhost-user message. To avoid duplicating code in setting the memory tables, we should use a helper to populate this field. This change adds this helper. Signed-off-by: Raphael Norwitz

[PATCH v3 00/10] vhost-user: Lift Max Ram Slots Limitation

In QEMU today, a VM with a vhost-user device can hot add memory a maximum of 8 times. See these threads, among others: [1] https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01046.html https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01236.html [2]

[PATCH v3 05/10] Lift max memory slots limit imposed by vhost-user

Historically, sending all memory regions to vhost-user backends in a single message imposed a limitation on the number of times memory could be hot-added to a VM with a vhost-user device. Now that backends which support the VHOST_USER_PROTOCOL_F_CONFIGURE_SLOTS send memory regions individually, we

[PATCH v3 07/10] Support ram slot configuration in libvhost-user

The VHOST_USER_GET_MAX_MEM_SLOTS message allows a vhost-user backend to specify a maximum number of ram slots it is willing to support. This change adds support for libvhost-user to process this message. For now the backend will reply with 8 as the maximum number of regions supported.

Re: [RFC PATCH 8/8] riscv: Add RV64F instructions description

On 2020/5/12 2:11, Richard Henderson wrote: On 4/30/20 12:21 AM, LIU Zhiwei wrote: +FCVT_L_S RISCV 110 00010 rs1:5 rm:3 rd:5 1010011 \ +!constraints { $rd != 2 && $rd != 3 && $rd != 4 && $rm != 6 && $rm != 5 } + +FCVT_LU_S RISCV 110 00011 rs1:5 rm:3 rd:5 1010011 \ +!constraints { $rd

[PATCH v3 10/10] Lift max ram slots limit in libvhost-user

Historically, VMs with vhost-user devices could hot-add memory a maximum of 8 times. Now that the VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS protocol feature has been added, VMs with vhost-user backends which support this new feature can support a configurable number of ram slots up to the maximum

[PATCH v3 09/10] Support individual region unmap in libvhost-user

When the VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS protocol feature is enabled, on memory hot-unplug qemu will transmit memory regions to remove individually using the new message VHOST_USER_REM_MEM_REG message. With this change, vhost-user backends build with libvhost-user can now unmap

  1   2   3   4   >