Re: [PATCH v3 0/9] pc-bios: s390x: Cleanup part 1

2020-05-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200527074920.43669-1-fran...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200527074920.43669-1-fran...@linux.ibm.com Subject: [PATCH v3 0/9] pc-bios: s390x: Cleanup part 1

[PATCH v2 02/11] tests/acceptance: refactor boot_linux_console test to allow code reuse

2020-05-27 Thread Pavel Dovgalyuk
This patch splits code in BootLinuxConsole class into two different classes to allow reusing it by record/replay tests. Signed-off-by: Pavel Dovgalyuk --- 0 files changed diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py index c6b06a1a13..f23c5833b7

[PATCH v2 00/11] Record/replay acceptance tests

2020-05-27 Thread Pavel Dovgalyuk
The following series adds record/replay tests to the acceptance group. Test pass successfully with the latest submitted record/replay fixes: - replay: notify the main loop when there are no instructions - replay: synchronize on every virtual timer callback The provided tests perform kernel boot

Re: [PATCH 3/4] configure: add flag to enable SafeStack

2020-05-27 Thread Stefan Hajnoczi
On Fri, May 22, 2020 at 11:24:46AM -0400, Daniele Buono wrote: > I would feel more confident by adding another check in configure to make > sure that the user didn't enable SafeStack manually through other means, > like manually setting the option through extra_cflags. > What do you think? Sure,

Re: [PATCH v6 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites

2020-05-27 Thread Philippe Mathieu-Daudé
Hi Daniel, On 5/19/20 8:20 PM, Philippe Mathieu-Daudé wrote: > Hi, > > This series has two parts: > > - First we add the ability to QOM objects to produce data > consumable by the fw_cfg device, > > - Then we add the tls-cipher-suites object, and let it > implement the

Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic

2020-05-27 Thread Stefan Hajnoczi
On Fri, May 08, 2020 at 08:24:52AM +0200, Philippe Mathieu-Daudé wrote: > Let the NVMe emulated device be target-agnostic. > > It is not clear if dccvap_writefn() really needs > memory_region_writeback() or could use memory_region_msync(). > > Philippe Mathieu-Daudé (4): > memory: Rename

Re: [PATCH v7 14/32] qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type()

2020-05-27 Thread Eric Blake
On 5/27/20 4:51 AM, Alberto Garcia wrote: On Tue 26 May 2020 10:32:08 PM CEST, Eric Blake wrote: +/* The subcluster X [0..31] is allocated */ +#define QCOW_OFLAG_SUB_ALLOC(X) (1ULL << (X)) +/* The subcluster X [0..31] reads as zeroes */ +#define QCOW_OFLAG_SUB_ZERO(X)

Re: [PATCH v2 03/11] tests/acceptance: add base class record/replay kernel tests

2020-05-27 Thread Philippe Mathieu-Daudé
On 5/27/20 12:30 PM, Pavel Dovgalyuk wrote: > This patch adds a base for testing kernel boot recording and replaying. > Each test has the phase of recording and phase of replaying. > Virtual machines just boot the kernel and do not interact with > the network. > Structure and image links for the

Re: [PATCH v2 4/7] device-core: use atomic_set on .realized property

2020-05-27 Thread Stefan Hajnoczi
On Mon, May 11, 2020 at 07:09:48PM +0300, Maxim Levitsky wrote: > Some code might race with placement of new devices on a bus. > We currently first place a (unrealized) device on the bus > and then realize it. > > As a workaround, users that scan the child device list, can > check the realized

[PULL 07/12] tests/tcg: better detect confused gdb which can't connect

2020-05-27 Thread Alex Bennée
While we may gamely give the right information it can still confuse the wide range of GDBs out there. For example ppc64abi32-linux-user reports: warning: Selected architecture powerpc:common is not compatible with reported target architecture powerpc:common64 warning: Architecture rejected

[PULL 05/12] tests/fp: enable extf80_le_quite tests

2020-05-27 Thread Alex Bennée
These have been fixed now so we no longer need a special version of the le_quiet rule to skip the test. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20200520140541.30256-6-alex.ben...@linaro.org> diff --git a/tests/Makefile.include b/tests/Makefile.include index

Re: [PATCH v6 2/5] softmmu/vl: Let -fw_cfg option take a 'blob_id' argument

2020-05-27 Thread Daniel P . Berrangé
On Tue, May 19, 2020 at 08:20:21PM +0200, Philippe Mathieu-Daudé wrote: > The 'blob_id' argument refers to a QOM object able to produce > data consumable by the fw_cfg device. The producer object must > implement the FW_CFG_DATA_GENERATOR interface. > > Signed-off-by: Philippe Mathieu-Daudé >

Re: [PATCH v2] iotests: Dump QCOW2 dirty bitmaps metadata

2020-05-27 Thread Vladimir Sementsov-Ogievskiy
26.05.2020 23:26, Andrey Shinkevich wrote: Add dirty bitmap information to QCOW2 metadata dump in qcow2.py script. The sample output: Header extension: Bitmaps magic 0x23852875 length24 nb_bitmaps2 reserved320

Re: [PATCH v3 14/22] microvm: use 2G split unconditionally

2020-05-27 Thread Igor Mammedov
On Wed, 27 May 2020 15:06:28 +0200 Paolo Bonzini wrote: > On 27/05/20 14:25, Igor Mammedov wrote: > >> (2) we loose a gigabyte page. > > I'm not sure waht exactly we loose in this case. > > Lets assume we allocating guest 5G of continuous RAM using 1G > > huge pages, > >

Re: [PATCH v2 05/11] tests/acceptance: add record/replay test for aarch64

2020-05-27 Thread Philippe Mathieu-Daudé
On 5/27/20 12:31 PM, Pavel Dovgalyuk wrote: > This patch adds a test for record/replay of the kernel > image boot for aarch64 platform. > > Signed-off-by: Pavel Dovgalyuk > --- > 0 files changed > > diff --git a/tests/acceptance/replay_kernel.py > b/tests/acceptance/replay_kernel.py > index

Re: [PATCH 7/7] linux-user: limit check to HOST_LONG_BITS < TARGET_ABI_BITS

2020-05-27 Thread Laurent Vivier
Le 25/05/2020 à 15:18, Thomas Huth a écrit : > From: Alex Bennée > > Newer clangs rightly spot that you can never exceed the full address > space of 64 bit hosts with: > > linux-user/elfload.c:2076:41: error: result of comparison 'unsigned > long' > 18446744073709551615 is always false >

[PULL 08/12] tests/docker: add debian11 base image

2020-05-27 Thread Alex Bennée
We won't use this for building QEMU but we do need newer GCC's and binutils for building some of our test cases. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20200520140541.30256-10-alex.ben...@linaro.org> diff --git a/tests/docker/Makefile.include

[PATCH v2 11/11] tests/acceptance: Linux boot test for record/replay

2020-05-27 Thread Pavel Dovgalyuk
This patch adds a test for record/replay, which boots Linux image from the disk and interacts with the network. The idea and code of this test is borrowed from boot_linux.py However, currently record/replay works only for x86_64, therefore other tests were excluded. Each test consists of the

Re: [PATCH 01/24] arm/stm32f405: Fix realization of "stm32f2xx-adc" devices

2020-05-27 Thread Philippe Mathieu-Daudé
On 5/27/20 11:27 AM, Markus Armbruster wrote: > Alistair Francis writes: > >> On Mon, May 18, 2020 at 10:08 PM Markus Armbruster wrote: >>> >>> Alistair Francis writes: >>> On Sun, May 17, 2020 at 10:06 PM Markus Armbruster wrote: > > stm32f405_soc_initfn() creates six such

Re: [PATCH v4 3/5] block: generate coroutine-wrapper code

2020-05-27 Thread Vladimir Sementsov-Ogievskiy
27.05.2020 00:30, Eric Blake wrote: On 5/25/20 5:07 AM, Vladimir Sementsov-Ogievskiy wrote: We have a very frequent pattern of creating coroutine from function with several arguments:    - create structure to pack parameters    - create _entry function to call original function taking

Re: [PATCH v3 4/9] pc-bios: s390x: Get rid of magic offsets into the lowcore

2020-05-27 Thread Janosch Frank
On 5/27/20 10:50 AM, Christian Borntraeger wrote: > > > On 27.05.20 09:49, Janosch Frank wrote: >> If we have a lowcore struct that has members for offsets that we want >> to touch, why not use it? >> >> Signed-off-by: Janosch Frank >> Reviewed-by: David Hildenbrand >> --- >>

[PATCH v6 0/5] block: enhance handling of size-related BlockConf properties

2020-05-27 Thread Roman Kagan
BlockConf includes several properties counted in bytes. Enhance their handling in a some aspects, specifically - accept common size suffixes (k, m) - perform consistency checks on the values - lift the upper limit on physical_block_size and logical_block_size Also fix the accessor for

[PATCH v6 1/5] virtio-blk: store opt_io_size with correct size

2020-05-27 Thread Roman Kagan
The width of opt_io_size in virtio_blk_config is 32bit. However, it's written with virtio_stw_p; this may result in value truncation, and on big-endian systems with legacy virtio in completely bogus readings in the guest. Use the appropriate accessor to store it. Signed-off-by: Roman Kagan

[PATCH v3] arm/aspeed: Rework NIC attachment

2020-05-27 Thread Cédric Le Goater
The number of MACs supported by an Aspeed SoC is defined by "macs_num" under the SoC model, that is two for the AST2400 and AST2500 and four for the AST2600. The model initializes the maximum number of supported MACs but the number of realized devices is capped by the number of network device

[PATCH v6 3/5] qdev-properties: blocksize: use same limits in code and description

2020-05-27 Thread Roman Kagan
Make it easier (more visible) to maintain the limits on the blocksize properties in sync with the respective description, by using macros both in the code and in the description. Signed-off-by: Roman Kagan --- v4 -> v5: - split out into separate patch [Philippe] hw/core/qdev-properties.c | 21

[PATCH v6 5/5] block: lift blocksize property limit to 2 MiB

2020-05-27 Thread Roman Kagan
Logical and physical block sizes in QEMU are limited to 32 KiB. This appears unnecessary tight, and we've seen bigger block sizes handy at times. Lift the limitation up to 2 MiB which appears to be good enough for everybody, and matches the qcow2 cluster size limit. Signed-off-by: Roman Kagan

Re: [PATCH v2 01/11] tests/acceptance: allow console interaction with specific VMs

2020-05-27 Thread Alex Bennée
Pavel Dovgalyuk writes: > Console interaction in avocado scripts was possible only with single > default VM. > This patch modifies the function parameters to allow passing a specific > VM as a parameter to interact with it. > > Signed-off-by: Pavel Dovgalyuk > Reviewed-by: Willian Rampazzo >

Re: [PATCH 2/5] vhost: involve device backends in feature negotiation

2020-05-27 Thread Marc-André Lureau
Hi Stefan On Fri, May 22, 2020 at 7:18 PM Stefan Hajnoczi wrote: > > Many vhost devices in QEMU currently do not involve the device backend > in feature negotiation. This seems fine at first glance for device types > without their own feature bits (virtio-net has many but other device > types

Re: [PATCH] linux-user, alpha: fix oldumount syscall

2020-05-27 Thread Laurent Vivier
Le 02/05/2020 à 21:46, Laurent Vivier a écrit : > When we try to bootstrap debian/lenny for alpha, it fails because > it cannot umount /.root directory: > > ... > Setting up initscripts (2.86.ds1-61) ... > umount: /.root: Function not implemented > dpkg: error processing initscripts

Re: [PATCH v6 5/5] block: lift blocksize property limit to 2 MiB

2020-05-27 Thread Eric Blake
On 5/27/20 7:45 AM, Roman Kagan wrote: Logical and physical block sizes in QEMU are limited to 32 KiB. This appears unnecessary tight, and we've seen bigger block sizes handy unnecessarily at times. Lift the limitation up to 2 MiB which appears to be good enough for everybody, and matches

Re: [PATCH v3 14/22] microvm: use 2G split unconditionally

2020-05-27 Thread Paolo Bonzini
On 27/05/20 16:26, Igor Mammedov wrote: > On Wed, 27 May 2020 15:06:28 +0200 > Paolo Bonzini wrote: > >> On 27/05/20 14:25, Igor Mammedov wrote: (2) we loose a gigabyte page. >>> I'm not sure waht exactly we loose in this case. >>> Lets assume we allocating guest 5G

Re: [PATCH v2 00/11] Record/replay acceptance tests

2020-05-27 Thread Philippe Mathieu-Daudé
On 5/27/20 3:41 PM, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/159057543840.16818.14393433996899521784.stgit@pasha-ThinkPad-X280/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > [...]> > ERROR: line

Re: [PATCH v2 04/11] tests/acceptance: add kernel record/replay test for x86_64

2020-05-27 Thread Philippe Mathieu-Daudé
On 5/27/20 12:31 PM, Pavel Dovgalyuk wrote: > This patch adds a test for record/replay an execution of x86_64 machine. > Execution scenario includes simple kernel boot, which allows testing > basic hardware interaction in RR mode. > > Signed-off-by: Pavel Dovgalyuk > --- > 0 files changed > >

[PULL 04/12] tests/tcg: fix invocation of the memory record/replay tests

2020-05-27 Thread Alex Bennée
I'm not sure when this broke but we should use EXTRA_RUNS for "virtual" tests which are not generated from the binary names. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20200520140541.30256-5-alex.ben...@linaro.org> diff --git

[PATCH v4 2/5] virtio-scsi: introduce a constant for fixed virtqueues

2020-05-27 Thread Stefan Hajnoczi
The event and control virtqueues are always present, regardless of the multi-queue configuration. Define a constant so that virtqueue number calculations are easier to read. Signed-off-by: Stefan Hajnoczi Reviewed-by: Cornelia Huck --- include/hw/virtio/virtio-scsi.h | 3 +++

[PATCH v4 3/5] virtio-scsi: default num_queues to -smp N

2020-05-27 Thread Stefan Hajnoczi
Automatically size the number of virtio-scsi-pci, vhost-scsi-pci, and vhost-user-scsi-pci request virtqueues to match the number of vCPUs. Other transports continue to default to 1 request virtqueue. A 1:1 virtqueue:vCPU mapping ensures that completion interrupts are handled on the same vCPU that

Re: [PATCH v4 3/5] virtio-scsi: default num_queues to -smp N

2020-05-27 Thread Daniel P . Berrangé
On Wed, May 27, 2020 at 11:29:23AM +0100, Stefan Hajnoczi wrote: > Automatically size the number of virtio-scsi-pci, vhost-scsi-pci, and > vhost-user-scsi-pci request virtqueues to match the number of vCPUs. > Other transports continue to default to 1 request virtqueue. IIRC this was raised on

Re: [PATCH 2/2] qom: Make "info qom-tree" show children sorted

2020-05-27 Thread Philippe Mathieu-Daudé
On 5/27/20 10:47 AM, Markus Armbruster wrote: > "info qom-tree" prints children in unstable order. This is a pain > when diffing output for different versions to find change. Print it > sorted. > > Signed-off-by: Markus Armbruster > --- > qom/qom-hmp-cmds.c | 24 > 1

[PATCH v2 10/11] tests/acceptance: refactor boot_linux to allow code reuse

2020-05-27 Thread Pavel Dovgalyuk
This patch moves image downloading functions to the separate class to allow reusing them from record/replay tests. Signed-off-by: Pavel Dovgalyuk --- 0 files changed diff --git a/tests/acceptance/boot_linux.py b/tests/acceptance/boot_linux.py index 075a386300..3aa57e88b0 100644 ---

Re: [PATCH 4/4] check-block: Enable iotests with SafeStack

2020-05-27 Thread Stefan Hajnoczi
On Fri, May 22, 2020 at 11:35:42AM -0400, Daniele Buono wrote: > On 5/21/2020 5:59 AM, Stefan Hajnoczi wrote: > > On Wed, Apr 29, 2020 at 03:44:20PM -0400, Daniele Buono wrote: > > > > > > > > Signed-off-by: Daniele Buono > > > --- > > > tests/check-block.sh | 12 +++- > > > 1 file

Re: [PATCH v2] arm/aspeed: Rework NIC attachment

2020-05-27 Thread Markus Armbruster
Cédric Le Goater writes: > The number of MACs supported by an Aspeed SoC is defined by "macs_num" > under the SoC model, that is two for the AST2400 and AST2500 and four > the AST2600. The model initializes the maximum number of supported > MACs but the number of realized devices is caped by the

Re: [PATCH v3] arm/aspeed: Rework NIC attachment

2020-05-27 Thread Markus Armbruster
Cédric Le Goater writes: > The number of MACs supported by an Aspeed SoC is defined by "macs_num" > under the SoC model, that is two for the AST2400 and AST2500 and four > for the AST2600. The model initializes the maximum number of supported > MACs but the number of realized devices is capped

Re: [PATCH 3/4] configure: add flag to enable SafeStack

2020-05-27 Thread Daniele Buono
Hi Stefan, a quick clarification on configure: right now, in configure, there's * "Advanced Options (experts only)" which usually don't have both enable and disable for each option, and * "Optional features, enabled with --enable-FEATURE and disabled with --disable-FEATURE, default is enabled if

Re: [PATCH RFC 01/32] python/qemu: create qemu.lib module

2020-05-27 Thread John Snow
On 5/26/20 11:25 AM, Daniel P. Berrangé wrote: > On Tue, May 26, 2020 at 05:23:42PM +0200, Philippe Mathieu-Daudé wrote: >> On 5/26/20 5:22 PM, Daniel P. Berrangé wrote: >>> On Mon, May 18, 2020 at 08:27:54PM -0400, John Snow wrote: On 5/18/20 3:33 PM, Vladimir

Re: [PATCH v2 01/11] tests/acceptance: allow console interaction with specific VMs

2020-05-27 Thread Willian Rampazzo
On Wed, May 27, 2020 at 11:20 AM Alex Bennée wrote: > > > Pavel Dovgalyuk writes: > > > Console interaction in avocado scripts was possible only with single > > default VM. > > This patch modifies the function parameters to allow passing a specific > > VM as a parameter to interact with it. > >

[PULL 02/12] tests/vm: pass --genisoimage to basevm script

2020-05-27 Thread Alex Bennée
If we have an alternative to genisoimage we really need to tell the script about it as well so it can use it. It will still default to genisoimage in case it is run outside our build machinery. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Robert Foley

Re: [PATCH v2 1/5] hw: Add sockets_specified field in CpuTopology

2020-05-27 Thread Daniel P . Berrangé
On Wed, May 27, 2020 at 10:01:21AM +, Anup Patel wrote: > > > > -Original Message- > > From: Daniel P. Berrangé > > Sent: 27 May 2020 15:21 > > To: Anup Patel > > Cc: Eduardo Habkost ; Marcel Apfelbaum > > ; Peter Maydell ; > > Palmer Dabbelt ; Alistair Francis > > ; Sagar

Re: [PATCH v6 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites

2020-05-27 Thread Philippe Mathieu-Daudé
On 5/27/20 1:33 PM, Daniel P. Berrangé wrote: > On Wed, May 27, 2020 at 01:29:20PM +0200, Philippe Mathieu-Daudé wrote: >> Hi Daniel, >> >> On 5/19/20 8:20 PM, Philippe Mathieu-Daudé wrote: >>> Hi, >>> >>> This series has two parts: >>> >>> - First we add the ability to QOM objects to produce data

Re: [PATCH v4 4/5] block: drop bdrv_prwv

2020-05-27 Thread Vladimir Sementsov-Ogievskiy
27.05.2020 00:34, Eric Blake wrote: On 5/25/20 5:08 AM, Vladimir Sementsov-Ogievskiy wrote: Now, when we are not more paying extra code for coroutine wrappers, there no more sence in extra indirection layer: bdrv_prwv(). Let's drop it and instead genereate pure bdrv_preadv() and bdrv_pwritev().

Re: [PATCH v1 2/3] linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit

2020-05-27 Thread Aleksandar Markovic
сре, 27. мај 2020. у 12:07 Alex Bennée је написао/ла: > > We rely on the pointer to wrap when accessing the high address of the > COMMPAGE so it lands somewhere reasonable. However on 32 bit hosts we > cannot afford just to map the entire 4gb address range. The old mmap > trial and error code

Re: [PATCH RFC 01/32] python/qemu: create qemu.lib module

2020-05-27 Thread Daniel P . Berrangé
On Wed, May 27, 2020 at 10:28:44AM -0400, John Snow wrote: > > > On 5/26/20 11:25 AM, Daniel P. Berrangé wrote: > > On Tue, May 26, 2020 at 05:23:42PM +0200, Philippe Mathieu-Daudé wrote: > >> On 5/26/20 5:22 PM, Daniel P. Berrangé wrote: > >>> On Mon, May 18, 2020 at 08:27:54PM -0400, John Snow

[PULL 01/12] configure: add alternate binary for genisoimage

2020-05-27 Thread Alex Bennée
Not all distros ship genisoimage which is a Debian fork from the original cdrtools. As the options are pretty much the same support it as a fallback binary. Signed-off-by: Alex Bennée Signed-off-by: Robert Foley Message-Id: <20200519132259.405-2-robert.fo...@linaro.org> diff --git a/configure

[PULL 09/12] tests/docker: use a gcc-10 based image for arm64 tests

2020-05-27 Thread Alex Bennée
As we enable newer features that we want to test on arm64 targets we need newer compilers. Split off a new debian-arm64-test-cross image which we can use to build these new tests. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id:

[PULL 00/12] testing and plugin fixes

2020-05-27 Thread Alex Bennée
The following changes since commit ddc760832fa8cf5e93b9d9e6e854a5114ac63510: Merge remote-tracking branch 'remotes/gkurz/tags/9p-next-2020-05-26' into staging (2020-05-26 14:05:53 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git

Re: [PATCH v2 5/7] sm501: Replace hand written implementation with pixman where possible

2020-05-27 Thread BALATON Zoltan
Hello, On Wed, 27 May 2020, Gerd Hoffmann wrote: Well, the advantage of *not* using pixman is that you can easily switch the code to use offsets instead of pointers, then apply the mask to the *final* offset to avoid oob data access: The mask applied to src_base is not to prevent overflow but

Re: [PATCH v6 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites

2020-05-27 Thread Daniel P . Berrangé
On Wed, May 27, 2020 at 01:29:20PM +0200, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 5/19/20 8:20 PM, Philippe Mathieu-Daudé wrote: > > Hi, > > > > This series has two parts: > > > > - First we add the ability to QOM objects to produce data > > consumable by the fw_cfg device, > > > >

Re: [PATCH v3 14/22] microvm: use 2G split unconditionally

2020-05-27 Thread Igor Mammedov
On Tue, 26 May 2020 06:48:39 +0200 Gerd Hoffmann wrote: > > > Well, I think we can (should) drop max-ram-below-4g too. There is > > > no reason to use that with microvm, other that shooting yourself into > > > the foot (by making mmio overlap with ram). > > > > > > With that being gone too

Re: [PATCH v2 2/7] Implement drain_call_rcu and use it in hmp_device_del

2020-05-27 Thread Stefan Hajnoczi
On Mon, May 11, 2020 at 07:09:46PM +0300, Maxim Levitsky wrote: > /* The operands of the minus operator must have the same type, > * which must be the one that we specify in the cast. > diff --git a/qdev-monitor.c b/qdev-monitor.c > index 56cee1483f..70877840a2 100644 > --- a/qdev-monitor.c >

Re: [PATCH] linux-user/strace.list: fix epoll_create{,1} -strace output

2020-05-27 Thread Laurent Vivier
Le 16/04/2020 à 19:59, Sergei Trofimovich a écrit : > Fix syscall name and parameters priinter. > > Before the change: > > ``` > $ alpha-linux-user/qemu-alpha -strace -L /usr/alpha-unknown-linux-gnu/ /tmp/a > ... > 1274697 >

[PATCH v2 08/11] tests/acceptance: add record/replay test for m68k

2020-05-27 Thread Pavel Dovgalyuk
This patch adds a test for record/replay of the kernel image boot for m68k platform. Signed-off-by: Pavel Dovgalyuk --- 0 files changed diff --git a/tests/acceptance/replay_kernel.py b/tests/acceptance/replay_kernel.py index 7ac046b822..0d629d1ee7 100644 ---

[PATCH v2 05/11] tests/acceptance: add record/replay test for aarch64

2020-05-27 Thread Pavel Dovgalyuk
This patch adds a test for record/replay of the kernel image boot for aarch64 platform. Signed-off-by: Pavel Dovgalyuk --- 0 files changed diff --git a/tests/acceptance/replay_kernel.py b/tests/acceptance/replay_kernel.py index c7526f1aba..deca69d6cb 100644 ---

[PATCH v2 07/11] tests/acceptance: add record/replay test for ppc64

2020-05-27 Thread Pavel Dovgalyuk
This patch adds a test for record/replay of the kernel image boot for ppc64 platform. Signed-off-by: Pavel Dovgalyuk --- 0 files changed diff --git a/tests/acceptance/replay_kernel.py b/tests/acceptance/replay_kernel.py index d715ee7ca9..7ac046b822 100644 ---

Re: [PATCH v6 4/5] crypto: Add tls-cipher-suites object

2020-05-27 Thread Daniel P . Berrangé
On Tue, May 19, 2020 at 08:20:23PM +0200, Philippe Mathieu-Daudé wrote: > Example of use to dump: > > $ qemu-system-x86_64 -S \ > -object tls-cipher-suites,id=mysuite,priority=@SYSTEM,verbose=yes > Cipher suites for @SYSTEM: > - TLS_AES_256_GCM_SHA384

Re: [PATCH v2 1/7] scsi/scsi_bus: switch search direction in scsi_device_find

2020-05-27 Thread Stefan Hajnoczi
On Mon, May 11, 2020 at 07:09:45PM +0300, Maxim Levitsky wrote: > This change will allow us to convert the bus children list to RCU, > while not changing the logic of this function > > Signed-off-by: Maxim Levitsky > --- > hw/scsi/scsi-bus.c | 12 ++-- > 1 file changed, 10

Re: [PATCH v3 14/22] microvm: use 2G split unconditionally

2020-05-27 Thread Paolo Bonzini
On 27/05/20 14:25, Igor Mammedov wrote: >> (2) we loose a gigabyte page. > I'm not sure waht exactly we loose in this case. > Lets assume we allocating guest 5G of continuous RAM using 1G huge > pages, > in this case I'd think that on host side MMIO overlay won't

Re: [PATCH v2 00/11] Record/replay acceptance tests

2020-05-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/159057543840.16818.14393433996899521784.stgit@pasha-ThinkPad-X280/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 159057543840.16818.14393433996899521784.stgit@pasha-ThinkPad-X280 Subject:

Re: [PATCH v2 02/11] tests/acceptance: refactor boot_linux_console test to allow code reuse

2020-05-27 Thread Alex Bennée
Pavel Dovgalyuk writes: > This patch splits code in BootLinuxConsole class into two different > classes to allow reusing it by record/replay tests. > > Signed-off-by: Pavel Dovgalyuk > --- > 0 files changed > > diff --git a/tests/acceptance/boot_linux_console.py >

Re: [PATCH] linux-user: return target error codes for socket() and prctl()

2020-05-27 Thread Laurent Vivier
Le 25/04/2020 à 00:00, Helge Deller a écrit : > Return target error codes instead of host error codes. > > Signed-off-by: Helge Deller > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 05f03919ff..655a86fa45 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c >

Re: [PATCH v2 3/7] device-core: use RCU for list of childs of a bus

2020-05-27 Thread Stefan Hajnoczi
On Mon, May 11, 2020 at 07:09:47PM +0300, Maxim Levitsky wrote: > diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h > index d87d989e72..ef47cb2d9c 100644 > --- a/include/hw/qdev-core.h > +++ b/include/hw/qdev-core.h > @@ -3,6 +3,8 @@ > > #include "qemu/queue.h" > #include

[PULL 03/12] travis.yml: Use clang++ in the Clang tests

2020-05-27 Thread Alex Bennée
From: Thomas Huth Our configure script does not look for clang++ automatically, so we should use --cxx=clang++ to make sure that we test our C++ code with Clang, too. And while we're at it, also use --host-cc=clang here to avoid that we use the normal "cc" as host C compiler. Signed-off-by:

[PULL 06/12] tests/fp: split and audit the conversion tests

2020-05-27 Thread Alex Bennée
Split the float conversion tests into separate groups and audit the tests to check what is still broken. I was able to enable a bunch of tests that had been missed before: all the float to float conversions ui32_to_extF80 ui64_to_extF80 extF80_to_ui32 extF80_to_ui32_r_minMag

[PULL 10/12] cpus-common: ensure auto-assigned cpu_indexes don't clash

2020-05-27 Thread Alex Bennée
Basing the cpu_index on the number of currently allocated vCPUs fails when vCPUs aren't removed in a LIFO manner. This is especially true when we are allocating a cpu_index for each guest thread in linux-user where there is no ordering constraint on their allocation and de-allocation. [I've

[PATCH v4 5/5] vhost-user-blk: default num_queues to -smp N

2020-05-27 Thread Stefan Hajnoczi
Automatically size the number of request virtqueues to match the number of vCPUs. This ensures that completion interrupts are handled on the same vCPU that submitted the request. No IPI is necessary to complete an I/O request and performance is improved. Signed-off-by: Stefan Hajnoczi

[PATCH v2 03/11] tests/acceptance: add base class record/replay kernel tests

2020-05-27 Thread Pavel Dovgalyuk
This patch adds a base for testing kernel boot recording and replaying. Each test has the phase of recording and phase of replaying. Virtual machines just boot the kernel and do not interact with the network. Structure and image links for the tests are borrowed from boot_linux_console.py Testing

[PATCH v2 09/11] tests/acceptance: record/replay tests with advcal images

2020-05-27 Thread Pavel Dovgalyuk
This patch adds more record/replay tests with kernel images. Signed-off-by: Pavel Dovgalyuk -- v2: - make download path fixed to allow pre-test downloading (suggested by Willian Rampazzo) --- 0 files changed diff --git a/tests/acceptance/replay_kernel.py

[PATCH v2 04/11] tests/acceptance: add kernel record/replay test for x86_64

2020-05-27 Thread Pavel Dovgalyuk
This patch adds a test for record/replay an execution of x86_64 machine. Execution scenario includes simple kernel boot, which allows testing basic hardware interaction in RR mode. Signed-off-by: Pavel Dovgalyuk --- 0 files changed diff --git a/tests/acceptance/replay_kernel.py

RE: [PATCH v2 1/5] hw: Add sockets_specified field in CpuTopology

2020-05-27 Thread Anup Patel
> -Original Message- > From: Daniel P. Berrangé > Sent: 27 May 2020 16:12 > To: Anup Patel > Cc: Peter Maydell ; qemu-ri...@nongnu.org; > Eduardo Habkost ; Sagar Karandikar > ; Anup Patel ; qemu- > de...@nongnu.org; Atish Patra ; Alistair Francis > ; Palmer Dabbelt > Subject: Re:

[PATCH v3 3/4] hw/riscv: Allow creating multiple instances of PLIC

2020-05-27 Thread Anup Patel
We extend PLIC emulation to allow multiple instances of PLIC in a QEMU RISC-V machine. To achieve this, we remove first HART id zero assumption from PLIC emulation. Signed-off-by: Anup Patel Reviewed-by: Palmer Dabbelt Reviewed-by: Alistair Francis --- hw/riscv/sifive_e.c| 2 +-

[PATCH v3 2/4] hw/riscv: spike: Allow creating multiple sockets

2020-05-27 Thread Anup Patel
We extend RISC-V spike machine to allow creating a multi-socket machine. Each RISC-V spike machine socket is a set of HARTs and a CLINT instance. Other peripherals are shared between all RISC-V spike machine sockets. We also update RISC-V spike machine device tree to treat each socket as a NUMA

[PATCH v3 1/4] hw/riscv: Allow creating multiple instances of CLINT

2020-05-27 Thread Anup Patel
We extend CLINT emulation to allow multiple instances of CLINT in a QEMU RISC-V machine. To achieve this, we remove first HART id zero assumption from CLINT emulation. Signed-off-by: Anup Patel Reviewed-by: Alistair Francis Reviewed-by: Palmer Dabbelt --- hw/riscv/sifive_clint.c | 20

[PATCH v3 4/4] hw/riscv: virt: Allow creating multiple sockets

2020-05-27 Thread Anup Patel
We extend RISC-V virt machine to allow creating a multi-socket machine. Each RISC-V virt machine socket is a set of HARTs, a CLINT instance, and a PLIC instance. Other peripherals are shared between all RISC-V virt machine sockets. We also update RISC-V virt machine device tree to treat each

[PATCH v3 0/4] RISC-V multi-socket support

2020-05-27 Thread Anup Patel
This series adds multi-socket support for RISC-V virt machine and RISC-V spike machine. The multi-socket support will help us improve various RISC-V operating systems, firmwares, and bootloader to support RISC-V NUMA systems. These patch can be found in riscv_multi_socket_v3 branch at:

[PATCH v6 2/5] block: consolidate blocksize properties consistency checks

2020-05-27 Thread Roman Kagan
Several block device properties related to blocksize configuration must be in certain relationship WRT each other: physical block must be no smaller than logical block; min_io_size, opt_io_size, and discard_granularity must be a multiple of a logical block. To ensure these requirements are met,

[PATCH v6 4/5] block: make size-related BlockConf properties accept size suffixes

2020-05-27 Thread Roman Kagan
Several BlockConf properties represent respective sizes in bytes so it makes sense to accept size suffixes for them. Turn them all into uint32_t and use size-suffix-capable setters/getters on them; introduce DEFINE_PROP_SIZE32 and adjust DEFINE_PROP_BLOCKSIZE for that. (Making them uint64_t and

Re: [PATCH v6 3/5] qdev-properties: blocksize: use same limits in code and description

2020-05-27 Thread Eric Blake
On 5/27/20 7:45 AM, Roman Kagan wrote: Make it easier (more visible) to maintain the limits on the blocksize properties in sync with the respective description, by using macros both in the code and in the description. Signed-off-by: Roman Kagan --- Reviewed-by: Eric Blake -- Eric Blake,

Re: [PATCH v6 2/5] block: consolidate blocksize properties consistency checks

2020-05-27 Thread Eric Blake
On 5/27/20 7:45 AM, Roman Kagan wrote: Several block device properties related to blocksize configuration must be in certain relationship WRT each other: physical block must be no smaller than logical block; min_io_size, opt_io_size, and discard_granularity must be a multiple of a logical block.

Re: [PATCH 7/7] linux-user: limit check to HOST_LONG_BITS < TARGET_ABI_BITS

2020-05-27 Thread Thomas Huth
On 27/05/2020 16.44, Laurent Vivier wrote: > Le 25/05/2020 à 15:18, Thomas Huth a écrit : >> From: Alex Bennée >> >> Newer clangs rightly spot that you can never exceed the full address >> space of 64 bit hosts with: >> >> linux-user/elfload.c:2076:41: error: result of comparison 'unsigned >>

Re: [PATCH v6 4/5] block: make size-related BlockConf properties accept size suffixes

2020-05-27 Thread Eric Blake
On 5/27/20 7:45 AM, Roman Kagan wrote: Several BlockConf properties represent respective sizes in bytes so it makes sense to accept size suffixes for them. Turn them all into uint32_t and use size-suffix-capable setters/getters on them; introduce DEFINE_PROP_SIZE32 and adjust

[PULL 12/12] tests/tcg: add new threadcount test

2020-05-27 Thread Alex Bennée
Based on the original testcase by Nikolay Igotti. Message-ID: Signed-off-by: Nikolay Igotti Signed-off-by: Alex Bennée Message-Id: <20200520140541.30256-15-alex.ben...@linaro.org> diff --git a/tests/tcg/multiarch/threadcount.c b/tests/tcg/multiarch/threadcount.c new file mode 100644 index

Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices

2020-05-27 Thread Peter Maydell
On Wed, 27 May 2020 at 15:12, Markus Armbruster wrote: > * PATCH 08: in a realize method. Can't actually fail, so let's use > _abort. > > * PATCH 09 (this one): likewise. I disagree with these. We're in a realize function, the API says "on errors, report them via the Error* you got passed",

[PATCH] hw/pci: Fix crash when running QEMU with "-nic model=rocker"

2020-05-27 Thread Thomas Huth
QEMU currently aborts when being started with "-nic model=rocker" or with "-net nic,model=rocker". This happens because the "rocker" device is not a normal NIC but a switch, which has different properties. Thus we should only consider real NIC devices for "-nic" and "-net". These devices can be

Re: [PATCH v2 7/7] virtio-scsi: use scsi_device_get

2020-05-27 Thread Stefan Hajnoczi
On Mon, May 11, 2020 at 07:09:51PM +0300, Maxim Levitsky wrote: > This will help us to avoid the scsi device disappearing > after we took a reference to it. > > It doesn't by itself forbid case when we try to access > an unrealized device > > Suggested-by: Stefan Hajnoczi > Signed-off-by: Maxim

Re: [PATCH v2 11/11] tests/acceptance: Linux boot test for record/replay

2020-05-27 Thread Alex Bennée
Pavel Dovgalyuk writes: > This patch adds a test for record/replay, which boots Linux > image from the disk and interacts with the network. > The idea and code of this test is borrowed from boot_linux.py > However, currently record/replay works only for x86_64, > therefore other tests were

Re: [PATCH v7 22/32] qcow2: Add subcluster support to zero_in_l2_slice()

2020-05-27 Thread Eric Blake
On 5/25/20 1:08 PM, Alberto Garcia wrote: The QCOW_OFLAG_ZERO bit that indicates that a cluster reads as zeroes is only used in standard L2 entries. Extended L2 entries use individual 'all zeroes' bits for each subcluster. This must be taken into account when updating the L2 entry and also when

[PATCH v4 05/10] riscv: Initial commit of OpenTitan machine

2020-05-27 Thread Alistair Francis
This adds a barebone OpenTitan machine to QEMU. Signed-off-by: Alistair Francis Reviewed-by: Bin Meng --- default-configs/riscv32-softmmu.mak | 1 + default-configs/riscv64-softmmu.mak | 11 +- include/hw/riscv/opentitan.h| 63 +++ hw/riscv/opentitan.c| 169

[PATCH v4 01/10] riscv/boot: Add a missing header include

2020-05-27 Thread Alistair Francis
As the functions declared in this header use the symbol_fn_t typedef itself declared in "hw/loader.h", we need to include it here to make the header file self-contained. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Bin Meng --- include/hw/riscv/boot.h | 1 +

[PATCH v4 00/10] RISC-V Add the OpenTitan Machine

2020-05-27 Thread Alistair Francis
OpenTitan is an open source silicon Root of Trust (RoT) project. This series adds initial support for the OpenTitan machine to QEMU. This series add the Ibex CPU to the QEMU RISC-V target. It then adds the OpenTitan machine, the Ibex UART and the Ibex PLIC. The UART has been tested sending and

[PATCH v4 09/10] riscv/opentitan: Connect the UART device

2020-05-27 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé --- include/hw/riscv/opentitan.h | 13 + hw/riscv/opentitan.c | 24 ++-- 2 files changed, 35 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] hw/vfio/common: Trace in which mode a IOMMU is opened

2020-05-27 Thread Cornelia Huck
On Wed, 27 May 2020 12:53:30 -0400 Peter Xu wrote: > On Wed, May 27, 2020 at 06:27:38PM +0200, Philippe Mathieu-Daudé wrote: > > On 5/27/20 6:16 PM, Peter Xu wrote: > > > On Wed, May 27, 2020 at 05:53:16PM +0200, Philippe Mathieu-Daudé wrote: > > > +for (i = 0; i < ARRAY_SIZE(iommu);

Re: [PATCH v7 28/32] qcow2: Add subcluster support to qcow2_co_pwrite_zeroes()

2020-05-27 Thread Eric Blake
On 5/25/20 1:08 PM, Alberto Garcia wrote: This works now at the subcluster level and pwrite_zeroes_alignment is updated accordingly. qcow2_cluster_zeroize() is turned into qcow2_subcluster_zeroize() with the following changes: - The request can now be subcluster-aligned. - The

  1   2   3   >