Re: [PULL 04/12] hmp: Simplify qom-set

2020-06-02 Thread Markus Armbruster
"Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > Simplify qom_set by making it use qmp_qom_set and the JSON parser. > > (qemu) qom-get /machine smm > "auto" > (qemu) qom-set /machine smm "auto" > > Signed-off-by: Dr. David Alan Gilbert > Message-Id:

RE: [PATCH 3/3] migration/colo: Merge multi checkpoint request into one.

2020-06-02 Thread Zhanghailiang
> -Original Message- > From: Zhang Chen [mailto:chen.zh...@intel.com] > Sent: Friday, May 15, 2020 12:28 PM > To: Dr . David Alan Gilbert ; Juan Quintela > ; Zhanghailiang ; > qemu-dev > Cc: Zhang Chen ; Jason Wang > ; Zhang Chen > Subject: [PATCH 3/3] migration/colo: Merge multi

RE: [PATCH 2/3] migration/colo: Update checkpoint time lately

2020-06-02 Thread Zhanghailiang
Reviewed-by: zhanghailiang Hmm, How much time it spends on preparing before COLO process ? > -Original Message- > From: Zhang Chen [mailto:chen.zh...@intel.com] > Sent: Friday, May 15, 2020 12:28 PM > To: Dr . David Alan Gilbert ; Juan Quintela > ; Zhanghailiang ; > qemu-dev > Cc:

Re: [PATCH] hw/pci/pcie: Move hot plug capability check to pre_plug callback

2020-06-02 Thread Julia Suvorova
On Tue, Jun 2, 2020 at 5:54 AM Michael S. Tsirkin wrote: > > On Mon, Jun 01, 2020 at 06:29:34PM +0200, Julia Suvorova wrote: > > Check for hot plug capability earlier to avoid removing devices attached > > during the initialization process. > > > > Run qemu with an unattached drive: > > -drive

Re: [PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

2020-06-02 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > I don't have much clue about the Renesas hardware, but at least > I know now the source files a little bit, so I volunteer to pick > up patches and send pull-requests for them during my scarce > hobbyist time, until someone else with more knowledge steps up > to

[PATCH 3/4] block: Add block accounting code for GET LBA STATUS

2020-06-02 Thread Lin Ma
Signed-off-by: Lin Ma --- include/block/accounting.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/block/accounting.h b/include/block/accounting.h index 878b4c3581..645014fb0b 100644 --- a/include/block/accounting.h +++ b/include/block/accounting.h @@ -38,6 +38,7 @@ enum

[PATCH 4/4] scsi-disk: Add support for the GET LBA STATUS 16 command

2020-06-02 Thread Lin Ma
Signed-off-by: Lin Ma --- hw/scsi/scsi-disk.c | 92 include/scsi/constants.h | 1 + 2 files changed, 93 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 387503e11b..2d2c6b4b82 100644 --- a/hw/scsi/scsi-disk.c +++

[PATCH 0/4] Add Support for GET LBA STATUS 16 command in scsi emulation

2020-06-02 Thread Lin Ma
In this current design, The GET LBA STATUS parameter data only contains an eight-byte header + one LBA status descriptor. How to test: host:~ # qemu-system-x86_64 \ ... -drive file=/vm0/disk0.raw,format=raw,if=none,id=drive0,discard=unmap \ -device scsi-hd,id=scsi0,drive=drive0 \ ... guest:~ #

[PATCH 1/4] block: Add bdrv_co_get_lba_status

2020-06-02 Thread Lin Ma
The get lba status wrapper based on the bdrv_block_status. The following patches will add GET LBA STATUS 16 support for scsi emulation layer. Signed-off-by: Lin Ma --- block/io.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/block/io.c

[PATCH 2/4] block: Add GET LBA STATUS support

2020-06-02 Thread Lin Ma
Signed-off-by: Lin Ma --- block/block-backend.c | 38 ++ include/sysemu/block-backend.h | 2 ++ 2 files changed, 40 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index 6936b25c83..feb1f38b98 100644 --- a/block/block-backend.c

Re: [PATCH] or1k: Fix compilation hiccup

2020-06-02 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 29 May 2020 at 17:23, Christophe de Dinechin > wrote: >> On 2020-05-26 at 20:51 CEST, Eric Blake wrote... >> > diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c >> > index d08ce6181199..95011a8015b4 100644 >> > --- a/hw/openrisc/openrisc_sim.c

Re: About the kvm-no-adjvtime CPU property

2020-06-02 Thread Ying Fang
On 2020/6/1 20:29, Andrew Jones wrote: On Mon, Jun 01, 2020 at 08:07:31PM +0800, Ying Fang wrote: On 2020/6/1 16:07, Andrew Jones wrote: On Sat, May 30, 2020 at 04:56:26PM +0800, Ying Fang wrote: About the kvm-no-adjvtime CPU property Hi Andrew, To adjust virutal time, a new kvm cpu

Re: [PATCH 0/4] Add Support for GET LBA STATUS 16 command in scsi emulation

2020-06-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200602074201.10879-1-...@suse.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH 0/4] Add Support for GET LBA STATUS 16 command in scsi emulation

2020-06-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200602074201.10879-1-...@suse.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200602074201.10879-1-...@suse.com Subject: [PATCH 0/4] Add Support for GET LBA STATUS 16 command in scsi

Re: [PATCH 0/4] Add Support for GET LBA STATUS 16 command in scsi emulation

2020-06-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200602074201.10879-1-...@suse.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export

Re: [PATCH 0/4] Add Support for GET LBA STATUS 16 command in scsi emulation

2020-06-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200602074201.10879-1-...@suse.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

2020-06-02 Thread Philippe Mathieu-Daudé
On 6/2/20 9:23 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> I don't have much clue about the Renesas hardware, but at least >> I know now the source files a little bit, so I volunteer to pick >> up patches and send pull-requests for them during my scarce >> hobbyist time,

Re: [PATCH for-5.1 V4 4/4] MAINTAINERS: Add myself as Loongson-3 maintainer

2020-06-02 Thread Philippe Mathieu-Daudé
On 6/2/20 4:39 AM, Huacai Chen wrote: > Signed-off-by: Huacai Chen > Co-developed-by: Jiaxun Yang > --- > MAINTAINERS | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 0944d9c..c42a218 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1092,6

Re: [PATCH v2 11/20] qapi: backup: add x-max-chunk and x-max-workers parameters

2020-06-02 Thread Vladimir Sementsov-Ogievskiy
01.06.2020 21:11, Vladimir Sementsov-Ogievskiy wrote: Add new parameters to configure future backup features. The patch doesn't introduce aio backup requests (so we actually have only one worker) neither requests larger than one cluster. Still, formally we satisfy these maximums anyway, so add

Re: [PATCH 1/6] target/s390x/mmu_helper: Use address_space_rw() in place

2020-06-02 Thread David Hildenbrand
On 31.05.20 19:54, Philippe Mathieu-Daudé wrote: > In an effort to remove the cpu_physical_memory_rw() API, > update s390_cpu_virt_mem_rw() to use a more recent > address_space_rw() API. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/s390x/mmu_helper.c | 6 -- > 1 file changed, 4

Re: Sam460Ex screen mode, audio and network

2020-06-02 Thread Philippe Mathieu-Daudé
Cc'ing the sam460ex maintainer. On 6/1/20 8:01 PM, Andrea Palmatè wrote: > Hello, i've successfully configured AmigaOS4 on Qemu 5 and i've > installed it without any problem. > It is working on an i5 laptop. I've tried to use the native screen mode > 1366x768 but it has some problems. It seems a

Re: [PATCH] checkpatch: reversed logic with acpi test checks

2020-06-02 Thread Philippe Mathieu-Daudé
On 6/2/20 7:36 AM, Michael S. Tsirkin wrote: > Logic reversed: allowed list should just be ignored. Instead we > only take that into account :( > > Fixes: e11b06a880ca ("checkpatch: ignore allowed diff list") > Signed-off-by: Michael S. Tsirkin > --- > scripts/checkpatch.pl | 2 +- > 1 file

[question] Partial sector issue while discard in qcow2 image

2020-06-02 Thread Lin Ma
Hi all, During woring to add GET LBA STATUS support in qemu scsi emulation layer, I encountered an unmap issue with qcow2 image, It's likely about how to unmap partial clusters. e.g.: With these default values: * the default value of s->qdev.blocksize: 512 * the default value of

Re: [PATCH 3/3] numa: Initialize node initiator with respect to .has_cpu

2020-06-02 Thread Tao Xu
On 6/1/2020 4:10 PM, Michal Privoznik wrote: On 5/29/20 5:09 PM, Igor Mammedov wrote: On Fri, 29 May 2020 15:33:48 +0200 Michal Privoznik wrote: The initiator attribute of a NUMA node is documented as the 'NUMA node that has best performance to given NUMA node'. If a NUMA node has at least

[PATCH] virtio-blk: Disable request queuing while switching contexts

2020-06-02 Thread Sergio Lopez
Disable request queuing while switching contexts on virtio_blk_data_plane_[start|stop](), preventing requests from getting queued on the wrong context. Placing requests on the wrong context may lead to them being wrongly accessed in parallel from different threads, potentially leading to multiple

Re: [PATCH v2 00/20] backup performance: block_status + async

2020-06-02 Thread Vladimir Sementsov-Ogievskiy
01.06.2020 21:59, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200601181118.579-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can

Re: [PATCH v4 2/2] vhost-user-blk: delay vhost_user_blk_disconnect

2020-06-02 Thread Dima Stepanov
On Sat, May 30, 2020 at 08:55:30PM -0400, Raphael Norwitz wrote: > On Thu, May 28, 2020 at 5:13 AM Dima Stepanov wrote: > > > > A socket write during vhost-user communication may trigger a disconnect > > event, calling vhost_user_blk_disconnect() and clearing all the > > vhost_dev structures

[PATCH] numa: forbid '-numa node, mem' for 5.1 and newer machine types

2020-06-02 Thread Igor Mammedov
Deprecation period is run out and it's a time to flip the switch introduced by cd5ff8333a. Disable legacy option for new machine types (since 5.1) and amend documentation. '-numa node,memdev' shall be used instead of disabled option with new machine types. Signed-off-by: Igor Mammedov --- -

[PATCH 0/2] mailmap: change email addresses of two contributors

2020-06-02 Thread Aleksandar Markovic
Two contributors want to switch to using their new email addresses. Aleksandar Markovic (2): mailmap: Change email address of Filip Bozuta mailmap: Change email address of Stefan Brankovic .mailmap | 2 ++ 1 file changed, 2 insertions(+) -- 2.20.1

[PATCH 1/2] mailmap: Change email address of Filip Bozuta

2020-06-02 Thread Aleksandar Markovic
Filip Buzuta wants to use his new email address for his future work in QEMU. CC: Filip Bozuta Signed-off-by: Aleksandar Markovic --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index e3628c7a66..9f2a3a55f9 100644 --- a/.mailmap +++ b/.mailmap @@ -45,6 +45,7

[PATCH 2/2] mailmap: Change email address of Stefan Brankovic

2020-06-02 Thread Aleksandar Markovic
Stefan Brankovic wants to use his new email address for his future work in QEMU. CC: Stefan Brankovic Signed-off-by: Aleksandar Markovic --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 9f2a3a55f9..84f36592ba 100644 --- a/.mailmap +++ b/.mailmap @@

Re: [PATCH v2 9/9] target/arm: Convert Neon one-register-and-immediate insns to decodetree

2020-06-02 Thread Peter Maydell
On Tue, 2 Jun 2020 at 00:32, Richard Henderson wrote: > It might be clearer to use dup_const for each case, which would more closely > match the pseudocode. E.g. here, > > return dup_const(MO_16, imm << 8); > > > +imm |= (imm << 8) | (imm << 16) | (imm << 24); > > return

[Bug 1881729] [NEW] target_read_memory in disas.c ignores possible errors

2020-06-02 Thread Nickie S.
Public bug reported: `target_read_memory` in `disas.c` ignores (possible) errors. This leads to disassembler possibly disassembling garbage. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which

Re: [PULL 00/12] migration/virtiofs/hmp queue

2020-06-02 Thread Peter Maydell
On Mon, 1 Jun 2020 at 19:43, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > The following changes since commit 7ea32024c6b3ad9c88d6200e73dbf76c8e160024: > > Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-june-01-2020' into staging (2020-06-01 >

Re: [PULL 04/12] hmp: Simplify qom-set

2020-06-02 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" writes: > > > From: "Dr. David Alan Gilbert" > > > > Simplify qom_set by making it use qmp_qom_set and the JSON parser. > > > > (qemu) qom-get /machine smm > > "auto" > > (qemu) qom-set /machine smm "auto" > > > >

Re: [RFC 5/6] bios-tables-test: Add Q35/TPM-TIS test

2020-06-02 Thread Stefan Berger
On 6/1/20 6:21 AM, Eric Auger wrote: Test tables specific to the TPM-TIS instantiation. The TPM2 is added in the framework. Also the DSDT is updated with the TPM. The new function should be be usable for CRB as well, later one. Signed-off-by: Eric Auger --- tests/qtest/bios-tables-test.c |

Re: [RFC 6/6] bios-tables-test: Generate reference tables for Q35/TPM-TIS

2020-06-02 Thread Stefan Berger
On 6/1/20 6:21 AM, Eric Auger wrote: TPM2, DSDT tables were generated using tests/data/acpi/rebuild-expected-aml.sh Signed-off-by: Eric Auger Reviewed-by: Stefan Berger --- tests/qtest/bios-tables-test-allowed-diff.h | 2 -- tests/data/acpi/q35/DSDT.tis| Bin 0 ->

Re: [PATCH] virtio-blk: Disable request queuing while switching contexts

2020-06-02 Thread Sergio Lopez
On Tue, Jun 02, 2020 at 03:04:33PM +0200, Kevin Wolf wrote: > Am 02.06.2020 um 14:18 hat Sergio Lopez geschrieben: > > On Tue, Jun 02, 2020 at 01:23:14PM +0200, Kevin Wolf wrote: > > > Am 02.06.2020 um 10:11 hat Sergio Lopez geschrieben: > > > > Disable request queuing while switching contexts on

Re: Sam460Ex screen mode, audio and network

2020-06-02 Thread BALATON Zoltan
On Tue, 2 Jun 2020, BALATON Zoltan wrote: On Tue, 2 Jun 2020, Philippe Mathieu-Daudé wrote: Cc'ing the sam460ex maintainer. On 6/1/20 8:01 PM, Andrea Palmatè wrote: It is working on an i5 laptop. I've tried to use the native screen mode 1366x768 but it has some problems. It seems a stride

[Bug 1881648] Re: `qemu-img info` reports an incorrect actual-size when the underlying posix filesystem has transparent compression

2020-06-02 Thread Max Reitz
But that’s the point of that field, to show the amount of space used by the image on the host. The man page documents it as: “disk size: How much space the image file occupies on the host file system (may be shown as 0 if this information is unavailable, e.g. because there is no file system)”,

Re: [PATCH] virtiofsd: Use clone() and not unshare(), support non-root

2020-06-02 Thread Stefan Hajnoczi
On Fri, May 01, 2020 at 02:25:48PM -0400, Colin Walters wrote: > I'd like to make use of virtiofs as part of our tooling in > https://github.com/coreos/coreos-assembler > Most of the code runs as non-root today; qemu also runs as non-root. > We use 9p right now. > > virtiofsd's builtin sandboxing

Re: [PATCH RFC 26/32] python//machine.py: use qmp.command

2020-06-02 Thread Kevin Wolf
Am 29.05.2020 um 02:18 hat John Snow geschrieben: > > [...] > > > > > -def qmp(self, cmd, conv_keys=True, **args): > > -""" > > -Invoke a QMP command and return the response dict > > -""" > > +@classmethod > > +def _qmp_args(cls, _conv_keys: bool = True,

Re: [question] Partial sector issue while discard in qcow2 image

2020-06-02 Thread Kevin Wolf
Am 02.06.2020 um 09:45 hat Lin Ma geschrieben: > Hi all, > > During woring to add GET LBA STATUS support in qemu scsi emulation > layer, I encountered an unmap issue with qcow2 image, It's likely > about how to unmap partial clusters. e.g.: > > With these default values: > * the default value

Re: [PATCH RFC 01/32] python/qemu: create qemu.lib module

2020-06-02 Thread Vladimir Sementsov-Ogievskiy
26.05.2020 18:07, Philippe Mathieu-Daudé wrote: On 5/19/20 12:54 PM, Vladimir Sementsov-Ogievskiy wrote: 19.05.2020 03:27, John Snow wrote: On 5/18/20 3:33 PM, Vladimir Sementsov-Ogievskiy wrote: 18.05.2020 21:23, John Snow wrote: On 5/18/20 2:14 PM, Vladimir Sementsov-Ogievskiy wrote:

what is the symbole "leul" mean on this code?

2020-06-02 Thread tugouxp
HI guys: i am stucked by the following code,and i can find document illustrations this nowhere. what does the "leul" stands for? and the postfix 10 means what? thank you! 10 6001 11 movi_i32 tmp3,$0x60010020pref=all 12

Re: [PATCH v4] linux-user: syscall: ioctls: support DRM_IOCTL_VERSION

2020-06-02 Thread Laurent Vivier
Le 02/06/2020 à 14:00, cheng...@emindsoft.com.cn a écrit : > From: Chen Gang > > Another DRM_IOCTL_* commands will be done later. > > Signed-off-by: Chen Gang > --- > configure | 10 ++ > linux-user/ioctls.h| 5 +++ > linux-user/syscall.c | 67

[PATCH] docs/system: Document Aspeed boards

2020-06-02 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- docs/system/arm/aspeed.rst | 85 ++ docs/system/target-arm.rst | 1 + 2 files changed, 86 insertions(+) create mode 100644 docs/system/arm/aspeed.rst diff --git a/docs/system/arm/aspeed.rst b/docs/system/arm/aspeed.rst

Re: [RFC 3/6] tests/acpi: Ignore TPM2.tis and DSDT.tis

2020-06-02 Thread Stefan Berger
On 6/1/20 6:21 AM, Eric Auger wrote: Subsequent patches will alter the content of TPM2.tis and DSDT.tis so let's ignore them until the references are generated. Signed-off-by: Eric Auger Reviewed-by: Stefan Berger --- tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ 1 file changed,

Re: [PATCH v3 1/4] acpi: Convert build_tpm2() to build_append* API

2020-06-02 Thread Stefan Berger
On 6/2/20 9:55 AM, Auger Eric wrote: Hi Stefan, On 6/2/20 3:30 PM, Stefan Berger wrote: On 6/1/20 5:57 AM, Eric Auger wrote: In preparation of its move to the generic acpi code, let's convert build_tpm2() to use build_append API. This latter now is prefered in place of direct ACPI struct field

Re: [PATCH 5/8] decodetree: Allow group covering the entire insn space

2020-06-02 Thread Peter Maydell
On Mon, 18 May 2020 at 17:41, Richard Henderson wrote: > > This is an edge case for sure, but the logic that disallowed > this case was faulty. Further, a few fixes scattered about > can allow this to work. > > Signed-off-by: Richard Henderson > --- > ...est1.decode =>

Re: [PATCH v4 00/13] user-mode: Prune build dependencies (part 1)

2020-06-02 Thread Philippe Mathieu-Daudé
This series is now fully reviewed. Laurent, as Paolo's misc-tree is already full, can it go via your linux-user tree (as it improve linux-user at the end)? Thanks, Phil. On 5/22/20 7:24 PM, Philippe Mathieu-Daudé wrote: > This is the first part of a series reducing user-mode > dependencies. By

[PULL 1/2] target/m68k: implement fmove.l #,FPCR

2020-06-02 Thread Laurent Vivier
The immediate value mode was ignored and instruction execution ends to an invalid access mode. This was found running 'R' that set FPSR to 0 at startup with a 'fmove.l #0,FPSR' in qemu-system-m68k emulation and triggers a kernel crash: [ 56.64] *** ADDRESS ERROR *** FORMAT=2 [

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2020-06-02 Thread Max Reitz
On 02.06.20 16:43, Vladimir Sementsov-Ogievskiy wrote: > 01.11.2019 18:25, Max Reitz wrote: > > Sorry for being late, I have some comments Uh, well. Reasonable, but I hope you don’t mind me having no longer having this patch fresh on my mind. >> The XFS kernel driver has a bug that may cause

[PATCH v1 5/9] cputlb: ensure we re-fill the TLB if it has reset

2020-06-02 Thread Alex Bennée
Any write to a device might cause a re-arrangement of memory triggering a TLB flush and potential re-size of the TLB invalidating previous entries. This would cause users of qemu_plugin_get_hwaddr() to see the warning: invalid use of qemu_plugin_get_hwaddr because of the failed tlb_lookup

Re: [RFC 4/6] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS

2020-06-02 Thread Stefan Berger
On 6/1/20 6:21 AM, Eric Auger wrote: While writing tests for checking the content of TPM2 and DSDT along with TPM-TIS instantiation I attempted to reuse the framework used for TPM-TIS tests. However While dumping the ACPI tables I get an assert on TPM2_ST_NO_SESSIONS. My assumption is maybe the

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2020-06-02 Thread Vladimir Sementsov-Ogievskiy
01.11.2019 18:25, Max Reitz wrote: Sorry for being late, I have some comments The XFS kernel driver has a bug that may cause data corruption for qcow2 images as of qemu commit c8bb23cbdbe32f. We can work around it by treating post-EOF fallocates as serializing up until infinity (INT64_MAX in

[PULL 0/2] M68k for 5.1 patches

2020-06-02 Thread Laurent Vivier
The following changes since commit 853a60b87024b2f5d7c0c54a432d7798cb679900: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20200601a' into staging (2020-06-01 21:34:47 +0100) are available in the Git repository at: git://github.com/vivier/qemu-m68k.git

[PULL 2/2] target/m68k: implement opcode fetoxm1

2020-06-02 Thread Laurent Vivier
Example provided in the launchpad bug fails with: qemu: uncaught target signal 4 (Illegal instruction) - core dumped Illegal instruction (core dumped) It appears fetoxm1 is not implemented: IN: expm1f 0x85cc: fetoxm1x %fp2,%fp0 Disassembler disagrees with translator over

Re: [PATCH v6 00/20] nvme: small fixes, refactoring and cleanups

2020-06-02 Thread Kevin Wolf
Am 14.05.2020 um 06:45 hat Klaus Jensen geschrieben: > From: Klaus Jensen > > Changes since v5 > > * Prefixed all patches with "hw/block/nvme" to avoid confusion with the > nvme block driver. > > * Added patch two patches: > > hw/block/nvme: fix pin-based interrupt

[PATCH v1 7/9] plugins: add API to return a name for a IO device

2020-06-02 Thread Alex Bennée
This may well end up being anonymous but it should always be unique. Signed-off-by: Alex Bennée --- include/qemu/qemu-plugin.h | 5 + plugins/api.c | 18 ++ 2 files changed, 23 insertions(+) diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h

[PATCH v1 6/9] hw/virtio/pci: include vdev name in registered PCI sections

2020-06-02 Thread Alex Bennée
When viewing/debugging memory regions it is sometimes hard to figure out which PCI device something belongs to. Make the names unique by including the vdev name in the name string. Signed-off-by: Alex Bennée --- hw/virtio/virtio-pci.c | 21 + 1 file changed, 13

[PATCH v1 3/9] scripts/clean-includes: Mark 'qemu/qemu-plugin.h' as special header

2020-06-02 Thread Alex Bennée
From: Philippe Mathieu-Daudé "qemu/qemu-plugin.h" isn't meant to be include by QEMU codebase, but by 3rd party plugins that QEMU can use. These plugins can be built out of QEMU and don't include "qemu/osdep.h". Mark "qemu/qemu-plugin.h" as a special header that doesn't need to be cleaned for

Re: [PATCH v1 6/9] hw/virtio/pci: include vdev name in registered PCI sections

2020-06-02 Thread Philippe Mathieu-Daudé
On 6/2/20 5:46 PM, Alex Bennée wrote: > When viewing/debugging memory regions it is sometimes hard to figure > out which PCI device something belongs to. Make the names unique by > including the vdev name in the name string. > > Signed-off-by: Alex Bennée > --- > hw/virtio/virtio-pci.c | 21

Re: [PATCH v3 0/2] fuzz: Skip QTest serialization

2020-06-02 Thread Alexander Bulekov
Thank you Darren. On 200602 1428, Darren Kenny wrote: > > Hi Alex, > > In general the series looks good, so: > > Reviewed-by: Darren Kenny > > But not sure how to handle the patchew output though, not sure if it is > really a concern or not, since do/while won't work that context. > Yes -

Re: [PATCH 0/5] Add strace support for printing arguments of selected syscalls

2020-06-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200602115331.1659-1-filip.boz...@syrmia.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200602115331.1659-1-filip.boz...@syrmia.com Subject: [PATCH 0/5] Add strace support for printing

Re: [RFC 4/6] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS

2020-06-02 Thread Stefan Berger
On 6/2/20 9:39 AM, Stefan Berger wrote: On 6/1/20 6:21 AM, Eric Auger wrote: While writing tests for checking the content of TPM2 and DSDT along with TPM-TIS instantiation I attempted to reuse the framework used for TPM-TIS tests. However While dumping the ACPI tables I get an assert on

Re: [PATCH] docs/system: Document Aspeed boards

2020-06-02 Thread Philippe Mathieu-Daudé
On 6/2/20 3:50 PM, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > docs/system/arm/aspeed.rst | 85 ++ > docs/system/target-arm.rst | 1 + > 2 files changed, 86 insertions(+) > create mode 100644 docs/system/arm/aspeed.rst > > diff --git

Re: [PATCH] .travis.yml: Temporarily disable the aarch64 job

2020-06-02 Thread Richard Henderson
On 6/2/20 8:36 AM, Philippe Mathieu-Daudé wrote: > Have you experienced problems with the s390x/powerpc jobs too? I have, just yesterday. r~

[PATCH v1 9/9] .travis.yml: allow failure for unreliable hosts

2020-06-02 Thread Alex Bennée
They will still run but they won't get in the way of the result. Signed-off-by: Alex Bennée --- .travis.yml | 5 + 1 file changed, 5 insertions(+) diff --git a/.travis.yml b/.travis.yml index 564be50a3c1..ec6367af1f0 100644 --- a/.travis.yml +++ b/.travis.yml @@ -429,6 +429,7 @@ jobs:

[PATCH] hw/block/nvme: Verify msix_vector_use() returned value

2020-06-02 Thread Philippe Mathieu-Daudé
msix_vector_use() returns -EINVAL on error. Assert it won't. Signed-off-by: Philippe Mathieu-Daudé --- Notes taken while reviewing: https://www.mail-archive.com/qemu-block@nongnu.org/msg66831.html Based-on: <20200514044611.734782-1-...@irrelevant.dk> --- hw/block/nvme.c | 5 - 1 file

Re: [PATCH v3 1/6] iotests: Add extension names to qcow2.py dump

2020-06-02 Thread Eric Blake
On 6/2/20 11:05 AM, Eric Blake wrote: [I hit send too soon...] +++ b/tests/qemu-iotests/qcow2.py @@ -6,19 +6,36 @@ import string   class QcowHeaderExtension: +    QCOW2_EXT_MAGIC_BACKING_FORMAT = 0xE2792ACA +    QCOW2_EXT_MAGIC_FEATURE_TABLE = 0x6803f857 Why the inconsistency between

Re: [PATCH v1 7/9] plugins: add API to return a name for a IO device

2020-06-02 Thread Clement Deschamps
On 6/2/20 5:46 PM, Alex Bennée wrote: This may well end up being anonymous but it should always be unique. Signed-off-by: Alex Bennée --- include/qemu/qemu-plugin.h | 5 + plugins/api.c | 18 ++ 2 files changed, 23 insertions(+) diff --git

Re: [PATCH v3 3/6] iotests: dump bitmap extension data with qcow2.py

2020-06-02 Thread Eric Blake
On 6/1/20 8:48 AM, Andrey Shinkevich wrote: Add bitmap header extension data, if any, to the dump in qcow2.py. Header extension: Bitmaps magic 0x23852875 length24 nb_bitmaps2 reserved320 bitmap_directory_size

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2020-06-02 Thread Vladimir Sementsov-Ogievskiy
02.06.2020 18:46, Max Reitz wrote: On 02.06.20 16:43, Vladimir Sementsov-Ogievskiy wrote: 01.11.2019 18:25, Max Reitz wrote: Sorry for being late, I have some comments Uh, well. Reasonable, but I hope you don’t mind me having no longer having this patch fresh on my mind. The XFS kernel

Re: [PATCH v4] linux-user: syscall: ioctls: support DRM_IOCTL_VERSION

2020-06-02 Thread Chen Gang
On 2020/6/2 下午9:40, Laurent Vivier wrote: >> +static inline abi_long target_to_host_drmversion(struct drm_version >> *host_ver, >> +abi_long target_addr) >> +{ >> +struct target_drm_version *target_ver; >> + >> +if

Re: [PATCH 2/8] decodetree: Tidy error_with_file

2020-06-02 Thread Peter Maydell
On Mon, 18 May 2020 at 17:40, Richard Henderson wrote: > > Use proper varargs to print the arguments. > > Signed-off-by: Richard Henderson > --- > scripts/decodetree.py | 24 ++-- > 1 file changed, 14 insertions(+), 10 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: RFC: use VFIO over a UNIX domain socket to implement device offloading

2020-06-02 Thread Alex Williamson
On Wed, 20 May 2020 17:45:13 -0700 John G Johnson wrote: > > I'm confused by VFIO_USER_ADD_MEMORY_REGION vs VFIO_USER_IOMMU_MAP_DMA. > > The former seems intended to provide the server with access to the > > entire GPA space, while the latter indicates an IOVA to GPA mapping of > > those

Re: [PATCH] .travis.yml: Temporarily disable the aarch64 job

2020-06-02 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Travis-CI Aarch64 runners are currently broken, the build fails > because the filesystem quota is full [1]: > > AR libqemuutil.a > nm: qemu-sockets.o: Bad value > LINKqemu-ga > qga/main.o: In function `main': >

Re: [PATCH] virtio-blk: Disable request queuing while switching contexts

2020-06-02 Thread Stefan Hajnoczi
On Tue, Jun 02, 2020 at 03:04:33PM +0200, Kevin Wolf wrote: > Am 02.06.2020 um 14:18 hat Sergio Lopez geschrieben: > > On Tue, Jun 02, 2020 at 01:23:14PM +0200, Kevin Wolf wrote: > > > Am 02.06.2020 um 10:11 hat Sergio Lopez geschrieben: > > > > Disable request queuing while switching contexts on

Re: [PATCH] .travis.yml: Temporarily disable the aarch64 job

2020-06-02 Thread Philippe Mathieu-Daudé
On 6/2/20 5:28 PM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> Travis-CI Aarch64 runners are currently broken, the build fails >> because the filesystem quota is full [1]: >> >> AR libqemuutil.a >> nm: qemu-sockets.o: Bad value >> LINKqemu-ga >> qga/main.o:

[PATCH v1 4/9] tests/plugin: correctly honour io_count

2020-06-02 Thread Alex Bennée
Signed-off-by: Alex Bennée --- tests/plugin/mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/plugin/mem.c b/tests/plugin/mem.c index 878abf09d19..4725bd851d8 100644 --- a/tests/plugin/mem.c +++ b/tests/plugin/mem.c @@ -28,7 +28,7 @@ static void

[PATCH v1 1/9] plugins: new lockstep plugin for debugging TCG changes

2020-06-02 Thread Alex Bennée
When we make changes to the TCG we sometimes cause regressions that are deep into the execution cycle of the guest. Debugging this often requires comparing large volumes of trace information to figure out where behaviour has diverged. The lockstep plugin utilises a shared socket so two QEMU's

[PATCH v1 0/9] plugins/next (bug fixes, hwprofile, lockstep)

2020-06-02 Thread Alex Bennée
Hi, This is the current state of my plugins tree. It has a few minor fixes to the headers as well as a bug I found in the cputlb which was triggered when a pci_config write via io_writex causes the memory regions to be reset and as a result a flush and potential re-sizing of the TLB entries. This

[PATCH v1 2/9] qemu-plugin.h: add missing include to define size_t

2020-06-02 Thread Alex Bennée
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20200524202427.951784-1-c...@braap.org> --- include/qemu/qemu-plugin.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/qemu/qemu-plugin.h

[PATCH v1 8/9] plugins: new hwprofile plugin

2020-06-02 Thread Alex Bennée
This is a plugin intended to help with profiling access to various bits of system hardware. It only really makes sense for system emulation. It takes advantage of the recently exposed helper API that allows us to see the device name (memory region name) associated with a device. Signed-off-by:

Re: [RFC 4/6] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS

2020-06-02 Thread Auger Eric
Hi Stefan, On 6/2/20 3:39 PM, Stefan Berger wrote: > On 6/1/20 6:21 AM, Eric Auger wrote: >> While writing tests for checking the content of TPM2 and DSDT >> along with TPM-TIS instantiation I attempted to reuse the >> framework used for TPM-TIS tests. However While dumping the >> ACPI tables I

Re: [PATCH v3 2/6] iotests: move check for printable data to QcowHeaderExtension class

2020-06-02 Thread Eric Blake
On 6/1/20 8:48 AM, Andrey Shinkevich wrote: Let us differ binary data type from string one for the extension data variable and keep the string as the QcowHeaderExtension class member in the script qcow2.py. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/qcow2.py | 15 ---

Re: [PATCH v3 1/4] acpi: Convert build_tpm2() to build_append* API

2020-06-02 Thread Auger Eric
Hi Stefan, On 6/2/20 3:30 PM, Stefan Berger wrote: > On 6/1/20 5:57 AM, Eric Auger wrote: >> In preparation of its move to the generic acpi code, >> let's convert build_tpm2() to use build_append API. This >> latter now is prefered in place of direct ACPI struct field >> settings with manual

Re: [RFC 2/6] tests/acpi: Add void tables for Q35/TPM-TIS bios-tables-test

2020-06-02 Thread Stefan Berger
On 6/1/20 6:21 AM, Eric Auger wrote: Add placeholders for TPM and DSDT reference tables for Q35 TPM-TIS tests. Signed-off-by: Eric Auger Reviewed-by: Stefan Berger --- tests/data/acpi/q35/DSDT.tis | Bin tests/data/acpi/q35/TPM2.tis | Bin 2 files changed, 0 insertions(+), 0

Re: [RFC 1/6] test/tpm-emu: include sockets and channel headers in tpm-emu header

2020-06-02 Thread Stefan Berger
On 6/1/20 6:21 AM, Eric Auger wrote: Include sockets and channel headers to that the header is self-contained. Signed-off-by: Eric Auger Reviewed-by: Stefan Berger --- tests/qtest/tpm-emu.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qtest/tpm-emu.h

Re: [PATCH v3 1/4] acpi: Convert build_tpm2() to build_append* API

2020-06-02 Thread Auger Eric
Hi Stefan, On 6/2/20 4:24 PM, Stefan Berger wrote: > On 6/2/20 9:55 AM, Auger Eric wrote: >> Hi Stefan, >> On 6/2/20 3:30 PM, Stefan Berger wrote: >>> On 6/1/20 5:57 AM, Eric Auger wrote: In preparation of its move to the generic acpi code, let's convert build_tpm2() to use build_append

Re: [PATCH 5/8] decodetree: Allow group covering the entire insn space

2020-06-02 Thread Richard Henderson
On 6/2/20 7:35 AM, Peter Maydell wrote: > On Mon, 18 May 2020 at 17:41, Richard Henderson > wrote: >> >> This is an edge case for sure, but the logic that disallowed >> this case was faulty. Further, a few fixes scattered about >> can allow this to work. >> >> Signed-off-by: Richard Henderson

Re: [PATCH v4 00/13] user-mode: Prune build dependencies (part 1)

2020-06-02 Thread Laurent Vivier
Le 02/06/2020 à 16:46, Philippe Mathieu-Daudé a écrit : > This series is now fully reviewed. > > Laurent, as Paolo's misc-tree is already full, can it go via your > linux-user tree (as it improve linux-user at the end)? OK, I add the series to my queue. I plan to do a linux-user PR soon.

Re: [PATCH v2] icount: make dma reads deterministic

2020-06-02 Thread Kevin Wolf
Am 30.04.2020 um 11:02 hat Pavel Dovgalyuk geschrieben: > From: Pavel Dovgalyuk > > Windows guest sometimes makes DMA requests with overlapping > target addresses. This leads to the following structure of iov for > the block driver: > > addr size1 > addr size2 > addr size3 > > It means that

Re: [PATCH v6 08/20] hw/block/nvme: allow use of any valid msix vector

2020-06-02 Thread Philippe Mathieu-Daudé
On 5/28/20 5:44 PM, Philippe Mathieu-Daudé wrote: > On 5/14/20 6:45 AM, Klaus Jensen wrote: >> From: Klaus Jensen >> >> If the device uses MSI-X, any of the 2048 MSI-X interrupt vectors are >> valid. If the device is not using MSI-X, vector will and can only be >> zero at this point. >> >> Cc:

Re: [PATCH v3 1/6] iotests: Add extension names to qcow2.py dump

2020-06-02 Thread Eric Blake
On 6/1/20 8:48 AM, Andrey Shinkevich wrote: Header extension: Feature table magic 0x6803f857 length192 data The change incurs modification of the output in 031, 036 and 061 test cases. Signed-off-by: Andrey Shinkevich ---

Re: [RFC 4/6] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS

2020-06-02 Thread Stefan Berger
On 6/2/20 12:13 PM, Auger Eric wrote: Hi Stefan, On 6/2/20 3:39 PM, Stefan Berger wrote: On 6/1/20 6:21 AM, Eric Auger wrote: While writing tests for checking the content of TPM2 and DSDT along with TPM-TIS instantiation I attempted to reuse the framework used for TPM-TIS tests. However While

Re: [PATCH RFC 01/32] python/qemu: create qemu.lib module

2020-06-02 Thread Kevin Wolf
Am 14.05.2020 um 07:53 hat John Snow geschrieben: > move python/qemu/*.py to python/qemu/lib/*.py. > > To create a namespace package, the 'qemu' directory itself shouldn't > have module files in it. Thus, these files will go under a 'lib' package > directory instead. > > Bolster the

[PATCH] .travis.yml: Temporarily disable the aarch64 job

2020-06-02 Thread Philippe Mathieu-Daudé
Travis-CI Aarch64 runners are currently broken, the build fails because the filesystem quota is full [1]: AR libqemuutil.a nm: qemu-sockets.o: Bad value LINKqemu-ga qga/main.o: In function `main': /home/travis/build/qemu/qemu/qga/main.c:1494: undefined reference to

Re: [PATCH v8 5/8] qdev-properties: make blocksize accept size suffixes

2020-06-02 Thread Philippe Mathieu-Daudé
On 5/29/20 12:55 AM, Roman Kagan wrote: > It appears convenient to be able to specify physical_block_size and > logical_block_size using common size suffixes. > > Teach the blocksize property setter to interpret them. Also express the > upper and lower limits in the respective units. > >

  1   2   3   4   >