Re: [PATCH v4 01/12] qcow2.py: python style fixes

2020-06-06 Thread Vladimir Sementsov-Ogievskiy
05.06.2020 22:43, Eric Blake wrote: On 6/4/20 12:41 PM, Vladimir Sementsov-Ogievskiy wrote: Fix flake8 complains. Leave the only chunk of lines over 79 characters: complaints initialization of cmds variable. Leave it for another day, when it should be refactored to utilize argparse instead

Re: [PATCH for-5.1 V4 3/4] hw/mips: Add Loongson-3 machine support (with KVM)

2020-06-06 Thread Aleksandar Markovic
уто, 2. јун 2020. у 04:40 Huacai Chen је написао/ла: > > Add Loongson-3 based machine support, it use i8259 as the interrupt > controler and use GPEX as the pci controller. Currently it can only > work with KVM, but we will add TCG support in future. > > We already have a full functional Linux

[PATCH] hw/misc/auxbus: Use qemu_log_mask(UNIMP) instead of debug printf

2020-06-06 Thread Philippe Mathieu-Daudé
Replace a deprecated DPRINTF() call by qemu_log_mask(LOG_UNIMP). Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/auxbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/auxbus.c b/hw/misc/auxbus.c index f8e7b97971..06aabf20c5 100644 --- a/hw/misc/auxbus.c +++

Re: [PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fields

2020-06-06 Thread Vladimir Sementsov-Ogievskiy
05.06.2020 23:16, Eric Blake wrote: On 6/4/20 12:41 PM, Vladimir Sementsov-Ogievskiy wrote: No need in lists: it's a constant variable. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   tests/qemu-iotests/qcow2_format.py | 40 +++---   1 file changed, 20 insertions(+),

Re: [PATCH v4 02/12] qcow2.py: move qcow2 format classes to separate module

2020-06-06 Thread Vladimir Sementsov-Ogievskiy
05.06.2020 23:14, Eric Blake wrote: On 6/4/20 12:41 PM, Vladimir Sementsov-Ogievskiy wrote: We are going to enhance qcow2 format parsing by adding more structure classes. Let's split format parsing from utility code. Signed-off-by: Vladimir Sementsov-Ogievskiy ---  

Re: [PATCH RFC v2 1/5] block: add bitmap-populate job

2020-06-06 Thread Vladimir Sementsov-Ogievskiy
05.06.2020 13:59, Peter Krempa wrote: On Fri, Jun 05, 2020 at 12:07:47 +0200, Kevin Wolf wrote: Am 05.06.2020 um 11:58 hat Peter Krempa geschrieben: On Fri, Jun 05, 2020 at 11:44:07 +0200, Kevin Wolf wrote: [...] The above was actually inspired by a very recent problem I have in my attempt

Re: [PATCH 1/1] target/ppc: add vmsumudm vmsumcud instructions

2020-06-06 Thread Richard Henderson
On 6/4/20 10:14 PM, Lijun Pan wrote: > +static void vmsumcudm(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b, > + ppc_avr_t *c, bool ca) > +{ > +#ifdef CONFIG_INT128 > + __uint128_t prod[2]; > + int i; > + > + for (i = 0; i < 2; i++) { > + prod[i] =

Re: [PATCH for-5.1 V4 2/4] target/mips: Add Loongson-3 CPU definition

2020-06-06 Thread Aleksandar Markovic
уто, 2. јун 2020. у 04:39 Huacai Chen је написао/ла: > > Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B > R1/R2. Loongson-3A R1 is the oldest and its ISA is the smallest, while > Loongson-3A R4 is the newest and its ISA is almost the superset of all > others. To reduce

[PATCH v5 07/13] qcow2_format.py: use strings to specify c-type of struct fields

2020-06-06 Thread Vladimir Sementsov-Ogievskiy
We are going to move field-parsing to super-class, this will be simpler with simple string specifiers instead of variables. For some reason, python doesn't allow the definition of ctypes variable in the class alongside fields: it would not be available then for use by the 'for' operator. Don't

[PATCH v5 12/13] qcow2: QcowHeaderExtension print names for extension magics

2020-06-06 Thread Vladimir Sementsov-Ogievskiy
Suggested-by: Andrey Shinkevich Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/031.out | 22 +++--- tests/qemu-iotests/036.out | 4 ++-- tests/qemu-iotests/061.out | 14 +++--- tests/qemu-iotests/qcow2_format.py | 17

[PATCH v5 11/13] qcow2_format: refactor QcowHeaderExtension as a subclass of Qcow2Struct

2020-06-06 Thread Vladimir Sementsov-Ogievskiy
Only two fields we can parse by generic code, but that is better than nothing. Keep further refactoring of variable-length fields for another day. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Shinkevich --- tests/qemu-iotests/qcow2_format.py | 53

Re: [RFC v2 00/18] Refactor configuration of guest memory protection

2020-06-06 Thread David Gibson
On Fri, Jun 05, 2020 at 12:55:05PM +0200, Cornelia Huck wrote: > On Thu, 21 May 2020 13:42:46 +1000 > David Gibson wrote: > > > A number of hardware platforms are implementing mechanisms whereby the > > hypervisor does not have unfettered access to guest memory, in order > > to mitigate the

Re: [RFC v2 00/18] Refactor configuration of guest memory protection

2020-06-06 Thread David Gibson
On Thu, Jun 04, 2020 at 11:08:21AM +0200, Greg Kurz wrote: > On Thu, 4 Jun 2020 16:44:14 +1000 > David Gibson wrote: > > > On Thu, Jun 04, 2020 at 01:39:22AM -0300, Thiago Jung Bauermann wrote: > > > > > > Hello David, > > > > > > David Gibson writes: > > > > > > > A number of hardware

[Bug 1659267] Re: It's not possible to start a VM with a network cable unplugged

2020-06-06 Thread timsoft
this would be really useful for testing resilliance and auto fall-over systems in a vm, to be able to quickly virtually "unplug" a network connection. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[PULL v2 01/19] linux-user, alpha: fix oldumount syscall

2020-06-06 Thread Laurent Vivier
When we try to bootstrap debian/lenny for alpha, it fails because it cannot umount /.root directory: ... Setting up initscripts (2.86.ds1-61) ... umount: /.root: Function not implemented dpkg: error processing initscripts (--configure): subprocess post-installation script returned

[PULL v2 11/19] util/Makefile: Reduce the user-mode object list

2020-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé These objects are not required when configured with --disable-system. Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Tested-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200522172510.25784-6-phi...@redhat.com> Signed-off-by:

[PULL v2 02/19] linux-user: return target error codes for socket() and prctl()

2020-06-06 Thread Laurent Vivier
From: Helge Deller Return target error codes instead of host error codes. Signed-off-by: Helge Deller Reviewed-by: Laurent Vivier Message-Id: <20200424220033.ga28...@ls3530.fritz.box> Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PULL v2 00/19] Linux user for 5.1 patches

2020-06-06 Thread Laurent Vivier
The following changes since commit ddc760832fa8cf5e93b9d9e6e854a5114ac63510: Merge remote-tracking branch 'remotes/gkurz/tags/9p-next-2020-05-26' into s= taging (2020-05-26 14:05:53 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git

[PULL v2 07/19] Makefile: Only build virtiofsd if system-mode is enabled

2020-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Do not build the virtiofsd helper when configured with --disable-system. Reviewed-by: Richard Henderson Acked-by: Dr. David Alan Gilbert Reviewed-by: Laurent Vivier Tested-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daudé Message-Id:

[PATCH v5 02/13] qcow2.py: add licensing blurb

2020-06-06 Thread Vladimir Sementsov-Ogievskiy
Add classic heading, which is missing here. Keep copyright place empty, for anyone who have added (or will add) some intellectual property here. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/qcow2.py | 16 1 file changed, 16 insertions(+) diff --git

[PATCH v5 03/13] qcow2.py: move qcow2 format classes to separate module

2020-06-06 Thread Vladimir Sementsov-Ogievskiy
We are going to enhance qcow2 format parsing by adding more structure classes. Let's split format parsing from utility code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/qcow2.py| 160 +- tests/qemu-iotests/qcow2_format.py | 173

[PATCH v5 04/13] qcow2_format.py: drop new line printing at end of dump()

2020-06-06 Thread Vladimir Sementsov-Ogievskiy
This will simplify further conversion. To compensate, print this empty line directly in cmd_dump_header(). Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Shinkevich --- tests/qemu-iotests/qcow2.py| 1 + tests/qemu-iotests/qcow2_format.py | 1 - 2 files changed, 1

[PATCH v5 09/13] qcow2_format.py: add field-formatting class

2020-06-06 Thread Vladimir Sementsov-Ogievskiy
Allow formatter class in structure definition instead of hacking with 'mask'. This will simplify further introduction of new formatters. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Shinkevich --- tests/qemu-iotests/qcow2_format.py | 35 +- 1 file

[PATCH v5 08/13] qcow2_format.py: separate generic functionality of structure classes

2020-06-06 Thread Vladimir Sementsov-Ogievskiy
We are going to introduce more Qcow2 structure types, defined like QcowHeader. Move generic functionality into base class to be reused for further structure classes. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Shinkevich --- tests/qemu-iotests/qcow2_format.py | 101

[PATCH v5 10/13] qcow2_format.py: QcowHeaderExtension: add dump method

2020-06-06 Thread Vladimir Sementsov-Ogievskiy
Obviously, for-loop body in dump_extensions should be the dump method of extension. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Shinkevich --- tests/qemu-iotests/qcow2_format.py | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git

Re: [PATCH] net: tulip: Set PCI revision to match dec21143

2020-06-06 Thread Marek Vasut
On 4/18/20 2:25 AM, Marek Vasut wrote: > The tulip driver claims to emulate dec21143 and it does not emulate dec21142. > The dec21142 and dec21143 can be discerned by the PCI revision register, > where dec21142 reports value < 0x20 and dec21143 value >= 0x20. E.g. the > U-Boot 'tulip' driver also

[PULL v2 03/19] linux-user: Add support for /proc/cpuinfo on hppa platform

2020-06-06 Thread Laurent Vivier
From: Helge Deller Provide our own /proc/cpuinfo file for the hppa (parisc) platform. Signed-off-by: Helge Deller Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id: <20200424210648.ga26...@ls3530.fritz.box> [lv: s/an/our/ and add TARGET_HPPA to guard is_proc()]

[PULL v2 02/19] linux-user: return target error codes for socket() and prctl()

2020-06-06 Thread Laurent Vivier
From: Helge Deller Return target error codes instead of host error codes. Signed-off-by: Helge Deller Reviewed-by: Laurent Vivier Message-Id: <20200424220033.ga28...@ls3530.fritz.box> Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PULL v2 00/19] Linux user for 5.1 patches

2020-06-06 Thread Laurent Vivier
The following changes since commit ddc760832fa8cf5e93b9d9e6e854a5114ac63510: Merge remote-tracking branch 'remotes/gkurz/tags/9p-next-2020-05-26' into s= taging (2020-05-26 14:05:53 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git

[PATCH v5 05/13] qcow2_format.py: use tuples instead of lists for fields

2020-06-06 Thread Vladimir Sementsov-Ogievskiy
No need in lists: it's a constant variable. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Shinkevich --- tests/qemu-iotests/qcow2_format.py | 40 +++--- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/tests/qemu-iotests/qcow2_format.py

[PATCH v5 01/13] qcow2.py: python style fixes

2020-06-06 Thread Vladimir Sementsov-Ogievskiy
Fix flake8 complaints. Leave the only chunk of lines over 79 characters: initialization of cmds variable. Leave it for another day, when it should be refactored to utilize argparse instead of hand-written parsing. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/qcow2.py | 95

[PATCH v5 06/13] qcow2_format.py: use modern string formatting

2020-06-06 Thread Vladimir Sementsov-Ogievskiy
Use .format and f-strings instead of old %style. Also, the file uses both '' and "" quotes, for consistency let's use '', except for cases when we need '' inside the string (use "" to avoid extra escaping). Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Shinkevich ---

[PULL v2 10/19] tests/Makefile: Restrict some softmmu-only tests

2020-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé In the next commit we are going to remove some objects from the util-obj-y variable (objects which are not used by user-mode, when configured with --disable-system). Then some system-mode tests are going to fail, due to the missing objects: $ make check-unit -k

[PULL v2 14/19] exec: Assert CPU migration is not used on user-only build

2020-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Reviewed-by: Laurent Vivier Tested-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200522172510.25784-9-phi...@redhat.com> Signed-off-by: Laurent Vivier --- exec.c | 4 +++- 1

[PULL v2 15/19] arch_init: Remove unused 'qapi-commands-misc.h' include

2020-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Commit ffaee83bcb2 moved qmp_query_target but forgot to remove this include. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Tested-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daudé Message-Id:

[PULL v2 04/19] linux-user/strace.list: fix epoll_create{, 1} -strace output

2020-06-06 Thread Laurent Vivier
From: Sergei Trofimovich Fix syscall name and parameters priinter. Before the change: ``` $ alpha-linux-user/qemu-alpha -strace -L /usr/alpha-unknown-linux-gnu/ /tmp/a ... 1274697 %s(%d)(2097152,274903156744,274903156760,274905840712,274877908880,274903235616) = 3 1274697 exit_group(0) ```

[PULL v2 05/19] linux-user/mmap.c: fix integer underflow in target_mremap

2020-06-06 Thread Laurent Vivier
From: Jonathan Marler Fixes: https://bugs.launchpad.net/bugs/1876373 This code path in mmap occurs when a page size is decreased with mremap. When a section of pages is shrunk, qemu calls mmap_reserve on the pages that were released. However, it has the diff operation reversed, subtracting

[PULL v2 06/19] linux-user: implement OFD locks

2020-06-06 Thread Laurent Vivier
From: Andreas Schwab Signed-off-by: Andreas Schwab Reviewed-by: Laurent Vivier Message-Id: Signed-off-by: Laurent Vivier --- linux-user/generic/fcntl.h | 4 linux-user/syscall.c | 6 ++ 2 files changed, 10 insertions(+) diff --git a/linux-user/generic/fcntl.h

Re: [PULL v2 00/19] Linux user for 5.1 patches

2020-06-06 Thread Laurent Vivier
Le 06/06/2020 à 15:14, Laurent Vivier a écrit : > The following changes since commit ddc760832fa8cf5e93b9d9e6e854a5114ac63510: > > Merge remote-tracking branch 'remotes/gkurz/tags/9p-next-2020-05-26' into s= > taging (2020-05-26 14:05:53 +0100) > > are available in the Git repository at: > >

Re: [PATCH for-5.1 V4 3/4] hw/mips: Add Loongson-3 machine support (with KVM)

2020-06-06 Thread Aleksandar Markovic
суб, 6. јун 2020. у 09:32 Aleksandar Markovic је написао/ла: > > уто, 2. јун 2020. у 04:40 Huacai Chen је написао/ла: > > > > Add Loongson-3 based machine support, it use i8259 as the interrupt > > controler and use GPEX as the pci controller. Currently it can only > > work with KVM, but we will

[PATCH v5 13/13] qcow2_format.py: dump bitmaps header extension

2020-06-06 Thread Vladimir Sementsov-Ogievskiy
Add class for bitmap extension and dump its fields. Further work is to dump bitmap directory. Test new functionality inside 291 iotest. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Shinkevich --- tests/qemu-iotests/291 | 4 +++ tests/qemu-iotests/291.out

[PATCH v5 00/13] iotests: Dump QCOW2 dirty bitmaps metadata

2020-06-06 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is my suggestion to substitute only first three patches :) of Andrey's [PATCH v3 0/6] iotests: Dump QCOW2 dirty bitmaps metadata v5: 01: - typo in commit message - fix over-79 lines 02: new, specify GPL license 03: specify GPL license 04-06: add Andrey's r-b 07: - grammar in

gitlab-ci: Do not use the standard container images from gitlab

2020-06-06 Thread Sam Eiderman
Hi, I am using debian 10 container to compile qemu too. I think that what happens here is that /usr/include/linux/swab.h Uses BITS_PER_LONG instead of __BITS_PER_LONG which is actually defined before in qemu at: include/qemu/bitops.h:#define BITS_PER_LONG (sizeof (unsigned

Re: gitlab-ci: Do not use the standard container images from gitlab

2020-06-06 Thread Alex Bennée
Sam Eiderman writes: > Hi, > > I am using debian 10 container to compile qemu too. > > I think that what happens here is that > > /usr/include/linux/swab.h > > Uses BITS_PER_LONG instead of __BITS_PER_LONG which is actually defined before > in qemu at: That is indeed the error - we are just

[PULL v2 17/19] target/s390x: Restrict CpuClass::get_crash_info() to system-mode

2020-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Cornelia Huck Reviewed-by: Laurent Vivier Tested-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200522172510.25784-12-phi...@redhat.com> Signed-off-by: Laurent Vivier --- target/s390x/cpu.c |

[PULL v2 19/19] stubs: Restrict ui/win32-kbd-hook to system-mode

2020-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé In Makefile.objs, the ui/ directory is restricted to system-mode: 43 ifeq ($(CONFIG_SOFTMMU),y) ... 65 common-obj-y += ui/ 66 common-obj-m += ui/ ... 82 endif # CONFIG_SOFTMMU Restrict the ui/ stub added in commit 2df9f5718df to only build it for system-mode

[PULL v2 08/19] configure: Avoid building TCG when not needed

2020-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Avoid building TCG when building only tools: ./configure --enable-tools --disable-system --disable-user This saves us from running the soft-float tests enabled since commit 76170102508. Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Reviewed-by:

[PULL v2 18/19] hw/core: Restrict CpuClass::get_crash_info() to system-mode

2020-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Tested-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200522172510.25784-13-phi...@redhat.com> Signed-off-by: Laurent Vivier --- hw/core/cpu.c | 2 ++

Re: [RFC v2 00/18] Refactor configuration of guest memory protection

2020-06-06 Thread David Gibson
On Fri, Jun 05, 2020 at 05:01:07PM -0300, Thiago Jung Bauermann wrote: > > Paolo Bonzini writes: > > > On 05/06/20 01:30, Thiago Jung Bauermann wrote: > >> Paolo Bonzini writes: > >>> On 04/06/20 23:54, Thiago Jung Bauermann wrote: > QEMU could always create a PEF object, and if the

[PATCH v2] Implement configurable descriptor size in ftgmac100

2020-06-06 Thread Erik Smit
The hardware supports configurable descriptor sizes, configured in the DBLAC register. Most drivers use the default 4 word descriptor, which is currently hardcoded, but Aspeed SDK configures 8 words to store extra data. --- The implementation of the driver in Supermicro BMC SMT_X11_158 adds 4

Re: gitlab-ci: Do not use the standard container images from gitlab

2020-06-06 Thread Sam Eiderman
Thanks for the link I do believe that the correct approach for me is to rename BITS_PER_LONG to __BITS_PER_LONG (I just added a sed command in my Dockerfile) and move on with my particular usage, however I am just wondering whether dropping debian10/ubuntu20 in the official qemu ci/ pipeline

[PULL v2 09/19] tests/Makefile: Only display TCG-related tests when TCG is available

2020-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Tested-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200522172510.25784-4-phi...@redhat.com> Signed-off-by: Laurent Vivier ---

[PULL v2 13/19] target/riscv/cpu: Restrict CPU migration to system-mode

2020-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Tested-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200522172510.25784-8-phi...@redhat.com> Signed-off-by: Laurent Vivier --- target/riscv/cpu.c

[Bug 1882350] [NEW] it always create sdx device when I configure ide device with hdx name

2020-06-06 Thread marshell
Public bug reported: I have configured 2 ide disks with name starting with hd, but when the vm boots up, it shows disks whose name starting with sd. 1. ide disks in vm xml: 2. in VM: sda8:002G 0 disk sdb

[PULL v2 01/19] linux-user, alpha: fix oldumount syscall

2020-06-06 Thread Laurent Vivier
When we try to bootstrap debian/lenny for alpha, it fails because it cannot umount /.root directory: ... Setting up initscripts (2.86.ds1-61) ... umount: /.root: Function not implemented dpkg: error processing initscripts (--configure): subprocess post-installation script returned

[PULL v2 12/19] stubs/Makefile: Reduce the user-mode object list

2020-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé These stubs are not required when configured with --disable-system. Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Tested-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200522172510.25784-7-phi...@redhat.com> Signed-off-by:

[PULL v2 03/19] linux-user: Add support for /proc/cpuinfo on hppa platform

2020-06-06 Thread Laurent Vivier
From: Helge Deller Provide our own /proc/cpuinfo file for the hppa (parisc) platform. Signed-off-by: Helge Deller Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id: <20200424210648.ga26...@ls3530.fritz.box> [lv: s/an/our/ and add TARGET_HPPA to guard is_proc()]

[PULL v2 16/19] target/i386: Restrict CpuClass::get_crash_info() to system-mode

2020-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Tested-by: Laurent Vivier Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200522172510.25784-11-phi...@redhat.com> Signed-off-by: Laurent Vivier --- target/i386/cpu.c | 6 +- 1 file changed, 5

Re: [PATCH] hw/misc/auxbus: Use qemu_log_mask(UNIMP) instead of debug printf

2020-06-06 Thread Richard Henderson
On 6/6/20 12:02 AM, Philippe Mathieu-Daudé wrote: > Replace a deprecated DPRINTF() call by qemu_log_mask(LOG_UNIMP). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/misc/auxbus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 0/5] colo: Introduce resource agent and test suite/CI

2020-06-06 Thread Lukas Straub
On Mon, 18 May 2020 09:38:24 + "Zhang, Chen" wrote: > > -Original Message- > > From: Lukas Straub > > Sent: Monday, May 11, 2020 8:27 PM > > To: qemu-devel > > Cc: Alberto Garcia ; Dr. David Alan Gilbert > > ; Zhang, Chen > > Subject: [PATCH 0/5] colo: Introduce resource agent and

Re: [PATCH 5/7] softfloat: return low bits of quotient from floatx80_modrem

2020-06-06 Thread Richard Henderson
On 6/5/20 12:01 PM, Joseph Myers wrote: > Both x87 and m68k need the low parts of the quotient for their > remainder operations. Arrange for floatx80_modrem to track those bits > and return them via a pointer. > > The architectures using float32_rem and float64_rem do not appear to > need this

[PATCH 2/4] sm501: Drop unneded variable

2020-06-06 Thread BALATON Zoltan
We don't need a separate variable to keep track if we allocated memory that needs to be freed as we can test the pointer itself. Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c

[PATCH 1/4] sm501: Fix bounds checks

2020-06-06 Thread BALATON Zoltan
We don't need to add width to pitch when calculating last point, that would reject valid ops within the card's local_mem. Fixes: b15a22bbcbe6a78dc3d88fe3134985e4cdd87de4 Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

Re: [PATCH V2 1/2] migration/colo: Optimize COLO boot code path

2020-06-06 Thread Lukas Straub
On Thu, 4 Jun 2020 16:55:32 +0800 Zhang Chen wrote: > From: Zhang Chen > > No need to reuse MIGRATION_STATUS_ACTIVE boot COLO. > > Signed-off-by: Zhang Chen > Reviewed-by: zhanghailiang > --- > migration/colo.c | 2 -- > migration/migration.c | 17 ++--- > 2 files

[PATCH] MAINTAINERS: Fix the classification of bios-tables-test-allowed-diff.h

2020-06-06 Thread Thomas Huth
The file tests/qtest/bios-tables-test-allowed-diff.h is currently only assigned to the qtest section according MAINTAINERS. However, this file normally only gets updated when the ACPI tables changed - something the qtest maintainers don't have much clue of. Thus this file should rather be assigned

Re: [PATCH for-5.1 V4 3/4] hw/mips: Add Loongson-3 machine support (with KVM)

2020-06-06 Thread chen huacai
On Sat, Jun 6, 2020 at 4:01 AM Aleksandar Markovic wrote: > > суб, 6. јун 2020. у 09:32 Aleksandar Markovic > је написао/ла: > > > > уто, 2. јун 2020. у 04:40 Huacai Chen је написао/ла: > > > > > > Add Loongson-3 based machine support, it use i8259 as the interrupt > > > controler and use GPEX

Re: [RFC v2 18/18] guest memory protection: Alter virtio default properties for protected guests

2020-06-06 Thread David Gibson
On Sat, Jun 06, 2020 at 04:21:31PM -0400, Michael S. Tsirkin wrote: > On Thu, May 21, 2020 at 01:43:04PM +1000, David Gibson wrote: > > The default behaviour for virtio devices is not to use the platforms normal > > DMA paths, but instead to use the fact that it's running in a hypervisor > > to

Re: gitlab-ci: Do not use the standard container images from gitlab

2020-06-06 Thread Thomas Huth
On 06/06/2020 14.38, Sam Eiderman wrote: > Thanks for the link > > I do believe that the correct approach for me is to rename > BITS_PER_LONG to __BITS_PER_LONG (I just added a sed command in my > Dockerfile) and move on with my particular usage, however I am just > wondering whether dropping

Re: [PATCH 2/7] softfloat: fix floatx80 remainder pseudo-denormal check for zero

2020-06-06 Thread Richard Henderson
On 6/5/20 12:00 PM, Joseph Myers wrote: > The floatx80 remainder implementation ignores the high bit of the > significand when checking whether an operand (numerator) with zero > exponent is zero. This means it mishandles a pseudo-denormal > representation of 0x1p-16382L by treating it as zero.

Re: [PATCH 3/7] softfloat: do not return pseudo-denormal from floatx80 remainder

2020-06-06 Thread Richard Henderson
On 6/5/20 12:00 PM, Joseph Myers wrote: > The floatx80 remainder implementation sometimes returns the numerator > unchanged when the denominator is sufficiently larger than the > numerator. But if the value to be returned unchanged is a > pseudo-denormal, that is incorrect. Fix it to normalize

[PATCH v2 2/7] avocado_qemu: Introduce pick_qemu_util to pick qemu utility binaries

2020-06-06 Thread Lukas Straub
This introduces a generic function to pick qemu utility binaries from the build dir, system or via test parameter. Signed-off-by: Lukas Straub --- tests/acceptance/avocado_qemu/__init__.py | 15 +++ 1 file changed, 15 insertions(+) diff --git

[PATCH v2 1/7] block/quorum.c: stable children names

2020-06-06 Thread Lukas Straub
If we remove the child with the highest index from the quorum, decrement s->next_child_index. This way we get stable children names as long as we only remove the last child. Signed-off-by: Lukas Straub Fixes: https://bugs.launchpad.net/bugs/1881231 Reviewed-by: Zhang Chen Reviewed-by: Alberto

Re: [PATCH v4 0/4] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-06-06 Thread Lukas Straub
On Mon, 25 May 2020 17:44:12 +0200 Lukas Straub wrote: > Hello Everyone, > In many cases, if qemu has a network connection (qmp, migration, chardev, > etc.) > to some other server and that server dies or hangs, qemu hangs too. > These patches introduce the new 'yank' out-of-band qmp command to

[PATCH v2 7/7] MAINTAINERS: Add myself as maintainer for COLO resource agent

2020-06-06 Thread Lukas Straub
While I'm not going to have much time for this, I'll still try to test and review patches. Signed-off-by: Lukas Straub --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8cbc1fac2b..4c623a96e1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

Re: [PATCH V2 2/2] migration/colo: Update checkpoint time lately

2020-06-06 Thread Lukas Straub
On Thu, 4 Jun 2020 16:55:33 +0800 Zhang Chen wrote: > From: Zhang Chen > > Previous operation(like vm_start and replication_start_all) will consume > extra time for first forced synchronization, so reduce it in this patch. > > Signed-off-by: Zhang Chen > Reviewed-by: zhanghailiang > ---

Re: [PATCH 1/7] softfloat: merge floatx80_mod and floatx80_rem

2020-06-06 Thread Richard Henderson
On 6/5/20 11:59 AM, Joseph Myers wrote: > The m68k-specific softfloat code includes a function floatx80_mod that > is extremely similar to floatx80_rem, but computing the remainder > based on truncating the quotient toward zero rather than rounding it > to nearest integer. This is also useful for

[PATCH v2 0/7] colo: Introduce resource agent and test suite/CI

2020-06-06 Thread Lukas Straub
Hello Everyone, So here is v2. Patch 1 can already be merged independently of the others. Regards, Lukas Straub Changes: v2: -use new yank api -drop disk_size parameter -introduce pick_qemu_util function and use it Overview: Hello Everyone, These patches introduce a resource agent for fully

Re: [PATCH 6/7] target/i386: reimplement fprem1 using floatx80 operations

2020-06-06 Thread Richard Henderson
On 6/5/20 12:02 PM, Joseph Myers wrote: > The x87 fprem1 emulation is currently based around conversion to > double, which is inherently unsuitable for a good emulation of any > floatx80 operation. Reimplement using the soft-float floatx80 > remainder operations. > > Signed-off-by: Joseph Myers

[PATCH v2 4/7] colo: Introduce resource agent

2020-06-06 Thread Lukas Straub
Introduce a resource agent which can be used to manage qemu COLO in a pacemaker cluster. Signed-off-by: Lukas Straub --- scripts/colo-resource-agent/colo | 1466 ++ 1 file changed, 1466 insertions(+) create mode 100755 scripts/colo-resource-agent/colo diff --git

[PATCH 3/4] sm501: Ignore no-op blits

2020-06-06 Thread BALATON Zoltan
Some guests seem to try source copy blits with same source and dest which are no-op so avoid calling pixman for these. Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index

[PATCH v2 3/7] boot_linux.py: Use pick_qemu_util

2020-06-06 Thread Lukas Straub
Replace duplicate code with pick_qemu_util. Signed-off-by: Lukas Straub --- tests/acceptance/boot_linux.py | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/tests/acceptance/boot_linux.py b/tests/acceptance/boot_linux.py index 075a386300..6b99112cad 100644 ---

[PATCH v2 5/7] colo: Introduce high-level test suite

2020-06-06 Thread Lukas Straub
Add high-level test relying on the colo resource-agent to test all failover cases while checking guest network connectivity. Signed-off-by: Lukas Straub --- scripts/colo-resource-agent/crm_master | 44 ++ scripts/colo-resource-agent/crm_resource | 12 + tests/acceptance/colo.py

Re: [RFC v2 18/18] guest memory protection: Alter virtio default properties for protected guests

2020-06-06 Thread Michael S. Tsirkin
On Thu, May 21, 2020 at 01:43:04PM +1000, David Gibson wrote: > The default behaviour for virtio devices is not to use the platforms normal > DMA paths, but instead to use the fact that it's running in a hypervisor > to directly access guest memory. That doesn't work if the guest's memory > is

Re: [PULL v2 00/19] Linux user for 5.1 patches

2020-06-06 Thread Aleksandar Markovic
суб, 6. јун 2020. у 15:24 Laurent Vivier је написао/ла: > > Le 06/06/2020 à 15:14, Laurent Vivier a écrit : > > The following changes since commit ddc760832fa8cf5e93b9d9e6e854a5114ac63510: > > > > Merge remote-tracking branch 'remotes/gkurz/tags/9p-next-2020-05-26' into > > s= > > taging

Re: [PATCH 4/7] softfloat: do not set denominator high bit for floatx80 remainder

2020-06-06 Thread Richard Henderson
On 6/5/20 12:01 PM, Joseph Myers wrote: > The floatx80 remainder implementation unnecessarily sets the high bit > of bSig explicitly. By that point in the function, arguments that are > invalid, zero, infinity or NaN have already been handled and > subnormals have been through

[PATCH 4/4] sm501: Optimise 1 pixel 2d ops

2020-06-06 Thread BALATON Zoltan
Some guests do 1x1 blits which is faster to do directly than calling a function for it so avoid overhead in this case. Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 40 +--- 1 file changed, 37 insertions(+), 3 deletions(-) diff --git

[PATCH v2 6/7] configure,Makefile: Install colo resource-agent

2020-06-06 Thread Lukas Straub
Optionally install the resouce-agent so it gets picked up by pacemaker. Signed-off-by: Lukas Straub --- Makefile | 5 + configure | 10 ++ 2 files changed, 15 insertions(+) diff --git a/Makefile b/Makefile index 8a9113e666..2ebffc4465 100644 --- a/Makefile +++ b/Makefile @@

[PATCH 0/4] More sm501 fixes and optimisations

2020-06-06 Thread BALATON Zoltan
Some small fixes and optimisations for hw/display/sm501.c. BALATON Zoltan (4): sm501: Fix bounds checks sm501: Drop unneded variable sm501: Ignore no-op blits sm501: Optimise 1 pixel 2d ops hw/display/sm501.c | 58 ++ 1 file changed, 48

Re: [PATCH v3 08/20] migration/colo: Use ram_block_discard_disable()

2020-06-06 Thread Lukas Straub
On Wed, 3 Jun 2020 16:49:02 +0200 David Hildenbrand wrote: > COLO will copy all memory in a RAM block, disable discarding of RAM. > > Reviewed-by: Dr. David Alan Gilbert > Cc: "Michael S. Tsirkin" > Cc: Hailiang Zhang > Cc: Juan Quintela > Cc: "Dr. David Alan Gilbert" > Signed-off-by: