[PATCH V6 4/4] MAINTAINERS: Add Loongson-3 maintainer and reviewer

2020-06-24 Thread Huacai Chen
Add myself as a maintainer of Loongson-3 virtual platform, and also add Jiaxun Yang as a reviewer. Signed-off-by: Huacai Chen Co-developed-by: Jiaxun Yang --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 51a4570..0226a74 100644 ---

[PULL 24/31] target/i386: Add notes for versioned CPU models

2020-06-24 Thread Paolo Bonzini
From: Tao Xu Add which features are added or removed in this version. Signed-off-by: Tao Xu Message-Id: <20200324051034.30541-1-tao3...@intel.com> Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c

[PULL 19/31] softfloat: return low bits of quotient from floatx80_modrem

2020-06-24 Thread Paolo Bonzini
From: Joseph Myers Both x87 and m68k need the low parts of the quotient for their remainder operations. Arrange for floatx80_modrem to track those bits and return them via a pointer. The architectures using float32_rem and float64_rem do not appear to need this information, so the *_rem

Re: [PATCH v5 00/12] pc-bios: s390x: Cleanup part 1

2020-06-24 Thread Janosch Frank
On 6/24/20 12:46 PM, Thomas Huth wrote: > On 24/06/2020 12.44, Cornelia Huck wrote: >> On Wed, 24 Jun 2020 03:52:14 -0400 >> Janosch Frank wrote: >> >>> The bios is in dire need for a cleanup as there are still a lot of >>> magic constants being used throughout as well as duplicated code. >>> >>>

[PATCH] hw/core/null-machine: Do not initialize unused chardev backends

2020-06-24 Thread Philippe Mathieu-Daudé
The MachineClass uses an inverted logic (inherited from the PC machines [*]) to create the chardev backends for the default devices (see commits 998bbd74b9d..aa40fc9c964 and ac33f8fad14). As the none-machine doesn't have any hardware device, it is pointless to initialize chardev backends. Fix by

[PULL 26/31] numa: forbid '-numa node, mem' for 5.1 and newer machine types

2020-06-24 Thread Paolo Bonzini
From: Igor Mammedov Deprecation period is run out and it's a time to flip the switch introduced by cd5ff8333a. Disable legacy option for new machine types (since 5.1) and amend documentation. '-numa node,memdev' shall be used instead of disabled option with new machine types. Signed-off-by:

[PATCH v4 01/20] stubs: add isa_create_simple

2020-06-24 Thread Gerd Hoffmann
Needed for -soundhw cleanup. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- stubs/isa-bus.c | 7 +++ stubs/Makefile.objs | 1 + 2 files changed, 8 insertions(+) create mode 100644 stubs/isa-bus.c diff --git a/stubs/isa-bus.c

[PATCH v4 08/20] audio: deprecate -soundhw gus

2020-06-24 Thread Gerd Hoffmann
Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Signed-off-by: Gerd Hoffmann --- hw/audio/gus.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/audio/gus.c b/hw/audio/gus.c index c8df2bde6b32..7e4a8cadad6f 100644 --- a/hw/audio/gus.c

[PATCH v4 05/20] audio: deprecate -soundhw es1370

2020-06-24 Thread Gerd Hoffmann
Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Add an alias so both es1370 and ES1370 are working with -device. Signed-off-by: Gerd Hoffmann --- hw/audio/es1370.c | 9 ++--- qdev-monitor.c| 1 + 2 files changed, 3 insertions(+), 7 deletions(-) diff

Re: [PATCH] xen: Fix xen-legacy-backend qdev types

2020-06-24 Thread Jason Andryuk
On Wed, Jun 24, 2020 at 8:30 AM Paul Durrant wrote: > > > -Original Message- > > From: Jason Andryuk > > Sent: 24 June 2020 13:20 > > To: Stefano Stabellini ; Anthony Perard > > ; Paul > > Durrant ; xen-de...@lists.xenproject.org > > Cc: Jason Andryuk ; qemu-devel@nongnu.org > >

[PATCH v5 01/10] module: qom module support

2020-06-24 Thread Gerd Hoffmann
Add support for qom types provided by modules. For starters use a manually maintained list which maps qom type to module and prefix. Two load functions are added: One to load the module for a specific type, and one to load all modules (needed for object/device lists as printed by -- for example

[PATCH v5 00/10] build some devices as modules.

2020-06-24 Thread Gerd Hoffmann
Specifically devices which depend on shared libraries, to reduce the runtime dependencies of core qemu. v2: - better commit messages. - add some more devices. - general tidy up. v3: - rebase, solve stubs conflict. - fix -vga $name - fix -device $name,help v4: - rebase to latest master -

Re: [PULL 25/31] osdep: Make MIN/MAX evaluate arguments only once

2020-06-24 Thread Philippe Mathieu-Daudé
On 6/24/20 2:13 PM, Eric Blake wrote: > On 6/24/20 5:50 AM, Paolo Bonzini wrote: >> From: Eric Blake >> >> I'm not aware of any immediate bugs in qemu where a second runtime >> evalution of the arguments to MIN() or MAX() causes a problem, but > > evaluation > >> Update the MIN/MAX macros to

[PATCH v5 0/5] VIRTIO-IOMMU probe request support and MSI bypass on ARM

2020-06-24 Thread Eric Auger
By default the virtio-iommu translates MSI transactions. This behavior is inherited from ARM SMMU. However the virt machine code knows where the MSI doorbells are, so we can easily declare those regions as VIRTIO_IOMMU_RESV_MEM_T_MSI. With that setting the guest iommu subsystem will not need to

[PATCH v5 3/5] virtio-iommu: Handle reserved regions in the translation process

2020-06-24 Thread Eric Auger
When translating an address we need to check if it belongs to a reserved virtual address range. If it does, there are 2 cases: - it belongs to a RESERVED region: the guest should neither use this address in a MAP not instruct the end-point to DMA on them. We report an error - It belongs to

Migration vmdesc and xen-save-devices-state

2020-06-24 Thread Jason Andryuk
Hi, At some point, QEMU changed to add a json VM description (vmdesc) after the migration data. The vmdesc is not needed to restore the migration data, but qemu_loadvm_state() will read and discard the vmdesc to clear the stream when should_send_vmdesc() is true. xen-save-devices-state

[PATCH v2 01/25] iotests: Fix 051 output after qdev_init_nofail() removal

2020-06-24 Thread Alex Bennée
From: Philippe Mathieu-Daudé Commit 96927c744 replaced qdev_init_nofail() call by isa_realize_and_unref() which has a different error message. Update the test output accordingly. Gitlab CI error after merging b77b5b3dc7: https://gitlab.com/qemu-project/qemu/-/jobs/597414772#L4375 Reported-by:

[PATCH v2 02/25] crypto/linux_keyring: fix 'secret_keyring' configure test

2020-06-24 Thread Alex Bennée
From: David Edmondson The configure test for 'secret_keyring' incorrectly checked the 'have_keyring' variable. Fixes: 54e7aac0562452e4fcab65ca5001d030eef2de15 Signed-off-by: David Edmondson Signed-off-by: Alex Bennée Message-Id: <20200618092636.71832-1-david.edmond...@oracle.com> ---

[PATCH v2 04/25] tests/vm: Add configuration to basevm.py

2020-06-24 Thread Alex Bennée
From: Robert Foley Added use of a configuration to tests/vm/basevm.py. The configuration provides parameters used to configure a VM. This allows for providing alternate configurations to the VM being created/launched. cpu, machine, memory, and NUMA configuration are all examples of configuration

[PATCH v2 00/25] testing/next (vm, gitlab, docker)

2020-06-24 Thread Alex Bennée
Hi, This is the current state of my testing/next queue. The main changes from the last post: https://patchew.org/QEMU/20200622143204.12921-1-alex.ben...@linaro.org/ are the inclusion of Danial's excellent work to generate containers which are stored in the gitlab registry and used as a basis

[PATCH v2 05/25] tests/vm: Added configuration file support

2020-06-24 Thread Alex Bennée
From: Robert Foley Changes to tests/vm/basevm.py to allow accepting a configuration file as a parameter. Allows for specifying VM options such as cpu, machine, memory, and arbitrary qemu arguments for specifying options such as NUMA configuration. Also added an example conf_example_aarch64.yml

[PATCH v2 07/25] tests/vm: Added a new script for ubuntu.aarch64.

2020-06-24 Thread Alex Bennée
From: Robert Foley ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM. Another new file is also added aarch64vm.py, which is a module with common methods used by aarch64 VMs, such as how to create the flash images. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Signed-off-by:

Re: [PATCH v2 0/2] Avoid abort on QMP attempt to add an object with duplicate id

2020-06-24 Thread Auger Eric
Hi, On 6/24/20 3:35 PM, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200624124301.7112-1-eric.au...@redhat.com/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the > testing commands and > their output below. If you have Docker

Building plugin failed on Windows with mingw

2020-06-24 Thread casmac
Hi all, I want to build QEMU 4.2.0 with the plugin module on Windows 7 with Mingw, but the building process faild. The step I follow is listed below: 1. create "dsp_build" diretory under source file folder 2. change directory to dsp_build , and run ../configure --target-list=dsp-softmmu

[RFC v5 12/12] pc-bios: s390x: Cleanup jump to ipl code

2020-06-24 Thread Janosch Frank
jump_to_IPL_code takes a 64 bit address, masks it with the short psw address mask and later branches to it using a full 64 bit register. * As the masking is not necessary, let's remove it * Without the mask we can save the ipl address to a static 64 bit function ptr as we later branch to it *

Re: [PATCH v4 1/5] qdev: Introduce DEFINE_PROP_RESERVED_REGION

2020-06-24 Thread Markus Armbruster
Auger Eric writes: > Hi Markus, > > On 6/23/20 5:13 PM, Markus Armbruster wrote: >> Eric Auger writes: >> >>> Introduce a new property defining a reserved region: >>> ::. >>> >>> This will be used to encode reserved IOVA regions. >>> >>> For instance, in virtio-iommu use case, reserved IOVA

[PATCH] trivial: Remove extra character in configure help

2020-06-24 Thread Christophe de Dinechin
Signed-off-by: Christophe de Dinechin --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index ba88fd1824..c7a6a5adfe 100755 --- a/configure +++ b/configure @@ -1787,7 +1787,7 @@ Advanced options (experts only): --block-drv-ro-whitelist=L

Re: [PATCH] i386: Mask SVM features if nested SVM is disabled

2020-06-24 Thread Paolo Bonzini
On 24/06/20 01:01, Eduardo Habkost wrote: > QEMU incorrectly validates FEAT_SVM feature flags against > GET_SUPPORTED_CPUID even if SVM features are being masked out by > cpu_x86_cpuid(). This can make QEMU print warnings on most AMD > CPU models, even when SVM nesting is disabled (which is the >

Re: -enablefips

2020-06-24 Thread Markus Armbruster
Gerd Hoffmann writes: > On Tue, Jun 23, 2020 at 11:51:09PM -0400, John Snow wrote: >> I never knew what this option did, but the answer is ... strange! >> >> It's only defined for linux, in os-posix.c. When called, it calls >> fips_set_state(true), located in osdep.c. >> >> This will read

Re: [PATCH] trivial: Remove extra character in configure help

2020-06-24 Thread Christophe de Dinechin
Please ignore. The =B appears intentional, even if it offsets the whole help text. Maybe replace with =L to indicate a list is expected? > On 24 Jun 2020, at 10:33, Christophe de Dinechin wrote: > > Signed-off-by: Christophe de Dinechin > --- > configure | 2 +- > 1 file changed, 1

[PATCH v2 11/25] vnc: Plug minor memory leak in vnc_display_open()

2020-06-24 Thread Markus Armbruster
vnc_display_print_local_addr() leaks the Error object when qio_channel_socket_get_local_address() fails. Seems unlikely. Called when we create a VNC display with vnc_display_open(). Plug the leak by passing NULL to ignore the error. Cc: Daniel P. Berrange Cc: Gerd Hoffmann Signed-off-by:

[PATCH v2 18/25] riscv_hart: Fix riscv_harts_realize() error API violations

2020-06-24 Thread Markus Armbruster
The Error ** argument must be NULL, _abort, _fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. riscv_harts_realize() is wrong

[PATCH v2 25/25] arm/{bcm2835, fsl-imx25, fsl-imx6}: Fix realize error API violations

2020-06-24 Thread Markus Armbruster
The Error ** argument must be NULL, _abort, _fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. bcm2835_peripherals_realize(),

Re: [PATCH] trivial: Remove extra character in configure help

2020-06-24 Thread Daniel P . Berrangé
On Wed, Jun 24, 2020 at 10:33:37AM +0200, Christophe de Dinechin wrote: > Signed-off-by: Christophe de Dinechin > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index ba88fd1824..c7a6a5adfe 100755 > --- a/configure > +++

Re: [PATCH] MAINTAINERS: Cover pip requirements.txt

2020-06-24 Thread Philippe Mathieu-Daudé
Cleber are you OK with this? On 6/5/20 6:37 PM, Philippe Mathieu-Daudé wrote: > Add an entry in 'Python scripts' to cover the requirements.txt > file added in commit 213137217a6 (this file contains a list of > Python packages used by our test suite). > > Signed-off-by: Philippe Mathieu-Daudé >

[PATCH v4 19/20] pcspk: update docs/system/target-i386-desc.rst.inc

2020-06-24 Thread Gerd Hoffmann
Add PC speaker with config hints. Signed-off-by: Gerd Hoffmann --- docs/system/target-i386-desc.rst.inc | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/docs/system/target-i386-desc.rst.inc b/docs/system/target-i386-desc.rst.inc index 47a169e0ae2a..7d1fffacbea3

[PATCH v4 18/20] audio: add soundhw deprecation notice

2020-06-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- docs/system/deprecated.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 3a255591c341..4cbf3bba3944 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -82,6

[PATCH v4 06/20] audio: deprecate -soundhw adlib

2020-06-24 Thread Gerd Hoffmann
Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Signed-off-by: Gerd Hoffmann --- hw/audio/adlib.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c index 7c3b67dcfb8c..65dff5b6fca4 100644 ---

[PATCH v4 17/20] audio: deprecate -soundhw pcspk

2020-06-24 Thread Gerd Hoffmann
Add deprecation message to the audio init function. Factor out audio initialization and call that from both audio init and realize, so setting the audiodev property is enough to properly initialize pcspk. Add a property alias to the machine type to set the audio device, so pcspk can be

[PATCH v4 04/20] audio: deprecate -soundhw ac97

2020-06-24 Thread Gerd Hoffmann
Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Add an alias so both ac97 and AC97 are working with -device. Signed-off-by: Gerd Hoffmann --- hw/audio/ac97.c | 9 ++--- qdev-monitor.c | 1 + 2 files changed, 3 insertions(+), 7 deletions(-) diff --git

[PATCH v4 07/20] audio: deprecate -soundhw cs4231a

2020-06-24 Thread Gerd Hoffmann
Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Signed-off-by: Gerd Hoffmann --- hw/audio/cs4231a.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/audio/cs4231a.c b/hw/audio/cs4231a.c index ffdbb58d6a11..59705a8d4701 100644 ---

Re: [PATCH v2 1/1] target/rx: Check for page crossings in use_goto_tb()

2020-06-24 Thread Aleksandar Markovic
уто, 2. јун 2020. у 00:19 Richard Henderson је написао/ла: > > On 5/31/20 6:45 AM, Ahmed Karaman wrote: > > Add the page crossings check in use_goto_tb(). If this check is not > > applied, a number of bugs may occasionally occur during target rx > > system mode emulation. > > Also, this check is

Re: [PULL 25/31] osdep: Make MIN/MAX evaluate arguments only once

2020-06-24 Thread Daniel P . Berrangé
On Wed, Jun 24, 2020 at 07:13:17AM -0500, Eric Blake wrote: > On 6/24/20 5:50 AM, Paolo Bonzini wrote: > > From: Eric Blake > > > > I'm not aware of any immediate bugs in qemu where a second runtime > > evalution of the arguments to MIN() or MAX() causes a problem, but > > evaluation > > >

Re: [PATCH v4 20/20] audio: set default value for pcspk.iobase property

2020-06-24 Thread Eric Blake
On 6/24/20 6:30 AM, Gerd Hoffmann wrote: Allows to drop the explicit qdev_prop_set_uint32 call in pcspk_init. "allows to $verb" is not idiomatic, better is "allows ${verb}ing" [Allows dropping] or "allows $subject to $verb" [Allows us to drop]. Signed-off-by: Gerd Hoffmann ---

[PATCH v2 1/2] qom: Introduce object_property_try_add_child()

2020-06-24 Thread Eric Auger
object_property_add() does not allow object_property_try_add() to gracefully fail as _abort is passed as an error handle. However such failure can easily be triggered from the QMP shell when, for instance, one attempts to create an object with an id that already exists. This is achived from the

Re: [PATCH v3 6/8] s390/sclp: add extended-length sccb support for kvm guest

2020-06-24 Thread Cornelia Huck
On Wed, 24 Jun 2020 14:40:58 +0200 Thomas Huth wrote: > On 24/06/2020 14.36, Cornelia Huck wrote: > > On Thu, 18 Jun 2020 18:22:56 -0400 > > Collin Walling wrote: > > > >> As more features and facilities are added to the Read SCP Info (RSCPI) > >> response, more space is required to store

Re: [PATCH v1 04/10] virtio-pci: implement queue_enabled method

2020-06-24 Thread Laurent Vivier
On 22/06/2020 17:37, Cindy Lu wrote: > From: Jason Wang > > With version 1, we can detect whether a queue is enabled via > queue_enabled. > > Signed-off-by: Jason Wang > Signed-off-by: Cindy Lu > --- > hw/virtio/virtio-pci.c | 18 ++ > 1 file changed, 18 insertions(+) > >

Re: [PATCH v11 00/61] target/riscv: support vector extension v0.7.1

2020-06-24 Thread Alistair Francis
On Tue, Jun 23, 2020 at 3:00 PM LIU Zhiwei wrote: > > This patchset implements the vector extension for RISC-V on QEMU. > > You can also find the patchset and all *test cases* in > my repo(https://github.com/romanheros/qemu.git branch:vector-upstream-v11). > All the test cases are in the

Re: [PATCH v5 0/5] VIRTIO-IOMMU probe request support and MSI bypass on ARM

2020-06-24 Thread Michael S. Tsirkin
On Wed, Jun 24, 2020 at 03:26:20PM +0200, Eric Auger wrote: > By default the virtio-iommu translates MSI transactions. This > behavior is inherited from ARM SMMU. However the virt machine > code knows where the MSI doorbells are, so we can easily > declare those regions as

[PATCH] usb: fix usb-host build on windows.

2020-06-24 Thread Gerd Hoffmann
Seems the new API is not available on windows. Update #ifdefs accordingly. Fixes: 9f815e83e983 ("usb: add hostdevice property to usb-host") Reported-by: Howard Spoelstra Signed-off-by: Gerd Hoffmann --- hw/usb/host-libusb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 19/25] gitlab: convert jobs to use custom built containers

2020-06-24 Thread Alex Bennée
From: Daniel P. Berrangé Now that we're building standard container images from dockerfiles in tests/docker/dockerfiles, we can convert the build jobs to use them. The key benefit of this is that a contributor can now more easily replicate the CI environment on their local machine. The container

[PATCH v2 16/25] .gitignore: un-ignore .gitlab-ci.d

2020-06-24 Thread Alex Bennée
The sooner we deprecate in-tree builds the sooner this mess of regexes can be thrown away. Signed-off-by: Alex Bennée --- v2 - just use explicit !/.gitlab-ci.d --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 90acb4347d4..2992d15931a 100644 ---

Re: [RFC RESEND v7 0/4] QEMU cpus.c refactoring

2020-06-24 Thread Roman Bolshakov
On Mon, Jun 22, 2020 at 03:45:30PM +0200, Claudio Fontana wrote: > Motivation and higher level steps: > > https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg04628.html > > MAIN OPEN POINTS: > > * confirmation on hvf state (Roman). > Hi Claudio, I'm sorry for delay. I'm wrapping up

Re: [PATCH v4] arm/virt: Add memory hot remove support

2020-06-24 Thread Igor Mammedov
On Mon, 22 Jun 2020 13:41:57 +0100 Shameer Kolothum wrote: > This adds support for memory(pc-dimm) hot remove on arm/virt that > uses acpi ged device. > > NVDIMM hot removal is not yet supported. > > Signed-off-by: Shameer Kolothum > --- > v2 --> v3 > -Addressed Eric's comments on v3. > v2

Re: [PATCH v2 20/25] x86: Fix x86_cpu_new() error API violations

2020-06-24 Thread Paolo Bonzini
On 24/06/20 16:17, Igor Mammedov wrote: >> -cpu = object_new(MACHINE(x86ms)->cpu_type); >> - >> -object_property_set_uint(cpu, apic_id, "apic-id", _err); >> -qdev_realize(DEVICE(cpu), NULL, _err); >> - >> -object_unref(cpu); >> -error_propagate(errp, local_err); >> +

[PATCH V6 2/4] hw/intc: Add Loongson liointc support

2020-06-24 Thread Huacai Chen
Loongson-3 has an integrated liointc (Local I/O interrupt controller). It is similar to goldfish interrupt controller, but more powerful (e.g., it can route external interrupt to multi-cores). Documents about Loongson-3's liointc: 1, https://wiki.godson.ac.cn/ip_block:liointc; 2, The "I/O中断"

Re: [PATCH v5 00/12] pc-bios: s390x: Cleanup part 1

2020-06-24 Thread Thomas Huth
On 24/06/2020 12.44, Cornelia Huck wrote: On Wed, 24 Jun 2020 03:52:14 -0400 Janosch Frank wrote: The bios is in dire need for a cleanup as there are still a lot of magic constants being used throughout as well as duplicated code. In the first part of this series we consolidate constants and

[PULL 08/31] configure: add libdaxctl support

2020-06-24 Thread Paolo Bonzini
From: Jingqi Liu Add a pair of configure options --{enable,disable}-libdaxctl to control whether QEMU is compiled with libdaxctl [1]. Libdaxctl is a utility library for managing the device dax subsystem. QEMU uses mmap(2) to maps vNVDIMM backends and aligns the mapping address to the page size

[PULL 16/31] softfloat: fix floatx80 remainder pseudo-denormal check for zero

2020-06-24 Thread Paolo Bonzini
From: Joseph Myers The floatx80 remainder implementation ignores the high bit of the significand when checking whether an operand (numerator) with zero exponent is zero. This means it mishandles a pseudo-denormal representation of 0x1p-16382L by treating it as zero. Fix this by checking the

[PULL 27/31] kvm: i386: allow TSC to differ by NTP correction bounds without TSC scaling

2020-06-24 Thread Paolo Bonzini
From: Marcelo Tosatti The Linux TSC calibration procedure is subject to small variations (its common to see +-1 kHz difference between reboots on a given CPU, for example). So migrating a guest between two hosts with identical processor can fail, in case of a small variation in calibrated TSC

Re: [PATCH] hw/core/null-machine: Do not initialize unused chardev backends

2020-06-24 Thread Thomas Huth
On 24/06/2020 12.56, Philippe Mathieu-Daudé wrote: The MachineClass uses an inverted logic (inherited from the PC machines [*]) to create the chardev backends for the default devices (see commits 998bbd74b9d..aa40fc9c964 and ac33f8fad14). As the none-machine doesn't have any hardware device, it

[PATCH v4 10/20] audio: deprecate -soundhw hda

2020-06-24 Thread Gerd Hoffmann
Add deprecation message to the audio init function. Signed-off-by: Gerd Hoffmann --- hw/audio/intel-hda.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index f673b8317a84..f6cea49686d7 100644 --- a/hw/audio/intel-hda.c +++

[PATCH v4 20/20] audio: set default value for pcspk.iobase property

2020-06-24 Thread Gerd Hoffmann
Allows to drop the explicit qdev_prop_set_uint32 call in pcspk_init. Signed-off-by: Gerd Hoffmann --- include/hw/audio/pcspk.h | 6 +- hw/audio/pcspk.c | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/include/hw/audio/pcspk.h b/include/hw/audio/pcspk.h index

[PATCH v4 11/20] pc_basic_device_init: pass PCMachineState

2020-06-24 Thread Gerd Hoffmann
Need access to pcms for pcspk initialization. Just preparation, no functional change. Signed-off-by: Gerd Hoffmann --- include/hw/i386/pc.h | 3 ++- hw/i386/pc.c | 3 ++- hw/i386/pc_piix.c| 2 +- hw/i386/pc_q35.c | 2 +- 4 files changed, 6 insertions(+), 4 deletions(-) diff

[PATCH v2 5/6] virtio-serial-bus: add terminal resize messages

2020-06-24 Thread Szymon Lukasz
Implement the part of the virtio spec that allows to notify the virtio driver about terminal resizes. The virtio spec contains two methods to achieve that: For legacy drivers, we have only one port and we put the terminal size in the config space and inject the config changed interrupt. For

[PATCH v4 09/20] audio: deprecate -soundhw sb16

2020-06-24 Thread Gerd Hoffmann
Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Signed-off-by: Gerd Hoffmann --- hw/audio/sb16.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/audio/sb16.c b/hw/audio/sb16.c index df6f755a37f8..2d9e50f99b5d 100644 ---

Re: [PATCH v3 2/8] s390/sclp: check sccb len before filling in data

2020-06-24 Thread Thomas Huth
On 19/06/2020 00.22, Collin Walling wrote: The SCCB must be checked for a sufficient length before it is filled with any data. If the length is insufficient, then the SCLP command is suppressed and the proper response code is set in the SCCB header. Fixes: 832be0d8a3bb ("s390x: sclp: Report

Re: sysbus failed assert for xen_sysdev

2020-06-24 Thread Jason Andryuk
On Wed, Jun 24, 2020 at 6:29 AM Paul Durrant wrote: > > > -Original Message- > > From: Jason Andryuk > > Sent: 24 June 2020 04:24 > > To: Paul Durrant > > Cc: Markus Armbruster ; Mark Cave-Ayland > > ; Anthony > > PERARD ; xen-devel > > ; QEMU > de...@nongnu.org> > > Subject: Re:

Re: [PATCH v3 6/8] s390/sclp: add extended-length sccb support for kvm guest

2020-06-24 Thread Thomas Huth
On 24/06/2020 14.36, Cornelia Huck wrote: On Thu, 18 Jun 2020 18:22:56 -0400 Collin Walling wrote: As more features and facilities are added to the Read SCP Info (RSCPI) response, more space is required to store them. The space used to store these new features intrudes on the space originally

Re: [PATCH v3 8/8] s390: guest support for diagnose 0x318

2020-06-24 Thread Cornelia Huck
On Thu, 18 Jun 2020 18:22:58 -0400 Collin Walling wrote: > DIAGNOSE 0x318 (diag318) is an s390 instruction that allows the storage > of diagnostic information that is collected by the firmware in the case > of hardware/firmware service events. > > QEMU handles the instruction by storing the

[PATCH v5 06/10] usb: build usb-redir as module

2020-06-24 Thread Gerd Hoffmann
Drops libusbredirparser.so dependency from core qemu. Signed-off-by: Gerd Hoffmann --- util/module.c| 1 + hw/usb/Makefile.objs | 9 ++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/util/module.c b/util/module.c index 89da9a3cce05..e3226165e91c 100644 ---

[PATCH v5 09/10] vga: build virtio-gpu as module

2020-06-24 Thread Gerd Hoffmann
Drops libvirglrenderer.so dependency from core qemu. Signed-off-by: Gerd Hoffmann --- util/module.c| 6 ++ hw/display/Makefile.objs | 23 +-- 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/util/module.c b/util/module.c index

[PATCH v2 09/25] tests/vm: change scripts to use self._config

2020-06-24 Thread Alex Bennée
From: Robert Foley This change converts existing scripts to using for example self.ROOT_PASS, to self._config['root_pass']. We made similar changes for GUEST_USER, and GUEST_PASS. This allows us also to remove the change in basevm.py, which adds __getattr__ for backwards compatibility.

[PATCH v2 24/25] gitlab: add avocado asset caching

2020-06-24 Thread Alex Bennée
These can be quite big so lets cache them. I couldn't find any nots on ccache in the gitlab docs so I've just ignored it for now. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200622143204.12921-19-alex.ben...@linaro.org> --- .gitlab-ci.yml | 6 ++ 1 file

[PATCH v2 23/25] gitlab: enable check-tcg for linux-user tests

2020-06-24 Thread Alex Bennée
We should have the containers available now. Signed-off-by: Alex Bennée --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 7fcbdacd9e9..54da29dd384 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -142,7 +142,7 @@

[PULL 11/31] hw/scsi/megasas: Fix possible out-of-bounds array access in tracepoints

2020-06-24 Thread Paolo Bonzini
From: Thomas Huth Some tracepoints in megasas.c use a guest-controlled value as an index into the mfi_frame_desc[] array. Thus a malicious guest could cause an out-of-bounds error here. Fortunately, the impact is very low since this can only happen when the corresponding tracepoints have been

[PULL 25/31] osdep: Make MIN/MAX evaluate arguments only once

2020-06-24 Thread Paolo Bonzini
From: Eric Blake I'm not aware of any immediate bugs in qemu where a second runtime evalution of the arguments to MIN() or MAX() causes a problem, but proactively preventing such abuse is easier than falling prey to an unintended case down the road. At any rate, here's the conversation that

[PULL 13/31] xen: Actually fix build without passthrough

2020-06-24 Thread Paolo Bonzini
From: Anthony PERARD Fix typo. Fixes: acd0c9416d48 ("xen: fix build without pci passthrough") Signed-off-by: Anthony PERARD Message-Id: <20200619103115.254127-1-anthony.per...@citrix.com> Signed-off-by: Paolo Bonzini --- hw/xen/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1

[PULL 09/31] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-06-24 Thread Paolo Bonzini
From: Jingqi Liu If the backend file is devdax pmem character device, the alignment specified by the option 'align=NUM' in the '-object memory-backend-file' needs to match the alignment requirement of the devdax pmem character device. This patch uses the interfaces of libdaxctl to fetch the

[PULL 17/31] softfloat: do not return pseudo-denormal from floatx80 remainder

2020-06-24 Thread Paolo Bonzini
From: Joseph Myers The floatx80 remainder implementation sometimes returns the numerator unchanged when the denominator is sufficiently larger than the numerator. But if the value to be returned unchanged is a pseudo-denormal, that is incorrect. Fix it to normalize the numerator in that case.

[PULL 23/31] target/i386: reimplement fpatan using floatx80 operations

2020-06-24 Thread Paolo Bonzini
From: Joseph Myers The x87 fpatan emulation is currently based around conversion to double. This is inherently unsuitable for a good emulation of any floatx80 operation. Reimplement using the soft-float operations, as for other such instructions. Signed-off-by: Joseph Myers Message-Id:

[PULL 30/31] ibex_uart: fix XOR-as-pow

2020-06-24 Thread Paolo Bonzini
The xor-as-pow warning in clang actually detected a genuine bug. Fix it. Signed-off-by: Paolo Bonzini --- hw/char/ibex_uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/ibex_uart.c b/hw/char/ibex_uart.c index 3e0dd9968e..45cd724998 100644 ---

Re: [PATCH v5 00/12] pc-bios: s390x: Cleanup part 1

2020-06-24 Thread Cornelia Huck
On Wed, 24 Jun 2020 12:46:49 +0200 Thomas Huth wrote: > On 24/06/2020 12.44, Cornelia Huck wrote: > > On Wed, 24 Jun 2020 03:52:14 -0400 > > Janosch Frank wrote: > > > >> The bios is in dire need for a cleanup as there are still a lot of > >> magic constants being used throughout as well as

[PULL 31/31] i386: Mask SVM features if nested SVM is disabled

2020-06-24 Thread Paolo Bonzini
From: Eduardo Habkost QEMU incorrectly validates FEAT_SVM feature flags against GET_SUPPORTED_CPUID even if SVM features are being masked out by cpu_x86_cpuid(). This can make QEMU print warnings on most AMD CPU models, even when SVM nesting is disabled (which is the default). This bug was

[PATCH v2 6/6] virtio-console: notify the guest about terminal resizes

2020-06-24 Thread Szymon Lukasz
If a virtio serial port is a console port forward terminal resize messages from the chardev backend to the guest. Signed-off-by: Szymon Lukasz --- hw/char/virtio-console.c | 64 +--- 1 file changed, 60 insertions(+), 4 deletions(-) diff --git

[PATCH v4 15/20] audio: rework pcspk_init()

2020-06-24 Thread Gerd Hoffmann
Instead of creating and returning the pc speaker accept it as argument. That allows to rework the initialization workflow in followup patches. Signed-off-by: Gerd Hoffmann --- include/hw/audio/pcspk.h | 6 +- hw/i386/pc.c | 2 +- hw/isa/i82378.c | 2 +- 3 files changed,

[PATCH v4 00/20] audio: deprecate -soundhw

2020-06-24 Thread Gerd Hoffmann
v2: - use g_assert_not_reached() for stubs. - add deprecation notice. v3: - rebase to latest master. - adapt to armbru's device initialization changes. v4: - reorder patches, drop temporary -global setup, go straight to -machine pcspk-audiodev= instead. - update error messages and

[PATCH v4 03/20] audio: add deprecated_register_soundhw

2020-06-24 Thread Gerd Hoffmann
Add helper function for -soundhw deprecation. It can replace the simple init functions which just call {isa,pci}_create_simple() with a hardcoded type. It also prints a deprecation message. Signed-off-by: Gerd Hoffmann --- include/hw/audio/soundhw.h | 2 ++ hw/audio/soundhw.c | 24

[PATCH v4 14/20] softmmu: initialize spice and audio earlier

2020-06-24 Thread Gerd Hoffmann
audiodev must be initialized before machine_set_property so the machine can have audiodev property aliases. spice must initialize before audiodev because the default audiodev is spice only in case spice is actually enabled. Signed-off-by: Gerd Hoffmann --- softmmu/vl.c | 12 ++-- 1

RE: sysbus failed assert for xen_sysdev

2020-06-24 Thread Paul Durrant
> -Original Message- > From: Jason Andryuk > Sent: 24 June 2020 13:15 > To: Paul Durrant > Cc: Markus Armbruster ; Mark Cave-Ayland > ; Anthony > PERARD ; xen-devel > ; QEMU de...@nongnu.org> > Subject: Re: sysbus failed assert for xen_sysdev > > On Wed, Jun 24, 2020 at 6:29 AM Paul

RE: [PATCH] xen: Fix xen-legacy-backend qdev types

2020-06-24 Thread Paul Durrant
> -Original Message- > From: Jason Andryuk > Sent: 24 June 2020 13:20 > To: Stefano Stabellini ; Anthony Perard > ; Paul > Durrant ; xen-de...@lists.xenproject.org > Cc: Jason Andryuk ; qemu-devel@nongnu.org > Subject: [PATCH] xen: Fix xen-legacy-backend qdev types > > xen-sysdev is a

Re: [PATCH 1/2] vvfat: Check that updated filenames are valid

2020-06-24 Thread Kevin Wolf
Am 23.06.2020 um 20:21 hat Eric Blake geschrieben: > On 6/23/20 12:55 PM, Kevin Wolf wrote: > > FAT allows only a restricted set of characters in file names, and for > > some of the illegal characters, it's actually important that we catch > > them: If filenames can contain '/', the guest can

Re: [PATCH v3 6/8] s390/sclp: add extended-length sccb support for kvm guest

2020-06-24 Thread Cornelia Huck
On Thu, 18 Jun 2020 18:22:56 -0400 Collin Walling wrote: > As more features and facilities are added to the Read SCP Info (RSCPI) > response, more space is required to store them. The space used to store > these new features intrudes on the space originally used to store CPU > entries. This

[PATCH v5 10/10] chardev: enable modules, use for braille

2020-06-24 Thread Gerd Hoffmann
Removes brlapi library dependency from core qemu. Signed-off-by: Gerd Hoffmann --- Makefile.objs | 1 + chardev/char.c| 2 +- util/module.c | 1 + chardev/Makefile.objs | 5 - 4 files changed, 7 insertions(+), 2 deletions(-) diff --git a/Makefile.objs

[PATCH v5 07/10] vga: build qxl as module

2020-06-24 Thread Gerd Hoffmann
First step in making spice support modular. Signed-off-by: Gerd Hoffmann --- util/module.c| 2 ++ hw/Makefile.objs | 1 + hw/display/Makefile.objs | 5 - 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/util/module.c b/util/module.c index

Re: [PATCH v2 0/2] Avoid abort on QMP attempt to add an object with duplicate id

2020-06-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200624124301.7112-1-eric.au...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH v2 0/3] hyperv: vmbus: ACPI various corrections

2020-06-24 Thread Igor Mammedov
On Tue, 23 Jun 2020 17:44:57 +0200 Paolo Bonzini wrote: > On 23/06/20 16:57, Igor Mammedov wrote: > >>> > >>> dtc | 2 +- > >>> hw/hyperv/vmbus.c| 3 +-- > >>> hw/i386/acpi-build.c | 17 + > >>>

[PATCH v2 08/25] tests/vm: Added a new script for centos.aarch64.

2020-06-24 Thread Alex Bennée
From: Robert Foley centos.aarch64 creates a CentOS 8 image. Also added a new kickstart script used to build the centos.aarch64 image. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id:

[PATCH v2 03/25] tests/vm: pass args through to BaseVM's __init__

2020-06-24 Thread Alex Bennée
From: Robert Foley Adding the args parameter to BaseVM's __init__. We will shortly need to pass more parameters to the class so let's just pass args rather than growing the parameter list. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by:

[PATCH v2 12/25] tests/vm: switch from optsparse to argparse

2020-06-24 Thread Alex Bennée
optparse has been deprecated since version 3.2 and argparse is the blessed replacement. Take the opportunity to enhance our help output showing defaults when called. Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé Reviewed-by: Robert Foley --- tests/vm/basevm.py | 84

  1   2   3   4   5   6   >