Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-06-30 Thread Philippe Mathieu-Daudé
On 6/29/20 11:31 PM, BALATON Zoltan wrote: > On Mon, 29 Jun 2020, Philippe Mathieu-Daudé wrote: >> On 6/27/20 9:17 AM, Markus Armbruster wrote: >>> BALATON Zoltan writes: On Wed, 22 Apr 2020, BALATON Zoltan wrote: > On Wed, 22 Apr 2020, Philippe Mathieu-Daudé wrote: >> On

Re: [PATCH] disas/sh4: Add missing fallthrough annotations

2020-06-30 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200630055953.9309-1-th...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] disas/sh4: Add missing fallthrough annotations Type: series Message-id:

Re: [PULL 00/63] riscv-to-apply queue

2020-06-30 Thread LIU Zhiwei
On 2020/6/29 6:51, Alistair Francis wrote: On Sun, Jun 28, 2020 at 7:30 AM Peter Maydell wrote: On Fri, 26 Jun 2020 at 22:53, Alistair Francis wrote: The following changes since commit 553cf5d7c47bee05a3dec9461c1f8430316d516b: Merge remote-tracking branch

Re: [PATCH v2 2/2] target/m68k: consolidate physical translation offset into get_physical_address()

2020-06-30 Thread Laurent Vivier
Le 30/06/2020 à 08:10, Mark Cave-Ayland a écrit : > Since all callers to get_physical_address() now apply the same page offset to > the translation result, move the logic into get_physical_address() itself to > avoid duplication. > > Suggested-by: Philippe Mathieu-Daudé > Signed-off-by: Mark

Re: [PATC 7/9] Skipping drm build, unsupported

2020-06-30 Thread Philippe Mathieu-Daudé
+Gerd On 6/29/20 11:48 PM, David CARLIER wrote: > From 157a0374093371719de42e99364352d64190f52a Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Mon, 29 Jun 2020 22:20:06 + > Subject: [PATCH 7/9] Skipping drm build, unsupported. > > Signed-off-by: David Carlier Reviewed-by: Philippe

Re: [PATCH 3/6] target/riscv: Check for LEGAL NaN-boxing

2020-06-30 Thread Chih-Min Chao
On Sat, Jun 27, 2020 at 5:05 AM LIU Zhiwei wrote: > A narrow n-bit operation, where n < FLEN, checks that input operands > are correctly NaN-boxed, i.e., all upper FLEN - n bits are 1. > If so, the n least-significant bits of the input are used as the input > value, > otherwise the input value

[PATCH] disas/sh4: Add missing fallthrough annotations

2020-06-30 Thread Thomas Huth
Add fallthrough annotations to be able to compile the code without warnings with -Wimplicit-fallthrough. Looking at the code, it seems like the fallthrough is indeed intended here, so the comments should be appropriate. Signed-off-by: Thomas Huth --- Note: The new lines use TABs since all the

Re: [PATCH 5/6] target/riscv: Flush not valid NaN-boxing input to canonical NaN

2020-06-30 Thread Chih-Min Chao
On Sat, Jun 27, 2020 at 5:09 AM LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > target/riscv/insn_trans/trans_rvd.inc.c | 7 +- > target/riscv/insn_trans/trans_rvf.inc.c | 272 > 2 files changed, 235 insertions(+), 44 deletions(-) > > diff --git

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-06-30 Thread Ahmed Karaman
On Tue, Jun 30, 2020 at 7:59 AM 罗勇刚(Yonggang Luo) wrote: > > Wonderful work, May I reproduce the work on my local machine? > > On Mon, Jun 29, 2020 at 6:26 PM Ahmed Karaman > wrote: >> >> Hi, >> >> The second report of the TCG Continuous Benchmarking series builds >> upon the QEMU performance

[PATCH v2 0/2] target/m68k: fix physical address translation in m68k_cpu_get_phys_page_debug()

2020-06-30 Thread Mark Cave-Ayland
The first patch in the series fixes the original bug, whilst the second patch implements the suggestion by Philippe to consolidate the translation offset logic into get_physical_address() itself now that all callers are identical. Signed-off-by: Mark Cave-Ayland v2: - Add R-B tags from

[PATCH v2 1/2] target/m68k: fix physical address translation in m68k_cpu_get_phys_page_debug()

2020-06-30 Thread Mark Cave-Ayland
The result of the get_physical_address() function should be combined with the offset of the original page access before being returned. Otherwise the m68k_cpu_get_phys_page_debug() function can round to the wrong page causing incorrect lookups in gdbstub and various "Disassembler disagrees with

Re: [PATCH v1 05/10] vhost-backend: export the vhost backend helper

2020-06-30 Thread Cindy Lu
On Thu, Jun 25, 2020 at 11:07 PM Laurent Vivier wrote: > > On 22/06/2020 17:37, Cindy Lu wrote: > > export the helper then we can reuse them in other backend > > > > Signed-off-by: Cindy Lu > > --- > > hw/virtio/vhost-backend.c | 18 +- > >

Re: [PATCH 3/6] target/riscv: Check for LEGAL NaN-boxing

2020-06-30 Thread LIU Zhiwei
On 2020/6/30 15:20, Chih-Min Chao wrote: On Sat, Jun 27, 2020 at 5:05 AM LIU Zhiwei > wrote: A narrow n-bit operation, where n < FLEN, checks that input operands are correctly NaN-boxed, i.e., all upper FLEN - n bits are 1. If so, the n

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-06-30 Thread Christian Ehrhardt 
This will re-open again for Bionic due to bug 1885419 forcing a revert of the former backports. After a deeper evaluation if the assert is wrong in the backport or just flagging a problem formerly already existing in Bionic this will be re-fixed. ** Changed in: qemu (Ubuntu Bionic)

[PATCH v2 2/2] target/m68k: consolidate physical translation offset into get_physical_address()

2020-06-30 Thread Mark Cave-Ayland
Since all callers to get_physical_address() now apply the same page offset to the translation result, move the logic into get_physical_address() itself to avoid duplication. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Mark Cave-Ayland --- target/m68k/helper.c | 12 +++- 1 file

Re: [PATCH v1 09/10] vhost-vdpa: introduce vhost-vdpa backend

2020-06-30 Thread Maxime Coquelin
On 6/22/20 5:37 PM, Cindy Lu wrote: > Currently we have 2 types of vhost backends in QEMU: vhost kernel and > vhost-user. The above patch provides a generic device for vDPA purpose, > this vDPA device exposes to user space a non-vendor-specific configuration > interface for setting up a vhost

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-06-30 Thread Ahmed Karaman
On Tue, Jun 30, 2020 at 6:34 AM Lukáš Doktor wrote: > > Dne 29. 06. 20 v 12:25 Ahmed Karaman napsal(a): > > Hi, > > > > The second report of the TCG Continuous Benchmarking series builds > > upon the QEMU performance metrics calculated in the previous report. > > This report presents a method to

Re: [PATCH 2/5] hw/i2c: Rename i2c_try_create_slave() as i2c_slave_new()

2020-06-30 Thread Philippe Mathieu-Daudé
On 6/29/20 11:37 PM, BALATON Zoltan wrote: > On Mon, 29 Jun 2020, Philippe Mathieu-Daudé wrote: >> We use "new" names for functions that allocate and initialize >> device objects: pci_new(), isa_new(), usb_new(). >> Let's call this one i2c_slave_new(). Since we have to update >> all the callers,

[PATCH 2/4] migration: Add block-bitmap-mapping parameter

2020-06-30 Thread Max Reitz
This migration parameter allows mapping block node names and bitmap names to aliases for the purpose of block dirty bitmap migration. This way, management tools can use different node and bitmap names on the source and destination and pass the mapping of how bitmaps are to be transferred to qemu

[PATCH 1/4] migration: Prevent memleak by ...params_test_apply

2020-06-30 Thread Max Reitz
The created structure is not really a proper QAPI object, so we cannot and will not free its members. Strings therein should therefore not be duplicated, or we will leak them. Signed-off-by: Max Reitz --- migration/migration.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 4/4] iotests: Test node/bitmap aliases during migration

2020-06-30 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/300 | 487 + tests/qemu-iotests/300.out | 5 + tests/qemu-iotests/group | 1 + 3 files changed, 493 insertions(+) create mode 100755 tests/qemu-iotests/300 create mode 100644

Re: [PULL 00/63] riscv-to-apply queue

2020-06-30 Thread LIU Zhiwei
On 2020/6/30 16:11, Thomas Huth wrote: On 30/06/2020 08.56, LIU Zhiwei wrote: On 2020/6/29 6:51, Alistair Francis wrote: On Sun, Jun 28, 2020 at 7:30 AM Peter Maydell wrote: On Fri, 26 Jun 2020 at 22:53, Alistair Francis wrote: The following changes since commit

[PATCH v3 25/26] arm/{bcm2835, fsl-imx25, fsl-imx6}: Fix realize error API violations

2020-06-30 Thread Markus Armbruster
The Error ** argument must be NULL, _abort, _fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. bcm2835_peripherals_realize(),

[PATCH v3 08/26] qga: Plug unlikely memory leak in guest-set-memory-blocks

2020-06-30 Thread Markus Armbruster
transfer_memory_block() leaks an Error object when reading file /sys/devices/system/memory/memory/state fails with errno other than ENOENT, and @sys2memblk is false, i.e. when the state file exists but cannot be read (seems quite unlikely), and this is guest-set-memory-blocks, not

[PATCH v3 06/26] usb/dev-mtp: Fix Error double free after inotify failure

2020-06-30 Thread Markus Armbruster
error_report_err() frees its first argument. Freeing it again is wrong. Don't. Fixes: 47287c27d0c367a89f7b2851e23a7f8b2d499dd6 Cc: Gerd Hoffmann Cc: Daniel P. Berrangé Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster --- hw/usb/dev-mtp.c | 2 -- 1 file changed, 2 deletions(-)

[PATCH v3 22/26] arm/stm32f205 arm/stm32f405: Fix realize error API violation

2020-06-30 Thread Markus Armbruster
The Error ** argument must be NULL, _abort, _fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. stm32f205_soc_realize() and

Re: [PATCH 15/19] iotests: qemu-img tests for luks key management

2020-06-30 Thread Maxim Levitsky
On Tue, 2020-06-30 at 10:56 +0200, Max Reitz wrote: > On 29.06.20 14:05, Maxim Levitsky wrote: > > On Thu, 2020-06-25 at 14:55 +0200, Max Reitz wrote: > > > From: Maxim Levitsky > > > > > > This commit adds two tests, which test the new amend interface > > > of both luks raw images and qcow2

Re: [PATCH v3 03/26] Clean up some calls to ignore Error objects the right way

2020-06-30 Thread Daniel P . Berrangé
On Tue, Jun 30, 2020 at 11:03:28AM +0200, Markus Armbruster wrote: > Receiving the error in a local variable only to free it is less clear > (and also less efficient) than passing NULL. Clean up. > > Cc: Daniel P. Berrange > Cc: Jerome Forissier > CC: Greg Kurz > Signed-off-by: Markus

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-06-30 Thread Michael S. Tsirkin
On Tue, Jun 30, 2020 at 04:29:19PM +0800, Jason Wang wrote: > > On 2020/6/30 上午10:41, Jason Wang wrote: > > > > On 2020/6/29 下午9:34, Peter Xu wrote: > > > On Mon, Jun 29, 2020 at 01:51:47PM +0800, Jason Wang wrote: > > > > On 2020/6/28 下午10:47, Peter Xu wrote: > > > > > On Sun, Jun 28, 2020 at

Re: [PATCH v3 23/26] aspeed: Fix realize error API violation

2020-06-30 Thread Philippe Mathieu-Daudé
On 6/30/20 11:03 AM, Markus Armbruster wrote: > The Error ** argument must be NULL, _abort, _fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no longer points to NULL

Re: [PATCH v4 3/7] ccid: build smartcard as module

2020-06-30 Thread Philippe Mathieu-Daudé
On 6/23/20 7:12 PM, Gerd Hoffmann wrote: > Hi, > >>> +{ .type = "ccid-card-passthru",.mod = "usb-smartcard" }, >>> +{ .type = "ccid-card-emulated",.mod = "usb-smartcard" }, >> >> We want to use type definitions here (such TYPE_CCID_PASSTHRU), >> as we don't

[PATCH 10/10] hw/block/nvme: support reset/finish recommended limits

2020-06-30 Thread Klaus Jensen
Add the rrl and frl device parameters. The parameters specify the number of seconds before the device may perform an internal operation to "clear" the Reset Zone Recommended and Finish Zone Recommended attributes respectively. When the attibutes are set is governed by the rrld and frld parameters

[PATCH v6 10/15] hw/sd/sdcard: Simplify cmd_valid_while_locked()

2020-06-30 Thread Philippe Mathieu-Daudé
cmd_valid_while_locked() only needs to read SDRequest->cmd, pass it directly and make it const. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index

[PATCH v6 02/15] hw/sd/sdcard: Update coding style to make checkpatch.pl happy

2020-06-30 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé To make the next commit easier to review, clean this code first. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c

[PATCH v6 01/15] MAINTAINERS: Cc qemu-block mailing list

2020-06-30 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé We forgot to include the qemu-block mailing list while adding this section in commit 076a0fc32a7. Fix this. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS

Re: [PATCH v2 06/18] hw/block/nvme: Define trace events related to NS Types

2020-06-30 Thread Klaus Jensen
On Jun 18 06:34, Dmitry Fomichev wrote: > A few trace events are defined that are relevant to implementing > Namespace Types (NVMe TP 4056). > > Signed-off-by: Dmitry Fomichev Reviewed-by: Klaus Jensen > --- > hw/block/trace-events | 11 +++ > 1 file changed, 11 insertions(+) > >

Re: [PATCH v5 10/21] virtio-mem: Paravirtualized memory hot(un)plug

2020-06-30 Thread David Hildenbrand
On 30.06.20 12:06, Michael S. Tsirkin wrote: > On Fri, Jun 26, 2020 at 09:22:37AM +0200, David Hildenbrand wrote: >> This is the very basic/initial version of virtio-mem. An introduction to >> virtio-mem can be found in the Linux kernel driver [1]. While it can be >> used in the current state for

Re: [PATCH 2/4] migration: Add block-bitmap-mapping parameter

2020-06-30 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > This migration parameter allows mapping block node names and bitmap > names to aliases for the purpose of block dirty bitmap migration. > > This way, management tools can use different node and bitmap names on > the source and destination and pass the

Re: [PATCH v2 3/4] hw/block/nvme: Fix pmrmsc register size

2020-06-30 Thread Klaus Jensen
On Jun 30 12:37, Philippe Mathieu-Daudé wrote: > The Persistent Memory Region Controller Memory Space Control > register is 64-bit wide. See 'Figure 68: Register Definition' > of the 'NVM Express Base Specification Revision 1.4'. > > Fixes: 6cf9413229 ("introduce PMR support from NVMe 1.4 spec")

Re: [PATCH 0/7] hw/mips/malta: Rework to allow more than 2GB of RAM on 64-bit

2020-06-30 Thread Aleksandar Markovic
уторак, 30. јун 2020., Philippe Mathieu-Daudé је написао/ла: > Hi, > > Following Jiaxun Yang's patch and discussion: > https://patchwork.kernel.org/patch/11416915/ > > - Rename the current machine as 'malta-virt' (keeping 'malta' aliased) > Suggestions for better names are welcome, maybe

Re: [PATCH] net: tap: check if the file descriptor is valid before using it

2020-06-30 Thread Daniel P . Berrangé
On Tue, Jun 30, 2020 at 12:35:46PM +0200, Laurent Vivier wrote: > On 30/06/2020 12:03, Jason Wang wrote: > > > > On 2020/6/30 下午5:45, Laurent Vivier wrote: > >> On 30/06/2020 11:31, Daniel P. Berrangé wrote: > >>> On Tue, Jun 30, 2020 at 10:23:18AM +0100, Daniel P. Berrangé wrote: > On Tue,

[PATCH v3 0/4] hw/block/nvme: Fix I/O BAR structure

2020-06-30 Thread Philippe Mathieu-Daudé
Improvements for the I/O BAR structure: - correct pmrmsc register size (Klaus) - pack structures - align to 4KB Since v2: - Added Klaus' tags with correct address $ git backport-diff -u v2 Key: [] : patches are identical [] : number of functional differences between upstream/downstream

Re: [PATCH 0/7] hw/mips/malta: Rework to allow more than 2GB of RAM on 64-bit

2020-06-30 Thread Aleksandar Markovic
уто, 30. јун 2020. у 13:34 Philippe Mathieu-Daudé је написао/ла: > > On 6/30/20 1:17 PM, Aleksandar Markovic wrote: > > уторак, 30. јун 2020., Philippe Mathieu-Daudé > > је написао/ла: > > > > On 6/30/20 1:01 PM, Aleksandar Markovic wrote: > > > > > > > >

Re: [PATCH 0/7] hw/mips/malta: Rework to allow more than 2GB of RAM on 64-bit

2020-06-30 Thread Aleksandar Markovic
уто, 30. јун 2020. у 13:59 Philippe Mathieu-Daudé је написао/ла: > > On 6/30/20 1:55 PM, Aleksandar Markovic wrote: > > уто, 30. јун 2020. у 13:34 Philippe Mathieu-Daudé је > > написао/ла: > >> > >> On 6/30/20 1:17 PM, Aleksandar Markovic wrote: > >>> уторак, 30. јун 2020., Philippe

Re: [PATCH v2 08/18] hw/block/nvme: Make Zoned NS Command Set definitions

2020-06-30 Thread Klaus Jensen
On Jun 30 13:44, Klaus Jensen wrote: > On Jun 18 06:34, Dmitry Fomichev wrote: > > Define values and structures that are needed to support Zoned > > Namespace Command Set (NVMe TP 4053) in PCI NVMe controller emulator. > > > > All new protocol definitions are located in include/block/nvme.h > >

[PATCH] target/i386: Correct the warning message of Intel PT

2020-06-30 Thread Luwei Kang
The CPUID level need to be set to 0x14 manually on old machine-type if Intel PT is enabled in guest. E.g. the CPUID[0].EAX(level)=7 and CPUID[7].EBX[25](intel-pt)=1 when the Qemu with "-machine pc-i440fx-3.1 -cpu qemu64,+intel-pt" parameter. This patch corrects the warning message of the previous

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-06-30 Thread Aleksandar Markovic
уто, 30. јун 2020. у 09:30 Ahmed Karaman је написао/ла: > > On Tue, Jun 30, 2020 at 7:59 AM 罗勇刚(Yonggang Luo) > wrote: > > > > Wonderful work, May I reproduce the work on my local machine? > > > > On Mon, Jun 29, 2020 at 6:26 PM Ahmed Karaman > > wrote: > >> > >> Hi, > >> > >> The second

Re: [PATC 7/9] Skipping drm build, unsupported

2020-06-30 Thread Gerd Hoffmann
On Tue, Jun 30, 2020 at 08:44:24AM +0200, Philippe Mathieu-Daudé wrote: > +Gerd > > On 6/29/20 11:48 PM, David CARLIER wrote: > > From 157a0374093371719de42e99364352d64190f52a Mon Sep 17 00:00:00 2001 > > From: David Carlier > > Date: Mon, 29 Jun 2020 22:20:06 + > > Subject: [PATCH 7/9]

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-06-30 Thread Jason Wang
On 2020/6/30 下午5:21, Michael S. Tsirkin wrote: On Tue, Jun 30, 2020 at 04:29:19PM +0800, Jason Wang wrote: On 2020/6/30 上午10:41, Jason Wang wrote: On 2020/6/29 下午9:34, Peter Xu wrote: On Mon, Jun 29, 2020 at 01:51:47PM +0800, Jason Wang wrote: On 2020/6/28 下午10:47, Peter Xu wrote: On Sun,

Re: [PATCH v3 06/26] usb/dev-mtp: Fix Error double free after inotify failure

2020-06-30 Thread Daniel P . Berrangé
On Tue, Jun 30, 2020 at 11:03:31AM +0200, Markus Armbruster wrote: > error_report_err() frees its first argument. Freeing it again is > wrong. Don't. > > Fixes: 47287c27d0c367a89f7b2851e23a7f8b2d499dd6 > Cc: Gerd Hoffmann > Cc: Daniel P. Berrangé > Cc: qemu-sta...@nongnu.org > Signed-off-by:

Re: [PATCH v3 10/26] test-util-filemonitor: Plug unlikely memory leak

2020-06-30 Thread Daniel P . Berrangé
On Tue, Jun 30, 2020 at 11:03:35AM +0200, Markus Armbruster wrote: > test_file_monitor_events() leaks an Error object when > qemu_file_monitor_add_watch() fails, which seems unlikely. Plug it. > > Cc: Daniel P. Berrangé > Signed-off-by: Markus Armbruster > --- > tests/test-util-filemonitor.c

Re: [PATCH] net: tap: check if the file descriptor is valid before using it

2020-06-30 Thread Daniel P . Berrangé
On Tue, Jun 30, 2020 at 05:21:49PM +0800, Jason Wang wrote: > > On 2020/6/30 上午3:30, Laurent Vivier wrote: > > On 28/06/2020 08:31, Jason Wang wrote: > > > On 2020/6/25 下午7:56, Laurent Vivier wrote: > > > > On 25/06/2020 10:48, Daniel P. Berrangé wrote: > > > > > On Wed, Jun 24, 2020 at

Re: [PATCH v3 22/26] arm/stm32f205 arm/stm32f405: Fix realize error API violation

2020-06-30 Thread Philippe Mathieu-Daudé
On 6/30/20 11:03 AM, Markus Armbruster wrote: > The Error ** argument must be NULL, _abort, _fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no longer points to NULL

Re: [RFC 0/4] Enable virtio-fs on s390x

2020-06-30 Thread Cornelia Huck
On Tue, 30 Jun 2020 10:04:51 +0100 Stefan Hajnoczi wrote: > On Mon, Jun 29, 2020 at 02:07:16PM +0100, Daniel P. Berrangé wrote: > > On Mon, Jun 29, 2020 at 01:53:05PM +0100, Stefan Hajnoczi wrote: > > > On Thu, Jun 25, 2020 at 12:04:26PM +0200, Marc Hartmayer wrote: > > > > This RFC is about

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-06-30 Thread Aleksandar Markovic
уто, 30. јун 2020. у 06:34 Lukáš Doktor је написао/ла: > > Dne 29. 06. 20 v 12:25 Ahmed Karaman napsal(a): > > Hi, > > > > The second report of the TCG Continuous Benchmarking series builds > > upon the QEMU performance metrics calculated in the previous report. > > This report presents a method

Re: [PATCH] net: tap: check if the file descriptor is valid before using it

2020-06-30 Thread Jason Wang
On 2020/6/30 下午5:31, Daniel P. Berrangé wrote: On Tue, Jun 30, 2020 at 10:23:18AM +0100, Daniel P. Berrangé wrote: On Tue, Jun 30, 2020 at 05:21:49PM +0800, Jason Wang wrote: On 2020/6/30 上午3:30, Laurent Vivier wrote: On 28/06/2020 08:31, Jason Wang wrote: On 2020/6/25 下午7:56, Laurent

[PATCH v6 11/15] hw/sd/sdcard: Constify sd_crc*()'s message argument

2020-06-30 Thread Philippe Mathieu-Daudé
CRC functions don't modify the buffer argument, make it const. Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 0fd672357c..2238ba066d 100644 ---

[PATCH v6 05/15] hw/sd/sdcard: Do not switch to ReceivingData if address is invalid

2020-06-30 Thread Philippe Mathieu-Daudé
Only move the state machine to ReceivingData if there is no pending error. This avoids later OOB access while processing commands queued. "SD Specifications Part 1 Physical Layer Simplified Spec. v3.01" 4.3.3 Data Read Read command is rejected if BLOCK_LEN_ERROR or ADDRESS_ERROR

[PATCH v6 14/15] hw/sd/sdcard: Display offset in read/write_data() trace events

2020-06-30 Thread Philippe Mathieu-Daudé
Having 'base address' and 'relative offset' displayed separately is more helpful than the absolute address. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 8 hw/sd/trace-events | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff

Re: [PATCH v9 02/34] qcow2: Convert qcow2_get_cluster_offset() into qcow2_get_host_offset()

2020-06-30 Thread Max Reitz
On 28.06.20 13:02, Alberto Garcia wrote: > qcow2_get_cluster_offset() takes an (unaligned) guest offset and > returns the (aligned) offset of the corresponding cluster in the qcow2 > image. > > In practice none of the callers need to know where the cluster starts > so this patch makes the

Re: [PATCH 0/7] hw/mips/malta: Rework to allow more than 2GB of RAM on 64-bit

2020-06-30 Thread Philippe Mathieu-Daudé
On 6/30/20 12:54 PM, Aleksandar Markovic wrote: > > > уторак, 30. јун 2020., Philippe Mathieu-Daudé > је написао/ла: > > On 6/30/20 12:48 PM, Aleksandar Markovic wrote: > > > > > > уторак, 30. јун 2020., Philippe Mathieu-Daudé

Re: [PATCH] net: tap: check if the file descriptor is valid before using it

2020-06-30 Thread Jason Wang
On 2020/6/30 下午6:35, Laurent Vivier wrote: On 30/06/2020 12:03, Jason Wang wrote: On 2020/6/30 下午5:45, Laurent Vivier wrote: On 30/06/2020 11:31, Daniel P. Berrangé wrote: On Tue, Jun 30, 2020 at 10:23:18AM +0100, Daniel P. Berrangé wrote: On Tue, Jun 30, 2020 at 05:21:49PM +0800, Jason

Re: [PATCH 0/7] hw/mips/malta: Rework to allow more than 2GB of RAM on 64-bit

2020-06-30 Thread Philippe Mathieu-Daudé
On 6/30/20 1:01 PM, Aleksandar Markovic wrote: > > > уторак, 30. јун 2020., Philippe Mathieu-Daudé > је написао/ла: > > On Tue, Jun 30, 2020 at 12:52 PM Philippe Mathieu-Daudé > mailto:f4...@amsat.org>> wrote: > > > > On 6/30/20 12:48 PM, Aleksandar

[PATCH v3 2/4] hw/block/nvme: Use QEMU_PACKED on hardware/packet structures

2020-06-30 Thread Philippe Mathieu-Daudé
These structures either describe hardware registers, or commands ('packets') to send to the hardware. To forbid the compiler to optimize and change fields alignment, mark the structures as packed. Reviewed-by: Klaus Jensen Signed-off-by: Philippe Mathieu-Daudé --- include/block/nvme.h | 38

[PATCH v3 3/4] hw/block/nvme: Fix pmrmsc register size

2020-06-30 Thread Philippe Mathieu-Daudé
The Persistent Memory Region Controller Memory Space Control register is 64-bit wide. See 'Figure 68: Register Definition' of the 'NVM Express Base Specification Revision 1.4'. Fixes: 6cf9413229 ("introduce PMR support from NVMe 1.4 spec") Reported-by: Klaus Jensen Reviewed-by: Klaus Jensen

[PATCH v3 1/4] hw/block/nvme: Update specification URL

2020-06-30 Thread Philippe Mathieu-Daudé
At some point the URL changed, update it to avoid other developers to search for it. Reviewed-by: Klaus Jensen Signed-off-by: Philippe Mathieu-Daudé --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index

Re: [PATCH RFC] virtio-fs: force virtio 1.x usage

2020-06-30 Thread Stefan Hajnoczi
On Mon, Jun 29, 2020 at 12:27:58PM +0200, Cornelia Huck wrote: > virtio-fs devices are only specified for virtio-1, so it is unclear > how a legacy or transitional device should behave. > > Signed-off-by: Cornelia Huck > --- I thought that the following already forced VIRTIO 1.0 because it

Re: [PATCH v2 1/3] Makefile: Compute libraries for libqemuutil.a and libvhost-user.a

2020-06-30 Thread Stefan Hajnoczi
On Fri, Jun 26, 2020 at 06:27:04PM +0200, Christophe de Dinechin wrote: > In util/Makefile.objs, there is a setting for dbus.o-libs. > Trying to copy-paste that to add a library for module.o that was was > not otherwise linked yields link errors on a number of binaries, > e.g. qemu-ga, with

[PATCH 5/7] hw/mips/malta: Introduce the 'malta-phys' machine

2020-06-30 Thread Philippe Mathieu-Daudé
Introduce the 'malta-phys' machine, aiming to have the same limitations as real hardware. Start by restricting the RAM to 1GB, which is the maximum amount of memory the GT-64120A north bridge can address. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/malta.c | 21 + 1

Re: [PATCH] hw/misc/pca9552: Add missing TypeInfo::class_size field

2020-06-30 Thread Philippe Mathieu-Daudé
On 6/29/20 11:07 PM, Peter Maydell wrote: > On Mon, 29 Jun 2020 at 08:47, Philippe Mathieu-Daudé wrote: >> >> When adding the generic PCA955xClass in commit 736132e455, we >> forgot to set the class_size field. Fill it now to avoid: > > Thanks; I've applied this to master since it fixes a memory

[PATCH 6/7] hw/mips/malta: Verify malta-phys machine uses correct DIMM sizes

2020-06-30 Thread Philippe Mathieu-Daudé
The machine has 4 DIMM slots. Each DIMM must be a power of 2. Add a check the total RAM is a good combination of DIMMs. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/malta.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/mips/malta.c b/hw/mips/malta.c index

[PATCH 7/7] hw/mips/malta: Allow more than 2GB on 64-bit malta-virt

2020-06-30 Thread Philippe Mathieu-Daudé
Since we don't respect the hardware restrictions, there is no good reason to limit the maximum amount of RAM to 2GB. Suggested-by: Yunqiang Su Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/malta.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/mips/malta.c

Re: [PATCH v2 0/3] virtiofsd capability changes and addition

2020-06-30 Thread Stefan Hajnoczi
On Mon, Jun 29, 2020 at 12:54:17PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This is a set of changes relating to the capability restirctions > introduced in virtiofsd back in a59feb483b8. > > The first one is a potentially important fix; the

[PATCH 3/4] iotests.py: Add wait_for_runstate()

2020-06-30 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index ef739dd1e3..32f262db5a 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -799,6

Re: [PATCH] hw/block/nvme: Align I/O BAR to 4 KiB

2020-06-30 Thread Klaus Jensen
On Jun 30 10:35, Philippe Mathieu-Daudé wrote: > Hi Klaus, > > On 6/25/20 8:23 PM, Klaus Jensen wrote: > > On Jun 25 17:48, Philippe Mathieu-Daudé wrote: > >> Simplify the NVMe emulated device by aligning the I/O BAR to 4 KiB. > >> > >> Signed-off-by: Philippe Mathieu-Daudé > >> --- > >>

[PATCH v3 07/26] spapr: Plug minor memory leak in spapr_machine_init()

2020-06-30 Thread Markus Armbruster
spapr_machine_init() leaks an Error object when kvmppc_check_papr_resize_hpt() fails and spapr->resize_hpt is SPAPR_RESIZE_HPT_DISABLED, i.e. when the host doesn't support hash page table resizing, and the user didn't ask for it. As harmless as memory leaks can possibly be. Plug it. Fixes:

[PATCH v3 00/26] Error handling fixes & cleanups

2020-06-30 Thread Markus Armbruster
This series addresses a number of error handling issues I found while working on error handling improvements. v3: * PATCH 20: Can actually fail; propagate [Igor, Paolo] * PATCH 26: New Markus Armbruster (26): net/virtio: Fix failover_replug_primary() return value regression pci: Delete

[PATCH v3 05/26] tests: Use error_free_or_abort() where appropriate

2020-06-30 Thread Markus Armbruster
Replace g_assert(err != NULL); error_free(err); err = NULL; and variations thereof by error_free_or_abort(); Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/check-block-qdict.c | 24 ++-- tests/check-qom-proplist.c | 7 ++-

Re: [PATCH v3 09/26] sd/milkymist-memcard: Plug minor memory leak in realize

2020-06-30 Thread Philippe Mathieu-Daudé
On 6/30/20 11:03 AM, Markus Armbruster wrote: > milkymist_memcard_realize() leaks an Error object when realization of > its "sd-card" device fails. Quite harmless, since we only ever > realize this once, in milkymist_init() via milkymist_memcard_create(). > > Plug the leak. > > Fixes:

Re: [PATCH v2 2/3] trace: Add support for recorder back-end

2020-06-30 Thread Dr. David Alan Gilbert
* Christophe de Dinechin (dinec...@redhat.com) wrote: > The recorder library provides support for low-cost continuous > recording of events, which can then be replayed. This makes it > possible to collect data "after the fact",for example to show the > events that led to a crash. > > Recorder

Re: [PATCH v3 11/26] vnc: Plug minor memory leak in vnc_display_open()

2020-06-30 Thread Daniel P . Berrangé
On Tue, Jun 30, 2020 at 11:03:36AM +0200, Markus Armbruster wrote: > vnc_display_print_local_addr() leaks the Error object when > qio_channel_socket_get_local_address() fails. Seems unlikely. Called > when we create a VNC display with vnc_display_open(). Plug the leak > by passing NULL to

Re: [PATCH 1/3] hw/block/nvme: add NVMe 1.4 specific fields

2020-06-30 Thread Philippe Mathieu-Daudé
On 6/30/20 6:31 AM, Klaus Jensen wrote: > From: Klaus Jensen > > Add new fields from NVM Express v1.4. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 3 +- > include/block/nvme.h | 195 +-- > 2 files changed, 172 insertions(+), 26

Re: [PATCH] hw/block/nvme: Align I/O BAR to 4 KiB

2020-06-30 Thread Philippe Mathieu-Daudé
On 6/30/20 10:46 AM, Klaus Jensen wrote: > On Jun 30 10:35, Philippe Mathieu-Daudé wrote: >> Hi Klaus, >> >> On 6/25/20 8:23 PM, Klaus Jensen wrote: >>> On Jun 25 17:48, Philippe Mathieu-Daudé wrote: Simplify the NVMe emulated device by aligning the I/O BAR to 4 KiB. Signed-off-by:

Re: [PATCH 01/10] modules: Provide macros making it easier to identify module exports

2020-06-30 Thread Michael S. Tsirkin
On Fri, Jun 26, 2020 at 06:42:58PM +0200, Christophe de Dinechin wrote: > In order to facilitate the move of large chunks of functionality to > load modules, it is simpler to create a wrapper with the same name > that simply relays the implementation. For efficiency, this is > typically done using

[PATCH 06/10] hw/block/nvme: add the zone append command

2020-06-30 Thread Klaus Jensen
Add the Zone Append command. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 106 ++ hw/block/nvme.h | 3 ++ hw/block/trace-events | 2 + 3 files changed, 111 insertions(+) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index

[PATCH 08/10] hw/block/nvme: allow open to close transitions by controller

2020-06-30 Thread Klaus Jensen
Allow the controller to release open resources by transitioning implicitly and explicitly opened zones to closed. This is done using a naive "least recently opened" strategy. Some workloads may behave very badly with this, but for the purpose of testing how software deals with this it is

[PATCH v6 00/15] hw/sd/sdcard: Fix CVE-2020-13253 & cleanups

2020-06-30 Thread Philippe Mathieu-Daudé
Patches 5 & 6 fix CVE-2020-13253. The rest are (accumulated) cleanups. Since v5: Fix incorrect use of sd_addr_to_wpnum() in sd_reset() Missing review: [PATCH 01/15] MAINTAINERS: Cc qemu-block mailing list [PATCH 03/15] hw/sd/sdcard: Move some definitions to use them [PATCH 04/15] hw/sd/sdcard:

[PATCH v2 0/9] Improve synchronization between QEMU and HVF

2020-06-30 Thread Roman Bolshakov
The series is a prerequisite to implement gdbstub support for HVF and mostly concerns improvements of cpu_synchronize_* functions wrt to HVF and addresses old TODO's in the related code. Changes since v1: - Reduced kick loss race (Paolo) and removed SIG_IPI blocking in the kick patch - Added

[PATCH v2 2/9] i386: hvf: Move synchronize functions to sysemu

2020-06-30 Thread Roman Bolshakov
Cc: Cameron Esfahani Signed-off-by: Roman Bolshakov --- cpus.c| 12 include/sysemu/hw_accel.h | 10 ++ 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/cpus.c b/cpus.c index 41d1c5099f..d94456ed29 100644 --- a/cpus.c +++ b/cpus.c @@

Re: [PATCH v9 02/34] qcow2: Convert qcow2_get_cluster_offset() into qcow2_get_host_offset()

2020-06-30 Thread Alberto Garcia
On Tue 30 Jun 2020 12:19:42 PM CEST, Max Reitz wrote: >> @@ -537,8 +542,6 @@ int qcow2_get_cluster_offset(BlockDriverState *bs, >> uint64_t offset, >> bytes_needed = bytes_available; >> } >> >> -*cluster_offset = 0; >> - > > You drop this line without replacement now. That

Re: [PATCH 1/4] migration: Prevent memleak by ...params_test_apply

2020-06-30 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > The created structure is not really a proper QAPI object, so we cannot > and will not free its members. Strings therein should therefore not be > duplicated, or we will leak them. > > Signed-off-by: Max Reitz > --- > migration/migration.c | 4 ++-- > 1

Re: [PATCH] net: tap: check if the file descriptor is valid before using it

2020-06-30 Thread Laurent Vivier
On 30/06/2020 12:03, Jason Wang wrote: > > On 2020/6/30 下午5:45, Laurent Vivier wrote: >> On 30/06/2020 11:31, Daniel P. Berrangé wrote: >>> On Tue, Jun 30, 2020 at 10:23:18AM +0100, Daniel P. Berrangé wrote: On Tue, Jun 30, 2020 at 05:21:49PM +0800, Jason Wang wrote: > On 2020/6/30

[PATCH v2 8/9] i386: hvf: Clean up synchronize functions

2020-06-30 Thread Roman Bolshakov
Make them more concise and consitent with the rest of the code in the file and drop non-relevant TODO. Cc: Cameron Esfahani Signed-off-by: Roman Bolshakov --- target/i386/hvf/hvf.c | 36 1 file changed, 16 insertions(+), 20 deletions(-) diff --git

[PATCH] linux-user/elfload: use MAP_FIXED in pgb_reserved_va

2020-06-30 Thread Alex Bennée
Given we assert the requested address matches what we asked we should also make that clear in the mmap flags. Otherwise we see failures in the GitLab environment for some currently unknown but allowable reason. Signed-off-by: Alex Bennée --- linux-user/elfload.c | 2 +- 1 file changed, 1

[PATCH v2 9/9] MAINTAINERS: Add Cameron as HVF co-maintainer

2020-06-30 Thread Roman Bolshakov
Similar patch was sent a while ago but got lost. While at it, add a status wiki page. Cc: Cameron Esfahani Signed-off-by: Roman Bolshakov --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index dec252f38b..b6d4f62ba2 100644 --- a/MAINTAINERS +++

Re: [PATCH 0/7] hw/mips/malta: Rework to allow more than 2GB of RAM on 64-bit

2020-06-30 Thread Philippe Mathieu-Daudé
On Tue, Jun 30, 2020 at 12:52 PM Philippe Mathieu-Daudé wrote: > > On 6/30/20 12:48 PM, Aleksandar Markovic wrote: > > > > > > уторак, 30. јун 2020., Philippe Mathieu-Daudé > > је написао/ла: > > > > Hi, > > > > Following Jiaxun Yang's patch and discussion: > >

Re: [PATCH v2 2/4] hw/block/nvme: Use QEMU_PACKED on hardware/packet structures

2020-06-30 Thread Klaus Jensen
On Jun 30 12:37, Philippe Mathieu-Daudé wrote: > These structures either describe hardware registers, or > commands ('packets') to send to the hardware. To forbid > the compiler to optimize and change fields alignment, > mark the structures as packed. > > Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH 0/7] hw/mips/malta: Rework to allow more than 2GB of RAM on 64-bit

2020-06-30 Thread Aleksandar Markovic
уторак, 30. јун 2020., Philippe Mathieu-Daudé је написао/ла: > On 6/30/20 12:48 PM, Aleksandar Markovic wrote: > > > > > > уторак, 30. јун 2020., Philippe Mathieu-Daudé > > је написао/ла: > > > > Hi, > > > > Following Jiaxun Yang's patch and discussion: > >

[PATCH v3 4/4] hw/block/nvme: Align I/O BAR to 4 KiB

2020-06-30 Thread Philippe Mathieu-Daudé
Simplify the NVMe emulated device by aligning the I/O BAR to 4 KiB. Reviewed-by: Klaus Jensen Signed-off-by: Philippe Mathieu-Daudé --- include/block/nvme.h | 2 ++ hw/block/nvme.c | 5 ++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/block/nvme.h

[PATCH v3 0/2] target/m68k: fix physical address translation in m68k_cpu_get_phys_page_debug()

2020-06-30 Thread Mark Cave-Ayland
The first patch in the series fixes the original bug, whilst the second patch implements the suggestion by Philippe to consolidate the translation offset logic into get_physical_address() itself now that all callers are identical. Signed-off-by: Mark Cave-Ayland v3: - Fix Transparent

  1   2   3   4   5   >