Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

On Tue, 30 Jun 2020 20:00:08 +0200 Christian Schoenebeck wrote: > On Dienstag, 30. Juni 2020 18:39:57 CEST Greg Kurz wrote: > > On Tue, 30 Jun 2020 17:16:40 +0200 > > > > Christian Schoenebeck wrote: > > > On Montag, 29. Juni 2020 18:39:02 CEST Greg Kurz wrote: > > > > On Wed, 03 Jun 2020

Re: [PULL 6/6] MAINTAINERS: Add 'Performance Tools and Tests' subsection

On 6/29/20 12:28 PM, Aleksandar Markovic wrote: > понедељак, 29. јун 2020., Philippe Mathieu-Daudé > је написао/ла: > > On 6/27/20 9:51 PM, Aleksandar Markovic wrote: > > This commit creates a new 'Miscellaneous' section which hosts a new > > 'Performance

Re: [PATCH v10 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites

On Tue, Jun 23, 2020 at 07:27:21PM +0200, Philippe Mathieu-Daudé wrote: > Hi, > > This series has 3 parts: > > - First we add the tls-cipher-suites object > > - We add the ability to QOM objects to produce data > consumable by the fw_cfg device, > > - Then we let the tls-cipher-suites object

Re: [PATCH v7 15/21] multi-process: Synchronize remote memory

On Sat, Jun 27, 2020 at 10:09:37AM -0700, elena.ufimts...@oracle.com wrote: > +static bool try_merge(RemoteMemSync *sync, MemoryRegionSection *section) > +{ > +uint64_t mrs_size, mrs_gpa, mrs_page; > +MemoryRegionSection *prev_sec; > +bool merged = false; > +uintptr_t mrs_host; > +

[PATCH v2 4/5] iotests.py: filter_testfiles(): filter SOCK_DIR too

Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index ac9d199a1e..31d4b105ca 100644 --- a/tests/qemu-iotests/iotests.py +++

Re: [PATCH 2/2] xen: cleanup unrealized flash devices

On Wed, Jul 1, 2020 at 3:03 AM Paul Durrant wrote: > > > -Original Message- > > From: Philippe Mathieu-Daudé > > Sent: 30 June 2020 18:27 > > To: p...@xen.org; xen-de...@lists.xenproject.org; qemu-devel@nongnu.org > > Cc: 'Eduardo Habkost' ; 'Michael S. Tsirkin' > > ; 'Paul Durrant' > >

Re: [PATCH 1/2] virtio-ccw: fix virtio_set_ind_atomic

On 16.06.20 06:50, Halil Pasic wrote: > The atomic_cmpxchg() loop is broken because we occasionally end up with > old and _old having different values (a legit compiler can generate code > that accessed *ind_addr again to pick up a value for _old instead of > using the value of old that was

Re: [PATCH 2/2] s390x/pci: fix set_ind_atomic

On 16.06.20 06:50, Halil Pasic wrote: > The atomic_cmpxchg() loop is broken because we occasionally end up with > old and _old having different values (a legit compiler can generate code > that accessed *ind_addr again to pick up a value for _old instead of > using the value of old that was

[Bug 1885889] Re: ERROR: core-image-minimal-1.0-r0 do_rootfs: The postinstall intercept hook 'update_font_cache' failed,

Why do you file this under the upstream "QEMU" component? This does not seem to be related to QEMU at all? ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH v7 14/21] multi-process: PCI BAR read/write handling for proxy & remote endpoints

On Sat, Jun 27, 2020 at 10:09:36AM -0700, elena.ufimts...@oracle.com wrote: > @@ -54,6 +57,12 @@ gboolean mpqemu_process_msg(QIOChannel *ioc, GIOCondition > cond, > case PCI_CONFIG_READ: > process_config_read(ioc, pci_dev, ); > break; > +case BAR_WRITE: > +

[PATCH v2 3/5] nbd: make nbd_export_close_all() synchronous

Consider nbd_export_close_all(). The call-stack looks like this: nbd_export_close_all() -> nbd_export_close -> call client_close() for each client. client_close() doesn't guarantee that client is closed: nbd_trip() keeps reference to it. So, nbd_export_close_all() just reduce reference counter

[PATCH v2 5/5] iotests: test shutdown when bitmap is exported through NBD

Test shutdown when bitmap is exported through NBD and active client exists. The previous patch fixes a crash, provoked by this scenario. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/299 | 65 ++ tests/qemu-iotests/299.out | 10 ++

[PATCH v2 2/5] iotests.py: QemuIoInteractive: print output on failure

Make it simpler to debug when qemu-io fails due to wrong arguments or environment. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- tests/qemu-iotests/iotests.py | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py

[PATCH v2 1/5] iotests: QemuIoInteractive: use qemu_io_args_no_fmt

The only user (iotest 205) of QemuIoInteractive provides -f argument, so it's a bit inefficient to use qemu_io_args, which contains -f too. And we are going to add one more test, which wants to specify -f by hand. Let's use qemu_io_args_no_fmt. Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: Race with atexit functions in system emulation

On 01/07/20 13:05, Alex Bennée wrote: > Should we maybe defer the exit to once the main loop has been exited > with a some sort of vmstop? Or could we have an atexit handler that > kills the main thread? Yes, I think the way to do "exit" is to use qemu_system_shutdown_request. Possibly halt the

Re: [PATCH 1/2] pci: pass along the return value of dma_memory_rw

On Mon, Jun 29, 2020 at 10:20:52PM +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Some devices might want to know the return value of dma_memory_rw, so > pass it along instead of ignoring it. > > There are no existing users of the return value, so this patch should be > safe. > >

Re: [PATCH 2/2] xen: cleanup unrealized flash devices

On 7/1/20 2:40 PM, Philippe Mathieu-Daudé wrote: > On 7/1/20 2:25 PM, Jason Andryuk wrote: >> On Wed, Jul 1, 2020 at 3:03 AM Paul Durrant wrote: >>> -Original Message- From: Philippe Mathieu-Daudé Sent: 30 June 2020 18:27 To: p...@xen.org;

Re: [PATCH 0/2] two atomic_cmpxchg() related fixes

On Wed, 1 Jul 2020 14:06:11 +0200 Christian Borntraeger wrote: > On 01.07.20 14:01, Cornelia Huck wrote: > > On Tue, 16 Jun 2020 06:50:33 +0200 > > Halil Pasic wrote: > > > >> The story short: compiler can generate code that does two > >> distinct fetches of *ind_addr for old and _old. If

Re: [PATCH 3/4] nbd: make client_close synchronous

29.06.2020 16:56, Stefan Hajnoczi wrote: On Mon, Jun 29, 2020 at 10:55:06AM +0300, Vladimir Sementsov-Ogievskiy wrote: Also, why in block/io.c we kick the main context, but not bs->aio_context? From AIO_WAIT_WHILE(): * The caller's thread must be the IOThread that owns @ctx or the main

Re: [PATCH v10 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites

On 7/1/20 12:31 PM, Daniel P. Berrangé wrote: > On Tue, Jun 23, 2020 at 07:27:21PM +0200, Philippe Mathieu-Daudé wrote: >> Hi, >> >> This series has 3 parts: >> >> - First we add the tls-cipher-suites object >> >> - We add the ability to QOM objects to produce data >> consumable by the fw_cfg

Re: [PATCH 1/4] migration: Prevent memleak by ...params_test_apply

30.06.2020 11:45, Max Reitz wrote: The created structure is not really a proper QAPI object, so we cannot and will not free its members. Strings therein should therefore not be duplicated, or we will leak them. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best

Re: [PATCH v2 14/18] hw/block/nvme: Generate zone AENs

On Jun 18 06:34, Dmitry Fomichev wrote: > Added an optional Boolean "zone_async_events" property to the driver. > Once it's turned on, the namespace will be sending "Zone Descriptor > Changed" asynchronous events to the host in particular situations > defined by the protocol. In order to clear

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

On 2020/7/1 下午8:16, Peter Xu wrote: On Wed, Jul 01, 2020 at 04:11:49PM +0800, Jason Wang wrote: On 2020/6/30 下午11:20, Peter Xu wrote: On Tue, Jun 30, 2020 at 05:23:31PM +0800, Jason Wang wrote: Ok, we had a dedicated mr for interrupt:

Re: [PATCH v9 14/34] qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type()

On 28.06.20 13:02, Alberto Garcia wrote: > This patch adds QCow2SubclusterType, which is the subcluster-level > version of QCow2ClusterType. All QCOW2_SUBCLUSTER_* values have the > the same meaning as their QCOW2_CLUSTER_* equivalents (when they > exist). See below for details and caveats. > >

Re: nvme emulation merge process (was: Re: [PATCH 00/10] hw/block/nvme: namespace types and zoned namespaces)

On Jul 1 12:34, Kevin Wolf wrote: > Am 30.06.2020 um 22:36 hat Klaus Jensen geschrieben: > > On Jun 30 08:42, Keith Busch wrote: > > > On Tue, Jun 30, 2020 at 04:09:46PM +0200, Philippe Mathieu-Daudé wrote: > > > > What I see doable for the following days is: > > > > - hw/block/nvme: Fix I/O BAR

Re: [PATCH v3 00/13] vDPA support in qemu

Patchew URL: https://patchew.org/QEMU/20200701092449.17451-1-l...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[Bug 1885720] Re: qemu/migration/postcopy-ram.c:387: bad return expression ?

Posted: migration: postcopy take proper error return ** Changed in: qemu Status: Confirmed => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1885720 Title:

Re: [PULL 6/6] MAINTAINERS: Add 'Performance Tools and Tests' subsection

On 7/1/20 12:32 PM, Philippe Mathieu-Daudé wrote: > On 6/29/20 12:28 PM, Aleksandar Markovic wrote: >> понедељак, 29. јун 2020., Philippe Mathieu-Daudé > > је написао/ла: >> >> On 6/27/20 9:51 PM, Aleksandar Markovic wrote: >> > This commit creates a new

[PATCH v2 0/5] Fix crash due to NBD export leak

Hi all! We've faced crash bug, which is reproducing on master branch as well. The case is described in 03, where fix is suggested. New iotest in 05 crashes without that fix. v2: 01: reword commit msg, add Eric's r-b 02: fix type in commit msg, add Eric's r-b 03: rewrite v1:04 split into 04

Re: [PATCH] pc-bios/s390-ccw: Generate and include dependency files in the Makefile

On Tue, 30 Jun 2020 16:29:55 +0200 Thomas Huth wrote: > The Makefile of the s390-ccw bios does not handle dependencies of the > *.c files from the headers yet, so that you often have to run a "make > clean" to get the build right when one of the headers has been changed. > Let's make sure that

Race with atexit functions in system emulation

Hi, While running some TSAN tests I ran into the following race condition: WARNING: ThreadSanitizer: data race (pid=1605) Write of size 4 at 0x55c437814d98 by thread T2 (mutexes: write M619): #0 replay_finish /home/alex.bennee/lsrc/qemu.git/replay/replay.c:393:17

Re: [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership

Hi, Philippe and Alexandar, On Wed, Jul 1, 2020 at 4:49 PM Philippe Mathieu-Daudé wrote: > > On 7/1/20 10:00 AM, Philippe Mathieu-Daudé wrote: > > On 6/30/20 7:19 PM, Philippe Mathieu-Daudé wrote: > >> On 6/30/20 6:46 PM, Aleksandar Markovic wrote: > >>> Paul Burton and Aurelien Jarno removed

[PATCH] acpi: Fix access to PM1 control and status registers

The ACPI spec state that "Accesses to PM1 control registers are accessed through byte and word accesses." (In section 4.7.3.2.1 PM1 Control Registers of my old spec copy rev 4.0a). With commit 5d971f9e6725 ("memory: Revert "memory: accept mismatching sizes in memory_region_access_valid""), it

Re: [PATCH 0/2] two atomic_cmpxchg() related fixes

On 01.07.20 14:01, Cornelia Huck wrote: > On Tue, 16 Jun 2020 06:50:33 +0200 > Halil Pasic wrote: > >> The story short: compiler can generate code that does two >> distinct fetches of *ind_addr for old and _old. If that happens we can >> not figure out if we had the desired xchg or not. >> >>

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

On Wed, Jul 01, 2020 at 04:11:49PM +0800, Jason Wang wrote: > > On 2020/6/30 下午11:20, Peter Xu wrote: > > On Tue, Jun 30, 2020 at 05:23:31PM +0800, Jason Wang wrote: > > > > > Ok, we had a dedicated mr for interrupt: > > > > > > > > > >

Re: [PATCH v9 11/34] qcow2: Add offset_into_subcluster() and size_to_subclusters()

On 28.06.20 13:02, Alberto Garcia wrote: > Like offset_into_cluster() and size_to_clusters(), but for > subclusters. > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Blake > --- > block/qcow2.h | 10 ++ > 1 file changed, 10 insertions(+) Reviewed-by: Max Reitz signature.asc

[PATCH] MAINTAINERS: add VT-d entry

Add this entry as suggested by Jason and Michael. CC: Jason Wang CC: Michael S. Tsirkin CC: Paolo Bonzini Signed-off-by: Peter Xu --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index dec252f38b..569cfc1fcd 100644 --- a/MAINTAINERS +++

Re: [PULL 3/6] MAINTAINERS: Add Loongson-3 maintainer and reviewer

On 6/29/20 11:56 AM, Aleksandar Markovic wrote: > понедељак, 29. јун 2020., Philippe Mathieu-Daudé > је написао/ла: > > On 6/27/20 9:51 PM, Aleksandar Markovic wrote: > > From: Huacai Chen > > > > > Add myself as the

Re: [PATCH 2/2] iscsi: return -EIO when sense fields are meaningless

On 01/07/20 12:54, Xie Yongji wrote: > When an I/O request failed, now we only return correct > value on scsi check condition. We should also have a > default errno such as -EIO in other case. > > Signed-off-by: Xie Yongji > --- > block/iscsi.c | 2 ++ > 1 file changed, 2 insertions(+) > >

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

On Wed, Jul 01, 2020 at 08:30:07PM +0800, Jason Wang wrote: > > I overlooked myself that the IR region will be there even if ir=off. > > > Yes, but the point stands still but the issue is still if ir=off. > > > >So I > > think the assert should stand. > > > Do you mean vhost can't

[PATCH 1/1] scripts/performance: Add dissect.py script

Python script that dissects QEMU execution into three main phases: code generation, JIT execution and helpers execution. Syntax: dissect.py [-h] -- [] \ [] [-h] - Print the script arguments help message. Example of usage: dissect.py -- qemu-arm coulomb_double-arm Example

Re: [PATCH] pc: fix leak in pc_system_flash_cleanup_unused

On 200701 0749, Paolo Bonzini wrote: > On 01/07/20 03:58, Alexander Bulekov wrote: > > fix a leak detected when building with --enable-sanitizers: > > ./i386-softmmu/qemu-system-i386 > > Upon exit: > > ==13576==ERROR: LeakSanitizer: detected memory leaks > > > > Direct leak of 1216 byte(s) in 1

[PATCH 0/1] Add Script for Dissecting QEMU Execution

Hi, This series adds the dissect.py script which breaks down the execution of QEMU into three main phases: code generation, JIT execution, and helpers execution. It prints the number of instructions executed by QEMU in each of these three phases, plus the total number of executed instructions.

nvme emulation merge process (was: Re: [PATCH 00/10] hw/block/nvme: namespace types and zoned namespaces)

Am 30.06.2020 um 22:36 hat Klaus Jensen geschrieben: > On Jun 30 08:42, Keith Busch wrote: > > On Tue, Jun 30, 2020 at 04:09:46PM +0200, Philippe Mathieu-Daudé wrote: > > > What I see doable for the following days is: > > > - hw/block/nvme: Fix I/O BAR structure [3] > > > - hw/block/nvme: handle

Re: [PATCH 2/4] migration: Add block-bitmap-mapping parameter

On 30.06.20 12:51, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: >> This migration parameter allows mapping block node names and bitmap >> names to aliases for the purpose of block dirty bitmap migration. >> >> This way, management tools can use different node and bitmap

Re: [PATCH v2 6/6] hw/mips/malta: Introduce the 'malta-unleashed' 64-bit machine

On Tue, Jun 30, 2020 at 04:52:36PM +0200, Philippe Mathieu-Daudé wrote: > Introduce the 'malta-unleashed' machine. This machine does not > model any existing hardware (as the default 'malta' neither model > a real hardware). The purpose of this machine is to allow user > of the current 'malta'

Re: [PATCH 0/2] two atomic_cmpxchg() related fixes

On Tue, 16 Jun 2020 06:50:33 +0200 Halil Pasic wrote: > The story short: compiler can generate code that does two > distinct fetches of *ind_addr for old and _old. If that happens we can > not figure out if we had the desired xchg or not. > > Halil Pasic (2): > virtio-ccw: fix

Re: [PATCH] acpi: Fix access to PM1 control and status registers

On Wed, Jul 01, 2020 at 12:05:49PM +0100, Anthony PERARD wrote: > The ACPI spec state that "Accesses to PM1 control registers are > accessed through byte and word accesses." (In section 4.7.3.2.1 PM1 > Control Registers of my old spec copy rev 4.0a). > > With commit 5d971f9e6725 ("memory: Revert

[PATCH v2] tests: disassemble-aml.sh: generate AML in readable format

On systems where the IASL tool exists, we can convert extected ACPI tables to ASL format, which is useful for debugging and documentation purposes. This script does this for all ACPI tables under tests/data/acpi/. Signed-off-by: Michael S. Tsirkin --- changes from v1: - suggest the script

Re: [PATCH 2/2] checkpatch: Change occurences of 'kernel' to 'qemu' in user messages

On Sat, Jun 20, 2020 at 9:32 AM Aleksandar Markovic wrote: > > It is odd that we inform user that, for example, his current working > directory is not kernel root, when, in face, we mean qemu root. > > Replace that and few other similar odd user messages. > > Signed-off-by: Aleksandar Markovic >

Re: [PATCH v2] chardev/tcp: fix error message double free error

On 01/07/20 09:06, Markus Armbruster wrote: > lichun writes: > >> Signed-off-by: lichun >> --- >> chardev/char-socket.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/chardev/char-socket.c b/chardev/char-socket.c >> index afebeec5c3..569d54c144 100644 >> ---

Re: [PATCH v7 13/21] multi-process: Forward PCI config space acceses to the remote process

On Sat, Jun 27, 2020 at 10:09:35AM -0700, elena.ufimts...@oracle.com wrote: > @@ -42,6 +48,12 @@ gboolean mpqemu_process_msg(QIOChannel *ioc, GIOCondition > cond, > case CONNECT_DEV: > process_connect_dev_msg(, ioc, _err); > break; > +case PCI_CONFIG_WRITE: > +

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

On Mittwoch, 1. Juli 2020 12:09:24 CEST Greg Kurz wrote: > No I'm talking about code that isn't changed by this series: > > if (initial_offset == 0) { > v9fs_co_rewinddir(pdu, fidp); > } else { > v9fs_co_seekdir(pdu, fidp, initial_offset); > } > count =

Re: [PATCH v3 0/9] Generalize memory encryption models

On Fri, 26 Jun 2020 14:49:37 +0200 Janosch Frank wrote: > On 6/26/20 12:58 PM, Daniel P. Berrangé wrote: > > On Fri, Jun 26, 2020 at 11:29:03AM +0100, Dr. David Alan Gilbert wrote: > >> * Janosch Frank (fran...@linux.ibm.com) wrote: > >>> On 6/26/20 11:32 AM, Daniel P. Berrangé wrote: > On

Re: [PATCH v4 0/3] Avoid abort on QMP attempt to add an object with duplicate id

On 01/07/20 08:51, Auger Eric wrote: >> Very nice. I see a failure reported by Patchew, I'll look into it as >> well if you don't have time. > > So "[PATCH v5 0/3] Avoid abort on QMP attempt to add an object with > duplicate id" seems to have fixed the Patchew error (I decreased the > size of

Re: [PATCH v9 13/34] qcow2: Update get/set_l2_entry() and add get/set_l2_bitmap()

On 28.06.20 13:02, Alberto Garcia wrote: > Extended L2 entries are 128-bit wide: 64 bits for the entry itself and > 64 bits for the subcluster allocation bitmap. > > In order to support them correctly get/set_l2_entry() need to be > updated so they take the entry width into account in order to >

Re: [PATCH 2/2] xen: cleanup unrealized flash devices

On 7/1/20 2:25 PM, Jason Andryuk wrote: > On Wed, Jul 1, 2020 at 3:03 AM Paul Durrant wrote: >> >>> -Original Message- >>> From: Philippe Mathieu-Daudé >>> Sent: 30 June 2020 18:27 >>> To: p...@xen.org; xen-de...@lists.xenproject.org; qemu-devel@nongnu.org >>> Cc: 'Eduardo Habkost' ;

Re: [PATCH 0/2] hw/block/nvme: handle transient dma errors

On 6/29/20 11:34 PM, Klaus Jensen wrote: > On Jun 29 14:07, no-re...@patchew.org wrote: >> Patchew URL: >> https://patchew.org/QEMU/20200629202053.1223342-1-...@irrelevant.dk/ >> --- /tmp/qemu-test/src/tests/qemu-iotests/040.out 2020-06-29 >> 20:12:10.0 + >> +++

[Bug 1885889] Re: ERROR: core-image-minimal-1.0-r0 do_rootfs: The postinstall intercept hook 'update_font_cache' failed,

I am running this under below ubuntu environment. santhosh@santhosh-VirtualBox:~/Denverton/Source/BSP/poky$ uname -a Linux santhosh-VirtualBox 4.15.0-108-generic #109-Ubuntu SMP Fri Jun 19 11:33:10 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux santhosh@santhosh-VirtualBox:~/Denverton/Source/BSP/poky$

Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

On Tue, Jun 30, 2020 at 05:38:25PM +0200, Aleksandar Markovic wrote: > уто, 30. јун 2020. у 16:52 Philippe Mathieu-Daudé је > написао/ла: > > > > Hi, > > > > This series add a new 'malta-strict' machine, that aims to properly > > model the real hardware (which is not what the current 'malta' > >

Re: [PATCH] acpi: Fix access to PM1 control and status registers

On Wed, Jul 01, 2020 at 08:01:55AM -0400, Michael S. Tsirkin wrote: > On Wed, Jul 01, 2020 at 12:05:49PM +0100, Anthony PERARD wrote: > > The ACPI spec state that "Accesses to PM1 control registers are > > accessed through byte and word accesses." (In section 4.7.3.2.1 PM1 > > Control Registers of

[PATCH v4 00/40] testing/next (vm, gitlab, fixes)

Hi, This is the next iteration of my testing/next queue. It has grown by a further 9 patches. The last iteration was: https://patchew.org/QEMU/20200626181357.26211-1-alex.ben...@linaro.org/ I've ironed out the final problems with GitLab failures through a combination of fixes for linux-user

[PATCH v4 12/40] python/qemu: Add ConsoleSocket for optional use in QEMUMachine

From: Robert Foley We add the ConsoleSocket object, which has a socket interface and which will consume all arriving characters on the socket, placing them into an in memory buffer. This will also provide those chars via recv() as would a regular socket. ConsoleSocket also has the option of

[PATCH v4 03/40] crypto/linux_keyring: fix 'secret_keyring' configure test

From: David Edmondson The configure test for 'secret_keyring' incorrectly checked the 'have_keyring' variable. Fixes: 54e7aac0562452e4fcab65ca5001d030eef2de15 Signed-off-by: David Edmondson Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id:

[PATCH v4 01/40] hw/isa: check for current_cpu before generating IRQ

It's possible to trigger this function from qtest/monitor at which point current_cpu won't point at the right place. Check it and fall back to first_cpu if it's NULL. Signed-off-by: Alex Bennée Cc: Bug 1878645 <1878...@bugs.launchpad.net> --- hw/isa/lpc_ich9.c | 2 +- 1 file changed, 1

[PATCH v4 34/40] gitlab: enable check-tcg for linux-user tests

Switch to building in the new debian-all-test-cross image which has most of the cross compilers inline. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- .gitlab-ci.yml | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH v4 36/40] gitlab: split build-disabled into two phases

As we run check-qtest in "SLOW" mode this can timeout so split into two jobs. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- v4 - rename :->- --- .gitlab-ci.yml | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[PATCH v4 14/40] tests/vm: switch from optsparse to argparse

optparse has been deprecated since version 3.2 and argparse is the blessed replacement. Take the opportunity to enhance our help output showing defaults when called. Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé Reviewed-by: Robert Foley --- v2 - add explicit

[PATCH v4 23/40] gitlab: build containers with buildkit and metadata

According to the documentation to be able to use --cache-from for remote registries you need to enable both buildkit and inline the metadata. We want to do this to support pulling from gitlab when users build their local docker images. Signed-off-by: Alex Bennée --- .gitlab-ci.d/containers.yml

[PATCH v4 38/40] containers.yml: build with docker.py tooling

Instead of building the docker files directly use the same docker.py scripting as we do for building locally. This should help ensure we use the exact same steps and allow us to cache properly when building locally. To get this working you have to have a fairly recent docker binary otherwise you

[PATCH v4 17/40] tests/docker: change tag naming scheme of our images

We've been misusing the tag naming scheme for some time by overloading the post : section with the image type. Really it should be saved for the revision of that particular build. Move the details to the other side so we have: qemu/image-name with the implied :latest version added by the

[PATCH v4 31/40] tests/tcg: add more default compilers to configure.sh

We were missing a bunch of compilers which we could use if they were locally installed. The defaults are based on Debian as they seem to be the best distro for well distributed cross-build compilers. Signed-off-by: Alex Bennée --- tests/tcg/configure.sh | 19 ++- 1 file changed,

[PATCH v4 28/40] tests/acceptance: skip multicore mips_malta tests on GitLab

For some reason these tests fail all the time on GitLab. I can re-create the hang around 3% of the time locally but it doesn't seem to be MTTCG related. For now skipIf on GITLAB_CI. Signed-off-by: Alex Bennée Cc: Aleksandar Markovic --- tests/acceptance/machine_mips_malta.py | 3 +++ 1 file

Re: [PATCH 2/2] target-i386: sev: fail query-sev-capabilities if QEMU cannot use SEV

On 6/30/20 10:45 AM, Paolo Bonzini wrote: In some cases, such as if the kvm-amd "sev" module parameter is set to 0, SEV will be unavailable but query-sev-capabilities will still return all the information. This tricks libvirt into erroneously reporting that SEV is available. Check the actual

Re: [PATCH v2] tests: disassemble-aml.sh: generate AML in readable format

Patchew URL: https://patchew.org/QEMU/20200701121349.50523-1-...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2] tests: disassemble-aml.sh: generate AML in readable format Type: series Message-id:

[PULL 01/13] sm501: Fix bounds checks

From: BALATON Zoltan We don't need to add width to pitch when calculating last point, that would reject valid ops within the card's local_mem. Fixes: b15a22bbcbe6a78dc3d88fe3134985e4cdd87de4 Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell Message-id:

[PATCH v4 12/14] vhost_net: introduce set_config & get_config

This patch introduces set_config & get_config method which allows vhost_net set/get the config to backend Signed-off-by: Cindy Lu --- hw/net/vhost_net-stub.c | 11 +++ hw/net/vhost_net.c | 10 ++ include/net/vhost_net.h | 5 + 3 files changed, 26 insertions(+) diff

[PULL 05/13] sm501: Optimise 1 pixel 2d ops

From: BALATON Zoltan Some guests do 1x1 blits which is faster to do directly than calling a function for it so avoid overhead in this case. Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell Message-id: 7302d7b4c5c313bad7681ac4686417143c3e.1592686588.git.bala...@eik.bme.hu

Re: [PATCH v2] pc: fix leak in pc_system_flash_cleanup_unused

On 01/07/20 16:52, Alexander Bulekov wrote: > tries to fix a leak detected when building with --enable-sanitizers: > ./i386-softmmu/qemu-system-i386 > Upon exit: > ==13576==ERROR: LeakSanitizer: detected memory leaks > > Direct leak of 1216 byte(s) in 1 object(s) allocated from: > #0

Re: [PATC 7/9] Skipping drm build, unsupported

> > Ah, that is the problem. Yes, DT_CHR is an non-posix optimization which > > allows to get the file type directly, without another round-trip to the > > kernel. If that isn't available you can stat() the file and check > > ((st_mode & S_IFMT) == S_IFCHR) instead. > > Even when d_type and

[PATCH v12 03/61] target/riscv: support vector extension csr

The v0.7.1 specification does not define vector status within mstatus. A future revision will define the privileged portion of the vector status. Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson --- target/riscv/cpu_bits.h | 15 +

[PATCH v12 02/61] target/riscv: implementation-defined constant parameters

vlen is the vector register length in bits. elen is the max element size in bits. vext_spec is the vector specification version, default value is v0.7.1. Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson --- target/riscv/cpu.c | 7 +++

Re: [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership

On 01/07/20 15:53, Aleksandar Markovic wrote: > Although, honestly speaking, your > credentials for being a maintainer are - at least - three order of > magnitude higher than for some other maintainer. Aleksandar, this is not an acceptable way to refer to other people contributing to QEMU. To

[PATCH v12 10/61] target/riscv: vector single-width integer add and subtract

Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson --- target/riscv/helper.h | 25 ++ target/riscv/insn32.decode | 10 + target/riscv/insn_trans/trans_rvv.inc.c | 291 target/riscv/vector_helper.c

[PATCH v12 15/61] target/riscv: vector narrowing integer right shift instructions

Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/helper.h | 13 target/riscv/insn32.decode | 6 ++ target/riscv/insn_trans/trans_rvv.inc.c | 90 + target/riscv/vector_helper.c

[PATCH v12 17/61] target/riscv: vector integer min/max instructions

Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/helper.h | 33 target/riscv/insn32.decode | 8 +++ target/riscv/insn_trans/trans_rvv.inc.c | 10 target/riscv/vector_helper.c|

[PATCH v12 20/61] target/riscv: vector widening integer multiply instructions

Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/helper.h | 19 + target/riscv/insn32.decode | 6 +++ target/riscv/insn_trans/trans_rvv.inc.c | 8 target/riscv/vector_helper.c| 51

[PATCH v2 0/3] some docs (booting, mttcg, icount)

Hi, This is the current state of documentation patches. They didn't get much review the first time around so I present them as a series. I Think we should merge them unless anyone want to argue they actively muddy our document situation? The following have no reviews: - docs/devel: convert and

[PATCH 2/3] util: support detailed error reporting for qemu_open

Create a "qemu_open_err" method which does the same as "qemu_open", but with a "Error **errp" for error reporting. There should be no behavioural difference for existing callers at this stage. Signed-off-by: Daniel P. Berrangé --- include/qemu/osdep.h | 1 + util/osdep.c | 71

Re: [PATCH v2 3/3] trace: Example of "centralized" recorder tracing

On Tue, Jun 30, 2020 at 01:41:36PM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 26, 2020 at 06:27:06PM +0200, Christophe de Dinechin wrote: > IMHO the whole point of having the pluggable trace backend impls, is > precisely that we don't have to add multiple different calls in the > code. A

Re: [PATCH RFC] virtio-fs: force virtio 1.x usage

On Tue, 30 Jun 2020 09:04:38 -0400 "Michael S. Tsirkin" wrote: > On Tue, Jun 30, 2020 at 02:25:04PM +0200, Cornelia Huck wrote: > > What bothers me most is that you need to explicitly request a device to > > be modern-only, while that should be the default for any newly added > > device. Hence

[PATCH v12 26/61] target/riscv: vector single-width fractional multiply with rounding and saturation

Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson --- target/riscv/helper.h | 9 ++ target/riscv/insn32.decode | 2 + target/riscv/insn_trans/trans_rvv.inc.c | 4 + target/riscv/vector_helper.c| 107

Re: [PATCH] KVM: add support for AMD nested live migration

Il mer 1 lug 2020, 18:28 Dr. David Alan Gilbert ha scritto: > > > +return (nested_state->format == KVM_STATE_NESTED_FORMAT_SVM && > > +nested_state->size > offsetof(struct kvm_nested_state, > data)); > > How does this nested_state->size work? It looks like even if it's 1 byte >

Re: [PATCH v4 01/40] hw/isa: check for current_cpu before generating IRQ

On 7/1/20 6:40 PM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> On 7/1/20 3:56 PM, Alex Bennée wrote: >>> It's possible to trigger this function from qtest/monitor at which >>> point current_cpu won't point at the right place. Check it and >>> fall back to first_cpu if it's NULL.

[PATCH v12 49/61] target/riscv: vector mask-register logical instructions

Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson --- target/riscv/helper.h | 9 ++ target/riscv/insn32.decode | 8 + target/riscv/insn_trans/trans_rvv.inc.c | 35 ++ target/riscv/vector_helper.c| 40

[PATCH v12 48/61] target/riscv: vector widening floating-point reduction instructions

Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/helper.h | 3 ++ target/riscv/insn32.decode | 2 ++ target/riscv/insn_trans/trans_rvv.inc.c | 3 ++ target/riscv/vector_helper.c| 46

[PATCH v4 08/40] tests/vm: Add common Ubuntu python module

From: Robert Foley Add a common Ubuntu python module and make use of it with the ubuntu.i386 script. This is preparation for adding an Ubuntu script ubuntu.aarch64. Splitting out the common logic such as build_image() will reduce duplication. Signed-off-by: Robert Foley Tested-by: Philippe

[PATCH v4 05/40] tests/vm: pass args through to BaseVM's __init__

From: Robert Foley Adding the args parameter to BaseVM's __init__. We will shortly need to pass more parameters to the class so let's just pass args rather than growing the parameter list. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by:

[PATCH v4 04/40] util/coroutine: Cleanup start_switch_fiber_ for TSAN.

From: Robert Foley This is a cleanup patch to follow-up the patch which introduced TSAN. This patch makes separate start_switch_fiber_ functions for TSAN and ASAN. This does two things: 1. Unrelated ASAN and TSAN code is separate and each function only has arguments that are actually needed.

[PATCH v4 02/40] iotests: Fix 051 output after qdev_init_nofail() removal

From: Philippe Mathieu-Daudé Commit 96927c744 replaced qdev_init_nofail() call by isa_realize_and_unref() which has a different error message. Update the test output accordingly. Gitlab CI error after merging b77b5b3dc7: https://gitlab.com/qemu-project/qemu/-/jobs/597414772#L4375 Reported-by:

  1   2   3   4   5   >