[PULL 14/28] aspeed: Clean up roundabout error propagation

2020-07-02 Thread Markus Armbruster
Replace sysbus_realize(SYS_BUS_DEVICE(>spi[i]), _err); error_propagate(, local_err); if (err) { error_propagate(errp, err); return; } by sysbus_realize(SYS_BUS_DEVICE(>spi[i]), ); if (err) {

[PULL 19/28] riscv/sifive_u: Fix sifive_u_soc_realize() error API violations

2020-07-02 Thread Markus Armbruster
The Error ** argument must be NULL, _abort, _fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. sifive_u_soc_realize() is wrong

[PULL 09/28] spapr: Plug minor memory leak in spapr_machine_init()

2020-07-02 Thread Markus Armbruster
spapr_machine_init() leaks an Error object when kvmppc_check_papr_resize_hpt() fails and spapr->resize_hpt is SPAPR_RESIZE_HPT_DISABLED, i.e. when the host doesn't support hash page table resizing, and the user didn't ask for it. As harmless as memory leaks can possibly be. Plug it. Fixes:

Re: [PATCH 3/4] hw/arm/virt-acpi-build: Only expose flash on older machine types

2020-07-02 Thread Michael S. Tsirkin
On Thu, Jul 02, 2020 at 11:16:03AM +0100, Peter Maydell wrote: > On Thu, 2 Jul 2020 at 10:53, Michael S. Tsirkin wrote: > > > > On Mon, Jun 29, 2020 at 04:09:37PM +0200, Andrew Jones wrote: > > > The flash device is exclusively for the host-controlled firmware, so > > > we should not expose it to

[PULL 04/28] pci: Delete useless error_propagate()

2020-07-02 Thread Markus Armbruster
Cc: Jens Freimann Cc: Michael S. Tsirkin Cc: Marcel Apfelbaum Signed-off-by: Markus Armbruster Reviewed-by: Jens Freimann Reviewed-by: Michael S. Tsirkin Message-Id: <20200630090351.1247703-3-arm...@redhat.com> --- hw/pci/pci.c | 3 --- 1 file changed, 3 deletions(-) diff --git

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-07-02 Thread Christian Schoenebeck
On Mittwoch, 1. Juli 2020 17:12:40 CEST Greg Kurz wrote: > On Wed, 01 Jul 2020 13:47:12 +0200 > > Christian Schoenebeck wrote: > > On Mittwoch, 1. Juli 2020 12:09:24 CEST Greg Kurz wrote: > > > No I'm talking about code that isn't changed by this series: > > > if (initial_offset == 0) { > >

Re: Properly quitting qemu immediately after failing migration

2020-07-02 Thread Vladimir Sementsov-Ogievskiy
02.07.2020 10:23, Max Reitz wrote: On 01.07.20 18:16, Vladimir Sementsov-Ogievskiy wrote: 29.06.2020 18:00, Max Reitz wrote: On 29.06.20 16:18, Vladimir Sementsov-Ogievskiy wrote: 29.06.2020 16:48, Max Reitz wrote: Hi, In an iotest, I’m trying to quit qemu immediately after a migration has

[PULL 02/10] object: qom module support

2020-07-02 Thread Gerd Hoffmann
Little helper function to load modules on demand. In most cases adding module loading support for devices and other objects is just s/object_class_by_name/module_object_class_by_name/ in the right spot. Signed-off-by: Gerd Hoffmann Message-id: 20200624131045.14512-3-kra...@redhat.com ---

[PULL 04/10] build: fix device module builds

2020-07-02 Thread Gerd Hoffmann
See comment. Feels quite hackish. Better ideas anyone? Signed-off-by: Gerd Hoffmann Message-id: 20200624131045.14512-5-kra...@redhat.com --- Makefile.target | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Makefile.target b/Makefile.target index 8ed1eba95b9c..c70325df5796 100644 ---

[PULL 00/10] Modules 20200702 patches

2020-07-02 Thread Gerd Hoffmann
The following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab: hw/misc/pca9552: Add missing TypeInfo::class_size field (2020-06-29 21:16:10 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/modules-20200702-pull-request for you to fetch changes up

[PULL 03/10] qdev: device module support

2020-07-02 Thread Gerd Hoffmann
Hook module loading into the places where we need it when building devices as modules. Signed-off-by: Gerd Hoffmann Message-id: 20200624131045.14512-4-kra...@redhat.com --- hw/core/qdev.c | 6 -- qdev-monitor.c | 5 +++-- qom/qom-qmp-cmds.c | 3 ++- softmmu/vl.c | 4 ++-- 4

Re: [PATCH] MAINTAINERS: update linux-user maintainer

2020-07-02 Thread Philippe Mathieu-Daudé
On 7/2/20 1:16 PM, riku.voi...@linaro.org wrote: > From: Riku Voipio > > I haven't been active for a while. Pass the maintainer hat > forward to Laurent, who has done a stellar job filling in. > > Signed-off-by: Riku Voipio Thanks a lot for your contributions Riku!!! FWIW: Reviewed-by:

Re: [PATCH v7 17/21] multi-process: Retrieve PCI info from remote process

2020-07-02 Thread Stefan Hajnoczi
On Sat, Jun 27, 2020 at 10:09:39AM -0700, elena.ufimts...@oracle.com wrote: > @@ -267,3 +275,84 @@ const MemoryRegionOps proxy_mr_ops = { > .max_access_size = 1, > }, > }; > + > +static void probe_pci_info(PCIDevice *dev) > +{ > +PCIDeviceClass *pc = PCI_DEVICE_GET_CLASS(dev); >

Re: Properly quitting qemu immediately after failing migration

2020-07-02 Thread Vladimir Sementsov-Ogievskiy
02.07.2020 14:44, Vladimir Sementsov-Ogievskiy wrote: 02.07.2020 10:23, Max Reitz wrote: On 01.07.20 18:16, Vladimir Sementsov-Ogievskiy wrote: 29.06.2020 18:00, Max Reitz wrote: On 29.06.20 16:18, Vladimir Sementsov-Ogievskiy wrote: 29.06.2020 16:48, Max Reitz wrote: Hi, In an iotest, I’m

Re: [PATCH v9 22/34] qcow2: Add subcluster support to zero_in_l2_slice()

2020-07-02 Thread Max Reitz
On 28.06.20 13:02, Alberto Garcia wrote: > The QCOW_OFLAG_ZERO bit that indicates that a cluster reads as > zeroes is only used in standard L2 entries. Extended L2 entries use > individual 'all zeroes' bits for each subcluster. > > This must be taken into account when updating the L2 entry and

Re: [PATCH RFC] virtio-fs: force virtio 1.x usage

2020-07-02 Thread Michael S. Tsirkin
On Thu, Jul 02, 2020 at 01:55:59PM +0200, Cornelia Huck wrote: > On Thu, 2 Jul 2020 07:22:49 -0400 > "Michael S. Tsirkin" wrote: > > > On Thu, Jul 02, 2020 at 12:45:38PM +0200, Cornelia Huck wrote: > > > On Thu, 2 Jul 2020 06:16:06 -0400 > > > "Michael S. Tsirkin" wrote: > > > > > > > On

[PATCH v5 11/20] pc_basic_device_init: pass PCMachineState

2020-07-02 Thread Gerd Hoffmann
Need access to pcms for pcspk initialization. Just preparation, no functional change. Signed-off-by: Gerd Hoffmann --- include/hw/i386/pc.h | 3 ++- hw/i386/pc.c | 3 ++- hw/i386/pc_piix.c| 2 +- hw/i386/pc_q35.c | 2 +- 4 files changed, 6 insertions(+), 4 deletions(-) diff

[PATCH v5 05/20] audio: deprecate -soundhw es1370

2020-07-02 Thread Gerd Hoffmann
Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Add an alias so both es1370 and ES1370 are working with -device. Signed-off-by: Gerd Hoffmann --- hw/audio/es1370.c | 9 ++--- qdev-monitor.c| 1 + 2 files changed, 3 insertions(+), 7 deletions(-) diff

[PULL 00/28] Error reporting patches patches for 2020-07-02

2020-07-02 Thread Markus Armbruster
The following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab: hw/misc/pca9552: Add missing TypeInfo::class_size field (2020-06-29 21:16:10 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-error-2020-07-02 for you to fetch changes up

[PULL 23/28] amd_iommu: Fix amdvi_realize() error API violation

2020-07-02 Thread Markus Armbruster
The Error ** argument must be NULL, _abort, _fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. amdvi_realize() is wrong that

Re: [PATCH v7 0/5] VIRTIO-IOMMU probe request support and MSI bypass on ARM

2020-07-02 Thread Auger Eric
Hi, On 6/29/20 9:03 AM, Eric Auger wrote: > By default the virtio-iommu translates MSI transactions. This > behavior is inherited from ARM SMMU. However the virt machine > code knows where the MSI doorbells are, so we can easily > declare those regions as VIRTIO_IOMMU_RESV_MEM_T_MSI. With that >

Re: [PATCH 0/4] migration: Add block-bitmap-mapping parameter

2020-07-02 Thread Vladimir Sementsov-Ogievskiy
Hmm, seems, you didn't use scripts/get_maintainer.pl, as neither Eric nor John are in Cc. Add them. 30.06.2020 11:45, Max Reitz wrote: RFC v1: https://lists.nongnu.org/archive/html/qemu-block/2020-05/msg00912.html RFC v2: https://lists.nongnu.org/archive/html/qemu-block/2020-05/msg00915.html

Re: [PATCH v7 0/5] VIRTIO-IOMMU probe request support and MSI bypass on ARM

2020-07-02 Thread Michael S. Tsirkin
On Mon, Jun 29, 2020 at 09:03:59AM +0200, Eric Auger wrote: > By default the virtio-iommu translates MSI transactions. This > behavior is inherited from ARM SMMU. However the virt machine > code knows where the MSI doorbells are, so we can easily > declare those regions as

Re: [PATCH v7 5/5] hw/arm/virt: Let the virtio-iommu bypass MSIs

2020-07-02 Thread Michael S. Tsirkin
On Mon, Jun 29, 2020 at 09:04:04AM +0200, Eric Auger wrote: > At the moment the virtio-iommu translates MSI transactions. > This behavior is inherited from ARM SMMU. The virt machine > code knows where the guest MSI doorbells are so we can easily > declare those regions as

[PULL SUBSYSTEM s390x 09/11] pc-bios: s390x: Make u32 ptr check explicit

2020-07-02 Thread Thomas Huth
From: Janosch Frank Let's make it a bit more clear that we check the full 64 bits to fit into the 32 we return. Signed-off-by: Janosch Frank Suggested-by: David Hildenbrand Reviewed-by: David Hildenbrand Reviewed-by: Thomas Huth Message-Id: <20200624075226.92728-11-fran...@linux.ibm.com>

[PULL SUBSYSTEM s390x 04/11] pc-bios: s390x: Get rid of magic offsets into the lowcore

2020-07-02 Thread Thomas Huth
From: Janosch Frank If we have a lowcore struct that has members for offsets that we want to touch, why not use it? Signed-off-by: Janosch Frank Reviewed-by: David Hildenbrand Reviewed-by: Thomas Huth Reviewed-by: Cornelia Huck Message-Id: <20200624075226.92728-5-fran...@linux.ibm.com>

Re: [PULL SUBSYSTEM s390x 00/11] s390-ccw bios update

2020-07-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200702115045.6171-1-th...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL SUBSYSTEM s390x 00/11] s390-ccw bios update Type: series Message-id:

[PULL 07/10] vga: build qxl as module

2020-07-02 Thread Gerd Hoffmann
First step in making spice support modular. Signed-off-by: Gerd Hoffmann Message-id: 20200624131045.14512-8-kra...@redhat.com --- util/module.c| 2 ++ hw/Makefile.objs | 1 + hw/display/Makefile.objs | 5 - 3 files changed, 7 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 2/2] configure: add support for Control-Flow Integrity

2020-07-02 Thread Daniel P . Berrangé
On Thu, Jul 02, 2020 at 08:50:08AM -0400, Daniele Buono wrote: > > > On 7/2/2020 5:52 AM, Daniel P. Berrangé wrote: > > On Thu, Jul 02, 2020 at 01:49:48AM -0400, Daniele Buono wrote: > > > This patch adds a flag to enable/disable control flow integrity checks > > > on indirect function calls.

Re: [PATCH v7 0/5] VIRTIO-IOMMU probe request support and MSI bypass on ARM

2020-07-02 Thread Michael S. Tsirkin
On Thu, Jul 02, 2020 at 02:01:46PM +0200, Auger Eric wrote: > Hi Michael, > > On 7/2/20 1:28 PM, Michael S. Tsirkin wrote: > > On Mon, Jun 29, 2020 at 09:03:59AM +0200, Eric Auger wrote: > >> By default the virtio-iommu translates MSI transactions. This > >> behavior is inherited from ARM SMMU.

Re: [PATCH v7 19/21] multi-process: perform device reset in the remote process

2020-07-02 Thread Stefan Hajnoczi
On Sat, Jun 27, 2020 at 10:09:41AM -0700, elena.ufimts...@oracle.com wrote: > @@ -283,3 +288,14 @@ static void process_proxy_ping_msg(QIOChannel *ioc) > > mpqemu_msg_send(, ioc); > } > + > +static void process_device_reset_msg(QIOChannel *ioc) > +{ > +MPQemuMsg ret = { 0 }; > + > +

[PATCH v5 03/20] audio: add deprecated_register_soundhw

2020-07-02 Thread Gerd Hoffmann
Add helper function for -soundhw deprecation. It can replace the simple init functions which just call {isa,pci}_create_simple() with a hardcoded type. It also prints a deprecation message. Signed-off-by: Gerd Hoffmann --- include/hw/audio/soundhw.h | 2 ++ hw/audio/soundhw.c | 24

[PATCH v5 12/20] pc_basic_device_init: drop has_pit arg

2020-07-02 Thread Gerd Hoffmann
Now that we pass pcms anyway, we don't need the has_pit arg any more. No functional change. Signed-off-by: Gerd Hoffmann --- include/hw/i386/pc.h | 1 - hw/i386/pc.c | 3 +-- hw/i386/pc_piix.c| 2 +- hw/i386/pc_q35.c | 2 +- 4 files changed, 3 insertions(+), 5 deletions(-) diff

[PATCH v5 14/20] softmmu: initialize spice and audio earlier

2020-07-02 Thread Gerd Hoffmann
audiodev must be initialized before machine_set_property so the machine can have audiodev property aliases. spice must initialize before audiodev because the default audiodev is spice only in case spice is actually enabled. Signed-off-by: Gerd Hoffmann --- softmmu/vl.c | 12 ++-- 1

[PATCH 3/5] MAINTAINERS: Adjust MIPS maintainership (remove Aurelien Jarno)

2020-07-02 Thread Philippe Mathieu-Daudé
From: Aleksandar Markovic Aurelien Jarno removed for not being present. Aleksandar Markovic comment: A polite email was sent [less than 12 hours ago (Peter Maydell was Cc:ed and can confirm)] to him with question whether he intend to actively participate, but there was no response.

Re: [PATCH v5 11/20] pc_basic_device_init: pass PCMachineState

2020-07-02 Thread Philippe Mathieu-Daudé
On 7/2/20 3:25 PM, Gerd Hoffmann wrote: > Need access to pcms for pcspk initialization. > Just preparation, no functional change. > > Signed-off-by: Gerd Hoffmann > --- > include/hw/i386/pc.h | 3 ++- > hw/i386/pc.c | 3 ++- > hw/i386/pc_piix.c| 2 +- > hw/i386/pc_q35.c | 2 +- >

Re: [PATCH v2 0/1] Add Script for Dissecting QEMU Execution

2020-07-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200702142942.4887-1-ahmedkhaledkara...@gmail.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a

Re: [PATCH v9 30/34] qcow2: Add prealloc field to QCowL2Meta

2020-07-02 Thread Max Reitz
On 02.07.20 16:58, Eric Blake wrote: > On 7/2/20 9:50 AM, Max Reitz wrote: >> On 28.06.20 13:02, Alberto Garcia wrote: >>> This field allows us to indicate that the L2 metadata update does not >>> come from a write request with actual data but from a preallocation >>> request. >>> >>> For

[PULL 13/28] vnc: Plug minor memory leak in vnc_display_open()

2020-07-02 Thread Markus Armbruster
vnc_display_print_local_addr() leaks the Error object when qio_channel_socket_get_local_address() fails. Seems unlikely. Called when we create a VNC display with vnc_display_open(). Plug the leak by passing NULL to ignore the error. Cc: Daniel P. Berrange Cc: Gerd Hoffmann Signed-off-by:

[PULL 26/28] hw/arm/armsse: Fix armsse_realize() error API violation

2020-07-02 Thread Markus Armbruster
The Error ** argument must be NULL, _abort, _fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. armsse_realize() is wrong that

[PULL 17/28] hw: Fix error API violation around object_property_set_link()

2020-07-02 Thread Markus Armbruster
The Error ** argument must be NULL, _abort, _fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. virtio_gpu_pci_base_realize(),

Re: [PATCH v7 0/5] VIRTIO-IOMMU probe request support and MSI bypass on ARM

2020-07-02 Thread Auger Eric
Hi Michael, On 7/2/20 1:28 PM, Michael S. Tsirkin wrote: > On Mon, Jun 29, 2020 at 09:03:59AM +0200, Eric Auger wrote: >> By default the virtio-iommu translates MSI transactions. This >> behavior is inherited from ARM SMMU. However the virt machine >> code knows where the MSI doorbells are, so we

Re: [PATCH v3 0/2] target mips: Misc fixes and improvements

2020-07-02 Thread Philippe Mathieu-Daudé
On 7/1/20 8:25 PM, Aleksandar Markovic wrote: > A collection of pending fixes and improvements. > > v2->v3: > > - minor content and commit message changes > > v1->v2: > > - minor content and commit message changes > > Aleksandar Markovic (2): > target/mips: Remove identical if/else

Re: [PATCH 07/46] error: Avoid more error_propagate() when error is not used here

2020-07-02 Thread Markus Armbruster
Markus Armbruster writes: > Vladimir Sementsov-Ogievskiy writes: > >> 24.06.2020 19:43, Markus Armbruster wrote: >>> When all we do with an Error we receive into a local variable is >>> propagating to somewhere else, we can just as well receive it there >>> right away. The previous commit did

[PATCH v5 00/20] audio: deprecate -soundhw

2020-07-02 Thread Gerd Hoffmann
v2: - use g_assert_not_reached() for stubs. - add deprecation notice. v3: - rebase to latest master. - adapt to armbru's device initialization changes. v4: - reorder patches, drop temporary -global setup, go straight to -machine pcspk-audiodev= instead. - update error messages and

[PATCH v5 13/20] pc_basic_device_init: drop no_vmport arg

2020-07-02 Thread Gerd Hoffmann
Now that we pass pcms anyway, we don't need the no_vmport arg any more. No functional change. Signed-off-by: Gerd Hoffmann --- include/hw/i386/pc.h | 1 - hw/i386/pc.c | 3 +-- hw/i386/pc_piix.c| 1 - hw/i386/pc_q35.c | 1 - 4 files changed, 1 insertion(+), 5 deletions(-) diff

[PATCH v5 02/20] stubs: add pci_create_simple

2020-07-02 Thread Gerd Hoffmann
Needed for -soundhw cleanup. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- stubs/pci-bus.c | 7 +++ stubs/Makefile.objs | 1 + 2 files changed, 8 insertions(+) create mode 100644 stubs/pci-bus.c diff --git a/stubs/pci-bus.c

[PATCH v5 08/20] audio: deprecate -soundhw gus

2020-07-02 Thread Gerd Hoffmann
Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Signed-off-by: Gerd Hoffmann --- hw/audio/gus.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/audio/gus.c b/hw/audio/gus.c index c8df2bde6b32..7e4a8cadad6f 100644 --- a/hw/audio/gus.c

[PATCH 5/5] MAINTAINERS: Adjust MIPS maintainership (Add Huacai Chen & Jiaxun Yang)

2020-07-02 Thread Philippe Mathieu-Daudé
From: Aleksandar Markovic Huacai Chen steps in as new energy [1]. Aurelien Jarno comment [2]: It happens that I known Huacai Chen from the time he was upstreaming the Loongson 3 support to the kernel, I have been testing and reviewing his patches. I also know Jiaxun Yang from the

Re: [PATCH v7 21/21] multi-process: add configure and usage information

2020-07-02 Thread Stefan Hajnoczi
On Sat, Jun 27, 2020 at 10:09:43AM -0700, elena.ufimts...@oracle.com wrote: > +2) Usage > + > + > +Multi-process QEMU requires an orchestrator to launch. Please refer to a > +light-weight python based orchestrator for mpqemu in > +scripts/mpqemu-launcher.py to lauch QEMU in multi-process

[PULL 0/3] Seabios 20200702 patches

2020-07-02 Thread Gerd Hoffmann
The following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab: hw/misc/pca9552: Add missing TypeInfo::class_size field (2020-06-29 21:16:10 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/seabios-20200702-pull-request for you to fetch changes up

Re: [PATCH 5/5] MAINTAINERS: Adjust MIPS maintainership (Add Huacai Chen & Jiaxun Yang)

2020-07-02 Thread Jiaxun Yang
在 2020/7/2 下午9:37, Philippe Mathieu-Daudé 写道: From: Aleksandar Markovic Huacai Chen steps in as new energy [1]. Aurelien Jarno comment [2]: It happens that I known Huacai Chen from the time he was upstreaming the Loongson 3 support to the kernel, I have been testing and reviewing

Re: [PATCH 2/2] configure: add support for Control-Flow Integrity

2020-07-02 Thread Daniele Buono
On 7/2/2020 9:12 AM, Daniel P. Berrangé wrote: On Thu, Jul 02, 2020 at 08:50:08AM -0400, Daniele Buono wrote: On 7/2/2020 5:52 AM, Daniel P. Berrangé wrote: On Thu, Jul 02, 2020 at 01:49:48AM -0400, Daniele Buono wrote: This patch adds a flag to enable/disable control flow integrity checks

[PULL v2 02/12] linux-user/sparc64: Fix the handling of window spill trap

2020-07-02 Thread Laurent Vivier
From: Giuseppe Musacchio Fix the handling of window spill traps by keeping cansave into account when calculating the new CWP. Signed-off-by: Giuseppe Musacchio Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20200625091204.3186186-3-laur...@vivier.eu> ---

[PULL v2 07/12] linux-user: Add strace support for printing arguments of lseek()

2020-07-02 Thread Laurent Vivier
From: Filip Bozuta This patch implements strace argument printing functionality for syscall: *lseek - reposition read/write file offset off_t lseek(int fd, off_t offset, int whence) man page: https://www.man7.org/linux/man-pages/man2/lseek.2.html Implementation notes:

[PULL v2 05/12] linux-user: Add strace support for a group of syscalls

2020-07-02 Thread Laurent Vivier
From: Filip Bozuta This patch implements strace argument printing functionality for following syscalls: *acct - switch process accounting on or off int acct(const char *filename) man page: https://www.man7.org/linux/man-pages/man2/acct.2.html *fsync, fdatasync -

[PULL v2 06/12] linux-user: Add strace support for printing argument of syscalls used for extended attributes

2020-07-02 Thread Laurent Vivier
From: Filip Bozuta This patch implements strace argument printing functionality for following syscalls: *getxattr, lgetxattr, fgetxattr - retrieve an extended attribute value ssize_t getxattr(const char *path, const char *name, void *value, size_t size) ssize_t

[PULL 11/28] sd/milkymist-memcard: Plug minor memory leak in realize

2020-07-02 Thread Markus Armbruster
milkymist_memcard_realize() leaks an Error object when realization of its "sd-card" device fails. Quite harmless, since we only ever realize this once, in milkymist_init() via milkymist_memcard_create(). Plug the leak. Fixes: 3d0369ba499866cc6a839f71212d97876500762d Cc: Philippe Mathieu-Daudé

[PULL 09/10] vga: build virtio-gpu as module

2020-07-02 Thread Gerd Hoffmann
Drops libvirglrenderer.so dependency from core qemu. Signed-off-by: Gerd Hoffmann Message-id: 20200624131045.14512-10-kra...@redhat.com --- util/module.c| 6 ++ hw/display/Makefile.objs | 23 +-- 2 files changed, 19 insertions(+), 10 deletions(-) diff --git

Re: [PATCH v9 23/34] qcow2: Add subcluster support to discard_in_l2_slice()

2020-07-02 Thread Max Reitz
On 28.06.20 13:02, Alberto Garcia wrote: > Two things need to be taken into account here: > > 1) With full_discard == true the L2 entry must be cleared completely. >This also includes the L2 bitmap if the image has extended L2 >entries. > > 2) With full_discard == false we have to make

Re: [PATCH v6 0/7] dwc-hsotg (aka dwc2) USB host controller emulation

2020-07-02 Thread Gerd Hoffmann
Hi, > Peter already applied this series to master. Ah, this is where the conflict comes from. /me removes an item from the todo list. take care, Gerd

[PATCH v5 01/20] stubs: add isa_create_simple

2020-07-02 Thread Gerd Hoffmann
Needed for -soundhw cleanup. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- stubs/isa-bus.c | 7 +++ stubs/Makefile.objs | 1 + 2 files changed, 8 insertions(+) create mode 100644 stubs/isa-bus.c diff --git a/stubs/isa-bus.c

[PATCH v5 15/20] audio: rework pcspk_init()

2020-07-02 Thread Gerd Hoffmann
Instead of creating and returning the pc speaker accept it as argument. That allows to rework the initialization workflow in followup patches. Signed-off-by: Gerd Hoffmann --- include/hw/audio/pcspk.h | 6 +- hw/i386/pc.c | 2 +- hw/isa/i82378.c | 2 +- hw/mips/jazz.c

[PATCH v5 06/20] audio: deprecate -soundhw adlib

2020-07-02 Thread Gerd Hoffmann
Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Signed-off-by: Gerd Hoffmann --- hw/audio/adlib.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c index 7c3b67dcfb8c..65dff5b6fca4 100644 ---

Questions regarding the usage of the QIO API

2020-07-02 Thread Karaoui mohamed lamine
Hi, (Not sure if this is the right place to ask such a question. Please redirect me if it is the case.) I am currently debugging a problem related to the usage of the QIO interface (qio_channel_closee, qio_channel_add_watch, ...). Where can I find more information on the internal working of this

[PATCH v5 20/20] audio: set default value for pcspk.iobase property

2020-07-02 Thread Gerd Hoffmann
Allows dropping the explicit qdev_prop_set_uint32 call in pcspk_init. Signed-off-by: Gerd Hoffmann --- include/hw/audio/pcspk.h | 6 +- hw/audio/pcspk.c | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/include/hw/audio/pcspk.h b/include/hw/audio/pcspk.h index

[PATCH] tests/acceptance: Add a test for the sun4u sparc64 machine

2020-07-02 Thread Thomas Huth
We can use the image from the advent calendar 2018 to test the sun4u machine. It's not using the "QEMU advent calendar" string, so we can not use the do_test_advcal_2018() from boot_linux_console.py, thus let's also put it into a separate file to also be able to add an entry to the MAINTAINERS

Re: [PATCH] configure / util: Auto-detect the availability of openpty()

2020-07-02 Thread Daniel P . Berrangé
On Thu, Jul 02, 2020 at 04:39:55PM +0200, Thomas Huth wrote: > Recent versions of Solaris (v11.4) now feature an openpty() function, > too, causing a build failure since we ship our own implementation of > openpty() for Solaris in util/qemu-openpty.c so far. Since there are > now both variants

Re: [PATCH 03/46] qdev: Smooth error checking of qdev_realize() & friends

2020-07-02 Thread Markus Armbruster
Markus Armbruster writes: > Vladimir Sementsov-Ogievskiy writes: > >> 24.06.2020 19:43, Markus Armbruster wrote: >>> Convert >>> >>> foo(..., ); >>> if (err) { >>> ... >>> } >>> >>> to >>> >>> if (!foo(..., )) { >>> ... >>> } >>> >>> for

Re: [PATCH v9 30/34] qcow2: Add prealloc field to QCowL2Meta

2020-07-02 Thread Eric Blake
On 7/2/20 9:50 AM, Max Reitz wrote: On 28.06.20 13:02, Alberto Garcia wrote: This field allows us to indicate that the L2 metadata update does not come from a write request with actual data but from a preallocation request. For traditional images this does not make any difference, but for

[PULL 08/28] usb/dev-mtp: Fix Error double free after inotify failure

2020-07-02 Thread Markus Armbruster
error_report_err() frees its first argument. Freeing it again is wrong. Don't. Fixes: 47287c27d0c367a89f7b2851e23a7f8b2d499dd6 Cc: Gerd Hoffmann Cc: Daniel P. Berrangé Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster Message-Id: <20200630090351.1247703-7-arm...@redhat.com>

[PULL 28/28] migration/rdma: Plug memory leaks in qemu_rdma_registration_stop()

2020-07-02 Thread Markus Armbruster
qemu_rdma_registration_stop() uses the ERROR() macro to create, report to stderr, and store an Error object. The stored Error object is never used, and its memory is leaked. Even where ERROR() doesn't leak, it is ill-advised. The whole point of passing an Error to the caller is letting the

Seeing a problem in multi cpu runs where memory mapped pcie device register reads are returning incorrect values

2020-07-02 Thread mwoodpatrick
Background == I have a test environment which runs QEMU 4.2 with a plugin that runs two copies of a PCIE device simulator on a CentOS 7.5 host with an Ubuntu 18.04 guest. When running with a single QEMU CPU using: -cpu kvm64,+lahf_lm -M q35,kernel-irqchip=off -device

Re: [PULL SUBSYSTEM s390x 00/11] s390-ccw bios update

2020-07-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200702115045.6171-1-th...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL SUBSYSTEM s390x 00/11] s390-ccw bios update Type: series Message-id:

Re: [PATCH 2/2] configure: add support for Control-Flow Integrity

2020-07-02 Thread Daniele Buono
On 7/2/2020 5:45 AM, Paolo Bonzini wrote: On 02/07/20 07:49, Daniele Buono wrote: This patch adds a flag to enable/disable control flow integrity checks on indirect function calls. This feature is only provided by LLVM/Clang v3.9 or higher, and only allows indirect function calls to functions

Re: [PATCH v9 21/34] qcow2: Add subcluster support to qcow2_get_host_offset()

2020-07-02 Thread Max Reitz
On 28.06.20 13:02, Alberto Garcia wrote: > The logic of this function remains pretty much the same, except that > it uses count_contiguous_subclusters(), which combines the logic of > count_contiguous_clusters() / count_contiguous_clusters_unallocated() > and checks individual subclusters. > >

Re: [PATCH 2/2] configure: add support for Control-Flow Integrity

2020-07-02 Thread Paolo Bonzini
On 02/07/20 14:50, Daniele Buono wrote: > I also wonder if this is something that could be put in the fuzzing > environment. It would probably also help in finding coding error in > corner cases quicker. Yes, fuzzing and tests/docker/test-debug should enable CFI. Also, tests/docker/test-clang

[PATCH 2/5] target/mips: Remove identical if/else branches

2020-07-02 Thread Philippe Mathieu-Daudé
From: Aleksandar Markovic Remove the segment: if (other_tc == other->current_tc) { tccause = other->CP0_Cause; } else { tccause = other->CP0_Cause; } Original contributor can't remember what was his intention. Fixes: 5a25ce9487 ("mips: Hook in more reg

[PULL 2/3] seabios: update 128k config

2020-07-02 Thread Gerd Hoffmann
Turn off some options to keep size below 128k. Signed-off-by: Gerd Hoffmann --- roms/config.seabios-128k | 3 +++ 1 file changed, 3 insertions(+) diff --git a/roms/config.seabios-128k b/roms/config.seabios-128k index c43912bf9de4..d18c802c46e9 100644 --- a/roms/config.seabios-128k +++

[PULL 1/3] seabios: update submodule to pre-1.14 master snapshot

2020-07-02 Thread Gerd Hoffmann
seabios 1.14 release is planned for end of july, early enough to make it into qemu 5.1-rc2 if everything goes as planned. Update seabios to a master snapshot now, so it'll get test coverage during the freeze and the update to the final version is much smaller (and should have bugfixes only).

[PULL 18/28] hw/arm: Drop useless object_property_set_link() error handling

2020-07-02 Thread Markus Armbruster
object_property_set_link() fails when the property doesn't exist, is not settable, or its .check() method fails. These are all programming errors here, so passing it _abort is appropriate. Cc: Peter Maydell Cc: "Cédric Le Goater" Cc: Andrew Jeffery Cc: Joel Stanley Cc: qemu-...@nongnu.org

[PULL 27/28] arm/{bcm2835, fsl-imx25, fsl-imx6}: Fix realize error API violations

2020-07-02 Thread Markus Armbruster
The Error ** argument must be NULL, _abort, _fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. bcm2835_peripherals_realize(),

Re: [PATCH] linux-user: Fix "print_fdset()" in "strace.c" to not print ", " after last value

2020-07-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200702102749.22178-1-filip.boz...@syrmia.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] linux-user: Fix "print_fdset()" in "strace.c" to not print ", " after last value Type:

[PATCH] MAINTAINERS: update linux-user maintainer

2020-07-02 Thread riku . voipio
From: Riku Voipio I haven't been active for a while. Pass the maintainer hat forward to Laurent, who has done a stellar job filling in. Signed-off-by: Riku Voipio --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git MAINTAINERS MAINTAINERS index

Re: [PATCH 0/2] two atomic_cmpxchg() related fixes

2020-07-02 Thread Cornelia Huck
On Tue, 16 Jun 2020 06:50:33 +0200 Halil Pasic wrote: > The story short: compiler can generate code that does two > distinct fetches of *ind_addr for old and _old. If that happens we can > not figure out if we had the desired xchg or not. > > Halil Pasic (2): > virtio-ccw: fix

Re: [PATCH RFC] virtio-fs: force virtio 1.x usage

2020-07-02 Thread Cornelia Huck
On Thu, 2 Jul 2020 07:22:49 -0400 "Michael S. Tsirkin" wrote: > On Thu, Jul 02, 2020 at 12:45:38PM +0200, Cornelia Huck wrote: > > On Thu, 2 Jul 2020 06:16:06 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jul 01, 2020 at 06:19:17PM +0200, Cornelia Huck wrote: > > > > On Tue, 30

[PULL SUBSYSTEM s390x 10/11] pc-bios/s390-ccw: Generate and include dependency files in the Makefile

2020-07-02 Thread Thomas Huth
The Makefile of the s390-ccw bios does not handle dependencies of the *.c files from the headers yet, so that you often have to run a "make clean" to get the build right when one of the headers has been changed. Let's make sure that we generate and include dependency files for all *.c files now to

[PULL SUBSYSTEM s390x 06/11] pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR

2020-07-02 Thread Thomas Huth
From: Janosch Frank Let's move some of the PSW mask defines into s390-arch.h and use them in jump2ipl.c. Also let's introduce a new constant for the address mask of 8 byte (short) PSWs. Signed-off-by: Janosch Frank Reviewed-by: David Hildenbrand Reviewed-by: Thomas Huth Message-Id:

[PATCH v2 0/3] block: improve error reporting for unsupported O_DIRECT

2020-07-02 Thread Daniel P . Berrangé
v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00269.html See patch commit messages for rationale Ideally we would convert other callers of qemu_open to use qemu_open_err, and eventually remove qemu_open, renaming qemu_open_err back to qemu_open. Given soft freeze is just days

[PATCH v2 1/3] util: validate whether O_DIRECT is supported after failure

2020-07-02 Thread Daniel P . Berrangé
Currently we suggest that a filesystem may not support O_DIRECT after seeing an EINVAL. Other things can cause EINVAL though, so it is better to do an explicit check, and then report a definitive error message. Signed-off-by: Daniel P. Berrangé --- util/osdep.c | 15 +++ 1 file

Re: [PATCH] Makefile: Compute libraries for libqemuutil.a and libvhost-user.a

2020-07-02 Thread Michael Tokarev
01.07.2020 12:12, Christophe de Dinechin wrote: .. >>> # Build libraries >>> >>> +libqemuutil.a-libs += $(call extract-libs, $(util-obj-y) $(trace-obj-y) >>> $(stub-obj-y)) >>> +libvhost-user.a-libs += $(call extract-libs, $(libvhost-user-obj-y) >>> $(util-obj-y) $(stub-obj-y)) .. >> Another

[PATCH 0/5] MIPS patches queue for 5.1 soft freeze

2020-07-02 Thread Philippe Mathieu-Daudé
This series contains the current MIPS patch queue: - Remove unused/unbuilt device (unfortunately the machine won't be merged in time for the 5.1 release) - Trivial fix for LP bug #1885718 - Urgent removal of inactive maintainers - Huacai Chen and Jiaxun Yang designated as new maintainers If

Re: [PATCH v7 00/21] Initial support for multi-process qemu

2020-07-02 Thread Stefan Hajnoczi
On Sat, Jun 27, 2020 at 10:09:22AM -0700, elena.ufimts...@oracle.com wrote: > From: Elena Ufimtseva > > This is the v7 of the patchset. I have completed the review and left comments on the patches. I'm glad it was possible to simplify this feature. The overall approach makes sense to me and I

Re: [PATCH] MAINTAINERS: update linux-user maintainer

2020-07-02 Thread Laurent Vivier
Le 02/07/2020 à 13:16, riku.voi...@linaro.org a écrit : > From: Riku Voipio > > I haven't been active for a while. Pass the maintainer hat > forward to Laurent, who has done a stellar job filling in. > > Signed-off-by: Riku Voipio > --- > MAINTAINERS | 3 +-- > 1 file changed, 1 insertion(+),

Re: [PATCH] linux-user: Fix "print_fdset()" in "strace.c" to not print "," after last value

2020-07-02 Thread Laurent Vivier
Le 02/07/2020 à 12:27, Filip Bozuta a écrit : > Function "print_fdset()" in "strace.c" is used to print the file descriptor > values in "print__newselect()" which prints arguments of syscall _newselect(). > Until changes from this patch, this function was printing "," even after the > last value

[PULL 24/28] arm/stm32f205 arm/stm32f405: Fix realize error API violation

2020-07-02 Thread Markus Armbruster
The Error ** argument must be NULL, _abort, _fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. stm32f205_soc_realize() and

[PULL 20/28] riscv_hart: Fix riscv_harts_realize() error API violations

2020-07-02 Thread Markus Armbruster
The Error ** argument must be NULL, _abort, _fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. riscv_harts_realize() is wrong

[PULL SUBSYSTEM s390x 03/11] pc-bios: s390x: Move sleep and yield to helper.h

2020-07-02 Thread Thomas Huth
From: Janosch Frank They are definitely helper functions. Signed-off-by: Janosch Frank Reviewed-by: Christian Borntraeger Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand Message-Id: <20200624075226.92728-4-fran...@linux.ibm.com> Signed-off-by: Thomas Huth ---

[PULL SUBSYSTEM s390x 11/11] pc-bios/s390: Update s390-ccw bios binaries with the latest changes

2020-07-02 Thread Thomas Huth
... to make sure that the binaries match the current state of the sources. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw.img | Bin 42608 -> 42608 bytes pc-bios/s390-netboot.img | Bin 67232 -> 67232 bytes 2 files changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-ccw.img

[PULL SUBSYSTEM s390x 05/11] pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64

2020-07-02 Thread Thomas Huth
From: Janosch Frank This constant enables 64 bit addressing, not the ESAME architecture, so it shouldn't be named ZMODE. Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth Message-Id: <20200624075226.92728-7-fran...@linux.ibm.com> Signed-off-by: Thomas Huth ---

  1   2   3   4   5   6   >