[PATCH v4 05/10] hw/sd/pl181: Use named GPIOs

2020-07-05 Thread Philippe Mathieu-Daudé
To make the code easier to manage/review/use, rename the cardstatus[0] variable as 'card_readonly' and name the GPIO "card-read-only". Similarly with cardstatus[1], renamed as 'card_inserted' and name its GPIO "card-inserted". Adapt the users accordingly by using the qdev_init_gpio_out_named()

Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-05 Thread Max Filippov
On Sun, Jul 5, 2020 at 11:16 AM Max Filippov wrote: > On Sun, Jul 5, 2020 at 10:09 AM Peter Maydell > wrote: > > On Thu, 2 Jul 2020 at 19:53, Richard Henderson > > wrote: > > > This isn't right. Not so much the gen_io_start portion, but the entire > > > existence of helper_check_interrupt. >

[PATCH v2 3/5] hw/i2c: Rename i2c_realize_and_unref() as i2c_slave_realize_and_unref()

2020-07-05 Thread Philippe Mathieu-Daudé
The other i2c functions are called i2c_slave_FOO(). Rename as i2c_slave_realize_and_unref() to be consistent. Suggested-by: Markus Armbruster Reviewed-by: Corey Minyard Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i2c/i2c.h | 2 +- hw/arm/aspeed.c | 10 ++ hw/i2c/core.c

[PATCH v2 1/5] hw/i2c/aspeed_i2c: Simplify aspeed_i2c_get_bus()

2020-07-05 Thread Philippe Mathieu-Daudé
All the callers of aspeed_i2c_get_bus() have a AspeedI2CState and cast it to a DeviceState with DEVICE(), then aspeed_i2c_get_bus() cast the DeviceState to an AspeedI2CState with ASPEED_I2C()... Simplify aspeed_i2c_get_bus() callers by using AspeedI2CState argument. Reviewed-by: Markus

[PATCH v2 0/5] hw/i2c: Rename method names for consistency and add documentation

2020-07-05 Thread Philippe Mathieu-Daudé
In commit d88c42ff2c we added 2 methods: i2c_try_create_slave() and i2c_realize_and_unref(). Markus noted their name could be improved for consistency [1], and Peter reported the lack of documentation [2]. Fix that now. Since v1: - Addressed Markus review comments - Added Markus/Corey R-b tags

RE: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-05 Thread Wu, Wentong
Thanks, I think we can get this series merged currently. -Original Message- From: Peter Maydell Sent: Monday, July 6, 2020 1:10 AM To: Wu, Wentong Cc: QEMU Developers ; QEMU Trivial ; Chris Wulff ; Marek Vasut Subject: Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl

RE: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-05 Thread Wu, Wentong
Maybe below patch will reduce some overhead, because currently it will exit to main loop to handle interrupt but if with (env->regs[CR_STATUS] & CR_STATUS_PIE) = False, it does nothing except set env->irq_pending again. diff --git a/hw/nios2/cpu_pic.c b/hw/nios2/cpu_pic.c index

Re: [PATCH v2] ftgmac100: fix dblac write test

2020-07-05 Thread Andrew Jeffery
On Sun, 28 Jun 2020, at 23:56, erik-smit wrote: > The test of the write of the dblac register was testing the old value > instead of the new value. This would accept the write of an invalid value > but subsequently refuse any following valid writes. > > Signed-off-by: erik-smit > --- >

[PATCH v4 07/10] hw/sd/pl181: Do not create SD card within the SDHCI controller

2020-07-05 Thread Philippe Mathieu-Daudé
SDHCI controllers provide a SD Bus to plug SD cards, but don't come with SD card plugged in :) Let the machine/board object create and plug the SD cards when required. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/integratorcp.c | 13 + hw/arm/realview.c | 12

[PATCH 2/4] hw/lm32/milkymist: Comment to remember some IRQs lines are left unwired

2020-07-05 Thread Philippe Mathieu-Daudé
The 'card is readonly' and 'card inserted' IRQs are not wired. Add a comment in case someone know where to wire them. Signed-off-by: Philippe Mathieu-Daudé --- hw/lm32/milkymist.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c index

[PATCH 3/4] hw/sd/milkymist: Create the SDBus at init()

2020-07-05 Thread Philippe Mathieu-Daudé
We don't need to wait until realize() to create the SDBus, create it in init() directly. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/milkymist-memcard.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c index

[PATCH 4/4] hw/sd/milkymist: Do not create SD card within the SDHCI controller

2020-07-05 Thread Philippe Mathieu-Daudé
SDHCI controllers provide a SD Bus to plug SD cards, but don't come with SD card plugged in :) Let the machine/board object create and plug the SD cards when required. Signed-off-by: Philippe Mathieu-Daudé --- hw/lm32/milkymist.c | 13 + hw/sd/milkymist-memcard.c | 55

[PATCH 0/4] hw/sd/milkymist: Do not create SD card within the SDHCI controller

2020-07-05 Thread Philippe Mathieu-Daudé
SDHCI controllers provide a SD Bus to plug SD cards, but don't come with SD card plugged in :) This series move the SD card creation to the machine/board code. Regards, Phil. Philippe Mathieu-Daudé (4): hw/lm32/milkymist: Un-inline milkymist_memcard_create() hw/lm32/milkymist: Comment to

[PATCH v2 4/5] hw/i2c: Rename i2c_create_slave() as i2c_slave_create_simple()

2020-07-05 Thread Philippe Mathieu-Daudé
We use "create_simple" names for functions that allocate, initialize, configure and realize device objects: pci_create_simple(), isa_create_simple(), usb_create_simple(). For consistency, rename i2c_create_slave() as i2c_slave_create_simple(). Since we have to update all the callers, also let it

[PATCH 1/2] hw/sd/pxa2xx_mmci: Do not create SD card within the SDHCI controller

2020-07-05 Thread Philippe Mathieu-Daudé
SDHCI controllers provide a SD Bus to plug SD cards, but don't come with SD card plugged in :) Let the machine/board object create and plug the SD cards when required. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/pxa.h | 3 +-- hw/arm/pxa2xx.c | 39

[PATCH 2/2] hw/sd/pxa2xx_mmci: Trivial simplification

2020-07-05 Thread Philippe Mathieu-Daudé
Avoid declaring PXA2xxMMCIState local variable, return it directly. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/pxa2xx_mmci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/sd/pxa2xx_mmci.c b/hw/sd/pxa2xx_mmci.c index 9482b9212d..2996a2ef17 100644 ---

[PATCH 0/2] hw/sd/pxa2xx_mmci: Do not create SD card within the SDHCI controller

2020-07-05 Thread Philippe Mathieu-Daudé
SDHCI controllers provide a SD Bus to plug SD cards, but don't come with SD card plugged in This series move the SD card creation to the machine/board code. Regards, Phil. Philippe Mathieu-Daudé (2): hw/sd/pxa2xx_mmci: Do not create SD card within the SDHCI controller hw/sd/pxa2xx_mmci:

[PATCH] target/xtensa: implement NMI support

2020-07-05 Thread Max Filippov
When NMI is configured it is taken regardless of INTENABLE SR contents, PS.INTLEVEL or PS.EXCM. It is cleared automatically once it's taken. Add nmi_level to XtensaConfig, puth there NMI level from the overlay or XCHAL_NUM_INTLEVELS + 1 when NMI is not configured. Add NMI mask to INTENABLE SR and

Re: [PATCH] load_elf: Remove unused address variables from callers

2020-07-05 Thread David Gibson
On Sun, Jul 05, 2020 at 07:22:11PM +0200, BALATON Zoltan wrote: > Several callers of load_elf() pass pointers for lowaddr and highaddr > parameters which are then not used for anything. This may stem from a > misunderstanding that load_elf need a value here but in fact it can > take NULL to ignore

Re: [PATCH 1/2] virtio-ccw: fix virtio_set_ind_atomic

2020-07-05 Thread Christian Borntraeger
On 04.07.20 20:34, Michael S. Tsirkin wrote: > On Tue, Jun 16, 2020 at 06:50:34AM +0200, Halil Pasic wrote: >> The atomic_cmpxchg() loop is broken because we occasionally end up with >> old and _old having different values (a legit compiler can generate code >> that accessed *ind_addr again to

[PATCH v4 08/10] hw/sd/pl181: Replace disabled fprintf()s by trace events

2020-07-05 Thread Philippe Mathieu-Daudé
Convert disabled DPRINTF() to trace events and remove ifdef'ry. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/pl181.c | 26 +- hw/sd/trace-events | 10 ++ 2 files changed, 19 insertions(+), 17 deletions(-) diff --git a/hw/sd/pl181.c b/hw/sd/pl181.c index

[PATCH v4 04/10] hw/arm/versatilepb: Comment to remember some IRQs lines are left unwired

2020-07-05 Thread Philippe Mathieu-Daudé
The 'card is readonly' and 'card inserted' IRQs are not wired. Add a comment in case someone know where to wire them. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/versatilepb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/versatilepb.c b/hw/arm/versatilepb.c index

[PATCH 1/4] hw/lm32/milkymist: Un-inline milkymist_memcard_create()

2020-07-05 Thread Philippe Mathieu-Daudé
As we will modify milkymist_memcard_create(), move it first to the source file where it is used. Signed-off-by: Philippe Mathieu-Daudé --- hw/lm32/milkymist-hw.h | 11 --- hw/lm32/milkymist.c| 11 +++ 2 files changed, 11 insertions(+), 11 deletions(-) diff --git

[RFC PATCH 0/2] hw/sd: Deprecate the SPI mode and the SPI to SD adapter

2020-07-05 Thread Philippe Mathieu-Daudé
I tried to maintain the SPI mode because it is useful in tiny embedded devices, and thought it would be helpful for the AVR MCUs. As AVR was blocked, I thought it was wise to deprecate the SPI mode as users are interested in the faster MMC mode. Today Thomas surprised me by posting an update of

[RFC PATCH 2/2] hw/sd/sdcard: Deprecate the SPI mode

2020-07-05 Thread Philippe Mathieu-Daudé
SD cards be used with SPI, SD or MMC protocol. Unfortunately, maintaining the SPI protocol make improving the MMC mode very difficult. As of 2020 users are more interested in using cards with the MMC protocol. Signed-off-by: Philippe Mathieu-Daudé --- docs/system/deprecated.rst | 5 + 1

[RFC PATCH 1/2] hw/sd/ssi-sd: Deprecate the SPI to SD card 'adapter'

2020-07-05 Thread Philippe Mathieu-Daudé
This device duplicate the SPI mode of the sd-card device. The SPI protocol is better handler in the sd-card, however as the TYPE_SSI_SLAVE is not an interface, the sd-card can not implement it easily to be pluggable on a SPI bus. Meanwhile the ssi-sd device acts as a bridge, but is bitroting.

Re: [PATCH v2 1/1] disas: mips: Add Loongson 2F disassembler

2020-07-05 Thread Jiaxun Yang
在 2020/7/3 18:44, Stefan Brankovic 写道: Add disassembler for Loongson 2F instruction set. Testing is done by comparing qemu disassembly output, obtained by using -d in_asm command line option, with appropriate objdump output. This disassembler is written as a generic disassembler that can be

[Bug 1885827] Re: building plugin failed on Windows with mingw

2020-07-05 Thread Xiaolei
Hi, I patched configure file and makefile. The output is listed below. The project is configured as : #../configure --target-list=dsp-softmmu --cross-prefix=x86_64-w64-mingw32- --enable-gtk --enable-sdl --enable-debug --enable-plugins --extra-cflags="-DBUILDING_DLL" But running make

Re: [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error

2020-07-05 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé wrote: >> >> As we have no interest in the underlying block geometry, >> directly call blk_getlength(). We have to care about machines >> creating SD card with not drive attached (probably incorrect >> API use). Simply

Re: [PATCH rc6 26/30] target/avr: Update build system

2020-07-05 Thread Philippe Mathieu-Daudé
On 7/5/20 4:03 PM, Thomas Huth wrote: > From: Michael Rolnik > > Make AVR support buildable. > > [AM: Remove word 'Atmel' from filenames and all elements of code] > Suggested-by: Aleksandar Markovic > Signed-off-by: Michael Rolnik > Signed-off-by: Richard Henderson > Signed-off-by:

Re: [PATCH v2 1/5] hw/i2c/aspeed_i2c: Simplify aspeed_i2c_get_bus()

2020-07-05 Thread Andrew Jeffery
On Mon, 6 Jul 2020, at 08:11, Philippe Mathieu-Daudé wrote: > All the callers of aspeed_i2c_get_bus() have a AspeedI2CState and > cast it to a DeviceState with DEVICE(), then aspeed_i2c_get_bus() > cast the DeviceState to an AspeedI2CState with ASPEED_I2C()... > > Simplify aspeed_i2c_get_bus()

Re: [PATCH v11 7/8] nbd: introduce ERRP_AUTO_PROPAGATE

2020-07-05 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == _fatal > (the program will exit prior to the error_append_hint() or >

[PATCH v4 10/10] hw/sd: move sdcard legacy API to 'hw/sd/sdcard_legacy.h'

2020-07-05 Thread Philippe Mathieu-Daudé
omap_mmc.c is the last device left using the legacy sdcard API. Move the prototype declarations into a separate header, to make it clear this is a legacy API. Reviewed-by: Alistair Francis Message-Id: <20180216022933.10945-8-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v2] hw/core/qdev: Increase qdev_realize() kindness

2020-07-05 Thread Philippe Mathieu-Daudé
Since commit 510ef98dca5, qdev_realize() aborts if bus-less device is realized on a bus. Be kind with the developer by displaying a hint about what is wrong. Signed-off-by: Philippe Mathieu-Daudé --- v2: Use errp (bonzini suggestion) Paolo, I was tempted to check errp is really _abort else it

[PATCH v2 2/5] hw/i2c: Rename i2c_try_create_slave() as i2c_slave_new()

2020-07-05 Thread Philippe Mathieu-Daudé
We use "new" names for functions that allocate and initialize device objects: pci_new(), isa_new(), usb_new(). Let's call this one i2c_slave_new(). Since we have to update all the callers, also let it return a I2CSlave object. Suggested-by: Markus Armbruster Reviewed-by: Markus Armbruster

[PATCH v2 5/5] hw/i2c: Document the I2C qdev helpers

2020-07-05 Thread Philippe Mathieu-Daudé
In commit d88c42ff2c we added new prototype but neglected to add their documentation. Fix that. Reported-by: Peter Maydell Reviewed-by: Corey Minyard Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i2c/i2c.h | 48 1 file changed, 48

[PATCH v4 01/10] hw/sd/pl181: Replace fprintf(stderr, "*\n") with error_report()

2020-07-05 Thread Philippe Mathieu-Daudé
From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[PATCH v4 09/10] hw/sd/sdcard: make sd_data_ready() static

2020-07-05 Thread Philippe Mathieu-Daudé
sd_data_ready() belongs to the legacy API. As its last user has been converted to the SDBus API, make it static. Reviewed-by: Alistair Francis Message-Id: <20180216022933.10945-7-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sd.h | 1 - hw/sd/sd.c | 2 +- 2

[PATCH 2/2] target/i386: Enable TSX Suspend Load Address Tracking feature

2020-07-05 Thread Cathy Zhang
This instruction aims to give a way to choose which memory accesses do not need to be tracked in the TSX read set, which is defined as CPUID.(EAX=7,ECX=0):EDX[bit 16]. The release spec link is as follows: https://software.intel.com/content/dam/develop/public/us/en/documents/\

[PATCH 1/2] target/i386: Add SERIALIZE cpu feature

2020-07-05 Thread Cathy Zhang
The availability of the SERIALIZATION instruction is indicated by the presence of the CPUID feature flag SERIALIZE, which is defined as CPUID.(EAX=7,ECX=0):ECX[bit 14]. The release spec link is as follows: https://software.intel.com/content/dam/develop/public/us/en/documents/\

[PATCH 0/2] Add new features for intel processor

2020-07-05 Thread Cathy Zhang
This patchset is to add two new features for intel processors which support them, like Sapphire Rapids. SERIALIZE is a faster serializing instruction which does not modify registers, arithmetic flags or memory, will not cause VM exit. TSX suspend load tracking instruction aims to give a way to

[Bug 1886362] [NEW] Heap use-after-free in lduw_he_p through e1000e_write_to_rx_buffers

2020-07-05 Thread Alexander Bulekov
Public bug reported: Hello, This reproducer causes a heap-use-after free. QEMU Built with --enable-sanitizers: cat << EOF | ./i386-softmmu/qemu-system-i386 -M q35,accel=qtest \ -qtest stdio -nographic -monitor none -serial none outl 0xcf8 0x80001010 outl 0xcfc 0xe102 outl 0xcf8 0x80001014

Re: [PATCH 0/7] accel/kvm: Simplify few functions that can use global kvm_state

2020-07-05 Thread Paolo Bonzini
On 04/07/20 18:50, Philippe Mathieu-Daudé wrote: > kind ping :) Queued all except 4. Paolo > On 6/23/20 12:50 PM, Philippe Mathieu-Daudé wrote: >> Following Paolo's idea on kvm_check_extension(): >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg713794.html >> >> CI: >>

Re: [RFC PATCH v2 15/23] hw/m68k/mcf520x: Emit warning when old code is used

2020-07-05 Thread Thomas Huth
Am Sat, 4 Jul 2020 17:39:00 +0200 schrieb Philippe Mathieu-Daudé : > This code hasn't been QOM'ified yet. Warn the user. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: Add comment (thuth) > --- > hw/m68k/mcf5206.c | 5 + > hw/m68k/mcf5208.c | 3 +++ > 2 files changed, 8

Re: [PATCH v2 1/1] disas: mips: Add Loongson 2F disassembler

2020-07-05 Thread Aleksandar Markovic
On Saturday, July 4, 2020, Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> wrote: > > > On Friday, July 3, 2020, Stefan Brankovic > wrote: > >> Add disassembler for Loongson 2F instruction set. >> >> Testing is done by comparing qemu disassembly output, obtained by >> using -d in_asm

Re: [RFC PATCH 4/7] accel/kvm: Simplify kvm_set_sigmask_len()

2020-07-05 Thread Paolo Bonzini
On 23/06/20 12:50, Philippe Mathieu-Daudé wrote: > The sigmask_len is a property of the accelerator, not the VM. > Simplify by directly using the global kvm_state, remove the > unnecessary KVMState* argument. This is not entirely true, if there were multiple KVMStates how would you know which one

Re: [PATCH v7 1/8] mac_oldworld: Allow loading binary ROM image

2020-07-05 Thread David Gibson
On Tue, Jun 30, 2020 at 11:45:42PM +0200, BALATON Zoltan wrote: > On Tue, 30 Jun 2020, Mark Cave-Ayland wrote: > > On 29/06/2020 19:55, BALATON Zoltan wrote: > > > The beige G3 Power Macintosh has a 4MB firmware ROM. Fix the size of > > > the rom region and fall back to loading a binary image with

Re: [PATCH v3 8/9] spapr: PEF: block migration

2020-07-05 Thread David Gibson
On Fri, Jun 26, 2020 at 11:33:03AM +0100, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > We haven't yet implemented the fairly involved handshaking that will be > > needed to migrate PEF protected guests. For now, just use a migration > > blocker so we get

Re: [PATCH v4 02/11] target/ppc: Enable Power ISA 3.1

2020-07-05 Thread David Gibson
On Wed, Jul 01, 2020 at 06:43:37PM -0500, Lijun Pan wrote: > This patch enables the Power ISA 3.1 in QEMU. > > Signed-off-by: Lijun Pan Applied to ppc-for-5.2. > --- > v4: split to 01/11 and 02/11 > v2: add Power ISA 3.1 flag > > target/ppc/cpu.h| 2 +- >

Re: [PATCH v4 00/11] Add several Power ISA 3.1 32/64-bit vector instructions

2020-07-05 Thread David Gibson
On Wed, Jul 01, 2020 at 06:43:35PM -0500, Lijun Pan wrote: > This patch series add several newly introduced 32/64-bit vector > instructions in Power ISA 3.1. Power ISA 3.1 flag is introduced in > this version. In v4 version, coding style issues are fixed, community > reviews/suggestions are taken

Re: [PATCH v2 0/7] colo: Introduce resource agent and test suite/CI

2020-07-05 Thread Lukas Straub
On Sat, 6 Jun 2020 21:17:32 +0200 Lukas Straub wrote: > Hello Everyone, > So here is v2. Patch 1 can already be merged independently of the others. > > Regards, > Lukas Straub > > Changes: > v2: > -use new yank api > -drop disk_size parameter > -introduce pick_qemu_util function and use it

Re: [PATCH] hw/core/qdev: Increase qdev_realize() kindness

2020-07-05 Thread Philippe Mathieu-Daudé
On 7/5/20 7:46 AM, Paolo Bonzini wrote: > On 20/06/20 17:38, Philippe Mathieu-Daudé wrote: >> -} else { >> -assert(!DEVICE_GET_CLASS(dev)->bus_type); >> +} else if (DEVICE_GET_CLASS(dev)->bus_type) { >> +error_report("%s: Unexpected bus '%s' for device '%s'", >> +

Re: [PATCH v4 08/21] microvm/acpi: add minimal acpi support

2020-07-05 Thread Michael S. Tsirkin
On Fri, Jul 03, 2020 at 09:25:10PM +0200, Gerd Hoffmann wrote: > On Fri, Jul 03, 2020 at 09:09:43AM -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 02, 2020 at 10:48:46PM +0200, Gerd Hoffmann wrote: > > > +/* copy AML table into ACPI tables blob and patch header there */ > > > +

Re: [PATCH] hw/core/qdev: Increase qdev_realize() kindness

2020-07-05 Thread Philippe Mathieu-Daudé
On 7/5/20 1:14 PM, Paolo Bonzini wrote: > Are we sure that qdev_realize is never called with user-provided input? I am not sure, but ... > If it's a programming error, the call chain will end up passing > _abort anyway, won't it? ... this is a good point :) > > Paolo > > Il dom 5 lug 2020,

[Bug 1886306] [NEW] qemu running slow when the window is in background

2020-07-05 Thread Philippe Mathieu-Daudé
Public bug reported: Reported by on IRC: QEMU almost freezes when running with `GDK_BACKEND=x11` set and the parameter `gl=on` added to the `-display` option. GDK_BACKEND=x11 qemu-system-x86_64 -nodefaults -no-user-config -enable- kvm -machine q35 -cpu host -m 4G -display gtk,gl=on -vga std

Re: [PATCH v5 0/7] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-07-05 Thread Lukas Straub
On Wed, 24 Jun 2020 21:47:46 +0200 Lukas Straub wrote: > On Tue, 23 Jun 2020 16:42:30 +0200 > Lukas Straub wrote: > > > Hello Everyone, > > In many cases, if qemu has a network connection (qmp, migration, chardev, > > etc.) > > to some other server and that server dies or hangs, qemu hangs

Re: [RFC PATCH 4/7] accel/kvm: Simplify kvm_set_sigmask_len()

2020-07-05 Thread Philippe Mathieu-Daudé
On 7/5/20 9:12 AM, Paolo Bonzini wrote: > On 23/06/20 12:50, Philippe Mathieu-Daudé wrote: >> The sigmask_len is a property of the accelerator, not the VM. >> Simplify by directly using the global kvm_state, remove the >> unnecessary KVMState* argument. > > This is not entirely true, if there

[Bug 1886318] [NEW] Qemu after v5.0.0 breaks macos guests

2020-07-05 Thread Simon John
Public bug reported: The Debian Sid 5.0-6 qemu-kvm package can no longer get further than the Clover bootloader whereas 5.0-6 and earlier worked fine. So I built qemu master from github and it has the same problem, whereas git tag v5.0.0 (or 4.2.1) does not, so something between v5.0.0 release

[Bug 1886343] [NEW] configure has non-posix bash syntax

2020-07-05 Thread Wilson-q
Public bug reported: which gives an error when run on a system that uses dash for /bin/sh. The problem is at line 6464 which has if test "$have_keyring" == "yes" the double equal sign is non-posix bash syntax that isn't accepted by posix shells like dash. This was added 2020-05-25

Re: [PATCH 22/26] hw/usb/usb-hcd: Use OHCI type definitions

2020-07-05 Thread Niek Linnenbank
On Sat, Jul 4, 2020, 16:50 Philippe Mathieu-Daudé wrote: > Various machine/board/soc models create OHCI device instances > with the generic QDEV API, and don't need to access USB internals. > > Simplify header inclusions by moving the QOM type names into a > simple header, with no need to

[PATCH v4 00/10] hw/sd: convert legacy SDHCI devices to the SDBus API

2020-07-05 Thread Philippe Mathieu-Daudé
Hi, Since v3: - rebased (was from Feb 2018) - use named GPIOs - addressed Peter review comment (adding TYPE_PL181_BUS object) - convert DPRINF to trace events Since v2: - pl181: remove legacy sd_set_cb() (Peter) Since v1: - rebased on /master (Peter sdcard reset() patches) - fix milkymist-mmc

[PATCH v4 06/10] hw/sd/pl181: Expose a SDBus and connect the SDCard to it

2020-07-05 Thread Philippe Mathieu-Daudé
Convert the controller to the SDBus API: - add the a TYPE_PL181_BUS object of type TYPE_SD_BUS, - adapt the SDBusClass set_inserted/set_readonly handlers - create the bus in the PL181 controller - switch legacy sd_*() API to the sdbus_*() API. Signed-off-by: Philippe Mathieu-Daudé --- Since v3:

[PATCH v4 02/10] hw/sd/pl181: Rename pl181_send_command() as pl181_do_command()

2020-07-05 Thread Philippe Mathieu-Daudé
pl181_send_command() do a bus transaction (send or receive), rename it as pl181_do_command(). Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/pl181.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd/pl181.c b/hw/sd/pl181.c index 649386ec3d..3fc2cdd71a 100644 ---

[PATCH v4 03/10] hw/sd/pl181: Add TODO to use Fifo32 API

2020-07-05 Thread Philippe Mathieu-Daudé
Add TODO to use Fifo32 API from "qemu/fifo32.h". Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/pl181.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd/pl181.c b/hw/sd/pl181.c index 3fc2cdd71a..86219c851d 100644 --- a/hw/sd/pl181.c +++ b/hw/sd/pl181.c @@ -57,7 +57,7

Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-05 Thread Peter Maydell
On Thu, 2 Jul 2020 at 19:53, Richard Henderson wrote: > This isn't right. Not so much the gen_io_start portion, but the entire > existence of helper_check_interrupt. I agree that it looks bogus (xtensa has a similar helper as well, incidentally), but fixing all that stuff up is more effort than

Re: [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error

2020-07-05 Thread Philippe Mathieu-Daudé
On 7/5/20 12:26 AM, Philippe Mathieu-Daudé wrote: > On 7/5/20 12:18 AM, Philippe Mathieu-Daudé wrote: >> On 7/5/20 12:10 AM, Philippe Mathieu-Daudé wrote: >>> On 7/4/20 1:42 AM, Philippe Mathieu-Daudé wrote: On 7/3/20 5:16 PM, Philippe Mathieu-Daudé wrote: > On 7/3/20 3:23 PM, Peter

[PATCH] hw/arm/aspeed: Do not create and attach empty SD cards by default

2020-07-05 Thread Philippe Mathieu-Daudé
Since added in commit 2bea128c3d, each SDHCI is wired with a SD card, using empty card when no block drive provided. This is not the desired behavior. The SDHCI exposes a SD bus to plug cards on, if no card available, it is fine to have an unplugged bus. Avoid creating unnecessary SD card device

[PATCH] load_elf: Remove unused address variables from callers

2020-07-05 Thread BALATON Zoltan
Several callers of load_elf() pass pointers for lowaddr and highaddr parameters which are then not used for anything. This may stem from a misunderstanding that load_elf need a value here but in fact it can take NULL to ignore these values. Remove such unused variables and pass NULL instead from

Re: [PATCH v2] apic: Report current_count via 'info lapic'

2020-07-05 Thread Jan Kiszka
On 07.02.20 07:43, Jan Kiszka wrote: From: Jan Kiszka This is helpful when debugging stuck guest timers. As we need apic_get_current_count for that, and it is really not emulation specific, move it to apic_common.c and export it. Fix its style at this chance as well. Signed-off-by: Jan

Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-05 Thread Max Filippov
On Sun, Jul 5, 2020 at 10:09 AM Peter Maydell wrote: > On Thu, 2 Jul 2020 at 19:53, Richard Henderson > wrote: > > This isn't right. Not so much the gen_io_start portion, but the entire > > existence of helper_check_interrupt. > > I agree that it looks bogus (xtensa has a similar helper as

Re: [PATCH v2 1/1] disas: mips: Add Loongson 2F disassembler

2020-07-05 Thread Aleksandar Markovic
On Sunday, July 5, 2020, Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> wrote: > > > On Saturday, July 4, 2020, Aleksandar Markovic < > aleksandar.qemu.de...@gmail.com> wrote: > >> >> >> On Friday, July 3, 2020, Stefan Brankovic >> wrote: >> >>> Add disassembler for Loongson 2F

Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-05 Thread Peter Maydell
On Mon, 29 Jun 2020 at 09:17, Wentong Wu wrote: > > wrctl instruction on nios2 target will cause checking cpu > interrupt but tcg_handle_interrupt() will call cpu_abort() > if the CPU gets an interrupt while it's not in 'can do IO' > state, so add gen_io_start around wrctl instruction. Also > at

Re: [PATCH v7 1/8] mac_oldworld: Allow loading binary ROM image

2020-07-05 Thread BALATON Zoltan
On Sun, 5 Jul 2020, David Gibson wrote: On Tue, Jun 30, 2020 at 11:45:42PM +0200, BALATON Zoltan wrote: On Tue, 30 Jun 2020, Mark Cave-Ayland wrote: On 29/06/2020 19:55, BALATON Zoltan wrote: The beige G3 Power Macintosh has a 4MB firmware ROM. Fix the size of the rom region and fall back to

Re: [PULL v2 12/64] target/riscv: add vector amo operations

2020-07-05 Thread Peter Maydell
On Thu, 2 Jul 2020 at 17:33, Alistair Francis wrote: > > From: LIU Zhiwei > > Vector AMOs operate as if aq and rl bits were zero on each element > with regard to ordering relative to other instructions in the same hart. > Vector AMOs provide no ordering guarantee between element operations > in

Re: [PULL 05/34] virtio-iommu: Implement RESV_MEM probe request

2020-07-05 Thread Peter Maydell
On Fri, 3 Jul 2020 at 17:54, Peter Maydell wrote: > > From: Eric Auger > > This patch implements the PROBE request. At the moment, > only THE RESV_MEM property is handled. The first goal is > to report iommu wide reserved regions such as the MSI regions > set by the machine code. On x86 this

Re: [PATCH rc6 00/30] target/avr merger

2020-07-05 Thread Thomas Huth
Am Sun, 5 Jul 2020 07:29:06 -0700 (PDT) schrieb no-re...@patchew.org: > Patchew URL: > https://patchew.org/QEMU/20200705140315.260514-1-h...@tuxfamily.org/ [...] > === OUTPUT BEGIN === > 1/30 Checking commit b5e3116a3591 (target/avr: Add basic parameters > of the new platform) WARNING: added,

Re: [PATCH rc6 00/30] target/avr merger

2020-07-05 Thread Peter Maydell
On Sun, 5 Jul 2020 at 19:31, Thomas Huth wrote: > > Am Sun, 5 Jul 2020 07:29:06 -0700 (PDT) > schrieb no-re...@patchew.org: > > > Patchew URL: > > https://patchew.org/QEMU/20200705140315.260514-1-h...@tuxfamily.org/ > [...] > > === OUTPUT BEGIN === > > 1/30 Checking commit b5e3116a3591

RE: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-05 Thread Wu, Wentong
Correct the format > -Original Message- > From: Richard Henderson > Sent: Friday, July 3, 2020 2:54 AM > To: Wu, Wentong ; qemu-devel@nongnu.org > Cc: qemu-triv...@nongnu.org; ma...@denx.de; crwu...@gmail.com; > peter.mayd...@linaro.org > Subject: Re: [PATCH 3/3] target/nios2: Use

[PATCH rc6 02/30] target/avr: Introduce basic CPU class object

2020-07-05 Thread Thomas Huth
From: Michael Rolnik This patch introduces AVR CPU class object and its basic elements and functions. [AM: Split a larger AVR introduction patch into logical units] Suggested-by: Aleksandar Markovic Co-developed-by: Michael Rolnik Co-developed-by: Sarah Harris Signed-off-by: Michael Rolnik

[PATCH rc6 25/30] hw/avr: Add limited support for some Arduino boards

2020-07-05 Thread Thomas Huth
From: Philippe Mathieu-Daudé Arduino boards are build with AVR chipsets. Add some of these boards: - Arduino Duemilanove - Arduino Uno - Arduino Mega For more information: https://www.arduino.cc/en/Main/Products https://store.arduino.cc/arduino-genuino/most-popular [AM: Remove word

[PATCH rc6 03/30] target/avr: CPU class: Add interrupt handling support

2020-07-05 Thread Thomas Huth
From: Michael Rolnik This patch introduces functions avr_cpu_do_interrupt() and avr_cpu_exec_interrupt() that are part of AVR CPU class object. [AM: Split a larger AVR introduction patch into logical units] Suggested-by: Aleksandar Markovic Co-developed-by: Michael Rolnik Co-developed-by:

[PATCH rc6 17/30] target/avr: Initialize TCG register variables

2020-07-05 Thread Thomas Huth
From: Michael Rolnik Initialize TCG register variables. Co-developed-by: Richard Henderson Co-developed-by: Michael Rolnik Signed-off-by: Michael Rolnik Signed-off-by: Richard Henderson Signed-off-by: Aleksandar Markovic Tested-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic

[PATCH rc6 14/30] target/avr: Add instruction translation - Bit and Bit-test Instructions

2020-07-05 Thread Thomas Huth
From: Michael Rolnik This includes: - LSR, ROR - ASR - SWAP - SBI, CBI - BST, BLD - BSET, BCLR Signed-off-by: Michael Rolnik Signed-off-by: Richard Henderson Signed-off-by: Aleksandar Markovic Tested-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic

[PATCH rc6 15/30] target/avr: Add instruction translation - MCU Control Instructions

2020-07-05 Thread Thomas Huth
From: Michael Rolnik This includes: - BREAK - NOP - SLEEP - WDR Signed-off-by: Michael Rolnik Signed-off-by: Richard Henderson Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Markovic Signed-off-by: Thomas Huth --- target/avr/insn.decode | 8 +

[PATCH rc6 05/30] target/avr: CPU class: Add migration support

2020-07-05 Thread Thomas Huth
From: Michael Rolnik Add migration-related functions of AVR CPU class object. [AM: Split a larger AVR introduction patch into logical units] Suggested-by: Aleksandar Markovic Co-developed-by: Michael Rolnik Co-developed-by: Sarah Harris Signed-off-by: Michael Rolnik Signed-off-by: Sarah

[PATCH rc6 20/30] hw/timer: avr: Add limited support for 16-bit timer peripheral

2020-07-05 Thread Thomas Huth
From: Michael Rolnik These were designed to facilitate testing but should provide enough function to be useful in other contexts. Only a subset of the functions of each peripheral is implemented, mainly due to the lack of a standard way to handle electrical connections (like GPIO pins). [AM:

[PATCH rc6 24/30] hw/avr: Add some ATmega microcontrollers

2020-07-05 Thread Thomas Huth
From: Philippe Mathieu-Daudé Add some AVR microcontrollers from the ATmega family: - middle range: ATmega168 and ATmega328 - high range: ATmega1280 and ATmega2560 For product comparison: https://www.microchip.com/wwwproducts/ProductCompare/ATmega168P/ATmega328P

[PATCH rc6 21/30] hw/misc: avr: Add limited support for power reduction device

2020-07-05 Thread Thomas Huth
From: Michael Rolnik This is a simple device of just one register, and whenever this register is written to it calls qemu_set_irq function for each of 8 bits/IRQs. It is used to implement AVR Power Reduction. [AM: Remove word 'Atmel' from filenames and all elements of code] Suggested-by:

[PATCH rc6 06/30] target/avr: CPU class: Add GDB support

2020-07-05 Thread Thomas Huth
From: Michael Rolnik This includes GDB hooks for reading from wnd wrtiting to AVR registers, and xml register definition file as well. [AM: Split a larger AVR introduction patch into logical units] Suggested-by: Aleksandar Markovic Co-developed-by: Michael Rolnik Co-developed-by: Sarah Harris

[PATCH rc6 11/30] target/avr: Add instruction translation - Arithmetic and Logic Instructions

2020-07-05 Thread Thomas Huth
From: Michael Rolnik This includes: - ADD, ADC, ADIW - SBIW, SUB, SUBI, SBC, SBCI - AND, ANDI - OR, ORI, EOR - COM, NEG - INC, DEC - MUL, MULS, MULSU - FMUL, FMULS, FMULSU - DES Signed-off-by: Michael Rolnik Signed-off-by: Richard Henderson Signed-off-by: Aleksandar Markovic Tested-by:

[PATCH rc6 30/30] target/avr: Add section into QEMU documentation

2020-07-05 Thread Thomas Huth
The new section explains basic ways of using AVR target in QEMU. Signed-off-by: Michael Rolnik [thuth: Converted doc from texi to Sphinx syntax] Signed-off-by: Thomas Huth --- docs/system/target-avr.rst | 37 + docs/system/targets.rst| 1 + 2 files

[PATCH rc6 28/30] tests/boot-serial: Test some Arduino boards (AVR based)

2020-07-05 Thread Thomas Huth
From: Michael Rolnik Print out 'T' through serial port. The Arduino Duemilanove is based on a AVR5 CPU, while the Arduino MEGA2560 on a AVR6 CPU. Signed-off-by: Michael Rolnik Signed-off-by: Philippe Mathieu-Daudé [rth: Squash Arduino adjustments from f4bug] Tested-by: Richard Henderson

[PATCH rc6 19/30] hw/char: avr: Add limited support for USART peripheral

2020-07-05 Thread Thomas Huth
From: Michael Rolnik These were designed to facilitate testing but should provide enough function to be useful in other contexts. Only a subset of the functions of each peripheral is implemented, mainly due to the lack of a standard way to handle electrical connections (like GPIO pins). [AM:

[PATCH rc6 27/30] tests/machine-none: Add AVR support

2020-07-05 Thread Thomas Huth
From: Michael Rolnik Add a single code line that will automatically provide 'machine none' test. Signed-off-by: Michael Rolnik Signed-off-by: Richard Henderson Signed-off-by: Aleksandar Markovic Tested-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic Reviewed-by: Thomas Huth

RE: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-05 Thread Wu, Wentong
Correct the format > -Original Message- > From: Richard Henderson > Sent: Friday, July 3, 2020 2:54 AM > To: Wu, Wentong ; qemu-devel@nongnu.org > Cc: qemu-triv...@nongnu.org; ma...@denx.de; crwu...@gmail.com; > peter.mayd...@linaro.org > Subject: Re: [PATCH 3/3] target/nios2: Use

[PATCH rc6 00/30] target/avr merger

2020-07-05 Thread Thomas Huth
This is the AVR port from Michael, release (merge) candidate 6. I've rebased rc5 to the current master branch, fixed the conflicts, and updated the APIs where necessary (e.g. qdev_create() had to be replaced). These patches have been on the list for a long time. Let's try to get them finally

[PATCH rc6 08/30] target/avr: Add defintions of AVR core types

2020-07-05 Thread Thomas Huth
From: Michael Rolnik AVR core types are: - avr1 - avr2 - avr25 - avr3 - avr31 - avr35 - avr4 - avr5 - avr51 - avr6 - avrtiny - xmega2 - xmega3 - xmega4 - xmega5 - xmega6 - xmega7 Each core type covers multiple AVR MCUs, mentioned in the comments before

[PATCH rc6 04/30] target/avr: CPU class: Add memory menagement support

2020-07-05 Thread Thomas Huth
From: Michael Rolnik This patch introduces three memory-management-related functions that will become part of AVR CPU class object. [AM: Split a larger AVR introduction patch into logical units] Suggested-by: Aleksandar Markovic Co-developed-by: Michael Rolnik Co-developed-by: Sarah Harris

[PATCH rc6 01/30] target/avr: Add basic parameters of the new platform

2020-07-05 Thread Thomas Huth
From: Michael Rolnik This includes definitions of various basic parameters needed for integration of a new platform into QEMU. [AM: Split a larger AVR introduction patch into logical units] Suggested-by: Aleksandar Markovic Co-developed-by: Michael Rolnik Co-developed-by: Sarah Harris

[PATCH rc6 26/30] target/avr: Update build system

2020-07-05 Thread Thomas Huth
From: Michael Rolnik Make AVR support buildable. [AM: Remove word 'Atmel' from filenames and all elements of code] Suggested-by: Aleksandar Markovic Signed-off-by: Michael Rolnik Signed-off-by: Richard Henderson Signed-off-by: Aleksandar Markovic Tested-by: Philippe Mathieu-Daudé

  1   2   >