RE: [PATCH V3 0/3] migration/colo: Optimize COLO framework code

2020-07-08 Thread Zhang, Chen
Hi Hailiang/Dave, No news for a while, any comments? Thanks Zhang Chen > -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Zhang, Chen > Sent: Monday, June 22, 2020 2:53 PM > To: Dr. David Alan Gilbert > Cc: Zhanghailiang ; qemu-dev

Re: Failure prints during format or mounting a usb storage device

2020-07-08 Thread Paul Zimmerman
On Wed, Jul 8, 2020 at 12:29 AM Gerd Hoffmann wrote: > Hi, > > > > Why does 7ad3d51ebb8a522ffcad391c4bef281245739dde look at short-not-ok? > > > > Because the patch changes dev-storage to terminate the transfer if a > > short packet is received, so I figured 'short-not-ok' should affect > >

[PATCH] tests/docker: update toolchain set in debian-xtensa-cross

2020-07-08 Thread Max Filippov
Switch to the prebuilt xtensa toolchains release 2020.07. Drop csp toolchain as the csp core is not a part of QEMU. Add de233_fpu and dsp3400 toolchains to enable DFPU and FPU2000 tests. Signed-off-by: Max Filippov --- tests/docker/dockerfiles/debian-xtensa-cross.docker | 6 +++--- 1 file

Re: [PATCH v4 08/12] hw/nvram: NPCM7xx OTP device model

2020-07-08 Thread Philippe Mathieu-Daudé
On 7/7/20 8:47 PM, Havard Skinnemoen wrote: > This supports reading and writing OTP fuses and keys. Only fuse reading > has been tested. Protection is not implemented. > > Reviewed-by: Avi Fishman > Signed-off-by: Havard Skinnemoen > --- > hw/arm/npcm7xx.c | 32 +++ >

Re: [RFC v2 3/6] cpus: extract out kvm-specific code to accel/kvm

2020-07-08 Thread Claudio Fontana
Ciao Paolo, On 7/7/20 7:01 PM, Paolo Bonzini wrote: > On 07/07/20 15:58, Claudio Fontana wrote: >> +static void kvm_kick_vcpu_thread(CPUState *cpu) >> +{ >> +cpus_kick_thread(cpu); >> +} >> + > > I would just use cpus_kick_thread instead of wrapping it (and likewise Here I left the common

Qemu core dump when stop guest with virtio-blk(remote storage) and iothread

2020-07-08 Thread 苏思婷
Description of problem: Qemu core dump when stop guest with virtio-blk(remote storage) and iothread Version-Release number pf selected component (if applicable): kernel version:4.19.36.bsk.9-amd64 qemu-kvm version:QEMU emulator version 2.12.1 How reproducible:

Re: [PATCH] tests/docker: update toolchain set in debian-xtensa-cross

2020-07-08 Thread Alex Bennée
Max Filippov writes: > Switch to the prebuilt xtensa toolchains release 2020.07. > Drop csp toolchain as the csp core is not a part of QEMU. > Add de233_fpu and dsp3400 toolchains to enable DFPU and FPU2000 tests. Queued to misc/for-5.1-rc0, thanks. > > Signed-off-by: Max Filippov > --- >

Re: [PATCH 00/21] target/xtensa: implement double precision FPU

2020-07-08 Thread Alex Bennée
Max Filippov writes: > On Tue, Jul 7, 2020 at 12:21 PM Alex Bennée wrote: >> Well it ran some xtensa tests thanks to the docker cross compiler >> support. Do you know what toolchains we need? >> >> Currently we have the following: >> >> ENV CPU_LIST csp dc232b dc233c >> ENV

Re: [PATCH] tests/docker: update toolchain set in debian-xtensa-cross

2020-07-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200708082347.27318-1-jcmvb...@gmail.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: qemu-system-ppc64 abort()s with pcie bridges

2020-07-08 Thread Greg Kurz
On Wed, 8 Jul 2020 10:03:47 +0200 Thomas Huth wrote: > > Hi, > > qemu-system-ppc64 currently abort()s when it is started with a pcie > bridge device: > > $ qemu-system-ppc64 -M pseries-5.1 -device pcie-pci-bridge > Unexpected error in object_property_find() at qom/object.c:1240: >

[Bug 1886793] [NEW] "go install" command fails while running inside s390x docker container on x86_64 host using qemu

2020-07-08 Thread Nirman Narang
Public bug reported: Steps to reproduce the issue: Register x86_64 host with the latest qemu-user-static. docker run --rm --privileged multiarch/qemu-user-static --reset -p yes Build the following Docker Image using following Dockerfile.s390x using command docker build -t

[Bug 1886811] [NEW] systemd complains Failed to enqueue loopback interface start request: Operation not supported

2020-07-08 Thread Ryutaroh Matsumoto
Public bug reported: This symptom seems similar to https://bugs.launchpad.net/qemu/+bug/1823790 Host Linux: Debian 11 Bullseye (testing) on x84-64 architecture qemu version: latest git of git commit hash eb2c66b10efd2b914b56b20ae90655914310c925 compiled with "./configure --static

Re: [PATCH v4 04/11] target/ppc: convert vmuluwm to tcg_gen_gvec_mul

2020-07-08 Thread David Gibson
On Wed, Jul 01, 2020 at 06:43:39PM -0500, Lijun Pan wrote: > Convert the original implementation of vmuluwm to the more generic > tcg_gen_gvec_mul. > > Signed-off-by: Lijun Pan Applied to ppc-for-5.2. > --- > Reviewed-by: Richard Henderson > v3: newly introduced > > target/ppc/helper.h

Re: [PATCH] cpu: Add starts_halted() method

2020-07-08 Thread David Gibson
On Wed, Jul 08, 2020 at 10:38:29AM +0200, Philippe Mathieu-Daudé wrote: > Hi Thiago, > > On 7/8/20 1:28 AM, Thiago Jung Bauermann wrote: > > > > Hello Eduardo, > > > > Eduardo Habkost writes: > > > >> On Tue, Jul 07, 2020 at 05:43:33PM -0300, Thiago Jung Bauermann wrote: > >>> PowerPC sPAPRs

Re: [PATCH] hw/register: Document register_init_block @memory_size

2020-07-08 Thread Laurent Vivier
Le 07/07/2020 à 08:23, Philippe Mathieu-Daudé a écrit : > Document the 'memory_size' argument of register_init_block(). > > Fixes: a74229597e ("register: Add block initialise helper") > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/register.h | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH] cpu: Add starts_halted() method

2020-07-08 Thread Peter Maydell
On Wed, 8 Jul 2020 at 12:12, David Gibson wrote: > On Wed, Jul 08, 2020 at 10:38:29AM +0200, Philippe Mathieu-Daudé wrote: > > Class boolean field certainly sounds better, but I am not sure this > > is a property of the machine. Rather the arch? So move the field > > to CPUClass? Maybe not, let's

Re: [PULL v2 00/41] virtio,acpi: features, fixes, cleanups.

2020-07-08 Thread Peter Maydell
On Wed, 8 Jul 2020 at 07:45, Michael S. Tsirkin wrote: > > On Tue, Jul 07, 2020 at 06:50:55PM +0100, Peter Maydell wrote: > > Sure. (You can always just resend a new v2 cover letter without > > all the patches; that's what most people do for minor respins.) > > As a reply-to or as a new thread?

Re: [PATCH] trivial: Remove trailing whitespaces

2020-07-08 Thread Roman Bolshakov
On Mon, Jul 06, 2020 at 06:23:00PM +0200, Christophe de Dinechin wrote: > There are a number of unnecessary trailing whitespaces that have > accumulated over time in the source code. They cause stray changes > in patches if you use tools that automatically remove them. > > Tested by doing a `git

Migrating custom qemu.org infrastructure to GitLab

2020-07-08 Thread Stefan Hajnoczi
Dear QEMU community, QEMU currently has a static website, wiki, git repo hosting, and special-purpose cronjobs/containers running in VMs. There is currently no system administrator looking after our infrastructure so the most urgent tasks fall onto me, the remainder are ignored/postponed. The

[Bug 1886793] Re: "go install" command fails while running inside s390x docker container on x86_64 host using qemu

2020-07-08 Thread Nirman Narang
One more thing which I tried: I installed qemu on x86 Ubuntu host with apt-get install. Extracted s390x go 1.14.2 binaries on the same. Ran the following commands: root:~ wget -q https://storage.googleapis.com/golang/go1.14.2.linux-s390x.tar.gz root@:~# chmod ugo+r go1.14.2.linux-s390x.tar.gz

build error of unused function as MACRO G_DEFINE_AUTOPTR_CLEANUP_FUNC expand

2020-07-08 Thread Li Qiang
Hello all, I build qemu with fuzzing enabled using clang and following error come. nbd/server.c:1937:1: error: unused function 'glib_listautoptr_cleanup_NBDExtentArray' [-Werror,-Wunused-function] G_DEFINE_AUTOPTR_CLEANUP_FUNC(NBDExtentArray, nbd_extent_array_free); ^

Re: [PATCH 07/21] target/xtensa: move FSR/FCR register accessors

2020-07-08 Thread Richard Henderson
On 7/6/20 4:47 PM, Max Filippov wrote: > Move FSR/FCR register accessors from core opcodes to FPU2000 opcodes as > they are FPU2000-specific. > > Signed-off-by: Max Filippov > --- > target/xtensa/translate.c | 64 +++ > 1 file changed, 32 insertions(+), 32

Re: [PATCH 3/5] block: introduce preallocate filter

2020-07-08 Thread Vladimir Sementsov-Ogievskiy
08.07.2020 15:07, Stefan Hajnoczi wrote: On Sat, Jun 20, 2020 at 05:36:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: It may be used for file-systems with slow allocation. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 3 +- block/preallocate.c | 255

Re: [PATCH 06/21] target/xtensa: rename FPU2000 translators and helpers

2020-07-08 Thread Richard Henderson
On 7/6/20 4:47 PM, Max Filippov wrote: > Add _s suffix to all FPU2000 opcode translators and helpers that also > have double-precision variant to unify naming and allow adding DFPU > implementations. Add _fpu2k_ to the name of wur_fcr helper to make space > for the DFPU wur_fcr helper. > >

Questions about online resizing a lun passthrough disk with virtio-scsi

2020-07-08 Thread lma
Hi all, I have questions about online resizing a scsi lun passthrough disk. Here is my test scenario: host A: - the local 50GB sata /dev/sdd1 is configured as a physical volume, Created a 10GB logical volume. - exported the lv by iscsi target by targetcli. host B: - connected to the above

Re: [PATCH v4 01/12] npcm7xx: Add config symbol

2020-07-08 Thread Havard Skinnemoen
On Wed, Jul 8, 2020 at 9:56 AM Philippe Mathieu-Daudé wrote: > > +config NPCM7XX > > +bool > > +select A9MPCORE > > +select ARM_GIC > > +select PL310 # cache controller > > +select SERIAL > > +select UNIMP > > And this in patch 5: "Add NPCM730 and NPCM750 SoC models" Is

Re: [RFC v2 1/6] cpus: extract out TCG-specific code to accel/tcg

2020-07-08 Thread Claudio Fontana
On 7/7/20 6:58 PM, Paolo Bonzini wrote: > On 07/07/20 15:58, Claudio Fontana wrote: >> + >> +CpusAccel tcg_cpus = { >> +.create_vcpu_thread = tcg_start_vcpu_thread, >> +.kick_vcpu_thread = tcg_kick_vcpu_thread, >> + >> +.synchronize_post_reset = tcg_cpu_synchronize_noop, >> +

Re: [PATCH 3/3] cpu-timers, icount: new modules

2020-07-08 Thread Claudio Fontana
On 7/8/20 5:12 PM, Paolo Bonzini wrote: > On 08/07/20 17:07, Thomas Huth wrote: >>> Nope, unfortunately we don't have an s390 CI. But if you can get your >>> hands on one, just "./configure --target-list=s390x-softmmu && make && >>> make check-block" will show it. >> >> We've got a s390x builder

Re: [PATCH] cpu: Add starts_halted() method

2020-07-08 Thread Peter Maydell
On Wed, 8 Jul 2020 at 16:25, Eduardo Habkost wrote: > On Wed, Jul 08, 2020 at 02:14:03PM +0100, Peter Maydell wrote: > > The original bug as described in the commit message sounds > > to me like something we should look to fix in the implementation > > of async_run_on_cpu() -- it shouldn't cause

Re: [PATCH 0/6] target/riscv: NaN-boxing for multiple precison

2020-07-08 Thread Richard Henderson
On 7/7/20 2:45 PM, LIU Zhiwei wrote: >> On 2020/7/3 1:37, Richard Henderson wrote: >>> I think it would be better to do all of the nan-boxing work inside of the >>> helpers, including the return values. >> Do you mean a helper function just for nan-boxing work? No, that's not what I mean. >> I

Re: [PATCH 03/21] softfloat: add xtensa specialization for pickNaNMulAdd

2020-07-08 Thread Richard Henderson
On 7/6/20 4:47 PM, Max Filippov wrote: > pickNaNMulAdd logic on Xtensa is the same as pickNaN when applied to > the expression (a * b) + c. So with two pickNaN variants there must be > two pickNaNMulAdd variants. "Is the same as"? I question the non-use of the infzero parameter. When infzero,

Memory callback

2020-07-08 Thread Super Man
Sorry to bother you, I would like to ask a question.I want to use qemu to monitor the information of the target thread reading and writing memory. I see that qemu supports the tcg plugin, but I just find the following code in plugin-gen.c .Do I just need to add a record function in it? How do I

[PATCH v2 2/2] linux-user: fix print_syscall_err() when syscall returned value is negative

2020-07-08 Thread Laurent Vivier
print_syscall_err() relies on the sign of the returned value to know if it is an errno value or not. But in some cases the returned value can have the most signicant bit set without being an errno. This patch restores previous behaviour that was also checking if we can decode the errno to

[PATCH v2 0/2] linux-user: fix print_syscall_err()

2020-07-08 Thread Laurent Vivier
This function has been introduced to manage in a generic way the error code of the syscall in the strace output. But it has introduced a regression regarding two previous commits: 2a7e12455c1d ("linux-user/strace.c: Correct errno printing for mmap etc") that intoduced the use of "-ret" rather

[PATCH v2 1/2] linux-user: fix the errno value in print_syscall_err()

2020-07-08 Thread Laurent Vivier
errno of the target is returned as a negative value by the syscall, not in the host errno variable. The emulation of the target syscall can return an error while the host doesn't set an errno value. Target errnos and host errnos can also differ in some cases. Fixes: c84be71f6854 ("linux-user:

Re: [PULL 07/15] hw/timer: RX62N 8-Bit timer (TMR)

2020-07-08 Thread Yoshinori Sato
2020-07-08 00:06 に Thomas Huth さんは書きました: On 07/07/2020 17.02, Yoshinori Sato wrote: On Mon, 29 Jun 2020 18:58:56 +0900, Philippe Mathieu-Daudé wrote: Hi Yoshinori, On 6/25/20 11:25 AM, Peter Maydell wrote: On Sun, 21 Jun 2020 at 13:54, Philippe Mathieu-Daudé wrote: From: Yoshinori Sato

Re: [PATCH v2 1/2] linux-user: fix the errno value in print_syscall_err()

2020-07-08 Thread Richard Henderson
On 7/8/20 8:24 AM, Laurent Vivier wrote: > errno of the target is returned as a negative value by the syscall, > not in the host errno variable. > > The emulation of the target syscall can return an error while the > host doesn't set an errno value. Target errnos and host errnos can > also differ

Re: [PATCH 2/5] block/io: introduce bdrv_co_range_try_lock

2020-07-08 Thread Vladimir Sementsov-Ogievskiy
07.07.2020 19:10, Stefan Hajnoczi wrote: On Sat, Jun 20, 2020 at 05:36:46PM +0300, Vladimir Sementsov-Ogievskiy wrote: @@ -83,6 +84,12 @@ typedef struct BdrvTrackedRequest { CoQueue wait_queue; /* coroutines blocked on this request */ struct BdrvTrackedRequest *waiting_for; + +

Re: Migrating custom qemu.org infrastructure to GitLab

2020-07-08 Thread Stefan Hajnoczi
On Wed, Jul 8, 2020 at 10:52 AM Stefan Hajnoczi wrote: Great, thanks for all the responses! Since others are interested in qemu-web.git, the wiki, and the bug tracker, I will investigate git repo hosting (mirrors). I'll send an update once I have more experience with GitLab and a proposal for

Re: [PATCH 3/3] cpu-timers, icount: new modules

2020-07-08 Thread Claudio Fontana
On 7/8/20 4:34 PM, Paolo Bonzini wrote: > On 29/06/20 11:35, Claudio Fontana wrote: >> refactoring of cpus.c continues with cpu timer state extraction. >> >> cpu-timers: responsible for the cpu timers state, and for access to >> cpu clocks and ticks. >> >> icount: counts the TCG instructions

Re: [PATCH 3/3] cpu-timers, icount: new modules

2020-07-08 Thread Claudio Fontana
On 7/8/20 5:05 PM, Paolo Bonzini wrote: > On 08/07/20 17:00, Claudio Fontana wrote: >>> Bisectable, 100% failure rate, etc. :( Can you split the patch in >>> multiple parts, specifically separating any rename or introducing of >>> includes from the final file move? >> Hi Paolo, >> >> will take a

Re: [PATCH 3/3] cpu-timers, icount: new modules

2020-07-08 Thread Claudio Fontana
On 7/8/20 5:23 PM, Paolo Bonzini wrote: > On 08/07/20 17:17, Claudio Fontana wrote: >> On 7/8/20 5:05 PM, Paolo Bonzini wrote: >>> On 08/07/20 17:00, Claudio Fontana wrote: > Bisectable, 100% failure rate, etc. :( Can you split the patch in > multiple parts, specifically separating any

Re: [PATCH v2 2/2] linux-user: fix print_syscall_err() when syscall returned value is negative

2020-07-08 Thread Richard Henderson
On 7/8/20 8:24 AM, Laurent Vivier wrote: > -static void > +static bool > print_syscall_err(abi_long ret) > { > -const char *errstr = NULL; > +const char *errstr; > > qemu_log(" = "); > if (ret < 0) { This should be a target-specific test. E.g. on most asm-generic I'm pretty

Re: [PULL 00/53] Misc patches for QEMU 5.1 soft freeze

2020-07-08 Thread Claudio Fontana
On 7/7/20 8:37 PM, Peter Maydell wrote: > On Mon, 6 Jul 2020 at 17:48, Paolo Bonzini wrote: >> >> The following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab: >> >> hw/misc/pca9552: Add missing TypeInfo::class_size field (2020-06-29 >> 21:16:10 +0100) >> >> are available in the

Re: [PATCH v2 2/2] linux-user: fix print_syscall_err() when syscall returned value is negative

2020-07-08 Thread Laurent Vivier
Le 08/07/2020 à 17:52, Richard Henderson a écrit : > On 7/8/20 8:24 AM, Laurent Vivier wrote: >> -static void >> +static bool >> print_syscall_err(abi_long ret) >> { >> -const char *errstr = NULL; >> +const char *errstr; >> >> qemu_log(" = "); >> if (ret < 0) { > > This

Re: [PATCH 05/21] target/xtensa: support copying registers up to 64 bits wide

2020-07-08 Thread Richard Henderson
On 7/6/20 4:47 PM, Max Filippov wrote: > +if (arg_copy[i].arg->num_bits <= 32) { > +temp = tcg_temp_local_new_i32(); > +tcg_gen_mov_i32(temp, arg_copy[i].arg->in); > +} else if (arg_copy[i].arg->num_bits <= 64) { > +

Re: [PATCH 08/21] target/xtensa: don't access BR regfile directly

2020-07-08 Thread Richard Henderson
On 7/6/20 4:47 PM, Max Filippov wrote: > BR registers used in FPU comparison opcodes are available as opcode > arguments for translators. Use them. This simplifies comparison helpers > interface and makes them usable in FLIX bundles. > > Signed-off-by: Max Filippov > --- >

Re: [PATCH v2 1/2] linux-user: fix the errno value in print_syscall_err()

2020-07-08 Thread Philippe Mathieu-Daudé
On 7/8/20 5:24 PM, Laurent Vivier wrote: > errno of the target is returned as a negative value by the syscall, > not in the host errno variable. > > The emulation of the target syscall can return an error while the > host doesn't set an errno value. Target errnos and host errnos can > also differ

Re: [PULL 0/2] tcg patch queue

2020-07-08 Thread Peter Maydell
On Mon, 6 Jul 2020 at 19:52, Richard Henderson wrote: > > The following changes since commit eb6490f544388dd24c0d054a96dd304bc7284450: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200703' into staging (2020-07-04 > 16:08:41 +0100) > > are available in the Git

Re: [PATCH 1/5] block/io: introduce bdrv_try_mark_request_serialising

2020-07-08 Thread Vladimir Sementsov-Ogievskiy
07.07.2020 18:56, Stefan Hajnoczi wrote: On Sat, Jun 20, 2020 at 05:36:45PM +0300, Vladimir Sementsov-Ogievskiy wrote: Introduce a function to mark the request serialising only if there are no conflicting request to wait for. The function is static, so mark it unused. The attribute is to be

Re: [PATCH 09/21] target/xtensa: add DFP option, registers and opcodes

2020-07-08 Thread Richard Henderson
On 7/6/20 4:47 PM, Max Filippov wrote: > +float64 HELPER(add_d)(CPUXtensaState *env, float64 a, float64 b) > +{ > +set_use_first_nan(true, >fp_status); > +return float64_add(a, b, >fp_status); > +} > + > float32 HELPER(add_s)(CPUXtensaState *env, float32 a, float32 b) > { > +

Re: [PULL 00/53] Misc patches for QEMU 5.1 soft freeze

2020-07-08 Thread Claudio Fontana
On 7/8/20 6:16 PM, Paolo Bonzini wrote: > On 08/07/20 18:13, Claudio Fontana wrote: >> so I don't get any tcg_get_icount_limit() compiled in, and no >> errors. >> >> I think that having comparable configure command line and compiler >> version/flags would help me pin down any related issue. > >

Re: [PATCH v4 01/12] npcm7xx: Add config symbol

2020-07-08 Thread Philippe Mathieu-Daudé
On 7/7/20 8:47 PM, Havard Skinnemoen wrote: > Add a config symbol for the NPCM7xx BMC SoC family that subsequent > patches can use in Makefiles. > > Reviewed-by: Tyrone Ting > Acked-by: Joel Stanley > Signed-off-by: Havard Skinnemoen > --- > default-configs/arm-softmmu.mak | 1 + >

Re: [PATCH v4 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-08 Thread Philippe Mathieu-Daudé
Hi Havard, On 7/7/20 8:47 PM, Havard Skinnemoen wrote: > The Nuvoton NPCM7xx SoC family are used to implement Baseboard > Management Controllers in servers. While the family includes four SoCs, > this patch implements limited support for two of them: NPCM730 (targeted > for Data Center

Re: [PATCH v7 06/47] block: Drop bdrv_is_encrypted()

2020-07-08 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: The original purpose of bdrv_is_encrypted() was to inquire whether a BDS can be used without the user entering a password or not. It has not been used for that purpose for quite some time. Actually, it is not even fit for that purpose, because to answer

Re: [PATCH 01/21] softfloat: make NO_SIGNALING_NANS runtime property

2020-07-08 Thread Philippe Mathieu-Daudé
On 7/7/20 1:47 AM, Max Filippov wrote: > target/xtensa, the only user of NO_SIGNALING_NANS macro has FPU > implementations with and without the corresponding property. With > NO_SIGNALING_NANS being a macro they cannot be a part of the same QEMU > executable. > Replace macro with new property in

Re: [PATCH v7 07/47] block: Add bdrv_supports_compressed_writes()

2020-07-08 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: Filters cannot compress data themselves but they have to implement .bdrv_co_pwritev_compressed() still (or they cannot forward compressed writes). Therefore, checking whether bs->drv->bdrv_co_pwritev_compressed is non-NULL is not sufficient to know whether

Re: [PATCH v3 17/18] hw/block/nvme: provide the mandatory subnqn field

2020-07-08 Thread Dmitry Fomichev
Looks good, Reviewed-by: Dmitry Fomichev On Mon, 2020-07-06 at 08:13 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > The SUBNQN field is mandatory in NVM Express 1.3. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

Re: [PATCH v3 12/18] hw/block/nvme: support the get/set features select and save fields

2020-07-08 Thread Dmitry Fomichev
Looks good, Reviewed-by: Dmitry Fomichev On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Since the device does not have any persistent state storage, no > features are "saveable" and setting the Save (SV) field in any Set > Features command will result in a

[PATCH 0/2] keepalive default

2020-07-08 Thread Vladimir Sementsov-Ogievskiy
Hi all! We understood, that keepalive is almost superfluous with default 2 hours in /proc/tcp_keepalive_time. Forcing user to setup keepalive for the whole system doesn't seem right, better setup it per-socket. These series suggests to set some defaults for keepalive settings as well as set

Re: [PATCH 0/2] keepalive default

2020-07-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200708191540.28455-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [PATCH] cpu: Add starts_halted() method

2020-07-08 Thread Peter Maydell
On Wed, 8 Jul 2020 at 17:03, Eduardo Habkost wrote: > > On Wed, Jul 08, 2020 at 04:32:51PM +0100, Peter Maydell wrote: > > On Wed, 8 Jul 2020 at 16:25, Eduardo Habkost wrote: > > > On Wed, Jul 08, 2020 at 02:14:03PM +0100, Peter Maydell wrote: > > > > The original bug as described in the commit

[Bug 1886811] Re: systemd complains Failed to enqueue loopback interface start request: Operation not supported

2020-07-08 Thread Ryutaroh Matsumoto
** Bug watch added: Debian Bug tracker #964289 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964289 ** Also affects: qemu (Debian) via https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964289 Importance: Unknown Status: Unknown -- You received this bug notification because

Re: [PATCH v7 08/47] throttle: Support compressed writes

2020-07-08 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/throttle.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/throttle.c b/block/throttle.c index 0ebbad0743..f6e619aca2 100644 --- a/block/throttle.c +++

Re: [PATCH v7 10/47] mirror-top: Support compressed writes

2020-07-08 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: Signed-off-by: Max Reitz --- block/mirror.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/mirror.c b/block/mirror.c index e8e8844afc..469acf4600 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1480,6 +1480,15 @@ static int

Re: [PATCH v7 13/47] block: Use CAFs in block status functions

2020-07-08 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: Use the child access functions in the block status inquiry functions as appropriate. Signed-off-by: Max Reitz --- block/io.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/block/io.c b/block/io.c index

Re: [PATCH v3 15/18] hw/block/nvme: reject invalid nsid values in active namespace id list

2020-07-08 Thread Dmitry Fomichev
Looks good, Reviewed-by: Dmitry Fomichev On Mon, 2020-07-06 at 08:13 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Reject the nsid broadcast value (0x) and 0xfffe in the > Active Namespace ID list. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 10 ++ >

Re: [PATCH] MAINTAINERS: update nvme entry

2020-07-08 Thread Keith Busch
On Tue, Jul 07, 2020 at 05:26:13PM +0200, Kevin Wolf wrote: > Am 06.07.2020 um 21:43 hat Keith Busch geschrieben: > > The nvme emulated device development pace has increased recently. Klaus > > has offered to co-maintain, and since we have many new contributions > > coming through, we're adding a

Re: [PATCH v4 08/12] hw/nvram: NPCM7xx OTP device model

2020-07-08 Thread Havard Skinnemoen
On Wed, Jul 8, 2020 at 1:54 AM Philippe Mathieu-Daudé wrote: > > On 7/7/20 8:47 PM, Havard Skinnemoen wrote: > > +value = tswap32(nc->disabled_modules); > > +npcm7xx_otp_array_write(>fuse_array, , 64, sizeof(value)); > > What is magic offset 64 for? Good point. I'll add some definitions

Re: [PATCH v4 01/12] npcm7xx: Add config symbol

2020-07-08 Thread Philippe Mathieu-Daudé
On 7/8/20 6:58 PM, Havard Skinnemoen wrote: > On Wed, Jul 8, 2020 at 9:56 AM Philippe Mathieu-Daudé wrote: >>> +config NPCM7XX >>> +bool >>> +select A9MPCORE >>> +select ARM_GIC >>> +select PL310 # cache controller >>> +select SERIAL >>> +select UNIMP >> >> And this in

Re: [PATCH 05/21] target/xtensa: support copying registers up to 64 bits wide

2020-07-08 Thread Max Filippov
On Wed, Jul 8, 2020 at 9:14 AM Richard Henderson wrote: > > On 7/6/20 4:47 PM, Max Filippov wrote: > > +if (arg_copy[i].arg->num_bits <= 32) { > > +temp = tcg_temp_local_new_i32(); > > +tcg_gen_mov_i32(temp, arg_copy[i].arg->in); > > +

Re: [PATCH v7 01/47] block: Add child access functions

2020-07-08 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: There are BDS children that the general block layer code can access, namely bs->file and bs->backing. Since the introduction of filters and external data files, their meaning is not quite clear. bs->backing can be a COW source, or it can be a filtered

Re: [PATCH v7 02/47] block: Add chain helper functions

2020-07-08 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: Add some helper functions for skipping filters in a chain of block nodes. Signed-off-by: Max Reitz --- include/block/block_int.h | 3 +++ block.c | 55 +++ 2 files changed, 58 insertions(+) diff

Re: [PATCH 09/21] target/xtensa: add DFP option, registers and opcodes

2020-07-08 Thread Max Filippov
On Wed, Jul 8, 2020 at 9:25 AM Richard Henderson wrote: > > On 7/6/20 4:47 PM, Max Filippov wrote: > > +float64 HELPER(add_d)(CPUXtensaState *env, float64 a, float64 b) > > +{ > > +set_use_first_nan(true, >fp_status); > > +return float64_add(a, b, >fp_status); > > +} > > + > > float32

Re: [PATCH v4 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-08 Thread Philippe Mathieu-Daudé
On 7/8/20 7:31 PM, Philippe Mathieu-Daudé wrote: > Hi Havard, > > On 7/7/20 8:47 PM, Havard Skinnemoen wrote: >> The Nuvoton NPCM7xx SoC family are used to implement Baseboard >> Management Controllers in servers. While the family includes four SoCs, >> this patch implements limited support for

Re: [PATCH v4 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-08 Thread Havard Skinnemoen
On Wed, Jul 8, 2020 at 10:31 AM Philippe Mathieu-Daudé wrote: > > Hi Havard, > > On 7/7/20 8:47 PM, Havard Skinnemoen wrote: > > The Nuvoton NPCM7xx SoC family are used to implement Baseboard > > Management Controllers in servers. While the family includes four SoCs, > > this patch implements

Re: [PATCH v3 03/18] hw/block/nvme: additional tracing

2020-07-08 Thread Dmitry Fomichev
Looks good, Reviewed-by: Dmitry Fomichev > On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Add various additional tracing and streamline nvme_identify_ns and > nvme_identify_nslist (they do not need to repeat the command, it is > already in the trace name). >

Re: [PATCH v3 02/18] hw/block/nvme: fix missing endian conversion

2020-07-08 Thread Dmitry Fomichev
Looks good, Reviewed-by: Dmitry Fomichev > On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Fix a missing cpu_to conversion by moving conversion to just before > returning instead. > > Signed-off-by: Klaus Jensen > Suggested-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH v7 00/47] block: Deal with filters

2020-07-08 Thread Andrey Shinkevich
On 08.07.2020 20:32, Eric Blake wrote: On 7/8/20 12:20 PM, Andrey Shinkevich wrote: On 25.06.2020 18:21, Max Reitz wrote: v6: https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg01715.html Branch: https://github.com/XanClic/qemu.git child-access-functions-v7 Branch:

Re: [PATCH v7 03/47] block: bdrv_cow_child() for bdrv_has_zero_init()

2020-07-08 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: bdrv_has_zero_init() and the related bdrv_unallocated_blocks_are_zero() should use bdrv_cow_child() if they want to check whether the given BDS has a COW backing file. Signed-off-by: Max Reitz --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH v7 05/47] block: Include filters when freezing backing chain

2020-07-08 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: In order to make filters work in backing chains, the associated functions must be able to deal with them and freeze both COW and filter child links. While at it, add some comments that note which functions require their caller to ensure that a given child

Re: [PATCH v7 11/47] backup-top: Support compressed writes

2020-07-08 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: Signed-off-by: Max Reitz --- block/backup-top.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/backup-top.c b/block/backup-top.c index af2f20f346..f304df8f26 100644 --- a/block/backup-top.c +++ b/block/backup-top.c @@ -99,6 +99,15

Re: [PATCH 03/21] softfloat: add xtensa specialization for pickNaNMulAdd

2020-07-08 Thread Max Filippov
On Wed, Jul 8, 2020 at 9:07 AM Richard Henderson wrote: > > On 7/6/20 4:47 PM, Max Filippov wrote: > > pickNaNMulAdd logic on Xtensa is the same as pickNaN when applied to > > the expression (a * b) + c. So with two pickNaN variants there must be > > two pickNaNMulAdd variants. > > "Is the same

Re: [PATCH 7/7] block/io: improve loadvm performance

2020-07-08 Thread Vladimir Sementsov-Ogievskiy
03.07.2020 20:35, Denis V. Lunev wrote: This patch creates intermediate buffer for reading from block driver state and performs read-ahead to this buffer. Snapshot code performs reads sequentially and thus we know what offsets will be required and when they will become not needed. Results are

Re: [PATCH v3 05/18] hw/block/nvme: add temperature threshold feature

2020-07-08 Thread Dmitry Fomichev
Looks good, Reviewed-by: Dmitry Fomichev On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > It might seem weird to implement this feature for an emulated device, > but it is mandatory to support and the feature is useful for testing > asynchronous event request

Re: [PATCH v3 07/18] hw/block/nvme: add support for the get log page command

2020-07-08 Thread Dmitry Fomichev
Looks good, Reviewed-by: Dmitry Fomichev On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Add support for the Get Log Page command and basic implementations of > the mandatory Error Information, SMART / Health Information and Firmware > Slot Information log

Re: build error of unused function as MACRO G_DEFINE_AUTOPTR_CLEANUP_FUNC expand

2020-07-08 Thread Alexander Bulekov
Hi Li, I usually build the fuzzer with "make i386-softmmu/fuzz", so I must have missed the nbd issue... I could not reproduce this locally since: alxndr@mozz:qemu(master)$ dpkg -l "*glib2.0-bin*" Desired=Unknown/Install/Remove/Purge/Hold |

Re: [PULL 00/53] Misc patches for QEMU 5.1 soft freeze

2020-07-08 Thread Claudio Fontana
On 7/8/20 6:55 PM, Paolo Bonzini wrote: > On 08/07/20 18:45, Claudio Fontana wrote: >> C++ is used to link the final qemu-system binary and on my system c++ has >> LTO: >> >> c++ -v >> Using built-in specs. >> COLLECT_GCC=c++ >> COLLECT_LTO_WRAPPER=/usr/lib64/gcc/x86_64-suse-linux/7/lto-wrapper

[Bug 1886811] Re: systemd complains Failed to enqueue loopback interface start request: Operation not supported

2020-07-08 Thread Laurent Vivier
It would help to know which operation is not supported. Could you get the coredump? Is it possible to run the operation with "QEMU_STRACE" set in the environment? Normally loop ioctls are supported. But it seems the following ones are not implemented in QEMU: LOOP_SET_CAPACITY,

Re: [PATCH v7 00/47] block: Deal with filters

2020-07-08 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: v6: https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg01715.html Branch: https://github.com/XanClic/qemu.git child-access-functions-v7 Branch: https://git.xanclic.moe/XanClic/qemu.git child-access-functions-v7 I cloned the branch from the

Re: [PATCH v7 04/47] block: bdrv_set_backing_hd() is about bs->backing

2020-07-08 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: bdrv_set_backing_hd() is a function that explicitly cares about the bs->backing child. Highlight that in its description and use child_bs(bs->backing) instead of backing_bs(bs) to make it more obvious. Signed-off-by: Max Reitz Reviewed-by: Vladimir

[Bug 1886793] Re: "go install" command fails while running inside s390x docker container on x86_64 host using qemu

2020-07-08 Thread Laurent Vivier
Could you try to reproduce the problem with the latest version of QEMU from git repo? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1886793 Title: "go install" command fails while running inside

[RFC PATCH] configure: remove all dependencies on a (re)configure

2020-07-08 Thread Alex Bennée
The previous code was brittle and missed cases such as the mipn32 variants which for some reason has the 64 bit syscalls. This leads to a number of binary targets having deps lines like: all.clang-sanitizer/mipsn32el-linux-user/linux-user/signal.d 140:

Re: [PATCH v7 09/47] copy-on-read: Support compressed writes

2020-07-08 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: Signed-off-by: Max Reitz --- block/copy-on-read.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/block/copy-on-read.c b/block/copy-on-read.c index a6e3c74a68..a6a864f147 100644 --- a/block/copy-on-read.c +++ b/block/copy-on-read.c @@

Re: [PULL 00/53] Misc patches for QEMU 5.1 soft freeze

2020-07-08 Thread Claudio Fontana
On 7/8/20 7:03 PM, Claudio Fontana wrote: > On 7/8/20 6:55 PM, Paolo Bonzini wrote: >> On 08/07/20 18:45, Claudio Fontana wrote: >>> C++ is used to link the final qemu-system binary and on my system c++ has >>> LTO: >>> >>> c++ -v >>> Using built-in specs. >>> COLLECT_GCC=c++ >>>

Re: [PATCH v7 12/47] block: Use bdrv_filter_(bs|child) where obvious

2020-07-08 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: Places that use patterns like if (bs->drv->is_filter && bs->file) { ... something about bs->file->bs ... } should be BlockDriverState *filtered = bdrv_filter_bs(bs); if (filtered) { ... something about @filtered ...

Re: [PULL 00/53] Misc patches for QEMU 5.1 soft freeze

2020-07-08 Thread Claudio Fontana
On 7/8/20 8:25 PM, Claudio Fontana wrote: > On 7/8/20 7:03 PM, Claudio Fontana wrote: >> On 7/8/20 6:55 PM, Paolo Bonzini wrote: >>> On 08/07/20 18:45, Claudio Fontana wrote: C++ is used to link the final qemu-system binary and on my system c++ has LTO: c++ -v Using

[PATCH 2/2] util/qemu-sockets: make keep-alive enabled by default

2020-07-08 Thread Vladimir Sementsov-Ogievskiy
Keep-alive won't hurt, let's try to enable it even if not requested by user. Signed-off-by: Vladimir Sementsov-Ogievskiy --- util/qemu-sockets.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index

[PATCH 1/2] sockets: keep-alive settings

2020-07-08 Thread Vladimir Sementsov-Ogievskiy
Introduce keep-alive settings (TCP_KEEPCNT, TCP_KEEPIDLE, TCP_KEEPINTVL) and chose some defaults. The linux default of 2 hours for /proc/tcp_keepalive_time (corresponding to TCP_KEEPIDLE) makes keep-alive option almost superfluous. Let's add a possibility to set the options by hand and specify

Re: [PATCH v3 01/18] hw/block/nvme: bump spec data structures to v1.3

2020-07-08 Thread Dmitry Fomichev
Looks good with a small nit (see below), Reviewed-by: Dmitry Fomichev > On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Add missing fields in the Identify Controller and Identify Namespace > data structures to bring them in line with NVMe v1.3. > > This also

  1   2   3   4   >