Re: [PATCH 2/2] util/qemu-sockets: make keep-alive enabled by default

2020-07-09 Thread Daniel P . Berrangé
On Wed, Jul 08, 2020 at 10:15:39PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Keep-alive won't hurt, let's try to enable it even if not requested by > user. Keep-alive intentionally breaks TCP connections earlier than normal in face of transient networking problems. The question is more about

Re: [PATCH RFC 4/5] s390x: implement virtio-mem-ccw

2020-07-09 Thread Cornelia Huck
On Wed, 8 Jul 2020 20:51:34 +0200 David Hildenbrand wrote: > Add a proper CCW proxy device, similar to the PCI variant. > > Signed-off-by: David Hildenbrand > --- > hw/s390x/virtio-ccw-mem.c | 165 ++ > hw/s390x/virtio-ccw.h | 13 +++ > 2 files

Re: [PATCH 2/2] x86/cpu: Handle GUEST_MAXPHYADDR < HOST_MAXPHYADDR for hosts that don't support it

2020-07-09 Thread Paolo Bonzini
On 09/07/20 11:55, Mohammed Gamal wrote: >> Ideally we would simply outlaw (3), but it's hard for backward >> compatibility reasons. Second best solution is a flag somewhere >> (msr, cpuid, ...) telling the guest firmware "you can use >> GUEST_MAXPHYADDR, we guarantee it is <= HOST_MAXPHYADDR". >

Re: [PATCH 1/7] migration/savevm: respect qemu_fclose() error code in save_snapshot()

2020-07-09 Thread Juan Quintela
"Denis V. Lunev" wrote: > qemu_fclose() could return error, f.e. if bdrv_co_flush() will return > the error. > > This validation will become more important once we will start waiting of > asynchronous IO operations, started from bdrv_write_vmstate(), which are > coming soon. > > Signed-off-by:

Re: [PULL 13/29] qapi: Flatten object-add

2020-07-09 Thread Markus Armbruster
Paolo Bonzini writes: > On 08/07/20 18:05, Kevin Wolf wrote: >> Markus was going to introduce new QAPI schema syntax that would allow to >> specify a few options explicitly and then one option for "the rest" that >> would just be mapped to a QDict like "any" or "gen": false, and that >> wouldn't

Re: [PULL 00/12] Block layer patches

2020-07-09 Thread Kevin Wolf
Am 07.07.2020 um 18:34 hat Kevin Wolf geschrieben: > The following changes since commit 7623b5ba017f61de5d7c2bba12c6feb3d55091b1: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-5.1-pull-request' into staging > (2020-07-06 11:40:10 +0100) > > are available in the Git

Re: [PATCH] tests/qtest/fuzz: Add missing spaces in description

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 10:37 AM, Thomas Huth wrote: > There should be a space between "forking" and "for". > > Signed-off-by: Thomas Huth > --- > tests/qtest/fuzz/virtio_scsi_fuzz.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/qtest/fuzz/virtio_scsi_fuzz.c >

Re: [PATCH] cpu: Add starts_halted() method

2020-07-09 Thread Greg Kurz
On Thu, 9 Jul 2020 12:18:06 +0200 Philippe Mathieu-Daudé wrote: > On 7/9/20 11:54 AM, Greg Kurz wrote: > > On Thu, 9 Jul 2020 07:11:09 +0200 > > Philippe Mathieu-Daudé wrote: > >> On 7/8/20 11:39 PM, Eduardo Habkost wrote: > >>> On Wed, Jul 08, 2020 at 06:45:57PM +0200, Philippe Mathieu-Daudé

Re: [PULL 00/53] Misc patches for QEMU 5.1 soft freeze

2020-07-09 Thread Claudio Fontana
On 7/8/20 8:41 PM, Paolo Bonzini wrote: > > > Il mer 8 lug 2020, 20:25 Claudio Fontana > ha scritto: > > What I did notice is that all the code that directly or indirectly uses > the functions is under an > > if (0) ( > ) > > since tcg_enabled is the

Re: [PATCH 1/2] sockets: keep-alive settings

2020-07-09 Thread Daniel P . Berrangé
On Wed, Jul 08, 2020 at 10:15:38PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Introduce keep-alive settings (TCP_KEEPCNT, TCP_KEEPIDLE, > TCP_KEEPINTVL) and chose some defaults. > > The linux default of 2 hours for /proc/tcp_keepalive_time > (corresponding to TCP_KEEPIDLE) makes keep-alive

Re: [PATCH v7 00/47] block: Deal with filters

2020-07-09 Thread Andrey Shinkevich
On 09.07.2020 11:20, Max Reitz wrote: On 08.07.20 22:47, Eric Blake wrote: On 7/8/20 12:20 PM, Andrey Shinkevich wrote: On 25.06.2020 18:21, Max Reitz wrote: v6: https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg01715.html Branch: https://github.com/XanClic/qemu.git

Re: qemu-system-ppc64 abort()s with pcie bridges

2020-07-09 Thread Greg Kurz
On Wed, 8 Jul 2020 11:57:03 +0200 Greg Kurz wrote: > On Wed, 8 Jul 2020 10:03:47 +0200 > Thomas Huth wrote: > > > > > Hi, > > > > qemu-system-ppc64 currently abort()s when it is started with a pcie > > bridge device: > > > > $ qemu-system-ppc64 -M pseries-5.1 -device pcie-pci-bridge > >

Re: [PATCH] migration: fix memory leak in qmp_migrate_set_parameters

2020-07-09 Thread Juan Quintela
Chuan Zheng wrote: > From: Zheng Chuan > > "tmp.tls_hostname" and "tmp.tls_creds" allocated by > migrate_params_test_apply() > is forgot to free at the end of qmp_migrate_set_parameters(). Fix that. > > The leak stack: > Direct leak of 2 byte(s) in 2 object(s) allocated from: >#0

Re: [PATCH] cpu: Add starts_halted() method

2020-07-09 Thread Greg Kurz
On Thu, 9 Jul 2020 07:11:09 +0200 Philippe Mathieu-Daudé wrote: > On 7/8/20 11:39 PM, Eduardo Habkost wrote: > > On Wed, Jul 08, 2020 at 06:45:57PM +0200, Philippe Mathieu-Daudé wrote: > >> On 7/8/20 5:25 PM, Eduardo Habkost wrote: > >>> On Wed, Jul 08, 2020 at 02:14:03PM +0100, Peter Maydell

Re: Migrating custom qemu.org infrastructure to GitLab

2020-07-09 Thread Gerd Hoffmann
Hi, > > 2. wiki.qemu.org is a MediaWiki instance. Account creation is a hurdle > > to one-time or new contributors. It is unclear whether GitLab's wiki > > is expressive enough for a lossless conversion of the existing QEMU > > wiki. Any volunteers interested in evaluating the wiki migration

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

2020-07-09 Thread Daniel P . Berrangé
On Wed, Jul 08, 2020 at 10:46:57PM -0400, Cleber Rosa wrote: > This is a mapping of Peter's "remake-merge-builds" and > "pull-buildtest" scripts, gone through some updates, adding some build > option and removing others. > > The jobs currently cover the machines that the QEMU project owns, and

Re: [PULL v2 00/41] virtio,acpi: features, fixes, cleanups.

2020-07-09 Thread Peter Maydell
On Tue, 7 Jul 2020 at 18:50, Peter Maydell wrote: > > On Tue, 7 Jul 2020 at 13:04, Michael S. Tsirkin wrote: > > Precisely. Sorry about missing this. > > I made this change and pushed to the same tag - don't want to spam > > the list for a small thing like this. Can you pick this up pls? > >

Re: [PATCH v4 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-09 Thread Havard Skinnemoen
On Wed, Jul 8, 2020 at 10:34 PM Philippe Mathieu-Daudé wrote: > > On 7/9/20 2:06 AM, Havard Skinnemoen wrote: > > On Wed, Jul 8, 2020 at 11:13 AM Havard Skinnemoen > > wrote: > >> On Wed, Jul 8, 2020 at 10:31 AM Philippe Mathieu-Daudé > >> wrote: > >>> On 7/7/20 8:47 PM, Havard Skinnemoen

[PATCH 2/2] linux-user: add netlink RTM_SETLINK command

2020-07-09 Thread Laurent Vivier
This command is needed to be able to boot systemd in a container. $ sudo systemd-nspawn -D /chroot/armhf/sid/ -b Spawning container sid on /chroot/armhf/sid. Press ^] three times within 1s to kill container. systemd 245.6-2 running in system mode. Detected virtualization systemd-nspawn.

[PATCH 1/2] linux-user: add new netlink types

2020-07-09 Thread Laurent Vivier
Only implement IFLA_PERM_ADDRESS to fix the following error: Unknown host QEMU_IFLA type: 54 The couple of other ones, IFLA_PROP_LIST and IFLA_ALT_IFNAME, have been introduced to be used with RTM_NEWLINKPROP, RTM_DELLINKPROP and RTM_GETLINKPROP that are not implemented by QEMU. Signed-off-by:

Re: [PATCH v7 00/47] block: Deal with filters

2020-07-09 Thread Max Reitz
On 08.07.20 22:47, Eric Blake wrote: > On 7/8/20 12:20 PM, Andrey Shinkevich wrote: >> On 25.06.2020 18:21, Max Reitz wrote: >>> v6: >>> https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg01715.html >>> >>> Branch: https://github.com/XanClic/qemu.git child-access-functions-v7 >>> Branch:

Re: [PATCH v7 00/47] block: Deal with filters

2020-07-09 Thread Max Reitz
On 08.07.20 22:37, Eric Blake wrote: > On 7/8/20 2:46 PM, Andrey Shinkevich wrote: >> >> On 08.07.2020 20:32, Eric Blake wrote: >>> On 7/8/20 12:20 PM, Andrey Shinkevich wrote: On 25.06.2020 18:21, Max Reitz wrote: > v6: >

[PATCH] tests/qtest/fuzz: Add missing spaces in description

2020-07-09 Thread Thomas Huth
There should be a space between "forking" and "for". Signed-off-by: Thomas Huth --- tests/qtest/fuzz/virtio_scsi_fuzz.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/fuzz/virtio_scsi_fuzz.c b/tests/qtest/fuzz/virtio_scsi_fuzz.c index 51dce491ab..3a9ea13736

Re: [PATCH v7 02/47] block: Add chain helper functions

2020-07-09 Thread Andrey Shinkevich
On 09.07.2020 11:24, Max Reitz wrote: On 08.07.20 19:20, Andrey Shinkevich wrote: On 25.06.2020 18:21, Max Reitz wrote: Add some helper functions for skipping filters in a chain of block nodes. Signed-off-by: Max Reitz ---   include/block/block_int.h |  3 +++   block.c   |

Re: [PATCH v2 2/7] Implement drain_call_rcu and use it in hmp_device_del

2020-07-09 Thread Maxim Levitsky
On Wed, 2020-05-27 at 14:11 +0100, Stefan Hajnoczi wrote: > On Mon, May 11, 2020 at 07:09:46PM +0300, Maxim Levitsky wrote: > > /* The operands of the minus operator must have the same type, > > * which must be the one that we specify in the cast. > > diff --git a/qdev-monitor.c

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 4:46 AM, Cleber Rosa wrote: > This is a mapping of Peter's "remake-merge-builds" and > "pull-buildtest" scripts, gone through some updates, adding some build > option and removing others. > > The jobs currently cover the machines that the QEMU project owns, and that > are setup and

[PATCH v2 2/2] hw/riscv: sifive_u: Provide a reliable way for bootloader to detect whether it is running in QEMU

2020-07-09 Thread Bin Meng
From: Bin Meng The reset vector codes are subject to change, e.g.: with recent fw_dynamic type image support, it breaks oreboot again. Add a subregion in the MROM, with the size of machine RAM stored, so that we can provide a reliable way for bootloader to detect whether it is running in QEMU.

Re: [PATCH RFC 2/5] s390x: implement diag260

2020-07-09 Thread Christian Borntraeger
On 08.07.20 20:51, David Hildenbrand wrote: > Let's implement the "storage configuration" part of diag260. This diag > is found under z/VM, to indicate usable chunks of memory tot he guest OS. > As I don't have access to documentation, I have no clue what the actual > error cases are, and which

Re: [PATCH] Remove the CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE switch

2020-07-09 Thread Paolo Bonzini
On 09/07/20 07:34, Thomas Huth wrote: > GCC supports "#pragma GCC diagnostic" since version 4.6, and > Clang seems to support it, too, since its early versions 3.x. > That means that our minimum required compiler versions all support > this pragma already and we can remove the test from configure

Re: [PULL 00/53] Misc patches for QEMU 5.1 soft freeze

2020-07-09 Thread Paolo Bonzini
On 09/07/20 08:59, Claudio Fontana wrote: > anything else that we could use to find the real problem? I'm using $ gcc -v ... gcc version 8.3.1 20191121 (Red Hat 8.3.1-5) (GCC) $ ld -v GNU ld version 2.30-68.el8 > Of course I can try a blind fix, where I suggest to explicitly provide the >

Re: [PATCH 2/2] x86/cpu: Handle GUEST_MAXPHYADDR < HOST_MAXPHYADDR for hosts that don't support it

2020-07-09 Thread Mohammed Gamal
On Thu, 2020-07-09 at 11:44 +0200, Gerd Hoffmann wrote: > Hi, > > > > (CCing libvir-list, and people who were included in the OVMF > > > thread[1]) > > > > > > [1] > > > https://lore.kernel.org/qemu-devel/99779e9c-f05f-501b-b4be-ff719f140...@canonical.com/ > > > Also, it's important that we

Re: [PATCH] cpu: Add starts_halted() method

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 11:54 AM, Greg Kurz wrote: > On Thu, 9 Jul 2020 07:11:09 +0200 > Philippe Mathieu-Daudé wrote: >> On 7/8/20 11:39 PM, Eduardo Habkost wrote: >>> On Wed, Jul 08, 2020 at 06:45:57PM +0200, Philippe Mathieu-Daudé wrote: On 7/8/20 5:25 PM, Eduardo Habkost wrote: > On Wed, Jul 08,

Re: [PATCH] Remove the CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE switch

2020-07-09 Thread Stefan Hajnoczi
On Thu, Jul 09, 2020 at 07:34:56AM +0200, Thomas Huth wrote: > diff --git a/util/coroutine-ucontext.c b/util/coroutine-ucontext.c > index f0b66320e1..a4e6446ed9 100644 > --- a/util/coroutine-ucontext.c > +++ b/util/coroutine-ucontext.c > @@ -237,19 +237,15 @@ Coroutine *qemu_coroutine_new(void) >

[PATCH] migration: fix memory leak in qmp_migrate_set_parameters

2020-07-09 Thread Chuan Zheng
From: Zheng Chuan "tmp.tls_hostname" and "tmp.tls_creds" allocated by migrate_params_test_apply() is forgot to free at the end of qmp_migrate_set_parameters(). Fix that. The leak stack: Direct leak of 2 byte(s) in 2 object(s) allocated from: #0 0xb597c20b in __interceptor_malloc

[Bug 1886811] Re: systemd complains Failed to enqueue loopback interface start request: Operation not supported

2020-07-09 Thread Laurent Vivier
** Changed in: qemu Status: New => In Progress ** Changed in: qemu Assignee: (unassigned) => Laurent Vivier (laurent-vivier) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1886811 Title:

Re: [PATCH 2/2] util/qemu-sockets: make keep-alive enabled by default

2020-07-09 Thread Vladimir Sementsov-Ogievskiy
09.07.2020 11:29, Daniel P. Berrangé wrote: On Wed, Jul 08, 2020 at 10:15:39PM +0300, Vladimir Sementsov-Ogievskiy wrote: Keep-alive won't hurt, let's try to enable it even if not requested by user. Keep-alive intentionally breaks TCP connections earlier than normal in face of transient

Re: [PATCH v2 1/2] GitLab Gating CI: introduce pipeline-status contrib script

2020-07-09 Thread Erik Skultety
On Wed, Jul 08, 2020 at 10:46:56PM -0400, Cleber Rosa wrote: > This script is intended to be used right after a push to a branch. > > By default, it will look for the pipeline associated with the commit > that is the HEAD of the *local* staging branch. It can be used as a > one time check, or

Re: [PATCH v7 12/47] block: Use bdrv_filter_(bs|child) where obvious

2020-07-09 Thread Max Reitz
On 08.07.20 20:24, Andrey Shinkevich wrote: > On 25.06.2020 18:21, Max Reitz wrote: >> Places that use patterns like >> >> if (bs->drv->is_filter && bs->file) { >> ... something about bs->file->bs ... >> } >> >> should be >> >> BlockDriverState *filtered =

Re: [PATCH RFC 4/5] s390x: implement virtio-mem-ccw

2020-07-09 Thread David Hildenbrand
On 09.07.20 11:24, Cornelia Huck wrote: > On Wed, 8 Jul 2020 20:51:34 +0200 > David Hildenbrand wrote: > >> Add a proper CCW proxy device, similar to the PCI variant. >> >> Signed-off-by: David Hildenbrand >> --- >> hw/s390x/virtio-ccw-mem.c | 165 ++ >>

Re: [PATCH v2 3/7] device-core: use RCU for list of childs of a bus

2020-07-09 Thread Maxim Levitsky
On Wed, 2020-05-27 at 15:45 +0100, Stefan Hajnoczi wrote: > On Mon, May 11, 2020 at 07:09:47PM +0300, Maxim Levitsky wrote: > > diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h > > index d87d989e72..ef47cb2d9c 100644 > > --- a/include/hw/qdev-core.h > > +++ b/include/hw/qdev-core.h > >

[PATCH v2 1/2] hw/riscv: Modify MROM size to end at 0x10000

2020-07-09 Thread Bin Meng
From: Bin Meng At present the size of Mask ROM for sifive_u / spike / virt machines is set to 0x11000, which ends at an unusual address. This changes the size to 0xf000 so that it ends at 0x1. Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé --- (no changes since v1)

Re: [PATCH v2 6/7] scsi: Add scsi_device_get

2020-07-09 Thread Maxim Levitsky
On Wed, 2020-05-27 at 16:27 +0100, Stefan Hajnoczi wrote: > On Mon, May 11, 2020 at 07:09:50PM +0300, Maxim Levitsky wrote: > > +/* > > + * This function works like scsi_device_get but doesn't take a refernce > > s/refernce/reference/ > > > + * to the returned object. Intended for legacy code >

Re: Migrating custom qemu.org infrastructure to GitLab

2020-07-09 Thread Paolo Bonzini
On 09/07/20 12:22, Thomas Huth wrote: > FWIW, seems like we could use the "pandoc" tool to convert Mediawiki > (our old Wiki) to Markdown (Gitlab wiki). I've done a quick test and > converted https://wiki.qemu.org/Contribute/MailingLists into >

Re: [PATCH 0/2] keepalive default

2020-07-09 Thread Daniel P . Berrangé
On Wed, Jul 08, 2020 at 10:15:37PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > We understood, that keepalive is almost superfluous with default 2 hours > in /proc/tcp_keepalive_time. Forcing user to setup keepalive for the > whole system doesn't seem right, better setup it

Re: [PATCH v2 4/7] device-core: use atomic_set on .realized property

2020-07-09 Thread Maxim Levitsky
On Wed, 2020-05-27 at 16:00 +0100, Stefan Hajnoczi wrote: > On Mon, May 11, 2020 at 07:09:48PM +0300, Maxim Levitsky wrote: > > Some code might race with placement of new devices on a bus. > > We currently first place a (unrealized) device on the bus > > and then realize it. > > > > As a

Re: [PATCH] cpu: Add starts_halted() method

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 5:26 AM, Thiago Jung Bauermann wrote: > > Thiago Jung Bauermann writes: > >> I'm seeing the vcpu being KVM_RUN'd too early twice during hotplug. >> Both of them are before cpu_reset() and ppc_cpu_reset(). > > Hm, rereading the message obviously the above is partially wrong. The >

Re: [PATCH RFC 2/5] s390x: implement diag260

2020-07-09 Thread Cornelia Huck
On Wed, 8 Jul 2020 20:51:32 +0200 David Hildenbrand wrote: > Let's implement the "storage configuration" part of diag260. This diag > is found under z/VM, to indicate usable chunks of memory tot he guest OS. > As I don't have access to documentation, I have no clue what the actual > error cases

[PATCH] iotests: Simplify _filter_img_create() a bit

2020-07-09 Thread Max Reitz
Not only is it a bit stupid to try to filter multi-line "Formatting" output (because we only need it for a single test, which can easily be amended to no longer need it), it is also problematic when there can be output after a "Formatting" line that we do not want to filter as if it were part of

[PATCH] docs/devel/fuzzing: Fix bugs in documentation

2020-07-09 Thread Thomas Huth
Fix typo - the option is called "--fuzz-target" and not "--fuzz_taget". Also use a different fuzzer in the example, since "virtio-net-fork-fuzz" does not seem to be a valid fuzzer target (anymore?). Signed-off-by: Thomas Huth --- docs/devel/fuzzing.txt | 6 +++--- 1 file changed, 3

Re: [PATCH v7 12/47] block: Use bdrv_filter_(bs|child) where obvious

2020-07-09 Thread Andrey Shinkevich
On 09.07.2020 11:59, Max Reitz wrote: On 08.07.20 20:24, Andrey Shinkevich wrote: On 25.06.2020 18:21, Max Reitz wrote: Places that use patterns like if (bs->drv->is_filter && bs->file) { ... something about bs->file->bs ... } should be BlockDriverState *filtered

Re: [PATCH 2/2] x86/cpu: Handle GUEST_MAXPHYADDR < HOST_MAXPHYADDR for hosts that don't support it

2020-07-09 Thread Gerd Hoffmann
Hi, > > (CCing libvir-list, and people who were included in the OVMF > > thread[1]) > > > > [1] > > https://lore.kernel.org/qemu-devel/99779e9c-f05f-501b-b4be-ff719f140...@canonical.com/ > > Also, it's important that we work with libvirt and management > > software to ensure they have

Re: [PATCH 1/2] hw/riscv: Modify MROM size to end at 0x10000

2020-07-09 Thread Bin Meng
Hi Philippe, On Thu, Jul 9, 2020 at 1:15 PM Philippe Mathieu-Daudé wrote: > > On 7/9/20 3:09 AM, Bin Meng wrote: > > From: Bin Meng > > > > At present the size of Mask ROM for sifive_u / spike / virt machines > > is set to 0x11000, which ends at an unusual address. This changes the > > size to

Re: Migrating custom qemu.org infrastructure to GitLab

2020-07-09 Thread Thomas Huth
On 09/07/2020 12.16, Gerd Hoffmann wrote: > Hi, > >>> 2. wiki.qemu.org is a MediaWiki instance. Account creation is a hurdle >>> to one-time or new contributors. It is unclear whether GitLab's wiki >>> is expressive enough for a lossless conversion of the existing QEMU >>> wiki. Any volunteers

Re: [PATCH] Remove the CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE switch

2020-07-09 Thread Thomas Huth
On 09/07/2020 12.51, Stefan Hajnoczi wrote: > On Thu, Jul 09, 2020 at 07:34:56AM +0200, Thomas Huth wrote: >> diff --git a/util/coroutine-ucontext.c b/util/coroutine-ucontext.c >> index f0b66320e1..a4e6446ed9 100644 >> --- a/util/coroutine-ucontext.c >> +++ b/util/coroutine-ucontext.c >> @@

Re: [PATCH RFC 3/5] s390x: prepare device memory address space

2020-07-09 Thread Cornelia Huck
On Wed, 8 Jul 2020 20:51:33 +0200 David Hildenbrand wrote: > Let's allocate the device memory information and setup the device > memory address space. Expose the maximum ramsize via SCLP and the actual > initial ramsize via diag260. > > Signed-off-by: David Hildenbrand > --- >

Re: Failure prints during format or mounting a usb storage device

2020-07-09 Thread Gerd Hoffmann
> Starting at line 1746 is the first CBW, it's for an Inquiry command. > > Starting at line 1759 is the response, notice at line 1761 the MSD debug > says "Data in 64/36", which is strange. Not really. First is the packet size, second is the (remaining) data size. Inquiry data is 36 bytes, and

Re: [PATCH v7 02/47] block: Add chain helper functions

2020-07-09 Thread Max Reitz
On 08.07.20 19:20, Andrey Shinkevich wrote: > On 25.06.2020 18:21, Max Reitz wrote: >> Add some helper functions for skipping filters in a chain of block >> nodes. >> >> Signed-off-by: Max Reitz >> --- >>   include/block/block_int.h |  3 +++ >>   block.c   | 55

Re: [PATCH] Remove the CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE switch

2020-07-09 Thread Daniel P . Berrangé
On Thu, Jul 09, 2020 at 07:34:56AM +0200, Thomas Huth wrote: > GCC supports "#pragma GCC diagnostic" since version 4.6, and > Clang seems to support it, too, since its early versions 3.x. > That means that our minimum required compiler versions all support > this pragma already and we can remove

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

2020-07-09 Thread Erik Skultety
On Wed, Jul 08, 2020 at 10:46:57PM -0400, Cleber Rosa wrote: > This is a mapping of Peter's "remake-merge-builds" and > "pull-buildtest" scripts, gone through some updates, adding some build > option and removing others. > > The jobs currently cover the machines that the QEMU project owns, and

Re: [PATCH 2/2] util/qemu-sockets: make keep-alive enabled by default

2020-07-09 Thread Denis V. Lunev
On 7/9/20 11:29 AM, Daniel P. Berrangé wrote: > On Wed, Jul 08, 2020 at 10:15:39PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Keep-alive won't hurt, let's try to enable it even if not requested by >> user. > Keep-alive intentionally breaks TCP connections earlier than normal > in face of

Re: [PATCH v10 02/34] qcow2: Convert qcow2_get_cluster_offset() into qcow2_get_host_offset()

2020-07-09 Thread Max Reitz
On 03.07.20 17:57, Alberto Garcia wrote: > qcow2_get_cluster_offset() takes an (unaligned) guest offset and > returns the (aligned) offset of the corresponding cluster in the qcow2 > image. > > In practice none of the callers need to know where the cluster starts > so this patch makes the

Re: [PATCH v2 1/2] GitLab Gating CI: introduce pipeline-status contrib script

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 10:55 AM, Erik Skultety wrote: > On Wed, Jul 08, 2020 at 10:46:56PM -0400, Cleber Rosa wrote: >> This script is intended to be used right after a push to a branch. >> >> By default, it will look for the pipeline associated with the commit >> that is the HEAD of the *local* staging

Re: [PULL 0/3] M68k next patches

2020-07-09 Thread Peter Maydell
On Mon, 6 Jul 2020 at 21:06, Laurent Vivier wrote: > > The following changes since commit 64f0ad8ad8e13257e7c912df470d46784b55c3fd: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2020-07-02' > into staging (2020-07-02 15:54:09 +0100) > > are available in the Git repository

Re: [PATCH v2 7/7] virtio-scsi: use scsi_device_get

2020-07-09 Thread Maxim Levitsky
On Wed, 2020-05-27 at 16:50 +0100, Stefan Hajnoczi wrote: > On Mon, May 11, 2020 at 07:09:51PM +0300, Maxim Levitsky wrote: > > This will help us to avoid the scsi device disappearing > > after we took a reference to it. > > > > It doesn't by itself forbid case when we try to access > > an

Re: [PATCH] tests: improve performance of device-introspect-test

2020-07-09 Thread Laurent Vivier
On 09/07/2020 13:28, Daniel P. Berrangé wrote: > Total execution time with "-m slow" and x86_64 QEMU, drops from 3 > minutes 15 seconds, down to 54 seconds. > > Individual tests drop from 17-20 seconds, down to 3-4 seconds. > > The cost of this change is that any QOM bugs resulting in the test >

Re: [PATCH v2 2/7] Implement drain_call_rcu and use it in hmp_device_del

2020-07-09 Thread Maxim Levitsky
On Thu, 2020-07-09 at 13:42 +0200, Markus Armbruster wrote: > Maxim Levitsky writes: > > > This allows to preserve the semantics of hmp_device_del, > > that the device is deleted immediatly which was changed by previos > > patch that delayed this to RCU callback > > > > Suggested-by: Stefan

Re: Migrating custom qemu.org infrastructure to GitLab

2020-07-09 Thread Thomas Huth
On 09/07/2020 12.33, Paolo Bonzini wrote: > On 09/07/20 12:22, Thomas Huth wrote: >> FWIW, seems like we could use the "pandoc" tool to convert Mediawiki >> (our old Wiki) to Markdown (Gitlab wiki). I've done a quick test and >> converted https://wiki.qemu.org/Contribute/MailingLists into >>

Re: [PULL 00/41] testing updates (vm, gitlab, misc build fixes)

2020-07-09 Thread Peter Maydell
On Thu, 9 Jul 2020 at 13:24, Philippe Mathieu-Daudé wrote: > libssh is bugged on Ubuntu 18.04. > https://bugs.launchpad.net/qemu/+bug/1838763 > > We need to use 'configure --disable-libssh' there. Ah, thanks. I guess libssh recently got installed on that box. -- PMM

[PATCH 1/6] block/aio_task: allow start/wait task from any coroutine

2020-07-09 Thread Denis V. Lunev
From: Vladimir Sementsov-Ogievskiy Currently, aio task pool assumes that there is a main coroutine, which creates tasks and wait for them. Let's remove the restriction by using CoQueue. Code becomes clearer, interface more obvious. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by:

[PATCH v8 0/6] block: seriously improve savevm/loadvm performance

2020-07-09 Thread Denis V. Lunev
This series do standard basic things: - it creates intermediate buffer for all writes from QEMU migration code to QCOW2 image, - this buffer is sent to disk asynchronously, allowing several writes to run in parallel. In general, migration code is fantastically inefficent (by observation),

[Bug 1886811] Re: systemd complains Failed to enqueue loopback interface start request: Operation not supported

2020-07-09 Thread Bug Watch Updater
** Changed in: qemu (Debian) Status: Unknown => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1886811 Title: systemd complains Failed to enqueue loopback interface start request:

Re: [PATCH] tests/qtest/fuzz: Add missing spaces in description

2020-07-09 Thread Alexander Bulekov
On 200709 1228, Philippe Mathieu-Daudé wrote: > On 7/9/20 10:37 AM, Thomas Huth wrote: > > There should be a space between "forking" and "for". > > > > Signed-off-by: Thomas Huth > > --- > > tests/qtest/fuzz/virtio_scsi_fuzz.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > >

[PATCH v1 04/13] cputlb: ensure we save the IOTLB data in case of reset

2020-07-09 Thread Alex Bennée
Any write to a device might cause a re-arrangement of memory triggering a TLB flush and potential re-size of the TLB invalidating previous entries. This would cause users of qemu_plugin_get_hwaddr() to see the warning: invalid use of qemu_plugin_get_hwaddr because of the failed tlb_lookup

[PATCH v1 06/13] plugins: add API to return a name for a IO device

2020-07-09 Thread Alex Bennée
This may well end up being anonymous but it should always be unique. Signed-off-by: Alex Bennée [r-b provisional given change to g_intern_string] Reviewed-by: Clement Deschamps Reviewed-by: Emilio G. Cota --- v3 - return a non-freeable const g_intern_string() - checkpatch cleanups ---

[PATCH v1 08/13] plugins: expand the bb plugin to be thread safe and track per-cpu

2020-07-09 Thread Alex Bennée
While there isn't any easy way to make the inline counts thread safe we can ensure the callback based ones are. While we are at it we can reduce introduce a new option ("idle") to dump a report of the current bb and insn count each time a vCPU enters the idle state. Signed-off-by: Alex Bennée

Updates on libcapstone?

2020-07-09 Thread Philippe Mathieu-Daudé
Hi Richard, We are using libcapstone since almost 3 years for the arm/i386/ppc 'base' architectures. The library is still optional in ./configure. I wonder if we can make it a strong requisite, this way we could get rid of disas/{arm.c,arm-a64.cc,i386.c,ppc.c} and the disas/libvixl submodule,

Re: [PATCH v10 31/34] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit

2020-07-09 Thread Max Reitz
On 03.07.20 17:58, Alberto Garcia wrote: > Now that the implementation of subclusters is complete we can finally > add the necessary options to create and read images with this feature, > which we call "extended L2 entries". > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Blake >

Re: [PATCH v10 34/34] iotests: Add tests for qcow2 images with extended L2 entries

2020-07-09 Thread Max Reitz
On 03.07.20 17:58, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia > --- > tests/qemu-iotests/271 | 901 + > tests/qemu-iotests/271.out | 724 + > tests/qemu-iotests/group | 1 + > 3 files changed, 1626 insertions(+) >

Re: [PATCH] Fix MIPS add.s after 1ace099f2acb952eaaef0ba7725879949a7e4406

2020-07-09 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 7/7/20 6:26 PM, Aleksandar Markovic wrote: > On Fri, Jul 3, 2020 at 6:33 PM Alex Richardson > wrote: >> >> After merging latest QEMU upstream into our CHERI fork, I noticed that >> some of the FPU tests in our MIPS baremetal testsuite >>

Re: [PATCH-for-5.1 2/2] fuzz: add missing header for rcu_enable_atfork

2020-07-09 Thread Alexander Bulekov
On 200709 0718, Thomas Huth wrote: > On 08/07/2020 22.01, Alexander Bulekov wrote: > > In 45222b9a90, I fixed a broken check for rcu_enable_atfork introduced > > in d6919e4cb6. I added a call to rcu_enable_atfork after the > > call to qemu_init in fuzz.c, but forgot to include the corresponding >

Re: [PATCH-for-5.1 2/2] fuzz: add missing header for rcu_enable_atfork

2020-07-09 Thread Thomas Huth
On 09/07/2020 15.38, Alexander Bulekov wrote: > On 200709 0718, Thomas Huth wrote: >> On 08/07/2020 22.01, Alexander Bulekov wrote: >>> In 45222b9a90, I fixed a broken check for rcu_enable_atfork introduced >>> in d6919e4cb6. I added a call to rcu_enable_atfork after the >>> call to qemu_init in

Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/7/20 10:29 PM, Niek Linnenbank wrote: > Hi Philippe, > > Just tried out your patch on latest master, and I noticed I couldn't > apply it without getting this error: > > $ git am ~/Downloads/patches/\[PATCH\ 2_2\]\ hw_sd_sdcard\:\ Do\ not\ > allow\ invalid\ SD\ card\ sizes\ -\ Philippe\

[PATCH v1 02/13] docs/devel: add some notes on tcg-icount for developers

2020-07-09 Thread Alex Bennée
This attempts to bring together my understanding of the requirements for icount behaviour into one reference document for our developer notes. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Cc: Paolo Bonzini Cc: Pavel Dovgalyuk Cc: Peter Maydell Message-Id:

[PATCH v1 00/13] misc rc0 fixes (docs, plugins, docker)

2020-07-09 Thread Alex Bennée
Hi, These are some candidate patches for rc0 along with a few plugin patches that haven't yet gotten review. The new functionality won't get added to the PR but I'd like to get the cputlb fix in. Alongside the plugin stuff there are some documentation updates which are worth adding and some

[PATCH v1 01/13] docs/devel: convert and update MTTCG design document

2020-07-09 Thread Alex Bennée
Do a light conversion to .rst and clean-up some of the language at the start now MTTCG has been merged for a while. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- docs/devel/index.rst | 1 + ...ti-thread-tcg.txt => multi-thread-tcg.rst} | 52

[PATCH v1 03/13] docs: Add to gdbstub documentation the PhyMemMode

2020-07-09 Thread Alex Bennée
From: Jon Doron The PhyMemMode gdb extension command was missing from the gdb.rst document. Signed-off-by: Jon Doron Signed-off-by: Alex Bennée Message-Id: <20200601171609.1665397-1-ari...@gmail.com> --- docs/system/gdb.rst | 20 1 file changed, 20 insertions(+) diff

Re: [qemu-web PATCH] new page: conservancy.md

2020-07-09 Thread Thomas Huth
On 07/07/2020 17.19, Paolo Bonzini wrote: > On 07/07/20 16:51, Alex Bennée wrote: >> +QEMU interacts with Conservancy through a Leadership Committee, >> +currently composed of the following members: >> + >> +* Alex Bennée >> +* Paolo Bonzini >> +* Andreas Färber >> +* Alexander Graf >> +* Stefan

Re: [PULL 00/41] testing updates (vm, gitlab, misc build fixes)

2020-07-09 Thread Peter Maydell
On Tue, 7 Jul 2020 at 08:09, Alex Bennée wrote: > > There will be some docker failures until the official repository has > seeded but local builds should continue to work. > > > > The following changes since commit eb6490f544388dd24c0d054a96dd304bc7284450: > > Merge remote-tracking branch

Re: [PATCH 2/2] util/qemu-sockets: make keep-alive enabled by default

2020-07-09 Thread Daniel P . Berrangé
On Thu, Jul 09, 2020 at 11:49:17AM +0300, Vladimir Sementsov-Ogievskiy wrote: > 09.07.2020 11:29, Daniel P. Berrangé wrote: > > On Wed, Jul 08, 2020 at 10:15:39PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > Keep-alive won't hurt, let's try to enable it even if not requested by > > >

Re: Questions about online resizing a lun passthrough disk with virtio-scsi

2020-07-09 Thread Lin Ma
On 2020-07-08 15:11, Paolo Bonzini wrote: On 08/07/20 16:44, lma wrote: Is the 'block_resize' mandatory to notify guest os after online resizing a lun passed through disk? I'm curious it because I found there're couple of ways can make guest os realize the disk capacity change. e.g: * run

Re: [PATCH] ossaudio: fix out of bounds write

2020-07-09 Thread Gerd Hoffmann
> > diff --git a/audio/ossaudio.c b/audio/ossaudio.c > > index f88d076ec2..a7dcaa31ad 100644 > > --- a/audio/ossaudio.c > > +++ b/audio/ossaudio.c > > @@ -691,6 +691,7 @@ static size_t oss_read(HWVoiceIn *hw, void *buf, size_t > > len) > > len, dst); > >

Re: Delete some Wiki pages (was: Migrating custom qemu.org infrastructure to GitLab)

2020-07-09 Thread Paolo Bonzini
On 09/07/20 15:10, Thomas Huth wrote: > - https://wiki.qemu.org/Features/40p : > - https://wiki.qemu.org/Features/PRePCleanup : > - https://wiki.qemu.org/Features/BeBox > - https://wiki.qemu.org/Features/DriveRefactoring > - https://wiki.qemu.org/Features/LegacyRemoval > -

[PATCH] softmmu/vl: Include "qemu/rcu.h" for rcu_disable_atfork()

2020-07-09 Thread Philippe Mathieu-Daudé
In commit 73c6e4013b we let vl.c use rcu_disable_atfork() which is declared in "qemu/rcu.h", but forgot to include this header. Fortunately has never been a problem since vl.c includes "exec/memory.h" which includes "qemu/rcu.h". Include the missing header now in case we split vl.c later. Fixes:

[PATCH v1 05/13] hw/virtio/pci: include vdev name in registered PCI sections

2020-07-09 Thread Alex Bennée
When viewing/debugging memory regions it is sometimes hard to figure out which PCI device something belongs to. Make the names unique by including the vdev name in the name string. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin --- v2 - swap

QEMU | Pipeline #164743957 has failed for master | 48f22ad0

2020-07-09 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 48f22ad0 ( https://gitlab.com/qemu-project/qemu/-/commit/48f22ad04ead83e61b4b35871ec6f6109779b791 ) Commit Message: Merge

Re: Questions about online resizing a lun passthrough disk with virtio-scsi

2020-07-09 Thread Lin Ma
On 2020-07-09 12:00, Paolo Bonzini wrote: On 09/07/20 13:52, Lin Ma wrote: It's not recommended however, because block_resize will report the change to the guest directly with a CAPACITY HAS CHANGED unit attention condition. Got it, The 'block_resize' is the recommended or necessary step,

Re: [PATCH v10 21/34] qcow2: Add subcluster support to qcow2_get_host_offset()

2020-07-09 Thread Max Reitz
On 03.07.20 17:58, Alberto Garcia wrote: > The logic of this function remains pretty much the same, except that > it uses count_contiguous_subclusters(), which combines the logic of > count_contiguous_clusters() / count_contiguous_clusters_unallocated() > and checks individual subclusters. > >

Re: [PULL 00/41] testing updates (vm, gitlab, misc build fixes)

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 1:31 PM, Peter Maydell wrote: > On Tue, 7 Jul 2020 at 08:09, Alex Bennée wrote: >> >> There will be some docker failures until the official repository has >> seeded but local builds should continue to work. >> >> >> >> The following changes since commit

Re: [PATCH v5 08/20] microvm/acpi: add minimal acpi support

2020-07-09 Thread Gerd Hoffmann
Hi, > > +scope = aml_scope("\\"); > > +pkg = aml_package(4); > > +aml_append(pkg, aml_int(5)); /* SLEEP_CONTROL_REG.SLP_TYP */ > > I'm not sure what does the comment refer to here. It's the register field the value gets written to. With full acpi this is PM1a_CNT.SLP_TYP,

Re: [PATCH] cpu: Add starts_halted() method

2020-07-09 Thread Greg Kurz
On Thu, 9 Jul 2020 14:21:04 +0200 Philippe Mathieu-Daudé wrote: > On 7/9/20 12:55 PM, Greg Kurz wrote: > > On Thu, 9 Jul 2020 12:18:06 +0200 > > Philippe Mathieu-Daudé wrote: > > [...] > >>> > >>> FYI, PAPR requires all vCPUs to be "stopped" by default. It is up to the > >>> guest to start

  1   2   3   4   >