Fix the contition to figure whenever we need to wait for more data or
not. Simply check the mode, if we are not in DATAIN state any more we
are done already and don't need to go ASYNC.
Fixes: 7ad3d51ebb8a ("usb: add short-packet handling to usb-storage driver")
Reported-by: Sai Pavan Boddu
On 11.07.2020 22:11, Vladimir Sementsov-Ogievskiy wrote:
03.07.2020 16:13, Andrey Shinkevich wrote:
Read and dump entries from the bitmap directory of QCOW2 image.
It extends the output in the test case #291.
...
diff --git a/tests/qemu-iotests/qcow2_format.py
On 09/07/2020 12.13, Philippe Mathieu-Daudé wrote:
> On 7/9/20 10:55 AM, Erik Skultety wrote:
>> On Wed, Jul 08, 2020 at 10:46:56PM -0400, Cleber Rosa wrote:
>>> This script is intended to be used right after a push to a branch.
>>>
>>> By default, it will look for the pipeline associated with the
12.07.2020 15:00, Simon John wrote:
> macos guests no longer boot after commit
> 5d971f9e672507210e77d020d89e0e89165c8fc9
>
> acpi-tmr needs 2 byte memory accesses, so breaks as that commit only allows 4
> bytes.
>
> Fixes: 5d971f9e672507210e7 (memory: Revert "memory: accept mismatching sizes
From: Philippe Mathieu-Daudé
This test never required "chardev/char-mux.h", remove it.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20200423202112.644-3-phi...@redhat.com>
Reviewed-by: Richard Henderson
Signed-off-by: Marc-André Lureau
---
tests/test-char.c | 1 -
1 file changed, 1
From: Philippe Mathieu-Daudé
The msmouse / wctablet / testdev character devices are only
used by system emulation. Remove them from user mode and tools.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20200423202112.644-4-phi...@redhat.com>
Reviewed-by: Richard Henderson
Signed-off-by:
From: Philippe Mathieu-Daudé
monitor/misc.c never required "chardev/char-mux.h", remove it.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20200423202112.644-2-phi...@redhat.com>
Reviewed-by: Richard Henderson
Signed-off-by: Marc-André Lureau
---
monitor/misc.c | 1 -
1 file changed, 1
On 7/10/20 4:04 PM, Philippe Mathieu-Daudé wrote:
> On 7/8/20 11:52 AM, Stefan Hajnoczi wrote:
>>
>> There is a snowball effect where the experience is improved the more
>> GitLab features we use, so I hope that most of these migrations will
>> be possible.
>
> I've been looking at other features
On Thu, 25 Jun 2020 07:50:11 +0300
Jon Doron wrote:
> Signed-off-by: Jon Doron
Reviewed-by: Igor Mammedov
> ---
> hw/i386/acpi-build.c | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index
On Fri, Jul 10, 2020 at 10:03:56PM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > Total execution time with "-m slow" and x86_64 QEMU, drops from 3
> > minutes 15 seconds, down to 54 seconds.
> >
> > Individual tests drop from 17-20 seconds, down to 3-4 seconds.
>
> Nice!
>
On Mon, 29 Jun 2020 16:09:37 +0200
Andrew Jones wrote:
> The flash device is exclusively for the host-controlled firmware, so
> we should not expose it to the OS. Exposing it risks the OS messing
> with it, which could break firmware runtime services and surprise the
> OS when all its changes
On Mon, 13 Jul 2020 at 09:39, Philippe Mathieu-Daudé wrote:
>
> On 7/10/20 4:04 PM, Philippe Mathieu-Daudé wrote:
>
> > 7/ License Compliance
> >
> > https://docs.gitlab.com/ee/user/compliance/license_compliance/
>
> WRT IRC feedback QEMU licensing is a lost cause, I can not tell,
> but I think
On 7/13/20 11:04 AM, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove the superfluous break, as there is a "return" before it.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
Hmm I never reviewed this patch, only the openrisc one:
On 10.07.20 18:12, Max Reitz wrote:
> On 07.07.20 18:17, Kevin Wolf wrote:
>> Am 07.07.2020 um 16:23 hat Kevin Wolf geschrieben:
>>> Espeically when O_DIRECT is used with image files so that the page cache
>>> indirection can't cause a merge of allocating requests, the file will
>>> fragment on
Hello,
Ping...
Anyone have comments about this path?
To reduce the downtime during checkpoints, the patch tries to migrate
memory page as many as possible just before entering COLO state.
Thanks.
Regards,
Derek
On 2020/6/21 上午10:10, Derek Su wrote:
To reduce the guest's downtime during
25.06.2020 18:21, Max Reitz wrote:
There are BDS children that the general block layer code can access,
namely bs->file and bs->backing. Since the introduction of filters and
external data files, their meaning is not quite clear. bs->backing can
be a COW source, or it can be a filtered child;
Eduardo Habkost writes:
> On Fri, Jul 10, 2020 at 11:05:29AM +0200, Philippe Mathieu-Daudé wrote:
>> +Stefan for tracing PoV
>>
>> On 7/9/20 9:48 PM, Eduardo Habkost wrote:
>> > On Fri, Jun 26, 2020 at 04:26:33PM +0200, Philippe Mathieu-Daudé
>> > wrote:
>> >> On 6/26/20 1:00 PM,
On Mon, 13 Jul 2020 09:51:12 +0200
Thomas Huth wrote:
> There is some additional information about the 3270 support in our Wiki
> at https://wiki.qemu.org/Features/3270 - so let's include this information
> into the main documentation now to have one single source of information
> (the Wiki page
On 13/07/2020 11.05, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/block/pflash_cfi01.c | 1 -
> hw/display/cirrus_vga.c
On Thu, 9 Jul 2020 00:46:12 +0200
Julia Suvorova wrote:
> Add trace events similar to piix4_gpe_readb() to check gpe status.
>
> Signed-off-by: Julia Suvorova
Reviewed-by: Igor Mammedov
> ---
> hw/acpi/ich9.c | 7 ++-
> hw/acpi/trace-events | 4
> 2 files changed, 10
On 13/07/2020 11.05, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/cris/translate.c | 7 +++
>
Variable "cpu_env" is used in file "syscall.c" to store
the information about the cpu environment. This variable
is used because values of some syscalls can vary between
cpu architectures. This patch makes the "cpu_env" accessible
in "strace.c" so it can enable aproppriate "-strace" argument
This patch implements strace argument printing functionality for following
syscalls:
* truncate, ftruncate - truncate a file to a specified length
int truncate/truncate64(const char *path, off_t length)
int ftruncate/ftruncate64(int fd, off_t length)
man page:
On 10/07/2020 21.30, Richard Henderson wrote:
> On 7/9/20 6:07 AM, Philippe Mathieu-Daudé wrote:
>> I remember you had a series related to capstone, but eventually there
>> was a problem so you postponed it until some patches were merged
>> upstream, do you remember?
>
> I do.
>
> My biggest
On 13.07.2020 11:43, Vladimir Sementsov-Ogievskiy wrote:
12.07.2020 19:07, Andrey Shinkevich wrote:
On 11.07.2020 16:05, Vladimir Sementsov-Ogievskiy wrote:
26.06.2020 17:31, Andrey Shinkevich wrote:
The script 'bench_write_req.py' allows comparing performances of write
request for two
> Am 13.07.2020 um 11:12 schrieb Heiko Carstens :
>
> On Fri, Jul 10, 2020 at 05:24:07PM +0200, David Hildenbrand wrote:
>>> On 10.07.20 17:18, Heiko Carstens wrote:
>>> On Fri, Jul 10, 2020 at 02:12:33PM +0200, David Hildenbrand wrote:
> Note: Reading about diag260 subcode 0xc, we could
On Jul 12, 2020, at 10:02 PM, qemu-devel-requ...@nongnu.org wrote:
Message: 6
Date: Mon, 13 Jul 2020 00:17:30 -
From: JuanPabloCuervo <1887...@bugs.launchpad.net>
To: qemu-devel@nongnu.org
Subject: [Bug 1887318] [NEW] impossible to install in OSX Yosemite
10.10.5
Message-ID:
On 7/11/2020 12:48 AM, Eduardo Habkost wrote:
On Fri, Jul 10, 2020 at 09:45:49AM +0800, Chenyi Qiang wrote:
On 7/10/2020 6:12 AM, Eduardo Habkost wrote:
I'm very sorry for taking so long to review this. Question
below:
On Fri, Jun 19, 2020 at 03:31:11PM +0800, Chenyi Qiang wrote:
Add
On 11.07.20 10:57, Alex Bennée wrote:
>
> Max Reitz writes:
>
>> Otherwise the result is basically unpredictable.
>>
>> (Note that the precise environment variable to control sorting order is
>> LC_COLLATE, but LC_ALL overrides LC_COLLATE, and we do not want the
>> sorting order to be messed up
On Thu, 25 Jun 2020 07:50:09 +0300
Jon Doron wrote:
> After doing further tests and looking at the latest HyperV ACPI DSDT.
> Do minor fix to our VMBus ACPI entry.
Jon,
vmbus feature needs a testcase, could you look into it please?
(see tests/qtest/bios-tables-test.c for an example.
also look
12.07.2020 19:07, Andrey Shinkevich wrote:
On 11.07.2020 16:05, Vladimir Sementsov-Ogievskiy wrote:
26.06.2020 17:31, Andrey Shinkevich wrote:
The script 'bench_write_req.py' allows comparing performances of write
request for two qemu-img binary files.
An example with (qemu-img binary 1) and
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
tcg/riscv/tcg-target.inc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tcg/riscv/tcg-target.inc.c
From: Liao Pingfang
Remove the superfluous break, as there is a "return" before it.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
fsdev/virtfs-proxy-helper.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fsdev/virtfs-proxy-helper.c
Hi Alexey,
On 7/13/20 10:55 AM, Alexey Kirillov wrote:
> In some shells, we can't use == sign (as example, in dash).
>
> Signed-off-by: Alexey Kirillov
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
scsi/utils.c | 4
1 file changed, 4 deletions(-)
diff --git a/scsi/utils.c b/scsi/utils.c
index
From: Liao Pingfang
Remove superfluous break.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
target/arm/kvm64.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c
index 1169237..ef1e960 100644
---
On Fri, Jul 10, 2020 at 08:55:20AM +0200, Thomas Huth wrote:
> Most of the -usbdevice paramaters have been removed already. Update
> the doc accordingly.
Queued up for 5.1
thanks,
Gerd
On 13/07/2020 11.05, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/sh4/translate.c | 3 ---
> 1 file changed, 3
On Apr 29 2020, Laurent Vivier wrote:
> "Since the extended-precision data format has an explicit integer bit, a
> number can be formatted with a nonzero exponent, less than the maximum
> value, and a zero integer bit. The IEEE 754 standard does not define a
> zero integer bit. Such a number is
On 7/13/20 11:05 AM, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
I hadn't reviewed this patch, but now I did.
> ---
>
* Claudio Fontana (cfont...@suse.de) wrote:
> Hello all,
>
> during unrelated work for splitting QTest from the TCG instruction counting
> module,
>
> I encountered what seems to be a migration stream issue, which is apparent
> only on s390, and only shows in block test 267.
>
> ./check
On Wed, Jul 08, 2020 at 06:51:18PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 07.07.2020 18:56, Stefan Hajnoczi wrote:
> > On Sat, Jun 20, 2020 at 05:36:45PM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > Introduce a function to mark the request serialising only if there are
> > > no
On Wed, Jul 08, 2020 at 06:56:53PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 07.07.2020 19:10, Stefan Hajnoczi wrote:
> > On Sat, Jun 20, 2020 at 05:36:46PM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > +int coroutine_fn bdrv_co_pwrite_zeroes_locked(BdrvChild *child, int64_t
> > >
Hello,
On 7/13/20 1:03 PM, Dr. David Alan Gilbert wrote:
> * Claudio Fontana (cfont...@suse.de) wrote:
>> Hello all,
>>
>> during unrelated work for splitting QTest from the TCG instruction counting
>> module,
>>
>> I encountered what seems to be a migration stream issue, which is apparent
>>
On Mon, 13 Jul 2020 12:03:33 +0100
"Dr. David Alan Gilbert" wrote:
> * Claudio Fontana (cfont...@suse.de) wrote:
> > The following workarounds hide the problem (make the test pass):
> >
> > 1) always including the icount field in the (unrelated) timers field that
> > are sent before in the
On Thu, Jul 09, 2020 at 07:48:55PM -0400, Alexander Bulekov wrote:
> On 200623 1514, Stefan Hajnoczi wrote:
> > On Thu, Jun 11, 2020 at 01:56:51AM -0400, Alexander Bulekov wrote:
> > > Signed-off-by: Alexander Bulekov
> > > ---
> > > exec.c| 17 -
>
Max spotted that I didn't test -qed...
Signed-off-by: Eric Blake
---
tests/qemu-iotests/024 | 2 +-
tests/qemu-iotests/024.out | 1 -
tests/qemu-iotests/043 | 5 +++--
tests/qemu-iotests/043.out | 4
4 files changed, 4 insertions(+), 8 deletions(-)
diff --git
On 7/13/2020 3:23 PM, Chenyi Qiang wrote:
On 7/11/2020 12:48 AM, Eduardo Habkost wrote:
On Fri, Jul 10, 2020 at 09:45:49AM +0800, Chenyi Qiang wrote:
On 7/10/2020 6:12 AM, Eduardo Habkost wrote:
I'm very sorry for taking so long to review this. Question
below:
On Fri, Jun 19, 2020 at
On 7/10/20 11:57 PM, John Snow wrote:
> I'm proposing that I split the actual Python library off from the other
> miscellaneous python scripts we have and declare it maintained. Add
> myself as a maintainer of this folder, along with Cleber.
>
> Signed-off-by: John Snow
> ---
> MAINTAINERS | 9
On 7/10/20 8:22 PM, Alex Bennée wrote:
> Like the sed we include earlier we want something more recent for
> iotests to work.
>
> Fixes: 57ee95ed
> Cc: Max Reitz
> Signed-off-by: Alex Bennée
> ---
> .cirrus.yml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
Switch from stable-4.2 branch back to master (which is actually
maintained, I think we tend to forget about stable...).
git shortlog 2faae0f7..a62d3673:
5eraph (2):
disable_dns option
limit vnameserver_addr to port 53
Akihiro Suda (1):
libslirp.h: fix SlirpConfig v3
13.07.2020 07:49, Andrey Shinkevich wrote:
On 11.07.2020 19:34, Vladimir Sementsov-Ogievskiy wrote:
03.07.2020 16:13, Andrey Shinkevich wrote:
There are two ways to initialize a class derived from Qcow2Struct:
1. Pass a block of binary data to the constructor.
2. Pass the file descriptor to
On 13/07/2020 11.03, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/ppc/misc_helper.c | 5 -
> 1 file changed, 5
On 13/07/2020 11.04, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> migration/migration.c | 2 --
> 1 file changed, 2 deletions(-)
On 13/07/2020 11.04, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> scsi/utils.c | 4
> 1 file changed, 4 deletions(-)
>
>
This patch implements strace argument printing functionality for following
syscalls:
* mlock, munlock, mlockall, munlockall - lock and unlock memory
int mlock(const void *addr, size_t len)
int munlock(const void *addr, size_t len)
int mlockall(int flags)
int
This patch implements strace argument printing functionality for following
syscalls:
* clock_getres, clock_gettime, clock_settime - clock and time functions
int clock_getres(clockid_t clockid, struct timespec *res)
int clock_gettime(clockid_t clockid, struct timespec *tp)
Le ven. 10 juil. 2020 à 22:35, Alistair Francis a écrit :
>
> On Mon, Jul 6, 2020 at 2:45 AM Alexandre Mergnat
> wrote:
> >
> > The end address calculation for NA4 mode is wrong because the address
> > used isn't shifted.
> >
> > That imply all NA4 setup are not applied by the PMP.
>
> I'm not
On Wed, Jul 08, 2020 at 06:50:12PM +0200, Cornelia Huck wrote:
> On Wed, 8 Jul 2020 14:05:26 +0100
> Stefan Hajnoczi wrote:
>
> > On Tue, Jul 07, 2020 at 05:44:53PM +0200, Cornelia Huck wrote:
> > > On Mon, 6 Jul 2020 14:56:48 +0100
> > > Stefan Hajnoczi wrote:
>
> > > > diff --git
On 7/13/20 12:05 PM, Peter Maydell wrote:
> On Mon, 13 Jul 2020 at 09:57, Philippe Mathieu-Daudé wrote:
>> Why not make it a generic container in the MachineState and create
>> the container in hw/core/machine.c::machine_initfn()?
>
> I don't think we create containers like that for any other
>
On 13.07.2020 11:43, Vladimir Sementsov-Ogievskiy wrote:
12.07.2020 19:07, Andrey Shinkevich wrote:
On 11.07.2020 16:05, Vladimir Sementsov-Ogievskiy wrote:
26.06.2020 17:31, Andrey Shinkevich wrote:
The script 'bench_write_req.py' allows comparing performances of write
request for two
From: Alexander Bulekov
When configuring with --enable-fuzzing, we overwrote the CFLAGS
added by all the preceding checks. Instead of overwriting CFLAGS, append
the ones we need.
Fixes: adc28027ff ("fuzz: add configure flag --enable-fuzzing")
Reported-by: Li Qiang
Signed-off-by: Alexander
Hi Peter,
the following changes since commit 9f526fce49c6ac48114ed04914b5a76e4db75785:
Merge remote-tracking branch
'remotes/stsquad/tags/pull-testing-and-misc-110720-2' into staging (2020-07-12
15:32:05 +0100)
are available in the Git repository at:
https://gitlab.com/huth/qemu.git
On 6/29/20 2:14 PM, Peter Maydell wrote:
> On Mon, 29 Jun 2020 at 10:39, Philippe Mathieu-Daudé wrote:
>>
>> Hi Peter,
>>
>> On 6/28/20 10:37 PM, Peter Maydell wrote:
>>> Currently we have a free-floating set of IRQs and a function
>>> tosa_out_switch() which handle the GPIO lines on the tosa
On Thu, Jul 09, 2020 at 10:16:31AM -0400, Jag Raman wrote:
> > On Jul 2, 2020, at 9:40 AM, Stefan Hajnoczi wrote:
> > On Sat, Jun 27, 2020 at 10:09:22AM -0700, elena.ufimts...@oracle.com wrote:
> > makes sense to me and I see how it forms the base on which
> > VFIO-over-socket and smaller remote
Max noticed that I didn't run iotests on -luks...
Signed-off-by: Eric Blake
---
tests/qemu-iotests/282.out | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/qemu-iotests/282.out b/tests/qemu-iotests/282.out
index 5d079dabce1d..67db7ab15aff 100644
---
On Mon, Jul 13, 2020 at 07:36:20AM +0200, Thomas Huth wrote:
> On 10/07/2020 22.36, Gerd Hoffmann wrote:
> > Signed-off-by: Gerd Hoffmann
> > ---
> > tests/qtest/Makefile.include | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/qtest/Makefile.include
Let us differ binary data type from string one for the extension data
variable and keep the string as the QcowHeaderExtension class member.
Signed-off-by: Andrey Shinkevich
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/qcow2_format.py | 14
Add bitmap table information to the QCOW2 metadata dump.
It extends the output of the test case #291
Bitmap name bitmap-1
...
Bitmap table typeoffset size
0 serialized 4718592 65536
1 serialized
As __dict__ is being extended with class members we do not want to
print, make a light copy of the initial __dict__ and extend the copy
by adding lists we have to print in the JSON output.
Signed-off-by: Andrey Shinkevich
---
tests/qemu-iotests/qcow2_format.py | 4
1 file changed, 4
Add the command key to the qcow2.py arguments list to dump QCOW2
metadata in JSON format. Here is the suggested way to do that. The
implementation of the dump in JSON format is in the patch that follows.
Signed-off-by: Andrey Shinkevich
---
tests/qemu-iotests/qcow2.py| 19
There are two ways to initialize a class derived from Qcow2Struct:
1. Pass a block of binary data to the constructor.
2. Pass the file descriptor to allow reading the file from constructor.
Let's change the Qcow2BitmapExt initialization method from 1 to 2 to
support a scattered reading in the
13.07.2020 10:20, Michael Tokarev пишет:
> 12.07.2020 15:00, Simon John wrote:
>> macos guests no longer boot after commit
>> 5d971f9e672507210e77d020d89e0e89165c8fc9
>>
>> acpi-tmr needs 2 byte memory accesses, so breaks as that commit only allows
>> 4 bytes.
>>
>> Fixes: 5d971f9e672507210e7
13.07.2020 10:07, Andrey Shinkevich wrote:
On 11.07.2020 22:11, Vladimir Sementsov-Ogievskiy wrote:
03.07.2020 16:13, Andrey Shinkevich wrote:
Read and dump entries from the bitmap directory of QCOW2 image.
It extends the output in the test case #291.
...
diff --git
From: Philippe Mathieu-Daudé
Split out code only used during system emulation,
to reduce code pulled in user emulation and tools.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20200423202112.644-6-phi...@redhat.com>
Reviewed-by: Richard Henderson
Signed-off-by: Marc-André Lureau
---
From: Philippe Mathieu-Daudé
No file out of chardev/ requires access to this header,
restrict its scope.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20200423202112.644-5-phi...@redhat.com>
Reviewed-by: Richard Henderson
Signed-off-by: Marc-André Lureau
---
include/chardev/char-mux.h
On Mon, 13 Jul 2020 at 10:37, Cédric Le Goater wrote:
> On 7/13/20 10:06 AM, Erik Smit wrote:
> > On Mon, 13 Jul 2020 at 09:52, Cédric Le Goater wrote:
> >>
> >> With this patch, the supermicro firmware boots further but there is still
> >> an issue. It might be the flash definition I used. The
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
target/openrisc/sys_helper.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/target/openrisc/sys_helper.c
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
target/cris/translate.c | 7 +++
target/cris/translate_v10.inc.c | 2 --
2 files changed, 3
On 06.07.20 22:39, Eric Blake wrote:
> During 'qemu-img create ... 2>&1', if --quiet is not in force, we can
> end up with buffered I/O in stdout that was produced before failure,
> but which appears in output after failure. This is confusing; the fix
> is to flush stdout prior to attempting
On 13/07/2020 11.03, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous break.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/arm/kvm64.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/arm/kvm64.c
On 7/10/20 7:22 AM, John Snow wrote:
> As always, Optional[T] causes problems with unchecked access. Add a
> helper that asserts the pipe is present before we attempt to talk with
> it.
>
> Signed-off-by: John Snow
> ---
> python/qemu/machine.py | 16 +++-
> 1 file changed, 11
On 7/10/20 7:06 AM, John Snow wrote:
> Machine.wait() does not appear to be used except in the acceptance tests,
> and an infinite timeout by default in a test suite is not the most helpful.
>
> Change it to 3 seconds, like the default shutdown timeout.
>
> Signed-off-by: John Snow
> ---
>
On Sat, Jul 04, 2020 at 04:49:17PM +0200, Philippe Mathieu-Daudé wrote:
> Hi,
>
> This is the second time I try to replace a magic typename string
> by a constant, and Zoltan warns me this is counter productive as
> "hw/usb.h" pulls in an insane amount of code.
>
> Time to give the usb
On 17.06.20 20:27,
Sorry :/
Connor Kuehl wrote:
> Providing an empty string for the backing file parameter like so:
>
> qemu-img create -f qcow2 -b '' /tmp/foo
>
> allows the flow of control to reach and subsequently fail an assert
> statement because passing an empty string to
>
>
GCC supports "#pragma GCC diagnostic" since version 4.6, and
Clang seems to support it, too, since its early versions 3.x.
That means that our minimum required compiler versions all support
this pragma already and we can remove the test from configure and
all the related #ifdefs in the code.
From: Olaf Hering
Avoid random return value.
Fixes commit f2dfe54c74f768a5bf78c9e5918918727f9d9459
Signed-off-by: Olaf Hering
Message-Id: <20200707171326.16422-1-o...@aepfle.de>
Reviewed-by: Richard Henderson
Signed-off-by: Thomas Huth
---
configure | 1 +
1 file changed, 1 insertion(+)
Fix typo - the option is called "--fuzz-target" and not "--fuzz_taget".
Also use a different fuzzer in the example, since "virtio-net-fork-fuzz"
does not seem to be a valid fuzzer target (anymore?).
Signed-off-by: Thomas Huth
Message-Id: <20200709084059.22539-1-th...@redhat.com>
---
From: Alexander Bulekov
In 45222b9a90, I fixed a broken check for rcu_enable_atfork introduced
in d6919e4cb6. I added a call to rcu_enable_atfork after the
call to qemu_init in fuzz.c, but forgot to include the corresponding
header, breaking --enable-fuzzing --enable-werror builds.
Fixes:
There should be a space between "forking" and "for".
Message-Id: <20200709083719.1-1-th...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Alexander Bulekov
Signed-off-by: Thomas Huth
---
tests/qtest/fuzz/virtio_scsi_fuzz.c | 4 ++--
1 file changed, 2 insertions(+), 2
On 13.07.20 12:27, David Hildenbrand wrote:
>
>
>> Am 13.07.2020 um 11:12 schrieb Heiko Carstens :
>>
>> On Fri, Jul 10, 2020 at 05:24:07PM +0200, David Hildenbrand wrote:
On 10.07.20 17:18, Heiko Carstens wrote:
On Fri, Jul 10, 2020 at 02:12:33PM +0200, David Hildenbrand wrote:
On 7/13/20 12:51 PM, Cornelia Huck wrote:
> On Sat, 11 Jul 2020 13:40:50 +0200
> Claudio Fontana wrote:
>
>> I found out something that for me shows that more investigation here is
>> warranted.
>>
>>
>> Here is my latest workaround for the problem:
>>
>>
>>
>> diff --git
On Wed, Jul 08, 2020 at 07:17:52PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 08.07.2020 15:07, Stefan Hajnoczi wrote:
> > On Sat, Jun 20, 2020 at 05:36:47PM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > It may be used for file-systems with slow allocation.
> > >
> > > Signed-off-by:
On 7/13/20 1:39 PM, Claudio Fontana wrote:
> Hello,
>
> On 7/13/20 1:03 PM, Dr. David Alan Gilbert wrote:
>> * Claudio Fontana (cfont...@suse.de) wrote:
>>> Hello all,
>>>
>>> during unrelated work for splitting QTest from the TCG instruction counting
>>> module,
>>>
>>> I encountered what seems
On Thu, Jun 25, 2020 at 9:55 PM Vivek Goyal wrote:
>
> On Thu, Jun 25, 2020 at 12:19:39PM +0900, Chirantan Ekbote wrote:
> [..]
> > > Chirantan,
> > >
> > > So you ended up renaming all "trusted", "security" and "system" xattrs?
> > > Only "user" xattrs are complete passthrough?
> > >
> >
> > No,
On 13/07/2020 11.05, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> block/vmdk.c | 3 ---
> 1 file changed, 3 deletions(-)
>
>
On 7/10/20 7:22 AM, John Snow wrote:
> These should all be purely annotations with no changes in behavior at
> all. You need to be in the python folder, but you should be able to
> confirm that these annotations are correct (or at least self-consistent)
> by running `mypy --strict qemu`.
>
>
On 13/07/2020 11.04, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> tcg/riscv/tcg-target.inc.c | 2 --
> 1 file changed, 2
On 13/07/2020 11.04, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove the superfluous break, as there is a "return" before.
>
> Signed-off-by: Liao Pingfang a
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> ui/vnc-enc-tight.c | 1 -
> 1 file changed, 1 deletion(-)
>
>
On 7/10/20 7:06 AM, John Snow wrote:
> This is done primarily to avoid the 'bare except' pattern, which
> suppresses all exceptions during shutdown and can obscure errors.
>
> Replace this with a pattern that isolates the different kind of shutdown
> paradigms (_hard_shutdown and _soft_shutdown),
1 - 100 of 484 matches
Mail list logo
