Re: [PATCH-for-5.1 v2 0/2] stubs: Fix notify-event stub linkage error on MinGW

2020-08-18 Thread Paolo Bonzini
On 05/08/20 10:55, Philippe Mathieu-Daudé wrote: > 2 trivial patches to fix the link error reported by Thomas: > > LINKtests/test-timed-average.exe > libqemuutil.a(main-loop.o): In function `qemu_notify_event': > util/main-loop.c:139: multiple definition of `qemu_notify_event' > >

Re: [PATCH] qemu-img: Explicit number replaced by a constant

2020-08-18 Thread Stefano Garzarella
Hi Yi Li, thanks for this patch! Just a comment below: On Mon, Aug 17, 2020 at 07:01:13PM +0800, Yi Li wrote: > Signed-off-by: Yi Li > --- > qemu-img.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 5308773811..a0fbc2757c

Re: [PATCH-for-5.2] memory: Add trace events to audit MemoryRegionOps fields

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 8:32 AM, Paolo Bonzini wrote: > On 06/08/20 17:26, Philippe Mathieu-Daudé wrote: >> Add trace events to audit MemoryRegionOps field such: >> - are all the valid/impl fields provided? >> - is the region a power of two? >> >> These cases are accepted, but it is interesting to list them.

Re: What is bs->reqs_lock for?

2020-08-18 Thread Paolo Bonzini
On 13/08/20 18:34, Vladimir Sementsov-Ogievskiy wrote: > I thought bs is attached to one aio context and aio context attached to > one iothread. For now yes, but with multiqueue there would be many iothreads sending requests to the AioContext. The BDS would still have a "home" aiocontext to

Re: [PATCH 00/18] hw/riscv: Add Microchip PolarFire SoC Icicle Kit board support

2020-08-18 Thread Anup Patel
On Tue, Aug 18, 2020 at 1:23 AM wrote: > > On 8/17/20 8:28 PM, Alistair Francis wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Mon, Aug 17, 2020 at 11:12 AM via wrote: > >> Hi Anup, > >> > >> On 8/17/20 11:30 AM, Bin Meng

Re: [PATCH-for-5.1 v2 0/2] stubs: Fix notify-event stub linkage error on MinGW

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 8:37 AM, Paolo Bonzini wrote: > On 05/08/20 10:55, Philippe Mathieu-Daudé wrote: >> 2 trivial patches to fix the link error reported by Thomas: >> >> LINKtests/test-timed-average.exe >> libqemuutil.a(main-loop.o): In function `qemu_notify_event': >> util/main-loop.c:139:

Re: [PATCH v4 5/8] mips/cps: Use start-powered-off CPUState property

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 5:33 AM, Thiago Jung Bauermann wrote: > Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the > start-powered-off property which makes cpu_common_reset() initialize it > to 1 in common code. > > Also change creation of CPU object from cpu_create() to object_new() and >

Re: [RFC PATCH 06/22] qemu-nbd: Use raw block driver for --offset

2020-08-18 Thread Kevin Wolf
Am 17.08.2020 um 19:19 hat Nir Soffer geschrieben: > On Thu, Aug 13, 2020 at 7:36 PM Kevin Wolf wrote: > > > Instead of implementing qemu-nbd --offset in the NBD code, just put a > > raw block node with the requested offset on top of the user image and > > rely on that doing the job. > > > >

Re: [RFC PATCH 06/22] qemu-nbd: Use raw block driver for --offset

2020-08-18 Thread Nir Soffer
On Tue, Aug 18, 2020 at 11:47 AM Kevin Wolf wrote: > Am 17.08.2020 um 19:19 hat Nir Soffer geschrieben: > > On Thu, Aug 13, 2020 at 7:36 PM Kevin Wolf wrote: > > > > > Instead of implementing qemu-nbd --offset in the NBD code, just put a > > > raw block node with the requested offset on top of

Re: [RFC PATCH] os-posix: fix regression for install-less datadir location

2020-08-18 Thread Paolo Bonzini
On 16/07/20 16:11, Marc-André Lureau wrote: > os_find_datadir() used to check the ../share/qemu location (regardless > of CONFIG_QEMU_DATADIR). It turns out that people rely on that location > for running qemu in an arbitrary "install-less/portable" fashion. Change > the logic to return that

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Jason Wang
On 2020/8/18 下午4:55, Daniel P. Berrangé wrote: On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: On 2020/8/14 下午1:16, Yan Zhao wrote: On Thu, Aug 13, 2020 at 12:24:50PM +0800, Jason Wang wrote:

Re: [PATCH] memory: Directly dispatch alias accesses on origin memory region

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/17/20 6:27 PM, Paolo Bonzini wrote: > On 16/08/20 19:30, Philippe Mathieu-Daudé wrote: >> There is an issue when accessing an alias memory region via the >> memory_region_dispatch_read() / memory_region_dispatch_write() >> calls: >> >> The memory_region_init_alias() flow is: >> >>

[Bug 1890545] Re: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

2020-08-18 Thread Tony.LI
I wrote an example to load local HTML: #include "mainwindow.h" #include "ui_mainwindow.h" #include MainWindow::MainWindow(QWidget *parent) : QMainWindow(parent), ui(new Ui::MainWindow) { ui->setupUi(this); QWebEngineView *webView = new QWebEngineView(this);

Re: hw-display-qxl.so: undefined symbol: qemu_qxl_io_log_semaphore

2020-08-18 Thread Gerd Hoffmann
Hi, > So nothing specific to qxl, seems all modules are busted. > I tried downgrading gcc to f32 versions, no difference. Same after > downgrading binutils. Downgrading glibc downgrades the whole distro so I > didn't attempt it > Any suggestions? Try downgrade rpm macros? take care, Gerd

Re: [PATCH v4 4/8] ppc/e500: Use start-powered-off CPUState property

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 5:33 AM, Thiago Jung Bauermann wrote: > Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use > the start-powered-off property which makes cpu_common_reset() initialize it > to 1 in common code. > > Also change creation of CPU object from cpu_create() to object_new()

[Bug 1890545] Re: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

2020-08-18 Thread Tony.LI
I wrote an example to load local HTML: #include "mainwindow.h" #include "ui_mainwindow.h" #include MainWindow::MainWindow(QWidget *parent) : QMainWindow(parent), ui(new Ui::MainWindow) { ui->setupUi(this); QWebEngineView *webView = new QWebEngineView(this);

Re: [PATCH] hw: add a number of SPI-flash's of m25p80 family

2020-08-18 Thread Cédric Le Goater
On 8/17/20 7:16 PM, i.kononenko wrote: > No, the ext ID wasn't be checked at a real HW. > Just copied it from the U-boot official repository > https://github.com/u-boot/u-boot/blob/789bfb52668ee609b2043de645e2f94bbd24fd1f/drivers/mtd/spi/spi-nor-ids.c#L183 OK. Reviewed-by: Cédric Le Goater >

Re: [PATCH-for-5.2] memory: Add trace events to audit MemoryRegionOps fields

2020-08-18 Thread Paolo Bonzini
On 06/08/20 17:26, Philippe Mathieu-Daudé wrote: > Add trace events to audit MemoryRegionOps field such: > - are all the valid/impl fields provided? > - is the region a power of two? > > These cases are accepted, but it is interesting to list them. > > Example: > > $ qemu-system-i386 -S

Re: [PATCH 0/1] qcow2: Skip copy-on-write when allocating a zero cluster

2020-08-18 Thread Kevin Wolf
Am 17.08.2020 um 20:18 hat Alberto Garcia geschrieben: > On Mon 17 Aug 2020 05:53:07 PM CEST, Kevin Wolf wrote: > > Maybe the difference is in allocating 64k at once instead of doing a > > separate allocation for every 4k block? But with the extent size hint > > patches to file-posix, we should

Re: [PATCH-for-5.1 v2 2/2] stubs: Remove qemu_notify_event()

2020-08-18 Thread Paolo Bonzini
On 05/08/20 13:49, Thomas Huth wrote: >> ... as this is the current behavior. > But could we maybe end up in a scenario, where the stub from > stubs/cpu-get-icount.c is used, which then calls the real implementation > of qemu_notify_event() in main-loop.c ? Yes, definitely. It would happen in

[Bug 1882851] [PATCH 1/2] drm/virtio: fix unblank

2020-08-18 Thread Gerd Hoffmann
When going through a disable/enable cycle without changing the framebuffer the optimization added by commit 3954ff10e06e ("drm/virtio: skip set_scanout if framebuffer didn't change") causes the screen stay blank. Add a bool to force an update to fix that. v2: use drm_atomic_crtc_needs_modeset()

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Daniel P . Berrangé
Your mail came through as HTML-only so all the quoting and attribution is mangled / lost now :-( On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote: >On 2020/8/18 下午4:55, Daniel P. Berrangé wrote: > > On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: > > On 2020/8/14

Re: [PATCH] hw: dev-wacom: Support wacom tablet emulation in linux qemu

2020-08-18 Thread Gerd Hoffmann
On Mon, Aug 17, 2020 at 06:42:02PM +0200, Michael Nazzareno Trimarchi wrote: > Hi Gerd > > Have another small question. Do you know how force show cursor working > in this case? Which display and which vga do you use? take care, Gerd

Re: [PATCH 1/4] edid: use physical dimensions if available

2020-08-18 Thread Gerd Hoffmann
On Mon, Aug 17, 2020 at 04:57:55PM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Aug 17, 2020 at 4:21 PM Gerd Hoffmann wrote: > > > > On Mon, Aug 17, 2020 at 04:00:53PM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > Add width_mm/height_mm to

Re: [PATCH 13/41] hvf: Add missing include

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/14/20 12:25 AM, Eduardo Habkost wrote: > The sysemu/accel.h header is needed for the ACCEL_CLASS_NAME > macro. This will be necessary to allow us to use OBJECT_DEFINE*() > for TYPE_HVF_ACCEL. > > Signed-off-by: Eduardo Habkost > --- > include/sysemu/hvf.h | 2 ++ > 1 file changed, 2

Re: [PATCH v4 4/8] ppc/e500: Use start-powered-off CPUState property

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 9:22 AM, Philippe Mathieu-Daudé wrote: > On 8/18/20 5:33 AM, Thiago Jung Bauermann wrote: >> Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use >> the start-powered-off property which makes cpu_common_reset() initialize it >> to 1 in common code. >> >> Also change

Re: [PATCH v4 7/8] sparc/sun4m: Use start-powered-off CPUState property

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 5:33 AM, Thiago Jung Bauermann wrote: > Instead of setting CPUState::halted to 1 in secondary_cpu_reset(), use the > start-powered-off property which makes cpu_common_reset() initialize it > to 1 in common code. > > This makes secondary_cpu_reset() unnecessary, so remove it. > > Also

Re: [PATCH 1/2] i386/cpu: Clear FEAT_XSAVE_COMP_{LO, HI} when XSAVE is not available

2020-08-18 Thread Paolo Bonzini
On 16/07/20 10:20, Xiaoyao Li wrote: > Per Intel SDM vol 1, 13.2, if CPUID.1:ECX.XSAVE[bit 26] is 0, the > processor provides no further enumeration through CPUID function 0DH. > > Signed-off-by: Xiaoyao Li > --- > target/i386/cpu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Cornelia Huck
On Tue, 18 Aug 2020 09:55:27 +0100 Daniel P. Berrangé wrote: > On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: > > Another point, as we discussed in another thread, it's really hard to make > > sure the above API work for all types of devices and frameworks. So having a > > vendor

Re: [PATCH] hw: dev-wacom: Support wacom tablet emulation in linux qemu

2020-08-18 Thread Michael Nazzareno Trimarchi
Hi On Tue, Aug 18, 2020 at 8:02 AM Gerd Hoffmann wrote: > > On Mon, Aug 17, 2020 at 06:42:02PM +0200, Michael Nazzareno Trimarchi wrote: > > Hi Gerd > > > > Have another small question. Do you know how force show cursor working > > in this case? > > Which display and which vga do you use?

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Daniel P . Berrangé
On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: > > On 2020/8/14 下午1:16, Yan Zhao wrote: > > On Thu, Aug 13, 2020 at 12:24:50PM +0800, Jason Wang wrote: > > > On 2020/8/10 下午3:46, Yan Zhao wrote: > > > > > driver is it handled by? > > > > It looks that the devlink is for network

Re: [PATCH 108/150] meson: convert hw/isa

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/17/20 4:40 PM, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > hw/Makefile.objs | 1 - > hw/isa/Makefile.objs | 11 --- > hw/isa/meson.build | 11 +++ > hw/meson.build | 1 + > 4

Re: [PATCH v3 000/150] Meson integration for 5.2

2020-08-18 Thread Paolo Bonzini
On 18/08/20 11:59, Cornelia Huck wrote: > On Mon, 17 Aug 2020 16:34:53 +0200 > Paolo Bonzini wrote: > >> - Simplified/rewrote handling of the modules variable [Howard] >> - Fixed access to gdb-xml files [Howard] >> - Fixed cross-compilation failure due to mingw prefix [Howard] >> - Fixed SDL2

Re: [PATCH 088/150] meson: convert hw/smbios

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/17/20 4:36 PM, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > hw/Makefile.objs| 1 - > hw/meson.build | 1 + > hw/smbios/Makefile.objs | 10 -- > hw/smbios/meson.build | 13

Re: [PATCH V2] Introduce a new flag for piix to disable root bus PCI hotplug

2020-08-18 Thread Ani Sinha
> On Aug 18, 2020, at 3:49 PM, Ani Sinha wrote: > >  > This is not a workaround, this is a feature we need badly. We have discussed > this at length. Igor suggested we have one additional global flag to disable > all pci hotplug. But then that leads to strange case when pci hotplug on the

Re: [PATCH v3 0/7] colo: Introduce resource agent and test suite/CI

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 2:27 PM, Lukas Straub wrote: > On Tue, 4 Aug 2020 12:46:29 +0200 > Lukas Straub wrote: > >> Hello Everyone, >> So here is v3. Patch 1 can already be merged independently of the others. >> Please review. >> >> Regards, >> Lukas Straub >> >> Based-on: >> "Introduce 'yank' oob qmp

Re: [RFC PATCH] os-posix: fix regression for install-less datadir location

2020-08-18 Thread Peter Maydell
On Tue, 18 Aug 2020 at 10:11, Paolo Bonzini wrote: > > On 16/07/20 16:11, Marc-André Lureau wrote: > > os_find_datadir() used to check the ../share/qemu location (regardless > > of CONFIG_QEMU_DATADIR). It turns out that people rely on that location > > for running qemu in an arbitrary

Re: [PATCH 00/18] hw/riscv: Add Microchip PolarFire SoC Icicle Kit board support

2020-08-18 Thread via
On 8/18/20 7:17 AM, Anup Patel wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Tue, Aug 18, 2020 at 1:23 AM wrote: >> On 8/17/20 8:28 PM, Alistair Francis wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you

[PATCH] audio/jack: fix use after free segfault

2020-08-18 Thread Geoffrey McRae
Due to a ridiculous commit in the Jack library, the client may have been freed already by a secondary audio device recovering its session. https://github.com/jackaudio/jack2/issues/627 Until there is a proper fix for this we can not risk using the pointer at all if we have been notified of a

Re: [PATCH V2] Introduce a new flag for piix to disable root bus PCI hotplug

2020-08-18 Thread Ani Sinha
Igor etc, I just tested this patch using a Windows 2012 R2 image and it seems to be working. Any feedbacks on this patch? On Tue, Aug 11, 2020 at 6:42 PM Ani Sinha wrote: > > We introduce a new global flag for PIIX with which we can turn on or off PCI > device hotplug on the root bus. This flag

Re: [RFC PATCH 1/9] memory: Initialize MemoryRegionOps for RAM memory regions

2020-08-18 Thread P J P
+-- On Mon, 17 Aug 2020, Philippe Mathieu-Daudé wrote --+ | Fix by initializing the MemoryRegionOps to ram_device_mem_ops, this way the | memory accesses are properly dispatched using | memory_region_ram_device_read() / memory_region_ram_device_write(). | | Fixes: 4a2e242bbb ("memory: Don't

Re: [PATCH V2] Introduce a new flag for piix to disable root bus PCI hotplug

2020-08-18 Thread Ani Sinha
This is not a workaround, this is a feature we need badly. We have discussed this at length. Igor suggested we have one additional global flag to disable all pci hotplug. But then that leads to strange case when pci hotplug on the bridges are enabled (we have a separate flag for that). Hence, I

Re: [PATCH 092/150] meson: convert hw/vfio

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/17/20 4:36 PM, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > hw/Makefile.objs | 1 - > hw/meson.build| 1 + > hw/vfio/Makefile.objs | 8 > hw/vfio/meson.build | 18 ++ >

Re: [PATCH v4 4/8] ppc/e500: Use start-powered-off CPUState property

2020-08-18 Thread Igor Mammedov
On Tue, 18 Aug 2020 00:33:19 -0300 Thiago Jung Bauermann wrote: [...] > Also change creation of CPU object from cpu_create() to object_new() and > qdev_realize() because cpu_create() realizes the CPU and it's not possible > to set a property after the object is realized. cpu_create was

[RFC PATCH 3/9] block/curl: Tracing

2020-08-18 Thread David Edmondson
Add some more trace functions to the IO path. Signed-off-by: David Edmondson --- block/curl.c | 10 +- block/io.c | 4 block/linux-aio.c | 6 ++ block/trace-events | 13 - 4 files changed, 31 insertions(+), 2 deletions(-) diff --git a/block/curl.c

Re: [PATCH 07/11] vfio/platform: Remove dead assignment in vfio_intp_interrupt()

2020-08-18 Thread Stefan Hajnoczi
On Thu, Aug 13, 2020 at 09:18:59PM +0200, Auger Eric wrote: > Hi Alex, > > On 8/13/20 9:15 PM, Alex Williamson wrote: > > On Thu, 13 Aug 2020 20:02:45 +0200 > > Auger Eric wrote: > > > >> Hi Alex, > >> > >> On 8/13/20 6:59 PM, Alex Williamson wrote: > >>> On Thu, 13 Aug 2020 15:37:08 +0800 >

[PATCH v4 2/4] iotests.py: Add wait_for_runstate()

2020-08-18 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 717b5b652c..ee93cf22db 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -833,6

[PATCH v4 3/4] iotests.py: Let wait_migration() return on failure

2020-08-18 Thread Max Reitz
Let wait_migration() return on failure (with the return value indicating whether the migration was completed or has failed), so we can use it for migrations that are expected to fail, too. Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 18 -- 1 file changed, 12

[PATCH v4 1/4] migration: Add block-bitmap-mapping parameter

2020-08-18 Thread Max Reitz
This migration parameter allows mapping block node names and bitmap names to aliases for the purpose of block dirty bitmap migration. This way, management tools can use different node and bitmap names on the source and destination and pass the mapping of how bitmaps are to be transferred to qemu

[PATCH v4 4/4] iotests: Test node/bitmap aliases during migration

2020-08-18 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/300 | 595 + tests/qemu-iotests/300.out | 5 + tests/qemu-iotests/group | 1 + 3 files changed, 601 insertions(+) create mode 100755 tests/qemu-iotests/300 create mode 100644

Re: [PATCH] fixed proc myself (linux user) for musl

2020-08-18 Thread Андрей Аладьев
I've sent 3 separate patches using "git send email", please review. пн, 17 авг. 2020 г. в 18:12, Laurent Vivier : > Hi, > > it seems your patch does several things. > > Could you split it into several patches? > Could you add a description of what the patches do? > Could you use a tool like "git

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Cornelia Huck
On Tue, 18 Aug 2020 10:16:28 +0100 Daniel P. Berrangé wrote: > On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote: > >On 2020/8/18 下午4:55, Daniel P. Berrangé wrote: > > > > On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: > > > > On 2020/8/14 下午1:16, Yan Zhao wrote: >

Re: [PATCH V2] Introduce a new flag for piix to disable root bus PCI hotplug

2020-08-18 Thread Philippe Mathieu-Daudé
Hi, On 8/18/20 11:54 AM, Ani Sinha wrote: > Igor etc, I just tested this patch using a Windows 2012 R2 image and > it seems to be working. Any feedbacks on this patch? > > On Tue, Aug 11, 2020 at 6:42 PM Ani Sinha wrote: >> >> We introduce a new global flag for PIIX with which we can turn on or

Re: [PATCH 103/150] meson: convert hw/pci

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/17/20 4:40 PM, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > hw/Makefile.objs | 1 - > hw/meson.build | 1 + > hw/pci/Makefile.objs | 14 -- > hw/pci/meson.build | 19

[PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations

2020-08-18 Thread Rohit Shinde
Added fallthrough comment on line 270 to prevent the compiler from throwing an error while compiling with the -Wimplicit-fallthrough flag Signed-off-by: Rohit Shinde --- qapi/opts-visitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index

Re: [PATCH v3 000/150] Meson integration for 5.2

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 12:25 PM, Paolo Bonzini wrote: > On 18/08/20 11:59, Cornelia Huck wrote: >> On Mon, 17 Aug 2020 16:34:53 +0200 >> Paolo Bonzini wrote: >> >>> - Simplified/rewrote handling of the modules variable [Howard] >>> - Fixed access to gdb-xml files [Howard] >>> - Fixed cross-compilation

[RFC PATCH 4/9] block/curl: Perform IO in fixed size chunks

2020-08-18 Thread David Edmondson
Do all IO requests to the remote server in 256kB chunks. Signed-off-by: David Edmondson --- block/curl.c | 151 - block/trace-events | 2 + 2 files changed, 109 insertions(+), 44 deletions(-) diff --git a/block/curl.c b/block/curl.c index

[RFC PATCH 1/9] block/curl: Add an 'offset' parameter, affecting all range requests

2020-08-18 Thread David Edmondson
A new 'offset' parameter affects all range requests that are sent to the remote server. The value, in bytes, is simply added to any byte offset values passed in to the driver. Signed-off-by: David Edmondson --- block/curl.c | 12 +++-

Re: [PATCH] qemu-img: Explicit number replaced by a constant

2020-08-18 Thread Max Reitz
On 18.08.20 09:19, Stefano Garzarella wrote: > Hi Yi Li, > thanks for this patch! Just a comment below: > > On Mon, Aug 17, 2020 at 07:01:13PM +0800, Yi Li wrote: >> Signed-off-by: Yi Li >> --- >> qemu-img.c | 12 ++-- >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git

Re: hw-display-qxl.so: undefined symbol: qemu_qxl_io_log_semaphore

2020-08-18 Thread Daniel P . Berrangé
On Wed, Aug 12, 2020 at 11:46:21AM -0400, Cole Robinson wrote: > On 7/29/20 8:50 AM, Stefan Hajnoczi wrote: > > On Thu, Jul 16, 2020 at 05:10:26PM -0400, Cole Robinson wrote: > >> I'm trying to build qemu 5.1.0-rc0 in Fedora. I'm hitting some issues. > > > > For anyone else reading this email

[PATCH v2 3/7] x86: cpuhp: refuse cpu hot-unplug request earlier if not supported

2020-08-18 Thread Igor Mammedov
CPU hot-unplug with SMM requires firmware participation to prevent guest crash (i.e. CPU can be removed only after OS _and_ firmware were prepared for the action). Previous patches introduced ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT feature bit, which is advertised by firmware when it has support for CPU

Re: [PATCH v2 4/7] acpi: add aml_land() and aml_break() primitives

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 2:22 PM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé > --- > include/hw/acpi/aml-build.h | 2 ++ > hw/acpi/aml-build.c | 16 > 2 files changed, 18 insertions(+) > > diff --git a/include/hw/acpi/aml-build.h

[RFC v4 1/2] memory: Rename memory_region_notify_one to memory_region_notify_one_iommu

2020-08-18 Thread Eugenio Pérez
Signed-off-by: Eugenio Pérez --- hw/arm/smmu-common.c | 2 +- hw/arm/smmuv3.c | 2 +- hw/i386/intel_iommu.c | 4 ++-- include/exec/memory.h | 6 +++--- softmmu/memory.c | 6 +++--- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/arm/smmu-common.c

[RFC v4 2/2] memory: Skip bad range assertion if notifier is DEVIOTLB type

2020-08-18 Thread Eugenio Pérez
Signed-off-by: Eugenio Pérez --- hw/virtio/vhost.c | 2 +- include/exec/memory.h | 2 ++ softmmu/memory.c | 15 +-- 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 1a1384e7a6..6ca168b47e 100644 ---

Re: [PATCH 00/41] qom: Automated conversion of type checking boilerplate

2020-08-18 Thread Eduardo Habkost
On Tue, Aug 18, 2020 at 12:59:03PM +0300, Roman Bolshakov wrote: > On Thu, Aug 13, 2020 at 06:25:44PM -0400, Eduardo Habkost wrote: > > This is an extension of the series previously submitted by > > Daniel[1], including a script that will convert existing type > > checker macros automatically. > >

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Cornelia Huck
On Tue, 18 Aug 2020 10:24:33 +0100 Daniel P. Berrangé wrote: > On Tue, Aug 18, 2020 at 11:06:17AM +0200, Cornelia Huck wrote: > > On Tue, 18 Aug 2020 09:55:27 +0100 > > Daniel P. Berrangé wrote: > > > > > On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: > > > > Another point, as

Re: [PATCH 090/150] meson: convert hw/watchdog

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/17/20 4:36 PM, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > hw/Makefile.objs | 1 - > hw/meson.build| 1 + > hw/watchdog/Makefile.objs | 7 --- > hw/watchdog/meson.build | 7 +++ >

Re: [PATCH 094/150] meson: convert hw/tpm

2020-08-18 Thread Philippe Mathieu-Daudé
Hi Paolo, Marc-André, On 8/17/20 4:36 PM, Paolo Bonzini wrote: > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > hw/Makefile.objs | 1 - > hw/meson.build | 1 + > hw/tpm/Makefile.objs | 6 -- > hw/tpm/meson.build | 8 > 4 files changed, 9

Re: [PATCH v4 5/8] mips/cps: Use start-powered-off CPUState property

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 9:26 AM, Philippe Mathieu-Daudé wrote: > On 8/18/20 5:33 AM, Thiago Jung Bauermann wrote: >> Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the >> start-powered-off property which makes cpu_common_reset() initialize it >> to 1 in common code. >> >> Also change

[RFC PATCH 6/9] block/curl: Cache downloaded blocks

2020-08-18 Thread David Edmondson
In the hope that they will be referred to multiple times, cache the blocks downloaded from the remote server. Signed-off-by: David Edmondson --- block/curl.c | 321 +++-- block/trace-events | 3 + 2 files changed, 287 insertions(+), 37

[RFC PATCH 2/9] block/curl: Remove readahead support

2020-08-18 Thread David Edmondson
Block based caching and the current readahead support do not interact well, so remove readahead support before adding block caching. Readahead will be re-added later. Signed-off-by: David Edmondson --- block/curl.c | 23 ---

[RFC PATCH 8/9] block/curl: Allow 16 sockets/ACB

2020-08-18 Thread David Edmondson
qemu-img allows up to 16 coroutines when performing IO. Ensure that there is a Curl socket and ACB available to each of them. Signed-off-by: David Edmondson --- block/curl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/curl.c b/block/curl.c index

[PATCH v2 1/7] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features

2020-08-18 Thread Igor Mammedov
It will allow firmware to notify QEMU that firmware requires SMI being triggered on CPU hot[un]plug, so that it would be able to account for hotplugged CPU and relocate it to new SMM base and/or safely remove CPU on unplug. Using negotiated features, follow up patches will insert SMI upcall into

[PATCH v2 5/7] tests: acpi: mark to be changed tables in bios-tables-test-allowed-diff

2020-08-18 Thread Igor Mammedov
... to let tests pass until binary blobs are updated with new AML Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h

[PATCH v2 6/7] x68: acpi: trigger SMI before sending hotplug Notify event to OSPM

2020-08-18 Thread Igor Mammedov
In case firmware has negotiated CPU hotplug SMI feature, generate AML to describe SMI IO port region and send SMI to firmware on each CPU hotplug SCI in case new CPUs were hotplugged. Since new CPUs can be hotplugged while CPU_SCAN_METHOD is running we can't send SMI before new CPUs are fetched

[PATCH v2 7/7] tests: acpi: update acpi blobs with new AML

2020-08-18 Thread Igor Mammedov
Update CPU hotplug AML with following changes Method (CSCN, 0, Serialized) { Acquire (\_SB.PCI0.PRES.CPLK, 0x) +Name (CNEW, Package (0x01){}) +Local1 = Zero Local0 = One -While ((Local0

[PATCH v2 2/7] x86: cphp: prevent guest crash on CPU hotplug when broadcast SMI is in use

2020-08-18 Thread Igor Mammedov
There were reports of guest crash on CPU hotplug, when using q35 machine type and OVMF with SMM, due to hotplugged CPU trying to process SMI at default SMI handler location without it being relocated by firmware first. Fix it by refusing hotplug if firmware hasn't negotiated CPU hotplug with SMI

[PATCH v2 0/7] x86: fix cpu hotplug with secure boot

2020-08-18 Thread Igor Mammedov
v2: - AML: clean is_inserted flag only after SMI callback - make x-smi-cpu-hotunplug false by default - massage error hint on not supported unplug v1: - fix typos and some phrases (Laszlo) - add unplug check (Laszlo) - redo AML scan logic to avoid race when adding multiple CPUs CPU

Re: [PATCH v2 0/7] x86: fix cpu hotplug with secure boot

2020-08-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200818122208.1243901-1-imamm...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH v3 000/150] Meson integration for 5.2

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/17/20 4:34 PM, Paolo Bonzini wrote: > - Simplified/rewrote handling of the modules variable [Howard] > - Fixed access to gdb-xml files [Howard] > - Fixed cross-compilation failure due to mingw prefix [Howard] > - Fixed SDL2 detection on cross compiles [Howard] > - Fixed sub-makefiles that

[PATCH v4 0/4] migration: Add block-bitmap-mapping parameter

2020-08-18 Thread Max Reitz
RFC v1: https://lists.nongnu.org/archive/html/qemu-block/2020-05/msg00912.html RFC v2: https://lists.nongnu.org/archive/html/qemu-block/2020-05/msg00915.html v1: https://lists.nongnu.org/archive/html/qemu-devel/2020-06/msg09792.html v2:

Re: [PATCH v3 000/150] Meson integration for 5.2

2020-08-18 Thread Cornelia Huck
On Mon, 17 Aug 2020 16:34:53 +0200 Paolo Bonzini wrote: > - Simplified/rewrote handling of the modules variable [Howard] > - Fixed access to gdb-xml files [Howard] > - Fixed cross-compilation failure due to mingw prefix [Howard] > - Fixed SDL2 detection on cross compiles [Howard] > - Fixed

Re: [PATCH 00/41] qom: Automated conversion of type checking boilerplate

2020-08-18 Thread Roman Bolshakov
On Thu, Aug 13, 2020 at 06:25:44PM -0400, Eduardo Habkost wrote: > This is an extension of the series previously submitted by > Daniel[1], including a script that will convert existing type > checker macros automatically. > Hi Eduardo, do you have a repo where it can be checked it out? Thanks,

Re: [PATCH v4 5/8] mips/cps: Use start-powered-off CPUState property

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 1:03 PM, Philippe Mathieu-Daudé wrote: > On 8/18/20 9:26 AM, Philippe Mathieu-Daudé wrote: >> On 8/18/20 5:33 AM, Thiago Jung Bauermann wrote: >>> Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the >>> start-powered-off property which makes cpu_common_reset()

Re: [RFC PATCH 1/9] memory: Initialize MemoryRegionOps for RAM memory regions

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 11:52 AM, P J P wrote: > +-- On Mon, 17 Aug 2020, Philippe Mathieu-Daudé wrote --+ > | Fix by initializing the MemoryRegionOps to ram_device_mem_ops, this way the > | memory accesses are properly dispatched using > | memory_region_ram_device_read() / memory_region_ram_device_write().

Re: [PATCH 104/150] meson: convert hw/nvram

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/17/20 4:40 PM, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > hw/Makefile.objs | 1 - > hw/meson.build | 1 + > hw/nvram/Makefile.objs | 8 > hw/nvram/meson.build | 9 + > 4 files

Re: [PATCH 13/41] hvf: Add missing include

2020-08-18 Thread Roman Bolshakov
On Thu, Aug 13, 2020 at 06:25:57PM -0400, Eduardo Habkost wrote: > The sysemu/accel.h header is needed for the ACCEL_CLASS_NAME > macro. This will be necessary to allow us to use OBJECT_DEFINE*() > for TYPE_HVF_ACCEL. > > Signed-off-by: Eduardo Habkost > --- > include/sysemu/hvf.h | 2 ++ > 1

Re: [PATCH 105/150] meson: convert hw/rdma

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/17/20 4:40 PM, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > hw/Makefile.objs | 1 - > hw/meson.build| 1 + > hw/rdma/Makefile.objs | 3 --- > hw/rdma/meson.build | 10 ++ > 4 files

Re: [PATCH 098/150] meson: convert hw/sd

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/17/20 4:40 PM, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > hw/Makefile.objs| 1 - > hw/meson.build | 1 + > hw/sd/Makefile.objs | 12 > hw/sd/meson.build | 12 > 4 files

Re: hw-display-qxl.so: undefined symbol: qemu_qxl_io_log_semaphore

2020-08-18 Thread Daniel P . Berrangé
On Tue, Aug 18, 2020 at 01:15:21PM +0100, Daniel P. Berrangé wrote: > IOW, new systemtap 4.4 is exposing a long standing design > flaw in QEMU's probe. > > I'm gong to ask the systemtap maintainers for an opinion on > this behaviour change none the less. Reported to systemtap maintainers here:

Re: virtio-vsock requires 'disable-legacy=on' in QEMU 5.1

2020-08-18 Thread Cornelia Huck
On Mon, 17 Aug 2020 15:11:28 +0200 Stefano Garzarella wrote: > On Mon, Aug 17, 2020 at 12:27:46PM +0200, Cornelia Huck wrote: > > On Thu, 13 Aug 2020 14:04:15 +0200 > > Stefano Garzarella wrote: > > > > > On Thu, Aug 13, 2020 at 12:37:37PM +0200, Cornelia Huck wrote: > > > > On Thu, 13 Aug

[RFC v4 0/2] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-18 Thread Eugenio Pérez
I am able to hit this assertion when a Red Hat 7 guest virtio_net device raises an "Invalidation" of all the TLB entries. This happens in the guest's startup if 'intel_iommu=on' argument is passed to the guest kernel and right IOMMU/ATS devices are declared in qemu's command line. Command line:

Re: [PATCH v2 0/7] x86: fix cpu hotplug with secure boot

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 2:56 PM, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200818122208.1243901-1-imamm...@redhat.com/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the > testing commands and > their output below. If you have Docker

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Daniel P . Berrangé
On Tue, Aug 18, 2020 at 11:06:17AM +0200, Cornelia Huck wrote: > On Tue, 18 Aug 2020 09:55:27 +0100 > Daniel P. Berrangé wrote: > > > On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: > > > Another point, as we discussed in another thread, it's really hard to make > > > sure the above

Re: [PATCH v4 4/8] ppc/e500: Use start-powered-off CPUState property

2020-08-18 Thread Igor Mammedov
On Tue, 18 Aug 2020 09:22:05 +0200 Philippe Mathieu-Daudé wrote: > On 8/18/20 5:33 AM, Thiago Jung Bauermann wrote: > > Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use > > the start-powered-off property which makes cpu_common_reset() initialize it > > to 1 in common

Re: [PATCH v7 10/47] mirror-top: Support compressed writes

2020-08-18 Thread Kevin Wolf
Am 25.06.2020 um 17:21 hat Max Reitz geschrieben: > Signed-off-by: Max Reitz > --- > block/mirror.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/block/mirror.c b/block/mirror.c > index e8e8844afc..469acf4600 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@

Re: [PATCH 087/150] meson: convert hw/nubus

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/17/20 4:36 PM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > hw/Makefile.objs | 1 - > hw/meson.build | 1 + > hw/nubus/Makefile.objs | 4 > hw/nubus/meson.build | 7 +++ > 4 files changed, 8 insertions(+), 5 deletions(-) > delete mode 100644

[RFC PATCH 9/9] block/curl: Add readahead support

2020-08-18 Thread David Edmondson
Re-add support for a readahead parameter, which is the number of bytes added to the request from the upper layer before breaking the request into blocks. The default is zero. The number of bytes specified has no alignment requirements. Signed-off-by: David Edmondson --- block/curl.c

Re: [PATCH] Makefile: Let the 'help' target list the helper targets

2020-08-18 Thread Philippe Mathieu-Daudé
Hi Mirek, On 4/23/20 12:43 PM, Philippe Mathieu-Daudé wrote: > List the name of the helper targets when calling 'make help', > along with the tool targets: > > $ make help > [...] > > Helper targets: > fsdev/virtfs-proxy-helper - Build virtfs-proxy-helper >

Re: [PATCH 2/2] hw: ehci: check return value of 'usb_packet_map'

2020-08-18 Thread Gerd Hoffmann
On Wed, Aug 12, 2020 at 09:17:27AM -0700, Li Qiang wrote: > If 'usb_packet_map' fails, we should stop to process the usb > request. Queued up all three ehci/xhci patches. thanks, Gerd

  1   2   3   4   5   >