Re: [PATCH] cirrus.yml: Exclude some targets in the FreeBSD job to speed up the build

On 27/08/2020 17.00, Daniel P. Berrangé wrote: > On Mon, Aug 24, 2020 at 11:44:10AM +0200, Thomas Huth wrote: >> The FreeBSD jobs currently hit the 1h time limit in the Cirrus-CI. >> We've got to exclude some build targets here to make sure that the job >> finishes in time again. The targets that

Re: [PULL 0/3] Fixes 20200825 patches

On Thu, Aug 27, 2020 at 11:23:58AM +0100, Peter Maydell wrote: > On Thu, 27 Aug 2020 at 08:20, Thomas Huth wrote: > > Peter, what is still missing that you could use the gitlab CI as gating > > tests, too? > > I think we're waiting on a respin of the scripts from > Cleber, aren't we? > > Also

Re: Contributor wanting to get started with simple contributions

On 28/08/2020 02.49, Rohit Shinde wrote: > Hey Thomas, > > Thanks for the in-depth response! I appreciate it a lot! > > > > On Wed, Aug 26, 2020 at 9:38 PM Thomas Huth > wrote: > > On 26/08/2020 17.00, Rohit Shinde wrote: > > Hey Thomas, > > > > I

Re: [PATCH v6 03/20] seabios: add bios-microvm.bin binary

On Thu, Aug 27, 2020 at 04:48:54PM +0200, Sergio Lopez wrote: > On Wed, Aug 26, 2020 at 12:52:37PM +0200, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > > --- > > pc-bios/bios-microvm.bin | Bin 0 -> 131072 bytes > > 1 file changed, 0 insertions(+), 0 deletions(-) > > create mode

Re: [PATCH] ninjatool: quote dollars in variables

Il gio 27 ago 2020, 09:33 Laurent Vivier ha scritto: > This actually fixes the '-Wl,-rpath,$ORIGIN/', but doesn't fix the crash > with statically linked binaries. > I will try to reproduce when I am back; it works for Peter so there must be something different in the setup. In any case, if

Re: [PATCH v5 09/12] migration/dirtyrate: Implement get_sample_page_period() and block_sample_page_period()

On Thursday, 2020-08-27 at 16:01:37 +08, Zheng Chuan wrote: > On 2020/8/26 18:17, David Edmondson wrote: >> On Monday, 2020-08-24 at 17:14:37 +08, Chuan Zheng wrote: >> >>> Implement get_sample_page_period() and set_sample_page_period() to >>> sleep specific time between sample actions. >>> >>>

Re: [PATCH] pc-bios: s390x: Add a comment to the io and external new PSW setup

On 22/07/2020 10.05, Janosch Frank wrote: > On 7/22/20 9:39 AM, Christian Borntraeger wrote: >> >> >> On 22.07.20 09:24, Janosch Frank wrote: >>> On 7/22/20 8:43 AM, Christian Borntraeger wrote: On 15.07.20 16:08, Janosch Frank wrote: > Normally they don't need to be set up

Re: [PATCH v5 11/12] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

On 2020/8/26 18:26, David Edmondson wrote: > On Monday, 2020-08-24 at 17:14:39 +08, Chuan Zheng wrote: > >> Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be >> called >> >> Signed-off-by: Chuan Zheng >> --- >> migration/dirtyrate.c | 45

[PATCH v2 2/4] pc-bios: s390x: Use reset PSW if avaliable

If a blob provides a reset PSW then we should use it instead of branching to the PSW address and using our own mask. Signed-off-by: Janosch Frank --- pc-bios/s390-ccw/bootmap.c | 1 + pc-bios/s390-ccw/jump2ipl.c | 48 ++--- pc-bios/s390-ccw/s390-ccw.h | 1 + 3

[PATCH RFC v2 3/4] pc-bios: s390x: Save io and external new PSWs before overwriting them

Currently we always overwrite the mentioned exception new PSWs before loading the enabled wait PSW. Let's save the PSW before overwriting and restore it right before starting the loaded kernel. Signed-off-by: Janosch Frank --- Maybe we should rather statically allocate a lowcore so we don't

Re: [PATCH 00/77] target/microblaze improvements

On 8/27/20 2:11 AM, Edgar E. Iglesias wrote: > So a first general regression is that opcode 0 no longer > traps as an illegal instruction (seems to be treated as an > add with all r0). Oops, will fix. r~

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

On 07/02/2020 15.02, Jason J. Herne wrote: > On 2/7/20 6:28 AM, Christian Borntraeger wrote: >> Jason, >> >> can you run objdump -Sdr on jump2ipl.o on a broken variant? >> >> > To keep the volume lower, I've only pasted the output that I think > you're interested in. If you want to see the entire

[PATCH] meson: fix keymaps witout qemu-keymap

In case the qemu-keymap tool generating them is neither installed on the system nor built from sources (due to xkbcommon not being available) qemu will not find the keymaps when started directly from the build tree, This happens because commit ddcf607fa3d6 ("meson: drop keymaps symlink") removed

Re: [PATCH] meson: fix qxl module build

On Thu, Aug 27, 2020 at 10:47 AM Gerd Hoffmann wrote: > Drop qxl object from softmmu source set, it is built as module. > > Also drop CONFIG_QXL condition from qxl_ss.add. First because it is > pointless, the whole thing is wrapped into "has_key('CONFIG_QXL')". > Second because it doesn't work

[Bug 1893010] Re: qemu linux-user doesn't support OFD fcntl locks

New patch version: fix target_to_host_fcntl_cmd mapping, avoid do_fcntl code duplication. ** Patch added: "qemu-5.0.0-ofd-fcntl-2.patch" https://bugs.launchpad.net/qemu/+bug/1893010/+attachment/5405156/+files/qemu-5.0.0-ofd-fcntl-2.patch -- You received this bug notification because you are

Re: [PATCH v5 10/12] migration/dirtyrate: Implement calculate_dirtyrate() function

On 2020/8/26 18:21, David Edmondson wrote: > On Monday, 2020-08-24 at 17:14:38 +08, Chuan Zheng wrote: > >> Implement calculate_dirtyrate() function. >> >> Signed-off-by: Chuan Zheng >> Signed-off-by: YanYing Zhuang >> --- >> migration/dirtyrate.c | 45

Re: Meson build on macOS: undefined symbol treatment

On 26/08/2020 15.11, Emmanuel Blot wrote: > Hi, > > I’ve noticed that since meson builds have been enabled, on macOS, the > build outcome with undefined symbols has changed: > > - prior to meson introduction (v5.1.0): >   * referencing an undeclared symbol in source code led to a warning at >

Re: [PATCH] meson: move pixman detection to meson

Il gio 27 ago 2020, 09:28 Thomas Huth ha scritto: > But I've tested the patch now, and it does not work: > > .../qemu/meson.build:117:3: ERROR: Unknown variable "have_system". > > Should the pixman test maybe be moved to a later spot in the file? It > currently shows up before the have_system

Re: [PATCH] meson: move pixman detection to meson

On 26/08/2020 09.02, Paolo Bonzini wrote: > When pixman is not installed (or too old), but virglrenderer is available > and "configure" has been run with "--disable-system", the build currently > aborts when trying to compile vhost-user-gpu (since it requires pixman). > > Let's skip the build of

Re: [PATCH v6 12/20] microvm/acpi: disable virtio-mmio cmdline hack

On Wed, Aug 26, 2020 at 12:52:46PM +0200, Gerd Hoffmann wrote: > ... in case we are using ACPI. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Igor Mammedov > --- > hw/i386/microvm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Sergio Lopez > diff --git

Re: [PATCH v7 0/8] Introduce 'yank' oob qmp command to recover from hanging qemu

On Tue, 18 Aug 2020 14:26:31 +0200 Lukas Straub wrote: > On Tue, 4 Aug 2020 10:11:22 +0200 > Lukas Straub wrote: > > > Hello Everyone, > > In many cases, if qemu has a network connection (qmp, migration, chardev, > > etc.) > > to some other server and that server dies or hangs, qemu hangs

[PATCH RFC v3 04/14] target/riscv: Implement kvm_arch_get_registers

Get GPR CSR and FP registers from kvm by KVM_GET_ONE_REG ioctl. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/kvm.c | 150 - 1 file changed, 149 insertions(+), 1 deletion(-) diff --git a/target/riscv/kvm.c

[PATCH RFC v3 03/14] target/riscv: Implement function kvm_arch_init_vcpu

Get isa info from kvm while kvm init. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/kvm.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c index 8c386d9acf..7983f43f3f 100644 ---

[PATCH RFC v3 13/14] target/riscv: Implement virtual time adjusting with vm state changing

We hope that virtual time adjusts with vm state changing. When a vm is stopped, guest virtual time should stop counting and kvm_timer should be stopped. When the vm is resumed, guest virtual time should continue to count and kvm_timer should be restored. Signed-off-by: Yifei Jiang Signed-off-by:

[PATCH RFC v3 05/14] arget/riscv: Implement kvm_arch_put_registers

Put GPR CSR and FP registers to kvm by KVM_SET_ONE_REG ioctl Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/kvm.c | 142 - 1 file changed, 141 insertions(+), 1 deletion(-) diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c

[PATCH RFC v3 08/14] target/riscv: Handler KVM_EXIT_RISCV_SBI exit

Use char-fe handler console sbi call, which implement early console io while apply 'earlycon=sbi' into kernel parameters. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/kvm.c | 42 - target/riscv/sbi_ecall_interface.h | 72

Re: Help with usb-host hostdevice property

On Thu, Aug 27, 2020 at 5:01 AM Gerd Hoffmann wrote: > > Hi, > > > usb 1-1: Invalid ep0 maxpacket: 64 > > usb usb1-port1: unable to enumerate USB device > > https://patchwork.ozlabs.org/project/qemu-devel/patch/20200826145239.6077-18-kra...@redhat.com/ That helps indeed, thanks Gerd!

Re: [PATCH] ninjatool: quote dollars in variables

On Thu, 27 Aug 2020 at 10:20, Paolo Bonzini wrote: > > ... and actually it's fixed in 0.55.1. We can therefore just update the > submodule and declare 0.55.1 the minimum required version for QEMU. Oh, I meant to ask -- if 0.56 is the one that gets rid of the warnings about unstable-keyval

Re: [PATCH v7 1/8] Introduce yank feature

On Tue, Aug 04, 2020 at 10:11:34AM +0200, Lukas Straub wrote: > The yank feature allows to recover from hanging qemu by "yanking" > at various parts. Other qemu systems can register themselves and > multiple yank functions. Then all yank functions for selected > instances can be called by the

Re: [PATCH v3 09/10] hw/intc: fix default registers value in exynos4210_combiner_read()

On Thu, 27 Aug 2020 at 12:04, Chen Qun wrote: > > Clang static code analyzer show warning: > hw/intc/exynos4210_combiner.c:231:9: warning: Value stored to 'val' is never > read > val = s->reg_set[offset >> 2]; > > The default register return value should be return 'val'. > > Reported-by:

[PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands

savevm, loadvm and delvm are some of the few HMP commands that have never been converted to use QMP. The primary reason for this lack of conversion is that they block execution of the thread for as long as they run. Despite this downside, however, libvirt and applications using libvirt have used

[PATCH v3 5/7] block: allow specifying name of block device for vmstate storage

Currently the vmstate will be stored in the first block device that supports snapshots. Historically this would have usually been the root device, but with UEFI it might be the variable store. There needs to be a way to override the choice of block device to store the state in. Signed-off-by:

[PATCH v3 4/7] block: add ability to specify list of blockdevs during snapshot

When running snapshot operations, there are various rules for which blockdevs are included/excluded. While this provides reasonable default behaviour, there are scenarios that are not well handled by the default logic. Some of the conditions do not have a single correct answer. Thus there needs

Re: [PATCH v5 06/12] migration/dirtyrate: Record hash results for each sampled page

* Zheng Chuan (zhengch...@huawei.com) wrote: > > > On 2020/8/26 20:35, Dr. David Alan Gilbert wrote: > > * Chuan Zheng (zhengch...@huawei.com) wrote: > >> Record hash results for each sampled page, crc32 is taken to calculate > >> hash results for each sampled 4K-page. > >> > >> Signed-off-by:

Re: [PATCH v3 0/7] colo: Introduce resource agent and test suite/CI

On Tue, 18 Aug 2020 14:27:01 +0200 Lukas Straub wrote: > On Tue, 4 Aug 2020 12:46:29 +0200 > Lukas Straub wrote: > > > Hello Everyone, > > So here is v3. Patch 1 can already be merged independently of the others. > > Please review. > > > > Regards, > > Lukas Straub > > > > Based-on: > >

[Bug 1893010] Re: qemu linux-user doesn't support OFD fcntl locks

The attached patch fixes the issue for me. ** Patch added: "qemu-5.0.0-ofd-fcntl.patch" https://bugs.launchpad.net/qemu/+bug/1893010/+attachment/5405131/+files/qemu-5.0.0-ofd-fcntl.patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [PATCH] ninjatool: quote dollars in variables

Found; https://github.com/mesonbuild/Meson/issues/5191. (With the fix there's no rpath at all in the QEMU build process). Let's ask for a backport to 0.55.2. Paolo Il gio 27 ago 2020, 10:22 Paolo Bonzini ha scritto: > > > Il gio 27 ago 2020, 09:33 Laurent Vivier ha scritto: > >> This

Re: [PATCH for-5.2 v2 3/9] pc-bios/s390-ccw: Introduce ENODEV define and remove guards of others

On 06/08/2020 15.27, Janosch Frank wrote: > On 8/6/20 12:53 PM, Thomas Huth wrote: >> Remove the "#ifndef E..." guards from the defines here - the header >> guard S390_CCW_H at the top of the file should avoid double definition, >> and if the error code is defined in a different file already,

Re: [PATCH 00/77] target/microblaze improvements

On Tue, Aug 25, 2020 at 01:58:33PM -0700, Richard Henderson wrote: > Well, this is larger than I expected. > > I started off thinking conversion to decodetree would be quick, > after I reviewed the mttcg patches last week. Then I realized > that this could also use conversion to the generic

Re: [PATCH] ninjatool: quote dollars in variables

... and actually it's fixed in 0.55.1. We can therefore just update the submodule and declare 0.55.1 the minimum required version for QEMU. Paolo Il gio 27 ago 2020, 11:10 Paolo Bonzini ha scritto: > Found; https://github.com/mesonbuild/Meson/issues/5191. > > (With the fix there's no rpath at

Re: [PATCH v5 07/10] block: introduce preallocate filter

26.08.2020 16:51, David Edmondson wrote: + file-systems with slow allocation. + + Supported options: + + .. program:: preallocate + .. option:: prealloc-align + +On preallocation, align file length to this number, default 1M. *the file length As for “number”... Well, it is a number.

[PATCH RFC v3 02/14] target/riscv: Add target/riscv/kvm.c to place the public kvm interface

Add target/riscv/kvm.c to place kvm_arch_* function needed by kvm/kvm-all.c. Meanwhile, add kvm support in configure file. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin Reviewed-by: Alistair Francis --- configure| 1 + target/riscv/kvm.c | 128

[PATCH RFC v3 11/14] target/riscv: Support riscv cpu vmstate

Describe gpr, fpr and csr in vmstate_riscv_cpu. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/cpu.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index d8c32a8f84..b698f4adbb 100644 ---

Re: [PATCH 64/77] target/microblaze: Convert mbar to decodetree

On Tue, Aug 25, 2020 at 01:59:37PM -0700, Richard Henderson wrote: > Split this out of the normal branch instructions, as it requires > special handling. End the TB only for an instruction barrier. > > Signed-off-by: Richard Henderson > --- > target/microblaze/insns.decode | 2 + >

Re: [PATCH v2 09/10] hw/intc: Remove redundant statement in exynos4210_combiner_read()

On Thu, 27 Aug 2020 at 08:01, Chenqun (kuhn) wrote: > > > Subject: Re: [PATCH v2 09/10] hw/intc: Remove redundant statement in > > exynos4210_combiner_read() > > The code as it stands is definitely wrong, but I'm not sure this is the > > correct fix. > > Surely the intention must have been to

[PATCH v2 4/4] pc-bios: s390x: Go into disabled wait when encountering a PGM exception

Let's setup a PGM PSW, so we won't load 0s when a program exception happens. Instead we'll load a disabled wait PSW. Signed-off-by: Janosch Frank --- pc-bios/s390-ccw/start.S | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pc-bios/s390-ccw/start.S b/pc-bios/s390-ccw/start.S index

Re: [PULL 0/3] Fixes 20200825 patches

> if I've got that right, something in this pull request broke the gitlab > CI, see: > > https://gitlab.com/qemu-project/qemu/-/jobs/702680909 > > 216 (33/45) > tests/acceptance/vnc.py:Vnc.test_change_password_requires_a_password: > ERROR: Unexpected empty reply from server (0.08 s) > 217

Re: [PATCH 1/8] etsec: Use TYPE_ETSEC_COMMON constant

On Wed, Aug 26, 2020 at 02:43:27PM -0400, Eduardo Habkost wrote: > This will make future conversion to use OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost Acked-by: David Gibson > --- > Cc: David Gibson > Cc: Jason Wang > Cc: qemu-...@nongnu.org > Cc: qemu-devel@nongnu.org > ---

Re: [PATCH 7/8] ppce500: Use TYPE_PPC_E500_PCI_BRIDGE constant

On Wed, Aug 26, 2020 at 02:43:33PM -0400, Eduardo Habkost wrote: > This will make future conversion to use OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost Acked-by: David Gibson > --- > Cc: David Gibson > Cc: qemu-...@nongnu.org > Cc: qemu-devel@nongnu.org > --- >

Re: [PULL 0/3] Fixes 20200825 patches

On Thu, 27 Aug 2020 at 08:20, Thomas Huth wrote: > Peter, what is still missing that you could use the gitlab CI as gating > tests, too? I think we're waiting on a respin of the scripts from Cleber, aren't we? Also we need figure out how to handle the conflict between "gitlab's git repo is

[PATCH v3 08/10] usb/bus: Remove dead assignment in usb_get_fw_dev_path()

Clang static code analyzer show warning: qemu/hw/usb/bus.c:615:13: warning: Value stored to 'pos' is never read pos += snprintf(fw_path + pos, fw_len - pos, "%s@%lx", Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Markus Armbruster --- Cc: Gerd Hoffmann Cc: Markus

[PATCH v3 05/10] hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions()

Clang static code analyzer show warning: hw/virtio/vhost-user.c:606:9: warning: Value stored to 'mr' is never read mr = vhost_user_get_mr_data(reg->userspace_addr, , ); ^~ Reported-by: Euler Robot Signed-off-by: Chen Qun

[PATCH v3 10/10] hw/display/vga:Remove redundant statement in vga_draw_graphic()

Clang static code analyzer show warning: hw/display/vga.c:1677:9: warning: Value stored to 'update' is never read update = full_update; ^~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Gerd Hoffmann Reviewed-by: Li Qiang --- Cc: Gerd Hoffmann

Re: [PATCH v2 (BROKEN) 0/6] migration: bring improved savevm/loadvm/delvm to QMP

Daniel P. Berrangé writes: > On Wed, Aug 26, 2020 at 07:28:24PM +0100, Daniel P. Berrangé wrote: >> On Wed, Aug 26, 2020 at 05:52:06PM +0200, Markus Armbruster wrote: >> > Open questions: >> > >> > * Do we want the QMP command to delete existing snapshots with >> > conflicting tag / ID, like

[PATCH v3 3/7] migration: stop returning errno from load_snapshot()

None of the callers care about the errno value since there is a full Error object populated. This gives consistency with save_snapshot() which already just returns -1. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 17 - 1 file

Re: [PATCH v5 09/12] migration/dirtyrate: Implement get_sample_page_period() and block_sample_page_period()

On 2020/8/27 16:01, Zheng Chuan wrote: > > > On 2020/8/26 18:17, David Edmondson wrote: >> On Monday, 2020-08-24 at 17:14:37 +08, Chuan Zheng wrote: >> >>> Implement get_sample_page_period() and set_sample_page_period() to >>> sleep specific time between sample actions. >>> >>> Signed-off-by:

[Bug 1893003] Re: qemu linux-user doesn't translate host/target data for iovec I/O

The attached patch fixes the issue for me, but is incomplete (and not thoroughly tested) as I've only implemented inotify data translation for readv syscall. ** Patch added: "qemu-5.0.0-inotify-readv.patch"

[PATCH RFC v3 06/14] target/riscv: Support start kernel directly by KVM

Get kernel and fdt start address in virt.c, and pass them to KVM when cpu reset. In addition, add kvm_riscv.h to place riscv specific interface. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- hw/riscv/virt.c | 8 target/riscv/cpu.c | 4

[PATCH RFC v3 01/14] linux-header: Update linux/kvm.h

Update linux-headers/linux/kvm.h from https://github.com/kvm-riscv/linux. Only use this header file, so here do not update all linux headers by update-linux-headers.sh until above KVM series is accepted. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- linux-headers/linux/kvm.h | 8

[PATCH RFC v3 00/14] Add riscv kvm accel support

This series adds both riscv32 and riscv64 kvm support, and implements migration based on riscv. It is based on temporarily unaccepted kvm: https://github.com/kvm-riscv/linux Compared to RFC v2, the migration is supported in this series. The new added migration feature also requires the following

[PATCH RFC v3 14/14] target/riscv: Support virtual time context synchronization

Add virtual time context description to vmstate_riscv_cpu. After cpu being loaded, virtual time context is updated to KVM. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/cpu.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/target/riscv/cpu.c

[PATCH RFC v3 10/14] target/riscv: Add sifive_plic vmstate

Add sifive_plic vmstate for supporting sifive_plic migration. Current vmstate framework only supports one structure parameter as num field to describe variable length arrays, so introduce num_enables. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- hw/riscv/sifive_plic.c | 24

[PATCH RFC v3 12/14] target/riscv: Add kvm_riscv_get/put_regs_timer

Add kvm_riscv_get/put_regs_timer to synchronize virtual time context from KVM. The frequency of virtual time is not supported by KVM_SET_ONE_REG, So it's useless to synchronize the frequency of virtual time. To set register of RISCV_TIMER_REG(state) will occur a error from KVM on kvm_timer_state

[PATCH RFC v3 07/14] hw/riscv: PLIC update external interrupt by KVM when kvm enabled

Only support supervisor external interrupt currently. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- hw/riscv/sifive_plic.c | 31 ++- target/riscv/kvm.c | 19 +++ target/riscv/kvm_riscv.h | 1 + 3 files changed, 42 insertions(+), 9

Re: better file/line info for format string errors in trace events

On Tue, Aug 25, 2020 at 10:49:08PM +0100, Peter Maydell wrote: > If you have a format string error in a trace event it fails > like this: > > In file included from ../../hw/block/trace.h:1:0, > from ../../hw/block/fdc.c:48: > ./trace/trace-hw_block.h: In function

Re: [PATCH 00/77] target/microblaze improvements

On Thu, Aug 27, 2020 at 03:01:57AM -0700, Richard Henderson wrote: > On 8/27/20 2:11 AM, Edgar E. Iglesias wrote: > > So a first general regression is that opcode 0 no longer > > traps as an illegal instruction (seems to be treated as an > > add with all r0). > > Oops, will fix. Thanks. Here's

Re: [PULL v5 00/12] The following changes since commit 3461487523b897d324e8d91f3fd20ed55f849544:

On Wed, 26 Aug 2020 at 22:13, Helge Deller wrote: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200727' into staging (2020-07-28 > 18:43:48 +0100) > > are available in the Git repository at: > > g...@github.com:hdeller/qemu-hppa.git

Re: [PATCH v7 8/8] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test

On Tue, Aug 04, 2020 at 10:12:01AM +0200, Lukas Straub wrote: > A connecting chardev object has an additional reference by the connecting > thread, so if the chardev is still connecting by the end of the test, > then the chardev object won't be freed. This in turn means that the yank > instance

Re: [PATCH v7 4/8] migration: Add yank feature

On Tue, Aug 04, 2020 at 10:11:45AM +0200, Lukas Straub wrote: > Register yank functions on sockets to shut them down. > > Signed-off-by: Lukas Straub > Acked-by: Stefan Hajnoczi > --- > migration/channel.c | 12 > migration/migration.c | 25

Re: [PATCH v2 (BROKEN) 0/6] migration: bring improved savevm/loadvm/delvm to QMP

Daniel P. Berrangé writes: > On Wed, Aug 26, 2020 at 05:52:06PM +0200, Markus Armbruster wrote: >> Sorry for taking so long to reply. >> >> Daniel P. Berrangé writes: >> >> > A followup to: >> > >> > v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html >> > >> > When QMP

[PATCH v3 07/10] vfio/platform: Remove dead assignment in vfio_intp_interrupt()

Clang static code analyzer show warning: hw/vfio/platform.c:239:9: warning: Value stored to 'ret' is never read ret = event_notifier_test_and_clear(intp->interrupt); ^ ~~ Reported-by: Euler Robot Signed-off-by: Chen Qun

[PATCH v3 09/10] hw/intc: fix default registers value in exynos4210_combiner_read()

Clang static code analyzer show warning: hw/intc/exynos4210_combiner.c:231:9: warning: Value stored to 'val' is never read val = s->reg_set[offset >> 2]; The default register return value should be return 'val'. Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Igor Mitsyanko

[PATCH v3 06/10] hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check()

Clang static code analyzer show warning: hw/net/virtio-net.c:2077:5: warning: Value stored to 'tcp_flag' is never read tcp_flag &= VIRTIO_NET_TCP_FLAG; ^ ~~~ The 'VIRTIO_NET_TCP_FLAG' is '0x3F'. The last ‘tcp_flag’ assignment statement is the same as that of the

[PATCH v3 2/7] block: push error reporting into bdrv_all_*_snapshot functions

The bdrv_all_*_snapshot functions return a BlockDriverState pointer for the invalid backend, which the callers then use to report an error message. In some cases multiple callers are reporting the same error message, but with slightly different text. In the future there will be more error

[PATCH v3 6/7] iotests: add support for capturing and matching QMP events

When using the _launch_qemu and _send_qemu_cmd functions from common.qemu, any QMP events get mixed in with the output from the commands and responses. This makes it difficult to write a test case as the ordering of events in the output is not stable. This introduces a variable 'capture_events'

[PATCH v3 0/7] migration: bring improved savevm/loadvm/delvm to QMP

v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html v2: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg07523.html When QMP was first introduced some 10+ years ago now, the snapshot related commands (savevm/loadvm/delvm) were not converted. This was primarily

[PATCH v3 1/7] migration: improve error reporting of block driver state name

With blockdev, a BlockDriverState may not have a device name, so using a node name is required as an alternative. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 12 ++-- tests/qemu-iotests/267.out | 4 ++-- 2 files changed, 8

Re: [PATCH v6 01/20] microvm: name qboot binary qboot.rom

On Wed, Aug 26, 2020 at 12:52:35PM +0200, Gerd Hoffmann wrote: > qboot isn't a bios and shouldnt be named that way. > > Signed-off-by: Gerd Hoffmann > --- > hw/i386/microvm.c | 4 ++-- > pc-bios/{bios-microvm.bin => qboot.rom} | Bin > roms/Makefile

[PATCH 1/2] m25p80: Add basic support for the SFDP command

JEDEC STANDARD JESD216 for Serial Flash Discovery Parameters (SFDP) provides a mean to describe the features of a serial flash device using a set of internal parameter tables. This is the initial framework for the RDSFDP command giving access to a private SFDP area under the flash. This area now

[PATCH 2/2] m25p80: Add the n25q256a SFDP table

The same values were collected on 4 differents OpenPower systems, palmettos, romulus and tacoma. Signed-off-by: Cédric Le Goater --- hw/block/m25p80_sfdp.h | 2 ++ hw/block/m25p80.c | 6 -- hw/block/m25p80_sfdp.c | 49 ++ hw/block/Makefile.objs

[PATCH 0/2] m25p80: Add SFDP support

Hello, JEDEC STANDARD JESD216 for Serial Flash Discovery Parameters (SFDP) provides a mean to describe the features of a serial flash device using a set of internal parameter tables. Support in Linux has been added some time ago and the spi-nor driver is using it more often to detect the flash

[PATCH v2 0/4] pc-bios: s390x: Cleanup part 2

So, here are a few more cleanup patches mostly cleaning up ipl code and some of the assembly. The patches are available here: https://github.com/frankjaa/qemu/pull/new/cleanup_bios2 v2: * Fixed psw saving in use reset psw patch (thanks Jason) * Dropped a lot of patches which

[PATCH RFC v3 09/14] target/riscv: Add host cpu type

Currently, host cpu is inherited simply. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/cpu.c | 6 ++ target/riscv/cpu.h | 1 + 2 files changed, 7 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 266e70cc47..d8c32a8f84 100644 ---

[PATCH v2 1/4] pc-bios: s390x: Fix bootmap.c zipl component entry data handling

The two main types of zipl component entries are execute and load/data. The last member of the component entry struct therefore denotes either a PSW or an address. Let's make this a bit more clear by introducing a union and cleaning up the code that uses that struct member. The execute type

Re: [PATCH 64/77] target/microblaze: Convert mbar to decodetree

On 8/27/20 2:24 AM, Edgar E. Iglesias wrote: >> +/* >> + * Instruction access memory barrier. >> + * End the TB so that we recognize self-modified code immediately. >> + */ >> +if (mbar_imm & 1) { >> +dc->cpustate_changed = 1; >> +} > > This should be (mbar_imm &

Re: [PATCH 64/77] target/microblaze: Convert mbar to decodetree

On Thu, Aug 27, 2020 at 02:58:06AM -0700, Richard Henderson wrote: > On 8/27/20 2:24 AM, Edgar E. Iglesias wrote: > >> +/* > >> + * Instruction access memory barrier. > >> + * End the TB so that we recognize self-modified code immediately. > >> + */ > >> +if (mbar_imm & 1) { >

Re: [PATCH] linux-user: fix target_to_host_timespec64()

On 27.8.20. 09:04, Laurent Vivier wrote: in 32 bit mode, drop the padding in tv_nsec. If host is 64bit and target is 32bit, the padding bytes will be copied from the target and as the kernel checks the value, the syscall exits with EINVAL. Signed-off-by: Laurent Vivier ---

Re: [PATCH v7 2/8] block/nbd.c: Add yank feature

On Tue, Aug 04, 2020 at 10:11:37AM +0200, Lukas Straub wrote: > Register a yank function which shuts down the socket and sets > s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an > error occured. > > Signed-off-by: Lukas Straub > Acked-by: Stefan Hajnoczi > --- > block/nbd.c | 129

Re: [PATCH v7 3/8] chardev/char-socket.c: Add yank feature

On Tue, Aug 04, 2020 at 10:11:41AM +0200, Lukas Straub wrote: > Register a yank function to shutdown the socket on yank. > > Signed-off-by: Lukas Straub > Acked-by: Stefan Hajnoczi > --- > chardev/char-socket.c | 31 +++ > 1 file changed, 31 insertions(+)

Re: [PATCH v7 0/8] Introduce 'yank' oob qmp command to recover from hanging qemu

On Thu, Aug 27, 2020 at 10:42:46AM +0200, Lukas Straub wrote: > On Tue, 18 Aug 2020 14:26:31 +0200 > Lukas Straub wrote: > > > On Tue, 4 Aug 2020 10:11:22 +0200 > > Lukas Straub wrote: > > > > > Hello Everyone, > > > In many cases, if qemu has a network connection (qmp, migration, chardev, >

[PATCH v3 04/10] target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16()

Clang static code analyzer show warning: target/arm/translate-a64.c:13007:5: warning: Value stored to 'rd' is never read rd = extract32(insn, 0, 5); ^~ target/arm/translate-a64.c:13008:5: warning: Value stored to 'rn' is never read rn = extract32(insn, 5, 5);

[PATCH v3 02/10] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read()

Clang static code analyzer show warning: hw/arm/omap1.c:1760:15: warning: Value stored to 'cpu' during its initialization is never read CPUState *cpu = CPU(s->cpu); ^~~ ~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Peter Maydell Reviewed-by: Li

[PATCH v3 01/10] hw/arm/virt-acpi-build:Remove dead assignment in build_madt()

Clang static code analyzer show warning: hw/arm/virt-acpi-build.c:641:5: warning: Value stored to 'madt' is never read madt = acpi_data_push(table_data, sizeof *madt); ^ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Igor

[PATCH v3 00/10] trivial patchs for static code analyzer fixes

Since v2: - Patch1: Addressed Li Qiang review comment. - Patch2: Addressed Peter Maydell and Li Qiang review comment. - Patch3：Delete memleak commit message, and Addressed Peter Maydell review comment. - Patch4: Addressed Peter Maydell review comment. - Patch6: Addressed Li Qiang review comment.

[PATCH v3 03/10] target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli()

Clang static code analyzer show warning: target/arm/translate-a64.c:8635:14: warning: Value stored to 'tcg_rn' during its initialization is never read TCGv_i64 tcg_rn = new_tmp_a64(s); ^~ ~~ target/arm/translate-a64.c:8636:14: warning: Value stored to 'tcg_rd'

Re: [PATCH 64/77] target/microblaze: Convert mbar to decodetree

On 8/27/20 3:08 AM, Edgar E. Iglesias wrote: >> Ok. I assume this follows a write to something like an interrupt controller >> register? > > yes, kind of. It's a memory store to a device that raises an interrupt as a > result of that store. The interrupt propagates to the CPU and on real HW if >

Re: [PATCH 06/12] ui/gtk-gl-area: Plug memleak in gd_gl_area_create_context()

Pan Nengyuan 于2020年8月27日周四 下午3:06写道： > > > > On 2020/8/26 20:20, Li Qiang wrote: > > Pan Nengyuan 于2020年8月14日周五 下午6:15写道： > >> > >> Receiving error in local variable err, and forgot to free it. > >> Considering that there is no place to deal with it. Clean up. > >> > >> Reported-by: Euler Robot

Re: [PATCH 00/77] target/microblaze improvements

On 8/27/20 3:22 AM, Edgar E. Iglesias wrote: > Thanks. Here's another issue, it seems some branches are jumping > to the wrong address. > > This is a disasm from a failing case: > > 0xffd033a0: brlid r15, -636 // 0xffd03124 > 0xffd033a4: or r0, r0, r0 > >

Re: [PATCH] Deprecate lm32 port

Am 27. August 2020 13:32:59 MESZ schrieb Peter Maydell : >Deprecate our lm32 target support. Michael Walle (former lm32 >maintainer) >suggested that we do this in 2019: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg605024.html >because the only public user of the architecture is the

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

On Tue, Aug 11, 2020 at 09:43:43AM +0800, Jiajun Chen wrote: > Used_memslots is equal to dev->mem->nregions now, it is true for > vhost kernel, but not for vhost user, which uses the memory regions > that have file descriptor. In fact, not all of the memory regions > have file descriptor. > It is

  1   2   3   4   5   >