[PATCH v3 07/12] microvm: add second ioapic

Create second ioapic, route virtio-mmio IRQs to it, allow more virtio-mmio devices (24 instead of 8). Needs ACPI, enabled by default, can be turned off using -machine ioapic2=off Signed-off-by: Gerd Hoffmann --- include/hw/i386/microvm.h | 2 ++ hw/i386/microvm.c | 56

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Wed, Dec 02, 2020 at 12:01:21PM +, Daniel P. Berrangé wrote: > On Wed, Dec 02, 2020 at 06:37:46AM -0500, Michael S. Tsirkin wrote: > > On Wed, Dec 02, 2020 at 11:26:39AM +, Daniel P. Berrangé wrote: > > > On Wed, Dec 02, 2020 at 06:19:29AM -0500, Michael S. Tsirkin wrote: > > > > On

Re: [PATCH v3 01/12] [testing] disable xhci msix

On Thu, Dec 03, 2020 at 06:00:54AM -0500, Michael S. Tsirkin wrote: > On Thu, Dec 03, 2020 at 11:54:12AM +0100, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > > A bit more context on why you are doing this? Scratch the patch, I just forgot to pass in --base so git publish skips this

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Thu, Dec 03, 2020 at 06:21:47AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2020 at 12:01:21PM +, Daniel P. Berrangé wrote: > > On Wed, Dec 02, 2020 at 06:37:46AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Dec 02, 2020 at 11:26:39AM +, Daniel P. Berrangé wrote: > > > > On

Re: [PULL 0/6] pc,vhost: fixes

On Thu, 3 Dec 2020 at 11:02, Peter Maydell wrote: > > On Thu, 3 Dec 2020 at 10:59, Michael S. Tsirkin wrote: > > > > On Thu, Dec 03, 2020 at 10:20:03AM +, Peter Maydell wrote: > > > On Wed, 2 Dec 2020 at 11:03, Michael S. Tsirkin wrote: > > > > > > > > Patch 5 gave me pause but we do need

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Thu, Dec 03, 2020 at 07:01:11AM -0500, Michael S. Tsirkin wrote: > On Thu, Dec 03, 2020 at 11:45:12AM +, Daniel P. Berrangé wrote: > > On Thu, Dec 03, 2020 at 06:40:11AM -0500, Michael S. Tsirkin wrote: > > > On Thu, Dec 03, 2020 at 11:32:53AM +, Daniel P. Berrangé wrote: > > > > On

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Thu, Dec 03, 2020 at 07:11:17AM -0500, Michael S. Tsirkin wrote: > On Thu, Dec 03, 2020 at 11:43:41AM +, Dr. David Alan Gilbert wrote: > > Another way to solve this would be to remove the unplugging from the > > migration layer and leave it as a problem for the management layer to do > >

Re: help with a build-user and build-user-plugin failure

Hi all, and thanks for the help, after a lot of fiddling and applying your suggestions (and a reboot !?) now things work. The only thing I am left seeing (also on master) is with check-tcg: Remote 'g' packet reply is too long (expected 312 bytes, got 560 bytes):

[PATCH RFC v4 05/15] target/riscv: Implement kvm_arch_put_registers

Put GPR CSR and FP registers to kvm by KVM_SET_ONE_REG ioctl Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/kvm.c | 142 - 1 file changed, 141 insertions(+), 1 deletion(-) diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c

[PATCH RFC v4 15/15] target/riscv: Add time frequency migration support

If vcpu's time frequency is not specified by CPU option 'time-frequency' on the destination, the time frequency of destination will follow the source. If vcpu's time frequency specified by CPU option 'time-frequency' on the destination is different from migrated time frequency. The migration will

Re: [PATCH v3 05/10] hvf: arm: Mark CPU as dirty on reset

On Thu, Dec 03, 2020 at 11:55:17AM +0100, Alexander Graf wrote: > > On 03.12.20 02:52, Roman Bolshakov wrote: > > On Wed, Dec 02, 2020 at 08:04:03PM +0100, Alexander Graf wrote: > > > When clearing internal state of a CPU, we should also make sure that HVF > > > knows about it and can push the

Re: [PATCH v3 05/10] hvf: arm: Mark CPU as dirty on reset

On 03.12.20 14:02, Roman Bolshakov wrote: On Thu, Dec 03, 2020 at 11:55:17AM +0100, Alexander Graf wrote: On 03.12.20 02:52, Roman Bolshakov wrote: On Wed, Dec 02, 2020 at 08:04:03PM +0100, Alexander Graf wrote: When clearing internal state of a CPU, we should also make sure that HVF knows

[PATCH v3 03/12] x86: add support for second ioapic

Add ioapic_init_secondary to initialize it, wire up in gsi handling and acpi apic table creation. Signed-off-by: Gerd Hoffmann --- include/hw/i386/ioapic.h | 2 ++ include/hw/i386/ioapic_internal.h | 2 +- include/hw/i386/x86.h | 3 +++ hw/i386/acpi-common.c

[PATCH v3 10/12] tests/acpi: add ioapic2=on test for microvm

APIC table changes: [034h 0052 1]Subtable Type : 01 [I/O APIC] [035h 0053 1] Length : 0C [036h 0054 1] I/O Apic ID : 00 [037h 0055 1] Reserved : 00 [038h 0056 4] Address : FEC0

[PATCH v3 12/12] tests/acpi: disallow updates for expected data files

Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index 191ac230b013..dfb8523c8bf4 100644 ---

[Bug 1906536] Re: Unable to set SVE VL to 1024 bits or above since 7b6a2198

Are there any other examples of where linux-user tries to preserve execution environment details over an execve? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1906536 Title: Unable to set SVE VL

[PATCH RFC v4 12/15] target/riscv: Support virtual time context synchronization

Add virtual time context description to vmstate_riscv_cpu. After cpu being loaded, virtual time context is updated to KVM. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/machine.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/target/riscv/machine.c

[PATCH RFC v4 08/15] target/riscv: Handle KVM_EXIT_RISCV_SBI exit

Use char-fe to handle console sbi call, which implement early console io while apply 'earlycon=sbi' into kernel parameters. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/kvm.c | 42 - target/riscv/sbi_ecall_interface.h | 72

[PATCH v4 1/2] hw/virtio-pci Added counter for pcie capabilities offsets.

From: Andrew Removed hardcoded offset for ats. Added cap offset counter for future capabilities like AER. Signed-off-by: Andrew Melnychenko --- hw/virtio/virtio-pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index

Re: [PATCH v3 06/12] microvm: drop microvm_gsi_handler()

On Thu, Dec 03, 2020 at 11:54:17AM +0100, Gerd Hoffmann wrote: > With the improved gsi_handler() we don't need > our private version any more. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Igor Mammedov > --- > hw/i386/microvm.c | 14 +- > 1 file changed, 1 insertion(+), 13

[PATCH] readline: Fix possible array index out of bounds in readline_hist_add()

When the 'cmdline' is the last entry in 'rs->history' array, there is no need to put this entry to the end of the array, partly because it is the last entry, and partly because the next operition will lead to array index out of bounds. Reported-by: Euler Robot Signed-off-by: Alex Chen ---

Re: [PATCH v2 1/1] security-process: update process information

On Thu, Dec 03, 2020 at 07:59:02PM +0530, P J P wrote: > From: Prasad J Pandit > > We are about to introduce a qemu-security mailing list to report > and triage QEMU security issues. > > Update the security process web page with new mailing list address > and triage details. > > Signed-off-by:

Re: [PATCH v2 2/4] hw/scsi/megasas: Assert cdb_len is valid in megasas_handle_scsi()

Philippe Mathieu-Daudé 于2020年12月2日周三 上午3:13写道： > > cdb_len can not be zero... (or less than 6) here, else we have a > out-of-bound read first in scsi_cdb_length(): > > 71 int scsi_cdb_length(uint8_t *buf) > 72 { > 73 int cdb_len; > 74 > 75 switch (buf[0] >> 5) { Hi Philippe, Here I

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Thu, Dec 03, 2020 at 06:40:11AM -0500, Michael S. Tsirkin wrote: > On Thu, Dec 03, 2020 at 11:32:53AM +, Daniel P. Berrangé wrote: > > On Thu, Dec 03, 2020 at 06:21:47AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Dec 02, 2020 at 12:01:21PM +, Daniel P. Berrangé wrote: > > > > On

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, Dec 03, 2020 at 11:43:41AM +, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Thu, Dec 03, 2020 at 11:32:53AM +, Daniel P. Berrangé wrote: > > > > On Thu, Dec 03, 2020 at 06:21:47AM -0500,

Re: [PATCH v2 2/4] hw/scsi/megasas: Assert cdb_len is valid in megasas_handle_scsi()

On 12/3/20 1:02 PM, Li Qiang wrote: > Philippe Mathieu-Daudé 于2020年12月3日周四 下午7:37写道： >> >> Hi Li, >> >> On 12/3/20 12:21 PM, Li Qiang wrote: >>> Philippe Mathieu-Daudé 于2020年12月2日周三 上午3:13写道： cdb_len can not be zero... (or less than 6) here, else we have a out-of-bound read first

[PATCH RFC v4 03/15] target/riscv: Implement function kvm_arch_init_vcpu

Get isa info from kvm while kvm init. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/kvm.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c index 8c386d9acf..86660ba81b 100644 ---

[PATCH RFC v4 09/15] target/riscv: Add host cpu type

Currently, host cpu is inherited simply. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/cpu.c | 6 ++ target/riscv/cpu.h | 1 + 2 files changed, 7 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index faee98a58c..439dc89ee7 100644 ---

Ping: [PATCH v2 0/2] bugfix: Decrease dirty bitmap blocks after we remove ramblock

Hi folks, kindly ping ... This bugfix can save several MBs memory, waiting for review, thanks. Keqian. On 2020/11/30 21:11, Keqian Zhu wrote: > Keqian Zhu (2): > ramlist: Make dirty bitmap blocks of ramlist resizable > ramlist: Resize dirty bitmap blocks after remove ramblock > >

[PATCH v3 02/12] x86: rewrite gsi_handler()

Rewrite function to use switch() for IRQ number mapping. Check i8259_irq exists before raising it so the function also works in case no i8259 (aka pic) is present. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov --- hw/i386/x86.c | 14 ++ 1 file changed, 10 insertions(+), 4

[PATCH 8/9] vnc: add support for extended desktop resize

The extended desktop resize encoding adds support for (a) clients sending resize requests to the server, and (b) multihead support. This patch implements (a). All resize requests are rejected by qemu. Qemu can't resize the framebuffer on its own, this is in the hands of the guest, so all qemu

Re: [PULL 0/6] pc,vhost: fixes

On Thu, Dec 03, 2020 at 10:20:03AM +, Peter Maydell wrote: > On Wed, 2 Dec 2020 at 11:03, Michael S. Tsirkin wrote: > > > > Patch 5 gave me pause but we do need patch 6 as > > it's a guest triggerable assert, and it seemed > > cleaner to just take the whole patchset than cherry-pick. > > Is

Re: [PATCH 8/9] vnc: add support for extended desktop resize

On Thu, Dec 03, 2020 at 12:08:04PM +0100, Gerd Hoffmann wrote: > The extended desktop resize encoding adds support for (a) clients > sending resize requests to the server, and (b) multihead support. > > This patch implements (a). All resize requests are rejected by qemu. > Qemu can't resize the

[PATCH RFC v4 11/15] target/riscv: Implement virtual time adjusting with vm state changing

We hope that virtual time adjusts with vm state changing. When a vm is stopped, guest virtual time should stop counting and kvm_timer should be stopped. When the vm is resumed, guest virtual time should continue to count and kvm_timer should be restored. Signed-off-by: Yifei Jiang Signed-off-by:

[PATCH RFC v4 00/15] Add riscv kvm accel support

This series adds both riscv32 and riscv64 kvm support, and implements migration based on riscv. It is based on temporarily unaccepted kvm: https://github.com/kvm-riscv/linux (lastest version v15). This series depends on above pending changes which haven't yet been accepted, so this QEMU patch

[PATCH RFC v4 04/15] target/riscv: Implement kvm_arch_get_registers

Get GPR CSR and FP registers from kvm by KVM_GET_ONE_REG ioctl. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/kvm.c | 150 - 1 file changed, 149 insertions(+), 1 deletion(-) diff --git a/target/riscv/kvm.c

Re: [PATCH] hw/block: m25p80: Implement AAI-WP command support for SST flashes

Hello Bin, On [2020 Dec 02] Wed 22:30:37, Bin Meng wrote: > From: Xuzhou Cheng > > Auto Address Increment (AAI) Word-Program is a special command of > SST flashes. AAI-WP allows multiple bytes of data to be programmed > without re-issuing the next sequential address location. > >

[PATCH v4 0/2] hw/virtio-pci: AER capability

Main motivation: According to Microsoft driver\device certification requirements for next version of Window Server, PCIe device must support AER. "Windows Server PCI Express devices are required to support Advanced Error Reporting [AER] as defined in PCI Express Base Specification version 2.1."

Re: [PATCH v3 04/12] microvm: make number of virtio transports runtime changeable

On Thu, Dec 03, 2020 at 11:54:15AM +0100, Gerd Hoffmann wrote: > This will allow to increase the number of transports in > case we have enough irq lines available for them all. > > Signed-off-by: Gerd Hoffmann > --- > include/hw/i386/microvm.h | 2 +- > hw/i386/microvm.c | 9 +++-- >

[PATCH v2 1/1] security-process: update process information

From: Prasad J Pandit We are about to introduce a qemu-security mailing list to report and triage QEMU security issues. Update the security process web page with new mailing list address and triage details. Signed-off-by: Prasad J Pandit --- contribute/security-process.md | 154

[PATCH v3 11/12] tests/acpi: update expected data files

Signed-off-by: Gerd Hoffmann --- tests/data/acpi/microvm/APIC.ioapic2 | Bin 70 -> 82 bytes tests/data/acpi/microvm/DSDT.ioapic2 | Bin 365 -> 365 bytes 2 files changed, 0 insertions(+), 0 deletions(-) diff --git a/tests/data/acpi/microvm/APIC.ioapic2 b/tests/data/acpi/microvm/APIC.ioapic2

[PATCH v3 08/12] tests/acpi: allow updates for expected data files

Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8bf4..191ac230b013 100644 ---

[PATCH 2/9] console: add check for ui_info pointer

Verify the hw_ops->ui_info function pointer is non-zero before calling it. Can be triggered by qxl which changes hw_ops when switching between qxl-native and vga-compat modes. Signed-off-by: Gerd Hoffmann --- ui/console.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 3/9] vnc: use enum for features

Use an enum for the vnc feature bits. That way they are enumerated automatically and we don't have to do that manually when adding or removing features. Signed-off-by: Gerd Hoffmann --- ui/vnc.h | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git

Re: [PATCH v2 2/4] hw/scsi/megasas: Assert cdb_len is valid in megasas_handle_scsi()

Hi Li, On 12/3/20 12:21 PM, Li Qiang wrote: > Philippe Mathieu-Daudé 于2020年12月2日周三 上午3:13写道： >> >> cdb_len can not be zero... (or less than 6) here, else we have a >> out-of-bound read first in scsi_cdb_length(): >> >> 71 int scsi_cdb_length(uint8_t *buf) >> 72 { >> 73 int cdb_len; >> 74

Re: [PATCH v2 00/28] target/arm: Implement v8.1M and Cortex-M55

On Thu, 19 Nov 2020 at 21:56, Peter Maydell wrote: > > This is a v2 because it's a respin of "target/arm: More v8.1M > features". The bad news is it's nearly doubled in length. The good > news is that this is because the new patches on the end are enough to > implement all the remaining missing

[PATCH RFC v4 01/15] linux-header: Update linux/kvm.h

Update linux-headers/linux/kvm.h from https://github.com/avpatel/linux/tree/riscv_kvm_v15. Only use this header file, so here do not update all linux headers by update-linux-headers.sh before above KVM series is accepted. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin ---

[PATCH RFC v4 14/15] target/riscv: Synchronize vcpu's frequency with KVM

If vcpu's frequency is specified by cpu option 'frequency', it will be set into KVM by KVM_SET_ONE_REG ioctl. Otherwise, vcpu's frequency will follow KVM by KVM_GET_ONE_REG ioctl. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/kvm.c | 17 + 1 file

[PATCH RFC v4 07/15] hw/riscv: PLIC update external interrupt by KVM when kvm enabled

Only support supervisor external interrupt currently. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- hw/intc/sifive_plic.c| 31 ++- target/riscv/kvm.c | 19 +++ target/riscv/kvm_riscv.h | 1 + 3 files changed, 42 insertions(+), 9

Re: [PATCH 0/5] SCSI: fix transfer limits for SCSI passthrough

On 03/12/20 13:49, Maxim Levitsky wrote: On Wed, 2020-11-04 at 19:32 +0200, Maxim Levitsky wrote: This patch series attempts to provide a solution to the problem of the transfer limits of the raw file driver (host_device/file-posix), some of which I already tried to fix in the past. I included

Re: [PATCH v3 03/12] x86: add support for second ioapic

On Thu, Dec 03, 2020 at 11:54:14AM +0100, Gerd Hoffmann wrote: > Add ioapic_init_secondary to initialize it, wire up > in gsi handling and acpi apic table creation. > > Signed-off-by: Gerd Hoffmann > --- > include/hw/i386/ioapic.h | 2 ++ > include/hw/i386/ioapic_internal.h | 2 +- >

Re: [PATCH for-5.2 05/10] vhost-user-blk-test: close fork child file descriptors

On Tue, Nov 24, 2020 at 08:08:26PM +0800, Coiby Xu wrote: > Hi Stefan, > > On Wed, Nov 11, 2020 at 12:43:26PM +, Stefan Hajnoczi wrote: > > Do not leave stdin and stdout open after fork. stdout is the > > tap-driver.pl pipe. If we keep the pipe open then tap-driver.pl will not > > detect that

[PATCH v2 0/1] security-process: update with mailing list details

From: Prasad J Pandit Hello, * After upstream discussions and considering various options like LaunchPad bugs, GitLab issues etc. -> https://lists.nongnu.org/archive/html/qemu-devel/2020-09/msg04266.html -> https://lists.nongnu.org/archive/html/qemu-devel/2020-10/msg00059.html We are

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

On Thu, Dec 03, 2020 at 07:46:29AM +0100, Gerd Hoffmann wrote: > Hi, > > > It would be much nicer to do the wrapper the other way round, i.e. > > setting properties before the device is realized would update a > > configuration struct and realize would then call .create() with that > > struct.

[PATCH v3 04/12] microvm: make number of virtio transports runtime changeable

This will allow to increase the number of transports in case we have enough irq lines available for them all. Signed-off-by: Gerd Hoffmann --- include/hw/i386/microvm.h | 2 +- hw/i386/microvm.c | 9 +++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git

[PATCH v3 01/12] [testing] disable xhci msix

Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-xhci-pci.c b/hw/usb/hcd-xhci-pci.c index bba628d3d230..5def3ea55ff3 100644 --- a/hw/usb/hcd-xhci-pci.c +++ b/hw/usb/hcd-xhci-pci.c @@ -239,7 +239,7 @@ static void

[PATCH v3 00/12] microvm: add second ioapic

Add a second ioapic to microvm. Gives us more IRQ lines we can use for virtio-mmio devices. Bump number of possible virtio-mmio devices from 8 to 24. v3: - pick up some review tags. - replace magic numbers with #defines. - add asl changes to commit messages. v2: - reorganize code a bit. -

[PATCH v3 09/12] tests/acpi: add data files for ioapic2 test variant

Copy microvm/APIC -> microvm/APIC.ioapic2 Copy microvm/DSDT -> microvm/DSDT.ioapic2 Signed-off-by: Gerd Hoffmann --- tests/data/acpi/microvm/APIC.ioapic2 | Bin 0 -> 70 bytes tests/data/acpi/microvm/DSDT.ioapic2 | Bin 0 -> 365 bytes 2 files changed, 0 insertions(+), 0 deletions(-) create mode

Re: [PATCH v3 05/10] hvf: arm: Mark CPU as dirty on reset

On 03.12.20 02:52, Roman Bolshakov wrote: On Wed, Dec 02, 2020 at 08:04:03PM +0100, Alexander Graf wrote: When clearing internal state of a CPU, we should also make sure that HVF knows about it and can push the new values down to vcpu state. I'm sorry if I'm asking something dumb. But isn't

[PATCH 0/9] vnc: support some new extensions.

The rfb standard keeps envolving. While the official spec is kind of frozen since a decade or so the community maintains an updated version of the spec at: https://github.com/rfbproto/rfbproto/ This series adds support for two new extensions from that spec: alpha cursor and extended

[PATCH 1/9] console: allow con==NULL in dpy_set_ui_info

Use active_console in that case like we do in many other places. Signed-off-by: Gerd Hoffmann --- ui/console.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/console.c b/ui/console.c index 53dee8e26b17..16b326854080 100644 --- a/ui/console.c +++ b/ui/console.c @@

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Thu, Dec 03, 2020 at 11:43:41AM +, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Thu, Dec 03, 2020 at 11:32:53AM +, Daniel P. Berrangé wrote: > > > On Thu, Dec 03, 2020 at 06:21:47AM -0500, Michael S. Tsirkin wrote: > > > > On Wed, Dec 02, 2020 at

Re: [PATCH v2 2/4] hw/scsi/megasas: Assert cdb_len is valid in megasas_handle_scsi()

Philippe Mathieu-Daudé 于2020年12月3日周四 下午7:37写道： > > Hi Li, > > On 12/3/20 12:21 PM, Li Qiang wrote: > > Philippe Mathieu-Daudé 于2020年12月2日周三 上午3:13写道： > >> > >> cdb_len can not be zero... (or less than 6) here, else we have a > >> out-of-bound read first in scsi_cdb_length(): > >> > >> 71 int

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Thu, Dec 03, 2020 at 12:06:14PM +, Daniel P. Berrangé wrote: > > > It isn't really about the admin. It is about countless existing mgmt apps > > > that expect migration will always succeed if the VM is paused. The mgmt > > > apps triggering the migraiton is not neccessarily the same as

[PATCH RFC v4 10/15] target/riscv: Add kvm_riscv_get/put_regs_timer

Add kvm_riscv_get/put_regs_timer to synchronize virtual time context from KVM. To set register of RISCV_TIMER_REG(state) will occur a error from KVM on kvm_timer_state == 0. It's better to adapt in KVM, but it doesn't matter that adaping in QEMU. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng

Re: [PATCH 0/5] SCSI: fix transfer limits for SCSI passthrough

On Wed, 2020-11-04 at 19:32 +0200, Maxim Levitsky wrote: > This patch series attempts to provide a solution to the problem of the > transfer > limits of the raw file driver (host_device/file-posix), some of which I > already tried to fix in the past. > > I included 2 patches from Tom Yan which

Re: [PATCH v2 0/4] vhost-user: avoid g_return_val_if() in get/set_config()

On Wed, Dec 02, 2020 at 03:26:07PM +, Stefan Hajnoczi wrote: v2: * Print errors [Marc-André] Markus Armbruster pointed out that g_return_val_if() is meant for programming errors. It must not be used for input validation since it can be compiled out. Use explicit if statements instead.

Re: [PATCH] fuzz: avoid double-fetches by default

On Wednesday, 2020-12-02 at 11:42:14 -05, Alexander Bulekov wrote: > The generic fuzzer can find double-fetch bugs. However: > * We currently have no good way of producing qemu-system reproducers for > double-fetch bugs. Even if we can get developers to run the binary-blob > reproducers with

Re: [PATCH v3 07/12] microvm: add second ioapic

On Thu, Dec 03, 2020 at 11:54:18AM +0100, Gerd Hoffmann wrote: > Create second ioapic, route virtio-mmio IRQs to it, > allow more virtio-mmio devices (24 instead of 8). > > Needs ACPI, enabled by default, can be turned off > using -machine ioapic2=off > > Signed-off-by: Gerd Hoffmann > --- >

[PATCH 5/9] vnc: add pseudo encodings

Add #defines for two new pseudo encodings: * cursor with alpha channel. * extended desktop resize. Signed-off-by: Gerd Hoffmann --- ui/vnc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/vnc.h b/ui/vnc.h index a7fd38a82075..6f5006da3593 100644 --- a/ui/vnc.h +++ b/ui/vnc.h @@

[PATCH 9/9] qxl: add ui_info callback

This makes qxl respond to user interface window resizes when not using spice, so it works with gtk and vnc too. Signed-off-by: Gerd Hoffmann --- hw/display/qxl.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Thu, Dec 03, 2020 at 11:32:53AM +, Daniel P. Berrangé wrote: > On Thu, Dec 03, 2020 at 06:21:47AM -0500, Michael S. Tsirkin wrote: > > On Wed, Dec 02, 2020 at 12:01:21PM +, Daniel P. Berrangé wrote: > > > On Wed, Dec 02, 2020 at 06:37:46AM -0500, Michael S. Tsirkin wrote: > > > > On

[Bug 1903752] Re: qemu-system-avr error: qemu-system-avr: execution left flash memory

I can not reproduce. ** Tags added: avr ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1903752 Title: qemu-system-avr error: qemu-system-avr:

Re: [PATCH v3 06/10] hvf: Add Apple Silicon support

On 03.12.20 06:21, Roman Bolshakov wrote: On Wed, Dec 02, 2020 at 08:04:04PM +0100, Alexander Graf wrote: With Apple Silicon available to the masses, it's a good time to add support for driving its virtualization extensions from QEMU. This patch adds all necessary architecture specific code

[PATCH v3 05/12] microvm: make pcie irq base runtime changeable

Allows to move them in case we have enough irq lines available. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov --- include/hw/i386/microvm.h | 2 +- hw/i386/microvm.c | 11 ++- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/include/hw/i386/microvm.h

Re: [PATCH v3 00/12] microvm: add second ioapic

On Thu, Dec 03, 2020 at 11:54:11AM +0100, Gerd Hoffmann wrote: > Add a second ioapic to microvm. Gives us more IRQ lines we can > use for virtio-mmio devices. Bump number of possible virtio-mmio > devices from 8 to 24. acpi things all look ok: Reviewed-by: Michael S. Tsirkin > v3: > -

Re: [PULL 0/6] pc,vhost: fixes

On Thu, 3 Dec 2020 at 10:59, Michael S. Tsirkin wrote: > > On Thu, Dec 03, 2020 at 10:20:03AM +, Peter Maydell wrote: > > On Wed, 2 Dec 2020 at 11:03, Michael S. Tsirkin wrote: > > > > > > Patch 5 gave me pause but we do need patch 6 as > > > it's a guest triggerable assert, and it seemed >

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

On 02/12/20 18:35, Kevin Wolf wrote: Could we have an intermediate state that doesn't require any duplication and thus have no separate code paths that could diverge? The one requirement we have for an intermediate state is that it supports both interfaces: The well-know create/set

[PATCH 4/9] vnc: drop unused copyrect feature

vnc stopped using the copyrect pseudo encoding in 2017, in commit 50628d3479e4 ("cirrus/vnc: zap bitblit support from console code.") So we can drop the now unused copyrect feature bit. Signed-off-by: Gerd Hoffmann --- ui/vnc.h | 2 -- ui/vnc.c | 3 --- 2 files changed, 5 deletions(-) diff

Re: [PATCH 1/2] nvme: updated shared header for copy command

On Tue, Nov 24, 2020 at 08:14:17AM +0100, Klaus Jensen wrote: > From: Klaus Jensen > > Add new data structures and types for the Simple Copy command. > > Signed-off-by: Klaus Jensen > Cc: Stefan Hajnoczi > Cc: Fam Zheng > --- > include/block/nvme.h | 45

[Bug 1906536] Re: Unable to set SVE VL to 1024 bits or above since 7b6a2198

I don't think we currently do have anything else we try to preserve over execve-to-maybe-another-QEMU-emulated-process, no. The other approach of "provide a config knob equivalent to /proc/sys/abi/sve_default_vector_length" is probably simpler. -- You received this bug notification because you

Re: [PATCH v2 2/4] contrib/vhost-user-gpu: avoid g_return_val_if() input validation

On Thu, Dec 03, 2020 at 02:26:08PM +0400, Marc-André Lureau wrote: > On Thu, Dec 3, 2020 at 1:52 PM Stefan Hajnoczi wrote: > > > On Wed, Dec 02, 2020 at 07:50:51PM +0400, Marc-André Lureau wrote: > > > On Wed, Dec 2, 2020 at 7:27 PM Stefan Hajnoczi > > wrote: > > > > > > > Do not validate input

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, Dec 03, 2020 at 11:32:53AM +, Daniel P. Berrangé wrote: > > On Thu, Dec 03, 2020 at 06:21:47AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Dec 02, 2020 at 12:01:21PM +, Daniel P. Berrangé wrote: > > > > On Wed, Dec 02, 2020 at

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Thu, Dec 03, 2020 at 11:45:12AM +, Daniel P. Berrangé wrote: > On Thu, Dec 03, 2020 at 06:40:11AM -0500, Michael S. Tsirkin wrote: > > On Thu, Dec 03, 2020 at 11:32:53AM +, Daniel P. Berrangé wrote: > > > On Thu, Dec 03, 2020 at 06:21:47AM -0500, Michael S. Tsirkin wrote: > > > > On

Re: [PATCH for-6.0 00/11] target/arm: enforce alignment

Cc'ing Pavel On 12/1/20 4:55 PM, Peter Maydell wrote: > On Wed, 25 Nov 2020 at 04:06, Richard Henderson > wrote: >> >> As reported in https://bugs.launchpad.net/bugs/1905356 >> >> Not implementing SCTLR.A, but all of the other required >> alignment for SCTLR.A=0 in Table A3-1. > > Something in

Re: [PATCH v13 08/10] copy-on-read: skip non-guest reads if no copy needed

02.12.2020 21:30, Andrey Shinkevich wrote: If the flag BDRV_REQ_PREFETCH was set, skip idling read/write operations in COR-driver. It can be taken into account for the COR-algorithms optimization. That check is being made during the block stream job by the moment. Add the BDRV_REQ_PREFETCH flag

[PATCH RFC v4 13/15] target/riscv: Introduce dynamic time frequency for virt machine

Currently, time base frequency was fixed as SIFIVE_CLINT_TIMEBASE_FREQ. Here introduce "time-frequency" property to set time base frequency dynamically of which default value is still SIFIVE_CLINT_TIMEBASE_FREQ. The virt machine uses frequency of the first cpu to create clint and fdt.

[PATCH RFC v4 06/15] target/riscv: Support start kernel directly by KVM

Get kernel and fdt start address in virt.c, and pass them to KVM when cpu reset. In addition, add kvm_riscv.h to place riscv specific interface. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- hw/riscv/virt.c | 8 target/riscv/cpu.c | 4

[PATCH v4 2/2] hw/virtio-pci Added AER capability.

From: Andrew Added AER capability for virtio-pci devices. Also added property for devices, by default AER is disabled. Signed-off-by: Andrew Melnychenko --- hw/virtio/virtio-pci.c | 16 hw/virtio/virtio-pci.h | 4 2 files changed, 20 insertions(+) diff --git

RE: [PATCH v14 4/4] arm: xlnx-versal: Connect usb to virt-versal

Hi Peter/Edgar, > -Original Message- > From: Edgar E. Iglesias > Sent: Thursday, December 3, 2020 11:35 PM > To: Peter Maydell > Cc: Sai Pavan Boddu ; Markus Armbruster > ; Marc-André Lureau ; > Paolo Bonzini ; Gerd Hoffmann ; > Edgar Iglesias ; Francisco Eduardo Iglesias > ; Alistair

[PATCH v15 0/4] Add Versal usb model

This patch series adds dwc3 usb controller to versal SOC. Changes for V2: Make XHCIState non-qom Use container_of functions for retriving pci device instance Initialize the AddressSpace pointer in PATCH 1/3 itself Changes for V3: Convert XHCIState to TYPE_DEVICE and register as a

Re: [PATCH 2/8] hvf: Move common code out

On 03.12.20 19:42, Peter Collingbourne wrote: On Thu, Dec 3, 2020 at 1:41 AM Roman Bolshakov wrote: On Mon, Nov 30, 2020 at 04:00:11PM -0800, Peter Collingbourne wrote: On Mon, Nov 30, 2020 at 3:18 PM Alexander Graf wrote: On 01.12.20 00:01, Peter Collingbourne wrote: On Mon, Nov 30,

[PATCH v15 4/4] arm: xlnx-versal: Connect usb to virt-versal

From: Vikram Garhwal Connect VersalUsb2 subsystem to xlnx-versal SOC, its placed in iou of lpd domain and configure it as dual port host controller. Add the respective guest dts nodes for "xlnx-versal-virt" machine. Signed-off-by: Vikram Garhwal Signed-off-by: Sai Pavan Boddu Reviewed-by:

[PATCH v15 1/4] usb: Add versal-usb2-ctrl-regs module

This module emulates control registers of versal usb2 controller, this is added just to make guest happy. In general this module would control the phy-reset signal from usb controller, data coherency of the transactions, signals the host system errors received from controller. Signed-off-by: Sai

Re: [PATCH v4 2/2] hw/virtio-pci Added AER capability.

On Thu, Dec 03, 2020 at 03:25:17PM +0200, Andrew Melnychenko wrote: > From: Andrew > > Added AER capability for virtio-pci devices. > Also added property for devices, by default AER is disabled. > > Signed-off-by: Andrew Melnychenko > --- > hw/virtio/virtio-pci.c | 16 >

Re: [PATCH for-6.0 v2 2/3] spapr/xive: Fix size of END table and number of claimed IPIs

On Thu, 3 Dec 2020 10:51:10 +0100 Cédric Le Goater wrote: > On 11/30/20 7:07 PM, Cédric Le Goater wrote: > > On 11/30/20 5:52 PM, Greg Kurz wrote: > >> The sPAPR XIVE device has an internal ENDT table the size of > >> which is configurable by the machine. This table is supposed > >> to contain

[PATCH v3 06/12] microvm: drop microvm_gsi_handler()

With the improved gsi_handler() we don't need our private version any more. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov --- hw/i386/microvm.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c index

Re: [PATCH v3 01/12] [testing] disable xhci msix

On Thu, Dec 03, 2020 at 11:54:12AM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann A bit more context on why you are doing this? > --- > hw/usb/hcd-xhci-pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/usb/hcd-xhci-pci.c b/hw/usb/hcd-xhci-pci.c >

[PATCH 6/9] vnc: add alpha cursor support

There is a new vnc extension for cursors with an alpha channel. Use it if supported by the vnc client, prefer it over the "rich cursor" extension which supports only a bitmask for transparency. This is a visible improvement especially on modern desktops which actually use the alpha channel when

[PATCH 7/9] vnc: force initial resize message

The vnc server should send desktop resize notifications unconditionally on a new client connect, for feature negotiation reasons. Add a bool flag to vnc_desktop_resize() to force sending the message even in case there is no size change. Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 9 +

  1   2   3   >