Re: [RFC PATCH] ci: ensure that all jobs use a shallow clone

2021-01-08 Thread Daniel P . Berrangé
On Thu, Jan 07, 2021 at 08:23:49PM +0100, Paolo Bonzini wrote: > Il gio 7 gen 2021, 20:05 Thomas Huth ha scritto: > > > on travis-ci.com you can > > only get free CI minutes for non-sponsored FOSS projects. > > So let's simply not worry about Travis-CI anymore. > > > > Maybe we could rather

Re: [PULL 00/47] tcg patch queue

2021-01-08 Thread Peter Maydell
On Thu, 7 Jan 2021 at 20:14, Richard Henderson wrote: > > The following changes since commit 470dd6bd360782f5137f7e3376af6a44658eb1d3: > > Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-060121-4' > into staging (2021-01-06 22:18:36 +) > > are available in the Git

Re: [PATCH 4/4] block: introduce BDRV_MAX_LENGTH

2021-01-08 Thread Vladimir Sementsov-Ogievskiy
07.01.2021 12:58, Richard W.M. Jones wrote: On Fri, Dec 04, 2020 at 01:27:13AM +0300, Vladimir Sementsov-Ogievskiy wrote: Finally to be safe with calculations, to not calculate different maximums for different nodes (depending on cluster size and request_alignment), let's simply set

Re: [RFC PATCH] ci: ensure that all jobs use a shallow clone

2021-01-08 Thread Thomas Huth
On 08/01/2021 11.16, Daniel P. Berrangé wrote: IOW, despite travis giving us non-x86 builders, it is doomed to be unusuable, unless we can convince them to give us a *massively* larger free credit allowance on the qemu account. I think convincing them to do this will be very hard. I've tried

Re: [PATCH] hw/virtio-pci: Replace error_report() by qemu_log_mask(GUEST_ERROR)

2021-01-08 Thread Stefano Garzarella
On Thu, Dec 10, 2020 at 06:28:34PM +0100, Philippe Mathieu-Daudé wrote: Replace I/O write error reported with error_report() by qemu_log_mask(GUEST_ERROR) which allow filtering. Signed-off-by: Philippe Mathieu-Daudé --- hw/virtio/virtio-pci.c | 6 -- 1 file changed, 4 insertions(+), 2

[RFC PATCH] Makefile: add GNU global tags support

2021-01-08 Thread Alex Bennée
GNU Global is another tags engine which is more like cscope in being able to support finding both references and definitions. You will be un-surprised to know it also integrates well with Emacs. The main benefit of integrating it into find-src-path is it takes less time to rebuild the database

Re: [PATCH 2/3] hw/misc/pvpanic: add PCI interface support

2021-01-08 Thread Peter Maydell
On Fri, 18 Dec 2020 at 13:36, Mihai Carabas wrote: > > Add PCI interface support for PVPANIC device. Create a new file pvpanic-pci.c > where the PCI specific routines reside and update the build system with the > new > files and config structure. > > Signed-off-by: Mihai Carabas > --- >

Re: [PATCH v4 1/3] target/arm: Implement an IMPDEF pauth algorithm

2021-01-08 Thread Peter Maydell
On Wed, 16 Dec 2020 at 22:12, Richard Henderson wrote: > > Without hardware acceleration, a cryptographically strong > algorithm is too expensive for pauth_computepac. > > Even with hardware accel, we are not currently expecting > to link the linux-user binaries to any crypto libraries, > and

Re: [PATCH v1] s390x/tcg: Fix RISBHG

2021-01-08 Thread David Hildenbrand
On 08.01.21 10:44, David Hildenbrand wrote: > On 08.01.21 03:20, Nick Desaulniers wrote: >> On Thu, Jan 7, 2021 at 3:27 PM David Hildenbrand wrote: >>> >>> Am 08.01.2021 um 00:21 schrieb Nick Desaulniers : On Thu, Jan 7, 2021 at 3:13 PM David Hildenbrand wrote: > > RISBHG

[Bug 1910723] [NEW] NULL pointer dereference issues in am53c974 SCSI host bus adapter

2021-01-08 Thread Mauro Matteo Cascella
Public bug reported: Two NULL pointer dereference issues were found in the am53c974 SCSI host bus adapter emulation of QEMU. They could occur while handling the 'Information Transfer' command (CMD_TI) in function handle_ti() in hw/scsi/esp.c, and could be abused by a malicious guest to crash the

Re: [PATCH v1] s390x/tcg: Fix RISBHG

2021-01-08 Thread David Hildenbrand
On 08.01.21 11:19, David Hildenbrand wrote: > On 08.01.21 10:44, David Hildenbrand wrote: >> On 08.01.21 03:20, Nick Desaulniers wrote: >>> On Thu, Jan 7, 2021 at 3:27 PM David Hildenbrand >>> wrote: > Am 08.01.2021 um 00:21 schrieb Nick Desaulniers : > > On Thu, Jan 7,

Re: [PULL 00/66] MIPS patches for 2021-01-07

2021-01-08 Thread Peter Maydell
On Fri, 8 Jan 2021 at 11:28, Philippe Mathieu-Daudé wrote: > Le ven. 8 janv. 2021 11:35, Peter Maydell a écrit : >> Looks like decodetree fails to cope with non-ASCII characters in >> its input file -- probably this depends on the host locale settings: >> I think these hosts run in the 'C'

[PATCH v2 0/4] s390x/tcg: fix booting Linux kernels compiled with clang-11 and clang-12

2021-01-08 Thread David Hildenbrand
This series fixes booting current upstream Linux kernel compiled by clang-11 and clang-12 under TCG. Decided to pull in already separatly sent patches. The last patch is not required to fix the boot issues, but related to patch #3. Latest version of the patches available at:

Re: [PATCH v4 2/3] target/arm: Add cpu properties to control pauth

2021-01-08 Thread Peter Maydell
On Wed, 16 Dec 2020 at 22:12, Richard Henderson wrote: > > The crypto overhead of emulating pauth can be significant for > some workloads. Add two boolean properties that allows the > feature to be turned off, on with the architected algorithm, > or on with an implementation defined algorithm. >

Re: [PULL 00/66] MIPS patches for 2021-01-07

2021-01-08 Thread Peter Maydell
On Thu, 7 Jan 2021 at 22:25, Philippe Mathieu-Daudé wrote: > > The following changes since commit 470dd6bd360782f5137f7e3376af6a44658eb1d3: > > Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-060121-4' > into staging (2021-01-06 22:18:36 +) > > are available in the Git

Re: [RFC PATCH] ci: ensure that all jobs use a shallow clone

2021-01-08 Thread Daniel P . Berrangé
On Fri, Jan 08, 2021 at 12:06:01PM +0100, Thomas Huth wrote: > On 08/01/2021 11.16, Daniel P. Berrangé wrote: > > > IOW, despite travis giving us non-x86 builders, it is doomed to be > > unusuable, unless we can convince them to give us a *massively* > > larger free credit allowance on the qemu

Re: [PULL 00/66] MIPS patches for 2021-01-07

2021-01-08 Thread Philippe Mathieu-Daudé
Hi Peter, Le ven. 8 janv. 2021 11:35, Peter Maydell a écrit : > On Thu, 7 Jan 2021 at 22:25, Philippe Mathieu-Daudé > wrote: > > > > The following changes since commit > 470dd6bd360782f5137f7e3376af6a44658eb1d3: > > > > Merge remote-tracking branch >

Re: What's the correct way to implement rfi and related instruction.

2021-01-08 Thread Cédric Le Goater
On 1/8/21 5:21 AM, 罗勇刚(Yonggang Luo) wrote: > > > On Fri, Jan 8, 2021 at 5:54 AM Cédric Le Goater > wrote: >> >> On 1/7/21 8:14 PM, 罗勇刚(Yonggang Luo) wrote: >> > This is the first patch,: >> > It's store MSR bits differntly for different rfi instructions: >> > [Qemu-devel]

Re: [PATCH v15 00/13] Apply COR-filter to the block-stream permanently

2021-01-08 Thread Vladimir Sementsov-Ogievskiy
05.01.2021 19:08, Max Reitz wrote: On 16.12.20 07:16, Vladimir Sementsov-Ogievskiy wrote: Hi all! Here is a new version of cor-filter in block-stream series. Main change is freezing the chain in cor-filter itself. Thanks, applied to my block branch:

Re: [PATCH] gdbstub.c uses incorrect check for active gdb in use_gdb_syscalls

2021-01-08 Thread Alex Bennée
Keith Packard writes: > When checking whether there is a live gdb connection, code shouldn't > use 'gdbserver_state.init' as that value is set when the > gdbserver_state structure is initialized in init_gdbserver_state, not > when the gdb socket has a valid connection. > > The 'handle_detach'

Re: [PATCH 4/4] block: introduce BDRV_MAX_LENGTH

2021-01-08 Thread Richard W.M. Jones
On Fri, Jan 08, 2021 at 01:51:35PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 07.01.2021 12:58, Richard W.M. Jones wrote: > >On Fri, Dec 04, 2020 at 01:27:13AM +0300, Vladimir Sementsov-Ogievskiy wrote: > >>Finally to be safe with calculations, to not calculate different > >>maximums for

Re: [PATCH 4/4] block: introduce BDRV_MAX_LENGTH

2021-01-08 Thread Daniel P . Berrangé
On Fri, Jan 08, 2021 at 02:14:30PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 07.01.2021 15:20, Richard W.M. Jones wrote: > > On Thu, Jan 07, 2021 at 10:56:12AM +, Richard W.M. Jones wrote: > > > On Thu, Jan 07, 2021 at 09:58:17AM +, Richard W.M. Jones wrote: > > > > On Fri, Dec 04, 2020

Re: [PATCH v2 0/7] Fix some memleaks caused by ptimer_init

2021-01-08 Thread Peter Maydell
On Thu, 17 Dec 2020 at 11:32, Gan Qixin wrote: > > v1->v2: > Changes suggested by Peter Maydell: > Delete the modification of unrelated whitespace. > > Gan Qixin (7): > allwinner-a10-pit: Use ptimer_free() in the finalize function to avoid > memleaks > digic-timer: Use ptimer_free()

Re: [PATCH] virtio-mmio: fix guest kernel crash with SHM regions

2021-01-08 Thread Stefano Garzarella
On Sun, Dec 20, 2020 at 05:35:39PM +0100, Laurent Vivier wrote: In the kernel, virtio_gpu_init() uses virtio_get_shm_region() since commit 6076a9711dc5 ("drm/virtio: implement blob resources: probe for host visible region") but vm_get_shm_region() unconditionally uses VIRTIO_MMIO_SHM_SEL to get

Re: [PATCH 1/3] hw/misc/pvpanic: split-out generic and bus dependent code

2021-01-08 Thread Peter Maydell
On Fri, 18 Dec 2020 at 13:36, Mihai Carabas wrote: > > To ease the PCI device addition in next patches, split the code as follows: > - generic code (read/write/setup) is being kept in pvpanic.c > - ISA dependent code moved to pvpanic-isa.c > > Also, rename: > - ISA_PVPANIC_DEVICE ->

[PATCH v2 2/4] s390x/tcg: Fix RISBHG

2021-01-08 Thread David Hildenbrand
RISBHG is broken and currently hinders clang-11 builds of upstream kernels from booting: the kernel crashes early, while decompressing the image. [...] Kernel fault: interruption code 0005 ilc:2 Kernel random base: PSW : 20018000 00017a1e R:0

[PATCH v2 1/4] s390x/tcg: Fix ALGSI

2021-01-08 Thread David Hildenbrand
Looks like something went wrong whiel touching that line. Instead of "r1" we need a new temporary. Also, we have to pass MO_TEQ, to indicate that we are working with 64-bit values. Let's revert these changes. Fixes: ff26d287bddc ("target/s390x: Improve cc computation for ADD LOGICAL")

Re: [PATCH 4/4] block: introduce BDRV_MAX_LENGTH

2021-01-08 Thread Vladimir Sementsov-Ogievskiy
07.01.2021 15:20, Richard W.M. Jones wrote: On Thu, Jan 07, 2021 at 10:56:12AM +, Richard W.M. Jones wrote: On Thu, Jan 07, 2021 at 09:58:17AM +, Richard W.M. Jones wrote: On Fri, Dec 04, 2020 at 01:27:13AM +0300, Vladimir Sementsov-Ogievskiy wrote: Finally to be safe with

Re: [PATCH 3/3] pvpanic : update pvpanic spec document

2021-01-08 Thread Peter Maydell
On Fri, 18 Dec 2020 at 13:36, Mihai Carabas wrote: > > Add pvpanic PCI device support details in docs/specs/pvpanic.txt. > > Signed-off-by: Mihai Carabas > --- > docs/specs/pvpanic.txt | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/docs/specs/pvpanic.txt

Re: [PATCH v3 0/4] hw/arm: sabrelite: Improve emulation fidelity to allow booting upstream U-Boot

2021-01-08 Thread Peter Maydell
On Wed, 6 Jan 2021 at 06:35, Bin Meng wrote: > > From: Bin Meng > > > At present the upstream U-Boot (as of today, v2021.01-rc3) does not > boot on QEMU sabrelite machine. > > This fixes several issues to improve emulation fidelity of the i.MX6 > sabrelite board. With this series, upstream

[PATCH v2 4/4] s390x/tcg: Ignore register content if b1/b2 is zero when handling EXECUTE

2021-01-08 Thread David Hildenbrand
In our EXECUTE fast path, we have to ignore the content of r0, if specified by b1 or b2. Fixes: d376f123c7de ("target/s390x: Re-implement a few EXECUTE target insns directly") Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v2 3/4] s390x/tcg: Only ignore content in r0 when specified via "b" or "x"

2021-01-08 Thread David Hildenbrand
Using get_address() with register identifiers comming from an "r" field is wrong: if the "r" field designates "r0", we don't read the content and instead assume 0 - which should only be applied when the register was specified via "b" or "x". PoP 5-11 "Operand-Address Generation": "A zero in any

Re: [PATCH v2] ui/cocoa: Fix openFile: deprecation on Big Sur

2021-01-08 Thread Peter Maydell
On Sat, 2 Jan 2021 at 15:14, Roman Bolshakov wrote: > > ui/cocoa.m:1188:44: warning: 'openFile:' is deprecated: first deprecated in > macOS 11.0 - Use -[NSWorkspace openURL:] instead. > [-Wdeprecated-declarations] > if ([[NSWorkspace sharedWorkspace] openFile: full_file_path] ==

[Bug 1910696] [NEW] Qemu fails to start with error " There is no option group 'spice'"

2021-01-08 Thread Edvinas Valatka
Public bug reported: After upgrade from 5.1.0 to 5.2.0, qemu fails on start with error: ` /usr/bin/qemu-system-x86_64 -S -name trinti -uuid f8ad2ff6-8808-4f42-8f0b-9e23acd20f84 -daemonize -cpu host -nographic -serial chardev:console -nodefaults -no-reboot -no-user-config -sandbox

Re: [PATCH v1] s390x/tcg: Fix RISBHG

2021-01-08 Thread David Hildenbrand
CROSS_COMPILE=s390x-linux-gnu- export LLVM=1 make distclean make defconfig # Make F32 initrd boot without inserting modules ./scripts/config -e CONFIG_SCSI_ISCSI_ATTRS ./scripts/config -e CONFIG_ISCSI_TCP make -j40 > /dev/null --- 3. Run it via QEMU. I boot a full Fedora 32 using the cloud-i

Re: VirtioSound device emulation implementation

2021-01-08 Thread Gerd Hoffmann
Hi, > >> Are you planning to make it an in-QEMU device or maybe a external > >> vhost-user daemon? > > > > The project page states that we need to use the QEMU audio subsystem > > for playing and capturing audio samples. > > Is this one of the QEMU internship projects? one of last years gsoc

[PATCH v2 4/4] hw/ppc: Remove unused ppcuic_init()

2021-01-08 Thread Peter Maydell
Now we've converted all the callsites to directly create the QOM UIC device themselves, the ppcuic_init() function is unused and can be removed. The enum defining PPCUIC symbolic constants can be moved to the ppc-uic.h header where it more naturally belongs. Signed-off-by: Peter Maydell

Re: pxa crashes with qemu v5.2 when executing xscale operations

2021-01-08 Thread Peter Maydell
On Mon, 21 Dec 2020 at 16:01, Guenter Roeck wrote: > Something like the following should do. > > qemu-system-arm -M z2 -kernel arch/arm/boot/zImage -no-reboot \ > -initrd rootfs-armv5.cpio \ > --append "rdinit=/sbin/init console=ttyS0" \ > -nographic -monitor null -serial stdio > >

Re: [PATCH] decodetree: Open files with encoding='utf-8'

2021-01-08 Thread Peter Maydell
On Fri, 8 Jan 2021 at 16:44, Philippe Mathieu-Daudé wrote: > > On 1/8/21 4:38 PM, Peter Maydell wrote: > > Should we also be opening the output file explicitly as > > utf-8 ? (How do we say "write to sys.stdout as utf-8" for > > the case where we're doing that?) > > I have been wondering about

[PATCH] spapr: Improve handling of memory unplug with old guests

2021-01-08 Thread Greg Kurz
Since commit 1e8b5b1aa16b ("spapr: Allow memory unplug to always succeed") trying to unplug memory from a guest that doesn't support it (eg. rhel6) no longer generates an error like it used to. Instead, it leaves the memory around : only a subsequent reboot or manual use of drmgr within the guest

[PATCH v3 4/6] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2021-01-08 Thread Leif Lindholm
Signed-off-by: Leif Lindholm --- target/arm/cpu.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 063228de2a..18c1cb02bb 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -1736,6 +1736,37 @@ FIELD(V7M_FPCCR,

[PATCH v3 3/6] target/arm: make ARMCPU.ctr 64-bit

2021-01-08 Thread Leif Lindholm
When FEAT_MTE is implemented, the AArch64 view of CTR_EL0 adds the TminLine field in bits [37:32]. Extend the ctr field to be able to hold this context. Signed-off-by: Leif Lindholm --- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/cpu.h

Re: [PATCH v2 0/4] s390x/tcg: fix booting Linux kernels compiled with clang-11 and clang-12

2021-01-08 Thread Nick Desaulniers via
On Fri, Jan 8, 2021 at 5:21 AM David Hildenbrand wrote: > > This series fixes booting current upstream Linux kernel compiled by > clang-11 and clang-12 under TCG. > > Decided to pull in already separatly sent patches. The last patch is > not required to fix the boot issues, but related to patch

[PATCH v5 5/6] hw/misc: Add QTest for NPCM7XX PWM Module

2021-01-08 Thread Hao Wu via
We add a qtest for the PWM in the previous patch. It proves it works as expected. Reviewed-by: Havard Skinnemoen Reviewed-by: Tyrone Ting Signed-off-by: Hao Wu Reviewed-by: Peter Maydell --- tests/qtest/meson.build| 1 + tests/qtest/npcm7xx_pwm-test.c | 490

[PATCH] kvm: mirror "-machine dirty_gfn_count" to the accelerator property

2021-01-08 Thread huangy81
QEMU enable the dirty ring feature by specifing the "-accel" sub-parameter. https://lore.kernel.org/qemu-devel/20210108165050.406906-10-pet...@redhat.com/ Libvirt use "-machine accel=kvm" option to specify the accelerator by default, which is incompatible with above option. This patch introduce

Re: [PATCH v2 2/4] s390x/tcg: Fix RISBHG

2021-01-08 Thread Richard Henderson
On 1/8/21 3:20 AM, David Hildenbrand wrote: > RISBHG is broken and currently hinders clang-11 builds of upstream kernels > from booting: the kernel crashes early, while decompressing the image. > > [...] >Kernel fault: interruption code 0005 ilc:2 >Kernel random base: >

Re: [PATCH v2 4/4] s390x/tcg: Ignore register content if b1/b2 is zero when handling EXECUTE

2021-01-08 Thread Richard Henderson
On 1/8/21 3:20 AM, David Hildenbrand wrote: > In our EXECUTE fast path, we have to ignore the content of r0, if > specified by b1 or b2. > > Fixes: d376f123c7de ("target/s390x: Re-implement a few EXECUTE target insns > directly") > Signed-off-by: David Hildenbrand > --- >

Re: pxa crashes with qemu v5.2 when executing xscale operations

2021-01-08 Thread Peter Maydell
On Fri, 8 Jan 2021 at 18:56, Guenter Roeck wrote: > > On 1/8/21 9:25 AM, Peter Maydell wrote: > > On Mon, 21 Dec 2020 at 16:01, Guenter Roeck wrote: > >> Something like the following should do. > >> > >> qemu-system-arm -M z2 -kernel arch/arm/boot/zImage -no-reboot \ > >> -initrd

[PATCH v4 13/13] KVM: Dirty ring support

2021-01-08 Thread Peter Xu
KVM dirty ring is a new interface to pass over dirty bits from kernel to the userspace. Instead of using a bitmap for each memory region, the dirty ring contains an array of dirtied GPAs to fetch (in the form of offset in slots). For each vcpu there will be one dirty ring that binds to it.

[PATCH] virtio: move 'use-disabled-flag' property to hw_compat_4_2

2021-01-08 Thread Stefano Garzarella
Commit 9d7bd0826f introduced a new 'use-disabled-flag' property set to true by default. To allow the migration, we set this property to false in the hw_compat, but in the wrong place (hw_compat_4_1). Since commit 9d7bd0826f was released with QEMU 5.0, we move 'use-disabled-flag' property to

Re: [RFC PATCH] Makefile: add GNU global tags support

2021-01-08 Thread Ben Widawsky
On 21-01-08 12:19:35, Alex Bennée wrote: > GNU Global is another tags engine which is more like cscope in being > able to support finding both references and definitions. You will be > un-surprised to know it also integrates well with Emacs. > > The main benefit of integrating it into

[PATCH 0/2] lan9118: Fix RX Status FIFO PEEK value

2021-01-08 Thread Peter Maydell
This patchset fixes https://bugs.launchpad.net/bugs/1904954 : we give a bogus value for the RX Status FIFO peek register, because of a copy-and-paste error. (This bug has been present since 2009 when the device model was first added.) Patch 1 fixes the bug; patch 2 does a little bit of tidyup

[PATCH 2/2] hw/net/lan9118: Add symbolic constants for register offsets

2021-01-08 Thread Peter Maydell
The lan9118 code mostly uses symbolic constants for register offsets; the exceptions are those which the datasheet doesn't give an official symbolic name to. Add some names for the registers which don't already have them, based on the longer names they are given in the memory map. Signed-off-by:

Re: [PATCH 1/2] hw/net/lan9118: Fix RX Status FIFO PEEK value

2021-01-08 Thread Philippe Mathieu-Daudé
On 1/8/21 7:04 PM, Peter Maydell wrote: > A copy-and-paste error meant that the return value for register offset 0x44 > (the RX Status FIFO PEEK register) returned a byte from a bogus offset in > the rx status FIFO. Fix the typo. Wow, nice catch :) Reviewed-by: Philippe Mathieu-Daudé > Cc:

[Bug 1904954] Re: lan9118 bug peeked received message size not equal to actual received message size

2021-01-08 Thread Peter Maydell
This patchset should fix this bug: https://patchew.org/QEMU/20210108180401.2263-1-peter.mayd...@linaro.org/ PS: this isn't a security issue because the lan9118 is used only on board models that can't run under KVM and so it is not on QEMU's security boundary. -- You received this bug

Re: [RFC PATCH v2 00/32] CXL 2.0 Support

2021-01-08 Thread Jonathan Cameron
On Tue, 5 Jan 2021 08:52:51 -0800 Ben Widawsky wrote: > Fixes since v1 [1]: > * Defer introducing some commands/registers not yet used (Ben) > * Add stubbed device_reg_init_common() (Ben) > * Improve assertions in DVSEC creation (Jonathan) > * Use 'n' for HDM register offsets (Jonathan) > *

[Bug 1910586] Re: SD card size constraint conceptually wrong

2021-01-08 Thread -
> Indeed, we can remove this warning for block devices. Couldn't you simply remove the entire size check logic for block devices? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1910586 Title: SD

Large QEMU implementation at INE – Searching for consultants

2021-01-08 Thread Martin Zugnoni
Dear QEMU devs, I'm Martin, Director of Software at https://ine.com/. At INE we are developing a very ambisius online platform for Networking and Cyber Security interactive labs. We will be heavily using QEMU and KVM. I hate spamming this mailing list with this kind of information, but truly

[PATCH v3 6/6] target/arm: add aarch32 ID register fields to cpu.h

2021-01-08 Thread Leif Lindholm
Add entries present in ARM DDI 0487F.c (August 2020). Signed-off-by: Leif Lindholm Reviewed-by: Peter Maydell Reviewed-by: Laurent Desnogues --- target/arm/cpu.h | 28 1 file changed, 28 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index

[PATCH] tests/acceptance: Fix race conditions in s390x tests & skip fedora on gitlab-CI

2021-01-08 Thread Thomas Huth
There was a race condition in the first test where there was already the "crw" output in the dmesg, but the "0.0.4711" entry has not been created in the /sys fs yet. Fix it by waiting until it is there. The second test has even more problems on gitlab-CI. Even after adding some more

[Bug 1904954] Re: lan9118 bug peeked received message size not equal to actual received message size

2021-01-08 Thread Peter Maydell
** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1904954 Title: lan9118 bug peeked received message size not equal to actual received message

Re: [PATCH v2 3/4] s390x/tcg: Only ignore content in r0 when specified via "b" or "x"

2021-01-08 Thread Richard Henderson
On 1/8/21 3:20 AM, David Hildenbrand wrote: > Using get_address() with register identifiers comming from an "r" field > is wrong: if the "r" field designates "r0", we don't read the content > and instead assume 0 - which should only be applied when the register > was specified via "b" or "x". > >

Re: qemu bsd-user plans

2021-01-08 Thread Peter Maydell
Adding the people to the CC list who were on the previous discussion thread... -- PMM On Fri, 8 Jan 2021 at 19:43, Warner Losh wrote: > > The FreeBSD project has rewritten bsd-user. We've been working on this for > quite some time (the earliest commits date from 2013). Maybe a dozen people >

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-08 Thread Paolo Bonzini
On 08/01/21 20:29, Roman Bolshakov wrote: Paolo, I tried to use extract_all_objects() to get all object files directly but it doesn't work on dependency objects defined via declare_dependency(). It works only on regular targets (libs and executables). And as far as I understand the intention to

Re: [PATCHv3] arm-virt: add secure pl061 for reset/power down

2021-01-08 Thread Peter Maydell
On Wed, 6 Jan 2021 at 16:34, Maxim Uvarov wrote: > > Add secure pl061 for reset/power down machine from > the secure world (Arm Trusted Firmware). > Use the same gpio 3 and gpio 4 which were used by > non acpi variant of linux power control gpios. > > Signed-off-by: Maxim Uvarov > --- > v3:

Re: [PATCH v2 2/2] hw/ssi: imx_spi: Disable chip selects in imx_spi_reset()

2021-01-08 Thread Peter Maydell
On Wed, 2 Dec 2020 at 14:45, Bin Meng wrote: > > From: Xuzhou Cheng > > When a write to ECSPI_CONREG register to disable the SPI controller, > imx_spi_reset() is called to reset the controller, during which CS > lines should have been disabled, otherwise the state machine of any > devices (e.g.:

Re: [PATCH] decodetree: Open files with encoding='utf-8'

2021-01-08 Thread Yonggang Luo
On Fri, Jan 8, 2021 at 7:18 AM Philippe Mathieu-Daudé wrote: > > When decodetree.py was added in commit 568ae7efae7, QEMU was > using Python 2 which happily reads UTF-8 files in text mode. > Python 3 requires either UTF-8 locale or an explicit encoding > passed to open(). Now that Python 3 is

[PULL 08/23] hw/arm/highbank: Drop dead KVM support code

2021-01-08 Thread Peter Maydell
Support for running KVM on 32-bit Arm hosts was removed in commit 82bf7ae84ce739e. You can still run a 32-bit guest on a 64-bit Arm host CPU, but because Arm KVM requires the host and guest CPU types to match, it is not possible to run a guest that requires a Cortex-A9 or Cortex-A15 CPU there.

[PULL 22/23] hw/arm: sabrelite: Connect the Ethernet PHY at address 6

2021-01-08 Thread Peter Maydell
From: Bin Meng At present, when booting U-Boot on QEMU sabrelite, we see: Net: Board Net Initialization Failed No ethernet found. U-Boot scans PHY at address 4/5/6/7 (see board_eth_init() in the U-Boot source: board/boundary/nitrogen6x/nitrogen6x.c). On the real board, the Ethernet PHY

[PATCH v4 12/13] KVM: Disable manual dirty log when dirty ring enabled

2021-01-08 Thread Peter Xu
KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 is for KVM_CLEAR_DIRTY_LOG, which is only useful for KVM_GET_DIRTY_LOG. Skip enabling it for kvm dirty ring. More importantly, KVM_DIRTY_LOG_INITIALLY_SET will not wr-protect all the pages initially, which is against how kvm dirty ring is used - there's no way

[PATCH v4 09/13] KVM: Simplify dirty log sync in kvm_set_phys_mem

2021-01-08 Thread Peter Xu
kvm_physical_sync_dirty_bitmap() on the whole section is inaccurate, because the section can be a superset of the memslot that we're working on. The result is that if the section covers multiple kvm memslots, we could be doing the synchronization for multiple times for each kvmslot in the

[PATCH v2 3/4] hw/ppc/ppc405_uc: Drop use of ppcuic_init()

2021-01-08 Thread Peter Maydell
Switch the ppc405_uc boards to directly creating and configuring the UIC, rather than doing it via the old ppcuic_init() helper function. We retain the API feature of ppc405ep_init() where it passes back something allowing the callers to wire up devices to the UIC if they need to, even though

[RFC PATCH] linux-user/mmap: Return EFAULT for invalid addresses

2021-01-08 Thread Richard Purdie
When using qemu-i386 to run gobject introspection parts of a webkitgtk  build using musl as libc on a 64 bit host, it sits in an infinite loop  of mremap calls of ever decreasing/increasing addresses. I suspect something in the musl memory allocation code loops indefinitely if it only sees ENOMEM

[PATCH v2] decodetree: Open files with encoding='utf-8'

2021-01-08 Thread Philippe Mathieu-Daudé
When decodetree.py was added in commit 568ae7efae7, QEMU was using Python 2 which happily reads UTF-8 files in text mode. Python 3 requires either UTF-8 locale or an explicit encoding passed to open(). Now that Python 3 is required, explicit UTF-8 encoding for decodetree source files. To avoid

Re: [PATCH v2 1/2] docs: Add qemu-storage-daemon(1) manpage to meson.build

2021-01-08 Thread Alex Bennée
Peter Maydell writes: > In commit 1982e1602d15 we added a new qemu-storage-daemon(1) manpage. > At the moment new manpages have to be listed both in the conf.py for > Sphinx and also in docs/meson.build for Meson. We forgot the second > of those -- correct the omission. > > Signed-off-by:

[PATCH v3 1/6] target/arm: fix typo in cpu.h ID_AA64PFR1 field name

2021-01-08 Thread Leif Lindholm
SBSS -> SSBS Signed-off-by: Leif Lindholm Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Laurent Desnogues --- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 7e6c881a7e..5e3cf77ec7

[PATCH v3 2/6] target/arm: make ARMCPU.clidr 64-bit

2021-01-08 Thread Leif Lindholm
The AArch64 view of CLIDR_EL1 extends the ICB field to include also bit 32, as well as adding a Ttype field when FEAT_MTE is implemented. Extend the clidr field to be able to hold this context. Signed-off-by: Leif Lindholm Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell

[PATCH v3 0/6] target/arm: various changes to cpu.h

2021-01-08 Thread Leif Lindholm
First, fix a typo in ID_AA64PFR1 (SBSS -> SSBS). Second, turn clidr in the ARMCPU struct 64-bit, to support all fields defined by the ARM ARM. Third, add field definitions for CLIDR (excepting the Ttype fields, since I was unsure of prefererred naming - Ttype7-Ttype1?). Fourth add all ID_AA64

[PATCH v3 5/6] target/arm: add aarch64 ID register fields to cpu.h

2021-01-08 Thread Leif Lindholm
Add entries present in ARM DDI 0487F.c (August 2020). Signed-off-by: Leif Lindholm Reviewed-by: Peter Maydell Reviewed-by: Laurent Desnogues --- target/arm/cpu.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index

[PATCH v5 0/6] Additional NPCM7xx devices

2021-01-08 Thread Hao Wu via
This patch series include a few more NPCM7XX devices including - Analog Digital Converter (ADC) - Pulse Width Modulation (PWM) We also modified the CLK module to generate clock values using qdev_clock. These clocks are used to determine various clocks in NPCM7XX devices. Thank you for your

[PATCH v5 6/6] hw/*: Use type casting for SysBusDevice in NPCM7XX

2021-01-08 Thread Hao Wu via
A device shouldn't access its parent object which is QOM internal. Instead it should use type cast for this purporse. This patch fixes this issue for all NPCM7XX Devices. Signed-off-by: Hao Wu Reviewed-by: Peter Maydell --- hw/arm/npcm7xx_boards.c | 2 +- hw/mem/npcm7xx_mc.c | 2 +-

Re: pxa crashes with qemu v5.2 when executing xscale operations

2021-01-08 Thread Peter Maydell
On Mon, 21 Dec 2020 at 15:24, Philippe Mathieu-Daudé wrote: > On 12/21/20 6:28 AM, Guenter Roeck wrote: > > 84: ec432000mar acc0, r2, r3 > > > > > > This is supposed to be a DSP or iWMMXt coprocessor instruction. > > I did notice that the

[PATCH v2 0/4] hw/ppc: Convert UIC device to QOM

2021-01-08 Thread Peter Maydell
This patchseries converts the PPC UIC "Universal Interrupt Controller" to a QOM device. My main reason for doing it is that this fixes a couple of long-standing trivial Coverity issues -- the current ppcuic_init() function allocates an array of qemu_irqs which the callers then leak. (The leak is

[Bug 1904954] Re: lan9118 bug peeked received message size not equal to actual received message size

2021-01-08 Thread Peter Maydell
(The line of code you point out is pretty clearly wrong; it would just be nice to have a test case to confirm that the obvious fix works.) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1904954

[Bug 1904954] Re: lan9118 bug peeked received message size not equal to actual received message size

2021-01-08 Thread Peter Maydell
Do you have a test case that will reproduce this bug ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1904954 Title: lan9118 bug peeked received message size not equal to actual received message

Re: [PATCH] decodetree: Open files with encoding='utf-8'

2021-01-08 Thread Philippe Mathieu-Daudé
On 1/8/21 6:14 PM, Peter Maydell wrote: > On Fri, 8 Jan 2021 at 16:44, Philippe Mathieu-Daudé wrote: >> >> On 1/8/21 4:38 PM, Peter Maydell wrote: >>> Should we also be opening the output file explicitly as >>> utf-8 ? (How do we say "write to sys.stdout as utf-8" for >>> the case where we're

[PATCH v5 1/6] hw/misc: Add clock converter in NPCM7XX CLK module

2021-01-08 Thread Hao Wu via
This patch allows NPCM7XX CLK module to compute clocks that are used by other NPCM7XX modules. Add a new struct NPCM7xxClockConverterState which represents a single converter. Each clock converter in CLK module represents one converter in NPCM7XX CLK Module(PLL, SEL or Divider). Each converter

[PATCH v5 2/6] hw/timer: Refactor NPCM7XX Timer to use CLK clock

2021-01-08 Thread Hao Wu via
This patch makes NPCM7XX Timer to use a the timer clock generated by the CLK module instead of the magic number TIMER_REF_HZ. Reviewed-by: Havard Skinnemoen Reviewed-by: Tyrone Ting Signed-off-by: Hao Wu --- hw/arm/npcm7xx.c | 5 hw/timer/npcm7xx_timer.c | 39

Re: [PATCH v1] s390x/tcg: Fix RISBHG

2021-01-08 Thread Nick Desaulniers via
On Fri, Jan 8, 2021 at 1:45 AM David Hildenbrand wrote: > > On 08.01.21 03:20, Nick Desaulniers wrote: > > On Thu, Jan 7, 2021 at 3:27 PM David Hildenbrand > > wrote: > >> > >> > >>> Am 08.01.2021 um 00:21 schrieb Nick Desaulniers : > >>> > >>> On Thu, Jan 7, 2021 at 3:13 PM David Hildenbrand

Re: [PATCH v2 0/4] s390x/tcg: fix booting Linux kernels compiled with clang-11 and clang-12

2021-01-08 Thread Guenter Roeck
On 1/8/21 5:20 AM, David Hildenbrand wrote: > This series fixes booting current upstream Linux kernel compiled by > clang-11 and clang-12 under TCG. > > Decided to pull in already separatly sent patches. The last patch is > not required to fix the boot issues, but related to patch #3. > > Latest

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-08 Thread Roman Bolshakov
On Thu, Jan 07, 2021 at 08:41:50PM +0100, Paolo Bonzini wrote: > Il gio 7 gen 2021, 20:36 Roman Bolshakov ha scritto: > > > > No I think that Meson should simply explode link_whole libraries to their > > > constituent objects. This way duplicates are avoided. > > > > > > > Ok. I've looked

Re: [PATCH v2 24/24] target/arm: Enforce alignment for sve unpredicated LDR/STR

2021-01-08 Thread Peter Maydell
On Thu, 7 Jan 2021 at 22:02, Richard Henderson wrote: > > On 1/7/21 7:39 AM, Peter Maydell wrote: > >> +if (align > MO_ALIGN_8) { > >> +t0 = tcg_temp_new_i64(); > >> +tcg_gen_qemu_ld_i64(t0, clean_addr, midx, MO_LEQ | align); > >> +

[PATCH] linux-user/mmap: Avoid asserts for out of range mremap calls

2021-01-08 Thread Richard Purdie
If mremap() is called without the MREMAP_MAYMOVE flag with a start address just before the end of memory (reserved_va) where new_size would exceed it (and GUEST_ADDR_MAX), the assert(end - 1 <= GUEST_ADDR_MAX) in  page_set_flags() would trigger. Add an extra guard to the guest_range_valid()

Re: [PULL 00/23] target-arm queue

2021-01-08 Thread Peter Maydell
rth-gitlab/tags/pull-tcg-20210107' > into staging (2021-01-07 20:34:05 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20210108 > > for you to fetch changes up to c9f8511ea8d2b80723af0fea1f716d7

[PATCH 1/2] hw/net/lan9118: Fix RX Status FIFO PEEK value

2021-01-08 Thread Peter Maydell
A copy-and-paste error meant that the return value for register offset 0x44 (the RX Status FIFO PEEK register) returned a byte from a bogus offset in the rx status FIFO. Fix the typo. Cc: qemu-sta...@nongnu.org Fixes: https://bugs.launchpad.net/qemu/+bug/1904954 Signed-off-by: Peter Maydell ---

Re: [PATCH 2/2] hw/net/lan9118: Add symbolic constants for register offsets

2021-01-08 Thread Philippe Mathieu-Daudé
On 1/8/21 7:04 PM, Peter Maydell wrote: > The lan9118 code mostly uses symbolic constants for register offsets; > the exceptions are those which the datasheet doesn't give an official > symbolic name to. > > Add some names for the registers which don't already have them, based > on the longer

Re: [PATCH] configure: Add flags for MinGW32 standalone build

2021-01-08 Thread Joshua Watt
On 1/8/21 1:25 AM, Thomas Huth wrote: On 07/01/2021 22.38, Joshua Watt wrote: There are two cases that need to be accounted for when compiling QEMU for MinGW32:   1) A standalone distribution, where QEMU is self contained and extracted by the user, such as a user would download from the

Re: [PULL 00/66] MIPS patches for 2021-01-07

2021-01-08 Thread Richard Henderson
On 1/8/21 5:22 AM, 罗勇刚(Yonggang Luo) wrote: >>> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position >>> 80: ordinal not in range(128) > Can we always reading file in decodetree with utf8 encoding > And convert all decodetree to utf8 encoding, and the problem should resolved. > ```

Re: [RFC PATCH v2 00/32] CXL 2.0 Support

2021-01-08 Thread Ben Widawsky
On 21-01-08 18:44:04, Jonathan Cameron wrote: > On Tue, 5 Jan 2021 08:52:51 -0800 > Ben Widawsky wrote: > > > Fixes since v1 [1]: > > * Defer introducing some commands/registers not yet used (Ben) > > * Add stubbed device_reg_init_common() (Ben) > > * Improve assertions in DVSEC creation

Re: [PATCH v2] decodetree: Open files with encoding='utf-8'

2021-01-08 Thread Eduardo Habkost
On Fri, Jan 08, 2021 at 07:09:52PM +0100, Philippe Mathieu-Daudé wrote: > When decodetree.py was added in commit 568ae7efae7, QEMU was > using Python 2 which happily reads UTF-8 files in text mode. > Python 3 requires either UTF-8 locale or an explicit encoding > passed to open(). Now that Python

  1   2   3   >