Re: [PATCH] tcg: Remove unused tcg_out_dupi_vec() stub

2021-01-10 Thread Richard Henderson
On 1/9/21 6:10 PM, Wataru Ashihara wrote: > This fixes the build with --enable-tcg-interpreter: > > clang -Ilibqemu-arm-softmmu.fa.p -I. -I.. -Itarget/arm -I../target/arm > -I../dtc/libfdt -I../capstone/include/capstone -Iqapi -Itrace -Iui > -Iui/shader -I/usr/include/pixman-1

Re: [PATCH] target/i386: Use X86Seg enum for segment registers

2021-01-10 Thread Richard Henderson
On 1/9/21 1:34 PM, Philippe Mathieu-Daudé wrote: > Use the dedicated X86Seg enum type for segment registers. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/i386/cpu.h| 4 ++-- > target/i386/gdbstub.c| 2 +- > target/i386/tcg/seg_helper.c | 8 >

Re: [PATCH] hvf: guard xgetbv call.

2021-01-10 Thread Richard Henderson
On 1/10/21 8:34 AM, Richard Henderson wrote: > On 1/9/21 3:46 PM, Roman Bolshakov wrote: >> +static int xgetbv(uint32_t cpuid_ecx, uint32_t idx, uint64_t *xcr) >> { >> -uint32_t eax, edx; >> +uint32_t xcrl, xcrh; >> >> -__asm__ volatile ("xgetbv" >> - : "=a"

[PATCH v7 4/6] [RISCV_PM] Support pointer masking for RISC-V for i/c/f/d/a types of instructions

2021-01-10 Thread Alexey Baturo
Signed-off-by: Alexey Baturo --- target/riscv/insn_trans/trans_rva.c.inc | 3 +++ target/riscv/insn_trans/trans_rvd.c.inc | 2 ++ target/riscv/insn_trans/trans_rvf.c.inc | 2 ++ target/riscv/insn_trans/trans_rvi.c.inc | 2 ++ target/riscv/translate.c| 14 ++ 5

[PATCH v7 1/6] [RISCV_PM] Add J-extension into RISC-V

2021-01-10 Thread Alexey Baturo
Signed-off-by: Alexey Baturo Reviewed-by: Richard Henderson --- target/riscv/cpu.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index 6339e84819..d152842e37 100644 --- a/target/riscv/cpu.h +++ b/target/riscv/cpu.h @@ -72,6 +72,7 @@ #define RVS

Re: [PULL 23/35] hw/intc: Rework Loongson LIOINTC

2021-01-10 Thread Peter Maydell
On Sun, 3 Jan 2021 at 21:11, Philippe Mathieu-Daudé wrote: > > From: Huacai Chen > > As suggested by Philippe Mathieu-Daudé, rework Loongson's liointc: > 1, Move macro definitions to loongson_liointc.h; > 2, Remove magic values and use macros instead; > 3, Replace dead D() code by trace events.

coverity warning about possible missing error check in v9fs_request()

2021-01-10 Thread Peter Maydell
Hi; Coverity has just come up with a new warning (CID 1438968) about an unchecked error return value in the 9pfs code. (I'm not sure why now -- the code in question is unchanged since 2011; probably some other callsites changed enough to trigger the "other callsites check return value" heuristic.)

Re: [PATCH 1/2] tcg: Mark more tcg_out*() functions with attribute 'unused'

2021-01-10 Thread Philippe Mathieu-Daudé
On 1/10/21 6:51 PM, Richard Henderson wrote: > On 1/10/21 6:27 AM, Philippe Mathieu-Daudé wrote: >> The tcg_out* functions are utility routines that may or >> may not be used by a particular backend. Similarly to commit >> 4196dca63b8, mark them with the 'unused' attribute to suppress >> spurious

Re: [PATCH v3 0/3] unbreak non-tcg builds

2021-01-10 Thread Claudio Fontana
On 10/13/20 4:55 PM, Philippe Mathieu-Daudé wrote: > On 10/13/20 4:38 PM, Claudio Fontana wrote: >> This series now unbreaks current non-tcg builds >> (!CONFIG_TCG). >> >> tests Makefiles need to avoid relying on all non-native >> archs binaries to be present, >> >> bios-tables-test needs to skip

Re: [PATCH 1/2] tcg: Mark more tcg_out*() functions with attribute 'unused'

2021-01-10 Thread Richard Henderson
On 1/10/21 6:27 AM, Philippe Mathieu-Daudé wrote: > The tcg_out* functions are utility routines that may or > may not be used by a particular backend. Similarly to commit > 4196dca63b8, mark them with the 'unused' attribute to suppress > spurious warnings if they aren't used. > > This fixes the

Re: [PATCH v2] target/i386/sev: add support to query the attestation report

2021-01-10 Thread Dov Murik
Hello Brijesh, On 05/01/2021 18:39, Brijesh Singh wrote: The SEV FW >= 0.23 added a new command that can be used to query the attestation report containing the SHA-256 digest of the guest memory and VMSA encrypted with the LAUNCH_UPDATE and sign it with the PEK. Note, we already have a

Re: [PATCH] hvf: guard xgetbv call.

2021-01-10 Thread Richard Henderson
On 1/9/21 3:46 PM, Roman Bolshakov wrote: > +static int xgetbv(uint32_t cpuid_ecx, uint32_t idx, uint64_t *xcr) > { > -uint32_t eax, edx; > +uint32_t xcrl, xcrh; > > -__asm__ volatile ("xgetbv" > - : "=a" (eax), "=d" (edx) > - : "c" (xcr)); >

[PATCH v7 0/6] RISC-V Pointer Masking implementation

2021-01-10 Thread Alexey Baturo
Hi folks, Sorry it took me almost 3 month to provide the reply and fixes: it was a really busy EOY. This series contains fixed @Alistair suggestion on enabling J-ext. As for @Richard comments: - Indeed I've missed appending review-by to the approved commits. Now I've restored them except for

[PATCH v7 5/6] [RISCV_PM] Implement address masking functions required for RISC-V Pointer Masking extension

2021-01-10 Thread Alexey Baturo
From: Anatoly Parshintsev Signed-off-by: Anatoly Parshintsev Reviewed-by: Richard Henderson --- target/riscv/cpu.h | 19 +++ target/riscv/translate.c | 34 -- 2 files changed, 51 insertions(+), 2 deletions(-) diff --git

[PATCH v7 2/6] [RISCV_PM] Support CSRs required for RISC-V PM extension except for the ones required for hypervisor mode

2021-01-10 Thread Alexey Baturo
Signed-off-by: Alexey Baturo --- target/riscv/cpu.c | 3 + target/riscv/cpu.h | 12 ++ target/riscv/cpu_bits.h | 66 ++ target/riscv/csr.c | 271 4 files changed, 352 insertions(+) diff --git a/target/riscv/cpu.c

Re: [PULL 22/23] hw/riscv: Use the CPU to determine if 32-bit

2021-01-10 Thread Peter Maydell
On Fri, 18 Dec 2020 at 06:01, Alistair Francis wrote: > > Instead of using string compares to determine if a RISC-V machine is > using 32-bit or 64-bit CPUs we can use the initalised CPUs. This avoids > us having to maintain a list of CPU names to compare against. > > This commit also fixes the

Re: [PULL 23/35] hw/intc: Rework Loongson LIOINTC

2021-01-10 Thread Philippe Mathieu-Daudé
Hi Peter, Huacai, On 1/10/21 8:49 PM, Peter Maydell wrote: > On Sun, 3 Jan 2021 at 21:11, Philippe Mathieu-Daudé wrote: >> >> From: Huacai Chen >> >> As suggested by Philippe Mathieu-Daudé, rework Loongson's liointc: >> 1, Move macro definitions to loongson_liointc.h; >> 2, Remove magic values

Re: [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge

2021-01-10 Thread BALATON Zoltan
On Sun, 10 Jan 2021, Philippe Mathieu-Daudé wrote: +PCI experts On 1/10/21 1:43 AM, BALATON Zoltan wrote: On Sun, 10 Jan 2021, Philippe Mathieu-Daudé wrote: Hi Zoltan, On 1/9/21 9:16 PM, BALATON Zoltan wrote: Currently the ISA devices that are part of the VIA south bridge, superio chip are

[PATCH v2] hvf: guard xgetbv call.

2021-01-10 Thread Hill Ma
This prevents illegal instruction on cpus do not support xgetbv. Buglink: https://bugs.launchpad.net/qemu/+bug/1758819 Signed-off-by: Hill Ma --- v2: xgetbv() modified based on feedback. target/i386/hvf/x86_cpuid.c | 28 +++- 1 file changed, 19 insertions(+), 9

[PATCH v7 3/6] [RISCV_PM] Print new PM CSRs in QEMU logs

2021-01-10 Thread Alexey Baturo
Signed-off-by: Alexey Baturo Reviewed-by: Richard Henderson --- target/riscv/cpu.c | 25 + 1 file changed, 25 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index d50f09b757..19398977d3 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@

[PATCH v7 6/6] [RISCV_PM] Allow experimental J-ext to be turned on

2021-01-10 Thread Alexey Baturo
Signed-off-by: Alexey Baturo --- target/riscv/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 19398977d3..234401c3c6 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -499,6 +499,7 @@ static void riscv_cpu_realize(DeviceState

Re: [PULL 00/23] target-arm queue

2021-01-10 Thread Yonggang Luo
On Sat, Jan 9, 2021 at 1:51 AM Peter Maydell wrote: > > On Fri, 8 Jan 2021 at 15:36, Peter Maydell wrote: > > > > Nothing too exciting, but does include the last bits of v8.1M support work. > > > > -- PMM > > > > The following changes since commit e79de63ab1bd1f6550e7b915e433bec1ad1a870a: > > >

check-tcg HOWTO?

2021-01-10 Thread Claudio Fontana
Hi Alex, happy new year, I am trying to get check-tcg to run reliably, as I am doing some substantial refactoring of tcg cpu operations, so I need to verify that TCG is fine. This is an overall getting started question, is there a how-to on how to use check-tcg and how to fix things when

Re: [PATCH] tcg: Remove unused tcg_out_dupi_vec() stub

2021-01-10 Thread Philippe Mathieu-Daudé
On 1/10/21 7:23 PM, Richard Henderson wrote: > On 1/9/21 6:10 PM, Wataru Ashihara wrote: >> This fixes the build with --enable-tcg-interpreter: >> >> clang -Ilibqemu-arm-softmmu.fa.p -I. -I.. -Itarget/arm -I../target/arm >> -I../dtc/libfdt -I../capstone/include/capstone -Iqapi -Itrace -Iui >>

[PATCH v4 2/6] hw/ssi: imx_spi: Remove imx_spi_update_irq() in imx_spi_reset()

2021-01-10 Thread Bin Meng
From: Bin Meng Usually the approach is that the device on the other end of the line is going to reset its state anyway, so there's no need to actively signal an irq line change during the reset hook. Move imx_spi_update_irq() out of imx_spi_reset(), to a new function imx_spi_hard_reset() that

Re: VirtioSound device emulation implementation

2021-01-10 Thread Shreyansh Chouhan
Hi, I have been reading about the virtio and vhost specifications, however I have a few doubts. I tried looking for them but I still do not understand them clearly enough. From what I understand, there are two protocols: The virtio protocol: The one that specifies how we can have common

[PATCH 00/23] next round of audio patches

2021-01-10 Thread Volker Rümelin
A mix of bug fixes and improvements. Patches 01/23 - 11/23 have a few SDL fixes and add audio recording functions to the SDL audio backend. Patch 12/23 removes unnecessary code from audio/audio.c. Patches 13/23 - 16/23 fix a few PulseAudio backend bugs. Patch 17/23 shows a PulseAudio backend

[PATCH 08/23] audio: split pcm_ops function get_buffer_in

2021-01-10 Thread Volker Rümelin
Split off pcm_ops function run_buffer_in from get_buffer_in and call run_buffer_in before get_buffer_in. The next patch only needs the generic buffer management part from audio_generic_get_buffer_in(). Signed-off-by: Volker Rümelin --- audio/alsaaudio.c | 1 + audio/audio.c | 18

[PATCH 18/23] paaudio: limit minreq to 75% of audio timer_rate

2021-01-10 Thread Volker Rümelin
Currently with the playback buffer attribute minreq = -1 and flag PA_STREAM_EARLY_REQUESTS PulseAudio uses minreq = tlength / 4. To improve audio playback with larger PulseAudio server side buffers, limit minreq to a maximum of 75% of audio timer_rate. That way there is a good chance qemu receives

Re: [PATCH] shippable.yml: Remove jobs duplicated on Gitlab-CI

2021-01-10 Thread Philippe Mathieu-Daudé
On 1/8/21 4:36 PM, Paolo Bonzini wrote: > On 08/01/21 16:21, Daniel P. Berrangé wrote: >> On Fri, Jan 08, 2021 at 04:14:30PM +0100, Paolo Bonzini wrote: ... >>> >>> The debian-mips-cross/mips-softmmu pair (and also mipsel-softmmu) is >>> currently excluded by Gitlab's cross-mips-system, is there a

[PATCH v7 3/7] fuzz: split write operand using binary approach

2021-01-10 Thread Qiuhao Li
Currently, we split the write commands' data from the middle. If it does not work, try to move the pivot left by one byte and retry until there is no space. But, this method has two flaws: 1. It may fail to trim all unnecessary bytes on the right side. For example, there is an IO write command:

Re: What's the correct way to implement rfi and related instruction.

2021-01-10 Thread Yonggang Luo
On Fri, Jan 8, 2021 at 2:02 AM Cédric Le Goater wrote: > > On 1/8/21 5:21 AM, 罗勇刚(Yonggang Luo) wrote: > > > > > > On Fri, Jan 8, 2021 at 5:54 AM Cédric Le Goater > wrote: > >> > >> On 1/7/21 8:14 PM, 罗勇刚(Yonggang Luo) wrote: > >> > This is the first patch,: > >> > It's store MSR bits differntly

Re: [PATCH] tcg: Remove unused tcg_out_dupi_vec() stub

2021-01-10 Thread Philippe Mathieu-Daudé
Cc'ing Stefan. On 1/10/21 5:10 AM, Wataru Ashihara wrote: > This fixes the build with --enable-tcg-interpreter: > > clang -Ilibqemu-arm-softmmu.fa.p -I. -I.. -Itarget/arm -I../target/arm > -I../dtc/libfdt -I../capstone/include/capstone -Iqapi -Itrace -Iui > -Iui/shader

[RFC PATCH 2/2] gitlab-ci: Add a job building TCI with Clang

2021-01-10 Thread Philippe Mathieu-Daudé
Split the current GCC build-tci job in 2, and use Clang compiler in the new job. Signed-off-by: Philippe Mathieu-Daudé --- RFC in case someone have better idea to optimize can respin this patch. .gitlab-ci.yml | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff

[PATCH v7 6/7] fuzz: add minimization options

2021-01-10 Thread Qiuhao Li
-M1: remove IO commands iteratively -M2: try setting bits in operand of write/out to zero Signed-off-by: Qiuhao Li Reviewed-by: Alexander Bulekov Tested-by: Alexander Bulekov --- scripts/oss-fuzz/minimize_qtest_trace.py | 30 1 file changed, 26 insertions(+), 4

[PATCH v7 7/7] fuzz: heuristic split write based on past IOs

2021-01-10 Thread Qiuhao Li
If previous write commands write the same length of data with the same step, we view it as a hint. Signed-off-by: Qiuhao Li Reviewed-by: Alexander Bulekov Tested-by: Alexander Bulekov --- scripts/oss-fuzz/minimize_qtest_trace.py | 56 1 file changed, 56 insertions(+)

Re: [PATCH v4 1/7] fuzz: accelerate non-crash detection

2021-01-10 Thread Alexander Bulekov
On 210110 2110, Qiuhao Li wrote: > On Wed, 2021-01-06 at 23:18 -0500, Alexander Bulekov wrote: > > On 201229 1240, Qiuhao Li wrote: > > > We spend much time waiting for the timeout program during the > > > minimization > > > process until it passes a time limit. This patch hacks the CLOSED > > >

[PATCH 04/23] sdlaudio: don't start playback in init routine

2021-01-10 Thread Volker Rümelin
Every emulated audio device has a way to enable audio playback. Don't start playback until the guest enables the audio device. This patch keeps the SDL2 device pause state in sync with hw->enabled. Signed-off-by: Volker Rümelin --- audio/sdlaudio.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH 01/23] sdlaudio: remove leftover SDL1.2 code

2021-01-10 Thread Volker Rümelin
Signed-off-by: Volker Rümelin --- audio/sdlaudio.c | 30 +- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/audio/sdlaudio.c b/audio/sdlaudio.c index 21b7a0484b..bf3cfb8456 100644 --- a/audio/sdlaudio.c +++ b/audio/sdlaudio.c @@ -240,28 +240,24 @@

[PATCH 02/23] audio: fix bit-rotted code

2021-01-10 Thread Volker Rümelin
Signed-off-by: Volker Rümelin --- audio/alsaaudio.c | 2 +- audio/sdlaudio.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index a8e62542f9..6787e91bc1 100644 --- a/audio/alsaaudio.c +++ b/audio/alsaaudio.c @@ -599,7 +599,7 @@

[PATCH 09/23] sdlaudio: add recording functions

2021-01-10 Thread Volker Rümelin
Add audio recording functions. SDL 2.0.5 or later is required to use the recording functions. Playback continues to work with earlier SDL 2.0 versions. Signed-off-by: Volker Rümelin --- audio/sdlaudio.c | 142 ++- 1 file changed, 139 insertions(+), 3

[PATCH 11/23] sdlaudio: enable (in|out).mixing-engine=off

2021-01-10 Thread Volker Rümelin
Enable the SDL2 backend options -audiodev sdl,out.mixing- engine=off,in.mixing-engine=off. Signed-off-by: Volker Rümelin --- audio/sdlaudio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/audio/sdlaudio.c b/audio/sdlaudio.c index 445cae8de5..c68c62a3e4 100644 ---

[PATCH 14/23] paaudio: wait for PA_STREAM_READY in qpa_write()

2021-01-10 Thread Volker Rümelin
Don't call pa_stream_writable_size() in qpa_write() before the playback stream is ready. This prevents a lot of the following pulseaudio error messages. pulseaudio: pa_stream_writable_size failed pulseaudio: Reason: Bad state To reproduce start qemu with -parallel none -device

[PATCH 20/23] dsoundaudio: replace GetForegroundWindow()

2021-01-10 Thread Volker Rümelin
GetForegroundWindow() doesn't necessarily return the own window handle. It just returns a handle to the currently active window and can even return NULL. At the time dsound_open() gets called the active window is most likely the shell window and not the QEMU window. Replace GetForegroundWindow()

Re: [PATCH v4 2/6] hw/ssi: imx_spi: Remove imx_spi_update_irq() in imx_spi_reset()

2021-01-10 Thread Bin Meng
Hi Philippe, On Sun, Jan 10, 2021 at 7:15 PM Philippe Mathieu-Daudé wrote: > > On 1/10/21 9:14 AM, Bin Meng wrote: > > From: Bin Meng > > > > Usually the approach is that the device on the other end of the line > > is going to reset its state anyway, so there's no need to actively > > signal an

[PATCH v7 0/7] fuzz: improve crash case minimization

2021-01-10 Thread Qiuhao Li
Extend and refine the crash case minimization process. Test input: Bug 1909261 full_reproducer 6500 QTest instructions (write mostly) Refined (-M1 minimization level) vs. Original version: real 38m31.942s <-- real 532m57.192s user 28m18.188s <-- user 89m0.536s sys 12m42.239s

[PATCH 0/2] tcg/tci: Fix Clang build

2021-01-10 Thread Philippe Mathieu-Daudé
Fix the build failure reported by Wataru Ashihara on [*] and add a CI test to catch future problems. [*] https://www.mail-archive.com/qemu-devel@nongnu.org/msg771326.html Philippe Mathieu-Daudé (2): tcg: Mark more tcg_out*() functions with attribute 'unused' gitlab-ci: Add a job building TCI

[PATCH 1/2] tcg: Mark more tcg_out*() functions with attribute 'unused'

2021-01-10 Thread Philippe Mathieu-Daudé
The tcg_out* functions are utility routines that may or may not be used by a particular backend. Similarly to commit 4196dca63b8, mark them with the 'unused' attribute to suppress spurious warnings if they aren't used. This fixes the build with --enable-tcg-interpreter: [98/151] Compiling C

Re: [PATCH 00/23] next round of audio patches

2021-01-10 Thread Volker Rümelin
> Patchew URL: > https://patchew.org/QEMU/9315afe5-5958-c0b4-ea1e-14769511a...@t-online.de/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 9315afe5-5958-c0b4-ea1e-14769511a...@t-online.de > Subject:

Re: [PULL 04/47] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign

2021-01-10 Thread Volker Rümelin
> We do not need or want to be allocating page sized quanta. > > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Stefan Weil > Message-Id: <20201018164836.1149452-1-richard.hender...@linaro.org> > Signed-off-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson > --- >

Re: [PULL 23/35] hw/intc: Rework Loongson LIOINTC

2021-01-10 Thread Huacai Chen
I think R_END should be 0x60, Jiaxun, what do you think? Huacai On Mon, Jan 11, 2021 at 5:51 AM BALATON Zoltan wrote: > > On Sun, 10 Jan 2021, Philippe Mathieu-Daudé wrote: > > Hi Peter, Huacai, > > > > On 1/10/21 8:49 PM, Peter Maydell wrote: > >> On Sun, 3 Jan 2021 at 21:11, Philippe

Re: [PULL 23/35] hw/intc: Rework Loongson LIOINTC

2021-01-10 Thread Jiaxun Yang
On Mon, Jan 11, 2021, at 8:36 AM, Huacai Chen wrote: > I think R_END should be 0x60, Jiaxun, what do you think? U r right. The manual is misleading. Thanks. - Jiaxun > > Huacai > > On Mon, Jan 11, 2021 at 5:51 AM BALATON Zoltan wrote: > > > > On Sun, 10 Jan 2021, Philippe Mathieu-Daudé

Re: [PATCH v4 1/7] fuzz: accelerate non-crash detection

2021-01-10 Thread Qiuhao Li
On Sun, 2021-01-10 at 11:00 -0500, Alexander Bulekov wrote: > On 210110 2110, Qiuhao Li wrote: > > On Wed, 2021-01-06 at 23:18 -0500, Alexander Bulekov wrote: > > > On 201229 1240, Qiuhao Li wrote: > > > > We spend much time waiting for the timeout program during the > > > > minimization > > > >

[PATCH] util/oslib-win32: Fix _aligned_malloc() arguments order

2021-01-10 Thread Philippe Mathieu-Daudé
Commit dfbd0b873a8 inadvertently swapped the arguments of _aligned_malloc(), correct it to fix [*]: G_TEST_SRCDIR=C:/Users/ContainerAdministrator/AppData/Local/Temp/cirrus-ci-build/tests G_TEST_BUILDDIR=C:/Users/ContainerAdministrator/AppData/Local/Temp/cirrus-ci-build/build/tests

[Bug 1658141] Re: QEMU's default msrs handling causes Windows 10 64 bit to crash

2021-01-10 Thread Francois Gouget
This bug is still present. However the "ignore_msrs=1" workaround does not work with QEmu 3.1 anymore. To prevent Windows 10 from crashing one must upgrade QEmu to 5.0.14. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1658141] Re: QEMU's default msrs handling causes Windows 10 64 bit to crash

2021-01-10 Thread Francois Gouget
The bug is still present so changing the status back to New. ** Changed in: qemu Status: Expired => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1658141 Title: QEMU's default msrs

Re: [PULL 23/35] hw/intc: Rework Loongson LIOINTC

2021-01-10 Thread BALATON Zoltan
On Sun, 10 Jan 2021, Philippe Mathieu-Daudé wrote: Hi Peter, Huacai, On 1/10/21 8:49 PM, Peter Maydell wrote: On Sun, 3 Jan 2021 at 21:11, Philippe Mathieu-Daudé wrote: From: Huacai Chen As suggested by Philippe Mathieu-Daudé, rework Loongson's liointc: 1, Move macro definitions to

Re: [PATCH 4/8] hw/ppc/ppc440_bamboo: Drop use of ppcuic_init()

2021-01-10 Thread Nathan Chancellor
On Sat, Dec 12, 2020 at 12:15:33AM +, Peter Maydell wrote: > Switch the bamboo board to directly creating and configuring the UIC, > rather than doing it via the old ppcuic_init() helper function. > > Signed-off-by: Peter Maydell > --- > hw/ppc/ppc440_bamboo.c | 38

Re: [PATCH 4/5] hw/ppc/ppc4xx_pci: Replace pointless warning by assert()

2021-01-10 Thread Nathan Chancellor
On Tue, Sep 01, 2020 at 12:40:42PM +0200, Philippe Mathieu-Daudé wrote: > We call pci_register_root_bus() to register 4 IRQs with the > ppc4xx_pci_set_irq() handler. As it can only be called with > values in the [0-4[ range, replace the pointless warning by > an assert(). > > Signed-off-by:

Re: [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge

2021-01-10 Thread Jiaxun Yang
On Mon, Jan 11, 2021, at 3:25 AM, BALATON Zoltan wrote: > On Sun, 10 Jan 2021, Philippe Mathieu-Daudé wrote: > > +PCI experts > > > > On 1/10/21 1:43 AM, BALATON Zoltan wrote: > >> On Sun, 10 Jan 2021, Philippe Mathieu-Daudé wrote: [...] > > I'm not a PCI expert but my understanding is PCI

RE: [PATCH v2 0/7] Fix some memleaks caused by ptimer_init

2021-01-10 Thread ganqixin
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Friday, January 8, 2021 7:43 PM > To: ganqixin > Cc: QEMU Developers ; QEMU Trivial > ; Beniamino Galvani ; > Antony Pavlov ; Igor Mitsyanko > ; sundeep subbaraya ; > Jan Kiszka ; Chenqun (kuhn) > ;

[Bug 1910941] [NEW] Assertion `addr < cache->len && 2 <= cache->len - addr' in virtio-blk

2021-01-10 Thread Cheol-Woo,Myung
Public bug reported: Hello, Using hypervisor fuzzer, hyfuzz, I found an assertion failure through virtio-blk emulator. A malicious guest user/process could use this flaw to abort the QEMU process on the host, resulting in a denial of service. This was found in version 5.2.0 (master) ```

Re: [PATCH v7 1/7] fuzz: accelerate non-crash detection

2021-01-10 Thread Alexander Bulekov
On 210110 2119, Qiuhao Li wrote: > We spend much time waiting for the timeout program during the minimization > process until it passes a time limit. This patch hacks the CLOSED (indicates > the redirection file closed) notification in QTest's output if it doesn't > crash. > > Test with

[PATCH v4 6/6] hw/ssi: imx_spi: Correct tx and rx fifo endianness

2021-01-10 Thread Bin Meng
From: Bin Meng The endianness of data exchange between tx and rx fifo is incorrect. Earlier bytes are supposed to show up on MSB and later bytes on LSB, ie: in big endian. The manual does not explicitly say this, but the U-Boot and Linux driver codes have a swap on the data transferred to tx

[PATCH v4 5/6] hw/ssi: imx_spi: Correct the burst length > 32 bit transfer logic

2021-01-10 Thread Bin Meng
From: Bin Meng For the ECSPIx_CONREG register BURST_LENGTH field, the manual says: 0x020 A SPI burst contains the 1 LSB in first word and all 32 bits in second word. 0x021 A SPI burst contains the 2 LSB in first word and all 32 bits in second word. Current logic uses either s->burst_length

[PATCH 06/23] sdlaudio: fill remaining sample buffer with silence

2021-01-10 Thread Volker Rümelin
Fill the remaining sample buffer with silence. To fill it with zeroes is wrong for unsigned samples because this is silence with a DC bias. Signed-off-by: Volker Rümelin --- audio/sdlaudio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/audio/sdlaudio.c

Re: [PATCH v2 4/4] s390x/tcg: Ignore register content if b1/b2 is zero when handling EXECUTE

2021-01-10 Thread Thomas Huth
On 08/01/2021 14.20, David Hildenbrand wrote: In our EXECUTE fast path, we have to ignore the content of r0, if specified by b1 or b2. Fixes: d376f123c7de ("target/s390x: Re-implement a few EXECUTE target insns directly") Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 4

Re: [PATCH 00/23] next round of audio patches

2021-01-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/9315afe5-5958-c0b4-ea1e-14769511a...@t-online.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 9315afe5-5958-c0b4-ea1e-14769511a...@t-online.de Subject: [PATCH 00/23] next round

Re: [PATCH v4 2/6] hw/ssi: imx_spi: Remove imx_spi_update_irq() in imx_spi_reset()

2021-01-10 Thread Philippe Mathieu-Daudé
On 1/10/21 9:14 AM, Bin Meng wrote: > From: Bin Meng > > Usually the approach is that the device on the other end of the line > is going to reset its state anyway, so there's no need to actively > signal an irq line change during the reset hook. > > Move imx_spi_update_irq() out of

Re: [PATCH v4 3/6] hw/ssi: imx_spi: Disable chip selects when controller is disabled

2021-01-10 Thread Philippe Mathieu-Daudé
On 1/10/21 9:14 AM, Bin Meng wrote: > From: Xuzhou Cheng > > When a write to ECSPI_CONREG register to disable the SPI controller, > imx_spi_reset() is called to reset the controller, but chip select > lines should have been disabled, otherwise the state machine of any > devices (e.g.: SPI

[PATCH v4 3/6] hw/ssi: imx_spi: Disable chip selects when controller is disabled

2021-01-10 Thread Bin Meng
From: Xuzhou Cheng When a write to ECSPI_CONREG register to disable the SPI controller, imx_spi_reset() is called to reset the controller, but chip select lines should have been disabled, otherwise the state machine of any devices (e.g.: SPI flashes) connected to the SPI master is stuck to its

[PATCH v4 4/6] hw/ssi: imx_spi: Log unimplemented burst length

2021-01-10 Thread Bin Meng
From: Bin Meng Current implementation of the imx spi controller expects the burst length to be multiple of 8, which is the most common use case. In case the burst length is not what we expect, log it to give user a chance to notice it. Signed-off-by: Bin Meng Reviewed-by: Philippe

[PATCH 05/23] sdlaudio: always clear the sample buffer

2021-01-10 Thread Volker Rümelin
Always fill the remaining audio callback buffer with silence. SDL 2.0 doesn't initialize the audio callback buffer. This was an incompatible change compared to SDL 1.2. For reference read the SDL 1.2 to 2.0 migration guide. Signed-off-by: Volker Rümelin --- audio/sdlaudio.c | 33

[PATCH 07/23] sdlaudio: replace legacy functions with modern ones

2021-01-10 Thread Volker Rümelin
With the modern audio functions it's possible to add new features like audio recording. As a side effect this patch fixes a bug where SDL2 can't be used on Windows. This bug was reported on the qemu-devel mailing list at https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg04043.html

[PATCH 10/23] audio: break generic buffer dependency on mixing-engine

2021-01-10 Thread Volker Rümelin
Break the unnecessary dependency of the generic buffer management code on mixing-engine. This is required for the next patch. Signed-off-by: Volker Rümelin --- audio/audio.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index

[PATCH 19/23] paaudio: send recorded data in smaller chunks

2021-01-10 Thread Volker Rümelin
Tell PulseAudio to send recorded audio data in smaller chunks than timer_period, so there's a good chance that qemu can read recorded audio data every time it looks for new data. PulseAudio tries to send buffer updates at a fragsize / 2 rate. With fragsize = timer_period / 2 * 3 the update rate

Re: [PATCH v4 1/7] fuzz: accelerate non-crash detection

2021-01-10 Thread Qiuhao Li
On Wed, 2021-01-06 at 23:18 -0500, Alexander Bulekov wrote: > On 201229 1240, Qiuhao Li wrote: > > We spend much time waiting for the timeout program during the > > minimization > > process until it passes a time limit. This patch hacks the CLOSED > > (indicates > > the redirection file closed)

[PATCH v7 5/7] fuzz: set bits in operand of write/out to zero

2021-01-10 Thread Qiuhao Li
Simplifying the crash cases by opportunistically setting bits in operands of out/write to zero may help to debug, since usually bit one means turn on or trigger a function while zero is the default turn-off setting. Tested Bug 1908062. Signed-off-by: Qiuhao Li Reviewed-by: Alexander Bulekov

[PATCH v7 1/7] fuzz: accelerate non-crash detection

2021-01-10 Thread Qiuhao Li
We spend much time waiting for the timeout program during the minimization process until it passes a time limit. This patch hacks the CLOSED (indicates the redirection file closed) notification in QTest's output if it doesn't crash. Test with quadrupled trace input at:

[PATCH v7 2/7] fuzz: double the IOs to remove for every loop

2021-01-10 Thread Qiuhao Li
Instead of removing IO instructions one by one, we can try deleting multiple instructions at once. According to the locality of reference, we double the number of instructions to remove for the next round and recover it to one once we fail. This patch is usually significant for large input. Test

[PATCH 13/23] paaudio: avoid to clip samples multiple times

2021-01-10 Thread Volker Rümelin
The pulseaudio backend currently converts, clips and copies audio playback samples in the mixing-engine sample buffer multiple times. In qpa_get_buffer_out() the function pa_stream_begin_write() returns a rather large buffer and this allows audio_pcm_hw_run_out() in audio/audio.c to copy all

[PATCH 22/23] dsoundaudio: enable f32 audio sample format

2021-01-10 Thread Volker Rümelin
Enable the f32 audio sample format for the DirectSound backend. Signed-off-by: Volker Rümelin --- audio/audio_win_int.c | 71 --- 1 file changed, 47 insertions(+), 24 deletions(-) diff --git a/audio/audio_win_int.c b/audio/audio_win_int.c index

[PATCH 16/23] paaudio: remove unneeded code

2021-01-10 Thread Volker Rümelin
Commit baea032ec7 "audio/paaudio: fix ignored buffer_length setting" added code to handle buffer_length defaults. This was unnecessary because the audio_buffer_* functions in audio/audio.c already handle this. Remove the unneeded code. Signed-off-by: Volker Rümelin --- audio/paaudio.c | 10

[PATCH 12/23] audio: remove remaining unused plive code

2021-01-10 Thread Volker Rümelin
Commit 73ad33ef7b "audio: remove plive" forgot to remove this code. Signed-off-by: Volker Rümelin --- audio/audio.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 22d769db0c..34c9cb9182 100644 --- a/audio/audio.c +++

[PATCH 21/23] dsoundaudio: rename dsound_open()

2021-01-10 Thread Volker Rümelin
Rename dsound_open() to dsound_set_cooperative_level(). The only task of that function is to set the cooperative level for DirectSound. Signed-off-by: Volker Rümelin --- audio/dsoundaudio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/audio/dsoundaudio.c

[PATCH 23/23] dsoundaudio: fix log message

2021-01-10 Thread Volker Rümelin
There is a mismatch between message and used argument. Change the argument from frequency to format. Signed-off-by: Volker Rümelin --- audio/audio_win_int.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/audio_win_int.c b/audio/audio_win_int.c index

[PATCH 15/23] paaudio: wait until the playback stream is ready

2021-01-10 Thread Volker Rümelin
Don't call pa_stream_writable_size() in qpa_get_buffer_out() before the playback stream is ready. This prevents a lot of the following pulseaudio error messages. pulseaudio: pa_stream_writable_size failed pulseaudio: Reason: Bad state To reproduce start qemu with -parallel none -device

[PATCH 17/23] paaudio: comment bugs in functions qpa_init_*

2021-01-10 Thread Volker Rümelin
The audio buffer size in audio/paaudio.c is typically larger than expected. Just comment the bugs in qpa_init_in() and qpa_init_out() for now. Fixing these bugs may break glitch free audio playback with fine tuned user audio settings. Signed-off-by: Volker Rümelin --- audio/paaudio.c | 8

[PATCH v4 0/6] hw/ssi: imx_spi: Fix various bugs in the imx_spi model

2021-01-10 Thread Bin Meng
From: Bin Meng This series fixes a bunch of bugs in current implementation of the imx spi controller, including the following issues: - chip select signal was not lower down when spi controller is disabled - remove imx_spi_update_irq() in imx_spi_reset() - transfer incorrect data when the burst

[PATCH v4 1/6] hw/ssi: imx_spi: Use a macro for number of chip selects supported

2021-01-10 Thread Bin Meng
From: Bin Meng Avoid using a magic number (4) everywhere for the number of chip selects supported. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé --- (no changes since v1) include/hw/ssi/imx_spi.h | 5 - hw/ssi/imx_spi.c | 4 ++-- 2

[PATCH 03/23] sdlaudio: add -audiodev sdl,out.buffer-count option

2021-01-10 Thread Volker Rümelin
Currently there is a crackling noise with SDL2 audio playback. Commit bcf19777df: "audio/sdlaudio: Allow audio playback with SDL2" already mentioned the crackling noise. Add an out.buffer-count option to give users a chance to select sane settings for glitch free audio playback. The idea was

Re: [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge

2021-01-10 Thread Philippe Mathieu-Daudé
+PCI experts On 1/10/21 1:43 AM, BALATON Zoltan wrote: > On Sun, 10 Jan 2021, Philippe Mathieu-Daudé wrote: >> Hi Zoltan, >> >> On 1/9/21 9:16 PM, BALATON Zoltan wrote: >>> Currently the ISA devices that are part of the VIA south bridge, >>> superio chip are wired up by board code. Move creation

[PATCH v7 4/7] fuzz: remove IO commands iteratively

2021-01-10 Thread Qiuhao Li
Now we use a one-time scan and remove strategy in the minimizer, which is not suitable for timing dependent instructions. For example, instruction A will indicate an address where the config chunk locates, and instruction B will make the configuration active. If we have the following instruction

[PATCH] util/oslib-win32: Fixes Use _aligned_malloc for qemu_try_memalign

2021-01-10 Thread Yonggang Luo
In commit dfbd0b873a85021c083d9b4b84630c3732645963, the use of _aligned_malloc are called with wrong parameter order, fixed it. Signed-off-by: Yonggang Luo --- util/oslib-win32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/oslib-win32.c b/util/oslib-win32.c index

[Bug 1777301] Re: Boot failed after installing Checkpoint Pointsec FDE

2021-01-10 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1777301 Title: Boot

[Bug 1777232] Re: NVME fails on big writes

2021-01-10 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1777232 Title: NVME fails

Re: [PATCH] hvf: guard xgetbv call.

2021-01-10 Thread Roman Bolshakov
On Sun, Jan 10, 2021 at 08:38:36AM -1000, Richard Henderson wrote: > On 1/10/21 8:34 AM, Richard Henderson wrote: > > On 1/9/21 3:46 PM, Roman Bolshakov wrote: > >> +static int xgetbv(uint32_t cpuid_ecx, uint32_t idx, uint64_t *xcr) > >> { > >> -uint32_t eax, edx; > >> +uint32_t xcrl,

Re: [PATCH v2] hvf: guard xgetbv call.

2021-01-10 Thread Roman Bolshakov
On Sun, Jan 10, 2021 at 01:08:54PM -0800, Hill Ma wrote: > This prevents illegal instruction on cpus do not support xgetbv. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1758819 > Signed-off-by: Hill Ma > --- > v2: xgetbv() modified based on feedback. > > target/i386/hvf/x86_cpuid.c | 28

[Bug 1910696] Re: Qemu fails to start with error " There is no option group 'spice'"

2021-01-10 Thread Edvinas Valatka
Additional information: This error occurs only if spice is compiled as module (`--enable-modules`) and spice parameters are supplied from file with `-readconfig /path/to/file` . If spice parameters are supplied from the command line (`-spice param1=a,param2=b`) , an error does not occur. Possible

[PATCH v16 01/20] multi-process: add the concept description to docs/devel/qemu-multiprocess

2021-01-10 Thread Jagannathan Raman
From: John G Johnson Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- docs/devel/index.rst | 1 + docs/devel/multi-process.rst | 966 +++ MAINTAINERS

  1   2   >